Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: support sniffing on multiple ports

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jul 24 10:49:23 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14915 )

Change subject: trx_toolkit/trx_sniff.py: support sniffing on multiple ports
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14915/2/src/target/trx_toolkit/trx_sniff.py 
File src/target/trx_toolkit/trx_sniff.py:

https://gerrit.osmocom.org/#/c/14915/2/src/target/trx_toolkit/trx_sniff.py@211 
PS2, Line 211: 		trx_group.add_argument("-p", "--base-port", "--base-ports",
> Are you sure it's correct keeping "--base-port" argument here?
Yep, it's kept for backwards compatibility. One can still specify only one base port.



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14915
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I76b818c673b98c427b5621ddb852f947c74557d6
Gerrit-Change-Number: 14915
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 24 Jul 2019 10:49:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190724/fdb3122a/attachment.html>


More information about the gerrit-log mailing list