Change in ...osmo-pcu[master]: ubsan: fiy shift

Hoernchen gerrit-no-reply at lists.osmocom.org
Tue Jul 23 15:17:33 UTC 2019


Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14906


Change subject: ubsan: fiy shift
......................................................................

ubsan: fiy shift

Ubsan complains about shifts into the sign bit due to automatic int
promotion, so cast explicitly.

Change-Id: I6387c7313832f6c7c920e1016b74562b66d6b68e
Related: OS#4029
---
M src/bts.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/06/14906/1

diff --git a/src/bts.cpp b/src/bts.cpp
index 395fc73..26dd401 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -551,7 +551,7 @@
 	}
 
 	/* get TLLI from downlink assignment */
-	tlli = ((*data++) & 0xf) << 28;
+	tlli = (uint32_t)((*data++) & 0xf) << 28;
 	tlli |= (*data++) << 20;
 	tlli |= (*data++) << 12;
 	tlli |= (*data++) << 4;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14906
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6387c7313832f6c7c920e1016b74562b66d6b68e
Gerrit-Change-Number: 14906
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190723/bed14e5b/attachment.html>


More information about the gerrit-log mailing list