Change in ...osmo-ttcn3-hacks[master]: msc: check IMEI: move reject LU into new function

osmith gerrit-no-reply at lists.osmocom.org
Tue Jul 23 13:09:49 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 )

Change subject: msc: check IMEI: move reject LU into new function
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/14901/1/msc/BSC_ConnectionHandler.ttcn 
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/#/c/14901/1/msc/BSC_ConnectionHandler.ttcn@645 
PS1, Line 645: f_reject_lu
> I would rather call it f_exp_lu_reject(), as we don't reject anything here, but expect this message  […]
Good idea! I went with f_expect_lu_reject for consistency with other functions in BSC_ConnectionHandler.ttcn.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifad259e21df035a89e97831a57c0675502308eb6
Gerrit-Change-Number: 14901
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Jul 2019 13:09:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190723/27672b40/attachment.html>


More information about the gerrit-log mailing list