Change in ...osmo-trx[master]: Transceiver: Clean up code passing parameters to threads

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 23 09:05:43 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14898 )

Change subject: Transceiver: Clean up code passing parameters to threads
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/14898/1/Transceiver52M/Transceiver.cpp 
File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/#/c/14898/1/Transceiver52M/Transceiver.cpp@241 
PS1, Line 241: malloc
> I am wondering, can we use static allocation here and simply pass a pointer to the stack? Or is ther […]
There'd be a race condition between threads, since this thread returns quickly.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14898
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I6e3898a8a66520cc5b2a7df9b9ae01b0b272387f
Gerrit-Change-Number: 14898
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Jul 2019 09:05:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190723/3d58a8f7/attachment.html>


More information about the gerrit-log mailing list