Change in ...osmocom-bb[master]: mobile: Fix encoding of cause in gsm480_tx_release_compl()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Jul 21 10:48:43 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14853 )

Change subject: mobile: Fix encoding of cause in gsm480_tx_release_compl()
......................................................................

mobile: Fix encoding of cause in gsm480_tx_release_compl()

Change-Id: Iba2ace7d82be5677d28b25f60ab0312fed76f5e5
Closes: CID#198577, CID#198576, CID#198575
---
M src/host/layer23/src/mobile/gsm480_ss.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/host/layer23/src/mobile/gsm480_ss.c b/src/host/layer23/src/mobile/gsm480_ss.c
index edc9c97..b114aa6 100644
--- a/src/host/layer23/src/mobile/gsm480_ss.c
+++ b/src/host/layer23/src/mobile/gsm480_ss.c
@@ -399,10 +399,10 @@
 
 	if (cause) {
 		uint8_t *tlv = msgb_put(msg, 4);
-		*tlv = GSM48_IE_CAUSE;
-		*tlv = 2;
-		*tlv = 0x80 | cause;
-		*tlv = 0x80 | GSM48_CAUSE_LOC_USER;
+		tlv[0] = GSM48_IE_CAUSE;
+		tlv[1] = 2;
+		tlv[2] = 0x80 | cause;
+		tlv[3] = 0x80 | GSM48_CAUSE_LOC_USER;
 	}
 	return gsm480_to_mm(msg, trans, GSM48_MMSS_DATA_REQ);
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14853
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iba2ace7d82be5677d28b25f60ab0312fed76f5e5
Gerrit-Change-Number: 14853
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190721/c610dce7/attachment.htm>


More information about the gerrit-log mailing list