Change in ...libosmocore[master]: osmo_get_rand_id(): Avoid dead code by proper #if/#else/#endif

laforge gerrit-no-reply at lists.osmocom.org
Sun Jul 21 10:30:23 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14875 )

Change subject: osmo_get_rand_id(): Avoid dead code by proper #if/#else/#endif
......................................................................

osmo_get_rand_id(): Avoid dead code by proper #if/#else/#endif

Change-Id: I34e465dead179487f7d4508e0e6ecf0e838c6eb7
Closes: CID#177910
---
M src/gsm/gsm_utils.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c
index f154c2b..365920f 100644
--- a/src/gsm/gsm_utils.c
+++ b/src/gsm/gsm_utils.c
@@ -466,8 +466,9 @@
 	if (rc < 0) {
 #if (USE_GNUTLS)
 		return gnutls_rnd(GNUTLS_RND_RANDOM, out, len);
-#endif
+#else
 		return -errno;
+#endif
 	}
 
 	/* getrandom() failed partially due to signal interruption:

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14875
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I34e465dead179487f7d4508e0e6ecf0e838c6eb7
Gerrit-Change-Number: 14875
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190721/4a60ce03/attachment.html>


More information about the gerrit-log mailing list