This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14851 ) Change subject: gsm322: Fix resource leak in gsm322_init() while reading BA ...................................................................... gsm322: Fix resource leak in gsm322_init() while reading BA Change-Id: Id42102ab8581e247f495fb7e05dc62a6743d28c5 Closes: CID#198546 --- M src/host/layer23/src/mobile/gsm322.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm322.c b/src/host/layer23/src/mobile/gsm322.c index cfd70d8..56dd236 100644 --- a/src/host/layer23/src/mobile/gsm322.c +++ b/src/host/layer23/src/mobile/gsm322.c @@ -5085,8 +5085,10 @@ } else while(!feof(fp)) { ba = talloc_zero(ms, struct gsm322_ba_list); - if (!ba) + if (!ba) { + fclose(fp); return -ENOMEM; + } rc = fread(buf, 4, 1, fp); if (!rc) { talloc_free(ba); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14851 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id42102ab8581e247f495fb7e05dc62a6743d28c5 Gerrit-Change-Number: 14851 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190721/10ea4fea/attachment.htm>