Change in ...osmocom-bb[master]: osmocon: Fix fd leak in error path of read_file()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Jul 21 10:29:34 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14850 )

Change subject: osmocon: Fix fd leak in error path of read_file()
......................................................................

osmocon: Fix fd leak in error path of read_file()

Change-Id: Iaae407658df184277f6e6e07d6a48d8b5c75587b
Closes: CID#198552
---
M src/host/osmocon/osmocon.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c
index 9090d27..9237214 100644
--- a/src/host/osmocon/osmocon.c
+++ b/src/host/osmocon/osmocon.c
@@ -290,6 +290,7 @@
 		if ((st.st_size > MAX_DNLOAD_SIZE) && (dnload.mode != MODE_ROMLOAD)) {
 			fprintf(stderr, "The maximum file size is 64kBytes (%u bytes)\n",
 				MAX_DNLOAD_SIZE);
+			close(fd);
 			return -EFBIG;
 		}
 	} else {

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14850
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Iaae407658df184277f6e6e07d6a48d8b5c75587b
Gerrit-Change-Number: 14850
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190721/183abe2c/attachment.htm>


More information about the gerrit-log mailing list