Change in ...osmo-bts[master]: l1sap: Don't discard fractional part of link_quality

laforge gerrit-no-reply at lists.osmocom.org
Sun Jul 21 10:06:33 UTC 2019


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14874


Change subject: l1sap: Don't discard fractional part of link_quality
......................................................................

l1sap: Don't discard fractional part of link_quality

When comparing the received link quality with the minimum threshold,
don't discard any fractional part by first converting to float and then
dividing by 10 (rather than the opposite order).

Change-Id: I1c365cf2b46fc8c5922e4e32fcc55d1f03b1e935
Closes: CID#171993
---
M src/common/l1sap.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/74/14874/1

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index b730b85..cd05955 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1218,7 +1218,7 @@
 	 * the content is not available due to decoding issues. Content not
 	 * available is expected as empty payload. We also check if quality is
 	 * good enough. */
-	if (msg->len && tch_ind->lqual_cb / 10 >= bts->min_qual_norm) {
+	if (msg->len && (float) tch_ind->lqual_cb / 10.0f >= bts->min_qual_norm) {
 		/* hand msg to RTP code for transmission */
 		if (lchan->abis_ip.rtp_socket)
 			osmo_rtp_send_frame_ext(lchan->abis_ip.rtp_socket,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14874
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1c365cf2b46fc8c5922e4e32fcc55d1f03b1e935
Gerrit-Change-Number: 14874
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190721/136721d0/attachment.html>


More information about the gerrit-log mailing list