Change in ...libosmocore[master]: gsm/gsm48_ie.c: fix deprecation warning: use gsm48_decode_bcd_number2()

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jul 21 09:47:30 UTC 2019


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14864


Change subject: gsm/gsm48_ie.c: fix deprecation warning: use gsm48_decode_bcd_number2()
......................................................................

gsm/gsm48_ie.c: fix deprecation warning: use gsm48_decode_bcd_number2()

Change-Id: I1b0eff1396776900c1286e41da3aee3ff78b326e
---
M src/gsm/gsm48_ie.c
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/64/14864/1

diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c
index 31028ba..5e67806 100644
--- a/src/gsm/gsm48_ie.c
+++ b/src/gsm/gsm48_ie.c
@@ -408,7 +408,9 @@
 	called->type = (lv[1] & 0x70) >> 4;
 
 	/* octet 4..N */
-	gsm48_decode_bcd_number(called->number, sizeof(called->number), lv, 1);
+	gsm48_decode_bcd_number2(called->number, sizeof(called->number),
+				 /* FIXME: emulate length of lv */
+				 lv, in_len + 1, 1);
 
 	return 0;
 }
@@ -463,7 +465,9 @@
 	}
 
 	/* octet 4..N */
-	gsm48_decode_bcd_number(callerid->number, sizeof(callerid->number), lv, i);
+	gsm48_decode_bcd_number2(callerid->number, sizeof(callerid->number),
+				 /* FIXME: emulate length of lv */
+				 lv, in_len + 1, i);
 
 	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14864
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1b0eff1396776900c1286e41da3aee3ff78b326e
Gerrit-Change-Number: 14864
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190721/9fdc5086/attachment.html>


More information about the gerrit-log mailing list