Change in ...libsmpp34[master]: bind_receiver_test: Fix "unused value" of writing addr_ton twice

laforge gerrit-no-reply at lists.osmocom.org
Sun Jul 21 09:33:53 UTC 2019


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libsmpp34/+/14862


Change subject: bind_receiver_test: Fix "unused value" of writing addr_ton twice
......................................................................

bind_receiver_test: Fix "unused value" of writing addr_ton twice

The constant 0x34 clearly hints that this should be written to
interface_version...

Closes: CID#135235
Change-Id: I89e16746da5c9f77b721294149a1bce5be5a1eae
---
M test_pdu/bind_receiver_test.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/62/14862/1

diff --git a/test_pdu/bind_receiver_test.c b/test_pdu/bind_receiver_test.c
index fa94c6f..67eab09 100644
--- a/test_pdu/bind_receiver_test.c
+++ b/test_pdu/bind_receiver_test.c
@@ -53,7 +53,7 @@
     snprintf((char*)b.system_id, sizeof(b.system_id), "%s", "system_id");
     snprintf((char*)b.password, sizeof(b.password), "%s", "pass");
     snprintf((char*)b.system_type, sizeof(b.system_type), "%s", "syste");
-    b.addr_ton    = 0x34;
+    b.interface_version = 0x34;
     b.addr_ton    = 2;
     b.addr_npi    = 1;
     snprintf((char*)b.address_range, sizeof(b.address_range), "%s", "address_range");

-- 
To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/14862
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libsmpp34
Gerrit-Branch: master
Gerrit-Change-Id: I89e16746da5c9f77b721294149a1bce5be5a1eae
Gerrit-Change-Number: 14862
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190721/eaf096bb/attachment.html>


More information about the gerrit-log mailing list