Change in ...osmo-remsim[master]: rspro_server.c: Fix memory leak in processing inbound RSPRO

laforge gerrit-no-reply at lists.osmocom.org
Sat Jul 20 10:20:41 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14827 )

Change subject: rspro_server.c: Fix memory leak in processing inbound RSPRO
......................................................................

rspro_server.c: Fix memory leak in processing inbound RSPRO

We need to unconditionally free the msgb that gets handed into
sock_read_cb() by the ipa server.

Closes: OS#4096
Change-Id: I12b4a22854eea79c9e9c3e565dd4803e4dc0ed5a
---
M src/server/rspro_server.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c
index 7cf98ad..c753f16 100644
--- a/src/server/rspro_server.c
+++ b/src/server/rspro_server.c
@@ -613,6 +613,7 @@
 	default:
 		goto invalid;
 	}
+	msgb_free(msg);
 	return rc;
 
 invalid:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14827
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I12b4a22854eea79c9e9c3e565dd4803e4dc0ed5a
Gerrit-Change-Number: 14827
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: roh <jsteiger at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190720/0130ea51/attachment.html>


More information about the gerrit-log mailing list