Change in ...openbsc[master]: manuals: Generate vty/counter documentation for osmo-bscnat

daniel gerrit-no-reply at lists.osmocom.org
Fri Jul 19 13:33:29 UTC 2019


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14530 )

Change subject: manuals: Generate vty/counter documentation for osmo-bscnat
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/#/c/14530/4/openbsc/doc/regen_doc.sh 
File openbsc/doc/regen_doc.sh:

https://gerrit.osmocom.org/#/c/14530/4/openbsc/doc/regen_doc.sh@19 
PS4, Line 19: OSMO_BSCNAT_BRANCH=$COMMIT ./regen_doc.sh osmo-nitb 4244 \
> osmo-nitb? that looks wrong!
That tells the script which docker container to use. the osmo-nitb one also has osmo-bsc_nat built, which is why the last argument overrides the default of the container.


https://gerrit.osmocom.org/#/c/14530/4/openbsc/doc/regen_doc.sh@22 
PS4, Line 22: osmo-bsc_nat
This starts osmo-bsc_nat instead of osmo-nitb



-- 
To view, visit https://gerrit.osmocom.org/c/openbsc/+/14530
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Change-Id: Ice7f15192a57e2c964d07d364732af888972ba0f
Gerrit-Change-Number: 14530
Gerrit-PatchSet: 4
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Jul 2019 13:33:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190719/e47397f2/attachment.html>


More information about the gerrit-log mailing list