Change in ...libosmocore[master]: tell ubsan to ignore SUN_LEN

pespin gerrit-no-reply at lists.osmocom.org
Fri Jul 19 12:35:26 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14682 )

Change subject: tell ubsan to ignore SUN_LEN
......................................................................


Patch Set 2: Code-Review+1

+1, but I still think information in this commit can be improved by adding:
* clang/ubsan version triggering the bug (because it's a compiler bug imho, C code in SUN_LEN is fine)
* Actual error line being printed.
* A comment in the added ifef __atribute__ line explaining it's there due to ubsan and SUN_LEN()


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14682
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5
Gerrit-Change-Number: 14682
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Jul 2019 12:35:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190719/c48db270/attachment.html>


More information about the gerrit-log mailing list