Change in ...libosmocore[master]: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support

pespin gerrit-no-reply at lists.osmocom.org
Fri Jul 19 10:21:59 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14360 )

Change subject: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support
......................................................................


Patch Set 5:

(7 comments)

Some stuff from cbsp.c and gsm48049.c looks duplicated, or at least they look quite similar.

https://gerrit.osmocom.org/#/c/14360/5/include/osmocom/gsm/cbsp.h 
File include/osmocom/gsm/cbsp.h:

https://gerrit.osmocom.org/#/c/14360/5/include/osmocom/gsm/cbsp.h@22 
PS5, Line 22: 	struct llist_head list;
Could add /* osmo_cbsp_cell_ent */


https://gerrit.osmocom.org/#/c/14360/5/include/osmocom/gsm/cbsp.h@45 
PS5, Line 45: 	struct llist_head list;
Could add /* osmo_cbsp_loading_ent */


https://gerrit.osmocom.org/#/c/14360/5/include/osmocom/gsm/protocol/gsm_48_049.h 
File include/osmocom/gsm/protocol/gsm_48_049.h:

https://gerrit.osmocom.org/#/c/14360/5/include/osmocom/gsm/protocol/gsm_48_049.h@16 
PS5, Line 16: #define CBSP_TCP_PORT 48049
Missing: /* 5.2 TCP/IP */


https://gerrit.osmocom.org/#/c/14360/5/include/osmocom/gsm/protocol/gsm_48_049.h@116 
PS5, Line 116: /* not explicitly specified, but every message starts with those mandatory eleemnts */
typo: eleemnts


https://gerrit.osmocom.org/#/c/14360/5/src/gsm/cbsp.c 
File src/gsm/cbsp.c:

https://gerrit.osmocom.org/#/c/14360/5/src/gsm/cbsp.c@39 
PS5, Line 39: 	return msgb_alloc_headroom_c(ctx, 65535, 16, name);
Wow, really, that long?


https://gerrit.osmocom.org/#/c/14360/5/src/gsm/cbsp.c@1303 
PS5, Line 1303: #ifdef HAVE_SYS_SOCKET_H
so if sys/socket.h is not available, then API osmo_cbsp_recv_buffered() is not present? sys/socket.h is only needed for recv(), isn't it?


https://gerrit.osmocom.org/#/c/14360/5/src/gsm/gsm48049.c 
File src/gsm/gsm48049.c:

https://gerrit.osmocom.org/#/c/14360/5/src/gsm/gsm48049.c@211 
PS5, Line 211: 
This looks wrong, code directly on the file, not inside any function?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14360
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935
Gerrit-Change-Number: 14360
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Jul 2019 10:21:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190719/0b96a4a4/attachment.html>


More information about the gerrit-log mailing list