Change in ...docker-playground[master]: debian-repo-install-test: add docker container

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 16 18:45:50 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14779 )

Change subject: debian-repo-install-test: add docker container
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14779/2/debian-repo-install-test/jenkins.sh 
File debian-repo-install-test/jenkins.sh:

https://gerrit.osmocom.org/#/c/14779/2/debian-repo-install-test/jenkins.sh@24 
PS2, Line 24: if ! docker exec "$BUILD_TAG" systemctl status; then
In order to avoid race conditions on busy/slow systems, it would make more sense to have a 10 time loop here with a sleep 1, and after 10 seconds then exit 1.



-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14779
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367
Gerrit-Change-Number: 14779
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Jul 2019 18:45:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190716/0fb55680/attachment.html>


More information about the gerrit-log mailing list