Change in ...osmo-pcu[master]: src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF

laforge gerrit-no-reply at lists.osmocom.org
Tue Jul 16 04:11:20 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14704 )

Change subject: src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF
......................................................................

src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF

The recent versions of OsmoBTS do provide the following measurements:

  - RSSI (Received Signal Strength Indication),
  - ToA (Timing of Arrival),
  - BER (Bit Error Rate),

as well as C/I (Carrier-to-Interference ratio) since [1] (OS#4006).

[1] https://gerrit.osmocom.org/r/Ia58043bd2381a4d34d604522e02899ae64ee0d26

Change-Id: I0fd6c35e8cf0b1314f4e3c336b233b5f7e42dfc6
Related: OS#1855
---
M src/pcu_l1_if.cpp
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 5cabe4f..bc712fd 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -289,14 +289,14 @@
 	switch (data_ind->sapi) {
 	case PCU_IF_SAPI_PDTCH:
 		meas.set_rssi(data_ind->rssi);
-#ifndef ENABLE_DIRECT_PHY
 		/* convert BER to % value */
 		meas.set_ber(data_ind->ber10k / 100);
 		meas.set_bto(data_ind->ta_offs_qbits);
 		meas.set_link_qual(data_ind->lqual_cb / 10);
+
 		LOGP(DL1IF, LOGL_DEBUG, "Data indication with raw measurements received: BER10k = %d, BTO = %d, Q = %d\n",
 		     data_ind->ber10k, data_ind->ta_offs_qbits, data_ind->lqual_cb);
-#endif
+
 		rc = pcu_rx_data_ind_pdtch(data_ind->trx_nr, data_ind->ts_nr,
 			data_ind->data, data_ind->len, data_ind->fn,
 			&meas);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14704
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I0fd6c35e8cf0b1314f4e3c336b233b5f7e42dfc6
Gerrit-Change-Number: 14704
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190716/b521ae73/attachment.html>


More information about the gerrit-log mailing list