Change in ...osmo-bts[master]: RSL: Fix fixed MS power control in RSL CHAN ACTIV

laforge gerrit-no-reply at lists.osmocom.org
Tue Jul 16 04:05:54 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14489 )

Change subject: RSL: Fix fixed MS power control in RSL CHAN ACTIV
......................................................................

RSL: Fix fixed MS power control in RSL CHAN ACTIV

Dynamic MS power control should only be active if a power parameters IE
was supplied.

Change-Id: I0bbe171a287b10d71fc853cd721f66e4c84db8c5
---
M src/common/rsl.c
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/rsl.c b/src/common/rsl.c
index 7630a8c..0a613bb 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -1116,6 +1116,14 @@
 
 	/* 9.3.32 BS Power Parameters */
 	/* 9.3.31 MS Power Parameters */
+	if (TLVP_PRESENT(&tp, RSL_IE_MS_POWER_PARAM))
+		lchan->ms_power_ctrl.fixed = 0;
+	else {
+		/* Spec explicitly states BTS should only perform
+		* autonomous MS power control loop in BTS if 'MS Power
+		* Parameters' IE is present! */
+		lchan->ms_power_ctrl.fixed = 1;
+	}
 	/* 9.3.16 Physical Context */
 
 	/* 9.3.29 SACCH Information */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14489
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0bbe171a287b10d71fc853cd721f66e4c84db8c5
Gerrit-Change-Number: 14489
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190716/aad03b3e/attachment.html>


More information about the gerrit-log mailing list