Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jul 14 04:20:14 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 )

Change subject: Clarify and refactor link quality (C/I) handling
......................................................................


Patch Set 4:

> using uint16_t gives a range of 0..655.35 dB, which is certainly sufficient ;)
> So both from a resolution and from a range point of view, uint16_t is fine.
> What I'm a bit more worried is whether there could be negative values?

I am actually changing to signed (int16_t) which gives us a range of -3276.8 .. 3276.7 dB,
or -32768 .. 32767 cB. This is still more than enough. Moreover, on all interfaces such as
PCUIF or L1SAP, we need a value in centiBels stored in int16_t. So I think it should be ok.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01
Gerrit-Change-Number: 14686
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Sun, 14 Jul 2019 04:20:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190714/876868b8/attachment.html>


More information about the gerrit-log mailing list