Change in ...osmo-ttcn3-hacks[master]: rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_...

laforge gerrit-no-reply at lists.osmocom.org
Sun Jul 14 00:10:04 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14710 )

Change subject: rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_ho_cmd
......................................................................

rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_ho_cmd

Change-Id: If84a1d4535ee12e33a50588e178bf1ebb6fb2cd5
---
M bsc/BSC_Tests.ttcn
M bsc/expected-results.xml
2 files changed, 6 insertions(+), 9 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 854dbbc..44a9172 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -3121,11 +3121,8 @@
 
 /* BSC asks for inter-BSC-out HO, receives BSSMAP Handover Command, but then no reply is received about HO outcome
  * (neither BSSMAP Clear Command for success nor RR Handover Failure). 48.008 3.1.5.3.3 "Abnormal Conditions" applies
- * and the lchan is released.
- * Note: this test is a misnomer. On missing HO Detect, normally the old BSS receives an RR Handover Failure from the
- * MS. Instead, this test is about the scenario in "Abnormal Conditions" as explained above. Leaving the test's name
- * unchanged to not confuse jenkins result reports. */
-private function f_tc_ho_out_fail_no_ho_detect(charstring id) runs on MSC_ConnHdlr {
+ * and the lchan is released. */
+private function f_tc_ho_out_fail_no_result_after_ho_cmd(charstring id) runs on MSC_ConnHdlr {
 	g_pars := f_gen_test_hdlr_pars();
 
 	var PDU_BSSAP ass_req := f_gen_ass_req();
@@ -3198,13 +3195,13 @@
 	setverdict(pass);
 	f_sleep(1.0);
 }
-testcase TC_ho_out_fail_no_ho_detect() runs on test_CT {
+testcase TC_ho_out_fail_no_result_after_ho_cmd() runs on test_CT {
 	var MSC_ConnHdlr vc_conn;
 
 	f_init(1, true);
 	f_sleep(1.0);
 
-	vc_conn := f_start_handler(refers(f_tc_ho_out_fail_no_ho_detect));
+	vc_conn := f_start_handler(refers(f_tc_ho_out_fail_no_result_after_ho_cmd));
 	vc_conn.done;
 }
 
@@ -4135,7 +4132,7 @@
 	execute( TC_ho_out_of_this_bsc() );
 	execute( TC_ho_out_fail_no_msc_response() );
 	execute( TC_ho_out_fail_rr_ho_failure() );
-	execute( TC_ho_out_fail_no_ho_detect() );
+	execute( TC_ho_out_fail_no_result_after_ho_cmd() );
 
 	execute( TC_ho_into_this_bsc() );
 	execute( TC_ho_in_fail_msc_clears() );
diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml
index d2c474c..3ea202c 100644
--- a/bsc/expected-results.xml
+++ b/bsc/expected-results.xml
@@ -87,7 +87,7 @@
   <testcase classname='BSC_Tests' name='TC_ho_out_of_this_bsc' time='MASKED'/>
   <testcase classname='BSC_Tests' name='TC_ho_out_fail_no_msc_response' time='MASKED'/>
   <testcase classname='BSC_Tests' name='TC_ho_out_fail_rr_ho_failure' time='MASKED'/>
-  <testcase classname='BSC_Tests' name='TC_ho_out_fail_no_ho_detect' time='MASKED'/>
+  <testcase classname='BSC_Tests' name='TC_ho_out_fail_no_result_after_ho_cmd' time='MASKED'/>
   <testcase classname='BSC_Tests' name='TC_ho_into_this_bsc' time='MASKED'/>
   <testcase classname='BSC_Tests' name='TC_ho_in_fail_msc_clears' time='MASKED'/>
   <testcase classname='BSC_Tests' name='TC_ho_in_fail_msc_clears_after_ho_detect' time='MASKED'/>

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14710
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If84a1d4535ee12e33a50588e178bf1ebb6fb2cd5
Gerrit-Change-Number: 14710
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190714/6313e421/attachment.html>


More information about the gerrit-log mailing list