Change in ...osmo-msc[master]: replace osmo_counter with stat_items

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Jul 12 06:29:06 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13802 )

Change subject: replace osmo_counter with stat_items
......................................................................


Patch Set 10: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/13802/10/include/osmocom/msc/gsm_data.h 
File include/osmocom/msc/gsm_data.h:

https://gerrit.osmocom.org/#/c/13802/10/include/osmocom/msc/gsm_data.h@102 
PS10, Line 102: MSC_STAT_NC_SS
MSC_STAT_ACTIVE_NC_SS then? ;)
IMHO this way it would be cleaner.


https://gerrit.osmocom.org/#/c/13802/10/src/libmsc/msc_net_init.c 
File src/libmsc/msc_net_init.c:

https://gerrit.osmocom.org/#/c/13802/10/src/libmsc/msc_net_init.c@71 
PS10, Line 71: net->statg
I would call OSMO_ASSERT() here, to be sure.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/13802
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I6a20123b263f4f808153794ee8a735092deb399e
Gerrit-Change-Number: 13802
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 12 Jul 2019 06:29:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190712/01acc5b2/attachment.html>


More information about the gerrit-log mailing list