Change in ...osmo-ttcn3-hacks[master]: msc: fix TC_lu_by_imei

osmith gerrit-no-reply at lists.osmocom.org
Thu Jul 11 14:05:29 UTC 2019


osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755


Change subject: msc: fix TC_lu_by_imei
......................................................................

msc: fix TC_lu_by_imei

Explicitly state the kind of ID request we want to ignore in the
TC_lu_by_imei test. This prevents the following dynamic test case error:

Performing a valueof or send operation on a non-specific template of enumerated type @L3_Templates.CmIdentityType.

This is fine for the test case in question. However I am not sure how
it would be possible to check for tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req(?)
with the CmIdentityType enum that we have now. If this becomes a problem
in the future, we might need to revert that commit and simply not use an
enum for the Identity Type.

Fixes: 328984591372ad5abf51655a51d45d880bfed182 ("L3_Templates: add enum CmIdentityType")
Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b
---
M msc/MSC_Tests.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/14755/1

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn
index 6f9eecd..f21002d 100644
--- a/msc/MSC_Tests.ttcn
+++ b/msc/MSC_Tests.ttcn
@@ -781,10 +781,10 @@
 	if (pars.ran_is_geran) {
 		BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3));
 	}
-	/* wait for LU reject, ignore any ID REQ */
+	/* wait for LU reject, ignore IMSI ID REQ */
 	alt {
 	[] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { }
-	[] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req)) { repeat; }
+	[] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req(CM_ID_TYPE_IMSI))) { repeat; }
 	}
 	/* wait for normal teardown */
 	f_expect_clear();

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b
Gerrit-Change-Number: 14755
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190711/b695abfd/attachment.html>


More information about the gerrit-log mailing list