Change in ...osmo-pcu[master]: Encoding: ACK/NACK: always encode with length field present
gerrit-no-reply at lists.osmocom.org
Thu Jul 11 03:36:26 UTC 2019
Hello laforge, Jenkins Builder,
I'd like you to reexamine a change. Please visit
to look at the new patch set (#3).
Change subject: Encoding: ACK/NACK: always encode with length field present
Encoding: ACK/NACK: always encode with length field present
In most cases the length field was present and this field takes 7
bits of the maximum available 110 rest bits.
The length field was only removed when encoding huge bitmaps usually
only happen on lossy connections with packet lost.
However the cases without length field were encoded incorrect,
because all remaining bits must be used by the uncompressed bitmaps,
but the PCU violates this by encoding always the "release 5" bit.
Rather than fixing the encoding without length field, simply remove it
and always encode with length field. This also reduces the code
1 file changed, 39 insertions(+), 43 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/97/14697/3
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14697
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log