Change in ...osmo-pcu[master]: Encoding: ACK/NACK: always encode with length field present

lynxis lazus gerrit-no-reply at lists.osmocom.org
Thu Jul 11 03:36:26 UTC 2019


Hello laforge, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-pcu/+/14697

to look at the new patch set (#3).

Change subject: Encoding: ACK/NACK: always encode with length field present
......................................................................

Encoding: ACK/NACK: always encode with length field present

In most cases the length field was present and this field takes 7
bits of the maximum available 110 rest bits.
The length field was only removed when encoding huge bitmaps usually
only happen on lossy connections with packet lost.
However the cases without length field were encoded incorrect,
because all remaining bits must be used by the uncompressed bitmaps,
but the PCU violates this by encoding always the "release 5" bit.
Rather than fixing the encoding without length field, simply remove it
and always encode with length field. This also reduces the code
complexity.

Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb
---
M src/encoding.cpp
1 file changed, 39 insertions(+), 43 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/97/14697/3
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14697
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb
Gerrit-Change-Number: 14697
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190711/af0ae6a9/attachment.html>


More information about the gerrit-log mailing list