Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Wed Jul 10 18:07:24 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14685 )

Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c 
File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c@800 
PS1, Line 800: 			synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, NULL);
> Why are you not printing it anymore? I thought you're enriching messages, not vice versa ;) Just pri […]
Printing either C/I or the match rate conditionally would complicate the LOGL1S(...) statement below, or at least make the code harder to read. I think I could use LOGPC() to solve the problem, but do we really need to care about the matching rate that much? If you insist, I will update the change.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14685
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0
Gerrit-Change-Number: 14685
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Comment-Date: Wed, 10 Jul 2019 18:07:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vadim Yanitskiy <axilirator at gmail.com>
Comment-In-Reply-To: ipse <Alexander.Chemeris at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190710/15f93cfb/attachment.html>


More information about the gerrit-log mailing list