Change in ...osmo-bts[master]: Move Access Burst link quality handling to L1SAP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 10 02:10:02 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14687 )

Change subject: Move Access Burst link quality handling to L1SAP
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/14687/2/src/osmo-bts-trx/scheduler_trx.c 
File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/#/c/14687/2/src/osmo-bts-trx/scheduler_trx.c@820 
PS2, Line 820: l1sap.u.rach_ind.lqual_cb = l1t->trx->bts->min_qual_rach
why are we setting lqual_cb to a static value here?  To report some reasonable default in the TRXDv0 case? Might make sense to explain this explicitly?  Or is that what the cryptic comment above means (I wouldn't understand it)?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14687
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78
Gerrit-Change-Number: 14687
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 10 Jul 2019 02:10:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190710/5668eaf3/attachment.htm>


More information about the gerrit-log mailing list