Change in ...osmo-ttcn3-hacks[master]: f_tc_ho_out_fail_no_ho_detect: stricter ordering

laforge gerrit-no-reply at lists.osmocom.org
Wed Jul 10 01:59:45 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14709 )

Change subject: f_tc_ho_out_fail_no_ho_detect: stricter ordering
......................................................................

f_tc_ho_out_fail_no_ho_detect: stricter ordering

Make sure that the RR is released only after the MSC has sent the Clear Command:
- first expect a Clear Request from osmo-bsc and return a Clear Command,
- only then accept RR release messages.

See 3GPP TS 48.008 3.1.5.3.3 "Abnormal Conditions": "The terrestrial resource
in the old BSS shall remain assigned until a CLEAR COMMAND message is received
from the MSC"

osmo-bsc already complies, the test should continue to pass.

Change-Id: Iba05336d3c4af8a1c57cdc828dae464eae3510b9
---
M bsc/BSC_Tests.ttcn
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 454ded7..854dbbc 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -3172,8 +3172,14 @@
 	 * TS 48.008 3.1.5.3.3 "Abnormal Conditions": Clear Request should go to the MSC, and RR should be released
 	 * after Clear Command */
 
-	var MgcpCommand mgcp;
 	var PDU_BSSAP rx_clear_request;
+	BSSAP.receive(tr_BSSMAP_ClearRequest) -> value rx_clear_request;
+	log("Got BSSMAP Clear Request");
+	/* Instruct BSC to clear channel */
+	var BssmapCause cause := bit2int(rx_clear_request.pdu.bssmap.clearRequest.cause.causeValue);
+	BSSAP.send(ts_BSSMAP_ClearCommand(cause));
+
+	var MgcpCommand mgcp;
 	interleave {
 	[] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {
 			log("Got Deact SACCH");
@@ -3185,12 +3191,6 @@
 			log("Got RF Chan Rel");
 			RSL.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));
 		}
-	[] BSSAP.receive(tr_BSSMAP_ClearRequest) -> value rx_clear_request {
-			log("Got BSSMAP Clear Request");
-			/* Instruct BSC to clear channel */
-			var BssmapCause cause := bit2int(rx_clear_request.pdu.bssmap.clearRequest.cause.causeValue);
-			BSSAP.send(ts_BSSMAP_ClearCommand(cause));
-		}
 	}
 
 	f_expect_dlcx_conns();

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14709
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iba05336d3c4af8a1c57cdc828dae464eae3510b9
Gerrit-Change-Number: 14709
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190710/36ed4796/attachment.html>


More information about the gerrit-log mailing list