Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jul 9 12:44:36 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14585 )

Change subject: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/14585/2/src/target/trx_toolkit/data_if.py 
File src/target/trx_toolkit/data_if.py:

https://gerrit.osmocom.org/#/c/14585/2/src/target/trx_toolkit/data_if.py@53 
PS2, Line 53: 		return None
> I agree, "return False" makes more sense here.
I forgot to fix this, thanks!



-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14585
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I164f5ae4ce7694d6e324aab927a04e96d489ebd8
Gerrit-Change-Number: 14585
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Jul 2019 12:44:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190709/e3747f99/attachment.html>


More information about the gerrit-log mailing list