Change in ...osmo-pcu[master]: Encoding: use uint16_t when interacting with the window object

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jul 8 16:41:14 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14571 )

Change subject: Encoding: use uint16_t when interacting with the window object
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/14571/2/src/encoding.cpp 
File src/encoding.cpp:

https://gerrit.osmocom.org/#/c/14571/2/src/encoding.cpp@975 
PS2, Line 975: ESN_CRBB = %d
... and here too.


https://gerrit.osmocom.org/#/c/14571/2/src/encoding.cpp@975 
PS2, Line 975: SSN = %d
You need %u here now.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14571
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: If62fa09d7bfa8e91ce707824f7019edb1b83da9e
Gerrit-Change-Number: 14571
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Mon, 08 Jul 2019 16:41:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190708/aaf9f544/attachment.html>


More information about the gerrit-log mailing list