Change in ...osmo-pcu[master]: Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for...

lynxis lazus gerrit-no-reply at lists.osmocom.org
Mon Jul 8 13:19:55 UTC 2019


lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14696


Change subject: Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for rest_bits
......................................................................

Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for rest_bits

The rest_bits are never read after calling this function nor are rest_bits
updated properly.

Change-Id: Ic350b0365b125638a6c752f692bef981ad6b9d89
---
M src/encoding.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/96/14696/1

diff --git a/src/encoding.cpp b/src/encoding.cpp
index e868379..99c1018 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -830,7 +830,7 @@
 
 static void write_packet_ack_nack_desc_egprs(
 	bitvec * dest, unsigned& wp,
-	gprs_rlc_ul_window *window, bool is_final, unsigned& rest_bits)
+	gprs_rlc_ul_window *window, bool is_final, unsigned rest_bits)
 {
 	unsigned int urbb_len = 0;
 	uint8_t crbb_len = 0;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14696
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic350b0365b125638a6c752f692bef981ad6b9d89
Gerrit-Change-Number: 14696
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190708/fbebb5a5/attachment.html>


More information about the gerrit-log mailing list