Change in ...osmo-ttcn3-hacks[master]: msc: add check IMEI tests

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jul 8 13:01:40 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 )

Change subject: msc: add check IMEI tests
......................................................................


Patch Set 2: Code-Review+1

(6 comments)

https://gerrit.osmocom.org/#/c/14694/2/library/GSUP_Types.ttcn 
File library/GSUP_Types.ttcn:

https://gerrit.osmocom.org/#/c/14694/2/library/GSUP_Types.ttcn@544 
PS2, Line 544: ) := tr_GSUP(
Git friendly style itself deserves CR+1 ;)


https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn 
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn@440 
PS2, Line 440: function
Is this function going to be called from other modules? If no, make it private.


https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn@446 
PS2, Line 446: if (not g_pars.net.expect_imei)
I would rather leave it up to the caller.


https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn@452 
PS2, Line 452: '010'B /* IMEI */
Would be great to have an enumerated type for that later on.


https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn@478 
PS2, Line 478: function
Same here.


https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn@484 
PS2, Line 484: if (not g_pars.net.expect_imei_early)
Same here.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d
Gerrit-Change-Number: 14694
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Jul 2019 13:01:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190708/72a83eca/attachment.html>


More information about the gerrit-log mailing list