Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX

ipse gerrit-no-reply at lists.osmocom.org
Sun Jul 7 18:41:10 UTC 2019


ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14684 )

Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/14684/1/src/osmo-bts-trx/scheduler_trx.c 
File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/#/c/14684/1/src/osmo-bts-trx/scheduler_trx.c@796 
PS1, Line 796: 	/* Handover RACH cannot be extended (11-bit) */
It's not clear how does this comment relates to the "if()" below. Could you reword it to make the relation obvious?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14684
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1e654a2e49cb83c5f1e6249c0de688f99bc466b0
Gerrit-Change-Number: 14684
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 07 Jul 2019 18:41:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190707/4a4acd3e/attachment.html>


More information about the gerrit-log mailing list