Change in ...osmo-trx[master]: Transceiver: Support SETFORMAT command

pespin gerrit-no-reply at lists.osmocom.org
Sun Jul 7 14:40:44 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14665 )

Change subject: Transceiver: Support SETFORMAT command
......................................................................


Patch Set 7:

> Patch Set 7:
> 
> I believe I raised this before in some other place: Why are we faling back to a lower version rather than simply failing SETFORMAT for any unknown version?  I think it's somewhat odd and dangerous if we have "SETFORMAT 3" and then the TRX returns "OK, I set 2".

Hi, please review the code again, the logic has changed since last time you commented on it. Right now the version is only applied if it supported by TRXD. If return code is different than the version requested, it's simply an indication towards BTSTRX about the nearest lower version supported by TRX, but in that case, the indicated version is NOT applied.

Discussion regarding this topic is on-going in https://osmocom.org/issues/4006#note-25.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14665
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: If9fc22f9987238a5ff870df7718de4efc9e04289
Gerrit-Change-Number: 14665
Gerrit-PatchSet: 7
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Sun, 07 Jul 2019 14:40:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190707/6471d32b/attachment.html>


More information about the gerrit-log mailing list