Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jul 7 13:22:03 UTC 2019


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14685


Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message
......................................................................

osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message

Instead of printing the match score of detected training sequence,
which is being calculated by rach_get_synch_seq() when TSC info is
absent, it makes more sense to print both RSSI and optional C/I
(Carrier-to-Interference ratio).

Also, let's explicitly log handover Access Bursts.

Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 5 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/85/14685/1

diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index 00d7bbb..b10ca26 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -791,21 +791,21 @@
 	 * known ones (3GPP TS 05.02, section 5.2.7), and fall-back to the default
 	 * TS0 if it fails. */
 	enum rach_synch_seq_t synch_seq = RACH_SYNCH_SEQ_TS0;
-	int best_score = 127 * RACH_SYNCH_SEQ_LEN;
 
 	/* Handover RACH cannot be extended (11-bit) */
 	if (chan == TRXC_RACH) {
 		if (bi->flags & TRX_BI_F_TS_INFO)
 			synch_seq = (enum rach_synch_seq_t) bi->tsc;
 		else
-			synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, &best_score);
+			synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, NULL);
 	}
 
 	LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn,
-	       "Received RACH (%s; match=%.1f%%) toa=%d\n",
+	       "Received%s RACH (%s): rssi=%d toa256=%d C/I=%d cB\n",
+	       (chan != TRXC_RACH) ? " handover" : "",
 	       get_value_string(rach_synch_seq_names, synch_seq),
-	       best_score * 100.0 / (127 * RACH_SYNCH_SEQ_LEN),
-	       bi->toa256);
+	       bi->rssi, bi->toa256,
+	       (bi->flags & TRX_BI_F_CI_CB) ? bi->ci_cb : 0);
 
 	/* Compose a new L1SAP primitive */
 	memset(&l1sap, 0x00, sizeof(l1sap));

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14685
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0
Gerrit-Change-Number: 14685
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190707/06e58555/attachment.html>


More information about the gerrit-log mailing list