This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14670 ) Change subject: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs ...................................................................... Patch Set 1: Code-Review+2 (1 comment) In any case, we can change this later on. https://gerrit.osmocom.org/#/c/14670/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/14670/1/src/osmo-bts-trx/trx_if.c@744 PS1, Line 744: static char buf[256]; > Since we only use it in one place, makes more sense to pass a stack buffer instead of allocating a s […] I was thinking about potential performance impact. Since we receive Uplink bursts quite often, and furthermore we are about to implement NOPE / IDLE indications, static buffer has an important advantage: there are less stack allocations. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I68729dc98a1840d2aa9e091153d176a103d5a228 Gerrit-Change-Number: 14670 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sun, 07 Jul 2019 10:19:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190707/16c9bc7c/attachment.htm>