Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jul 7 10:19:32 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14670 )

Change subject: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

In any case, we can change this later on.

https://gerrit.osmocom.org/#/c/14670/1/src/osmo-bts-trx/trx_if.c 
File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/#/c/14670/1/src/osmo-bts-trx/trx_if.c@744 
PS1, Line 744: 	static char buf[256];
> Since we only use it in one place, makes more sense to pass a stack buffer instead of allocating a s […]
I was thinking about potential performance impact. Since we receive Uplink bursts quite often, and furthermore we are about to implement NOPE / IDLE indications, static buffer has an important advantage: there are less stack allocations.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14670
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I68729dc98a1840d2aa9e091153d176a103d5a228
Gerrit-Change-Number: 14670
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 07 Jul 2019 10:19:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190707/b438b4d8/attachment.html>


More information about the gerrit-log mailing list