Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector()

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 4 22:09:40 UTC 2019


pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14641 )

Change subject: Transceiver: Move soft bits normalization to pullRadioVector()
......................................................................

Transceiver: Move soft bits normalization to pullRadioVector()

That's where all the filling logic happens, while in driveReceiveFIFO we
mostly want to take the burst, generate a message and sent it over the
socket.

Related: OS#4006
Change-Id: Ibfb48877af4ff5ef0f56390901669c8353beaf48
---
M Transceiver52M/Transceiver.cpp
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index 5a6b652..a6a32f0 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -649,6 +649,9 @@
   else /* size() here is actually gSlotLen + 8, due to guard periods */
     bi->nbits = gSlotLen;
 
+  // Convert -1..+1 soft bits to 0..1 soft bits
+  vectorSlicer(bi->rxBurst);
+
   delete radio_burst;
   return true;
 }
@@ -928,9 +931,6 @@
   if (!pullRadioVector(chan, &bi))
         return;
 
-  // Convert -1..+1 soft bits to 0..1 soft bits
-  vectorSlicer(bi.rxBurst);
-
   logRxBurst(chan, &bi);
 
   TOAint = (int) (bi.toa * 256.0 + 0.5); // round to closest integer

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14641
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ibfb48877af4ff5ef0f56390901669c8353beaf48
Gerrit-Change-Number: 14641
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190704/2e2b491f/attachment.html>


More information about the gerrit-log mailing list