Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 4 16:34:49 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 )

Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/trx_if.c 
File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/trx_if.c@446 
PS5, Line 446: 
> Huh, I thought we're doing this already for all commands. […]
You either do blacklist or whitelist. So far it's done this way because when I was fixing protocol issues this specific command was giving issues (SETSLOT), where RESP to retransmissions for one slot were being read if there were for the next one.
Other commands probably need to be added, but I guess in the end the only problematic ones are commands which are usually sent with different parameters one after the other (queued in the command list), like:
SETSLOT 1 2
RESP SETSLOT 0 1 2
SETSLOT 2 2
RESP SETSLOT 0 2 2

In this case, for SETFORMAT, we have a similar issue, so we want to add it here for sure, since it should usually happen:
SETFORMAT X
RESP SETFORMAT Y X
SET FORMAT Y
RESP SETFORMAT Y Y



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14611
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8afe950bd1ec2afaf3347ff848ee46e69c4f5011
Gerrit-Change-Number: 14611
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Comment-Date: Thu, 04 Jul 2019 16:34:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190704/b32b6cce/attachment.html>


More information about the gerrit-log mailing list