Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: introduce TRXD header version handling

fixeria gerrit-no-reply at lists.osmocom.org
Thu Jul 4 15:45:11 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14592 )

Change subject: osmo-bts-trx/trx_if.c: introduce TRXD header version handling
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/14592/3/src/common/scheduler.c 
File src/common/scheduler.c:

https://gerrit.osmocom.org/#/c/14592/3/src/common/scheduler.c@1317 
PS3, Line 1317: int trx_sched_ul_burst(struct l1sched_trx *l1t, struct trx_ul_burst_ind *bi)
> why did you drop the const in bi here?
Because we may need to decipher bi->burst below, so const is not applicable anymore.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14592
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I171c18229ca3e5cab70de0064a31e47c78602c0c
Gerrit-Change-Number: 14592
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Jul 2019 15:45:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190704/630f7687/attachment.html>


More information about the gerrit-log mailing list