Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 4 14:10:57 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14612 )

Change subject: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/#/c/14612/4/src/osmo-bts-trx/scheduler_trx.c 
File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/#/c/14612/4/src/osmo-bts-trx/scheduler_trx.c@1266 
PS4, Line 1266: 		/* FIXME: this calculation is wrong */
some description on WHY would be welcome.


https://gerrit.osmocom.org/#/c/14612/4/src/osmo-bts-trx/scheduler_trx.c@1411 
PS4, Line 1411: 			/* FIXME: what the hell is this?!? */
Not sure if all those comments belong to this patch. Since there are quite a lot of them and in here it's basically replacing fields with the pointer to struct, better push all those comments in a separate patch so we discuss them there.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14612
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iae6b78bafa4b86d0c681684de47320d641d3f7c0
Gerrit-Change-Number: 14612
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Jul 2019 14:10:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190704/a0e3d25c/attachment.html>


More information about the gerrit-log mailing list