Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version

pespin gerrit-no-reply at
Thu Jul 4 14:04:25 UTC 2019

pespin has posted comments on this change. ( )

Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version

Patch Set 5: Code-Review-1

Commit Message: 
PS5, Line 17: version, which can be either equal or lover than VER_REQ. In
love is in the air! or maybe lower. 
File src/osmo-bts-trx/l1_if.h: 
PS5, Line 11: 	int			setformat_sent;
File src/osmo-bts-trx/l1_if.c: 
PS5, Line 214: 			l1h->config.setformat_sent = 1;
= true. Also, you set trxd_hdr_ver_req inside trx_if_cmd_setformat(), but this one here. Please move them to be in the same place. 
File src/osmo-bts-trx/trx_if.c: 
PS5, Line 446: 
Seems we want to add code here to match the version parameter in SETFORMAT. 
PS5, Line 486: 	if (rsp->status < 0 || rsp->status > TRX_DATA_FORMAT_VER) {
You should check here if rsp->status > l1h->config.trxd_hdr_ver_req, since it should be equal or lower than the one you sent, not the one you support (which is unknown to trx). 
PS5, Line 529: 	} else if (strcmp(tcm->cmd, "SETFORMAT") == 0) {
Add a comment here on why tcm->cmd is used instead of rsp->cmd (due to RSP ERR 1 being answered).

To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8afe950bd1ec2afaf3347ff848ee46e69c4f5011
Gerrit-Change-Number: 14611
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <axilirator at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at>
Gerrit-Reviewer: pespin <pespin at>
Gerrit-CC: ipse <Alexander.Chemeris at>
Gerrit-Comment-Date: Thu, 04 Jul 2019 14:04:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list