Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: legacy flag is only for version 0x00

fixeria gerrit-no-reply at lists.osmocom.org
Wed Jul 3 14:11:48 UTC 2019


fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14584 )

Change subject: trx_toolkit/data_msg.py: legacy flag is only for version 0x00
......................................................................

trx_toolkit/data_msg.py: legacy flag is only for version 0x00

Since version 0x01, the burst bits are encoded as L16V,
so appending two dummy octets doesn't make sense.

Change-Id: I4d6c0bf54649d636ea6cb3fa2f37486b6619d5b3
---
M src/target/trx_toolkit/data_msg.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Hoernchen: Looks good to me, but someone else must approve
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved



diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py
index a2996ab..e946229 100644
--- a/src/target/trx_toolkit/data_msg.py
+++ b/src/target/trx_toolkit/data_msg.py
@@ -271,7 +271,7 @@
 
 		# This is a rudiment from (legacy) OpenBTS transceiver,
 		# some L1 implementations still expect two dummy bytes.
-		if legacy:
+		if legacy and self.ver == 0x00:
 			buf += bytearray(2)
 
 		return buf

-- 
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14584
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I4d6c0bf54649d636ea6cb3fa2f37486b6619d5b3
Gerrit-Change-Number: 14584
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190703/cc4307e6/attachment.html>


More information about the gerrit-log mailing list