Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field

pespin gerrit-no-reply at lists.osmocom.org
Tue Jul 2 13:10:25 UTC 2019


Hello fixeria, laforge, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-trx/+/14639

to look at the new patch set (#3).

Change subject: Transceiver: Drop unused rssi_valid struct field
......................................................................

Transceiver: Drop unused rssi_valid struct field

That field is actually never used. Furthermore, if pullRadioVector()
returns false, then the caller should consider the 'trx_ul_burst_ind'
structure as uninitialized. Moreover, RSSI is mandatory - we cannot send
burst indications without it.

Related: OS#4006
Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82
---
M Transceiver52M/Transceiver.cpp
M Transceiver52M/Transceiver.h
2 files changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/39/14639/3
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14639
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82
Gerrit-Change-Number: 14639
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190702/73ace2ca/attachment.html>


More information about the gerrit-log mailing list