Change in ...osmo-trx[master]: Logger: global Log mutex is now available from C code

laforge gerrit-no-reply at lists.osmocom.org
Tue Jul 2 04:41:10 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14645 )

Change subject: Logger: global Log mutex is now available from C code
......................................................................


Patch Set 1: Code-Review+1

why do we have a log mutex in the first place?  I did some research into multithreadded logging using libosmocore and found that the only critical part would be adding/removing of log targets at runtime (the linked list of log targets).  However, during the actual log output / log write, as long as you don't use LOGPC, IIRC you should be fine.  Every fprintf should be atomic, whether to stdout or to any other file.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14645
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I473e57479f8ae98a84ad00b76ff338f79f732236
Gerrit-Change-Number: 14645
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 02 Jul 2019 04:41:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190702/62f2046b/attachment.html>


More information about the gerrit-log mailing list