Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API

laforge gerrit-no-reply at lists.osmocom.org
Tue Jul 2 04:38:08 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 )

Change subject: Transceiver: replace UDPSocket with libosmocore socket API
......................................................................


Patch Set 1: Code-Review+1

I understand that the old code also simply printed an error message (perror), and the new code replicates this.  But if the TRX sockets are disappearing at runtime, I would expect we cannot really recoverfrom that? A separate patch should probably either try error recovery (re-creating sockets) or use the fail-fast principle and terminate?


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14644
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ib19856a3e0a7607f63436c4a80b1381a3f318764
Gerrit-Change-Number: 14644
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 02 Jul 2019 04:38:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190702/4df1ef87/attachment.html>


More information about the gerrit-log mailing list