Change in ...osmo-ggsn[master]: ggsn: Add minimalistic PAP support

fixeria gerrit-no-reply at lists.osmocom.org
Mon Jul 1 10:10:36 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/13608 )

Change subject: ggsn: Add minimalistic PAP support
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/13608/5/ggsn/ggsn.c 
File ggsn/ggsn.c:

https://gerrit.osmocom.org/#/c/13608/5/ggsn/ggsn.c@503 
PS5, Line 503: struct pap_element
I think it makes sense to add the spec. reference here too:

  /* RFC 1334, section 3.2. Packet Format */



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/13608
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I81875f30f9f1497199253497f84718510747f731
Gerrit-Change-Number: 13608
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: msuraev <suraev at alumni.ntnu.no>
Gerrit-Comment-Date: Mon, 01 Jul 2019 10:10:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190701/afe6b0cf/attachment.html>


More information about the gerrit-log mailing list