From admin at opensuse.org Mon Jul 1 02:43:52 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 01 Jul 2019 02:43:52 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1973758b09f_6eea925f416019b6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 681s] | | #ifdef HAVE_STDINT_H [ 681s] | | # include [ 681s] | | #endif [ 681s] | | #ifdef HAVE_UNISTD_H [ 681s] | | # include [ 681s] | | #endif [ 681s] | | int [ 681s] | | main () [ 681s] | | { [ 681s] | | if (sizeof ((size_t))) [ 681s] | | return 0; [ 681s] | | ; [ 681s] | | return 0; [ 681s] | | } [ 681s] | configure:12583: result: yes [ 681s] | configure:12596: checking for working alloca.h [ 681s] | configure:12613: gcc -o conftest -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now conftest.c >&5 [ 681s] | configure:12613: $? = 0 [ 681s] | configure:12621: result: yes [ 681s] | configure:12629: checking for alloca [ 681s] | configure:12666: gcc -o conftest -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now conftest.c >&5 [ 681s] | configure:12666: $? = 0 [ 682s] | configure:12674: result: yes [ 684s] | configure:12780: checking for library containing d[ 638.042143] sysrq: SysRq : Power Off [ 684s] [ 638.044468] reboot: Power down [ 684s] ### VM INTERACTION END ### [ 684s] [ 684s] armbuild14 failed "build libosmocore_1.1.0.75.316d.dsc" at Mon Jul 1 02:43:41 UTC 2019. [ 684s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 1 03:23:00 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 01 Jul 2019 03:23:00 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d197c9c13971_6eea925f416040a9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 405s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 405s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 405s] collect2: error: ld returned 1 exit status [ 405s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 405s] make[4]: *** [osmo-bts-virtual] Error 1 [ 405s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 405s] Makefile:385: recipe for target 'all-recursive' failed [ 405s] make[3]: *** [all-recursive] Error 1 [ 405s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 405s] Makefile:434: recipe for target 'all-recursive' failed [ 405s] make[2]: *** [all-recursive] Error 1 [ 405s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 405s] Makefile:366: recipe for target 'all' failed [ 405s] make[1]: *** [all] Error 2 [ 405s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 405s] dh_auto_build: make -j1 returned exit code 2 [ 405s] debian/rules:12: recipe for target 'build' failed [ 405s] make: *** [build] Error 2 [ 405s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 405s] [ 406s] armbuild24 failed "build osmo-bts_0.8.1.331.d1e7.dsc" at Mon Jul 1 03:22:42 UTC 2019. [ 406s] [ 406s] ### VM INTERACTION START ### [ 409s] [ 388.817653] sysrq: SysRq : Power Off [ 409s] [ 388.838344] reboot: Power down [ 409s] ### VM INTERACTION END ### [ 409s] [ 409s] armbuild24 failed "build osmo-bts_0.8.1.331.d1e7.dsc" at Mon Jul 1 03:22:45 UTC 2019. [ 409s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 1 03:45:05 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 01 Jul 2019 03:45:05 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1981df9e7cb_6eea925f41605087@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 477s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 477s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 477s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 477s] Makefile:442: recipe for target 'vlr.o' failed [ 477s] make[4]: *** [vlr.o] Error 1 [ 477s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 477s] Makefile:422: recipe for target 'all-recursive' failed [ 477s] make[3]: *** [all-recursive] Error 1 [ 477s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 477s] Makefile:462: recipe for target 'all-recursive' failed [ 477s] make[2]: *** [all-recursive] Error 1 [ 477s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 477s] Makefile:394: recipe for target 'all' failed [ 477s] make[1]: *** [all] Error 2 [ 477s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 477s] dh_auto_build: make -j1 returned exit code 2 [ 477s] debian/rules:45: recipe for target 'build' failed [ 477s] make: *** [build] Error 2 [ 477s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 477s] [ 477s] armbuild02 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Mon Jul 1 03:44:55 UTC 2019. [ 477s] [ 477s] ### VM INTERACTION START ### [ 480s] [ 449.963340] sysrq: SysRq : Power Off [ 480s] [ 449.987406] reboot: Power down [ 480s] ### VM INTERACTION END ### [ 480s] [ 480s] armbuild02 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Mon Jul 1 03:44:59 UTC 2019. [ 480s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 1 03:46:33 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 01 Jul 2019 03:46:33 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d19821cb9e53_6eea925f416052a1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 484s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 484s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 484s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 484s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 484s] make[4]: *** [gb_proxy.o] Error 1 [ 484s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 484s] Makefile:391: recipe for target 'all-recursive' failed [ 484s] make[3]: *** [all-recursive] Error 1 [ 484s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 484s] Makefile:453: recipe for target 'all-recursive' failed [ 484s] make[2]: *** [all-recursive] Error 1 [ 484s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 484s] Makefile:385: recipe for target 'all' failed [ 484s] make[1]: *** [all] Error 2 [ 484s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 484s] dh_auto_build: make -j1 returned exit code 2 [ 484s] debian/rules:45: recipe for target 'build' failed [ 484s] make: *** [build] Error 2 [ 484s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 484s] [ 484s] armbuild02 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Mon Jul 1 03:46:19 UTC 2019. [ 484s] [ 484s] ### VM INTERACTION START ### [ 487s] [ 460.349174] sysrq: SysRq : Power Off [ 487s] [ 460.369818] reboot: Power down [ 487s] ### VM INTERACTION END ### [ 487s] [ 487s] armbuild02 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Mon Jul 1 03:46:22 UTC 2019. [ 487s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Jul 1 08:31:34 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 1 Jul 2019 08:31:34 +0000 Subject: Change in ...osmocom-bb[master]: trxcon/scheduler: enrich GSM 05.03 encoding error messages In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14637 ) Change subject: trxcon/scheduler: enrich GSM 05.03 encoding error messages ...................................................................... trxcon/scheduler: enrich GSM 05.03 encoding error messages Change-Id: I35a7c5df4fc0ed2195ba721f92812874011459d9 --- M src/host/trxcon/sched_lchan_pdtch.c M src/host/trxcon/sched_lchan_rach.c M src/host/trxcon/sched_lchan_tchf.c M src/host/trxcon/sched_lchan_tchh.c M src/host/trxcon/sched_lchan_xcch.c 5 files changed, 16 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/trxcon/sched_lchan_pdtch.c b/src/host/trxcon/sched_lchan_pdtch.c index 845ef64..ad021a9 100644 --- a/src/host/trxcon/sched_lchan_pdtch.c +++ b/src/host/trxcon/sched_lchan_pdtch.c @@ -146,7 +146,9 @@ rc = gsm0503_pdtch_encode(buffer, lchan->prim->payload, lchan->prim->payload_len); if (rc) { - LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload\n"); + LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n", + lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload, + lchan->prim->payload_len)); /* Forget this primitive */ sched_prim_drop(lchan); diff --git a/src/host/trxcon/sched_lchan_rach.c b/src/host/trxcon/sched_lchan_rach.c index e96a0e6..5d1f3ab 100644 --- a/src/host/trxcon/sched_lchan_rach.c +++ b/src/host/trxcon/sched_lchan_rach.c @@ -108,7 +108,8 @@ /* Encode extended (11-bit) payload */ rc = gsm0503_rach_ext_encode(payload, ext_req->ra11, trx->bsic, true); if (rc) { - LOGP(DSCHD, LOGL_ERROR, "Could not encode extended RACH burst\n"); + LOGP(DSCHD, LOGL_ERROR, "Could not encode extended RACH burst " + "(ra=%u bsic=%u)\n", ext_req->ra11, trx->bsic); /* Forget this primitive */ sched_prim_drop(lchan); @@ -125,7 +126,8 @@ /* Encode regular (8-bit) payload */ rc = gsm0503_rach_ext_encode(payload, req->ra, trx->bsic, false); if (rc) { - LOGP(DSCHD, LOGL_ERROR, "Could not encode RACH burst\n"); + LOGP(DSCHD, LOGL_ERROR, "Could not encode RACH burst " + "(ra=%u bsic=%u)\n", req->ra, trx->bsic); /* Forget this primitive */ sched_prim_drop(lchan); diff --git a/src/host/trxcon/sched_lchan_tchf.c b/src/host/trxcon/sched_lchan_tchf.c index cec7daf..f2ecdcc 100644 --- a/src/host/trxcon/sched_lchan_tchf.c +++ b/src/host/trxcon/sched_lchan_tchf.c @@ -239,7 +239,9 @@ /* Encode payload */ rc = gsm0503_tch_fr_encode(buffer, lchan->prim->payload, l2_len, 1); if (rc) { - LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload\n"); + LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n", + lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload, + lchan->prim->payload_len)); /* Forget this primitive */ sched_prim_drop(lchan); diff --git a/src/host/trxcon/sched_lchan_tchh.c b/src/host/trxcon/sched_lchan_tchh.c index 172f54b..0201ee3 100644 --- a/src/host/trxcon/sched_lchan_tchh.c +++ b/src/host/trxcon/sched_lchan_tchh.c @@ -445,7 +445,9 @@ /* Encode the payload */ rc = gsm0503_tch_hr_encode(buffer, lchan->prim->payload, l2_len); if (rc) { - LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload\n"); + LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n", + lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload, + lchan->prim->payload_len)); /* Forget this primitive */ sched_prim_drop(lchan); diff --git a/src/host/trxcon/sched_lchan_xcch.c b/src/host/trxcon/sched_lchan_xcch.c index 2d2b1d9..196f949 100644 --- a/src/host/trxcon/sched_lchan_xcch.c +++ b/src/host/trxcon/sched_lchan_xcch.c @@ -155,7 +155,9 @@ /* Encode payload */ rc = gsm0503_xcch_encode(buffer, lchan->prim->payload); if (rc) { - LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload\n"); + LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n", + lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload, + lchan->prim->payload_len)); /* Forget this primitive */ sched_prim_drop(lchan); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14637 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I35a7c5df4fc0ed2195ba721f92812874011459d9 Gerrit-Change-Number: 14637 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 08:31:34 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 1 Jul 2019 08:31:34 +0000 Subject: Change in ...osmocom-bb[master]: trxcon/scheduer: fix: properly check rc of gsm0503_pdtch_encode() In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14638 ) Change subject: trxcon/scheduer: fix: properly check rc of gsm0503_pdtch_encode() ...................................................................... trxcon/scheduer: fix: properly check rc of gsm0503_pdtch_encode() The gsm0503_pdtch_encode() returns negative number on error, and the amount of encoded bits in case of success. Change-Id: I7d75141142922909330c5e86be8734bb06cd57a4 --- M src/host/trxcon/sched_lchan_pdtch.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/trxcon/sched_lchan_pdtch.c b/src/host/trxcon/sched_lchan_pdtch.c index ad021a9..733e574 100644 --- a/src/host/trxcon/sched_lchan_pdtch.c +++ b/src/host/trxcon/sched_lchan_pdtch.c @@ -145,7 +145,7 @@ /* Encode payload */ rc = gsm0503_pdtch_encode(buffer, lchan->prim->payload, lchan->prim->payload_len); - if (rc) { + if (rc < 0) { LOGP(DSCHD, LOGL_ERROR, "Failed to encode L2 payload (len=%zu): %s\n", lchan->prim->payload_len, osmo_hexdump(lchan->prim->payload, lchan->prim->payload_len)); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7d75141142922909330c5e86be8734bb06cd57a4 Gerrit-Change-Number: 14638 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 09:45:07 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 09:45:07 +0000 Subject: Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 ) Change subject: Introduce structs to encode TRXD packets ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/14629/2/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/14629/2/Transceiver52M/Transceiver.cpp at 957 PS2, Line 957: pkt > I think you also need to initialize the pkt->version here. [?] Ack https://gerrit.osmocom.org/#/c/14629/2/Transceiver52M/Transceiver.cpp at 967 PS2, Line 967: There's an uninitizalied > Actually, there are two bytes. [?] Agree, that's the same I'm saying :) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb Gerrit-Change-Number: 14629 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 01 Jul 2019 09:45:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 09:48:46 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 09:48:46 +0000 Subject: Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 ) Change subject: Introduce structs to encode TRXD packets ...................................................................... Patch Set 2: > Patch Set 2: > > Also, it would be great to split TRX protocol implementation out of Transceiver.cpp. Agree, I plan to do that in forthcoming commit once we implement different versions, I didn't want to make too many changes atthe same time, it'd have been confusing. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb Gerrit-Change-Number: 14629 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 01 Jul 2019 09:48:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 09:53:43 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 09:53:43 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: refactor: gather uplink burst parameters in struct In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14630 ) Change subject: Transceiver: refactor: gather uplink burst parameters in struct ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14630/2/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/14630/2/Transceiver52M/Transceiver.cpp at 562 PS2, Line 562: rssi_valid > Do you think we still need this? I think, if the function returns false, then the caller should cons [?] Agree, if you don't mind I'll remove it in a separate commit to keep refactor separated from removing this unused param. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7e590fb1c0901de627e782f183251c20f4f68d48 Gerrit-Change-Number: 14630 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 01 Jul 2019 09:53:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:08:13 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:08:13 +0000 Subject: Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14629 to look at the new patch set (#3). Change subject: Introduce structs to encode TRXD packets ...................................................................... Introduce structs to encode TRXD packets This will ease adding new protocol versions in the future. Related: OS#4006 Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb --- M Transceiver52M/Makefile.am M Transceiver52M/Transceiver.cpp A Transceiver52M/proto_trxd.h 3 files changed, 45 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/29/14629/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb Gerrit-Change-Number: 14629 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:08:13 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:08:13 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: refactor: gather uplink burst parameters in struct In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14630 to look at the new patch set (#3). Change subject: Transceiver: refactor: gather uplink burst parameters in struct ...................................................................... Transceiver: refactor: gather uplink burst parameters in struct A new struct trx_ul_burst_ind is introduced, which will handle information filled by lower layers upon decoding of uplink bursts. Methods pullRadioVector() and logRxBurst() are adapted to use that struct. This way it's easier to understand in/out parameters and it's also easier to add further parameters to be filled in in the future. Related: OS#4006 Change-Id: I7e590fb1c0901de627e782f183251c20f4f68d48 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 48 insertions(+), 53 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/30/14630/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7e590fb1c0901de627e782f183251c20f4f68d48 Gerrit-Change-Number: 14630 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:08:13 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:08:13 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14632 to look at the new patch set (#2). Change subject: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts ...................................................................... Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts Those 2 bytes at the end have been sent over the TRXD socket for historical reasons. However, osmo-bts-trx also supports receiving bursts without that padding since more than 2 years now (May 29 2017, 8876a507ff46c4caf8cb4f99df121f1188db01ef), so let's drop those two (since anyway those are not going to be sent for sure in v1 of TRXD protocol). Related: OS#4006 Change-Id: Iedc54011f333f48c6c8b81cab4d640f7601e01dd --- M Transceiver52M/Transceiver.cpp 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/32/14632/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iedc54011f333f48c6c8b81cab4d640f7601e01dd Gerrit-Change-Number: 14632 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:08:19 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:08:19 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14639 Change subject: Transceiver: Drop unused rssi_valid struct field ...................................................................... Transceiver: Drop unused rssi_valid struct field That field is actually never used. Furthermore, if pullRadioVector() returns false, then the caller should consider the 'trx_ul_burst_ind' structure as uninitialized. Moreover, RSSI is mandatory - we cannot send burst indications without it. Related: OS#4006 Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/39/14639/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 716a507..4999ac4 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -559,7 +559,6 @@ int max_i = -1; signalVector *burst; TransceiverState *state = &mStates[chan]; - bi->rssi_valid = false; /* Blocking FIFO read */ radioVector *radio_burst = mReceiveFIFO[chan]->read(); @@ -609,9 +608,6 @@ bi->rssi = 20.0 * log10(rxFullScale / avg); - /* RSSI estimation are valid */ - bi->rssi_valid = true; - if (type == IDLE) { /* Update noise levels */ state->mNoises.insert(avg); diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index 0f452c1..965d07d 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -41,7 +41,6 @@ double rssi; // in dBFS double toa; // in symbols double noise; // noise level in dBFS - bool rssi_valid; // are RSSI, noise and burstTime valid }; class Transceiver; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82 Gerrit-Change-Number: 14639 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:10:36 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 1 Jul 2019 10:10:36 +0000 Subject: Change in ...osmo-ggsn[master]: ggsn: Add minimalistic PAP support In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/13608 ) Change subject: ggsn: Add minimalistic PAP support ...................................................................... Patch Set 5: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/13608/5/ggsn/ggsn.c File ggsn/ggsn.c: https://gerrit.osmocom.org/#/c/13608/5/ggsn/ggsn.c at 503 PS5, Line 503: struct pap_element I think it makes sense to add the spec. reference here too: /* RFC 1334, section 3.2. Packet Format */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/13608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I81875f30f9f1497199253497f84718510747f731 Gerrit-Change-Number: 13608 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: msuraev Gerrit-Comment-Date: Mon, 01 Jul 2019 10:10:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:15:18 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:15:18 +0000 Subject: Change in ...osmo-ggsn[master]: ggsn: Add minimalistic PAP support In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#6) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/13608 ) Change subject: ggsn: Add minimalistic PAP support ...................................................................... ggsn: Add minimalistic PAP support Some modems are configured to use PAP as an additional authentication mechanism beyond the GSM authentication that's part of GMM. Let's handle such PAP authentication requests by simply acknowledging them all, without actually checking any credentials database. This is the most sane thing we can do for now, without adding external requirements / interfaces like radius servers or the like. Closes: OS#3914 Change-Id: I81875f30f9f1497199253497f84718510747f731 --- M ggsn/ggsn.c 1 file changed, 86 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/08/13608/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/13608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I81875f30f9f1497199253497f84718510747f731 Gerrit-Change-Number: 13608 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: msuraev Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:18:07 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 1 Jul 2019 10:18:07 +0000 Subject: Change in ...osmo-ggsn[master]: ggsn: Add minimalistic PAP support In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/13608 ) Change subject: ggsn: Add minimalistic PAP support ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/13608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I81875f30f9f1497199253497f84718510747f731 Gerrit-Change-Number: 13608 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: msuraev Gerrit-Comment-Date: Mon, 01 Jul 2019 10:18:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:18:37 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:18:37 +0000 Subject: Change in ...osmo-ggsn[master]: configure.ac: some versions of linux/if.h require including sys/socket.h In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14624 ) Change subject: configure.ac: some versions of linux/if.h require including sys/socket.h ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iba869a75745cea01024fa3ce04917c02fa608a13 Gerrit-Change-Number: 14624 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 01 Jul 2019 10:18:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:19:07 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 1 Jul 2019 10:19:07 +0000 Subject: Change in ...osmo-ggsn[master]: configure.ac: some versions of linux/if.h require including sys/socket.h In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14624 ) Change subject: configure.ac: some versions of linux/if.h require including sys/socket.h ...................................................................... Patch Set 2: Verified+1 Code-Review+2 Works for me (TM). -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iba869a75745cea01024fa3ce04917c02fa608a13 Gerrit-Change-Number: 14624 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 01 Jul 2019 10:19:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:31:21 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:31:21 +0000 Subject: Change in ...osmo-ggsn[master]: ggsn: Add minimalistic PAP support In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/13608 ) Change subject: ggsn: Add minimalistic PAP support ...................................................................... ggsn: Add minimalistic PAP support Some modems are configured to use PAP as an additional authentication mechanism beyond the GSM authentication that's part of GMM. Let's handle such PAP authentication requests by simply acknowledging them all, without actually checking any credentials database. This is the most sane thing we can do for now, without adding external requirements / interfaces like radius servers or the like. Closes: OS#3914 Change-Id: I81875f30f9f1497199253497f84718510747f731 --- M ggsn/ggsn.c 1 file changed, 86 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c index c559923..e95471a 100644 --- a/ggsn/ggsn.c +++ b/ggsn/ggsn.c @@ -1,7 +1,7 @@ /* * OsmoGGSN - Gateway GPRS Support Node * Copyright (C) 2002, 2003, 2004 Mondru AB. - * Copyright (C) 2017 by Harald Welte + * Copyright (C) 2017-2019 by Harald Welte * * The contents of this file may be used under the terms of the GNU * General Public License Version 2, provided that the above copyright @@ -47,6 +47,7 @@ #include #include #include +#include #include #include #include @@ -499,6 +500,87 @@ return NULL; } +/* RFC 1334, section 3.2. Packet Format */ +struct pap_element { + uint8_t code; + uint8_t id; + uint16_t len; /* length including header */ + uint8_t data[0]; +} __attribute__((packed)); + +enum pap_code { + PAP_CODE_AUTH_REQ = 1, + PAP_CODE_AUTH_ACK = 2, + PAP_CODE_AUTH_NAK = 3, +}; + +static const char *pap_welcome = "Welcome to OsmoGGSN " PACKAGE_VERSION; + +/* Handle PAP protocol according to RFC 1334 */ +static void process_pco_element_pap(const struct pco_element *pco_in, struct msgb *resp, + const struct apn_ctx *apn, struct pdp_t *pdp) +{ + const struct pap_element *pap_in = (const struct pap_element *) pco_in->data; + uint16_t pap_in_len; + uint8_t peer_id_len; + const uint8_t *peer_id; + unsigned int pap_welcome_len; + uint8_t pap_out_size; + struct pap_element *pap_out; + + if (pco_in->length < sizeof(struct pap_element)) + goto ret_broken; + + pap_in_len = osmo_load16be(&pap_in->len); + if (pco_in->length < pap_in_len) + goto ret_broken; + /* "pco_in->length > pap_in_len" is allowed: RFC1334 2.2 states: + "Octets outside the range of the Length field should be treated as + Data Link Layer padding and should be ignored on reception." + */ + + switch (pap_in->code) { + case PAP_CODE_AUTH_REQ: + if (pap_in_len < sizeof(struct pap_element) + 1) + goto ret_broken_auth; + peer_id_len = pap_in->data[0]; + if (pap_in_len < sizeof(struct pap_element) + 1 + peer_id_len) + goto ret_broken_auth; + peer_id = &pap_in->data[1]; + LOGPPDP(LOGL_DEBUG, pdp, "PCO PAP PeerId = %s, ACKing\n", + osmo_quote_str((const char *)peer_id, peer_id_len)); + /* Password-Length + Password following here, but we don't care */ + + /* Prepare response, we ACK all of them: */ + pap_welcome_len = strlen(pap_welcome); + /* +1: Length field of pap_welcome Message */ + pap_out_size = sizeof(struct pap_element) + 1 + pap_welcome_len; + pap_out = alloca(pap_out_size); + pap_out->code = PAP_CODE_AUTH_ACK; + pap_out->id = pap_in->id; + pap_out->len = htons(pap_out_size); + pap_out->data[0] = pap_welcome_len; + memcpy(pap_out->data+1, pap_welcome, pap_welcome_len); + msgb_t16lv_put(resp, PCO_P_PAP, pap_out_size, (uint8_t *) pap_out); + break; + case PAP_CODE_AUTH_ACK: + case PAP_CODE_AUTH_NAK: + default: + LOGPPDP(LOGL_NOTICE, pdp, "Unsupported PAP PCO Code %u, ignoring\n", pap_in->code); + break; + } + return; + +ret_broken_auth: + LOGPPDP(LOGL_NOTICE, pdp, "Invalid PAP AuthenticateReq: %s, ignoring\n", + osmo_hexdump_nospc((const uint8_t *)pco_in, pco_in->length)); + return; + +ret_broken: + LOGPPDP(LOGL_NOTICE, pdp, "Invalid PAP PCO Length: %s, ignoring\n", + osmo_hexdump_nospc((const uint8_t *)pco_in, pco_in->length)); +} + static void process_pco_element_ipcp(const struct pco_element *pco_elem, struct msgb *resp, const struct apn_ctx *apn, struct pdp_t *pdp) { @@ -580,6 +662,9 @@ const struct apn_ctx *apn, struct pdp_t *pdp) { switch (ntohs(pco_elem->protocol_id)) { + case PCO_P_PAP: + process_pco_element_pap(pco_elem, resp, apn, pdp); + break; case PCO_P_IPCP: process_pco_element_ipcp(pco_elem, resp, apn, pdp); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/13608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I81875f30f9f1497199253497f84718510747f731 Gerrit-Change-Number: 13608 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: msuraev Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:31:22 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:31:22 +0000 Subject: Change in ...osmo-ggsn[master]: ggsn: More logging from PCO handling (e.g. in case of malconfiguration) In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/13609 ) Change subject: ggsn: More logging from PCO handling (e.g. in case of malconfiguration) ...................................................................... ggsn: More logging from PCO handling (e.g. in case of malconfiguration) Change-Id: I38c2c4178ff4fd795f54638adec63166b1c0838e --- M ggsn/ggsn.c 1 file changed, 18 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c index e95471a..968d4dd 100644 --- a/ggsn/ggsn.c +++ b/ggsn/ggsn.c @@ -595,15 +595,19 @@ ptrdiff_t consumed; size_t remain; - if (!peer_v4) + if (!peer_v4) { + LOGPPDP(LOGL_ERROR, pdp, "IPCP but no IPv4 type ?!?\n"); return; + } ipcp = pco_elem->data; consumed = (ipcp - &pdp->pco_req.v[0]); remain = sizeof(pdp->pco_req.v) - consumed; ipcp_len = osmo_load16be(ipcp + 2); /* 1=code + 1=id */ - if (remain < 0 || remain < ipcp_len) + if (remain < 0 || remain < ipcp_len) { + LOGPPDP(LOGL_ERROR, pdp, "Malformed IPCP, ignoring\n"); return; + } /* Three byte T16L header */ msgb_put_u16(resp, 0x8021); /* IPCP */ @@ -636,6 +640,7 @@ const struct apn_ctx *apn, struct pdp_t *pdp) { unsigned int i; + const uint8_t *tail = resp->tail; for (i = 0; i < ARRAY_SIZE(apn->v6.cfg.dns); i++) { const struct in46_addr *i46a = &apn->v6.cfg.dns[i]; @@ -643,12 +648,15 @@ continue; msgb_t16lv_put(resp, PCO_P_DNS_IPv6_ADDR, i46a->len, i46a->v6.s6_addr); } + if (resp->tail == tail) + LOGPPDP(LOGL_NOTICE, pdp, "MS requested IPv6 DNS, but APN has none configured\n"); } static void process_pco_element_dns_ipv4(const struct pco_element *pco_elem, struct msgb *resp, const struct apn_ctx *apn, struct pdp_t *pdp) { unsigned int i; + const uint8_t *tail = resp->tail; for (i = 0; i < ARRAY_SIZE(apn->v4.cfg.dns); i++) { const struct in46_addr *i46a = &apn->v4.cfg.dns[i]; @@ -656,12 +664,17 @@ continue; msgb_t16lv_put(resp, PCO_P_DNS_IPv4_ADDR, i46a->len, (uint8_t *)&i46a->v4); } + if (resp->tail == tail) + LOGPPDP(LOGL_NOTICE, pdp, "MS requested IPv4 DNS, but APN has none configured\n"); } static void process_pco_element(const struct pco_element *pco_elem, struct msgb *resp, const struct apn_ctx *apn, struct pdp_t *pdp) { - switch (ntohs(pco_elem->protocol_id)) { + uint16_t protocol_id = ntohs(pco_elem->protocol_id); + + LOGPPDP(LOGL_DEBUG, pdp, "PCO Protocol 0x%04x\n", protocol_id); + switch (protocol_id) { case PCO_P_PAP: process_pco_element_pap(pco_elem, resp, apn, pdp); break; @@ -675,6 +688,8 @@ process_pco_element_dns_ipv4(pco_elem, resp, apn, pdp); break; default: + LOGPPDP(LOGL_INFO, pdp, "Unknown/Unimplemented PCO Protocol 0x%04x: %s\n", + protocol_id, osmo_hexdump_nospc(pco_elem->data, pco_elem->length)); break; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/13609 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I38c2c4178ff4fd795f54638adec63166b1c0838e Gerrit-Change-Number: 13609 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: msuraev Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:31:22 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:31:22 +0000 Subject: Change in ...osmo-ggsn[master]: ggsn: Avoid unaligned mem access reading PCO proto id In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14619 ) Change subject: ggsn: Avoid unaligned mem access reading PCO proto id ...................................................................... ggsn: Avoid unaligned mem access reading PCO proto id Change-Id: I3d80833319869503691a52927892e6ac30744915 --- M ggsn/ggsn.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c index 968d4dd..78987e4 100644 --- a/ggsn/ggsn.c +++ b/ggsn/ggsn.c @@ -671,7 +671,7 @@ static void process_pco_element(const struct pco_element *pco_elem, struct msgb *resp, const struct apn_ctx *apn, struct pdp_t *pdp) { - uint16_t protocol_id = ntohs(pco_elem->protocol_id); + uint16_t protocol_id = osmo_load16be(&pco_elem->protocol_id); LOGPPDP(LOGL_DEBUG, pdp, "PCO Protocol 0x%04x\n", protocol_id); switch (protocol_id) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14619 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I3d80833319869503691a52927892e6ac30744915 Gerrit-Change-Number: 14619 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:31:23 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:31:23 +0000 Subject: Change in ...osmo-ggsn[master]: ggsn: Use structures instead of raw arrays when parsing ipcp_hdr In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14620 ) Change subject: ggsn: Use structures instead of raw arrays when parsing ipcp_hdr ...................................................................... ggsn: Use structures instead of raw arrays when parsing ipcp_hdr We have a structure to handle that data type, so let's use it. Change-Id: I991e53544b733df7773d66280ffa19a2a5123d97 --- M ggsn/ggsn.c 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c index 78987e4..1c6bc4d 100644 --- a/ggsn/ggsn.c +++ b/ggsn/ggsn.c @@ -419,13 +419,13 @@ } __attribute__ ((packed)); /* determine if IPCP contains given option */ -static const uint8_t *ipcp_contains_option(const uint8_t *ipcp, size_t ipcp_len, +static const uint8_t *ipcp_contains_option(const struct ipcp_hdr *ipcp, size_t ipcp_len, enum ipcp_options opt, size_t opt_minlen) { - const uint8_t *cur_opt = ipcp + sizeof(struct ipcp_hdr); + const uint8_t *cur_opt = ipcp->options; /* iterate over Options and check if protocol contained */ - while (cur_opt + sizeof(struct ipcp_option_hdr) <= ipcp + ipcp_len) { + while (cur_opt + sizeof(struct ipcp_option_hdr) <= (uint8_t*)ipcp + ipcp_len) { const struct ipcp_option_hdr *cur_opt_hdr = (const struct ipcp_option_hdr *)cur_opt; /* length value includes 2 bytes type/length */ if (cur_opt_hdr->len < sizeof(struct ipcp_option_hdr)) @@ -588,7 +588,7 @@ const struct in46_addr *dns1 = &apn->v4.cfg.dns[0]; const struct in46_addr *dns2 = &apn->v4.cfg.dns[1]; uint8_t *start = resp->tail; - const uint8_t *ipcp; + const struct ipcp_hdr *ipcp; uint16_t ipcp_len; uint8_t *len1, *len2; unsigned int len_appended; @@ -600,10 +600,10 @@ return; } - ipcp = pco_elem->data; - consumed = (ipcp - &pdp->pco_req.v[0]); + ipcp = (const struct ipcp_hdr *)pco_elem->data; + consumed = (pco_elem->data - &pdp->pco_req.v[0]); remain = sizeof(pdp->pco_req.v) - consumed; - ipcp_len = osmo_load16be(ipcp + 2); /* 1=code + 1=id */ + ipcp_len = osmo_load16be(&ipcp->len); if (remain < 0 || remain < ipcp_len) { LOGPPDP(LOGL_ERROR, pdp, "Malformed IPCP, ignoring\n"); return; @@ -614,7 +614,7 @@ len1 = msgb_put(resp, 1); /* Length of contents: delay */ msgb_put_u8(resp, 0x02); /* ACK */ - msgb_put_u8(resp, ipcp[1]); /* ID: Needs to match request */ + msgb_put_u8(resp, ipcp->id); /* ID: Needs to match request */ msgb_put_u8(resp, 0x00); /* Length MSB */ len2 = msgb_put(resp, 1); /* Length LSB: delay */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14620 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I991e53544b733df7773d66280ffa19a2a5123d97 Gerrit-Change-Number: 14620 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:31:23 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:31:23 +0000 Subject: Change in ...osmo-ggsn[master]: configure.ac: Replace obosolete macro AC_CANONICAL_SYSTEM In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14621 ) Change subject: configure.ac: Replace obosolete macro AC_CANONICAL_SYSTEM ...................................................................... configure.ac: Replace obosolete macro AC_CANONICAL_SYSTEM $ autoconf -Wall configure.ac:11: warning: The macro `AC_CANONICAL_SYSTEM' is obsolete. configure.ac:11: You should run autoupdate. autoupdate applied the change present in this commit. Change-Id: Iee59e6e9a7670867d5bc55ba96f79130bc6982f6 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index ede6963..65d0e8c 100644 --- a/configure.ac +++ b/configure.ac @@ -8,7 +8,7 @@ AC_CONFIG_AUX_DIR([.]) AC_CONFIG_TESTDIR(tests) -AC_CANONICAL_SYSTEM +AC_CANONICAL_TARGET dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14621 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iee59e6e9a7670867d5bc55ba96f79130bc6982f6 Gerrit-Change-Number: 14621 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:31:24 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:31:24 +0000 Subject: Change in ...osmo-ggsn[master]: configure.ac: Use brackets in AC_INIT params In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14622 ) Change subject: configure.ac: Use brackets in AC_INIT params ...................................................................... configure.ac: Use brackets in AC_INIT params Change applied as a result of running "autoupdate". Change-Id: I955b535737f0a0cbdf25377609cec8f3d8d3eb45 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 65d0e8c..5fda6eb 100644 --- a/configure.ac +++ b/configure.ac @@ -1,5 +1,5 @@ # Process this file with autoconf to produce a configure script. -AC_INIT(osmo-ggsn, m4_esyscmd([./git-version-gen .tarball-version]), osmocom-net-gprs at lists.osmocom.org) +AC_INIT([osmo-ggsn],[m4_esyscmd(./git-version-gen .tarball-version)],[osmocom-net-gprs at lists.osmocom.org]) AC_CONFIG_SRCDIR([gtp/gtp.c]) AM_CONFIG_HEADER([config.h]) #AC_CONFIG_HEADER([config.h]) -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I955b535737f0a0cbdf25377609cec8f3d8d3eb45 Gerrit-Change-Number: 14622 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:31:26 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:31:26 +0000 Subject: Change in ...osmo-ggsn[master]: configure.ac: Use prefered AC_CONFIG_HEADERS over AM_CONFIG_HEADER In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14623 ) Change subject: configure.ac: Use prefered AC_CONFIG_HEADERS over AM_CONFIG_HEADER ...................................................................... configure.ac: Use prefered AC_CONFIG_HEADERS over AM_CONFIG_HEADER This macro is preferred by autofoo upstream. It was added around automake 1.7, and offers backward compatibility with AM_CONFIG_HEADER. Related: OS#3230 Change-Id: I88707d4895d9c231715d5252d2cfab589b42fe0c --- M configure.ac 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 5fda6eb..5581c32 100644 --- a/configure.ac +++ b/configure.ac @@ -1,8 +1,7 @@ # Process this file with autoconf to produce a configure script. AC_INIT([osmo-ggsn],[m4_esyscmd(./git-version-gen .tarball-version)],[osmocom-net-gprs at lists.osmocom.org]) AC_CONFIG_SRCDIR([gtp/gtp.c]) -AM_CONFIG_HEADER([config.h]) -#AC_CONFIG_HEADER([config.h]) +AC_CONFIG_HEADERS([config.h]) dnl *This* is the root dir, even if an install-sh exists in ../ or ../../ AC_CONFIG_AUX_DIR([.]) -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I88707d4895d9c231715d5252d2cfab589b42fe0c Gerrit-Change-Number: 14623 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:31:26 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:31:26 +0000 Subject: Change in ...osmo-ggsn[master]: configure.ac: some versions of linux/if.h require including sys/socket.h In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14624 ) Change subject: configure.ac: some versions of linux/if.h require including sys/socket.h ...................................................................... configure.ac: some versions of linux/if.h require including sys/socket.h Related: OS#3230 Change-Id: Iba869a75745cea01024fa3ce04917c02fa608a13 --- M configure.ac 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved; Verified Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index 5581c32..7b985b9 100644 --- a/configure.ac +++ b/configure.ac @@ -74,8 +74,12 @@ AC_HEADER_SYS_WAIT AC_CHECK_HEADERS([arpa/inet.h fcntl.h netdb.h netinet/in.h stdint.h stdlib.h string.h sys/ioctl.h sys/socket.h sys/time.h unistd.h]) -# Check for if header -AC_CHECK_HEADERS([linux/if.h net/if.h]) +# Check for if header. Some versions of linux/if.h fail without sys/socket.h included beforehand: +# see https://algorithmicallyrandom.blogspot.com/2012/07/error-on-including-include.html +AC_CHECK_HEADERS([linux/if.h net/if.h], [], [], [#ifdef HAVE_SYS_SOCKET_H + # include + # endif + ]) # Check for tun header AC_CHECK_HEADERS([linux/if_tun.h net/if_tun.h]) -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Iba869a75745cea01024fa3ce04917c02fa608a13 Gerrit-Change-Number: 14624 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 10:35:37 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 10:35:37 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: cosmetic: bsc: Document timer timing out in f_tc_ho_out_fail_no_ho_de... In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14606 ) Change subject: cosmetic: bsc: Document timer timing out in f_tc_ho_out_fail_no_ho_detect ...................................................................... cosmetic: bsc: Document timer timing out in f_tc_ho_out_fail_no_ho_detect Change-Id: I4d06fcff63d82f849da08f509b007cb19e809fb0 --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index ec1be13..f9609ba 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3167,7 +3167,7 @@ } /* The MS never shows up on the remote BSS. Eventually the BSC times - * out and we run into 3GPP TS 48.008 3.1.5.3.3 "Abnormal Conditions": + * out (T8) and we run into 3GPP TS 48.008 3.1.5.3.3 "Abnormal Conditions": * RR should be released and Clear Request should go to the MSC. */ var MgcpCommand mgcp; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4d06fcff63d82f849da08f509b007cb19e809fb0 Gerrit-Change-Number: 14606 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 11:07:16 2019 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Mon, 1 Jul 2019 11:07:16 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support receiving lowercase LCO codec In-Reply-To: References: Message-ID: dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14596 ) Change subject: mgw: Support receiving lowercase LCO codec ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I51dc1cdcbe2a5587769335fbecb5039ef22cae5d Gerrit-Change-Number: 14596 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 01 Jul 2019 11:07:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 19:09:08 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 19:09:08 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14639 to look at the new patch set (#2). Change subject: Transceiver: Drop unused rssi_valid struct field ...................................................................... Transceiver: Drop unused rssi_valid struct field That field is actually never used. Furthermore, if pullRadioVector() returns false, then the caller should consider the 'trx_ul_burst_ind' structure as uninitialized. Moreover, RSSI is mandatory - we cannot send burst indications without it. Related: OS#4006 Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 11 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/39/14639/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82 Gerrit-Change-Number: 14639 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 19:09:08 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 19:09:08 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14632 to look at the new patch set (#3). Change subject: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts ...................................................................... Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts Those 2 bytes at the end have been sent over the TRXD socket for historical reasons. However, osmo-bts-trx also supports receiving bursts without that padding since more than 2 years now (May 29 2017, 8876a507ff46c4caf8cb4f99df121f1188db01ef), so let's drop those two (since anyway those are not going to be sent for sure in v1 of TRXD protocol). Related: OS#4006 Change-Id: Iedc54011f333f48c6c8b81cab4d640f7601e01dd --- M Transceiver52M/Transceiver.cpp 1 file changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/32/14632/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iedc54011f333f48c6c8b81cab4d640f7601e01dd Gerrit-Change-Number: 14632 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 19:09:12 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 19:09:12 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu... Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() ...................................................................... Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() That's were all the filling logic happens, while in driveReceiveFIFO we mostly want to take the burst, generate a message and sent it over the socket. In pullRadioVector this way we always provide normalized values based on user configuration (VTY rssi-offset). Related: OS#4006 Change-Id: I1ee28daf21dc287bec564d45d58086d63655c0f6 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 11 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/40/14640/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index a0ff4cd..5a6b652 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -606,19 +606,19 @@ burst = radio_burst->getVector(max_i); avg = sqrt(avg / radio_burst->chans()); - bi->rssi = 20.0 * log10(rxFullScale / avg); + bi->rssi = 20.0 * log10(rxFullScale / avg) + rssiOffset; if (type == IDLE) { /* Update noise levels */ state->mNoises.insert(avg); state->mNoiseLev = state->mNoises.avg(); - bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev); + bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset; delete radio_burst; return false; } else { /* Do not update noise levels */ - bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev); + bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset; } unsigned max_toa = (type == RACH || type == EXT_RACH) ? @@ -906,22 +906,21 @@ } } -void Transceiver::logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi, double dbm) +void Transceiver::logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi) { LOG(DEBUG) << std::fixed << std::right << " chan: " << chan << " time: " << bi->burstTime - << " RSSI: " << std::setw(5) << std::setprecision(1) << bi->rssi - << "dBFS/" << std::setw(6) << -dbm << "dBm" - << " noise: " << std::setw(5) << std::setprecision(1) << bi->noise - << "dBFS/" << std::setw(6) << -(bi->noise + rssiOffset) << "dBm" + << " RSSI: " << std::setw(5) << std::setprecision(1) << (bi->rssi - rssiOffset) + << "dBFS/" << std::setw(6) << -bi->rssi << "dBm" + << " noise: " << std::setw(5) << std::setprecision(1) << (bi->noise - rssiOffset) + << "dBFS/" << std::setw(6) << -bi->noise << "dBm" << " TOA: " << std::setw(5) << std::setprecision(2) << bi->toa << " bits: " << *(bi->rxBurst); } void Transceiver::driveReceiveFIFO(size_t chan) { - double dBm; // in dBm int TOAint; // in 1/256 symbols struct trx_ul_burst_ind bi; @@ -932,8 +931,7 @@ // Convert -1..+1 soft bits to 0..1 soft bits vectorSlicer(bi.rxBurst); - dBm = bi.rssi + rssiOffset; - logRxBurst(chan, &bi, dBm); + logRxBurst(chan, &bi); TOAint = (int) (bi.toa * 256.0 + 0.5); // round to closest integer @@ -943,7 +941,7 @@ pkt->common.reserved = 0; pkt->common.tn = bi.burstTime.TN(); osmo_store32be(bi.burstTime.FN(), &pkt->common.fn); - pkt->v0.rssi = dBm; + pkt->v0.rssi = bi.rssi; osmo_store16be(TOAint, &pkt->v0.toa); SoftVector::iterator burstItr = bi.rxBurst->begin(); diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index d7c6182..7963519 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -271,7 +271,7 @@ /** set priority on current thread */ void setPriority(float prio = 0.5) { mRadioInterface->setPriority(prio); } - void logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi, double dbm); + void logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi); }; void *RxUpperLoopAdapter(TransceiverChannel *); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1ee28daf21dc287bec564d45d58086d63655c0f6 Gerrit-Change-Number: 14640 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 19:09:12 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 19:09:12 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector() Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14641 Change subject: Transceiver: Move soft bits normalization to pullRadioVector() ...................................................................... Transceiver: Move soft bits normalization to pullRadioVector() That's were all the filling logic happens, while in driveReceiveFIFO we mostly want to take the burst, generate a message and sent it over the socket. Related: OS#4006 Change-Id: Ibfb48877af4ff5ef0f56390901669c8353beaf48 --- M Transceiver52M/Transceiver.cpp 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/41/14641/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 5a6b652..a6a32f0 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -649,6 +649,9 @@ else /* size() here is actually gSlotLen + 8, due to guard periods */ bi->nbits = gSlotLen; + // Convert -1..+1 soft bits to 0..1 soft bits + vectorSlicer(bi->rxBurst); + delete radio_burst; return true; } @@ -928,9 +931,6 @@ if (!pullRadioVector(chan, &bi)) return; - // Convert -1..+1 soft bits to 0..1 soft bits - vectorSlicer(bi.rxBurst); - logRxBurst(chan, &bi); TOAint = (int) (bi.toa * 256.0 + 0.5); // round to closest integer -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ibfb48877af4ff5ef0f56390901669c8353beaf48 Gerrit-Change-Number: 14641 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 19:09:13 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 19:09:13 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind ...................................................................... Transceiver: Drop use of GSM::Time from trx_ul_burst_ind Use of that class is really not needed since we don't need to do any calculation with those values, so we can simply store the final values in the struct. Related: OS#4006 Change-Id: Iadf2683d7f52138a2248598641f3b702252f325d --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 11 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/42/14642/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index a6a32f0..6e678ac 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -558,6 +558,7 @@ float toa, max = -1.0, avg = 0.0; int max_i = -1; signalVector *burst; + GSM::Time burstTime; TransceiverState *state = &mStates[chan]; /* Blocking FIFO read */ @@ -566,8 +567,10 @@ return false; /* Set time and determine correlation type */ - bi->burstTime = radio_burst->getTime(); - CorrType type = expectedCorrType(bi->burstTime, chan); + burstTime = radio_burst->getTime(); + bi->fn = burstTime.FN(); + bi->tn = burstTime.TN(); + CorrType type = expectedCorrType(burstTime, chan); /* Enable 8-PSK burst detection if EDGE is enabled */ if (mEdge && (type == TSC)) @@ -576,7 +579,7 @@ /* Debug: dump bursts to disk */ /* bits 0-7 - chan 0 timeslots * bits 8-15 - chan 1 timeslots */ - if (mWriteBurstToDiskMask & ((1<burstTime.TN()) << (8*chan))) + if (mWriteBurstToDiskMask & ((1<tn) << (8*chan))) writeToFile(radio_burst, chan); /* No processing if the timeslot is off. @@ -913,7 +916,7 @@ { LOG(DEBUG) << std::fixed << std::right << " chan: " << chan - << " time: " << bi->burstTime + << " time: " << bi->tn << ":" << bi->fn << " RSSI: " << std::setw(5) << std::setprecision(1) << (bi->rssi - rssiOffset) << "dBFS/" << std::setw(6) << -bi->rssi << "dBm" << " noise: " << std::setw(5) << std::setprecision(1) << (bi->noise - rssiOffset) @@ -939,8 +942,8 @@ struct trxd_hdr_v0* pkt = (struct trxd_hdr_v0*)burstString; pkt->common.version = 0; pkt->common.reserved = 0; - pkt->common.tn = bi.burstTime.TN(); - osmo_store32be(bi.burstTime.FN(), &pkt->common.fn); + pkt->common.tn = bi.tn; + osmo_store32be(bi.fn, &pkt->common.fn); pkt->v0.rssi = bi.rssi; osmo_store16be(TOAint, &pkt->v0.toa); SoftVector::iterator burstItr = bi.rxBurst->begin(); diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index 7963519..9975823 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -38,7 +38,8 @@ struct trx_ul_burst_ind { SoftVector *rxBurst; unsigned nbits; // number of symbols per slot in rxBurst, not counting guard periods - GSM::Time burstTime; + uint32_t fn; // TDMA frame number + uint8_t tn; // TDMA time-slot number double rssi; // in dBFS double toa; // in symbols double noise; // noise level in dBFS -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iadf2683d7f52138a2248598641f3b702252f325d Gerrit-Change-Number: 14642 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 19:09:13 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 19:09:13 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind ...................................................................... Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind Make the interface using trx_ul_burst_ind more implementation agnostic as well as easier to use. For instance, we don't care about SoftVector size one returned from pullRadioVector(); we want to use nbits instead. As a result, we no longer spend time normalizing guard periods. While at it, change vectorSLicer to return void since it always returns true. Change-Id: I726e5a98a43367a22c9a4ca5cbd9eb87e6765c7a --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h M Transceiver52M/sigProcLib.cpp M Transceiver52M/sigProcLib.h 4 files changed, 29 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/43/14643/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 6e678ac..4fc277b 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -559,6 +559,7 @@ int max_i = -1; signalVector *burst; GSM::Time burstTime; + SoftVector *rxBurst; TransceiverState *state = &mStates[chan]; /* Blocking FIFO read */ @@ -644,17 +645,18 @@ } bi->toa = toa; - bi->rxBurst = demodAnyBurst(*burst, mSPSRx, amp, toa, type); + rxBurst = demodAnyBurst(*burst, mSPSRx, amp, toa, type); /* EDGE demodulator returns 444 (gSlotLen * 3) bits */ - if (bi->rxBurst->size() == EDGE_BURST_NBITS) + if (rxBurst->size() == EDGE_BURST_NBITS) bi->nbits = EDGE_BURST_NBITS; else /* size() here is actually gSlotLen + 8, due to guard periods */ bi->nbits = gSlotLen; // Convert -1..+1 soft bits to 0..1 soft bits - vectorSlicer(bi->rxBurst); + vectorSlicer(bi->rx_burst, rxBurst->begin(), bi->nbits); + delete rxBurst; delete radio_burst; return true; } @@ -914,6 +916,14 @@ void Transceiver::logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi) { + std::ostringstream os; + for (size_t i=0; i < bi->nbits; i++) { + if (bi->rx_burst[i] > 0.5) os << "1"; + else if (bi->rx_burst[i] > 0.25) os << "|"; + else if (bi->rx_burst[i] > 0.0) os << "'"; + else os << "-"; + } + LOG(DEBUG) << std::fixed << std::right << " chan: " << chan << " time: " << bi->tn << ":" << bi->fn @@ -922,7 +932,7 @@ << " noise: " << std::setw(5) << std::setprecision(1) << (bi->noise - rssiOffset) << "dBFS/" << std::setw(6) << -bi->noise << "dBm" << " TOA: " << std::setw(5) << std::setprecision(2) << bi->toa - << " bits: " << *(bi->rxBurst); + << " bits: " << os; } void Transceiver::driveReceiveFIFO(size_t chan) @@ -946,14 +956,12 @@ osmo_store32be(bi.fn, &pkt->common.fn); pkt->v0.rssi = bi.rssi; osmo_store16be(TOAint, &pkt->v0.toa); - SoftVector::iterator burstItr = bi.rxBurst->begin(); for (unsigned i = 0; i < bi.nbits; i++) - pkt->soft_bits[i] = (char) round((*burstItr++) * 255.0); + pkt->soft_bits[i] = (char) round(bi.rx_burst[i] * 255.0); /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi.nbits] */ pkt->soft_bits[bi.nbits + 1] = '\0'; - delete bi.rxBurst; mDataSockets[chan]->write(burstString, sizeof(struct trxd_hdr_v0) + bi.nbits + 2); } diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index 9975823..80047b3 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -35,8 +35,10 @@ #include "config_defs.h" } +#define MAX_RX_BURST_BUF_SIZE EDGE_BURST_NBITS + struct trx_ul_burst_ind { - SoftVector *rxBurst; + float rx_burst[MAX_RX_BURST_BUF_SIZE]; /* soft bits normalized 0..1 */ unsigned nbits; // number of symbols per slot in rxBurst, not counting guard periods uint32_t fn; // TDMA frame number uint8_t tn; // TDMA time-slot number diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp index fcda5fa..cff7825 100644 --- a/Transceiver52M/sigProcLib.cpp +++ b/Transceiver52M/sigProcLib.cpp @@ -530,19 +530,17 @@ return pulse; } -bool vectorSlicer(SoftVector *x) +/* Convert -1..+1 soft bits to 0..1 soft bits */ +void vectorSlicer(float *dest, const float *src, size_t len) { - SoftVector::iterator xP = x->begin(); - SoftVector::iterator xPEnd = x->end(); - while (xP < xPEnd) { - *xP = 0.5 * (*xP + 1.0f); - if (*xP > 1.0) - *xP = 1.0; - if (*xP < 0.0) - *xP = 0.0; - xP++; - } - return true; + size_t i; + for (i = 0; i < len; i++) { + dest[i] = 0.5 * (src[i] + 1.0f); + if (dest[i] > 1.0) + dest[i] = 1.0; + else if (dest[i] < 0.0) + dest[i] = 0.0; + } } static signalVector *rotateBurst(const BitVector &wBurst, diff --git a/Transceiver52M/sigProcLib.h b/Transceiver52M/sigProcLib.h index 79a5c3f..bae2127 100644 --- a/Transceiver52M/sigProcLib.h +++ b/Transceiver52M/sigProcLib.h @@ -59,7 +59,7 @@ void sigProcLibDestroy(void); /** Operate soft slicer on a soft-bit vector */ -bool vectorSlicer(SoftVector *x); +void vectorSlicer(float *dest, const float *src, size_t len); /** GMSK modulate a GSM burst of bits */ signalVector *modulateBurst(const BitVector &wBurst, -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I726e5a98a43367a22c9a4ca5cbd9eb87e6765c7a Gerrit-Change-Number: 14643 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 19:09:14 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 19:09:14 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 Change subject: Transceiver: replace UDPSocket with libosmocore socket API ...................................................................... Transceiver: replace UDPSocket with libosmocore socket API We have a good socket API in libosmocore, let's drop osmo-trx socket API and use libosmocore's one insteadi of maintaining the two of them. Change-Id: Ib19856a3e0a7607f63436c4a80b1381a3f318764 --- M CommonLibs/Makefile.am D CommonLibs/Sockets.cpp D CommonLibs/Sockets.h M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h M tests/CommonLibs/Makefile.am D tests/CommonLibs/SocketsTest.cpp D tests/CommonLibs/SocketsTest.ok M tests/testsuite.at 9 files changed, 53 insertions(+), 594 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/44/14644/1 diff --git a/CommonLibs/Makefile.am b/CommonLibs/Makefile.am index 22572e1..2c449e0 100644 --- a/CommonLibs/Makefile.am +++ b/CommonLibs/Makefile.am @@ -30,7 +30,6 @@ libcommon_la_SOURCES = \ BitVector.cpp \ LinkedLists.cpp \ - Sockets.cpp \ Threads.cpp \ Timeval.cpp \ Logger.cpp \ @@ -45,7 +44,6 @@ PRBS.h \ Interthread.h \ LinkedLists.h \ - Sockets.h \ Threads.h \ Timeval.h \ Vector.h \ diff --git a/CommonLibs/Sockets.cpp b/CommonLibs/Sockets.cpp deleted file mode 100644 index ce8e3d5..0000000 --- a/CommonLibs/Sockets.cpp +++ /dev/null @@ -1,287 +0,0 @@ -/* -* Copyright 2008, 2010 Free Software Foundation, Inc. -* -* -* This software is distributed under the terms of the GNU Affero Public License. -* See the COPYING file in the main directory for details. -* -* This use of this software may be subject to additional restrictions. -* See the LEGAL file in the main directory for details. - - This program is free software: you can redistribute it and/or modify - it under the terms of the GNU Affero General Public License as published by - the Free Software Foundation, either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU Affero General Public License for more details. - - You should have received a copy of the GNU Affero General Public License - along with this program. If not, see . - -*/ - - - -#include -#include -#include -#include -#include - -#include "Threads.h" -#include "Sockets.h" -#include -#include -#include - -#include -#include - - - - - - -bool resolveAddress(struct sockaddr_in *address, const char *hostAndPort) -{ - assert(address); - assert(hostAndPort); - char *copy = strdup(hostAndPort); - char *colon = strchr(copy,':'); - if (!colon) return false; - *colon = '\0'; - char *host = copy; - unsigned port = strtol(colon+1,NULL,10); - bool retVal = resolveAddress(address,host,port); - free(copy); - return retVal; -} - -bool resolveAddress(struct sockaddr_in *address, const char *host, unsigned short port) -{ - assert(address); - assert(host); - // FIXME -- Need to ignore leading/trailing spaces in hostname. - struct hostent *hp; - int h_errno_local; -#ifdef HAVE_GETHOSTBYNAME2_R - struct hostent hostData; - char tmpBuffer[2048]; - - // There are different flavors of gethostbyname_r(), but - // latest Linux use the following form: - if (gethostbyname2_r(host, AF_INET, &hostData, tmpBuffer, sizeof(tmpBuffer), &hp, &h_errno_local)!=0) { - CERR("WARNING -- gethostbyname2_r() failed for " << host << ", " << hstrerror(h_errno_local)); - return false; - } -#else - static Mutex sGethostbynameMutex; - // gethostbyname() is NOT thread-safe, so we should use a mutex here. - // Ideally it should be a global mutex for all non thread-safe socket - // operations and it should protect access to variables such as - // global h_errno. - sGethostbynameMutex.lock(); - hp = gethostbyname(host); - h_errno_local = h_errno; - sGethostbynameMutex.unlock(); -#endif - if (hp==NULL) { - CERR("WARNING -- gethostbyname() failed for " << host << ", " << hstrerror(h_errno_local)); - return false; - } - if (hp->h_addrtype != AF_INET) { - CERR("WARNING -- gethostbyname() resolved " << host << " to something other then AF_INET"); - return false; - } - address->sin_family = hp->h_addrtype; - assert(sizeof(address->sin_addr) == hp->h_length); - memcpy(&(address->sin_addr), hp->h_addr_list[0], hp->h_length); - address->sin_port = htons(port); - return true; -} - - - -DatagramSocket::DatagramSocket() -{ - memset(mDestination, 0, sizeof(mDestination)); -} - - - - - -void DatagramSocket::nonblocking() -{ - fcntl(mSocketFD,F_SETFL,O_NONBLOCK); -} - -void DatagramSocket::blocking() -{ - fcntl(mSocketFD,F_SETFL,0); -} - -void DatagramSocket::close() -{ - ::close(mSocketFD); -} - - -DatagramSocket::~DatagramSocket() -{ - close(); -} - - - - - -int DatagramSocket::write( const char * message, size_t length ) -{ - assert(length<=MAX_UDP_LENGTH); - int retVal = sendto(mSocketFD, message, length, 0, - (struct sockaddr *)mDestination, addressSize()); - if (retVal == -1 ) perror("DatagramSocket::write() failed"); - return retVal; -} - -int DatagramSocket::writeBack( const char * message, size_t length ) -{ - assert(length<=MAX_UDP_LENGTH); - int retVal = sendto(mSocketFD, message, length, 0, - (struct sockaddr *)mSource, addressSize()); - if (retVal == -1 ) perror("DatagramSocket::write() failed"); - return retVal; -} - - - -int DatagramSocket::write( const char * message) -{ - size_t length=strlen(message)+1; - return write(message,length); -} - -int DatagramSocket::writeBack( const char * message) -{ - size_t length=strlen(message)+1; - return writeBack(message,length); -} - - - -int DatagramSocket::send(const struct sockaddr* dest, const char * message, size_t length ) -{ - assert(length<=MAX_UDP_LENGTH); - int retVal = sendto(mSocketFD, message, length, 0, dest, addressSize()); - if (retVal == -1 ) perror("DatagramSocket::send() failed"); - return retVal; -} - -int DatagramSocket::send(const struct sockaddr* dest, const char * message) -{ - size_t length=strlen(message)+1; - return send(dest,message,length); -} - -int DatagramSocket::read(char* buffer, size_t length) -{ - socklen_t addr_len = sizeof(mSource); - int rd_length = recvfrom(mSocketFD, (void *) buffer, length, 0, - (struct sockaddr*) &mSource, &addr_len); - - if ((rd_length==-1) && (errno!=EAGAIN)) { - perror("DatagramSocket::read() failed"); - throw SocketError(); - } - return rd_length; -} - -int DatagramSocket::read(char* buffer, size_t length, unsigned timeout) -{ - fd_set fds; - FD_ZERO(&fds); - FD_SET(mSocketFD,&fds); - struct timeval tv; - tv.tv_sec = timeout/1000; - tv.tv_usec = (timeout%1000)*1000; - int sel = select(mSocketFD+1,&fds,NULL,NULL,&tv); - if (sel<0) { - perror("DatagramSocket::read() select() failed"); - throw SocketError(); - } - if (sel==0) return -1; - if (FD_ISSET(mSocketFD,&fds)) return read(buffer, length); - return -1; -} - - - - - - -UDPSocket::UDPSocket(const char *wSrcIP, unsigned short wSrcPort) - :DatagramSocket() -{ - open(wSrcPort, wSrcIP); -} - - -UDPSocket::UDPSocket(const char *wSrcIP, unsigned short wSrcPort, - const char *wDestIP, unsigned short wDestPort) - :DatagramSocket() -{ - open(wSrcPort, wSrcIP); - destination(wDestPort, wDestIP); -} - - - -void UDPSocket::destination( unsigned short wDestPort, const char * wDestIP ) -{ - resolveAddress((sockaddr_in*)mDestination, wDestIP, wDestPort ); -} - - -void UDPSocket::open(unsigned short localPort, const char *wlocalIP) -{ - // create - mSocketFD = socket(AF_INET,SOCK_DGRAM,0); - if (mSocketFD<0) { - perror("socket() failed"); - throw SocketError(); - } - - // pat added: This lets the socket be reused immediately, which is needed if OpenBTS crashes. - int on = 1; - setsockopt(mSocketFD, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)); - - - // bind - struct sockaddr_in address; - size_t length = sizeof(address); - bzero(&address,length); - address.sin_family = AF_INET; - address.sin_addr.s_addr = inet_addr(wlocalIP); - address.sin_port = htons(localPort); - if (bind(mSocketFD,(struct sockaddr*)&address,length)<0) { - perror("bind() failed"); - throw SocketError(); - } -} - - - -unsigned short UDPSocket::port() const -{ - struct sockaddr_in name; - socklen_t nameSize = sizeof(name); - int retVal = getsockname(mSocketFD, (struct sockaddr*)&name, &nameSize); - if (retVal==-1) throw SocketError(); - return ntohs(name.sin_port); -} - -// vim:ts=4:sw=4 diff --git a/CommonLibs/Sockets.h b/CommonLibs/Sockets.h deleted file mode 100644 index 71b8b22..0000000 --- a/CommonLibs/Sockets.h +++ /dev/null @@ -1,173 +0,0 @@ -/* -* Copyright 2008, 2010 Free Software Foundation, Inc. -* -* This software is distributed under the terms of the GNU Affero Public License. -* See the COPYING file in the main directory for details. -* -* This use of this software may be subject to additional restrictions. -* See the LEGAL file in the main directory for details. - - This program is free software: you can redistribute it and/or modify - it under the terms of the GNU Affero General Public License as published by - the Free Software Foundation, either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU Affero General Public License for more details. - - You should have received a copy of the GNU Affero General Public License - along with this program. If not, see . - -*/ - - -#ifndef SOCKETS_H -#define SOCKETS_H - -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - - - - - -#define MAX_UDP_LENGTH 1500 - -/** A function to resolve IP host names. */ -bool resolveAddress(struct sockaddr_in *address, const char *host, unsigned short port); - -/** Resolve an address of the form ":". */ -bool resolveAddress(struct sockaddr_in *address, const char *hostAndPort); - -/** An exception to throw when a critical socket operation fails. */ -class SocketError {}; -#define SOCKET_ERROR {throw SocketError(); } - -/** Abstract class for connectionless sockets. */ -class DatagramSocket { - -protected: - - int mSocketFD; ///< underlying file descriptor - char mDestination[256]; ///< address to which packets are sent - char mSource[256]; ///< return address of most recent received packet - -public: - - /** An almost-does-nothing constructor. */ - DatagramSocket(); - - virtual ~DatagramSocket(); - - /** Return the address structure size for this socket type. */ - virtual size_t addressSize() const = 0; - - /** - Send a binary packet. - @param buffer The data bytes to send to mDestination. - @param length Number of bytes to send, or strlen(buffer) if defaulted to -1. - @return number of bytes written, or -1 on error. - */ - int write( const char * buffer, size_t length); - - /** - Send a C-style string packet. - @param buffer The data bytes to send to mDestination. - @return number of bytes written, or -1 on error. - */ - int write( const char * buffer); - - /** - Send a binary packet. - @param buffer The data bytes to send to mSource. - @param length Number of bytes to send, or strlen(buffer) if defaulted to -1. - @return number of bytes written, or -1 on error. - */ - int writeBack(const char * buffer, size_t length); - - /** - Send a C-style string packet. - @param buffer The data bytes to send to mSource. - @return number of bytes written, or -1 on error. - */ - int writeBack(const char * buffer); - - - /** - Receive a packet. - @param buffer A char[MAX_UDP_LENGTH] procured by the caller. - @return The number of bytes received or -1 on non-blocking pass. - */ - int read(char* buffer, size_t length); - - /** - Receive a packet with a timeout. - @param buffer A char[MAX_UDP_LENGTH] procured by the caller. - @param maximum wait time in milliseconds - @return The number of bytes received or -1 on timeout. - */ - int read(char* buffer, size_t length, unsigned timeout); - - - /** Send a packet to a given destination, other than the default. */ - int send(const struct sockaddr *dest, const char * buffer, size_t length); - - /** Send a C-style string to a given destination, other than the default. */ - int send(const struct sockaddr *dest, const char * buffer); - - /** Make the socket non-blocking. */ - void nonblocking(); - - /** Make the socket blocking (the default). */ - void blocking(); - - /** Close the socket. */ - void close(); - -}; - - - -/** UDP/IP User Datagram Socket */ -class UDPSocket : public DatagramSocket { - -public: - - /** Open a USP socket with an OS-assigned port and no default destination. */ - UDPSocket(const char *localIP, unsigned short localPort); - - /** Given a full specification, open the socket and set the dest address. */ - UDPSocket(const char *localIP, unsigned short localPort, - const char *remoteIP, unsigned short remotePort); - - /** Set the destination port. */ - void destination( unsigned short wDestPort, const char * wDestIP ); - - /** Return the actual port number in use. */ - unsigned short port() const; - - /** Open and bind the UDP socket to a local port. */ - void open(unsigned short localPort=0, const char *wlocalIP="127.0.0.1"); - - /** Give the return address of the most recently received packet. */ - const struct sockaddr_in* source() const { return (const struct sockaddr_in*)mSource; } - - size_t addressSize() const { return sizeof(struct sockaddr_in); } - -}; - -#endif - - - -// vim:ts=4:sw=4 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 4fc277b..58e8719 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -32,6 +32,7 @@ #include "proto_trxd.h" #include +#include } #ifdef HAVE_CONFIG_H @@ -120,8 +121,7 @@ RadioInterface *wRadioInterface, double wRssiOffset, int wStackSize) : mBasePort(wBasePort), mLocalAddr(TRXAddress), mRemoteAddr(GSMcoreAddress), - mClockSocket(TRXAddress, wBasePort, GSMcoreAddress, wBasePort + 100), - mTransmitLatency(wTransmitLatency), mRadioInterface(wRadioInterface), + mClockSocket(-1), mTransmitLatency(wTransmitLatency), mRadioInterface(wRadioInterface), rssiOffset(wRssiOffset), stackSize(wStackSize), mSPSTx(tx_sps), mSPSRx(rx_sps), mChans(chans), mEdge(false), mOn(false), mForceClockInterface(false), mTxFreq(0.0), mRxFreq(0.0), mTSC(0), mMaxExpectedDelayAB(0), mMaxExpectedDelayNB(0), @@ -142,14 +142,19 @@ sigProcLibDestroy(); + if (mClockSocket >= 0) + close(mClockSocket); + for (size_t i = 0; i < mChans; i++) { mControlServiceLoopThreads[i]->cancel(); mControlServiceLoopThreads[i]->join(); delete mControlServiceLoopThreads[i]; mTxPriorityQueues[i].clear(); - delete mCtrlSockets[i]; - delete mDataSockets[i]; + if (mCtrlSockets[i] >= 0) + close(mCtrlSockets[i]); + if (mDataSockets[i] >= 0) + close(mDataSockets[i]); } } @@ -180,8 +185,8 @@ mExtRACH = ext_rach; mEdge = edge; - mDataSockets.resize(mChans); - mCtrlSockets.resize(mChans); + mDataSockets.resize(mChans, -1); + mCtrlSockets.resize(mChans, -1); mControlServiceLoopThreads.resize(mChans); mTxPriorityQueueServiceLoopThreads.resize(mChans); mRxServiceLoopThreads.resize(mChans); @@ -195,14 +200,30 @@ mStates[0].mRetrans = true; /* Setup sockets */ + mClockSocket = osmo_sock_init2(AF_UNSPEC, SOCK_DGRAM, IPPROTO_UDP, + mLocalAddr.c_str(), mBasePort, + mRemoteAddr.c_str(), mBasePort + 100, + OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT); + for (size_t i = 0; i < mChans; i++) { c_srcport = mBasePort + 2 * i + 1; c_dstport = mBasePort + 2 * i + 101; d_srcport = mBasePort + 2 * i + 2; d_dstport = mBasePort + 2 * i + 102; - mCtrlSockets[i] = new UDPSocket(mLocalAddr.c_str(), c_srcport, mRemoteAddr.c_str(), c_dstport); - mDataSockets[i] = new UDPSocket(mLocalAddr.c_str(), d_srcport, mRemoteAddr.c_str(), d_dstport); + mCtrlSockets[i] = osmo_sock_init2(AF_UNSPEC, SOCK_DGRAM, IPPROTO_UDP, + mLocalAddr.c_str(), c_srcport, + mRemoteAddr.c_str(), c_dstport, + OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT); + if (mCtrlSockets[i] < 0) + return false; + + mDataSockets[i] = osmo_sock_init2(AF_UNSPEC, SOCK_DGRAM, IPPROTO_UDP, + mLocalAddr.c_str(), d_srcport, + mRemoteAddr.c_str(), d_dstport, + OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT); + if (mCtrlSockets[i] < 0) + return false; } /* Randomize the central clock */ @@ -707,9 +728,11 @@ int msgLen; /* Attempt to read from control socket */ - msgLen = mCtrlSockets[chan]->read(buffer, MAX_PACKET_LENGTH); - if (msgLen < 1) + msgLen = read(mCtrlSockets[chan], buffer, MAX_PACKET_LENGTH); + if (msgLen <= 0) { + LOGCHAN(chan, DTRXCTRL, WARNING) << "mCtrlSockets read(" << mCtrlSockets[chan] << ") failed: " << msgLen; return; + } /* Zero-terminate received string */ buffer[msgLen] = '\0'; @@ -854,16 +877,23 @@ } LOGCHAN(chan, DTRXCTRL, INFO) << "response is '" << response << "'"; - mCtrlSockets[chan]->write(response, strlen(response) + 1); + msgLen = write(mCtrlSockets[chan], response, strlen(response) + 1); + if (msgLen <= 0) + LOGCHAN(chan, DTRXCTRL, WARNING) << "mCtrlSockets write(" << mCtrlSockets[chan] << ") failed: " << msgLen; } bool Transceiver::driveTxPriorityQueue(size_t chan) { + int msgLen; int burstLen; char buffer[EDGE_BURST_NBITS + 50]; // check data socket - size_t msgLen = mDataSockets[chan]->read(buffer, sizeof(buffer)); + msgLen = read(mDataSockets[chan], buffer, sizeof(buffer)); + if (msgLen <= 0) { + LOGCHAN(chan, DTRXCTRL, WARNING) << "mDataSockets read(" << mCtrlSockets[chan] << ") failed: " << msgLen; + return false; + } if (msgLen == gSlotLen + 1 + 4 + 1) { burstLen = gSlotLen; @@ -937,6 +967,7 @@ void Transceiver::driveReceiveFIFO(size_t chan) { + int msgLen; int TOAint; // in 1/256 symbols struct trx_ul_burst_ind bi; @@ -963,7 +994,9 @@ /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi.nbits] */ pkt->soft_bits[bi.nbits + 1] = '\0'; - mDataSockets[chan]->write(burstString, sizeof(struct trxd_hdr_v0) + bi.nbits + 2); + msgLen = write(mDataSockets[chan], burstString, sizeof(struct trxd_hdr_v0) + bi.nbits + 2); + if (msgLen <= 0) + LOGCHAN(chan, DTRXCTRL, WARNING) << "mDataSockets write(" << mCtrlSockets[chan] << ") failed: " << msgLen; } void Transceiver::driveTxFIFO() @@ -1023,13 +1056,16 @@ void Transceiver::writeClockInterface() { + int msgLen; char command[50]; // FIXME -- This should be adaptive. sprintf(command,"IND CLOCK %llu",(unsigned long long) (mTransmitDeadlineClock.FN()+2)); LOG(INFO) << "ClockInterface: sending " << command; - mClockSocket.write(command, strlen(command) + 1); + msgLen = write(mClockSocket, command, strlen(command) + 1); + if (msgLen <= 0) + LOG(WARNING) << "mClockSocket write(" << mClockSocket << ") failed: " << msgLen; mLastClockUpdateTime = mTransmitDeadlineClock; diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index 80047b3..cca9b41 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -25,7 +25,6 @@ #include "radioInterface.h" #include "Interthread.h" #include "GSMCommon.h" -#include "Sockets.h" #include #include @@ -167,9 +166,9 @@ std::string mLocalAddr; std::string mRemoteAddr; - std::vector mDataSockets; ///< socket for writing to/reading from GSM core - std::vector mCtrlSockets; ///< socket for writing/reading control commands from GSM core - UDPSocket mClockSocket; ///< socket for writing clock updates to GSM core + std::vector mDataSockets; ///< socket for writing to/reading from GSM core + std::vector mCtrlSockets; ///< socket for writing/reading control commands from GSM core + int mClockSocket; ///< socket for writing clock updates to GSM core std::vector mTxPriorityQueues; ///< priority queue of transmit bursts received from GSM core std::vector mReceiveFIFO; ///< radioInterface FIFO of receive bursts diff --git a/tests/CommonLibs/Makefile.am b/tests/CommonLibs/Makefile.am index 2a9a021..26b49e2 100644 --- a/tests/CommonLibs/Makefile.am +++ b/tests/CommonLibs/Makefile.am @@ -6,7 +6,6 @@ EXTRA_DIST = BitVectorTest.ok \ PRBSTest.ok \ InterthreadTest.ok \ - SocketsTest.ok \ TimevalTest.ok \ VectorTest.ok \ LogTest.ok \ @@ -16,7 +15,6 @@ BitVectorTest \ PRBSTest \ InterthreadTest \ - SocketsTest \ TimevalTest \ VectorTest \ LogTest @@ -30,10 +28,6 @@ InterthreadTest_LDADD = $(COMMON_LA) InterthreadTest_LDFLAGS = -lpthread $(AM_LDFLAGS) -SocketsTest_SOURCES = SocketsTest.cpp -SocketsTest_LDADD = $(COMMON_LA) -SocketsTest_LDFLAGS = -lpthread $(AM_LDFLAGS) - TimevalTest_SOURCES = TimevalTest.cpp TimevalTest_LDADD = $(COMMON_LA) diff --git a/tests/CommonLibs/SocketsTest.cpp b/tests/CommonLibs/SocketsTest.cpp deleted file mode 100644 index e4eef54..0000000 --- a/tests/CommonLibs/SocketsTest.cpp +++ /dev/null @@ -1,101 +0,0 @@ -/* -* Copyright 2008 Free Software Foundation, Inc. -* -* -* This software is distributed under the terms of the GNU Affero Public License. -* See the COPYING file in the main directory for details. -* -* This use of this software may be subject to additional restrictions. -* See the LEGAL file in the main directory for details. - - This program is free software: you can redistribute it and/or modify - it under the terms of the GNU Affero General Public License as published by - the Free Software Foundation, either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU Affero General Public License for more details. - - You should have received a copy of the GNU Affero General Public License - along with this program. If not, see . - -*/ - - - - -#include "Sockets.h" -#include "Threads.h" -#include -#include -#include -#include - -static const int gNumToSend = 10; - -static void sigalarm_handler(int foo) -{ - printf("FAIL: test did not run successfully\n"); - exit(EXIT_FAILURE); -} - -void *testReaderIP(void *param) -{ - UDPSocket *readSocket = (UDPSocket *)param; - readSocket->nonblocking(); - int rc = 0; - while (rcread(buf, MAX_UDP_LENGTH); - if (count>0) { - buf[count] = 0; - CERR("read: " << buf); - rc++; - } else { - sleep(2); - } - } - return NULL; -} - -int main(int argc, char * argv[] ) -{ - int count; - - if (signal(SIGALRM, sigalarm_handler) == SIG_ERR) { - perror("signal"); - exit(EXIT_FAILURE); - } - - /* If the test takes longer than 2*gNumToSend seconds, abort it */ - alarm(2* gNumToSend); - - UDPSocket readSocket("127.0.0.1", 0); - UDPSocket socket1("127.0.0.1", 0, "localhost", readSocket.port()); - - CERR("socket1: " << socket1.port() << ", readSocket: " << readSocket.port()); - - Thread readerThreadIP; - readerThreadIP.start(testReaderIP, &readSocket); - - // give the readers time to open - sleep(1); - - for (int i=0; i expout -AT_CHECK([$abs_top_builddir/tests/CommonLibs/SocketsTest], [], [expout], [ignore]) -AT_CLEANUP - AT_SETUP([TimevalTest]) AT_KEYWORDS([TimevalTest]) cat $abs_srcdir/CommonLibs/TimevalTest.ok > expout -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib19856a3e0a7607f63436c4a80b1381a3f318764 Gerrit-Change-Number: 14644 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 19:09:14 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 19:09:14 +0000 Subject: Change in ...osmo-trx[master]: Logger: global Log mutex is now available from C code Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14645 Change subject: Logger: global Log mutex is now available from C code ...................................................................... Logger: global Log mutex is now available from C code This way the C++ logging API can still be used while allowing for C files to use the same mutex. Change-Id: I473e57479f8ae98a84ad00b76ff338f79f732236 --- M CommonLibs/Logger.cpp M CommonLibs/debug.c M CommonLibs/debug.h M Transceiver52M/osmo-trx.cpp 4 files changed, 79 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/45/14645/1 diff --git a/CommonLibs/Logger.cpp b/CommonLibs/Logger.cpp index 171c635..f68fab5 100644 --- a/CommonLibs/Logger.cpp +++ b/CommonLibs/Logger.cpp @@ -35,8 +35,6 @@ using namespace std; -Mutex gLogToLock; - std::ostream& operator<<(std::ostream& os, std::ostringstream& ss) { return os << ss.str(); @@ -45,15 +43,13 @@ Log::~Log() { int old_state; - pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_state); int mlen = mStream.str().size(); int neednl = (mlen==0 || mStream.str()[mlen-1] != '\n'); const char *fmt = neednl ? "%s\n" : "%s"; - ScopedLock lock(gLogToLock); - // The COUT() macro prevents messages from stomping each other but adds uninteresting thread numbers, - // so just use std::cout. + + log_mutex_lock_canceldisable(&old_state); LOGPSRC(mCategory, mPriority, filename, line, fmt, mStream.str().c_str()); - pthread_setcancelstate(old_state, NULL); + log_mutex_unlock_canceldisable(old_state); } ostringstream& Log::get() diff --git a/CommonLibs/debug.c b/CommonLibs/debug.c index 294924d..17ef5bc 100644 --- a/CommonLibs/debug.c +++ b/CommonLibs/debug.c @@ -1,3 +1,5 @@ +#include + #include #include #include "debug.h" @@ -34,3 +36,49 @@ .cat = default_categories, .num_cat = ARRAY_SIZE(default_categories), }; + +pthread_mutex_t log_mutex; + +bool log_mutex_init() { + int rc; + pthread_mutexattr_t attr; + + if ((rc = pthread_mutexattr_init(&attr))) { + fprintf(stderr, "pthread_mutexattr_init() failed: %d\n", rc); + return false; + } + if ((rc = pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE))) { + fprintf(stderr, "pthread_mutexattr_settype() failed: %d\n", rc); + return false; + } + if ((rc = pthread_mutex_init(&log_mutex, &attr))) { + fprintf(stderr, "pthread_mutex_init() failed: %d\n", rc); + return false; + } + if ((rc = pthread_mutexattr_destroy(&attr))) { + fprintf(stderr, "pthread_mutexattr_destroy() failed: %d\n", rc); + return false; + } + return true; + /* FIXME: do we need to call pthread_mutex_destroy() during process exit? */ +} + +/* If called inside a C++ destructor, use log_mutex_(un)lock_canceldisable() APIs instead. + See osmo-trx commit 86be40b4eb762d5c12e8e3f7388ca9f254e77b36 for more information */ +void log_mutex_lock() { + OSMO_ASSERT(!pthread_mutex_lock(&log_mutex)); +} + +void log_mutex_unlock() { + OSMO_ASSERT(!pthread_mutex_unlock(&log_mutex)); +} + +void log_mutex_lock_canceldisable(int *st) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, st); + log_mutex_lock(); +} + +void log_mutex_unlock_canceldisable(int st) { + log_mutex_unlock(); + pthread_setcancelstate(st, NULL); +} diff --git a/CommonLibs/debug.h b/CommonLibs/debug.h index a5b9271..760ab32 100644 --- a/CommonLibs/debug.h +++ b/CommonLibs/debug.h @@ -1,5 +1,10 @@ #pragma once +#include +#include + +#include + extern const struct log_info log_info; /* Debug Areas of the code */ @@ -9,3 +14,22 @@ DDEV, DLMS, }; + + +bool log_mutex_init(); +void log_mutex_lock(); +void log_mutex_unlock(); +void log_mutex_lock_canceldisable(int *st); +void log_mutex_unlock_canceldisable(int st); + +#define CLOGC(category, level, fmt, args...) do { \ + log_mutex_lock(); \ + LOGP(category, level, "[tid=%lu] " fmt, pthread_self(), ##args); \ + log_mutex_unlock(); \ +} while(0) + +#define CLOGCHAN(chan, category, level, fmt, args...) do { \ + log_mutex_lock(); \ + LOGP(category, level, "[tid=%lu][chan=%lu] " fmt, pthread_self(), chan, ##args); \ + log_mutex_unlock(); \ +} while(0) diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index 06b1a18..6cbd243 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -569,6 +569,10 @@ #endif #endif + if (!log_mutex_init()) { + fprintf(stderr, "Failed to initialize log mutex!\n"); + exit(2); + } convolve_init(); convert_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I473e57479f8ae98a84ad00b76ff338f79f732236 Gerrit-Change-Number: 14645 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 19:09:15 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 19:09:15 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support SETFORMAT command Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14646 Change subject: Transceiver: Support SETFORMAT command ...................................................................... Transceiver: Support SETFORMAT command Only old v0 is supported so far. TRXD protocol related data/logic is moved to its own file out of Transceiver class. Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed --- M Transceiver52M/Makefile.am M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h A Transceiver52M/proto_trxd.c M Transceiver52M/proto_trxd.h 5 files changed, 100 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/46/14646/1 diff --git a/Transceiver52M/Makefile.am b/Transceiver52M/Makefile.am index 4adf474..791c586 100644 --- a/Transceiver52M/Makefile.am +++ b/Transceiver52M/Makefile.am @@ -47,7 +47,8 @@ Transceiver.cpp \ ChannelizerBase.cpp \ Channelizer.cpp \ - Synthesis.cpp + Synthesis.cpp \ + proto_trxd.c libtransceiver_common_la_SOURCES = \ $(COMMON_SOURCES) \ diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 300ce46..b8094bd 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -31,7 +31,7 @@ #include "osmo_signal.h" #include "proto_trxd.h" -#include +#include #include } @@ -125,7 +125,7 @@ rssiOffset(wRssiOffset), stackSize(wStackSize), mSPSTx(tx_sps), mSPSRx(rx_sps), mChans(chans), mEdge(false), mOn(false), mForceClockInterface(false), mTxFreq(0.0), mRxFreq(0.0), mTSC(0), mMaxExpectedDelayAB(0), mMaxExpectedDelayNB(0), - mWriteBurstToDiskMask(0) + mWriteBurstToDiskMask(0), mVersionTRXD(0) { txFullScale = mRadioInterface->fullScaleInputValue(); rxFullScale = mRadioInterface->fullScaleOutputValue(); @@ -864,6 +864,18 @@ mStates[chan].chanType[timeslot] = (ChannelCombination) corrCode; setModulus(timeslot, chan); sprintf(response,"RSP SETSLOT 0 %d %d",timeslot,corrCode); + } else if (match_cmd(command, "SETFORMAT", ¶ms)) { + // set TRXD protocol version + unsigned version_recv, version_used; + sscanf(params, "%u", &version_recv); + LOGC(DTRXCTRL, INFO) << "BTS requests TRXD version switch: " << version_recv; + if (version_recv > TRX_DATA_FORMAT_VER) + version_used = TRX_DATA_FORMAT_VER; + else + version_used = version_recv; + LOGC(DTRXCTRL, NOTICE) << "switching to TRXD version " << version_used; + mVersionTRXD = version_used; + sprintf(response,"RSP SETFORMAT %u %u", version_used, version_recv); } else if (match_cmd(command, "_SETBURSTTODISKMASK", ¶ms)) { // debug command! may change or disapear without notice // set a mask which bursts to dump to disk @@ -967,9 +979,6 @@ void Transceiver::driveReceiveFIFO(size_t chan) { - int msgLen; - int TOAint; // in 1/256 symbols - struct trx_ul_burst_ind bi; if (!pullRadioVector(chan, &bi)) @@ -977,23 +986,13 @@ logRxBurst(chan, &bi); - TOAint = (int) (bi.toa * 256.0 + 0.5); // round to closest integer - - char burstString[sizeof(struct trxd_hdr_v0) + bi.nbits]; - struct trxd_hdr_v0* pkt = (struct trxd_hdr_v0*)burstString; - pkt->common.version = 0; - pkt->common.reserved = 0; - pkt->common.tn = bi.tn; - osmo_store32be(bi.fn, &pkt->common.fn); - pkt->v0.rssi = bi.rssi; - osmo_store16be(TOAint, &pkt->v0.toa); - - for (unsigned i = 0; i < bi.nbits; i++) - pkt->soft_bits[i] = (char) round(bi.rx_burst[i] * 255.0); - - msgLen = write(mDataSockets[chan], burstString, sizeof(struct trxd_hdr_v0) + bi.nbits); - if (msgLen <= 0) - LOGCHAN(chan, DTRXCTRL, WARNING) << "mDataSockets write(" << mCtrlSockets[chan] << ") failed: " << msgLen; + switch (mVersionTRXD) { + case 0: + trxd_send_burst_ind_v0(chan, mDataSockets[chan], &bi); + break; + default: + OSMO_ASSERT(false); + } } void Transceiver::driveTxFIFO() diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index cca9b41..ea41f78 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -34,18 +34,6 @@ #include "config_defs.h" } -#define MAX_RX_BURST_BUF_SIZE EDGE_BURST_NBITS - -struct trx_ul_burst_ind { - float rx_burst[MAX_RX_BURST_BUF_SIZE]; /* soft bits normalized 0..1 */ - unsigned nbits; // number of symbols per slot in rxBurst, not counting guard periods - uint32_t fn; // TDMA frame number - uint8_t tn; // TDMA time-slot number - double rssi; // in dBFS - double toa; // in symbols - double noise; // noise level in dBFS -}; - class Transceiver; /** Channel descriptor for transceiver object and channel number pair */ @@ -228,6 +216,7 @@ unsigned mMaxExpectedDelayAB; ///< maximum expected time-of-arrival offset in GSM symbols for Access Bursts (RACH) unsigned mMaxExpectedDelayNB; ///< maximum expected time-of-arrival offset in GSM symbols for Normal Bursts unsigned mWriteBurstToDiskMask; ///< debug: bitmask to indicate which timeslots to dump to disk + unsigned mVersionTRXD; ///< Format version to use for TRXD protocol communication std::vector mStates; diff --git a/Transceiver52M/proto_trxd.c b/Transceiver52M/proto_trxd.c new file mode 100644 index 0000000..f29d6ee --- /dev/null +++ b/Transceiver52M/proto_trxd.c @@ -0,0 +1,52 @@ +/* + * Copyright (C) 2019 sysmocom - s.f.m.c. GmbH + * All Rights Reserved + * + * SPDX-License-Identifier: AGPL-3.0+ + * + * Author: Pau Espin Pedrol + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * See the COPYING file in the main directory for details. + */ + +#include "proto_trxd.h" + + +bool trxd_send_burst_ind_v0(size_t chan, int fd, const struct trx_ul_burst_ind *bi) { + int rc; + int toa_int; + + /* in 1/256 symbols, round to closest integer */ + toa_int = (int) (bi->toa * 256.0 + 0.5); + + char buf[sizeof(struct trxd_hdr_v0) + bi->nbits]; + struct trxd_hdr_v0* pkt = (struct trxd_hdr_v0*)buf; + pkt->common.version = 0; + pkt->common.reserved = 0; + pkt->common.tn = bi->tn; + osmo_store32be(bi->fn, &pkt->common.fn); + pkt->v0.rssi = bi->rssi; + osmo_store16be(toa_int, &pkt->v0.toa); + + for (unsigned i = 0; i < bi->nbits; i++) + pkt->soft_bits[i] = (char) round(bi->rx_burst[i] * 255.0); + + rc = write(fd, buf, sizeof(struct trxd_hdr_v0) + bi->nbits); + if (rc <= 0) { + CLOGCHAN(chan, DMAIN, LOGL_NOTICE, "mDataSockets write(%d) failed: %d\n", fd, rc); + return false; + } + return true; +} diff --git a/Transceiver52M/proto_trxd.h b/Transceiver52M/proto_trxd.h index 9da18db..ef34666 100644 --- a/Transceiver52M/proto_trxd.h +++ b/Transceiver52M/proto_trxd.h @@ -1,8 +1,32 @@ #pragma once #include +#include +#include +#include + +#include #include +#include "debug.h" + +#define MAX_RX_BURST_BUF_SIZE 444 /* 444 = EDGE_BURST_NBITS */ + +struct trx_ul_burst_ind { + float rx_burst[MAX_RX_BURST_BUF_SIZE]; /* soft bits normalized 0..1 */ + unsigned nbits; // number of symbols per slot in rxBurst, not counting guard periods + uint32_t fn; // TDMA frame number + uint8_t tn; // TDMA time-slot number + double rssi; // in dBFS + double toa; // in symbols + double noise; // noise level in dBFS +}; + +bool trxd_send_burst_ind_v0(size_t chan, int fd, const struct trx_ul_burst_ind *bi); + +/* The latest supported TRXD header format version */ +#define TRX_DATA_FORMAT_VER 0 + struct trxd_hdr_common { #if OSMO_IS_LITTLE_ENDIAN uint8_t tn:3, -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed Gerrit-Change-Number: 14646 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 1 19:09:34 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 1 Jul 2019 19:09:34 +0000 Subject: Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 ) Change subject: Introduce structs to encode TRXD packets ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb Gerrit-Change-Number: 14629 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 01 Jul 2019 19:09:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Tue Jul 2 02:40:30 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 02 Jul 2019 02:40:30 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1ac42f485b2_6eea925f418518a2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 512s] | This file was extended by libosmocore config.status 1.1.0.75-316d, which was [ 512s] | generated by GNU Autoconf 2.69. Invocation command line was [ 512s] | [ 512s] | CONFIG_FILES = [ 512s] | CONFIG_HEADERS = [ 512s] | CONFIG_LINKS = [ 512s] | CONFIG_COMMANDS = [ 512s] | $ ./config.status Doxyfile.core [ 512s] | [ 512s] | on armbuild24 [ 512s] | [ 512s] | config.status:1200: creating Doxyfile.core [ 512s] [ 512s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 512s] make[1]: *** [override_dh_auto_test] Error 1 [ 512s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 512s] debian/rules:15: recipe for target 'build' failed [ 512s] make: *** [build] Error 2 [ 512s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 512s] [ 512s] armbuild24 failed "build libosmocore_1.1.0.75.316d.dsc" at Tue Jul 2 02:40:10 UTC 2019. [ 512s] [ 512s] ### VM INTERACTION START ### [ 514s] [ 495.476365] sysrq: SysRq : Power Off [ 514s] [ 495.493575] reboot: Power down [ 515s] ### VM INTERACTION END ### [ 515s] [ 515s] armbuild24 failed "build libosmocore_1.1.0.75.316d.dsc" at Tue Jul 2 02:40:14 UTC 2019. [ 515s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 2 02:50:30 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 02 Jul 2019 02:50:30 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1ac685698bb_6eea925f4185195f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 441s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 441s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 441s] collect2: error: ld returned 1 exit status [ 441s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 441s] make[4]: *** [osmo-bts-virtual] Error 1 [ 441s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 441s] Makefile:385: recipe for target 'all-recursive' failed [ 441s] make[3]: *** [all-recursive] Error 1 [ 441s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 441s] Makefile:434: recipe for target 'all-recursive' failed [ 441s] make[2]: *** [all-recursive] Error 1 [ 442s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 442s] Makefile:366: recipe for target 'all' failed [ 442s] make[1]: *** [all] Error 2 [ 442s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 442s] dh_auto_build: make -j1 returned exit code 2 [ 442s] debian/rules:12: recipe for target 'build' failed [ 442s] make: *** [build] Error 2 [ 442s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 442s] [ 442s] armbuild17 failed "build osmo-bts_0.8.1.331.d1e7.dsc" at Tue Jul 2 02:50:16 UTC 2019. [ 442s] [ 442s] ### VM INTERACTION START ### [ 445s] [ 399.831363] sysrq: SysRq : Power Off [ 445s] [ 399.833575] reboot: Power down [ 445s] ### VM INTERACTION END ### [ 445s] [ 445s] armbuild17 failed "build osmo-bts_0.8.1.331.d1e7.dsc" at Tue Jul 2 02:50:19 UTC 2019. [ 445s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 2 03:26:14 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 02 Jul 2019 03:26:14 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1aced6cd1ab_6eea925f418525b8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 421s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 421s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 421s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 421s] Makefile:442: recipe for target 'vlr.o' failed [ 421s] make[4]: *** [vlr.o] Error 1 [ 421s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 421s] Makefile:422: recipe for target 'all-recursive' failed [ 421s] make[3]: *** [all-recursive] Error 1 [ 421s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 421s] Makefile:462: recipe for target 'all-recursive' failed [ 421s] make[2]: *** [all-recursive] Error 1 [ 421s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 421s] Makefile:394: recipe for target 'all' failed [ 421s] make[1]: *** [all] Error 2 [ 421s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 421s] dh_auto_build: make -j1 returned exit code 2 [ 421s] debian/rules:45: recipe for target 'build' failed [ 421s] make: *** [build] Error 2 [ 421s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 421s] [ 421s] armbuild21 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 2 03:26:01 UTC 2019. [ 421s] [ 421s] ### VM INTERACTION START ### [ 424s] [ 406.006533] sysrq: SysRq : Power Off [ 424s] [ 406.007888] reboot: Power down [ 425s] ### VM INTERACTION END ### [ 425s] [ 425s] armbuild21 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 2 03:26:05 UTC 2019. [ 425s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 2 03:28:14 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 02 Jul 2019 03:28:14 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1acf50ce2a0_6eea925f41852689@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 537s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 537s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 537s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 537s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 537s] make[4]: *** [gb_proxy.o] Error 1 [ 537s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 537s] Makefile:391: recipe for target 'all-recursive' failed [ 537s] make[3]: *** [all-recursive] Error 1 [ 537s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 537s] Makefile:453: recipe for target 'all-recursive' failed [ 537s] make[2]: *** [all-recursive] Error 1 [ 537s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 537s] Makefile:385: recipe for target 'all' failed [ 537s] make[1]: *** [all] Error 2 [ 537s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 537s] dh_auto_build: make -j1 returned exit code 2 [ 537s] debian/rules:45: recipe for target 'build' failed [ 537s] make: *** [build] Error 2 [ 537s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 537s] [ 537s] armbuild19 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Tue Jul 2 03:27:55 UTC 2019. [ 537s] [ 537s] ### VM INTERACTION START ### [ 540s] [ 495.165245] sysrq: SysRq : Power Off [ 540s] [ 495.166920] reboot: Power down [ 541s] ### VM INTERACTION END ### [ 541s] [ 541s] armbuild19 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Tue Jul 2 03:27:59 UTC 2019. [ 541s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Jul 2 04:20:39 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Jul 2019 04:20:39 +0000 Subject: Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 ) Change subject: Introduce structs to encode TRXD packets ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb Gerrit-Change-Number: 14629 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 02 Jul 2019 04:20:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 04:21:28 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Jul 2019 04:21:28 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: refactor: gather uplink burst parameters in struct In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14630 ) Change subject: Transceiver: refactor: gather uplink burst parameters in struct ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7e590fb1c0901de627e782f183251c20f4f68d48 Gerrit-Change-Number: 14630 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 02 Jul 2019 04:21:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 04:22:44 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Jul 2019 04:22:44 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14639 ) Change subject: Transceiver: Drop unused rssi_valid struct field ...................................................................... Patch Set 2: Code-Review+1 are the nbits related changes supposed to be in the same patch? the comitlog doesn't even mention them. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82 Gerrit-Change-Number: 14639 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Jul 2019 04:22:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 04:23:43 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Jul 2019 04:23:43 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 ) Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1ee28daf21dc287bec564d45d58086d63655c0f6 Gerrit-Change-Number: 14640 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Jul 2019 04:23:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 04:24:32 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Jul 2019 04:24:32 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14641 ) Change subject: Transceiver: Move soft bits normalization to pullRadioVector() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ibfb48877af4ff5ef0f56390901669c8353beaf48 Gerrit-Change-Number: 14641 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Jul 2019 04:24:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 04:31:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Jul 2019 04:31:22 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 ) Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iadf2683d7f52138a2248598641f3b702252f325d Gerrit-Change-Number: 14642 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Jul 2019 04:31:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 04:34:08 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Jul 2019 04:34:08 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind ...................................................................... Patch Set 1: Code-Review+1 tbh, I'm not quite sure this (like many other patches here) are a big improvement to the code, but as I'm not working on osmo-trx, I trust your judgement. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I726e5a98a43367a22c9a4ca5cbd9eb87e6765c7a Gerrit-Change-Number: 14643 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Jul 2019 04:34:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 04:38:08 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Jul 2019 04:38:08 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API ...................................................................... Patch Set 1: Code-Review+1 I understand that the old code also simply printed an error message (perror), and the new code replicates this. But if the TRX sockets are disappearing at runtime, I would expect we cannot really recoverfrom that? A separate patch should probably either try error recovery (re-creating sockets) or use the fail-fast principle and terminate? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib19856a3e0a7607f63436c4a80b1381a3f318764 Gerrit-Change-Number: 14644 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Jul 2019 04:38:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 04:41:10 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Jul 2019 04:41:10 +0000 Subject: Change in ...osmo-trx[master]: Logger: global Log mutex is now available from C code In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14645 ) Change subject: Logger: global Log mutex is now available from C code ...................................................................... Patch Set 1: Code-Review+1 why do we have a log mutex in the first place? I did some research into multithreadded logging using libosmocore and found that the only critical part would be adding/removing of log targets at runtime (the linked list of log targets). However, during the actual log output / log write, as long as you don't use LOGPC, IIRC you should be fine. Every fprintf should be atomic, whether to stdout or to any other file. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I473e57479f8ae98a84ad00b76ff338f79f732236 Gerrit-Change-Number: 14645 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Jul 2019 04:41:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 04:45:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 2 Jul 2019 04:45:35 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support SETFORMAT command In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14646 ) Change subject: Transceiver: Support SETFORMAT command ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14646/1/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/14646/1/Transceiver52M/Transceiver.cpp at 872 PS1, Line 872: if (version_recv > TRX_DATA_FORMAT_VER) : version_used = TRX_DATA_FORMAT_VER; so if somebody requests version 3, but the TRX can only do 0, 1 and 2, then version 2 will be selected? I'm not sure if this is the semantics we'd like? One could also argue that the existing version (whatever is mVersionTRXD at that point) should be retained if an unsupported version is received. It just looks a bit strange to me if "SETVERSION 3" can still succeed even if '2' is chosen. A lazy client might just check for success/failure -> boom. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed Gerrit-Change-Number: 14646 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Jul 2019 04:45:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 05:14:25 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 05:14:25 +0000 Subject: Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 ) Change subject: Introduce structs to encode TRXD packets ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb Gerrit-Change-Number: 14629 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 05:14:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 05:19:50 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 05:19:50 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: refactor: gather uplink burst parameters in struct In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14630 ) Change subject: Transceiver: refactor: gather uplink burst parameters in struct ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7e590fb1c0901de627e782f183251c20f4f68d48 Gerrit-Change-Number: 14630 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 05:19:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 05:22:08 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 05:22:08 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14639 ) Change subject: Transceiver: Drop unused rssi_valid struct field ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14639/2/Transceiver52M/Transceiver.h File Transceiver52M/Transceiver.h: https://gerrit.osmocom.org/#/c/14639/2/Transceiver52M/Transceiver.h at 40 PS2, Line 40: unsigned nbits; AFAIR, it used to be done in a separate commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82 Gerrit-Change-Number: 14639 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Jul 2019 05:22:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 05:23:47 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 05:23:47 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 ) Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14640/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14640/1//COMMIT_MSG at 9 PS1, Line 9: were where -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1ee28daf21dc287bec564d45d58086d63655c0f6 Gerrit-Change-Number: 14640 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Jul 2019 05:23:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 05:24:24 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 05:24:24 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14641 ) Change subject: Transceiver: Move soft bits normalization to pullRadioVector() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ibfb48877af4ff5ef0f56390901669c8353beaf48 Gerrit-Change-Number: 14641 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 02 Jul 2019 05:24:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 05:32:12 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 05:32:12 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind ...................................................................... Patch Set 1: > I'm not quite sure this (like many other patches here) are a big improvement [...] ACK. This change looks more like getting rid of C++ code and rewriting to C. What are the benefits? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I726e5a98a43367a22c9a4ca5cbd9eb87e6765c7a Gerrit-Change-Number: 14643 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 02 Jul 2019 05:32:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 05:40:06 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 05:40:06 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API ...................................................................... Patch Set 1: (2 comments) Do we have osmo_select_loop() in this thread? https://gerrit.osmocom.org/#/c/14644/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14644/1//COMMIT_MSG at 10 PS1, Line 10: insteadi instead https://gerrit.osmocom.org/#/c/14644/1/Transceiver52M/Transceiver.h File Transceiver52M/Transceiver.h: https://gerrit.osmocom.org/#/c/14644/1/Transceiver52M/Transceiver.h at 171 PS1, Line 171: cosmetic: alignment -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib19856a3e0a7607f63436c4a80b1381a3f318764 Gerrit-Change-Number: 14644 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 02 Jul 2019 05:40:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 05:41:20 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 05:41:20 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14632 ) Change subject: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iedc54011f333f48c6c8b81cab4d640f7601e01dd Gerrit-Change-Number: 14632 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 02 Jul 2019 05:41:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 07:04:12 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 07:04:12 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: add basic TRXD version 0x01 support In-Reply-To: References: Message-ID: Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/14585 to look at the new patch set (#3). Change subject: trx_toolkit/fake_trx.py: add basic TRXD version 0x01 support ...................................................................... trx_toolkit/fake_trx.py: add basic TRXD version 0x01 support Change-Id: I164f5ae4ce7694d6e324aab927a04e96d489ebd8 --- M src/target/trx_toolkit/ctrl_if_trx.py M src/target/trx_toolkit/data_if.py M src/target/trx_toolkit/fake_trx.py 3 files changed, 71 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/85/14585/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I164f5ae4ce7694d6e324aab927a04e96d489ebd8 Gerrit-Change-Number: 14585 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 07:04:12 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 07:04:12 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/14586 to look at the new patch set (#3). Change subject: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation ...................................................................... trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation C/I (Carrier-to-Interference ratio) is a value in cB (centiBels), computed from the training sequence of each received burst, by comparing the "ideal" training sequence with the actual one. This change introduce a new command similar to FAKE_TOA and FAKE_RSSI. Change-Id: I7080effbbc1022d1884c6d6f0cb580eba8e514ff Related: OS#1855 --- M src/target/trx_toolkit/fake_trx.py 1 file changed, 29 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/86/14586/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7080effbbc1022d1884c6d6f0cb580eba8e514ff Gerrit-Change-Number: 14586 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 07:04:13 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 07:04:13 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: mark bit conversion methods as @staticmethod Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14647 Change subject: trx_toolkit/data_msg.py: mark bit conversion methods as @staticmethod ...................................................................... trx_toolkit/data_msg.py: mark bit conversion methods as @staticmethod Change-Id: I2f9fdd514908f186b1c6c043ee9b31c27a396900 --- M src/target/trx_toolkit/data_msg.py 1 file changed, 14 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/47/14647/1 diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py index 9ad19f6..511f692 100644 --- a/src/target/trx_toolkit/data_msg.py +++ b/src/target/trx_toolkit/data_msg.py @@ -108,7 +108,8 @@ return result # Converts unsigned soft-bits {254..0} to soft-bits {-127..127} - def usbit2sbit(self, bits): + @staticmethod + def usbit2sbit(bits): buf = [] for bit in bits: @@ -120,7 +121,8 @@ return buf # Converts soft-bits {-127..127} to unsigned soft-bits {254..0} - def sbit2usbit(self, bits): + @staticmethod + def sbit2usbit(bits): buf = [] for bit in bits: @@ -129,7 +131,8 @@ return buf # Converts soft-bits {-127..127} to bits {1..0} - def sbit2ubit(self, bits): + @staticmethod + def sbit2ubit(bits): buf = [] for bit in bits: @@ -138,7 +141,8 @@ return buf # Converts bits {1..0} to soft-bits {-127..127} - def ubit2sbit(self, bits): + @staticmethod + def ubit2sbit(bits): buf = [] for bit in bits: @@ -572,18 +576,18 @@ sbits_ref = list(range(-127, 128)) # Test both usbit2sbit() and sbit2usbit() - sbits = msg_trx2l1_ref.usbit2sbit(usbits_ref) - usbits = msg_trx2l1_ref.sbit2usbit(sbits) + sbits = DATAMSG.usbit2sbit(usbits_ref) + usbits = DATAMSG.sbit2usbit(sbits) assert(usbits[:255] == usbits_ref[:255]) assert(usbits[255] == 254) log.info("Check both usbit2sbit() and sbit2usbit(): OK") # Test both sbit2ubit() and ubit2sbit() - ubits = msg_trx2l1_ref.sbit2ubit(sbits_ref) + ubits = DATAMSG.sbit2ubit(sbits_ref) assert(ubits == ([1] * 127 + [0] * 128)) - sbits = msg_trx2l1_ref.ubit2sbit(ubits) + sbits = DATAMSG.ubit2sbit(ubits) assert(sbits == ([-127] * 127 + [127] * 128)) log.info("Check both sbit2ubit() and ubit2sbit(): OK") @@ -598,7 +602,7 @@ assert(msg_trx2l1_dec.fn == msg_l12trx_ref.fn) assert(msg_trx2l1_dec.tn == msg_l12trx_ref.tn) - assert(msg_l12trx_dec.burst == msg_l12trx_dec.sbit2ubit(burst_trx2l1_ref)) - assert(msg_trx2l1_dec.burst == msg_trx2l1_dec.ubit2sbit(burst_l12trx_ref)) + assert(msg_l12trx_dec.burst == DATAMSG.sbit2ubit(burst_trx2l1_ref)) + assert(msg_trx2l1_dec.burst == DATAMSG.ubit2sbit(burst_l12trx_ref)) log.info("Check L12TRX <-> TRX2L1 type transformations: OK") -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2f9fdd514908f186b1c6c043ee9b31c27a396900 Gerrit-Change-Number: 14647 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 07:04:14 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 07:04:14 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: add burst randomization helpers Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14648 Change subject: trx_toolkit/data_msg.py: add burst randomization helpers ...................................................................... trx_toolkit/data_msg.py: add burst randomization helpers Change-Id: Idf1393d3d1f04e6c60b356b797a18e6f77b23554 --- M src/target/trx_toolkit/data_msg.py 1 file changed, 30 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/48/14648/1 diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py index 511f692..86d0827 100644 --- a/src/target/trx_toolkit/data_msg.py +++ b/src/target/trx_toolkit/data_msg.py @@ -82,6 +82,10 @@ def parse_burst(self, burst): raise NotImplementedError + # Generate a random message specific burst + def rand_burst(self): + raise NotImplementedError + # Generates a random frame number def rand_fn(self): return random.randint(0, GSM_HYPERFRAME) @@ -319,6 +323,14 @@ else: self.burst = list(burst[:GSM_BURST_LEN]) + # Generate a random message specific burst + def rand_burst(self, length = GSM_BURST_LEN): + self.burst = [] + + for i in range(length): + ubit = random.randint(0, 1) + self.burst.append(ubit) + # Transforms this message to TRX2L1 message def gen_trx2l1(self): # Allocate a new message @@ -480,6 +492,14 @@ # Save self.burst = burst_sbits + # Generate a random message specific burst + def rand_burst(self, length = GSM_BURST_LEN): + self.burst = [] + + for i in range(length): + sbit = random.randint(-127, 127) + self.burst.append(sbit) + # Transforms this message to L12TRX message def gen_l12trx(self): # Allocate a new message @@ -499,28 +519,20 @@ log.basicConfig(level = log.DEBUG, format = "[%(levelname)s] %(filename)s:%(lineno)d %(message)s") - # Generate two random bursts - burst_l12trx_ref = [] - burst_trx2l1_ref = [] - - for i in range(0, GSM_BURST_LEN): - ubit = random.randint(0, 1) - burst_l12trx_ref.append(ubit) - - sbit = random.randint(-127, 127) - burst_trx2l1_ref.append(sbit) - log.info("Generating the reference messages") # Create messages of both types - msg_l12trx_ref = DATAMSG_L12TRX(burst = burst_l12trx_ref) - msg_trx2l1_ref = DATAMSG_TRX2L1(burst = burst_trx2l1_ref) + msg_l12trx_ref = DATAMSG_L12TRX() + msg_trx2l1_ref = DATAMSG_TRX2L1() # Validate header randomization for i in range(0, 100): msg_l12trx_ref.rand_hdr() msg_trx2l1_ref.rand_hdr() + msg_l12trx_ref.rand_burst() + msg_trx2l1_ref.rand_burst() + assert(msg_l12trx_ref.validate()) assert(msg_trx2l1_ref.validate()) @@ -550,9 +562,9 @@ log.info("Comparing decoded messages with the reference") # Compare bursts - assert(msg_l12trx_dec.burst == burst_l12trx_ref) - assert(msg_trx2l1_dec.burst == burst_trx2l1_ref) - assert(msg_trx2l1_legacy_dec.burst == burst_trx2l1_ref) + assert(msg_l12trx_dec.burst == msg_l12trx_ref.burst) + assert(msg_trx2l1_dec.burst == msg_trx2l1_ref.burst) + assert(msg_trx2l1_legacy_dec.burst == msg_trx2l1_ref.burst) log.info("Compare bursts: OK") @@ -602,7 +614,7 @@ assert(msg_trx2l1_dec.fn == msg_l12trx_ref.fn) assert(msg_trx2l1_dec.tn == msg_l12trx_ref.tn) - assert(msg_l12trx_dec.burst == DATAMSG.sbit2ubit(burst_trx2l1_ref)) - assert(msg_trx2l1_dec.burst == DATAMSG.ubit2sbit(burst_l12trx_ref)) + assert(msg_l12trx_dec.burst == DATAMSG.sbit2ubit(msg_trx2l1_ref.burst)) + assert(msg_trx2l1_dec.burst == DATAMSG.ubit2sbit(msg_l12trx_ref.burst)) log.info("Check L12TRX <-> TRX2L1 type transformations: OK") -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idf1393d3d1f04e6c60b356b797a18e6f77b23554 Gerrit-Change-Number: 14648 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 10:40:30 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 10:40:30 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: mark bit conversion methods as @staticmethod In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14647 ) Change subject: trx_toolkit/data_msg.py: mark bit conversion methods as @staticmethod ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2f9fdd514908f186b1c6c043ee9b31c27a396900 Gerrit-Change-Number: 14647 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 10:40:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 10:46:15 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 10:46:15 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: add burst randomization helpers In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14648 ) Change subject: trx_toolkit/data_msg.py: add burst randomization helpers ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14648/1/src/target/trx_toolkit/data_msg.py File src/target/trx_toolkit/data_msg.py: https://gerrit.osmocom.org/#/c/14648/1/src/target/trx_toolkit/data_msg.py at 500 PS1, Line 500: sbit = random.randint(-127, 127) Shouldn't this be encoded 254..0? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idf1393d3d1f04e6c60b356b797a18e6f77b23554 Gerrit-Change-Number: 14648 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 10:46:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 11:04:13 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 11:04:13 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14586 ) Change subject: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7080effbbc1022d1884c6d6f0cb580eba8e514ff Gerrit-Change-Number: 14586 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 11:04:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 11:05:37 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 11:05:37 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14639 ) Change subject: Transceiver: Drop unused rssi_valid struct field ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14639/2/Transceiver52M/Transceiver.h File Transceiver52M/Transceiver.h: https://gerrit.osmocom.org/#/c/14639/2/Transceiver52M/Transceiver.h at 40 PS2, Line 40: unsigned nbits; > AFAIR, it used to be done in a separate commit. Thanks, it probably ended up here during some git rebase/rework. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82 Gerrit-Change-Number: 14639 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 11:05:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 11:07:10 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 11:07:10 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API ...................................................................... Patch Set 1: > Do we have osmo_select_loop() in this thread? No we don't, but with this change it's easier adding it later on together with more osmocom features if we want. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib19856a3e0a7607f63436c4a80b1381a3f318764 Gerrit-Change-Number: 14644 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 02 Jul 2019 11:07:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 11:15:12 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 11:15:12 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind ...................................................................... Patch Set 1: > Patch Set 1: > > > I'm not quite sure this (like many other patches here) are a big improvement [...] > > ACK. This change looks more like getting rid of C++ code and rewriting to C. What are the benefits? The idea is to slowly get rid of lots of boilerplate classes and code which are not really useful since we already have libosmocore counterparts, shrinking and cleaning up osmo-trx code base. It also makes it easier for people used to osmocom code to understand, contribute and maintain the code, lowering the entry barrier. I usually find myself losing time trying having to go through all those classes to understand a small snippet of code, and end up seeing there's not real point in using them, and those contain lots of death code anyway. After these changes I find all this related code far easier to understand and improve than it was before. By cleaning up the code it was visible for instance that normalization procedure was applied to guard periods which are not really used from that point onwards. By using C++ classes in low level code I ended up having to use silly for loops in some places a long time ago instead of using memcpy, etc. So as the guy who's usually investing efforts in fixing stuff and adding new features to osmo-trx, I really see the benefits on the long run. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I726e5a98a43367a22c9a4ca5cbd9eb87e6765c7a Gerrit-Change-Number: 14643 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 02 Jul 2019 11:15:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 11:45:18 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 2 Jul 2019 11:45:18 +0000 Subject: Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 ) Change subject: Introduce structs to encode TRXD packets ...................................................................... Patch Set 4: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb Gerrit-Change-Number: 14629 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 11:45:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 11:56:02 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Jul 2019 11:56:02 +0000 Subject: Change in ...osmo-ci[master]: common.sh: osmo_git_last_commits_tags: add "all" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14649 Change subject: common.sh: osmo_git_last_commits_tags: add "all" ...................................................................... common.sh: osmo_git_last_commits_tags: add "all" Allow printing all tags instead of only the N most recent ones. Related: OS#3870 Change-Id: I684c6881915831b33b679e8ae873213beb034ab7 --- M scripts/common.sh 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/49/14649/1 diff --git a/scripts/common.sh b/scripts/common.sh index 0a32c31..30ab53f 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -16,7 +16,7 @@ # Print last tags and related commits for an Osmocom git repository, e.g.: # "ec798b89700dcca5c5b28edf1a1cd16ea311f30a refs/tags/1.0.1" # $1: Osmocom repository -# $2: amount of commit, tag pairs to print (default: 1) +# $2: amount of commit, tag pairs to print (default: 1, set to "all" to print all) # $3: string to print when there are no tags (default: empty string) osmo_git_last_commits_tags() { # git output: @@ -31,7 +31,9 @@ ret="$(git ls-remote --tags "$OSMO_GIT_URL/$1")" ret="$(echo "$ret" | grep 'refs/tags/[0-9.]*$' || true)" ret="$(echo "$ret" | sort -V -t/ -k3)" - ret="$(echo "$ret" | tail -n "$2")" + if [ "$2" != "all" ]; then + ret="$(echo "$ret" | tail -n "$2")" + fi if [ -n "$ret" ]; then echo "$ret" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I684c6881915831b33b679e8ae873213beb034ab7 Gerrit-Change-Number: 14649 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 11:56:02 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Jul 2019 11:56:02 +0000 Subject: Change in ...osmo-ci[master]: osmocom-list-commits: move repo list to common.sh Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14650 Change subject: osmocom-list-commits: move repo list to common.sh ...................................................................... osmocom-list-commits: move repo list to common.sh Prepare for new script, which will use the same list of repositories. Related: OS#3870 Change-Id: I954b1d5229c44ebcec7e7228f2565a5c6755d16c --- M scripts/common.sh M scripts/osmocom-list-commits.sh 2 files changed, 26 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/50/14650/1 diff --git a/scripts/common.sh b/scripts/common.sh index 30ab53f..2cf31a5 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -2,6 +2,31 @@ # Various functions and variables used in multiple osmo-ci shell scripts OSMO_GIT_URL="https://git.osmocom.org" +# Osmocom repositories of which we want to build release tarballs automatically, and list the current versions at +# https://jenkins.osmocom.org/jenkins/job/Osmocom-list-commits/lastSuccessfulBuild/artifact/commits.txt +OSMO_RELEASE_REPOS=" + libasn1c + libosmo-abis + libosmocore + libosmo-netif + libosmo-sccp + libsmpp34 + libusrp + osmo-bsc + osmo-bts + osmo-ggsn + osmo-hlr + osmo-iuh + osmo-mgw + osmo-msc + osmo-pcu + osmo-sgsn + osmo-sip-connector + osmo-sysmon + osmo-trx + osmocom-bb +" + # Print commit of HEAD for an Osmocom git repository, e.g.: # "f90496f577e78944ce8db1aa5b900477c1e479b0" # $1: repository diff --git a/scripts/osmocom-list-commits.sh b/scripts/osmocom-list-commits.sh index e0d3eb0..b584195 100755 --- a/scripts/osmocom-list-commits.sh +++ b/scripts/osmocom-list-commits.sh @@ -4,28 +4,6 @@ . "$(dirname "$0")/common.sh" FORMAT_STR="%-22s %-42s %9s %-40s %s\n" -REPOS=" - libasn1c - libosmo-abis - libosmocore - libosmo-netif - libosmo-sccp - libsmpp34 - libusrp - osmo-bsc - osmo-bts - osmo-ggsn - osmo-hlr - osmo-iuh - osmo-mgw - osmo-msc - osmo-pcu - osmo-sgsn - osmo-sip-connector - osmo-sysmon - osmo-trx - osmocom-bb -" # Header if [ -z "$NO_HEADER" ]; then @@ -33,7 +11,7 @@ fi # Table -for repo in $REPOS; do +for repo in $OSMO_RELEASE_REPOS; do last_tag="$(osmo_git_last_tags "$repo" 1 "-")" last_commit="$(osmo_git_last_commits "$repo" 1 "-")" head_commit="$(osmo_git_head_commit "$repo")" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I954b1d5229c44ebcec7e7228f2565a5c6755d16c Gerrit-Change-Number: 14650 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 11:56:03 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Jul 2019 11:56:03 +0000 Subject: Change in ...osmo-ci[master]: scripts: add osmocom-release-tarballs.sh Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14651 Change subject: scripts: add osmocom-release-tarballs.sh ...................................................................... scripts: add osmocom-release-tarballs.sh Generate tarball releases for all tags in all repositories. Related: OS#3870 Change-Id: I0a904c26e1c45aa46ddc59a01b776f2c7c5f947d --- M .gitignore A scripts/osmocom-release-tarballs.sh 2 files changed, 216 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/51/14651/1 diff --git a/.gitignore b/.gitignore index e101b84..ff207ee 100644 --- a/.gitignore +++ b/.gitignore @@ -8,6 +8,7 @@ __pycache__/ _temp/ _deps/ +_release_tarballs/ # osmocom-nightly-packages.sh nightly-3g_* diff --git a/scripts/osmocom-release-tarballs.sh b/scripts/osmocom-release-tarballs.sh new file mode 100755 index 0000000..b9d21c3 --- /dev/null +++ b/scripts/osmocom-release-tarballs.sh @@ -0,0 +1,215 @@ +#!/bin/sh -e +# Iterate over all relevant Osmocom repositories and generate release tarballs for each of the repository tags. The tags +# are queried from the git server without cloning the repositories first, so we can clone them only if we need to build +# a missing tarball. All repositories are deleted afterwards to save space. +# +# Environment variables: +# * KEEP_TEMP: do not delete cloned repositories (use for development) +# * PARALLEL_MAKE: -jN argument for make (default: -j5). + +cd "$(dirname "$0")" +. ./common.sh +PARALLEL_MAKE="${PARALLEL_MAKE:--j5}" +OUTPUT="$(cd ..; pwd)/_release_tarballs" +TEMP="$(cd ..; pwd)/_temp" + +# Print all tags for which no release tarball should be built. +# $1: Osmocom repository +tags_to_ignore() { + case "$1" in + libosmocore) + # configure.ac:144: error: required file 'src/gb/Makefile.in' not found + echo "0.5.0" + echo "0.5.1" + ;; + libsmpp34) + # duplicate of 1.12.0 + echo "1.12" + ;; + osmo-bsc) + # openbsc + echo "1.0.1" + # Requires libosmo-legacy-mgcp + echo "1.1.0" + echo "1.1.1" + echo "1.1.2" + echo "1.2.0" + echo "1.2.1" + echo "1.2.2" + ;; + osmo-bts) + # gsm_data_shared.h:464:26: error: field 'power_params' has incomplete type + echo "0.2.0" + echo "0.3.0" + ;; + osmo-hlr) + # Not using autotools + echo "0.0.1" + ;; + osmo-mgw) + # openbsc + echo "1.0.1" + ;; + osmo-msc) + # openbsc + echo "1.0.1" + ;; + osmo-pcu) + # Duplicates of 0.1.0, 0.2.0 + echo "0.1" + echo "0.2" + ;; + osmo-sgsn) + # openbsc + echo "0.9.0 0.9.1 0.9.2 0.9.3 0.9.4 0.9.5 0.9.6 0.9.8 0.9.9 0.9.10 0.9.11 0.9.12 0.9.13 0.9.14" + echo "0.9.15 0.9.16 0.10.0 0.10.1 0.11.0 0.12.0 0.13.0 0.14.0 0.15.0 1.0.1" + ;; + osmo-sip-connector) + # make: *** No rule to make target 'osmoappdesc.py' + echo "0.0.1" + ;; + osmo-trx) + # cp: cannot stat './/home/user/code/osmo-dev/src/osmo-ci/_temp/repos/osmo-trx/configure' + echo "0.2.0" + echo "0.3.0" + ;; + esac +} + +# Clone dependency repositories. +# $1: Osmocom repository +prepare_depends() { + case "$1" in + osmo-bts) + # Includes openbsc/gsm_data_shared.h + prepare_repo "openbsc" + ;; + esac +} + +# Apply workarounds for bugs that break too many releases. This function runs between ./configure and make dist-bzip2. +# $1: Osmocom repository +fix_repo() { + case "$1" in + osmo-mgw) + # No rule to make target 'osmocom/mgcp_client/mgcp_common.h' (OS#4084) + make -C "$TEMP/repos/$1/include/osmocom/mgcp_client" mgcp_common.h || true + ;; + esac +} + +# Check if one specific tag should be ignored. +# $1: Osmocom repository +# $2: tag (e.g. "1.0.0") +ignore_tag() { + local repo="$1" + local tag="$2" + local tags="$(tags_to_ignore "$repo")" + for tag_i in $tags; do + if [ "$tag" = "$tag_i" ]; then + return 0 + fi + done + return 1 +} + +# Delete existing temp dir (unless KEEP_TEMP is set). If all repos were checked out, this restores ~500 MB of space. +remove_temp_dir() { + if [ -n "$KEEP_TEMP" ]; then + echo "NOTE: not removing temp dir, because KEEP_TEMP is set: $TEMP" + elif [ -d "$TEMP" ]; then + rm -rf "$TEMP" + fi +} + +# Clone an Osmocom repository to $TEMP/repos/$repo, clean it, checkout a tag. +# $1: Osmocom repository +# $2: tag (optional, default: master) +prepare_repo() { + local repo="$1" + local tag="${2:-master}" + + if ! [ -d "$TEMP/repos/$repo" ]; then + git -C "$TEMP/repos" clone "$OSMO_GIT_URL/$repo" + fi + + cd "$TEMP/repos/$repo" + git clean -qdxf + git reset --hard HEAD # in case the tracked files were modified (e.g. libsmpp34 1.10) + git checkout -q "$tag" +} + +# Checkout a given tag and build a release tarball. +# $1: Osmocom repository +# $2: tag +create_tarball() { + local repo="$1" + local tag="$2" + local tarball="$repo-$tag.tar.bz2" + + # Be verbose during the tarball build and preparation. Everything else is not verbose, so we can generate an + # easy to read overview of tarballs that are already built or are ignored. + set -x + + prepare_repo "$repo" "$tag" + prepare_depends "$repo" + + cd "$TEMP/repos/$repo" + autoreconf -fi + ./configure + fix_repo "$repo" + make dist-bzip2 + + # Back to non-verbose mode + set +x + + if ! [ -e "$tarball" ]; then + echo "NOTE: tarball has a different name (wrong version in configure.ac?), renaming." + mv -v *.tar.bz2 "$tarball" + fi +} + +# Move a generated release tarball to the output dir. +move_tarball() { + local repo="$1" + local tag="$2" + local tarball="$repo-$tag.tar.bz2" + + cd "$TEMP/repos/$repo" + mkdir -p "$OUTPUT/$repo" + mv "$tarball" "$OUTPUT/$repo/$tarball" +} + +remove_temp_dir +mkdir -p "$TEMP/repos" +echo "Temp dir: $TEMP" + +for repo in $OSMO_RELEASE_REPOS; do + echo "$repo" + tags="$(osmo_git_last_commits_tags "$repo" "all" | cut -d / -f 3)" + + # Skip untagged repos + if [ -z "$tags" ]; then + echo " (repository has no release tags)" + continue + fi + + # Build missing tarballs for each tag + for tag in $tags; do + tarball="$repo-$tag.tar.bz2" + if ignore_tag "$repo" "$tag"; then + echo " $tarball (ignored)" + continue + elif [ -e "$OUTPUT/$repo/$tarball" ]; then + echo " $tarball (exists)" + continue + fi + + echo " $tarball (creating)" + create_tarball "$repo" "$tag" + move_tarball "$repo" "$tag" + done +done + +remove_temp_dir +echo "done!" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0a904c26e1c45aa46ddc59a01b776f2c7c5f947d Gerrit-Change-Number: 14651 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 11:56:03 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Jul 2019 11:56:03 +0000 Subject: Change in ...osmo-ci[master]: common.sh: add docker_images_require Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14652 Change subject: common.sh: add docker_images_require ...................................................................... common.sh: add docker_images_require Clone docker-playground.git, source its jenkins-common.sh and run docker_images_require from there. This will make it possible to run osmocom-release-tarballs.sh in a docker container, for which the Dockerfile is stored in docker-playground.git. Related: OS#3870 Change-Id: Ic4519ccb6978793054869862f8ca0e21d9cf5be4 --- M .gitignore M scripts/common.sh 2 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/52/14652/1 diff --git a/.gitignore b/.gitignore index ff207ee..459f2c9 100644 --- a/.gitignore +++ b/.gitignore @@ -9,6 +9,7 @@ _temp/ _deps/ _release_tarballs/ +_docker_playground # osmocom-nightly-packages.sh nightly-3g_* diff --git a/scripts/common.sh b/scripts/common.sh index 2cf31a5..bf24fc4 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -27,6 +27,8 @@ osmocom-bb " +OSMO_BRANCH_DOCKER_PLAYGROUND="${OSMO_BRANCH_DOCKER_PLAYGROUND:-master}" + # Print commit of HEAD for an Osmocom git repository, e.g.: # "f90496f577e78944ce8db1aa5b900477c1e479b0" # $1: repository @@ -96,3 +98,27 @@ ;; esac } + +# Build docker images from docker-playground.git. +# $1...$n: docker image names (e.g. "debian-stretch-build") +docker_images_require() { + local oldpwd="$PWD" + + # Get docker-plaground.git + if [ -d "_docker_playground" ]; then + git -C _docker_playground fetch + else + git clone https://git.osmocom.org/docker-playground/ _docker_playground + fi + cd _docker_playground + git checkout "$OSMO_BRANCH_DOCKER_PLAYGROUND" + git reset --hard "origin/$OSMO_BRANCH_DOCKER_PLAYGROUND" + + # jenkins-common.sh expects to run from a subdir in docker-playground.git + cd "$1" + + # Subshell: run docker_images_require from jenkins-common.sh, pass all arguments + (. ../jenkins-common.sh; docker_images_require "$@") + + cd "$oldpwd" +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic4519ccb6978793054869862f8ca0e21d9cf5be4 Gerrit-Change-Number: 14652 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 11:56:03 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Jul 2019 11:56:03 +0000 Subject: Change in ...osmo-ci[master]: jobs: add osmocom-release-tarballs.yml Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14653 Change subject: jobs: add osmocom-release-tarballs.yml ...................................................................... jobs: add osmocom-release-tarballs.yml Related: OS#3870 Depends: I991fe41a1f55ccd6a66815ec3d7f239850397d9a (docker-playground) Change-Id: I994da5c27f9198e5bcf2d567dd473f9ed078d9c0 --- A jobs/osmocom-release-tarballs.yml 1 file changed, 54 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/53/14653/1 diff --git a/jobs/osmocom-release-tarballs.yml b/jobs/osmocom-release-tarballs.yml new file mode 100644 index 0000000..56f5777 --- /dev/null +++ b/jobs/osmocom-release-tarballs.yml @@ -0,0 +1,54 @@ +--- +- project: + name: Osmocom-release-tarballs + jobs: + - Osmocom-release-tarballs + +- job-template: + name: 'Osmocom-release-tarballs' + project-type: freestyle + defaults: global + description: | + For each relevant Osmocom repository and its tags, build release tarballs (OS#3870). + parameters: + - string: + name: BRANCH_OSMO_CI + description: | + osmo-ci.git branch where the osmocom-release-tarballs.sh gets pulled from + default: 'master' + - string: + name: BRANCH_DOCKER_PLAYGROUND + description: | + docker-playground.git branch where the Dockerfile gets pulled from + default: 'master' + builders: + - shell: | + export OSMO_BRANCH_DOCKER_PLAYGROUND="$BRANCH_DOCKER_PLAYGROUND" + . scripts/common.sh + docker_images_require "debian-stretch-build" "debian-stretch-build-dist" + + docker run \ + --rm=true \ + -v "$PWD:/osmo-ci" \ + -w /osmo-ci \ + -e KEEP_TEMP="$KEEP_TEMP" \ + "$USER/debian-stretch-build-dist" /osmo-ci/scripts/osmocom-release-tarballs.sh + scm: + - git: + branches: + - '$BRANCH_OSMO_CI' + url: git://git.osmocom.org/osmo-ci + git-config-name: 'Jenkins Builder' + git-config-email: 'jenkins at osmocom.org' + # Don't wipe workspace to keep generated release tarballs + wipe-workspace: false + triggers: + - timed: "@midnight" + # Limit to one specific builder (so we don't regenerate all tarballs when switching to another builder) + node: build2-deb9build-ansible + publishers: + - email: + notify-every-unstable-build: true + recipients: 'jenkins-notifications at lists.osmocom.org' + +# vim: expandtab tabstop=2 shiftwidth=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I994da5c27f9198e5bcf2d567dd473f9ed078d9c0 Gerrit-Change-Number: 14653 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 11:56:09 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Jul 2019 11:56:09 +0000 Subject: Change in ...docker-playground[master]: debian-stretch-build-dist: new Dockerfile Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14654 Change subject: debian-stretch-build-dist: new Dockerfile ...................................................................... debian-stretch-build-dist: new Dockerfile Provide all build dependencies needed to pass ./configure of most Osmocom repositories. This will be used to run osmo-release-tarballs.sh in jenkins. Related: OS#3870 Change-Id: I991fe41a1f55ccd6a66815ec3d7f239850397d9a --- A debian-stretch-build-dist/Dockerfile A debian-stretch-build-dist/Makefile A debian-stretch-build-dist/Release.key 3 files changed, 59 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/54/14654/1 diff --git a/debian-stretch-build-dist/Dockerfile b/debian-stretch-build-dist/Dockerfile new file mode 100644 index 0000000..a1f0290 --- /dev/null +++ b/debian-stretch-build-dist/Dockerfile @@ -0,0 +1,38 @@ +ARG USER +FROM $USER/debian-stretch-build + +ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/" + +COPY Release.key /tmp/Release.key + +RUN apt-key add /tmp/Release.key && \ + rm /tmp/Release.key && \ + echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-latest.list + +ADD $OSMOCOM_REPO/Release /tmp/Release +RUN apt-get update && \ + apt-get install -y --no-install-recommends \ + ca-certificates \ + libboost-all-dev \ + liboping-dev \ + libuhd-dev \ + \ + libasn1c-dev \ + libgtp-dev \ + libgtpnl-dev \ + liblimesuite-dev \ + liborcania-dev \ + libosmo-abis-dev \ + libosmocore-dev \ + libosmodsp-dev \ + libosmo-gsup-client-dev \ + libosmo-mgcp-client-dev \ + libosmo-netif-dev \ + libosmo-ranap-dev \ + libosmo-sccp-dev \ + libosmo-sigtran-dev \ + libsmpp34-dev \ + libulfius-dev \ + libusrp-dev \ + libyder-dev && \ + apt-get clean diff --git a/debian-stretch-build-dist/Makefile b/debian-stretch-build-dist/Makefile new file mode 100644 index 0000000..8d0e10b --- /dev/null +++ b/debian-stretch-build-dist/Makefile @@ -0,0 +1 @@ +include ../make/Makefile diff --git a/debian-stretch-build-dist/Release.key b/debian-stretch-build-dist/Release.key new file mode 100644 index 0000000..e656238 --- /dev/null +++ b/debian-stretch-build-dist/Release.key @@ -0,0 +1,20 @@ +-----BEGIN PGP PUBLIC KEY BLOCK----- +Version: GnuPG v1.4.5 (GNU/Linux) + +mQENBFJBt/wBCADAht3d/ilNuyzaXYw/QwTRvmjyoDvfXw+H/3Fvk1zlDZoiKPPc +a1wCVBINUZl7vYM2OXqbJwYa++JP2Q48xKSvC6thbRc/YLievkbcvTemf7IaREfl +CTjoYpoqXHa9kHMw1aALDm8CNU88jZmnV7v9L6hKkbYDxie+jpoj7D6B9JlxgNJ4 +5dQyRNsFGVcIl4Vplt1HyGc5Q5nQI/VgS2rlF/IOXmhRQBc4LEDdU8R2IKnkU4ee +S7TWanAigGAQhxGuCkS39/CWzc1DhLhjlNhBl/+RTPejkqJtAy00ZLps3+RqUN1Y +CU/Fsr7aRlYVGqQ/BlptwV0XQ2VVYJX2oEBBABEBAAG0MG5ldHdvcmsgT0JTIFBy +b2plY3QgPG5ldHdvcmtAYnVpbGQub3BlbnN1c2Uub3JnPokBPAQTAQIAJgUCWmMc +aQIbAwUJDEAUbQYLCQgHAwIEFQIIAwQWAgMBAh4BAheAAAoJEGLrGgkXKA3fjsoI +ALSXmXzFCpTxg8a6tvXkqddY/qAmeBMNUf7hslI9wN3leNmCrnuHS8TbHWYJZgtw +8M5fKL3aRQYaIiqqm1XOUF0OqwYNDj5V3y38mM68NYOkzgSP7foMwZp9Y0TlGhtI +L8weA+2RUjB4hwwGMAYMqkRZyKW3NhPqdlGGoXac1ilwEyGXFHdOLbkhtyS+P2yb +/EvaKIN5cMLzRZKeYgdp9WuAirV+yV/SDbgvabW098lrWhGLltlRRDQgMV883p8I +ERMI1wlLFZGnHL3mfBWGeQ24M/DaBOdXQDtfBLCJ9nGztmDBUb8i6GFWU7nD2TGi +8mYUsED1ZDwO/0jdvJ4gSluIRgQTEQIABgUCUkG3/AAKCRA7MBG3a51lIzhdAJ9v +d6XPffMZRcCGgDEY5OaTn/MsCQCgrXbeZpFJgnirSrc8rRonvzYFiF4= +=Gvly +-----END PGP PUBLIC KEY BLOCK----- -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I991fe41a1f55ccd6a66815ec3d7f239850397d9a Gerrit-Change-Number: 14654 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 12:22:03 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 12:22:03 +0000 Subject: Change in ...osmo-ci[master]: common.sh: osmo_git_last_commits_tags: add "all" In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14649 ) Change subject: common.sh: osmo_git_last_commits_tags: add "all" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I684c6881915831b33b679e8ae873213beb034ab7 Gerrit-Change-Number: 14649 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 12:22:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 12:22:06 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 12:22:06 +0000 Subject: Change in ...osmo-ci[master]: osmocom-list-commits: move repo list to common.sh In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14650 ) Change subject: osmocom-list-commits: move repo list to common.sh ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I954b1d5229c44ebcec7e7228f2565a5c6755d16c Gerrit-Change-Number: 14650 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 12:22:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 12:22:10 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 12:22:10 +0000 Subject: Change in ...osmo-ci[master]: scripts: add osmocom-release-tarballs.sh In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14651 ) Change subject: scripts: add osmocom-release-tarballs.sh ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0a904c26e1c45aa46ddc59a01b776f2c7c5f947d Gerrit-Change-Number: 14651 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 12:22:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 12:22:14 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 12:22:14 +0000 Subject: Change in ...osmo-ci[master]: common.sh: add docker_images_require In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14652 ) Change subject: common.sh: add docker_images_require ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic4519ccb6978793054869862f8ca0e21d9cf5be4 Gerrit-Change-Number: 14652 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 12:22:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 12:22:18 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 12:22:18 +0000 Subject: Change in ...osmo-ci[master]: jobs: add osmocom-release-tarballs.yml In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14653 ) Change subject: jobs: add osmocom-release-tarballs.yml ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I994da5c27f9198e5bcf2d567dd473f9ed078d9c0 Gerrit-Change-Number: 14653 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 12:22:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 12:48:59 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 2 Jul 2019 12:48:59 +0000 Subject: Change in ...osmo-mgw[master]: "make dist" fix for: no rule to make mgcp_common.h Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14655 Change subject: "make dist" fix for: no rule to make mgcp_common.h ...................................................................... "make dist" fix for: no rule to make mgcp_common.h Mark osmocom/mgcp_client/mgcp_common.h as nodist, so "make dist" will not try to include it in the source tarball. This caused "make dist" to fail in a clean osmo-mgw source tree with: make[2]: *** No rule to make target 'osmocom/mgcp_client/mgcp_common.h', needed by 'distdir'. Stop. Related: OS#4084 Change-Id: Ia1d7b051c0924a785b0f7ec0195192e3a852ed70 --- M include/Makefile.am 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/55/14655/1 diff --git a/include/Makefile.am b/include/Makefile.am index 2daaf20..9d0368b 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -6,9 +6,12 @@ osmocom/mgcp_client/mgcp_client.h \ osmocom/mgcp_client/mgcp_client_endpoint_fsm.h \ osmocom/mgcp_client/mgcp_client_fsm.h \ - osmocom/mgcp_client/mgcp_common.h \ osmocom/mgcp/mgcp.h \ osmocom/mgcp/mgcp_common.h \ osmocom/mgcp/mgcp_internal.h \ osmocom/mgcp/osmux.h \ $(NULL) + +nobase_nodist_include_HEADERS = \ + osmocom/mgcp_client/mgcp_common.h \ + $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia1d7b051c0924a785b0f7ec0195192e3a852ed70 Gerrit-Change-Number: 14655 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:03:22 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:03:22 +0000 Subject: Change in ...osmo-mgw[master]: "make dist" fix for: no rule to make mgcp_common.h In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14655 ) Change subject: "make dist" fix for: no rule to make mgcp_common.h ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Why https://gerrit.osmocom.org/#/c/14655/1/include/Makefile.am File include/Makefile.am: https://gerrit.osmocom.org/#/c/14655/1/include/Makefile.am at 16 PS1, Line 16: osmocom/mgcp_client/mgcp_common.h \ This one MUST be distributed, since osmocom/mgcp_client/mgcp_client.h includes it. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia1d7b051c0924a785b0f7ec0195192e3a852ed70 Gerrit-Change-Number: 14655 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 13:03:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:09:24 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:09:24 +0000 Subject: Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 ) Change subject: Introduce structs to encode TRXD packets ...................................................................... Patch Set 4: Code-Review+2 1+1=+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb Gerrit-Change-Number: 14629 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 13:09:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:09:37 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:09:37 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: refactor: gather uplink burst parameters in struct In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14630 ) Change subject: Transceiver: refactor: gather uplink burst parameters in struct ...................................................................... Patch Set 4: 1+1=+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7e590fb1c0901de627e782f183251c20f4f68d48 Gerrit-Change-Number: 14630 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 13:09:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:09:45 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:09:45 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: refactor: gather uplink burst parameters in struct In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14630 ) Change subject: Transceiver: refactor: gather uplink burst parameters in struct ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7e590fb1c0901de627e782f183251c20f4f68d48 Gerrit-Change-Number: 14630 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 13:09:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:09:56 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:09:56 +0000 Subject: Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 ) Change subject: Introduce structs to encode TRXD packets ...................................................................... Introduce structs to encode TRXD packets This will ease adding new protocol versions in the future. Related: OS#4006 Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb --- M Transceiver52M/Makefile.am M Transceiver52M/Transceiver.cpp A Transceiver52M/proto_trxd.h 3 files changed, 46 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/Transceiver52M/Makefile.am b/Transceiver52M/Makefile.am index 89ab796..4adf474 100644 --- a/Transceiver52M/Makefile.am +++ b/Transceiver52M/Makefile.am @@ -25,6 +25,7 @@ AM_CPPFLAGS = -Wall $(STD_DEFINES_AND_INCLUDES) -I${srcdir}/arch/common -I${srcdir}/device/common AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) +AM_CFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) rev2dir = $(datadir)/usrp/rev2 rev4dir = $(datadir)/usrp/rev4 @@ -66,7 +67,8 @@ Resampler.h \ ChannelizerBase.h \ Channelizer.h \ - Synthesis.h + Synthesis.h \ + proto_trxd.h COMMON_LDADD = \ libtransceiver_common.la \ diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 0aa4ff5..5441745 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -29,6 +29,9 @@ extern "C" { #include "osmo_signal.h" +#include "proto_trxd.h" + +#include } #ifdef HAVE_CONFIG_H @@ -950,22 +953,24 @@ TOAint = (int) (TOA * 256.0 + 0.5); // round to closest integer - char burstString[nbits + 10]; - burstString[0] = burstTime.TN(); - for (int i = 0; i < 4; i++) - burstString[1+i] = (burstTime.FN() >> ((3-i)*8)) & 0x0ff; - burstString[5] = (int)dBm; - burstString[6] = (TOAint >> 8) & 0x0ff; - burstString[7] = TOAint & 0x0ff; + char burstString[sizeof(struct trxd_hdr_v0) + nbits + 2]; + struct trxd_hdr_v0* pkt = (struct trxd_hdr_v0*)burstString; + pkt->common.version = 0; + pkt->common.reserved = 0; + pkt->common.tn = burstTime.TN(); + osmo_store32be(burstTime.FN(), &pkt->common.fn); + pkt->v0.rssi = dBm; + osmo_store16be(TOAint, &pkt->v0.toa); SoftVector::iterator burstItr = rxBurst->begin(); for (unsigned i = 0; i < nbits; i++) - burstString[8 + i] = (char) round((*burstItr++) * 255.0); + pkt->soft_bits[i] = (char) round((*burstItr++) * 255.0); - burstString[nbits + 9] = '\0'; + /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi.nbits] */ + pkt->soft_bits[nbits + 1] = '\0'; delete rxBurst; - mDataSockets[chan]->write(burstString, nbits + 10); + mDataSockets[chan]->write(burstString, sizeof(struct trxd_hdr_v0) + nbits + 2); } void Transceiver::driveTxFIFO() diff --git a/Transceiver52M/proto_trxd.h b/Transceiver52M/proto_trxd.h new file mode 100644 index 0000000..9da18db --- /dev/null +++ b/Transceiver52M/proto_trxd.h @@ -0,0 +1,28 @@ +#pragma once + +#include +#include + +struct trxd_hdr_common { +#if OSMO_IS_LITTLE_ENDIAN + uint8_t tn:3, + reserved:1, + version:4; +#elif OSMO_IS_BIG_ENDIAN + uint8_t version:4, + reserved:1, + tn:3; +#endif + uint32_t fn; /* big endian */ +} __attribute__ ((packed)); + +struct trxd_hdr_v0_specific { + uint8_t rssi; + uint16_t toa; /* big endian */ +} __attribute__ ((packed)); + +struct trxd_hdr_v0 { + struct trxd_hdr_common common; + struct trxd_hdr_v0_specific v0; + uint8_t soft_bits[0]; +} __attribute__ ((packed)); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14629 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I67ffede171eddde436f9057191ed76015a8ea6eb Gerrit-Change-Number: 14629 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:09:57 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:09:57 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: refactor: gather uplink burst parameters in struct In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14630 ) Change subject: Transceiver: refactor: gather uplink burst parameters in struct ...................................................................... Transceiver: refactor: gather uplink burst parameters in struct A new struct trx_ul_burst_ind is introduced, which will handle information filled by lower layers upon decoding of uplink bursts. Methods pullRadioVector() and logRxBurst() are adapted to use that struct. This way it's easier to understand in/out parameters and it's also easier to add further parameters to be filled in in the future. Related: OS#4006 Change-Id: I7e590fb1c0901de627e782f183251c20f4f68d48 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 48 insertions(+), 53 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 5441745..c3896bd 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -551,27 +551,24 @@ * Pull bursts from the FIFO and handle according to the slot * and burst correlation type. Equalzation is currently disabled. */ -SoftVector *Transceiver::pullRadioVector(GSM::Time &wTime, double &RSSI, bool &isRssiValid, - double &timingOffset, double &noise, - size_t chan) +bool Transceiver::pullRadioVector(size_t chan, struct trx_ul_burst_ind *bi) { int rc; complex amp; float toa, max = -1.0, avg = 0.0; int max_i = -1; signalVector *burst; - SoftVector *bits = NULL; TransceiverState *state = &mStates[chan]; - isRssiValid = false; + bi->rssi_valid = false; /* Blocking FIFO read */ radioVector *radio_burst = mReceiveFIFO[chan]->read(); if (!radio_burst) - return NULL; + return false; /* Set time and determine correlation type */ - GSM::Time time = radio_burst->getTime(); - CorrType type = expectedCorrType(time, chan); + bi->burstTime = radio_burst->getTime(); + CorrType type = expectedCorrType(bi->burstTime, chan); /* Enable 8-PSK burst detection if EDGE is enabled */ if (mEdge && (type == TSC)) @@ -580,14 +577,14 @@ /* Debug: dump bursts to disk */ /* bits 0-7 - chan 0 timeslots * bits 8-15 - chan 1 timeslots */ - if (mWriteBurstToDiskMask & ((1<burstTime.TN()) << (8*chan))) writeToFile(radio_burst, chan); /* No processing if the timeslot is off. * Not even power level or noise calculation. */ if (type == OFF) { delete radio_burst; - return NULL; + return false; } /* Select the diversity channel with highest energy */ @@ -603,30 +600,29 @@ if (max_i < 0) { LOG(ALERT) << "Received empty burst"; delete radio_burst; - return NULL; + return false; } /* Average noise on diversity paths and update global levels */ burst = radio_burst->getVector(max_i); avg = sqrt(avg / radio_burst->chans()); - wTime = time; - RSSI = 20.0 * log10(rxFullScale / avg); + bi->rssi = 20.0 * log10(rxFullScale / avg); /* RSSI estimation are valid */ - isRssiValid = true; + bi->rssi_valid = true; if (type == IDLE) { /* Update noise levels */ state->mNoises.insert(avg); state->mNoiseLev = state->mNoises.avg(); - noise = 20.0 * log10(rxFullScale / state->mNoiseLev); + bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev); delete radio_burst; - return NULL; + return false; } else { /* Do not update noise levels */ - noise = 20.0 * log10(rxFullScale / state->mNoiseLev); + bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev); } unsigned max_toa = (type == RACH || type == EXT_RACH) ? @@ -645,15 +641,14 @@ } delete radio_burst; - return NULL; + return false; } - timingOffset = toa; - - bits = demodAnyBurst(*burst, mSPSRx, amp, toa, type); + bi->toa = toa; + bi->rxBurst = demodAnyBurst(*burst, mSPSRx, amp, toa, type); delete radio_burst; - return bits; + return true; } void Transceiver::reset() @@ -909,66 +904,60 @@ } } -void Transceiver::logRxBurst(size_t chan, SoftVector *burst, GSM::Time time, double dbm, - double rssi, double noise, double toa) +void Transceiver::logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi, double dbm) { LOG(DEBUG) << std::fixed << std::right << " chan: " << chan - << " time: " << time - << " RSSI: " << std::setw(5) << std::setprecision(1) << rssi + << " time: " << bi->burstTime + << " RSSI: " << std::setw(5) << std::setprecision(1) << bi->rssi << "dBFS/" << std::setw(6) << -dbm << "dBm" - << " noise: " << std::setw(5) << std::setprecision(1) << noise - << "dBFS/" << std::setw(6) << -(noise + rssiOffset) << "dBm" - << " TOA: " << std::setw(5) << std::setprecision(2) << toa - << " bits: " << *burst; + << " noise: " << std::setw(5) << std::setprecision(1) << bi->noise + << "dBFS/" << std::setw(6) << -(bi->noise + rssiOffset) << "dBm" + << " TOA: " << std::setw(5) << std::setprecision(2) << bi->toa + << " bits: " << *(bi->rxBurst); } void Transceiver::driveReceiveFIFO(size_t chan) { - SoftVector *rxBurst = NULL; - double RSSI; // in dBFS double dBm; // in dBm - double TOA; // in symbols int TOAint; // in 1/256 symbols - double noise; // noise level in dBFS - GSM::Time burstTime; - bool isRssiValid; // are RSSI, noise and burstTime valid unsigned nbits = gSlotLen; - rxBurst = pullRadioVector(burstTime, RSSI, isRssiValid, TOA, noise, chan); - if (!rxBurst) - return; + struct trx_ul_burst_ind bi; + + if (!pullRadioVector(chan, &bi)) + return; // Convert -1..+1 soft bits to 0..1 soft bits - vectorSlicer(rxBurst); + vectorSlicer(bi.rxBurst); /* * EDGE demodulator returns 444 (148 * 3) bits */ - if (rxBurst->size() == gSlotLen * 3) + if (bi.rxBurst->size() == gSlotLen * 3) nbits = gSlotLen * 3; - dBm = RSSI + rssiOffset; - logRxBurst(chan, rxBurst, burstTime, dBm, RSSI, noise, TOA); + dBm = bi.rssi + rssiOffset; + logRxBurst(chan, &bi, dBm); - TOAint = (int) (TOA * 256.0 + 0.5); // round to closest integer + TOAint = (int) (bi.toa * 256.0 + 0.5); // round to closest integer char burstString[sizeof(struct trxd_hdr_v0) + nbits + 2]; struct trxd_hdr_v0* pkt = (struct trxd_hdr_v0*)burstString; pkt->common.version = 0; pkt->common.reserved = 0; - pkt->common.tn = burstTime.TN(); - osmo_store32be(burstTime.FN(), &pkt->common.fn); + pkt->common.tn = bi.burstTime.TN(); + osmo_store32be(bi.burstTime.FN(), &pkt->common.fn); pkt->v0.rssi = dBm; osmo_store16be(TOAint, &pkt->v0.toa); - SoftVector::iterator burstItr = rxBurst->begin(); + SoftVector::iterator burstItr = bi.rxBurst->begin(); for (unsigned i = 0; i < nbits; i++) pkt->soft_bits[i] = (char) round((*burstItr++) * 255.0); /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi.nbits] */ pkt->soft_bits[nbits + 1] = '\0'; - delete rxBurst; + delete bi.rxBurst; mDataSockets[chan]->write(burstString, sizeof(struct trxd_hdr_v0) + nbits + 2); } diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index ceb8c4a..0f452c1 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -35,6 +35,15 @@ #include "config_defs.h" } +struct trx_ul_burst_ind { + SoftVector *rxBurst; + GSM::Time burstTime; + double rssi; // in dBFS + double toa; // in symbols + double noise; // noise level in dBFS + bool rssi_valid; // are RSSI, noise and burstTime valid +}; + class Transceiver; /** Channel descriptor for transceiver object and channel number pair */ @@ -191,9 +200,7 @@ void pushRadioVector(GSM::Time &nowTime); /** Pull and demodulate a burst from the receive FIFO */ - SoftVector *pullRadioVector(GSM::Time &wTime, double &RSSI, bool &isRssiValid, - double &timingOffset, double &noise, - size_t chan = 0); + bool pullRadioVector(size_t chan, struct trx_ul_burst_ind *ind); /** Set modulus for specific timeslot */ void setModulus(size_t timeslot, size_t chan); @@ -264,8 +271,7 @@ /** set priority on current thread */ void setPriority(float prio = 0.5) { mRadioInterface->setPriority(prio); } - void logRxBurst(size_t chan, SoftVector *burst, GSM::Time time, double dbm, - double rssi, double noise, double toa); + void logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi, double dbm); }; void *RxUpperLoopAdapter(TransceiverChannel *); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14630 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7e590fb1c0901de627e782f183251c20f4f68d48 Gerrit-Change-Number: 14630 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:10:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:10:25 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field In-Reply-To: References: Message-ID: Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14639 to look at the new patch set (#3). Change subject: Transceiver: Drop unused rssi_valid struct field ...................................................................... Transceiver: Drop unused rssi_valid struct field That field is actually never used. Furthermore, if pullRadioVector() returns false, then the caller should consider the 'trx_ul_burst_ind' structure as uninitialized. Moreover, RSSI is mandatory - we cannot send burst indications without it. Related: OS#4006 Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/39/14639/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82 Gerrit-Change-Number: 14639 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:10:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:10:25 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu... In-Reply-To: References: Message-ID: Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14640 to look at the new patch set (#2). Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() ...................................................................... Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() That's where all the filling logic happens, while in driveReceiveFIFO we mostly want to take the burst, generate a message and sent it over the socket. In pullRadioVector this way we always provide normalized values based on user configuration (VTY rssi-offset). Related: OS#4006 Change-Id: I1ee28daf21dc287bec564d45d58086d63655c0f6 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 11 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/40/14640/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1ee28daf21dc287bec564d45d58086d63655c0f6 Gerrit-Change-Number: 14640 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:10:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:10:25 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector() In-Reply-To: References: Message-ID: Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14641 to look at the new patch set (#2). Change subject: Transceiver: Move soft bits normalization to pullRadioVector() ...................................................................... Transceiver: Move soft bits normalization to pullRadioVector() That's where all the filling logic happens, while in driveReceiveFIFO we mostly want to take the burst, generate a message and sent it over the socket. Related: OS#4006 Change-Id: Ibfb48877af4ff5ef0f56390901669c8353beaf48 --- M Transceiver52M/Transceiver.cpp 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/41/14641/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ibfb48877af4ff5ef0f56390901669c8353beaf48 Gerrit-Change-Number: 14641 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:10:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:10:25 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14642 to look at the new patch set (#2). Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind ...................................................................... Transceiver: Drop use of GSM::Time from trx_ul_burst_ind Use of that class is really not needed since we don't need to do any calculation with those values, so we can simply store the final values in the struct. Related: OS#4006 Change-Id: Iadf2683d7f52138a2248598641f3b702252f325d --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 11 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/42/14642/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iadf2683d7f52138a2248598641f3b702252f325d Gerrit-Change-Number: 14642 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:10:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:10:25 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14643 to look at the new patch set (#2). Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind ...................................................................... Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind Make the interface using trx_ul_burst_ind more implementation agnostic as well as easier to use. For instance, we don't care about SoftVector size one returned from pullRadioVector(); we want to use nbits instead. As a result, we no longer spend time normalizing guard periods. While at it, change vectorSLicer to return void since it always returns true. Change-Id: I726e5a98a43367a22c9a4ca5cbd9eb87e6765c7a --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h M Transceiver52M/sigProcLib.cpp M Transceiver52M/sigProcLib.h 4 files changed, 29 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/43/14643/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I726e5a98a43367a22c9a4ca5cbd9eb87e6765c7a Gerrit-Change-Number: 14643 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:10:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:10:25 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14644 to look at the new patch set (#2). Change subject: Transceiver: replace UDPSocket with libosmocore socket API ...................................................................... Transceiver: replace UDPSocket with libosmocore socket API We have a good socket API in libosmocore, let's drop osmo-trx socket API and use libosmocore's one instead of maintaining the two of them. Change-Id: Ib19856a3e0a7607f63436c4a80b1381a3f318764 --- M CommonLibs/Makefile.am D CommonLibs/Sockets.cpp D CommonLibs/Sockets.h M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h M tests/CommonLibs/Makefile.am D tests/CommonLibs/SocketsTest.cpp D tests/CommonLibs/SocketsTest.ok M tests/testsuite.at 9 files changed, 53 insertions(+), 594 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/44/14644/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib19856a3e0a7607f63436c4a80b1381a3f318764 Gerrit-Change-Number: 14644 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:10:28 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:10:28 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move nbits burst size calculation to pullRadioVector() Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14656 Change subject: Transceiver: Move nbits burst size calculation to pullRadioVector() ...................................................................... Transceiver: Move nbits burst size calculation to pullRadioVector() That's where all the filling logic happens, while in driveReceiveFIFO we mostly want to take the burst, generate a message and sent it over the socket. Related: OS#4006 Change-Id: Ib1df10c40d737954904290f57d58b1c77d65f82e --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/56/14656/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index f04a132..a0ff4cd 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -643,6 +643,12 @@ bi->toa = toa; bi->rxBurst = demodAnyBurst(*burst, mSPSRx, amp, toa, type); + /* EDGE demodulator returns 444 (gSlotLen * 3) bits */ + if (bi->rxBurst->size() == EDGE_BURST_NBITS) + bi->nbits = EDGE_BURST_NBITS; + else /* size() here is actually gSlotLen + 8, due to guard periods */ + bi->nbits = gSlotLen; + delete radio_burst; return true; } @@ -917,7 +923,6 @@ { double dBm; // in dBm int TOAint; // in 1/256 symbols - unsigned nbits = gSlotLen; struct trx_ul_burst_ind bi; @@ -927,18 +932,12 @@ // Convert -1..+1 soft bits to 0..1 soft bits vectorSlicer(bi.rxBurst); - /* - * EDGE demodulator returns 444 (148 * 3) bits - */ - if (bi.rxBurst->size() == gSlotLen * 3) - nbits = gSlotLen * 3; - dBm = bi.rssi + rssiOffset; logRxBurst(chan, &bi, dBm); TOAint = (int) (bi.toa * 256.0 + 0.5); // round to closest integer - char burstString[sizeof(struct trxd_hdr_v0) + nbits + 2]; + char burstString[sizeof(struct trxd_hdr_v0) + bi.nbits + 2]; struct trxd_hdr_v0* pkt = (struct trxd_hdr_v0*)burstString; pkt->common.version = 0; pkt->common.reserved = 0; @@ -948,14 +947,14 @@ osmo_store16be(TOAint, &pkt->v0.toa); SoftVector::iterator burstItr = bi.rxBurst->begin(); - for (unsigned i = 0; i < nbits; i++) + for (unsigned i = 0; i < bi.nbits; i++) pkt->soft_bits[i] = (char) round((*burstItr++) * 255.0); /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi.nbits] */ - pkt->soft_bits[nbits + 1] = '\0'; + pkt->soft_bits[bi.nbits + 1] = '\0'; delete bi.rxBurst; - mDataSockets[chan]->write(burstString, sizeof(struct trxd_hdr_v0) + nbits + 2); + mDataSockets[chan]->write(burstString, sizeof(struct trxd_hdr_v0) + bi.nbits + 2); } void Transceiver::driveTxFIFO() diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index 965d07d..d7c6182 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -37,6 +37,7 @@ struct trx_ul_burst_ind { SoftVector *rxBurst; + unsigned nbits; // number of symbols per slot in rxBurst, not counting guard periods GSM::Time burstTime; double rssi; // in dBFS double toa; // in symbols -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14656 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib1df10c40d737954904290f57d58b1c77d65f82e Gerrit-Change-Number: 14656 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:10:29 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:10:29 +0000 Subject: Change in ...osmo-trx[master]: WIP: Support TRXD v1 Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14657 Change subject: WIP: Support TRXD v1 ...................................................................... WIP: Support TRXD v1 Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 --- M Transceiver52M/proto_trxd.h 1 file changed, 33 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/57/14657/1 diff --git a/Transceiver52M/proto_trxd.h b/Transceiver52M/proto_trxd.h index ef34666..de1fe49 100644 --- a/Transceiver52M/proto_trxd.h +++ b/Transceiver52M/proto_trxd.h @@ -50,3 +50,36 @@ struct trxd_hdr_v0_specific v0; uint8_t soft_bits[0]; } __attribute__ ((packed)); + + + +#define TRXD_MODULATION_GMSK(ts_set) (0b0000 | (ts_set & 0b0011)) +#define TRXD_MODULATION_8PSK(ts_set) (0b0100 | (ts_set & 0b0001)) +#define TRXD_MODULATION_AQPSK(ts_set) (0b0110 | (ts_set & 0b0001)) +#define TRXD_MODULATION_16QAM(ts_set) (0b1000 | (ts_set & 0b0001)) +#define TRXD_MODULATION_32QAM(ts_set) (0b1010 | (ts_set & 0b0001)) + + +struct trxd_hdr_v1_specific { + uint8_t rssi; + uint16_t toa; /* big endian */ + union { + uint8_t mts; +#if OSMO_IS_LITTLE_ENDIAN + uint8_t tsc:3, + modulation:4, + idle:1; +#elif OSMO_IS_BIG_ENDIAN + uint8_t idle:1, + modulation:4, + tsc:3; +#endif + }; + uint16_t ci; /* big endian */ +} __attribute__ ((packed)); + +struct trxd_hdr_v1 { + struct trxd_hdr_common common; + struct trxd_hdr_v1_specific v1; + uint8_t soft_bits[0]; +} __attribute__ ((packed)); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:16:33 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 13:16:33 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14639 ) Change subject: Transceiver: Drop unused rssi_valid struct field ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82 Gerrit-Change-Number: 14639 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 13:16:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:17:03 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 13:17:03 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move nbits burst size calculation to pullRadioVector() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14656 ) Change subject: Transceiver: Move nbits burst size calculation to pullRadioVector() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14656 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib1df10c40d737954904290f57d58b1c77d65f82e Gerrit-Change-Number: 14656 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 02 Jul 2019 13:17:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:19:15 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 13:19:15 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: add burst randomization helpers In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14648 ) Change subject: trx_toolkit/data_msg.py: add burst randomization helpers ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14648/1/src/target/trx_toolkit/data_msg.py File src/target/trx_toolkit/data_msg.py: https://gerrit.osmocom.org/#/c/14648/1/src/target/trx_toolkit/data_msg.py at 500 PS1, Line 500: sbit = random.randint(-127, 127) > Shouldn't this be encoded 254.. [?] Nope, because this is an abstract representation. "On the wire" they're encoded as 254..0. See self.gen_burst() and self.parse_burst() above. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idf1393d3d1f04e6c60b356b797a18e6f77b23554 Gerrit-Change-Number: 14648 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 13:19:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:22:55 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 13:22:55 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: implement header version coding In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14576 ) Change subject: trx_toolkit/data_msg.py: implement header version coding ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idb0377d66290eb9c15d6998a5806a84fa2e5dd02 Gerrit-Change-Number: 14576 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 13:22:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:23:00 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 13:23:00 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: introduce header coding version 0x01 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14579 ) Change subject: trx_toolkit/data_msg.py: introduce header coding version 0x01 ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie810c5a482d1c908994e8cdd32a2ea641ae7cedd Gerrit-Change-Number: 14579 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 13:23:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 13:58:03 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 13:58:03 +0000 Subject: Change in ...osmo-trx[master]: Logger: global Log mutex is now available from C code In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14645 ) Change subject: Logger: global Log mutex is now available from C code ...................................................................... Patch Set 2: > Patch Set 1: Code-Review+1 > > why do we have a log mutex in the first place? I did some research into multithreadded logging using libosmocore and found that the only critical part would be adding/removing of log targets at runtime (the linked list of log targets). However, during the actual log output / log write, as long as you don't use LOGPC, IIRC you should be fine. Every fprintf should be atomic, whether to stdout or to any other file. Hi, good point. I did some reseach and here are my conclusions: * Agree, the only "really dangerous" part seems to be log targets. Some nuisances or weird situations of not using mutex: * unordered timestamps on generated output (th1 generates timestamp, th2 preempts th1 generates timestamp and prints, th1 prints). * color tag left opened if color is disabled through VTY (log color is disabled while other thread is in the middle of generating log line). So the important cases are basically a thread calling LOGPSRC while another calls: * race conditons during llog_targets_reopen()->log_target_file_reopen() * logging_vty.c "logging enable", "log syslog local", "log gsmtap", "log stderr", etc. -> log_add_target() -> append to the list osmo_log_target_list * logging_vty.c "logging disable" -> log_del_target() -> osmo_log_target_list so I think all in all there should be a mutex. But actually the one in osmo-trx doesn't seem to be covering the VTY commands AFAICT, so it's really not useful against big issues (but it's useful against nuisances explained first). The steps to procede should be IMHO: * Keep the mutex for now in osmo-trx to at least solve nuisances. * Add some sort of multithread support in libosmocore's logging system (by adding an internal mutex around log targets (and list), and enabling using the mutex through a libosmocore public API (such as log_enable_multithread_support(bool enable)). * Once libosmocore has that multithread support, drop the osmo-trx mutex and use the libosmocore API. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I473e57479f8ae98a84ad00b76ff338f79f732236 Gerrit-Change-Number: 14645 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 13:58:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 14:02:35 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 14:02:35 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: add burst randomization helpers In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14648 ) Change subject: trx_toolkit/data_msg.py: add burst randomization helpers ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idf1393d3d1f04e6c60b356b797a18e6f77b23554 Gerrit-Change-Number: 14648 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 14:02:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 14:03:53 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 2 Jul 2019 14:03:53 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: introduce header coding version 0x01 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14579 ) Change subject: trx_toolkit/data_msg.py: introduce header coding version 0x01 ...................................................................... Patch Set 5: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14579/5/src/target/trx_toolkit/data_msg.py File src/target/trx_toolkit/data_msg.py: https://gerrit.osmocom.org/#/c/14579/5/src/target/trx_toolkit/data_msg.py at 342 PS5, Line 342: > Nope. This class represents the L12TRX (i.e. [?] Ah ok, downlink bursts then iiuc. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie810c5a482d1c908994e8cdd32a2ea641ae7cedd Gerrit-Change-Number: 14579 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 14:03:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 14:19:06 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 14:19:06 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: add burst randomization helpers In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14648 ) Change subject: trx_toolkit/data_msg.py: add burst randomization helpers ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idf1393d3d1f04e6c60b356b797a18e6f77b23554 Gerrit-Change-Number: 14648 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 02 Jul 2019 14:19:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 14:19:21 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 14:19:21 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: mark bit conversion methods as @staticmethod In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14647 ) Change subject: trx_toolkit/data_msg.py: mark bit conversion methods as @staticmethod ...................................................................... trx_toolkit/data_msg.py: mark bit conversion methods as @staticmethod Change-Id: I2f9fdd514908f186b1c6c043ee9b31c27a396900 --- M src/target/trx_toolkit/data_msg.py 1 file changed, 14 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py index 9ad19f6..511f692 100644 --- a/src/target/trx_toolkit/data_msg.py +++ b/src/target/trx_toolkit/data_msg.py @@ -108,7 +108,8 @@ return result # Converts unsigned soft-bits {254..0} to soft-bits {-127..127} - def usbit2sbit(self, bits): + @staticmethod + def usbit2sbit(bits): buf = [] for bit in bits: @@ -120,7 +121,8 @@ return buf # Converts soft-bits {-127..127} to unsigned soft-bits {254..0} - def sbit2usbit(self, bits): + @staticmethod + def sbit2usbit(bits): buf = [] for bit in bits: @@ -129,7 +131,8 @@ return buf # Converts soft-bits {-127..127} to bits {1..0} - def sbit2ubit(self, bits): + @staticmethod + def sbit2ubit(bits): buf = [] for bit in bits: @@ -138,7 +141,8 @@ return buf # Converts bits {1..0} to soft-bits {-127..127} - def ubit2sbit(self, bits): + @staticmethod + def ubit2sbit(bits): buf = [] for bit in bits: @@ -572,18 +576,18 @@ sbits_ref = list(range(-127, 128)) # Test both usbit2sbit() and sbit2usbit() - sbits = msg_trx2l1_ref.usbit2sbit(usbits_ref) - usbits = msg_trx2l1_ref.sbit2usbit(sbits) + sbits = DATAMSG.usbit2sbit(usbits_ref) + usbits = DATAMSG.sbit2usbit(sbits) assert(usbits[:255] == usbits_ref[:255]) assert(usbits[255] == 254) log.info("Check both usbit2sbit() and sbit2usbit(): OK") # Test both sbit2ubit() and ubit2sbit() - ubits = msg_trx2l1_ref.sbit2ubit(sbits_ref) + ubits = DATAMSG.sbit2ubit(sbits_ref) assert(ubits == ([1] * 127 + [0] * 128)) - sbits = msg_trx2l1_ref.ubit2sbit(ubits) + sbits = DATAMSG.ubit2sbit(ubits) assert(sbits == ([-127] * 127 + [127] * 128)) log.info("Check both sbit2ubit() and ubit2sbit(): OK") @@ -598,7 +602,7 @@ assert(msg_trx2l1_dec.fn == msg_l12trx_ref.fn) assert(msg_trx2l1_dec.tn == msg_l12trx_ref.tn) - assert(msg_l12trx_dec.burst == msg_l12trx_dec.sbit2ubit(burst_trx2l1_ref)) - assert(msg_trx2l1_dec.burst == msg_trx2l1_dec.ubit2sbit(burst_l12trx_ref)) + assert(msg_l12trx_dec.burst == DATAMSG.sbit2ubit(burst_trx2l1_ref)) + assert(msg_trx2l1_dec.burst == DATAMSG.ubit2sbit(burst_l12trx_ref)) log.info("Check L12TRX <-> TRX2L1 type transformations: OK") -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2f9fdd514908f186b1c6c043ee9b31c27a396900 Gerrit-Change-Number: 14647 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 2 14:19:21 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 2 Jul 2019 14:19:21 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: add burst randomization helpers In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14648 ) Change subject: trx_toolkit/data_msg.py: add burst randomization helpers ...................................................................... trx_toolkit/data_msg.py: add burst randomization helpers Change-Id: Idf1393d3d1f04e6c60b356b797a18e6f77b23554 --- M src/target/trx_toolkit/data_msg.py 1 file changed, 30 insertions(+), 18 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py index 511f692..86d0827 100644 --- a/src/target/trx_toolkit/data_msg.py +++ b/src/target/trx_toolkit/data_msg.py @@ -82,6 +82,10 @@ def parse_burst(self, burst): raise NotImplementedError + # Generate a random message specific burst + def rand_burst(self): + raise NotImplementedError + # Generates a random frame number def rand_fn(self): return random.randint(0, GSM_HYPERFRAME) @@ -319,6 +323,14 @@ else: self.burst = list(burst[:GSM_BURST_LEN]) + # Generate a random message specific burst + def rand_burst(self, length = GSM_BURST_LEN): + self.burst = [] + + for i in range(length): + ubit = random.randint(0, 1) + self.burst.append(ubit) + # Transforms this message to TRX2L1 message def gen_trx2l1(self): # Allocate a new message @@ -480,6 +492,14 @@ # Save self.burst = burst_sbits + # Generate a random message specific burst + def rand_burst(self, length = GSM_BURST_LEN): + self.burst = [] + + for i in range(length): + sbit = random.randint(-127, 127) + self.burst.append(sbit) + # Transforms this message to L12TRX message def gen_l12trx(self): # Allocate a new message @@ -499,28 +519,20 @@ log.basicConfig(level = log.DEBUG, format = "[%(levelname)s] %(filename)s:%(lineno)d %(message)s") - # Generate two random bursts - burst_l12trx_ref = [] - burst_trx2l1_ref = [] - - for i in range(0, GSM_BURST_LEN): - ubit = random.randint(0, 1) - burst_l12trx_ref.append(ubit) - - sbit = random.randint(-127, 127) - burst_trx2l1_ref.append(sbit) - log.info("Generating the reference messages") # Create messages of both types - msg_l12trx_ref = DATAMSG_L12TRX(burst = burst_l12trx_ref) - msg_trx2l1_ref = DATAMSG_TRX2L1(burst = burst_trx2l1_ref) + msg_l12trx_ref = DATAMSG_L12TRX() + msg_trx2l1_ref = DATAMSG_TRX2L1() # Validate header randomization for i in range(0, 100): msg_l12trx_ref.rand_hdr() msg_trx2l1_ref.rand_hdr() + msg_l12trx_ref.rand_burst() + msg_trx2l1_ref.rand_burst() + assert(msg_l12trx_ref.validate()) assert(msg_trx2l1_ref.validate()) @@ -550,9 +562,9 @@ log.info("Comparing decoded messages with the reference") # Compare bursts - assert(msg_l12trx_dec.burst == burst_l12trx_ref) - assert(msg_trx2l1_dec.burst == burst_trx2l1_ref) - assert(msg_trx2l1_legacy_dec.burst == burst_trx2l1_ref) + assert(msg_l12trx_dec.burst == msg_l12trx_ref.burst) + assert(msg_trx2l1_dec.burst == msg_trx2l1_ref.burst) + assert(msg_trx2l1_legacy_dec.burst == msg_trx2l1_ref.burst) log.info("Compare bursts: OK") @@ -602,7 +614,7 @@ assert(msg_trx2l1_dec.fn == msg_l12trx_ref.fn) assert(msg_trx2l1_dec.tn == msg_l12trx_ref.tn) - assert(msg_l12trx_dec.burst == DATAMSG.sbit2ubit(burst_trx2l1_ref)) - assert(msg_trx2l1_dec.burst == DATAMSG.ubit2sbit(burst_l12trx_ref)) + assert(msg_l12trx_dec.burst == DATAMSG.sbit2ubit(msg_trx2l1_ref.burst)) + assert(msg_trx2l1_dec.burst == DATAMSG.ubit2sbit(msg_l12trx_ref.burst)) log.info("Check L12TRX <-> TRX2L1 type transformations: OK") -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idf1393d3d1f04e6c60b356b797a18e6f77b23554 Gerrit-Change-Number: 14648 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Wed Jul 3 02:44:49 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 03 Jul 2019 02:44:49 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1c16bab5fdb_6eea925f42135455@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 528s] | This file was extended by libosmocore config.status 1.1.0.75-316d, which was [ 528s] | generated by GNU Autoconf 2.69. Invocation command line was [ 528s] | [ 528s] | CONFIG_FILES = [ 528s] | CONFIG_HEADERS = [ 528s] | CONFIG_LINKS = [ 528s] | CONFIG_COMMANDS = [ 528s] | $ ./config.status Doxyfile.core [ 528s] | [ 528s] | on armbuild24 [ 528s] | [ 528s] | config.status:1200: creating Doxyfile.core [ 528s] [ 528s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 528s] make[1]: *** [override_dh_auto_test] Error 1 [ 528s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 528s] debian/rules:15: recipe for target 'build' failed [ 528s] make: *** [build] Error 2 [ 528s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 528s] [ 528s] armbuild24 failed "build libosmocore_1.1.0.75.316d.dsc" at Wed Jul 3 02:44:32 UTC 2019. [ 528s] [ 528s] ### VM INTERACTION START ### [ 530s] [ 512.149222] sysrq: SysRq : Power Off [ 530s] [ 512.194090] reboot: Power down [ 531s] ### VM INTERACTION END ### [ 531s] [ 531s] armbuild24 failed "build libosmocore_1.1.0.75.316d.dsc" at Wed Jul 3 02:44:36 UTC 2019. [ 531s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Wed Jul 3 05:27:57 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 03 Jul 2019 05:27:57 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1c3cf14736f_6eea925f42143516@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 522s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 522s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 522s] collect2: error: ld returned 1 exit status [ 522s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 522s] make[4]: *** [osmo-bts-virtual] Error 1 [ 522s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 522s] Makefile:385: recipe for target 'all-recursive' failed [ 522s] make[3]: *** [all-recursive] Error 1 [ 522s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 522s] Makefile:434: recipe for target 'all-recursive' failed [ 522s] make[2]: *** [all-recursive] Error 1 [ 522s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 522s] Makefile:366: recipe for target 'all' failed [ 522s] make[1]: *** [all] Error 2 [ 522s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 522s] dh_auto_build: make -j1 returned exit code 2 [ 522s] debian/rules:12: recipe for target 'build' failed [ 522s] make: *** [build] Error 2 [ 522s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 522s] [ 522s] armbuild14 failed "build osmo-bts_0.8.1.331.d1e7.dsc" at Wed Jul 3 05:27:40 UTC 2019. [ 522s] [ 522s] ### VM INTERACTION START ### [ 525s] [ 476.738330] sysrq: SysRq : Power Off [ 525s] [ 476.740472] reboot: Power down [ 526s] ### VM INTERACTION END ### [ 526s] [ 526s] armbuild14 failed "build osmo-bts_0.8.1.331.d1e7.dsc" at Wed Jul 3 05:27:44 UTC 2019. [ 526s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Jul 3 06:33:22 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 3 Jul 2019 06:33:22 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: library/TRXC_Types.ttcn: add FAKE_CI command for C/I simulation Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14658 Change subject: library/TRXC_Types.ttcn: add FAKE_CI command for C/I simulation ...................................................................... library/TRXC_Types.ttcn: add FAKE_CI command for C/I simulation Change-Id: Ibbab8df117a97a3dce160c67d1adbc67c31637e2 Depends: (OsmocomBB) I7080effbbc1022d1884c6d6f0cb580eba8e514ff Related: OS#4006 --- M library/TRXC_Types.ttcn 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/14658/1 diff --git a/library/TRXC_Types.ttcn b/library/TRXC_Types.ttcn index a87266e..b67243b 100644 --- a/library/TRXC_Types.ttcn +++ b/library/TRXC_Types.ttcn @@ -19,9 +19,9 @@ type charstring TrxcVerb ("POWERON", "POWEROFF", "CLOCK", "RXTUNE", "TXTUNE", "SETSLOT", "SETTSC", "SETBSIC", "SETPOWER", "SETMAXDLY", "SETMAXDLYNB", "SETSLOT", "HANDOVER", "NOHANDOVER", - "MEASURE", "FAKE_RSSI", "FAKE_TOA" ) with { + "MEASURE", "FAKE_RSSI", "FAKE_TOA", "FAKE_CI" ) with { variant "TEXT_CODING(,convert=upper_case, - '((POWERON)|(POWEROFF)|(CLOCK)|(RXTUNE)|(TXTUNE)|(SETSLOT)|(SETTSC)|(SETBSIC)|(SETPOWER)|(SETMAXDLY)|(SETMAXDLYNB)|(HANDOVER)|(NOHANDOVER)|(MEASURE)|(FAKE_RSSI)|(FAKE_TOA))' + '((POWERON)|(POWEROFF)|(CLOCK)|(RXTUNE)|(TXTUNE)|(SETSLOT)|(SETTSC)|(SETBSIC)|(SETPOWER)|(SETMAXDLY)|(SETMAXDLYNB)|(HANDOVER)|(NOHANDOVER)|(MEASURE)|(FAKE_RSSI)|(FAKE_TOA)|(FAKE_CI))' ,case_insensitive)" } @@ -86,5 +86,12 @@ } } +template (value) TrxcMessage ts_TRXC_FAKE_CI(int16_t ci, int16_t thresh := 0) := { + cmd := { + verb := "FAKE_CI", + params := { int2str(ci), int2str(thresh) } + } +} + } with { encode "TEXT" } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibbab8df117a97a3dce160c67d1adbc67c31637e2 Gerrit-Change-Number: 14658 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 06:33:22 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 3 Jul 2019 06:33:22 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: library/L1CTL_Types.ttcn: introduce TRAFFIC_{REQ|IND} templates Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14659 Change subject: library/L1CTL_Types.ttcn: introduce TRAFFIC_{REQ|IND} templates ...................................................................... library/L1CTL_Types.ttcn: introduce TRAFFIC_{REQ|IND} templates Change-Id: Ic9f412579da33d0c76b7dd616bd1b305aacf5884 Related: OS#1855 --- M library/L1CTL_Types.ttcn 1 file changed, 42 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/59/14659/1 diff --git a/library/L1CTL_Types.ttcn b/library/L1CTL_Types.ttcn index 01214b2..77c1f6a 100644 --- a/library/L1CTL_Types.ttcn +++ b/library/L1CTL_Types.ttcn @@ -622,6 +622,24 @@ } } + template (value) L1ctlUlMessage ts_L1CTL_TRAFFIC_REQ(template (value) RslChannelNr chan_nr, + template (value) RslLinkId link_id, + octetstring frame) := { + header := ts_L1ctlHeader(L1CTL_TRAFFIC_REQ), + ul_info := { + chan_nr := chan_nr, + link_id := link_id, + padding := '0000'O + }, + ul_info_tbf := omit, + ul_info_abs := omit, + payload := { + traffic_req := { + data := frame + } + } + }; + template (value) L1ctlUlMessage ts_L1CTL_TBF_CFG_REQ(boolean is_uplink, TfiUsfArr tfi_usf) := { header := ts_L1ctlHeader(L1CTL_TBF_CFG_REQ), ul_info := omit, @@ -719,6 +737,30 @@ } }; + /* for matching against incoming TRAFFIC_IND */ + template L1ctlDlMessage tr_L1CTL_TRAFFIC_IND(template RslChannelNr chan_nr, + template RslLinkId link_id := ?, + template octetstring frame := ?, + template uint8_t num_biterr := 0, + template uint8_t fire_crc := 0) := { + header := tr_L1ctlHeader(L1CTL_TRAFFIC_IND), + dl_info := { + chan_nr := chan_nr, + link_id := link_id, + arfcn := ?, + frame_nr := ?, + rx_level := ?, + snr := ?, + num_biterr := num_biterr, + fire_crc := fire_crc + }, + payload := { + traffic_ind := { + data := frame + } + } + }; + template (value) L1ctlUlMessage ts_L1CTL_CRYPTO_REQ(RslChannelNr chan_nr, uint8_t algo, octetstring key) := { header := ts_L1ctlHeader(L1CTL_CRYPTO_REQ), -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9f412579da33d0c76b7dd616bd1b305aacf5884 Gerrit-Change-Number: 14659 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 06:33:23 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 3 Jul 2019 06:33:23 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14660 Change subject: BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb ...................................................................... BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb The idea of this test case is to verify that the link quality measurements, in particular C/I (Carrier-to-Interference ratio), are delivered to the PCU (as a part of PCUIF_DATA.ind). The C/I ratio needs to be calculated by the transceiver from the training sequence of each burst, where we can compare the "ideal" training sequence with the actual training sequence and then express that in cB (centiBels). This test case can only be executed with fake_trx.py and trxcon, because this pair allows us to simulate C/I values. Also, the new TRXD header format needs to be supported (see OS#4006). Change-Id: I67d89b2f0e13a7a6f74f001b19d37add77ec06f5 Depends: (OsmocomBB) I7080effbbc1022d1884c6d6f0cb580eba8e514ff Related: OS#1855 --- M bts/BTS_Tests.ttcn 1 file changed, 77 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/14660/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 3b27469..2ab4acc 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -422,6 +422,8 @@ /* Start with a default moderate timing offset equalling TA=2, and RSSI=-60 */ ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_TIMING(2*256))); ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_RSSI(-60))); + /* FIXME: OsmoBTS may have different AB / NB threshold (see MIN_QUAL_NORM, MIN_QUAL_RACH) */ + ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_CI(0))); } /* Wait some extra time to make sure the BTS emits a stable carrier. @@ -4312,6 +4314,80 @@ setverdict(pass); } +private function f_TC_pcu_data_ind_lqual_cb(int16_t lqual_cb_exp, int16_t thresh) +runs on test_CT { + var template PCUIF_send_data sdt; + var PCUIF_send_data sd; + var int16_t lqual_cb; + timer T := 1.0; + + /* PCUIF_DATA.ind is encapsulated into a supplementary record */ + sdt := t_SD_PCUIF_MSGT(g_pcu_conn_id, PCU_IF_MSG_DATA_IND); + + /* Send a random PDTCH frame over Um */ + L1CTL.send(ts_L1CTL_TRAFFIC_REQ(ts_RslChanNr_PDCH(7), ts_RslLinkID_DCCH(0), + '0000'O & f_rnd_octstring(21))); + + T.start; + alt { + /* If expected link quality is above the threshold */ + [lqual_cb_exp >= thresh] PCU.receive(sdt) -> value sd { + lqual_cb := sd.data.u.data_ind.lqual_cb; + log("Rx PCUIF_DATA.ind (lqual_cb=", lqual_cb, ")"); + + /* Make sure the actual link quality matches the expected value */ + if (not match(lqual_cb, lqual_cb_exp)) { + setverdict(fail, log2str("Link quality ", lqual_cb, " does not match ", + "expected value ", lqual_cb_exp)); + } else { + setverdict(pass); + } + } + /* If expected link quality is below the threshold */ + [lqual_cb_exp < thresh] PCU.receive(sdt) -> value sd { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Rx unexpected PCUIF_DATA.ind: ", sd.data)); + } + /* Ignore PCUIF_RTS.req and PCUIF_TIME.ind */ + [] PCU.receive { repeat; } + [lqual_cb_exp < thresh] T.timeout { + log("Rx nothing, as expected"); + setverdict(pass); + } + [lqual_cb_exp >= thresh] T.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "Timeout waiting for PCUIF_DATA.ind"); + } + } +} + +/* Verify C/I (Carrier-to-Interference ratio) processing of PDTCH frames */ +testcase TC_pcu_data_ind_lqual_cb() runs on test_CT { + f_init_pcu_test(); + PCU.clear; + + f_init_l1ctl(); + f_l1_tune(L1CTL); + + /* Activate a PDCH channel on TS7 */ + f_TC_pcu_act_req(0, 0, 7, true); + + /* Tune trxcon to that PDCH channel on TS7 */ + f_L1CTL_DM_EST_REQ(L1CTL, { false, mp_trx0_arfcn }, + valueof(ts_RslChanNr_PDCH(7)), 7); + + /* C/I in centiBels, test range: -256 .. +1280, step 128 */ + for (var int16_t i := -256; i <= 1280; i := i + 128) { + var TrxcMessage ret; + + ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, + valueof(ts_TRXC_FAKE_CI(i))); + + /* FIXME: OsmoBTS may have different threshold (see MIN_QUAL_NORM) */ + f_TC_pcu_data_ind_lqual_cb(i, thresh := 0); + } +} + /* Send PAGING via RSL, expect it to shw up on PCU socket */ testcase TC_pcu_paging_from_rsl() runs on test_CT { f_init_pcu_test(); @@ -6160,6 +6236,7 @@ execute( TC_pcu_data_req_imm_ass_pch() ); execute( TC_pcu_rach_content() ); execute( TC_pcu_ext_rach_content() ); + execute( TC_pcu_data_ind_lqual_cb() ); execute( TC_pcu_paging_from_rsl() ); execute( TC_pcu_time_ind() ); execute( TC_pcu_rts_req() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I67d89b2f0e13a7a6f74f001b19d37add77ec06f5 Gerrit-Change-Number: 14660 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Wed Jul 3 06:42:15 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 03 Jul 2019 06:42:15 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1c4e4a95d84_6eea925f42152254@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 646s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 646s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 646s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 646s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 646s] make[4]: *** [gb_proxy.o] Error 1 [ 646s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 646s] Makefile:391: recipe for target 'all-recursive' failed [ 646s] make[3]: *** [all-recursive] Error 1 [ 646s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 646s] Makefile:453: recipe for target 'all-recursive' failed [ 646s] make[2]: *** [all-recursive] Error 1 [ 646s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 646s] Makefile:385: recipe for target 'all' failed [ 646s] make[1]: *** [all] Error 2 [ 646s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 646s] dh_auto_build: make -j1 returned exit code 2 [ 646s] debian/rules:45: recipe for target 'build' failed [ 646s] make: *** [build] Error 2 [ 646s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 646s] [ 646s] obs-arm-6 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Wed Jul 3 06:42:01 UTC 2019. [ 646s] [ 646s] ### VM INTERACTION START ### [ 649s] [ 616.065967] sysrq: SysRq : Power Off [ 649s] [ 616.082210] reboot: Power down [ 650s] ### VM INTERACTION END ### [ 650s] [ 650s] obs-arm-6 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Wed Jul 3 06:42:05 UTC 2019. [ 650s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Wed Jul 3 06:50:15 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 03 Jul 2019 06:50:15 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1c5046562a6_6eea925f421542d0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 398s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 398s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 398s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 398s] Makefile:442: recipe for target 'vlr.o' failed [ 398s] make[4]: *** [vlr.o] Error 1 [ 398s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 398s] Makefile:422: recipe for target 'all-recursive' failed [ 398s] make[3]: *** [all-recursive] Error 1 [ 398s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 398s] Makefile:462: recipe for target 'all-recursive' failed [ 398s] make[2]: *** [all-recursive] Error 1 [ 398s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 398s] Makefile:394: recipe for target 'all' failed [ 398s] make[1]: *** [all] Error 2 [ 398s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 398s] dh_auto_build: make -j1 returned exit code 2 [ 398s] debian/rules:45: recipe for target 'build' failed [ 398s] make: *** [build] Error 2 [ 398s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 398s] [ 398s] armbuild26 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Wed Jul 3 06:49:56 UTC 2019. [ 398s] [ 398s] ### VM INTERACTION START ### [ 401s] [ 374.971434] sysrq: SysRq : Power Off [ 401s] [ 374.972836] reboot: Power down [ 401s] ### VM INTERACTION END ### [ 401s] [ 401s] armbuild26 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Wed Jul 3 06:49:59 UTC 2019. [ 401s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Jul 3 07:18:11 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 07:18:11 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support uppercase LCO options In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14589 ) Change subject: mgw: Support uppercase LCO options ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/14589/1/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/#/c/14589/1/src/libosmo-mgcp/mgcp_protocol.c at 612 PS1, Line 612: while ((lco_id = get_lco_identifier(lco_id))) { This is changing the parsing logic slightly. It is probably worth mentioning in the commit message, just in case we have a regression. Here's an example where the result would not be the same (probably not a real world use case; old code uses first p:, new code uses second p:): p:1234-1234, a:PCUM, p:2345-2345 https://gerrit.osmocom.org/#/c/14589/1/src/libosmo-mgcp/mgcp_protocol.c at 630 PS1, Line 630: "LCO: unhandled option: '%c'/%d\n", *lco_id, *lco_id); How about also logging the entire lco->string here? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic28a5eacc4c441d68e8a20d2743956ab2e01125d Gerrit-Change-Number: 14589 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 07:18:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 07:25:42 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 07:25:42 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support uppercase header parameters In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14590 ) Change subject: mgw: Support uppercase header parameters ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14590/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14590/2//COMMIT_MSG at 7 PS2, Line 7: uppercase this commit adds support for lowercase header parameters -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I48252415f9d0cd985ad097f334aa4c1665f52511 Gerrit-Change-Number: 14590 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 07:25:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 07:26:48 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 07:26:48 +0000 Subject: Change in ...osmo-mgw[master]: mgcp-cli: Support uppercase header parameters In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14594 ) Change subject: mgcp-cli: Support uppercase header parameters ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14594/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14594/1//COMMIT_MSG at 7 PS1, Line 7: uppercase lowercase -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f7b07b77c2946e9cd6f0eeca00011bd905126dd Gerrit-Change-Number: 14594 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 07:26:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 07:28:03 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 07:28:03 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support receiving uppercase connection mode In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14595 ) Change subject: mgw: Support receiving uppercase connection mode ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4da93dfc69b5585a197a7e201a1afb72c2f97030 Gerrit-Change-Number: 14595 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 07:28:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 07:30:54 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 07:30:54 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support receiving lowercase LCO codec In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14596 ) Change subject: mgw: Support receiving lowercase LCO codec ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I51dc1cdcbe2a5587769335fbecb5039ef22cae5d Gerrit-Change-Number: 14596 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 03 Jul 2019 07:30:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 07:34:08 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 07:34:08 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support uppercase LCO options In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14589 ) Change subject: mgw: Support uppercase LCO options ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14589/1/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/#/c/14589/1/src/libosmo-mgcp/mgcp_protocol.c at 612 PS1, Line 612: while ((lco_id = get_lco_identifier(lco_id))) { > This is changing the parsing logic slightly. [?] After reading https://gerrit.osmocom.org/c/osmo-mgw/+/14597/1 I realize that check_local_cx_options() takes care of the case above. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic28a5eacc4c441d68e8a20d2743956ab2e01125d Gerrit-Change-Number: 14589 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 07:34:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 07:34:54 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 07:34:54 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Make check of duplicated LCO fields case insensitive In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14597 ) Change subject: mgw: Make check of duplicated LCO fields case insensitive ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I254bfa3a2d2562441ca3a576cc8e1e7967d9c495 Gerrit-Change-Number: 14597 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 03 Jul 2019 07:34:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 07:35:41 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 07:35:41 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Allow receiving lowercase MGCP header keyword In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14598 ) Change subject: mgw: Allow receiving lowercase MGCP header keyword ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I7d1e55faddafa3c3093d38513d4a434ecf5ea5bd Gerrit-Change-Number: 14598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 03 Jul 2019 07:35:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 07:36:05 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 07:36:05 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Allow receiving lowercase X-Osmo-Ign Callid field In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14599 ) Change subject: mgw: Allow receiving lowercase X-Osmo-Ign Callid field ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifc1b3bfe6ff6922df478cea89bbbb291b5fa5706 Gerrit-Change-Number: 14599 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 03 Jul 2019 07:36:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 07:36:25 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 07:36:25 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Allow receiving uppercase noanswer keyword In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14600 ) Change subject: mgw: Allow receiving uppercase noanswer keyword ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14600 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I637cb20f0af4de33ebf6589b1aff260d57d03e7b Gerrit-Change-Number: 14600 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 03 Jul 2019 07:36:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 07:47:29 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 07:47:29 +0000 Subject: Change in ...osmo-mgw[master]: "make dist" fix for: no rule to make mgcp_common.h In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/14655 to look at the new patch set (#2). Change subject: "make dist" fix for: no rule to make mgcp_common.h ...................................................................... "make dist" fix for: no rule to make mgcp_common.h Mark osmocom/mgcp_client/mgcp_common.h as nodist, so "make dist" will not try to include it in the source tarball. This caused "make dist" to fail in a clean osmo-mgw source tree with: make[2]: *** No rule to make target 'osmocom/mgcp_client/mgcp_common.h', needed by 'distdir'. Stop. The file gets copied during make from osmocom/mgcp/mgcp_common.h (see include/osmocom/mgcp_client/Makefile.am). Therefore it is not included in the source tree and we don't need to distribute it. Related: OS#4084 Change-Id: Ia1d7b051c0924a785b0f7ec0195192e3a852ed70 --- M include/Makefile.am 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/55/14655/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia1d7b051c0924a785b0f7ec0195192e3a852ed70 Gerrit-Change-Number: 14655 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 07:48:41 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 07:48:41 +0000 Subject: Change in ...osmo-mgw[master]: "make dist" fix for: no rule to make mgcp_common.h In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14655 ) Change subject: "make dist" fix for: no rule to make mgcp_common.h ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14655/1/include/Makefile.am File include/Makefile.am: https://gerrit.osmocom.org/#/c/14655/1/include/Makefile.am at 16 PS1, Line 16: osmocom/mgcp_client/mgcp_common.h \ > This one MUST be distributed, since osmocom/mgcp_client/mgcp_client.h includes it. The file is a copy of "osmocom/mgcp/mgcp_common.h" and gets generated during make, therefore we don't need to distribute it. I've updated the commit message. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia1d7b051c0924a785b0f7ec0195192e3a852ed70 Gerrit-Change-Number: 14655 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 07:48:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Wed Jul 3 08:43:05 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 03 Jul 2019 08:43:05 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1c6aa5ca30d_6eea925f4217925d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 1287s] | config.status:1200: creating Makefile [ 1287s] | config.status:1200: creating config.h [ 1287s] | config.status:1429: executing tests/atconfig commands [ 1287s] | config.status:1429: executing depfiles commands [ 1287s] | config.status:1429: executing libtool commands [ 1287s] | configure:16841: WARNING: unrecognized options: --disable-maintainer-mode [ 1287s] | [ 1287s] | ## ---------------- ## [ 1287s] | ## Cache variables. ## [ 1287s] | ## ---------------- ## [ 1287s] | [ 1287s] | ac_cv_build=arm-unknown-linux-gnueabihf [ 1287s] | ac_cv_c_compiler_gnu=yes [ 1287s] | ac_cv_env_CC_set= [ 1287s] | ac_cv_env_CC_value= [ 1287s] | ac_cv_env_CFLAGS_set=set [ 1287s] | ac_cv_env_CFLAGS_value='-g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security' [ 1287s] | ac_cv_env_CPPFLAGS_set=set [ 1287s] | ac_cv_env_CPPFLAGS_value='-Wdate-time -D_FORTIFY_SOURCE=2' [ 1287s] | ac_cv_env_CPP_set= [ 1287s] | ac_cv_env_CPP_value= [ 1287s] | ac_cv_env_LDFLAGS_set=set [ 1287s] | ac_cv_env_LDFLAGS_value='-Wl,-z,relro -Wl,-z,now' [ 1289s] |[ 1243.562575] sysrq: SysRq : Power Off [ 1289s] [ 1243.589957] reboot: Power down [ 1290s] ### VM INTERACTION END ### [ 1290s] [ 1290s] obs-arm-5 failed "build libosmocore_1.1.0.75.316d.dsc" at Wed Jul 3 08:42:54 UTC 2019. [ 1290s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Jul 3 09:21:48 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 3 Jul 2019 09:21:48 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: implement header version coding In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14576 ) Change subject: trx_toolkit/data_msg.py: implement header version coding ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idb0377d66290eb9c15d6998a5806a84fa2e5dd02 Gerrit-Change-Number: 14576 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 09:21:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 09:21:51 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 3 Jul 2019 09:21:51 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: introduce header coding version 0x01 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14579 ) Change subject: trx_toolkit/data_msg.py: introduce header coding version 0x01 ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie810c5a482d1c908994e8cdd32a2ea641ae7cedd Gerrit-Change-Number: 14579 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 09:21:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:08:41 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:08:41 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: library/TRXC_Types.ttcn: add FAKE_CI command for C/I simulation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14658 ) Change subject: library/TRXC_Types.ttcn: add FAKE_CI command for C/I simulation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibbab8df117a97a3dce160c67d1adbc67c31637e2 Gerrit-Change-Number: 14658 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:08:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:14:58 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:14:58 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: library/L1CTL_Types.ttcn: introduce TRAFFIC_{REQ|IND} templates In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14659 ) Change subject: library/L1CTL_Types.ttcn: introduce TRAFFIC_{REQ|IND} templates ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9f412579da33d0c76b7dd616bd1b305aacf5884 Gerrit-Change-Number: 14659 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:14:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:30:16 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:30:16 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support uppercase LCO options In-Reply-To: References: Message-ID: Hello daniel, laforge, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/14589 to look at the new patch set (#2). Change subject: mgw: Support uppercase LCO options ...................................................................... mgw: Support uppercase LCO options MGCP RFC3435 (https://tools.ietf.org/html/rfc3435) states almost all text has to be handled in a case-insensitive way, except SDP parts. Related: OS#4001 Change-Id: Ic28a5eacc4c441d68e8a20d2743956ab2e01125d --- M src/libosmo-mgcp/mgcp_protocol.c M tests/mgcp/mgcp_test.c M tests/mgcp/mgcp_test.ok 3 files changed, 77 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/89/14589/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic28a5eacc4c441d68e8a20d2743956ab2e01125d Gerrit-Change-Number: 14589 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:30:16 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:30:16 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support lowercase header parameters In-Reply-To: References: Message-ID: Hello laforge, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/14590 to look at the new patch set (#3). Change subject: mgw: Support lowercase header parameters ...................................................................... mgw: Support lowercase header parameters MGCP RFC3435 (https://tools.ietf.org/html/rfc3435) states almost all text has to be handled in a case-insensitive way, except SDP parts. Related: OS#4001 Change-Id: I48252415f9d0cd985ad097f334aa4c1665f52511 --- M src/libosmo-mgcp/mgcp_protocol.c M tests/mgcp/mgcp_test.c M tests/mgcp/mgcp_test.ok 3 files changed, 18 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/90/14590/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I48252415f9d0cd985ad097f334aa4c1665f52511 Gerrit-Change-Number: 14590 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:30:16 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:30:16 +0000 Subject: Change in ...osmo-mgw[master]: mgcp-cli: Support lowercase header parameters In-Reply-To: References: Message-ID: Hello laforge, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/14594 to look at the new patch set (#2). Change subject: mgcp-cli: Support lowercase header parameters ...................................................................... mgcp-cli: Support lowercase header parameters MGCP RFC3435 (https://tools.ietf.org/html/rfc3435) states almost all text has to be handled in a case-insensitive way, except SDP parts. Related: OS#4001 Change-Id: I4f7b07b77c2946e9cd6f0eeca00011bd905126dd --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/94/14594/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f7b07b77c2946e9cd6f0eeca00011bd905126dd Gerrit-Change-Number: 14594 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:31:16 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:31:16 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14660 ) Change subject: BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I67d89b2f0e13a7a6f74f001b19d37add77ec06f5 Gerrit-Change-Number: 14660 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:31:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:33:21 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:33:21 +0000 Subject: Change in ...osmo-mgw[master]: "make dist" fix for: no rule to make mgcp_common.h In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14655 ) Change subject: "make dist" fix for: no rule to make mgcp_common.h ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14655/2/include/Makefile.am File include/Makefile.am: https://gerrit.osmocom.org/#/c/14655/2/include/Makefile.am at 15 PS2, Line 15: nobase_nodist_include_HEADERS = \ Please add a comment here explaining the same stuff you explained in the commit description (about it being copied). -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia1d7b051c0924a785b0f7ec0195192e3a852ed70 Gerrit-Change-Number: 14655 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:33:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:35:49 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:35:49 +0000 Subject: Change in ...docker-playground[master]: debian-stretch-build-dist: new Dockerfile In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14654 ) Change subject: debian-stretch-build-dist: new Dockerfile ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I991fe41a1f55ccd6a66815ec3d7f239850397d9a Gerrit-Change-Number: 14654 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:35:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:37:02 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:37:02 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support uppercase LCO options In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14589 ) Change subject: mgw: Support uppercase LCO options ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14589/1/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/#/c/14589/1/src/libosmo-mgcp/mgcp_protocol.c at 612 PS1, Line 612: while ((lco_id = get_lco_identifier(lco_id))) { > After reading https://gerrit.osmocom. [?] Yes, check_local_cx_options() takes care of it so that scenario cannot happen. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic28a5eacc4c441d68e8a20d2743956ab2e01125d Gerrit-Change-Number: 14589 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:37:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:39:44 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:39:44 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support uppercase LCO options In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14589 ) Change subject: mgw: Support uppercase LCO options ...................................................................... Patch Set 2: Code-Review+2 Adding +2 after applying osmith's comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic28a5eacc4c441d68e8a20d2743956ab2e01125d Gerrit-Change-Number: 14589 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:39:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:40:18 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:40:18 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support lowercase header parameters In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14590 ) Change subject: mgw: Support lowercase header parameters ...................................................................... Patch Set 3: Code-Review+2 Only commit description changed with fix requested, +1+1=+2. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I48252415f9d0cd985ad097f334aa4c1665f52511 Gerrit-Change-Number: 14590 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:40:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:40:30 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:40:30 +0000 Subject: Change in ...osmo-mgw[master]: mgcp-cli: Support lowercase header parameters In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14594 ) Change subject: mgcp-cli: Support lowercase header parameters ...................................................................... Patch Set 2: Code-Review+2 Only commit description changed with fix requested, +1+1=+2. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f7b07b77c2946e9cd6f0eeca00011bd905126dd Gerrit-Change-Number: 14594 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:40:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:40:54 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:40:54 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support uppercase LCO options In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14589 ) Change subject: mgw: Support uppercase LCO options ...................................................................... mgw: Support uppercase LCO options MGCP RFC3435 (https://tools.ietf.org/html/rfc3435) states almost all text has to be handled in a case-insensitive way, except SDP parts. Related: OS#4001 Change-Id: Ic28a5eacc4c441d68e8a20d2743956ab2e01125d --- M src/libosmo-mgcp/mgcp_protocol.c M tests/mgcp/mgcp_test.c M tests/mgcp/mgcp_test.ok 3 files changed, 77 insertions(+), 21 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 74926ad..9baf50d 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -590,7 +590,7 @@ static int set_local_cx_options(void *ctx, struct mgcp_lco *lco, const char *options) { - char *p_opt, *a_opt; + char *lco_id; char codec[17]; if (!options) @@ -608,18 +608,33 @@ talloc_free(lco->string); lco->string = talloc_strdup(ctx, options); - p_opt = strstr(lco->string, "p:"); - if (p_opt && sscanf(p_opt, "p:%d-%d", - &lco->pkt_period_min, &lco->pkt_period_max) == 1) - lco->pkt_period_max = lco->pkt_period_min; + lco_id = lco->string; + while ((lco_id = get_lco_identifier(lco_id))) { + switch (tolower(lco_id[0])) { + case 'p': + if (sscanf(lco_id + 1, ":%d-%d", + &lco->pkt_period_min, &lco->pkt_period_max) == 1) + lco->pkt_period_max = lco->pkt_period_min; + break; + case 'a': + /* FIXME: LCO also supports the negotiation of more then one codec. + * (e.g. a:PCMU;G726-32) But this implementation only supports a single + * codec only. */ + if (sscanf(lco_id + 1, ":%16[^,]", codec) == 1) { + talloc_free(lco->codec); + lco->codec = talloc_strdup(ctx, codec); + } + break; + default: + LOGP(DLMGCP, LOGL_NOTICE, + "LCO: unhandled option: '%c'/%d in \"%s\"\n", + *lco_id, *lco_id, lco->string); + break; + } - /* FIXME: LCO also supports the negotiation of more then one codec. - * (e.g. a:PCMU;G726-32) But this implementation only supports a single - * codec only. */ - a_opt = strstr(lco->string, "a:"); - if (a_opt && sscanf(a_opt, "a:%16[^,]", codec) == 1) { - talloc_free(lco->codec); - lco->codec = talloc_strdup(ctx, codec); + lco_id = strchr(lco_id, ','); + if (!lco_id) + break; } LOGP(DLMGCP, LOGL_DEBUG, diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index c4931b2..ab6d0ce 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -208,8 +208,24 @@ "a=rtpmap:99 AMR/8000\r\n" \ "a=ptime:40\r\n" -#define MDCX4_SO \ +/* Test different upper/lower case in options */ +#define MDCX4_PT4 \ "MDCX 18983220 1 at mgw MGCP 1.0\r\n" \ + "M: sendrecv\r" \ + "C: 2\r\n" \ + "I: %s\r\n" \ + "L: A:AMR, NT:IN\r\n" \ + "\n" \ + "v=0\r\n" \ + "o=- %s 23 IN IP4 0.0.0.0\r\n" \ + "c=IN IP4 0.0.0.0\r\n" \ + "t=0 0\r\n" \ + "m=audio 4441 RTP/AVP 99\r\n" \ + "a=rtpmap:99 AMR/8000\r\n" \ + "a=ptime:40\r\n" + +#define MDCX4_SO \ + "MDCX 18983221 1 at mgw MGCP 1.0\r\n" \ "M: sendonly\r" \ "C: 2\r\n" \ "I: %s\r\n" \ @@ -224,17 +240,17 @@ "a=ptime:40\r\n" #define MDCX4_RO \ - "MDCX 18983221 1 at mgw MGCP 1.0\r\n" \ + "MDCX 18983222 1 at mgw MGCP 1.0\r\n" \ "M: recvonly\r" \ "C: 2\r\n" \ "I: %s\r\n" \ "L: p:20, a:AMR, nt:IN\r\n" #define MDCX_TOO_LONG_CI \ - "MDCX 18983222 1 at mgw MGCP 1.0\r\n" \ + "MDCX 18983223 1 at mgw MGCP 1.0\r\n" \ "I: 123456789012345678901234567890123\n" -#define MDCX_TOO_LONG_CI_RET "510 18983222 FAIL\r\n" +#define MDCX_TOO_LONG_CI_RET "510 18983223 FAIL\r\n" #define SHORT2 "CRCX 1" #define SHORT2_RET "510 000000 FAIL\r\n" @@ -526,8 +542,9 @@ {"MDCX4_PT1", MDCX4_PT1, MDCX4_RET("18983217"), 99}, {"MDCX4_PT2", MDCX4_PT2, MDCX4_RET("18983218"), 99}, {"MDCX4_PT3", MDCX4_PT3, MDCX4_RET("18983219"), 99}, - {"MDCX4_SO", MDCX4_SO, MDCX4_RET("18983220"), 99}, - {"MDCX4_RO", MDCX4_RO, MDCX4_RO_RET("18983221"), PTYPE_IGNORE}, + {"MDCX4_PT4", MDCX4_PT4, MDCX4_RET("18983220"), 99}, + {"MDCX4_SO", MDCX4_SO, MDCX4_RET("18983221"), 99}, + {"MDCX4_RO", MDCX4_RO, MDCX4_RO_RET("18983222"), PTYPE_IGNORE}, {"DLCX", DLCX, DLCX_RET, PTYPE_IGNORE}, {"CRCX_ZYN", CRCX_ZYN, CRCX_ZYN_RET, 97}, {"EMPTY", EMPTY, EMPTY_RET}, diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok index d21eaa1..3929d79 100644 --- a/tests/mgcp/mgcp_test.ok +++ b/tests/mgcp/mgcp_test.ok @@ -193,10 +193,34 @@ Dummy packets: 2 ================================================ -Testing MDCX4_SO +Testing MDCX4_PT4 creating message from statically defined input: ---------8<--------- MDCX 18983220 1 at mgw MGCP 1.0 +M: sendrecv C: 2 +I: %s +L: A:AMR, NT:IN + +v=0 +o=- %s 23 IN IP4 0.0.0.0 +c=IN IP4 0.0.0.0 +t=0 0 +m=audio 4441 RTP/AVP 99 +a=rtpmap:99 AMR/8000 +a=ptime:40 + +---------8<--------- +checking response: +using message with patched conn_id for comparison +Response matches our expectations. +(response contains a connection id) +Dummy packets: 2 + +================================================ +Testing MDCX4_SO +creating message from statically defined input: +---------8<--------- +MDCX 18983221 1 at mgw MGCP 1.0 M: sendonly C: 2 I: %s L: p:20, a:AMR, nt:IN @@ -219,7 +243,7 @@ Testing MDCX4_RO creating message from statically defined input: ---------8<--------- -MDCX 18983221 1 at mgw MGCP 1.0 +MDCX 18983222 1 at mgw MGCP 1.0 M: recvonly C: 2 I: %s L: p:20, a:AMR, nt:IN @@ -446,7 +470,7 @@ Testing MDCX_TOO_LONG_CI creating message from statically defined input: ---------8<--------- -MDCX 18983222 1 at mgw MGCP 1.0 +MDCX 18983223 1 at mgw MGCP 1.0 I: 123456789012345678901234567890123 ---------8<--------- -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic28a5eacc4c441d68e8a20d2743956ab2e01125d Gerrit-Change-Number: 14589 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:40:55 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:40:55 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support lowercase header parameters In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14590 ) Change subject: mgw: Support lowercase header parameters ...................................................................... mgw: Support lowercase header parameters MGCP RFC3435 (https://tools.ietf.org/html/rfc3435) states almost all text has to be handled in a case-insensitive way, except SDP parts. Related: OS#4001 Change-Id: I48252415f9d0cd985ad097f334aa4c1665f52511 --- M src/libosmo-mgcp/mgcp_protocol.c M tests/mgcp/mgcp_test.c M tests/mgcp/mgcp_test.ok 3 files changed, 18 insertions(+), 20 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 9baf50d..3a4591f 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -813,7 +813,7 @@ if (!mgcp_check_param(endp, line)) continue; - switch (line[0]) { + switch (toupper(line[0])) { case 'L': local_options = (const char *)line + 3; break; @@ -831,7 +831,6 @@ mode = (const char *)line + 3; break; case 'X': - case 'x': if (strncasecmp("Osmux: ", line + 2, strlen("Osmux: ")) == 0) { /* If osmux is disabled, just skip setting it up */ if (!p->endp->cfg->osmux) @@ -1090,7 +1089,7 @@ if (!mgcp_check_param(endp, line)) continue; - switch (line[0]) { + switch (toupper(line[0])) { case 'C': if (mgcp_verify_call_id(endp, line + 3) != 0) { rate_ctr_inc(&rate_ctrs->ctr[MGCP_MDCX_FAIL_INVALID_CALLID]); @@ -1115,7 +1114,6 @@ silent = strcmp("noanswer", line + 3) == 0; break; case 'X': - case 'x': if (strncasecmp("Osmux: ", line + 2, strlen("Osmux: ")) == 0) { /* If osmux is disabled, just skip setting it up */ if (!p->endp->cfg->osmux) @@ -1314,7 +1312,7 @@ if (!mgcp_check_param(endp, line)) continue; - switch (line[0]) { + switch (toupper(line[0])) { case 'C': if (mgcp_verify_call_id(endp, line + 3) != 0) { error_code = 516; @@ -1465,7 +1463,7 @@ LOGP(DLMGCP, LOGL_NOTICE, "RQNT: processing request for notification ...\n"); for_each_line(line, p->save) { - switch (line[0]) { + switch (toupper(line[0])) { case 'S': tone = extract_tone(line); break; diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index ab6d0ce..c67b9d5 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -211,10 +211,10 @@ /* Test different upper/lower case in options */ #define MDCX4_PT4 \ "MDCX 18983220 1 at mgw MGCP 1.0\r\n" \ - "M: sendrecv\r" \ - "C: 2\r\n" \ - "I: %s\r\n" \ - "L: A:AMR, NT:IN\r\n" \ + "m: sendrecv\r" \ + "c: 2\r\n" \ + "i: %s\r\n" \ + "l: A:AMR, NT:IN\r\n" \ "\n" \ "v=0\r\n" \ "o=- %s 23 IN IP4 0.0.0.0\r\n" \ @@ -260,7 +260,7 @@ #define CRCX \ "CRCX 2 1 at mgw MGCP 1.0\r\n" \ - "M: recvonly\r\n" \ + "m: recvonly\r\n" \ "C: 2\r\n" \ "L: p:20\r\n" \ "\r\n" \ diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok index 3929d79..08ea438 100644 --- a/tests/mgcp/mgcp_test.ok +++ b/tests/mgcp/mgcp_test.ok @@ -65,7 +65,7 @@ creating message from statically defined input: ---------8<--------- CRCX 2 1 at mgw MGCP 1.0 -M: recvonly +m: recvonly C: 2 L: p:20 @@ -197,9 +197,9 @@ creating message from statically defined input: ---------8<--------- MDCX 18983220 1 at mgw MGCP 1.0 -M: sendrecv C: 2 -I: %s -L: A:AMR, NT:IN +m: sendrecv c: 2 +i: %s +l: A:AMR, NT:IN v=0 o=- %s 23 IN IP4 0.0.0.0 @@ -383,7 +383,7 @@ creating message from statically defined input: ---------8<--------- CRCX 2 1 at mgw MGCP 1.0 -M: recvonly +m: recvonly C: 2 L: p:20 @@ -508,7 +508,7 @@ creating message from statically defined input: ---------8<--------- CRCX 2 1 at mgw MGCP 1.0 -M: recvonly +m: recvonly C: 2 L: p:20 @@ -526,7 +526,7 @@ creating message from statically defined input: ---------8<--------- CRCX 2 1 at mgw MGCP 1.0 -M: recvonly +m: recvonly C: 2 L: p:20 @@ -638,7 +638,7 @@ creating message from statically defined input: ---------8<--------- CRCX 2 1 at mgw MGCP 1.0 -M: recvonly +m: recvonly C: 2 L: p:20 @@ -1189,7 +1189,7 @@ creating message from statically defined input: ---------8<--------- CRCX 2 1 at mgw MGCP 1.0 -M: recvonly +m: recvonly C: 2 L: p:20 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I48252415f9d0cd985ad097f334aa4c1665f52511 Gerrit-Change-Number: 14590 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:40:55 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:40:55 +0000 Subject: Change in ...osmo-mgw[master]: mgcp-cli: Support lowercase header parameters In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14594 ) Change subject: mgcp-cli: Support lowercase header parameters ...................................................................... mgcp-cli: Support lowercase header parameters MGCP RFC3435 (https://tools.ietf.org/html/rfc3435) states almost all text has to be handled in a case-insensitive way, except SDP parts. Related: OS#4001 Change-Id: I4f7b07b77c2946e9cd6f0eeca00011bd905126dd --- M src/libosmo-mgcp-client/mgcp_client.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index f2204e1..fd188c3 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -35,6 +35,7 @@ #include #include #include +#include #ifndef OSMUX_CID_MAX #define OSMUX_CID_MAX 255 /* FIXME: use OSMUX_CID_MAX from libosmo-netif? */ @@ -573,7 +574,7 @@ *data_end = '\0'; for_each_non_empty_line(line, data_ptr) { - switch (line[0]) { + switch (toupper(line[0])) { case 'Z': rc = mgcp_parse_head_param(r->head.endpoint, sizeof(r->head.endpoint), @@ -603,7 +604,6 @@ goto exit; break; case 'X': - case 'x': if (strncasecmp("Osmux: ", line + 2, strlen("Osmux: ")) == 0) { rc = mgcp_parse_osmux_cid(line); if (rc < 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14594 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4f7b07b77c2946e9cd6f0eeca00011bd905126dd Gerrit-Change-Number: 14594 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:40:56 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:40:56 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support receiving uppercase connection mode In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14595 ) Change subject: mgw: Support receiving uppercase connection mode ...................................................................... mgw: Support receiving uppercase connection mode MGCP RFC3435 (https://tools.ietf.org/html/rfc3435) states almost all text has to be handled in a case-insensitive way, except SDP parts. Related: OS#4001 Change-Id: I4da93dfc69b5585a197a7e201a1afb72c2f97030 --- M src/libosmo-mgcp/mgcp_msg.c M tests/mgcp/mgcp_test.c M tests/mgcp/mgcp_test.ok 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_msg.c b/src/libosmo-mgcp/mgcp_msg.c index 59e0e91..44589d1 100644 --- a/src/libosmo-mgcp/mgcp_msg.c +++ b/src/libosmo-mgcp/mgcp_msg.c @@ -91,13 +91,13 @@ if (!endp) return -1; - if (strcmp(mode, "recvonly") == 0) + if (strcasecmp(mode, "recvonly") == 0) conn->mode = MGCP_CONN_RECV_ONLY; - else if (strcmp(mode, "sendrecv") == 0) + else if (strcasecmp(mode, "sendrecv") == 0) conn->mode = MGCP_CONN_RECV_SEND; - else if (strcmp(mode, "sendonly") == 0) + else if (strcasecmp(mode, "sendonly") == 0) conn->mode = MGCP_CONN_SEND_ONLY; - else if (strcmp(mode, "loopback") == 0) + else if (strcasecmp(mode, "loopback") == 0) conn->mode = MGCP_CONN_LOOPBACK; else { LOGPCONN(conn, DLMGCP, LOGL_ERROR, diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index c67b9d5..5a14bdf 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -165,7 +165,7 @@ #define MDCX4_PT1 \ "MDCX 18983217 1 at mgw MGCP 1.0\r\n" \ - "M: sendrecv\r" \ + "M: SENDRECV\r" \ "C: 2\r\n" \ "I: %s\r\n" \ "L: p:20-40, a:AMR, nt:IN\r\n" \ diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok index 08ea438..358a85c 100644 --- a/tests/mgcp/mgcp_test.ok +++ b/tests/mgcp/mgcp_test.ok @@ -125,7 +125,7 @@ creating message from statically defined input: ---------8<--------- MDCX 18983217 1 at mgw MGCP 1.0 -M: sendrecv C: 2 +M: SENDRECV C: 2 I: %s L: p:20-40, a:AMR, nt:IN -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4da93dfc69b5585a197a7e201a1afb72c2f97030 Gerrit-Change-Number: 14595 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:40:56 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:40:56 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Support receiving lowercase LCO codec In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14596 ) Change subject: mgw: Support receiving lowercase LCO codec ...................................................................... mgw: Support receiving lowercase LCO codec MGCP RFC3435 (https://tools.ietf.org/html/rfc3435) states almost all text has to be handled in a case-insensitive way, except SDP parts. Related: OS#4001 Change-Id: I51dc1cdcbe2a5587769335fbecb5039ef22cae5d --- M src/libosmo-mgcp/mgcp_codec.c M src/libosmo-mgcp/mgcp_protocol.c M tests/mgcp/mgcp_test.c M tests/mgcp/mgcp_test.ok 4 files changed, 10 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve dexter: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_codec.c b/src/libosmo-mgcp/mgcp_codec.c index 8bf0564..8be4c3c 100644 --- a/src/libosmo-mgcp/mgcp_codec.c +++ b/src/libosmo-mgcp/mgcp_codec.c @@ -99,7 +99,7 @@ conn->end.codec = NULL; } -/* Set members of struct mgcp_rtp_codec, extrapolate in missing information */ +/* Set members of struct mgcp_rtp_codec, extrapolate in missing information. Param audio_name is expected in uppercase. */ static int codec_set(void *ctx, struct mgcp_rtp_codec *codec, int payload_type, const char *audio_name, unsigned int pt_offset, struct mgcp_codec_param *param) { @@ -239,7 +239,7 @@ * \param[out] codec configuration (caller provided memory). * \param[out] conn related rtp-connection. * \param[in] payload_type codec type id (e.g. 3 for GSM, -1 when undefined). - * \param[in] audio_name audio codec name (e.g. "GSM/8000/1"). + * \param[in] audio_name audio codec name, in uppercase (e.g. "GSM/8000/1"). * \param[in] param optional codec parameters (set to NULL when unused). * \returns 0 on success, -EINVAL on failure. */ int mgcp_codec_add(struct mgcp_conn_rtp *conn, int payload_type, const char *audio_name, struct mgcp_codec_param *param) diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 3a4591f..6d9bd70 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -592,6 +592,7 @@ { char *lco_id; char codec[17]; + int len; if (!options) return 0; @@ -622,7 +623,11 @@ * codec only. */ if (sscanf(lco_id + 1, ":%16[^,]", codec) == 1) { talloc_free(lco->codec); - lco->codec = talloc_strdup(ctx, codec); + /* MGCP header is case insensive, and we'll need + codec in uppercase when using it later: */ + len = strlen(codec); + lco->codec = talloc_size(ctx, len + 1); + osmo_str_toupper_buf(lco->codec, len + 1, codec); } break; default: diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index 5a14bdf..39fe5d0 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -214,7 +214,7 @@ "m: sendrecv\r" \ "c: 2\r\n" \ "i: %s\r\n" \ - "l: A:AMR, NT:IN\r\n" \ + "l: A:amr, NT:IN\r\n" \ "\n" \ "v=0\r\n" \ "o=- %s 23 IN IP4 0.0.0.0\r\n" \ diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok index 358a85c..6f4da10 100644 --- a/tests/mgcp/mgcp_test.ok +++ b/tests/mgcp/mgcp_test.ok @@ -199,7 +199,7 @@ MDCX 18983220 1 at mgw MGCP 1.0 m: sendrecv c: 2 i: %s -l: A:AMR, NT:IN +l: A:amr, NT:IN v=0 o=- %s 23 IN IP4 0.0.0.0 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I51dc1cdcbe2a5587769335fbecb5039ef22cae5d Gerrit-Change-Number: 14596 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:40:57 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:40:57 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Make check of duplicated LCO fields case insensitive In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14597 ) Change subject: mgw: Make check of duplicated LCO fields case insensitive ...................................................................... mgw: Make check of duplicated LCO fields case insensitive Otherwise it would not catch a duplicate if first the param is introduced in upper case and later in lower case, or the other way around. MGCP RFC3435 (https://tools.ietf.org/html/rfc3435) states almost all text has to be handled in a case-insensitive way, except SDP parts. Related: OS#4001 Change-Id: I254bfa3a2d2562441ca3a576cc8e1e7967d9c495 --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 6d9bd70..fa41a8a 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -559,7 +559,7 @@ * before. If yes, we must bail, an LCO must only appear once * in the LCO string */ for (i = 0; i < lco_seen_n; i++) { - if (strcmp(lco_seen[i], lco_identifier) == 0) + if (strcasecmp(lco_seen[i], lco_identifier) == 0) goto error; } lco_seen[lco_seen_n] = lco_identifier; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I254bfa3a2d2562441ca3a576cc8e1e7967d9c495 Gerrit-Change-Number: 14597 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:40:57 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:40:57 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Allow receiving lowercase MGCP header keyword In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14598 ) Change subject: mgw: Allow receiving lowercase MGCP header keyword ...................................................................... mgw: Allow receiving lowercase MGCP header keyword MGCP RFC3435 (https://tools.ietf.org/html/rfc3435) states almost all text has to be handled in a case-insensitive way, except SDP parts. Related: OS#4001 Change-Id: I7d1e55faddafa3c3093d38513d4a434ecf5ea5bd --- M src/libosmo-mgcp/mgcp_msg.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_msg.c b/src/libosmo-mgcp/mgcp_msg.c index 44589d1..3e95ed1 100644 --- a/src/libosmo-mgcp/mgcp_msg.c +++ b/src/libosmo-mgcp/mgcp_msg.c @@ -325,7 +325,7 @@ } break; case 2: - if (strcmp("MGCP", elem)) { + if (strcasecmp("MGCP", elem)) { LOGP(DLMGCP, LOGL_ERROR, "MGCP header parsing error\n"); return -510; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I7d1e55faddafa3c3093d38513d4a434ecf5ea5bd Gerrit-Change-Number: 14598 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:40:58 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:40:58 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Allow receiving lowercase X-Osmo-Ign Callid field In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14599 ) Change subject: mgw: Allow receiving lowercase X-Osmo-Ign Callid field ...................................................................... mgw: Allow receiving lowercase X-Osmo-Ign Callid field MGCP RFC3435 (https://tools.ietf.org/html/rfc3435) states almost all text has to be handled in a case-insensitive way, except SDP parts. Related: OS#4001 Change-Id: Ifc1b3bfe6ff6922df478cea89bbbb291b5fa5706 --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index fa41a8a..7683f4e 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -785,7 +785,7 @@ if (!token) break; - if (!strcmp(token, "C")) + if (!strcasecmp(token, "C")) endp->x_osmo_ign |= MGCP_X_OSMO_IGN_CALLID; else LOGPENDP(endp, DLMGCP, LOGL_ERROR, "received unknown X-Osmo-IGN item '%s'\n", token); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifc1b3bfe6ff6922df478cea89bbbb291b5fa5706 Gerrit-Change-Number: 14599 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:40:58 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 10:40:58 +0000 Subject: Change in ...osmo-mgw[master]: mgw: Allow receiving uppercase noanswer keyword In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14600 ) Change subject: mgw: Allow receiving uppercase noanswer keyword ...................................................................... mgw: Allow receiving uppercase noanswer keyword MGCP RFC3435 (https://tools.ietf.org/html/rfc3435) states almost all text has to be handled in a case-insensitive way, except SDP parts. Related: OS#4001 Change-Id: I637cb20f0af4de33ebf6589b1aff260d57d03e7b --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 7683f4e..b596044 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -1116,7 +1116,7 @@ mode = (const char *)line + 3; break; case 'Z': - silent = strcmp("noanswer", line + 3) == 0; + silent = strcasecmp("noanswer", line + 3) == 0; break; case 'X': if (strncasecmp("Osmux: ", line + 2, strlen("Osmux: ")) == 0) { @@ -1333,7 +1333,7 @@ } break; case 'Z': - silent = strcmp("noanswer", line + 3) == 0; + silent = strcasecmp("noanswer", line + 3) == 0; break; default: LOGPENDP(endp, DLMGCP, LOGL_NOTICE, -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14600 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I637cb20f0af4de33ebf6589b1aff260d57d03e7b Gerrit-Change-Number: 14600 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:52:11 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Jul 2019 10:52:11 +0000 Subject: Change in ...docker-playground[master]: debian-stretch-build-dist: new Dockerfile In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14654 ) Change subject: debian-stretch-build-dist: new Dockerfile ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I991fe41a1f55ccd6a66815ec3d7f239850397d9a Gerrit-Change-Number: 14654 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:52:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:52:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Jul 2019 10:52:36 +0000 Subject: Change in ...osmo-ci[master]: common.sh: osmo_git_last_commits_tags: add "all" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14649 ) Change subject: common.sh: osmo_git_last_commits_tags: add "all" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I684c6881915831b33b679e8ae873213beb034ab7 Gerrit-Change-Number: 14649 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:52:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:53:40 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Jul 2019 10:53:40 +0000 Subject: Change in ...osmo-ci[master]: osmocom-list-commits: move repo list to common.sh In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14650 ) Change subject: osmocom-list-commits: move repo list to common.sh ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I954b1d5229c44ebcec7e7228f2565a5c6755d16c Gerrit-Change-Number: 14650 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:53:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:54:09 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Jul 2019 10:54:09 +0000 Subject: Change in ...osmo-ci[master]: scripts: add osmocom-release-tarballs.sh In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14651 ) Change subject: scripts: add osmocom-release-tarballs.sh ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0a904c26e1c45aa46ddc59a01b776f2c7c5f947d Gerrit-Change-Number: 14651 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:54:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:54:32 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Jul 2019 10:54:32 +0000 Subject: Change in ...osmo-ci[master]: common.sh: add docker_images_require In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14652 ) Change subject: common.sh: add docker_images_require ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic4519ccb6978793054869862f8ca0e21d9cf5be4 Gerrit-Change-Number: 14652 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:54:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:54:48 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Jul 2019 10:54:48 +0000 Subject: Change in ...osmo-ci[master]: jobs: add osmocom-release-tarballs.yml In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14653 ) Change subject: jobs: add osmocom-release-tarballs.yml ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I994da5c27f9198e5bcf2d567dd473f9ed078d9c0 Gerrit-Change-Number: 14653 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:54:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:54:57 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 3 Jul 2019 10:54:57 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: implement header version coding In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14576 ) Change subject: trx_toolkit/data_msg.py: implement header version coding ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idb0377d66290eb9c15d6998a5806a84fa2e5dd02 Gerrit-Change-Number: 14576 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:54:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:55:31 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Jul 2019 10:55:31 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14639 ) Change subject: Transceiver: Drop unused rssi_valid struct field ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82 Gerrit-Change-Number: 14639 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 10:55:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:58:13 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Jul 2019 10:58:13 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move nbits burst size calculation to pullRadioVector() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14656 ) Change subject: Transceiver: Move nbits burst size calculation to pullRadioVector() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14656 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib1df10c40d737954904290f57d58b1c77d65f82e Gerrit-Change-Number: 14656 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Jul 2019 10:58:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:58:25 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Jul 2019 10:58:25 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 ) Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1ee28daf21dc287bec564d45d58086d63655c0f6 Gerrit-Change-Number: 14640 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Jul 2019 10:58:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 10:58:32 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Jul 2019 10:58:32 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14641 ) Change subject: Transceiver: Move soft bits normalization to pullRadioVector() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ibfb48877af4ff5ef0f56390901669c8353beaf48 Gerrit-Change-Number: 14641 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 03 Jul 2019 10:58:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:00:07 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Jul 2019 11:00:07 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib19856a3e0a7607f63436c4a80b1381a3f318764 Gerrit-Change-Number: 14644 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 03 Jul 2019 11:00:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:02:47 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 3 Jul 2019 11:02:47 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14632 ) Change subject: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts ...................................................................... Patch Set 4: I still don't think it's a good idea to merge this. Let's keep the old as-is, and switch to the new v1. Don't try to fix v0 now. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iedc54011f333f48c6c8b81cab4d640f7601e01dd Gerrit-Change-Number: 14632 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 03 Jul 2019 11:02:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:10:20 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 3 Jul 2019 11:10:20 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: introduce header coding version 0x01 In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14579 ) Change subject: trx_toolkit/data_msg.py: introduce header coding version 0x01 ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie810c5a482d1c908994e8cdd32a2ea641ae7cedd Gerrit-Change-Number: 14579 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 11:10:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:10:49 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 3 Jul 2019 11:10:49 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: legacy flag is only for version 0x00 In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14584 ) Change subject: trx_toolkit/data_msg.py: legacy flag is only for version 0x00 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14584 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4d6c0bf54649d636ea6cb3fa2f37486b6619d5b3 Gerrit-Change-Number: 14584 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 11:10:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:14:35 2019 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Wed, 3 Jul 2019 11:14:35 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts/scheduler: provide actual C/I values to OsmoPCU In-Reply-To: References: Message-ID: tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14613 ) Change subject: osmo-bts/scheduler: provide actual C/I values to OsmoPCU ...................................................................... Patch Set 3: Code-Review+1 (1 comment) This change is ready for review. https://gerrit.osmocom.org/#/c/14613/3/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14613/3/src/osmo-bts-trx/scheduler_trx.c at 986 PS3, Line 986: uint8_t *ci_cb_num = &chan_state->ci_cb_num; > picky comment: Can we name it ci_cb_count? otherwise it's difficult to differentiate it with ci_cb_s [?] But they're already all named _num ... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia58043bd2381a4d34d604522e02899ae64ee0d26 Gerrit-Change-Number: 14613 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Wed, 03 Jul 2019 11:14:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:25:44 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 3 Jul 2019 11:25:44 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14586 ) Change subject: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7080effbbc1022d1884c6d6f0cb580eba8e514ff Gerrit-Change-Number: 14586 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 11:25:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:35:42 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:35:42 +0000 Subject: Change in ...docker-playground[master]: debian-stretch-build-dist: new Dockerfile In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14654 ) Change subject: debian-stretch-build-dist: new Dockerfile ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I991fe41a1f55ccd6a66815ec3d7f239850397d9a Gerrit-Change-Number: 14654 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 11:35:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:35:50 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:35:50 +0000 Subject: Change in ...docker-playground[master]: debian-stretch-build-dist: new Dockerfile In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14654 ) Change subject: debian-stretch-build-dist: new Dockerfile ...................................................................... debian-stretch-build-dist: new Dockerfile Provide all build dependencies needed to pass ./configure of most Osmocom repositories. This will be used to run osmo-release-tarballs.sh in jenkins. Related: OS#3870 Change-Id: I991fe41a1f55ccd6a66815ec3d7f239850397d9a --- A debian-stretch-build-dist/Dockerfile A debian-stretch-build-dist/Makefile A debian-stretch-build-dist/Release.key 3 files changed, 59 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved osmith: Verified diff --git a/debian-stretch-build-dist/Dockerfile b/debian-stretch-build-dist/Dockerfile new file mode 100644 index 0000000..a1f0290 --- /dev/null +++ b/debian-stretch-build-dist/Dockerfile @@ -0,0 +1,38 @@ +ARG USER +FROM $USER/debian-stretch-build + +ARG OSMOCOM_REPO="http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/" + +COPY Release.key /tmp/Release.key + +RUN apt-key add /tmp/Release.key && \ + rm /tmp/Release.key && \ + echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-latest.list + +ADD $OSMOCOM_REPO/Release /tmp/Release +RUN apt-get update && \ + apt-get install -y --no-install-recommends \ + ca-certificates \ + libboost-all-dev \ + liboping-dev \ + libuhd-dev \ + \ + libasn1c-dev \ + libgtp-dev \ + libgtpnl-dev \ + liblimesuite-dev \ + liborcania-dev \ + libosmo-abis-dev \ + libosmocore-dev \ + libosmodsp-dev \ + libosmo-gsup-client-dev \ + libosmo-mgcp-client-dev \ + libosmo-netif-dev \ + libosmo-ranap-dev \ + libosmo-sccp-dev \ + libosmo-sigtran-dev \ + libsmpp34-dev \ + libulfius-dev \ + libusrp-dev \ + libyder-dev && \ + apt-get clean diff --git a/debian-stretch-build-dist/Makefile b/debian-stretch-build-dist/Makefile new file mode 100644 index 0000000..8d0e10b --- /dev/null +++ b/debian-stretch-build-dist/Makefile @@ -0,0 +1 @@ +include ../make/Makefile diff --git a/debian-stretch-build-dist/Release.key b/debian-stretch-build-dist/Release.key new file mode 100644 index 0000000..e656238 --- /dev/null +++ b/debian-stretch-build-dist/Release.key @@ -0,0 +1,20 @@ +-----BEGIN PGP PUBLIC KEY BLOCK----- +Version: GnuPG v1.4.5 (GNU/Linux) + +mQENBFJBt/wBCADAht3d/ilNuyzaXYw/QwTRvmjyoDvfXw+H/3Fvk1zlDZoiKPPc +a1wCVBINUZl7vYM2OXqbJwYa++JP2Q48xKSvC6thbRc/YLievkbcvTemf7IaREfl +CTjoYpoqXHa9kHMw1aALDm8CNU88jZmnV7v9L6hKkbYDxie+jpoj7D6B9JlxgNJ4 +5dQyRNsFGVcIl4Vplt1HyGc5Q5nQI/VgS2rlF/IOXmhRQBc4LEDdU8R2IKnkU4ee +S7TWanAigGAQhxGuCkS39/CWzc1DhLhjlNhBl/+RTPejkqJtAy00ZLps3+RqUN1Y +CU/Fsr7aRlYVGqQ/BlptwV0XQ2VVYJX2oEBBABEBAAG0MG5ldHdvcmsgT0JTIFBy +b2plY3QgPG5ldHdvcmtAYnVpbGQub3BlbnN1c2Uub3JnPokBPAQTAQIAJgUCWmMc +aQIbAwUJDEAUbQYLCQgHAwIEFQIIAwQWAgMBAh4BAheAAAoJEGLrGgkXKA3fjsoI +ALSXmXzFCpTxg8a6tvXkqddY/qAmeBMNUf7hslI9wN3leNmCrnuHS8TbHWYJZgtw +8M5fKL3aRQYaIiqqm1XOUF0OqwYNDj5V3y38mM68NYOkzgSP7foMwZp9Y0TlGhtI +L8weA+2RUjB4hwwGMAYMqkRZyKW3NhPqdlGGoXac1ilwEyGXFHdOLbkhtyS+P2yb +/EvaKIN5cMLzRZKeYgdp9WuAirV+yV/SDbgvabW098lrWhGLltlRRDQgMV883p8I +ERMI1wlLFZGnHL3mfBWGeQ24M/DaBOdXQDtfBLCJ9nGztmDBUb8i6GFWU7nD2TGi +8mYUsED1ZDwO/0jdvJ4gSluIRgQTEQIABgUCUkG3/AAKCRA7MBG3a51lIzhdAJ9v +d6XPffMZRcCGgDEY5OaTn/MsCQCgrXbeZpFJgnirSrc8rRonvzYFiF4= +=Gvly +-----END PGP PUBLIC KEY BLOCK----- -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I991fe41a1f55ccd6a66815ec3d7f239850397d9a Gerrit-Change-Number: 14654 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:38:35 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:38:35 +0000 Subject: Change in ...osmo-ci[master]: common.sh: osmo_git_last_commits_tags: add "all" In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14649 ) Change subject: common.sh: osmo_git_last_commits_tags: add "all" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I684c6881915831b33b679e8ae873213beb034ab7 Gerrit-Change-Number: 14649 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 11:38:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:38:38 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:38:38 +0000 Subject: Change in ...osmo-ci[master]: common.sh: osmo_git_last_commits_tags: add "all" In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14649 ) Change subject: common.sh: osmo_git_last_commits_tags: add "all" ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I684c6881915831b33b679e8ae873213beb034ab7 Gerrit-Change-Number: 14649 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 11:38:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:38:43 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:38:43 +0000 Subject: Change in ...osmo-ci[master]: common.sh: osmo_git_last_commits_tags: add "all" In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/14649 ) Change subject: common.sh: osmo_git_last_commits_tags: add "all" ...................................................................... common.sh: osmo_git_last_commits_tags: add "all" Allow printing all tags instead of only the N most recent ones. Related: OS#3870 Change-Id: I684c6881915831b33b679e8ae873213beb034ab7 --- M scripts/common.sh 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/scripts/common.sh b/scripts/common.sh index 0a32c31..30ab53f 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -16,7 +16,7 @@ # Print last tags and related commits for an Osmocom git repository, e.g.: # "ec798b89700dcca5c5b28edf1a1cd16ea311f30a refs/tags/1.0.1" # $1: Osmocom repository -# $2: amount of commit, tag pairs to print (default: 1) +# $2: amount of commit, tag pairs to print (default: 1, set to "all" to print all) # $3: string to print when there are no tags (default: empty string) osmo_git_last_commits_tags() { # git output: @@ -31,7 +31,9 @@ ret="$(git ls-remote --tags "$OSMO_GIT_URL/$1")" ret="$(echo "$ret" | grep 'refs/tags/[0-9.]*$' || true)" ret="$(echo "$ret" | sort -V -t/ -k3)" - ret="$(echo "$ret" | tail -n "$2")" + if [ "$2" != "all" ]; then + ret="$(echo "$ret" | tail -n "$2")" + fi if [ -n "$ret" ]; then echo "$ret" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I684c6881915831b33b679e8ae873213beb034ab7 Gerrit-Change-Number: 14649 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:38:55 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:38:55 +0000 Subject: Change in ...osmo-ci[master]: osmocom-list-commits: move repo list to common.sh In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14650 ) Change subject: osmocom-list-commits: move repo list to common.sh ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I954b1d5229c44ebcec7e7228f2565a5c6755d16c Gerrit-Change-Number: 14650 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 11:38:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:39:02 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:39:02 +0000 Subject: Change in ...osmo-ci[master]: osmocom-list-commits: move repo list to common.sh In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/14650 ) Change subject: osmocom-list-commits: move repo list to common.sh ...................................................................... osmocom-list-commits: move repo list to common.sh Prepare for new script, which will use the same list of repositories. Related: OS#3870 Change-Id: I954b1d5229c44ebcec7e7228f2565a5c6755d16c --- M scripts/common.sh M scripts/osmocom-list-commits.sh 2 files changed, 26 insertions(+), 23 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved osmith: Verified diff --git a/scripts/common.sh b/scripts/common.sh index 30ab53f..2cf31a5 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -2,6 +2,31 @@ # Various functions and variables used in multiple osmo-ci shell scripts OSMO_GIT_URL="https://git.osmocom.org" +# Osmocom repositories of which we want to build release tarballs automatically, and list the current versions at +# https://jenkins.osmocom.org/jenkins/job/Osmocom-list-commits/lastSuccessfulBuild/artifact/commits.txt +OSMO_RELEASE_REPOS=" + libasn1c + libosmo-abis + libosmocore + libosmo-netif + libosmo-sccp + libsmpp34 + libusrp + osmo-bsc + osmo-bts + osmo-ggsn + osmo-hlr + osmo-iuh + osmo-mgw + osmo-msc + osmo-pcu + osmo-sgsn + osmo-sip-connector + osmo-sysmon + osmo-trx + osmocom-bb +" + # Print commit of HEAD for an Osmocom git repository, e.g.: # "f90496f577e78944ce8db1aa5b900477c1e479b0" # $1: repository diff --git a/scripts/osmocom-list-commits.sh b/scripts/osmocom-list-commits.sh index e0d3eb0..b584195 100755 --- a/scripts/osmocom-list-commits.sh +++ b/scripts/osmocom-list-commits.sh @@ -4,28 +4,6 @@ . "$(dirname "$0")/common.sh" FORMAT_STR="%-22s %-42s %9s %-40s %s\n" -REPOS=" - libasn1c - libosmo-abis - libosmocore - libosmo-netif - libosmo-sccp - libsmpp34 - libusrp - osmo-bsc - osmo-bts - osmo-ggsn - osmo-hlr - osmo-iuh - osmo-mgw - osmo-msc - osmo-pcu - osmo-sgsn - osmo-sip-connector - osmo-sysmon - osmo-trx - osmocom-bb -" # Header if [ -z "$NO_HEADER" ]; then @@ -33,7 +11,7 @@ fi # Table -for repo in $REPOS; do +for repo in $OSMO_RELEASE_REPOS; do last_tag="$(osmo_git_last_tags "$repo" 1 "-")" last_commit="$(osmo_git_last_commits "$repo" 1 "-")" head_commit="$(osmo_git_head_commit "$repo")" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I954b1d5229c44ebcec7e7228f2565a5c6755d16c Gerrit-Change-Number: 14650 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:39:23 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:39:23 +0000 Subject: Change in ...osmo-ci[master]: scripts: add osmocom-release-tarballs.sh In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14651 ) Change subject: scripts: add osmocom-release-tarballs.sh ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0a904c26e1c45aa46ddc59a01b776f2c7c5f947d Gerrit-Change-Number: 14651 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 11:39:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:39:31 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:39:31 +0000 Subject: Change in ...osmo-ci[master]: scripts: add osmocom-release-tarballs.sh In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/14651 ) Change subject: scripts: add osmocom-release-tarballs.sh ...................................................................... scripts: add osmocom-release-tarballs.sh Generate tarball releases for all tags in all repositories. Related: OS#3870 Change-Id: I0a904c26e1c45aa46ddc59a01b776f2c7c5f947d --- M .gitignore A scripts/osmocom-release-tarballs.sh 2 files changed, 216 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/.gitignore b/.gitignore index e101b84..ff207ee 100644 --- a/.gitignore +++ b/.gitignore @@ -8,6 +8,7 @@ __pycache__/ _temp/ _deps/ +_release_tarballs/ # osmocom-nightly-packages.sh nightly-3g_* diff --git a/scripts/osmocom-release-tarballs.sh b/scripts/osmocom-release-tarballs.sh new file mode 100755 index 0000000..b9d21c3 --- /dev/null +++ b/scripts/osmocom-release-tarballs.sh @@ -0,0 +1,215 @@ +#!/bin/sh -e +# Iterate over all relevant Osmocom repositories and generate release tarballs for each of the repository tags. The tags +# are queried from the git server without cloning the repositories first, so we can clone them only if we need to build +# a missing tarball. All repositories are deleted afterwards to save space. +# +# Environment variables: +# * KEEP_TEMP: do not delete cloned repositories (use for development) +# * PARALLEL_MAKE: -jN argument for make (default: -j5). + +cd "$(dirname "$0")" +. ./common.sh +PARALLEL_MAKE="${PARALLEL_MAKE:--j5}" +OUTPUT="$(cd ..; pwd)/_release_tarballs" +TEMP="$(cd ..; pwd)/_temp" + +# Print all tags for which no release tarball should be built. +# $1: Osmocom repository +tags_to_ignore() { + case "$1" in + libosmocore) + # configure.ac:144: error: required file 'src/gb/Makefile.in' not found + echo "0.5.0" + echo "0.5.1" + ;; + libsmpp34) + # duplicate of 1.12.0 + echo "1.12" + ;; + osmo-bsc) + # openbsc + echo "1.0.1" + # Requires libosmo-legacy-mgcp + echo "1.1.0" + echo "1.1.1" + echo "1.1.2" + echo "1.2.0" + echo "1.2.1" + echo "1.2.2" + ;; + osmo-bts) + # gsm_data_shared.h:464:26: error: field 'power_params' has incomplete type + echo "0.2.0" + echo "0.3.0" + ;; + osmo-hlr) + # Not using autotools + echo "0.0.1" + ;; + osmo-mgw) + # openbsc + echo "1.0.1" + ;; + osmo-msc) + # openbsc + echo "1.0.1" + ;; + osmo-pcu) + # Duplicates of 0.1.0, 0.2.0 + echo "0.1" + echo "0.2" + ;; + osmo-sgsn) + # openbsc + echo "0.9.0 0.9.1 0.9.2 0.9.3 0.9.4 0.9.5 0.9.6 0.9.8 0.9.9 0.9.10 0.9.11 0.9.12 0.9.13 0.9.14" + echo "0.9.15 0.9.16 0.10.0 0.10.1 0.11.0 0.12.0 0.13.0 0.14.0 0.15.0 1.0.1" + ;; + osmo-sip-connector) + # make: *** No rule to make target 'osmoappdesc.py' + echo "0.0.1" + ;; + osmo-trx) + # cp: cannot stat './/home/user/code/osmo-dev/src/osmo-ci/_temp/repos/osmo-trx/configure' + echo "0.2.0" + echo "0.3.0" + ;; + esac +} + +# Clone dependency repositories. +# $1: Osmocom repository +prepare_depends() { + case "$1" in + osmo-bts) + # Includes openbsc/gsm_data_shared.h + prepare_repo "openbsc" + ;; + esac +} + +# Apply workarounds for bugs that break too many releases. This function runs between ./configure and make dist-bzip2. +# $1: Osmocom repository +fix_repo() { + case "$1" in + osmo-mgw) + # No rule to make target 'osmocom/mgcp_client/mgcp_common.h' (OS#4084) + make -C "$TEMP/repos/$1/include/osmocom/mgcp_client" mgcp_common.h || true + ;; + esac +} + +# Check if one specific tag should be ignored. +# $1: Osmocom repository +# $2: tag (e.g. "1.0.0") +ignore_tag() { + local repo="$1" + local tag="$2" + local tags="$(tags_to_ignore "$repo")" + for tag_i in $tags; do + if [ "$tag" = "$tag_i" ]; then + return 0 + fi + done + return 1 +} + +# Delete existing temp dir (unless KEEP_TEMP is set). If all repos were checked out, this restores ~500 MB of space. +remove_temp_dir() { + if [ -n "$KEEP_TEMP" ]; then + echo "NOTE: not removing temp dir, because KEEP_TEMP is set: $TEMP" + elif [ -d "$TEMP" ]; then + rm -rf "$TEMP" + fi +} + +# Clone an Osmocom repository to $TEMP/repos/$repo, clean it, checkout a tag. +# $1: Osmocom repository +# $2: tag (optional, default: master) +prepare_repo() { + local repo="$1" + local tag="${2:-master}" + + if ! [ -d "$TEMP/repos/$repo" ]; then + git -C "$TEMP/repos" clone "$OSMO_GIT_URL/$repo" + fi + + cd "$TEMP/repos/$repo" + git clean -qdxf + git reset --hard HEAD # in case the tracked files were modified (e.g. libsmpp34 1.10) + git checkout -q "$tag" +} + +# Checkout a given tag and build a release tarball. +# $1: Osmocom repository +# $2: tag +create_tarball() { + local repo="$1" + local tag="$2" + local tarball="$repo-$tag.tar.bz2" + + # Be verbose during the tarball build and preparation. Everything else is not verbose, so we can generate an + # easy to read overview of tarballs that are already built or are ignored. + set -x + + prepare_repo "$repo" "$tag" + prepare_depends "$repo" + + cd "$TEMP/repos/$repo" + autoreconf -fi + ./configure + fix_repo "$repo" + make dist-bzip2 + + # Back to non-verbose mode + set +x + + if ! [ -e "$tarball" ]; then + echo "NOTE: tarball has a different name (wrong version in configure.ac?), renaming." + mv -v *.tar.bz2 "$tarball" + fi +} + +# Move a generated release tarball to the output dir. +move_tarball() { + local repo="$1" + local tag="$2" + local tarball="$repo-$tag.tar.bz2" + + cd "$TEMP/repos/$repo" + mkdir -p "$OUTPUT/$repo" + mv "$tarball" "$OUTPUT/$repo/$tarball" +} + +remove_temp_dir +mkdir -p "$TEMP/repos" +echo "Temp dir: $TEMP" + +for repo in $OSMO_RELEASE_REPOS; do + echo "$repo" + tags="$(osmo_git_last_commits_tags "$repo" "all" | cut -d / -f 3)" + + # Skip untagged repos + if [ -z "$tags" ]; then + echo " (repository has no release tags)" + continue + fi + + # Build missing tarballs for each tag + for tag in $tags; do + tarball="$repo-$tag.tar.bz2" + if ignore_tag "$repo" "$tag"; then + echo " $tarball (ignored)" + continue + elif [ -e "$OUTPUT/$repo/$tarball" ]; then + echo " $tarball (exists)" + continue + fi + + echo " $tarball (creating)" + create_tarball "$repo" "$tag" + move_tarball "$repo" "$tag" + done +done + +remove_temp_dir +echo "done!" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0a904c26e1c45aa46ddc59a01b776f2c7c5f947d Gerrit-Change-Number: 14651 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:40:04 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:40:04 +0000 Subject: Change in ...osmo-ci[master]: common.sh: add docker_images_require In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14652 ) Change subject: common.sh: add docker_images_require ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic4519ccb6978793054869862f8ca0e21d9cf5be4 Gerrit-Change-Number: 14652 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 11:40:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:40:10 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:40:10 +0000 Subject: Change in ...osmo-ci[master]: common.sh: add docker_images_require In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/14652 ) Change subject: common.sh: add docker_images_require ...................................................................... common.sh: add docker_images_require Clone docker-playground.git, source its jenkins-common.sh and run docker_images_require from there. This will make it possible to run osmocom-release-tarballs.sh in a docker container, for which the Dockerfile is stored in docker-playground.git. Related: OS#3870 Change-Id: Ic4519ccb6978793054869862f8ca0e21d9cf5be4 --- M .gitignore M scripts/common.sh 2 files changed, 27 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/.gitignore b/.gitignore index ff207ee..459f2c9 100644 --- a/.gitignore +++ b/.gitignore @@ -9,6 +9,7 @@ _temp/ _deps/ _release_tarballs/ +_docker_playground # osmocom-nightly-packages.sh nightly-3g_* diff --git a/scripts/common.sh b/scripts/common.sh index 2cf31a5..bf24fc4 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -27,6 +27,8 @@ osmocom-bb " +OSMO_BRANCH_DOCKER_PLAYGROUND="${OSMO_BRANCH_DOCKER_PLAYGROUND:-master}" + # Print commit of HEAD for an Osmocom git repository, e.g.: # "f90496f577e78944ce8db1aa5b900477c1e479b0" # $1: repository @@ -96,3 +98,27 @@ ;; esac } + +# Build docker images from docker-playground.git. +# $1...$n: docker image names (e.g. "debian-stretch-build") +docker_images_require() { + local oldpwd="$PWD" + + # Get docker-plaground.git + if [ -d "_docker_playground" ]; then + git -C _docker_playground fetch + else + git clone https://git.osmocom.org/docker-playground/ _docker_playground + fi + cd _docker_playground + git checkout "$OSMO_BRANCH_DOCKER_PLAYGROUND" + git reset --hard "origin/$OSMO_BRANCH_DOCKER_PLAYGROUND" + + # jenkins-common.sh expects to run from a subdir in docker-playground.git + cd "$1" + + # Subshell: run docker_images_require from jenkins-common.sh, pass all arguments + (. ../jenkins-common.sh; docker_images_require "$@") + + cd "$oldpwd" +} -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic4519ccb6978793054869862f8ca0e21d9cf5be4 Gerrit-Change-Number: 14652 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:41:08 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:41:08 +0000 Subject: Change in ...osmo-ci[master]: jobs: add osmocom-release-tarballs.yml In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14653 ) Change subject: jobs: add osmocom-release-tarballs.yml ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I994da5c27f9198e5bcf2d567dd473f9ed078d9c0 Gerrit-Change-Number: 14653 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 11:41:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:41:13 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:41:13 +0000 Subject: Change in ...osmo-ci[master]: jobs: add osmocom-release-tarballs.yml In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/14653 ) Change subject: jobs: add osmocom-release-tarballs.yml ...................................................................... jobs: add osmocom-release-tarballs.yml Related: OS#3870 Depends: I991fe41a1f55ccd6a66815ec3d7f239850397d9a (docker-playground) Change-Id: I994da5c27f9198e5bcf2d567dd473f9ed078d9c0 --- A jobs/osmocom-release-tarballs.yml 1 file changed, 54 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/jobs/osmocom-release-tarballs.yml b/jobs/osmocom-release-tarballs.yml new file mode 100644 index 0000000..56f5777 --- /dev/null +++ b/jobs/osmocom-release-tarballs.yml @@ -0,0 +1,54 @@ +--- +- project: + name: Osmocom-release-tarballs + jobs: + - Osmocom-release-tarballs + +- job-template: + name: 'Osmocom-release-tarballs' + project-type: freestyle + defaults: global + description: | + For each relevant Osmocom repository and its tags, build release tarballs (OS#3870). + parameters: + - string: + name: BRANCH_OSMO_CI + description: | + osmo-ci.git branch where the osmocom-release-tarballs.sh gets pulled from + default: 'master' + - string: + name: BRANCH_DOCKER_PLAYGROUND + description: | + docker-playground.git branch where the Dockerfile gets pulled from + default: 'master' + builders: + - shell: | + export OSMO_BRANCH_DOCKER_PLAYGROUND="$BRANCH_DOCKER_PLAYGROUND" + . scripts/common.sh + docker_images_require "debian-stretch-build" "debian-stretch-build-dist" + + docker run \ + --rm=true \ + -v "$PWD:/osmo-ci" \ + -w /osmo-ci \ + -e KEEP_TEMP="$KEEP_TEMP" \ + "$USER/debian-stretch-build-dist" /osmo-ci/scripts/osmocom-release-tarballs.sh + scm: + - git: + branches: + - '$BRANCH_OSMO_CI' + url: git://git.osmocom.org/osmo-ci + git-config-name: 'Jenkins Builder' + git-config-email: 'jenkins at osmocom.org' + # Don't wipe workspace to keep generated release tarballs + wipe-workspace: false + triggers: + - timed: "@midnight" + # Limit to one specific builder (so we don't regenerate all tarballs when switching to another builder) + node: build2-deb9build-ansible + publishers: + - email: + notify-every-unstable-build: true + recipients: 'jenkins-notifications at lists.osmocom.org' + +# vim: expandtab tabstop=2 shiftwidth=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14653 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I994da5c27f9198e5bcf2d567dd473f9ed078d9c0 Gerrit-Change-Number: 14653 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:41:31 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 11:41:31 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts/scheduler: provide actual C/I values to OsmoPCU In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14613 ) Change subject: osmo-bts/scheduler: provide actual C/I values to OsmoPCU ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14613/3/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14613/3/src/osmo-bts-trx/scheduler_trx.c at 986 PS3, Line 986: uint8_t *ci_cb_num = &chan_state->ci_cb_num; > But they're already all named _num ... Ah indeed, then let's keep the same naming. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia58043bd2381a4d34d604522e02899ae64ee0d26 Gerrit-Change-Number: 14613 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Wed, 03 Jul 2019 11:41:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: tnt Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:43:58 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 11:43:58 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14639 ) Change subject: Transceiver: Drop unused rssi_valid struct field ...................................................................... Transceiver: Drop unused rssi_valid struct field That field is actually never used. Furthermore, if pullRadioVector() returns false, then the caller should consider the 'trx_ul_burst_ind' structure as uninitialized. Moreover, RSSI is mandatory - we cannot send burst indications without it. Related: OS#4006 Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 0 insertions(+), 5 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index c3896bd..f04a132 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -559,7 +559,6 @@ int max_i = -1; signalVector *burst; TransceiverState *state = &mStates[chan]; - bi->rssi_valid = false; /* Blocking FIFO read */ radioVector *radio_burst = mReceiveFIFO[chan]->read(); @@ -609,9 +608,6 @@ bi->rssi = 20.0 * log10(rxFullScale / avg); - /* RSSI estimation are valid */ - bi->rssi_valid = true; - if (type == IDLE) { /* Update noise levels */ state->mNoises.insert(avg); diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index 0f452c1..965d07d 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -41,7 +41,6 @@ double rssi; // in dBFS double toa; // in symbols double noise; // noise level in dBFS - bool rssi_valid; // are RSSI, noise and burstTime valid }; class Transceiver; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82 Gerrit-Change-Number: 14639 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:43:58 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 11:43:58 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move nbits burst size calculation to pullRadioVector() In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14656 ) Change subject: Transceiver: Move nbits burst size calculation to pullRadioVector() ...................................................................... Transceiver: Move nbits burst size calculation to pullRadioVector() That's where all the filling logic happens, while in driveReceiveFIFO we mostly want to take the burst, generate a message and sent it over the socket. Related: OS#4006 Change-Id: Ib1df10c40d737954904290f57d58b1c77d65f82e --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 11 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index f04a132..a0ff4cd 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -643,6 +643,12 @@ bi->toa = toa; bi->rxBurst = demodAnyBurst(*burst, mSPSRx, amp, toa, type); + /* EDGE demodulator returns 444 (gSlotLen * 3) bits */ + if (bi->rxBurst->size() == EDGE_BURST_NBITS) + bi->nbits = EDGE_BURST_NBITS; + else /* size() here is actually gSlotLen + 8, due to guard periods */ + bi->nbits = gSlotLen; + delete radio_burst; return true; } @@ -917,7 +923,6 @@ { double dBm; // in dBm int TOAint; // in 1/256 symbols - unsigned nbits = gSlotLen; struct trx_ul_burst_ind bi; @@ -927,18 +932,12 @@ // Convert -1..+1 soft bits to 0..1 soft bits vectorSlicer(bi.rxBurst); - /* - * EDGE demodulator returns 444 (148 * 3) bits - */ - if (bi.rxBurst->size() == gSlotLen * 3) - nbits = gSlotLen * 3; - dBm = bi.rssi + rssiOffset; logRxBurst(chan, &bi, dBm); TOAint = (int) (bi.toa * 256.0 + 0.5); // round to closest integer - char burstString[sizeof(struct trxd_hdr_v0) + nbits + 2]; + char burstString[sizeof(struct trxd_hdr_v0) + bi.nbits + 2]; struct trxd_hdr_v0* pkt = (struct trxd_hdr_v0*)burstString; pkt->common.version = 0; pkt->common.reserved = 0; @@ -948,14 +947,14 @@ osmo_store16be(TOAint, &pkt->v0.toa); SoftVector::iterator burstItr = bi.rxBurst->begin(); - for (unsigned i = 0; i < nbits; i++) + for (unsigned i = 0; i < bi.nbits; i++) pkt->soft_bits[i] = (char) round((*burstItr++) * 255.0); /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi.nbits] */ - pkt->soft_bits[nbits + 1] = '\0'; + pkt->soft_bits[bi.nbits + 1] = '\0'; delete bi.rxBurst; - mDataSockets[chan]->write(burstString, sizeof(struct trxd_hdr_v0) + nbits + 2); + mDataSockets[chan]->write(burstString, sizeof(struct trxd_hdr_v0) + bi.nbits + 2); } void Transceiver::driveTxFIFO() diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index 965d07d..d7c6182 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -37,6 +37,7 @@ struct trx_ul_burst_ind { SoftVector *rxBurst; + unsigned nbits; // number of symbols per slot in rxBurst, not counting guard periods GSM::Time burstTime; double rssi; // in dBFS double toa; // in symbols -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14656 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib1df10c40d737954904290f57d58b1c77d65f82e Gerrit-Change-Number: 14656 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:45:26 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 11:45:26 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move nbits calculation to pullRadioVector() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14631 ) Change subject: Transceiver: Move nbits calculation to pullRadioVector() ...................................................................... Patch Set 3: Abandoned in favor of merged https://gerrit.osmocom.org/c/osmo-trx/+/14656 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4a8c6c1db0474461d1055857f2e0af7aba04ae32 Gerrit-Change-Number: 14631 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 11:45:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:45:30 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 11:45:30 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move nbits calculation to pullRadioVector() In-Reply-To: References: Message-ID: pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14631 ) Change subject: Transceiver: Move nbits calculation to pullRadioVector() ...................................................................... Abandoned Abandoned in favor of merged https://gerrit.osmocom.org/c/osmo-trx/+/14656 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4a8c6c1db0474461d1055857f2e0af7aba04ae32 Gerrit-Change-Number: 14631 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:58:16 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:58:16 +0000 Subject: Change in ...osmo-mgw[master]: "make dist" fix for: no rule to make mgcp_common.h In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/14655 to look at the new patch set (#3). Change subject: "make dist" fix for: no rule to make mgcp_common.h ...................................................................... "make dist" fix for: no rule to make mgcp_common.h Mark osmocom/mgcp_client/mgcp_common.h as nodist, so "make dist" will not try to include it in the source tarball. This caused "make dist" to fail in a clean osmo-mgw source tree with: make[2]: *** No rule to make target 'osmocom/mgcp_client/mgcp_common.h', needed by 'distdir'. Stop. The file gets copied during make from osmocom/mgcp/mgcp_common.h (see include/osmocom/mgcp_client/Makefile.am). Therefore it is not included in the source tree and we don't need to distribute it. Related: OS#4084 Change-Id: Ia1d7b051c0924a785b0f7ec0195192e3a852ed70 --- M include/Makefile.am 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/55/14655/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia1d7b051c0924a785b0f7ec0195192e3a852ed70 Gerrit-Change-Number: 14655 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:58:38 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 11:58:38 +0000 Subject: Change in ...osmo-mgw[master]: "make dist" fix for: no rule to make mgcp_common.h In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14655 ) Change subject: "make dist" fix for: no rule to make mgcp_common.h ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14655/2/include/Makefile.am File include/Makefile.am: https://gerrit.osmocom.org/#/c/14655/2/include/Makefile.am at 15 PS2, Line 15: nobase_nodist_include_HEADERS = \ > Please add a comment here explaining the same stuff you explained in the commit description (about i [?] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia1d7b051c0924a785b0f7ec0195192e3a852ed70 Gerrit-Change-Number: 14655 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 11:58:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 11:59:45 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 11:59:45 +0000 Subject: Change in ...osmo-mgw[master]: "make dist" fix for: no rule to make mgcp_common.h In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14655 ) Change subject: "make dist" fix for: no rule to make mgcp_common.h ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia1d7b051c0924a785b0f7ec0195192e3a852ed70 Gerrit-Change-Number: 14655 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 11:59:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 12:16:27 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 3 Jul 2019 12:16:27 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: bsc: Do proper chan release in TC_ho_out_fail_no_ho_detect In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14609 ) Change subject: bsc: Do proper chan release in TC_ho_out_fail_no_ho_detect ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14609 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic398896147a0b6b04ffeae56a23d25783b2b17fe Gerrit-Change-Number: 14609 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 03 Jul 2019 12:16:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 12:20:16 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 12:20:16 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: bsc: Do proper chan release in TC_ho_out_fail_no_ho_detect In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14609 ) Change subject: bsc: Do proper chan release in TC_ho_out_fail_no_ho_detect ...................................................................... bsc: Do proper chan release in TC_ho_out_fail_no_ho_detect BSC waits to receive a ClearCommand in response to its ClearRequest before it starts tearing down the MGCP conn on the MSC-side of the MGW endpoint. As a result, expected DLCX was not being sent which made test fail. However, currently test still fails because current osmo-bsc master sends a repeated ClearRequest message in this scenario. Related: OS#4078 Change-Id: Ic398896147a0b6b04ffeae56a23d25783b2b17fe --- M bsc/BSC_Tests.ttcn 1 file changed, 13 insertions(+), 11 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index f9609ba..88df9bc 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -2893,7 +2893,7 @@ } /* Expecting MGCP to DLCX the endpoint's two connections: towards BTS and towards MSC */ -private function f_expect_dlcx_conns(boolean exp_clear_cmpl := true) runs on MSC_ConnHdlr { +private function f_expect_dlcx_conns() runs on MSC_ConnHdlr { var MgcpCommand mgcp; var template MgcpResponse mgcp_resp; var MGCP_RecvFrom mrf; @@ -2923,9 +2923,7 @@ }; } - if (exp_clear_cmpl) { - BSSAP.receive(tr_BSSMAP_ClearComplete); - } + BSSAP.receive(tr_BSSMAP_ClearComplete); } private function f_tc_ho_out_of_this_bsc(charstring id) runs on MSC_ConnHdlr { @@ -2978,7 +2976,7 @@ var BssmapCause cause := enum2int(cause_val); BSSAP.send(ts_BSSMAP_ClearCommand(cause)); - f_expect_dlcx_conns(true); + f_expect_dlcx_conns(); setverdict(pass); f_sleep(1.0); } @@ -3171,6 +3169,7 @@ * RR should be released and Clear Request should go to the MSC. */ var MgcpCommand mgcp; + var PDU_BSSAP rx_clear_request; interleave { [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) { log("Got Deact SACCH"); @@ -3182,12 +3181,15 @@ log("Got RF Chan Rel"); RSL.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr)); } - [] BSSAP.receive(tr_BSSMAP_ClearRequest) { + [] BSSAP.receive(tr_BSSMAP_ClearRequest) -> value rx_clear_request { log("Got BSSMAP Clear Request"); + /* Instruct BSC to clear channel */ + var BssmapCause cause := bit2int(rx_clear_request.pdu.bssmap.clearRequest.cause.causeValue); + BSSAP.send(ts_BSSMAP_ClearCommand(cause)); } } - f_expect_dlcx_conns(false); + f_expect_dlcx_conns(); setverdict(pass); f_sleep(1.0); @@ -3332,7 +3334,7 @@ var BssmapCause cause := enum2int(cause_val); BSSAP.send(ts_BSSMAP_ClearCommand(cause)); - f_expect_dlcx_conns(true); + f_expect_dlcx_conns(); setverdict(pass); f_sleep(1.0); @@ -3414,7 +3416,7 @@ var BssmapCause cause := enum2int(cause_val); BSSAP.send(ts_BSSMAP_ClearCommand(cause)); - f_expect_dlcx_conns(true); + f_expect_dlcx_conns(); setverdict(pass); f_sleep(1.0); } @@ -3493,7 +3495,7 @@ var BssmapCause cause := enum2int(cause_val); BSSAP.send(ts_BSSMAP_ClearCommand(cause)); - f_expect_dlcx_conns(true); + f_expect_dlcx_conns(); setverdict(pass); f_sleep(1.0); @@ -3566,7 +3568,7 @@ var BssmapCause cause := bit2int(rx_clear_request.pdu.bssmap.clearRequest.cause.causeValue); BSSAP.send(ts_BSSMAP_ClearCommand(cause)); }; - f_expect_dlcx_conns(true); + f_expect_dlcx_conns(); setverdict(pass); f_sleep(1.0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14609 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic398896147a0b6b04ffeae56a23d25783b2b17fe Gerrit-Change-Number: 14609 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Wed Jul 3 13:09:56 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 03 Jul 2019 13:09:56 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1ca93a68def_6eea925f422478a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 751s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 751s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 751s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 751s] Makefile:442: recipe for target 'vlr.o' failed [ 751s] make[4]: *** [vlr.o] Error 1 [ 751s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 751s] Makefile:422: recipe for target 'all-recursive' failed [ 751s] make[3]: *** [all-recursive] Error 1 [ 751s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 751s] Makefile:462: recipe for target 'all-recursive' failed [ 751s] make[2]: *** [all-recursive] Error 1 [ 751s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 751s] Makefile:394: recipe for target 'all' failed [ 751s] make[1]: *** [all] Error 2 [ 751s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 751s] dh_auto_build: make -j1 returned exit code 2 [ 751s] debian/rules:45: recipe for target 'build' failed [ 751s] make: *** [build] Error 2 [ 751s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 752s] [ 752s] obs-arm-6 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Wed Jul 3 13:09:51 UTC 2019. [ 752s] [ 752s] ### VM INTERACTION START ### [ 756s] [ 708.277287] sysrq: SysRq : Power Off [ 756s] [ 708.309092] reboot: Power down [ 756s] ### VM INTERACTION END ### [ 756s] [ 756s] obs-arm-6 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Wed Jul 3 13:09:55 UTC 2019. [ 756s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Wed Jul 3 13:55:41 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 03 Jul 2019 13:55:41 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1cb3e44ba17_6eea925f42259175@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 653s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 653s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 653s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 653s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 653s] make[4]: *** [gb_proxy.o] Error 1 [ 653s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 653s] Makefile:391: recipe for target 'all-recursive' failed [ 653s] make[3]: *** [all-recursive] Error 1 [ 653s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 653s] Makefile:453: recipe for target 'all-recursive' failed [ 653s] make[2]: *** [all-recursive] Error 1 [ 653s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 653s] Makefile:385: recipe for target 'all' failed [ 653s] make[1]: *** [all] Error 2 [ 653s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 653s] dh_auto_build: make -j1 returned exit code 2 [ 653s] debian/rules:45: recipe for target 'build' failed [ 653s] make: *** [build] Error 2 [ 653s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 653s] [ 653s] armbuild13 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Wed Jul 3 13:55:22 UTC 2019. [ 653s] [ 653s] ### VM INTERACTION START ### [ 656s] [ 592.944694] sysrq: SysRq : Power Off [ 656s] [ 592.947040] reboot: Power down [ 656s] ### VM INTERACTION END ### [ 656s] [ 656s] armbuild13 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Wed Jul 3 13:55:25 UTC 2019. [ 656s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Jul 3 14:11:46 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 3 Jul 2019 14:11:46 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: implement header version coding In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14576 ) Change subject: trx_toolkit/data_msg.py: implement header version coding ...................................................................... trx_toolkit/data_msg.py: implement header version coding It may be necessary to extend the message specific header with more information. Since this is not a TLV-based protocol, we need to include the header format version. +-----------------+------------------------+ | 7 6 5 4 3 2 1 0 | bit numbers | +-----------------+------------------------+ | X X X X . . . . | header version (0..15) | +-----------------+------------------------+ | . . . . . X X X | TDMA TN (0..7) | +-----------------+------------------------+ | . . . . X . . . | RESERVED (0) | +-----------------+------------------------+ Instead of prepending an additional byte, it was decided to use 4 MSB bits of the first octet, which used to be zero-initialized due to the value range of TDMA TN. Therefore, the current header format has implicit version 0x00. Otherwise Wireshark (or trx_sniff.py) would need to guess the header version, or alternatively follow the control channel looking for the version setting command. The reserved bit number 3 can be used in the future to extend the TDMA TN range to (0..15), in case anybody would need to transfer UMTS bursts. Change-Id: Idb0377d66290eb9c15d6998a5806a84fa2e5dd02 Related: OS#4006 --- M src/target/trx_toolkit/data_msg.py 1 file changed, 115 insertions(+), 15 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Hoernchen: Looks good to me, but someone else must approve diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py index 86d0827..5bd04ca 100644 --- a/src/target/trx_toolkit/data_msg.py +++ b/src/target/trx_toolkit/data_msg.py @@ -4,7 +4,7 @@ # TRX Toolkit # DATA interface message definitions and helpers # -# (C) 2018 by Vadim Yanitskiy +# (C) 2018-2019 by Vadim Yanitskiy # # All Rights Reserved # @@ -49,20 +49,55 @@ parent of both DATAMSG_L12TRX and DATAMSG_TRX2L2 (see below), and has the following fields: - +--------------+-------------------+ - | TN (1 octet) | FN (4 octets, BE) | - +--------------+-------------------+ + +-----------------+----------------+-------------------+ + | VER (1/2 octet) | TN (1/2 octet) | FN (4 octets, BE) | + +-----------------+----------------+-------------------+ where: - - TN is TDMA time-slot number (1 octet), and + - VER is the header version indicator (1/2 octet MSB), + - TN is TDMA time-slot number (1/2 octet LSB), and - FN is TDMA frame number (4 octets, big endian). + == Header version indication + + It may be necessary to extend the message specific header + with more information. Since this is not a TLV-based + protocol, we need to include the header format version. + + +-----------------+------------------------+ + | 7 6 5 4 3 2 1 0 | bit numbers | + +-----------------+------------------------+ + | X X X X . . . . | header version (0..15) | + +-----------------+------------------------+ + | . . . . . X X X | TDMA TN (0..7) | + +-----------------+------------------------+ + | . . . . X . . . | RESERVED (0) | + +-----------------+------------------------+ + + Instead of prepending an additional byte, it was decided to use + 4 MSB bits of the first octet, which used to be zero-initialized + due to the value range of TDMA TN. Therefore, the legacy header + format has implicit version 0x00. + + Otherwise Wireshark (or trx_sniff.py) would need to guess the + header version, or alternatively follow the control channel + looking for the version setting command. + + The reserved bit number 3 can be used in the future to extend + the TDMA TN range to (0..15), in case anybody would need + to transfer UMTS bursts. + """ + # NOTE: up to 16 versions can be encoded + CHDR_VERSION_MAX = 0b1111 + known_versions = [0x00] + # Common constructor - def __init__(self, fn = None, tn = None, burst = None): + def __init__(self, fn = None, tn = None, burst = None, ver = 0): self.burst = burst + self.ver = ver self.fn = fn self.tn = tn @@ -103,6 +138,9 @@ def desc_hdr(self): result = "" + if self.ver > 0: + result += ("ver=%u " % self.ver) + if self.fn is not None: result += ("fn=%u " % self.fn) @@ -156,6 +194,9 @@ # Validates the message fields def validate(self): + if not self.ver in self.known_versions: + return False + if self.burst is None: return False @@ -185,10 +226,10 @@ # Allocate an empty byte-array buf = bytearray() - # Put timeslot index - buf.append(self.tn) + # Put version (4 bits) and TDMA TN (3 bits) + buf.append((self.ver << 4) | (self.tn & 0x07)) - # Put frame number (4 octets, BE) + # Put TDMA FN (4 octets, BE) buf += struct.pack(">L", self.fn) # Generate message specific header part @@ -214,9 +255,12 @@ if length < (self.HDR_LEN + GSM_BURST_LEN): raise ValueError("Message is to short") - # Parse both fn and tn + # Parse version and TDMA TN + self.ver = (msg[0] >> 4) + self.tn = (msg[0] & 0x07) + + # Parse TDMA FN self.fn = struct.unpack(">L", msg[1:5])[0] - self.tn = msg[0] # Specific message part self.parse_hdr(msg) @@ -332,9 +376,10 @@ self.burst.append(ubit) # Transforms this message to TRX2L1 message - def gen_trx2l1(self): + def gen_trx2l1(self, ver = None): # Allocate a new message - msg = DATAMSG_TRX2L1(fn = self.fn, tn = self.tn) + msg = DATAMSG_TRX2L1(fn = self.fn, tn = self.tn, + ver = self.ver if ver is None else ver) # Convert burst bits if self.burst is not None: @@ -501,9 +546,10 @@ self.burst.append(sbit) # Transforms this message to L12TRX message - def gen_l12trx(self): + def gen_l12trx(self, ver = None): # Allocate a new message - msg = DATAMSG_L12TRX(fn = self.fn, tn = self.tn) + msg = DATAMSG_L12TRX(fn = self.fn, tn = self.tn, + ver = self.ver if ver is None else ver) # Convert burst bits if self.burst is not None: @@ -618,3 +664,57 @@ assert(msg_trx2l1_dec.burst == DATAMSG.ubit2sbit(msg_l12trx_ref.burst)) log.info("Check L12TRX <-> TRX2L1 type transformations: OK") + + # Test header version coding + for ver in DATAMSG.known_versions: + # Create messages of both types + msg_l12trx = DATAMSG_L12TRX(ver = ver) + msg_trx2l1 = DATAMSG_TRX2L1(ver = ver) + + # Randomize message specific headers + msg_l12trx.rand_hdr() + msg_trx2l1.rand_hdr() + + # Randomize bursts + msg_l12trx.rand_burst() + msg_trx2l1.rand_burst() + + # Encode DATA messages + msg_l12trx_enc = msg_l12trx.gen_msg() + msg_trx2l1_enc = msg_trx2l1.gen_msg() + + # Parse generated DATA messages + msg_l12trx_dec = DATAMSG_L12TRX() + msg_trx2l1_dec = DATAMSG_TRX2L1() + msg_l12trx_dec.parse_msg(msg_l12trx_enc) + msg_trx2l1_dec.parse_msg(msg_trx2l1_enc) + + # Match the header version + assert(msg_l12trx_dec.ver == ver) + assert(msg_trx2l1_dec.ver == ver) + + # Match common TDMA fields + assert(msg_l12trx_dec.tn == msg_l12trx.tn) + assert(msg_trx2l1_dec.fn == msg_trx2l1.fn) + + # Compare bursts + assert(msg_l12trx_dec.burst == msg_l12trx.burst) + assert(msg_trx2l1_dec.burst == msg_trx2l1.burst) + + log.info("Check header version %u coding: OK" % ver) + + msg_trx2l1_gen = msg_l12trx.gen_trx2l1() + msg_l12trx_gen = msg_trx2l1.gen_l12trx() + + assert(msg_trx2l1_gen is not None) + assert(msg_l12trx_gen is not None) + + # Match the header version + assert(msg_trx2l1_gen.ver == ver) + assert(msg_l12trx_gen.ver == ver) + + # Match common TDMA fields + assert(msg_trx2l1_gen.tn == msg_l12trx.tn) + assert(msg_l12trx_gen.fn == msg_trx2l1.fn) + + log.info("Verify direct transformation: OK") -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Idb0377d66290eb9c15d6998a5806a84fa2e5dd02 Gerrit-Change-Number: 14576 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 14:11:47 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 3 Jul 2019 14:11:47 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: introduce header coding version 0x01 In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14579 ) Change subject: trx_toolkit/data_msg.py: introduce header coding version 0x01 ...................................................................... trx_toolkit/data_msg.py: introduce header coding version 0x01 The new version adds the following fields to the TRX2L1 message, keeping the L12TRX message unchanged: +------+-----+-----+-----+--------------------+ | RSSI | ToA | MTS | C/I | soft-bits (254..0) | +------+-----+-----+-----+--------------------+ - MTS (1 octet) - Modulation and Training Sequence info, and - C/I (2 octets) - Carrier-to-Interference ratio (big endian). == Coding of MTS: Modulation and Training Sequence info 3GPP TS 45.002 version 15.1.0 defines several modulation types, and a few sets of training sequences for each type. The most common are GMSK and 8-PSK (which is used in EDGE). +-----------------+---------------------------------------+ | 7 6 5 4 3 2 1 0 | bit numbers (value range) | +-----------------+---------------------------------------+ | . . . . . X X X | Training Sequence Code (0..7) | +-----------------+---------------------------------------+ | . X X X X . . . | Modulation, TS set number (see below) | +-----------------+---------------------------------------+ | X . . . . . . . | IDLE / nope frame indication (0 or 1) | +-----------------+---------------------------------------+ The bit number 7 (MSB) is set to high when either nothing has been detected, or during IDLE frames, so we can deliver noise levels, and avoid clock gaps on the L1 side. Other bits are ignored, and should be set to low (0) in this case. == Coding of modulation and TS set number GMSK has 4 sets of training sequences (see tables 5.2.3a-d), while 8-PSK (see tables 5.2.3f-g) and the others have 2 sets. Access and Synchronization bursts also have several synch. sequences. +-----------------+---------------------------------------+ | 7 6 5 4 3 2 1 0 | bit numbers (value range) | +-----------------+---------------------------------------+ | . 0 0 X X . . . | GMSK, 4 TS sets (0..3) | +-----------------+---------------------------------------+ | . 0 1 0 X . . . | 8-PSK, 2 TS sets (0..1) | +-----------------+---------------------------------------+ | . 0 1 1 X . . . | AQPSK, 2 TS sets (0..1) | +-----------------+---------------------------------------+ | . 1 0 0 X . . . | 16QAM, 2 TS sets (0..1) | +-----------------+---------------------------------------+ | . 1 0 1 X . . . | 32QAM, 2 TS sets (0..1) | +-----------------+---------------------------------------+ | . 1 1 1 X . . . | RESERVED (0) | +-----------------+---------------------------------------+ == C/I: Carrier-to-Interference ratio The C/I value is computed from the training sequence of each burst, where we can compare the "ideal" training sequence with the actual training sequence, and then express that difference in centiBels. Change-Id: Ie810c5a482d1c908994e8cdd32a2ea641ae7cedd Related: OS#4006, OS#1855 --- M src/target/trx_toolkit/data_msg.py 1 file changed, 362 insertions(+), 33 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Hoernchen: Looks good to me, but someone else must approve diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py index 5bd04ca..a2996ab 100644 --- a/src/target/trx_toolkit/data_msg.py +++ b/src/target/trx_toolkit/data_msg.py @@ -25,8 +25,37 @@ import random import struct +from enum import Enum from gsm_shared import * +class Modulation(Enum): + """ Modulation types defined in 3GPP TS 45.002 """ + ModGMSK = (0b0000, 148) + Mod8PSK = (0b0100, 444) + ModAQPSK = (0b0110, 296) + Mod16QAM = (0b1000, 592) + Mod32QAM = (0b1010, 740) + + def __init__(self, coding, bl): + # Coding in TRXD header + self.coding = coding + # Burst length + self.bl = bl + + @classmethod + def pick(self, coding): + for mod in list(self): + if mod.coding == coding: + return mod + return None + + @classmethod + def pick_by_bl(self, bl): + for mod in list(self): + if mod.bl == bl: + return mod + return None + class DATAMSG: """ TRXD (DATA) message codec (common part). @@ -92,7 +121,7 @@ # NOTE: up to 16 versions can be encoded CHDR_VERSION_MAX = 0b1111 - known_versions = [0x00] + known_versions = [0x00, 0x01] # Common constructor def __init__(self, fn = None, tn = None, burst = None, ver = 0): @@ -101,6 +130,12 @@ self.fn = fn self.tn = tn + # The common header length + @property + def CHDR_LEN(self): + # (VER + TN) + FN + return 1 + 4 + # Generates message specific header def gen_hdr(self): raise NotImplementedError @@ -197,12 +232,6 @@ if not self.ver in self.known_versions: return False - if self.burst is None: - return False - - if len(self.burst) not in (GSM_BURST_LEN, EDGE_BURST_LEN): - return False - if self.fn is None: return False @@ -237,7 +266,8 @@ buf += hdr # Generate burst - buf += self.gen_burst() + if self.burst is not None: + buf += self.gen_burst() # This is a rudiment from (legacy) OpenBTS transceiver, # some L1 implementations still expect two dummy bytes. @@ -248,11 +278,8 @@ # Parses a TRX DATA message def parse_msg(self, msg): - # Calculate message length - length = len(msg) - - # Check length - if length < (self.HDR_LEN + GSM_BURST_LEN): + # Make sure we have at least header + if len(msg) < self.HDR_LEN: raise ValueError("Message is to short") # Parse version and TDMA TN @@ -267,7 +294,10 @@ # Copy burst, skipping header msg_burst = msg[self.HDR_LEN:] - self.parse_burst(msg_burst) + if len(msg_burst) > 0: + self.parse_burst(msg_burst) + else: + self.burst = None class DATAMSG_L12TRX(DATAMSG): """ L12TRX (L1 -> TRX) message codec. @@ -276,6 +306,8 @@ or an Uplink burst on the MS side, and has the following message specific fixed-size header preceding the burst bits: + == Versions 0x00, 0x01 + +-----+--------------------+ | PWR | hard-bits (1 or 0) | +-----+--------------------+ @@ -290,13 +322,26 @@ """ # Constants - HDR_LEN = 6 PWR_MIN = 0x00 PWR_MAX = 0xff # Specific message fields pwr = None + # Calculates header length depending on its version + @property + def HDR_LEN(self): + # Common header length + length = self.CHDR_LEN + + # Message specific header length + if self.ver in (0x00, 0x01): + length += 1 # PWR + else: + raise IndexError("Unhandled version %u" % self.ver) + + return length + # Validates the message fields def validate(self): # Validate common fields @@ -309,6 +354,14 @@ if self.pwr < self.PWR_MIN or self.pwr > self.PWR_MAX: return False + # FIXME: properly handle IDLE / NOPE indications + if self.burst is None: + return False + + # FIXME: properly handle IDLE / NOPE indications + if len(self.burst) not in (GSM_BURST_LEN, EDGE_BURST_LEN): + return False + return True # Generates a random power level @@ -394,16 +447,78 @@ or a Downlink burst on the MS side, and has the following message specific fixed-size header preceding the burst bits: + == Version 0x00 + +------+-----+--------------------+ | RSSI | ToA | soft-bits (254..0) | +------+-----+--------------------+ + == Version 0x01 + + +------+-----+-----+-----+--------------------+ + | RSSI | ToA | MTS | C/I | soft-bits (254..0) | + +------+-----+-----+-----+--------------------+ + where: - RSSI (1 octet) - Received Signal Strength Indication encoded without the negative sign. - ToA (2 octets) - Timing of Arrival in units of 1/256 of symbol (big endian). + - MTS (1 octet) - Modulation and Training Sequence info. + - C/I (2 octets) - Carrier-to-Interference ratio (big endian). + + == Coding of MTS: Modulation and Training Sequence info + + 3GPP TS 45.002 version 15.1.0 defines several modulation types, + and a few sets of training sequences for each type. The most + common are GMSK and 8-PSK (which is used in EDGE). + + +-----------------+---------------------------------------+ + | 7 6 5 4 3 2 1 0 | bit numbers (value range) | + +-----------------+---------------------------------------+ + | . . . . . X X X | Training Sequence Code (0..7) | + +-----------------+---------------------------------------+ + | . X X X X . . . | Modulation, TS set number (see below) | + +-----------------+---------------------------------------+ + | X . . . . . . . | IDLE / nope frame indication (0 or 1) | + +-----------------+---------------------------------------+ + + The bit number 7 (MSB) is set to high when either nothing has been + detected, or during IDLE frames, so we can deliver noise levels, + and avoid clock gaps on the L1 side. Other bits are ignored, + and should be set to low (0) in this case. L16 shall be set to 0x00. + + == Coding of modulation and TS set number + + GMSK has 4 sets of training sequences (see tables 5.2.3a-d), + while 8-PSK (see tables 5.2.3f-g) and the others have 2 sets. + Access and Synchronization bursts also have several synch. + sequences. + + +-----------------+---------------------------------------+ + | 7 6 5 4 3 2 1 0 | bit numbers (value range) | + +-----------------+---------------------------------------+ + | . 0 0 X X . . . | GMSK, 4 TS sets (0..3) | + +-----------------+---------------------------------------+ + | . 0 1 0 X . . . | 8-PSK, 2 TS sets (0..1) | + +-----------------+---------------------------------------+ + | . 0 1 1 X . . . | AQPSK, 2 TS sets (0..1) | + +-----------------+---------------------------------------+ + | . 1 0 0 X . . . | 16QAM, 2 TS sets (0..1) | + +-----------------+---------------------------------------+ + | . 1 0 1 X . . . | 32QAM, 2 TS sets (0..1) | + +-----------------+---------------------------------------+ + | . 1 1 1 X . . . | RESERVED (0) | + +-----------------+---------------------------------------+ + + == C/I: Carrier-to-Interference ratio + + The C/I value can be computed from the training sequence of each + burst, where we can compare the "ideal" training sequence with + the actual training sequence and then express that in centiBels. + + == Coding of the burst bits Unlike to be transmitted bursts, the received bursts are designated using the soft-bits notation, so the receiver can indicate its @@ -416,9 +531,6 @@ """ - # Constants - HDR_LEN = 8 - # rxlev2dbm(0..63) gives us [-110..-47], plus -10 dbm for noise RSSI_MIN = -120 RSSI_MAX = -47 @@ -427,11 +539,81 @@ TOA256_MIN = -32768 TOA256_MAX = 32767 + # TSC (Training Sequence Code) range + TSC_RANGE = range(0, 8) + + # C/I range (in centiBels) + CI_MIN = -1280 + CI_MAX = 1280 + + # IDLE frame / nope detection indicator + NOPE_IND = (1 << 7) + # Specific message fields rssi = None toa256 = None - # Validates the message fields + # Version 0x01 specific (default values) + mod_type = Modulation.ModGMSK + nope_ind = False + + tsc_set = None + tsc = None + ci = None + + # Calculates header length depending on its version + @property + def HDR_LEN(self): + # Common header length + length = self.CHDR_LEN + + # Message specific header length + if self.ver == 0x00: + # RSSI + ToA + length += 1 + 2 + elif self.ver == 0x01: + # RSSI + ToA + TS + C/I + length += 1 + 2 + 1 + 2 + else: + raise IndexError("Unhandled version %u" % self.ver) + + return length + + def _validate_burst_v0(self): + # Burst is mandatory + if self.burst is None: + return False + + # ... and can be either of GSM (GMSK) or EDGE (8-PSK) + if len(self.burst) not in (GSM_BURST_LEN, EDGE_BURST_LEN): + return False + + return True + + def _validate_burst_v1(self): + # Burst is omitted in case of an IDLE / NOPE indication + if self.nope_ind and self.burst is None: + return True + if self.nope_ind and self.burst is not None: + return False + + if self.burst is None: + return False + + # Burst length depends on modulation type + if len(self.burst) != self.mod_type.bl: + return False + + return True + + # Validates the burst + def validate_burst(self): + if self.ver == 0x00: + return self._validate_burst_v0() + elif self.ver >= 0x01: + return self._validate_burst_v1() + + # Validates the message header fields def validate(self): # Validate common fields if not DATAMSG.validate(self): @@ -449,6 +631,35 @@ if self.toa256 < self.TOA256_MIN or self.toa256 > self.TOA256_MAX: return False + if self.ver >= 0x01: + if type(self.mod_type) is not Modulation: + return False + + if self.tsc_set is None: + return False + + if self.mod_type is Modulation.ModGMSK: + if self.tsc_set not in range(0, 4): + return False + else: + if self.tsc_set not in range(0, 2): + return False + + if self.tsc is None: + return False + + if self.tsc not in self.TSC_RANGE: + return False + + if self.ci is None: + return False + + if self.ci < self.CI_MIN or self.ci > self.CI_MAX: + return False + + if not self.validate_burst(): + return False + return True # Generates a random RSSI value @@ -477,6 +688,17 @@ self.rssi = self.rand_rssi() self.toa256 = self.rand_toa256() + if self.ver >= 0x01: + self.mod_type = random.choice(list(Modulation)) + if self.mod_type is Modulation.ModGMSK: + self.tsc_set = random.randint(0, 3) + else: + self.tsc_set = random.randint(0, 1) + self.tsc = random.choice(self.TSC_RANGE) + + # C/I: Carrier-to-Interference ratio + self.ci = random.randint(self.CI_MIN, self.CI_MAX) + # Generates human-readable header description def desc_hdr(self): # Describe the common part @@ -488,9 +710,61 @@ if self.toa256 is not None: result += ("toa256=%d " % self.toa256) + if self.ver >= 0x01: + if not self.nope_ind: + if self.mod_type is not None: + result += ("%s " % self.mod_type) + if self.tsc_set is not None: + result += ("set=%u " % self.tsc_set) + if self.tsc is not None: + result += ("tsc=%u " % self.tsc) + if self.ci is not None: + result += ("C/I=%d cB " % self.ci) + else: + result += "(IDLE / NOPE IND) " + # Strip useless whitespace and return return result.strip() + # Encodes Modulation and Training Sequence info + def gen_mts(self): + # IDLE / nope indication has no MTS info + if self.nope_ind: + return self.NOPE_IND + + # TSC: . . . . . X X X + mts = self.tsc & 0b111 + + # MTS: . X X X X . . . + mts |= self.mod_type.coding << 3 + mts |= self.tsc_set << 3 + + return mts + + # Parses Modulation and Training Sequence info + def parse_mts(self, mts): + # IDLE / nope indication has no MTS info + self.nope_ind = (mts & self.NOPE_IND) > 0 + if self.nope_ind: + self.mod_type = None + self.tsc_set = None + self.tsc = None + return + + # TSC: . . . . . X X X + self.tsc = mts & 0b111 + + # MTS: . X X X X . . . + mts = (mts >> 3) & 0b1111 + if (mts & 0b1100) > 0: + # Mask: . . . . M M M S + self.mod_type = Modulation.pick(mts & 0b1110) + self.tsc_set = mts & 0b1 + else: + # GMSK: . . . . 0 0 S S + self.mod_type = Modulation.ModGMSK + self.tsc_set = mts & 0b11 + # Generates message specific header part def gen_hdr(self): # Allocate an empty byte-array @@ -503,6 +777,17 @@ # Big endian, 2 bytes (int32_t) buf += struct.pack(">h", self.toa256) + if self.ver >= 0x01: + # Modulation and Training Sequence info + mts = self.gen_mts() + buf.append(mts) + + # C/I: Carrier-to-Interference ratio (in centiBels) + if not self.nope_ind: + buf += struct.pack(">h", self.ci) + else: + buf += bytearray(2) + return buf # Parses message specific header part @@ -513,6 +798,16 @@ # Parse ToA (Time of Arrival) self.toa256 = struct.unpack(">h", hdr[6:8])[0] + if self.ver >= 0x01: + # Modulation and Training Sequence info + self.parse_mts(hdr[8]) + + # C/I: Carrier-to-Interference ratio (in centiBels) + if not self.nope_ind: + self.ci = struct.unpack(">h", hdr[9:11])[0] + else: + self.ci = None + # Generates message specific burst def gen_burst(self): # Convert soft-bits to unsigned soft-bits @@ -521,26 +816,38 @@ # Encode to bytes return bytearray(burst_usbits) + # Parses message specific burst for header version 0 + def _parse_burst_v0(self, burst): + bl = len(burst) + + # We need to guess modulation by the length of burst + self.mod_type = Modulation.pick_by_bl(bl) + if self.mod_type is None: + # Some old transceivers append two dummy bytes + self.mod_type = Modulation.pick_by_bl(bl - 2) + + if self.mod_type is None: + raise ValueError("Odd burst length") + + return burst[:self.mod_type.bl] + # Parses message specific burst def parse_burst(self, burst): - length = len(burst) + burst = list(burst) - # Distinguish between GSM and EDGE - if length >= EDGE_BURST_LEN: - burst_usbits = list(burst[:EDGE_BURST_LEN]) - else: - burst_usbits = list(burst[:GSM_BURST_LEN]) + if self.ver == 0x00: + burst = self._parse_burst_v0(burst) # Convert unsigned soft-bits to soft-bits - burst_sbits = self.usbit2sbit(burst_usbits) - - # Save - self.burst = burst_sbits + self.burst = self.usbit2sbit(burst) # Generate a random message specific burst - def rand_burst(self, length = GSM_BURST_LEN): + def rand_burst(self, length = None): self.burst = [] + if length is None: + length = self.mod_type.bl + for i in range(length): sbit = random.randint(-127, 127) self.burst.append(sbit) @@ -697,12 +1004,20 @@ assert(msg_l12trx_dec.tn == msg_l12trx.tn) assert(msg_trx2l1_dec.fn == msg_trx2l1.fn) + # Match version specific fields + if msg_trx2l1.ver >= 0x01: + assert(msg_trx2l1_dec.nope_ind == msg_trx2l1.nope_ind) + assert(msg_trx2l1_dec.mod_type == msg_trx2l1.mod_type) + assert(msg_trx2l1_dec.tsc_set == msg_trx2l1.tsc_set) + assert(msg_trx2l1_dec.tsc == msg_trx2l1.tsc) + assert(msg_trx2l1_dec.ci == msg_trx2l1.ci) + + log.info("Check header version %u coding: OK" % ver) + # Compare bursts assert(msg_l12trx_dec.burst == msg_l12trx.burst) assert(msg_trx2l1_dec.burst == msg_trx2l1.burst) - log.info("Check header version %u coding: OK" % ver) - msg_trx2l1_gen = msg_l12trx.gen_trx2l1() msg_l12trx_gen = msg_trx2l1.gen_l12trx() @@ -717,4 +1032,18 @@ assert(msg_trx2l1_gen.tn == msg_l12trx.tn) assert(msg_l12trx_gen.fn == msg_trx2l1.fn) - log.info("Verify direct transformation: OK") + log.info("Verify version %u direct transformation: OK" % ver) + + # Verify NOPE indication coding + if msg_trx2l1.ver >= 0x01: + msg_trx2l1 = DATAMSG_TRX2L1(ver = ver) + msg_trx2l1.nope_ind = True + msg_trx2l1.rand_hdr() + + msg_trx2l1_dec = DATAMSG_TRX2L1() + msg_trx2l1_dec.parse_msg(msg_trx2l1.gen_msg()) + + assert(msg_trx2l1.nope_ind == msg_trx2l1_dec.nope_ind) + assert(msg_trx2l1.burst == msg_trx2l1_dec.burst) + + log.info("Verify version %u NOPE indication coding: OK" % ver) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14579 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie810c5a482d1c908994e8cdd32a2ea641ae7cedd Gerrit-Change-Number: 14579 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 14:11:48 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 3 Jul 2019 14:11:48 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/data_msg.py: legacy flag is only for version 0x00 In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14584 ) Change subject: trx_toolkit/data_msg.py: legacy flag is only for version 0x00 ...................................................................... trx_toolkit/data_msg.py: legacy flag is only for version 0x00 Since version 0x01, the burst bits are encoded as L16V, so appending two dummy octets doesn't make sense. Change-Id: I4d6c0bf54649d636ea6cb3fa2f37486b6619d5b3 --- M src/target/trx_toolkit/data_msg.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Hoernchen: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py index a2996ab..e946229 100644 --- a/src/target/trx_toolkit/data_msg.py +++ b/src/target/trx_toolkit/data_msg.py @@ -271,7 +271,7 @@ # This is a rudiment from (legacy) OpenBTS transceiver, # some L1 implementations still expect two dummy bytes. - if legacy: + if legacy and self.ver == 0x00: buf += bytearray(2) return buf -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14584 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4d6c0bf54649d636ea6cb3fa2f37486b6619d5b3 Gerrit-Change-Number: 14584 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 14:41:55 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 14:41:55 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move out TRXD socket send code to prepare for TRXDv1 In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14646 to look at the new patch set (#3). Change subject: Transceiver: Move out TRXD socket send code to prepare for TRXDv1 ...................................................................... Transceiver: Move out TRXD socket send code to prepare for TRXDv1 Only old v0 is supported so far. TRXD protocol related data/logic is moved to its own file out of Transceiver class. Code is refactored so it can be re-used later by TRXDv1. Related: OS#4006 Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed --- M Transceiver52M/Makefile.am M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h A Transceiver52M/proto_trxd.c M Transceiver52M/proto_trxd.h 5 files changed, 128 insertions(+), 54 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/46/14646/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed Gerrit-Change-Number: 14646 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 14:41:55 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 14:41:55 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Avoid noise calculation formula in 2 branches in pullRad... Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14661 Change subject: Transceiver: Avoid noise calculation formula in 2 branches in pullRadioVector ...................................................................... Transceiver: Avoid noise calculation formula in 2 branches in pullRadioVector Makes code easier to follow and will help in forthcoming refactoring once idle frames are supported. Change-Id: I56c84e9684ca460efd6c983d7e95d8e455bcac69 --- M Transceiver52M/Transceiver.cpp 1 file changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/61/14661/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 58e8719..7f05a2c 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -631,19 +631,18 @@ burst = radio_burst->getVector(max_i); avg = sqrt(avg / radio_burst->chans()); - bi->rssi = 20.0 * log10(rxFullScale / avg) + rssiOffset; - if (type == IDLE) { /* Update noise levels */ state->mNoises.insert(avg); state->mNoiseLev = state->mNoises.avg(); - bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset; + } + bi->rssi = 20.0 * log10(rxFullScale / avg) + rssiOffset; + bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset; + + if (type == IDLE) { delete radio_burst; return false; - } else { - /* Do not update noise levels */ - bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset; } unsigned max_toa = (type == RACH || type == EXT_RACH) ? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I56c84e9684ca460efd6c983d7e95d8e455bcac69 Gerrit-Change-Number: 14661 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 14:41:56 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 14:41:56 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Simplify code on early error return when calling detectA... Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14662 Change subject: Transceiver: Simplify code on early error return when calling detectAnyBurst ...................................................................... Transceiver: Simplify code on early error return when calling detectAnyBurst We get rid of one branch and simplify code logic. Change-Id: I026e35262bfe42c3d23ebdc06d84e4908a8380e2 --- M Transceiver52M/Transceiver.cpp 1 file changed, 4 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/62/14662/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 7f05a2c..81b428a 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -650,20 +650,16 @@ /* Detect normal or RACH bursts */ rc = detectAnyBurst(*burst, mTSC, BURST_THRESH, mSPSRx, type, amp, toa, max_toa); - - if (rc > 0) { - type = (CorrType) rc; - } else if (rc <= 0) { - if (rc == -SIGERR_CLIP) { + if (rc <= 0) { + if (rc == -SIGERR_CLIP) LOG(WARNING) << "Clipping detected on received RACH or Normal Burst"; - } else if (rc != SIGERR_NONE) { + else if (rc != SIGERR_NONE) LOG(WARNING) << "Unhandled RACH or Normal Burst detection error"; - } - delete radio_burst; return false; } + type = (CorrType) rc; bi->toa = toa; rxBurst = demodAnyBurst(*burst, mSPSRx, amp, toa, type); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I026e35262bfe42c3d23ebdc06d84e4908a8380e2 Gerrit-Change-Number: 14662 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 14:41:56 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 14:41:56 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: pullRadioVector(): Move initialization of var to start o... Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14663 Change subject: Transceiver: pullRadioVector(): Move initialization of var to start of function ...................................................................... Transceiver: pullRadioVector(): Move initialization of var to start of function This will be needed upon forthcoming refactor to support idle frames, which will add a goto return. Otherwise compiler complains: error: jump to label ret_idle [-fpermissive] note: crosses initialization of unsigned int max_toa Change-Id: Icd2793adc7b73a795184639b95fb5da336909b59 --- M Transceiver52M/Transceiver.cpp 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/63/14663/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 81b428a..92d4061 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -577,6 +577,7 @@ int rc; complex amp; float toa, max = -1.0, avg = 0.0; + unsigned max_toa; int max_i = -1; signalVector *burst; GSM::Time burstTime; @@ -645,8 +646,8 @@ return false; } - unsigned max_toa = (type == RACH || type == EXT_RACH) ? - mMaxExpectedDelayAB : mMaxExpectedDelayNB; + max_toa = (type == RACH || type == EXT_RACH) ? + mMaxExpectedDelayAB : mMaxExpectedDelayNB; /* Detect normal or RACH bursts */ rc = detectAnyBurst(*burst, mTSC, BURST_THRESH, mSPSRx, type, amp, toa, max_toa); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14663 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Icd2793adc7b73a795184639b95fb5da336909b59 Gerrit-Change-Number: 14663 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 14:41:57 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 14:41:57 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support pulling idle frames in pullRadioVector() Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14664 Change subject: Transceiver: Support pulling idle frames in pullRadioVector() ...................................................................... Transceiver: Support pulling idle frames in pullRadioVector() This logic will be used once we support TRXDv1, where idle indications are sent through the socket. Related: OS#4006 Change-Id: I46404f6e4055b6d3af3afffb0dfe4a19502917aa --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 20 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/64/14664/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 92d4061..4462cdd 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -591,8 +591,6 @@ /* Set time and determine correlation type */ burstTime = radio_burst->getTime(); - bi->fn = burstTime.FN(); - bi->tn = burstTime.TN(); CorrType type = expectedCorrType(burstTime, chan); /* Enable 8-PSK burst detection if EDGE is enabled */ @@ -612,6 +610,15 @@ return false; } + /* Initialize struct bi */ + bi->nbits = 0; + bi->fn = burstTime.FN(); + bi->tn = burstTime.TN(); + bi->rssi = 0.0; + bi->toa = 0.0; + bi->noise = 0.0; + bi->idle = false; + /* Select the diversity channel with highest energy */ for (size_t i = 0; i < radio_burst->chans(); i++) { float pow = energyDetect(*radio_burst->getVector(i), 20 * mSPSRx); @@ -624,8 +631,7 @@ if (max_i < 0) { LOG(ALERT) << "Received empty burst"; - delete radio_burst; - return false; + goto ret_idle; } /* Average noise on diversity paths and update global levels */ @@ -641,10 +647,8 @@ bi->rssi = 20.0 * log10(rxFullScale / avg) + rssiOffset; bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset; - if (type == IDLE) { - delete radio_burst; - return false; - } + if (type == IDLE) + goto ret_idle; max_toa = (type == RACH || type == EXT_RACH) ? mMaxExpectedDelayAB : mMaxExpectedDelayNB; @@ -656,8 +660,7 @@ LOG(WARNING) << "Clipping detected on received RACH or Normal Burst"; else if (rc != SIGERR_NONE) LOG(WARNING) << "Unhandled RACH or Normal Burst detection error"; - delete radio_burst; - return false; + goto ret_idle; } type = (CorrType) rc; @@ -676,6 +679,11 @@ delete rxBurst; delete radio_burst; return true; + +ret_idle: + bi->idle = true; + delete radio_burst; + return false; } void Transceiver::reset() @@ -968,7 +976,7 @@ struct trx_ul_burst_ind bi; - if (!pullRadioVector(chan, &bi)) + if (!pullRadioVector(chan, &bi) || bi.idle) return; logRxBurst(chan, &bi); diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index e4d0440..a66c962 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -44,6 +44,7 @@ double rssi; // in dBFS double toa; // in symbols double noise; // noise level in dBFS + bool idle; // true if no valid burst is included }; class Transceiver; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14664 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I46404f6e4055b6d3af3afffb0dfe4a19502917aa Gerrit-Change-Number: 14664 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 14:41:57 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 14:41:57 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support SETFORMAT command Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14665 Change subject: Transceiver: Support SETFORMAT command ...................................................................... Transceiver: Support SETFORMAT command Only old v0 is supported so far. Related: OS#4006 Change-Id: If9fc22f9987238a5ff870df7718de4efc9e04289 --- M Transceiver52M/Transceiver.cpp 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/65/14665/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index c9c8a05..8d85c01 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -868,6 +868,18 @@ mStates[chan].chanType[timeslot] = (ChannelCombination) corrCode; setModulus(timeslot, chan); sprintf(response,"RSP SETSLOT 0 %d %d",timeslot,corrCode); + } else if (match_cmd(command, "SETFORMAT", ¶ms)) { + // set TRXD protocol version + unsigned version_recv, version_used; + sscanf(params, "%u", &version_recv); + LOGC(DTRXCTRL, INFO) << "BTS requests TRXD version switch: " << version_recv; + if (version_recv > TRX_DATA_FORMAT_VER) + version_used = TRX_DATA_FORMAT_VER; + else + version_used = version_recv; + LOGC(DTRXCTRL, NOTICE) << "switching to TRXD version " << version_used; + mVersionTRXD = version_used; + sprintf(response,"RSP SETFORMAT %u %u", version_used, version_recv); } else if (match_cmd(command, "_SETBURSTTODISKMASK", ¶ms)) { // debug command! may change or disapear without notice // set a mask which bursts to dump to disk -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9fc22f9987238a5ff870df7718de4efc9e04289 Gerrit-Change-Number: 14665 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 14:51:22 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 14:51:22 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move out TRXD socket send code to prepare for TRXDv1 In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14646 to look at the new patch set (#4). Change subject: Transceiver: Move out TRXD socket send code to prepare for TRXDv1 ...................................................................... Transceiver: Move out TRXD socket send code to prepare for TRXDv1 Only old v0 is supported so far. TRXD protocol related data/logic is moved to its own file out of Transceiver class. Code is refactored so it can be re-used later by TRXDv1. Related: OS#4006 Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed --- M Transceiver52M/Makefile.am M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h A Transceiver52M/proto_trxd.c M Transceiver52M/proto_trxd.h 5 files changed, 128 insertions(+), 54 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/46/14646/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed Gerrit-Change-Number: 14646 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 16:13:59 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 16:13:59 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support SETFORMAT command In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14665 to look at the new patch set (#3). Change subject: Transceiver: Support SETFORMAT command ...................................................................... Transceiver: Support SETFORMAT command Only old v0 is supported so far. Related: OS#4006 Change-Id: If9fc22f9987238a5ff870df7718de4efc9e04289 --- M Transceiver52M/Transceiver.cpp 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/65/14665/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9fc22f9987238a5ff870df7718de4efc9e04289 Gerrit-Change-Number: 14665 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 16:24:19 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 16:24:19 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: ggsn: Add TC_pdp4_act_deact_ipcp_pap_broken() In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13564 ) Change subject: ggsn: Add TC_pdp4_act_deact_ipcp_pap_broken() ...................................................................... ggsn: Add TC_pdp4_act_deact_ipcp_pap_broken() This test case reproduces a real-world PCO capture including a broken PAP AuthenticationReq. It triggers some weird behavior in OsmoGGSN 1.3.0 where it would send duplicate IPCP repsonses and no PAP response. Change-Id: Ie89d984ed9e26fbbb2e4914bdb8623446d462a4c Related: OS#3914 --- M ggsn_tests/GGSN_Tests.ttcn M ggsn_tests/expected-results.xml M ggsn_tests/gen_links.sh M library/GTP_Templates.ttcn 4 files changed, 50 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index dc9d07c..31c1056 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -22,6 +22,7 @@ import from GTPC_Types all; import from GTPU_Types all; import from IPCP_Types all; + import from PAP_Types all; import from IP_Types all; import from ICMP_Types all; import from ICMPv6_Types all; @@ -932,6 +933,39 @@ f_pdp_ctx_del(ctx, '1'B); } + /* Test PDP context activation for dynamic IPv4 EUA with IPv4 DNS in IPCP + PAP authentication (broken) */ + testcase TC_pdp4_act_deact_ipcp_pap_broken() runs on GT_CT { + f_init(); + var OCT4 ggsn_ip4_dns1 := f_inet_addr(m_ggsn_ip4_dns1); + var OCT4 ggsn_ip4_dns2 := f_inet_addr(m_ggsn_ip4_dns2); + var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet, valueof(t_EuaIPv4Dyn))); + ctx.pco_req := valueof(ts_PCO_PAP_IPv4_DNS); + f_pdp_ctx_act(ctx); + f_PCO_ensure_no_duplicates(ctx.pco_neg); + /* verify IPCP is at all contained */ + if (not match(ctx.pco_neg, tr_PCO_Contains('8021'O))) { + setverdict(fail, "IPCP not found in PCO"); + } + /* verify IPCP contains both primary and secondary DNS */ + var IpcpPacket ipcp := dec_IpcpPacket(f_PCO_extract_proto(ctx.pco_neg, '8021'O)); + if (not match(ipcp, tr_IPCP_Ack_DNS(0, ggsn_ip4_dns1, ggsn_ip4_dns2))) { + if (not match(ipcp, tr_IPCP_Ack_DNS(0))) { + setverdict(fail, "Primary/Secondary DNS PCO IPCP option not found"); + } else { + setverdict(fail, "Primary/Secondary DNS PCO IPCP option found but not matching expected values"); + } + } + /* verify that PAP is contained */ + if (not match(ctx.pco_neg, tr_PCO_Contains('C023'O))) { + setverdict(fail, "PAP not found in PCO"); + } + var PapPacket pap := dec_PapPacket(f_PCO_extract_proto(ctx.pco_neg, 'C023'O)); + if (not match(pap, tr_PAP_AuthAck)) { + setverdict(fail, "PAP isn't an AuthenticateAck: ", pap); + } + f_pdp_ctx_del(ctx, '1'B); + } + /* Test PDP context activation for dynamic IPv4 EUA with IPv4 DNS in PCO */ testcase TC_pdp4_act_deact_pcodns() runs on GT_CT { f_init(); @@ -1277,6 +1311,7 @@ control { execute(TC_pdp4_act_deact()); execute(TC_pdp4_act_deact_ipcp()); + execute(TC_pdp4_act_deact_ipcp_pap_broken()); execute(TC_pdp4_act_deact_pcodns()); execute(TC_pdp4_act_deact_gtpu_access()); execute(TC_pdp4_clients_interact_with_txseq()); diff --git a/ggsn_tests/expected-results.xml b/ggsn_tests/expected-results.xml index c2defea..c60a804 100644 --- a/ggsn_tests/expected-results.xml +++ b/ggsn_tests/expected-results.xml @@ -1,7 +1,8 @@ - + + diff --git a/ggsn_tests/gen_links.sh b/ggsn_tests/gen_links.sh index 82e35d4..1b54e9d 100755 --- a/ggsn_tests/gen_links.sh +++ b/ggsn_tests/gen_links.sh @@ -45,7 +45,7 @@ gen_links $DIR $FILES DIR=../library -FILES="Misc_Helpers.ttcn General_Types.ttcn GSM_Types.ttcn Osmocom_Types.ttcn Native_Functions.ttcn Native_FunctionDefs.cc IPCP_Types.ttcn " +FILES="Misc_Helpers.ttcn General_Types.ttcn GSM_Types.ttcn Osmocom_Types.ttcn Native_Functions.ttcn Native_FunctionDefs.cc IPCP_Types.ttcn PAP_Types.ttcn " FILES+="GTP_CodecPort.ttcn GTP_CodecPort_CtrlFunct.ttcn GTP_CodecPort_CtrlFunctDef.cc GTP_Templates.ttcn " FILES+="Osmocom_VTY_Functions.ttcn " gen_links $DIR $FILES diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn index f2e6ac0..aa42759 100644 --- a/library/GTP_Templates.ttcn +++ b/library/GTP_Templates.ttcn @@ -471,6 +471,18 @@ lengthProtoID := ?, protoIDContents := ? } + template ProtocolElement ts_PCOelem_PAP_broken := { + protocolID := 'C023'O, + lengthProtoID := 60, + /* PPP Password Authentication Protocol containing incorrect Peer-Id-Length set to 4 (6-7 should be the valid one), see OS#3914. */ + protoIDContents := '0100003c'O & '0444435338323700bc1c08087c1508083e00790000150808fd06000001000000000000000000000000000000000000000000000000000000'O + } + template ProtConfigOptions ts_PCO_PAP_IPv4_DNS modifies ts_PCO := { + protocols := { + ts_PCOelem_PAP_broken, + { protocolID := '8021'O, lengthProtoID := 16, protoIDContents := enc_IpcpPacket(valueof(ts_IPCP_ReqDNS)) } + } + } template ProtConfigOptions tr_PCO_Contains(OCT2 prot_id) modifies tr_PCO := { protocols := { *, tr_PCO_Proto(prot_id), * } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13564 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie89d984ed9e26fbbb2e4914bdb8623446d462a4c Gerrit-Change-Number: 13564 Gerrit-PatchSet: 7 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 16:28:10 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 16:28:10 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: WIP In-Reply-To: References: Message-ID: pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14493 ) Change subject: WIP ...................................................................... Abandoned Feature added for all mgw tests in I31fed700772dd0b063f913b1e1639fd428c46e7d and previous commits. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I21ffcaa241e4fc0bd2c6563e21f1c8bdb4d14dd6 Gerrit-Change-Number: 14493 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 16:29:17 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 16:29:17 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14632 ) Change subject: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts ...................................................................... Patch Set 4: Code-Review-1 I removed this one from the patch series. I'll mark is as WIP and abandon it in a few days if we still think we don't want it. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iedc54011f333f48c6c8b81cab4d640f7601e01dd Gerrit-Change-Number: 14632 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 03 Jul 2019 16:29:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 16:59:07 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 16:59:07 +0000 Subject: Change in ...osmo-pcap[master]: tests/Makefile.am: Fix make check Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14666 Change subject: tests/Makefile.am: Fix make check ...................................................................... tests/Makefile.am: Fix make check Without this patch, make check fails with following error: No rule to make target 'atconfig', needed by 'check-local' Changes needed to fix the issue were gathered by looking at differences with libosmo-netif's Makefile. Change-Id: Ie6698d1c1d36e2b8a5391bc2322c1632458751db --- M tests/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/66/14666/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index def6e8b..720d631 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -17,6 +17,7 @@ } >'$(srcdir)/package.m4' EXTRA_DIST = testsuite.at $(srcdir)/package.m4 $(TESTSUITE) +DISTCLEANFILES = atconfig TESTSUITE = $(srcdir)/testsuite if ENABLE_EXT_TESTS @@ -39,7 +40,6 @@ clean-local: test ! -f '$(TESTSUITE)' || \ $(SHELL) '$(TESTSUITE)' --clean - $(RM) -f atconfig AUTOM4TE = $(SHELL) $(top_srcdir)/missing --run autom4te AUTOTEST = $(AUTOM4TE) --language=autotest -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ie6698d1c1d36e2b8a5391bc2322c1632458751db Gerrit-Change-Number: 14666 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 17:15:17 2019 From: gerrit-no-reply at lists.osmocom.org (roh) Date: Wed, 3 Jul 2019 17:15:17 +0000 Subject: Change in ...osmo-remsim[master]: add examples to the command line options for remsim-bankd and remsim-... Message-ID: roh has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14667 Change subject: add examples to the command line options for remsim-bankd and remsim-client ...................................................................... add examples to the command line options for remsim-bankd and remsim-client Change-Id: Idfa6352ce90dd36dd27306d6c8a2023935ed822d --- M doc/manuals/chapters/remsim-bankd.adoc M doc/manuals/chapters/remsim-client.adoc 2 files changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/67/14667/1 diff --git a/doc/manuals/chapters/remsim-bankd.adoc b/doc/manuals/chapters/remsim-bankd.adoc index be9b2c0..d35056b 100644 --- a/doc/manuals/chapters/remsim-bankd.adoc +++ b/doc/manuals/chapters/remsim-bankd.adoc @@ -85,6 +85,16 @@ Specify the local TCP port to whicc the socket for incoming connections from `osmo-remsim-client`s is bound to. +==== Examples +.remsim-server is on 10.2.3.4, cardreader has 5 slots: +---- +osmo-remsim-bankd -i 10.2.3.4 -n 5 +---- +.remsim-server is on 10.2.3.4, cardreader has 4 slots, local ip is 10.5.4.3 +---- +osmo-remsim-bankd -i 10.2.3.4 -n 4 -I 10.5.4.3 +---- + === Logging `osmo-remsim-bankd` currently logs to stdout only, and the logging diff --git a/doc/manuals/chapters/remsim-client.adoc b/doc/manuals/chapters/remsim-client.adoc index 0526dbb..26c1661 100644 --- a/doc/manuals/chapters/remsim-client.adoc +++ b/doc/manuals/chapters/remsim-client.adoc @@ -83,6 +83,15 @@ and will later be overridden by the ATR as specified by `osmo-remsim-bankd` once a card has been mapped to this client. +==== Examples +.remsim-server is on 10.2.3.4, sysmoQMOD on usb bus, all 4 modems: +---- +osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 0 -H 2-1.1 -c 0 +osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 1 -H 2-1.1 -c 0 +osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 0 -H 2-1.4 -c 0 +osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 1 -H 2-1.4 -c 0 +---- + === Logging `osmo-remsim-client` currently logs to stdout only, and the logging -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14667 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Idfa6352ce90dd36dd27306d6c8a2023935ed822d Gerrit-Change-Number: 14667 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 17:15:17 2019 From: gerrit-no-reply at lists.osmocom.org (roh) Date: Wed, 3 Jul 2019 17:15:17 +0000 Subject: Change in ...osmo-remsim[master]: add examples to remsim-server (json output) Message-ID: roh has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14668 Change subject: add examples to remsim-server (json output) ...................................................................... add examples to remsim-server (json output) Change-Id: I102a79a5d1f0055586a9fa1f9688acd4258f585b --- M doc/manuals/chapters/remsim-server.adoc 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/68/14668/1 diff --git a/doc/manuals/chapters/remsim-server.adoc b/doc/manuals/chapters/remsim-server.adoc index 01d24b2..c0ca6b8 100644 --- a/doc/manuals/chapters/remsim-server.adoc +++ b/doc/manuals/chapters/remsim-server.adoc @@ -76,3 +76,13 @@ *POST* performs a global reset of the `osmo-remsim-server` state. This means all mappings are removed. + +==== Examples +.remsim-server is on 10.2.3.4, one simbank with 5 cards: http://10.2.3.4:9997/api/backend/v1/banks +---- +{"banks":[{"peer":"B1","state":"CONNECTED_BANKD","component_id":{"type_":"remsimBankd","name":"fixme-name","software":"remsim-bankd","swVersion":"0.1.0.17-6d8a"},"bankId":1,"numberOfSlots":5}]} +---- +.remsim-server is on 10.2.3.4, 4 clients: http://10.2.3.4:9997/api/backend/v1/clients +---- +{"clients":[{"peer":"C0:0","state":"CONNECTED_CLIENT","component_id":{"type_":"remsimClient","name":"simtrace2-remsim-client","software":"remsim-client","swVersion":"0.1.0.17-6d8a"}},{"peer":"C0:0","state":"CONNECTED_CLIENT","component_id":{"type_":"remsimClient","name":"simtrace2-remsim-client","software":"remsim-client","swVersion":"0.1.0.17-6d8a"}},{"peer":"C0:0","state":"CONNECTED_CLIENT","component_id":{"type_":"remsimClient","name":"simtrace2-remsim-client","software":"remsim-client","swVersion":"0.1.0.17-6d8a"}},{"peer":"C0:0","state":"CONNECTED_CLIENT","component_id":{"type_":"remsimClient","name":"simtrace2-remsim-client","software":"remsim-client","swVersion":"0.1.0.17-6d8a"}}]} +---- -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I102a79a5d1f0055586a9fa1f9688acd4258f585b Gerrit-Change-Number: 14668 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 18:21:35 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 18:21:35 +0000 Subject: Change in ...meta-telephony[201705]: Add recipe for osmo-pcap, both server and client In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#2) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/meta-telephony/+/3534 ) Change subject: Add recipe for osmo-pcap, both server and client ...................................................................... Add recipe for osmo-pcap, both server and client Change-Id: I5bb85b118029d1559a958803184690a9d0f23e4a --- A recipes-osmocom/osmo-pcap/osmo-pcap.inc A recipes-osmocom/osmo-pcap/osmo-pcap_git.bb 2 files changed, 46 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/34/3534/2 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/3534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I5bb85b118029d1559a958803184690a9d0f23e4a Gerrit-Change-Number: 3534 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Assignee: pespin Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Max Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 18:22:18 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 18:22:18 +0000 Subject: Change in ...meta-telephony[201705]: Add recipe for osmo-pcap, both server and client In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/3534 ) Change subject: Add recipe for osmo-pcap, both server and client ...................................................................... Patch Set 2: -Code-Review After merging, meta-telephony laforge/nightly needs to be updated to set the recipe to AUTOREV. -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/3534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I5bb85b118029d1559a958803184690a9d0f23e4a Gerrit-Change-Number: 3534 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Assignee: pespin Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Max Gerrit-Comment-Date: Wed, 03 Jul 2019 18:22:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 3 18:29:44 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 3 Jul 2019 18:29:44 +0000 Subject: Change in ...meta-telephony[201705]: Add recipe for osmo-pcap, both server and client In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/3534 ) Change subject: Add recipe for osmo-pcap, both server and client ...................................................................... Patch Set 2: Verified+1 I have another patch for meta-sysmocom-bsp adding this recipe to the feeds so it gets built over time. The patch can be found in branch pespin/201705-pcap, and I'll merge it to 201705 (and rebase laforge/nightly) once this patch is merged. -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/3534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I5bb85b118029d1559a958803184690a9d0f23e4a Gerrit-Change-Number: 3534 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Assignee: pespin Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Max Gerrit-Comment-Date: Wed, 03 Jul 2019 18:29:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Thu Jul 4 02:46:45 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 04 Jul 2019 02:46:45 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1d68a24d548_6eea925f423778ba@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 874s] -Returned: 0, Current node: 1 '%s> ' [ 874s] -Going to execute 'ambiguous_str' [ 874s] -Called: 'ambiguous_str [ARG]' (argc=0) [ 874s] -Returned: 0, Current node: 1 '%s> ' [ 874s] -Going to execute 'ambiguous_str arg' [ 874s] -Called: 'ambiguous_str [ARG]' (argc=1) [ 874s] -Returned: 0, Current node: 1 '%s> ' [ 874s] -Going to execute 'ambiguous_str arg keyword' [ 874s] -Called: 'ambiguous_str ARG keyword' [ 874s] -Returned: 0, Current node: 1 '%s> ' [ 874s] -All tests passed [ 874s] ./testsuite.at:196: exit code was 139, expected 0 [ 874s] 31. testsuite.at:192: 31. vty (testsuite.at:192): FAILED (testsuite.at:196) [ 874s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 874s] make[1]: *** [override_dh_auto_test] Error 1 [ 874s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 874s] debian/rules:15: recipe for target 'build' failed [ 874s] make: *** [build] Error 2 [ 874s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 874s] [ 874s] obs-arm-6 failed "build libosmocore_1.1.0.75.316d.dsc" at Thu Jul 4 02:46:24 UTC 2019. [ 874s] [ 874s] ### VM INTERACTION START ### [ 876s] [ 831.091369] sysrq: SysRq : Power Off [ 876s] [ 831.119056] reboot: Power down [ 876s] ### VM INTERACTION END ### [ 876s] [ 876s] obs-arm-6 failed "build libosmocore_1.1.0.75.316d.dsc" at Thu Jul 4 02:46:27 UTC 2019. [ 876s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Thu Jul 4 03:22:45 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 04 Jul 2019 03:22:45 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1d71165f112_6eea925f4238309c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 343s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 343s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 343s] collect2: error: ld returned 1 exit status [ 343s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 343s] make[4]: *** [osmo-bts-virtual] Error 1 [ 343s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 343s] Makefile:385: recipe for target 'all-recursive' failed [ 343s] make[3]: *** [all-recursive] Error 1 [ 343s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 343s] Makefile:434: recipe for target 'all-recursive' failed [ 343s] make[2]: *** [all-recursive] Error 1 [ 343s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 343s] Makefile:366: recipe for target 'all' failed [ 343s] make[1]: *** [all] Error 2 [ 343s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 343s] dh_auto_build: make -j1 returned exit code 2 [ 343s] debian/rules:12: recipe for target 'build' failed [ 343s] make: *** [build] Error 2 [ 343s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 343s] [ 343s] armbuild25 failed "build osmo-bts_0.8.1.331.d1e7.dsc" at Thu Jul 4 03:22:36 UTC 2019. [ 343s] [ 343s] ### VM INTERACTION START ### [ 346s] [ 320.983598] sysrq: SysRq : Power Off [ 346s] [ 320.984767] reboot: Power down [ 346s] ### VM INTERACTION END ### [ 346s] [ 346s] armbuild25 failed "build osmo-bts_0.8.1.331.d1e7.dsc" at Thu Jul 4 03:22:40 UTC 2019. [ 346s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Thu Jul 4 03:46:28 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 04 Jul 2019 03:46:28 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1d76969d3a1_6eea925f4238380@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 452s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 452s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 452s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 452s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 452s] make[4]: *** [gb_proxy.o] Error 1 [ 452s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 452s] Makefile:391: recipe for target 'all-recursive' failed [ 452s] make[3]: *** [all-recursive] Error 1 [ 452s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 452s] Makefile:453: recipe for target 'all-recursive' failed [ 452s] make[2]: *** [all-recursive] Error 1 [ 452s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 452s] Makefile:385: recipe for target 'all' failed [ 452s] make[1]: *** [all] Error 2 [ 452s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 452s] dh_auto_build: make -j1 returned exit code 2 [ 452s] debian/rules:45: recipe for target 'build' failed [ 452s] make: *** [build] Error 2 [ 452s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 452s] [ 452s] armbuild22 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Thu Jul 4 03:46:12 UTC 2019. [ 452s] [ 452s] ### VM INTERACTION START ### [ 455s] [ 435.994222] sysrq: SysRq : Power Off [ 455s] [ 436.047100] reboot: Power down [ 456s] ### VM INTERACTION END ### [ 456s] [ 456s] armbuild22 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Thu Jul 4 03:46:16 UTC 2019. [ 456s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Thu Jul 4 03:48:45 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 04 Jul 2019 03:48:45 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1d772d9ff17_6eea925f42384295@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 599s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 599s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 599s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 599s] Makefile:442: recipe for target 'vlr.o' failed [ 599s] make[4]: *** [vlr.o] Error 1 [ 599s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 599s] Makefile:422: recipe for target 'all-recursive' failed [ 599s] make[3]: *** [all-recursive] Error 1 [ 599s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 599s] Makefile:462: recipe for target 'all-recursive' failed [ 599s] make[2]: *** [all-recursive] Error 1 [ 599s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 599s] Makefile:394: recipe for target 'all' failed [ 599s] make[1]: *** [all] Error 2 [ 599s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 599s] dh_auto_build: make -j1 returned exit code 2 [ 599s] debian/rules:45: recipe for target 'build' failed [ 599s] make: *** [build] Error 2 [ 599s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 599s] [ 599s] armbuild13 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Thu Jul 4 03:48:33 UTC 2019. [ 599s] [ 599s] ### VM INTERACTION START ### [ 602s] [ 557.535441] sysrq: SysRq : Power Off [ 602s] [ 557.537800] reboot: Power down [ 602s] ### VM INTERACTION END ### [ 602s] [ 602s] armbuild13 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Thu Jul 4 03:48:37 UTC 2019. [ 602s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Jul 4 06:14:21 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 06:14:21 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support SETFORMAT command In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14665 ) Change subject: Transceiver: Support SETFORMAT command ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9fc22f9987238a5ff870df7718de4efc9e04289 Gerrit-Change-Number: 14665 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Jul 2019 06:14:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 07:37:58 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Jul 2019 07:37:58 +0000 Subject: Change in ...osmo-pcap[master]: tests/Makefile.am: Fix make check In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14666 ) Change subject: tests/Makefile.am: Fix make check ...................................................................... Patch Set 1: I can not reproduce this error. The patch looks like it influences "make distclean", which should delete the "atconfig" file. So I don't understand how it relates to the error mentioned in the commit message. Can you provide instructions on how to reproduce this in a clean osmo-pcap source tree, or link to a jenkins log output where this happened? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ie6698d1c1d36e2b8a5391bc2322c1632458751db Gerrit-Change-Number: 14666 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith Gerrit-Comment-Date: Thu, 04 Jul 2019 07:37:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 10:22:17 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 10:22:17 +0000 Subject: Change in ...osmo-pcap[master]: tests/Makefile.am: Fix "./configure && make clean && make" In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/14666 to look at the new patch set (#2). Change subject: tests/Makefile.am: Fix "./configure && make clean && make" ...................................................................... tests/Makefile.am: Fix "./configure && make clean && make" Without this patch, make check fails with following error: No rule to make target 'atconfig', needed by 'check-local' Changes needed to fix the issue were gathered by looking at differences with libosmo-netif's Makefile. Change-Id: Ie6698d1c1d36e2b8a5391bc2322c1632458751db --- M tests/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/66/14666/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ie6698d1c1d36e2b8a5391bc2322c1632458751db Gerrit-Change-Number: 14666 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 11:11:05 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 11:11:05 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14612 to look at the new patch set (#4). Change subject: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers ...................................................................... osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers This change needs to be done in order avoid adding more and more arguments to the UL logical channel handlers (such as rx_rach_fn). Since we have different versions of the TRXD header, and may have other burst-based PHYs in the future, some fields of an Uplink burst indication have conditional presence. Change-Id: Iae6b78bafa4b86d0c681684de47320d641d3f7c0 Related: OS#4006, OS#1855 --- M include/osmo-bts/scheduler_backend.h M src/common/scheduler.c M src/osmo-bts-trx/scheduler_trx.c M src/osmo-bts-virtual/scheduler_virtbts.c 4 files changed, 189 insertions(+), 152 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/12/14612/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iae6b78bafa4b86d0c681684de47320d641d3f7c0 Gerrit-Change-Number: 14612 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 11:11:05 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 11:11:05 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts/scheduler: provide actual C/I values to OsmoPCU In-Reply-To: References: Message-ID: Hello tnt, pespin, ipse, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14613 to look at the new patch set (#4). Change subject: osmo-bts/scheduler: provide actual C/I values to OsmoPCU ...................................................................... osmo-bts/scheduler: provide actual C/I values to OsmoPCU C/I (Carrier-to-Interference ratio) is a value in cB (centiBels), computed from the training sequence of each received burst, by comparing the "ideal" training sequence with the actual one. So far, there was no way to expose more measurements from OsmoTRX, excluding both RSSI and ToA. Since the new version of TRXD header, we can receive C/I indications and send the averaged (per 4 bursts) values to OsmoPCU (as a part of PCUIF_DATA.ind). Please note that we also need to attach C/I measurements to the following L1SAP primitives: - PRIM_PH_RACH.ind, - PRIM_PH_DATA.ind, - PRIM_TCH.ind, but this will be done in the follow up changes. Change-Id: Ia58043bd2381a4d34d604522e02899ae64ee0d26 Fixes: OS#1855 --- M include/osmo-bts/scheduler.h M src/osmo-bts-trx/scheduler_trx.c 2 files changed, 18 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/13/14613/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia58043bd2381a4d34d604522e02899ae64ee0d26 Gerrit-Change-Number: 14613 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 11:11:06 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 11:11:06 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14669 Change subject: osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code ...................................................................... osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code This kind of debugging can be done using trx_sniff.py tool from the TRX Toolkit [1]. Probably, this code was needed during the initial development and testing. [1] https://git.osmocom.org/osmocom-bb/tree/src/target/trx_toolkit Change-Id: I50e0e5feeba4c3028f55209dd8e41e09ed5f70b1 --- M src/osmo-bts-trx/trx_if.c 1 file changed, 0 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/69/14669/1 diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index f2e8b90..0ae12c2 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -48,9 +48,6 @@ #include "l1_if.h" #include "trx_if.h" -/* enable to print RSSI level graph */ -//#define TOA_RSSI_DEBUG - int transceiver_available = 0; /* @@ -933,16 +930,6 @@ (bi.flags & TRX_BI_F_NOPE_IND) ? "NOPE.ind" : "UL burst", hdr_ver, bi.tn, bi.fn, bi.rssi, bi.toa256); -#ifdef TOA_RSSI_DEBUG - char deb[128]; - - sprintf(deb, "| 0 " - " | rssi=%4d toa=%5d fn=%u", - bi.rssi, bi.toa256, bi.fn); - deb[1 + (128 + bi.rssi) / 4] = '*'; - fprintf(stderr, "%s\n", deb); -#endif - /* feed received burst into scheduler code */ trx_sched_ul_burst(&l1h->l1s, &bi); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14669 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I50e0e5feeba4c3028f55209dd8e41e09ed5f70b1 Gerrit-Change-Number: 14669 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 11:11:07 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 11:11:07 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14670 Change subject: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs ...................................................................... osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs Since we may have different versions of the TRXD header, some new fields of an Uplink burst indication have conditional presence. Therefore we need a smart function to print them conditionally. Change-Id: I68729dc98a1840d2aa9e091153d176a103d5a228 Related: OS#4006 --- M src/osmo-bts-trx/trx_if.c 1 file changed, 45 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/70/14670/1 diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index 0ae12c2..e9193ca 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -738,6 +738,48 @@ return trx_data_handle_burst_v0(l1h, bi, buf, buf_len); } +static const char *trx_data_desc_msg(const struct trx_ul_burst_ind *bi) +{ + struct osmo_strbuf sb; + static char buf[256]; + + /* Modulation types defined in 3GPP TS 45.002 */ + static const char *mod_names[] = { + [TRX_BURST_GMSK] = "GMSK", + [TRX_BURST_8PSK] = "8-PSK", + }; + + /* Initialize the string buffer */ + sb = (struct osmo_strbuf) { .buf = buf, .len = sizeof(buf) }; + + /* Common TDMA parameters */ + OSMO_STRBUF_PRINTF(sb, "tn=%u fn=%u", bi->tn, bi->fn); + + /* Nothing else to print for NOPE.ind */ + if (bi->flags & TRX_BI_F_NOPE_IND) + return buf; + + /* RSSI and ToA256 */ + OSMO_STRBUF_PRINTF(sb, " rssi=%d toa256=%d", bi->rssi, bi->toa256); + + /* Modulation and TSC set */ + if (bi->flags & TRX_BI_F_MOD_TYPE) + OSMO_STRBUF_PRINTF(sb, " mod=%s", mod_names[bi->bt]); + + /* Training Sequence Code */ + if (bi->flags & TRX_BI_F_TS_INFO) + OSMO_STRBUF_PRINTF(sb, " set=%u tsc=%u", bi->tsc_set, bi->tsc); + + /* C/I: Carrier-to-Interference ratio (in centiBels) */ + if (bi->flags & TRX_BI_F_CI_CB) + OSMO_STRBUF_PRINTF(sb, " C/I=%d cB", bi->ci_cb); + + /* Burst length */ + OSMO_STRBUF_PRINTF(sb, " burst_len=%zu", bi->burst_len); + + return buf; +} + /* Parse TRXD message from transceiver, compose an UL burst indication. * * This message contains a demodulated Uplink burst with fixed-size @@ -924,11 +966,10 @@ if (rc < 0) return rc; - /* TODO: also print TSC and C/I */ - LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG, - "Rx %s (hdr_ver=%u): tn=%u fn=%u rssi=%d toa256=%d\n", + /* Print header & burst info */ + LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG, "Rx %s (hdr_ver=%u): %s\n", (bi.flags & TRX_BI_F_NOPE_IND) ? "NOPE.ind" : "UL burst", - hdr_ver, bi.tn, bi.fn, bi.rssi, bi.toa256); + hdr_ver, trx_data_desc_msg(&bi)); /* feed received burst into scheduler code */ trx_sched_ul_burst(&l1h->l1s, &bi); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I68729dc98a1840d2aa9e091153d176a103d5a228 Gerrit-Change-Number: 14670 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 11:14:31 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 11:14:31 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14593 ) Change subject: osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If61c71d20d590bf07bfd019afb33000a0b6135bd Gerrit-Change-Number: 14593 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 11:14:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 11:15:33 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 11:15:33 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8afe950bd1ec2afaf3347ff848ee46e69c4f5011 Gerrit-Change-Number: 14611 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: ipse Gerrit-Comment-Date: Thu, 04 Jul 2019 11:15:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 12:06:54 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 12:06:54 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: introduce TRXD header version handling In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14592 ) Change subject: osmo-bts-trx/trx_if.c: introduce TRXD header version handling ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14592/3/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/#/c/14592/3/src/common/scheduler.c at 1317 PS3, Line 1317: int trx_sched_ul_burst(struct l1sched_trx *l1t, struct trx_ul_burst_ind *bi) why did you drop the const in bi here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I171c18229ca3e5cab70de0064a31e47c78602c0c Gerrit-Change-Number: 14592 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 12:06:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 13:33:49 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Jul 2019 13:33:49 +0000 Subject: Change in ...osmo-pcap[master]: tests/Makefile.am: Fix "./configure && make clean && make" In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14666 ) Change subject: tests/Makefile.am: Fix "./configure && make clean && make" ...................................................................... Patch Set 2: Verified+1 Code-Review+2 (1 comment) Code looks good, I have reproduced the bug and verified that this patch fixes it. https://gerrit.osmocom.org/#/c/14666/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14666/2//COMMIT_MSG at 7 PS2, Line 7: make make check -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ie6698d1c1d36e2b8a5391bc2322c1632458751db Gerrit-Change-Number: 14666 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 04 Jul 2019 13:33:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 13:36:05 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Jul 2019 13:36:05 +0000 Subject: Change in ...osmo-pcap[master]: gitignore: fix application names Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14671 Change subject: gitignore: fix application names ...................................................................... gitignore: fix application names Change-Id: I4ea6b6691a0e6cfb3de0c9d2b1a0c3ed68a18514 --- M .gitignore 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/71/14671/1 diff --git a/.gitignore b/.gitignore index b80db93..882ef61 100644 --- a/.gitignore +++ b/.gitignore @@ -27,8 +27,8 @@ # apps -src/osmo_pcap_client -src/osmo_pcap_server +src/osmo-pcap-client +src/osmo-pcap-server # tests tests/atconfig -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I4ea6b6691a0e6cfb3de0c9d2b1a0c3ed68a18514 Gerrit-Change-Number: 14671 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 13:37:19 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 13:37:19 +0000 Subject: Change in ...osmo-pcap[master]: gitignore: fix application names In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14671 ) Change subject: gitignore: fix application names ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I4ea6b6691a0e6cfb3de0c9d2b1a0c3ed68a18514 Gerrit-Change-Number: 14671 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 13:37:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 13:38:19 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 13:38:19 +0000 Subject: Change in ...osmo-pcap[master]: tests/Makefile.am: Fix "./configure && make clean && make" In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14666 ) Change subject: tests/Makefile.am: Fix "./configure && make clean && make" ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14666/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14666/2//COMMIT_MSG at 7 PS2, Line 7: make > make check Nope, it happened during make. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ie6698d1c1d36e2b8a5391bc2322c1632458751db Gerrit-Change-Number: 14666 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 13:38:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 13:38:23 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 13:38:23 +0000 Subject: Change in ...osmo-pcap[master]: tests/Makefile.am: Fix "./configure && make clean && make" In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14666 ) Change subject: tests/Makefile.am: Fix "./configure && make clean && make" ...................................................................... tests/Makefile.am: Fix "./configure && make clean && make" Without this patch, make check fails with following error: No rule to make target 'atconfig', needed by 'check-local' Changes needed to fix the issue were gathered by looking at differences with libosmo-netif's Makefile. Change-Id: Ie6698d1c1d36e2b8a5391bc2322c1632458751db --- M tests/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved; Verified Jenkins Builder: Verified diff --git a/tests/Makefile.am b/tests/Makefile.am index def6e8b..720d631 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -17,6 +17,7 @@ } >'$(srcdir)/package.m4' EXTRA_DIST = testsuite.at $(srcdir)/package.m4 $(TESTSUITE) +DISTCLEANFILES = atconfig TESTSUITE = $(srcdir)/testsuite if ENABLE_EXT_TESTS @@ -39,7 +40,6 @@ clean-local: test ! -f '$(TESTSUITE)' || \ $(SHELL) '$(TESTSUITE)' --clean - $(RM) -f atconfig AUTOM4TE = $(SHELL) $(top_srcdir)/missing --run autom4te AUTOTEST = $(AUTOM4TE) --language=autotest -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ie6698d1c1d36e2b8a5391bc2322c1632458751db Gerrit-Change-Number: 14666 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 13:41:12 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 13:41:12 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14593 ) Change subject: osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If61c71d20d590bf07bfd019afb33000a0b6135bd Gerrit-Change-Number: 14593 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 13:41:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 13:41:35 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 13:41:35 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14669 ) Change subject: osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14669 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I50e0e5feeba4c3028f55209dd8e41e09ed5f70b1 Gerrit-Change-Number: 14669 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 13:41:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 13:43:23 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 4 Jul 2019 13:43:23 +0000 Subject: Change in ...osmo-pcap[master]: tests/Makefile.am: Fix "./configure && make clean && make" In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14666 ) Change subject: tests/Makefile.am: Fix "./configure && make clean && make" ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14666/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14666/2//COMMIT_MSG at 7 PS2, Line 7: make > Nope, it happened during make. not for me: $ ./configure && make clean && make ... Making all in tests make[2]: Entering directory '/home/user/code/osmo-dev/src/osmo-pcap/tests' make[2]: Nothing to be done for 'all'. make[2]: Leaving directory '/home/user/code/osmo-dev/src/osmo-pcap/tests' make[2]: Entering directory '/home/user/code/osmo-dev/src/osmo-pcap' make[2]: Leaving directory '/home/user/code/osmo-dev/src/osmo-pcap' make[1]: Leaving directory '/home/user/code/osmo-dev/src/osmo-pcap' $ ./configure && make clean && make check ... make[2]: Entering directory '/home/user/code/osmo-dev/src/osmo-pcap/tests' /usr/bin/make check-local make[3]: Entering directory '/home/user/code/osmo-dev/src/osmo-pcap/tests' make[3]: *** No rule to make target 'atconfig', needed by 'check-local'. Stop. make[3]: Leaving directory '/home/user/code/osmo-dev/src/osmo-pcap/tests' Makefile:314: recipe for target 'check-am' failed make[2]: *** [check-am] Error 2 make[2]: Leaving directory '/home/user/code/osmo-dev/src/osmo-pcap/tests' Makefile:389: recipe for target 'check-recursive' failed make[1]: *** [check-recursive] Error 1 make[1]: Leaving directory '/home/user/code/osmo-dev/src/osmo-pcap' Makefile:680: recipe for target 'check' failed make: *** [check] Error 2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ie6698d1c1d36e2b8a5391bc2322c1632458751db Gerrit-Change-Number: 14666 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 13:43:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 13:43:42 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 13:43:42 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14670 ) Change subject: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14670/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/14670/1/src/osmo-bts-trx/trx_if.c at 744 PS1, Line 744: static char buf[256]; Since we only use it in one place, makes more sense to pass a stack buffer instead of allocating a static buffer imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I68729dc98a1840d2aa9e091153d176a103d5a228 Gerrit-Change-Number: 14670 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 13:43:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 14:04:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 14:04:25 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version ...................................................................... Patch Set 5: Code-Review-1 (6 comments) https://gerrit.osmocom.org/#/c/14611/5//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14611/5//COMMIT_MSG at 17 PS5, Line 17: version, which can be either equal or lover than VER_REQ. In love is in the air! or maybe lower. https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/l1_if.h File src/osmo-bts-trx/l1_if.h: https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/l1_if.h at 11 PS5, Line 11: int setformat_sent; bool? https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/l1_if.c File src/osmo-bts-trx/l1_if.c: https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/l1_if.c at 214 PS5, Line 214: l1h->config.setformat_sent = 1; = true. Also, you set trxd_hdr_ver_req inside trx_if_cmd_setformat(), but this one here. Please move them to be in the same place. https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/trx_if.c at 446 PS5, Line 446: Seems we want to add code here to match the version parameter in SETFORMAT. https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/trx_if.c at 486 PS5, Line 486: if (rsp->status < 0 || rsp->status > TRX_DATA_FORMAT_VER) { You should check here if rsp->status > l1h->config.trxd_hdr_ver_req, since it should be equal or lower than the one you sent, not the one you support (which is unknown to trx). https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/trx_if.c at 529 PS5, Line 529: } else if (strcmp(tcm->cmd, "SETFORMAT") == 0) { Add a comment here on why tcm->cmd is used instead of rsp->cmd (due to RSP ERR 1 being answered). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8afe950bd1ec2afaf3347ff848ee46e69c4f5011 Gerrit-Change-Number: 14611 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: ipse Gerrit-Comment-Date: Thu, 04 Jul 2019 14:04:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 14:10:57 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 14:10:57 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14612 ) Change subject: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/#/c/14612/4/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14612/4/src/osmo-bts-trx/scheduler_trx.c at 1266 PS4, Line 1266: /* FIXME: this calculation is wrong */ some description on WHY would be welcome. https://gerrit.osmocom.org/#/c/14612/4/src/osmo-bts-trx/scheduler_trx.c at 1411 PS4, Line 1411: /* FIXME: what the hell is this?!? */ Not sure if all those comments belong to this patch. Since there are quite a lot of them and in here it's basically replacing fields with the pointer to struct, better push all those comments in a separate patch so we discuss them there. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iae6b78bafa4b86d0c681684de47320d641d3f7c0 Gerrit-Change-Number: 14612 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 14:10:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 14:12:43 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 14:12:43 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts/scheduler: provide actual C/I values to OsmoPCU In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14613 ) Change subject: osmo-bts/scheduler: provide actual C/I values to OsmoPCU ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia58043bd2381a4d34d604522e02899ae64ee0d26 Gerrit-Change-Number: 14613 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Thu, 04 Jul 2019 14:12:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 14:44:59 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 14:44:59 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: detectAnyBurst() family: Use struct to gather all out params Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14672 Change subject: sigProcLib: detectAnyBurst() family: Use struct to gather all out params ...................................................................... sigProcLib: detectAnyBurst() family: Use struct to gather all out params Currently we have 2 out parameters, but in forthcoming commits will add a third one. All those functions already have too many parameters, so let's put together all the output params in a struct to pass them easily and make it easier to understand they are the estimated output values. Related: OS#4006 Change-Id: I05cfa0ceaa2e633a5e6e404e2eae497ff4442dea --- M Transceiver52M/Transceiver.cpp M Transceiver52M/sigProcLib.cpp M Transceiver52M/sigProcLib.h 3 files changed, 45 insertions(+), 45 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/72/14672/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 4462cdd..5c5707b 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -575,8 +575,8 @@ bool Transceiver::pullRadioVector(size_t chan, struct trx_ul_burst_ind *bi) { int rc; - complex amp; - float toa, max = -1.0, avg = 0.0; + struct estim_burst_params ebp; + float max = -1.0, avg = 0.0; unsigned max_toa; int max_i = -1; signalVector *burst; @@ -654,7 +654,7 @@ mMaxExpectedDelayAB : mMaxExpectedDelayNB; /* Detect normal or RACH bursts */ - rc = detectAnyBurst(*burst, mTSC, BURST_THRESH, mSPSRx, type, amp, toa, max_toa); + rc = detectAnyBurst(*burst, mTSC, BURST_THRESH, mSPSRx, type, max_toa, &ebp); if (rc <= 0) { if (rc == -SIGERR_CLIP) LOG(WARNING) << "Clipping detected on received RACH or Normal Burst"; @@ -664,8 +664,8 @@ } type = (CorrType) rc; - bi->toa = toa; - rxBurst = demodAnyBurst(*burst, mSPSRx, amp, toa, type); + bi->toa = ebp.toa; + rxBurst = demodAnyBurst(*burst, mSPSRx, ebp.amp, ebp.toa, type); /* EDGE demodulator returns 444 (gSlotLen * 3) bits */ if (rxBurst->size() == EDGE_BURST_NBITS) diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp index cff7825..52a6701 100644 --- a/Transceiver52M/sigProcLib.cpp +++ b/Transceiver52M/sigProcLib.cpp @@ -1463,8 +1463,8 @@ */ static int detectBurst(const signalVector &burst, signalVector &corr, CorrelationSequence *sync, - float thresh, int sps, complex *amp, float *toa, - int start, int len) + float thresh, int sps, int start, int len, + struct estim_burst_params *ebp) { const signalVector *corr_in; signalVector *dec = NULL; @@ -1490,23 +1490,23 @@ sps = 1; /* Peak detection - place restrictions at correlation edges */ - *amp = fastPeakDetect(corr, toa); + ebp->amp = fastPeakDetect(corr, &ebp->toa); - if ((*toa < 3 * sps) || (*toa > len - 3 * sps)) + if ((ebp->toa < 3 * sps) || (ebp->toa > len - 3 * sps)) return 0; /* Peak -to-average ratio */ - if (computePeakRatio(&corr, sps, *toa, *amp) < thresh) + if (computePeakRatio(&corr, sps, ebp->toa, ebp->amp) < thresh) return 0; /* Compute peak-to-average ratio. Reject if we don't have enough values */ - *amp = peakDetect(corr, toa, NULL); + ebp->amp = peakDetect(corr, &ebp->toa, NULL); /* Normalize our channel gain */ - *amp = *amp / sync->gain; + ebp->amp = ebp->amp / sync->gain; /* Compensate for residuate time lag */ - *toa = *toa - sync->toa; + ebp->toa = ebp->toa - sync->toa; return 1; } @@ -1532,13 +1532,10 @@ * head: Search symbols before target * tail: Search symbols after target */ -static int detectGeneralBurst(const signalVector &rxBurst, - float thresh, - int sps, - complex &, - float &toa, +static int detectGeneralBurst(const signalVector &rxBurst, float thresh, int sps, int target, int head, int tail, - CorrelationSequence *sync) + CorrelationSequence *sync, + struct estim_burst_params *ebp) { int rc, start, len; bool clipping = false; @@ -1560,17 +1557,17 @@ signalVector corr(len); rc = detectBurst(rxBurst, corr, sync, - thresh, sps, &, &toa, start, len); + thresh, sps, start, len, ebp); if (rc < 0) { return -SIGERR_INTERNAL; } else if (!rc) { - amp = 0.0f; - toa = 0.0f; + ebp->amp = 0.0f; + ebp->toa = 0.0f; return clipping?-SIGERR_CLIP:SIGERR_NONE; } /* Subtract forward search bits from delay */ - toa -= head; + ebp->toa -= head; return 1; } @@ -1585,7 +1582,7 @@ * tail: Search 8 symbols + maximum expected delay */ static int detectRACHBurst(const signalVector &burst, float threshold, int sps, - complex &litude, float &toa, unsigned max_toa, bool ext) + unsigned max_toa, bool ext, struct estim_burst_params *ebp) { int rc, target, head, tail; int i, num_seq; @@ -1596,8 +1593,8 @@ num_seq = ext ? 3 : 1; for (i = 0; i < num_seq; i++) { - rc = detectGeneralBurst(burst, threshold, sps, amplitude, toa, - target, head, tail, gRACHSequences[i]); + rc = detectGeneralBurst(burst, threshold, sps, target, head, tail, + gRACHSequences[i], ebp); if (rc > 0) break; } @@ -1614,7 +1611,7 @@ * tail: Search 6 symbols + maximum expected delay */ static int analyzeTrafficBurst(const signalVector &burst, unsigned tsc, float threshold, - int sps, complex &litude, float &toa, unsigned max_toa) + int sps, unsigned max_toa, struct estim_burst_params *ebp) { int rc, target, head, tail; CorrelationSequence *sync; @@ -1627,13 +1624,12 @@ tail = 6 + max_toa; sync = gMidambles[tsc]; - rc = detectGeneralBurst(burst, threshold, sps, amplitude, toa, - target, head, tail, sync); + rc = detectGeneralBurst(burst, threshold, sps, target, head, tail, sync, ebp); return rc; } static int detectEdgeBurst(const signalVector &burst, unsigned tsc, float threshold, - int sps, complex &litude, float &toa, unsigned max_toa) + int sps, unsigned max_toa, struct estim_burst_params *ebp) { int rc, target, head, tail; CorrelationSequence *sync; @@ -1646,33 +1642,30 @@ tail = 6 + max_toa; sync = gEdgeMidambles[tsc]; - rc = detectGeneralBurst(burst, threshold, sps, amplitude, toa, - target, head, tail, sync); + rc = detectGeneralBurst(burst, threshold, sps, + target, head, tail, sync, ebp); return rc; } int detectAnyBurst(const signalVector &burst, unsigned tsc, float threshold, - int sps, CorrType type, complex &, float &toa, - unsigned max_toa) + int sps, CorrType type, unsigned max_toa, + struct estim_burst_params *ebp) { int rc = 0; switch (type) { case EDGE: - rc = detectEdgeBurst(burst, tsc, threshold, sps, - amp, toa, max_toa); + rc = detectEdgeBurst(burst, tsc, threshold, sps, max_toa, ebp); if (rc > 0) break; else type = TSC; case TSC: - rc = analyzeTrafficBurst(burst, tsc, threshold, sps, - amp, toa, max_toa); + rc = analyzeTrafficBurst(burst, tsc, threshold, sps, max_toa, ebp); break; case EXT_RACH: case RACH: - rc = detectRACHBurst(burst, threshold, sps, amp, toa, - max_toa, type == EXT_RACH); + rc = detectRACHBurst(burst, threshold, sps, max_toa, type == EXT_RACH, ebp); break; default: LOG(ERR) << "Invalid correlation type"; diff --git a/Transceiver52M/sigProcLib.h b/Transceiver52M/sigProcLib.h index bae2127..8442cfc 100644 --- a/Transceiver52M/sigProcLib.h +++ b/Transceiver52M/sigProcLib.h @@ -101,15 +101,23 @@ */ float energyDetect(const signalVector &rxBurst, unsigned windowLength); + +/** Struct used to fill out parameters in detectAnyBurst(): estimated burst parameters + at param amplitude The estimated amplitude of received TSC burst. + at param toa The estimated time-of-arrival of received TSC burst (in symbols). +*/ +struct estim_burst_params { + complex amp; + float toa; +}; /** 8-PSK/GMSK/RACH burst detector @param burst The received GSM burst of interest @param tsc Midamble type (0..7) also known as TSC @param threshold The threshold that the received burst's post-correlator SNR is compared against to determine validity. @param sps The number of samples per GSM symbol. - @param amplitude The estimated amplitude of received TSC burst. - @param toa The estimate time-of-arrival of received TSC burst (in symbols). @param max_toa The maximum expected time-of-arrival (in symbols). + @param ebp The estimated parameters of the detected burst. @return positive value (CorrType) if threshold value is reached, negative value (-SignalError) on error, zero (SIGERR_NONE) if no burst is detected @@ -119,9 +127,8 @@ float threshold, int sps, CorrType type, - complex &, - float &toa, - unsigned max_toa); + unsigned max_toa, + struct estim_burst_params *ebp); /** Demodulate burst basde on type and output soft bits */ SoftVector *demodAnyBurst(const signalVector &burst, int sps, -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I05cfa0ceaa2e633a5e6e404e2eae497ff4442dea Gerrit-Change-Number: 14672 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 14:44:59 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 14:44:59 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: detectAnyBurst(): make TSC used to detect burst available... Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14673 Change subject: sigProcLib: detectAnyBurst(): make TSC used to detect burst available to caller ...................................................................... sigProcLib: detectAnyBurst(): make TSC used to detect burst available to caller This value will be sent in TRXDv1 protocol. Related: OS#4006 Change-Id: I603b7b52f957cf897b036dbaeb22c01a55de08c3 --- M Transceiver52M/sigProcLib.cpp M Transceiver52M/sigProcLib.h 2 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/73/14673/1 diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp index 52a6701..c22009a 100644 --- a/Transceiver52M/sigProcLib.cpp +++ b/Transceiver52M/sigProcLib.cpp @@ -1595,8 +1595,10 @@ for (i = 0; i < num_seq; i++) { rc = detectGeneralBurst(burst, threshold, sps, target, head, tail, gRACHSequences[i], ebp); - if (rc > 0) + if (rc > 0) { + ebp->tsc = i; break; + } } return rc; @@ -1624,6 +1626,7 @@ tail = 6 + max_toa; sync = gMidambles[tsc]; + ebp->tsc = tsc; rc = detectGeneralBurst(burst, threshold, sps, target, head, tail, sync, ebp); return rc; } @@ -1642,6 +1645,7 @@ tail = 6 + max_toa; sync = gEdgeMidambles[tsc]; + ebp->tsc = tsc; rc = detectGeneralBurst(burst, threshold, sps, target, head, tail, sync, ebp); return rc; diff --git a/Transceiver52M/sigProcLib.h b/Transceiver52M/sigProcLib.h index 8442cfc..6d4ca9b 100644 --- a/Transceiver52M/sigProcLib.h +++ b/Transceiver52M/sigProcLib.h @@ -105,10 +105,12 @@ /** Struct used to fill out parameters in detectAnyBurst(): estimated burst parameters @param amplitude The estimated amplitude of received TSC burst. @param toa The estimated time-of-arrival of received TSC burst (in symbols). + at param tsc The TSC used to detect the burst. */ struct estim_burst_params { complex amp; float toa; + uint8_t tsc; }; /** 8-PSK/GMSK/RACH burst detector -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14673 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I603b7b52f957cf897b036dbaeb22c01a55de08c3 Gerrit-Change-Number: 14673 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 14:45:40 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 14:45:40 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support TRXD v1 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14657 ) Change subject: Transceiver: Support TRXD v1 ...................................................................... Patch Set 6: (2 comments) This change is ready for review. https://gerrit.osmocom.org/#/c/14657/5/Transceiver52M/proto_trxd.h File Transceiver52M/proto_trxd.h: https://gerrit.osmocom.org/#/c/14657/5/Transceiver52M/proto_trxd.h at 17 PS5, Line 17: Not supported yet > Neither OsmoTRX will support them any time soon. Sure, I just wanted to list them here since they are also described in the protocol header. https://gerrit.osmocom.org/#/c/14657/2/Transceiver52M/proto_trxd.c File Transceiver52M/proto_trxd.c: https://gerrit.osmocom.org/#/c/14657/2/Transceiver52M/proto_trxd.c at 68 PS2, Line 68: pkt->common.version = 1; : pkt->common.reserved = 0; : pkt->common.tn = bi->tn; : osmo_store32be(bi->fn, &pkt->common.fn); : pkt->v1.rssi = bi->rssi; : osmo_store16be(toa_int, &pkt->v1.toa); > This basically duplicates what trxd_send_burst_ind_v0() does. [?] I don't think it's really a benefit moving it, since anyway one still needs to set version bit differently for instance. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 14:45:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 15:18:39 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 15:18:39 +0000 Subject: Change in ...osmo-trx[master]: Add C/I computation Message-ID: Hello tnt, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 to review the following change. Change subject: Add C/I computation ...................................................................... Add C/I computation Change-Id: Ib4ceec553f2e5f77bf3f6777724968456a180f5e Signed-off-by: Sylvain Munaut --- M Transceiver52M/Transceiver.cpp M Transceiver52M/sigProcLib.cpp M Transceiver52M/sigProcLib.h 3 files changed, 34 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/74/14674/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 32297b6..f90decd 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -621,7 +621,7 @@ bi->modulation = (type == EDGE) ? MODULATION_8PSK : MODULATION_GMSK; bi->tss = 0; /* TODO: we only support tss 0 right now */ bi->tsc = 0; - bi->ci = 0; /* TODO: calculate C/I and assign the value here, see branch tnt/ci. */ + bi->ci = 0; /* Select the diversity channel with highest energy */ for (size_t i = 0; i < radio_burst->chans(); i++) { @@ -670,6 +670,7 @@ type = (CorrType) rc; bi->toa = ebp.toa; bi->tsc = ebp.tsc; + bi->ci = (int16_t) ebp.ci; rxBurst = demodAnyBurst(*burst, mSPSRx, ebp.amp, ebp.toa, type); /* EDGE demodulator returns 444 (gSlotLen * 3) bits */ diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp index c22009a..a65ea5e 100644 --- a/Transceiver52M/sigProcLib.cpp +++ b/Transceiver52M/sigProcLib.cpp @@ -1453,6 +1453,28 @@ return out; }; +static float computeCI(const signalVector *burst, CorrelationSequence *sync, + float toa, int start, complex xcorr) +{ + float S, C; + int ps; + + /* Integer position where the sequence starts */ + ps = start + 1 - sync->sequence->size() + (int)roundf(toa); + + /* Estimate Signal power */ + S = 0.0f; + for (int i=0, j=ps; i<(int)sync->sequence->size(); i++,j++) + S += (*burst)[j].norm2(); + S /= sync->sequence->size(); + + /* Esimate Carrier power */ + C = xcorr.norm2() / ((sync->sequence->size() - 1) * sync->gain.abs()); + + /* Interference = Signal - Carrier, so C/I = C / (S - C) */ + return 3.0103f * log2f(C / (S - C)); +} + /* * Detect a burst based on correlation and peak-to-average ratio * @@ -1468,6 +1490,7 @@ { const signalVector *corr_in; signalVector *dec = NULL; + complex xcorr; if (sps == 4) { dec = downsampleBurst(burst); @@ -1495,15 +1518,18 @@ if ((ebp->toa < 3 * sps) || (ebp->toa > len - 3 * sps)) return 0; - /* Peak -to-average ratio */ + /* Peak-to-average ratio */ if (computePeakRatio(&corr, sps, ebp->toa, ebp->amp) < thresh) return 0; - /* Compute peak-to-average ratio. Reject if we don't have enough values */ - ebp->amp = peakDetect(corr, &ebp->toa, NULL); + /* Refine TOA and correlation value */ + xcorr = peakDetect(corr, &ebp->toa, NULL); + + /* Compute C/I */ + ebp->ci = computeCI(corr_in, sync, ebp->toa, start, xcorr); /* Normalize our channel gain */ - ebp->amp = ebp->amp / sync->gain; + ebp->amp = xcorr / sync->gain; /* Compensate for residuate time lag */ ebp->toa = ebp->toa - sync->toa; @@ -1563,6 +1589,7 @@ } else if (!rc) { ebp->amp = 0.0f; ebp->toa = 0.0f; + ebp->ci = 0.0f; return clipping?-SIGERR_CLIP:SIGERR_NONE; } diff --git a/Transceiver52M/sigProcLib.h b/Transceiver52M/sigProcLib.h index 6d4ca9b..fd9a5f0 100644 --- a/Transceiver52M/sigProcLib.h +++ b/Transceiver52M/sigProcLib.h @@ -111,6 +111,7 @@ complex amp; float toa; uint8_t tsc; + float ci; }; /** 8-PSK/GMSK/RACH burst detector -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib4ceec553f2e5f77bf3f6777724968456a180f5e Gerrit-Change-Number: 14674 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: tnt Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 15:30:35 2019 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Thu, 4 Jul 2019 15:30:35 +0000 Subject: Change in ...osmo-trx[master]: Add C/I computation In-Reply-To: References: Message-ID: tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14674 ) Change subject: Add C/I computation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib4ceec553f2e5f77bf3f6777724968456a180f5e Gerrit-Change-Number: 14674 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-Comment-Date: Thu, 04 Jul 2019 15:30:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 15:36:32 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 15:36:32 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation In-Reply-To: References: Message-ID: Hello tnt, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 to look at the new patch set (#2). Change subject: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation ...................................................................... sigProcLib: Add C/I (Carrier-to-Interference ratio) computation Related: OS#4006 Change-Id: Ib4ceec553f2e5f77bf3f6777724968456a180f5e --- M Transceiver52M/sigProcLib.cpp M Transceiver52M/sigProcLib.h 2 files changed, 37 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/74/14674/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib4ceec553f2e5f77bf3f6777724968456a180f5e Gerrit-Change-Number: 14674 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 15:36:32 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 15:36:32 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support TRXD v1 In-Reply-To: References: Message-ID: Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 to look at the new patch set (#7). Change subject: Transceiver: Support TRXD v1 ...................................................................... Transceiver: Support TRXD v1 C/I value still needs to be computed and set in bi in pullRadioVector(). Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/proto_trxd.c M Transceiver52M/proto_trxd.h 3 files changed, 95 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/57/14657/7 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 15:41:49 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 15:41:49 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version ...................................................................... Patch Set 5: (5 comments) https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/l1_if.h File src/osmo-bts-trx/l1_if.h: https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/l1_if.h at 11 PS5, Line 11: int setformat_sent; > bool? Other *_sent members are using int. Feel free to fix this in a separate change, I don't think it's critical and deserves that much attention. https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/l1_if.c File src/osmo-bts-trx/l1_if.c: https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/l1_if.c at 214 PS5, Line 214: l1h->config.setformat_sent = 1; > move them to be in the same place ACK. https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/trx_if.c at 446 PS5, Line 446: > Seems we want to add code here to match the version parameter in SETFORMAT. Huh, I thought we're doing this already for all commands. And that's why we decided to keep the requested version in the response... As it turns out, we do match the command only. For sure, I can add SETFORMAT here, but what about other commands? What if we send 'CMD TXTUNE 890000', but receive 'RSP TXTUNE 000000'? Why this matching should be implemented for every separate command individually? https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/trx_if.c at 486 PS5, Line 486: if (rsp->status < 0 || rsp->status > TRX_DATA_FORMAT_VER) { > You should check here if rsp->status > l1h->config. [?] ACK. https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/trx_if.c at 529 PS5, Line 529: } else if (strcmp(tcm->cmd, "SETFORMAT") == 0) { > Add a comment here on why tcm->cmd is used instead of rsp->cmd (due to RSP ERR 1 being answered). ACK! -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8afe950bd1ec2afaf3347ff848ee46e69c4f5011 Gerrit-Change-Number: 14611 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: ipse Gerrit-Comment-Date: Thu, 04 Jul 2019 15:41:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 15:45:11 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 15:45:11 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: introduce TRXD header version handling In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14592 ) Change subject: osmo-bts-trx/trx_if.c: introduce TRXD header version handling ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14592/3/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/#/c/14592/3/src/common/scheduler.c at 1317 PS3, Line 1317: int trx_sched_ul_burst(struct l1sched_trx *l1t, struct trx_ul_burst_ind *bi) > why did you drop the const in bi here? Because we may need to decipher bi->burst below, so const is not applicable anymore. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I171c18229ca3e5cab70de0064a31e47c78602c0c Gerrit-Change-Number: 14592 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 15:45:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 16:05:38 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 16:05:38 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation In-Reply-To: References: Message-ID: Hello tnt, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 to look at the new patch set (#3). Change subject: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation ...................................................................... sigProcLib: Add C/I (Carrier-to-Interference ratio) computation Related: OS#4006 Change-Id: Ib4ceec553f2e5f77bf3f6777724968456a180f5e --- M Transceiver52M/Transceiver.cpp M Transceiver52M/sigProcLib.cpp M Transceiver52M/sigProcLib.h 3 files changed, 52 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/74/14674/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib4ceec553f2e5f77bf3f6777724968456a180f5e Gerrit-Change-Number: 14674 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 16:25:35 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 16:25:35 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation In-Reply-To: References: Message-ID: Hello tnt, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 to look at the new patch set (#4). Change subject: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation ...................................................................... sigProcLib: Add C/I (Carrier-to-Interference ratio) computation Related: OS#4006 Change-Id: Ib4ceec553f2e5f77bf3f6777724968456a180f5e --- M Transceiver52M/sigProcLib.cpp M Transceiver52M/sigProcLib.h 2 files changed, 51 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/74/14674/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib4ceec553f2e5f77bf3f6777724968456a180f5e Gerrit-Change-Number: 14674 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 16:25:35 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 16:25:35 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support TRXD v1 In-Reply-To: References: Message-ID: Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 to look at the new patch set (#9). Change subject: Transceiver: Support TRXD v1 ...................................................................... Transceiver: Support TRXD v1 C/I value still needs to be computed and set in bi in pullRadioVector(). Related: OS#4006 Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/proto_trxd.c M Transceiver52M/proto_trxd.h 3 files changed, 96 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/57/14657/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 16:26:20 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 16:26:20 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 ) Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1ee28daf21dc287bec564d45d58086d63655c0f6 Gerrit-Change-Number: 14640 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 04 Jul 2019 16:26:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 16:27:57 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 16:27:57 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version In-Reply-To: References: Message-ID: Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14611 to look at the new patch set (#6). Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version ...................................................................... osmo-bts-trx/trx_if.c: request the newest TRXD header version This change introduces the new command for TRXD header version negotiation - SETFORMAT. If the transceiver does not support the format negotiation, it would reject this command with 'RSP ERR 1'. Otherwise the response should be: RSP SETFORMAT where VER_REQ is the requested version, and VER is the actual version, which can be either equal or lower than VER_REQ. In other words, the transceiver may not support the requested version, but a lower one, for example: L1 -> TRX: CMD SETFORMAT 2 TRX -> L1: RSP SETFORMAT 1 2 Unlike OsmoTRX, FakeTRX does not reject unknown commands, but confirm them. Thus older versions of FakeTRX would always respond with status code 0, corresponding to version 0: L1 -> TRX: CMD SETFORMAT 2 TRX -> L1: RSP SETFORMAT 0 2 Change-Id: I8afe950bd1ec2afaf3347ff848ee46e69c4f5011 Related: OS#4006 --- M src/osmo-bts-trx/l1_if.c M src/osmo-bts-trx/l1_if.h M src/osmo-bts-trx/trx_if.c M src/osmo-bts-trx/trx_if.h 4 files changed, 71 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/11/14611/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8afe950bd1ec2afaf3347ff848ee46e69c4f5011 Gerrit-Change-Number: 14611 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: ipse Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 16:32:16 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 16:32:16 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14641 ) Change subject: Transceiver: Move soft bits normalization to pullRadioVector() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ibfb48877af4ff5ef0f56390901669c8353beaf48 Gerrit-Change-Number: 14641 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 04 Jul 2019 16:32:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 16:32:50 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 16:32:50 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 ) Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iadf2683d7f52138a2248598641f3b702252f325d Gerrit-Change-Number: 14642 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 04 Jul 2019 16:32:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 16:34:49 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 16:34:49 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/14611/5/src/osmo-bts-trx/trx_if.c at 446 PS5, Line 446: > Huh, I thought we're doing this already for all commands. [?] You either do blacklist or whitelist. So far it's done this way because when I was fixing protocol issues this specific command was giving issues (SETSLOT), where RESP to retransmissions for one slot were being read if there were for the next one. Other commands probably need to be added, but I guess in the end the only problematic ones are commands which are usually sent with different parameters one after the other (queued in the command list), like: SETSLOT 1 2 RESP SETSLOT 0 1 2 SETSLOT 2 2 RESP SETSLOT 0 2 2 In this case, for SETFORMAT, we have a similar issue, so we want to add it here for sure, since it should usually happen: SETFORMAT X RESP SETFORMAT Y X SET FORMAT Y RESP SETFORMAT Y Y -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8afe950bd1ec2afaf3347ff848ee46e69c4f5011 Gerrit-Change-Number: 14611 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: ipse Gerrit-Comment-Date: Thu, 04 Jul 2019 16:34:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 16:36:10 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 16:36:10 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: request the newest TRXD header version In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: request the newest TRXD header version ...................................................................... Patch Set 6: Code-Review-1 See my comment from previous patch version. Once that's fixed, +1 from me. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8afe950bd1ec2afaf3347ff848ee46e69c4f5011 Gerrit-Change-Number: 14611 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: ipse Gerrit-Comment-Date: Thu, 04 Jul 2019 16:36:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 16:38:46 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 16:38:46 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Not critical. https://gerrit.osmocom.org/#/c/14643/2/Transceiver52M/sigProcLib.cpp File Transceiver52M/sigProcLib.cpp: https://gerrit.osmocom.org/#/c/14643/2/Transceiver52M/sigProcLib.cpp at 536 PS2, Line 536: cosmetic: I personally prefer tabs, but since the whole file is using spaces, it makes sense to keep the code consistent. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I726e5a98a43367a22c9a4ca5cbd9eb87e6765c7a Gerrit-Change-Number: 14643 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 16:38:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 16:40:37 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 16:40:37 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib19856a3e0a7607f63436c4a80b1381a3f318764 Gerrit-Change-Number: 14644 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 16:40:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 16:40:45 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 16:40:45 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14643/2/Transceiver52M/sigProcLib.cpp File Transceiver52M/sigProcLib.cpp: https://gerrit.osmocom.org/#/c/14643/2/Transceiver52M/sigProcLib.cpp at 536 PS2, Line 536: > cosmetic: I personally prefer tabs, but since the whole file is using spaces, it makes sense to keep [?] Since I had to rewrite the whole function, I thought it's a good moment to move to tabs ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I726e5a98a43367a22c9a4ca5cbd9eb87e6765c7a Gerrit-Change-Number: 14643 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 16:40:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 16:43:20 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 16:43:20 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Avoid noise calculation formula in 2 branches in pullRad... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14661 ) Change subject: Transceiver: Avoid noise calculation formula in 2 branches in pullRadioVector ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14661/1/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/14661/1/Transceiver52M/Transceiver.cpp at 645 PS1, Line 645: return false; TODO: we can send IDLE indications with noise measurements from here later on. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I56c84e9684ca460efd6c983d7e95d8e455bcac69 Gerrit-Change-Number: 14661 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Jul 2019 16:43:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 17:07:50 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 17:07:50 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Simplify code on early error return when calling detectA... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14662 ) Change subject: Transceiver: Simplify code on early error return when calling detectAnyBurst ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I026e35262bfe42c3d23ebdc06d84e4908a8380e2 Gerrit-Change-Number: 14662 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Jul 2019 17:07:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 18:24:36 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 18:24:36 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: pullRadioVector(): Move initialization of var to start o... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14663 ) Change subject: Transceiver: pullRadioVector(): Move initialization of var to start of function ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14663 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Icd2793adc7b73a795184639b95fb5da336909b59 Gerrit-Change-Number: 14663 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Jul 2019 18:24:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 18:24:47 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 4 Jul 2019 18:24:47 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support pulling idle frames in pullRadioVector() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14664 ) Change subject: Transceiver: Support pulling idle frames in pullRadioVector() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14664 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I46404f6e4055b6d3af3afffb0dfe4a19502917aa Gerrit-Change-Number: 14664 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Thu, 04 Jul 2019 18:24:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 22:08:48 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 22:08:48 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu... In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 ) Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() ...................................................................... Patch Set 2: Code-Review+2 +1+1=+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1ee28daf21dc287bec564d45d58086d63655c0f6 Gerrit-Change-Number: 14640 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 22:08:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 22:08:59 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 22:08:59 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 ) Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind ...................................................................... Patch Set 2: +1+1=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iadf2683d7f52138a2248598641f3b702252f325d Gerrit-Change-Number: 14642 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 22:08:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 22:09:03 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 22:09:03 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 ) Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iadf2683d7f52138a2248598641f3b702252f325d Gerrit-Change-Number: 14642 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 22:09:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 22:09:12 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 22:09:12 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind ...................................................................... Patch Set 2: Code-Review+2 +1+1=+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I726e5a98a43367a22c9a4ca5cbd9eb87e6765c7a Gerrit-Change-Number: 14643 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 22:09:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 22:09:22 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 22:09:22 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API ...................................................................... Patch Set 2: Code-Review+2 +1+1=+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib19856a3e0a7607f63436c4a80b1381a3f318764 Gerrit-Change-Number: 14644 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 04 Jul 2019 22:09:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 22:09:40 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 22:09:40 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu... In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 ) Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() ...................................................................... Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() That's where all the filling logic happens, while in driveReceiveFIFO we mostly want to take the burst, generate a message and sent it over the socket. In pullRadioVector this way we always provide normalized values based on user configuration (VTY rssi-offset). Related: OS#4006 Change-Id: I1ee28daf21dc287bec564d45d58086d63655c0f6 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 11 insertions(+), 13 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index a0ff4cd..5a6b652 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -606,19 +606,19 @@ burst = radio_burst->getVector(max_i); avg = sqrt(avg / radio_burst->chans()); - bi->rssi = 20.0 * log10(rxFullScale / avg); + bi->rssi = 20.0 * log10(rxFullScale / avg) + rssiOffset; if (type == IDLE) { /* Update noise levels */ state->mNoises.insert(avg); state->mNoiseLev = state->mNoises.avg(); - bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev); + bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset; delete radio_burst; return false; } else { /* Do not update noise levels */ - bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev); + bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset; } unsigned max_toa = (type == RACH || type == EXT_RACH) ? @@ -906,22 +906,21 @@ } } -void Transceiver::logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi, double dbm) +void Transceiver::logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi) { LOG(DEBUG) << std::fixed << std::right << " chan: " << chan << " time: " << bi->burstTime - << " RSSI: " << std::setw(5) << std::setprecision(1) << bi->rssi - << "dBFS/" << std::setw(6) << -dbm << "dBm" - << " noise: " << std::setw(5) << std::setprecision(1) << bi->noise - << "dBFS/" << std::setw(6) << -(bi->noise + rssiOffset) << "dBm" + << " RSSI: " << std::setw(5) << std::setprecision(1) << (bi->rssi - rssiOffset) + << "dBFS/" << std::setw(6) << -bi->rssi << "dBm" + << " noise: " << std::setw(5) << std::setprecision(1) << (bi->noise - rssiOffset) + << "dBFS/" << std::setw(6) << -bi->noise << "dBm" << " TOA: " << std::setw(5) << std::setprecision(2) << bi->toa << " bits: " << *(bi->rxBurst); } void Transceiver::driveReceiveFIFO(size_t chan) { - double dBm; // in dBm int TOAint; // in 1/256 symbols struct trx_ul_burst_ind bi; @@ -932,8 +931,7 @@ // Convert -1..+1 soft bits to 0..1 soft bits vectorSlicer(bi.rxBurst); - dBm = bi.rssi + rssiOffset; - logRxBurst(chan, &bi, dBm); + logRxBurst(chan, &bi); TOAint = (int) (bi.toa * 256.0 + 0.5); // round to closest integer @@ -943,7 +941,7 @@ pkt->common.reserved = 0; pkt->common.tn = bi.burstTime.TN(); osmo_store32be(bi.burstTime.FN(), &pkt->common.fn); - pkt->v0.rssi = dBm; + pkt->v0.rssi = bi.rssi; osmo_store16be(TOAint, &pkt->v0.toa); SoftVector::iterator burstItr = bi.rxBurst->begin(); diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index d7c6182..7963519 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -271,7 +271,7 @@ /** set priority on current thread */ void setPriority(float prio = 0.5) { mRadioInterface->setPriority(prio); } - void logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi, double dbm); + void logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi); }; void *RxUpperLoopAdapter(TransceiverChannel *); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1ee28daf21dc287bec564d45d58086d63655c0f6 Gerrit-Change-Number: 14640 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 22:09:40 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 22:09:40 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector() In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14641 ) Change subject: Transceiver: Move soft bits normalization to pullRadioVector() ...................................................................... Transceiver: Move soft bits normalization to pullRadioVector() That's where all the filling logic happens, while in driveReceiveFIFO we mostly want to take the burst, generate a message and sent it over the socket. Related: OS#4006 Change-Id: Ibfb48877af4ff5ef0f56390901669c8353beaf48 --- M Transceiver52M/Transceiver.cpp 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 5a6b652..a6a32f0 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -649,6 +649,9 @@ else /* size() here is actually gSlotLen + 8, due to guard periods */ bi->nbits = gSlotLen; + // Convert -1..+1 soft bits to 0..1 soft bits + vectorSlicer(bi->rxBurst); + delete radio_burst; return true; } @@ -928,9 +931,6 @@ if (!pullRadioVector(chan, &bi)) return; - // Convert -1..+1 soft bits to 0..1 soft bits - vectorSlicer(bi.rxBurst); - logRxBurst(chan, &bi); TOAint = (int) (bi.toa * 256.0 + 0.5); // round to closest integer -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ibfb48877af4ff5ef0f56390901669c8353beaf48 Gerrit-Change-Number: 14641 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 22:09:41 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 22:09:41 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 ) Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind ...................................................................... Transceiver: Drop use of GSM::Time from trx_ul_burst_ind Use of that class is really not needed since we don't need to do any calculation with those values, so we can simply store the final values in the struct. Related: OS#4006 Change-Id: Iadf2683d7f52138a2248598641f3b702252f325d --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 11 insertions(+), 7 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index a6a32f0..6e678ac 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -558,6 +558,7 @@ float toa, max = -1.0, avg = 0.0; int max_i = -1; signalVector *burst; + GSM::Time burstTime; TransceiverState *state = &mStates[chan]; /* Blocking FIFO read */ @@ -566,8 +567,10 @@ return false; /* Set time and determine correlation type */ - bi->burstTime = radio_burst->getTime(); - CorrType type = expectedCorrType(bi->burstTime, chan); + burstTime = radio_burst->getTime(); + bi->fn = burstTime.FN(); + bi->tn = burstTime.TN(); + CorrType type = expectedCorrType(burstTime, chan); /* Enable 8-PSK burst detection if EDGE is enabled */ if (mEdge && (type == TSC)) @@ -576,7 +579,7 @@ /* Debug: dump bursts to disk */ /* bits 0-7 - chan 0 timeslots * bits 8-15 - chan 1 timeslots */ - if (mWriteBurstToDiskMask & ((1<burstTime.TN()) << (8*chan))) + if (mWriteBurstToDiskMask & ((1<tn) << (8*chan))) writeToFile(radio_burst, chan); /* No processing if the timeslot is off. @@ -913,7 +916,7 @@ { LOG(DEBUG) << std::fixed << std::right << " chan: " << chan - << " time: " << bi->burstTime + << " time: " << bi->tn << ":" << bi->fn << " RSSI: " << std::setw(5) << std::setprecision(1) << (bi->rssi - rssiOffset) << "dBFS/" << std::setw(6) << -bi->rssi << "dBm" << " noise: " << std::setw(5) << std::setprecision(1) << (bi->noise - rssiOffset) @@ -939,8 +942,8 @@ struct trxd_hdr_v0* pkt = (struct trxd_hdr_v0*)burstString; pkt->common.version = 0; pkt->common.reserved = 0; - pkt->common.tn = bi.burstTime.TN(); - osmo_store32be(bi.burstTime.FN(), &pkt->common.fn); + pkt->common.tn = bi.tn; + osmo_store32be(bi.fn, &pkt->common.fn); pkt->v0.rssi = bi.rssi; osmo_store16be(TOAint, &pkt->v0.toa); SoftVector::iterator burstItr = bi.rxBurst->begin(); diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index 7963519..9975823 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -38,7 +38,8 @@ struct trx_ul_burst_ind { SoftVector *rxBurst; unsigned nbits; // number of symbols per slot in rxBurst, not counting guard periods - GSM::Time burstTime; + uint32_t fn; // TDMA frame number + uint8_t tn; // TDMA time-slot number double rssi; // in dBFS double toa; // in symbols double noise; // noise level in dBFS -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iadf2683d7f52138a2248598641f3b702252f325d Gerrit-Change-Number: 14642 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 22:09:41 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 22:09:41 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind ...................................................................... Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind Make the interface using trx_ul_burst_ind more implementation agnostic as well as easier to use. For instance, we don't care about SoftVector size one returned from pullRadioVector(); we want to use nbits instead. As a result, we no longer spend time normalizing guard periods. While at it, change vectorSLicer to return void since it always returns true. Change-Id: I726e5a98a43367a22c9a4ca5cbd9eb87e6765c7a --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h M Transceiver52M/sigProcLib.cpp M Transceiver52M/sigProcLib.h 4 files changed, 29 insertions(+), 21 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 6e678ac..4fc277b 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -559,6 +559,7 @@ int max_i = -1; signalVector *burst; GSM::Time burstTime; + SoftVector *rxBurst; TransceiverState *state = &mStates[chan]; /* Blocking FIFO read */ @@ -644,17 +645,18 @@ } bi->toa = toa; - bi->rxBurst = demodAnyBurst(*burst, mSPSRx, amp, toa, type); + rxBurst = demodAnyBurst(*burst, mSPSRx, amp, toa, type); /* EDGE demodulator returns 444 (gSlotLen * 3) bits */ - if (bi->rxBurst->size() == EDGE_BURST_NBITS) + if (rxBurst->size() == EDGE_BURST_NBITS) bi->nbits = EDGE_BURST_NBITS; else /* size() here is actually gSlotLen + 8, due to guard periods */ bi->nbits = gSlotLen; // Convert -1..+1 soft bits to 0..1 soft bits - vectorSlicer(bi->rxBurst); + vectorSlicer(bi->rx_burst, rxBurst->begin(), bi->nbits); + delete rxBurst; delete radio_burst; return true; } @@ -914,6 +916,14 @@ void Transceiver::logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi) { + std::ostringstream os; + for (size_t i=0; i < bi->nbits; i++) { + if (bi->rx_burst[i] > 0.5) os << "1"; + else if (bi->rx_burst[i] > 0.25) os << "|"; + else if (bi->rx_burst[i] > 0.0) os << "'"; + else os << "-"; + } + LOG(DEBUG) << std::fixed << std::right << " chan: " << chan << " time: " << bi->tn << ":" << bi->fn @@ -922,7 +932,7 @@ << " noise: " << std::setw(5) << std::setprecision(1) << (bi->noise - rssiOffset) << "dBFS/" << std::setw(6) << -bi->noise << "dBm" << " TOA: " << std::setw(5) << std::setprecision(2) << bi->toa - << " bits: " << *(bi->rxBurst); + << " bits: " << os; } void Transceiver::driveReceiveFIFO(size_t chan) @@ -946,14 +956,12 @@ osmo_store32be(bi.fn, &pkt->common.fn); pkt->v0.rssi = bi.rssi; osmo_store16be(TOAint, &pkt->v0.toa); - SoftVector::iterator burstItr = bi.rxBurst->begin(); for (unsigned i = 0; i < bi.nbits; i++) - pkt->soft_bits[i] = (char) round((*burstItr++) * 255.0); + pkt->soft_bits[i] = (char) round(bi.rx_burst[i] * 255.0); /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi.nbits] */ pkt->soft_bits[bi.nbits + 1] = '\0'; - delete bi.rxBurst; mDataSockets[chan]->write(burstString, sizeof(struct trxd_hdr_v0) + bi.nbits + 2); } diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index 9975823..80047b3 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -35,8 +35,10 @@ #include "config_defs.h" } +#define MAX_RX_BURST_BUF_SIZE EDGE_BURST_NBITS + struct trx_ul_burst_ind { - SoftVector *rxBurst; + float rx_burst[MAX_RX_BURST_BUF_SIZE]; /* soft bits normalized 0..1 */ unsigned nbits; // number of symbols per slot in rxBurst, not counting guard periods uint32_t fn; // TDMA frame number uint8_t tn; // TDMA time-slot number diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp index fcda5fa..cff7825 100644 --- a/Transceiver52M/sigProcLib.cpp +++ b/Transceiver52M/sigProcLib.cpp @@ -530,19 +530,17 @@ return pulse; } -bool vectorSlicer(SoftVector *x) +/* Convert -1..+1 soft bits to 0..1 soft bits */ +void vectorSlicer(float *dest, const float *src, size_t len) { - SoftVector::iterator xP = x->begin(); - SoftVector::iterator xPEnd = x->end(); - while (xP < xPEnd) { - *xP = 0.5 * (*xP + 1.0f); - if (*xP > 1.0) - *xP = 1.0; - if (*xP < 0.0) - *xP = 0.0; - xP++; - } - return true; + size_t i; + for (i = 0; i < len; i++) { + dest[i] = 0.5 * (src[i] + 1.0f); + if (dest[i] > 1.0) + dest[i] = 1.0; + else if (dest[i] < 0.0) + dest[i] = 0.0; + } } static signalVector *rotateBurst(const BitVector &wBurst, diff --git a/Transceiver52M/sigProcLib.h b/Transceiver52M/sigProcLib.h index 79a5c3f..bae2127 100644 --- a/Transceiver52M/sigProcLib.h +++ b/Transceiver52M/sigProcLib.h @@ -59,7 +59,7 @@ void sigProcLibDestroy(void); /** Operate soft slicer on a soft-bit vector */ -bool vectorSlicer(SoftVector *x); +void vectorSlicer(float *dest, const float *src, size_t len); /** GMSK modulate a GSM burst of bits */ signalVector *modulateBurst(const BitVector &wBurst, -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14643 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I726e5a98a43367a22c9a4ca5cbd9eb87e6765c7a Gerrit-Change-Number: 14643 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 4 22:09:42 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 4 Jul 2019 22:09:42 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API ...................................................................... Transceiver: replace UDPSocket with libosmocore socket API We have a good socket API in libosmocore, let's drop osmo-trx socket API and use libosmocore's one instead of maintaining the two of them. Change-Id: Ib19856a3e0a7607f63436c4a80b1381a3f318764 --- M CommonLibs/Makefile.am D CommonLibs/Sockets.cpp D CommonLibs/Sockets.h M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h M tests/CommonLibs/Makefile.am D tests/CommonLibs/SocketsTest.cpp D tests/CommonLibs/SocketsTest.ok M tests/testsuite.at 9 files changed, 53 insertions(+), 594 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/CommonLibs/Makefile.am b/CommonLibs/Makefile.am index 22572e1..2c449e0 100644 --- a/CommonLibs/Makefile.am +++ b/CommonLibs/Makefile.am @@ -30,7 +30,6 @@ libcommon_la_SOURCES = \ BitVector.cpp \ LinkedLists.cpp \ - Sockets.cpp \ Threads.cpp \ Timeval.cpp \ Logger.cpp \ @@ -45,7 +44,6 @@ PRBS.h \ Interthread.h \ LinkedLists.h \ - Sockets.h \ Threads.h \ Timeval.h \ Vector.h \ diff --git a/CommonLibs/Sockets.cpp b/CommonLibs/Sockets.cpp deleted file mode 100644 index ce8e3d5..0000000 --- a/CommonLibs/Sockets.cpp +++ /dev/null @@ -1,287 +0,0 @@ -/* -* Copyright 2008, 2010 Free Software Foundation, Inc. -* -* -* This software is distributed under the terms of the GNU Affero Public License. -* See the COPYING file in the main directory for details. -* -* This use of this software may be subject to additional restrictions. -* See the LEGAL file in the main directory for details. - - This program is free software: you can redistribute it and/or modify - it under the terms of the GNU Affero General Public License as published by - the Free Software Foundation, either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU Affero General Public License for more details. - - You should have received a copy of the GNU Affero General Public License - along with this program. If not, see . - -*/ - - - -#include -#include -#include -#include -#include - -#include "Threads.h" -#include "Sockets.h" -#include -#include -#include - -#include -#include - - - - - - -bool resolveAddress(struct sockaddr_in *address, const char *hostAndPort) -{ - assert(address); - assert(hostAndPort); - char *copy = strdup(hostAndPort); - char *colon = strchr(copy,':'); - if (!colon) return false; - *colon = '\0'; - char *host = copy; - unsigned port = strtol(colon+1,NULL,10); - bool retVal = resolveAddress(address,host,port); - free(copy); - return retVal; -} - -bool resolveAddress(struct sockaddr_in *address, const char *host, unsigned short port) -{ - assert(address); - assert(host); - // FIXME -- Need to ignore leading/trailing spaces in hostname. - struct hostent *hp; - int h_errno_local; -#ifdef HAVE_GETHOSTBYNAME2_R - struct hostent hostData; - char tmpBuffer[2048]; - - // There are different flavors of gethostbyname_r(), but - // latest Linux use the following form: - if (gethostbyname2_r(host, AF_INET, &hostData, tmpBuffer, sizeof(tmpBuffer), &hp, &h_errno_local)!=0) { - CERR("WARNING -- gethostbyname2_r() failed for " << host << ", " << hstrerror(h_errno_local)); - return false; - } -#else - static Mutex sGethostbynameMutex; - // gethostbyname() is NOT thread-safe, so we should use a mutex here. - // Ideally it should be a global mutex for all non thread-safe socket - // operations and it should protect access to variables such as - // global h_errno. - sGethostbynameMutex.lock(); - hp = gethostbyname(host); - h_errno_local = h_errno; - sGethostbynameMutex.unlock(); -#endif - if (hp==NULL) { - CERR("WARNING -- gethostbyname() failed for " << host << ", " << hstrerror(h_errno_local)); - return false; - } - if (hp->h_addrtype != AF_INET) { - CERR("WARNING -- gethostbyname() resolved " << host << " to something other then AF_INET"); - return false; - } - address->sin_family = hp->h_addrtype; - assert(sizeof(address->sin_addr) == hp->h_length); - memcpy(&(address->sin_addr), hp->h_addr_list[0], hp->h_length); - address->sin_port = htons(port); - return true; -} - - - -DatagramSocket::DatagramSocket() -{ - memset(mDestination, 0, sizeof(mDestination)); -} - - - - - -void DatagramSocket::nonblocking() -{ - fcntl(mSocketFD,F_SETFL,O_NONBLOCK); -} - -void DatagramSocket::blocking() -{ - fcntl(mSocketFD,F_SETFL,0); -} - -void DatagramSocket::close() -{ - ::close(mSocketFD); -} - - -DatagramSocket::~DatagramSocket() -{ - close(); -} - - - - - -int DatagramSocket::write( const char * message, size_t length ) -{ - assert(length<=MAX_UDP_LENGTH); - int retVal = sendto(mSocketFD, message, length, 0, - (struct sockaddr *)mDestination, addressSize()); - if (retVal == -1 ) perror("DatagramSocket::write() failed"); - return retVal; -} - -int DatagramSocket::writeBack( const char * message, size_t length ) -{ - assert(length<=MAX_UDP_LENGTH); - int retVal = sendto(mSocketFD, message, length, 0, - (struct sockaddr *)mSource, addressSize()); - if (retVal == -1 ) perror("DatagramSocket::write() failed"); - return retVal; -} - - - -int DatagramSocket::write( const char * message) -{ - size_t length=strlen(message)+1; - return write(message,length); -} - -int DatagramSocket::writeBack( const char * message) -{ - size_t length=strlen(message)+1; - return writeBack(message,length); -} - - - -int DatagramSocket::send(const struct sockaddr* dest, const char * message, size_t length ) -{ - assert(length<=MAX_UDP_LENGTH); - int retVal = sendto(mSocketFD, message, length, 0, dest, addressSize()); - if (retVal == -1 ) perror("DatagramSocket::send() failed"); - return retVal; -} - -int DatagramSocket::send(const struct sockaddr* dest, const char * message) -{ - size_t length=strlen(message)+1; - return send(dest,message,length); -} - -int DatagramSocket::read(char* buffer, size_t length) -{ - socklen_t addr_len = sizeof(mSource); - int rd_length = recvfrom(mSocketFD, (void *) buffer, length, 0, - (struct sockaddr*) &mSource, &addr_len); - - if ((rd_length==-1) && (errno!=EAGAIN)) { - perror("DatagramSocket::read() failed"); - throw SocketError(); - } - return rd_length; -} - -int DatagramSocket::read(char* buffer, size_t length, unsigned timeout) -{ - fd_set fds; - FD_ZERO(&fds); - FD_SET(mSocketFD,&fds); - struct timeval tv; - tv.tv_sec = timeout/1000; - tv.tv_usec = (timeout%1000)*1000; - int sel = select(mSocketFD+1,&fds,NULL,NULL,&tv); - if (sel<0) { - perror("DatagramSocket::read() select() failed"); - throw SocketError(); - } - if (sel==0) return -1; - if (FD_ISSET(mSocketFD,&fds)) return read(buffer, length); - return -1; -} - - - - - - -UDPSocket::UDPSocket(const char *wSrcIP, unsigned short wSrcPort) - :DatagramSocket() -{ - open(wSrcPort, wSrcIP); -} - - -UDPSocket::UDPSocket(const char *wSrcIP, unsigned short wSrcPort, - const char *wDestIP, unsigned short wDestPort) - :DatagramSocket() -{ - open(wSrcPort, wSrcIP); - destination(wDestPort, wDestIP); -} - - - -void UDPSocket::destination( unsigned short wDestPort, const char * wDestIP ) -{ - resolveAddress((sockaddr_in*)mDestination, wDestIP, wDestPort ); -} - - -void UDPSocket::open(unsigned short localPort, const char *wlocalIP) -{ - // create - mSocketFD = socket(AF_INET,SOCK_DGRAM,0); - if (mSocketFD<0) { - perror("socket() failed"); - throw SocketError(); - } - - // pat added: This lets the socket be reused immediately, which is needed if OpenBTS crashes. - int on = 1; - setsockopt(mSocketFD, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)); - - - // bind - struct sockaddr_in address; - size_t length = sizeof(address); - bzero(&address,length); - address.sin_family = AF_INET; - address.sin_addr.s_addr = inet_addr(wlocalIP); - address.sin_port = htons(localPort); - if (bind(mSocketFD,(struct sockaddr*)&address,length)<0) { - perror("bind() failed"); - throw SocketError(); - } -} - - - -unsigned short UDPSocket::port() const -{ - struct sockaddr_in name; - socklen_t nameSize = sizeof(name); - int retVal = getsockname(mSocketFD, (struct sockaddr*)&name, &nameSize); - if (retVal==-1) throw SocketError(); - return ntohs(name.sin_port); -} - -// vim:ts=4:sw=4 diff --git a/CommonLibs/Sockets.h b/CommonLibs/Sockets.h deleted file mode 100644 index 71b8b22..0000000 --- a/CommonLibs/Sockets.h +++ /dev/null @@ -1,173 +0,0 @@ -/* -* Copyright 2008, 2010 Free Software Foundation, Inc. -* -* This software is distributed under the terms of the GNU Affero Public License. -* See the COPYING file in the main directory for details. -* -* This use of this software may be subject to additional restrictions. -* See the LEGAL file in the main directory for details. - - This program is free software: you can redistribute it and/or modify - it under the terms of the GNU Affero General Public License as published by - the Free Software Foundation, either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU Affero General Public License for more details. - - You should have received a copy of the GNU Affero General Public License - along with this program. If not, see . - -*/ - - -#ifndef SOCKETS_H -#define SOCKETS_H - -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - - - - - -#define MAX_UDP_LENGTH 1500 - -/** A function to resolve IP host names. */ -bool resolveAddress(struct sockaddr_in *address, const char *host, unsigned short port); - -/** Resolve an address of the form ":". */ -bool resolveAddress(struct sockaddr_in *address, const char *hostAndPort); - -/** An exception to throw when a critical socket operation fails. */ -class SocketError {}; -#define SOCKET_ERROR {throw SocketError(); } - -/** Abstract class for connectionless sockets. */ -class DatagramSocket { - -protected: - - int mSocketFD; ///< underlying file descriptor - char mDestination[256]; ///< address to which packets are sent - char mSource[256]; ///< return address of most recent received packet - -public: - - /** An almost-does-nothing constructor. */ - DatagramSocket(); - - virtual ~DatagramSocket(); - - /** Return the address structure size for this socket type. */ - virtual size_t addressSize() const = 0; - - /** - Send a binary packet. - @param buffer The data bytes to send to mDestination. - @param length Number of bytes to send, or strlen(buffer) if defaulted to -1. - @return number of bytes written, or -1 on error. - */ - int write( const char * buffer, size_t length); - - /** - Send a C-style string packet. - @param buffer The data bytes to send to mDestination. - @return number of bytes written, or -1 on error. - */ - int write( const char * buffer); - - /** - Send a binary packet. - @param buffer The data bytes to send to mSource. - @param length Number of bytes to send, or strlen(buffer) if defaulted to -1. - @return number of bytes written, or -1 on error. - */ - int writeBack(const char * buffer, size_t length); - - /** - Send a C-style string packet. - @param buffer The data bytes to send to mSource. - @return number of bytes written, or -1 on error. - */ - int writeBack(const char * buffer); - - - /** - Receive a packet. - @param buffer A char[MAX_UDP_LENGTH] procured by the caller. - @return The number of bytes received or -1 on non-blocking pass. - */ - int read(char* buffer, size_t length); - - /** - Receive a packet with a timeout. - @param buffer A char[MAX_UDP_LENGTH] procured by the caller. - @param maximum wait time in milliseconds - @return The number of bytes received or -1 on timeout. - */ - int read(char* buffer, size_t length, unsigned timeout); - - - /** Send a packet to a given destination, other than the default. */ - int send(const struct sockaddr *dest, const char * buffer, size_t length); - - /** Send a C-style string to a given destination, other than the default. */ - int send(const struct sockaddr *dest, const char * buffer); - - /** Make the socket non-blocking. */ - void nonblocking(); - - /** Make the socket blocking (the default). */ - void blocking(); - - /** Close the socket. */ - void close(); - -}; - - - -/** UDP/IP User Datagram Socket */ -class UDPSocket : public DatagramSocket { - -public: - - /** Open a USP socket with an OS-assigned port and no default destination. */ - UDPSocket(const char *localIP, unsigned short localPort); - - /** Given a full specification, open the socket and set the dest address. */ - UDPSocket(const char *localIP, unsigned short localPort, - const char *remoteIP, unsigned short remotePort); - - /** Set the destination port. */ - void destination( unsigned short wDestPort, const char * wDestIP ); - - /** Return the actual port number in use. */ - unsigned short port() const; - - /** Open and bind the UDP socket to a local port. */ - void open(unsigned short localPort=0, const char *wlocalIP="127.0.0.1"); - - /** Give the return address of the most recently received packet. */ - const struct sockaddr_in* source() const { return (const struct sockaddr_in*)mSource; } - - size_t addressSize() const { return sizeof(struct sockaddr_in); } - -}; - -#endif - - - -// vim:ts=4:sw=4 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 4fc277b..58e8719 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -32,6 +32,7 @@ #include "proto_trxd.h" #include +#include } #ifdef HAVE_CONFIG_H @@ -120,8 +121,7 @@ RadioInterface *wRadioInterface, double wRssiOffset, int wStackSize) : mBasePort(wBasePort), mLocalAddr(TRXAddress), mRemoteAddr(GSMcoreAddress), - mClockSocket(TRXAddress, wBasePort, GSMcoreAddress, wBasePort + 100), - mTransmitLatency(wTransmitLatency), mRadioInterface(wRadioInterface), + mClockSocket(-1), mTransmitLatency(wTransmitLatency), mRadioInterface(wRadioInterface), rssiOffset(wRssiOffset), stackSize(wStackSize), mSPSTx(tx_sps), mSPSRx(rx_sps), mChans(chans), mEdge(false), mOn(false), mForceClockInterface(false), mTxFreq(0.0), mRxFreq(0.0), mTSC(0), mMaxExpectedDelayAB(0), mMaxExpectedDelayNB(0), @@ -142,14 +142,19 @@ sigProcLibDestroy(); + if (mClockSocket >= 0) + close(mClockSocket); + for (size_t i = 0; i < mChans; i++) { mControlServiceLoopThreads[i]->cancel(); mControlServiceLoopThreads[i]->join(); delete mControlServiceLoopThreads[i]; mTxPriorityQueues[i].clear(); - delete mCtrlSockets[i]; - delete mDataSockets[i]; + if (mCtrlSockets[i] >= 0) + close(mCtrlSockets[i]); + if (mDataSockets[i] >= 0) + close(mDataSockets[i]); } } @@ -180,8 +185,8 @@ mExtRACH = ext_rach; mEdge = edge; - mDataSockets.resize(mChans); - mCtrlSockets.resize(mChans); + mDataSockets.resize(mChans, -1); + mCtrlSockets.resize(mChans, -1); mControlServiceLoopThreads.resize(mChans); mTxPriorityQueueServiceLoopThreads.resize(mChans); mRxServiceLoopThreads.resize(mChans); @@ -195,14 +200,30 @@ mStates[0].mRetrans = true; /* Setup sockets */ + mClockSocket = osmo_sock_init2(AF_UNSPEC, SOCK_DGRAM, IPPROTO_UDP, + mLocalAddr.c_str(), mBasePort, + mRemoteAddr.c_str(), mBasePort + 100, + OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT); + for (size_t i = 0; i < mChans; i++) { c_srcport = mBasePort + 2 * i + 1; c_dstport = mBasePort + 2 * i + 101; d_srcport = mBasePort + 2 * i + 2; d_dstport = mBasePort + 2 * i + 102; - mCtrlSockets[i] = new UDPSocket(mLocalAddr.c_str(), c_srcport, mRemoteAddr.c_str(), c_dstport); - mDataSockets[i] = new UDPSocket(mLocalAddr.c_str(), d_srcport, mRemoteAddr.c_str(), d_dstport); + mCtrlSockets[i] = osmo_sock_init2(AF_UNSPEC, SOCK_DGRAM, IPPROTO_UDP, + mLocalAddr.c_str(), c_srcport, + mRemoteAddr.c_str(), c_dstport, + OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT); + if (mCtrlSockets[i] < 0) + return false; + + mDataSockets[i] = osmo_sock_init2(AF_UNSPEC, SOCK_DGRAM, IPPROTO_UDP, + mLocalAddr.c_str(), d_srcport, + mRemoteAddr.c_str(), d_dstport, + OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT); + if (mCtrlSockets[i] < 0) + return false; } /* Randomize the central clock */ @@ -707,9 +728,11 @@ int msgLen; /* Attempt to read from control socket */ - msgLen = mCtrlSockets[chan]->read(buffer, MAX_PACKET_LENGTH); - if (msgLen < 1) + msgLen = read(mCtrlSockets[chan], buffer, MAX_PACKET_LENGTH); + if (msgLen <= 0) { + LOGCHAN(chan, DTRXCTRL, WARNING) << "mCtrlSockets read(" << mCtrlSockets[chan] << ") failed: " << msgLen; return; + } /* Zero-terminate received string */ buffer[msgLen] = '\0'; @@ -854,16 +877,23 @@ } LOGCHAN(chan, DTRXCTRL, INFO) << "response is '" << response << "'"; - mCtrlSockets[chan]->write(response, strlen(response) + 1); + msgLen = write(mCtrlSockets[chan], response, strlen(response) + 1); + if (msgLen <= 0) + LOGCHAN(chan, DTRXCTRL, WARNING) << "mCtrlSockets write(" << mCtrlSockets[chan] << ") failed: " << msgLen; } bool Transceiver::driveTxPriorityQueue(size_t chan) { + int msgLen; int burstLen; char buffer[EDGE_BURST_NBITS + 50]; // check data socket - size_t msgLen = mDataSockets[chan]->read(buffer, sizeof(buffer)); + msgLen = read(mDataSockets[chan], buffer, sizeof(buffer)); + if (msgLen <= 0) { + LOGCHAN(chan, DTRXCTRL, WARNING) << "mDataSockets read(" << mCtrlSockets[chan] << ") failed: " << msgLen; + return false; + } if (msgLen == gSlotLen + 1 + 4 + 1) { burstLen = gSlotLen; @@ -937,6 +967,7 @@ void Transceiver::driveReceiveFIFO(size_t chan) { + int msgLen; int TOAint; // in 1/256 symbols struct trx_ul_burst_ind bi; @@ -963,7 +994,9 @@ /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi.nbits] */ pkt->soft_bits[bi.nbits + 1] = '\0'; - mDataSockets[chan]->write(burstString, sizeof(struct trxd_hdr_v0) + bi.nbits + 2); + msgLen = write(mDataSockets[chan], burstString, sizeof(struct trxd_hdr_v0) + bi.nbits + 2); + if (msgLen <= 0) + LOGCHAN(chan, DTRXCTRL, WARNING) << "mDataSockets write(" << mCtrlSockets[chan] << ") failed: " << msgLen; } void Transceiver::driveTxFIFO() @@ -1023,13 +1056,16 @@ void Transceiver::writeClockInterface() { + int msgLen; char command[50]; // FIXME -- This should be adaptive. sprintf(command,"IND CLOCK %llu",(unsigned long long) (mTransmitDeadlineClock.FN()+2)); LOG(INFO) << "ClockInterface: sending " << command; - mClockSocket.write(command, strlen(command) + 1); + msgLen = write(mClockSocket, command, strlen(command) + 1); + if (msgLen <= 0) + LOG(WARNING) << "mClockSocket write(" << mClockSocket << ") failed: " << msgLen; mLastClockUpdateTime = mTransmitDeadlineClock; diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index 80047b3..e4d0440 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -25,7 +25,6 @@ #include "radioInterface.h" #include "Interthread.h" #include "GSMCommon.h" -#include "Sockets.h" #include #include @@ -167,9 +166,9 @@ std::string mLocalAddr; std::string mRemoteAddr; - std::vector mDataSockets; ///< socket for writing to/reading from GSM core - std::vector mCtrlSockets; ///< socket for writing/reading control commands from GSM core - UDPSocket mClockSocket; ///< socket for writing clock updates to GSM core + std::vector mDataSockets; ///< socket for writing to/reading from GSM core + std::vector mCtrlSockets; ///< socket for writing/reading control commands from GSM core + int mClockSocket; ///< socket for writing clock updates to GSM core std::vector mTxPriorityQueues; ///< priority queue of transmit bursts received from GSM core std::vector mReceiveFIFO; ///< radioInterface FIFO of receive bursts diff --git a/tests/CommonLibs/Makefile.am b/tests/CommonLibs/Makefile.am index 2a9a021..26b49e2 100644 --- a/tests/CommonLibs/Makefile.am +++ b/tests/CommonLibs/Makefile.am @@ -6,7 +6,6 @@ EXTRA_DIST = BitVectorTest.ok \ PRBSTest.ok \ InterthreadTest.ok \ - SocketsTest.ok \ TimevalTest.ok \ VectorTest.ok \ LogTest.ok \ @@ -16,7 +15,6 @@ BitVectorTest \ PRBSTest \ InterthreadTest \ - SocketsTest \ TimevalTest \ VectorTest \ LogTest @@ -30,10 +28,6 @@ InterthreadTest_LDADD = $(COMMON_LA) InterthreadTest_LDFLAGS = -lpthread $(AM_LDFLAGS) -SocketsTest_SOURCES = SocketsTest.cpp -SocketsTest_LDADD = $(COMMON_LA) -SocketsTest_LDFLAGS = -lpthread $(AM_LDFLAGS) - TimevalTest_SOURCES = TimevalTest.cpp TimevalTest_LDADD = $(COMMON_LA) diff --git a/tests/CommonLibs/SocketsTest.cpp b/tests/CommonLibs/SocketsTest.cpp deleted file mode 100644 index e4eef54..0000000 --- a/tests/CommonLibs/SocketsTest.cpp +++ /dev/null @@ -1,101 +0,0 @@ -/* -* Copyright 2008 Free Software Foundation, Inc. -* -* -* This software is distributed under the terms of the GNU Affero Public License. -* See the COPYING file in the main directory for details. -* -* This use of this software may be subject to additional restrictions. -* See the LEGAL file in the main directory for details. - - This program is free software: you can redistribute it and/or modify - it under the terms of the GNU Affero General Public License as published by - the Free Software Foundation, either version 3 of the License, or - (at your option) any later version. - - This program is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - GNU Affero General Public License for more details. - - You should have received a copy of the GNU Affero General Public License - along with this program. If not, see . - -*/ - - - - -#include "Sockets.h" -#include "Threads.h" -#include -#include -#include -#include - -static const int gNumToSend = 10; - -static void sigalarm_handler(int foo) -{ - printf("FAIL: test did not run successfully\n"); - exit(EXIT_FAILURE); -} - -void *testReaderIP(void *param) -{ - UDPSocket *readSocket = (UDPSocket *)param; - readSocket->nonblocking(); - int rc = 0; - while (rcread(buf, MAX_UDP_LENGTH); - if (count>0) { - buf[count] = 0; - CERR("read: " << buf); - rc++; - } else { - sleep(2); - } - } - return NULL; -} - -int main(int argc, char * argv[] ) -{ - int count; - - if (signal(SIGALRM, sigalarm_handler) == SIG_ERR) { - perror("signal"); - exit(EXIT_FAILURE); - } - - /* If the test takes longer than 2*gNumToSend seconds, abort it */ - alarm(2* gNumToSend); - - UDPSocket readSocket("127.0.0.1", 0); - UDPSocket socket1("127.0.0.1", 0, "localhost", readSocket.port()); - - CERR("socket1: " << socket1.port() << ", readSocket: " << readSocket.port()); - - Thread readerThreadIP; - readerThreadIP.start(testReaderIP, &readSocket); - - // give the readers time to open - sleep(1); - - for (int i=0; i expout -AT_CHECK([$abs_top_builddir/tests/CommonLibs/SocketsTest], [], [expout], [ignore]) -AT_CLEANUP - AT_SETUP([TimevalTest]) AT_KEYWORDS([TimevalTest]) cat $abs_srcdir/CommonLibs/TimevalTest.ok > expout -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib19856a3e0a7607f63436c4a80b1381a3f318764 Gerrit-Change-Number: 14644 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Fri Jul 5 02:37:22 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 05 Jul 2019 02:37:22 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1eb7f9a5d39_5e58e345f4246837@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 338s] | This file was extended by libosmocore config.status 1.1.0.75-316d, which was [ 338s] | generated by GNU Autoconf 2.69. Invocation command line was [ 338s] | [ 338s] | CONFIG_FILES = [ 338s] | CONFIG_HEADERS = [ 338s] | CONFIG_LINKS = [ 338s] | CONFIG_COMMANDS = [ 338s] | $ ./config.status Doxyfile.core [ 338s] | [ 338s] | on obs-arm-6 [ 338s] | [ 338s] | config.status:1200: creating Doxyfile.core [ 338s] [ 338s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 338s] make[1]: *** [override_dh_auto_test] Error 1 [ 338s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 338s] debian/rules:15: recipe for target 'build' failed [ 338s] make: *** [build] Error 2 [ 338s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 338s] [ 338s] obs-arm-6 failed "build libosmocore_1.1.0.75.316d.dsc" at Fri Jul 5 02:37:01 UTC 2019. [ 338s] [ 338s] ### VM INTERACTION START ### [ 340s] [ 321.383225] sysrq: SysRq : Power Off [ 340s] [ 321.384560] reboot: Power down [ 340s] ### VM INTERACTION END ### [ 340s] [ 340s] obs-arm-6 failed "build libosmocore_1.1.0.75.316d.dsc" at Fri Jul 5 02:37:05 UTC 2019. [ 340s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 5 02:48:14 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 05 Jul 2019 02:48:14 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1eba7232bbc_5e58e345f4246968@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 422s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 422s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 422s] collect2: error: ld returned 1 exit status [ 422s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 422s] make[4]: *** [osmo-bts-virtual] Error 1 [ 422s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 422s] Makefile:385: recipe for target 'all-recursive' failed [ 422s] make[3]: *** [all-recursive] Error 1 [ 422s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 422s] Makefile:434: recipe for target 'all-recursive' failed [ 422s] make[2]: *** [all-recursive] Error 1 [ 422s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 422s] Makefile:366: recipe for target 'all' failed [ 422s] make[1]: *** [all] Error 2 [ 422s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 422s] dh_auto_build: make -j1 returned exit code 2 [ 422s] debian/rules:12: recipe for target 'build' failed [ 422s] make: *** [build] Error 2 [ 422s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 422s] [ 422s] armbuild18 failed "build osmo-bts_0.8.1.331.d1e7.dsc" at Fri Jul 5 02:48:08 UTC 2019. [ 422s] [ 422s] ### VM INTERACTION START ### [ 425s] [ 383.158051] sysrq: SysRq : Power Off [ 425s] [ 383.160085] reboot: Power down [ 425s] ### VM INTERACTION END ### [ 425s] [ 425s] armbuild18 failed "build osmo-bts_0.8.1.331.d1e7.dsc" at Fri Jul 5 02:48:11 UTC 2019. [ 425s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 5 03:26:14 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 05 Jul 2019 03:26:14 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1ec35846e74_5e58e345f4247567@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 532s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 532s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 532s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 532s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 532s] make[4]: *** [gb_proxy.o] Error 1 [ 532s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 532s] Makefile:391: recipe for target 'all-recursive' failed [ 532s] make[3]: *** [all-recursive] Error 1 [ 532s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 532s] Makefile:453: recipe for target 'all-recursive' failed [ 532s] make[2]: *** [all-recursive] Error 1 [ 532s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 532s] Makefile:385: recipe for target 'all' failed [ 532s] make[1]: *** [all] Error 2 [ 532s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 532s] dh_auto_build: make -j1 returned exit code 2 [ 532s] debian/rules:45: recipe for target 'build' failed [ 532s] make: *** [build] Error 2 [ 532s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 532s] [ 532s] armbuild16 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Fri Jul 5 03:26:06 UTC 2019. [ 532s] [ 532s] ### VM INTERACTION START ### [ 536s] [ 494.690123] sysrq: SysRq : Power Off [ 536s] [ 494.691809] reboot: Power down [ 536s] ### VM INTERACTION END ### [ 536s] [ 536s] armbuild16 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Fri Jul 5 03:26:09 UTC 2019. [ 536s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 5 03:26:31 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 05 Jul 2019 03:26:31 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d1ec376b50f9_5e58e345f42476fa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 546s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 546s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 546s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 546s] Makefile:442: recipe for target 'vlr.o' failed [ 546s] make[4]: *** [vlr.o] Error 1 [ 546s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 546s] Makefile:422: recipe for target 'all-recursive' failed [ 546s] make[3]: *** [all-recursive] Error 1 [ 546s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 546s] Makefile:462: recipe for target 'all-recursive' failed [ 546s] make[2]: *** [all-recursive] Error 1 [ 546s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 546s] Makefile:394: recipe for target 'all' failed [ 546s] make[1]: *** [all] Error 2 [ 546s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 546s] dh_auto_build: make -j1 returned exit code 2 [ 546s] debian/rules:45: recipe for target 'build' failed [ 546s] make: *** [build] Error 2 [ 546s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 546s] [ 546s] armbuild13 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Fri Jul 5 03:26:18 UTC 2019. [ 546s] [ 546s] ### VM INTERACTION START ### [ 549s] [ 503.131337] sysrq: SysRq : Power Off [ 549s] [ 503.133035] reboot: Power down [ 549s] ### VM INTERACTION END ### [ 549s] [ 549s] armbuild13 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Fri Jul 5 03:26:21 UTC 2019. [ 549s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Jul 5 05:24:38 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Jul 2019 05:24:38 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: detectAnyBurst(): make TSC used to detect burst available... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14673 ) Change subject: sigProcLib: detectAnyBurst(): make TSC used to detect burst available to caller ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14673 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I603b7b52f957cf897b036dbaeb22c01a55de08c3 Gerrit-Change-Number: 14673 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 05 Jul 2019 05:24:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 5 05:25:09 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Jul 2019 05:25:09 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14674 ) Change subject: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib4ceec553f2e5f77bf3f6777724968456a180f5e Gerrit-Change-Number: 14674 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: tnt Gerrit-Comment-Date: Fri, 05 Jul 2019 05:25:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 5 08:53:38 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 5 Jul 2019 08:53:38 +0000 Subject: Change in ...osmo-pcap[master]: gitignore: fix application names In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14671 ) Change subject: gitignore: fix application names ...................................................................... gitignore: fix application names Change-Id: I4ea6b6691a0e6cfb3de0c9d2b1a0c3ed68a18514 --- M .gitignore 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/.gitignore b/.gitignore index b80db93..882ef61 100644 --- a/.gitignore +++ b/.gitignore @@ -27,8 +27,8 @@ # apps -src/osmo_pcap_client -src/osmo_pcap_server +src/osmo-pcap-client +src/osmo-pcap-server # tests tests/atconfig -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I4ea6b6691a0e6cfb3de0c9d2b1a0c3ed68a18514 Gerrit-Change-Number: 14671 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 5 11:01:43 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Jul 2019 11:01:43 +0000 Subject: Change in ...osmo-pcap[master]: debian/changelog: Mark 0.0.11 as released Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14675 Change subject: debian/changelog: Mark 0.0.11 as released ...................................................................... debian/changelog: Mark 0.0.11 as released Change-Id: I08a722be405f667797d180ec66e08ba0dc9f59d8 --- M debian/changelog 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/75/14675/1 diff --git a/debian/changelog b/debian/changelog index 13bce30..1345f93 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,4 +1,4 @@ -osmo-pcap (0.0.11) UNRELEASED; urgency=medium +osmo-pcap (0.0.11) unstable; urgency=medium * Add "source ip A.B.C.D" option to use specific address. * Add osmo-pcap-client-dbg/osmo-pcap-server-dbg package -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I08a722be405f667797d180ec66e08ba0dc9f59d8 Gerrit-Change-Number: 14675 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 5 11:01:43 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Jul 2019 11:01:43 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E0=2E6=2E100-e524_=E2=86=92_0=2E1=2E0?= Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14676 Change subject: Bump version: 0.0.6.100-e524 ? 0.1.0 ...................................................................... Bump version: 0.0.6.100-e524 ? 0.1.0 Change-Id: Id122ff79aa3f339afb5a35f758c67a350cf94830 --- M debian/changelog 1 file changed, 50 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/76/14676/1 diff --git a/debian/changelog b/debian/changelog index 1345f93..91fef4a 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,53 @@ +osmo-pcap (0.1.0) unstable; urgency=medium + + [ Harald Welte ] + * sock_src_init(): Don't freeaddrinfo() undefined src_result + * Use TCP port numbers for VTY that don't overlap with other Osmocom Software + * Rename osmo_pcap_{client_server} executables to osmo-pcap-{client,server} + * Use libosmocore osmo_sock_init2() instead of local implementation + * client: Move to osmo_sock_init2_ofd() + * Add support for generating IPIP to osmo-pcap-client + * debian/control: Fix URLs for homepage, git, gitweb + * change binary builds URL to network:osmocom as that's more maintained + * Fix compiler warning about deprecated _BSD_SOURCE + + [ Max ] + * Add gitreview config + * Use release helper from libosmocore + + [ Pau Espin Pedrol ] + * cosmetic: client: rename forward_packet function + * vty: skip installing cmds now always installed by default + * client: Properly name main talloc ctx + * server: Properly name main talloc ctx + * Drop osmo_init_logging and use osmo_init_logging2 + * osmo_client_send_data: Fix wrong log format + * configure.ac: Add --enable-werror flag + * configure.ac: Add --enable-sanitize flag + * jenkins.sh: enable werror and sanitize configure flags + * Replace '.' in counter names with ':' + * Use enum for PKT_LINK_* + * client: Set snaplen to MAXIMUM_SNAPLEN + * client: Add pcap snaplen VTY cmd + * client_send_link: snaplen not needed during allocation + * server: Improve verification of messages from client + * server: Add pcap snaplen VTY cmd + * contrib/jenkins.sh: Update to current osmocom infra + * debian: Clean up to look like other osmocom projects + * Install systemd services with autotools + * Install cfg files with autotools + * gitignore: Add compile + * debian: Install osmo_pcap_clean_old in osmo-pcap-server pkg + * tests/Makefile.am: Fix "./configure && make clean && make" + * debian/changelog: Mark 0.0.11 as released + + [ Oliver Smith ] + * Fix DISTCHECK_CONFIGURE_FLAGS override + * contrib: fix makedistcheck with disabled systemd + * gitignore: fix application names + + -- Pau Espin Pedrol Fri, 05 Jul 2019 13:00:49 +0200 + osmo-pcap (0.0.11) unstable; urgency=medium * Add "source ip A.B.C.D" option to use specific address. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14676 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Id122ff79aa3f339afb5a35f758c67a350cf94830 Gerrit-Change-Number: 14676 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 5 11:03:52 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Jul 2019 11:03:52 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E0=2E6=2E100-e524_=E2=86=92_0=2E1=2E0?= Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14677 Change subject: Bump version: 0.0.6.100-e524 ? 0.1.0 ...................................................................... Bump version: 0.0.6.100-e524 ? 0.1.0 Change-Id: I2ca3555ef5e19c6920d916618dee788bf18a6218 --- M debian/changelog 1 file changed, 50 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/77/14677/1 diff --git a/debian/changelog b/debian/changelog index 1345f93..f6b3cfd 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,53 @@ +osmo-pcap (0.1.0) unstable; urgency=medium + + [ Harald Welte ] + * sock_src_init(): Don't freeaddrinfo() undefined src_result + * Use TCP port numbers for VTY that don't overlap with other Osmocom Software + * Rename osmo_pcap_{client_server} executables to osmo-pcap-{client,server} + * Use libosmocore osmo_sock_init2() instead of local implementation + * client: Move to osmo_sock_init2_ofd() + * Add support for generating IPIP to osmo-pcap-client + * debian/control: Fix URLs for homepage, git, gitweb + * change binary builds URL to network:osmocom as that's more maintained + * Fix compiler warning about deprecated _BSD_SOURCE + + [ Max ] + * Add gitreview config + * Use release helper from libosmocore + + [ Pau Espin Pedrol ] + * cosmetic: client: rename forward_packet function + * vty: skip installing cmds now always installed by default + * client: Properly name main talloc ctx + * server: Properly name main talloc ctx + * Drop osmo_init_logging and use osmo_init_logging2 + * osmo_client_send_data: Fix wrong log format + * configure.ac: Add --enable-werror flag + * configure.ac: Add --enable-sanitize flag + * jenkins.sh: enable werror and sanitize configure flags + * Replace '.' in counter names with ':' + * Use enum for PKT_LINK_* + * client: Set snaplen to MAXIMUM_SNAPLEN + * client: Add pcap snaplen VTY cmd + * client_send_link: snaplen not needed during allocation + * server: Improve verification of messages from client + * server: Add pcap snaplen VTY cmd + * contrib/jenkins.sh: Update to current osmocom infra + * debian: Clean up to look like other osmocom projects + * Install systemd services with autotools + * Install cfg files with autotools + * gitignore: Add compile + * debian: Install osmo_pcap_clean_old in osmo-pcap-server pkg + * tests/Makefile.am: Fix "./configure && make clean && make" + * debian/changelog: Mark 0.0.11 as released + + [ Oliver Smith ] + * Fix DISTCHECK_CONFIGURE_FLAGS override + * contrib: fix makedistcheck with disabled systemd + * gitignore: fix application names + + -- Pau Espin Pedrol Fri, 05 Jul 2019 13:03:27 +0200 + osmo-pcap (0.0.11) unstable; urgency=medium * Add "source ip A.B.C.D" option to use specific address. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14677 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I2ca3555ef5e19c6920d916618dee788bf18a6218 Gerrit-Change-Number: 14677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 5 11:58:21 2019 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 5 Jul 2019 11:58:21 +0000 Subject: Change in ...osmo-bsc[master]: WIP: rest_octets: add Serving Cell Priority Parameters Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14678 Change subject: WIP: rest_octets: add Serving Cell Priority Parameters ...................................................................... WIP: rest_octets: add Serving Cell Priority Parameters When we add an EARFCN to to the SI2quater struct we do not add Serving Cell Priority Parameters. This essentially causes to MS to ignore the EARFCN because it is still undefined under which conditions the MS should change to LTE. Related: SYS#4510 Change-Id: I7eaf7de4386fe8aea404e8a187d8a1f5ed596ead --- M src/osmo-bsc/rest_octets.c 1 file changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/14678/1 diff --git a/src/osmo-bsc/rest_octets.c b/src/osmo-bsc/rest_octets.c index 9f2b4c0..4357e31 100644 --- a/src/osmo-bsc/rest_octets.c +++ b/src/osmo-bsc/rest_octets.c @@ -190,8 +190,35 @@ /* Priority and E-UTRAN Parameters Description */ bitvec_set_bit(bv, 1); - /* No Serving Cell Priority Parameters Descr. */ + /* Serving Cell Priority Parameters Descr. is Present, + * see also: 3GPP TS 44.018, Table 10.5.2.33b.1 */ + bitvec_set_bit(bv, 1); + + /* GERAN_PRIORITY */ bitvec_set_bit(bv, 0); + bitvec_set_bit(bv, 0); + bitvec_set_bit(bv, 0); + + /* THRESH_Priority_Search */ + bitvec_set_bit(bv, 0); + bitvec_set_bit(bv, 0); + bitvec_set_bit(bv, 0); + bitvec_set_bit(bv, 0); + + /* THRESH_GSM_low */ + bitvec_set_bit(bv, 0); + bitvec_set_bit(bv, 0); + bitvec_set_bit(bv, 0); + bitvec_set_bit(bv, 0); + + /* H_PRIO */ + bitvec_set_bit(bv, 0); + bitvec_set_bit(bv, 0); + + /* T_Reselection */ + bitvec_set_bit(bv, 0); + bitvec_set_bit(bv, 1); + /* No 3G Priority Parameters Description */ bitvec_set_bit(bv, 0); /* E-UTRAN Parameters Description */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7eaf7de4386fe8aea404e8a187d8a1f5ed596ead Gerrit-Change-Number: 14678 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 5 13:16:47 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 5 Jul 2019 13:16:47 +0000 Subject: Change in ...docker-playground[master]: clean up the net and attached containers to ensure reliable test starts Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14679 Change subject: clean up the net and attached containers to ensure reliable test starts ...................................................................... clean up the net and attached containers to ensure reliable test starts We can't create the net if it exists, and it can't be removed until all attached containers are dead, so ensure this is the case upon net creation. This fixes test failures due to stale nets and half-killed test runs. Change-Id: Id6d13b233ebfd808d8dfe83b6d1d1ba20c3392c8 --- M jenkins-common.sh 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/79/14679/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index 25ae26f..9fd3857 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -28,8 +28,18 @@ done } +#kills all containers attached to network +network_clean() { + docker network inspect $NET_NAME | grep Name | cut -d : -f2 | awk -F\" 'NR>1{print $2}' | xargs -rn1 docker kill +} + network_create() { NET=$1 + if docker network ls | grep -q $NET_NAME; then + echo removing stale network and containers... + network_clean + network_remove + fi echo Creating network $NET_NAME docker network create --internal --subnet $NET $NET_NAME } -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14679 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id6d13b233ebfd808d8dfe83b6d1d1ba20c3392c8 Gerrit-Change-Number: 14679 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 5 13:20:10 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Jul 2019 13:20:10 +0000 Subject: Change in ...docker-playground[master]: clean up the net and attached containers to ensure reliable test starts In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14679 ) Change subject: clean up the net and attached containers to ensure reliable test starts ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14679 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id6d13b233ebfd808d8dfe83b6d1d1ba20c3392c8 Gerrit-Change-Number: 14679 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Jul 2019 13:20:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 5 13:39:09 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Jul 2019 13:39:09 +0000 Subject: Change in ...osmo-mgw[master]: doc: X-Osmo-IGN: small formatting and typo fixes Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14680 Change subject: doc: X-Osmo-IGN: small formatting and typo fixes ...................................................................... doc: X-Osmo-IGN: small formatting and typo fixes Change-Id: I658901a63504f3733793c34947d59b034daa93f6 --- M doc/manuals/chapters/mgcp_extensions.adoc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/80/14680/1 diff --git a/doc/manuals/chapters/mgcp_extensions.adoc b/doc/manuals/chapters/mgcp_extensions.adoc index 86ff643..a68d785 100644 --- a/doc/manuals/chapters/mgcp_extensions.adoc +++ b/doc/manuals/chapters/mgcp_extensions.adoc @@ -11,7 +11,7 @@ ==== `X-Osmo-IGN` Format -The value part of X-Osmo-IGN must be one or more items separated by one or more +The value part of `X-Osmo-IGN` must be one or more items separated by one or more spaces. Each item consists of one or more non-whitespace characters. .Example: `X-Osmo-IGN` format with three ficticious items "X", "abc" and "123". @@ -19,7 +19,7 @@ X-Osmo-IGN: X abc 123 ---- -`X-Osmo-IGN` must be issued in the MGCP section (typically as its last item), +`X-Osmo-IGN` must be issued in the MGCP header section (typically as its last item), before the SDP section starts. ==== Supported `X-Osmo-IGN` Items -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I658901a63504f3733793c34947d59b034daa93f6 Gerrit-Change-Number: 14680 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 5 13:39:09 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 5 Jul 2019 13:39:09 +0000 Subject: Change in ...osmo-mgw[master]: doc: Document X-Osmux extension Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14681 Change subject: doc: Document X-Osmux extension ...................................................................... doc: Document X-Osmux extension Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 --- M doc/manuals/chapters/mgcp_extensions.adoc 1 file changed, 115 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/81/14681/1 diff --git a/doc/manuals/chapters/mgcp_extensions.adoc b/doc/manuals/chapters/mgcp_extensions.adoc index a68d785..32a3f0e 100644 --- a/doc/manuals/chapters/mgcp_extensions.adoc +++ b/doc/manuals/chapters/mgcp_extensions.adoc @@ -66,3 +66,118 @@ a=rtpmap:97 GSM-EFR/8000 a=ptime:40 ---- + +=== `X-Osmux` + +`X-Osmux` indicates to OsmoMGW that a given connection of an `rtpbridge` +endpoint has to be configured in order to handle Osmux frames instead of RTP +messages on the data plane. + +==== `X-Osmux` Format + +The value part of `X-Osmux` must be one integer in range [0..255], or +alternatively only on request messages, an asterisk (*) if the value is not yet +known. + +`X-Osmux` must be issued in the MGCP header section (typically as its last +item), before the SDP section starts. + +`X-Osmux` can be included inside `CRCX` and `MDCX` request messages, as well as +their respective response messages. + +In request messages, the value part of `X-Osmux` specifies the CID to be used by +OsmoMGW to <> Osmux frames to the remote peer for that connection, also +known as <>. + +In response messages, the value part of `X-Osmux` specifies the CID where +OsmoMGW expect to <> Osmux frames from the remote peer for that +connection, also known as <>. + +.Example: `X-Osmux` format with a known CID 3. +---- +X-Osmux: 3 +---- + +.Example: `X-Osmux` format with a wildcard (not yet known) CID. +---- +X-Osmux: * +---- + +==== `X-Osmux` Considerations + +If the MGCP client is willing to use Osmux for a given connection, it shall +specify so during `CRCX` time, and not later. If at `CRCX` time the MGCP client +doesn't yet know the <>, it can use an astersik (*) and provide +<> later within `MDCX` messages. + +All subsequent `MDCX` messages sent towards an Osmux connection must contain the +original <> sent during `CRCX`. The same way, all `MDCX` response shall +contain the <> sent during `CRCX`. + +The other required connection address parameters, such as IP address, port, and +codecs, are negotiated through MGCP and SDP as usual, but in this case the IP +address and port specific the Osmux socket IP address and port to use, that +together with the Osmux CID conform the entire tuple identifying a Osmux stream. + +Since Osmux only supports AMR codec payloads, the SDP must specify use of AMR +codec. + +.Example: `CRCX` message that instructs OsmoMGW to create an Osmux connection +---- +CRCX 189 rtpbridge/1 at mgw MGCP 1.0 +C: 36 +M: sendrecv +X-Osmux: 2 + +v=0 +o=- 36 23 IN IP4 172.18.2.20 +s=- +c=IN IP4 1.2.3.4 +t=0 0 +m=audio 2342 RTP/AVP 112 +a=fmtp:112 +a=rtpmap:112 AMR/8000/1 +a=ptime:20 +---- + +.Example: response to `CRCX` containing the <> +---- +200 189 OK +I: 07E41584 +X-Osmux: 2 +Z: rtpbridge/1 at mgw + +v=0 +o=- foo 21 IN IP4 172.18.1.20 +s=- +c=IN IP4 172.18.1.20 +t=0 0 +m=audio 11002 RTP/AVP 112 +a=rtpmap:112 AMR/8000 +a=ptime:20 +---- + +==== `X-Osmux` Support + +`X-Osmux` is known to be supported by OsmoMGW on the MGCP server side, and by +OsmoBSC as well as OsmoMSC on the MGCP client side (through libosmo-mgcp-cli). +No other programs supporting this feature are known or envisioned at the time of +writing this document. + +In OmoMGW, Osmux support is managed through VTY. + +.Example: Sample config file section with Osmux configuation +---- +mgcp + ... + osmux on <1> + osmux bind-ip 172.18.1.20 <2> + osmux port 1984 <3> + osmux batch-factor 4 <4> + osmux dummy on <5> +---- +<1> Allow clients to set allocate Osmux connections in `rtpbridge` endpoints, while still allowing RTP connections +<2> Bind the Osmux socket to the provided IP address +<3> Bind the Osmux socket to the provided UDP port +<4> Batch up to 4 RTP payloads of the same stream on each Osmux frame +<5> Periodically send Osmux dummy frames, useful to punch a hole in NATs and maintain connections opened. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 Gerrit-Change-Number: 14681 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 5 13:39:38 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 5 Jul 2019 13:39:38 +0000 Subject: Change in ...osmo-bsc[master]: WIP: rest_octets: add Serving Cell Priority Parameters In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14678 ) Change subject: WIP: rest_octets: add Serving Cell Priority Parameters ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7eaf7de4386fe8aea404e8a187d8a1f5ed596ead Gerrit-Change-Number: 14678 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 05 Jul 2019 13:39:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 5 14:17:12 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 5 Jul 2019 14:17:12 +0000 Subject: Change in ...docker-playground[master]: clean up the net and attached containers to ensure reliable test starts In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14679 ) Change subject: clean up the net and attached containers to ensure reliable test starts ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14679 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id6d13b233ebfd808d8dfe83b6d1d1ba20c3392c8 Gerrit-Change-Number: 14679 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 05 Jul 2019 14:17:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 5 15:41:49 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 5 Jul 2019 15:41:49 +0000 Subject: Change in ...libosmocore[master]: tell ubsan to ignore SUN_LEN Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14682 Change subject: tell ubsan to ignore SUN_LEN ...................................................................... tell ubsan to ignore SUN_LEN SUN_LEN is awful and ubsan will report this, so let's ignore it. Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 --- M src/socket.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/14682/1 diff --git a/src/socket.c b/src/socket.c index 1e303bf..c50af55 100644 --- a/src/socket.c +++ b/src/socket.c @@ -614,6 +614,9 @@ * type and \a proto and optionally binds or connects it, depending on * the value of \a flags parameter. */ +#if defined(__clang__) && defined(SUN_LEN) +__attribute__((no_sanitize("undefined"))) +#endif int osmo_sock_unix_init(uint16_t type, uint8_t proto, const char *socket_path, unsigned int flags) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 Gerrit-Change-Number: 14682 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Sat Jul 6 02:53:35 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 06 Jul 2019 02:53:35 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d200d37cc7dd_3358c4860014183a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 1151s] | This file was extended by libosmocore config.status 1.1.0.75-316d, which was [ 1151s] | generated by GNU Autoconf 2.69. Invocation command line was [ 1151s] | [ 1151s] | CONFIG_FILES = [ 1151s] | CONFIG_HEADERS = [ 1151s] | CONFIG_LINKS = [ 1151s] | CONFIG_COMMANDS = [ 1151s] | $ ./config.status Doxyfile.core [ 1151s] | [ 1151s] | on obs-arm-6 [ 1151s] | [ 1151s] | config.status:1200: creating Doxyfile.core [ 1151s] [ 1151s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 1151s] make[1]: *** [override_dh_auto_test] Error 1 [ 1151s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1151s] debian/rules:15: recipe for target 'build' failed [ 1151s] make: *** [build] Error 2 [ 1151s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 1151s] [ 1151s] obs-arm-6 failed "build libosmocore_1.1.0.75.316d.dsc" at Sat Jul 6 02:53:23 UTC 2019. [ 1151s] [ 1151s] ### VM INTERACTION START ### [ 1153s] [ 1068.847417] sysrq: SysRq : Power Off [ 1153s] [ 1068.849486] reboot: Power down [ 1154s] ### VM INTERACTION END ### [ 1154s] [ 1154s] obs-arm-6 failed "build libosmocore_1.1.0.75.316d.dsc" at Sat Jul 6 02:53:27 UTC 2019. [ 1154s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 6 05:55:18 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 06 Jul 2019 05:55:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2037dd5e57d_3358c4860014716f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 556s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 556s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 556s] collect2: error: ld returned 1 exit status [ 556s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 556s] make[4]: *** [osmo-bts-virtual] Error 1 [ 556s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 556s] Makefile:385: recipe for target 'all-recursive' failed [ 556s] make[3]: *** [all-recursive] Error 1 [ 556s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 556s] Makefile:434: recipe for target 'all-recursive' failed [ 556s] make[2]: *** [all-recursive] Error 1 [ 556s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 556s] Makefile:366: recipe for target 'all' failed [ 556s] make[1]: *** [all] Error 2 [ 556s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 556s] dh_auto_build: make -j1 returned exit code 2 [ 556s] debian/rules:12: recipe for target 'build' failed [ 556s] make: *** [build] Error 2 [ 556s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 556s] [ 556s] armbuild19 failed "build osmo-bts_0.8.1.331.d1e7.dsc" at Sat Jul 6 05:55:11 UTC 2019. [ 556s] [ 556s] ### VM INTERACTION START ### [ 559s] [ 493.533589] sysrq: SysRq : Power Off [ 559s] [ 493.536022] reboot: Power down [ 560s] ### VM INTERACTION END ### [ 560s] [ 560s] armbuild19 failed "build osmo-bts_0.8.1.331.d1e7.dsc" at Sat Jul 6 05:55:15 UTC 2019. [ 560s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 6 07:05:52 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 06 Jul 2019 07:05:52 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d204865439a2_3358c48600157747@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 413s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 413s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 413s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 413s] Makefile:442: recipe for target 'vlr.o' failed [ 413s] make[4]: *** [vlr.o] Error 1 [ 413s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 413s] Makefile:422: recipe for target 'all-recursive' failed [ 413s] make[3]: *** [all-recursive] Error 1 [ 413s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 413s] Makefile:462: recipe for target 'all-recursive' failed [ 413s] make[2]: *** [all-recursive] Error 1 [ 413s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 413s] Makefile:394: recipe for target 'all' failed [ 413s] make[1]: *** [all] Error 2 [ 413s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 413s] dh_auto_build: make -j1 returned exit code 2 [ 413s] debian/rules:45: recipe for target 'build' failed [ 413s] make: *** [build] Error 2 [ 413s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 413s] [ 413s] armbuild25 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Sat Jul 6 07:05:34 UTC 2019. [ 413s] [ 413s] ### VM INTERACTION START ### [ 416s] [ 390.427481] sysrq: SysRq : Power Off [ 416s] [ 390.429298] reboot: Power down [ 416s] ### VM INTERACTION END ### [ 416s] [ 416s] armbuild25 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Sat Jul 6 07:05:37 UTC 2019. [ 416s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 6 07:20:22 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 06 Jul 2019 07:20:22 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d204bd460e5b_3358c486001578f9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 768s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 768s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 768s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 768s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 768s] make[4]: *** [gb_proxy.o] Error 1 [ 768s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 768s] Makefile:391: recipe for target 'all-recursive' failed [ 768s] make[3]: *** [all-recursive] Error 1 [ 768s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 768s] Makefile:453: recipe for target 'all-recursive' failed [ 768s] make[2]: *** [all-recursive] Error 1 [ 768s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 768s] Makefile:385: recipe for target 'all' failed [ 768s] make[1]: *** [all] Error 2 [ 768s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 768s] dh_auto_build: make -j1 returned exit code 2 [ 768s] debian/rules:45: recipe for target 'build' failed [ 768s] make: *** [build] Error 2 [ 768s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 768s] [ 768s] obs-arm-5 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Sat Jul 6 07:20:11 UTC 2019. [ 768s] [ 768s] ### VM INTERACTION START ### [ 771s] [ 726.977126] sysrq: SysRq : Power Off [ 771s] [ 727.009090] reboot: Power down [ 771s] ### VM INTERACTION END ### [ 771s] [ 771s] obs-arm-5 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Sat Jul 6 07:20:14 UTC 2019. [ 771s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 7 02:41:34 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 07 Jul 2019 02:41:34 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d215bf197e32_3358c486002385c2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 590s] -Returned: 0, Current node: 1 '%s> ' [ 590s] -Going to execute 'ambiguous_str' [ 590s] -Called: 'ambiguous_str [ARG]' (argc=0) [ 590s] -Returned: 0, Current node: 1 '%s> ' [ 590s] -Going to execute 'ambiguous_str arg' [ 590s] -Called: 'ambiguous_str [ARG]' (argc=1) [ 590s] -Returned: 0, Current node: 1 '%s> ' [ 590s] -Going to execute 'ambiguous_str arg keyword' [ 590s] -Called: 'ambiguous_str ARG keyword' [ 590s] -Returned: 0, Current node: 1 '%s> ' [ 590s] -All tests passed [ 590s] ./testsuite.at:196: exit code was 139, expected 0 [ 590s] 31. testsuite.at:192: 31. vty (testsuite.at:192): FAILED (testsuite.at:196) [ 590s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 590s] make[1]: *** [override_dh_auto_test] Error 1 [ 590s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 590s] debian/rules:15: recipe for target 'build' failed [ 590s] make: *** [build] Error 2 [ 590s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 590s] [ 590s] armbuild22 failed "build libosmocore_1.1.0.75.316d.dsc" at Sun Jul 7 02:41:20 UTC 2019. [ 590s] [ 590s] ### VM INTERACTION START ### [ 592s] [ 570.976988] sysrq: SysRq : Power Off [ 593s] [ 571.078369] reboot: Power down [ 593s] ### VM INTERACTION END ### [ 593s] [ 593s] armbuild22 failed "build libosmocore_1.1.0.75.316d.dsc" at Sun Jul 7 02:41:24 UTC 2019. [ 593s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 7 03:28:09 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 07 Jul 2019 03:28:09 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2166d8ebb12_3358c48600239786@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 670s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 670s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 670s] collect2: error: ld returned 1 exit status [ 670s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 670s] make[4]: *** [osmo-bts-virtual] Error 1 [ 670s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 670s] Makefile:385: recipe for target 'all-recursive' failed [ 670s] make[3]: *** [all-recursive] Error 1 [ 671s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 671s] Makefile:434: recipe for target 'all-recursive' failed [ 671s] make[2]: *** [all-recursive] Error 1 [ 671s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 671s] Makefile:366: recipe for target 'all' failed [ 671s] make[1]: *** [all] Error 2 [ 671s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 671s] dh_auto_build: make -j1 returned exit code 2 [ 671s] debian/rules:12: recipe for target 'build' failed [ 671s] make: *** [build] Error 2 [ 671s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 671s] [ 671s] armbuild13 failed "build osmo-bts_0.8.1.331.d1e7.dsc" at Sun Jul 7 03:28:03 UTC 2019. [ 671s] [ 671s] ### VM INTERACTION START ### [ 674s] [ 611.797659] sysrq: SysRq : Power Off [ 674s] [ 611.800957] reboot: Power down [ 674s] ### VM INTERACTION END ### [ 674s] [ 674s] armbuild13 failed "build osmo-bts_0.8.1.331.d1e7.dsc" at Sun Jul 7 03:28:07 UTC 2019. [ 674s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 7 03:47:17 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 07 Jul 2019 03:47:17 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d216b4f3f226_3358c4860024071@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 502s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 502s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 502s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 502s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 502s] make[4]: *** [gb_proxy.o] Error 1 [ 502s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 502s] Makefile:391: recipe for target 'all-recursive' failed [ 502s] make[3]: *** [all-recursive] Error 1 [ 502s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 502s] Makefile:453: recipe for target 'all-recursive' failed [ 502s] make[2]: *** [all-recursive] Error 1 [ 502s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 502s] Makefile:385: recipe for target 'all' failed [ 502s] make[1]: *** [all] Error 2 [ 502s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 502s] dh_auto_build: make -j1 returned exit code 2 [ 502s] debian/rules:45: recipe for target 'build' failed [ 502s] make: *** [build] Error 2 [ 502s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 502s] [ 502s] armbuild02 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Sun Jul 7 03:47:06 UTC 2019. [ 502s] [ 502s] ### VM INTERACTION START ### [ 505s] [ 474.569904] sysrq: SysRq : Power Off [ 505s] [ 474.585369] reboot: Power down [ 505s] ### VM INTERACTION END ### [ 505s] [ 505s] armbuild02 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Sun Jul 7 03:47:09 UTC 2019. [ 505s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 7 03:49:00 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 07 Jul 2019 03:49:00 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d216bc6686f6_3358c486002409b0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 638s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 638s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 638s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 638s] Makefile:442: recipe for target 'vlr.o' failed [ 638s] make[4]: *** [vlr.o] Error 1 [ 638s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 638s] Makefile:422: recipe for target 'all-recursive' failed [ 638s] make[3]: *** [all-recursive] Error 1 [ 638s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 638s] Makefile:462: recipe for target 'all-recursive' failed [ 638s] make[2]: *** [all-recursive] Error 1 [ 638s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 638s] Makefile:394: recipe for target 'all' failed [ 638s] make[1]: *** [all] Error 2 [ 638s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 638s] dh_auto_build: make -j1 returned exit code 2 [ 638s] debian/rules:45: recipe for target 'build' failed [ 638s] make: *** [build] Error 2 [ 638s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 638s] [ 638s] armbuild17 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Sun Jul 7 03:48:55 UTC 2019. [ 638s] [ 638s] ### VM INTERACTION START ### [ 641s] [ 590.441098] sysrq: SysRq : Power Off [ 641s] [ 590.443349] reboot: Power down [ 641s] ### VM INTERACTION END ### [ 641s] [ 641s] armbuild17 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Sun Jul 7 03:48:59 UTC 2019. [ 641s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Sun Jul 7 07:48:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 07:48:05 +0000 Subject: Change in ...libosmocore[master]: tell ubsan to ignore SUN_LEN In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14682 ) Change subject: tell ubsan to ignore SUN_LEN ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 Gerrit-Change-Number: 14682 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 07:48:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 07:49:46 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 07:49:46 +0000 Subject: Change in ...docker-playground[master]: clean up the net and attached containers to ensure reliable test starts In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14679 ) Change subject: clean up the net and attached containers to ensure reliable test starts ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14679 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id6d13b233ebfd808d8dfe83b6d1d1ba20c3392c8 Gerrit-Change-Number: 14679 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jul 2019 07:49:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 07:50:11 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 07:50:11 +0000 Subject: Change in ...osmo-mgw[master]: doc: X-Osmo-IGN: small formatting and typo fixes In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14680 ) Change subject: doc: X-Osmo-IGN: small formatting and typo fixes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I658901a63504f3733793c34947d59b034daa93f6 Gerrit-Change-Number: 14680 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 07:50:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 07:50:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 07:50:56 +0000 Subject: Change in ...osmo-mgw[master]: doc: Document X-Osmux extension In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14681 ) Change subject: doc: Document X-Osmux extension ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 Gerrit-Change-Number: 14681 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 07:50:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 07:52:04 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 07:52:04 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E0=2E6=2E100-e524_=E2=86=92_0=2E1=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14677 ) Change subject: Bump version: 0.0.6.100-e524 ? 0.1.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14677 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I2ca3555ef5e19c6920d916618dee788bf18a6218 Gerrit-Change-Number: 14677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 07:52:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 07:52:15 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 07:52:15 +0000 Subject: Change in ...osmo-pcap[master]: debian/changelog: Mark 0.0.11 as released In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14675 ) Change subject: debian/changelog: Mark 0.0.11 as released ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I08a722be405f667797d180ec66e08ba0dc9f59d8 Gerrit-Change-Number: 14675 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 07:52:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 07:53:53 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 07:53:53 +0000 Subject: Change in ...meta-telephony[201705]: Add recipe for osmo-pcap, both server and client In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/3534 ) Change subject: Add recipe for osmo-pcap, both server and client ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/3534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I5bb85b118029d1559a958803184690a9d0f23e4a Gerrit-Change-Number: 3534 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Assignee: pespin Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Max Gerrit-Comment-Date: Sun, 07 Jul 2019 07:53:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 07:54:52 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 07:54:52 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14674 ) Change subject: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib4ceec553f2e5f77bf3f6777724968456a180f5e Gerrit-Change-Number: 14674 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: tnt Gerrit-Comment-Date: Sun, 07 Jul 2019 07:54:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 07:55:55 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 07:55:55 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Avoid noise calculation formula in 2 branches in pullRad... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14661 ) Change subject: Transceiver: Avoid noise calculation formula in 2 branches in pullRadioVector ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I56c84e9684ca460efd6c983d7e95d8e455bcac69 Gerrit-Change-Number: 14661 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 07:55:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 07:56:46 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 07:56:46 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Simplify code on early error return when calling detectA... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14662 ) Change subject: Transceiver: Simplify code on early error return when calling detectAnyBurst ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I026e35262bfe42c3d23ebdc06d84e4908a8380e2 Gerrit-Change-Number: 14662 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 07:56:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 07:57:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 07:57:36 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: pullRadioVector(): Move initialization of var to start o... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14663 ) Change subject: Transceiver: pullRadioVector(): Move initialization of var to start of function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14663 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Icd2793adc7b73a795184639b95fb5da336909b59 Gerrit-Change-Number: 14663 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 07:57:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 07:58:11 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 07:58:11 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support pulling idle frames in pullRadioVector() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14664 ) Change subject: Transceiver: Support pulling idle frames in pullRadioVector() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14664 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I46404f6e4055b6d3af3afffb0dfe4a19502917aa Gerrit-Change-Number: 14664 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 07:58:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 07:59:15 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 07:59:15 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: detectAnyBurst() family: Use struct to gather all out params In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14672 ) Change subject: sigProcLib: detectAnyBurst() family: Use struct to gather all out params ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I05cfa0ceaa2e633a5e6e404e2eae497ff4442dea Gerrit-Change-Number: 14672 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 07:59:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 07:59:57 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 07:59:57 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: detectAnyBurst(): make TSC used to detect burst available... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14673 ) Change subject: sigProcLib: detectAnyBurst(): make TSC used to detect burst available to caller ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14673 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I603b7b52f957cf897b036dbaeb22c01a55de08c3 Gerrit-Change-Number: 14673 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 07:59:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:01:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:01:16 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move out TRXD socket send code to prepare for TRXDv1 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14646 ) Change subject: Transceiver: Move out TRXD socket send code to prepare for TRXDv1 ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed Gerrit-Change-Number: 14646 Gerrit-PatchSet: 8 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 08:01:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:03:12 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:03:12 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support SETFORMAT command In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14665 ) Change subject: Transceiver: Support SETFORMAT command ...................................................................... Patch Set 7: I believe I raised this before in some other place: Why are we faling back to a lower version rather than simply failing SETFORMAT for any unknown version? I think it's somewhat odd and dangerous if we have "SETFORMAT 3" and then the TRX returns "OK, I set 2". -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9fc22f9987238a5ff870df7718de4efc9e04289 Gerrit-Change-Number: 14665 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 08:03:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:06:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:06:16 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts/scheduler: provide actual C/I values to OsmoPCU In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14613 ) Change subject: osmo-bts/scheduler: provide actual C/I values to OsmoPCU ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia58043bd2381a4d34d604522e02899ae64ee0d26 Gerrit-Change-Number: 14613 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-Comment-Date: Sun, 07 Jul 2019 08:06:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:07:14 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:07:14 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14593 ) Change subject: osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If61c71d20d590bf07bfd019afb33000a0b6135bd Gerrit-Change-Number: 14593 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jul 2019 08:07:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:07:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:07:36 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14669 ) Change subject: osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14669 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I50e0e5feeba4c3028f55209dd8e41e09ed5f70b1 Gerrit-Change-Number: 14669 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jul 2019 08:07:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:08:38 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:08:38 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14670 ) Change subject: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I68729dc98a1840d2aa9e091153d176a103d5a228 Gerrit-Change-Number: 14670 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jul 2019 08:08:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:12:52 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:12:52 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: library/TRXC_Types.ttcn: add FAKE_CI command for C/I simulation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14658 ) Change subject: library/TRXC_Types.ttcn: add FAKE_CI command for C/I simulation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibbab8df117a97a3dce160c67d1adbc67c31637e2 Gerrit-Change-Number: 14658 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jul 2019 08:12:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:13:41 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:13:41 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: library/L1CTL_Types.ttcn: introduce TRAFFIC_{REQ|IND} templates In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14659 ) Change subject: library/L1CTL_Types.ttcn: introduce TRAFFIC_{REQ|IND} templates ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9f412579da33d0c76b7dd616bd1b305aacf5884 Gerrit-Change-Number: 14659 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jul 2019 08:13:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:14:11 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:14:11 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: library/TRXC_Types.ttcn: add FAKE_CI command for C/I simulation In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14658 ) Change subject: library/TRXC_Types.ttcn: add FAKE_CI command for C/I simulation ...................................................................... library/TRXC_Types.ttcn: add FAKE_CI command for C/I simulation Change-Id: Ibbab8df117a97a3dce160c67d1adbc67c31637e2 Depends: (OsmocomBB) I7080effbbc1022d1884c6d6f0cb580eba8e514ff Related: OS#4006 --- M library/TRXC_Types.ttcn 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/TRXC_Types.ttcn b/library/TRXC_Types.ttcn index a87266e..b67243b 100644 --- a/library/TRXC_Types.ttcn +++ b/library/TRXC_Types.ttcn @@ -19,9 +19,9 @@ type charstring TrxcVerb ("POWERON", "POWEROFF", "CLOCK", "RXTUNE", "TXTUNE", "SETSLOT", "SETTSC", "SETBSIC", "SETPOWER", "SETMAXDLY", "SETMAXDLYNB", "SETSLOT", "HANDOVER", "NOHANDOVER", - "MEASURE", "FAKE_RSSI", "FAKE_TOA" ) with { + "MEASURE", "FAKE_RSSI", "FAKE_TOA", "FAKE_CI" ) with { variant "TEXT_CODING(,convert=upper_case, - '((POWERON)|(POWEROFF)|(CLOCK)|(RXTUNE)|(TXTUNE)|(SETSLOT)|(SETTSC)|(SETBSIC)|(SETPOWER)|(SETMAXDLY)|(SETMAXDLYNB)|(HANDOVER)|(NOHANDOVER)|(MEASURE)|(FAKE_RSSI)|(FAKE_TOA))' + '((POWERON)|(POWEROFF)|(CLOCK)|(RXTUNE)|(TXTUNE)|(SETSLOT)|(SETTSC)|(SETBSIC)|(SETPOWER)|(SETMAXDLY)|(SETMAXDLYNB)|(HANDOVER)|(NOHANDOVER)|(MEASURE)|(FAKE_RSSI)|(FAKE_TOA)|(FAKE_CI))' ,case_insensitive)" } @@ -86,5 +86,12 @@ } } +template (value) TrxcMessage ts_TRXC_FAKE_CI(int16_t ci, int16_t thresh := 0) := { + cmd := { + verb := "FAKE_CI", + params := { int2str(ci), int2str(thresh) } + } +} + } with { encode "TEXT" } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14658 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibbab8df117a97a3dce160c67d1adbc67c31637e2 Gerrit-Change-Number: 14658 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:14:11 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:14:11 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: library/L1CTL_Types.ttcn: introduce TRAFFIC_{REQ|IND} templates In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14659 ) Change subject: library/L1CTL_Types.ttcn: introduce TRAFFIC_{REQ|IND} templates ...................................................................... library/L1CTL_Types.ttcn: introduce TRAFFIC_{REQ|IND} templates Change-Id: Ic9f412579da33d0c76b7dd616bd1b305aacf5884 Related: OS#1855 --- M library/L1CTL_Types.ttcn 1 file changed, 42 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/L1CTL_Types.ttcn b/library/L1CTL_Types.ttcn index 01214b2..77c1f6a 100644 --- a/library/L1CTL_Types.ttcn +++ b/library/L1CTL_Types.ttcn @@ -622,6 +622,24 @@ } } + template (value) L1ctlUlMessage ts_L1CTL_TRAFFIC_REQ(template (value) RslChannelNr chan_nr, + template (value) RslLinkId link_id, + octetstring frame) := { + header := ts_L1ctlHeader(L1CTL_TRAFFIC_REQ), + ul_info := { + chan_nr := chan_nr, + link_id := link_id, + padding := '0000'O + }, + ul_info_tbf := omit, + ul_info_abs := omit, + payload := { + traffic_req := { + data := frame + } + } + }; + template (value) L1ctlUlMessage ts_L1CTL_TBF_CFG_REQ(boolean is_uplink, TfiUsfArr tfi_usf) := { header := ts_L1ctlHeader(L1CTL_TBF_CFG_REQ), ul_info := omit, @@ -719,6 +737,30 @@ } }; + /* for matching against incoming TRAFFIC_IND */ + template L1ctlDlMessage tr_L1CTL_TRAFFIC_IND(template RslChannelNr chan_nr, + template RslLinkId link_id := ?, + template octetstring frame := ?, + template uint8_t num_biterr := 0, + template uint8_t fire_crc := 0) := { + header := tr_L1ctlHeader(L1CTL_TRAFFIC_IND), + dl_info := { + chan_nr := chan_nr, + link_id := link_id, + arfcn := ?, + frame_nr := ?, + rx_level := ?, + snr := ?, + num_biterr := num_biterr, + fire_crc := fire_crc + }, + payload := { + traffic_ind := { + data := frame + } + } + }; + template (value) L1ctlUlMessage ts_L1CTL_CRYPTO_REQ(RslChannelNr chan_nr, uint8_t algo, octetstring key) := { header := ts_L1ctlHeader(L1CTL_CRYPTO_REQ), -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14659 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9f412579da33d0c76b7dd616bd1b305aacf5884 Gerrit-Change-Number: 14659 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:14:59 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:14:59 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14586 ) Change subject: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7080effbbc1022d1884c6d6f0cb580eba8e514ff Gerrit-Change-Number: 14586 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jul 2019 08:14:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:15:28 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:15:28 +0000 Subject: Change in ...osmo-mgw[master]: "make dist" fix for: no rule to make mgcp_common.h In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14655 ) Change subject: "make dist" fix for: no rule to make mgcp_common.h ...................................................................... "make dist" fix for: no rule to make mgcp_common.h Mark osmocom/mgcp_client/mgcp_common.h as nodist, so "make dist" will not try to include it in the source tarball. This caused "make dist" to fail in a clean osmo-mgw source tree with: make[2]: *** No rule to make target 'osmocom/mgcp_client/mgcp_common.h', needed by 'distdir'. Stop. The file gets copied during make from osmocom/mgcp/mgcp_common.h (see include/osmocom/mgcp_client/Makefile.am). Therefore it is not included in the source tree and we don't need to distribute it. Related: OS#4084 Change-Id: Ia1d7b051c0924a785b0f7ec0195192e3a852ed70 --- M include/Makefile.am 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/Makefile.am b/include/Makefile.am index 2daaf20..fbbd08d 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -6,9 +6,14 @@ osmocom/mgcp_client/mgcp_client.h \ osmocom/mgcp_client/mgcp_client_endpoint_fsm.h \ osmocom/mgcp_client/mgcp_client_fsm.h \ - osmocom/mgcp_client/mgcp_common.h \ osmocom/mgcp/mgcp.h \ osmocom/mgcp/mgcp_common.h \ osmocom/mgcp/mgcp_internal.h \ osmocom/mgcp/osmux.h \ $(NULL) + +# This gets copied during make from osmocom/mgcp/mgcp_common.h. Therefore it is not included in the source tree and we +# don't need to distribute it (OS#4084). +nobase_nodist_include_HEADERS = \ + osmocom/mgcp_client/mgcp_common.h \ + $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14655 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia1d7b051c0924a785b0f7ec0195192e3a852ed70 Gerrit-Change-Number: 14655 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:16:52 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:16:52 +0000 Subject: Change in ...osmo-remsim[master]: add examples to remsim-server (json output) In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14668 ) Change subject: add examples to remsim-server (json output) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I102a79a5d1f0055586a9fa1f9688acd4258f585b Gerrit-Change-Number: 14668 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 08:16:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:19:30 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:19:30 +0000 Subject: Change in ...osmo-remsim[master]: add examples to the command line options for remsim-bankd and remsim-... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14667 ) Change subject: add examples to the command line options for remsim-bankd and remsim-client ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14667/1/doc/manuals/chapters/remsim-client.adoc File doc/manuals/chapters/remsim-client.adoc: https://gerrit.osmocom.org/#/c/14667/1/doc/manuals/chapters/remsim-client.adoc at 89 PS1, Line 89: osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 0 -H 2-1.1 -c 0 : osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 1 -H 2-1.1 -c 0 : osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 0 -H 2-1.4 -c 0 : osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 1 -H 2-1.4 -c 0 Here all four clients would get the same client ID. That's invalid. In any osmo-remsim setup, each client must have a unique 16-bit ID. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14667 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Idfa6352ce90dd36dd27306d6c8a2023935ed822d Gerrit-Change-Number: 14667 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 08:19:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:21:46 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:21:46 +0000 Subject: Change in ...osmo-remsim[master]: add examples to remsim-server (json output) In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14668 ) Change subject: add examples to remsim-server (json output) ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14668/1/doc/manuals/chapters/remsim-server.adoc File doc/manuals/chapters/remsim-server.adoc: https://gerrit.osmocom.org/#/c/14668/1/doc/manuals/chapters/remsim-server.adoc at 87 PS1, Line 87: [{"peer":"C0:0","state":"CONNECTED_CLIENT","component_id":{"type_":"remsimClient","name":"simtrace2-remsim-client","software":"remsim-client","swVersion":"0.1.0.17-6d8a"}},{"peer":"C0:0","state":"CONNECTED_CLIENT","component_id":{"type_":"remsimClient","name":"simtrace2-remsim-client","software":"remsim-client","swVersion":"0.1.0.17-6d8a"}},{"peer":"C0:0","state":"CONNECTED_CLIENT","component_id":{"type_":"remsimClient","name":"simtrace2-remsim-client","software":"remsim-client","swVersion":"0.1.0.17-6d8a"}},{"peer":"C0:0","state":"CONNECTED_CLIENT","component_id":{"type_":"remsimClient","name":"simtrace2-remsim-client","software":"remsi Actually, here you can also see that all of them have identical client_id:slot_d. "C0:0" which is invalid. You would either have to change the client id or the slot ID so that the tuple of (client_id,slot_id) is unique in any deployment. For a QMOD setup with four modems, I would typically sugget to use the same client_id, but different slot IDs (0..3) for each modem. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I102a79a5d1f0055586a9fa1f9688acd4258f585b Gerrit-Change-Number: 14668 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 08:21:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:29:14 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:29:14 +0000 Subject: Change in ...osmo-remsim[master]: add examples to the command line options for remsim-bankd and remsim-... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14667 ) Change subject: add examples to the command line options for remsim-bankd and remsim-client ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14667/1/doc/manuals/chapters/remsim-client.adoc File doc/manuals/chapters/remsim-client.adoc: https://gerrit.osmocom.org/#/c/14667/1/doc/manuals/chapters/remsim-client.adoc at 89 PS1, Line 89: osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 0 -H 2-1.1 -c 0 : osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 1 -H 2-1.1 -c 0 : osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 0 -H 2-1.4 -c 0 : osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 1 -H 2-1.4 -c 0 > Here all four clients would get the same client ID. That's invalid. [?] actually, the tuple of (client_id,client_slot) must be unique, not the clent_id. So I wuold suggest to use slot_id 0..3 (-n parameter) -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14667 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Idfa6352ce90dd36dd27306d6c8a2023935ed822d Gerrit-Change-Number: 14667 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 08:29:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 08:57:48 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 7 Jul 2019 08:57:48 +0000 Subject: Change in ...osmo-bsc[master]: WIP: rest_octets: add Serving Cell Priority Parameters In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14678 ) Change subject: WIP: rest_octets: add Serving Cell Priority Parameters ...................................................................... Patch Set 1: Code-Review-1 (3 comments) It's really good that you appear to have manged to uncover the mystery of UEs stickin to GSM in combined GSM+LTE setups. However, some stylistic comments below on bitvec API usage. https://gerrit.osmocom.org/#/c/14678/1/src/osmo-bsc/rest_octets.c File src/osmo-bsc/rest_octets.c: https://gerrit.osmocom.org/#/c/14678/1/src/osmo-bsc/rest_octets.c at 198 PS1, Line 198: bitvec_set_bit(bv, 0); : bitvec_set_bit(bv, 0); : bitvec_set_bit(bv, 0); I suppose this is a 3bit field encoding an unsigned integer so I would encode it not as 3 individual bits but use bitvec_set_uint(bv, 0, 3); https://gerrit.osmocom.org/#/c/14678/1/src/osmo-bsc/rest_octets.c at 203 PS1, Line 203: bitvec_set_bit(bv, 0); : bitvec_set_bit(bv, 0); : bitvec_set_bit(bv, 0); : bitvec_set_bit(bv, 0); same here. it's a 4-bit integer that should use bitvec_set_uint(bv, 0, 4); The advantage is that later on, if you want to use anything else but '0' you have one actual integer value in the code to change, rather than four individual bits. https://gerrit.osmocom.org/#/c/14678/1/src/osmo-bsc/rest_octets.c at 208 PS1, Line 208: /* THRESH_GSM_low */ : bitvec_set_bit(bv, 0); : bitvec_set_bit(bv, 0); : bitvec_set_bit(bv, 0); : bitvec_set_bit(bv, 0); : : /* H_PRIO */ : bitvec_set_bit(bv, 0); : bitvec_set_bit(bv, 0); : : /* T_Reselection */ : bitvec_set_bit(bv, 0); : bitvec_set_bit(bv, 1); : same comment applies for these, I suppose -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7eaf7de4386fe8aea404e8a187d8a1f5ed596ead Gerrit-Change-Number: 14678 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 08:57:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 10:19:32 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Jul 2019 10:19:32 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14670 ) Change subject: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs ...................................................................... Patch Set 1: Code-Review+2 (1 comment) In any case, we can change this later on. https://gerrit.osmocom.org/#/c/14670/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/14670/1/src/osmo-bts-trx/trx_if.c at 744 PS1, Line 744: static char buf[256]; > Since we only use it in one place, makes more sense to pass a stack buffer instead of allocating a s [?] I was thinking about potential performance impact. Since we receive Uplink bursts quite often, and furthermore we are about to implement NOPE / IDLE indications, static buffer has an important advantage: there are less stack allocations. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I68729dc98a1840d2aa9e091153d176a103d5a228 Gerrit-Change-Number: 14670 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jul 2019 10:19:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 10:20:05 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Jul 2019 10:20:05 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: introduce TRXD header version handling In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14592 ) Change subject: osmo-bts-trx/trx_if.c: introduce TRXD header version handling ...................................................................... osmo-bts-trx/trx_if.c: introduce TRXD header version handling It may be necessary to extend the message specific header with more information. Since this is not a TLV-based protocol, we need to include the header format version. +-----------------+---------------------------+ | 7 6 5 4 3 2 1 0 | bit numbers (value range) | +-----------------+---------------------------+ | X X X X . . . . | header version (0..15) | +-----------------+---------------------------+ | . . . . . X X X | TDMA TN (0..7) | +-----------------+---------------------------+ | . . . . X . . . | RESERVED (0) | +-----------------+---------------------------+ Instead of prepending an additional byte, it was decided to use 4 MSB bits of the first octet, which used to be zero-initialized due to the value range of TDMA TN (0..7). Therefore the current header format has implicit version 0. Otherwise Wireshark (or trx_sniff.py) would have to guess the header version, or alternatively follow the control channel looking for the version setting command. This change introduces a new structure 'trx_ul_burst_ind', which represents an Uplink burst and the corresponding meta info. The purpose of this structure is to avoid overloading the existing functions, such as trx_sched_ul_burst(), with more and more arguments every time we bump the version. On receipt of a TRXD message, trx_data_read_cb() now parses the header version, and calls the corresponding dissector functions, e.g. trx_data_handle_(hdr|burst)_v0(). Change-Id: I171c18229ca3e5cab70de0064a31e47c78602c0c Related: OS#4006 --- M include/osmo-bts/scheduler.h M src/common/scheduler.c M src/osmo-bts-trx/trx_if.c 3 files changed, 200 insertions(+), 58 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmo-bts/scheduler.h b/include/osmo-bts/scheduler.h index c862307..9748d45 100644 --- a/include/osmo-bts/scheduler.h +++ b/include/osmo-bts/scheduler.h @@ -173,10 +173,6 @@ /*! \brief PHY informs us of new (current) GSM frame number */ int trx_sched_clock(struct gsm_bts *bts, uint32_t fn); -/*! \brief handle an UL burst received by PHY */ -int trx_sched_ul_burst(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - sbit_t *bits, uint16_t nbits, int8_t rssi, int16_t toa); - /*! \brief set multiframe scheduler to given physical channel config */ int trx_sched_set_pchan(struct l1sched_trx *l1t, uint8_t tn, enum gsm_phys_chan_config pchan); @@ -231,4 +227,20 @@ bool trx_sched_is_sacch_fn(struct gsm_bts_trx_ts *ts, uint32_t fn, bool uplink); extern const struct trx_sched_multiframe trx_sched_multiframes[]; +/*! UL burst indication with the corresponding meta info */ +struct trx_ul_burst_ind { + /* Mandatory fields */ + uint32_t fn; /*!< TDMA frame number */ + uint8_t tn; /*!< TDMA time-slot number */ + int16_t toa256; /*!< Timing of Arrival in units of 1/256 of symbol */ + int8_t rssi; /*!< Received Signal Strength Indication */ + + /*! Burst soft-bits buffer */ + sbit_t burst[EGPRS_BURST_LEN]; + size_t burst_len; +}; + +/*! Handle an UL burst received by PHY */ +int trx_sched_ul_burst(struct l1sched_trx *l1t, struct trx_ul_burst_ind *bi); + #endif /* TRX_SCHEDULER_H */ diff --git a/src/common/scheduler.c b/src/common/scheduler.c index 3f804a9..83779d7 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -1313,11 +1313,10 @@ return 0; } -/* process uplink burst */ -int trx_sched_ul_burst(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - sbit_t *bits, uint16_t nbits, int8_t rssi, int16_t toa256) +/* Process an Uplink burst indication */ +int trx_sched_ul_burst(struct l1sched_trx *l1t, struct trx_ul_burst_ind *bi) { - struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, tn); + struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, bi->tn); struct l1sched_chan_state *l1cs; const struct trx_sched_frame *frame; uint8_t offset, period, bid; @@ -1329,7 +1328,7 @@ /* get frame from multiframe */ period = l1ts->mf_period; - offset = fn % period; + offset = bi->fn % period; frame = l1ts->mf_frames + offset; chan = frame->ul_chan; @@ -1346,28 +1345,29 @@ return -EINVAL; /* calculate how many TDMA frames were potentially lost */ - trx_sched_calc_frame_loss(l1t, l1cs, tn, fn); + trx_sched_calc_frame_loss(l1t, l1cs, bi->tn, bi->fn); /* update TDMA frame counters */ - l1cs->last_tdma_fn = fn; + l1cs->last_tdma_fn = bi->fn; l1cs->proc_tdma_fs++; /* decrypt */ - if (bits && l1cs->ul_encr_algo) { + if (bi->burst_len && l1cs->ul_encr_algo) { ubit_t ks[114]; int i; - osmo_a5(l1cs->ul_encr_algo, l1cs->ul_encr_key, fn, NULL, ks); + osmo_a5(l1cs->ul_encr_algo, l1cs->ul_encr_key, bi->fn, NULL, ks); for (i = 0; i < 57; i++) { if (ks[i]) - bits[i + 3] = - bits[i + 3]; + bi->burst[i + 3] = - bi->burst[i + 3]; if (ks[i + 57]) - bits[i + 88] = - bits[i + 88]; + bi->burst[i + 88] = - bi->burst[i + 88]; } } - /* put burst to function */ - func(l1t, tn, fn, chan, bid, bits, nbits, rssi, toa256); + /* put burst to function + * TODO: rather pass a pointer to trx_ul_burst_ind */ + func(l1t, bi->tn, bi->fn, chan, bid, bi->burst, bi->burst_len, bi->rssi, bi->toa256); return 0; } diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index 9b1604c..a164f17 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -7,6 +7,7 @@ * * Copyright (C) 2013 Andreas Eversberg * Copyright (C) 2016-2017 Harald Welte + * Copyright (C) 2019 Vadim Yanitskiy * * All Rights Reserved * @@ -588,65 +589,194 @@ /* Maximum DATA message length (header + burst) */ #define TRX_DATA_MSG_MAX_LEN 512 +/* Common header length: 1/2 VER + 1/2 TDMA TN + 4 TDMA FN */ +#define TRX_CHDR_LEN (1 + 4) +/* Uplink v0 header length: 1 RSSI + 2 ToA256 */ +#define TRX_UL_V0HDR_LEN (TRX_CHDR_LEN + 1 + 2) + +/* TRXD header dissector for version 0 */ +static int trx_data_handle_hdr_v0(struct trx_l1h *l1h, + struct trx_ul_burst_ind *bi, + const uint8_t *buf, size_t buf_len) +{ + /* Make sure we have enough data */ + if (buf_len < TRX_UL_V0HDR_LEN) { + LOGPPHI(l1h->phy_inst, DTRX, LOGL_ERROR, + "Short read on TRXD, missing version 0 header " + "(len=%zu vs expected %d)\n", buf_len, TRX_UL_V0HDR_LEN); + return -EIO; + } + + bi->tn = buf[0] & 0b111; + bi->fn = osmo_load32be(buf + 1); + bi->rssi = -(int8_t)buf[5]; + bi->toa256 = (int16_t) osmo_load16be(buf + 6); + + if (bi->fn >= GSM_HYPERFRAME) { + LOGPPHI(l1h->phy_inst, DTRX, LOGL_ERROR, + "Illegal TDMA fn=%u\n", bi->fn); + return -EINVAL; + } + + return TRX_UL_V0HDR_LEN; +} + +/* TRXD burst handler for header version 0 */ +static int trx_data_handle_burst_v0(struct trx_l1h *l1h, + struct trx_ul_burst_ind *bi, + const uint8_t *buf, size_t buf_len) +{ + size_t i; + + /* Verify burst length */ + switch (buf_len) { + /* Legacy transceivers append two padding bytes */ + case EGPRS_BURST_LEN + 2: + case GSM_BURST_LEN + 2: + bi->burst_len = buf_len - 2; + break; + case EGPRS_BURST_LEN: + case GSM_BURST_LEN: + bi->burst_len = buf_len; + break; + + default: + LOGPPHI(l1h->phy_inst, DTRX, LOGL_NOTICE, + "Rx TRXD message with odd burst length %zu\n", buf_len); + return -EINVAL; + } + + /* Convert unsigned soft-bits [254..0] to soft-bits [-127..127] */ + for (i = 0; i < bi->burst_len; i++) { + if (buf[i] == 255) + bi->burst[i] = -127; + else + bi->burst[i] = 127 - buf[i]; + } + + return 0; +} + +/* Parse TRXD message from transceiver, compose an UL burst indication. + * + * This message contains a demodulated Uplink burst with fixed-size + * header preceding the burst bits. The header consists of the common + * and message specific part. + * + * +---------------+-----------------+------------+ + * | common header | specific header | burst bits | + * +---------------+-----------------+------------+ + * + * Common header is the same as for Downlink message: + * + * +-----------------+----------------+-------------------+ + * | VER (1/2 octet) | TN (1/2 octet) | FN (4 octets, BE) | + * +-----------------+----------------+-------------------+ + * + * and among with TDMA parameters, contains the version indicator: + * + * +-----------------+------------------------+ + * | 7 6 5 4 3 2 1 0 | bit numbers | + * +-----------------+------------------------+ + * | X X X X . . . . | header version (0..15) | + * +-----------------+------------------------+ + * | . . . . . X X X | TDMA TN (0..7) | + * +-----------------+------------------------+ + * | . . . . X . . . | RESERVED (0) | + * +-----------------+------------------------+ + * + * which is encoded in 4 MSB bits of the first octet, which used to be + * zero-initialized due to the value range of TDMA TN. Therefore, the + * old header format has implicit version 0x00. + * + * The message specific header has the following structure: + * + * == Version 0x00 + * + * +------+-----+--------------------+ + * | RSSI | ToA | soft-bits (254..0) | + * +------+-----+--------------------+ + * + * where: + * + * - RSSI (1 octet) - Received Signal Strength Indication + * encoded without the negative sign. + * - ToA (2 octets) - Timing of Arrival in units of 1/256 + * of symbol (big endian). + * + * == Coding of the burst bits + * + * Unlike to be transmitted bursts, the received bursts are designated + * using the soft-bits notation, so the receiver can indicate its + * assurance from 0 to -127 that a given bit is 1, and from 0 to +127 + * that a given bit is 0. + * + * Each soft-bit (-127..127) of the burst is encoded as an unsigned + * value in range (254..0) respectively using the constant shift. + * + */ static int trx_data_read_cb(struct osmo_fd *ofd, unsigned int what) { struct trx_l1h *l1h = ofd->data; uint8_t buf[TRX_DATA_MSG_MAX_LEN]; - int len; - uint8_t tn; - int8_t rssi; - int16_t toa256 = 0; - uint32_t fn; - sbit_t bits[EGPRS_BURST_LEN]; - int i, burst_len = GSM_BURST_LEN; + struct trx_ul_burst_ind bi; + ssize_t hdr_len, buf_len; + uint8_t hdr_ver; + int rc; - len = recv(ofd->fd, buf, sizeof(buf), 0); - if (len <= 0) { - return len; - } else if (len == EGPRS_BURST_LEN + 10) { - burst_len = EGPRS_BURST_LEN; - /* Accept bursts ending with 2 bytes of padding (OpenBTS compatible trx) or without them: */ - } else if (len != GSM_BURST_LEN + 10 && len != GSM_BURST_LEN + 8) { - LOGPPHI(l1h->phy_inst, DTRX, LOGL_NOTICE, "Got data message with invalid lenght " - "'%d'\n", len); - return -EINVAL; - } - tn = buf[0]; - fn = osmo_load32be(buf + 1); - rssi = -(int8_t)buf[5]; - toa256 = (int16_t) osmo_load16be(buf + 6); - - /* copy and convert bits {254..0} to sbits {-127..127} */ - for (i = 0; i < burst_len; i++) { - if (buf[8 + i] == 255) - bits[i] = -127; - else - bits[i] = 127 - buf[8 + i]; + buf_len = recv(ofd->fd, buf, sizeof(buf), 0); + if (buf_len <= 0) { + LOGPPHI(l1h->phy_inst, DTRX, LOGL_ERROR, + "recv() failed on TRXD with rc=%zd\n", buf_len); + return buf_len; } - if (tn >= 8) { - LOGPPHI(l1h->phy_inst, DTRX, LOGL_ERROR, "Illegal TS %d\n", tn); - return -EINVAL; - } - if (fn >= GSM_HYPERFRAME) { - LOGPPHI(l1h->phy_inst, DTRX, LOGL_ERROR, "Illegal FN %u\n", fn); - return -EINVAL; + /* Parse the header depending on its version */ + hdr_ver = buf[0] >> 4; + switch (hdr_ver) { + case 0: + /* Legacy protocol has no version indicator */ + hdr_len = trx_data_handle_hdr_v0(l1h, &bi, buf, buf_len); + break; + default: + LOGPPHI(l1h->phy_inst, DTRX, LOGL_ERROR, + "TRXD header version %u is not supported\n", hdr_ver); + return -ENOTSUP; } - LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG, "RX burst tn=%u fn=%u rssi=%d toa256=%d\n", - tn, fn, rssi, toa256); + /* Header parsing error */ + if (hdr_len < 0) + return hdr_len; + + /* We're done with the header now */ + buf_len -= hdr_len; + + switch (hdr_ver) { + case 0: + rc = trx_data_handle_burst_v0(l1h, &bi, buf + hdr_len, buf_len); + break; + } + + /* Burst parsing error */ + if (rc < 0) + return rc; + + LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG, + "Rx UL burst (hdr_ver=%u) tn=%u fn=%u rssi=%d toa256=%d\n", + hdr_ver, bi.tn, bi.fn, bi.rssi, bi.toa256); #ifdef TOA_RSSI_DEBUG char deb[128]; sprintf(deb, "| 0 " - " | rssi=%4d toa=%5d fn=%u", rssi, toa256, fn); - deb[1 + (128 + rssi) / 4] = '*'; + " | rssi=%4d toa=%5d fn=%u", + bi.rssi, bi.toa256, bi.fn); + deb[1 + (128 + bi.rssi) / 4] = '*'; fprintf(stderr, "%s\n", deb); #endif /* feed received burst into scheduler code */ - trx_sched_ul_burst(&l1h->l1s, tn, fn, bits, burst_len, rssi, toa256); + trx_sched_ul_burst(&l1h->l1s, &bi); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I171c18229ca3e5cab70de0064a31e47c78602c0c Gerrit-Change-Number: 14592 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 10:20:05 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Jul 2019 10:20:05 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14593 ) Change subject: osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support ...................................................................... osmo-bts-trx/trx_if.c: introduce TRXD header version 0x01 support The new version adds the following fields to the TRX2L1 message, keeping the L12TRX message unchanged: +------+-----+-----+-----+--------------------+ | RSSI | ToA | MTS | C/I | soft-bits (254..0) | +------+-----+-----+-----+--------------------+ - MTS (1 octet) - Modulation and Training Sequence info, and - C/I (2 octets) - Carrier-to-Interference ratio (big endian). == Coding of MTS: Modulation and Training Sequence info 3GPP TS 45.002 version 15.1.0 defines several modulation types, and a few sets of training sequences for each type. The most common are GMSK and 8-PSK (which is used in EDGE). +-----------------+---------------------------------------+ | 7 6 5 4 3 2 1 0 | bit numbers (value range) | +-----------------+---------------------------------------+ | . . . . . X X X | Training Sequence Code (0..7) | +-----------------+---------------------------------------+ | . X X X X . . . | Modulation, TS set number (see below) | +-----------------+---------------------------------------+ | X . . . . . . . | IDLE / nope frame indication (0 or 1) | +-----------------+---------------------------------------+ The bit number 7 (MSB) is set to high when either nothing has been detected, or during IDLE frames, so we can deliver noise levels, and avoid clock gaps on the L1 side. Other bits are ignored, and should be set to low (0) in this case. == Coding of modulation and TS set number GMSK has 4 sets of training sequences (see tables 5.2.3a-d), while 8-PSK (see tables 5.2.3f-g) and the others have 2 sets. Access and Synchronization bursts also have several synch. sequences. +-----------------+---------------------------------------+ | 7 6 5 4 3 2 1 0 | bit numbers (value range) | +-----------------+---------------------------------------+ | . 0 0 X X . . . | GMSK, 4 TS sets (0..3) | +-----------------+---------------------------------------+ | . 0 1 0 X . . . | 8-PSK, 2 TS sets (0..1) | +-----------------+---------------------------------------+ | . 0 1 1 X . . . | AQPSK, 2 TS sets (0..1) | +-----------------+---------------------------------------+ | . 1 0 0 X . . . | 16QAM, 2 TS sets (0..1) | +-----------------+---------------------------------------+ | . 1 0 1 X . . . | 32QAM, 2 TS sets (0..1) | +-----------------+---------------------------------------+ | . 1 1 1 X . . . | RESERVED (0) | +-----------------+---------------------------------------+ == C/I: Carrier-to-Interference ratio The C/I value is computed from the training sequence of each burst, where we can compare the "ideal" training sequence with the actual training sequence, and then express that difference in centiBels. == Limitations - The only supported modulation types are GMSK and 8-PSK. Messages with other modulation types will be rejected. - IDLE / NOPE indications are not (yet) handled. - The logical channel handlers do not (yet) handle optional fields, such as TSC and C/I. This will be implemented in the follow-up changes. Change-Id: If61c71d20d590bf07bfd019afb33000a0b6135bd Related: OS#4006 --- M include/osmo-bts/scheduler.h M src/osmo-bts-trx/trx_if.c 2 files changed, 183 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmo-bts/scheduler.h b/include/osmo-bts/scheduler.h index 9748d45..4f40636 100644 --- a/include/osmo-bts/scheduler.h +++ b/include/osmo-bts/scheduler.h @@ -227,14 +227,28 @@ bool trx_sched_is_sacch_fn(struct gsm_bts_trx_ts *ts, uint32_t fn, bool uplink); extern const struct trx_sched_multiframe trx_sched_multiframes[]; +#define TRX_BI_F_NOPE_IND (1 << 0) +#define TRX_BI_F_MOD_TYPE (1 << 1) +#define TRX_BI_F_TS_INFO (1 << 2) +#define TRX_BI_F_CI_CB (1 << 3) + /*! UL burst indication with the corresponding meta info */ struct trx_ul_burst_ind { + /* Field presence bitmask (see TRX_BI_F_*) */ + uint8_t flags; + /* Mandatory fields */ uint32_t fn; /*!< TDMA frame number */ uint8_t tn; /*!< TDMA time-slot number */ int16_t toa256; /*!< Timing of Arrival in units of 1/256 of symbol */ int8_t rssi; /*!< Received Signal Strength Indication */ + /* Optional fields (defined by flags) */ + enum trx_burst_type bt; /*!< Modulation type */ + uint8_t tsc_set; /*!< Training Sequence Set */ + uint8_t tsc; /*!< Training Sequence Code */ + int16_t ci_cb; /*!< Carrier-to-Interference ratio (in centiBels) */ + /*! Burst soft-bits buffer */ sbit_t burst[EGPRS_BURST_LEN]; size_t burst_len; diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index a164f17..f2e8b90 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -593,6 +593,8 @@ #define TRX_CHDR_LEN (1 + 4) /* Uplink v0 header length: 1 RSSI + 2 ToA256 */ #define TRX_UL_V0HDR_LEN (TRX_CHDR_LEN + 1 + 2) +/* Uplink v1 header length: + 1 MTS + 2 C/I */ +#define TRX_UL_V1HDR_LEN (TRX_UL_V0HDR_LEN + 1 + 2) /* TRXD header dissector for version 0 */ static int trx_data_handle_hdr_v0(struct trx_l1h *l1h, @@ -621,6 +623,64 @@ return TRX_UL_V0HDR_LEN; } +/* TRXD header dissector for version 0x01 */ +static int trx_data_handle_hdr_v1(struct trx_l1h *l1h, + struct trx_ul_burst_ind *bi, + const uint8_t *buf, size_t buf_len) +{ + uint8_t mts; + int rc; + + /* Make sure we have enough data */ + if (buf_len < TRX_UL_V1HDR_LEN) { + LOGPPHI(l1h->phy_inst, DTRX, LOGL_ERROR, + "Short read on TRXD, missing version 1 header " + "(len=%zu vs expected %d)\n", buf_len, TRX_UL_V1HDR_LEN); + return -EIO; + } + + /* Parse v0 specific part */ + rc = trx_data_handle_hdr_v0(l1h, bi, buf, buf_len); + if (rc < 0) + return rc; + + /* Move closer to the v1 specific part */ + buf_len -= rc; + buf += rc; + + /* IDLE / NOPE frame indication */ + if (buf[0] & (1 << 7)) { + bi->flags |= TRX_BI_F_NOPE_IND; + return TRX_UL_V1HDR_LEN; + } + + /* Modulation info and TSC set */ + mts = (buf[0] >> 3) & 0b1111; + if ((mts & 0b1100) == 0x00) { + bi->bt = TRX_BURST_GMSK; + bi->tsc_set = mts & 0b11; + bi->flags |= TRX_BI_F_MOD_TYPE; + } else if ((mts & 0b0100) == 0b0100) { + bi->bt = TRX_BURST_8PSK; + bi->tsc_set = mts & 0b1; + bi->flags |= TRX_BI_F_MOD_TYPE; + } else { + LOGPPHI(l1h->phy_inst, DTRX, LOGL_ERROR, + "Indicated modulation 0x%02x is not supported\n", mts & 0b1110); + return -ENOTSUP; + } + + /* Training Sequence Code */ + bi->tsc = buf[0] & 0b111; + bi->flags |= TRX_BI_F_TS_INFO; + + /* C/I: Carrier-to-Interference ratio (in centiBels) */ + bi->ci_cb = (int16_t) osmo_load16be(buf + 1); + bi->flags |= TRX_BI_F_CI_CB; + + return TRX_UL_V1HDR_LEN; +} + /* TRXD burst handler for header version 0 */ static int trx_data_handle_burst_v0(struct trx_l1h *l1h, struct trx_ul_burst_ind *bi, @@ -657,6 +717,30 @@ return 0; } +/* TRXD burst handler for header version 1 */ +static int trx_data_handle_burst_v1(struct trx_l1h *l1h, + struct trx_ul_burst_ind *bi, + const uint8_t *buf, size_t buf_len) +{ + /* Modulation types defined in 3GPP TS 45.002 */ + static const size_t bl[] = { + [TRX_BURST_GMSK] = 148, /* 1 bit per symbol */ + [TRX_BURST_8PSK] = 444, /* 3 bits per symbol */ + }; + + /* Verify burst length */ + if (bl[bi->bt] != buf_len) { + LOGPPHI(l1h->phy_inst, DTRX, LOGL_NOTICE, + "Rx TRXD message with odd burst length %zu, " + "expected %zu\n", buf_len, bl[bi->bt]); + return -EINVAL; + } + + /* The burst format is the same as for version 0. + * NOTE: other modulation types to be handled separately. */ + return trx_data_handle_burst_v0(l1h, bi, buf, buf_len); +} + /* Parse TRXD message from transceiver, compose an UL burst indication. * * This message contains a demodulated Uplink burst with fixed-size @@ -697,12 +781,72 @@ * | RSSI | ToA | soft-bits (254..0) | * +------+-----+--------------------+ * + * == Version 0x01 + * + * +------+-----+-----+-----+--------------------+ + * | RSSI | ToA | MTS | C/I | soft-bits (254..0) | + * +------+-----+-----+-----+--------------------+ + * * where: * * - RSSI (1 octet) - Received Signal Strength Indication * encoded without the negative sign. * - ToA (2 octets) - Timing of Arrival in units of 1/256 * of symbol (big endian). + * - MTS (1 octet) - Modulation and Training Sequence info. + * - C/I (2 octets) - Carrier-to-Interference ratio (big endian). + * + * == Coding of MTS: Modulation and Training Sequence info + * + * 3GPP TS 45.002 version 15.1.0 defines several modulation types, + * and a few sets of training sequences for each type. The most + * common are GMSK and 8-PSK (which is used in EDGE). + * + * +-----------------+---------------------------------------+ + * | 7 6 5 4 3 2 1 0 | bit numbers (value range) | + * +-----------------+---------------------------------------+ + * | . . . . . X X X | Training Sequence Code (0..7) | + * +-----------------+---------------------------------------+ + * | . X X X X . . . | Modulation, TS set number (see below) | + * +-----------------+---------------------------------------+ + * | X . . . . . . . | IDLE / nope frame indication (0 or 1) | + * +-----------------+---------------------------------------+ + * + * The bit number 7 (MSB) is set to high when either nothing has been + * detected, or during IDLE frames, so we can deliver noise levels, + * and avoid clock gaps on the L1 side. Other bits are ignored, + * and should be set to low (0) in this case. L16 shall be set to 0x00. + * + * == Coding of modulation and TS set number + * + * GMSK has 4 sets of training sequences (see tables 5.2.3a-d), + * while 8-PSK (see tables 5.2.3f-g) and the others have 2 sets. + * Access and Synchronization bursts also have several synch. + * sequences. + * + * +-----------------+---------------------------------------+ + * | 7 6 5 4 3 2 1 0 | bit numbers (value range) | + * +-----------------+---------------------------------------+ + * | . 0 0 X X . . . | GMSK, 4 TS sets (0..3) | + * +-----------------+---------------------------------------+ + * | . 0 1 0 X . . . | 8-PSK, 2 TS sets (0..1) | + * +-----------------+---------------------------------------+ + * | . 0 1 1 X . . . | AQPSK, 2 TS sets (0..1) | + * +-----------------+---------------------------------------+ + * | . 1 0 0 X . . . | 16QAM, 2 TS sets (0..1) | + * +-----------------+---------------------------------------+ + * | . 1 0 1 X . . . | 32QAM, 2 TS sets (0..1) | + * +-----------------+---------------------------------------+ + * | . 1 1 1 X . . . | RESERVED (0) | + * +-----------------+---------------------------------------+ + * + * NOTE: we only support GMSK and 8-PSK. + * + * == C/I: Carrier-to-Interference ratio + * + * The C/I value can be computed from the training sequence of each + * burst, where we can compare the "ideal" training sequence with + * the actual training sequence and then express that in centiBels. * * == Coding of the burst bits * @@ -731,6 +875,9 @@ return buf_len; } + /* Pre-clean (initialize) the flags */ + bi.flags = 0x00; + /* Parse the header depending on its version */ hdr_ver = buf[0] >> 4; switch (hdr_ver) { @@ -738,6 +885,9 @@ /* Legacy protocol has no version indicator */ hdr_len = trx_data_handle_hdr_v0(l1h, &bi, buf, buf_len); break; + case 1: + hdr_len = trx_data_handle_hdr_v1(l1h, &bi, buf, buf_len); + break; default: LOGPPHI(l1h->phy_inst, DTRX, LOGL_ERROR, "TRXD header version %u is not supported\n", hdr_ver); @@ -748,21 +898,39 @@ if (hdr_len < 0) return hdr_len; + /* TODO: we can use NOPE indications to get noise levels on IDLE + * TDMA frames, and properly drive scheduler if nothing has been + * detected on non-IDLE channels. */ + if (bi.flags & TRX_BI_F_NOPE_IND) { + LOGPPHI(l1h->phy_inst, DTRX, LOGL_NOTICE, + "IDLE / NOPE indications are not (yet) supported\n"); + return -ENOTSUP; + } + /* We're done with the header now */ buf_len -= hdr_len; + /* Handle burst bits */ switch (hdr_ver) { case 0: rc = trx_data_handle_burst_v0(l1h, &bi, buf + hdr_len, buf_len); break; + case 1: + rc = trx_data_handle_burst_v1(l1h, &bi, buf + hdr_len, buf_len); + break; + default: + /* Shall not happen, just to make GCC happy */ + OSMO_ASSERT(0); } /* Burst parsing error */ if (rc < 0) return rc; + /* TODO: also print TSC and C/I */ LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG, - "Rx UL burst (hdr_ver=%u) tn=%u fn=%u rssi=%d toa256=%d\n", + "Rx %s (hdr_ver=%u): tn=%u fn=%u rssi=%d toa256=%d\n", + (bi.flags & TRX_BI_F_NOPE_IND) ? "NOPE.ind" : "UL burst", hdr_ver, bi.tn, bi.fn, bi.rssi, bi.toa256); #ifdef TOA_RSSI_DEBUG -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If61c71d20d590bf07bfd019afb33000a0b6135bd Gerrit-Change-Number: 14593 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 10:20:06 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Jul 2019 10:20:06 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14669 ) Change subject: osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code ...................................................................... osmo-bts-trx/trx_if.c: drop RSSI / ToA debugging code This kind of debugging can be done using trx_sniff.py tool from the TRX Toolkit [1]. Probably, this code was needed during the initial development and testing. [1] https://git.osmocom.org/osmocom-bb/tree/src/target/trx_toolkit Change-Id: I50e0e5feeba4c3028f55209dd8e41e09ed5f70b1 --- M src/osmo-bts-trx/trx_if.c 1 file changed, 0 insertions(+), 13 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index f2e8b90..0ae12c2 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -48,9 +48,6 @@ #include "l1_if.h" #include "trx_if.h" -/* enable to print RSSI level graph */ -//#define TOA_RSSI_DEBUG - int transceiver_available = 0; /* @@ -933,16 +930,6 @@ (bi.flags & TRX_BI_F_NOPE_IND) ? "NOPE.ind" : "UL burst", hdr_ver, bi.tn, bi.fn, bi.rssi, bi.toa256); -#ifdef TOA_RSSI_DEBUG - char deb[128]; - - sprintf(deb, "| 0 " - " | rssi=%4d toa=%5d fn=%u", - bi.rssi, bi.toa256, bi.fn); - deb[1 + (128 + bi.rssi) / 4] = '*'; - fprintf(stderr, "%s\n", deb); -#endif - /* feed received burst into scheduler code */ trx_sched_ul_burst(&l1h->l1s, &bi); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14669 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I50e0e5feeba4c3028f55209dd8e41e09ed5f70b1 Gerrit-Change-Number: 14669 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 10:20:06 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Jul 2019 10:20:06 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14670 ) Change subject: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs ...................................................................... osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs Since we may have different versions of the TRXD header, some new fields of an Uplink burst indication have conditional presence. Therefore we need a smart function to print them conditionally. Change-Id: I68729dc98a1840d2aa9e091153d176a103d5a228 Related: OS#4006 --- M src/osmo-bts-trx/trx_if.c 1 file changed, 45 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index 0ae12c2..e9193ca 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -738,6 +738,48 @@ return trx_data_handle_burst_v0(l1h, bi, buf, buf_len); } +static const char *trx_data_desc_msg(const struct trx_ul_burst_ind *bi) +{ + struct osmo_strbuf sb; + static char buf[256]; + + /* Modulation types defined in 3GPP TS 45.002 */ + static const char *mod_names[] = { + [TRX_BURST_GMSK] = "GMSK", + [TRX_BURST_8PSK] = "8-PSK", + }; + + /* Initialize the string buffer */ + sb = (struct osmo_strbuf) { .buf = buf, .len = sizeof(buf) }; + + /* Common TDMA parameters */ + OSMO_STRBUF_PRINTF(sb, "tn=%u fn=%u", bi->tn, bi->fn); + + /* Nothing else to print for NOPE.ind */ + if (bi->flags & TRX_BI_F_NOPE_IND) + return buf; + + /* RSSI and ToA256 */ + OSMO_STRBUF_PRINTF(sb, " rssi=%d toa256=%d", bi->rssi, bi->toa256); + + /* Modulation and TSC set */ + if (bi->flags & TRX_BI_F_MOD_TYPE) + OSMO_STRBUF_PRINTF(sb, " mod=%s", mod_names[bi->bt]); + + /* Training Sequence Code */ + if (bi->flags & TRX_BI_F_TS_INFO) + OSMO_STRBUF_PRINTF(sb, " set=%u tsc=%u", bi->tsc_set, bi->tsc); + + /* C/I: Carrier-to-Interference ratio (in centiBels) */ + if (bi->flags & TRX_BI_F_CI_CB) + OSMO_STRBUF_PRINTF(sb, " C/I=%d cB", bi->ci_cb); + + /* Burst length */ + OSMO_STRBUF_PRINTF(sb, " burst_len=%zu", bi->burst_len); + + return buf; +} + /* Parse TRXD message from transceiver, compose an UL burst indication. * * This message contains a demodulated Uplink burst with fixed-size @@ -924,11 +966,10 @@ if (rc < 0) return rc; - /* TODO: also print TSC and C/I */ - LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG, - "Rx %s (hdr_ver=%u): tn=%u fn=%u rssi=%d toa256=%d\n", + /* Print header & burst info */ + LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG, "Rx %s (hdr_ver=%u): %s\n", (bi.flags & TRX_BI_F_NOPE_IND) ? "NOPE.ind" : "UL burst", - hdr_ver, bi.tn, bi.fn, bi.rssi, bi.toa256); + hdr_ver, trx_data_desc_msg(&bi)); /* feed received burst into scheduler code */ trx_sched_ul_burst(&l1h->l1s, &bi); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I68729dc98a1840d2aa9e091153d176a103d5a228 Gerrit-Change-Number: 14670 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 13:21:40 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Jul 2019 13:21:40 +0000 Subject: Change in ...libosmocore[master]: libosmogsm/l1sap.h: extend ph_rach_ind_param with lqual_cb Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14683 Change subject: libosmogsm/l1sap.h: extend ph_rach_ind_param with lqual_cb ...................................................................... libosmogsm/l1sap.h: extend ph_rach_ind_param with lqual_cb The link quality, defined by C/I (Carrier-to-Interference) ratio, can be computed from the training sequence of each burst, where we can compare the "ideal" training sequence with the actual training sequence and then express that in cB (centiBels, dB * 10). By analogy with both RSSI and ToA, it can be used to filter out false-positive detections and ghost Access Bursts. Change-Id: Ie2a66ebd040b61d6daf49e04bf8a84d3d64764ee --- M include/osmocom/gsm/l1sap.h 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/83/14683/1 diff --git a/include/osmocom/gsm/l1sap.h b/include/osmocom/gsm/l1sap.h index 9a9c008..19cc87a 100644 --- a/include/osmocom/gsm/l1sap.h +++ b/include/osmocom/gsm/l1sap.h @@ -68,6 +68,7 @@ int8_t rssi; /*!< RSSI of RACH indication */ uint16_t ber10k; /*!< BER in units of 0.01% */ int16_t acc_delay_256bits;/* !< Burst TA Offset in 1/256th bits */ + int16_t lqual_cb; /* !< Link quality in centiBel */ }; /*! for PH-[UNIT]DATA.{req,ind} | PH-RTS.ind */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie2a66ebd040b61d6daf49e04bf8a84d3d64764ee Gerrit-Change-Number: 14683 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 13:22:02 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Jul 2019 13:22:02 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14684 Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX ...................................................................... osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX TSC (Training Sequence Code) is an optional parameter of the UL burst indication. We need this information in order to decide whether an Access Burst is 11-bit encoded or not (see OS#1854). If this information is absent, we try to correlate the received synch. sequence with the known ones (3GPP TS 05.02, section 5.2.7), and fall-back to the default TS0 if it fails. Since the new TRXD header version, the training sequence code is indicated by the transceiver. Let's use it! Change-Id: I1e654a2e49cb83c5f1e6249c0de688f99bc466b0 Related: OS#1854, OS#4006 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 12 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/84/14684/1 diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 7bdbc4f..00d7bbb 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -784,19 +784,22 @@ uint8_t ra; int rc; - /* It would be great if the transceiver were doing some kind of tagging, - * whether it is extended (11-bit) RACH or not. We would not need to guess - * it here. For now, let's try to correlate the synch. sequence of a received - * Access Burst with the known ones (3GPP TS 05.02, section 5.2.7), and - * fall-back to the default TS0 if it fails. This would save some CPU - * power, and what is more important - prevent possible collisions. */ + /* TSC (Training Sequence Code) is an optional parameter of the UL burst + * indication. We need this information in order to decide whether an + * Access Burst is 11-bit encoded or not (see OS#1854). If this information + * is absent, we try to correlate the received synch. sequence with the + * known ones (3GPP TS 05.02, section 5.2.7), and fall-back to the default + * TS0 if it fails. */ enum rach_synch_seq_t synch_seq = RACH_SYNCH_SEQ_TS0; int best_score = 127 * RACH_SYNCH_SEQ_LEN; /* Handover RACH cannot be extended (11-bit) */ - if (chan == TRXC_RACH) - /* TODO: check for TRX_BI_F_TS_INFO flag! */ - synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, &best_score); + if (chan == TRXC_RACH) { + if (bi->flags & TRX_BI_F_TS_INFO) + synch_seq = (enum rach_synch_seq_t) bi->tsc; + else + synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, &best_score); + } LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, "Received RACH (%s; match=%.1f%%) toa=%d\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1e654a2e49cb83c5f1e6249c0de688f99bc466b0 Gerrit-Change-Number: 14684 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 13:22:03 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Jul 2019 13:22:03 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14685 Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message ...................................................................... osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message Instead of printing the match score of detected training sequence, which is being calculated by rach_get_synch_seq() when TSC info is absent, it makes more sense to print both RSSI and optional C/I (Carrier-to-Interference ratio). Also, let's explicitly log handover Access Bursts. Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/85/14685/1 diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 00d7bbb..b10ca26 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -791,21 +791,21 @@ * known ones (3GPP TS 05.02, section 5.2.7), and fall-back to the default * TS0 if it fails. */ enum rach_synch_seq_t synch_seq = RACH_SYNCH_SEQ_TS0; - int best_score = 127 * RACH_SYNCH_SEQ_LEN; /* Handover RACH cannot be extended (11-bit) */ if (chan == TRXC_RACH) { if (bi->flags & TRX_BI_F_TS_INFO) synch_seq = (enum rach_synch_seq_t) bi->tsc; else - synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, &best_score); + synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, NULL); } LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, - "Received RACH (%s; match=%.1f%%) toa=%d\n", + "Received%s RACH (%s): rssi=%d toa256=%d C/I=%d cB\n", + (chan != TRXC_RACH) ? " handover" : "", get_value_string(rach_synch_seq_names, synch_seq), - best_score * 100.0 / (127 * RACH_SYNCH_SEQ_LEN), - bi->toa256); + bi->rssi, bi->toa256, + (bi->flags & TRX_BI_F_CI_CB) ? bi->ci_cb : 0); /* Compose a new L1SAP primitive */ memset(&l1sap, 0x00, sizeof(l1sap)); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 Gerrit-Change-Number: 14685 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 13:22:03 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Jul 2019 13:22:03 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Clarify and refactor link quality (C/I) handling Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 --- M include/osmo-bts/gsm_data_shared.h M src/common/bts.c M src/common/l1sap.c M src/common/pcu_sock.c M src/common/vty.c M src/osmo-bts-litecell15/l1_if.c M src/osmo-bts-oc2g/l1_if.c M src/osmo-bts-sysmo/l1_if.c 8 files changed, 18 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/86/14686/1 diff --git a/include/osmo-bts/gsm_data_shared.h b/include/osmo-bts/gsm_data_shared.h index a4e326a..dd2a14c 100644 --- a/include/osmo-bts/gsm_data_shared.h +++ b/include/osmo-bts/gsm_data_shared.h @@ -759,8 +759,8 @@ int smscb_queue_max_len; /* maximum queue length */ int smscb_queue_hyst; /* hysteresis for CBCH laod indications */ - float min_qual_rach; /* minimum quality for RACH bursts */ - float min_qual_norm; /* minimum quality for normal daata */ + int16_t min_qual_rach; /* minimum link quality (in centiBels) for Access Bursts */ + int16_t min_qual_norm; /* minimum link quality (in centiBels) for Normal Bursts */ uint16_t max_ber10k_rach; /* Maximum permitted RACH BER in 0.01% */ struct { diff --git a/src/common/bts.c b/src/common/bts.c index f582ebd..f9c1eab 100644 --- a/src/common/bts.c +++ b/src/common/bts.c @@ -51,8 +51,8 @@ #include #include -#define MIN_QUAL_RACH 5.0f /* at least 5 dB C/I */ -#define MIN_QUAL_NORM -0.5f /* at least -1 dB C/I */ +#define MIN_QUAL_RACH 50 /* minimum link quality (in centiBels) for Access Bursts */ +#define MIN_QUAL_NORM -10 /* minimum link quality (in centiBels) for Normal Bursts */ static void bts_update_agch_max_queue_length(struct gsm_bts *bts); diff --git a/src/common/l1sap.c b/src/common/l1sap.c index b730b85..79af8e2 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1218,7 +1218,7 @@ * the content is not available due to decoding issues. Content not * available is expected as empty payload. We also check if quality is * good enough. */ - if (msg->len && tch_ind->lqual_cb / 10 >= bts->min_qual_norm) { + if (msg->len && tch_ind->lqual_cb >= bts->min_qual_norm) { /* hand msg to RTP code for transmission */ if (lchan->abis_ip.rtp_socket) osmo_rtp_send_frame_ext(lchan->abis_ip.rtp_socket, diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 39b4568..f8de944 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -330,8 +330,8 @@ LOGP(DPCU, LOGL_DEBUG, "Sending data indication: sapi=%s arfcn=%d block=%d data=%s\n", sapi_string[sapi], arfcn, block_nr, osmo_hexdump(data, len)); - if (lqual / 10 < bts->min_qual_norm) { - LOGP(DPCU, LOGL_DEBUG, "Link quality %"PRId16" is below threshold %f, dropping packet\n", + if (lqual < bts->min_qual_norm) { + LOGP(DPCU, LOGL_DEBUG, "Link quality %"PRId16" is below threshold %d, dropping packet\n", lqual, bts->min_qual_norm); return 0; } diff --git a/src/common/vty.c b/src/common/vty.c index f4fc181..7b7c7c1 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -300,9 +300,9 @@ sapi_buf = osmo_str_tolower(get_value_string(gsmtap_sapi_names, GSMTAP_CHANNEL_ACCH)); vty_out(vty, " gsmtap-sapi %s%s", sapi_buf, VTY_NEWLINE); } - vty_out(vty, " min-qual-rach %.0f%s", bts->min_qual_rach * 10.0f, + vty_out(vty, " min-qual-rach %d%s", bts->min_qual_rach, VTY_NEWLINE); - vty_out(vty, " min-qual-norm %.0f%s", bts->min_qual_norm * 10.0f, + vty_out(vty, " min-qual-norm %d%s", bts->min_qual_norm, VTY_NEWLINE); vty_out(vty, " max-ber10k-rach %u%s", bts->max_ber10k_rach, VTY_NEWLINE); @@ -618,24 +618,24 @@ DEFUN(cfg_bts_min_qual_rach, cfg_bts_min_qual_rach_cmd, "min-qual-rach <-100-100>", - "Set the minimum quality level of RACH burst to be accpeted\n" - "C/I level in tenth of dB\n") + "Set the minimum link quality level of Access Bursts to be accepted\n" + "C/I (Carrier-to-Interference) ratio in centiBels (dB * 10)\n") { struct gsm_bts *bts = vty->index; - bts->min_qual_rach = strtof(argv[0], NULL) / 10.0f; + bts->min_qual_rach = atoi(argv[0]); return CMD_SUCCESS; } DEFUN(cfg_bts_min_qual_norm, cfg_bts_min_qual_norm_cmd, "min-qual-norm <-100-100>", - "Set the minimum quality level of normal burst to be accpeted\n" - "C/I level in tenth of dB\n") + "Set the minimum link quality level of Normal Bursts to be accepted\n" + "C/I (Carrier-to-Interference) ratio in centiBels (dB * 10)\n") { struct gsm_bts *bts = vty->index; - bts->min_qual_norm = strtof(argv[0], NULL) / 10.0f; + bts->min_qual_norm = atoi(argv[0]); return CMD_SUCCESS; } diff --git a/src/osmo-bts-litecell15/l1_if.c b/src/osmo-bts-litecell15/l1_if.c index 3710fa8..77b72bd 100644 --- a/src/osmo-bts-litecell15/l1_if.c +++ b/src/osmo-bts-litecell15/l1_if.c @@ -1004,7 +1004,7 @@ struct ph_rach_ind_param rach_ind_param; /* FIXME: this should be deprecated/obsoleted as it bypasses rach.busy counting */ - if (ra_ind->measParam.fLinkQuality < bts->min_qual_rach) { + if (ra_ind->measParam.fLinkQuality * 10 < bts->min_qual_rach) { msgb_free(l1p_msg); return 0; } diff --git a/src/osmo-bts-oc2g/l1_if.c b/src/osmo-bts-oc2g/l1_if.c index d9c8da0..9affc89 100644 --- a/src/osmo-bts-oc2g/l1_if.c +++ b/src/osmo-bts-oc2g/l1_if.c @@ -1060,7 +1060,7 @@ struct ph_rach_ind_param rach_ind_param; /* FIXME: this should be deprecated/obsoleted as it bypasses rach.busy counting */ - if (ra_ind->measParam.fLinkQuality < bts->min_qual_rach) { + if (ra_ind->measParam.fLinkQuality * 10 < bts->min_qual_rach) { msgb_free(l1p_msg); return 0; } diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c index 0777d0e..975bd34 100644 --- a/src/osmo-bts-sysmo/l1_if.c +++ b/src/osmo-bts-sysmo/l1_if.c @@ -998,7 +998,7 @@ struct ph_rach_ind_param rach_ind_param; /* FIXME: this should be deprecated/obsoleted as it bypasses rach.busy counting */ - if (ra_ind->measParam.fLinkQuality < bts->min_qual_rach) { + if (ra_ind->measParam.fLinkQuality * 10 < bts->min_qual_rach) { msgb_free(l1p_msg); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 13:22:03 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Jul 2019 13:22:03 +0000 Subject: Change in ...osmo-bts[master]: Move Access Burst link quality handling to L1SAP Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14687 Change subject: Move Access Burst link quality handling to L1SAP ...................................................................... Move Access Burst link quality handling to L1SAP Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Depends: (libosmocore) Ie2a66ebd040b61d6daf49e04bf8a84d3d64764ee --- M src/common/l1sap.c M src/osmo-bts-litecell15/l1_if.c M src/osmo-bts-oc2g/l1_if.c M src/osmo-bts-sysmo/l1_if.c M src/osmo-bts-trx/scheduler_trx.c 5 files changed, 14 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/14687/1 diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 79af8e2..f07e79c 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1272,6 +1272,14 @@ return false; } + /* Link quality defined by C/I (Carrier-to-Interference ratio) */ + if (rach_ind->lqual_cb < bts->min_qual_rach) { + LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring RACH request: " + "link quality (%d) below the minimum (%d)\n", + rach_ind->lqual_cb, bts->min_qual_rach); + return false; + } + return true; } diff --git a/src/osmo-bts-litecell15/l1_if.c b/src/osmo-bts-litecell15/l1_if.c index 77b72bd..5c969f0 100644 --- a/src/osmo-bts-litecell15/l1_if.c +++ b/src/osmo-bts-litecell15/l1_if.c @@ -1003,12 +1003,6 @@ int rc; struct ph_rach_ind_param rach_ind_param; - /* FIXME: this should be deprecated/obsoleted as it bypasses rach.busy counting */ - if (ra_ind->measParam.fLinkQuality * 10 < bts->min_qual_rach) { - msgb_free(l1p_msg); - return 0; - } - dump_meas_res(LOGL_DEBUG, &ra_ind->measParam); if ((ra_ind->msgUnitParam.u8Size != 1) && @@ -1029,6 +1023,7 @@ .rssi = (int8_t) ra_ind->measParam.fRssi, .ber10k = (unsigned int) (ra_ind->measParam.fBer * 10000.0), .acc_delay_256bits = ra_ind->measParam.i16BurstTiming * 64, + .lqual_cb = ra_ind->measParam.fLinkQuality * 10, /* centiBels */ }; lchan = l1if_hLayer_to_lchan(trx, (uint32_t)ra_ind->hLayer2); diff --git a/src/osmo-bts-oc2g/l1_if.c b/src/osmo-bts-oc2g/l1_if.c index 9affc89..7df4147 100644 --- a/src/osmo-bts-oc2g/l1_if.c +++ b/src/osmo-bts-oc2g/l1_if.c @@ -1059,12 +1059,6 @@ int rc; struct ph_rach_ind_param rach_ind_param; - /* FIXME: this should be deprecated/obsoleted as it bypasses rach.busy counting */ - if (ra_ind->measParam.fLinkQuality * 10 < bts->min_qual_rach) { - msgb_free(l1p_msg); - return 0; - } - dump_meas_res(LOGL_DEBUG, &ra_ind->measParam); if ((ra_ind->msgUnitParam.u8Size != 1) && @@ -1085,6 +1079,7 @@ .rssi = (int8_t) ra_ind->measParam.fRssi, .ber10k = (unsigned int) (ra_ind->measParam.fBer * 10000.0), .acc_delay_256bits = ra_ind->measParam.i16BurstTiming * 64, + .lqual_cb = ra_ind->measParam.fLinkQuality * 10, /* centiBels */ }; lchan = l1if_hLayer_to_lchan(trx, (uint32_t)ra_ind->hLayer2); diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c index 975bd34..9c28e3a 100644 --- a/src/osmo-bts-sysmo/l1_if.c +++ b/src/osmo-bts-sysmo/l1_if.c @@ -997,12 +997,6 @@ int rc; struct ph_rach_ind_param rach_ind_param; - /* FIXME: this should be deprecated/obsoleted as it bypasses rach.busy counting */ - if (ra_ind->measParam.fLinkQuality * 10 < bts->min_qual_rach) { - msgb_free(l1p_msg); - return 0; - } - dump_meas_res(LOGL_DEBUG, &ra_ind->measParam); if ((ra_ind->msgUnitParam.u8Size != 1) && @@ -1024,6 +1018,7 @@ .rssi = (int8_t) ra_ind->measParam.fRssi, .ber10k = (unsigned int) (ra_ind->measParam.fBer * 10000.0), .acc_delay_256bits = ra_ind->measParam.i16BurstTiming * 64, + .lqual_cb = ra_ind->measParam.fLinkQuality * 10, /* centiBels */ }; lchan = l1if_hLayer_to_lchan(trx, ra_ind->hLayer2); diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index b10ca26..56483f3 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -816,6 +816,9 @@ l1sap.u.rach_ind.rssi = bi->rssi; l1sap.u.rach_ind.fn = bi->fn; + /* FIXME: check for TRX_BI_F_CI_CB, and use the value from UL.ind */ + l1sap.u.rach_ind.lqual_cb = l1t->trx->bts->min_qual_rach; + /* Decode RACH depending on its synch. sequence */ switch (synch_seq) { case RACH_SYNCH_SEQ_TS1: -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Gerrit-Change-Number: 14687 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 13:22:03 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Jul 2019 13:22:03 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14688 Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP ...................................................................... osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP Change-Id: I8d86dec7ebc039cbfd038c4342ff328b11281865 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/14688/1 diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 56483f3..5a24dda 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -816,8 +816,13 @@ l1sap.u.rach_ind.rssi = bi->rssi; l1sap.u.rach_ind.fn = bi->fn; - /* FIXME: check for TRX_BI_F_CI_CB, and use the value from UL.ind */ - l1sap.u.rach_ind.lqual_cb = l1t->trx->bts->min_qual_rach; + /* Link quality defined by C/I (Carrier-to-Interference ratio), + * which has optional presence. If it's absent, simulate the + * minimum acceptable value to pass L1SAP checks. */ + if (bi->flags & TRX_BI_F_CI_CB) + l1sap.u.rach_ind.lqual_cb = bi->ci_cb; + else + l1sap.u.rach_ind.lqual_cb = l1t->trx->bts->min_qual_rach; /* Decode RACH depending on its synch. sequence */ switch (synch_seq) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8d86dec7ebc039cbfd038c4342ff328b11281865 Gerrit-Change-Number: 14688 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 13:22:04 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 7 Jul 2019 13:22:04 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14689 Change subject: osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP ...................................................................... osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP Change-Id: Iea0dad65e9bc511f99375fd3ee2eb44e47a6168f --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/14689/1 diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 5a24dda..327ee6e 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -889,6 +889,8 @@ uint8_t *rssi_num = &chan_state->rssi_num; int32_t *toa256_sum = &chan_state->toa256_sum; uint8_t *toa_num = &chan_state->toa_num; + int32_t *ci_cb_sum = &chan_state->ci_cb_sum; + uint8_t *ci_cb_num = &chan_state->ci_cb_num; uint8_t l2[GSM_MACBLOCK_LEN], l2_len; int n_errors, n_bits_total; uint16_t ber10k; @@ -917,6 +919,8 @@ *rssi_num = 0; *toa256_sum = 0; *toa_num = 0; + *ci_cb_sum = 0; + *ci_cb_num = 0; } /* update mask + RSSI */ @@ -926,6 +930,12 @@ *toa256_sum += bi->toa256; (*toa_num)++; + /* C/I: Carrier-to-Interference ratio (in centiBels) */ + if (bi->flags & TRX_BI_F_CI_CB) { + *ci_cb_sum += bi->ci_cb; + (*ci_cb_num)++; + } + /* copy burst to buffer of 4 bursts */ burst = *bursts_p + bid * 116; memcpy(burst, bi->burst + 3, 58); @@ -971,13 +981,14 @@ n_errors, n_bits_total, *rssi_sum / *rssi_num, *toa256_sum / *toa_num); + lqual_cb = *ci_cb_num ? (*ci_cb_sum / *ci_cb_num) : 0; ber10k = compute_ber10k(n_bits_total, n_errors); return _sched_compose_ph_data_ind(l1t, bi->tn, *first_fn, chan, l2, l2_len, *rssi_sum / *rssi_num, *toa256_sum / *toa_num, - 0 /* FIXME: AVG C/I */, - ber10k, PRES_INFO_UNKNOWN); + lqual_cb, ber10k, + PRES_INFO_UNKNOWN); } /*! \brief a single PDTCH burst was received by the PHY, process it */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea0dad65e9bc511f99375fd3ee2eb44e47a6168f Gerrit-Change-Number: 14689 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 14:33:46 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 7 Jul 2019 14:33:46 +0000 Subject: Change in ...libosmocore[master]: tell ubsan to ignore SUN_LEN In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14682 ) Change subject: tell ubsan to ignore SUN_LEN ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14682/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14682/1//COMMIT_MSG at 9 PS1, Line 9: SUN_LEN is awful and ubsan will report this, so let's ignore it. Can you please explain why is it awful and why/what ubsan reports. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 Gerrit-Change-Number: 14682 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Sun, 07 Jul 2019 14:33:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 14:34:18 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 7 Jul 2019 14:34:18 +0000 Subject: Change in ...osmo-mgw[master]: doc: X-Osmo-IGN: small formatting and typo fixes In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14680 ) Change subject: doc: X-Osmo-IGN: small formatting and typo fixes ...................................................................... doc: X-Osmo-IGN: small formatting and typo fixes Change-Id: I658901a63504f3733793c34947d59b034daa93f6 --- M doc/manuals/chapters/mgcp_extensions.adoc 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/mgcp_extensions.adoc b/doc/manuals/chapters/mgcp_extensions.adoc index 86ff643..a68d785 100644 --- a/doc/manuals/chapters/mgcp_extensions.adoc +++ b/doc/manuals/chapters/mgcp_extensions.adoc @@ -11,7 +11,7 @@ ==== `X-Osmo-IGN` Format -The value part of X-Osmo-IGN must be one or more items separated by one or more +The value part of `X-Osmo-IGN` must be one or more items separated by one or more spaces. Each item consists of one or more non-whitespace characters. .Example: `X-Osmo-IGN` format with three ficticious items "X", "abc" and "123". @@ -19,7 +19,7 @@ X-Osmo-IGN: X abc 123 ---- -`X-Osmo-IGN` must be issued in the MGCP section (typically as its last item), +`X-Osmo-IGN` must be issued in the MGCP header section (typically as its last item), before the SDP section starts. ==== Supported `X-Osmo-IGN` Items -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14680 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I658901a63504f3733793c34947d59b034daa93f6 Gerrit-Change-Number: 14680 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 14:40:44 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 7 Jul 2019 14:40:44 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support SETFORMAT command In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14665 ) Change subject: Transceiver: Support SETFORMAT command ...................................................................... Patch Set 7: > Patch Set 7: > > I believe I raised this before in some other place: Why are we faling back to a lower version rather than simply failing SETFORMAT for any unknown version? I think it's somewhat odd and dangerous if we have "SETFORMAT 3" and then the TRX returns "OK, I set 2". Hi, please review the code again, the logic has changed since last time you commented on it. Right now the version is only applied if it supported by TRXD. If return code is different than the version requested, it's simply an indication towards BTSTRX about the nearest lower version supported by TRX, but in that case, the indicated version is NOT applied. Discussion regarding this topic is on-going in https://osmocom.org/issues/4006#note-25. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9fc22f9987238a5ff870df7718de4efc9e04289 Gerrit-Change-Number: 14665 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Sun, 07 Jul 2019 14:40:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 14:48:31 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 7 Jul 2019 14:48:31 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Avoid noise calculation formula in 2 branches in pullRad... In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14661 ) Change subject: Transceiver: Avoid noise calculation formula in 2 branches in pullRadioVector ...................................................................... Transceiver: Avoid noise calculation formula in 2 branches in pullRadioVector Makes code easier to follow and will help in forthcoming refactoring once idle frames are supported. Change-Id: I56c84e9684ca460efd6c983d7e95d8e455bcac69 --- M Transceiver52M/Transceiver.cpp 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 58e8719..7f05a2c 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -631,19 +631,18 @@ burst = radio_burst->getVector(max_i); avg = sqrt(avg / radio_burst->chans()); - bi->rssi = 20.0 * log10(rxFullScale / avg) + rssiOffset; - if (type == IDLE) { /* Update noise levels */ state->mNoises.insert(avg); state->mNoiseLev = state->mNoises.avg(); - bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset; + } + bi->rssi = 20.0 * log10(rxFullScale / avg) + rssiOffset; + bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset; + + if (type == IDLE) { delete radio_burst; return false; - } else { - /* Do not update noise levels */ - bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset; } unsigned max_toa = (type == RACH || type == EXT_RACH) ? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14661 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I56c84e9684ca460efd6c983d7e95d8e455bcac69 Gerrit-Change-Number: 14661 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 14:48:32 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 7 Jul 2019 14:48:32 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Simplify code on early error return when calling detectA... In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14662 ) Change subject: Transceiver: Simplify code on early error return when calling detectAnyBurst ...................................................................... Transceiver: Simplify code on early error return when calling detectAnyBurst We get rid of one branch and simplify code logic. Change-Id: I026e35262bfe42c3d23ebdc06d84e4908a8380e2 --- M Transceiver52M/Transceiver.cpp 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 7f05a2c..81b428a 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -650,20 +650,16 @@ /* Detect normal or RACH bursts */ rc = detectAnyBurst(*burst, mTSC, BURST_THRESH, mSPSRx, type, amp, toa, max_toa); - - if (rc > 0) { - type = (CorrType) rc; - } else if (rc <= 0) { - if (rc == -SIGERR_CLIP) { + if (rc <= 0) { + if (rc == -SIGERR_CLIP) LOG(WARNING) << "Clipping detected on received RACH or Normal Burst"; - } else if (rc != SIGERR_NONE) { + else if (rc != SIGERR_NONE) LOG(WARNING) << "Unhandled RACH or Normal Burst detection error"; - } - delete radio_burst; return false; } + type = (CorrType) rc; bi->toa = toa; rxBurst = demodAnyBurst(*burst, mSPSRx, amp, toa, type); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14662 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I026e35262bfe42c3d23ebdc06d84e4908a8380e2 Gerrit-Change-Number: 14662 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 14:48:33 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 7 Jul 2019 14:48:33 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: pullRadioVector(): Move initialization of var to start o... In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14663 ) Change subject: Transceiver: pullRadioVector(): Move initialization of var to start of function ...................................................................... Transceiver: pullRadioVector(): Move initialization of var to start of function This will be needed upon forthcoming refactor to support idle frames, which will add a goto return. Otherwise compiler complains: error: jump to label ret_idle [-fpermissive] note: crosses initialization of unsigned int max_toa Change-Id: Icd2793adc7b73a795184639b95fb5da336909b59 --- M Transceiver52M/Transceiver.cpp 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 81b428a..92d4061 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -577,6 +577,7 @@ int rc; complex amp; float toa, max = -1.0, avg = 0.0; + unsigned max_toa; int max_i = -1; signalVector *burst; GSM::Time burstTime; @@ -645,8 +646,8 @@ return false; } - unsigned max_toa = (type == RACH || type == EXT_RACH) ? - mMaxExpectedDelayAB : mMaxExpectedDelayNB; + max_toa = (type == RACH || type == EXT_RACH) ? + mMaxExpectedDelayAB : mMaxExpectedDelayNB; /* Detect normal or RACH bursts */ rc = detectAnyBurst(*burst, mTSC, BURST_THRESH, mSPSRx, type, amp, toa, max_toa); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14663 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Icd2793adc7b73a795184639b95fb5da336909b59 Gerrit-Change-Number: 14663 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 14:48:33 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 7 Jul 2019 14:48:33 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support pulling idle frames in pullRadioVector() In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14664 ) Change subject: Transceiver: Support pulling idle frames in pullRadioVector() ...................................................................... Transceiver: Support pulling idle frames in pullRadioVector() This logic will be used once we support TRXDv1, where idle indications are sent through the socket. Related: OS#4006 Change-Id: I46404f6e4055b6d3af3afffb0dfe4a19502917aa --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 20 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 92d4061..4462cdd 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -591,8 +591,6 @@ /* Set time and determine correlation type */ burstTime = radio_burst->getTime(); - bi->fn = burstTime.FN(); - bi->tn = burstTime.TN(); CorrType type = expectedCorrType(burstTime, chan); /* Enable 8-PSK burst detection if EDGE is enabled */ @@ -612,6 +610,15 @@ return false; } + /* Initialize struct bi */ + bi->nbits = 0; + bi->fn = burstTime.FN(); + bi->tn = burstTime.TN(); + bi->rssi = 0.0; + bi->toa = 0.0; + bi->noise = 0.0; + bi->idle = false; + /* Select the diversity channel with highest energy */ for (size_t i = 0; i < radio_burst->chans(); i++) { float pow = energyDetect(*radio_burst->getVector(i), 20 * mSPSRx); @@ -624,8 +631,7 @@ if (max_i < 0) { LOG(ALERT) << "Received empty burst"; - delete radio_burst; - return false; + goto ret_idle; } /* Average noise on diversity paths and update global levels */ @@ -641,10 +647,8 @@ bi->rssi = 20.0 * log10(rxFullScale / avg) + rssiOffset; bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset; - if (type == IDLE) { - delete radio_burst; - return false; - } + if (type == IDLE) + goto ret_idle; max_toa = (type == RACH || type == EXT_RACH) ? mMaxExpectedDelayAB : mMaxExpectedDelayNB; @@ -656,8 +660,7 @@ LOG(WARNING) << "Clipping detected on received RACH or Normal Burst"; else if (rc != SIGERR_NONE) LOG(WARNING) << "Unhandled RACH or Normal Burst detection error"; - delete radio_burst; - return false; + goto ret_idle; } type = (CorrType) rc; @@ -676,6 +679,11 @@ delete rxBurst; delete radio_burst; return true; + +ret_idle: + bi->idle = true; + delete radio_burst; + return false; } void Transceiver::reset() @@ -968,7 +976,7 @@ struct trx_ul_burst_ind bi; - if (!pullRadioVector(chan, &bi)) + if (!pullRadioVector(chan, &bi) || bi.idle) return; logRxBurst(chan, &bi); diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index e4d0440..a66c962 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -44,6 +44,7 @@ double rssi; // in dBFS double toa; // in symbols double noise; // noise level in dBFS + bool idle; // true if no valid burst is included }; class Transceiver; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14664 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I46404f6e4055b6d3af3afffb0dfe4a19502917aa Gerrit-Change-Number: 14664 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 14:49:03 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 7 Jul 2019 14:49:03 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14670 ) Change subject: osmo-bts-trx/trx_if.c: properly describe TRXD messages in logs ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14670/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/14670/1/src/osmo-bts-trx/trx_if.c at 744 PS1, Line 744: static char buf[256]; > I was thinking about potential performance impact. [?] that stack allocation is for free, no overhead exists. Instead of moving an address X to register, it'd be moving X-256, so that's not really a valid reason in my opinion. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14670 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I68729dc98a1840d2aa9e091153d176a103d5a228 Gerrit-Change-Number: 14670 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jul 2019 14:49:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 17:19:53 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Sun, 7 Jul 2019 17:19:53 +0000 Subject: Change in ...libosmocore[master]: tell ubsan to ignore SUN_LEN In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14682 ) Change subject: tell ubsan to ignore SUN_LEN ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14682/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14682/1//COMMIT_MSG at 9 PS1, Line 9: SUN_LEN is awful and ubsan will report this, so let's ignore it. > Can you please explain why is it awful and why/what ubsan reports. SUN_LEN(ptr) ((size_t) (((struct sockaddr_un *) 0)->sun_path) + strlen((ptr)->sun_path)) So obviously this is reported as runtime error so it's the first thing I look at while debugging since the sanitizer reports are rarely false. We should either fix sanitizer reports or suppress them. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 Gerrit-Change-Number: 14682 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Sun, 07 Jul 2019 17:19:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 18:41:10 2019 From: gerrit-no-reply at lists.osmocom.org (ipse) Date: Sun, 7 Jul 2019 18:41:10 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX In-Reply-To: References: Message-ID: ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14684 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14684/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14684/1/src/osmo-bts-trx/scheduler_trx.c at 796 PS1, Line 796: /* Handover RACH cannot be extended (11-bit) */ It's not clear how does this comment relates to the "if()" below. Could you reword it to make the relation obvious? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1e654a2e49cb83c5f1e6249c0de688f99bc466b0 Gerrit-Change-Number: 14684 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 07 Jul 2019 18:41:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 7 18:43:40 2019 From: gerrit-no-reply at lists.osmocom.org (ipse) Date: Sun, 7 Jul 2019 18:43:40 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message In-Reply-To: References: Message-ID: ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14685 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c at 800 PS1, Line 800: synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, NULL); What does this change has to do with debugging messages? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 Gerrit-Change-Number: 14685 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: ipse Gerrit-Comment-Date: Sun, 07 Jul 2019 18:43:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 02:37:14 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 02:37:14 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support TRXD v1 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14657 ) Change subject: Transceiver: Support TRXD v1 ...................................................................... Patch Set 9: (1 comment) https://gerrit.osmocom.org/#/c/14657/9/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/14657/9/Transceiver52M/Transceiver.cpp at 622 PS9, Line 622: bi->tss = 0; I just checked 3GPP TS 45.002, tables 5.2.3a-d. As it turns out, default TSC set is actually referred as TSC Set 1. On "the wire", bi->tss = 0 corresponds to that TSC Set 1, and bi->tss = 3 corresponds to TSC Set 4. Just for a clarification ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Jul 2019 02:37:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Mon Jul 8 02:39:18 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 08 Jul 2019 02:39:18 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d22acee411_3358c48600340057@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 451s] | This file was extended by libosmocore config.status 1.1.0.75-316d, which was [ 451s] | generated by GNU Autoconf 2.69. Invocation command line was [ 451s] | [ 451s] | CONFIG_FILES = [ 451s] | CONFIG_HEADERS = [ 451s] | CONFIG_LINKS = [ 451s] | CONFIG_COMMANDS = [ 451s] | $ ./config.status Doxyfile.core [ 451s] | [ 451s] | on armbuild22 [ 451s] | [ 451s] | config.status:1200: creating Doxyfile.core [ 451s] [ 451s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 451s] make[1]: *** [override_dh_auto_test] Error 1 [ 451s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 451s] debian/rules:15: recipe for target 'build' failed [ 451s] make: *** [build] Error 2 [ 451s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 451s] [ 451s] armbuild22 failed "build libosmocore_1.1.0.75.316d.dsc" at Mon Jul 8 02:38:59 UTC 2019. [ 451s] [ 451s] ### VM INTERACTION START ### [ 454s] [ 437.050267] sysrq: SysRq : Power Off [ 454s] [ 437.069973] reboot: Power down [ 454s] ### VM INTERACTION END ### [ 454s] [ 454s] armbuild22 failed "build libosmocore_1.1.0.75.316d.dsc" at Mon Jul 8 02:39:03 UTC 2019. [ 454s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 8 02:46:27 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 08 Jul 2019 02:46:27 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d22ae9417e71_3358c4860034036@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 267s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 267s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 267s] collect2: error: ld returned 1 exit status [ 267s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 267s] make[4]: *** [osmo-bts-virtual] Error 1 [ 267s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 267s] Makefile:385: recipe for target 'all-recursive' failed [ 267s] make[3]: *** [all-recursive] Error 1 [ 267s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 267s] Makefile:434: recipe for target 'all-recursive' failed [ 267s] make[2]: *** [all-recursive] Error 1 [ 267s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 267s] Makefile:366: recipe for target 'all' failed [ 267s] make[1]: *** [all] Error 2 [ 267s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 267s] dh_auto_build: make -j1 returned exit code 2 [ 267s] debian/rules:12: recipe for target 'build' failed [ 267s] make: *** [build] Error 2 [ 267s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 267s] [ 267s] obs-arm-5 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Mon Jul 8 02:46:07 UTC 2019. [ 267s] [ 267s] ### VM INTERACTION START ### [ 270s] [ 247.325146] sysrq: SysRq : Power Off [ 270s] [ 247.326764] reboot: Power down [ 270s] ### VM INTERACTION END ### [ 270s] [ 270s] obs-arm-5 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Mon Jul 8 02:46:11 UTC 2019. [ 270s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 8 03:11:52 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 08 Jul 2019 03:11:52 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d22b48a4e21b_3358c4860034143@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 372s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 372s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 372s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 372s] Makefile:442: recipe for target 'vlr.o' failed [ 372s] make[4]: *** [vlr.o] Error 1 [ 372s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 372s] Makefile:422: recipe for target 'all-recursive' failed [ 372s] make[3]: *** [all-recursive] Error 1 [ 372s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 372s] Makefile:462: recipe for target 'all-recursive' failed [ 372s] make[2]: *** [all-recursive] Error 1 [ 372s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 372s] Makefile:394: recipe for target 'all' failed [ 372s] make[1]: *** [all] Error 2 [ 372s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 372s] dh_auto_build: make -j1 returned exit code 2 [ 372s] debian/rules:45: recipe for target 'build' failed [ 372s] make: *** [build] Error 2 [ 372s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 372s] [ 372s] armbuild04 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Mon Jul 8 03:11:41 UTC 2019. [ 372s] [ 372s] ### VM INTERACTION START ### [ 375s] [ 355.215582] sysrq: SysRq : Power Off [ 375s] [ 355.216933] reboot: Power down [ 376s] ### VM INTERACTION END ### [ 376s] [ 376s] armbuild04 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Mon Jul 8 03:11:44 UTC 2019. [ 376s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 8 03:12:44 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 08 Jul 2019 03:12:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d22b4c6c0b9d_3358c486003415c7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 416s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 416s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 416s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 416s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 416s] make[4]: *** [gb_proxy.o] Error 1 [ 416s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 416s] Makefile:391: recipe for target 'all-recursive' failed [ 416s] make[3]: *** [all-recursive] Error 1 [ 416s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 416s] Makefile:453: recipe for target 'all-recursive' failed [ 416s] make[2]: *** [all-recursive] Error 1 [ 416s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 416s] Makefile:385: recipe for target 'all' failed [ 416s] make[1]: *** [all] Error 2 [ 416s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 416s] dh_auto_build: make -j1 returned exit code 2 [ 416s] debian/rules:45: recipe for target 'build' failed [ 416s] make: *** [build] Error 2 [ 416s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 416s] [ 416s] armbuild22 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Mon Jul 8 03:12:26 UTC 2019. [ 416s] [ 416s] ### VM INTERACTION START ### [ 419s] [ 400.351095] sysrq: SysRq : Power Off [ 419s] [ 400.352434] reboot: Power down [ 419s] ### VM INTERACTION END ### [ 419s] [ 419s] armbuild22 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Mon Jul 8 03:12:29 UTC 2019. [ 419s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Jul 8 03:42:54 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 03:42:54 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation In-Reply-To: References: Message-ID: Hello pespin, laforge, Jenkins Builder, Hoernchen, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/14586 to look at the new patch set (#4). Change subject: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation ...................................................................... trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation C/I (Carrier-to-Interference ratio) is a value in cB (centiBels), computed from the training sequence of each received burst, by comparing the "ideal" training sequence with the received one. This change introduces a new command similar to FAKE_TOA and FAKE_RSSI, so it can be used by TTCN-3 test case 'TC_pcu_data_ind_lqual_cb' to verify that the link quality measurements are delivered to the PCU. Change-Id: I7080effbbc1022d1884c6d6f0cb580eba8e514ff Related: OS#1855 --- M src/target/trx_toolkit/fake_trx.py 1 file changed, 29 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/86/14586/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7080effbbc1022d1884c6d6f0cb580eba8e514ff Gerrit-Change-Number: 14586 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 03:42:55 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 03:42:55 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/gsm_shared.py: introduce a new enum TrainingSeqGMSK Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14690 Change subject: trx_toolkit/gsm_shared.py: introduce a new enum TrainingSeqGMSK ...................................................................... trx_toolkit/gsm_shared.py: introduce a new enum TrainingSeqGMSK Training Sequences are defined in 3GPP TS 45.002, and used by the transceiver for detecting bursts. This change introduces an enum with training sequences for GMSK for Access and Normal bursts. This enumeration is needed for the follow-up changes that implement TRXD header version 1 support, and can now be used by RandBurstGen. Change-Id: If3bf102019ef53d6ee9ad230ef98bb45845b5af5 --- M src/target/trx_toolkit/gsm_shared.py 1 file changed, 78 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/90/14690/1 diff --git a/src/target/trx_toolkit/gsm_shared.py b/src/target/trx_toolkit/gsm_shared.py index d2f8278..d76978e 100644 --- a/src/target/trx_toolkit/gsm_shared.py +++ b/src/target/trx_toolkit/gsm_shared.py @@ -4,7 +4,7 @@ # TRX Toolkit # Common GSM constants # -# (C) 2018 by Vadim Yanitskiy +# (C) 2018-2019 by Vadim Yanitskiy # # All Rights Reserved # @@ -22,6 +22,8 @@ # with this program; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +from enum import Enum + # TDMA definitions GSM_SUPERFRAME = 26 * 51 GSM_HYPERFRAME = 2048 * GSM_SUPERFRAME @@ -29,3 +31,78 @@ # Burst length GSM_BURST_LEN = 148 EDGE_BURST_LEN = GSM_BURST_LEN * 3 + +class BurstType(Enum): + """ Burst types defined in 3GPP TS 45.002 """ + DUMMY = ("DB") # Dummy burst (5.2.6) + SYNC = ("SB") # Synchronization Burst (5.2.5) + FREQ = ("FB") # Frequency correction Burst (5.2.4) + ACCESS = ("AB") # Access Burst (5.2.7) + NORMAL = ("NB") # Normal Burst (5.2.3) + # HSR = ("HB") # Higher symbol rate burst (5.2.3a) + +class TrainingSeqGMSK(Enum): + """ Training Sequences defined in 3GPP TS 45.002 """ + + # Training Sequences for Access Burst (table 5.2.7-3) + AB_TS0 = (0, BurstType.ACCESS, "01001011011111111001100110101010001111000") + AB_TS1 = (1, BurstType.ACCESS, "01010100111110001000011000101111001001101") + AB_TS2 = (2, BurstType.ACCESS, "11101111001001110101011000001101101110111") + AB_TS4 = (4, BurstType.ACCESS, "11001001110001001110000000001101010110010") + + # Training Sequences for Access Burst (table 5.2.7-4) + AB_TS3 = (3, BurstType.ACCESS, "10001000111010111011010000010000101100010") + AB_TS5 = (5, BurstType.ACCESS, "01010000111111110101110101101100110010100") + AB_TS6 = (6, BurstType.ACCESS, "01011110011101011110110100010011000010111") + AB_TS7 = (7, BurstType.ACCESS, "01000010110000011101001010111011100010000") + + # Training Sequences for Synchronization Burst (table 5.2.5-3) + SB_TS0 = (0, BurstType.SYNC, "1011100101100010000001000000111100101101010001010111011000011011") + SB_TS1 = (1, BurstType.SYNC, "1110111001101011001010000011111011110100011111101100101100010101") + SB_TS2 = (2, BurstType.SYNC, "1110110000110111010100010101101001111000000100000010001101001110") + SB_TS3 = (3, BurstType.SYNC, "1011101000111101110101101111010010001011010000001000111010011000") + + # Training Sequences for Normal Burst (table 5.2.3a, TSC set 1) + NB_TS0 = (0, BurstType.NORMAL, "00100101110000100010010111") + NB_TS1 = (1, BurstType.NORMAL, "00101101110111100010110111") + NB_TS2 = (2, BurstType.NORMAL, "01000011101110100100001110") + NB_TS3 = (3, BurstType.NORMAL, "01000111101101000100011110") + NB_TS4 = (4, BurstType.NORMAL, "00011010111001000001101011") + NB_TS5 = (5, BurstType.NORMAL, "01001110101100000100111010") + NB_TS6 = (6, BurstType.NORMAL, "10100111110110001010011111") + NB_TS7 = (7, BurstType.NORMAL, "11101111000100101110111100") + + # TODO: more TSC sets from tables 5.2.3b-d + + def __init__(self, tsc, bt, seq_str, tsc_set = 0): + # Training Sequence Code + self.tsc = tsc + # Burst type + self.bt = bt + + # Training Sequence Code set + # NOTE: unlike the specs. we count from zero + self.tsc_set = tsc_set + + # Generate Training Sequence bits + self.seq = [int(x) for x in seq_str] + + @classmethod + def pick(self, burst): + # Normal burst TS (26 bits) + nb_seq = burst[3 + 57 + 1:][:26] + # Access burst TS (41 bits) + ab_seq = burst[8:][:41] + # Sync Burst TS (64 bits) + sb_seq = burst[3 + 39:][:64] + + for ts in list(self): + # Ugly Python way of writing 'switch' statement + if ts.bt is BurstType.NORMAL and ts.seq == nb_seq: + return ts + elif ts.bt is BurstType.ACCESS and ts.seq == ab_seq: + return ts + elif ts.bt is BurstType.SYNC and ts.seq == sb_seq: + return ts + + return None -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If3bf102019ef53d6ee9ad230ef98bb45845b5af5 Gerrit-Change-Number: 14690 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 03:42:55 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 03:42:55 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/rand_burst_gen.py: use TrainingSeqGMSK and BurstType enums Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14691 Change subject: trx_toolkit/rand_burst_gen.py: use TrainingSeqGMSK and BurstType enums ...................................................................... trx_toolkit/rand_burst_gen.py: use TrainingSeqGMSK and BurstType enums Change-Id: I8a3faceae4a8d9b57d86d42600db839da073dad6 --- M src/target/trx_toolkit/rand_burst_gen.py 1 file changed, 16 insertions(+), 56 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/91/14691/1 diff --git a/src/target/trx_toolkit/rand_burst_gen.py b/src/target/trx_toolkit/rand_burst_gen.py index 46c1e09..80ff3f2 100644 --- a/src/target/trx_toolkit/rand_burst_gen.py +++ b/src/target/trx_toolkit/rand_burst_gen.py @@ -28,50 +28,6 @@ class RandBurstGen: - # GSM 05.02 Chapter 5.2.3 Normal Burst - nb_tsc_list = [ - [ - 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, - 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, - ], - [ - 0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, - 1, 1, 0, 0, 0, 1, 0, 1, 1, 0, 1, 1, 1, - ], - [ - 0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, - 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0, - ], - [ - 0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, - 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0, - ], - [ - 0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, - 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1, - ], - [ - 0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, - 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0, - ], - [ - 1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, - 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1, - ], - [ - 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, - 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, - ], - ] - - # GSM 05.02 Chapter 5.2.5 SCH training sequence - sb_tsc = [ - 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0, - 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, - 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1, - 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1, - ] - # GSM 05.02 Chapter 5.2.6 Dummy Burst db_bits = [ 0, 0, 0, @@ -87,15 +43,13 @@ 0, 0, 0, ] - # GSM 05.02 Chapter 5.2.7 Access burst - ab_tsc = [ - 0, 1, 0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 1, 1, - 1, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 1, 0, - 1, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 0, 0, - ] + # Pick a random TSC for a given burst type + def get_rand_tsc(self, bt): + tsc_list = filter(lambda seq: seq.bt == bt, list(TrainingSeqGMSK)) + return random.choice(tsc_list) # Generate a normal burst - def gen_nb(self, seq_idx = 0): + def gen_nb(self, tsc = None): buf = [] # Tailing bits @@ -109,7 +63,9 @@ buf.append(random.randint(0, 1)) # Training sequence - buf += self.nb_tsc_list[seq_idx] + if tsc is None: + tsc = self.get_rand_tsc(BurstType.NORMAL) + buf += tsc.seq # Steal flag 2 / 2 buf.append(random.randint(0, 1)) @@ -128,7 +84,7 @@ return [0] * GSM_BURST_LEN # Generate a synchronization burst - def gen_sb(self): + def gen_sb(self, tsc = None): buf = [] # Tailing bits @@ -139,7 +95,9 @@ buf.append(random.randint(0, 1)) # Training sequence - buf += self.sb_tsc + if tsc is None: + tsc = self.get_rand_tsc(BurstType.SYNC) + buf += tsc.seq # Random data 2 / 2 for i in range(0, 39): @@ -155,14 +113,16 @@ return self.db_bits # Generate an access burst - def gen_ab(self): + def gen_ab(self, tsc = None): buf = [] # Tailing bits buf += [0] * 8 # Training sequence - buf += self.ab_tsc + if tsc is None: + tsc = self.get_rand_tsc(BurstType.ACCESS) + buf += tsc.seq # Random data for i in range(0, 36): -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14691 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8a3faceae4a8d9b57d86d42600db839da073dad6 Gerrit-Change-Number: 14691 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 03:42:56 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 03:42:56 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14692 Change subject: trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation ...................................................................... trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation Messages on DATA interface may have different header formats, defined by a version number, which can be negotiated on the control interface. By default, the Transceiver will use the legacy header version (0). The header format negotiation can be initiated by the L1 using the 'SETFORMAT' command. If the requested version is not supported by the transceiver, status code of the response message should indicate a preferred (basically, the latest) version. The format of this message is the following: L1 -> TRX: CMD SETFORMAT VER_REQ L1 <- TRX: RSP SETFORMAT VER_RSP VER_REQ where: - VER_REQ is the requested version (suggested by the L1), - VER_RSP is either the applied version if matches VER_REQ, or a preferred version if VER_REQ is not supported. If the transceiver indicates VER_RSP different than VER_REQ, the L1 is supposed to reinitiate the version negotiation using the suggested VER_RSP. For example: L1 -> TRX: CMD SETFORMAT 2 L1 <- TRX: RSP SETFORMAT 1 2 L1 -> TRX: CMD SETFORMAT 1 L1 <- TRX: RSP SETFORMAT 1 1 If no suitable VER_RSP is found, or the VER_REQ is incorrect, the status code in the response shall be -1. As soon as VER_RSP matches VER_REQ in the response, the process of negotiation is complete. Changing the header version is supposed to be done before POWERON, but can be also done after. Change-Id: I8d441b2559863d2dbd680db371062e4f3a2f9ff9 Related: OS#4006 --- M src/target/trx_toolkit/ctrl_if_trx.py M src/target/trx_toolkit/data_if.py 2 files changed, 70 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/92/14692/1 diff --git a/src/target/trx_toolkit/ctrl_if_trx.py b/src/target/trx_toolkit/ctrl_if_trx.py index 26a844f..f696418 100644 --- a/src/target/trx_toolkit/ctrl_if_trx.py +++ b/src/target/trx_toolkit/ctrl_if_trx.py @@ -4,7 +4,7 @@ # TRX Toolkit # CTRL interface implementation (common commands) # -# (C) 2016-2018 by Vadim Yanitskiy +# (C) 2016-2019 by Vadim Yanitskiy # # All Rights Reserved # @@ -42,6 +42,45 @@ that is prioritized, i.e. it can overwrite any commands mentioned above. If None is returned, a command is considered as unhandled. + == TRXD header version negotiation + + Messages on DATA interface may have different header formats, + defined by a version number, which can be negotiated on the + control interface. By default, the Transceiver will use the + legacy header version (0). + + The header format negotiation can be initiated by the L1 + using 'SETFORMAT' command. If the requested version is not + supported by the transceiver, status code of the response + message should indicate a preferred (basically, the latest) + version. The format of this message is the following: + + L1 -> TRX: CMD SETFORMAT VER_REQ + L1 <- TRX: RSP SETFORMAT VER_RSP VER_REQ + + where: + + - VER_REQ is the requested version (suggested by the L1), + - VER_RSP is either the applied version if matches VER_REQ, + or a preferred version if VER_REQ is not supported. + + If the transceiver indicates VER_RSP different than VER_REQ, + the L1 is supposed to reinitiate the version negotiation + using the suggested VER_RSP. For example: + + L1 -> TRX: CMD SETFORMAT 2 + L1 <- TRX: RSP SETFORMAT 1 2 + + L1 -> TRX: CMD SETFORMAT 1 + L1 <- TRX: RSP SETFORMAT 1 1 + + If no suitable VER_RSP is found, or the VER_REQ is incorrect, + the status code in the response shall be -1. + + As soon as VER_RSP matches VER_REQ in the response, the process + of negotiation is complete. Changing the header version is + supposed to be done before POWERON, but can be also done after. + """ def __init__(self, trx, *udp_link_args): @@ -147,6 +186,27 @@ return (0, [str(meas_dbm)]) + # TRXD header version negotiation + if self.verify_cmd(request, "SETFORMAT", 1): + log.debug("(%s) Recv SETFORMAT cmd" % self.trx) + + # Parse the requested version + ver_req = int(request[1]) + + log.info("(%s) Requested TRXD header version %u (current %u)" + % (self.trx, ver_req, self.trx.data_if._hdr_ver)) + + if not self.trx.data_if.set_hdr_ver(ver_req): + ver_rsp = self.trx.data_if.pick_hdr_ver(ver_req) + log.error("(%s) Requested TRXD header version %u " + "is not supported, suggesting %u..." + % (self.trx, ver_req, ver_rsp)) + return ver_rsp + + log.info("(%s) Using TRXD header version %u" + % (self.trx, ver_req)) + return ver_req + # Wrong / unknown command else: # We don't care about other commands, diff --git a/src/target/trx_toolkit/data_if.py b/src/target/trx_toolkit/data_if.py index 8ac0418..9f1f52a 100644 --- a/src/target/trx_toolkit/data_if.py +++ b/src/target/trx_toolkit/data_if.py @@ -42,6 +42,15 @@ self._hdr_ver = ver return True + def pick_hdr_ver(self, ver_req): + # Pick a version that is lower or equal to ver_req + for ver in DATAMSG.known_versions[::-1]: + if ver <= ver_req: + return ver + + # No suitable version found + return -1 + def match_hdr_ver(self, msg): if msg.ver == self._hdr_ver: return True -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8d441b2559863d2dbd680db371062e4f3a2f9ff9 Gerrit-Change-Number: 14692 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 03:44:35 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 03:44:35 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14585 ) Change subject: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I164f5ae4ce7694d6e324aab927a04e96d489ebd8 Gerrit-Change-Number: 14585 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Jul 2019 03:44:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 03:49:26 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 03:49:26 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14692 ) Change subject: trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14692/1/src/target/trx_toolkit/ctrl_if_trx.py File src/target/trx_toolkit/ctrl_if_trx.py: https://gerrit.osmocom.org/#/c/14692/1/src/target/trx_toolkit/ctrl_if_trx.py at 196 PS1, Line 196: Requested TRXD header version %u (current %u) Hmm, this debug print looks redundant. I think I will drop it and change the one below. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8d441b2559863d2dbd680db371062e4f3a2f9ff9 Gerrit-Change-Number: 14692 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 08 Jul 2019 03:49:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 09:59:46 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Mon, 8 Jul 2019 09:59:46 +0000 Subject: Change in ...docker-playground[master]: clean up the net and attached containers to ensure reliable test starts In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14679 ) Change subject: clean up the net and attached containers to ensure reliable test starts ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14679 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id6d13b233ebfd808d8dfe83b6d1d1ba20c3392c8 Gerrit-Change-Number: 14679 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Jul 2019 09:59:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 09:59:52 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Mon, 8 Jul 2019 09:59:52 +0000 Subject: Change in ...docker-playground[master]: clean up the net and attached containers to ensure reliable test starts In-Reply-To: References: Message-ID: Hoernchen has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14679 ) Change subject: clean up the net and attached containers to ensure reliable test starts ...................................................................... clean up the net and attached containers to ensure reliable test starts We can't create the net if it exists, and it can't be removed until all attached containers are dead, so ensure this is the case upon net creation. This fixes test failures due to stale nets and half-killed test runs. Change-Id: Id6d13b233ebfd808d8dfe83b6d1d1ba20c3392c8 --- M jenkins-common.sh 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Hoernchen: Verified diff --git a/jenkins-common.sh b/jenkins-common.sh index 25ae26f..9fd3857 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -28,8 +28,18 @@ done } +#kills all containers attached to network +network_clean() { + docker network inspect $NET_NAME | grep Name | cut -d : -f2 | awk -F\" 'NR>1{print $2}' | xargs -rn1 docker kill +} + network_create() { NET=$1 + if docker network ls | grep -q $NET_NAME; then + echo removing stale network and containers... + network_clean + network_remove + fi echo Creating network $NET_NAME docker network create --internal --subnet $NET $NET_NAME } -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14679 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id6d13b233ebfd808d8dfe83b6d1d1ba20c3392c8 Gerrit-Change-Number: 14679 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 12:00:12 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 12:00:12 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14195 ) Change subject: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler ...................................................................... Patch Set 3: @pespin, I think it still makes sense to merge this change. Since the matching problem has been solved in the recent libosmovty, it may be useful for those users who are using release version of libosmocore, or an older version. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: If9b0c0d031477ca87786aab5c269d00748e896c8 Gerrit-Change-Number: 14195 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Jul 2019 12:00:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 12:00:48 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Jul 2019 12:00:48 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/gsm_shared.py: introduce a new enum TrainingSeqGMSK In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14690 ) Change subject: trx_toolkit/gsm_shared.py: introduce a new enum TrainingSeqGMSK ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If3bf102019ef53d6ee9ad230ef98bb45845b5af5 Gerrit-Change-Number: 14690 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Jul 2019 12:00:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 12:01:33 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 8 Jul 2019 12:01:33 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/rand_burst_gen.py: use TrainingSeqGMSK and BurstType enums In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14691 ) Change subject: trx_toolkit/rand_burst_gen.py: use TrainingSeqGMSK and BurstType enums ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14691 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8a3faceae4a8d9b57d86d42600db839da073dad6 Gerrit-Change-Number: 14691 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Jul 2019 12:01:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 12:25:57 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 8 Jul 2019 12:25:57 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: hlr: update expected-results.xml In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14616 ) Change subject: hlr: update expected-results.xml ...................................................................... hlr: update expected-results.xml Add check imei, create-subscriber-on-demand tests. Change-Id: I8ea4a90d5da8367f369522cfd9133e2c6061dd5c --- M hlr/expected-results.xml 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/hlr/expected-results.xml b/hlr/expected-results.xml index 8329632..b7d2773 100644 --- a/hlr/expected-results.xml +++ b/hlr/expected-results.xml @@ -1,5 +1,5 @@ - + @@ -18,4 +18,10 @@ + + + + + + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14616 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8ea4a90d5da8367f369522cfd9133e2c6061dd5c Gerrit-Change-Number: 14616 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 12:27:15 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 8 Jul 2019 12:27:15 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: L3_Templates: fix IMEI length: 14 (not 15) Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14693 Change subject: L3_Templates: fix IMEI length: 14 (not 15) ...................................................................... L3_Templates: fix IMEI length: 14 (not 15) The right length is 14. The 15th additional checksum digit is not intended for digital transmission. A good overview of the IMEI/IMEISV structure is here: https://en.wikipedia.org/wiki/International_Mobile_Equipment_Identity#Structure_of_the_IMEI_and_IMEISV_(IMEI_software_version) Related: Iaf2569c099874b55acbd748b776394726cc5ce54 (osmo-msc) Change-Id: I7121f29a90f19d92c7bf26f26e76f1978c648459 --- M library/L3_Templates.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/14693/1 diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index a2fe67a..6af020b 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -2779,7 +2779,7 @@ } function f_gen_imei(integer suffix) return hexstring { - return f_concat_pad(15, '49999'H, suffix); + return f_concat_pad(14, '49999'H, suffix); } function f_gen_imsi(integer suffix) return hexstring { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7121f29a90f19d92c7bf26f26e76f1978c648459 Gerrit-Change-Number: 14693 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 12:27:16 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 8 Jul 2019 12:27:16 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: add check imei tests Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 Change subject: msc: add check imei tests ...................................................................... msc: add check imei tests Related: OS#2542 Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d --- M library/GSUP_Types.ttcn M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn M msc/expected-results.xml 4 files changed, 420 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/14694/1 diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn index e627538..74fbfc4 100644 --- a/library/GSUP_Types.ttcn +++ b/library/GSUP_Types.ttcn @@ -538,10 +538,30 @@ ts_GSUP(OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST, { valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_IMEI(imei)) }); +template GSUP_PDU tr_GSUP_CHECK_IMEI_REQ( + template hexstring imsi, + template hexstring imei +) := tr_GSUP( + OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST, + { + tr_GSUP_IE_IMSI(imsi), + tr_GSUP_IE_IMEI(imei), + tr_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_SUBSCRIBER_MANAGEMENT) + } +); + +template (value) GSUP_PDU ts_GSUP_CHECK_IMEI_RES(hexstring imsi, GSUP_IMEIResult result) := + ts_GSUP(OSMO_GSUP_MSGT_CHECK_IMEI_RESULT, { + valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_IMEI_Result(result)) }); + template GSUP_PDU tr_GSUP_CHECK_IMEI_RES(template hexstring imsi, template GSUP_IMEIResult result) := tr_GSUP(OSMO_GSUP_MSGT_CHECK_IMEI_RESULT, { tr_GSUP_IE_IMSI(imsi), tr_GSUP_IE_IMEI_Result(result) }); +template (value) GSUP_PDU ts_GSUP_CHECK_IMEI_ERR(hexstring imsi, integer cause) := + ts_GSUP(OSMO_GSUP_MSGT_CHECK_IMEI_ERROR, { + valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_Cause(cause)) }); + template GSUP_PDU tr_GSUP_CHECK_IMEI_ERR(template hexstring imsi, template integer cause) := tr_GSUP(OSMO_GSUP_MSGT_CHECK_IMEI_ERROR, { tr_GSUP_IE_IMSI(imsi), tr_GSUP_IE_Cause(cause) }); diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 1dd4d05..a5a110d 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -70,7 +70,11 @@ OCT1 kc_support, boolean expect_tmsi, boolean expect_auth, - boolean expect_ciph + boolean expect_ciph, + boolean expect_imei, + boolean expect_imei_early, + GSUP_IMEIResult check_imei_result, + boolean check_imei_error } type record BSC_ConnHdlrPars { @@ -433,6 +437,82 @@ } } +function f_mm_imei() runs on BSC_ConnHdlr +{ + var PDU_DTAP_MT dtap_mt; + var GSUP_PDU gsup_msg; + var MobileL3_CommonIE_Types.MobileIdentityLV mi; + + if (not g_pars.net.expect_imei) { + return + } + + /* MSC <-> BSC: ID req/rsp for IMEI */ + alt { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req('010'B /* IMEI */))) { + mi := valueof(ts_MI_IMEI_LV(g_pars.imei)); + BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_MM_ID_Rsp(mi))); + } + [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { + setverdict(fail, "Expected ID REQ for IMEI DTAP MT message, but got: ", dtap_mt); + mtc.stop; + } + } + + /* MSC <-> HLR: Check IMEI req/res/err */ + alt { + [g_pars.net.check_imei_error] GSUP.receive(tr_GSUP_CHECK_IMEI_REQ(g_pars.imsi, g_pars.imei)) { + GSUP.send(ts_GSUP_CHECK_IMEI_ERR(g_pars.imsi, 96 /* Invalid Mandatory Information */)); + } + [not g_pars.net.check_imei_error] GSUP.receive(tr_GSUP_CHECK_IMEI_REQ(g_pars.imsi, g_pars.imei)) { + GSUP.send(ts_GSUP_CHECK_IMEI_RES(g_pars.imsi, g_pars.net.check_imei_result)); + } + [] GSUP.receive(?) -> value gsup_msg { + setverdict(fail, "Expected CHECK IMEI REQ GSUP message (with IMEI:", g_pars.imei, " and IMSI: ", + g_pars.imsi, "), but got: ", gsup_msg); + mtc.stop; + } + } +} + +function f_mm_imei_early() runs on BSC_ConnHdlr +{ + var PDU_DTAP_MT dtap_mt; + var GSUP_PDU gsup_msg; + var MobileL3_CommonIE_Types.MobileIdentityLV mi; + + if (not g_pars.net.expect_imei_early) { + return + } + + /* MSC <-> BSC: ID req/rsp for IMEISV */ + alt { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req('011'B /* IMEISV */))) { + mi := valueof(ts_MI_IMEISV_LV(g_pars.imei)); + BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_MM_ID_Rsp(mi))); + } + [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { + setverdict(fail, "Expected ID REQ for IMEISV DTAP MT message, but got: ", dtap_mt); + mtc.stop; + } + } + + /* MSC <-> HLR: Check IMEI req/res/err */ + alt { + [g_pars.net.check_imei_error] GSUP.receive(tr_GSUP_CHECK_IMEI_REQ(g_pars.imsi, g_pars.imei)) { + GSUP.send(ts_GSUP_CHECK_IMEI_ERR(g_pars.imsi, 96 /* Invalid Mandatory Information */)); + } + [not g_pars.net.check_imei_error] GSUP.receive(tr_GSUP_CHECK_IMEI_REQ(g_pars.imsi, g_pars.imei)) { + GSUP.send(ts_GSUP_CHECK_IMEI_RES(g_pars.imsi, g_pars.net.check_imei_result)); + } + [] GSUP.receive(?) -> value gsup_msg { + setverdict(fail, "Expected CHECK IMEI REQ GSUP message (with IMEI:", g_pars.imei, " and IMSI: ", + g_pars.imsi, "), but got: ", gsup_msg); + mtc.stop; + } + } +} + function f_mm_common() runs on BSC_ConnHdlr { f_mm_auth(); @@ -508,8 +588,10 @@ f_ranap_initial_ue(l3_lu); } + f_mm_imei_early(); f_mm_common(); f_msc_lu_hlr(); + f_mm_imei(); f_accept_reject_lu(); /* FIXME: there could be pending SMS or other common procedures by the MSC, let's ignore them */ f_expect_clear(); diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 4b00e34..7df2e76 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -335,6 +335,7 @@ /* set some defaults */ f_vty_config(MSCVTY, "network", "authentication optional"); f_vty_config(MSCVTY, "msc", "assign-tmsi"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd 0"); f_vty_config(MSCVTY, "network", "encryption a5 0"); if (mp_enable_osmux_test) { if (osmux) { @@ -367,7 +368,11 @@ kc_support := '0A'O, /* A5/1 and A5/3 enabled */ expect_tmsi := true, expect_auth := false, - expect_ciph := false + expect_ciph := false, + expect_imei := false, + expect_imei_early := false, + check_imei_result := OSMO_GSUP_IMEI_RESULT_ACK, + check_imei_error := false }; var BSC_ConnHdlrPars pars := { sccp_addr_own := g_bssap[ran_idx].sccp_addr_own, @@ -5531,6 +5536,287 @@ vc_conn.done; } +private function f_tc_lu_imsi_auth_tmsi_check_imei(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_auth := true; + pars.net.expect_imei := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_auth_tmsi_check_imei() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd 1"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth_tmsi_check_imei), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_auth3g_tmsi_check_imei(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_auth := true; + pars.use_umts_aka := true; + pars.net.expect_imei := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_auth3g_tmsi_check_imei() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd 1"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth3g_tmsi_check_imei), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_noauth_tmsi_check_imei(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_imei := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_noauth_tmsi_check_imei() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "msc", "check-imei-rqd 1"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_noauth_tmsi_check_imei), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_noauth_notmsi_check_imei(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_tmsi := false; + pars.net.expect_imei := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_noauth_notmsi_check_imei() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "msc", "no assign-tmsi"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd 1"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_noauth_notmsi_check_imei), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_auth_tmsi_check_imei_nack(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + var PDU_ML3_MS_NW l3_lu; + var PDU_DTAP_MT dtap_mt; + + pars.net.expect_auth := true; + pars.net.expect_imei := true; + pars.net.check_imei_result := OSMO_GSUP_IMEI_RESULT_NACK; + f_init_handler(pars); + + /* Cannot use f_perform_lu() as we expect a reject */ + l3_lu := f_build_lu_imsi(g_pars.imsi) + f_create_gsup_expect(hex2str(g_pars.imsi)); + f_bssap_compl_l3(l3_lu); + BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); + + f_mm_common(); + f_msc_lu_hlr(); + f_mm_imei(); + + /* Expect reject. As of writing, sometimes it passes, sometimes we get a broken pipe (race condition)! */ + alt { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { + setverdict(pass); + } + [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { + setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); + mtc.stop; + } + } +} +testcase TC_lu_imsi_auth_tmsi_check_imei_nack() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd 1"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth_tmsi_check_imei_nack), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_auth_tmsi_check_imei_err(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + var PDU_ML3_MS_NW l3_lu; + var PDU_DTAP_MT dtap_mt; + + pars.net.expect_auth := true; + pars.net.expect_imei := true; + pars.net.check_imei_error := true; + f_init_handler(pars); + + /* Cannot use f_perform_lu() as we expect a reject */ + l3_lu := f_build_lu_imsi(g_pars.imsi) + f_create_gsup_expect(hex2str(g_pars.imsi)); + f_bssap_compl_l3(l3_lu); + BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); + + f_mm_common(); + f_msc_lu_hlr(); + f_mm_imei(); + + /* Expect reject. As of writing, sometimes it passes, sometimes we get a broken pipe (race condition)! */ + alt { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { + setverdict(pass); + } + [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { + setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); + mtc.stop; + } + } +} +testcase TC_lu_imsi_auth_tmsi_check_imei_err() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd 1"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth_tmsi_check_imei_err), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_auth_tmsi_check_imei_early(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_auth := true; + pars.net.expect_imei_early := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_auth_tmsi_check_imei_early() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd early"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth_tmsi_check_imei_early), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_auth3g_tmsi_check_imei_early(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_auth := true; + pars.use_umts_aka := true; + pars.net.expect_imei_early := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_auth3g_tmsi_check_imei_early() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd early"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth3g_tmsi_check_imei_early), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_noauth_tmsi_check_imei_early(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_imei_early := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_noauth_tmsi_check_imei_early() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "msc", "check-imei-rqd early"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_noauth_tmsi_check_imei_early), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_noauth_notmsi_check_imei_early(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_tmsi := false; + pars.net.expect_imei_early := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_noauth_notmsi_check_imei_early() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "msc", "no assign-tmsi"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd early"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_noauth_notmsi_check_imei_early), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_auth_tmsi_check_imei_early_nack(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + var PDU_ML3_MS_NW l3_lu; + var PDU_DTAP_MT dtap_mt; + + pars.net.expect_auth := true; + pars.net.expect_imei_early := true; + pars.net.check_imei_result := OSMO_GSUP_IMEI_RESULT_NACK; + f_init_handler(pars); + + /* Cannot use f_perform_lu() as we expect a reject */ + l3_lu := f_build_lu_imsi(g_pars.imsi) + f_create_gsup_expect(hex2str(g_pars.imsi)); + f_bssap_compl_l3(l3_lu); + BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); + + f_mm_imei_early(); + + /* Expect reject */ + alt { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { + setverdict(pass); + } + [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { + setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); + mtc.stop; + } + } +} +testcase TC_lu_imsi_auth_tmsi_check_imei_early_nack() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd early"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth_tmsi_check_imei_early_nack), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_auth_tmsi_check_imei_early_err(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + var PDU_ML3_MS_NW l3_lu; + var PDU_DTAP_MT dtap_mt; + + pars.net.expect_auth := true; + pars.net.expect_imei_early := true; + pars.net.check_imei_error := true; + f_init_handler(pars); + + /* Cannot use f_perform_lu() as we expect a reject */ + l3_lu := f_build_lu_imsi(g_pars.imsi) + f_create_gsup_expect(hex2str(g_pars.imsi)); + f_bssap_compl_l3(l3_lu); + BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); + + f_mm_imei_early(); + + /* Expect reject */ + alt { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { + setverdict(pass); + } + [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { + setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); + mtc.stop; + } + } +} +testcase TC_lu_imsi_auth_tmsi_check_imei_early_err() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd early"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth_tmsi_check_imei_early_err), 5); + vc_conn.done; +} control { execute( TC_cr_before_reset() ); @@ -5641,6 +5927,19 @@ execute( TC_ho_inter_msc_out() ); + execute( TC_lu_imsi_auth_tmsi_check_imei() ); + execute( TC_lu_imsi_auth3g_tmsi_check_imei() ); + execute( TC_lu_imsi_noauth_tmsi_check_imei() ); + execute( TC_lu_imsi_noauth_notmsi_check_imei() ); + execute( TC_lu_imsi_auth_tmsi_check_imei_nack() ); + execute( TC_lu_imsi_auth_tmsi_check_imei_err() ); + execute( TC_lu_imsi_auth_tmsi_check_imei_early() ); + execute( TC_lu_imsi_auth3g_tmsi_check_imei_early() ); + execute( TC_lu_imsi_noauth_tmsi_check_imei_early() ); + execute( TC_lu_imsi_noauth_notmsi_check_imei_early() ); + execute( TC_lu_imsi_auth_tmsi_check_imei_early_nack() ); + execute( TC_lu_imsi_auth_tmsi_check_imei_early_err() ); + /* Run this last: at the time of writing this test crashes the MSC */ execute( TC_lu_imsi_auth_tmsi_encr_3_1_log_msc_debug() ); execute( TC_gsup_mt_multi_part_sms() ); diff --git a/msc/expected-results.xml b/msc/expected-results.xml index a60e2ec..ca8edd2 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -1,5 +1,5 @@ - + @@ -97,4 +97,20 @@ + + + + + + + + + + + + + + + + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d Gerrit-Change-Number: 14694 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 12:41:23 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 8 Jul 2019 12:41:23 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: add check IMEI tests In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 ) Change subject: msc: add check IMEI tests ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d Gerrit-Change-Number: 14694 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 08 Jul 2019 12:41:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 12:48:36 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 12:48:36 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: L3_Templates: fix IMEI length: 14 (not 15) In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14693 ) Change subject: L3_Templates: fix IMEI length: 14 (not 15) ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7121f29a90f19d92c7bf26f26e76f1978c648459 Gerrit-Change-Number: 14693 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 08 Jul 2019 12:48:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 13:01:40 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 13:01:40 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: add check IMEI tests In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 ) Change subject: msc: add check IMEI tests ...................................................................... Patch Set 2: Code-Review+1 (6 comments) https://gerrit.osmocom.org/#/c/14694/2/library/GSUP_Types.ttcn File library/GSUP_Types.ttcn: https://gerrit.osmocom.org/#/c/14694/2/library/GSUP_Types.ttcn at 544 PS2, Line 544: ) := tr_GSUP( Git friendly style itself deserves CR+1 ;) https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn at 440 PS2, Line 440: function Is this function going to be called from other modules? If no, make it private. https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn at 446 PS2, Line 446: if (not g_pars.net.expect_imei) I would rather leave it up to the caller. https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn at 452 PS2, Line 452: '010'B /* IMEI */ Would be great to have an enumerated type for that later on. https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn at 478 PS2, Line 478: function Same here. https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn at 484 PS2, Line 484: if (not g_pars.net.expect_imei_early) Same here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d Gerrit-Change-Number: 14694 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 08 Jul 2019 13:01:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 13:05:16 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 13:05:16 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: cosmetic: move TC_gsup_mt_multi_part_sms() back Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14695 Change subject: MSC_Tests.ttcn: cosmetic: move TC_gsup_mt_multi_part_sms() back ...................................................................... MSC_Tests.ttcn: cosmetic: move TC_gsup_mt_multi_part_sms() back The mentioned test case doesn't cause any problems anymore. Change-Id: Ic8d456f4becade9010d4eb27159e6c2806b11810 --- M msc/MSC_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/14695/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 4b00e34..f551513 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -5593,6 +5593,7 @@ execute( TC_gsup_mt_sms_err() ); execute( TC_gsup_mt_sms_rp_mr() ); execute( TC_gsup_mo_mt_sms_rp_mr() ); + execute( TC_gsup_mt_multi_part_sms() ); execute( TC_lu_and_mo_ussd_single_request() ); execute( TC_lu_and_mt_ussd_notification() ); @@ -5643,7 +5644,6 @@ /* Run this last: at the time of writing this test crashes the MSC */ execute( TC_lu_imsi_auth_tmsi_encr_3_1_log_msc_debug() ); - execute( TC_gsup_mt_multi_part_sms() ); execute( TC_mo_cc_bssmap_clear() ); if (mp_enable_osmux_test) { execute( TC_lu_and_mt_call_osmux() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14695 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic8d456f4becade9010d4eb27159e6c2806b11810 Gerrit-Change-Number: 14695 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 13:19:55 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Mon, 8 Jul 2019 13:19:55 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for... Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14696 Change subject: Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for rest_bits ...................................................................... Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for rest_bits The rest_bits are never read after calling this function nor are rest_bits updated properly. Change-Id: Ic350b0365b125638a6c752f692bef981ad6b9d89 --- M src/encoding.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/96/14696/1 diff --git a/src/encoding.cpp b/src/encoding.cpp index e868379..99c1018 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -830,7 +830,7 @@ static void write_packet_ack_nack_desc_egprs( bitvec * dest, unsigned& wp, - gprs_rlc_ul_window *window, bool is_final, unsigned& rest_bits) + gprs_rlc_ul_window *window, bool is_final, unsigned rest_bits) { unsigned int urbb_len = 0; uint8_t crbb_len = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14696 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic350b0365b125638a6c752f692bef981ad6b9d89 Gerrit-Change-Number: 14696 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 13:19:55 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Mon, 8 Jul 2019 13:19:55 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: ACK/NACK: always encode with length field present Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14697 Change subject: Encoding: ACK/NACK: always encode with length field present ...................................................................... Encoding: ACK/NACK: always encode with length field present In most cases the length field was present and this field takes 7 bits of the maximum available 110 rest bits. The length field was only removed when encoding huge bitmaps usually only happen on lossy connections with packet lost. However the cases without length field were encoded incorrect, because all remaining bits must be used by the uncompressed bitmaps, but the PCU violates this by encoding allways the "release 5" bit. Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb --- M src/encoding.cpp 1 file changed, 28 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/97/14697/1 diff --git a/src/encoding.cpp b/src/encoding.cpp index 99c1018..3908744 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -849,12 +849,12 @@ bitvec ucmp_vec; bitvec crbb_vec; uint8_t uclen_crbb = 0; - bool len_coded = true; uint8_t crbb_start_clr_code; uint8_t i; /* static size of 16 bits - ..0. .... = ACKNACK: (Union) + ..1. .... = ACKNACK: (Union) + 0 0000 000 Length Desc ...0 .... = FINAL_ACK_INDICATION: False @@ -865,8 +865,9 @@ .... ..10 0101 0001 1... .... = STARTING_SEQUENCE_NUMBER: 1187 - .0.. .... = CRBB Exist: 0 */ - rest_bits -= 16; + .0.. .... = CRBB Exist: 0 + minimal size is 24 rest_bits */ + rest_bits -= 24; if (num_blocks > 0) /* V(Q) is NACK and omitted -> SSN = V(Q) + 1 */ @@ -903,47 +904,31 @@ crbb_len = crbb_vec.cur_bit; } - if (is_compressed == 0) { - /* length field takes 8 bits*/ - if (num_blocks > rest_bits - 8) { - eow = false; - urbb_len = rest_bits; - len_coded = false; - } else if (num_blocks == rest_bits) { - urbb_len = rest_bits; - len_coded = false; - } else - urbb_len = num_blocks; - len = urbb_len + 15; + if (is_compressed) { + /* 8 = 7 (CRBBlength) + 1 (CRBB starting color code) */ + rest_bits -= 8; } else { - if (num_blocks > uclen_crbb) { - eow = false; - urbb_len = num_blocks - uclen_crbb; - } - /* Union bit takes 1 bit */ - /* Other fields in descr of compresed bitmap takes 23 bits - * -8 = CRBB_STARTING_COLOR_CODE + CRBB_LENGTH */ - if (urbb_len > (rest_bits - crbb_len - 8)) { - eow = false; - len_coded = false; - urbb_len = rest_bits - crbb_len - 8; - /* -16 = ACKNACK Dissector length + CRBB_STARTING_COLOR_CODE + CRBB_LENGTH */ - } else if (urbb_len > (rest_bits - crbb_len - 16)) { - eow = false; - len_coded = false; - urbb_len = rest_bits - crbb_len - 16; - } + uclen_crbb = 0; + crbb_len = 0; + } + + if (num_blocks > uclen_crbb + rest_bits) { + eow = false; + urbb_len = rest_bits - crbb_len; + } else + urbb_len = num_blocks - uclen_crbb; + + if (is_compressed) len = urbb_len + crbb_len + 23; - } + else + len = urbb_len + 15; - /* EGPRS Ack/Nack Description IE */ - if (len_coded == false) { - bitvec_write_field(dest, &wp, 0, 1); // 0: don't have length - } else { - bitvec_write_field(dest, &wp, 1, 1); // 1: have length - bitvec_write_field(dest, &wp, len, 8); // length - } + + /* EGPRS Ack/Nack Description IE + * do not support Ack/Nack without length */ + bitvec_write_field(dest, &wp, 1, 1); // 1: have length + bitvec_write_field(dest, &wp, len, 8); // length bitvec_write_field(dest, &wp, is_final, 1); // FINAL_ACK_INDICATION bitvec_write_field(dest, &wp, bow, 1); // BEGINNING_OF_WINDOW @@ -973,9 +958,9 @@ } LOGP(DRLCMACUL, LOGL_DEBUG, "EGPRS URBB, urbb len = %d, SSN = %d, ESN_CRBB = %d, " - "len present = %s,desc len = %d, " + "desc len = %d, " "SNS = %d, WS = %d, V(Q) = %d, V(R) = %d%s%s\n", - urbb_len, ssn, esn_crbb, len_coded ? "yes" : "No" , len, + urbb_len, ssn, esn_crbb, len, window->sns(), window->ws(), window->v_q(), window->v_r(), bow ? ", BOW" : "", eow ? ", EOW" : ""); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb Gerrit-Change-Number: 14697 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 13:20:13 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Jul 2019 13:20:13 +0000 Subject: Change in ...osmo-python-tests[master]: tweak README Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/14698 Change subject: tweak README ...................................................................... tweak README Most importantly, mention 'python3 setup.py'. Tweak indenting and some wording. Change-Id: Id8c277de280b54d04edcafa77ed93017d6da473d --- M README 1 file changed, 15 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/98/14698/1 diff --git a/README b/README index 69eb764..dbb8d88 100644 --- a/README +++ b/README @@ -1,11 +1,20 @@ Building/installation: -sudo python setup.py install + + sudo python setup.py install + sudo python3 setup.py install + If you prefer to have it cleanly removable, install checkinstall and run -sudo checkinstall python setup.py install -Alternatively, just run 'pip install --user -e ./' or 'pip3 install --user -e ./' + + sudo checkinstall python setup.py install + +Alternatively, just run + + pip install --user -e ./ + pip3 install --user -e ./ + depending on your python version. -Use +Use: There are currently following scripts in this package: osmotestconfig.py - test that apps start/write with example configs soap.py - implementation of SOAP <-> Ctrl proxy implemented on top of Twisted (deprecated, unmaintained) @@ -20,8 +29,9 @@ osmodumpdoc.py - dump documentation, superseded by osmo_interact_vty.py -X osmotestvty.py - test vty operations, superseded by osmo_verify_transcript_vty.py -Each of these scripts imports a project-specific osmoappdesc.py, +Some of these scripts import a project-specific osmoappdesc.py, which provides information about the available apps, configs, vty ports, etc. +and is provided by other source trees (like osmo-bsc.git, osmo-msc.git, ...) Run the scripts with osmoappdesc.py in the current directory (preferred) or with -p . -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/14698 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: Id8c277de280b54d04edcafa77ed93017d6da473d Gerrit-Change-Number: 14698 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 13:22:05 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 8 Jul 2019 13:22:05 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: add check IMEI tests In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 ) Change subject: msc: add check IMEI tests ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/#/c/14694/2/library/GSUP_Types.ttcn File library/GSUP_Types.ttcn: https://gerrit.osmocom.org/#/c/14694/2/library/GSUP_Types.ttcn at 544 PS2, Line 544: ) := tr_GSUP( > Git friendly style itself deserves CR+1 ;) :D https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn at 440 PS2, Line 440: function > Is this function going to be called from other modules? If no, make it private. Yes, f_tc_lu_imsi_auth_tmsi_check_imei_nack() calls it directly. It can't use f_perform_lu(), because it expects a reject. https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn at 446 PS2, Line 446: if (not g_pars.net.expect_imei) > I would rather leave it up to the caller. I chose to do it that way, because f_mm_auth() works the same way, and also lots of code above has "if (g_pars...)" conditions inside the functions, instead of letting the caller (f_perform_lu() and tests that simulate failing LU and call f_mm_* directly) decide if the function should be called at all, or which parts of it. So I guess it was done in the other functions to have failing location update tests less verbose. But both is fine with me, if you insist on this, then I will change it. https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn at 478 PS2, Line 478: function > Same here. f_tc_lu_imsi_auth_tmsi_check_imei_early_nack() calls it directly. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d Gerrit-Change-Number: 14694 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 08 Jul 2019 13:22:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 13:23:03 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Jul 2019 13:23:03 +0000 Subject: Change in ...osmo-bsc[master]: doc/manuals, vty doc: more handover doc clarifications In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/14582 to look at the new patch set (#2). Change subject: doc/manuals, vty doc: more handover doc clarifications ...................................................................... doc/manuals, vty doc: more handover doc clarifications Related: OS#3487 Change-Id: I1639efb2dbcca4f0e9c33a74f3067606ce5f4209 --- M doc/manuals/chapters/handover.adoc M include/osmocom/bsc/handover_cfg.h M src/osmo-bsc/handover_vty.c M tests/handover_cfg.vty 4 files changed, 55 insertions(+), 49 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/82/14582/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1639efb2dbcca4f0e9c33a74f3067606ce5f4209 Gerrit-Change-Number: 14582 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 13:23:46 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Mon, 8 Jul 2019 13:23:46 +0000 Subject: Change in ...libosmocore[master]: utils.h: require a semi colon after OSMO_ASSERT In-Reply-To: References: Message-ID: lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14578 ) Change subject: utils.h: require a semi colon after OSMO_ASSERT ...................................................................... utils.h: require a semi colon after OSMO_ASSERT When using `OSMO_ASSERT(exp);` clang will warn about an empty expression because the semi colon was superflous. Use do {} while (0) to enfore the need of a semi colon. This might break other test. Change-Id: I2272d29a81496164bebd1696a694383a28a86434 --- M include/osmocom/core/utils.h M src/gsm/gsm0808_utils.c M tests/ctrl/ctrl_test.c 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h index 601bb56..8585a6a 100644 --- a/include/osmocom/core/utils.h +++ b/include/osmocom/core/utils.h @@ -98,9 +98,9 @@ * the predicate evaluates to false (0). */ #define OSMO_ASSERT(exp) \ - if (!(exp)) { \ + do if (!(exp)) { \ osmo_panic("Assert failed %s %s:%d\n", #exp, __FILE__, __LINE__); \ - } + } while(0) /*! duplicate a string using talloc and release its prior content (if any) * \param[in] ctx Talloc context to use for allocation diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c index afff59a..364a04f 100644 --- a/src/gsm/gsm0808_utils.c +++ b/src/gsm/gsm0808_utils.c @@ -273,7 +273,7 @@ case GSM0808_SCT_FR5: case GSM0808_SCT_HR4: case GSM0808_SCT_CSD: - OSMO_ASSERT((sc->cfg & 0xff00) == 0) + OSMO_ASSERT((sc->cfg & 0xff00) == 0); msgb_put_u8(msg, (uint8_t) sc->cfg & 0xff); break; default: @@ -874,7 +874,7 @@ msgb_put_u8(msg, cil->id_discr & 0x0f); - OSMO_ASSERT(cil->id_list_len <= GSM0808_CELL_ID_LIST2_MAXLEN) + OSMO_ASSERT(cil->id_list_len <= GSM0808_CELL_ID_LIST2_MAXLEN); for (i = 0; i < cil->id_list_len; i++) gsm0808_msgb_put_cell_id_u(msg, cil->id_discr, &cil->id_list[i]); @@ -906,7 +906,7 @@ switch (cil->id_discr) { case CELL_IDENT_LAC: - OSMO_ASSERT(cil->id_list_len <= CELL_ID_LIST_LAC_MAXLEN) + OSMO_ASSERT(cil->id_list_len <= CELL_ID_LIST_LAC_MAXLEN); for (i=0;iid_list_len;i++) { msgb_put_u16(msg, cil->id_list_lac[i]); } diff --git a/tests/ctrl/ctrl_test.c b/tests/ctrl/ctrl_test.c index cffb803..b46e9ac 100644 --- a/tests/ctrl/ctrl_test.c +++ b/tests/ctrl/ctrl_test.c @@ -121,7 +121,7 @@ printf("replied: '%s'\n", osmo_escape_str((char*)msgb_l2(sent_msg), -1)); OSMO_ASSERT(t->reply_str); - OSMO_ASSERT(!strcmp(t->reply_str, (char*)msgb_l2(sent_msg))) + OSMO_ASSERT(!strcmp(t->reply_str, (char*)msgb_l2(sent_msg))); msgb_free(sent_msg); } osmo_wqueue_clear(&ccon->write_queue); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2272d29a81496164bebd1696a694383a28a86434 Gerrit-Change-Number: 14578 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 13:23:47 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Jul 2019 13:23:47 +0000 Subject: Change in ...osmo-bsc[master]: make bsc_clear_request() static Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14699 Change subject: make bsc_clear_request() static ...................................................................... make bsc_clear_request() static bsc_clear_request() is in fact used only within gsm_08_08.c, make it static to that file. Since the gscon FSM, "real" BSSMAP Clear are sent only by gscon_bssmap_clear(). bsc_clear_request() remains in use for legacy code paths in gsm_08_08.c: - the bsc_filter, i.e. for IMSI filtering; - in move_to_msc(), from handle_cc_setup(), a code path that is in fact not entirely clear to me. It seems to be an old functionality to serve multiple MSCs? Both of which I personally haven't seen in use, are not tested and should probably be completely removed. For now contain legacy code in the static context. Adjust comment. Change-Id: Ic89d0afad42e4b11183a13d2dc6b7bbf0b822fd9 --- M include/osmocom/bsc/gsm_08_08.h M src/osmo-bsc/gsm_08_08.c M tests/bsc/bsc_test.c M tests/handover/handover_test.c 4 files changed, 4 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/99/14699/1 diff --git a/include/osmocom/bsc/gsm_08_08.h b/include/osmocom/bsc/gsm_08_08.h index 5241295..b46a8d3 100644 --- a/include/osmocom/bsc/gsm_08_08.h +++ b/include/osmocom/bsc/gsm_08_08.h @@ -10,7 +10,6 @@ void bsc_cipher_mode_compl(struct gsm_subscriber_connection *conn, struct msgb *msg, uint8_t chosen_encr); int bsc_compl_l3(struct gsm_subscriber_connection *conn, struct msgb *msg, uint16_t chosen_channel); void bsc_dtap(struct gsm_subscriber_connection *conn, uint8_t link_id, struct msgb *msg); -int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause); void bsc_cm_update(struct gsm_subscriber_connection *conn, const uint8_t *cm2, uint8_t cm2_len, const uint8_t *cm3, uint8_t cm3_len); diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c index 2c6a689..6ca5455 100644 --- a/src/osmo-bsc/gsm_08_08.c +++ b/src/osmo-bsc/gsm_08_08.c @@ -509,6 +509,8 @@ return false; } +static int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause); + /* * Plastic surgery... we want to give up the current connection */ @@ -635,8 +637,8 @@ return; } -/*! BSC->MSC: RR conn has been cleared. */ -int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause) +/*! BSSMAP Clear Request for legacy code paths, instead see gscon_bssmap_clear(). */ +static int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause) { int rc; struct msgb *resp; diff --git a/tests/bsc/bsc_test.c b/tests/bsc/bsc_test.c index 8e88ba8..492f0c5 100644 --- a/tests/bsc/bsc_test.c +++ b/tests/bsc/bsc_test.c @@ -243,8 +243,6 @@ void bsc_dtap(struct gsm_subscriber_connection *conn, uint8_t link_id, struct msgb *msg) {} void bsc_assign_compl(struct gsm_subscriber_connection *conn, uint8_t rr_cause) {} void bsc_assign_fail(struct gsm_subscriber_connection *conn, uint8_t cause, uint8_t *rr_cause) {} -int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause) -{ return 0; } void bsc_cm_update(struct gsm_subscriber_connection *conn, const uint8_t *cm2, uint8_t cm2_len, const uint8_t *cm3, uint8_t cm3_len) {} diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index a8a77be..bedf6f9 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -1779,8 +1779,6 @@ { return 0; } void bsc_dtap(struct gsm_subscriber_connection *conn, uint8_t link_id, struct msgb *msg) {} void bsc_assign_compl(struct gsm_subscriber_connection *conn, uint8_t rr_cause) {} -int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause) -{ return 0; } void bsc_cm_update(struct gsm_subscriber_connection *conn, const uint8_t *cm2, uint8_t cm2_len, const uint8_t *cm3, uint8_t cm3_len) {} -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic89d0afad42e4b11183a13d2dc6b7bbf0b822fd9 Gerrit-Change-Number: 14699 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 15:27:36 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 8 Jul 2019 15:27:36 +0000 Subject: Change in ...osmo-mgw[master]: doc: Document X-Osmux extension In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14681 ) Change subject: doc: Document X-Osmux extension ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14681/1/doc/manuals/chapters/mgcp_extensions.adoc File doc/manuals/chapters/mgcp_extensions.adoc: https://gerrit.osmocom.org/#/c/14681/1/doc/manuals/chapters/mgcp_extensions.adoc at 73 PS1, Line 73: endpoint has to be configured in order to handle Osmux frames instead of RTP s/has to be/can be/ ? If the other side ignores it osmux support stays disabled, right? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 Gerrit-Change-Number: 14681 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 08 Jul 2019 15:27:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 16:41:14 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 16:41:14 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: use uint16_t when interacting with the window object In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14571 ) Change subject: Encoding: use uint16_t when interacting with the window object ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/14571/2/src/encoding.cpp File src/encoding.cpp: https://gerrit.osmocom.org/#/c/14571/2/src/encoding.cpp at 975 PS2, Line 975: ESN_CRBB = %d ... and here too. https://gerrit.osmocom.org/#/c/14571/2/src/encoding.cpp at 975 PS2, Line 975: SSN = %d You need %u here now. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If62fa09d7bfa8e91ce707824f7019edb1b83da9e Gerrit-Change-Number: 14571 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 08 Jul 2019 16:41:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 16:44:03 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 16:44:03 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14696 ) Change subject: Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for rest_bits ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14696 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic350b0365b125638a6c752f692bef981ad6b9d89 Gerrit-Change-Number: 14696 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 08 Jul 2019 16:44:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 16:53:02 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 8 Jul 2019 16:53:02 +0000 Subject: Change in ...osmo-bsc[master]: remove double BSSMAP Clear on HO failure Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14700 Change subject: remove double BSSMAP Clear on HO failure ...................................................................... remove double BSSMAP Clear on HO failure If a handover fails when the new lchan is already fully established, osmo-bsc so far caused two BSSMAP Clear Requests to be sent out to the MSC: one caused by detaching the lchan from the gscon, one from returning the gscon back to ST_ACTIVE, which detects that no lchan is present and Clears. In fact only one of those is necessary. Checking for the presence of an lchan when entering ST_ACTIVE is an earlier attempt to catch insane situations. Since then, osmo-bsc has acquired other logic that will ensure sending a Clear Request in all cases, see gscon_forget_lchan(). Sending another BSSMAP Clear Request in ST_ACTIVE's onenter is simply not necessary. Drop gscon_fsm_active_onenter() entirely. Note: the double Clear Request is currently hit by TC_ho_out_fail_no_ho_detect(), which currently fails and will pass again after this patch; however, osmo-bsc should actually not release the lchan at all during this test, see OS#4093. In other words, osmo-bsc behavior for this scenario as well as TC_ho_out_fail_no_ho_detect() need to be changed, and the test will, once fixed, not be useful to trigger this issue anymore. Related: OS#4078 Change-Id: Iac1519eb8b24e8523caec682f9ac8e6dcf1327ce --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 0 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/00/14700/1 diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index bc5cb27..f8784f9 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -343,13 +343,6 @@ } } -static void gscon_fsm_active_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) -{ - struct gsm_subscriber_connection *conn = fi->priv; - if (!conn->lchan) - gscon_bssmap_clear(conn, GSM0808_CAUSE_EQUIPMENT_FAILURE); -} - /* We're on an active subscriber connection, passing DTAP back and forth */ static void gscon_fsm_active(struct osmo_fsm_inst *fi, uint32_t event, void *data) { @@ -605,7 +598,6 @@ S(GSCON_EV_HANDOVER_START), .out_state_mask = S(ST_CLEARING) | S(ST_ASSIGNMENT) | S(ST_HANDOVER), - .onenter = gscon_fsm_active_onenter, .action = gscon_fsm_active, }, [ST_ASSIGNMENT] = { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14700 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iac1519eb8b24e8523caec682f9ac8e6dcf1327ce Gerrit-Change-Number: 14700 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 17:14:27 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 17:14:27 +0000 Subject: Change in ...libosmocore[master]: utils.h: require a semi colon after OSMO_ASSERT In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14578 ) Change subject: utils.h: require a semi colon after OSMO_ASSERT ...................................................................... Patch Set 4: This commit breaks some builds: https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-msc/1783/IU=--disable-iu,WITH_MANUALS=1,a3=default,a4=default,label=osmocom-gerrit-debian9/console -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14578 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2272d29a81496164bebd1696a694383a28a86434 Gerrit-Change-Number: 14578 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: fixeria Gerrit-Comment-Date: Mon, 08 Jul 2019 17:14:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 17:35:11 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 17:35:11 +0000 Subject: Change in ...osmo-msc[master]: libmsc/msc_vty.c: print subscriber expiration time Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14701 Change subject: libmsc/msc_vty.c: print subscriber expiration time ...................................................................... libmsc/msc_vty.c: print subscriber expiration time Change-Id: I092691a8c443f4c5ed4d33de2e551fef592c1baf --- M src/libmsc/msc_vty.c 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/01/14701/1 diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index 8a976cb..c75cd0e 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -791,6 +791,8 @@ static void vty_dump_one_subscr(struct vty *vty, struct vlr_subscr *vsub, int offset, uint8_t dump_flags) { + struct gsm_network *net; + struct timespec now; char buf[128]; if (vsub->name[0] != '\0') { @@ -863,6 +865,21 @@ VTY_NEWLINE); } + /* XXX move t3212 into struct vlr_instance? */ + net = vsub->vlr->user_ctx; + if (!net->t3212) { + MSC_VTY_DUMP(vty, offset, "Expires: never (T3212 is disabled)%s", + VTY_NEWLINE); + } else if (vsub->expire_lu == VLR_SUBSCRIBER_NO_EXPIRATION) { + MSC_VTY_DUMP(vty, offset, "Expires: never%s", + VTY_NEWLINE); + } else if (osmo_clock_gettime(CLOCK_MONOTONIC, &now) == 0) { + MSC_VTY_DUMP(vty, offset, "Expires: in %ld min %ld sec%s", + (vsub->expire_lu - now.tv_sec) / 60, + (vsub->expire_lu - now.tv_sec) % 60, + VTY_NEWLINE); + } + MSC_VTY_DUMP(vty, offset, "Paging: %s paging for %d requests%s", vsub->cs.is_paging ? "is" : "not", llist_count(&vsub->cs.requests), -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14701 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I092691a8c443f4c5ed4d33de2e551fef592c1baf Gerrit-Change-Number: 14701 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 8 17:40:55 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 8 Jul 2019 17:40:55 +0000 Subject: Change in ...osmo-msc[master]: Fix: add missing commas to OSMO_ASSERT statements Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14702 Change subject: Fix: add missing commas to OSMO_ASSERT statements ...................................................................... Fix: add missing commas to OSMO_ASSERT statements Since I2272d29a81496164bebd1696a694383a28a86434, the OSMO_ASSERT statement needs to be terminated with a coma. Let's fix this. Change-Id: I4fae5fbab5fdbcce35906601d4f1031d971f4931 --- M src/libmsc/ran_peer.c M tests/msc_vlr/msc_vlr_tests.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/02/14702/1 diff --git a/src/libmsc/ran_peer.c b/src/libmsc/ran_peer.c index ce26794..77740a0 100644 --- a/src/libmsc/ran_peer.c +++ b/src/libmsc/ran_peer.c @@ -370,7 +370,7 @@ case RAN_PEER_EV_MSG_UP_CO_INITIAL: ctx = data; - OSMO_ASSERT(ctx) + OSMO_ASSERT(ctx); OSMO_ASSERT(!ctx->conn); OSMO_ASSERT(ctx->msg); diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c index 488cd19..35401ba 100644 --- a/tests/msc_vlr/msc_vlr_tests.c +++ b/tests/msc_vlr/msc_vlr_tests.c @@ -171,7 +171,7 @@ count = osmo_use_count_by(&msc_a->use_count, cm_service_use); OSMO_ASSERT(count > 0); - OSMO_ASSERT(osmo_use_count_get_put(&msc_a->use_count, cm_service_use, -count) == 0) + OSMO_ASSERT(osmo_use_count_get_put(&msc_a->use_count, cm_service_use, -count) == 0); ASSERT_RELEASE_CLEAR(msc_a->c.ran->type); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4fae5fbab5fdbcce35906601d4f1031d971f4931 Gerrit-Change-Number: 14702 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Tue Jul 9 02:32:24 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:32:24 +0000 Subject: Build failure of network:osmocom:nightly/rtl-sdr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fcbe6a4b5_3358c4860060360@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/rtl-sdr/Debian_Unstable/x86_64 Package network:osmocom:nightly/rtl-sdr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly rtl-sdr Last lines of build log: [ 8s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 8s] booting kvm... [ 8s] ### VM INTERACTION START ### [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 4.12.14-lp151.28.[ 3.137869] sysrq: SysRq : Changing Loglevel [ 13s] 4-default #1 SMP[ 3.139255] sysrq: Loglevel set to 4 [ 13s] Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 13s] Increasing log level from now on... [ 13s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] [ 13s] failed "build rtl-sdr_0.5.4.12.f68b.dsc" at Tue Jul 9 02:32:09 UTC 2019. [ 13s] [ 13s] ### VM INTERACTION START ### [ 16s] [ 6.196885] sysrq: SysRq : Power Off [ 16s] [ 6.203263] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] sheep81 failed "build rtl-sdr_0.5.4.12.f68b.dsc" at Tue Jul 9 02:32:13 UTC 2019. [ 16s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:32:24 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:32:24 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-dsp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fcbee1200_3358c486006037dc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-dsp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libosmo-dsp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-dsp Last lines of build log: [ 9s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 4[ 3.083588] sysrq: SysRq : Changing Loglevel [ 14s] .12.14-lp151.28.[ 3.085231] sysrq: Loglevel set to 4 [ 14s] 4-default #1 SMP Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 14s] Increasing log level from now on... [ 14s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 14s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 14s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 14s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 14s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 14s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 14s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 14s] [ 14s] failed "build libosmodsp_0.4.0.dsc" at Tue Jul 9 02:32:10 UTC 2019. [ 14s] [ 14s] ### VM INTERACTION START ### [ 17s] [ 6.140678] sysrq: SysRq : Power Off [ 17s] [ 6.147565] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] sheep84 failed "build libosmodsp_0.4.0.dsc" at Tue Jul 9 02:32:14 UTC 2019. [ 17s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:32:24 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:32:24 +0000 Subject: Build failure of network:osmocom:nightly/orcania in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fcbe16e31_3358c4860060358d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/orcania/Debian_Unstable/x86_64 Package network:osmocom:nightly/orcania failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly orcania Last lines of build log: [ 9s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 14s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 14s] 2nd stage started in virtual machine [ 14s] machine type: x86_64 [ 14s] Linux version: 4[ 3.556972] sysrq: SysRq : Changing Loglevel [ 14s] [ 3.558493] sysrq: Loglevel set to 4 [ 14s] .12.14-lp151.28.4-default #1 SMP Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 14s] Increasing log level from now on... [ 14s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 14s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 14s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 14s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 14s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 14s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 14s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 14s] [ 14s] failed "build orcania_1.2.9-5.dsc" at Tue Jul 9 02:32:08 UTC 2019. [ 14s] [ 14s] ### VM INTERACTION START ### [ 17s] [ 6.629907] sysrq: SysRq : Power Off [ 17s] [ 6.634466] reboot: Power down [ 17s] ### VM INTERACTION END ### [ 17s] [ 17s] sheep83 failed "build orcania_1.2.9-5.dsc" at Tue Jul 9 02:32:11 UTC 2019. [ 17s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:32:24 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:32:24 +0000 Subject: Build failure of network:osmocom:nightly/osmocom-nightly in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fcbdbdcfd_3358c4860060347c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmocom-nightly/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmocom-nightly failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmocom-nightly Last lines of build log: [ 11s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 4[ 3.847956] sysrq: SysRq : Changing Loglevel [ 17s] .12.14-1.g2114e9[ 3.849302] sysrq: Loglevel set to 4 [ 17s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 17s] Increasing log level from now on... [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] [ 17s] failed "build osmocom-nightly_0.0.0.20190709.dsc" at Tue Jul 9 02:32:06 UTC 2019. [ 17s] [ 17s] ### VM INTERACTION START ### [ 20s] [ 6.930517] sysrq: SysRq : Power Off [ 20s] [ 6.937533] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb01 failed "build osmocom-nightly_0.0.0.20190709.dsc" at Tue Jul 9 02:32:11 UTC 2019. [ 21s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:32:25 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:32:25 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fcbf5f533_3358c486006038e7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_Unstable/x86_64 Package network:osmocom:nightly/libosmocore failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 20s] Increasing log level from now on... [ 20s] [ 5.396707] sysrq: SysRq : Changing Loglevel [ 20s] [ 5.397567] sysrq: Loglevel set to 4 [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] [ 20s] failed "build libosmocore_1.1.0.76.4e28.dsc" at Tue Jul 9 02:32:13 UTC 2019. [ 20s] [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.505741] sysrq: SysRq : Power Off [ 23s] [ 8.513913] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb19 failed "build libosmocore_1.1.0.76.4e28.dsc" at Tue Jul 9 02:32:17 UTC 2019. [ 23s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:32:25 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:32:25 +0000 Subject: Build failure of network:osmocom:nightly/libasn1c in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fcbfcd2e7_3358c4860060395c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libasn1c/Debian_Unstable/x86_64 Package network:osmocom:nightly/libasn1c failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libasn1c Last lines of build log: [ 14s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 2200 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 16s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 24s] machine type: x86_64 [ 24s] Linux version: 4.12.14-lp151.28.4-default #1 SMP Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 24s] Increasing log l[ 7.571768] sysrq: SysRq : Changing Loglevel [ 24s] [ 7.572407] sysrq: Loglevel set to 4 [ 24s] evel from now on... [ 24s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 24s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 24s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 24s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 24s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 24s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 24s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 24s] [ 24s] failed "build libasn1c_0.9.31.3.5e00.dsc" at Tue Jul 9 02:32:16 UTC 2019. [ 24s] [ 24s] ### VM INTERACTION START ### [ 27s] [ 10.837456] sysrq: SysRq : Power Off [ 27s] [ 10.848837] reboot: Power down [ 27s] ### VM INTERACTION END ### [ 27s] [ 27s] build31 failed "build libasn1c_0.9.31.3.5e00.dsc" at Tue Jul 9 02:32:19 UTC 2019. [ 27s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:32:25 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:32:25 +0000 Subject: Build failure of network:osmocom:nightly/libgtpnl in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fcc0281a9_3358c4860060403e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/Debian_Unstable/x86_64 Package network:osmocom:nightly/libgtpnl failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: [ 13s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 4[ 4.593030] sysrq: SysRq : Changing Loglevel [ 20s] .12.14-1.g2114e9[ 4.594130] sysrq: Loglevel set to 4 [ 20s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 20s] Increasing log level from now on... [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] [ 20s] failed "build libgtpnl_1.2.0.1.bc71.dsc" at Tue Jul 9 02:32:15 UTC 2019. [ 20s] [ 20s] ### VM INTERACTION START ### [ 23s] [ 7.678306] sysrq: SysRq : Power Off [ 23s] [ 7.684312] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb58 failed "build libgtpnl_1.2.0.1.bc71.dsc" at Tue Jul 9 02:32:20 UTC 2019. [ 23s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:32:25 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:32:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-fl2k in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fcc076d1d_3358c486006041a8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-fl2k/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-fl2k failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-fl2k Last lines of build log: [ 13s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 15s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 4[ 4.847222] sysrq: SysRq : Changing Loglevel [ 20s] .12.14-1.g2114e9[ 4.849024] sysrq: Loglevel set to 4 [ 20s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 20s] Increasing log level from now on... [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] [ 20s] failed "build osmo-fl2k_0.1.1.12.df33.dsc" at Tue Jul 9 02:32:16 UTC 2019. [ 20s] [ 20s] ### VM INTERACTION START ### [ 23s] [ 7.962927] sysrq: SysRq : Power Off [ 23s] [ 7.967832] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb25 failed "build osmo-fl2k_0.1.1.12.df33.dsc" at Tue Jul 9 02:32:20 UTC 2019. [ 23s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:32:25 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:32:25 +0000 Subject: Build failure of network:osmocom:nightly/libsmpp34 in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fcc0e801f_3358c48600604219@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/Debian_Unstable/x86_64 Package network:osmocom:nightly/libsmpp34 failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libsmpp34 Last lines of build log: [ 14s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_12/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_12/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_12/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 15s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 4[ 4.354310] sysrq: SysRq : Changing Loglevel [ 20s] .12.14-1.g2114e9[ 4.355302] sysrq: Loglevel set to 4 [ 20s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 20s] Increasing log level from now on... [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] [ 20s] failed "build libsmpp34_1.13.0.5.6b36.dsc" at Tue Jul 9 02:32:18 UTC 2019. [ 20s] [ 20s] ### VM INTERACTION START ### [ 23s] [ 7.458192] sysrq: SysRq : Power Off [ 23s] [ 7.463583] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb28 failed "build libsmpp34_1.13.0.5.6b36.dsc" at Tue Jul 9 02:32:23 UTC 2019. [ 24s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:32:41 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:32:41 +0000 Subject: Build failure of network:osmocom:nightly/limesuite in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fcdace2ce_3358c48600604479@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/limesuite/Debian_Unstable/x86_64 Package network:osmocom:nightly/limesuite failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly limesuite Last lines of build log: [ 17s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 17s] booting kvm... [ 18s] ### VM INTERACTION START ### [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 19s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 25s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 25s] 2nd stage started in virtual machine [ 25s] machine type: x86_64 [ 25s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29[ 5.518419] sysrq: SysRq : Changing Loglevel [ 25s] :36 UTC 2019 (21[ 5.519995] sysrq: Loglevel set to 4 [ 25s] 14e94) [ 25s] Increasing log level from now on... [ 25s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 25s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 25s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 25s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 25s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 25s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 25s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 25s] [ 25s] failed "build limesuite_19.04.0-1.dsc" at Tue Jul 9 02:32:28 UTC 2019. [ 25s] [ 25s] ### VM INTERACTION START ### [ 28s] [ 8.663146] sysrq: SysRq : Power Off [ 28s] [ 8.670588] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] lamb61 failed "build limesuite_19.04.0-1.dsc" at Tue Jul 9 02:32:32 UTC 2019. [ 28s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:32:41 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:32:41 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fcda6ff22_3358c486006043f6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 17s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8000 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 19s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 25s] machine type: x86_64 [ 25s] Linux version: 4[ 5.579358] sysrq: SysRq : Changing Loglevel [ 25s] [ 5.580212] sysrq: Loglevel set to 4 [ 25s] .12.14-lp151.28.4-default #1 SMP Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 25s] Increasing log level from now on... [ 25s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 25s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 25s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 25s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 25s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 25s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 25s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 25s] [ 25s] failed "build osmo-python-tests_0.0.9.20190708.dsc" at Tue Jul 9 02:32:28 UTC 2019. [ 25s] [ 25s] ### VM INTERACTION START ### [ 28s] [ 8.824139] sysrq: SysRq : Power Off [ 28s] [ 8.835310] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] morla5 failed "build osmo-python-tests_0.0.9.20190708.dsc" at Tue Jul 9 02:32:31 UTC 2019. [ 28s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:36:41 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:36:41 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-abis in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fdca40780_3358c48600605028@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Debian_Unstable/x86_64 Package network:osmocom:nightly/libosmo-abis failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-abis Last lines of build log: [ 8s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 7250 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 3 [ 10s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 4.12.14-1.g2114e9[ 3.156943] sysrq: SysRq : Changing Loglevel [ 13s] [ 3.158512] sysrq: Loglevel set to 4 [ 13s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 13s] Increasing log level from now on... [ 13s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] [ 13s] failed "build libosmo-abis_0.6.0.10.6eb1.dsc" at Tue Jul 9 02:36:29 UTC 2019. [ 13s] [ 13s] ### VM INTERACTION START ### [ 16s] [ 6.221309] sysrq: SysRq : Power Off [ 16s] [ 6.228566] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] build84 failed "build libosmo-abis_0.6.0.10.6eb1.dsc" at Tue Jul 9 02:36:32 UTC 2019. [ 16s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:36:58 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:36:58 +0000 Subject: Build failure of network:osmocom:nightly/libasn1c in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fde435380_3358c4860060516b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libasn1c/Debian_Unstable/x86_64 Package network:osmocom:nightly/libasn1c failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libasn1c Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 4[ 4.316713] sysrq: SysRq : Changing Loglevel [ 19s] .12.14-1.g2114e9[ 4.317779] sysrq: Loglevel set to 4 [ 19s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 19s] Increasing log level from now on... [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] [ 19s] failed "build libasn1c_0.9.31.3.5e00.dsc" at Tue Jul 9 02:36:39 UTC 2019. [ 19s] [ 19s] ### VM INTERACTION START ### [ 22s] [ 7.421865] sysrq: SysRq : Power Off [ 22s] [ 7.445190] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb10 failed "build libasn1c_0.9.31.3.5e00.dsc" at Tue Jul 9 02:36:43 UTC 2019. [ 22s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:36:58 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:36:58 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fde47bf85_3358c486006052b9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 9s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 4.12.14-lp151.28.4-default #1 SMP Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 13s] Increasing log level from now on... [ 13s] [ 3.143450] sysrq: SysRq : Changing Loglevel [ 13s] [ 3.144582] sysrq: Loglevel set to 4 [ 13s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] [ 13s] failed "build osmo-python-tests_0.0.9.20190709.dsc" at Tue Jul 9 02:36:40 UTC 2019. [ 13s] [ 13s] ### VM INTERACTION START ### [ 16s] [ 6.204739] sysrq: SysRq : Power Off [ 16s] [ 6.211627] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] sheep82 failed "build osmo-python-tests_0.0.9.20190709.dsc" at Tue Jul 9 02:36:43 UTC 2019. [ 16s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:36:58 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:36:58 +0000 Subject: Build failure of network:osmocom:nightly/libsmpp34 in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fde4e4865_3358c48600605367@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libsmpp34/Debian_Unstable/x86_64 Package network:osmocom:nightly/libsmpp34 failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libsmpp34 Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 4[ 4.951167] sysrq: SysRq : Changing Loglevel [ 20s] .12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 20s] Increasing log level from now on... [ 20s] [ 4.957959] sysrq: Loglevel set to 4 [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] [ 20s] failed "build libsmpp34_1.13.0.5.6b36.dsc" at Tue Jul 9 02:36:42 UTC 2019. [ 20s] [ 20s] ### VM INTERACTION START ### [ 23s] [ 8.042441] sysrq: SysRq : Power Off [ 23s] [ 8.050184] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb15 failed "build libsmpp34_1.13.0.5.6b36.dsc" at Tue Jul 9 02:36:46 UTC 2019. [ 23s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:36:58 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:36:58 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-dsp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fde557f2c_3358c48600605452@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-dsp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libosmo-dsp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-dsp Last lines of build log: [ 13s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 15s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 4[ 4.647807] sysrq: SysRq : Changing Loglevel [ 21s] .12.14-1.g2114e9[ 4.649268] sysrq: Loglevel set to 4 [ 21s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 21s] Increasing log level from now on... [ 21s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] [ 21s] failed "build libosmodsp_0.4.0.dsc" at Tue Jul 9 02:36:44 UTC 2019. [ 21s] [ 21s] ### VM INTERACTION START ### [ 24s] [ 7.723349] sysrq: SysRq : Power Off [ 24s] [ 7.735523] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb25 failed "build libosmodsp_0.4.0.dsc" at Tue Jul 9 02:36:49 UTC 2019. [ 24s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:36:58 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:36:58 +0000 Subject: Build failure of network:osmocom:nightly/libgtpnl in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fde5a87c5_3358c486006055cf@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libgtpnl/Debian_Unstable/x86_64 Package network:osmocom:nightly/libgtpnl failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libgtpnl Last lines of build log: [ 15s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 17s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 22s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 22s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 4.12.14-1.g2114e9[ 4.716128] sysrq: SysRq : Changing Loglevel [ 22s] 4-default #1 SMP[ 4.717741] sysrq: Loglevel set to 4 [ 22s] Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 22s] Increasing log level from now on... [ 22s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 22s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 22s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 22s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 22s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 22s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 22s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 22s] [ 22s] failed "build libgtpnl_1.2.0.1.bc71.dsc" at Tue Jul 9 02:36:46 UTC 2019. [ 22s] [ 22s] ### VM INTERACTION START ### [ 25s] [ 7.788284] sysrq: SysRq : Power Off [ 25s] [ 7.793027] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] lamb54 failed "build libgtpnl_1.2.0.1.bc71.dsc" at Tue Jul 9 02:36:50 UTC 2019. [ 25s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:36:58 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:36:58 +0000 Subject: Build failure of network:osmocom:nightly/rtl-sdr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fde6375fd_3358c48600605688@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/rtl-sdr/Debian_Unstable/x86_64 Package network:osmocom:nightly/rtl-sdr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly rtl-sdr Last lines of build log: [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 15s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 15s] Booting from ROM... [ 21s] c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] [ 5.210806] sysrq: SysRq : Changing Loglevel [ 21s] [ 5.211703] sysrq: Loglevel set to 4 [ 21s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 21s] Increasing log level from now on... [ 21s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] [ 21s] failed "build rtl-sdr_0.5.4.12.f68b.dsc" at Tue Jul 9 02:36:49 UTC 2019. [ 21s] [ 21s] ### VM INTERACTION START ### [ 24s] [ 8.375513] sysrq: SysRq : Power Off [ 24s] [ 8.380350] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] lamb11 failed "build rtl-sdr_0.5.4.12.f68b.dsc" at Tue Jul 9 02:36:54 UTC 2019. [ 25s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:36:58 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:36:58 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fde6a0a63_3358c486006057f5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 10s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 11s] booting kvm... [ 11s] ### VM INTERACTION START ### [ 11s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 12s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 15s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 15s] 2nd stage started in virtual machine [ 15s] machine type: x86_64 [ 15s] Linux version: 4[ 3.196418] sysrq: SysRq : Changing Loglevel [ 15s] [ 3.198048] sysrq: Loglevel set to 4 [ 15s] .12.14-lp151.28.4-default #1 SMP Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 15s] Increasing log level from now on... [ 15s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 15s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 15s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 15s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 15s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 15s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 15s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 15s] [ 15s] failed "build osmo-gsm-manuals-dev_0.1.1.dsc" at Tue Jul 9 02:36:52 UTC 2019. [ 15s] [ 15s] ### VM INTERACTION START ### [ 18s] [ 6.263973] sysrq: SysRq : Power Off [ 18s] [ 6.272241] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] sheep84 failed "build osmo-gsm-manuals-dev_0.1.1.dsc" at Tue Jul 9 02:36:55 UTC 2019. [ 18s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:36:58 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:36:58 +0000 Subject: Build failure of network:osmocom:nightly/simtrace2 in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fde6ef716_3358c48600605861@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/simtrace2/Debian_Unstable/x86_64 Package network:osmocom:nightly/simtrace2 failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly simtrace2 Last lines of build log: [ 14s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 15s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 4[ 5.158882] sysrq: SysRq : Changing Loglevel [ 21s] .12.14-1.g2114e9[ 5.159997] sysrq: Loglevel set to 4 [ 21s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 21s] Increasing log level from now on... [ 21s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] [ 21s] failed "build simtrace2_0.5.1.29.155f.dsc" at Tue Jul 9 02:36:53 UTC 2019. [ 21s] [ 21s] ### VM INTERACTION START ### [ 25s] [ 8.246833] sysrq: SysRq : Power Off [ 25s] [ 8.252584] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] lamb01 failed "build simtrace2_0.5.1.29.155f.dsc" at Tue Jul 9 02:36:57 UTC 2019. [ 25s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:37:15 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:37:15 +0000 Subject: Build failure of network:osmocom:nightly/osmo-fl2k in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fde78500f_3358c4860060596d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-fl2k/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-fl2k failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-fl2k Last lines of build log: [ 11s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 4[ 4.402661] sysrq: SysRq : Changing Loglevel [ 18s] .12.14-1.g2114e9[ 4.403610] sysrq: Loglevel set to 4 [ 18s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 18s] Increasing log level from now on... [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build osmo-fl2k_0.1.1.12.df33.dsc" at Tue Jul 9 02:37:06 UTC 2019. [ 18s] [ 18s] ### VM INTERACTION START ### [ 21s] [ 7.479603] sysrq: SysRq : Power Off [ 21s] [ 7.488211] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb09 failed "build osmo-fl2k_0.1.1.12.df33.dsc" at Tue Jul 9 02:37:10 UTC 2019. [ 21s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:37:32 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:37:32 +0000 Subject: Build failure of network:osmocom:nightly/libusrp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe06b69e6_3358c486006060dc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 26s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 27s] booting kvm... [ 27s] ### VM INTERACTION START ### [ 27s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 28s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 37s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 37s] 2nd stage started in virtual machine [ 37s] machine type: x86_64 [ 37s] [ 8.326079] sysrq: SysRq : Changing Loglevel [ 37s] [ 8.327000] sysrq: Loglevel set to 4 [ 37s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 37s] Increasing log level from now on... [ 37s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 37s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 37s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 37s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 37s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 37s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 37s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 37s] [ 37s] failed "build libusrp_3.4.2.20190709.dsc" at Tue Jul 9 02:37:14 UTC 2019. [ 37s] [ 37s] ### VM INTERACTION START ### [ 40s] [ 11.647647] sysrq: SysRq : Power Off [ 40s] [ 11.666334] reboot: Power down [ 40s] ### VM INTERACTION END ### [ 40s] [ 40s] lamb56 failed "build libusrp_3.4.2.20190709.dsc" at Tue Jul 9 02:37:18 UTC 2019. [ 40s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:37:32 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:37:32 +0000 Subject: Build failure of network:osmocom:nightly/yder in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe072fa7b_3358c486006061d5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/yder/Debian_Unstable/x86_64 Package network:osmocom:nightly/yder failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly yder Last lines of build log: [ 20s] booting kvm... [ 20s] ### VM INTERACTION START ### [ 20s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 22s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 22s] Booting from ROM... [ 31s] c[?7l### VM INTERACTION END ### [ 31s] 2nd stage started in virtual machine [ 31s] [ 8.248348] sysrq: SysRq : Changing Loglevel [ 31s] [ 8.249262] sysrq: Loglevel set to 4 [ 31s] machine type: x86_64 [ 31s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 31s] Increasing log level from now on... [ 31s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 31s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 31s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 31s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 31s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 31s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 31s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 31s] [ 31s] failed "build yder_1.4.4-4.1.dsc" at Tue Jul 9 02:37:18 UTC 2019. [ 31s] [ 31s] ### VM INTERACTION START ### [ 34s] [ 11.450617] sysrq: SysRq : Power Off [ 34s] [ 11.472526] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 35s] [ 35s] lamb56 failed "build yder_1.4.4-4.1.dsc" at Tue Jul 9 02:37:23 UTC 2019. [ 35s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:37:49 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:37:49 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe07aa3aa_3358c4860060622a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_Unstable/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 14s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 22s] machine type: x86_64 [ 22s] Linux version: 4.12.14-1.g2114e9[ 5.157352] sysrq: SysRq : Changing Loglevel [ 22s] 4-default #1 SMP[ 5.158421] sysrq: Loglevel set to 4 [ 22s] Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 22s] Increasing log level from now on... [ 22s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 22s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 22s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 22s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 22s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 22s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 22s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 22s] [ 22s] failed "build libosmo-netif_0.5.0.1.f0f1.dsc" at Tue Jul 9 02:37:31 UTC 2019. [ 22s] [ 22s] ### VM INTERACTION START ### [ 25s] [ 8.280661] sysrq: SysRq : Power Off [ 25s] [ 8.286864] reboot: Power down [ 25s] ### VM INTERACTION END ### [ 25s] [ 25s] lamb19 failed "build libosmo-netif_0.5.0.1.f0f1.dsc" at Tue Jul 9 02:37:35 UTC 2019. [ 25s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:38:06 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:38:06 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe21f3268_3358c486006063a5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 15s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 21s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 21s] 2nd stage started in virtual machine [ 21s] machine type: x86_64 [ 21s] Linux version: 4[ 3.820471] sysrq: SysRq : Changing Loglevel [ 21s] .12.14-lp151.28.[ 3.821966] sysrq: Loglevel set to 4 [ 21s] 4-default #1 SMP Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 21s] Increasing log level from now on... [ 21s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 21s] [ 21s] failed "build osmo-pcu_0.6.0.73.2d24.dsc" at Tue Jul 9 02:37:59 UTC 2019. [ 21s] [ 21s] ### VM INTERACTION START ### [ 24s] [ 6.903803] sysrq: SysRq : Power Off [ 24s] [ 6.910677] reboot: Power down [ 24s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb76 failed "build osmo-pcu_0.6.0.73.2d24.dsc" at Tue Jul 9 02:38:02 UTC 2019. [ 24s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:38:06 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:38:06 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe225607c_3358c486006064ca@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 14s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 15s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 4[ 4.311827] sysrq: SysRq : Changing Loglevel [ 20s] .12.14-1.g2114e9[ 4.313573] sysrq: Loglevel set to 4 [ 20s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 20s] Increasing log level from now on... [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] [ 20s] failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:37:59 UTC 2019. [ 20s] [ 20s] ### VM INTERACTION START ### [ 23s] [ 7.380319] sysrq: SysRq : Power Off [ 23s] [ 7.387950] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb66 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:38:03 UTC 2019. [ 23s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:38:06 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:38:06 +0000 Subject: Build failure of network:osmocom:nightly/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe23365cd_3358c486006065ea@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 16s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 18s] booting kvm... [ 18s] ### VM INTERACTION START ### [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 2200 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 19s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 24s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 24s] 2nd stage started in virtual machine [ 24s] machine type: x86_64 [ 24s] Linux version: 4[ 4.922218] sysrq: SysRq : Changing Loglevel [ 24s] [ 4.922795] sysrq: Loglevel set to 4 [ 24s] .12.14-lp151.28.4-default #1 SMP Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 24s] Increasing log level from now on... [ 24s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 24s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 24s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 24s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 24s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 24s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 24s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 24s] [ 24s] failed "build osmo-ggsn_1.3.0.45.08ca.dsc" at Tue Jul 9 02:37:52 UTC 2019. [ 24s] [ 24s] ### VM INTERACTION START ### [ 28s] [ 8.117411] sysrq: SysRq : Power Off [ 28s] [ 8.120593] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] build34 failed "build osmo-ggsn_1.3.0.45.08ca.dsc" at Tue Jul 9 02:37:56 UTC 2019. [ 28s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:38:24 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:38:24 +0000 Subject: Build failure of network:osmocom:nightly/ulfius in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe23aadeb_3358c486006066b0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/ulfius/Debian_Unstable/x86_64 Package network:osmocom:nightly/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly ulfius Last lines of build log: [ 18s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 18s] booting kvm... [ 18s] ### VM INTERACTION START ### [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 20s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 28s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 28s] 2nd stage started in virtual machine [ 29s] [ 8.235077] sysrq: SysRq : Changing Loglevel [ 29s] [ 8.235991] sysrq: Loglevel set to 4 [ 29s] machine type: x86_64 [ 29s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 29s] Increasing log level from now on... [ 29s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 29s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 29s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 29s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 29s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 29s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 29s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 29s] [ 29s] failed "build ulfius_2.5.2-4.1.dsc" at Tue Jul 9 02:38:16 UTC 2019. [ 29s] [ 29s] ### VM INTERACTION START ### [ 32s] [ 11.492514] sysrq: SysRq : Power Off [ 32s] [ 11.507244] reboot: Power down [ 32s] ### VM INTERACTION END ### [ 32s] [ 32s] lamb56 failed "build ulfius_2.5.2-4.1.dsc" at Tue Jul 9 02:38:20 UTC 2019. [ 32s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:38:24 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:38:24 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe241e4c9_3358c48600606753@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 14s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 4.12.14-lp151.28.[ 3.564847] sysrq: SysRq : Changing Loglevel [ 20s] 4-default #1 SMP[ 3.566457] sysrq: Loglevel set to 4 [ 20s] Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 20s] Increasing log level from now on... [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] [ 20s] failed "build osmo-sip-connector_1.2.0.8.a137.dsc" at Tue Jul 9 02:38:02 UTC 2019. [ 20s] [ 20s] ### VM INTERACTION START ### [ 23s] [ 6.635535] sysrq: SysRq : Power Off [ 23s] [ 6.642852] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 24s] [ 24s] lamb75 failed "build osmo-sip-connector_1.2.0.8.a137.dsc" at Tue Jul 9 02:38:06 UTC 2019. [ 24s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:38:24 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:38:24 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcap in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe24c70a6_3358c48600606858@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-pcap failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcap Last lines of build log: [ 32s] booting kvm... [ 32s] ### VM INTERACTION START ### [ 32s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3000 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 34s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 34s] Booting from ROM... [ 40s] c[?7l### VM INTERACTION END ### [ 40s] 2nd stage started in virtual machine [ 43s] machine type: x86_64 [ 43s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 43s] Increasing log level from now on... [ 43s] [ 8.454434] sysrq: SysRq : Changing Loglevel [ 43s] [ 8.456292] sysrq: Loglevel set to 4 [ 43s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 43s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 43s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 43s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 43s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 43s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 43s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 43s] [ 43s] failed "build osmo-pcap_0.0.6.100.e524.dsc" at Tue Jul 9 02:38:07 UTC 2019. [ 43s] [ 43s] ### VM INTERACTION START ### [ 46s] [ 11.840457] sysrq: SysRq : Power Off [ 46s] [ 11.893237] reboot: Power down [ 47s] ### VM INTERACTION END ### [ 47s] [ 47s] cloud129 failed "build osmo-pcap_0.0.6.100.e524.dsc" at Tue Jul 9 02:38:12 UTC 2019. [ 47s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:38:41 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:38:41 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sysmon in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe3f93635_3358c486006069f1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sysmon/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-sysmon failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sysmon Last lines of build log: [ 13s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8000 -drive file=/var/cache/obs/worker/root_19/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_19/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_19/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 15s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 4[ 3.575304] sysrq: SysRq : Changing Loglevel [ 19s] .12.14-lp151.28.4-default #1 SMP[ 3.576713] sysrq: Loglevel set to 4 [ 19s] Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 19s] Increasing log level from now on... [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] [ 19s] failed "build osmo-sysmon_0.1.0.2.9784.dsc" at Tue Jul 9 02:38:27 UTC 2019. [ 19s] [ 19s] ### VM INTERACTION START ### [ 22s] [ 6.660163] sysrq: SysRq : Power Off [ 22s] [ 6.666472] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] morla5 failed "build osmo-sysmon_0.1.0.2.9784.dsc" at Tue Jul 9 02:38:30 UTC 2019. [ 22s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:38:41 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:38:41 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe404dbc2_3358c486006070ed@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 16s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 18s] booting kvm... [ 18s] ### VM INTERACTION START ### [ 18s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -mem-prealloc -mem-path /dev/hugetlbfs -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 2200 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 20s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 25s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 25s] 2nd stage started in virtual machine [ 26s] machine type: x86_64 [ 26s] Linux version: 4.12.14-lp151.28.4-default #1 SMP Fri May 24 07:57:46 UTC 2019 (a[ 5.146912] sysrq: SysRq : Changing Loglevel [ 26s] [ 5.147636] sysrq: Loglevel set to 4 [ 26s] f35fd1) [ 26s] Increasing log level from now on... [ 26s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 26s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 26s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 26s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 26s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 26s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 26s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 26s] [ 26s] failed "build osmo-hlr_1.0.0.38.9ac4.dsc" at Tue Jul 9 02:38:30 UTC 2019. [ 26s] [ 26s] ### VM INTERACTION START ### [ 29s] [ 8.536942] sysrq: SysRq : Power Off [ 29s] [ 8.541717] reboot: Power down [ 29s] ### VM INTERACTION END ### [ 29s] [ 29s] build36 failed "build osmo-hlr_1.0.0.38.9ac4.dsc" at Tue Jul 9 02:38:34 UTC 2019. [ 29s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:39:15 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:39:15 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe60171b4_3358c48600607265@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 41s] booting kvm... [ 41s] ### VM INTERACTION START ### [ 41s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3000 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 43s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 43s] Booting from ROM... [ 51s] c[?7l### VM INTERACTION END ### [ 51s] 2nd stage started in virtual machine [ 53s] machine type: x86_64 [ 53s] [ 8.813978] sysrq: SysRq : Changing Loglevel [ 53s] [ 8.815447] sysrq: Loglevel set to 4 [ 53s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 53s] Increasing log level from now on... [ 53s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 53s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 53s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 53s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 53s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 53s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 53s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 53s] [ 53s] failed "build libosmo-sccp_1.0.0.22.abcb.dsc" at Tue Jul 9 02:39:08 UTC 2019. [ 53s] [ 53s] ### VM INTERACTION START ### [ 56s] [ 12.168235] sysrq: SysRq : Power Off [ 56s] [ 12.174600] reboot: Power down [ 56s] ### VM INTERACTION END ### [ 56s] [ 56s] cloud121 failed "build libosmo-sccp_1.0.0.22.abcb.dsc" at Tue Jul 9 02:39:12 UTC 2019. [ 56s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:39:32 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:39:32 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe7eeeac1_3358c4860060738d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 18s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 19s] booting kvm... [ 19s] ### VM INTERACTION START ### [ 19s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 20s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 27s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 27s] 2nd stage started in virtual machine [ 27s] machine type: x86_64 [ 27s] [ 6.006329] sysrq: SysRq : Changing Loglevel [ 27s] [ 6.007231] sysrq: Loglevel set to 4 [ 27s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 27s] Increasing log level from now on... [ 27s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 27s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 27s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 27s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 27s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 27s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 27s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 27s] [ 27s] failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:39:11 UTC 2019. [ 27s] [ 27s] ### VM INTERACTION START ### [ 30s] [ 9.108320] sysrq: SysRq : Power Off [ 30s] [ 9.182060] reboot: Power down [ 30s] ### VM INTERACTION END ### [ 30s] [ 30s] lamb53 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:39:15 UTC 2019. [ 30s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:39:32 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:39:32 +0000 Subject: Build failure of network:osmocom:nightly/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe7fa2a38_3358c4860060742@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 40s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 60s] booting kvm... [ 60s] ### VM INTERACTION START ### [ 60s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3000 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 61s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 68s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 68s] 2nd stage started in virtual machine [ 70s] machine type: x86_64 [ 70s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 70s] Increasing log level from now on... [ 70s] [ 7.715036] sysrq: SysRq : Changing Loglevel [ 70s] [ 7.716521] sysrq: Loglevel set to 4 [ 70s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 70s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 70s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 70s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 70s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 70s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 70s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 70s] [ 70s] failed "build osmo-trx_1.0.0.61.95c8.dsc" at Tue Jul 9 02:39:15 UTC 2019. [ 70s] [ 70s] ### VM INTERACTION START ### [ 73s] [ 11.086917] sysrq: SysRq : Power Off [ 73s] [ 11.098963] reboot: Power down [ 74s] ### VM INTERACTION END ### [ 74s] [ 74s] cloud107 failed "build osmo-trx_1.0.0.61.95c8.dsc" at Tue Jul 9 02:39:20 UTC 2019. [ 74s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:40:06 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:40:06 +0000 Subject: Build failure of network:osmocom:nightly/openbsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fe9ad217d_3358c486006076be@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_Unstable/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 4[ 3.948784] sysrq: SysRq : Changing Loglevel [ 18s] .12.14-1.g2114e9[ 3.949803] sysrq: Loglevel set to 4 [ 18s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 18s] Increasing log level from now on... [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 02:39:51 UTC 2019. [ 18s] [ 18s] ### VM INTERACTION START ### [ 21s] [ 7.019626] sysrq: SysRq : Power Off [ 21s] [ 7.023841] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb20 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 02:39:55 UTC 2019. [ 21s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:41:33 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:41:33 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23fef7e96b4_3358c4860060781d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 16s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 25s] booting kvm... [ 25s] ### VM INTERACTION START ### [ 25s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 6000 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 26s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 33s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 33s] 2nd stage started in virtual machine [ 35s] machine type: x86_64 [ 35s] [ 7.821114] sysrq: SysRq : Changing Loglevel [ 35s] [ 7.822539] sysrq: Loglevel set to 4 [ 35s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 35s] Increasing log level from now on... [ 35s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 35s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 35s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 35s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 35s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 35s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 35s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 35s] [ 35s] failed "build osmo-iuh_0.4.0.8.11b1.dsc" at Tue Jul 9 02:41:26 UTC 2019. [ 35s] [ 35s] ### VM INTERACTION START ### [ 38s] [ 11.265871] sysrq: SysRq : Power Off [ 38s] [ 11.279798] reboot: Power down [ 39s] ### VM INTERACTION END ### [ 39s] [ 39s] cloud136 failed "build osmo-iuh_0.4.0.8.11b1.dsc" at Tue Jul 9 02:41:31 UTC 2019. [ 39s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:43:49 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:43:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d23ff6f9a276_3358c486006080a7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 40s] booting kvm... [ 40s] ### VM INTERACTION START ### [ 40s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 41s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 41s] Booting from ROM... [ 47s] c[?7l### VM INTERACTION END ### [ 47s] 2nd stage started in virtual machine [ 47s] machine type: x86_64 [ 47s] [ 4.801145] sysrq: SysRq : Changing Loglevel [ 47s] [ 4.802368] sysrq: Loglevel set to 4 [ 47s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 47s] Increasing log level from now on... [ 47s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 47s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 47s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 47s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 47s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 47s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 47s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 47s] [ 47s] failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Tue Jul 9 02:43:36 UTC 2019. [ 47s] [ 47s] ### VM INTERACTION START ### [ 50s] [ 7.913749] sysrq: SysRq : Power Off [ 50s] [ 7.930043] reboot: Power down [ 50s] ### VM INTERACTION END ### [ 50s] [ 50s] lamb13 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Tue Jul 9 02:43:41 UTC 2019. [ 50s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:45:15 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:45:15 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in xUbuntu_16.04/i586 In-Reply-To: References: Message-ID: <5d23ffc686bfb_3358c4860060841f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-bts failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 209s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 209s] } [ 209s] ^ [ 209s] Makefile:437: recipe for target 'measurement.o' failed [ 209s] make[4]: *** [measurement.o] Error 1 [ 209s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 209s] Makefile:385: recipe for target 'all-recursive' failed [ 209s] make[3]: *** [all-recursive] Error 1 [ 209s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 209s] Makefile:434: recipe for target 'all-recursive' failed [ 209s] make[2]: *** [all-recursive] Error 1 [ 209s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 209s] Makefile:366: recipe for target 'all' failed [ 209s] make[1]: *** [all] Error 2 [ 209s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 209s] dh_auto_build: make -j1 returned exit code 2 [ 209s] debian/rules:12: recipe for target 'build' failed [ 209s] make: *** [build] Error 2 [ 209s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 209s] [ 209s] lamb04 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:44:57 UTC 2019. [ 209s] [ 209s] ### VM INTERACTION START ### [ 212s] [ 199.216862] sysrq: SysRq : Power Off [ 212s] [ 199.223861] reboot: Power down [ 212s] ### VM INTERACTION END ### [ 212s] [ 212s] lamb04 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:45:02 UTC 2019. [ 212s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:46:06 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:46:06 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_9.0/i586 In-Reply-To: References: Message-ID: <5d24000159c2b_3358c486006085c3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_9.0/i586 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 178s] Makefile:602: recipe for target 'rspro_util.lo' failed [ 178s] make[5]: *** [rspro_util.lo] Error 1 [ 178s] make[5]: Leaving directory '/usr/src/packages/BUILD/src' [ 178s] Makefile:743: recipe for target '../../src/libosmo-rspro.la' failed [ 178s] make[4]: *** [../../src/libosmo-rspro.la] Error 2 [ 178s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/bankd' [ 178s] Makefile:659: recipe for target 'all-recursive' failed [ 178s] make[3]: *** [all-recursive] Error 1 [ 178s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 178s] Makefile:460: recipe for target 'all-recursive' failed [ 178s] make[2]: *** [all-recursive] Error 1 [ 178s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 178s] Makefile:384: recipe for target 'all' failed [ 178s] make[1]: *** [all] Error 2 [ 178s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 178s] dh_auto_build: make -j1 returned exit code 2 [ 178s] debian/rules:12: recipe for target 'build' failed [ 178s] make: *** [build] Error 2 [ 178s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 178s] [ 178s] lamb06 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:45:58 UTC 2019. [ 178s] [ 178s] ### VM INTERACTION START ### [ 181s] [ 164.722360] sysrq: SysRq : Power Off [ 181s] [ 164.728369] reboot: Power down [ 181s] ### VM INTERACTION END ### [ 181s] [ 181s] lamb06 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:46:03 UTC 2019. [ 181s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:46:06 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:46:06 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in xUbuntu_18.10/i586 In-Reply-To: References: Message-ID: <5d240001c30ac_3358c4860060862b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/xUbuntu_18.10/i586 Package network:osmocom:nightly/osmo-remsim failed to build in xUbuntu_18.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 239s] rval.code, rval.consumed, msgb_length(msg)); [ 239s] ~~~~~~~~~~~~~ [ 239s] rspro_util.c: In function 'rspro_gen_TpduCard2Modem': [ 239s] rspro_util.c:384:2: error: expected ';' before 'pdu' [ 239s] pdu->msg.choice.tpduCardToModem.toClientSlot = *client; [ 239s] ^~~ [ 239s] make[5]: *** [Makefile:614: rspro_util.lo] Error 1 [ 239s] make[5]: Leaving directory '/usr/src/packages/BUILD/src' [ 239s] make[4]: *** [Makefile:771: ../../src/libosmo-rspro.la] Error 2 [ 239s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/bankd' [ 239s] make[3]: *** [Makefile:671: all-recursive] Error 1 [ 239s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 239s] make[2]: *** [Makefile:460: all-recursive] Error 1 [ 239s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 239s] make[1]: *** [Makefile:384: all] Error 2 [ 239s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 239s] dh_auto_build: make -j1 returned exit code 2 [ 239s] make: *** [debian/rules:12: build] Error 2 [ 239s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 239s] [ 239s] cloud114 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:45:43 UTC 2019. [ 239s] [ 239s] ### VM INTERACTION START ### [ 242s] [ 206.813876] sysrq: SysRq : Power Off [ 242s] [ 206.818477] reboot: Power down [ 243s] ### VM INTERACTION END ### [ 243s] [ 243s] cloud114 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:45:49 UTC 2019. [ 243s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:46:06 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:46:06 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in xUbuntu_16.04/x86_64 In-Reply-To: References: Message-ID: <5d240002bb7d6_3358c486006087b0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 169s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 169s] } [ 169s] ^ [ 169s] Makefile:437: recipe for target 'measurement.o' failed [ 169s] make[4]: *** [measurement.o] Error 1 [ 169s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 169s] Makefile:385: recipe for target 'all-recursive' failed [ 169s] make[3]: *** [all-recursive] Error 1 [ 169s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 169s] Makefile:434: recipe for target 'all-recursive' failed [ 169s] make[2]: *** [all-recursive] Error 1 [ 169s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 169s] Makefile:366: recipe for target 'all' failed [ 169s] make[1]: *** [all] Error 2 [ 169s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 169s] dh_auto_build: make -j1 returned exit code 2 [ 169s] debian/rules:12: recipe for target 'build' failed [ 169s] make: *** [build] Error 2 [ 169s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 169s] [ 169s] lamb12 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:45:56 UTC 2019. [ 169s] [ 169s] ### VM INTERACTION START ### [ 172s] [ 158.713384] sysrq: SysRq : Power Off [ 172s] [ 158.719866] reboot: Power down [ 172s] ### VM INTERACTION END ### [ 172s] [ 172s] lamb12 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:46:00 UTC 2019. [ 172s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:46:59 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:46:59 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <5d24003cb8eb6_3358c486006089c9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 182s] Makefile:602: recipe for target 'rspro_util.lo' failed [ 182s] make[5]: *** [rspro_util.lo] Error 1 [ 182s] make[5]: Leaving directory '/usr/src/packages/BUILD/src' [ 182s] Makefile:743: recipe for target '../../src/libosmo-rspro.la' failed [ 182s] make[4]: *** [../../src/libosmo-rspro.la] Error 2 [ 182s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/bankd' [ 182s] Makefile:659: recipe for target 'all-recursive' failed [ 182s] make[3]: *** [all-recursive] Error 1 [ 182s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 182s] Makefile:460: recipe for target 'all-recursive' failed [ 182s] make[2]: *** [all-recursive] Error 1 [ 182s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 182s] Makefile:384: recipe for target 'all' failed [ 182s] make[1]: *** [all] Error 2 [ 182s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 182s] dh_auto_build: make -j1 returned exit code 2 [ 182s] debian/rules:12: recipe for target 'build' failed [ 182s] make: *** [build] Error 2 [ 182s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 182s] [ 182s] lamb16 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:46:51 UTC 2019. [ 182s] [ 182s] ### VM INTERACTION START ### [ 185s] [ 171.992232] sysrq: SysRq : Power Off [ 185s] [ 171.997251] reboot: Power down [ 185s] ### VM INTERACTION END ### [ 185s] [ 185s] lamb16 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:46:56 UTC 2019. [ 185s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:46:59 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:46:59 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_8.0/i586 In-Reply-To: References: Message-ID: <5d24003d569dd_3358c48600609055@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_8.0/i586 Package network:osmocom:nightly/osmo-bts failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 174s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 174s] } [ 174s] ^ [ 174s] Makefile:426: recipe for target 'measurement.o' failed [ 174s] make[4]: *** [measurement.o] Error 1 [ 174s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 174s] Makefile:373: recipe for target 'all-recursive' failed [ 174s] make[3]: *** [all-recursive] Error 1 [ 174s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 174s] Makefile:422: recipe for target 'all-recursive' failed [ 174s] make[2]: *** [all-recursive] Error 1 [ 174s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 174s] Makefile:353: recipe for target 'all' failed [ 174s] make[1]: *** [all] Error 2 [ 174s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 174s] dh_auto_build: make -j1 returned exit code 2 [ 174s] debian/rules:12: recipe for target 'build' failed [ 174s] make: *** [build] Error 2 [ 174s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 174s] [ 174s] lamb06 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:46:41 UTC 2019. [ 174s] [ 174s] ### VM INTERACTION START ### [ 175s] Powering off. [ 175s] [ 160.186264] reboot: Power down [ 175s] ### VM INTERACTION END ### [ 175s] [ 175s] lamb06 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:46:43 UTC 2019. [ 175s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:48:07 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:48:07 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_8.0/x86_64 In-Reply-To: References: Message-ID: <5d2400783751c_3358c48600609127@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 308s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 308s] } [ 308s] ^ [ 308s] Makefile:426: recipe for target 'measurement.o' failed [ 308s] make[4]: *** [measurement.o] Error 1 [ 308s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 308s] Makefile:373: recipe for target 'all-recursive' failed [ 308s] make[3]: *** [all-recursive] Error 1 [ 308s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 308s] Makefile:422: recipe for target 'all-recursive' failed [ 308s] make[2]: *** [all-recursive] Error 1 [ 308s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 308s] Makefile:353: recipe for target 'all' failed [ 308s] make[1]: *** [all] Error 2 [ 308s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 308s] dh_auto_build: make -j1 returned exit code 2 [ 308s] debian/rules:12: recipe for target 'build' failed [ 308s] make: *** [build] Error 2 [ 308s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 308s] [ 308s] lamb52 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:47:50 UTC 2019. [ 308s] [ 308s] ### VM INTERACTION START ### [ 309s] Powering off. [ 309s] [ 291.534457] reboot: Power down [ 309s] ### VM INTERACTION END ### [ 310s] [ 310s] lamb52 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:47:53 UTC 2019. [ 310s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:48:24 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:48:24 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_9.0/i586 In-Reply-To: References: Message-ID: <5d240099354d0_3358c486006093d1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_9.0/i586 Package network:osmocom:nightly/osmo-bts failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 309s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 309s] } [ 309s] ^ [ 309s] Makefile:437: recipe for target 'measurement.o' failed [ 309s] make[4]: *** [measurement.o] Error 1 [ 309s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 310s] Makefile:385: recipe for target 'all-recursive' failed [ 310s] make[3]: *** [all-recursive] Error 1 [ 310s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 310s] Makefile:434: recipe for target 'all-recursive' failed [ 310s] make[2]: *** [all-recursive] Error 1 [ 310s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 310s] Makefile:366: recipe for target 'all' failed [ 310s] make[1]: *** [all] Error 2 [ 310s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 310s] dh_auto_build: make -j1 returned exit code 2 [ 310s] debian/rules:12: recipe for target 'build' failed [ 310s] make: *** [build] Error 2 [ 310s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 310s] [ 310s] lamb22 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:48:16 UTC 2019. [ 310s] [ 310s] ### VM INTERACTION START ### [ 313s] [ 286.573090] sysrq: SysRq : Power Off [ 313s] [ 286.590589] reboot: Power down [ 313s] ### VM INTERACTION END ### [ 313s] [ 313s] lamb22 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:48:21 UTC 2019. [ 313s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:48:41 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:48:41 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d24009aa602b_3358c486006094d2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 821s] -Returned: 0, Current node: 1 '%s> ' [ 821s] -Going to execute 'ambiguous_str' [ 821s] -Called: 'ambiguous_str [ARG]' (argc=0) [ 821s] -Returned: 0, Current node: 1 '%s> ' [ 821s] -Going to execute 'ambiguous_str arg' [ 821s] -Called: 'ambiguous_str [ARG]' (argc=1) [ 821s] -Returned: 0, Current node: 1 '%s> ' [ 821s] -Going to execute 'ambiguous_str arg keyword' [ 821s] -Called: 'ambiguous_str ARG keyword' [ 821s] -Returned: 0, Current node: 1 '%s> ' [ 821s] -All tests passed [ 821s] ./testsuite.at:196: exit code was 139, expected 0 [ 821s] 31. testsuite.at:192: 31. vty (testsuite.at:192): FAILED (testsuite.at:196) [ 821s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 821s] make[1]: *** [override_dh_auto_test] Error 1 [ 821s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 821s] debian/rules:15: recipe for target 'build' failed [ 821s] make: *** [build] Error 2 [ 821s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 821s] [ 821s] obs-arm-6 failed "build libosmocore_1.1.0.76.4e28.dsc" at Tue Jul 9 02:48:29 UTC 2019. [ 821s] [ 821s] ### VM INTERACTION START ### [ 824s] [ 796.488905] sysrq: SysRq : Power Off [ 824s] [ 796.507179] reboot: Power down [ 824s] ### VM INTERACTION END ### [ 824s] [ 824s] obs-arm-6 failed "build libosmocore_1.1.0.76.4e28.dsc" at Tue Jul 9 02:48:33 UTC 2019. [ 824s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:48:58 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:48:58 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in xUbuntu_18.10/i586 In-Reply-To: References: Message-ID: <5d2400b5564b1_3358c486006096a9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/xUbuntu_18.10/i586 Package network:osmocom:nightly/osmo-bts failed to build in xUbuntu_18.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 440s] switch (pchan) { [ 440s] ^~~~~~ [ 440s] measurement.c:423:28: warning: unused variable 'pchan' [-Wunused-variable] [ 440s] enum gsm_phys_chan_config pchan = ts_pchan(lchan->ts); [ 440s] ^~~~~ [ 440s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 440s] } [ 440s] ^ [ 440s] make[4]: *** [Makefile:457: measurement.o] Error 1 [ 440s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 440s] make[3]: *** [Makefile:385: all-recursive] Error 1 [ 440s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 440s] make[2]: *** [Makefile:434: all-recursive] Error 1 [ 440s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 440s] make[1]: *** [Makefile:366: all] Error 2 [ 440s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 440s] dh_auto_build: make -j1 returned exit code 2 [ 440s] make: *** [debian/rules:12: build] Error 2 [ 440s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 440s] [ 440s] lamb04 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:48:49 UTC 2019. [ 440s] [ 440s] ### VM INTERACTION START ### [ 443s] [ 428.497413] sysrq: SysRq : Power Off [ 443s] [ 428.516263] reboot: Power down [ 443s] ### VM INTERACTION END ### [ 443s] [ 443s] lamb04 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:48:53 UTC 2019. [ 443s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:49:15 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:49:15 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in xUbuntu_18.10/x86_64 In-Reply-To: References: Message-ID: <5d2400b7d1bc7_3358c48600609865@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/xUbuntu_18.10/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in xUbuntu_18.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 225s] /bin/bash ../libtool --tag=CC --mode=compile gcc -DPACKAGE_NAME=\"osmo-remsim\" -DPACKAGE_TARNAME=\"osmo-remsim\" -DPACKAGE_VERSION=\"0.1.0.19-293c\" -DPACKAGE_STRING=\"osmo-remsim\ 0.1.0.19-293c\" -DPACKAGE_BUGREPORT=\"simtrace at lists.osmocom.org\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DPACKAGE=\"osmo-remsim\" -DVERSION=\"0.1.0.19-293c\" -DHAVE_CSV_H=1 -DBUILD_SERVER=1 -DBUILD_BANKD=1 -DSTDC_HEADERS=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wall -I../include -I../include -I/usr/include/ -I/usr/include/ -I/usr/include/ -pthread -I/usr/include/PCSC -I/usr/include/libusb-1.0 -I/usr/include/ -I../include/osmocom/rspro -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o rspro_util.lo rspro_util.c [ 226s] libtool: compile: gcc -DPACKAGE_NAME=\"osmo-remsim\" -DPACKAGE_TARNAME=\"osmo-remsim\" -DPACKAGE_VERSION=\"0.1.0.19-293c\" "-DPACKAGE_STRING=\"osmo-remsim 0.1.0.19-293c\"" -DPACKAGE_BUGREPORT=\"simtrace at lists.osmocom.org\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DPACKAGE=\"osmo-remsim\" -DVERSION=\"0.1.0.19-293c\" -DHAVE_CSV_H=1 -DBUILD_SERVER=1 -DBUILD_BANKD=1 -DSTDC_HEADERS=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wall -I../include -I../include -I/usr/include/ -I/usr/include/ -I/usr/include/ -pthread -I/usr/include/PCSC -I/usr/include/libusb-1.0 -I/usr/include/ -I../include/osmocom/rspro -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -c rspro_util.c -fPIC -DPIC -o .libs/rspro_util.o [ 226s] rspro_util.c: In function 'rspro_gen_TpduCard2Modem': [ 226s] rspro_util.c:384:2: error: expected ';' before 'pdu' [ 226s] pdu->msg.choice.tpduCardToModem.toClientSlot = *client; [ 226s] ^~~ [ 226s] make[5]: *** [Makefile:614: rspro_util.lo] Error 1 [ 226s] make[5]: Leaving directory '/usr/src/packages/BUILD/src' [ 226s] make[4]: *** [Makefile:771: ../../src/libosmo-rspro.la] Error 2 [ 226s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/bankd' [ 226s] make[3]: *** [Makefile:671: all-recursive] Error 1 [ 226s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 226s] make[2]: *** [Makefile:460: all-recursive] Error 1 [ 226s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 226s] make[1]: *** [Makefile:384: all] Error 2 [ 226s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 226s] dh_auto_build: make -j1 returned exit code 2 [ 226s] make: *** [debian/rules:12: build] Error 2 [ 226s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 226s] [ 226s] cloud120 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:48:56 UTC 2019. [ 226s] [ 226s] ### VM INTERACTION START ### [ 229s] [ 194.997464] sysrq: SysRq : Power Off [ 229s] [ 195.004570] reboot: Power down [ 230s] ### VM INTERACTION END ### [ 230s] [ 230s] cloud120 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:49:02 UTC 2019. [ 230s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:49:49 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:49:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d2400d94b01a_3358c486006102c5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 241s] /bin/bash ../libtool --tag=CC --mode=compile gcc -DPACKAGE_NAME=\"osmo-remsim\" -DPACKAGE_TARNAME=\"osmo-remsim\" -DPACKAGE_VERSION=\"0.1.0.19-293c\" -DPACKAGE_STRING=\"osmo-remsim\ 0.1.0.19-293c\" -DPACKAGE_BUGREPORT=\"simtrace at lists.osmocom.org\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DPACKAGE=\"osmo-remsim\" -DVERSION=\"0.1.0.19-293c\" -DHAVE_CSV_H=1 -DBUILD_SERVER=1 -DBUILD_BANKD=1 -DSTDC_HEADERS=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wall -I../include -I../include -I/usr/include/ -I/usr/include/ -I/usr/include/ -pthread -I/usr/include/PCSC -I/usr/include/libusb-1.0 -I/usr/include/ -I../include/osmocom/rspro -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o rspro_util.lo rspro_util.c [ 241s] libtool: compile: gcc -DPACKAGE_NAME=\"osmo-remsim\" -DPACKAGE_TARNAME=\"osmo-remsim\" -DPACKAGE_VERSION=\"0.1.0.19-293c\" "-DPACKAGE_STRING=\"osmo-remsim 0.1.0.19-293c\"" -DPACKAGE_BUGREPORT=\"simtrace at lists.osmocom.org\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DPACKAGE=\"osmo-remsim\" -DVERSION=\"0.1.0.19-293c\" -DHAVE_CSV_H=1 -DBUILD_SERVER=1 -DBUILD_BANKD=1 -DSTDC_HEADERS=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wall -I../include -I../include -I/usr/include/ -I/usr/include/ -I/usr/include/ -pthread -I/usr/include/PCSC -I/usr/include/libusb-1.0 -I/usr/include/ -I../include/osmocom/rspro -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -c rspro_util.c -fPIC -DPIC -o .libs/rspro_util.o [ 241s] rspro_util.c: In function 'rspro_gen_TpduCard2Modem': [ 241s] rspro_util.c:384:2: error: expected ';' before 'pdu' [ 241s] pdu->msg.choice.tpduCardToModem.toClientSlot = *client; [ 241s] ^~~ [ 241s] make[5]: *** [Makefile:614: rspro_util.lo] Error 1 [ 241s] make[5]: Leaving directory '/usr/src/packages/BUILD/src' [ 241s] make[4]: *** [Makefile:771: ../../src/libosmo-rspro.la] Error 2 [ 241s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/bankd' [ 241s] make[3]: *** [Makefile:671: all-recursive] Error 1 [ 241s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 241s] make[2]: *** [Makefile:460: all-recursive] Error 1 [ 241s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 241s] make[1]: *** [Makefile:384: all] Error 2 [ 241s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 241s] dh_auto_build: make -j1 returned exit code 2 [ 241s] make: *** [debian/rules:12: build] Error 2 [ 241s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 241s] [ 241s] cloud115 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:49:33 UTC 2019. [ 241s] [ 241s] ### VM INTERACTION START ### [ 244s] [ 203.188553] sysrq: SysRq : Power Off [ 244s] [ 203.210757] reboot: Power down [ 245s] ### VM INTERACTION END ### [ 245s] [ 245s] cloud115 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:49:38 UTC 2019. [ 245s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:50:24 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:50:24 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in xUbuntu_18.10/x86_64 In-Reply-To: References: Message-ID: <5d2400f464e98_3358c486006103df@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/xUbuntu_18.10/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in xUbuntu_18.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 245s] switch (pchan) { [ 245s] ^~~~~~ [ 245s] measurement.c:423:28: warning: unused variable 'pchan' [-Wunused-variable] [ 245s] enum gsm_phys_chan_config pchan = ts_pchan(lchan->ts); [ 245s] ^~~~~ [ 245s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 245s] } [ 245s] ^ [ 245s] make[4]: *** [Makefile:457: measurement.o] Error 1 [ 245s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 245s] make[3]: *** [Makefile:385: all-recursive] Error 1 [ 245s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 245s] make[2]: *** [Makefile:434: all-recursive] Error 1 [ 245s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 245s] make[1]: *** [Makefile:366: all] Error 2 [ 245s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 245s] dh_auto_build: make -j1 returned exit code 2 [ 245s] make: *** [debian/rules:12: build] Error 2 [ 245s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 245s] [ 245s] lamb63 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:50:01 UTC 2019. [ 245s] [ 245s] ### VM INTERACTION START ### [ 249s] [ 234.780947] sysrq: SysRq : Power Off [ 249s] [ 234.788430] reboot: Power down [ 249s] ### VM INTERACTION END ### [ 249s] [ 249s] lamb63 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:50:06 UTC 2019. [ 249s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:50:58 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:50:58 +0000 Subject: Build failure of network:osmocom:nightly/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d24012eec27c_3358c486006106dc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 14s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 15s] booting kvm... [ 15s] ### VM INTERACTION START ### [ 15s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 4[ 3.702469] sysrq: SysRq : Changing Loglevel [ 20s] .12.14-1.g2114e9[ 3.703775] sysrq: Loglevel set to 4 [ 20s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 20s] Increasing log level from now on... [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] [ 20s] failed "build osmo-mgw_1.5.0.76.796a4.dsc" at Tue Jul 9 02:50:42 UTC 2019. [ 20s] [ 20s] ### VM INTERACTION START ### [ 23s] [ 6.770765] sysrq: SysRq : Power Off [ 23s] [ 6.787160] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb63 failed "build osmo-mgw_1.5.0.76.796a4.dsc" at Tue Jul 9 02:50:46 UTC 2019. [ 23s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:51:32 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:51:32 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d24014b9e4d6_3358c486006107c6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 250s] switch (pchan) { [ 250s] ^~~~~~ [ 250s] measurement.c:423:28: warning: unused variable 'pchan' [-Wunused-variable] [ 250s] enum gsm_phys_chan_config pchan = ts_pchan(lchan->ts); [ 250s] ^~~~~ [ 250s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 250s] } [ 250s] ^ [ 250s] make[4]: *** [Makefile:457: measurement.o] Error 1 [ 250s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 250s] make[3]: *** [Makefile:385: all-recursive] Error 1 [ 250s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 250s] make[2]: *** [Makefile:434: all-recursive] Error 1 [ 250s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 250s] make[1]: *** [Makefile:366: all] Error 2 [ 250s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 250s] dh_auto_build: make -j1 returned exit code 2 [ 250s] make: *** [debian/rules:12: build] Error 2 [ 250s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 250s] [ 250s] lamb64 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:51:23 UTC 2019. [ 250s] [ 250s] ### VM INTERACTION START ### [ 254s] [ 237.348155] sysrq: SysRq : Power Off [ 254s] [ 237.361617] reboot: Power down [ 254s] ### VM INTERACTION END ### [ 254s] [ 254s] lamb64 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:51:27 UTC 2019. [ 254s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:51:49 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:51:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d24014c3b682_3358c4860061081c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 16s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 17s] booting kvm... [ 17s] ### VM INTERACTION START ### [ 17s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 18s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 28s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 28s] 2nd stage started in virtual machine [ 28s] machine type: x86_64 [ 28s] Linux version: 4.12.14-1.g2114e9[ 8.986222] sysrq: SysRq : Changing Loglevel [ 28s] [ 8.989221] sysrq: Loglevel set to 4 [ 28s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 28s] Increasing log level from now on... [ 29s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 29s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 29s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 29s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 29s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 29s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 29s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 29s] [ 29s] failed "build osmo-bsc_1.4.0.94.58e01.dsc" at Tue Jul 9 02:51:41 UTC 2019. [ 29s] [ 29s] ### VM INTERACTION START ### [ 32s] [ 12.223444] sysrq: SysRq : Power Off [ 32s] [ 12.232123] reboot: Power down [ 32s] ### VM INTERACTION END ### [ 32s] [ 32s] lamb12 failed "build osmo-bsc_1.4.0.94.58e01.dsc" at Tue Jul 9 02:51:46 UTC 2019. [ 32s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:51:49 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:51:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d24014cc6b2e_3358c4860061096e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 10s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 11s] booting kvm... [ 11s] ### VM INTERACTION START ### [ 11s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_7/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_7/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_7/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 12s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 15s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 15s] 2nd stage started in virtual machine [ 15s] machine type: x86_64 [ 15s] [ 3.087106] sysrq: SysRq : Changing Loglevel [ 15s] Linux version: 4[ 3.088611] sysrq: Loglevel set to 4 [ 15s] .12.14-lp151.28.4-default #1 SMP Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 15s] Increasing log level from now on... [ 15s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 15s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 15s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 15s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 15s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 15s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 15s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 15s] [ 15s] failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 02:51:29 UTC 2019. [ 15s] [ 15s] ### VM INTERACTION START ### [ 18s] [ 6.147509] sysrq: SysRq : Power Off [ 18s] [ 6.153439] reboot: Power down [ 18s] ### VM INTERACTION END ### [ 18s] [ 18s] sheep83 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 02:51:33 UTC 2019. [ 18s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:52:06 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:52:06 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in xUbuntu_18.04/i586 In-Reply-To: References: Message-ID: <5d24016c666ed_3358c486006111fb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/xUbuntu_18.04/i586 Package network:osmocom:nightly/osmo-remsim failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 367s] Makefile:602: recipe for target 'rspro_util.lo' failed [ 367s] make[5]: *** [rspro_util.lo] Error 1 [ 367s] make[5]: Leaving directory '/usr/src/packages/BUILD/src' [ 367s] Makefile:743: recipe for target '../../src/libosmo-rspro.la' failed [ 367s] make[4]: *** [../../src/libosmo-rspro.la] Error 2 [ 367s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/bankd' [ 367s] Makefile:659: recipe for target 'all-recursive' failed [ 367s] make[3]: *** [all-recursive] Error 1 [ 367s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 367s] Makefile:460: recipe for target 'all-recursive' failed [ 367s] make[2]: *** [all-recursive] Error 1 [ 367s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 367s] Makefile:384: recipe for target 'all' failed [ 367s] make[1]: *** [all] Error 2 [ 367s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 367s] dh_auto_build: make -j1 returned exit code 2 [ 367s] debian/rules:12: recipe for target 'build' failed [ 367s] make: *** [build] Error 2 [ 367s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 367s] [ 367s] cloud128 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:51:53 UTC 2019. [ 367s] [ 367s] ### VM INTERACTION START ### [ 370s] [ 328.481898] sysrq: SysRq : Power Off [ 370s] [ 328.574427] reboot: Power down [ 370s] ### VM INTERACTION END ### [ 370s] [ 370s] cloud128 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:51:58 UTC 2019. [ 370s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:52:58 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:52:58 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_9.0/x86_64 In-Reply-To: References: Message-ID: <5d2401a6da641_3358c486006113a8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 218s] Makefile:602: recipe for target 'rspro_util.lo' failed [ 218s] make[5]: *** [rspro_util.lo] Error 1 [ 218s] make[5]: Leaving directory '/usr/src/packages/BUILD/src' [ 218s] Makefile:743: recipe for target '../../src/libosmo-rspro.la' failed [ 218s] make[4]: *** [../../src/libosmo-rspro.la] Error 2 [ 218s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/bankd' [ 218s] Makefile:659: recipe for target 'all-recursive' failed [ 218s] make[3]: *** [all-recursive] Error 1 [ 218s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 218s] Makefile:460: recipe for target 'all-recursive' failed [ 218s] make[2]: *** [all-recursive] Error 1 [ 218s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 218s] Makefile:384: recipe for target 'all' failed [ 218s] make[1]: *** [all] Error 2 [ 218s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 218s] dh_auto_build: make -j1 returned exit code 2 [ 218s] debian/rules:12: recipe for target 'build' failed [ 218s] make: *** [build] Error 2 [ 218s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 218s] [ 218s] cloud121 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:52:45 UTC 2019. [ 218s] [ 218s] ### VM INTERACTION START ### [ 222s] [ 185.460576] sysrq: SysRq : Power Off [ 222s] [ 185.466519] reboot: Power down [ 222s] ### VM INTERACTION END ### [ 222s] [ 222s] cloud121 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:52:50 UTC 2019. [ 222s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:52:58 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:52:58 +0000 Subject: Build failure of network:osmocom:nightly/openbsc in Debian_8.0/x86_64 In-Reply-To: References: Message-ID: <5d2401a7d4759_3358c486006115ef@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_8.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 90s] bsc_nat_utils.c:210:2: error: expected ';' before '_talloc_free' [ 90s] talloc_free(cfg); [ 90s] ^ [ 90s] Makefile:503: recipe for target 'bsc_nat_utils.o' failed [ 90s] make[4]: *** [bsc_nat_utils.o] Error 1 [ 90s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-bsc_nat' [ 90s] Makefile:417: recipe for target 'all-recursive' failed [ 90s] make[3]: *** [all-recursive] Error 1 [ 90s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 90s] Makefile:443: recipe for target 'all-recursive' failed [ 90s] make[2]: *** [all-recursive] Error 1 [ 90s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 90s] Makefile:374: recipe for target 'all' failed [ 90s] make[1]: *** [all] Error 2 [ 90s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 90s] dh_auto_build: make -j1 returned exit code 2 [ 90s] debian/rules:13: recipe for target 'build' failed [ 90s] make: *** [build] Error 2 [ 90s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 90s] [ 90s] build84 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 02:52:38 UTC 2019. [ 90s] [ 90s] ### VM INTERACTION START ### [ 91s] Powering off. [ 91s] [ 84.149905] reboot: Power down [ 92s] ### VM INTERACTION END ### [ 92s] [ 92s] build84 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 02:52:41 UTC 2019. [ 92s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:53:32 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:53:32 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_9.0/x86_64 In-Reply-To: References: Message-ID: <5d2401c33a8f1_3358c4860061175c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 232s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 232s] } [ 232s] ^ [ 232s] Makefile:437: recipe for target 'measurement.o' failed [ 232s] make[4]: *** [measurement.o] Error 1 [ 232s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 232s] Makefile:385: recipe for target 'all-recursive' failed [ 232s] make[3]: *** [all-recursive] Error 1 [ 232s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 232s] Makefile:434: recipe for target 'all-recursive' failed [ 232s] make[2]: *** [all-recursive] Error 1 [ 232s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 232s] Makefile:366: recipe for target 'all' failed [ 232s] make[1]: *** [all] Error 2 [ 232s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 232s] dh_auto_build: make -j1 returned exit code 2 [ 232s] debian/rules:12: recipe for target 'build' failed [ 232s] make: *** [build] Error 2 [ 232s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 232s] [ 232s] lamb57 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:53:12 UTC 2019. [ 232s] [ 232s] ### VM INTERACTION START ### [ 235s] [ 219.123825] sysrq: SysRq : Power Off [ 235s] [ 219.151178] reboot: Power down [ 236s] ### VM INTERACTION END ### [ 236s] [ 236s] lamb57 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:53:17 UTC 2019. [ 236s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:53:49 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:53:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in xUbuntu_18.04/i586 In-Reply-To: References: Message-ID: <5d2401c4b1df6_3358c486006118bf@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/xUbuntu_18.04/i586 Package network:osmocom:nightly/osmo-bts failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 446s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 446s] } [ 446s] ^ [ 446s] Makefile:437: recipe for target 'measurement.o' failed [ 446s] make[4]: *** [measurement.o] Error 1 [ 446s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 446s] Makefile:385: recipe for target 'all-recursive' failed [ 446s] make[3]: *** [all-recursive] Error 1 [ 446s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 446s] Makefile:434: recipe for target 'all-recursive' failed [ 446s] make[2]: *** [all-recursive] Error 1 [ 446s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 446s] Makefile:366: recipe for target 'all' failed [ 446s] make[1]: *** [all] Error 2 [ 446s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 446s] dh_auto_build: make -j1 returned exit code 2 [ 446s] debian/rules:12: recipe for target 'build' failed [ 446s] make: *** [build] Error 2 [ 446s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 446s] [ 446s] cloud126 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:53:37 UTC 2019. [ 446s] [ 446s] ### VM INTERACTION START ### [ 449s] [ 394.222355] sysrq: SysRq : Power Off [ 449s] [ 394.239669] reboot: Power down [ 451s] ### VM INTERACTION END ### [ 451s] [ 451s] cloud126 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 02:53:43 UTC 2019. [ 451s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:54:41 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:54:41 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in xUbuntu_19.04/x86_64 In-Reply-To: References: Message-ID: <5d2401fee3a8d_3358c4860061218d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/xUbuntu_19.04/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 170s] /bin/bash ../libtool --tag=CC --mode=compile gcc -DPACKAGE_NAME=\"osmo-remsim\" -DPACKAGE_TARNAME=\"osmo-remsim\" -DPACKAGE_VERSION=\"0.1.0.19-293c\" -DPACKAGE_STRING=\"osmo-remsim\ 0.1.0.19-293c\" -DPACKAGE_BUGREPORT=\"simtrace at lists.osmocom.org\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DPACKAGE=\"osmo-remsim\" -DVERSION=\"0.1.0.19-293c\" -DHAVE_CSV_H=1 -DBUILD_SERVER=1 -DBUILD_BANKD=1 -DSTDC_HEADERS=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wall -I../include -I../include -I/usr/include/ -I/usr/include/ -I/usr/include/ -pthread -I/usr/include/PCSC -I/usr/include/libusb-1.0 -I/usr/include/ -I../include/osmocom/rspro -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o rspro_util.lo rspro_util.c [ 170s] libtool: compile: gcc -DPACKAGE_NAME=\"osmo-remsim\" -DPACKAGE_TARNAME=\"osmo-remsim\" -DPACKAGE_VERSION=\"0.1.0.19-293c\" "-DPACKAGE_STRING=\"osmo-remsim 0.1.0.19-293c\"" -DPACKAGE_BUGREPORT=\"simtrace at lists.osmocom.org\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DPACKAGE=\"osmo-remsim\" -DVERSION=\"0.1.0.19-293c\" -DHAVE_CSV_H=1 -DBUILD_SERVER=1 -DBUILD_BANKD=1 -DSTDC_HEADERS=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wall -I../include -I../include -I/usr/include/ -I/usr/include/ -I/usr/include/ -pthread -I/usr/include/PCSC -I/usr/include/libusb-1.0 -I/usr/include/ -I../include/osmocom/rspro -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -c rspro_util.c -fPIC -DPIC -o .libs/rspro_util.o [ 170s] rspro_util.c: In function 'rspro_gen_TpduCard2Modem': [ 170s] rspro_util.c:384:2: error: expected ';' before 'pdu' [ 170s] pdu->msg.choice.tpduCardToModem.toClientSlot = *client; [ 170s] ^~~ [ 170s] make[5]: *** [Makefile:614: rspro_util.lo] Error 1 [ 170s] make[5]: Leaving directory '/usr/src/packages/BUILD/src' [ 170s] make[4]: *** [Makefile:771: ../../src/libosmo-rspro.la] Error 2 [ 170s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/bankd' [ 170s] make[3]: *** [Makefile:671: all-recursive] Error 1 [ 170s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 170s] make[2]: *** [Makefile:460: all-recursive] Error 1 [ 170s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 170s] make[1]: *** [Makefile:384: all] Error 2 [ 170s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 170s] dh_auto_build: make -j1 returned exit code 2 [ 170s] make: *** [debian/rules:12: build] Error 2 [ 170s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 170s] [ 170s] lamb61 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:54:26 UTC 2019. [ 170s] [ 170s] ### VM INTERACTION START ### [ 173s] [ 158.837142] sysrq: SysRq : Power Off [ 173s] [ 158.841587] reboot: Power down [ 173s] ### VM INTERACTION END ### [ 173s] [ 173s] lamb61 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 02:54:30 UTC 2019. [ 173s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:54:41 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:54:41 +0000 Subject: Build failure of network:osmocom:nightly/openbsc in Debian_9.0/i586 In-Reply-To: References: Message-ID: <5d2401ffb9616_3358c4860061225d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 98s] bsc_nat_utils.c:210:2: error: expected ';' before '_talloc_free' [ 98s] talloc_free(cfg); [ 98s] ^ [ 98s] Makefile:514: recipe for target 'bsc_nat_utils.o' failed [ 98s] make[4]: *** [bsc_nat_utils.o] Error 1 [ 98s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-bsc_nat' [ 98s] Makefile:429: recipe for target 'all-recursive' failed [ 98s] make[3]: *** [all-recursive] Error 1 [ 98s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 98s] Makefile:455: recipe for target 'all-recursive' failed [ 98s] make[2]: *** [all-recursive] Error 1 [ 98s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 98s] Makefile:387: recipe for target 'all' failed [ 98s] make[1]: *** [all] Error 2 [ 98s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 98s] dh_auto_build: make -j1 returned exit code 2 [ 98s] debian/rules:13: recipe for target 'build' failed [ 98s] make: *** [build] Error 2 [ 98s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 98s] [ 98s] build78 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 02:54:22 UTC 2019. [ 98s] [ 98s] ### VM INTERACTION START ### [ 102s] [ 91.668115] sysrq: SysRq : Power Off [ 102s] [ 91.677516] reboot: Power down [ 102s] ### VM INTERACTION END ### [ 102s] [ 102s] build78 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 02:54:26 UTC 2019. [ 102s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:55:49 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:55:49 +0000 Subject: Build failure of network:osmocom:nightly/openbsc in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <5d2402413cfc4_3358c48600612750@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 137s] bsc_nat_utils.c:210:2: error: expected ';' before '_talloc_free' [ 137s] talloc_free(cfg); [ 137s] ^ [ 137s] Makefile:514: recipe for target 'bsc_nat_utils.o' failed [ 137s] make[4]: *** [bsc_nat_utils.o] Error 1 [ 137s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-bsc_nat' [ 137s] Makefile:429: recipe for target 'all-recursive' failed [ 137s] make[3]: *** [all-recursive] Error 1 [ 137s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 137s] Makefile:455: recipe for target 'all-recursive' failed [ 137s] make[2]: *** [all-recursive] Error 1 [ 137s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 137s] Makefile:387: recipe for target 'all' failed [ 137s] make[1]: *** [all] Error 2 [ 137s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 137s] dh_auto_build: cd openbsc && make -j1 returned exit code 2 [ 137s] debian/rules:13: recipe for target 'build' failed [ 137s] make: *** [build] Error 2 [ 137s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 137s] [ 137s] lamb19 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 02:55:28 UTC 2019. [ 137s] [ 137s] ### VM INTERACTION START ### [ 140s] [ 128.460538] sysrq: SysRq : Power Off [ 140s] [ 128.467163] reboot: Power down [ 140s] ### VM INTERACTION END ### [ 140s] [ 140s] lamb19 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 02:55:32 UTC 2019. [ 140s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:57:15 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:57:15 +0000 Subject: Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.04/x86_64 In-Reply-To: References: Message-ID: <5d24029758441_3358c486006131af@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 125s] bsc_nat_utils.c:210:2: error: expected ';' before '_talloc_free' [ 125s] talloc_free(cfg); [ 125s] ^ [ 125s] Makefile:514: recipe for target 'bsc_nat_utils.o' failed [ 125s] make[4]: *** [bsc_nat_utils.o] Error 1 [ 125s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-bsc_nat' [ 125s] Makefile:429: recipe for target 'all-recursive' failed [ 125s] make[3]: *** [all-recursive] Error 1 [ 125s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 125s] Makefile:455: recipe for target 'all-recursive' failed [ 125s] make[2]: *** [all-recursive] Error 1 [ 125s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 125s] Makefile:387: recipe for target 'all' failed [ 125s] make[1]: *** [all] Error 2 [ 125s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 125s] dh_auto_build: make -j1 returned exit code 2 [ 125s] debian/rules:13: recipe for target 'build' failed [ 125s] make: *** [build] Error 2 [ 125s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 125s] [ 125s] build74 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 02:56:54 UTC 2019. [ 125s] [ 125s] ### VM INTERACTION START ### [ 129s] [ 117.839438] sysrq: SysRq : Power Off [ 129s] [ 117.855239] reboot: Power down [ 129s] ### VM INTERACTION END ### [ 129s] [ 129s] build74 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 02:56:59 UTC 2019. [ 129s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:58:06 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:58:06 +0000 Subject: Build failure of network:osmocom:nightly/openbsc in xUbuntu_18.10/i586 In-Reply-To: References: Message-ID: <5d2402d22a6f1_3358c48600613386@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_18.10/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_18.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 239s] from /usr/include/osmocom/core/msgb.h:24, [ 239s] from ../../include/openbsc/mgcp.h:26, [ 239s] from ../../include/openbsc/bsc_nat.h:24, [ 239s] from bsc_nat_utils.c:24: [ 239s] bsc_nat_utils.c: In function 'bsc_config_free': [ 239s] bsc_nat_utils.c:210:2: error: expected ';' before '_talloc_free' [ 239s] talloc_free(cfg); [ 239s] ^~~~~~~~~~~ [ 239s] make[4]: *** [Makefile:527: bsc_nat_utils.o] Error 1 [ 239s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-bsc_nat' [ 239s] make[3]: *** [Makefile:429: all-recursive] Error 1 [ 239s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 239s] make[2]: *** [Makefile:455: all-recursive] Error 1 [ 239s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 239s] make[1]: *** [Makefile:387: all] Error 2 [ 239s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 239s] dh_auto_build: cd openbsc && make -j1 returned exit code 2 [ 239s] make: *** [debian/rules:13: build] Error 2 [ 239s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 239s] [ 239s] lamb28 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 02:57:55 UTC 2019. [ 239s] [ 239s] ### VM INTERACTION START ### [ 243s] [ 226.077222] sysrq: SysRq : Power Off [ 243s] [ 226.082308] reboot: Power down [ 243s] ### VM INTERACTION END ### [ 243s] [ 243s] lamb28 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 02:58:00 UTC 2019. [ 243s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:58:06 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:58:06 +0000 Subject: Build failure of network:osmocom:nightly/openbsc in xUbuntu_18.04/i586 In-Reply-To: References: Message-ID: <5d2402d3181d_3358c48600613545@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_18.04/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 310s] bsc_nat_utils.c:210:2: error: expected ';' before '_talloc_free' [ 310s] talloc_free(cfg); [ 310s] ^ [ 310s] Makefile:514: recipe for target 'bsc_nat_utils.o' failed [ 310s] make[4]: *** [bsc_nat_utils.o] Error 1 [ 310s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-bsc_nat' [ 310s] Makefile:429: recipe for target 'all-recursive' failed [ 310s] make[3]: *** [all-recursive] Error 1 [ 310s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 310s] Makefile:455: recipe for target 'all-recursive' failed [ 310s] make[2]: *** [all-recursive] Error 1 [ 310s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 310s] Makefile:387: recipe for target 'all' failed [ 310s] make[1]: *** [all] Error 2 [ 310s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 310s] dh_auto_build: cd openbsc && make -j1 returned exit code 2 [ 310s] debian/rules:13: recipe for target 'build' failed [ 310s] make: *** [build] Error 2 [ 310s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 310s] [ 310s] lamb55 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 02:58:01 UTC 2019. [ 310s] [ 310s] ### VM INTERACTION START ### [ 313s] [ 300.779155] sysrq: SysRq : Power Off [ 313s] [ 300.834580] reboot: Power down [ 313s] ### VM INTERACTION END ### [ 313s] [ 313s] lamb55 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 02:58:05 UTC 2019. [ 313s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:58:42 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:58:42 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_8.0/i586 In-Reply-To: References: Message-ID: <5d2402f3765a8_3358c486006137c5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_8.0/i586 Package network:osmocom:nightly/osmo-msc failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 160s] ran_peer.c:374:3: error: expected ';' before 'do' [ 160s] OSMO_ASSERT(!ctx->conn); [ 160s] ^ [ 160s] Makefile:526: recipe for target 'ran_peer.o' failed [ 160s] make[4]: *** [ran_peer.o] Error 1 [ 160s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 160s] Makefile:410: recipe for target 'all-recursive' failed [ 160s] make[3]: *** [all-recursive] Error 1 [ 160s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 160s] Makefile:450: recipe for target 'all-recursive' failed [ 160s] make[2]: *** [all-recursive] Error 1 [ 160s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 160s] Makefile:381: recipe for target 'all' failed [ 160s] make[1]: *** [all] Error 2 [ 160s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 160s] dh_auto_build: make -j1 returned exit code 2 [ 160s] debian/rules:45: recipe for target 'build' failed [ 160s] make: *** [build] Error 2 [ 160s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 160s] [ 160s] build77 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 02:58:29 UTC 2019. [ 160s] [ 160s] ### VM INTERACTION START ### [ 161s] Powering off. [ 161s] [ 147.984399] reboot: Power down [ 161s] ### VM INTERACTION END ### [ 161s] [ 161s] build77 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 02:58:31 UTC 2019. [ 161s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 02:59:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 02:59:50 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_8.0/x86_64 In-Reply-To: References: Message-ID: <5d2403304eb82_3358c486006139e2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 204s] ran_peer.c:374:3: error: expected ';' before 'do' [ 204s] OSMO_ASSERT(!ctx->conn); [ 204s] ^ [ 204s] Makefile:526: recipe for target 'ran_peer.o' failed [ 204s] make[4]: *** [ran_peer.o] Error 1 [ 204s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 204s] Makefile:410: recipe for target 'all-recursive' failed [ 204s] make[3]: *** [all-recursive] Error 1 [ 204s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 204s] Makefile:450: recipe for target 'all-recursive' failed [ 204s] make[2]: *** [all-recursive] Error 1 [ 204s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 204s] Makefile:381: recipe for target 'all' failed [ 204s] make[1]: *** [all] Error 2 [ 204s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 204s] dh_auto_build: make -j1 returned exit code 2 [ 204s] debian/rules:45: recipe for target 'build' failed [ 204s] make: *** [build] Error 2 [ 204s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 204s] [ 204s] lamb62 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 02:59:39 UTC 2019. [ 204s] [ 204s] ### VM INTERACTION START ### [ 205s] Powering off. [ 205s] [ 191.051724] reboot: Power down [ 205s] ### VM INTERACTION END ### [ 205s] [ 205s] lamb62 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 02:59:41 UTC 2019. [ 205s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:00:42 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:00:42 +0000 Subject: Build failure of network:osmocom:nightly/openbsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d24036be37a6_3358c486006141ec@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_Testing/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 232s] from /usr/include/osmocom/core/msgb.h:24, [ 232s] from ../../include/openbsc/mgcp.h:26, [ 232s] from ../../include/openbsc/bsc_nat.h:24, [ 232s] from bsc_nat_utils.c:24: [ 232s] bsc_nat_utils.c: In function 'bsc_config_free': [ 232s] bsc_nat_utils.c:210:2: error: expected ';' before '_talloc_free' [ 232s] talloc_free(cfg); [ 232s] ^~~~~~~~~~~ [ 232s] make[4]: *** [Makefile:527: bsc_nat_utils.o] Error 1 [ 232s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-bsc_nat' [ 232s] make[3]: *** [Makefile:429: all-recursive] Error 1 [ 232s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 232s] make[2]: *** [Makefile:455: all-recursive] Error 1 [ 232s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 232s] make[1]: *** [Makefile:387: all] Error 2 [ 232s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 232s] dh_auto_build: cd openbsc && make -j1 returned exit code 2 [ 232s] make: *** [debian/rules:13: build] Error 2 [ 232s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 232s] [ 232s] cloud126 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 03:00:29 UTC 2019. [ 232s] [ 232s] ### VM INTERACTION START ### [ 235s] [ 199.062623] sysrq: SysRq : Power Off [ 235s] [ 199.074991] reboot: Power down [ 236s] ### VM INTERACTION END ### [ 236s] [ 236s] cloud126 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 03:00:35 UTC 2019. [ 236s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:00:59 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:00:59 +0000 Subject: Build failure of network:osmocom:nightly/openbsc in Debian_9.0/x86_64 In-Reply-To: References: Message-ID: <5d24038691c2c_3358c486006143ec@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 173s] bsc_nat_utils.c:210:2: error: expected ';' before '_talloc_free' [ 173s] talloc_free(cfg); [ 173s] ^ [ 173s] Makefile:514: recipe for target 'bsc_nat_utils.o' failed [ 173s] make[4]: *** [bsc_nat_utils.o] Error 1 [ 173s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-bsc_nat' [ 173s] Makefile:429: recipe for target 'all-recursive' failed [ 173s] make[3]: *** [all-recursive] Error 1 [ 173s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 173s] Makefile:455: recipe for target 'all-recursive' failed [ 173s] make[2]: *** [all-recursive] Error 1 [ 173s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 173s] Makefile:387: recipe for target 'all' failed [ 173s] make[1]: *** [all] Error 2 [ 173s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 173s] dh_auto_build: make -j1 returned exit code 2 [ 173s] debian/rules:13: recipe for target 'build' failed [ 173s] make: *** [build] Error 2 [ 173s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 173s] [ 173s] cloud136 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 03:00:49 UTC 2019. [ 173s] [ 173s] ### VM INTERACTION START ### [ 177s] [ 147.584750] sysrq: SysRq : Power Off [ 177s] [ 147.790740] reboot: Power down [ 178s] ### VM INTERACTION END ### [ 178s] [ 178s] cloud136 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 03:00:55 UTC 2019. [ 178s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:02:25 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:02:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in xUbuntu_19.04/x86_64 In-Reply-To: References: Message-ID: <5d2403c3cb9e4_3358c48600614581@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/xUbuntu_19.04/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 555s] switch (pchan) { [ 555s] ^~~~~~ [ 555s] measurement.c:423:28: warning: unused variable 'pchan' [-Wunused-variable] [ 555s] enum gsm_phys_chan_config pchan = ts_pchan(lchan->ts); [ 555s] ^~~~~ [ 555s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 555s] } [ 555s] ^ [ 555s] make[4]: *** [Makefile:457: measurement.o] Error 1 [ 555s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 555s] make[3]: *** [Makefile:385: all-recursive] Error 1 [ 555s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 555s] make[2]: *** [Makefile:434: all-recursive] Error 1 [ 555s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 555s] make[1]: *** [Makefile:366: all] Error 2 [ 555s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 555s] dh_auto_build: make -j1 returned exit code 2 [ 555s] make: *** [debian/rules:12: build] Error 2 [ 555s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 555s] [ 555s] cloud101 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 03:02:18 UTC 2019. [ 555s] [ 555s] ### VM INTERACTION START ### [ 558s] [ 535.460524] sysrq: SysRq : Power Off [ 558s] [ 535.476500] reboot: Power down [ 558s] ### VM INTERACTION END ### [ 558s] [ 558s] cloud101 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 03:02:22 UTC 2019. [ 558s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:03:49 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:03:49 +0000 Subject: Build failure of network:osmocom:nightly/openbsc in xUbuntu_18.10/x86_64 In-Reply-To: References: Message-ID: <5d24041e62fbf_3358c4860061499e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_18.10/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_18.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 600s] from /usr/include/osmocom/core/msgb.h:24, [ 600s] from ../../include/openbsc/mgcp.h:26, [ 600s] from ../../include/openbsc/bsc_nat.h:24, [ 600s] from bsc_nat_utils.c:24: [ 600s] bsc_nat_utils.c: In function 'bsc_config_free': [ 600s] bsc_nat_utils.c:210:2: error: expected ';' before '_talloc_free' [ 600s] talloc_free(cfg); [ 600s] ^~~~~~~~~~~ [ 600s] make[4]: *** [Makefile:527: bsc_nat_utils.o] Error 1 [ 600s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-bsc_nat' [ 600s] make[3]: *** [Makefile:429: all-recursive] Error 1 [ 600s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 600s] make[2]: *** [Makefile:455: all-recursive] Error 1 [ 600s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 600s] make[1]: *** [Makefile:387: all] Error 2 [ 600s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 600s] dh_auto_build: cd openbsc && make -j1 returned exit code 2 [ 600s] make: *** [debian/rules:13: build] Error 2 [ 600s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 600s] [ 600s] lamb59 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 03:03:32 UTC 2019. [ 600s] [ 600s] ### VM INTERACTION START ### [ 603s] [ 564.500974] sysrq: SysRq : Power Off [ 603s] [ 564.516350] reboot: Power down [ 604s] ### VM INTERACTION END ### [ 604s] [ 604s] lamb59 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 03:03:37 UTC 2019. [ 604s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:04:24 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:04:24 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_16.04/i586 In-Reply-To: References: Message-ID: <5d240457bd151_3358c486006151c5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 211s] ran_peer.c:374:3: error: expected ';' before 'do' [ 211s] OSMO_ASSERT(!ctx->conn); [ 211s] ^ [ 211s] Makefile:538: recipe for target 'ran_peer.o' failed [ 211s] make[4]: *** [ran_peer.o] Error 1 [ 211s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 211s] Makefile:422: recipe for target 'all-recursive' failed [ 211s] make[3]: *** [all-recursive] Error 1 [ 211s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 211s] Makefile:462: recipe for target 'all-recursive' failed [ 211s] make[2]: *** [all-recursive] Error 1 [ 211s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 211s] Makefile:394: recipe for target 'all' failed [ 211s] make[1]: *** [all] Error 2 [ 211s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 211s] dh_auto_build: make -j1 returned exit code 2 [ 211s] debian/rules:45: recipe for target 'build' failed [ 211s] make: *** [build] Error 2 [ 211s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 211s] [ 211s] lamb06 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:04:07 UTC 2019. [ 211s] [ 211s] ### VM INTERACTION START ### [ 214s] [ 200.919581] sysrq: SysRq : Power Off [ 214s] [ 200.932547] reboot: Power down [ 214s] ### VM INTERACTION END ### [ 214s] [ 214s] lamb06 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:04:12 UTC 2019. [ 214s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:05:32 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:05:32 +0000 Subject: Build failure of network:osmocom:nightly/openbsc in xUbuntu_19.04/x86_64 In-Reply-To: References: Message-ID: <5d240496c2ed6_3358c486006152a1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_19.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 216s] from /usr/include/osmocom/core/msgb.h:24, [ 216s] from ../../include/openbsc/mgcp.h:26, [ 216s] from ../../include/openbsc/bsc_nat.h:24, [ 216s] from bsc_nat_utils.c:24: [ 216s] bsc_nat_utils.c: In function 'bsc_config_free': [ 216s] bsc_nat_utils.c:210:2: error: expected ';' before '_talloc_free' [ 216s] talloc_free(cfg); [ 216s] ^~~~~~~~~~~ [ 216s] make[4]: *** [Makefile:527: bsc_nat_utils.o] Error 1 [ 216s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-bsc_nat' [ 216s] make[3]: *** [Makefile:429: all-recursive] Error 1 [ 216s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 216s] make[2]: *** [Makefile:455: all-recursive] Error 1 [ 216s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 216s] make[1]: *** [Makefile:387: all] Error 2 [ 216s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 216s] dh_auto_build: cd openbsc && make -j1 returned exit code 2 [ 216s] make: *** [debian/rules:13: build] Error 2 [ 216s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 216s] [ 216s] cloud106 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 03:05:22 UTC 2019. [ 216s] [ 216s] ### VM INTERACTION START ### [ 219s] [ 178.189426] sysrq: SysRq : Power Off [ 219s] [ 178.200808] reboot: Power down [ 221s] ### VM INTERACTION END ### [ 221s] [ 221s] cloud106 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 03:05:28 UTC 2019. [ 221s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:06:25 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:06:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_16.04/x86_64 In-Reply-To: References: Message-ID: <5d2404b62205f_3358c48600616119@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 205s] ran_peer.c:374:3: error: expected ';' before 'do' [ 205s] OSMO_ASSERT(!ctx->conn); [ 205s] ^ [ 205s] Makefile:538: recipe for target 'ran_peer.o' failed [ 205s] make[4]: *** [ran_peer.o] Error 1 [ 205s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 205s] Makefile:422: recipe for target 'all-recursive' failed [ 205s] make[3]: *** [all-recursive] Error 1 [ 205s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 205s] Makefile:462: recipe for target 'all-recursive' failed [ 205s] make[2]: *** [all-recursive] Error 1 [ 205s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 205s] Makefile:394: recipe for target 'all' failed [ 205s] make[1]: *** [all] Error 2 [ 205s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 205s] dh_auto_build: make -j1 returned exit code 2 [ 205s] debian/rules:45: recipe for target 'build' failed [ 205s] make: *** [build] Error 2 [ 205s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 205s] [ 205s] lamb11 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:06:01 UTC 2019. [ 205s] [ 205s] ### VM INTERACTION START ### [ 208s] [ 196.946012] sysrq: SysRq : Power Off [ 208s] [ 196.950206] reboot: Power down [ 209s] ### VM INTERACTION END ### [ 209s] [ 209s] lamb11 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:06:06 UTC 2019. [ 209s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:08:25 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:08:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_18.10/x86_64 In-Reply-To: References: Message-ID: <5d24052d92a55_3358c4860061678@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_18.10/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_18.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 308s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o ran_msg_a.o ran_msg_a.c [ 309s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o ran_peer.o ran_peer.c [ 309s] In file included from /usr/include/osmocom/core/fsm.h:12, [ 309s] from ran_peer.c:25: [ 309s] ran_peer.c: In function 'ran_peer_st_ready': [ 309s] ran_peer.c:374:3: error: expected ';' before 'do' [ 309s] OSMO_ASSERT(!ctx->conn); [ 309s] ^~~~~~~~~~~ [ 309s] make[4]: *** [Makefile:570: ran_peer.o] Error 1 [ 309s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 309s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 309s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 309s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 309s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 309s] make[1]: *** [Makefile:394: all] Error 2 [ 309s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 309s] dh_auto_build: make -j1 returned exit code 2 [ 309s] make: *** [debian/rules:45: build] Error 2 [ 309s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 309s] [ 309s] lamb11 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:08:05 UTC 2019. [ 309s] [ 309s] ### VM INTERACTION START ### [ 312s] [ 297.368387] sysrq: SysRq : Power Off [ 312s] [ 297.374232] reboot: Power down [ 312s] ### VM INTERACTION END ### [ 312s] [ 312s] lamb11 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:08:09 UTC 2019. [ 312s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:09:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:09:50 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d24058591f6e_3358c486006174c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 302s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o ran_msg_a.o ran_msg_a.c [ 303s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o ran_peer.o ran_peer.c [ 303s] In file included from /usr/include/osmocom/core/fsm.h:12, [ 303s] from ran_peer.c:25: [ 303s] ran_peer.c: In function 'ran_peer_st_ready': [ 303s] ran_peer.c:374:3: error: expected ';' before 'do' [ 303s] OSMO_ASSERT(!ctx->conn); [ 303s] ^~~~~~~~~~~ [ 303s] make[4]: *** [Makefile:570: ran_peer.o] Error 1 [ 303s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 303s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 303s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 303s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 303s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 303s] make[1]: *** [Makefile:394: all] Error 2 [ 303s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 303s] dh_auto_build: make -j1 returned exit code 2 [ 303s] make: *** [debian/rules:45: build] Error 2 [ 303s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 303s] [ 303s] lamb06 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:09:43 UTC 2019. [ 303s] [ 303s] ### VM INTERACTION START ### [ 306s] [ 289.650936] sysrq: SysRq : Power Off [ 306s] [ 289.657698] reboot: Power down [ 306s] ### VM INTERACTION END ### [ 306s] [ 306s] lamb06 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:09:47 UTC 2019. [ 306s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:09:33 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:09:33 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <5d240583a74b9_3358c4860061727b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 426s] ran_peer.c:374:3: error: expected ';' before 'do' [ 426s] OSMO_ASSERT(!ctx->conn); [ 426s] ^ [ 426s] Makefile:538: recipe for target 'ran_peer.o' failed [ 426s] make[4]: *** [ran_peer.o] Error 1 [ 426s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 426s] Makefile:422: recipe for target 'all-recursive' failed [ 426s] make[3]: *** [all-recursive] Error 1 [ 426s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 426s] Makefile:462: recipe for target 'all-recursive' failed [ 426s] make[2]: *** [all-recursive] Error 1 [ 426s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 426s] Makefile:394: recipe for target 'all' failed [ 426s] make[1]: *** [all] Error 2 [ 426s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 426s] dh_auto_build: make -j1 returned exit code 2 [ 426s] debian/rules:45: recipe for target 'build' failed [ 426s] make: *** [build] Error 2 [ 426s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 426s] [ 426s] cloud123 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:09:17 UTC 2019. [ 426s] [ 426s] ### VM INTERACTION START ### [ 429s] [ 380.954029] sysrq: SysRq : Power Off [ 429s] [ 380.972189] reboot: Power down [ 430s] ### VM INTERACTION END ### [ 430s] [ 430s] cloud123 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:09:23 UTC 2019. [ 430s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:10:07 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:10:07 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_18.10/i586 In-Reply-To: References: Message-ID: <5d2405a4e2103_3358c48600617573@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_18.10/i586 Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_18.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 331s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o ran_msg_a.o ran_msg_a.c [ 332s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o ran_peer.o ran_peer.c [ 332s] In file included from /usr/include/osmocom/core/fsm.h:12, [ 332s] from ran_peer.c:25: [ 332s] ran_peer.c: In function 'ran_peer_st_ready': [ 332s] ran_peer.c:374:3: error: expected ';' before 'do' [ 332s] OSMO_ASSERT(!ctx->conn); [ 332s] ^~~~~~~~~~~ [ 332s] make[4]: *** [Makefile:570: ran_peer.o] Error 1 [ 332s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 332s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 332s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 332s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 332s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 332s] make[1]: *** [Makefile:394: all] Error 2 [ 332s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 332s] dh_auto_build: make -j1 returned exit code 2 [ 332s] make: *** [debian/rules:45: build] Error 2 [ 332s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 332s] [ 332s] morla5 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:09:59 UTC 2019. [ 332s] [ 332s] ### VM INTERACTION START ### [ 335s] [ 320.150551] sysrq: SysRq : Power Off [ 335s] [ 320.156256] reboot: Power down [ 335s] ### VM INTERACTION END ### [ 335s] [ 335s] morla5 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:10:02 UTC 2019. [ 335s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:11:33 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:11:33 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_9.0/i586 In-Reply-To: References: Message-ID: <5d2405fe791cc_3358c48600617951@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_9.0/i586 Package network:osmocom:nightly/osmo-msc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 417s] ran_peer.c:374:3: error: expected ';' before 'do' [ 417s] OSMO_ASSERT(!ctx->conn); [ 417s] ^ [ 417s] Makefile:538: recipe for target 'ran_peer.o' failed [ 417s] make[4]: *** [ran_peer.o] Error 1 [ 417s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 417s] Makefile:422: recipe for target 'all-recursive' failed [ 417s] make[3]: *** [all-recursive] Error 1 [ 417s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 417s] Makefile:462: recipe for target 'all-recursive' failed [ 417s] make[2]: *** [all-recursive] Error 1 [ 417s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 417s] Makefile:394: recipe for target 'all' failed [ 417s] make[1]: *** [all] Error 2 [ 417s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 417s] dh_auto_build: make -j1 returned exit code 2 [ 417s] debian/rules:45: recipe for target 'build' failed [ 417s] make: *** [build] Error 2 [ 417s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 417s] [ 417s] cloud128 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:11:10 UTC 2019. [ 417s] [ 417s] ### VM INTERACTION START ### [ 420s] [ 351.723691] sysrq: SysRq : Power Off [ 420s] [ 351.734273] reboot: Power down [ 421s] ### VM INTERACTION END ### [ 421s] [ 421s] cloud128 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:11:16 UTC 2019. [ 421s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:12:07 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:12:07 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_18.04/i586 In-Reply-To: References: Message-ID: <5d24061ab30cc_3358c486006182e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_18.04/i586 Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_18.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 406s] ran_peer.c:374:3: error: expected ';' before 'do' [ 406s] OSMO_ASSERT(!ctx->conn); [ 406s] ^ [ 406s] Makefile:538: recipe for target 'ran_peer.o' failed [ 406s] make[4]: *** [ran_peer.o] Error 1 [ 406s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 406s] Makefile:422: recipe for target 'all-recursive' failed [ 406s] make[3]: *** [all-recursive] Error 1 [ 406s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 406s] Makefile:462: recipe for target 'all-recursive' failed [ 406s] make[2]: *** [all-recursive] Error 1 [ 406s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 406s] Makefile:394: recipe for target 'all' failed [ 406s] make[1]: *** [all] Error 2 [ 406s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 406s] dh_auto_build: make -j1 returned exit code 2 [ 406s] debian/rules:45: recipe for target 'build' failed [ 406s] make: *** [build] Error 2 [ 406s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 406s] [ 406s] cloud113 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:12:01 UTC 2019. [ 406s] [ 406s] ### VM INTERACTION START ### [ 409s] [ 378.316813] sysrq: SysRq : Power Off [ 409s] [ 378.327004] reboot: Power down [ 410s] ### VM INTERACTION END ### [ 410s] [ 410s] cloud113 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:12:06 UTC 2019. [ 410s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:13:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:13:50 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in xUbuntu_19.04/x86_64 In-Reply-To: References: Message-ID: <5d24067874636_3358c486006191c9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/xUbuntu_19.04/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 177s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o ran_msg_a.o ran_msg_a.c [ 177s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o ran_peer.o ran_peer.c [ 177s] In file included from /usr/include/osmocom/core/fsm.h:12, [ 177s] from ran_peer.c:25: [ 177s] ran_peer.c: In function 'ran_peer_st_ready': [ 177s] ran_peer.c:374:3: error: expected ';' before 'do' [ 177s] OSMO_ASSERT(!ctx->conn); [ 177s] ^~~~~~~~~~~ [ 177s] make[4]: *** [Makefile:570: ran_peer.o] Error 1 [ 177s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 177s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 177s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 177s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 177s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 177s] make[1]: *** [Makefile:394: all] Error 2 [ 177s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 177s] dh_auto_build: make -j1 returned exit code 2 [ 177s] make: *** [debian/rules:45: build] Error 2 [ 177s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 177s] [ 177s] build75 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:13:41 UTC 2019. [ 177s] [ 177s] ### VM INTERACTION START ### [ 180s] [ 171.536125] sysrq: SysRq : Power Off [ 180s] [ 171.537999] reboot: Power down [ 180s] ### VM INTERACTION END ### [ 180s] [ 180s] build75 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:13:44 UTC 2019. [ 180s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:20:07 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:20:07 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_9.0/x86_64 In-Reply-To: References: Message-ID: <5d2407fa17adb_3358c4860062105f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 316s] ran_peer.c:374:3: error: expected ';' before 'do' [ 316s] OSMO_ASSERT(!ctx->conn); [ 316s] ^ [ 316s] Makefile:538: recipe for target 'ran_peer.o' failed [ 316s] make[4]: *** [ran_peer.o] Error 1 [ 316s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 316s] Makefile:422: recipe for target 'all-recursive' failed [ 316s] make[3]: *** [all-recursive] Error 1 [ 316s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 316s] Makefile:462: recipe for target 'all-recursive' failed [ 316s] make[2]: *** [all-recursive] Error 1 [ 316s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 316s] Makefile:394: recipe for target 'all' failed [ 316s] make[1]: *** [all] Error 2 [ 316s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 316s] dh_auto_build: make -j1 returned exit code 2 [ 316s] debian/rules:45: recipe for target 'build' failed [ 316s] make: *** [build] Error 2 [ 316s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 316s] [ 316s] cloud116 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:20:00 UTC 2019. [ 316s] [ 316s] ### VM INTERACTION START ### [ 319s] [ 279.707647] sysrq: SysRq : Power Off [ 319s] [ 279.722591] reboot: Power down [ 320s] ### VM INTERACTION END ### [ 320s] [ 320s] cloud116 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 03:20:06 UTC 2019. [ 320s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:23:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:23:50 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <5d2408ccf0dbe_3358c4860062197e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 238s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 238s] } [ 238s] ^ [ 238s] Makefile:437: recipe for target 'measurement.o' failed [ 238s] make[4]: *** [measurement.o] Error 1 [ 238s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 238s] Makefile:385: recipe for target 'all-recursive' failed [ 238s] make[3]: *** [all-recursive] Error 1 [ 238s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 238s] Makefile:434: recipe for target 'all-recursive' failed [ 238s] make[2]: *** [all-recursive] Error 1 [ 238s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 238s] Makefile:366: recipe for target 'all' failed [ 238s] make[1]: *** [all] Error 2 [ 238s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 238s] dh_auto_build: make -j1 returned exit code 2 [ 238s] debian/rules:12: recipe for target 'build' failed [ 238s] make: *** [build] Error 2 [ 238s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 238s] [ 238s] lamb51 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 03:23:34 UTC 2019. [ 238s] [ 238s] ### VM INTERACTION START ### [ 241s] [ 227.416192] sysrq: SysRq : Power Off [ 241s] [ 227.422444] reboot: Power down [ 241s] ### VM INTERACTION END ### [ 241s] [ 241s] lamb51 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 03:23:38 UTC 2019. [ 241s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:35:16 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:35:16 +0000 Subject: Build failure of network:osmocom:latest/libgtpnl in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240b84283f4_3358c4860062466e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libgtpnl/Debian_Unstable/x86_64 Package network:osmocom:latest/libgtpnl failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libgtpnl Last lines of build log: [ 11s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_6/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_6/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_6/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] [ 4.233818] sysrq: SysRq : Changing Loglevel [ 18s] [ 4.235138] sysrq: Loglevel set to 4 [ 18s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 18s] Increasing log level from now on... [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build libgtpnl_1.2.0.dsc" at Tue Jul 9 03:35:08 UTC 2019. [ 18s] [ 18s] ### VM INTERACTION START ### [ 21s] [ 7.313203] sysrq: SysRq : Power Off [ 21s] [ 7.320859] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb03 failed "build libgtpnl_1.2.0.dsc" at Tue Jul 9 03:35:12 UTC 2019. [ 21s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:35:16 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:35:16 +0000 Subject: Build failure of network:osmocom:latest/libosmo-dsp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240b84ad0f5_3358c4860062472a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-dsp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-dsp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-dsp Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] [ 4.254242] sysrq: SysRq : Changing Loglevel [ 19s] Linux version: 4[ 4.255560] sysrq: Loglevel set to 4 [ 19s] .12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 19s] Increasing log level from now on... [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] [ 19s] failed "build libosmodsp_0.4.0.dsc" at Tue Jul 9 03:35:09 UTC 2019. [ 19s] [ 19s] ### VM INTERACTION START ### [ 22s] [ 7.331360] sysrq: SysRq : Power Off [ 22s] [ 7.337485] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb52 failed "build libosmodsp_0.4.0.dsc" at Tue Jul 9 03:35:13 UTC 2019. [ 22s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:35:16 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:35:16 +0000 Subject: Build failure of network:osmocom:latest/libasn1c in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240b857556f_3358c486006249ca@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libasn1c/Debian_Unstable/x86_64 Package network:osmocom:latest/libasn1c failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libasn1c Last lines of build log: [ 8s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 8s] booting kvm... [ 8s] ### VM INTERACTION START ### [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_11/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_11/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_11/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 12s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 12s] 2nd stage started in virtual machine [ 12s] machine type: x86_64 [ 12s] Linux version: 4[ 2.884234] sysrq: SysRq : Changing Loglevel [ 12s] .12.14-lp151.28.[ 2.885112] sysrq: Loglevel set to 4 [ 12s] 4-default #1 SMP Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 12s] Increasing log level from now on... [ 12s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 12s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 12s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 12s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 12s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 12s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 12s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 12s] [ 12s] failed "build libasn1c_0.9.31.dsc" at Tue Jul 9 03:34:58 UTC 2019. [ 12s] [ 12s] ### VM INTERACTION START ### [ 15s] [ 5.937236] sysrq: SysRq : Power Off [ 15s] [ 5.943888] reboot: Power down [ 15s] ### VM INTERACTION END ### [ 15s] [ 15s] sheep83 failed "build libasn1c_0.9.31.dsc" at Tue Jul 9 03:35:02 UTC 2019. [ 15s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:35:16 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:35:16 +0000 Subject: Build failure of network:osmocom:latest/libosmocore in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240b83c2ec0_3358c48600624575@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmocore failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmocore Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 4.12.14-1.g2114e9[ 3.653046] sysrq: SysRq : Changing Loglevel [ 18s] 4-default #1 SMP[ 3.654230] sysrq: Loglevel set to 4 [ 18s] Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 18s] Increasing log level from now on... [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build libosmocore_1.1.0.dsc" at Tue Jul 9 03:35:06 UTC 2019. [ 18s] [ 18s] ### VM INTERACTION START ### [ 21s] [ 6.737329] sysrq: SysRq : Power Off [ 21s] [ 6.744376] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb14 failed "build libosmocore_1.1.0.dsc" at Tue Jul 9 03:35:10 UTC 2019. [ 21s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:35:33 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:35:33 +0000 Subject: Build failure of network:osmocom:latest/osmocom-latest in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240b9ed9e09_3358c486006250a1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmocom-latest/Debian_Unstable/x86_64 Package network:osmocom:latest/osmocom-latest failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmocom-latest Last lines of build log: [ 11s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 4[ 3.667376] sysrq: SysRq : Changing Loglevel [ 17s] .12.14-1.g2114e9[ 3.669396] sysrq: Loglevel set to 4 [ 17s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 17s] Increasing log level from now on... [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] [ 17s] failed "build osmocom-latest_0.0.0.dsc" at Tue Jul 9 03:35:14 UTC 2019. [ 17s] [ 17s] ### VM INTERACTION START ### [ 20s] [ 6.739514] sysrq: SysRq : Power Off [ 20s] [ 6.745531] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] lamb56 failed "build osmocom-latest_0.0.0.dsc" at Tue Jul 9 03:35:18 UTC 2019. [ 20s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:35:33 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:35:33 +0000 Subject: Build failure of network:osmocom:latest/eclipse-titan in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240b9f78ae6_3358c48600625286@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/eclipse-titan/Debian_Unstable/x86_64 Package network:osmocom:latest/eclipse-titan failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest eclipse-titan Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 4[ 4.317561] sysrq: SysRq : Changing Loglevel [ 19s] .12.14-1.g2114e9[ 4.318795] sysrq: Loglevel set to 4 [ 19s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 19s] Increasing log level from now on... [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] [ 19s] failed "build eclipse-titan_6.5.0-1.dsc" at Tue Jul 9 03:35:18 UTC 2019. [ 19s] [ 19s] ### VM INTERACTION START ### [ 22s] [ 7.393301] sysrq: SysRq : Power Off [ 22s] [ 7.402841] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb28 failed "build eclipse-titan_6.5.0-1.dsc" at Tue Jul 9 03:35:22 UTC 2019. [ 22s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:35:33 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:35:33 +0000 Subject: Build failure of network:osmocom:latest/libusrp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240b9fc3779_3358c4860062539c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/Debian_Unstable/x86_64 Package network:osmocom:latest/libusrp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 13s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 15s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 4[ 4.367287] sysrq: SysRq : Changing Loglevel [ 20s] .12.14-1.g2114e9[ 4.369243] sysrq: Loglevel set to 4 [ 20s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 20s] Increasing log level from now on... [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] [ 20s] failed "build libusrp_3.4.2.dsc" at Tue Jul 9 03:35:20 UTC 2019. [ 20s] [ 20s] ### VM INTERACTION START ### [ 23s] [ 7.450595] sysrq: SysRq : Power Off [ 23s] [ 7.458471] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb13 failed "build libusrp_3.4.2.dsc" at Tue Jul 9 03:35:24 UTC 2019. [ 23s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:35:33 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:35:33 +0000 Subject: Build failure of network:osmocom:latest/libsmpp34 in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240ba03e5d9_3358c48600625435@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libsmpp34/Debian_Unstable/x86_64 Package network:osmocom:latest/libsmpp34 failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libsmpp34 Last lines of build log: [ 11s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 4[ 3.656110] sysrq: SysRq : Changing Loglevel [ 17s] .12.14-1.g2114e9[ 3.657739] sysrq: Loglevel set to 4 [ 17s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 17s] Increasing log level from now on... [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] [ 17s] failed "build libsmpp34_1.13.0.dsc" at Tue Jul 9 03:35:22 UTC 2019. [ 17s] [ 17s] ### VM INTERACTION START ### [ 20s] [ 6.736928] sysrq: SysRq : Power Off [ 20s] [ 6.744822] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] lamb66 failed "build libsmpp34_1.13.0.dsc" at Tue Jul 9 03:35:26 UTC 2019. [ 20s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:35:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:35:50 +0000 Subject: Build failure of network:osmocom:latest/osmo-ggsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240ba11700c_3358c486006255f7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-ggsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-ggsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-ggsn Last lines of build log: [ 9s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 9s] booting kvm... [ 9s] ### VM INTERACTION START ### [ 9s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 10s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 13s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 13s] 2nd stage started in virtual machine [ 13s] machine type: x86_64 [ 13s] Linux version: 4.12.14-lp151.28.4-default #1 SMP Fri May 24 07:5[ 2.980513] sysrq: SysRq : Changing Loglevel [ 13s] 7:46 UTC 2019 (a[ 2.981825] sysrq: Loglevel set to 4 [ 13s] f35fd1) [ 13s] Increasing log level from now on... [ 13s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 13s] [ 13s] failed "build osmo-ggsn_1.3.0.dsc" at Tue Jul 9 03:35:39 UTC 2019. [ 13s] [ 13s] ### VM INTERACTION START ### [ 16s] [ 6.039804] sysrq: SysRq : Power Off [ 16s] [ 6.046930] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] sheep81 failed "build osmo-ggsn_1.3.0.dsc" at Tue Jul 9 03:35:43 UTC 2019. [ 16s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:35:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:35:50 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240ba1a1cf5_3358c486006256d4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 14s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 16s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 20s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 20s] 2nd stage started in virtual machine [ 20s] machine type: x86_64 [ 20s] Linux version: 4[ 3.870494] sysrq: SysRq : Changing Loglevel [ 20s] .12.14-1.g2114e9[ 3.871538] sysrq: Loglevel set to 4 [ 20s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 20s] Increasing log level from now on... [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 20s] [ 20s] failed "build osmo-gsm-manuals-dev_0.1.1.dsc" at Tue Jul 9 03:35:29 UTC 2019. [ 20s] [ 20s] ### VM INTERACTION START ### [ 23s] [ 6.954743] sysrq: SysRq : Power Off [ 23s] [ 6.962147] reboot: Power down [ 23s] ### VM INTERACTION END ### [ 23s] [ 23s] lamb26 failed "build osmo-gsm-manuals-dev_0.1.1.dsc" at Tue Jul 9 03:35:33 UTC 2019. [ 23s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:36:07 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:36:07 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcu in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240bbb835dd_3358c486006258c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcu/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-pcu failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcu Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 4[ 3.664064] sysrq: SysRq : Changing Loglevel [ 17s] .12.14-1.g2114e9[ 3.665171] sysrq: Loglevel set to 4 [ 17s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 17s] Increasing log level from now on... [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] [ 17s] failed "build osmo-pcu_0.6.0.dsc" at Tue Jul 9 03:35:45 UTC 2019. [ 17s] [ 17s] ### VM INTERACTION START ### [ 20s] [ 6.746433] sysrq: SysRq : Power Off [ 20s] [ 6.753499] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] lamb52 failed "build osmo-pcu_0.6.0.dsc" at Tue Jul 9 03:35:49 UTC 2019. [ 20s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:36:07 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:36:07 +0000 Subject: Build failure of network:osmocom:latest/libosmo-abis in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240bbbd43ff_3358c48600625985@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-abis/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-abis failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-abis Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 4[ 3.716882] sysrq: SysRq : Changing Loglevel [ 18s] [ 3.718696] sysrq: Loglevel set to 4 [ 18s] .12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 18s] Increasing log level from now on... [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build libosmo-abis_0.6.0.dsc" at Tue Jul 9 03:35:47 UTC 2019. [ 18s] [ 18s] ### VM INTERACTION START ### [ 21s] [ 6.787219] sysrq: SysRq : Power Off [ 21s] [ 6.792723] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb56 failed "build libosmo-abis_0.6.0.dsc" at Tue Jul 9 03:35:51 UTC 2019. [ 21s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:36:07 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:36:07 +0000 Subject: Build failure of network:osmocom:latest/simtrace2 in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240bbc801b8_3358c4860062614e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/simtrace2/Debian_Unstable/x86_64 Package network:osmocom:latest/simtrace2 failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest simtrace2 Last lines of build log: [ 11s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] [ 3.655309] sysrq: SysRq : Changing Loglevel [ 17s] [ 3.656751] sysrq: Loglevel set to 4 [ 17s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 17s] Increasing log level from now on... [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] [ 17s] failed "build simtrace2_0.5.1.dsc" at Tue Jul 9 03:35:52 UTC 2019. [ 17s] [ 17s] ### VM INTERACTION START ### [ 20s] [ 6.735496] sysrq: SysRq : Power Off [ 20s] [ 6.742957] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] lamb20 failed "build simtrace2_0.5.1.dsc" at Tue Jul 9 03:35:56 UTC 2019. [ 20s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:36:07 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:36:07 +0000 Subject: Build failure of network:osmocom:latest/osmo-pcap in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240bbc30f91_3358c4860062605b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-pcap/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-pcap failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-pcap Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 4[ 4.372648] sysrq: SysRq : Changing Loglevel [ 18s] .12.14-1.g2114e9[ 4.373578] sysrq: Loglevel set to 4 [ 18s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 18s] Increasing log level from now on... [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build osmo-pcap_0.0.11.dsc" at Tue Jul 9 03:35:49 UTC 2019. [ 18s] [ 18s] ### VM INTERACTION START ### [ 21s] [ 7.449748] sysrq: SysRq : Power Off [ 21s] [ 7.455221] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb57 failed "build osmo-pcap_0.0.11.dsc" at Tue Jul 9 03:35:53 UTC 2019. [ 21s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:36:25 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:36:25 +0000 Subject: Build failure of network:osmocom:latest/libosmo-netif in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240bbdf05bf_3358c486006262e3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-netif/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-netif failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-netif Last lines of build log: [ 8s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 8s] booting kvm... [ 8s] ### VM INTERACTION START ### [ 8s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/hwrng,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 9s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 12s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 12s] 2nd stage started in virtual machine [ 12s] machine type: x86_64 [ 12s] Linux version: 4[ 3.042745] sysrq: SysRq : Changing Loglevel [ 12s] .12.14-lp151.28.[ 3.044525] sysrq: Loglevel set to 4 [ 12s] 4-default #1 SMP Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 12s] Increasing log level from now on... [ 12s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 12s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 12s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 12s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 12s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 12s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 12s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 12s] [ 12s] failed "build libosmo-netif_0.5.0.dsc" at Tue Jul 9 03:36:19 UTC 2019. [ 12s] [ 12s] ### VM INTERACTION START ### [ 15s] [ 6.099634] sysrq: SysRq : Power Off [ 15s] [ 6.106375] reboot: Power down [ 16s] ### VM INTERACTION END ### [ 16s] [ 16s] sheep81 failed "build libosmo-netif_0.5.0.dsc" at Tue Jul 9 03:36:24 UTC 2019. [ 16s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:36:42 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:36:42 +0000 Subject: Build failure of network:osmocom:latest/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240bd877b97_3358c486006264b2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bts Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] [ 4.249670] sysrq: SysRq : Changing Loglevel [ 18s] [ 4.251377] sysrq: Loglevel set to 4 [ 18s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 18s] Increasing log level from now on... [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build osmo-bts_1.0.1.dsc" at Tue Jul 9 03:36:25 UTC 2019. [ 18s] [ 18s] ### VM INTERACTION START ### [ 22s] [ 7.350877] sysrq: SysRq : Power Off [ 22s] [ 7.358271] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb52 failed "build osmo-bts_1.0.1.dsc" at Tue Jul 9 03:36:29 UTC 2019. [ 22s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:36:42 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:36:42 +0000 Subject: Build failure of network:osmocom:latest/osmo-sip-connector in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240bd7efd3b_3358c486006263c6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sip-connector/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sip-connector failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sip-connector Last lines of build log: [ 17s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 27s] booting kvm... [ 27s] ### VM INTERACTION START ### [ 27s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3000 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 28s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 34s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 34s] 2nd stage started in virtual machine [ 37s] machine type: x86_64 [ 37s] [ 8.213802] sysrq: SysRq : Changing Loglevel [ 37s] [ 8.215269] sysrq: Loglevel set to 4 [ 37s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 37s] Increasing log level from now on... [ 37s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 37s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 37s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 37s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 37s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 38s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 38s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 38s] [ 38s] failed "build osmo-sip-connector_1.2.0.dsc" at Tue Jul 9 03:36:21 UTC 2019. [ 38s] [ 38s] ### VM INTERACTION START ### [ 41s] [ 11.977268] sysrq: SysRq : Power Off [ 41s] [ 11.994264] reboot: Power down [ 41s] ### VM INTERACTION END ### [ 41s] [ 41s] cloud115 failed "build osmo-sip-connector_1.2.0.dsc" at Tue Jul 9 03:36:26 UTC 2019. [ 41s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:36:59 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:36:59 +0000 Subject: Build failure of network:osmocom:latest/limesuite in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240bf7687ee_3358c486006266a0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/limesuite/Debian_Unstable/x86_64 Package network:osmocom:latest/limesuite failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest limesuite Last lines of build log: [ 13s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 19s] Increasing log level from now on... [ 19s] [ 3.615206] sysrq: SysRq : Changing Loglevel [ 19s] [ 3.616337] sysrq: Loglevel set to 4 [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] [ 19s] failed "build limesuite_19.04.0-1.dsc" at Tue Jul 9 03:36:42 UTC 2019. [ 19s] [ 19s] ### VM INTERACTION START ### [ 22s] [ 6.701764] sysrq: SysRq : Power Off [ 22s] [ 6.706553] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb02 failed "build limesuite_19.04.0-1.dsc" at Tue Jul 9 03:36:46 UTC 2019. [ 22s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:36:59 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:36:59 +0000 Subject: Build failure of network:osmocom:latest/orcania in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240bf7f1428_3358c486006267f5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/orcania/Debian_Unstable/x86_64 Package network:osmocom:latest/orcania failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest orcania Last lines of build log: [ 21s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 30s] booting kvm... [ 30s] ### VM INTERACTION START ### [ 30s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 6000 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 31s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 37s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 37s] 2nd stage started in virtual machine [ 39s] machine type: x86_64 [ 39s] [ 7.413700] sysrq: SysRq : Changing Loglevel [ 39s] [ 7.415556] sysrq: Loglevel set to 4 [ 39s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 39s] Increasing log level from now on... [ 39s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 39s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 39s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 39s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 39s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 39s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 40s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 40s] [ 40s] failed "build orcania_1.2.9-5.dsc" at Tue Jul 9 03:36:47 UTC 2019. [ 40s] [ 40s] ### VM INTERACTION START ### [ 43s] [ 10.851789] sysrq: SysRq : Power Off [ 43s] [ 10.857702] reboot: Power down [ 43s] ### VM INTERACTION END ### [ 43s] [ 43s] cloud133 failed "build orcania_1.2.9-5.dsc" at Tue Jul 9 03:36:52 UTC 2019. [ 43s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:37:16 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:37:16 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240bf899df3_3358c48600626855@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sysmon failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 11s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_5/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_5/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_5/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 4.12.14-1.g2114e9[ 3.773121] sysrq: SysRq : Changing Loglevel [ 17s] 4-default #1 SMP[ 3.774717] sysrq: Loglevel set to 4 [ 17s] Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 17s] Increasing log level from now on... [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] [ 17s] failed "build osmo-sysmon_0.1.0.dsc" at Tue Jul 9 03:37:03 UTC 2019. [ 17s] [ 17s] ### VM INTERACTION START ### [ 20s] [ 6.847462] sysrq: SysRq : Power Off [ 20s] [ 6.853134] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] lamb08 failed "build osmo-sysmon_0.1.0.dsc" at Tue Jul 9 03:37:07 UTC 2019. [ 20s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:37:16 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:37:16 +0000 Subject: Build failure of network:osmocom:latest/osmo-mgw in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240bf8e1906_3358c48600626934@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-mgw/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-mgw failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-mgw Last lines of build log: [ 11s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] [ 4.327558] sysrq: SysRq : Changing Loglevel [ 17s] Linux version: 4[ 4.329178] sysrq: Loglevel set to 4 [ 17s] .12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 17s] Increasing log level from now on... [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build osmo-mgw_1.5.0.dsc" at Tue Jul 9 03:37:05 UTC 2019. [ 18s] [ 18s] ### VM INTERACTION START ### [ 21s] [ 7.410360] sysrq: SysRq : Power Off [ 21s] [ 7.417511] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb17 failed "build osmo-mgw_1.5.0.dsc" at Tue Jul 9 03:37:09 UTC 2019. [ 21s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:37:16 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:37:16 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240bf9369c7_3358c4860062701a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 11s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_2/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_2/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_2/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 4[ 4.176571] sysrq: SysRq : Changing Loglevel [ 17s] .12.14-1.g2114e9[ 4.178529] sysrq: Loglevel set to 4 [ 17s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 17s] Increasing log level from now on... [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build osmo-hlr_1.0.0.dsc" at Tue Jul 9 03:37:05 UTC 2019. [ 18s] [ 18s] ### VM INTERACTION START ### [ 21s] [ 7.260962] sysrq: SysRq : Power Off [ 21s] [ 7.268717] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb09 failed "build osmo-hlr_1.0.0.dsc" at Tue Jul 9 03:37:09 UTC 2019. [ 21s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:37:16 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:37:16 +0000 Subject: Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240bf98ab63_3358c486006271a4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmo-sccp/Debian_Unstable/x86_64 Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 13s] booting kvm... [ 13s] ### VM INTERACTION START ### [ 13s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_1/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_1/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_1/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 14s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 4.12.14-1.g2114e9[ 4.294960] sysrq: SysRq : Changing Loglevel [ 18s] 4-default #1 SMP[ 4.297091] sysrq: Loglevel set to 4 [ 18s] Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 18s] Increasing log level from now on... [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build libosmo-sccp_1.0.0.dsc" at Tue Jul 9 03:37:06 UTC 2019. [ 18s] [ 19s] ### VM INTERACTION START ### [ 22s] [ 7.364802] sysrq: SysRq : Power Off [ 22s] [ 7.371325] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] lamb52 failed "build libosmo-sccp_1.0.0.dsc" at Tue Jul 9 03:37:10 UTC 2019. [ 22s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:37:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:37:50 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240c151231_3358c486006274e2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 14s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 14s] booting kvm... [ 14s] ### VM INTERACTION START ### [ 14s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8000 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 6 [ 16s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 19s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 19s] 2nd stage started in virtual machine [ 19s] machine type: x86_64 [ 19s] [ 3.084960] sysrq: SysRq : Changing Loglevel [ 19s] [ 3.085768] sysrq: Loglevel set to 4 [ 19s] Linux version: 4.12.14-lp151.28.4-default #1 SMP Fri May 24 07:57:46 UTC 2019 (af35fd1) [ 19s] Increasing log level from now on... [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 19s] [ 19s] failed "build osmo-trx_1.0.0.dsc" at Tue Jul 9 03:37:34 UTC 2019. [ 19s] [ 19s] ### VM INTERACTION START ### [ 22s] [ 6.165005] sysrq: SysRq : Power Off [ 22s] [ 6.171314] reboot: Power down [ 22s] ### VM INTERACTION END ### [ 22s] [ 22s] morla5 failed "build osmo-trx_1.0.0.dsc" at Tue Jul 9 03:37:37 UTC 2019. [ 22s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:37:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:37:50 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240c15885cc_3358c486006275b9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 11s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 4.12.14-1.g2114e9[ 3.643264] sysrq: SysRq : Changing Loglevel [ 17s] 4-default #1 SMP[ 3.644963] sysrq: Loglevel set to 4 [ 17s] Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 17s] Increasing log level from now on... [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] [ 17s] failed "build osmo-bsc_1.4.1.dsc" at Tue Jul 9 03:37:44 UTC 2019. [ 17s] [ 17s] ### VM INTERACTION START ### [ 20s] [ 6.724795] sysrq: SysRq : Power Off [ 20s] [ 6.732796] reboot: Power down [ 20s] ### VM INTERACTION END ### [ 20s] [ 20s] lamb09 failed "build osmo-bsc_1.4.1.dsc" at Tue Jul 9 03:37:48 UTC 2019. [ 20s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:37:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:37:50 +0000 Subject: Build failure of network:osmocom:latest/yder in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240c148a8b5_3358c48600627366@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/yder/Debian_Unstable/x86_64 Package network:osmocom:latest/yder failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest yder Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_10/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_10/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_10/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 18s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 18s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 4[ 4.327803] sysrq: SysRq : Changing Loglevel [ 18s] .12.14-1.g2114e9[ 4.328857] sysrq: Loglevel set to 4 [ 18s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 18s] Increasing log level from now on... [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build yder_1.4.4-4.1.dsc" at Tue Jul 9 03:37:30 UTC 2019. [ 18s] [ 18s] ### VM INTERACTION START ### [ 21s] [ 7.398396] sysrq: SysRq : Power Off [ 21s] [ 7.405477] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb59 failed "build yder_1.4.4-4.1.dsc" at Tue Jul 9 03:37:34 UTC 2019. [ 21s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:37:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:37:50 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240c15d48eb_3358c48600627611@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_Unstable/x86_64 Package network:osmocom:latest/openbsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 11s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_4/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_4/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_4/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 4[ 4.259548] sysrq: SysRq : Changing Loglevel [ 18s] .12.14-1.g2114e9[ 4.260663] sysrq: Loglevel set to 4 [ 18s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 18s] Increasing log level from now on... [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build openbsc_1.2.0.dsc" at Tue Jul 9 03:37:45 UTC 2019. [ 18s] [ 18s] ### VM INTERACTION START ### [ 21s] [ 7.334800] sysrq: SysRq : Power Off [ 21s] [ 7.342522] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb17 failed "build openbsc_1.2.0.dsc" at Tue Jul 9 03:37:49 UTC 2019. [ 21s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:38:07 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:38:07 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240c35ac1_3358c486006278a6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_9/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_9/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_9/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 4[ 3.654773] sysrq: SysRq : Changing Loglevel [ 18s] .12.14-1.g2114e9[ 3.655725] sysrq: Loglevel set to 4 [ 18s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 18s] Increasing log level from now on... [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build osmo-iuh_0.4.0.dsc" at Tue Jul 9 03:37:46 UTC 2019. [ 18s] [ 18s] ### VM INTERACTION START ### [ 21s] [ 6.722956] sysrq: SysRq : Power Off [ 21s] [ 6.728968] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb52 failed "build osmo-iuh_0.4.0.dsc" at Tue Jul 9 03:37:51 UTC 2019. [ 21s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:38:25 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:38:25 +0000 Subject: Build failure of network:osmocom:latest/ulfius in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240c35bcf61_3358c486006280da@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/ulfius/Debian_Unstable/x86_64 Package network:osmocom:latest/ulfius failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest ulfius Last lines of build log: [ 12s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 18s] machine type: x86_64 [ 18s] Linux version: 4.12.14-1.g2114e9[ 3.633956] sysrq: SysRq : Changing Loglevel [ 18s] [ 3.635704] sysrq: Loglevel set to 4 [ 18s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 18s] Increasing log level from now on... [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build ulfius_2.5.2-4.1.dsc" at Tue Jul 9 03:38:11 UTC 2019. [ 18s] [ 18s] ### VM INTERACTION START ### [ 21s] [ 6.709305] sysrq: SysRq : Power Off [ 21s] [ 6.716926] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb59 failed "build ulfius_2.5.2-4.1.dsc" at Tue Jul 9 03:38:16 UTC 2019. [ 21s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:38:42 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:38:42 +0000 Subject: Build failure of network:osmocom:latest/osmo-sgsn in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240c5089f96_3358c4860062821e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sgsn/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sgsn failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sgsn Last lines of build log: [ 11s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 12s] booting kvm... [ 12s] ### VM INTERACTION START ### [ 12s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 8192 -drive file=/var/cache/obs/worker/root_8/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_8/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_8/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 8 [ 13s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 17s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 17s] 2nd stage started in virtual machine [ 17s] machine type: x86_64 [ 17s] Linux version: 4.12.14-1.g2114e9[ 4.229350] sysrq: SysRq : Changing Loglevel [ 17s] [ 4.230888] sysrq: Loglevel set to 4 [ 17s] 4-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 17s] Increasing log level from now on... [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 17s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 18s] [ 18s] failed "build osmo-sgsn_1.4.1.dsc" at Tue Jul 9 03:38:29 UTC 2019. [ 18s] [ 18s] ### VM INTERACTION START ### [ 21s] [ 7.309475] sysrq: SysRq : Power Off [ 21s] [ 7.317054] reboot: Power down [ 21s] ### VM INTERACTION END ### [ 21s] [ 21s] lamb07 failed "build osmo-sgsn_1.4.1.dsc" at Tue Jul 9 03:38:33 UTC 2019. [ 21s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 03:38:59 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 03:38:59 +0000 Subject: Build failure of network:osmocom:latest/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d240c70ac10d_3358c48600628375@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-msc Last lines of build log: [ 16s] objdump: /boot/vmlinuz: warning: ignoring section flag IMAGE_SCN_MEM_NOT_PAGED in section .bss [ 25s] booting kvm... [ 25s] ### VM INTERACTION START ### [ 25s] /usr/bin/qemu-kvm -nodefaults -no-reboot -nographic -vga none -cpu host,-smap -object rng-random,filename=/dev/random,id=rng0 -device virtio-rng-pci,rng=rng0 -runas qemu -net none -kernel /boot/vmlinuz -initrd /boot/initrd -append root=/dev/sda rootfstype=ext3 rootflags=data=writeback,nobarrier,commit=150,noatime ext4.allow_unsupported=1 kpti=off pti=off spectre_v2=off panic=1 quiet no-kvmclock elevator=noop nmi_watchdog=0 rw rd.driver.pre=binfmt_misc console=ttyS0 init=/.build/build -m 3000 -drive file=/var/cache/obs/worker/root_3/root,format=raw,if=none,id=disk,cache=unsafe -device ide-hd,drive=disk,serial=0 -drive file=/var/cache/obs/worker/root_3/swap,format=raw,if=none,id=swap,cache=unsafe -device ide-hd,drive=swap,serial=1 -serial stdio -chardev socket,id=monitor,server,nowait,path=/var/cache/obs/worker/root_3/root.qemu/monitor -mon chardev=monitor,mode=readline -smp 4 [ 26s] c[?7lSeaBIOS (version rel-1.12.0-0-ga698c89-prebuilt.qemu.org) [ 31s] Booting from ROM..c[?7l### VM INTERACTION END ### [ 31s] 2nd stage started in virtual machine [ 33s] machine type: x86_64 [ 33s] Linux version: 4.12.14-1.g2114e94-default #1 SMP Mon Jun 3 08:29:36 UTC 2019 (2114e94) [ 33s] Increasing log level from now on... [ 33s] [ 6.621525] sysrq: SysRq : Changing Loglevel [ 33s] [ 6.623483] sysrq: Loglevel set to 4 [ 33s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 33s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 33s] mkdir: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 33s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 33s] mount: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 33s] mkswap: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 33s] swapon: error while loading shared libraries: libpcre2-8.so.0: cannot open shared object file: No such file or directory [ 34s] [ 34s] failed "build osmo-msc_1.4.0.dsc" at Tue Jul 9 03:38:52 UTC 2019. [ 34s] [ 34s] ### VM INTERACTION START ### [ 37s] [ 10.032312] sysrq: SysRq : Power Off [ 37s] [ 10.037425] reboot: Power down [ 37s] ### VM INTERACTION END ### [ 37s] [ 37s] cloud115 failed "build osmo-msc_1.4.0.dsc" at Tue Jul 9 03:38:57 UTC 2019. [ 37s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 04:27:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 04:27:50 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d2417cfc7ff4_3358c486006339ef@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 162s] /bin/bash ../libtool --tag=CC --mode=compile gcc -DPACKAGE_NAME=\"osmo-remsim\" -DPACKAGE_TARNAME=\"osmo-remsim\" -DPACKAGE_VERSION=\"0.1.0.19-293c\" -DPACKAGE_STRING=\"osmo-remsim\ 0.1.0.19-293c\" -DPACKAGE_BUGREPORT=\"simtrace at lists.osmocom.org\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DPACKAGE=\"osmo-remsim\" -DVERSION=\"0.1.0.19-293c\" -DHAVE_CSV_H=1 -DBUILD_SERVER=1 -DBUILD_BANKD=1 -DSTDC_HEADERS=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wall -I../include -I../include -I/usr/include/ -I/usr/include/ -I/usr/include/ -pthread -I/usr/include/PCSC -I/usr/include/libusb-1.0 -I/usr/include/ -I../include/osmocom/rspro -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o rspro_util.lo rspro_util.c [ 162s] libtool: compile: gcc -DPACKAGE_NAME=\"osmo-remsim\" -DPACKAGE_TARNAME=\"osmo-remsim\" -DPACKAGE_VERSION=\"0.1.0.19-293c\" "-DPACKAGE_STRING=\"osmo-remsim 0.1.0.19-293c\"" -DPACKAGE_BUGREPORT=\"simtrace at lists.osmocom.org\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DPACKAGE=\"osmo-remsim\" -DVERSION=\"0.1.0.19-293c\" -DHAVE_CSV_H=1 -DBUILD_SERVER=1 -DBUILD_BANKD=1 -DSTDC_HEADERS=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wall -I../include -I../include -I/usr/include/ -I/usr/include/ -I/usr/include/ -pthread -I/usr/include/PCSC -I/usr/include/libusb-1.0 -I/usr/include/ -I../include/osmocom/rspro -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -c rspro_util.c -fPIC -DPIC -o .libs/rspro_util.o [ 162s] rspro_util.c: In function 'rspro_gen_TpduCard2Modem': [ 162s] rspro_util.c:384:2: error: expected ';' before 'pdu' [ 162s] pdu->msg.choice.tpduCardToModem.toClientSlot = *client; [ 162s] ^~~ [ 162s] make[5]: *** [Makefile:614: rspro_util.lo] Error 1 [ 162s] make[5]: Leaving directory '/usr/src/packages/BUILD/src' [ 162s] make[4]: *** [Makefile:771: ../../src/libosmo-rspro.la] Error 2 [ 162s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/bankd' [ 162s] make[3]: *** [Makefile:671: all-recursive] Error 1 [ 162s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 162s] make[2]: *** [Makefile:460: all-recursive] Error 1 [ 162s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 162s] make[1]: *** [Makefile:384: all] Error 2 [ 162s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 162s] dh_auto_build: make -j1 returned exit code 2 [ 162s] make: *** [debian/rules:12: build] Error 2 [ 162s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 162s] [ 162s] lamb19 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 04:27:36 UTC 2019. [ 162s] [ 162s] ### VM INTERACTION START ### [ 165s] [ 152.096690] sysrq: SysRq : Power Off [ 165s] [ 152.103055] reboot: Power down [ 166s] ### VM INTERACTION END ### [ 166s] [ 166s] lamb19 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 04:27:40 UTC 2019. [ 166s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 04:28:42 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 04:28:42 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d24180896ade_3358c48600634033@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 254s] switch (pchan) { [ 254s] ^~~~~~ [ 254s] measurement.c:423:28: warning: unused variable 'pchan' [-Wunused-variable] [ 254s] enum gsm_phys_chan_config pchan = ts_pchan(lchan->ts); [ 254s] ^~~~~ [ 254s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 254s] } [ 254s] ^ [ 254s] make[4]: *** [Makefile:457: measurement.o] Error 1 [ 254s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 254s] make[3]: *** [Makefile:385: all-recursive] Error 1 [ 254s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 254s] make[2]: *** [Makefile:434: all-recursive] Error 1 [ 254s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 254s] make[1]: *** [Makefile:366: all] Error 2 [ 254s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 254s] dh_auto_build: make -j1 returned exit code 2 [ 254s] make: *** [debian/rules:12: build] Error 2 [ 254s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 254s] [ 254s] lamb65 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 04:28:21 UTC 2019. [ 254s] [ 254s] ### VM INTERACTION START ### [ 257s] [ 241.170812] sysrq: SysRq : Power Off [ 257s] [ 241.177367] reboot: Power down [ 257s] ### VM INTERACTION END ### [ 257s] [ 257s] lamb65 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 04:28:26 UTC 2019. [ 257s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 04:34:25 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 04:34:25 +0000 Subject: Build failure of network:osmocom:nightly/openbsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d24197139320_3358c4860063476@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_Testing/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 148s] from /usr/include/osmocom/core/msgb.h:24, [ 148s] from ../../include/openbsc/mgcp.h:26, [ 148s] from ../../include/openbsc/bsc_nat.h:24, [ 148s] from bsc_nat_utils.c:24: [ 148s] bsc_nat_utils.c: In function 'bsc_config_free': [ 148s] bsc_nat_utils.c:210:2: error: expected ';' before '_talloc_free' [ 148s] talloc_free(cfg); [ 148s] ^~~~~~~~~~~ [ 148s] make[4]: *** [Makefile:527: bsc_nat_utils.o] Error 1 [ 148s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-bsc_nat' [ 148s] make[3]: *** [Makefile:429: all-recursive] Error 1 [ 148s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 148s] make[2]: *** [Makefile:455: all-recursive] Error 1 [ 148s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 148s] make[1]: *** [Makefile:387: all] Error 2 [ 148s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 148s] dh_auto_build: cd openbsc && make -j1 returned exit code 2 [ 148s] make: *** [debian/rules:13: build] Error 2 [ 148s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 148s] [ 148s] lamb58 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 04:34:10 UTC 2019. [ 148s] [ 148s] ### VM INTERACTION START ### [ 151s] [ 138.027628] sysrq: SysRq : Power Off [ 151s] [ 138.036461] reboot: Power down [ 151s] ### VM INTERACTION END ### [ 151s] [ 151s] lamb58 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 04:34:14 UTC 2019. [ 151s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 04:36:25 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 04:36:25 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d2419cda3b4e_3358c486006351f2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-sysmon failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 63s] #define PACKAGE "osmo-sysmon" [ 63s] #define VERSION "0.1.0" [ 63s] #define STDC_HEADERS 1 [ 63s] #define HAVE_SYS_TYPES_H 1 [ 63s] #define HAVE_SYS_STAT_H 1 [ 63s] #define HAVE_STDLIB_H 1 [ 63s] #define HAVE_STRING_H 1 [ 63s] #define HAVE_MEMORY_H 1 [ 63s] #define HAVE_STRINGS_H 1 [ 63s] #define HAVE_INTTYPES_H 1 [ 63s] #define HAVE_STDINT_H 1 [ 63s] #define HAVE_UNISTD_H 1 [ 63s] #define HAVE_DLFCN_H 1 [ 63s] #define LT_OBJDIR ".libs/" [ 63s] [ 63s] configure: exit 1 [ 63s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking returned exit code 1 [ 63s] make: *** [debian/rules:45: build] Error 2 [ 63s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 63s] [ 63s] build71 failed "build osmo-sysmon_0.1.0.dsc" at Tue Jul 9 04:36:06 UTC 2019. [ 63s] [ 63s] ### VM INTERACTION START ### [ 66s] [ 57.542938] sysrq: SysRq : Power Off [ 66s] [ 57.545044] reboot: Power down [ 66s] ### VM INTERACTION END ### [ 66s] [ 66s] build71 failed "build osmo-sysmon_0.1.0.dsc" at Tue Jul 9 04:36:09 UTC 2019. [ 66s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 04:40:59 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 04:40:59 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d241af67704c_3358c48600635558@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_Testing/x86_64 Package network:osmocom:latest/openbsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 165s] | #define HAVE_MEMORY_H 1 [ 165s] | #define HAVE_STRINGS_H 1 [ 165s] | #define HAVE_INTTYPES_H 1 [ 165s] | #define HAVE_STDINT_H 1 [ 165s] | #define HAVE_UNISTD_H 1 [ 165s] | #define HAVE_DLFCN_H 1 [ 165s] | #define LT_OBJDIR ".libs/" [ 165s] | #define BUILD_SMPP 1 [ 165s] | #define STDC_HEADERS 1 [ 165s] | #define HAVE_DBI_DBD_H 1 [ 165s] | #define HAVE_PCAP_PCAP_H 1 [ 165s] | #define HAVE_TM_GMTOFF_IN_TM 1 [ 165s] | [ 165s] | configure: exit 0 [ 165s] [ 165s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 165s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 165s] make: *** [debian/rules:13: build] Error 2 [ 165s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 165s] [ 165s] lamb59 failed "build openbsc_1.2.0.dsc" at Tue Jul 9 04:40:42 UTC 2019. [ 165s] [ 165s] ### VM INTERACTION START ### [ 167s] [ 154.244849] sysrq: SysRq : Power Off [ 167s] [ 154.249942] reboot: Power down [ 167s] ### VM INTERACTION END ### [ 167s] [ 168s] lamb59 failed "build openbsc_1.2.0.dsc" at Tue Jul 9 04:40:46 UTC 2019. [ 168s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 04:45:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 04:45:50 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d241c0581820_3358c4860063571@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 298s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o ran_msg_a.o ran_msg_a.c [ 299s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o ran_peer.o ran_peer.c [ 299s] In file included from /usr/include/osmocom/core/fsm.h:12, [ 299s] from ran_peer.c:25: [ 299s] ran_peer.c: In function 'ran_peer_st_ready': [ 299s] ran_peer.c:374:3: error: expected ';' before 'do' [ 299s] OSMO_ASSERT(!ctx->conn); [ 299s] ^~~~~~~~~~~ [ 299s] make[4]: *** [Makefile:570: ran_peer.o] Error 1 [ 299s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 299s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 299s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 299s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 299s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 299s] make[1]: *** [Makefile:394: all] Error 2 [ 299s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 299s] dh_auto_build: make -j1 returned exit code 2 [ 299s] make: *** [debian/rules:45: build] Error 2 [ 299s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 299s] [ 299s] lamb57 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 04:45:28 UTC 2019. [ 299s] [ 299s] ### VM INTERACTION START ### [ 302s] [ 286.016821] sysrq: SysRq : Power Off [ 302s] [ 286.023737] reboot: Power down [ 302s] ### VM INTERACTION END ### [ 302s] [ 302s] lamb57 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 04:45:32 UTC 2019. [ 302s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 06:03:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 06:03:50 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_9.0/armv7l In-Reply-To: References: Message-ID: <5d242e4ea4d29_3358c486006508b5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-remsim failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 514s] Makefile:602: recipe for target 'rspro_util.lo' failed [ 514s] make[5]: *** [rspro_util.lo] Error 1 [ 514s] make[5]: Leaving directory '/usr/src/packages/BUILD/src' [ 514s] Makefile:743: recipe for target '../../src/libosmo-rspro.la' failed [ 514s] make[4]: *** [../../src/libosmo-rspro.la] Error 2 [ 514s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/bankd' [ 514s] Makefile:659: recipe for target 'all-recursive' failed [ 514s] make[3]: *** [all-recursive] Error 1 [ 514s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 514s] Makefile:460: recipe for target 'all-recursive' failed [ 514s] make[2]: *** [all-recursive] Error 1 [ 514s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 514s] Makefile:384: recipe for target 'all' failed [ 514s] make[1]: *** [all] Error 2 [ 514s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 514s] dh_auto_build: make -j1 returned exit code 2 [ 514s] debian/rules:12: recipe for target 'build' failed [ 514s] make: *** [build] Error 2 [ 515s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 515s] [ 515s] obs-arm-5 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 06:03:34 UTC 2019. [ 515s] [ 515s] ### VM INTERACTION START ### [ 518s] [ 484.034439] sysrq: SysRq : Power Off [ 518s] [ 484.043509] reboot: Power down [ 518s] ### VM INTERACTION END ### [ 518s] [ 518s] obs-arm-5 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 06:03:38 UTC 2019. [ 518s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 06:18:25 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 06:18:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2431b41a508_3358c486006516c7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 430s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 430s] } [ 430s] ^ [ 430s] Makefile:437: recipe for target 'measurement.o' failed [ 430s] make[4]: *** [measurement.o] Error 1 [ 430s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 430s] Makefile:385: recipe for target 'all-recursive' failed [ 430s] make[3]: *** [all-recursive] Error 1 [ 430s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 430s] Makefile:434: recipe for target 'all-recursive' failed [ 430s] make[2]: *** [all-recursive] Error 1 [ 430s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 430s] Makefile:366: recipe for target 'all' failed [ 430s] make[1]: *** [all] Error 2 [ 430s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 430s] dh_auto_build: make -j1 returned exit code 2 [ 430s] debian/rules:12: recipe for target 'build' failed [ 430s] make: *** [build] Error 2 [ 430s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 430s] [ 430s] armbuild02 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 06:18:10 UTC 2019. [ 430s] [ 430s] ### VM INTERACTION START ### [ 433s] [ 400.716446] sysrq: SysRq : Power Off [ 433s] [ 400.732769] reboot: Power down [ 433s] ### VM INTERACTION END ### [ 433s] [ 433s] armbuild02 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 06:18:13 UTC 2019. [ 433s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 06:19:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 06:19:50 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d24320b9817_3358c48600651827@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 516s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 517s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 517s] collect2: error: ld returned 1 exit status [ 517s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 517s] make[4]: *** [osmo-bts-virtual] Error 1 [ 517s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 517s] Makefile:385: recipe for target 'all-recursive' failed [ 517s] make[3]: *** [all-recursive] Error 1 [ 517s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 517s] Makefile:434: recipe for target 'all-recursive' failed [ 517s] make[2]: *** [all-recursive] Error 1 [ 517s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 517s] Makefile:366: recipe for target 'all' failed [ 517s] make[1]: *** [all] Error 2 [ 517s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 517s] dh_auto_build: make -j1 returned exit code 2 [ 517s] debian/rules:12: recipe for target 'build' failed [ 517s] make: *** [build] Error 2 [ 517s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 517s] [ 517s] armbuild13 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 06:19:34 UTC 2019. [ 517s] [ 517s] ### VM INTERACTION START ### [ 520s] [ 464.970205] sysrq: SysRq : Power Off [ 520s] [ 464.972782] reboot: Power down [ 520s] ### VM INTERACTION END ### [ 520s] [ 520s] armbuild13 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 06:19:37 UTC 2019. [ 520s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Jul 9 07:10:25 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Jul 2019 07:10:25 +0000 Subject: Change in ...libosmocore[master]: Revert "utils.h: require a semi colon after OSMO_ASSERT" Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14703 Change subject: Revert "utils.h: require a semi colon after OSMO_ASSERT" ...................................................................... Revert "utils.h: require a semi colon after OSMO_ASSERT" This reverts commit 4e284b637943980a405a8c44f2712b749ded428f. Unfortunately, some projects such as OsmoMSC, OsmoBTS and OpenBSC do contain OSMO_ASSERT statements without a semi colon. Thus, this change causes compilation errors when building them. Please note that only the OSMO_ASSERT's definition is reverted, while changes to other files (adding missing semicolons) are kept. Change-Id: I6da4d7397d993f6c1af658cb5ae1e49c92a1b350 --- M include/osmocom/core/utils.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/03/14703/1 diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h index 8585a6a..601bb56 100644 --- a/include/osmocom/core/utils.h +++ b/include/osmocom/core/utils.h @@ -98,9 +98,9 @@ * the predicate evaluates to false (0). */ #define OSMO_ASSERT(exp) \ - do if (!(exp)) { \ + if (!(exp)) { \ osmo_panic("Assert failed %s %s:%d\n", #exp, __FILE__, __LINE__); \ - } while(0) + } /*! duplicate a string using talloc and release its prior content (if any) * \param[in] ctx Talloc context to use for allocation -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6da4d7397d993f6c1af658cb5ae1e49c92a1b350 Gerrit-Change-Number: 14703 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 07:13:57 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Jul 2019 07:13:57 +0000 Subject: Change in ...osmo-msc[master]: Fix: add missing semicolons to OSMO_ASSERT statements In-Reply-To: References: Message-ID: Hello lynxis lazus, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/14702 to look at the new patch set (#2). Change subject: Fix: add missing semicolons to OSMO_ASSERT statements ...................................................................... Fix: add missing semicolons to OSMO_ASSERT statements Change-Id: I4fae5fbab5fdbcce35906601d4f1031d971f4931 --- M src/libmsc/ran_peer.c M tests/msc_vlr/msc_vlr_tests.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/02/14702/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4fae5fbab5fdbcce35906601d4f1031d971f4931 Gerrit-Change-Number: 14702 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Tue Jul 9 07:21:50 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 07:21:50 +0000 Subject: Build failure of network:osmocom:nightly/openbsc in Debian_9.0/armv7l In-Reply-To: References: Message-ID: <5d244093b5d5d_3358c486006563fe@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/armv7l Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 303s] bsc_nat_utils.c:210:2: error: expected ';' before '_talloc_free' [ 303s] talloc_free(cfg); [ 303s] ^ [ 303s] Makefile:514: recipe for target 'bsc_nat_utils.o' failed [ 303s] make[4]: *** [bsc_nat_utils.o] Error 1 [ 303s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-bsc_nat' [ 303s] Makefile:429: recipe for target 'all-recursive' failed [ 303s] make[3]: *** [all-recursive] Error 1 [ 303s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 303s] Makefile:455: recipe for target 'all-recursive' failed [ 303s] make[2]: *** [all-recursive] Error 1 [ 303s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 303s] Makefile:387: recipe for target 'all' failed [ 303s] make[1]: *** [all] Error 2 [ 303s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 303s] dh_auto_build: make -j1 returned exit code 2 [ 303s] debian/rules:13: recipe for target 'build' failed [ 303s] make: *** [build] Error 2 [ 303s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 303s] [ 303s] armbuild10 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 07:21:44 UTC 2019. [ 303s] [ 303s] ### VM INTERACTION START ### [ 306s] [ 265.867830] sysrq: SysRq : Power Off [ 306s] [ 265.869751] reboot: Power down [ 306s] ### VM INTERACTION END ### [ 306s] [ 306s] armbuild10 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 07:21:48 UTC 2019. [ 306s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 08:18:58 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 08:18:58 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_9.0/armv7l In-Reply-To: References: Message-ID: <5d244e0e2a8f9_3358c486006664fd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 753s] ran_peer.c:374:3: error: expected ';' before 'do' [ 753s] OSMO_ASSERT(!ctx->conn); [ 753s] ^ [ 753s] Makefile:538: recipe for target 'ran_peer.o' failed [ 753s] make[4]: *** [ran_peer.o] Error 1 [ 753s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 753s] Makefile:422: recipe for target 'all-recursive' failed [ 753s] make[3]: *** [all-recursive] Error 1 [ 753s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 753s] Makefile:462: recipe for target 'all-recursive' failed [ 753s] make[2]: *** [all-recursive] Error 1 [ 753s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 753s] Makefile:394: recipe for target 'all' failed [ 753s] make[1]: *** [all] Error 2 [ 753s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 753s] dh_auto_build: make -j1 returned exit code 2 [ 753s] debian/rules:45: recipe for target 'build' failed [ 753s] make: *** [build] Error 2 [ 753s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 753s] [ 753s] obs-arm-6 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 08:18:38 UTC 2019. [ 753s] [ 753s] ### VM INTERACTION START ### [ 756s] [ 720.072469] sysrq: SysRq : Power Off [ 756s] [ 720.087346] reboot: Power down [ 757s] ### VM INTERACTION END ### [ 757s] [ 757s] obs-arm-6 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 08:18:42 UTC 2019. [ 757s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 08:31:49 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 08:31:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2450fdaf3a7_3358c4860066853@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 657s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 657s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 657s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 657s] Makefile:442: recipe for target 'vlr.o' failed [ 657s] make[4]: *** [vlr.o] Error 1 [ 657s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 657s] Makefile:422: recipe for target 'all-recursive' failed [ 657s] make[3]: *** [all-recursive] Error 1 [ 657s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 657s] Makefile:462: recipe for target 'all-recursive' failed [ 657s] make[2]: *** [all-recursive] Error 1 [ 657s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 657s] Makefile:394: recipe for target 'all' failed [ 657s] make[1]: *** [all] Error 2 [ 657s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 657s] dh_auto_build: make -j1 returned exit code 2 [ 657s] debian/rules:45: recipe for target 'build' failed [ 657s] make: *** [build] Error 2 [ 657s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 657s] [ 657s] obs-arm-6 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 08:31:34 UTC 2019. [ 657s] [ 657s] ### VM INTERACTION START ### [ 661s] [ 615.239771] sysrq: SysRq : Power Off [ 661s] [ 615.273338] reboot: Power down [ 661s] ### VM INTERACTION END ### [ 661s] [ 661s] obs-arm-6 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 08:31:38 UTC 2019. [ 661s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 08:45:49 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 08:45:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d245448ac987_3358c4860067041b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 681s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 681s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 681s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 681s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 681s] make[4]: *** [gb_proxy.o] Error 1 [ 681s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 681s] Makefile:391: recipe for target 'all-recursive' failed [ 681s] make[3]: *** [all-recursive] Error 1 [ 681s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 681s] Makefile:453: recipe for target 'all-recursive' failed [ 681s] make[2]: *** [all-recursive] Error 1 [ 681s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 681s] Makefile:385: recipe for target 'all' failed [ 681s] make[1]: *** [all] Error 2 [ 681s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 681s] dh_auto_build: make -j1 returned exit code 2 [ 681s] debian/rules:45: recipe for target 'build' failed [ 681s] make: *** [build] Error 2 [ 681s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 681s] [ 681s] armbuild13 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Tue Jul 9 08:45:33 UTC 2019. [ 681s] [ 681s] ### VM INTERACTION START ### [ 684s] [ 627.430184] sysrq: SysRq : Power Off [ 684s] [ 627.432737] reboot: Power down [ 685s] ### VM INTERACTION END ### [ 685s] [ 685s] armbuild13 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Tue Jul 9 08:45:37 UTC 2019. [ 685s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:22:52 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Jul 2019 09:22:52 +0000 Subject: Change in ...osmo-pcu[master]: src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14704 Change subject: src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF ...................................................................... src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF The recent versions of OsmoBTS do provide the following measurements: - RSSI (Received Signal Strength Indication), - ToA (Timing of Arrival), - BER (Bit Error Rate), as well as C/I (Carrier-to-Interference ratio) since [1] (OS#4006). [1] https://gerrit.osmocom.org/r/Ia58043bd2381a4d34d604522e02899ae64ee0d26 Change-Id: I0fd6c35e8cf0b1314f4e3c336b233b5f7e42dfc6 Related: OS#1855 --- M src/pcu_l1_if.cpp 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/04/14704/1 diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 5cabe4f..bc712fd 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -289,14 +289,14 @@ switch (data_ind->sapi) { case PCU_IF_SAPI_PDTCH: meas.set_rssi(data_ind->rssi); -#ifndef ENABLE_DIRECT_PHY /* convert BER to % value */ meas.set_ber(data_ind->ber10k / 100); meas.set_bto(data_ind->ta_offs_qbits); meas.set_link_qual(data_ind->lqual_cb / 10); + LOGP(DL1IF, LOGL_DEBUG, "Data indication with raw measurements received: BER10k = %d, BTO = %d, Q = %d\n", data_ind->ber10k, data_ind->ta_offs_qbits, data_ind->lqual_cb); -#endif + rc = pcu_rx_data_ind_pdtch(data_ind->trx_nr, data_ind->ts_nr, data_ind->data, data_ind->len, data_ind->fn, &meas); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0fd6c35e8cf0b1314f4e3c336b233b5f7e42dfc6 Gerrit-Change-Number: 14704 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:23:26 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 09:23:26 +0000 Subject: Change in ...libosmocore[master]: Revert "utils.h: require a semi colon after OSMO_ASSERT" In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14703 ) Change subject: Revert "utils.h: require a semi colon after OSMO_ASSERT" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6da4d7397d993f6c1af658cb5ae1e49c92a1b350 Gerrit-Change-Number: 14703 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jul 2019 09:23:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:29:24 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 09:29:24 +0000 Subject: Change in ...osmo-pcu[master]: src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14704 ) Change subject: src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14704/1/src/pcu_l1_if.cpp File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/#/c/14704/1/src/pcu_l1_if.cpp at 296 PS1, Line 296: (unrelated change) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0fd6c35e8cf0b1314f4e3c336b233b5f7e42dfc6 Gerrit-Change-Number: 14704 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: osmith Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 09 Jul 2019 09:29:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:37:03 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 09:37:03 +0000 Subject: Change in ...libosmocore[master]: Revert "utils.h: require a semi colon after OSMO_ASSERT" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14703 ) Change subject: Revert "utils.h: require a semi colon after OSMO_ASSERT" ...................................................................... Revert "utils.h: require a semi colon after OSMO_ASSERT" This reverts commit 4e284b637943980a405a8c44f2712b749ded428f. Unfortunately, some projects such as OsmoMSC, OsmoBTS and OpenBSC do contain OSMO_ASSERT statements without a semi colon. Thus, this change causes compilation errors when building them. Please note that only the OSMO_ASSERT's definition is reverted, while changes to other files (adding missing semicolons) are kept. Change-Id: I6da4d7397d993f6c1af658cb5ae1e49c92a1b350 --- M include/osmocom/core/utils.h 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h index 8585a6a..601bb56 100644 --- a/include/osmocom/core/utils.h +++ b/include/osmocom/core/utils.h @@ -98,9 +98,9 @@ * the predicate evaluates to false (0). */ #define OSMO_ASSERT(exp) \ - do if (!(exp)) { \ + if (!(exp)) { \ osmo_panic("Assert failed %s %s:%d\n", #exp, __FILE__, __LINE__); \ - } while(0) + } /*! duplicate a string using talloc and release its prior content (if any) * \param[in] ctx Talloc context to use for allocation -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6da4d7397d993f6c1af658cb5ae1e49c92a1b350 Gerrit-Change-Number: 14703 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:39:25 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 09:39:25 +0000 Subject: Change in ...osmo-msc[master]: libmsc/msc_vty.c: print subscriber expiration time In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14701 ) Change subject: libmsc/msc_vty.c: print subscriber expiration time ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14701 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I092691a8c443f4c5ed4d33de2e551fef592c1baf Gerrit-Change-Number: 14701 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 09 Jul 2019 09:39:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:41:37 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 09:41:37 +0000 Subject: Change in ...libosmocore[master]: Revert "utils.h: require a semi colon after OSMO_ASSERT" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14703 ) Change subject: Revert "utils.h: require a semi colon after OSMO_ASSERT" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6da4d7397d993f6c1af658cb5ae1e49c92a1b350 Gerrit-Change-Number: 14703 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jul 2019 09:41:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:42:42 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 09:42:42 +0000 Subject: Change in ...osmo-msc[master]: Fix: add missing semicolons to OSMO_ASSERT statements In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14702 ) Change subject: Fix: add missing semicolons to OSMO_ASSERT statements ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4fae5fbab5fdbcce35906601d4f1031d971f4931 Gerrit-Change-Number: 14702 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 09 Jul 2019 09:42:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:43:40 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 09:43:40 +0000 Subject: Change in ...libosmocore[master]: libosmogsm/l1sap.h: extend ph_rach_ind_param with lqual_cb In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14683 ) Change subject: libosmogsm/l1sap.h: extend ph_rach_ind_param with lqual_cb ...................................................................... Patch Set 1: Code-Review+1 do we have to care about forward/backward compatibility here? I think we don't, as L1SAP is always implemented inside one given program (Osmo-BTS) and hence all code uses the same definitions? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie2a66ebd040b61d6daf49e04bf8a84d3d64764ee Gerrit-Change-Number: 14683 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jul 2019 09:43:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:43:58 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 09:43:58 +0000 Subject: Change in ...libosmocore[master]: libosmogsm/l1sap.h: extend ph_rach_ind_param with lqual_cb In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14683 ) Change subject: libosmogsm/l1sap.h: extend ph_rach_ind_param with lqual_cb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie2a66ebd040b61d6daf49e04bf8a84d3d64764ee Gerrit-Change-Number: 14683 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jul 2019 09:43:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:44:46 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 09:44:46 +0000 Subject: Change in ...osmo-bsc[master]: remove double BSSMAP Clear on HO failure In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14700 ) Change subject: remove double BSSMAP Clear on HO failure ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14700 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iac1519eb8b24e8523caec682f9ac8e6dcf1327ce Gerrit-Change-Number: 14700 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jul 2019 09:44:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:45:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 09:45:05 +0000 Subject: Change in ...osmo-bsc[master]: make bsc_clear_request() static In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14699 ) Change subject: make bsc_clear_request() static ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic89d0afad42e4b11183a13d2dc6b7bbf0b822fd9 Gerrit-Change-Number: 14699 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jul 2019 09:45:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:45:07 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 09:45:07 +0000 Subject: Change in ...osmo-bsc[master]: make bsc_clear_request() static In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14699 ) Change subject: make bsc_clear_request() static ...................................................................... make bsc_clear_request() static bsc_clear_request() is in fact used only within gsm_08_08.c, make it static to that file. Since the gscon FSM, "real" BSSMAP Clear are sent only by gscon_bssmap_clear(). bsc_clear_request() remains in use for legacy code paths in gsm_08_08.c: - the bsc_filter, i.e. for IMSI filtering; - in move_to_msc(), from handle_cc_setup(), a code path that is in fact not entirely clear to me. It seems to be an old functionality to serve multiple MSCs? Both of which I personally haven't seen in use, are not tested and should probably be completely removed. For now contain legacy code in the static context. Adjust comment. Change-Id: Ic89d0afad42e4b11183a13d2dc6b7bbf0b822fd9 --- M include/osmocom/bsc/gsm_08_08.h M src/osmo-bsc/gsm_08_08.c M tests/bsc/bsc_test.c M tests/handover/handover_test.c 4 files changed, 4 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/bsc/gsm_08_08.h b/include/osmocom/bsc/gsm_08_08.h index 5241295..b46a8d3 100644 --- a/include/osmocom/bsc/gsm_08_08.h +++ b/include/osmocom/bsc/gsm_08_08.h @@ -10,7 +10,6 @@ void bsc_cipher_mode_compl(struct gsm_subscriber_connection *conn, struct msgb *msg, uint8_t chosen_encr); int bsc_compl_l3(struct gsm_subscriber_connection *conn, struct msgb *msg, uint16_t chosen_channel); void bsc_dtap(struct gsm_subscriber_connection *conn, uint8_t link_id, struct msgb *msg); -int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause); void bsc_cm_update(struct gsm_subscriber_connection *conn, const uint8_t *cm2, uint8_t cm2_len, const uint8_t *cm3, uint8_t cm3_len); diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c index 2c6a689..6ca5455 100644 --- a/src/osmo-bsc/gsm_08_08.c +++ b/src/osmo-bsc/gsm_08_08.c @@ -509,6 +509,8 @@ return false; } +static int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause); + /* * Plastic surgery... we want to give up the current connection */ @@ -635,8 +637,8 @@ return; } -/*! BSC->MSC: RR conn has been cleared. */ -int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause) +/*! BSSMAP Clear Request for legacy code paths, instead see gscon_bssmap_clear(). */ +static int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause) { int rc; struct msgb *resp; diff --git a/tests/bsc/bsc_test.c b/tests/bsc/bsc_test.c index 8e88ba8..492f0c5 100644 --- a/tests/bsc/bsc_test.c +++ b/tests/bsc/bsc_test.c @@ -243,8 +243,6 @@ void bsc_dtap(struct gsm_subscriber_connection *conn, uint8_t link_id, struct msgb *msg) {} void bsc_assign_compl(struct gsm_subscriber_connection *conn, uint8_t rr_cause) {} void bsc_assign_fail(struct gsm_subscriber_connection *conn, uint8_t cause, uint8_t *rr_cause) {} -int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause) -{ return 0; } void bsc_cm_update(struct gsm_subscriber_connection *conn, const uint8_t *cm2, uint8_t cm2_len, const uint8_t *cm3, uint8_t cm3_len) {} diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index a8a77be..bedf6f9 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -1779,8 +1779,6 @@ { return 0; } void bsc_dtap(struct gsm_subscriber_connection *conn, uint8_t link_id, struct msgb *msg) {} void bsc_assign_compl(struct gsm_subscriber_connection *conn, uint8_t rr_cause) {} -int bsc_clear_request(struct gsm_subscriber_connection *conn, uint32_t cause) -{ return 0; } void bsc_cm_update(struct gsm_subscriber_connection *conn, const uint8_t *cm2, uint8_t cm2_len, const uint8_t *cm3, uint8_t cm3_len) {} -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14699 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic89d0afad42e4b11183a13d2dc6b7bbf0b822fd9 Gerrit-Change-Number: 14699 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:46:19 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 09:46:19 +0000 Subject: Change in ...osmo-bsc[master]: remove double BSSMAP Clear on HO failure In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14700 ) Change subject: remove double BSSMAP Clear on HO failure ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14700 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iac1519eb8b24e8523caec682f9ac8e6dcf1327ce Gerrit-Change-Number: 14700 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 09 Jul 2019 09:46:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:51:45 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 09:51:45 +0000 Subject: Change in ...osmo-bsc[master]: doc/manuals, vty doc: more handover doc clarifications In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14582 ) Change subject: doc/manuals, vty doc: more handover doc clarifications ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1639efb2dbcca4f0e9c33a74f3067606ce5f4209 Gerrit-Change-Number: 14582 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jul 2019 09:51:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:54:09 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 09:54:09 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: ACK/NACK: always encode with length field present In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14697 ) Change subject: Encoding: ACK/NACK: always encode with length field present ...................................................................... Patch Set 1: Code-Review+1 it might be worth stating something like "rather than fixing the encoding without length field, let's simply always encode the length field" to the commit log, and have a related comment in the source code indicating that the spec permits for encoding without length field, could be as simple as "/* TODO: implement encoding of ACK/NACK without length field */" -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb Gerrit-Change-Number: 14697 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jul 2019 09:54:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:55:04 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 09:55:04 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14696 ) Change subject: Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for rest_bits ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14696 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic350b0365b125638a6c752f692bef981ad6b9d89 Gerrit-Change-Number: 14696 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jul 2019 09:55:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:56:28 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 09:56:28 +0000 Subject: Change in ...osmo-pcu[master]: src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14704 ) Change subject: src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0fd6c35e8cf0b1314f4e3c336b233b5f7e42dfc6 Gerrit-Change-Number: 14704 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 09 Jul 2019 09:56:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:56:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 09:56:56 +0000 Subject: Change in ...osmo-msc[master]: libmsc/msc_vty.c: print subscriber expiration time In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14701 ) Change subject: libmsc/msc_vty.c: print subscriber expiration time ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14701 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I092691a8c443f4c5ed4d33de2e551fef592c1baf Gerrit-Change-Number: 14701 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 09 Jul 2019 09:56:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 09:57:17 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 09:57:17 +0000 Subject: Change in ...osmo-msc[master]: Fix: add missing semicolons to OSMO_ASSERT statements In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14702 ) Change subject: Fix: add missing semicolons to OSMO_ASSERT statements ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4fae5fbab5fdbcce35906601d4f1031d971f4931 Gerrit-Change-Number: 14702 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 09 Jul 2019 09:57:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 11:24:32 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 11:24:32 +0000 Subject: Change in ...osmo-python-tests[master]: tweak README In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/14698 ) Change subject: tweak README ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/14698 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: Id8c277de280b54d04edcafa77ed93017d6da473d Gerrit-Change-Number: 14698 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jul 2019 11:24:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 11:24:57 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 11:24:57 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: cosmetic: move TC_gsup_mt_multi_part_sms() back In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14695 ) Change subject: MSC_Tests.ttcn: cosmetic: move TC_gsup_mt_multi_part_sms() back ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14695 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic8d456f4becade9010d4eb27159e6c2806b11810 Gerrit-Change-Number: 14695 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jul 2019 11:24:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 11:25:00 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 11:25:00 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: cosmetic: move TC_gsup_mt_multi_part_sms() back In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14695 ) Change subject: MSC_Tests.ttcn: cosmetic: move TC_gsup_mt_multi_part_sms() back ...................................................................... MSC_Tests.ttcn: cosmetic: move TC_gsup_mt_multi_part_sms() back The mentioned test case doesn't cause any problems anymore. Change-Id: Ic8d456f4becade9010d4eb27159e6c2806b11810 --- M msc/MSC_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 4b00e34..f551513 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -5593,6 +5593,7 @@ execute( TC_gsup_mt_sms_err() ); execute( TC_gsup_mt_sms_rp_mr() ); execute( TC_gsup_mo_mt_sms_rp_mr() ); + execute( TC_gsup_mt_multi_part_sms() ); execute( TC_lu_and_mo_ussd_single_request() ); execute( TC_lu_and_mt_ussd_notification() ); @@ -5643,7 +5644,6 @@ /* Run this last: at the time of writing this test crashes the MSC */ execute( TC_lu_imsi_auth_tmsi_encr_3_1_log_msc_debug() ); - execute( TC_gsup_mt_multi_part_sms() ); execute( TC_mo_cc_bssmap_clear() ); if (mp_enable_osmux_test) { execute( TC_lu_and_mt_call_osmux() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14695 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic8d456f4becade9010d4eb27159e6c2806b11810 Gerrit-Change-Number: 14695 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 11:25:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 11:25:36 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: L3_Templates: fix IMEI length: 14 (not 15) In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14693 ) Change subject: L3_Templates: fix IMEI length: 14 (not 15) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7121f29a90f19d92c7bf26f26e76f1978c648459 Gerrit-Change-Number: 14693 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 09 Jul 2019 11:25:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 11:25:40 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 11:25:40 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: L3_Templates: fix IMEI length: 14 (not 15) In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14693 ) Change subject: L3_Templates: fix IMEI length: 14 (not 15) ...................................................................... L3_Templates: fix IMEI length: 14 (not 15) The right length is 14. The 15th additional checksum digit is not intended for digital transmission. A good overview of the IMEI/IMEISV structure is here: https://en.wikipedia.org/wiki/International_Mobile_Equipment_Identity#Structure_of_the_IMEI_and_IMEISV_(IMEI_software_version) Related: Iaf2569c099874b55acbd748b776394726cc5ce54 (osmo-msc) Change-Id: I7121f29a90f19d92c7bf26f26e76f1978c648459 --- M library/L3_Templates.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index a2fe67a..6af020b 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -2779,7 +2779,7 @@ } function f_gen_imei(integer suffix) return hexstring { - return f_concat_pad(15, '49999'H, suffix); + return f_concat_pad(14, '49999'H, suffix); } function f_gen_imsi(integer suffix) return hexstring { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7121f29a90f19d92c7bf26f26e76f1978c648459 Gerrit-Change-Number: 14693 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 11:27:31 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 11:27:31 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: add check IMEI tests In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 ) Change subject: msc: add check IMEI tests ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d Gerrit-Change-Number: 14694 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 09 Jul 2019 11:27:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 11:30:03 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 11:30:03 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14586 ) Change subject: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7080effbbc1022d1884c6d6f0cb580eba8e514ff Gerrit-Change-Number: 14586 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jul 2019 11:30:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 11:30:51 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 9 Jul 2019 11:30:51 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14585 ) Change subject: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I164f5ae4ce7694d6e324aab927a04e96d489ebd8 Gerrit-Change-Number: 14585 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jul 2019 11:30:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 12:06:23 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 12:06:23 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: add check IMEI tests In-Reply-To: References: Message-ID: Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 to look at the new patch set (#3). Change subject: msc: add check IMEI tests ...................................................................... msc: add check IMEI tests Extend BSC_ConnHdlr with new check IMEI related parameters. Add tests for check IMEI and check IMEI early for multiple auth variations, as well as variants where the HLR would respond with NOK or ERR. Note that we can safely set "check-imei-rqd 0" in f_init(), because the latest OsmoMSC version already suppors this VTY command. Two tests do not always pass, sometimes the RAN connection breaks before the test finishes (TC_lu_imsi_auth_tmsi_check_imei_err and TC_lu_imsi_auth_tmsi_check_imei_nack). I have added them as expected errors in the expected-results.xml. Related: OS#2542 Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d --- M library/GSUP_Types.ttcn M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn M msc/expected-results.xml 4 files changed, 420 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/14694/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d Gerrit-Change-Number: 14694 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 12:06:26 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 12:06:26 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: Cosmetic: L3_Templates: fix comment: fro -> for Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14705 Change subject: Cosmetic: L3_Templates: fix comment: fro -> for ...................................................................... Cosmetic: L3_Templates: fix comment: fro -> for Change-Id: I239bbf21202300ac9883b5a0b5608d10db0fd721 --- M library/L3_Templates.ttcn 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/14705/1 diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index 6af020b..b39bb7a 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -54,7 +54,7 @@ } -/* send template fro Mobile Identity (TMSI) */ +/* send template for Mobile Identity (TMSI) */ template MobileIdentityLV ts_MI_TMSI_LV(OCT4 tmsi) := { lengthIndicator := 0, /* overwritten */ mobileIdentityV := { @@ -69,7 +69,7 @@ } } -/* send template fro Mobile Identity (TMSI) */ +/* send template for Mobile Identity (TMSI) */ function ts_MI_TMSI_TLV(template (omit) OCT4 tmsi) return template (omit) MobileIdentityTLV { var template (omit) MobileIdentityTLV ret; if (istemplatekind(tmsi, "omit")) { @@ -129,7 +129,7 @@ return l3; } -/* send template fro Mobile Identity (IMSI) */ +/* send template for Mobile Identity (IMSI) */ template (value) MobileIdentityLV ts_MI_IMSI_LV(hexstring imsi_digits) := { lengthIndicator := 0, /* overwritten */ mobileIdentityV := { @@ -140,7 +140,7 @@ } } -/* send template fro Mobile Identity (IMEI) */ +/* send template for Mobile Identity (IMEI) */ template (value) MobileIdentityLV ts_MI_IMEI_LV(hexstring imei_digits) := { lengthIndicator := 0, /* overwritten */ mobileIdentityV := { @@ -151,7 +151,7 @@ } } -/* send template fro Mobile Identity (IMEISV) */ +/* send template for Mobile Identity (IMEISV) */ template (value) MobileIdentityLV ts_MI_IMEISV_LV(hexstring imei_digits) := { lengthIndicator := 0, /* overwritten */ mobileIdentityV := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I239bbf21202300ac9883b5a0b5608d10db0fd721 Gerrit-Change-Number: 14705 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 12:06:26 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 12:06:26 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: L3_Templates: add enum CmIdentityType Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14706 Change subject: L3_Templates: add enum CmIdentityType ...................................................................... L3_Templates: add enum CmIdentityType Change-Id: Ibe50669663e641cdfd6a88f22c5404e2d90323b7 --- M library/L3_Templates.ttcn M msc/MSC_Tests.ttcn 2 files changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/06/14706/1 diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index b39bb7a..3011919 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -35,6 +35,15 @@ CM_TYPE_LCS ('1011'B) } +/* TS 24.008 10.5.3.4 Identity Type */ +type enumerated CmIdentityType { + CM_ID_TYPE_IMSI ('001'B), + CM_ID_TYPE_IMEI ('010'B), + CM_ID_TYPE_IMEISV ('011'B), + CM_ID_TYPE_TMSI ('100'B), + CM_ID_TYPE_PTMSI_RAI_PTMSI_SIG ('101'B) +} + template ML3_Cause_TLV ts_ML3_Cause(BIT7 cause, BIT4 loc := '0001'B, BIT2 std := '11'B) := { elementIdentifier := '08'O, lengthIndicator := 0, /* overwritten */ @@ -864,7 +873,7 @@ } } -template PDU_ML3_NW_MS tr_ML3_MT_MM_ID_Req(template BIT3 id_type := ?) := { +template PDU_ML3_NW_MS tr_ML3_MT_MM_ID_Req(template CmIdentityType id_type := ?) := { discriminator := '0101'B, tiOrSkip := { skipIndicator := '0000'B @@ -874,7 +883,7 @@ identityRequest := { messageType := '011000'B, nsd := '00'B, - identityType := id_type, + identityType := int2bit(enum2int(valueof(id_type)), 3), spare1_5 := ? } } diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index f551513..6f9eecd 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -817,7 +817,7 @@ BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); /* Wait for + respond to ID REQ (IMSI) */ - BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req('001'B))); + BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req(CM_ID_TYPE_IMSI))); BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_MM_ID_Rsp_IMSI(overlong_imsi))); /* test for OS#2864 */ BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_MM_ID_Rsp_IMSI(g_pars.imsi))); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14706 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibe50669663e641cdfd6a88f22c5404e2d90323b7 Gerrit-Change-Number: 14706 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 12:09:56 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 12:09:56 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: add check IMEI tests In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 ) Change subject: msc: add check IMEI tests ...................................................................... Patch Set 3: (1 comment) Updated to use the new CmIdentityType. https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/#/c/14694/2/msc/BSC_ConnectionHandler.ttcn at 452 PS2, Line 452: '010'B /* IMEI */ > Would be great to have an enumerated type for that later on. Done: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14706 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d Gerrit-Change-Number: 14694 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 09 Jul 2019 12:09:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 12:14:52 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 12:14:52 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/gsm_shared.py: introduce a new enum TrainingSeqGMSK In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14690 ) Change subject: trx_toolkit/gsm_shared.py: introduce a new enum TrainingSeqGMSK ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If3bf102019ef53d6ee9ad230ef98bb45845b5af5 Gerrit-Change-Number: 14690 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 09 Jul 2019 12:14:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 12:17:06 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 12:17:06 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/rand_burst_gen.py: use TrainingSeqGMSK and BurstType enums In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14691 ) Change subject: trx_toolkit/rand_burst_gen.py: use TrainingSeqGMSK and BurstType enums ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14691 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8a3faceae4a8d9b57d86d42600db839da073dad6 Gerrit-Change-Number: 14691 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 09 Jul 2019 12:17:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 12:29:42 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 12:29:42 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14585 ) Change subject: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support ...................................................................... Patch Set 4: (1 comment) No +1 because of return None instead of return False, other than that everything looks good to me. https://gerrit.osmocom.org/#/c/14585/2/src/target/trx_toolkit/data_if.py File src/target/trx_toolkit/data_if.py: https://gerrit.osmocom.org/#/c/14585/2/src/target/trx_toolkit/data_if.py at 53 PS2, Line 53: return None > return False I agree, "return False" makes more sense here. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I164f5ae4ce7694d6e324aab927a04e96d489ebd8 Gerrit-Change-Number: 14585 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Comment-Date: Tue, 09 Jul 2019 12:29:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 12:37:33 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Jul 2019 12:37:33 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support In-Reply-To: References: Message-ID: Hello pespin, laforge, Jenkins Builder, Hoernchen, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/14585 to look at the new patch set (#5). Change subject: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support ...................................................................... trx_toolkit/fake_trx.py: basic TRXD version 0x01 support Since the new TRXD header format has been introduced, FakeTRX needs to be able to fill it correctly. In particular, the following: - Modulation, which can be determined from the burst length; - Training Sequence Code (and set), which needs to be detected by comparing the burst bits of L12TRX message against known training sequences (only GMSK and the default TS set for now); - C/I (Carrier-to-Interference ratio), which can be simulated later on, as instructed on the TRXC interface ('FAKE_CI'). The actual TRXD header version is stored in the instance of class DATAInterface. By default (at startup), legacy version 0 is used. The version negotiation is supposed to be performed on the TRXC interface, and to be implemented in a follow-up change. Different Transceivers may use different header versions, thus in FakeTRX.send_data_msg() we need to override the original version of the L12TRX message, and generate the corresponding PDU. Limitations: - NOPE / IDLE indications are not (yet) supported; - TSC detection: GMSK modulation only. Change-Id: I164f5ae4ce7694d6e324aab927a04e96d489ebd8 Related: OS#4006 --- M src/target/trx_toolkit/burst_fwd.py M src/target/trx_toolkit/data_if.py M src/target/trx_toolkit/fake_trx.py 3 files changed, 78 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/85/14585/5 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I164f5ae4ce7694d6e324aab927a04e96d489ebd8 Gerrit-Change-Number: 14585 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 12:44:36 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Jul 2019 12:44:36 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14585 ) Change subject: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14585/2/src/target/trx_toolkit/data_if.py File src/target/trx_toolkit/data_if.py: https://gerrit.osmocom.org/#/c/14585/2/src/target/trx_toolkit/data_if.py at 53 PS2, Line 53: return None > I agree, "return False" makes more sense here. I forgot to fix this, thanks! -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I164f5ae4ce7694d6e324aab927a04e96d489ebd8 Gerrit-Change-Number: 14585 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Comment-Date: Tue, 09 Jul 2019 12:44:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 12:46:48 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Jul 2019 12:46:48 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/14692 to look at the new patch set (#3). Change subject: trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation ...................................................................... trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation Messages on DATA interface may have different header formats, defined by a version number, which can be negotiated on the control interface. By default, the Transceiver will use the legacy header version (0). The header format negotiation can be initiated by the L1 using the 'SETFORMAT' command. If the requested version is not supported by the transceiver, status code of the response message should indicate a preferred (basically, the latest) version. The format of this message is the following: L1 -> TRX: CMD SETFORMAT VER_REQ L1 <- TRX: RSP SETFORMAT VER_RSP VER_REQ where: - VER_REQ is the requested version (suggested by the L1), - VER_RSP is either the applied version if matches VER_REQ, or a preferred version if VER_REQ is not supported. If the transceiver indicates VER_RSP different than VER_REQ, the L1 is supposed to reinitiate the version negotiation using the suggested VER_RSP. For example: L1 -> TRX: CMD SETFORMAT 2 L1 <- TRX: RSP SETFORMAT 1 2 L1 -> TRX: CMD SETFORMAT 1 L1 <- TRX: RSP SETFORMAT 1 1 If no suitable VER_RSP is found, or the VER_REQ is incorrect, the status code in the response shall be -1. As soon as VER_RSP matches VER_REQ in the response, the process of negotiation is complete. Changing the header version is supposed to be done before POWERON, but can be also done after. Change-Id: I8d441b2559863d2dbd680db371062e4f3a2f9ff9 Related: OS#4006 --- M src/target/trx_toolkit/ctrl_if_trx.py M src/target/trx_toolkit/data_if.py 2 files changed, 75 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/92/14692/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8d441b2559863d2dbd680db371062e4f3a2f9ff9 Gerrit-Change-Number: 14692 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 12:51:00 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 12:51:00 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14586 ) Change subject: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation ...................................................................... Patch Set 6: Code-Review+1 Code looks good! Maybe it is worth logging the new ci_base and ci_rand_threshold values? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7080effbbc1022d1884c6d6f0cb580eba8e514ff Gerrit-Change-Number: 14586 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jul 2019 12:51:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 12:52:43 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 12:52:43 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14585 ) Change subject: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I164f5ae4ce7694d6e324aab927a04e96d489ebd8 Gerrit-Change-Number: 14585 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jul 2019 12:52:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 12:56:29 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 12:56:29 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14692 ) Change subject: trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8d441b2559863d2dbd680db371062e4f3a2f9ff9 Gerrit-Change-Number: 14692 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jul 2019 12:56:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 13:13:57 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 9 Jul 2019 13:13:57 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14586 ) Change subject: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation ...................................................................... Patch Set 6: > Maybe it is worth logging the new ci_base and ci_rand_threshold values? ACK, but in a separate change, and not only C/I ;) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7080effbbc1022d1884c6d6f0cb580eba8e514ff Gerrit-Change-Number: 14586 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 09 Jul 2019 13:13:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 13:26:31 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 9 Jul 2019 13:26:31 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: log_merge.sh: format logs after merging Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 Change subject: log_merge.sh: format logs after merging ...................................................................... log_merge.sh: format logs after merging Related: OS#3916 Change-Id: I671ffa2761c6e503dae9f3b16764d430131b16af --- M log_merge.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/07/14707/1 diff --git a/log_merge.sh b/log_merge.sh index 886b788..7d042f9 100755 --- a/log_merge.sh +++ b/log_merge.sh @@ -36,6 +36,8 @@ PREFIX="$BASE_NAME-$t" OUTPUT="$BASE_NAME.$t.merged" ttcn3_logmerge $PREFIX-*.log > "$OUTPUT" + ttcn3_logformat "$OUTPUT" > "_$OUTPUT" + mv "_$OUTPUT" "$OUTPUT" echo "Generated $OUTPUT" done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I671ffa2761c6e503dae9f3b16764d430131b16af Gerrit-Change-Number: 14707 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 14:56:23 2019 From: gerrit-no-reply at lists.osmocom.org (roh) Date: Tue, 9 Jul 2019 14:56:23 +0000 Subject: Change in ...osmo-remsim[master]: add examples to the command line options for remsim-bankd and remsim-... In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/14667 to look at the new patch set (#2). Change subject: add examples to the command line options for remsim-bankd and remsim-client ...................................................................... add examples to the command line options for remsim-bankd and remsim-client Change-Id: Idfa6352ce90dd36dd27306d6c8a2023935ed822d --- M contrib/etc_default/osmo-remsim-client-0 M contrib/etc_default/osmo-remsim-client-1 M contrib/etc_default/osmo-remsim-client-2 M contrib/etc_default/osmo-remsim-client-3 M contrib/systemd/osmo-remsim-client at .service M doc/manuals/chapters/remsim-bankd.adoc M doc/manuals/chapters/remsim-client.adoc 7 files changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/67/14667/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14667 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Idfa6352ce90dd36dd27306d6c8a2023935ed822d Gerrit-Change-Number: 14667 Gerrit-PatchSet: 2 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 14:56:23 2019 From: gerrit-no-reply at lists.osmocom.org (roh) Date: Tue, 9 Jul 2019 14:56:23 +0000 Subject: Change in ...osmo-remsim[master]: add examples to remsim-server (json output) In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/14668 to look at the new patch set (#2). Change subject: add examples to remsim-server (json output) ...................................................................... add examples to remsim-server (json output) Change-Id: I102a79a5d1f0055586a9fa1f9688acd4258f585b --- M doc/manuals/chapters/remsim-server.adoc 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/68/14668/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I102a79a5d1f0055586a9fa1f9688acd4258f585b Gerrit-Change-Number: 14668 Gerrit-PatchSet: 2 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 15:42:38 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Jul 2019 15:42:38 +0000 Subject: Change in ...osmo-bsc[master]: doc/manuals, vty doc: more handover doc clarifications In-Reply-To: References: Message-ID: neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14582 ) Change subject: doc/manuals, vty doc: more handover doc clarifications ...................................................................... doc/manuals, vty doc: more handover doc clarifications Related: OS#3487 Change-Id: I1639efb2dbcca4f0e9c33a74f3067606ce5f4209 --- M doc/manuals/chapters/handover.adoc M include/osmocom/bsc/handover_cfg.h M src/osmo-bsc/handover_vty.c M tests/handover_cfg.vty 4 files changed, 55 insertions(+), 49 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/handover.adoc b/doc/manuals/chapters/handover.adoc index 2f9d598..bb99751 100644 --- a/doc/manuals/chapters/handover.adoc +++ b/doc/manuals/chapters/handover.adoc @@ -434,7 +434,8 @@ Configuration settings relevant for algorithm 1 start with `handover1`. For further details, please refer to the OsmoBSC VTY Reference -(<>) or the telnet VTY online documentation. +(<>) or the telnet VTY online documentation. See the +`handover1` settings on the `config-net` and `config-net-bts` nodes. ==== Handover Algorithm 2 @@ -451,7 +452,8 @@ Configuration settings relevant for algorithm 2 start with `handover2`. For further details, please refer to the OsmoBSC VTY Reference -<> or the telnet VTY online documentation. +<> or the telnet VTY online documentation. See the `handover2` +settings on the `config-net` and `config-net-bts` nodes. ===== Load Distribution @@ -472,8 +474,8 @@ adhere to minimum reception levels and distance, see `min rxlev` and `max distance`. -Load distribution will take effect only for already established voice channels. -An MS will always first establish a voice call with its current cell choice; in +Load distribution will take effect only for already established channels. +For example, an MS will always first establish a voice call with its current cell choice; in load situations, it might be moved to another cell shortly after that. Considering the best neighbor _before_ starting a new voice call might be desirable, but is currently not implemented. Consider that RXLEV/RXQUAL ratings diff --git a/include/osmocom/bsc/handover_cfg.h b/include/osmocom/bsc/handover_cfg.h index 92b5cd4..f174aad 100644 --- a/include/osmocom/bsc/handover_cfg.h +++ b/include/osmocom/bsc/handover_cfg.h @@ -96,22 +96,22 @@ "handover1 ", "window rxlev averaging", "<1-10>", atoi, "%u", as_is, \ HO_CFG_STR_HANDOVER1 \ HO_CFG_STR_WIN_RXLEV \ - "How many RxLev measurements are used for averaging\n" \ + "How many RxLev measurements to use for averaging\n" \ "RxLev averaging: " HO_CFG_STR_AVG_COUNT) \ \ HO_CFG_ONE_MEMBER(unsigned int, hodec1_rxqual_avg_win, 1, \ "handover1 ", "window rxqual averaging", "<1-10>", atoi, "%u", as_is, \ HO_CFG_STR_HANDOVER1 \ HO_CFG_STR_WIN_RXQUAL \ - "How many RxQual measurements are used for averaging\n" \ + "How many RxQual measurements to use for averaging\n" \ "RxQual averaging: " HO_CFG_STR_AVG_COUNT) \ \ HO_CFG_ONE_MEMBER(unsigned int, hodec1_rxlev_neigh_avg_win, 10, \ "handover1 ", "window rxlev neighbor averaging", "<1-10>", atoi, "%u", as_is, \ HO_CFG_STR_HANDOVER1 \ HO_CFG_STR_WIN_RXLEV \ - "How many Neighbor RxLev measurements are used for averaging\n" \ - "How many Neighbor RxLev measurements are used for averaging\n" \ + "How many Neighbor RxLev measurements to use for averaging\n" \ + "How many Neighbor RxLev measurements to use for averaging\n" \ "Neighbor RxLev averaging: " HO_CFG_STR_AVG_COUNT) \ \ HO_CFG_ONE_MEMBER(unsigned int, hodec1_pwr_interval, 6, \ @@ -142,22 +142,22 @@ "handover2 ", "window rxlev averaging", "<1-10>", atoi, "%u", as_is, \ HO_CFG_STR_HANDOVER2 \ HO_CFG_STR_WIN_RXLEV \ - "How many RxLev measurements are used for averaging\n" \ + "How many RxLev measurements to use for averaging\n" \ "RxLev averaging: " HO_CFG_STR_AVG_COUNT) \ \ HO_CFG_ONE_MEMBER(unsigned int, hodec2_rxqual_avg_win, 1, \ "handover2 ", "window rxqual averaging", "<1-10>", atoi, "%u", as_is, \ HO_CFG_STR_HANDOVER2 \ HO_CFG_STR_WIN_RXQUAL \ - "How many RxQual measurements are used for averaging\n" \ + "How many RxQual measurements to use for averaging\n" \ "RxQual averaging: " HO_CFG_STR_AVG_COUNT) \ \ HO_CFG_ONE_MEMBER(unsigned int, hodec2_rxlev_neigh_avg_win, 10, \ "handover2 ", "window rxlev neighbor averaging", "<1-10>", atoi, "%u", as_is, \ HO_CFG_STR_HANDOVER2 \ HO_CFG_STR_WIN_RXLEV \ - "How many Neighbor RxLev measurements are used for averaging\n" \ - "How many Neighbor RxLev measurements are used for averaging\n" \ + "How many Neighbor RxLev measurements to use for averaging\n" \ + "How many Neighbor RxLev measurements to use for averaging\n" \ "Neighbor RxLev averaging: " HO_CFG_STR_AVG_COUNT) \ \ HO_CFG_ONE_MEMBER(unsigned int, hodec2_pwr_interval, 6, \ @@ -184,7 +184,7 @@ HO_CFG_ONE_MEMBER(bool, hodec2_as_active, 0, \ "handover2 ", "assignment", "0|1", a2bool, "%d", bool2i, \ HO_CFG_STR_HANDOVER2 \ - "Enable or disable in-call channel re-assignment\n" \ + "Enable or disable in-call channel re-assignment within the same cell\n" \ "Disable in-call assignment\n" \ "Enable in-call assignment\n") \ \ @@ -200,7 +200,7 @@ HO_CFG_STR_HANDOVER2 \ HO_CFG_STR_MIN \ "How weak may RxLev of an MS become before triggering HO\n" \ - "minimum RxLev (dBm)\n") \ + "minimum RxLev (dBm; note: negative values)\n") \ \ HO_CFG_ONE_MEMBER(int, hodec2_min_rxqual, 5, \ "handover2 ", "min rxqual", "<0-7>", atoi, "%d", as_is, \ @@ -247,27 +247,30 @@ "handover2 ", "penalty-time max-distance", "<0-99999>", atoi, "%d", as_is, \ HO_CFG_STR_HANDOVER2 \ HO_CFG_STR_PENALTY_TIME \ - "Time to suspend handovers after leaving this cell due to exceeding max distance\n" \ + "Time to suspend handover for a subscriber after leaving this cell due to exceeding max distance;" \ + " see also 'handover2 retries'\n" \ "Seconds\n") \ \ HO_CFG_ONE_MEMBER(int, hodec2_penalty_failed_ho, 60, \ "handover2 ", "penalty-time failed-ho", "<0-99999>", atoi, "%d", as_is, \ HO_CFG_STR_HANDOVER2 \ HO_CFG_STR_PENALTY_TIME \ - "Time to suspend handovers after handover failure to this cell\n" \ + "Time to suspend handover for a subscriber after a failed handover into this cell;" \ + " see also 'handover2 retries'\n" \ "Seconds\n") \ \ HO_CFG_ONE_MEMBER(int, hodec2_penalty_failed_as, 60, \ "handover2 ", "penalty-time failed-assignment", "<0-99999>", atoi, "%d", as_is, \ HO_CFG_STR_HANDOVER2 \ HO_CFG_STR_PENALTY_TIME \ - "Time to suspend handovers after assignment failure in this cell\n" \ + "Time to suspend handover for a subscriber after a failed re-assignment within this cell;" \ + " see also 'handover2 retries'\n" \ "Seconds\n") \ \ HO_CFG_ONE_MEMBER(int, hodec2_retries, 0, \ "handover2 ", "retries", "<0-9>", atoi, "%d", as_is, \ HO_CFG_STR_HANDOVER2 \ - "Immediately retry on handover/assignment failure\n" \ + "Number of times to immediately retry a failed handover/assignment, before a penalty time is applied\n" \ "Number of retries\n") \ #define HO_CFG_ALL_MEMBERS \ diff --git a/src/osmo-bsc/handover_vty.c b/src/osmo-bsc/handover_vty.c index 7979511..e9333ec 100644 --- a/src/osmo-bsc/handover_vty.c +++ b/src/osmo-bsc/handover_vty.c @@ -107,7 +107,8 @@ "handover2 congestion-check (disabled|<1-999>|now)", HO_CFG_STR_HANDOVER2 "Configure congestion check interval\n" - "Disable congestion checking, do not handover based on cell overload\n" + "Disable congestion checking, do not handover based on cell load. Note: there is one global congestion check" + " interval, i.e. contrary to other handover2 settings, this is not configurable per individual cell.\n" "Congestion check interval in seconds (default " OSMO_STRINGIFY_VAL(HO_CFG_CONGESTION_CHECK_DEFAULT) ")\n" "Manually trigger a congestion check to run right now\n") diff --git a/tests/handover_cfg.vty b/tests/handover_cfg.vty index 94c20d9..8fdaf1f 100644 --- a/tests/handover_cfg.vty +++ b/tests/handover_cfg.vty @@ -145,7 +145,7 @@ OsmoBSC(config-net-bts)# ### Verify that 'min rxlev' value range stops at -50 OsmoBSC(config-net-bts)# handover2 min rxlev ? - <-110--50> minimum RxLev (dBm) + <-110--50> minimum RxLev (dBm; note: negative values) default Use default (-100), remove explicit setting on this node OsmoBSC(config-net-bts)# handover2 min rxlev -111 % Unknown command. @@ -218,14 +218,14 @@ window Measurement averaging settings power Neighbor cell power triggering maximum Maximum Timing-Advance value (i.e. MS distance) before triggering HO - assignment Enable or disable in-call channel re-assignment + assignment Enable or disable in-call channel re-assignment within the same cell tdma-measurement Define measurement set of TDMA frames min Minimum Level/Quality thresholds before triggering HO afs-bias Configure bias to prefer AFS (AMR on TCH/F) over other codecs min-free-slots Minimum free TCH timeslots before cell is considered congested max-handovers Maximum number of concurrent handovers allowed per cell penalty-time Set penalty times to wait between repeated handovers - retries Immediately retry on handover/assignment failure + retries Number of times to immediately retry a failed handover/assignment, before a penalty time is applied congestion-check Configure congestion check interval OsmoBSC(config-net)# handover algorithm ? @@ -238,22 +238,22 @@ rxqual Received-Quality averaging OsmoBSC(config-net)# handover1 window rxlev ? - averaging How many RxLev measurements are used for averaging - neighbor How many Neighbor RxLev measurements are used for averaging + averaging How many RxLev measurements to use for averaging + neighbor How many Neighbor RxLev measurements to use for averaging OsmoBSC(config-net)# handover1 window rxlev averaging ? <1-10> RxLev averaging: Number of values to average over default Use default (10), remove explicit setting on this node OsmoBSC(config-net)# handover1 window rxlev neighbor ? - averaging How many Neighbor RxLev measurements are used for averaging + averaging How many Neighbor RxLev measurements to use for averaging OsmoBSC(config-net)# handover1 window rxlev neighbor averaging ? <1-10> Neighbor RxLev averaging: Number of values to average over default Use default (10), remove explicit setting on this node OsmoBSC(config-net)# handover1 window rxqual ? - averaging How many RxQual measurements are used for averaging + averaging How many RxQual measurements to use for averaging OsmoBSC(config-net)# handover1 window rxqual averaging ? <1-10> RxQual averaging: Number of values to average over @@ -286,22 +286,22 @@ rxqual Received-Quality averaging OsmoBSC(config-net)# handover2 window rxlev ? - averaging How many RxLev measurements are used for averaging - neighbor How many Neighbor RxLev measurements are used for averaging + averaging How many RxLev measurements to use for averaging + neighbor How many Neighbor RxLev measurements to use for averaging OsmoBSC(config-net)# handover2 window rxlev averaging ? <1-10> RxLev averaging: Number of values to average over default Use default (10), remove explicit setting on this node OsmoBSC(config-net)# handover2 window rxlev neighbor ? - averaging How many Neighbor RxLev measurements are used for averaging + averaging How many Neighbor RxLev measurements to use for averaging OsmoBSC(config-net)# handover2 window rxlev neighbor averaging ? <1-10> Neighbor RxLev averaging: Number of values to average over default Use default (10), remove explicit setting on this node OsmoBSC(config-net)# handover2 window rxqual ? - averaging How many RxQual measurements are used for averaging + averaging How many RxQual measurements to use for averaging OsmoBSC(config-net)# handover2 window rxqual averaging ? <1-10> RxQual averaging: Number of values to average over @@ -344,7 +344,7 @@ rxqual How bad may RxQual of an MS become before triggering HO OsmoBSC(config-net)# handover2 min rxlev ? - <-110--50> minimum RxLev (dBm) + <-110--50> minimum RxLev (dBm; note: negative values) default Use default (-100), remove explicit setting on this node OsmoBSC(config-net)# handover2 min rxqual ? @@ -383,9 +383,9 @@ default Use default (9999), remove explicit setting on this node OsmoBSC(config-net)# handover2 penalty-time ? - max-distance Time to suspend handovers after leaving this cell due to exceeding max distance - failed-ho Time to suspend handovers after handover failure to this cell - failed-assignment Time to suspend handovers after assignment failure in this cell + max-distance Time to suspend handover for a subscriber after leaving this cell due to exceeding max distance; see also 'handover2 retries' + failed-ho Time to suspend handover for a subscriber after a failed handover into this cell; see also 'handover2 retries' + failed-assignment Time to suspend handover for a subscriber after a failed re-assignment within this cell; see also 'handover2 retries' OsmoBSC(config-net)# handover2 penalty-time max-distance ? <0-99999> Seconds @@ -404,7 +404,7 @@ default Use default (0), remove explicit setting on this node OsmoBSC(config-net)# handover2 congestion-check ? - disabled Disable congestion checking, do not handover based on cell overload + disabled Disable congestion checking, do not handover based on cell load. Note: there is one global congestion check interval, i.e. contrary to other handover2 settings, this is not configurable per individual cell. <1-999> Congestion check interval in seconds (default 10) now Manually trigger a congestion check to run right now @@ -437,14 +437,14 @@ window Measurement averaging settings power Neighbor cell power triggering maximum Maximum Timing-Advance value (i.e. MS distance) before triggering HO - assignment Enable or disable in-call channel re-assignment + assignment Enable or disable in-call channel re-assignment within the same cell tdma-measurement Define measurement set of TDMA frames min Minimum Level/Quality thresholds before triggering HO afs-bias Configure bias to prefer AFS (AMR on TCH/F) over other codecs min-free-slots Minimum free TCH timeslots before cell is considered congested max-handovers Maximum number of concurrent handovers allowed per cell penalty-time Set penalty times to wait between repeated handovers - retries Immediately retry on handover/assignment failure + retries Number of times to immediately retry a failed handover/assignment, before a penalty time is applied OsmoBSC(config-net-bts)# handover algorithm ? 1 Algorithm 1: trigger handover based on comparing current cell and neighbor RxLev and RxQual, only. @@ -456,22 +456,22 @@ rxqual Received-Quality averaging OsmoBSC(config-net-bts)# handover1 window rxlev ? - averaging How many RxLev measurements are used for averaging - neighbor How many Neighbor RxLev measurements are used for averaging + averaging How many RxLev measurements to use for averaging + neighbor How many Neighbor RxLev measurements to use for averaging OsmoBSC(config-net-bts)# handover1 window rxlev averaging ? <1-10> RxLev averaging: Number of values to average over default Use default (10), remove explicit setting on this node OsmoBSC(config-net-bts)# handover1 window rxlev neighbor ? - averaging How many Neighbor RxLev measurements are used for averaging + averaging How many Neighbor RxLev measurements to use for averaging OsmoBSC(config-net-bts)# handover1 window rxlev neighbor averaging ? <1-10> Neighbor RxLev averaging: Number of values to average over default Use default (10), remove explicit setting on this node OsmoBSC(config-net-bts)# handover1 window rxqual ? - averaging How many RxQual measurements are used for averaging + averaging How many RxQual measurements to use for averaging OsmoBSC(config-net-bts)# handover1 window rxqual averaging ? <1-10> RxQual averaging: Number of values to average over @@ -504,22 +504,22 @@ rxqual Received-Quality averaging OsmoBSC(config-net-bts)# handover2 window rxlev ? - averaging How many RxLev measurements are used for averaging - neighbor How many Neighbor RxLev measurements are used for averaging + averaging How many RxLev measurements to use for averaging + neighbor How many Neighbor RxLev measurements to use for averaging OsmoBSC(config-net-bts)# handover2 window rxlev averaging ? <1-10> RxLev averaging: Number of values to average over default Use default (10), remove explicit setting on this node OsmoBSC(config-net-bts)# handover2 window rxlev neighbor ? - averaging How many Neighbor RxLev measurements are used for averaging + averaging How many Neighbor RxLev measurements to use for averaging OsmoBSC(config-net-bts)# handover2 window rxlev neighbor averaging ? <1-10> Neighbor RxLev averaging: Number of values to average over default Use default (10), remove explicit setting on this node OsmoBSC(config-net-bts)# handover2 window rxqual ? - averaging How many RxQual measurements are used for averaging + averaging How many RxQual measurements to use for averaging OsmoBSC(config-net-bts)# handover2 window rxqual averaging ? <1-10> RxQual averaging: Number of values to average over @@ -562,7 +562,7 @@ rxqual How bad may RxQual of an MS become before triggering HO OsmoBSC(config-net-bts)# handover2 min rxlev ? - <-110--50> minimum RxLev (dBm) + <-110--50> minimum RxLev (dBm; note: negative values) default Use default (-100), remove explicit setting on this node OsmoBSC(config-net-bts)# handover2 min rxqual ? @@ -601,9 +601,9 @@ default Use default (9999), remove explicit setting on this node OsmoBSC(config-net-bts)# handover2 penalty-time ? - max-distance Time to suspend handovers after leaving this cell due to exceeding max distance - failed-ho Time to suspend handovers after handover failure to this cell - failed-assignment Time to suspend handovers after assignment failure in this cell + max-distance Time to suspend handover for a subscriber after leaving this cell due to exceeding max distance; see also 'handover2 retries' + failed-ho Time to suspend handover for a subscriber after a failed handover into this cell; see also 'handover2 retries' + failed-assignment Time to suspend handover for a subscriber after a failed re-assignment within this cell; see also 'handover2 retries' OsmoBSC(config-net-bts)# handover2 penalty-time max-distance ? <0-99999> Seconds -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1639efb2dbcca4f0e9c33a74f3067606ce5f4209 Gerrit-Change-Number: 14582 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 15:43:44 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Jul 2019 15:43:44 +0000 Subject: Change in ...osmo-python-tests[master]: tweak README In-Reply-To: References: Message-ID: neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/python/osmo-python-tests/+/14698 ) Change subject: tweak README ...................................................................... tweak README Most importantly, mention 'python3 setup.py'. Tweak indenting and some wording. Change-Id: Id8c277de280b54d04edcafa77ed93017d6da473d --- M README 1 file changed, 15 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/README b/README index 69eb764..dbb8d88 100644 --- a/README +++ b/README @@ -1,11 +1,20 @@ Building/installation: -sudo python setup.py install + + sudo python setup.py install + sudo python3 setup.py install + If you prefer to have it cleanly removable, install checkinstall and run -sudo checkinstall python setup.py install -Alternatively, just run 'pip install --user -e ./' or 'pip3 install --user -e ./' + + sudo checkinstall python setup.py install + +Alternatively, just run + + pip install --user -e ./ + pip3 install --user -e ./ + depending on your python version. -Use +Use: There are currently following scripts in this package: osmotestconfig.py - test that apps start/write with example configs soap.py - implementation of SOAP <-> Ctrl proxy implemented on top of Twisted (deprecated, unmaintained) @@ -20,8 +29,9 @@ osmodumpdoc.py - dump documentation, superseded by osmo_interact_vty.py -X osmotestvty.py - test vty operations, superseded by osmo_verify_transcript_vty.py -Each of these scripts imports a project-specific osmoappdesc.py, +Some of these scripts import a project-specific osmoappdesc.py, which provides information about the available apps, configs, vty ports, etc. +and is provided by other source trees (like osmo-bsc.git, osmo-msc.git, ...) Run the scripts with osmoappdesc.py in the current directory (preferred) or with -p . -- To view, visit https://gerrit.osmocom.org/c/python/osmo-python-tests/+/14698 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Change-Id: Id8c277de280b54d04edcafa77ed93017d6da473d Gerrit-Change-Number: 14698 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 15:45:32 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Jul 2019 15:45:32 +0000 Subject: Change in ...osmo-bsc[master]: remove double BSSMAP Clear on HO failure In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14700 ) Change subject: remove double BSSMAP Clear on HO failure ...................................................................... Patch Set 1: Code-Review+2 combining 2 +1s from others -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14700 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iac1519eb8b24e8523caec682f9ac8e6dcf1327ce Gerrit-Change-Number: 14700 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 09 Jul 2019 15:45:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 15:45:41 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Jul 2019 15:45:41 +0000 Subject: Change in ...osmo-bsc[master]: remove double BSSMAP Clear on HO failure In-Reply-To: References: Message-ID: neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14700 ) Change subject: remove double BSSMAP Clear on HO failure ...................................................................... remove double BSSMAP Clear on HO failure If a handover fails when the new lchan is already fully established, osmo-bsc so far caused two BSSMAP Clear Requests to be sent out to the MSC: one caused by detaching the lchan from the gscon, one from returning the gscon back to ST_ACTIVE, which detects that no lchan is present and Clears. In fact only one of those is necessary. Checking for the presence of an lchan when entering ST_ACTIVE is an earlier attempt to catch insane situations. Since then, osmo-bsc has acquired other logic that will ensure sending a Clear Request in all cases, see gscon_forget_lchan(). Sending another BSSMAP Clear Request in ST_ACTIVE's onenter is simply not necessary. Drop gscon_fsm_active_onenter() entirely. Note: the double Clear Request is currently hit by TC_ho_out_fail_no_ho_detect(), which currently fails and will pass again after this patch; however, osmo-bsc should actually not release the lchan at all during this test, see OS#4093. In other words, osmo-bsc behavior for this scenario as well as TC_ho_out_fail_no_ho_detect() need to be changed, and the test will, once fixed, not be useful to trigger this issue anymore. Related: OS#4078 Change-Id: Iac1519eb8b24e8523caec682f9ac8e6dcf1327ce --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index bc5cb27..f8784f9 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -343,13 +343,6 @@ } } -static void gscon_fsm_active_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) -{ - struct gsm_subscriber_connection *conn = fi->priv; - if (!conn->lchan) - gscon_bssmap_clear(conn, GSM0808_CAUSE_EQUIPMENT_FAILURE); -} - /* We're on an active subscriber connection, passing DTAP back and forth */ static void gscon_fsm_active(struct osmo_fsm_inst *fi, uint32_t event, void *data) { @@ -605,7 +598,6 @@ S(GSCON_EV_HANDOVER_START), .out_state_mask = S(ST_CLEARING) | S(ST_ASSIGNMENT) | S(ST_HANDOVER), - .onenter = gscon_fsm_active_onenter, .action = gscon_fsm_active, }, [ST_ASSIGNMENT] = { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14700 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iac1519eb8b24e8523caec682f9ac8e6dcf1327ce Gerrit-Change-Number: 14700 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 17:46:42 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Jul 2019 17:46:42 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: comments: BSC_Tests: clarify f_tc_ho_out_fail functions Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14708 Change subject: comments: BSC_Tests: clarify f_tc_ho_out_fail functions ...................................................................... comments: BSC_Tests: clarify f_tc_ho_out_fail functions Change-Id: Ia0584324476d36077e92d1564d9d7e79a069addf --- M bsc/BSC_Tests.ttcn 1 file changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/08/14708/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 88df9bc..454ded7 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3119,8 +3119,12 @@ vc_conn.done; } -/* BSC asks for inter-BSC HO, receives BSSMAP Handover Command, but MS reports - * RR Handover Failure. */ +/* BSC asks for inter-BSC-out HO, receives BSSMAP Handover Command, but then no reply is received about HO outcome + * (neither BSSMAP Clear Command for success nor RR Handover Failure). 48.008 3.1.5.3.3 "Abnormal Conditions" applies + * and the lchan is released. + * Note: this test is a misnomer. On missing HO Detect, normally the old BSS receives an RR Handover Failure from the + * MS. Instead, this test is about the scenario in "Abnormal Conditions" as explained above. Leaving the test's name + * unchanged to not confuse jenkins result reports. */ private function f_tc_ho_out_fail_no_ho_detect(charstring id) runs on MSC_ConnHdlr { g_pars := f_gen_test_hdlr_pars(); @@ -3164,9 +3168,9 @@ } } - /* The MS never shows up on the remote BSS. Eventually the BSC times - * out (T8) and we run into 3GPP TS 48.008 3.1.5.3.3 "Abnormal Conditions": - * RR should be released and Clear Request should go to the MSC. */ + /* We get neither success nor failure report from the remote BSS. Eventually T8 times out and we run into 3GPP + * TS 48.008 3.1.5.3.3 "Abnormal Conditions": Clear Request should go to the MSC, and RR should be released + * after Clear Command */ var MgcpCommand mgcp; var PDU_BSSAP rx_clear_request; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia0584324476d36077e92d1564d9d7e79a069addf Gerrit-Change-Number: 14708 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 17:46:43 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Jul 2019 17:46:43 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: f_tc_ho_out_fail_no_ho_detect: stricter ordering Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14709 Change subject: f_tc_ho_out_fail_no_ho_detect: stricter ordering ...................................................................... f_tc_ho_out_fail_no_ho_detect: stricter ordering Make sure that the RR is released only after the MSC has sent the Clear Command: - first expect a Clear Request from osmo-bsc and return a Clear Command, - only then accept RR release messages. See 3GPP TS 48.008 3.1.5.3.3 "Abnormal Conditions": "The terrestrial resource in the old BSS shall remain assigned until a CLEAR COMMAND message is received from the MSC" osmo-bsc already complies, the test should continue to pass. Change-Id: Iba05336d3c4af8a1c57cdc828dae464eae3510b9 --- M bsc/BSC_Tests.ttcn 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/09/14709/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 454ded7..854dbbc 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3172,8 +3172,14 @@ * TS 48.008 3.1.5.3.3 "Abnormal Conditions": Clear Request should go to the MSC, and RR should be released * after Clear Command */ - var MgcpCommand mgcp; var PDU_BSSAP rx_clear_request; + BSSAP.receive(tr_BSSMAP_ClearRequest) -> value rx_clear_request; + log("Got BSSMAP Clear Request"); + /* Instruct BSC to clear channel */ + var BssmapCause cause := bit2int(rx_clear_request.pdu.bssmap.clearRequest.cause.causeValue); + BSSAP.send(ts_BSSMAP_ClearCommand(cause)); + + var MgcpCommand mgcp; interleave { [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) { log("Got Deact SACCH"); @@ -3185,12 +3191,6 @@ log("Got RF Chan Rel"); RSL.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr)); } - [] BSSAP.receive(tr_BSSMAP_ClearRequest) -> value rx_clear_request { - log("Got BSSMAP Clear Request"); - /* Instruct BSC to clear channel */ - var BssmapCause cause := bit2int(rx_clear_request.pdu.bssmap.clearRequest.cause.causeValue); - BSSAP.send(ts_BSSMAP_ClearCommand(cause)); - } } f_expect_dlcx_conns(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14709 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba05336d3c4af8a1c57cdc828dae464eae3510b9 Gerrit-Change-Number: 14709 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 17:46:43 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Jul 2019 17:46:43 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_... Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14710 Change subject: rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_ho_cmd ...................................................................... rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_ho_cmd Change-Id: If84a1d4535ee12e33a50588e178bf1ebb6fb2cd5 --- M bsc/BSC_Tests.ttcn 1 file changed, 5 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/10/14710/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 854dbbc..44a9172 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3121,11 +3121,8 @@ /* BSC asks for inter-BSC-out HO, receives BSSMAP Handover Command, but then no reply is received about HO outcome * (neither BSSMAP Clear Command for success nor RR Handover Failure). 48.008 3.1.5.3.3 "Abnormal Conditions" applies - * and the lchan is released. - * Note: this test is a misnomer. On missing HO Detect, normally the old BSS receives an RR Handover Failure from the - * MS. Instead, this test is about the scenario in "Abnormal Conditions" as explained above. Leaving the test's name - * unchanged to not confuse jenkins result reports. */ -private function f_tc_ho_out_fail_no_ho_detect(charstring id) runs on MSC_ConnHdlr { + * and the lchan is released. */ +private function f_tc_ho_out_fail_no_result_after_ho_cmd(charstring id) runs on MSC_ConnHdlr { g_pars := f_gen_test_hdlr_pars(); var PDU_BSSAP ass_req := f_gen_ass_req(); @@ -3198,13 +3195,13 @@ setverdict(pass); f_sleep(1.0); } -testcase TC_ho_out_fail_no_ho_detect() runs on test_CT { +testcase TC_ho_out_fail_no_result_after_ho_cmd() runs on test_CT { var MSC_ConnHdlr vc_conn; f_init(1, true); f_sleep(1.0); - vc_conn := f_start_handler(refers(f_tc_ho_out_fail_no_ho_detect)); + vc_conn := f_start_handler(refers(f_tc_ho_out_fail_no_result_after_ho_cmd)); vc_conn.done; } @@ -4135,7 +4132,7 @@ execute( TC_ho_out_of_this_bsc() ); execute( TC_ho_out_fail_no_msc_response() ); execute( TC_ho_out_fail_rr_ho_failure() ); - execute( TC_ho_out_fail_no_ho_detect() ); + execute( TC_ho_out_fail_no_result_after_ho_cmd() ); execute( TC_ho_into_this_bsc() ); execute( TC_ho_in_fail_msc_clears() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If84a1d4535ee12e33a50588e178bf1ebb6fb2cd5 Gerrit-Change-Number: 14710 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 17:47:47 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Jul 2019 17:47:47 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_... In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14710 ) Change subject: rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_ho_cmd ...................................................................... Patch Set 1: NOT SURE IF WE SHOULD RENAME THIS. It is definitely a better name, but do we want the jenkins report to show a discontinued test? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If84a1d4535ee12e33a50588e178bf1ebb6fb2cd5 Gerrit-Change-Number: 14710 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Comment-Date: Tue, 09 Jul 2019 17:47:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 9 17:48:52 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 9 Jul 2019 17:48:52 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_... In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14710 to look at the new patch set (#2). Change subject: rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_ho_cmd ...................................................................... rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_ho_cmd Change-Id: If84a1d4535ee12e33a50588e178bf1ebb6fb2cd5 --- M bsc/BSC_Tests.ttcn M bsc/expected-results.xml 2 files changed, 6 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/10/14710/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If84a1d4535ee12e33a50588e178bf1ebb6fb2cd5 Gerrit-Change-Number: 14710 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Tue Jul 9 21:14:55 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 21:14:55 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2503eca05e2_70ce112e5fc2578e4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sysmon failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 238s] sysmon" [ 238s] #define VERSION "0.1.0" [ 238s] #define STDC_HEADERS 1 [ 238s] #define HAVE_SYS_TYPES_H 1 [ 238s] #define HAVE_SYS_STAT_H 1 [ 238s] #define HAVE_STDLIB_H 1 [ 238s] #define HAVE_STRING_H 1 [ 238s] #define HAVE_MEMORY_H 1 [ 238s] #define HAVE_STRINGS_H 1 [ 238s] #define HAVE_INTTYPES_H 1 [ 238s] #define HAVE_STDINT_H 1 [ 238s] #define HAVE_UNISTD_H 1 [ 238s] #define HAVE_DLFCN_H 1 [ 238s] #define LT_OBJDIR ".libs/" [ 238s] [ 238s] configure: exit 1 [ 238s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking returned exit code 1 [ 238s] make: *** [debian/rules:45: build] Error 2 [ 238s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 238s] [ 238s] cloud130 failed "build osmo-sysmon_0.1.0.dsc" at Tue Jul 9 21:14:32 UTC 2019. [ 238s] [ 238s] ### VM INTERACTION START ### [ 242s] [ 195.774097] sysrq: SysRq : Power Off [ 242s] [ 195.777868] reboot: Power down [ 252s] ### VM INTERACTION END ### [ 252s] [ 252s] cloud130 failed "build osmo-sysmon_0.1.0.dsc" at Tue Jul 9 21:14:45 UTC 2019. [ 252s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 21:17:12 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 21:17:12 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d250463ad2d1_70ce112e5fc258274@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_Unstable/x86_64 Package network:osmocom:latest/openbsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 107s] | #define HAVE_MEMORY_H 1 [ 107s] | #define HAVE_STRINGS_H 1 [ 107s] | #define HAVE_INTTYPES_H 1 [ 107s] | #define HAVE_STDINT_H 1 [ 107s] | #define HAVE_UNISTD_H 1 [ 107s] | #define HAVE_DLFCN_H 1 [ 107s] | #define LT_OBJDIR ".libs/" [ 107s] | #define BUILD_SMPP 1 [ 107s] | #define STDC_HEADERS 1 [ 107s] | #define HAVE_DBI_DBD_H 1 [ 107s] | #define HAVE_PCAP_PCAP_H 1 [ 107s] | #define HAVE_TM_GMTOFF_IN_TM 1 [ 107s] | [ 107s] | configure: exit 0 [ 107s] [ 107s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 107s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 107s] make: *** [debian/rules:13: build] Error 2 [ 107s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 107s] [ 107s] build82 failed "build openbsc_1.2.0.dsc" at Tue Jul 9 21:17:02 UTC 2019. [ 107s] [ 107s] ### VM INTERACTION START ### [ 109s] [ 99.914956] sysrq: SysRq : Power Off [ 109s] [ 99.916939] reboot: Power down [ 109s] ### VM INTERACTION END ### [ 109s] [ 109s] build82 failed "build openbsc_1.2.0.dsc" at Tue Jul 9 21:17:06 UTC 2019. [ 109s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 21:19:45 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 21:19:45 +0000 Subject: Build failure of network:osmocom:nightly/osmo-remsim in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2504fba65fe_70ce112e5fc258445@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-remsim/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-remsim failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-remsim Last lines of build log: [ 178s] /bin/bash ../libtool --tag=CC --mode=compile gcc -DPACKAGE_NAME=\"osmo-remsim\" -DPACKAGE_TARNAME=\"osmo-remsim\" -DPACKAGE_VERSION=\"0.1.0.19-293c\" -DPACKAGE_STRING=\"osmo-remsim\ 0.1.0.19-293c\" -DPACKAGE_BUGREPORT=\"simtrace at lists.osmocom.org\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DPACKAGE=\"osmo-remsim\" -DVERSION=\"0.1.0.19-293c\" -DHAVE_CSV_H=1 -DBUILD_SERVER=1 -DBUILD_BANKD=1 -DSTDC_HEADERS=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wall -I../include -I../include -I/usr/include/ -I/usr/include/ -I/usr/include/ -pthread -I/usr/include/PCSC -I/usr/include/libusb-1.0 -I/usr/include/ -I../include/osmocom/rspro -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -c -o rspro_util.lo rspro_util.c [ 179s] libtool: compile: gcc -DPACKAGE_NAME=\"osmo-remsim\" -DPACKAGE_TARNAME=\"osmo-remsim\" -DPACKAGE_VERSION=\"0.1.0.19-293c\" "-DPACKAGE_STRING=\"osmo-remsim 0.1.0.19-293c\"" -DPACKAGE_BUGREPORT=\"simtrace at lists.osmocom.org\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DPACKAGE=\"osmo-remsim\" -DVERSION=\"0.1.0.19-293c\" -DHAVE_CSV_H=1 -DBUILD_SERVER=1 -DBUILD_BANKD=1 -DSTDC_HEADERS=1 -I. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wall -I../include -I../include -I/usr/include/ -I/usr/include/ -I/usr/include/ -pthread -I/usr/include/PCSC -I/usr/include/libusb-1.0 -I/usr/include/ -I../include/osmocom/rspro -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -c rspro_util.c -fPIC -DPIC -o .libs/rspro_util.o [ 179s] rspro_util.c: In function 'rspro_gen_TpduCard2Modem': [ 179s] rspro_util.c:384:2: error: expected ';' before 'pdu' [ 179s] pdu->msg.choice.tpduCardToModem.toClientSlot = *client; [ 179s] ^~~ [ 179s] make[5]: *** [Makefile:614: rspro_util.lo] Error 1 [ 179s] make[5]: Leaving directory '/usr/src/packages/BUILD/src' [ 179s] make[4]: *** [Makefile:771: ../../src/libosmo-rspro.la] Error 2 [ 179s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/bankd' [ 179s] make[3]: *** [Makefile:671: all-recursive] Error 1 [ 179s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 179s] make[2]: *** [Makefile:460: all-recursive] Error 1 [ 179s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 179s] make[1]: *** [Makefile:384: all] Error 2 [ 179s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 179s] dh_auto_build: make -j1 returned exit code 2 [ 179s] make: *** [debian/rules:12: build] Error 2 [ 179s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 179s] [ 179s] lamb56 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 21:19:34 UTC 2019. [ 179s] [ 179s] ### VM INTERACTION START ### [ 182s] [ 167.116196] sysrq: SysRq : Power Off [ 182s] [ 167.123705] reboot: Power down [ 182s] ### VM INTERACTION END ### [ 182s] [ 182s] lamb56 failed "build osmo-remsim_0.1.0.19.293c.dsc" at Tue Jul 9 21:19:38 UTC 2019. [ 182s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 21:20:02 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 21:20:02 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d250516a0563_70ce112e5fc258614@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 458s] switch (pchan) { [ 458s] ^~~~~~ [ 458s] measurement.c:423:28: warning: unused variable 'pchan' [-Wunused-variable] [ 458s] enum gsm_phys_chan_config pchan = ts_pchan(lchan->ts); [ 458s] ^~~~~ [ 458s] measurement.c:448:1: warning: control reaches end of non-void function [-Wreturn-type] [ 458s] } [ 458s] ^ [ 458s] make[4]: *** [Makefile:457: measurement.o] Error 1 [ 458s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/common' [ 458s] make[3]: *** [Makefile:385: all-recursive] Error 1 [ 458s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 458s] make[2]: *** [Makefile:434: all-recursive] Error 1 [ 458s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 458s] make[1]: *** [Makefile:366: all] Error 2 [ 458s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 458s] dh_auto_build: make -j1 returned exit code 2 [ 458s] make: *** [debian/rules:12: build] Error 2 [ 458s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 458s] [ 458s] lamb51 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 21:19:46 UTC 2019. [ 458s] [ 458s] ### VM INTERACTION START ### [ 461s] [ 401.735681] sysrq: SysRq : Power Off [ 461s] [ 401.742256] reboot: Power down [ 461s] ### VM INTERACTION END ### [ 461s] [ 461s] lamb51 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Tue Jul 9 21:19:50 UTC 2019. [ 461s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 21:36:03 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 21:36:03 +0000 Subject: Build failure of network:osmocom:nightly/openbsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2508d6ac631_70ce112e5fc265034@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_Unstable/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 211s] from /usr/include/osmocom/core/msgb.h:24, [ 211s] from ../../include/openbsc/mgcp.h:26, [ 211s] from ../../include/openbsc/bsc_nat.h:24, [ 211s] from bsc_nat_utils.c:24: [ 211s] bsc_nat_utils.c: In function 'bsc_config_free': [ 211s] bsc_nat_utils.c:210:2: error: expected ';' before '_talloc_free' [ 211s] talloc_free(cfg); [ 211s] ^~~~~~~~~~~ [ 211s] make[4]: *** [Makefile:527: bsc_nat_utils.o] Error 1 [ 211s] make[4]: Leaving directory '/usr/src/packages/BUILD/openbsc/src/osmo-bsc_nat' [ 211s] make[3]: *** [Makefile:429: all-recursive] Error 1 [ 211s] make[3]: Leaving directory '/usr/src/packages/BUILD/openbsc/src' [ 211s] make[2]: *** [Makefile:455: all-recursive] Error 1 [ 211s] make[2]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 211s] make[1]: *** [Makefile:387: all] Error 2 [ 211s] make[1]: Leaving directory '/usr/src/packages/BUILD/openbsc' [ 211s] dh_auto_build: cd openbsc && make -j1 returned exit code 2 [ 211s] make: *** [debian/rules:13: build] Error 2 [ 211s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 211s] [ 211s] lamb26 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 21:35:57 UTC 2019. [ 211s] [ 211s] ### VM INTERACTION START ### [ 214s] [ 197.660465] sysrq: SysRq : Power Off [ 214s] [ 197.680717] reboot: Power down [ 214s] ### VM INTERACTION END ### [ 214s] [ 214s] lamb26 failed "build openbsc_1.2.0.20190709.dsc" at Tue Jul 9 21:36:00 UTC 2019. [ 214s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 9 21:54:54 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 09 Jul 2019 21:54:54 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d250d4b2dafd_70ce112e5fc267351@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 401s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o ran_msg_a.o ran_msg_a.c [ 402s] gcc -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../.. -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/asn1c -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Werror=implicit -Werror=maybe-uninitialized -Werror=memset-transposed-args -Werror=null-dereference -Werror=sizeof-array-argument -Werror=sizeof-pointer-memaccess -c -o ran_peer.o ran_peer.c [ 402s] In file included from /usr/include/osmocom/core/fsm.h:12, [ 402s] from ran_peer.c:25: [ 402s] ran_peer.c: In function 'ran_peer_st_ready': [ 402s] ran_peer.c:374:3: error: expected ';' before 'do' [ 402s] OSMO_ASSERT(!ctx->conn); [ 402s] ^~~~~~~~~~~ [ 402s] make[4]: *** [Makefile:570: ran_peer.o] Error 1 [ 402s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libmsc' [ 402s] make[3]: *** [Makefile:422: all-recursive] Error 1 [ 402s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 402s] make[2]: *** [Makefile:462: all-recursive] Error 1 [ 402s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 402s] make[1]: *** [Makefile:394: all] Error 2 [ 402s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 402s] dh_auto_build: make -j1 returned exit code 2 [ 402s] make: *** [debian/rules:45: build] Error 2 [ 402s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 402s] [ 402s] build70 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 21:54:46 UTC 2019. [ 402s] [ 402s] ### VM INTERACTION START ### [ 406s] [ 385.725834] sysrq: SysRq : Power Off [ 406s] [ 385.741519] reboot: Power down [ 406s] ### VM INTERACTION END ### [ 406s] [ 406s] build70 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Tue Jul 9 21:54:51 UTC 2019. [ 406s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Jul 9 23:39:17 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Tue, 9 Jul 2019 23:39:17 +0000 Subject: Change in ...osmo-msc[master]: add semi-color after OSMO_ASSERT Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14711 Change subject: add semi-color after OSMO_ASSERT ...................................................................... add semi-color after OSMO_ASSERT In preparation of changing the OSMO_ASSERT() to require a semicolon. Change-Id: I42fca73393d14ebed973616b86fb87f89bdbf095 --- M src/libmsc/ran_peer.c M tests/msc_vlr/msc_vlr_tests.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/14711/1 diff --git a/src/libmsc/ran_peer.c b/src/libmsc/ran_peer.c index ce26794..77740a0 100644 --- a/src/libmsc/ran_peer.c +++ b/src/libmsc/ran_peer.c @@ -370,7 +370,7 @@ case RAN_PEER_EV_MSG_UP_CO_INITIAL: ctx = data; - OSMO_ASSERT(ctx) + OSMO_ASSERT(ctx); OSMO_ASSERT(!ctx->conn); OSMO_ASSERT(ctx->msg); diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c index 488cd19..35401ba 100644 --- a/tests/msc_vlr/msc_vlr_tests.c +++ b/tests/msc_vlr/msc_vlr_tests.c @@ -171,7 +171,7 @@ count = osmo_use_count_by(&msc_a->use_count, cm_service_use); OSMO_ASSERT(count > 0); - OSMO_ASSERT(osmo_use_count_get_put(&msc_a->use_count, cm_service_use, -count) == 0) + OSMO_ASSERT(osmo_use_count_get_put(&msc_a->use_count, cm_service_use, -count) == 0); ASSERT_RELEASE_CLEAR(msc_a->c.ran->type); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I42fca73393d14ebed973616b86fb87f89bdbf095 Gerrit-Change-Number: 14711 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 01:02:43 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 01:02:43 +0000 Subject: Change in ...osmo-msc[master]: add semi-color after OSMO_ASSERT In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14711 ) Change subject: add semi-color after OSMO_ASSERT ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14711/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14711/1//COMMIT_MSG at 9 PS1, Line 9: In preparation of changing the OSMO_ASSERT() to require a semicolon. it's good to fix this here. however, we cannot change OSMO_ASSERT as we must ensure newer libosmocore versions work with older applications. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I42fca73393d14ebed973616b86fb87f89bdbf095 Gerrit-Change-Number: 14711 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Jul 2019 01:02:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 01:51:30 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 01:51:30 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: log_merge.sh: format logs after merging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 ) Change subject: log_merge.sh: format logs after merging ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I671ffa2761c6e503dae9f3b16764d430131b16af Gerrit-Change-Number: 14707 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 10 Jul 2019 01:51:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 01:53:51 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 01:53:51 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: log_merge.sh: format logs after merging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 ) Change subject: log_merge.sh: format logs after merging ...................................................................... Patch Set 1: -Code-Review this basically means we cannot use any other tools on the logs but only use them for human consumption. Admittedly, this is the common case for now - but there are other tools such as the TITAN Eclipse Log file analyzer as well as the ttcn3_logfilter, which AFAIK all work only on the "un-formatted" log with one line per log event. So there's a trade-off here: Do we really want to preclude any such other tools (even future tools that we many not know yet or that many not exist yet) by unconditionally calling logformat? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I671ffa2761c6e503dae9f3b16764d430131b16af Gerrit-Change-Number: 14707 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 10 Jul 2019 01:53:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 01:57:10 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 01:57:10 +0000 Subject: Change in ...osmo-remsim[master]: add examples to the command line options for remsim-bankd and remsim-... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14667 ) Change subject: add examples to the command line options for remsim-bankd and remsim-client ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14667 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Idfa6352ce90dd36dd27306d6c8a2023935ed822d Gerrit-Change-Number: 14667 Gerrit-PatchSet: 2 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Jul 2019 01:57:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 01:57:14 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 01:57:14 +0000 Subject: Change in ...osmo-remsim[master]: add examples to the command line options for remsim-bankd and remsim-... In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14667 ) Change subject: add examples to the command line options for remsim-bankd and remsim-client ...................................................................... add examples to the command line options for remsim-bankd and remsim-client Change-Id: Idfa6352ce90dd36dd27306d6c8a2023935ed822d --- M contrib/etc_default/osmo-remsim-client-0 M contrib/etc_default/osmo-remsim-client-1 M contrib/etc_default/osmo-remsim-client-2 M contrib/etc_default/osmo-remsim-client-3 M contrib/systemd/osmo-remsim-client at .service M doc/manuals/chapters/remsim-bankd.adoc M doc/manuals/chapters/remsim-client.adoc 7 files changed, 24 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/etc_default/osmo-remsim-client-0 b/contrib/etc_default/osmo-remsim-client-0 index 8b70721..11f02ad 100644 --- a/contrib/etc_default/osmo-remsim-client-0 +++ b/contrib/etc_default/osmo-remsim-client-0 @@ -4,3 +4,4 @@ REMSIM_I="0" REMSIM_H="2-1.1" REMSIM_c="0" +REMSIM_n="0" diff --git a/contrib/etc_default/osmo-remsim-client-1 b/contrib/etc_default/osmo-remsim-client-1 index 519dcb4..99d1da8 100644 --- a/contrib/etc_default/osmo-remsim-client-1 +++ b/contrib/etc_default/osmo-remsim-client-1 @@ -4,3 +4,4 @@ REMSIM_I="1" REMSIM_H="2-1.1" REMSIM_c="0" +REMSIM_n="1" diff --git a/contrib/etc_default/osmo-remsim-client-2 b/contrib/etc_default/osmo-remsim-client-2 index 3f66289..c705df0 100644 --- a/contrib/etc_default/osmo-remsim-client-2 +++ b/contrib/etc_default/osmo-remsim-client-2 @@ -4,3 +4,4 @@ REMSIM_I="0" REMSIM_H="2-1.4" REMSIM_c="0" +REMSIM_n="2" diff --git a/contrib/etc_default/osmo-remsim-client-3 b/contrib/etc_default/osmo-remsim-client-3 index 149af2b..da48eaa 100644 --- a/contrib/etc_default/osmo-remsim-client-3 +++ b/contrib/etc_default/osmo-remsim-client-3 @@ -4,3 +4,4 @@ REMSIM_I="1" REMSIM_H="2-1.4" REMSIM_c="0" +REMSIM_n="3" diff --git a/contrib/systemd/osmo-remsim-client at .service b/contrib/systemd/osmo-remsim-client at .service index 738ae4a..130f289 100644 --- a/contrib/systemd/osmo-remsim-client at .service +++ b/contrib/systemd/osmo-remsim-client at .service @@ -6,7 +6,7 @@ Restart=always EnvironmentFile=/etc/default/osmo-remsim-client EnvironmentFile=/etc/default/osmo-remsim-client-%i -ExecStart=/usr/bin/osmo-remsim-client-st2 $GLOBAL_CLIENT_OPTS -I $REMSIM_I -H $REMSIM_H -c $REMSIM_c +ExecStart=/usr/bin/osmo-remsim-client-st2 $GLOBAL_CLIENT_OPTS -I $REMSIM_I -H $REMSIM_H -c $REMSIM_c -n $REMSIM_n RestartSec=2 [Install] diff --git a/doc/manuals/chapters/remsim-bankd.adoc b/doc/manuals/chapters/remsim-bankd.adoc index be9b2c0..d35056b 100644 --- a/doc/manuals/chapters/remsim-bankd.adoc +++ b/doc/manuals/chapters/remsim-bankd.adoc @@ -85,6 +85,16 @@ Specify the local TCP port to whicc the socket for incoming connections from `osmo-remsim-client`s is bound to. +==== Examples +.remsim-server is on 10.2.3.4, cardreader has 5 slots: +---- +osmo-remsim-bankd -i 10.2.3.4 -n 5 +---- +.remsim-server is on 10.2.3.4, cardreader has 4 slots, local ip is 10.5.4.3 +---- +osmo-remsim-bankd -i 10.2.3.4 -n 4 -I 10.5.4.3 +---- + === Logging `osmo-remsim-bankd` currently logs to stdout only, and the logging diff --git a/doc/manuals/chapters/remsim-client.adoc b/doc/manuals/chapters/remsim-client.adoc index 0526dbb..8f90a1a 100644 --- a/doc/manuals/chapters/remsim-client.adoc +++ b/doc/manuals/chapters/remsim-client.adoc @@ -83,6 +83,15 @@ and will later be overridden by the ATR as specified by `osmo-remsim-bankd` once a card has been mapped to this client. +==== Examples +.remsim-server is on 10.2.3.4, sysmoQMOD on usb bus, all 4 modems: +---- +osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 0 -H 2-1.1 -c 0 -n 0 +osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 1 -H 2-1.1 -c 0 -n 1 +osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 0 -H 2-1.4 -c 0 -n 2 +osmo-remsim-client-st2 -s 10.2.3.4 -V 1d50 -P 4004 -C 1 -I 1 -H 2-1.4 -c 0 -n 3 +---- + === Logging `osmo-remsim-client` currently logs to stdout only, and the logging -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14667 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Idfa6352ce90dd36dd27306d6c8a2023935ed822d Gerrit-Change-Number: 14667 Gerrit-PatchSet: 2 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 01:57:38 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 01:57:38 +0000 Subject: Change in ...osmo-remsim[master]: add examples to remsim-server (json output) In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14668 ) Change subject: add examples to remsim-server (json output) ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I102a79a5d1f0055586a9fa1f9688acd4258f585b Gerrit-Change-Number: 14668 Gerrit-PatchSet: 2 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Jul 2019 01:57:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 01:57:41 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 01:57:41 +0000 Subject: Change in ...osmo-remsim[master]: add examples to remsim-server (json output) In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14668 ) Change subject: add examples to remsim-server (json output) ...................................................................... add examples to remsim-server (json output) Change-Id: I102a79a5d1f0055586a9fa1f9688acd4258f585b --- M doc/manuals/chapters/remsim-server.adoc 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/remsim-server.adoc b/doc/manuals/chapters/remsim-server.adoc index 01d24b2..e5c80c7 100644 --- a/doc/manuals/chapters/remsim-server.adoc +++ b/doc/manuals/chapters/remsim-server.adoc @@ -76,3 +76,13 @@ *POST* performs a global reset of the `osmo-remsim-server` state. This means all mappings are removed. + +==== Examples +.remsim-server is on 10.2.3.4, one simbank with 5 cards: http://10.2.3.4:9997/api/backend/v1/banks +---- +{"banks":[{"peer":"B1","state":"CONNECTED_BANKD","component_id":{"type_":"remsimBankd","name":"fixme-name","software":"remsim-bankd","swVersion":"0.1.0.17-6d8a"},"bankId":1,"numberOfSlots":5}]} +---- +.remsim-server is on 10.2.3.4, 4 clients: http://10.2.3.4:9997/api/backend/v1/clients +---- +{"clients":[{"peer":"C0:2","state":"CONNECTED_CLIENT","component_id":{"type_":"remsimClient","name":"simtrace2-remsim-client","software":"remsim-client","swVersion":"0.1.0.17-6d8a"}},{"peer":"C0:0","state":"CONNECTED_CLIENT","component_id":{"type_":"remsimClient","name":"simtrace2-remsim-client","software":"remsim-client","swVersion":"0.1.0.17-6d8a"}},{"peer":"C0:3","state":"CONNECTED_CLIENT","component_id":{"type_":"remsimClient","name":"simtrace2-remsim-client","software":"remsim-client","swVersion":"0.1.0.17-6d8a"}},{"peer":"C0:1","state":"CONNECTED_CLIENT","component_id":{"type_":"remsimClient","name":"simtrace2-remsim-client","software":"remsim-client","swVersion":"0.1.0.17-6d8a"}}]} +---- -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14668 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I102a79a5d1f0055586a9fa1f9688acd4258f585b Gerrit-Change-Number: 14668 Gerrit-PatchSet: 2 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 01:58:30 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 01:58:30 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: comments: BSC_Tests: clarify f_tc_ho_out_fail functions In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14708 ) Change subject: comments: BSC_Tests: clarify f_tc_ho_out_fail functions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia0584324476d36077e92d1564d9d7e79a069addf Gerrit-Change-Number: 14708 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Jul 2019 01:58:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 01:59:01 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 01:59:01 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: f_tc_ho_out_fail_no_ho_detect: stricter ordering In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14709 ) Change subject: f_tc_ho_out_fail_no_ho_detect: stricter ordering ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14709 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba05336d3c4af8a1c57cdc828dae464eae3510b9 Gerrit-Change-Number: 14709 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Jul 2019 01:59:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 01:59:41 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 01:59:41 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14710 ) Change subject: rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_ho_cmd ...................................................................... Patch Set 2: Code-Review+1 I'm not against the rename -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If84a1d4535ee12e33a50588e178bf1ebb6fb2cd5 Gerrit-Change-Number: 14710 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Wed, 10 Jul 2019 01:59:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 01:59:45 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 01:59:45 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: comments: BSC_Tests: clarify f_tc_ho_out_fail functions In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14708 ) Change subject: comments: BSC_Tests: clarify f_tc_ho_out_fail functions ...................................................................... comments: BSC_Tests: clarify f_tc_ho_out_fail functions Change-Id: Ia0584324476d36077e92d1564d9d7e79a069addf --- M bsc/BSC_Tests.ttcn 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 88df9bc..454ded7 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3119,8 +3119,12 @@ vc_conn.done; } -/* BSC asks for inter-BSC HO, receives BSSMAP Handover Command, but MS reports - * RR Handover Failure. */ +/* BSC asks for inter-BSC-out HO, receives BSSMAP Handover Command, but then no reply is received about HO outcome + * (neither BSSMAP Clear Command for success nor RR Handover Failure). 48.008 3.1.5.3.3 "Abnormal Conditions" applies + * and the lchan is released. + * Note: this test is a misnomer. On missing HO Detect, normally the old BSS receives an RR Handover Failure from the + * MS. Instead, this test is about the scenario in "Abnormal Conditions" as explained above. Leaving the test's name + * unchanged to not confuse jenkins result reports. */ private function f_tc_ho_out_fail_no_ho_detect(charstring id) runs on MSC_ConnHdlr { g_pars := f_gen_test_hdlr_pars(); @@ -3164,9 +3168,9 @@ } } - /* The MS never shows up on the remote BSS. Eventually the BSC times - * out (T8) and we run into 3GPP TS 48.008 3.1.5.3.3 "Abnormal Conditions": - * RR should be released and Clear Request should go to the MSC. */ + /* We get neither success nor failure report from the remote BSS. Eventually T8 times out and we run into 3GPP + * TS 48.008 3.1.5.3.3 "Abnormal Conditions": Clear Request should go to the MSC, and RR should be released + * after Clear Command */ var MgcpCommand mgcp; var PDU_BSSAP rx_clear_request; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia0584324476d36077e92d1564d9d7e79a069addf Gerrit-Change-Number: 14708 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 01:59:45 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 01:59:45 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: f_tc_ho_out_fail_no_ho_detect: stricter ordering In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14709 ) Change subject: f_tc_ho_out_fail_no_ho_detect: stricter ordering ...................................................................... f_tc_ho_out_fail_no_ho_detect: stricter ordering Make sure that the RR is released only after the MSC has sent the Clear Command: - first expect a Clear Request from osmo-bsc and return a Clear Command, - only then accept RR release messages. See 3GPP TS 48.008 3.1.5.3.3 "Abnormal Conditions": "The terrestrial resource in the old BSS shall remain assigned until a CLEAR COMMAND message is received from the MSC" osmo-bsc already complies, the test should continue to pass. Change-Id: Iba05336d3c4af8a1c57cdc828dae464eae3510b9 --- M bsc/BSC_Tests.ttcn 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 454ded7..854dbbc 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3172,8 +3172,14 @@ * TS 48.008 3.1.5.3.3 "Abnormal Conditions": Clear Request should go to the MSC, and RR should be released * after Clear Command */ - var MgcpCommand mgcp; var PDU_BSSAP rx_clear_request; + BSSAP.receive(tr_BSSMAP_ClearRequest) -> value rx_clear_request; + log("Got BSSMAP Clear Request"); + /* Instruct BSC to clear channel */ + var BssmapCause cause := bit2int(rx_clear_request.pdu.bssmap.clearRequest.cause.causeValue); + BSSAP.send(ts_BSSMAP_ClearCommand(cause)); + + var MgcpCommand mgcp; interleave { [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) { log("Got Deact SACCH"); @@ -3185,12 +3191,6 @@ log("Got RF Chan Rel"); RSL.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr)); } - [] BSSAP.receive(tr_BSSMAP_ClearRequest) -> value rx_clear_request { - log("Got BSSMAP Clear Request"); - /* Instruct BSC to clear channel */ - var BssmapCause cause := bit2int(rx_clear_request.pdu.bssmap.clearRequest.cause.causeValue); - BSSAP.send(ts_BSSMAP_ClearCommand(cause)); - } } f_expect_dlcx_conns(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14709 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iba05336d3c4af8a1c57cdc828dae464eae3510b9 Gerrit-Change-Number: 14709 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 02:01:28 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 02:01:28 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: L3_Templates: add enum CmIdentityType In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14706 ) Change subject: L3_Templates: add enum CmIdentityType ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14706 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibe50669663e641cdfd6a88f22c5404e2d90323b7 Gerrit-Change-Number: 14706 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Jul 2019 02:01:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 02:01:42 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 02:01:42 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: Cosmetic: L3_Templates: fix comment: fro -> for In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14705 ) Change subject: Cosmetic: L3_Templates: fix comment: fro -> for ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I239bbf21202300ac9883b5a0b5608d10db0fd721 Gerrit-Change-Number: 14705 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Jul 2019 02:01:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 02:01:46 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 02:01:46 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: Cosmetic: L3_Templates: fix comment: fro -> for In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14705 ) Change subject: Cosmetic: L3_Templates: fix comment: fro -> for ...................................................................... Cosmetic: L3_Templates: fix comment: fro -> for Change-Id: I239bbf21202300ac9883b5a0b5608d10db0fd721 --- M library/L3_Templates.ttcn 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index 6af020b..b39bb7a 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -54,7 +54,7 @@ } -/* send template fro Mobile Identity (TMSI) */ +/* send template for Mobile Identity (TMSI) */ template MobileIdentityLV ts_MI_TMSI_LV(OCT4 tmsi) := { lengthIndicator := 0, /* overwritten */ mobileIdentityV := { @@ -69,7 +69,7 @@ } } -/* send template fro Mobile Identity (TMSI) */ +/* send template for Mobile Identity (TMSI) */ function ts_MI_TMSI_TLV(template (omit) OCT4 tmsi) return template (omit) MobileIdentityTLV { var template (omit) MobileIdentityTLV ret; if (istemplatekind(tmsi, "omit")) { @@ -129,7 +129,7 @@ return l3; } -/* send template fro Mobile Identity (IMSI) */ +/* send template for Mobile Identity (IMSI) */ template (value) MobileIdentityLV ts_MI_IMSI_LV(hexstring imsi_digits) := { lengthIndicator := 0, /* overwritten */ mobileIdentityV := { @@ -140,7 +140,7 @@ } } -/* send template fro Mobile Identity (IMEI) */ +/* send template for Mobile Identity (IMEI) */ template (value) MobileIdentityLV ts_MI_IMEI_LV(hexstring imei_digits) := { lengthIndicator := 0, /* overwritten */ mobileIdentityV := { @@ -151,7 +151,7 @@ } } -/* send template fro Mobile Identity (IMEISV) */ +/* send template for Mobile Identity (IMEISV) */ template (value) MobileIdentityLV ts_MI_IMEISV_LV(hexstring imei_digits) := { lengthIndicator := 0, /* overwritten */ mobileIdentityV := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14705 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I239bbf21202300ac9883b5a0b5608d10db0fd721 Gerrit-Change-Number: 14705 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 02:01:47 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 02:01:47 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: L3_Templates: add enum CmIdentityType In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14706 ) Change subject: L3_Templates: add enum CmIdentityType ...................................................................... L3_Templates: add enum CmIdentityType Change-Id: Ibe50669663e641cdfd6a88f22c5404e2d90323b7 --- M library/L3_Templates.ttcn M msc/MSC_Tests.ttcn 2 files changed, 12 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index b39bb7a..3011919 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -35,6 +35,15 @@ CM_TYPE_LCS ('1011'B) } +/* TS 24.008 10.5.3.4 Identity Type */ +type enumerated CmIdentityType { + CM_ID_TYPE_IMSI ('001'B), + CM_ID_TYPE_IMEI ('010'B), + CM_ID_TYPE_IMEISV ('011'B), + CM_ID_TYPE_TMSI ('100'B), + CM_ID_TYPE_PTMSI_RAI_PTMSI_SIG ('101'B) +} + template ML3_Cause_TLV ts_ML3_Cause(BIT7 cause, BIT4 loc := '0001'B, BIT2 std := '11'B) := { elementIdentifier := '08'O, lengthIndicator := 0, /* overwritten */ @@ -864,7 +873,7 @@ } } -template PDU_ML3_NW_MS tr_ML3_MT_MM_ID_Req(template BIT3 id_type := ?) := { +template PDU_ML3_NW_MS tr_ML3_MT_MM_ID_Req(template CmIdentityType id_type := ?) := { discriminator := '0101'B, tiOrSkip := { skipIndicator := '0000'B @@ -874,7 +883,7 @@ identityRequest := { messageType := '011000'B, nsd := '00'B, - identityType := id_type, + identityType := int2bit(enum2int(valueof(id_type)), 3), spare1_5 := ? } } diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index f551513..6f9eecd 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -817,7 +817,7 @@ BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); /* Wait for + respond to ID REQ (IMSI) */ - BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req('001'B))); + BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req(CM_ID_TYPE_IMSI))); BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_MM_ID_Rsp_IMSI(overlong_imsi))); /* test for OS#2864 */ BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_MM_ID_Rsp_IMSI(g_pars.imsi))); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14706 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibe50669663e641cdfd6a88f22c5404e2d90323b7 Gerrit-Change-Number: 14706 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 02:02:13 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 02:02:13 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: add check IMEI tests In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 ) Change subject: msc: add check IMEI tests ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d Gerrit-Change-Number: 14694 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 10 Jul 2019 02:02:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 02:05:45 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 02:05:45 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14612 ) Change subject: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iae6b78bafa4b86d0c681684de47320d641d3f7c0 Gerrit-Change-Number: 14612 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 10 Jul 2019 02:05:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 02:06:40 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 02:06:40 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14684 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1e654a2e49cb83c5f1e6249c0de688f99bc466b0 Gerrit-Change-Number: 14684 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Jul 2019 02:06:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 02:10:02 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 02:10:02 +0000 Subject: Change in ...osmo-bts[master]: Move Access Burst link quality handling to L1SAP In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14687 ) Change subject: Move Access Burst link quality handling to L1SAP ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14687/2/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14687/2/src/osmo-bts-trx/scheduler_trx.c at 820 PS2, Line 820: l1sap.u.rach_ind.lqual_cb = l1t->trx->bts->min_qual_rach why are we setting lqual_cb to a static value here? To report some reasonable default in the TRXDv0 case? Might make sense to explain this explicitly? Or is that what the cryptic comment above means (I wouldn't understand it)? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Gerrit-Change-Number: 14687 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Jul 2019 02:10:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 02:10:19 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 02:10:19 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14688 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8d86dec7ebc039cbfd038c4342ff328b11281865 Gerrit-Change-Number: 14688 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Jul 2019 02:10:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 02:10:47 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 02:10:47 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14689 ) Change subject: osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea0dad65e9bc511f99375fd3ee2eb44e47a6168f Gerrit-Change-Number: 14689 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Jul 2019 02:10:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 02:10:51 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 10 Jul 2019 02:10:51 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14688 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8d86dec7ebc039cbfd038c4342ff328b11281865 Gerrit-Change-Number: 14688 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Jul 2019 02:10:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Wed Jul 10 02:54:37 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 10 Jul 2019 02:54:37 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d25537a3a14d_70ce112e5fc30192a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 1006s] | configure:13464: result: yes [ 1006s] | configure:14062: checking whether to enable VTY/CTRL tests [ 1006s] | configure:14064: result: no [ 1006s] | configure:14311: checking whether gcc has __builtin_cpu_supports built-in [ 1006s] | configure:14332: gcc -o conftest -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -DBUILDING_LIBOSMOCORE -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -DBUILDING_LIBOSMOCORE -Wall -Wl,-z,relro -Wl,-z,now conftest.c >&5 [ 1006s] | conftest.c: In function 'main': [ 1006s] | conftest.c:46:11: warning: implicit declaration of function '__builtin_cpu_supports' [-Wimplicit-function-declaration] [ 1006s] | __builtin_cpu_supports("sse"); [ 1006s] | ^~~~~~~~~~~~~~~~~~~~~~ [ 1006s] | /tmp/ccQVSwXu.o: In function `main': [ 1006s] | ./conftest.c:46: undefined reference to `__builtin_cpu_supports' [ 1006s] | collect2: error: ld returned 1 exit status [ 1006s] | configure:14332: $? = 1 [ 1006s] | configure: failed program was: [ 1006s] | | /* confdefs.h */ [ 1006s] | | #define PACKAGE_NAME "libosmocore" [ 1006s] | | #define PACKAGE_TARNAME "libosmocore" [ 1006s] | | #define PACKAGE_VERSION "1.1.0.77-e242" [ 1006s] | | #define PACKAGE_STRING "libosmocore 1.1.0.77-e242" [ 1006s] | | #define PACKAGE_BUGREPORT "openbsc at lists.osmocom.org" [ 1006s] | | #define PACKAGE_URL "" [ 1006s] | | #define PACKAGE "libosmocore" [ 1006s] | | #define VERSION "1.1.0.77-e242" [ 1008s] | | #def[ 940.095788] sysrq: SysRq : Power Off [ 1008s] [ 940.112713] reboot: Power down [ 1008s] ### VM INTERACTION END ### [ 1008s] [ 1008s] armbuild04 failed "build libosmocore_1.1.0.77.e242.dsc" at Wed Jul 10 02:54:22 UTC 2019. [ 1008s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Wed Jul 10 05:16:21 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 10 Jul 2019 05:16:21 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2574a7ef511_70ce112e5fc3220d4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 468s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 468s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 468s] collect2: error: ld returned 1 exit status [ 468s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 468s] make[4]: *** [osmo-bts-virtual] Error 1 [ 468s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 468s] Makefile:385: recipe for target 'all-recursive' failed [ 468s] make[3]: *** [all-recursive] Error 1 [ 468s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 468s] Makefile:434: recipe for target 'all-recursive' failed [ 468s] make[2]: *** [all-recursive] Error 1 [ 468s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 468s] Makefile:366: recipe for target 'all' failed [ 468s] make[1]: *** [all] Error 2 [ 468s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 468s] dh_auto_build: make -j1 returned exit code 2 [ 468s] debian/rules:12: recipe for target 'build' failed [ 468s] make: *** [build] Error 2 [ 468s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 468s] [ 468s] armbuild01 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Wed Jul 10 05:16:16 UTC 2019. [ 468s] [ 468s] ### VM INTERACTION START ### [ 471s] [ 441.644140] sysrq: SysRq : Power Off [ 471s] [ 441.677143] reboot: Power down [ 471s] ### VM INTERACTION END ### [ 471s] [ 471s] armbuild01 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Wed Jul 10 05:16:19 UTC 2019. [ 471s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Wed Jul 10 05:49:46 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 10 Jul 2019 05:49:46 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d257c7ec146a_70ce112e5fc3233de@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 575s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 575s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 575s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 575s] Makefile:442: recipe for target 'vlr.o' failed [ 575s] make[4]: *** [vlr.o] Error 1 [ 575s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 575s] Makefile:422: recipe for target 'all-recursive' failed [ 575s] make[3]: *** [all-recursive] Error 1 [ 575s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 575s] Makefile:462: recipe for target 'all-recursive' failed [ 575s] make[2]: *** [all-recursive] Error 1 [ 575s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 575s] Makefile:394: recipe for target 'all' failed [ 575s] make[1]: *** [all] Error 2 [ 575s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 575s] dh_auto_build: make -j1 returned exit code 2 [ 575s] debian/rules:45: recipe for target 'build' failed [ 575s] make: *** [build] Error 2 [ 575s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 575s] [ 575s] armbuild25 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Wed Jul 10 05:49:27 UTC 2019. [ 575s] [ 575s] ### VM INTERACTION START ### [ 578s] [ 532.427421] sysrq: SysRq : Power Off [ 578s] [ 532.428762] reboot: Power down [ 578s] ### VM INTERACTION END ### [ 578s] [ 578s] armbuild25 failed "build osmo-msc_1.3.1.175.1c500.dsc" at Wed Jul 10 05:49:30 UTC 2019. [ 578s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Wed Jul 10 05:58:55 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 10 Jul 2019 05:58:55 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d257eb8dc2aa_70ce112e5fc32396b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 677s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 677s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 677s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 677s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 677s] make[4]: *** [gb_proxy.o] Error 1 [ 677s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 677s] Makefile:391: recipe for target 'all-recursive' failed [ 677s] make[3]: *** [all-recursive] Error 1 [ 677s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 677s] Makefile:453: recipe for target 'all-recursive' failed [ 677s] make[2]: *** [all-recursive] Error 1 [ 677s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 677s] Makefile:385: recipe for target 'all' failed [ 677s] make[1]: *** [all] Error 2 [ 677s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 677s] dh_auto_build: make -j1 returned exit code 2 [ 677s] debian/rules:45: recipe for target 'build' failed [ 677s] make: *** [build] Error 2 [ 677s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 677s] [ 677s] armbuild16 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Wed Jul 10 05:58:34 UTC 2019. [ 677s] [ 677s] ### VM INTERACTION START ### [ 680s] [ 627.810590] sysrq: SysRq : Power Off [ 680s] [ 627.812642] reboot: Power down [ 683s] ### VM INTERACTION END ### [ 683s] [ 683s] armbuild16 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Wed Jul 10 05:58:40 UTC 2019. [ 683s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Jul 10 07:08:38 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 07:08:38 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: log_merge.sh: format logs after merging In-Reply-To: References: Message-ID: Hello dexter, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 to look at the new patch set (#2). Change subject: log_merge.sh: format logs after merging ...................................................................... log_merge.sh: format logs after merging Keep unformatted logs in a new logs_unformatted dir, in case we need to use ttcn3_logfilter on them. Related: OS#3916 Change-Id: I671ffa2761c6e503dae9f3b16764d430131b16af --- M .gitignore M log_merge.sh 2 files changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/07/14707/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I671ffa2761c6e503dae9f3b16764d430131b16af Gerrit-Change-Number: 14707 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 07:10:05 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 07:10:05 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: log_merge.sh: format logs after merging In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 ) Change subject: log_merge.sh: format logs after merging ...................................................................... Patch Set 2: Patch updated to keep the unformatted logs in a new logs_unformatted dir. Now we have both, what do you think? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I671ffa2761c6e503dae9f3b16764d430131b16af Gerrit-Change-Number: 14707 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 10 Jul 2019 07:10:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 07:44:33 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 07:44:33 +0000 Subject: Change in ...docker-playground[master]: ttcn3-*: enable GSMTAP logging Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14712 Change subject: ttcn3-*: enable GSMTAP logging ...................................................................... ttcn3-*: enable GSMTAP logging Configure each osmo-* program to send GSMTAP log output to the IP of the docker container, which runs the testsuite (and therefore runs tcpdump). Related: https://lists.osmocom.org/pipermail/openbsc/2019-June/012946.html Change-Id: I99e74f6ffb5b7d566cec35995bf067df414968d8 --- M ttcn3-bsc-test/osmo-bsc.cfg M ttcn3-bsc-test/osmo-stp.cfg M ttcn3-bsc-test/sccplite/osmo-bsc.cfg M ttcn3-bscnat-test/osmo-bsc-nat.cfg M ttcn3-bts-test/oml/osmo-bts.cfg M ttcn3-bts-test/osmo-bsc.cfg M ttcn3-bts-test/osmo-bts.cfg M ttcn3-bts-test/virtphy/osmo-bts.cfg M ttcn3-ggsn-test/osmo-ggsn.cfg M ttcn3-hlr-test/osmo-hlr.cfg M ttcn3-mgw-test/osmo-mgw.cfg M ttcn3-msc-test/osmo-msc.cfg M ttcn3-msc-test/osmo-stp.cfg M ttcn3-pcu-test/osmo-pcu.cfg M ttcn3-pcu-test/sns/osmo-pcu.cfg M ttcn3-sgsn-test/osmo-sgsn.cfg M ttcn3-sip-test/osmo-sip-connector.cfg 17 files changed, 51 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/12/14712/1 diff --git a/ttcn3-bsc-test/osmo-bsc.cfg b/ttcn3-bsc-test/osmo-bsc.cfg index 783563a..3d226e9 100644 --- a/ttcn3-bsc-test/osmo-bsc.cfg +++ b/ttcn3-bsc-test/osmo-bsc.cfg @@ -3,6 +3,9 @@ !! password foo ! +log gsmtap 172.18.2.203 + logging level set-all debug +! log file /data/osmo-bsc.log logging filter all 1 logging color 0 diff --git a/ttcn3-bsc-test/osmo-stp.cfg b/ttcn3-bsc-test/osmo-stp.cfg index 7cee48b..f58fe64 100644 --- a/ttcn3-bsc-test/osmo-stp.cfg +++ b/ttcn3-bsc-test/osmo-stp.cfg @@ -2,6 +2,9 @@ ! OsmoSTP (0.8.1) configuration saved from vty !! ! +log gsmtap 172.18.2.203 + logging level set-all debug +! log file /data/osmo-stp.log logging filter all 1 logging color 0 diff --git a/ttcn3-bsc-test/sccplite/osmo-bsc.cfg b/ttcn3-bsc-test/sccplite/osmo-bsc.cfg index 3f29361..f7d640c 100644 --- a/ttcn3-bsc-test/sccplite/osmo-bsc.cfg +++ b/ttcn3-bsc-test/sccplite/osmo-bsc.cfg @@ -3,6 +3,9 @@ !! password foo ! +log gsmtap 172.18.12.203 + logging level set-all debug +! log file /data/osmo-bsc.log logging filter all 1 logging color 0 diff --git a/ttcn3-bscnat-test/osmo-bsc-nat.cfg b/ttcn3-bscnat-test/osmo-bsc-nat.cfg index 80d7095..66ecdc9 100644 --- a/ttcn3-bscnat-test/osmo-bsc-nat.cfg +++ b/ttcn3-bscnat-test/osmo-bsc-nat.cfg @@ -2,6 +2,9 @@ ! OsmoBSCNAT (0.12.0.266-2daa9) configuration saved from vty !! ! +log gsmtap 172.18.15.203 + logging level set-all debug +! log file /data/osmo-bsc_nat.log logging filter all 1 logging color 0 diff --git a/ttcn3-bts-test/oml/osmo-bts.cfg b/ttcn3-bts-test/oml/osmo-bts.cfg index 4ed1951..562440b 100644 --- a/ttcn3-bts-test/oml/osmo-bts.cfg +++ b/ttcn3-bts-test/oml/osmo-bts.cfg @@ -2,6 +2,9 @@ ! OsmoBTS (0.4.0.446-e0fb) configuration saved from vty !! ! +log gsmtap 172.18.9.10 + logging level set-all debug +! log file /data/osmo-bts.log logging filter all 1 logging color 0 diff --git a/ttcn3-bts-test/osmo-bsc.cfg b/ttcn3-bts-test/osmo-bsc.cfg index e98cc57..b2a45bc 100644 --- a/ttcn3-bts-test/osmo-bsc.cfg +++ b/ttcn3-bts-test/osmo-bsc.cfg @@ -3,6 +3,9 @@ !! password foo ! +log gsmtap 172.18.9.10 + logging level set-all debug +! log file /data/osmo-bsc.log logging filter all 1 logging color 0 diff --git a/ttcn3-bts-test/osmo-bts.cfg b/ttcn3-bts-test/osmo-bts.cfg index 611355b..11afc0d 100644 --- a/ttcn3-bts-test/osmo-bts.cfg +++ b/ttcn3-bts-test/osmo-bts.cfg @@ -2,6 +2,9 @@ ! OsmoBTS (0.4.0.446-e0fb) configuration saved from vty !! ! +log gsmtap 172.18.9.10 + logging level set-all debug +! log file /data/osmo-bts.log logging filter all 1 logging color 0 diff --git a/ttcn3-bts-test/virtphy/osmo-bts.cfg b/ttcn3-bts-test/virtphy/osmo-bts.cfg index 5957f03..540dcc3 100644 --- a/ttcn3-bts-test/virtphy/osmo-bts.cfg +++ b/ttcn3-bts-test/virtphy/osmo-bts.cfg @@ -2,6 +2,9 @@ ! OsmoBTS (0.4.0.446-e0fb) configuration saved from vty !! ! +log gsmtap 172.18.9.10 + logging level set-all debug +! log file /data/osmo-bts.log logging filter all 1 logging color 0 diff --git a/ttcn3-ggsn-test/osmo-ggsn.cfg b/ttcn3-ggsn-test/osmo-ggsn.cfg index ddbbf6c..fd1ea95 100644 --- a/ttcn3-ggsn-test/osmo-ggsn.cfg +++ b/ttcn3-ggsn-test/osmo-ggsn.cfg @@ -2,6 +2,9 @@ ! OpenGGSN (0.94.1-adac) configuration saved from vty !! ! +log gsmtap 172.18.3.202 + logging level set-all debug +! log file /data/osmo-ggsn.log logging filter all 1 logging color 0 diff --git a/ttcn3-hlr-test/osmo-hlr.cfg b/ttcn3-hlr-test/osmo-hlr.cfg index 47bbd23..57c1701 100644 --- a/ttcn3-hlr-test/osmo-hlr.cfg +++ b/ttcn3-hlr-test/osmo-hlr.cfg @@ -1,6 +1,9 @@ ! ! OsmoHLR example configuration ! +log gsmtap 172.18.10.103 + logging level set-all debug +! log stderr logging filter all 1 logging color 1 diff --git a/ttcn3-mgw-test/osmo-mgw.cfg b/ttcn3-mgw-test/osmo-mgw.cfg index 882c7d0..86645ba 100644 --- a/ttcn3-mgw-test/osmo-mgw.cfg +++ b/ttcn3-mgw-test/osmo-mgw.cfg @@ -2,6 +2,9 @@ ! OsmoMGW (1.2.0.17-52e3) configuration saved from vty !! ! +log gsmtap 172.18.4.181 + logging level set-all debug +! log stderr logging filter all 1 logging color 1 diff --git a/ttcn3-msc-test/osmo-msc.cfg b/ttcn3-msc-test/osmo-msc.cfg index db2029c..98a1a01 100644 --- a/ttcn3-msc-test/osmo-msc.cfg +++ b/ttcn3-msc-test/osmo-msc.cfg @@ -2,6 +2,9 @@ ! OsmoMSC (1.1.2.66-629c4-dirty) configuration saved from vty !! ! +log gsmtap 172.18.1.103 + logging level set-all debug +! log file /data/osmo-msc.log logging filter all 1 logging color 0 diff --git a/ttcn3-msc-test/osmo-stp.cfg b/ttcn3-msc-test/osmo-stp.cfg index cefaef1..1310be2 100644 --- a/ttcn3-msc-test/osmo-stp.cfg +++ b/ttcn3-msc-test/osmo-stp.cfg @@ -2,6 +2,9 @@ ! OsmoSTP (0.8.1) configuration saved from vty !! ! +log gsmtap 172.18.1.103 + logging level set-all debug +! log file /data/osmo-stp.log logging filter all 1 logging color 0 diff --git a/ttcn3-pcu-test/osmo-pcu.cfg b/ttcn3-pcu-test/osmo-pcu.cfg index e8a8552..ed31269 100644 --- a/ttcn3-pcu-test/osmo-pcu.cfg +++ b/ttcn3-pcu-test/osmo-pcu.cfg @@ -1,3 +1,6 @@ +log gsmtap 172.18.13.10 + logging level set-all debug + log file /data/osmo-pcu.log logging filter all 1 logging color 0 diff --git a/ttcn3-pcu-test/sns/osmo-pcu.cfg b/ttcn3-pcu-test/sns/osmo-pcu.cfg index f9bce3a..b7c57d1 100644 --- a/ttcn3-pcu-test/sns/osmo-pcu.cfg +++ b/ttcn3-pcu-test/sns/osmo-pcu.cfg @@ -1,3 +1,6 @@ +log gsmtap 172.18.14.10 + logging level set-all debug + log file /data/osmo-pcu.log logging filter all 1 logging color 0 diff --git a/ttcn3-sgsn-test/osmo-sgsn.cfg b/ttcn3-sgsn-test/osmo-sgsn.cfg index 37f4ed8..996d251 100644 --- a/ttcn3-sgsn-test/osmo-sgsn.cfg +++ b/ttcn3-sgsn-test/osmo-sgsn.cfg @@ -2,6 +2,9 @@ ! OsmoSGSN (1.2.0.46-e77e-dirty) configuration saved from vty !! ! +log gsmtap 172.18.8.103 + logging level set-all debug +! log stderr logging filter all 1 logging color 1 diff --git a/ttcn3-sip-test/osmo-sip-connector.cfg b/ttcn3-sip-test/osmo-sip-connector.cfg index 5df7468..efdee58 100644 --- a/ttcn3-sip-test/osmo-sip-connector.cfg +++ b/ttcn3-sip-test/osmo-sip-connector.cfg @@ -2,6 +2,9 @@ ! OsmoMNCC (1.1.0-dirty) configuration saved from vty !! ! +log gsmtap 172.18.11.103 + logging level set-all debug +! log file /data/osmo-sip-connector.log logging filter all 1 logging color 0 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I99e74f6ffb5b7d566cec35995bf067df414968d8 Gerrit-Change-Number: 14712 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 07:54:51 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 07:54:51 +0000 Subject: Change in ...docker-playground[master]: ttcn3-*: enable GSMTAP logging In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14712 ) Change subject: ttcn3-*: enable GSMTAP logging ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I99e74f6ffb5b7d566cec35995bf067df414968d8 Gerrit-Change-Number: 14712 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 10 Jul 2019 07:54:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 08:04:49 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 08:04:49 +0000 Subject: Change in ...osmo-msc[master]: Add vty option to globally enable LCLS In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13421 ) Change subject: Add vty option to globally enable LCLS ...................................................................... Patch Set 6: Hoernchen, passing this patch to you, because the related issue is also assigned to you: https://osmocom.org/issues/2487 As mentioned above: the patch is complete basically, but the VTY option has no effect yet, hence the patch is set to WIP. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/13421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibb587e6ae47cff71f5bf2e2d22c1da86cd7e1762 Gerrit-Change-Number: 13421 Gerrit-PatchSet: 6 Gerrit-Owner: Max Gerrit-Assignee: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-CC: Hoernchen Gerrit-Comment-Date: Wed, 10 Jul 2019 08:04:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 08:07:59 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 08:07:59 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14586 ) Change subject: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7080effbbc1022d1884c6d6f0cb580eba8e514ff Gerrit-Change-Number: 14586 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Jul 2019 08:07:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 08:10:52 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 08:10:52 +0000 Subject: Change in ...osmo-msc[master]: add semi-color after OSMO_ASSERT In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14711 ) Change subject: add semi-color after OSMO_ASSERT ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14711/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14711/1//COMMIT_MSG at 7 PS1, Line 7: color color? :) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I42fca73393d14ebed973616b86fb87f89bdbf095 Gerrit-Change-Number: 14711 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 10 Jul 2019 08:10:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 11:32:45 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 10 Jul 2019 11:32:45 +0000 Subject: Change in ...docker-playground[master]: ttcn3-*: enable GSMTAP logging In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14712 ) Change subject: ttcn3-*: enable GSMTAP logging ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I99e74f6ffb5b7d566cec35995bf067df414968d8 Gerrit-Change-Number: 14712 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 10 Jul 2019 11:32:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:03:11 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:03:11 +0000 Subject: Change in ...gapk[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/gapk/+/14713 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ifb581662b05d938acc04636c2a408e43bbe10bf0 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/13/14713/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index cf53c3a..2e9035d 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -38,5 +38,6 @@ $MAKE $PARALLEL_MAKE LD_LIBRARY_PATH="$inst/lib" $MAKE check || cat-testlogs.sh LD_LIBRARY_PATH="$inst/lib" DISTCHECK_CONFIGURE_FLAGS="" $MAKE distcheck || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/gapk/+/14713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: Ifb581662b05d938acc04636c2a408e43bbe10bf0 Gerrit-Change-Number: 14713 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:03:49 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:03:49 +0000 Subject: Change in ...libasn1c[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libasn1c/+/14714 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: If91b10d37cb4c940e009c12b232d042305d57886 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/14/14714/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7d68736..c23bdec 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -17,5 +17,6 @@ $MAKE $PARALLEL_MAKE $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/14714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: If91b10d37cb4c940e009c12b232d042305d57886 Gerrit-Change-Number: 14714 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:03:52 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:03:52 +0000 Subject: Change in ...libgtpnl[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libgtpnl/+/14715 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I20997b986b24ced9bb8d6d66a66d5ec2bafd00f2 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/15/14715/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index ebdc6ea..43e81a1 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -8,5 +8,6 @@ ./configure --enable-sanitize CFLAGS="-Werror" CPPFLAGS="-Werror" $MAKE $PARALLEL_MAKE $MAKE distcheck +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/14715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I20997b986b24ced9bb8d6d66a66d5ec2bafd00f2 Gerrit-Change-Number: 14715 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:03:55 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:03:55 +0000 Subject: Change in ...libosmo-abis[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14716 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ib261f25e2c7b48283a6142259991aadfcf40cdec --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/16/14716/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 6a76044..a465d5a 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -37,5 +37,6 @@ $MAKE $PARALLEL_MAKE $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib261f25e2c7b48283a6142259991aadfcf40cdec Gerrit-Change-Number: 14716 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:04:50 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:04:50 +0000 Subject: Change in ...libosmo-netif[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/14717 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I37908c12dae9d268b8bde186e2743a2d7fd13536 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/17/14717/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index f2013a5..5cfa8cb 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -39,5 +39,6 @@ $MAKE $PARALLEL_MAKE $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/14717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I37908c12dae9d268b8bde186e2743a2d7fd13536 Gerrit-Change-Number: 14717 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:04:53 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:04:53 +0000 Subject: Change in ...libosmo-sccp[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14718 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ia6ebe5add2c1ce6891d596fb2987e46f8ff8a6d6 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/18/14718/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index c54c1ac..da96c5e 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -54,6 +54,7 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14718 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia6ebe5add2c1ce6891d596fb2987e46f8ff8a6d6 Gerrit-Change-Number: 14718 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:04:56 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:04:56 +0000 Subject: Change in ...libosmocore[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14719 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ic147678e7906a8b9ad7fac8367602b656f4172e6 --- M contrib/jenkins_amd64.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/19/14719/1 diff --git a/contrib/jenkins_amd64.sh b/contrib/jenkins_amd64.sh index 9b83793..c79e26a 100755 --- a/contrib/jenkins_amd64.sh +++ b/contrib/jenkins_amd64.sh @@ -31,5 +31,6 @@ DISTCHECK_CONFIGURE_FLAGS=--enable-external-tests \ $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic147678e7906a8b9ad7fac8367602b656f4172e6 Gerrit-Change-Number: 14719 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:04:59 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:04:59 +0000 Subject: Change in ...libsmpp34[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libsmpp34/+/14720 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I78fc465169b9ed95a2f9aaef93f28e1ce47b551a --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/20/14720/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 8680cde..3b4e639 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -10,5 +10,6 @@ $MAKE $MAKE $PARALLEL_MAKE $MAKE distcheck || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/14720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I78fc465169b9ed95a2f9aaef93f28e1ce47b551a Gerrit-Change-Number: 14720 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:05:02 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:05:02 +0000 Subject: Change in ...libtelnet[master]: contrib/jenkins.sh: run "make {distcheck, maintainer-clean}" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libtelnet/+/14721 Change subject: contrib/jenkins.sh: run "make {distcheck,maintainer-clean}" ...................................................................... contrib/jenkins.sh: run "make {distcheck,maintainer-clean}" Related: OS#3047 Change-Id: I0c7cd8f8b2a3821e5c55fc84b24eca5e199ebbd8 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libtelnet refs/changes/21/14721/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 57da9fa..d75beda 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -5,3 +5,5 @@ autoreconf --install --force ./configure $MAKE $PARALLEL_MAKE +$MAKE distcheck +$MAKE maintainer-clean -- To view, visit https://gerrit.osmocom.org/c/libtelnet/+/14721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libtelnet Gerrit-Branch: master Gerrit-Change-Id: I0c7cd8f8b2a3821e5c55fc84b24eca5e199ebbd8 Gerrit-Change-Number: 14721 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:05:05 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:05:05 +0000 Subject: Change in ...libusrp[master]: contrib/jenkins.sh: run "make {distcheck, maintainer-clean}" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libusrp/+/14722 Change subject: contrib/jenkins.sh: run "make {distcheck,maintainer-clean}" ...................................................................... contrib/jenkins.sh: run "make {distcheck,maintainer-clean}" Related: OS#3047 Change-Id: Ic277f37413cb338f4f9bdf4c5fc033d94a2cd5db --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libusrp refs/changes/22/14722/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 57da9fa..d75beda 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -5,3 +5,5 @@ autoreconf --install --force ./configure $MAKE $PARALLEL_MAKE +$MAKE distcheck +$MAKE maintainer-clean -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/14722 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Ic277f37413cb338f4f9bdf4c5fc033d94a2cd5db Gerrit-Change-Number: 14722 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:05:08 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:05:08 +0000 Subject: Change in ...openbsc[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/openbsc/+/14723 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I3324f96ea0ec25b210562e0523b21f1a94db12ec --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/23/14723/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 277fece..da8703a 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -46,6 +46,7 @@ "$MAKE" $PARALLEL_MAKE "$MAKE" check || cat-testlogs.sh "$MAKE" distcheck || cat-testlogs.sh + "$MAKE" maintainer-clean } . osmo-build.sh -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I3324f96ea0ec25b210562e0523b21f1a94db12ec Gerrit-Change-Number: 14723 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:05:11 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:05:11 +0000 Subject: Change in ...osmo-bsc[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14724 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I5c257e21376cdccd6e2f413c7df6dd8caef497f1 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/24/14724/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index a47935f..524971b 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -61,6 +61,7 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-vty-tests --enable-external-tests --enable-werror $CONFIG" \ $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14724 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c257e21376cdccd6e2f413c7df6dd8caef497f1 Gerrit-Change-Number: 14724 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:05:14 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:05:14 +0000 Subject: Change in ...osmo-bts[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14725 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I9d9b2412f005e4bda0ed35ba715cfb4dca1b04c1 --- M contrib/jenkins_common.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/25/14725/1 diff --git a/contrib/jenkins_common.sh b/contrib/jenkins_common.sh index fd0359b..6e4fa7e 100644 --- a/contrib/jenkins_common.sh +++ b/contrib/jenkins_common.sh @@ -57,4 +57,6 @@ if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then $MAKE -C "$base/doc/manuals" publish fi + + $MAKE maintainer-clean } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9d9b2412f005e4bda0ed35ba715cfb4dca1b04c1 Gerrit-Change-Number: 14725 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:05:18 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:05:18 +0000 Subject: Change in ...osmo-e1d[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/14726 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: If69a9bddefd74fbdd8003d9efbb4f7756f407037 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/26/14726/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 255ad71..a6ca30e 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -44,5 +44,6 @@ $MAKE $PARALLEL_MAKE $MAKE check || cat-testlogs.sh DISTCHECK_CONFIGURE_FLAGS="$CONFIG" $MAKE distcheck || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/14726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: If69a9bddefd74fbdd8003d9efbb4f7756f407037 Gerrit-Change-Number: 14726 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:05:21 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:05:21 +0000 Subject: Change in ...osmo-ggsn[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14727 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I0ad159a3973d28ac79ea7fb433401c72b247c2b0 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/27/14727/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index b512334..2c03c09 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -60,4 +60,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14727 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I0ad159a3973d28ac79ea7fb433401c72b247c2b0 Gerrit-Change-Number: 14727 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:05:45 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:05:45 +0000 Subject: Change in ...osmo-gsm-manuals[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14728 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I99b9cd46e564cc1c5c1e92b9870368ff515a9356 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/28/14728/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7d4d8df..0c40e2f 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -16,5 +16,6 @@ $MAKE $PARALLEL_MAKE $MAKE $PARALLEL_MAKE check $MAKE $PARALLEL_MAKE distcheck +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I99b9cd46e564cc1c5c1e92b9870368ff515a9356 Gerrit-Change-Number: 14728 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:05:48 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:05:48 +0000 Subject: Change in ...osmo-hlr[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14729 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I63808c5c2724b8f4c3cf40db682f74eec54f1e76 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/29/14729/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 1dadac3..5914182 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -58,4 +58,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I63808c5c2724b8f4c3cf40db682f74eec54f1e76 Gerrit-Change-Number: 14729 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:05:51 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:05:51 +0000 Subject: Change in ...osmo-iuh[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14730 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I6f9274efeb2fdda54feaa54eb299f7aafaaec1eb --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/30/14730/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 617aeac..5754f2c 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -55,5 +55,6 @@ || cat-testlogs.sh $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6f9274efeb2fdda54feaa54eb299f7aafaaec1eb Gerrit-Change-Number: 14730 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:05:54 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:05:54 +0000 Subject: Change in ...osmo-mgw[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14731 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I60c713a64ef629f0cb88121632ea6adc017fd0ae --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/31/14731/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 9777d4b..706ad5c 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -63,4 +63,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I60c713a64ef629f0cb88121632ea6adc017fd0ae Gerrit-Change-Number: 14731 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:05:57 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:05:57 +0000 Subject: Change in ...osmo-msc[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14732 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ifc91733c7fe0c5a002037523116014bf270997ef --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/32/14732/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index be8dadc..dca33bb 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -78,4 +78,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ifc91733c7fe0c5a002037523116014bf270997ef Gerrit-Change-Number: 14732 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:06:00 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:06:00 +0000 Subject: Change in ...osmo-pcap[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14733 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ieae88eec72801e143daa631e7d01a5e11e9befae --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/33/14733/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7ec1463..f1779dc 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -41,5 +41,6 @@ DISTCHECK_CONFIGURE_FLAGS="--with-pcap-config=/bin/true" \ PCAP_LIBS="-lpcap" PCAP_CFLAGS="" \ $MAKE distcheck || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ieae88eec72801e143daa631e7d01a5e11e9befae Gerrit-Change-Number: 14733 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:06:03 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:06:03 +0000 Subject: Change in ...osmo-pcu[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14734 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I733df8f8bfaf448a6507c9c9d75d2f076fedb342 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/34/14734/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index e805080..8c32cbb 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -104,4 +104,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I733df8f8bfaf448a6507c9c9d75d2f076fedb342 Gerrit-Change-Number: 14734 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:06:06 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:06:06 +0000 Subject: Change in ...osmo-remsim[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14735 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I619499ce68c8e0ddef597021329d9bfd4d2f1a77 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/35/14735/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 1a14278..249df64 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -39,5 +39,6 @@ $MAKE $PARALLEL_MAKE $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14735 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I619499ce68c8e0ddef597021329d9bfd4d2f1a77 Gerrit-Change-Number: 14735 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:06:10 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:06:10 +0000 Subject: Change in ...osmo-sgsn[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14736 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ic887518bd149f325a92c3517ee90c655b1368fd8 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/36/14736/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index a9d871f..51583f8 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -77,4 +77,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14736 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic887518bd149f325a92c3517ee90c655b1368fd8 Gerrit-Change-Number: 14736 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:06:13 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:06:13 +0000 Subject: Change in ...osmo-sip-connector[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14737 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ie2e181a6e74053c407f7ed3db17631ae041c9754 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/37/14737/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 579a9b1..6d9a9d9 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -52,4 +52,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ie2e181a6e74053c407f7ed3db17631ae041c9754 Gerrit-Change-Number: 14737 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:06:16 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:06:16 +0000 Subject: Change in ...osmo-sysmon[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/14738 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I7b39a97243de93383c77a0e172d737263d48053a --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/38/14738/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 631f95a..ff93c40 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -46,4 +46,5 @@ $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/14738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I7b39a97243de93383c77a0e172d737263d48053a Gerrit-Change-Number: 14738 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:06:19 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:06:19 +0000 Subject: Change in ...osmo-trx[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14739 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I6d541b47e68f5a8a61ac139a3ea85a9cb33856c1 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/39/14739/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index dedec81..1dd8478 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -107,4 +107,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6d541b47e68f5a8a61ac139a3ea85a9cb33856c1 Gerrit-Change-Number: 14739 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 12:06:22 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 10 Jul 2019 12:06:22 +0000 Subject: Change in ...osmocom-bb[master]: contrib/jenkins.sh: run "make maintainer-clean" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14740 Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I11c37f72b6e4294d1dc7b6d1751627ccf4f5c87a --- M contrib/jenkins.sh 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/40/14740/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index dc8cda6..52c6566 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -61,4 +61,10 @@ fi fi +# Test 'maintainer-clean' +for dir in gprsdecode layer23 gsmmap osmocon trxcon virt_phy; do + cd "$base/src/host/$dir" + make maintainer-clean +done + osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I11c37f72b6e4294d1dc7b6d1751627ccf4f5c87a Gerrit-Change-Number: 14740 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 13:25:19 2019 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Wed, 10 Jul 2019 13:25:19 +0000 Subject: Change in ...osmo-e1d[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/14726 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/14726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: If69a9bddefd74fbdd8003d9efbb4f7756f407037 Gerrit-Change-Number: 14726 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: tnt Gerrit-Comment-Date: Wed, 10 Jul 2019 13:25:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 13:25:37 2019 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Wed, 10 Jul 2019 13:25:37 +0000 Subject: Change in ...osmo-e1d[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/14726 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/14726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: If69a9bddefd74fbdd8003d9efbb4f7756f407037 Gerrit-Change-Number: 14726 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: tnt Gerrit-Comment-Date: Wed, 10 Jul 2019 13:25:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 13:25:44 2019 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Wed, 10 Jul 2019 13:25:44 +0000 Subject: Change in ...osmo-e1d[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: tnt has removed a vote on this change. Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/14726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: If69a9bddefd74fbdd8003d9efbb4f7756f407037 Gerrit-Change-Number: 14726 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: tnt Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 13:26:02 2019 From: gerrit-no-reply at lists.osmocom.org (tnt) Date: Wed, 10 Jul 2019 13:26:02 +0000 Subject: Change in ...osmo-e1d[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: tnt has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-e1d/+/14726 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: If69a9bddefd74fbdd8003d9efbb4f7756f407037 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: tnt: Looks good to me, approved; Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 255ad71..a6ca30e 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -44,5 +44,6 @@ $MAKE $PARALLEL_MAKE $MAKE check || cat-testlogs.sh DISTCHECK_CONFIGURE_FLAGS="$CONFIG" $MAKE distcheck || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/14726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: If69a9bddefd74fbdd8003d9efbb4f7756f407037 Gerrit-Change-Number: 14726 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: tnt Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 13:39:17 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Wed, 10 Jul 2019 13:39:17 +0000 Subject: Change in ...osmo-msc[master]: add semi-color after OSMO_ASSERT In-Reply-To: References: Message-ID: lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14711 ) Change subject: add semi-color after OSMO_ASSERT ...................................................................... Abandoned in favour of https://gerrit.osmocom.org/c/osmo-msc/+/14702 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I42fca73393d14ebed973616b86fb87f89bdbf095 Gerrit-Change-Number: 14711 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 13:54:52 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Wed, 10 Jul 2019 13:54:52 +0000 Subject: Change in ...osmo-msc[master]: Fix: add missing semicolons to OSMO_ASSERT statements In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14702 ) Change subject: Fix: add missing semicolons to OSMO_ASSERT statements ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4fae5fbab5fdbcce35906601d4f1031d971f4931 Gerrit-Change-Number: 14702 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 10 Jul 2019 13:54:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 13:59:46 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Wed, 10 Jul 2019 13:59:46 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: use uint16_t when interacting with the window object In-Reply-To: References: Message-ID: Hello Vadim Yanitskiy, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/14571 to look at the new patch set (#3). Change subject: Encoding: use uint16_t when interacting with the window object ...................................................................... Encoding: use uint16_t when interacting with the window object The ESN, SSN and uncompress bitmap len are uint16_t. The Window is using uint16_t in function arguments and return values. Don't do so many integer conversions. Change-Id: If62fa09d7bfa8e91ce707824f7019edb1b83da9e --- M src/encoding.cpp 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/71/14571/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If62fa09d7bfa8e91ce707824f7019edb1b83da9e Gerrit-Change-Number: 14571 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 14:06:36 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 14:06:36 +0000 Subject: Change in ...osmo-msc[master]: Fix: add missing semicolons to OSMO_ASSERT statements In-Reply-To: References: Message-ID: Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14702 ) Change subject: Fix: add missing semicolons to OSMO_ASSERT statements ...................................................................... Fix: add missing semicolons to OSMO_ASSERT statements Change-Id: I4fae5fbab5fdbcce35906601d4f1031d971f4931 --- M src/libmsc/ran_peer.c M tests/msc_vlr/msc_vlr_tests.c 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/ran_peer.c b/src/libmsc/ran_peer.c index ce26794..77740a0 100644 --- a/src/libmsc/ran_peer.c +++ b/src/libmsc/ran_peer.c @@ -370,7 +370,7 @@ case RAN_PEER_EV_MSG_UP_CO_INITIAL: ctx = data; - OSMO_ASSERT(ctx) + OSMO_ASSERT(ctx); OSMO_ASSERT(!ctx->conn); OSMO_ASSERT(ctx->msg); diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c index 488cd19..35401ba 100644 --- a/tests/msc_vlr/msc_vlr_tests.c +++ b/tests/msc_vlr/msc_vlr_tests.c @@ -171,7 +171,7 @@ count = osmo_use_count_by(&msc_a->use_count, cm_service_use); OSMO_ASSERT(count > 0); - OSMO_ASSERT(osmo_use_count_get_put(&msc_a->use_count, cm_service_use, -count) == 0) + OSMO_ASSERT(osmo_use_count_get_put(&msc_a->use_count, cm_service_use, -count) == 0); ASSERT_RELEASE_CLEAR(msc_a->c.ran->type); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14702 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4fae5fbab5fdbcce35906601d4f1031d971f4931 Gerrit-Change-Number: 14702 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 14:06:36 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 14:06:36 +0000 Subject: Change in ...osmo-msc[master]: libmsc/msc_vty.c: print subscriber expiration time In-Reply-To: References: Message-ID: Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14701 ) Change subject: libmsc/msc_vty.c: print subscriber expiration time ...................................................................... libmsc/msc_vty.c: print subscriber expiration time Change-Id: I092691a8c443f4c5ed4d33de2e551fef592c1baf --- M src/libmsc/msc_vty.c 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index 8a976cb..c75cd0e 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -791,6 +791,8 @@ static void vty_dump_one_subscr(struct vty *vty, struct vlr_subscr *vsub, int offset, uint8_t dump_flags) { + struct gsm_network *net; + struct timespec now; char buf[128]; if (vsub->name[0] != '\0') { @@ -863,6 +865,21 @@ VTY_NEWLINE); } + /* XXX move t3212 into struct vlr_instance? */ + net = vsub->vlr->user_ctx; + if (!net->t3212) { + MSC_VTY_DUMP(vty, offset, "Expires: never (T3212 is disabled)%s", + VTY_NEWLINE); + } else if (vsub->expire_lu == VLR_SUBSCRIBER_NO_EXPIRATION) { + MSC_VTY_DUMP(vty, offset, "Expires: never%s", + VTY_NEWLINE); + } else if (osmo_clock_gettime(CLOCK_MONOTONIC, &now) == 0) { + MSC_VTY_DUMP(vty, offset, "Expires: in %ld min %ld sec%s", + (vsub->expire_lu - now.tv_sec) / 60, + (vsub->expire_lu - now.tv_sec) % 60, + VTY_NEWLINE); + } + MSC_VTY_DUMP(vty, offset, "Paging: %s paging for %d requests%s", vsub->cs.is_paging ? "is" : "not", llist_count(&vsub->cs.requests), -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14701 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I092691a8c443f4c5ed4d33de2e551fef592c1baf Gerrit-Change-Number: 14701 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 14:07:39 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 14:07:39 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: use uint16_t when interacting with the window object In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14571 ) Change subject: Encoding: use uint16_t when interacting with the window object ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If62fa09d7bfa8e91ce707824f7019edb1b83da9e Gerrit-Change-Number: 14571 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 10 Jul 2019 14:07:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 14:27:57 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Wed, 10 Jul 2019 14:27:57 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: ACK/NACK: always encode with length field present In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/14697 to look at the new patch set (#2). Change subject: Encoding: ACK/NACK: always encode with length field present ...................................................................... Encoding: ACK/NACK: always encode with length field present In most cases the length field was present and this field takes 7 bits of the maximum available 110 rest bits. The length field was only removed when encoding huge bitmaps usually only happen on lossy connections with packet lost. However the cases without length field were encoded incorrect, because all remaining bits must be used by the uncompressed bitmaps, but the PCU violates this by encoding always the "release 5" bit. Rather than fixing the encoding without length field, simply remove it and always encode with length field. This also reduces the code complexity. Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb --- M src/encoding.cpp 1 file changed, 39 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/97/14697/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb Gerrit-Change-Number: 14697 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 15:48:33 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 15:48:33 +0000 Subject: Change in ...libosmocore[master]: libosmogsm/l1sap.h: extend ph_rach_ind_param with lqual_cb In-Reply-To: References: Message-ID: Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14683 ) Change subject: libosmogsm/l1sap.h: extend ph_rach_ind_param with lqual_cb ...................................................................... libosmogsm/l1sap.h: extend ph_rach_ind_param with lqual_cb The link quality, defined by C/I (Carrier-to-Interference) ratio, can be computed from the training sequence of each burst, where we can compare the "ideal" training sequence with the actual training sequence and then express that in cB (centiBels, dB * 10). By analogy with both RSSI and ToA, it can be used to filter out false-positive detections and ghost Access Bursts. Change-Id: Ie2a66ebd040b61d6daf49e04bf8a84d3d64764ee --- M include/osmocom/gsm/l1sap.h 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/gsm/l1sap.h b/include/osmocom/gsm/l1sap.h index 9a9c008..19cc87a 100644 --- a/include/osmocom/gsm/l1sap.h +++ b/include/osmocom/gsm/l1sap.h @@ -68,6 +68,7 @@ int8_t rssi; /*!< RSSI of RACH indication */ uint16_t ber10k; /*!< BER in units of 0.01% */ int16_t acc_delay_256bits;/* !< Burst TA Offset in 1/256th bits */ + int16_t lqual_cb; /* !< Link quality in centiBel */ }; /*! for PH-[UNIT]DATA.{req,ind} | PH-RTS.ind */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie2a66ebd040b61d6daf49e04bf8a84d3d64764ee Gerrit-Change-Number: 14683 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 15:59:22 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 15:59:22 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14684 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14684/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14684/1/src/osmo-bts-trx/scheduler_trx.c at 796 PS1, Line 796: /* Handover RACH cannot be extended (11-bit) */ > It's not clear how does this comment relates to the "if()" below. [?] Sure, but in a separate change. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1e654a2e49cb83c5f1e6249c0de688f99bc466b0 Gerrit-Change-Number: 14684 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Jul 2019 15:59:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ipse Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 16:15:21 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 10 Jul 2019 16:15:21 +0000 Subject: Change in ...osmo-hlr[master]: add keepalive for gsup client/server, osmo-hlr Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14741 Change subject: add keepalive for gsup client/server, osmo-hlr ...................................................................... add keepalive for gsup client/server, osmo-hlr Change-Id: I01654d4a023e76a2b9245817a0096148c8bd44c1 Depends: (libosmo-abis) Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b --- M doc/manuals/vty/hlr_vty_reference.xml M include/osmocom/gsupclient/gsup_client.h M src/gsup_server.c M src/gsup_server.h M src/gsupclient/gsup_client.c M src/gsupclient/gsup_test_client.c M src/hlr.c M src/hlr.h M src/hlr_vty.c M src/osmo-euse-demo.c 10 files changed, 109 insertions(+), 60 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/41/14741/1 diff --git a/doc/manuals/vty/hlr_vty_reference.xml b/doc/manuals/vty/hlr_vty_reference.xml index e5fd0f2..b1ce7d9 100644 --- a/doc/manuals/vty/hlr_vty_reference.xml +++ b/doc/manuals/vty/hlr_vty_reference.xml @@ -1408,6 +1408,13 @@ + + + + + + + config-hlr-euse diff --git a/include/osmocom/gsupclient/gsup_client.h b/include/osmocom/gsupclient/gsup_client.h index 154e3e0..a05511f 100644 --- a/include/osmocom/gsupclient/gsup_client.h +++ b/include/osmocom/gsupclient/gsup_client.h @@ -35,6 +35,7 @@ struct msgb; struct ipa_client_conn; struct osmo_gsup_client; +struct ipa_keepalive_params; /* Expects message in msg->l2h */ typedef int (*osmo_gsup_client_read_cb_t)(struct osmo_gsup_client *gsupc, struct msgb *msg); @@ -48,12 +49,11 @@ struct osmo_oap_client_state oap_state; - struct osmo_timer_list ping_timer; struct osmo_timer_list connect_timer; int is_connected; - int got_ipa_pong; struct ipaccess_unit *ipa_dev; /* identification information sent to IPA server */ + struct osmo_fsm_inst* ka_fsm; }; struct osmo_gsup_client *osmo_gsup_client_create2(void *talloc_ctx, @@ -61,13 +61,15 @@ const char *ip_addr, unsigned int tcp_port, osmo_gsup_client_read_cb_t read_cb, - struct osmo_oap_client_config *oapc_config); + struct osmo_oap_client_config *oapc_config, + struct ipa_keepalive_params * params); struct osmo_gsup_client *osmo_gsup_client_create(void *talloc_ctx, const char *unit_name, const char *ip_addr, unsigned int tcp_port, osmo_gsup_client_read_cb_t read_cb, - struct osmo_oap_client_config *oapc_config); + struct osmo_oap_client_config *oapc_config, + struct ipa_keepalive_params * params); void osmo_gsup_client_destroy(struct osmo_gsup_client *gsupc); int osmo_gsup_client_send(struct osmo_gsup_client *gsupc, struct msgb *msg); diff --git a/src/gsup_server.c b/src/gsup_server.c index e75bbd7..5a4031c 100644 --- a/src/gsup_server.c +++ b/src/gsup_server.c @@ -30,6 +30,8 @@ #include "gsup_server.h" #include "gsup_router.h" +static int osmo_gsup_server_closed_cb(struct ipa_server_conn *conn); + static void osmo_gsup_server_send(struct osmo_gsup_conn *conn, int proto_ext, struct msgb *msg_tx) { @@ -79,11 +81,17 @@ msg->l2h = &hh->data[0]; if (hh->proto == IPAC_PROTO_IPACCESS) { + uint8_t msg_type = *(msg->l2h); rc = ipa_server_conn_ccm(conn, msg); if (rc < 0) { /* conn is already invalid here! */ return -1; } + + /* peek the pong for out keepalive fsm */ + if(clnt->ka_fsm && msg_type == IPAC_MSGT_PONG) + ipa_keepalive_fsm_pong_received(clnt->ka_fsm); + msgb_free(msg); return 0; } @@ -171,6 +179,12 @@ return TLVP_LEN(&clnt->ccm, tag); } +static int osmo_gsup_server_ka_timeout_cb(struct osmo_fsm_inst *fi, void *conn){ + ipa_server_conn_destroy(conn); + /* we're dead, our talloc context was conn, which was freed */ + return 0; +} + static int osmo_gsup_server_ccm_cb(struct ipa_server_conn *conn, struct msgb *msg, struct tlv_parsed *tlvp, struct ipaccess_unit *unit) @@ -196,6 +210,18 @@ } gsup_route_add(clnt, addr, addr_len); + + if(clnt->ka_fsm) + osmo_fsm_inst_free(clnt->ka_fsm); + + if(clnt->server->ka_params){ + clnt->ka_fsm = ipa_server_conn_alloc_keepalive_fsm(conn, clnt->server->ka_params, "gsup_server"); + if(clnt->ka_fsm){ + ipa_keepalive_fsm_set_timeout_cb(clnt->ka_fsm, osmo_gsup_server_ka_timeout_cb); + ipa_keepalive_fsm_start(clnt->ka_fsm); + } + } + return 0; } @@ -206,6 +232,11 @@ LOGP(DLGSUP, LOGL_INFO, "Lost GSUP client %s:%d\n", conn->addr, conn->port); + if(clnt->ka_fsm){ + osmo_fsm_inst_free(clnt->ka_fsm); + clnt->ka_fsm = NULL; + } + gsup_route_del_conn(clnt); llist_del(&clnt->list); talloc_free(clnt); @@ -292,7 +323,7 @@ struct osmo_gsup_server * osmo_gsup_server_create(void *ctx, const char *ip_addr, uint16_t tcp_port, osmo_gsup_read_cb_t read_cb, - struct llist_head *lu_op_lst, void *priv) + struct llist_head *lu_op_lst, struct ipa_keepalive_params * params, void *priv) { struct osmo_gsup_server *gsups; int rc; @@ -313,6 +344,7 @@ gsups->read_cb = read_cb; gsups->priv = priv; + gsups->ka_params = params; rc = ipa_server_link_open(gsups->link); if (rc < 0) diff --git a/src/gsup_server.h b/src/gsup_server.h index 9c4d483..406ecf8 100644 --- a/src/gsup_server.h +++ b/src/gsup_server.h @@ -28,6 +28,7 @@ struct ipa_server_link *link; osmo_gsup_read_cb_t read_cb; struct llist_head routes; + struct ipa_keepalive_params* ka_params; }; @@ -45,6 +46,7 @@ /* Set when Location Update is received: */ bool supports_cs; /* client supports OSMO_GSUP_CN_DOMAIN_CS */ bool supports_ps; /* client supports OSMO_GSUP_CN_DOMAIN_PS */ + struct osmo_fsm_inst* ka_fsm; }; @@ -57,6 +59,7 @@ uint16_t tcp_port, osmo_gsup_read_cb_t read_cb, struct llist_head *lu_op_lst, + struct ipa_keepalive_params * params, void *priv); void osmo_gsup_server_destroy(struct osmo_gsup_server *gsups); diff --git a/src/gsupclient/gsup_client.c b/src/gsupclient/gsup_client.c index c8408fd..5fe9740 100644 --- a/src/gsupclient/gsup_client.c +++ b/src/gsupclient/gsup_client.c @@ -32,18 +32,6 @@ #include #include -static void start_test_procedure(struct osmo_gsup_client *gsupc); - -static void gsup_client_send_ping(struct osmo_gsup_client *gsupc) -{ - struct msgb *msg = osmo_gsup_client_msgb_alloc(); - - msg->l2h = msgb_put(msg, 1); - msg->l2h[0] = IPAC_MSGT_PING; - ipa_msg_push_header(msg, IPAC_PROTO_IPACCESS); - ipa_client_conn_send(gsupc->link, msg); -} - static int gsup_client_connect(struct osmo_gsup_client *gsupc) { int rc; @@ -57,12 +45,6 @@ osmo_timer_del(&gsupc->connect_timer); } - if (osmo_timer_pending(&gsupc->ping_timer)) { - LOGP(DLGSUP, LOGL_DEBUG, - "GSUP connect: ping timer already running\n"); - osmo_timer_del(&gsupc->ping_timer); - } - if (ipa_client_conn_clear_queue(gsupc->link) > 0) LOGP(DLGSUP, LOGL_DEBUG, "GSUP connect: discarded stored messages\n"); @@ -71,6 +53,10 @@ if (rc >= 0) { LOGP(DLGSUP, LOGL_NOTICE, "GSUP connecting to %s:%d\n", gsupc->link->addr, gsupc->link->port); + + if(gsupc->ka_fsm) + ipa_keepalive_fsm_start(gsupc->ka_fsm); + return 0; } @@ -133,14 +119,16 @@ gsupc->is_connected = up; if (up) { - start_test_procedure(gsupc); + if(gsupc->ka_fsm) + ipa_keepalive_fsm_start(gsupc->ka_fsm); if (gsupc->oap_state.state == OSMO_OAP_INITIALIZED) gsup_client_oap_register(gsupc); osmo_timer_del(&gsupc->connect_timer); } else { - osmo_timer_del(&gsupc->ping_timer); + if(gsupc->ka_fsm) + ipa_keepalive_fsm_stop(gsupc->ka_fsm); osmo_timer_schedule(&gsupc->connect_timer, OSMO_GSUP_CLIENT_RECONNECT_INTERVAL, 0); @@ -189,11 +177,10 @@ if (rc == 1) { uint8_t msg_type = *(msg->l2h); - /* CCM message */ - if (msg_type == IPAC_MSGT_PONG) { - LOGP(DLGSUP, LOGL_DEBUG, "GSUP receiving PONG\n"); - gsupc->got_ipa_pong = 1; - } + + /* peek the pong for out keepalive fsm */ + if(gsupc->ka_fsm && msg_type == IPAC_MSGT_PONG) + ipa_keepalive_fsm_pong_received(gsupc->ka_fsm); msgb_free(msg); return 0; @@ -228,34 +215,20 @@ return -1; } -static void ping_timer_cb(void *gsupc_) -{ - struct osmo_gsup_client *gsupc = gsupc_; +static int osmo_gsup_client_ka_timeout_cb(struct osmo_fsm_inst *fi, void *data){ + struct ipa_client_conn* cc = (struct ipa_client_conn*) data; + struct osmo_gsup_client* gsupc = (struct osmo_gsup_client *)cc->data; - LOGP(DLGSUP, LOGL_INFO, "GSUP ping callback (%s, %s PONG)\n", - gsupc->is_connected ? "connected" : "not connected", - gsupc->got_ipa_pong ? "got" : "didn't get"); + ipa_keepalive_fsm_stop(gsupc->ka_fsm); - if (gsupc->got_ipa_pong) { - start_test_procedure(gsupc); - return; - } - - LOGP(DLGSUP, LOGL_NOTICE, "GSUP ping timed out, reconnecting\n"); ipa_client_conn_close(gsupc->link); gsupc->is_connected = 0; - gsup_client_connect(gsupc); -} + osmo_timer_schedule(&gsupc->connect_timer, + OSMO_GSUP_CLIENT_RECONNECT_INTERVAL, 0); -static void start_test_procedure(struct osmo_gsup_client *gsupc) -{ - osmo_timer_setup(&gsupc->ping_timer, ping_timer_cb, gsupc); - - gsupc->got_ipa_pong = 0; - osmo_timer_schedule(&gsupc->ping_timer, OSMO_GSUP_CLIENT_PING_INTERVAL, 0); - LOGP(DLGSUP, LOGL_DEBUG, "GSUP sending PING\n"); - gsup_client_send_ping(gsupc); + /* do not terminate */ + return 0; } /*! @@ -276,7 +249,8 @@ const char *ip_addr, unsigned int tcp_port, osmo_gsup_client_read_cb_t read_cb, - struct osmo_oap_client_config *oapc_config) + struct osmo_oap_client_config *oapc_config, + struct ipa_keepalive_params * params) { struct osmo_gsup_client *gsupc; int rc; @@ -302,6 +276,12 @@ if (!gsupc->link) goto failed; + if(params){ + gsupc->ka_fsm = ipa_client_conn_alloc_keepalive_fsm(gsupc->link, params, "gsup_client"); + if(gsupc->ka_fsm) + ipa_keepalive_fsm_set_timeout_cb(gsupc->ka_fsm, osmo_gsup_client_ka_timeout_cb); + } + osmo_timer_setup(&gsupc->connect_timer, connect_timer_cb, gsupc); rc = gsup_client_connect(gsupc); @@ -327,17 +307,17 @@ const char *ip_addr, unsigned int tcp_port, osmo_gsup_client_read_cb_t read_cb, - struct osmo_oap_client_config *oapc_config) + struct osmo_oap_client_config *oapc_config, + struct ipa_keepalive_params * params) { struct ipaccess_unit *ipa_dev = talloc_zero(talloc_ctx, struct ipaccess_unit); ipa_dev->unit_name = talloc_strdup(ipa_dev, unit_name); - return osmo_gsup_client_create2(talloc_ctx, ipa_dev, ip_addr, tcp_port, read_cb, oapc_config); + return osmo_gsup_client_create2(talloc_ctx, ipa_dev, ip_addr, tcp_port, read_cb, oapc_config, params); } void osmo_gsup_client_destroy(struct osmo_gsup_client *gsupc) { osmo_timer_del(&gsupc->connect_timer); - osmo_timer_del(&gsupc->ping_timer); if (gsupc->link) { ipa_client_conn_close(gsupc->link); diff --git a/src/gsupclient/gsup_test_client.c b/src/gsupclient/gsup_test_client.c index b0362ad..cb293c9 100644 --- a/src/gsupclient/gsup_test_client.c +++ b/src/gsupclient/gsup_test_client.c @@ -10,6 +10,7 @@ #include #include #include +#include #include @@ -289,12 +290,12 @@ unsigned long long i; char *server_host = "127.0.0.1"; uint16_t server_port = OSMO_GSUP_PORT; + struct ipa_keepalive_params kap = {.interval = 10, .wait_for_resp = 5}; void *ctx = talloc_named_const(NULL, 0, "gsup_test_client"); - osmo_init_logging2(ctx, &gsup_test_client_log_info); g_gc = osmo_gsup_client_create(ctx, "GSUPTEST", server_host, server_port, - gsupc_read_cb, NULL); + gsupc_read_cb, NULL, &kap); signal(SIGINT, sig_cb); diff --git a/src/hlr.c b/src/hlr.c index 90cbac4..5237012 100644 --- a/src/hlr.c +++ b/src/hlr.c @@ -880,7 +880,7 @@ } g_hlr->gs = osmo_gsup_server_create(hlr_ctx, g_hlr->gsup_bind_addr, OSMO_GSUP_PORT, - read_cb, &g_lu_ops, g_hlr); + read_cb, &g_lu_ops, g_hlr->ka_params, g_hlr); if (!g_hlr->gs) { LOGP(DMAIN, LOGL_FATAL, "Error starting GSUP server\n"); exit(1); diff --git a/src/hlr.h b/src/hlr.h index 18c4a1d..97b49bc 100644 --- a/src/hlr.h +++ b/src/hlr.h @@ -61,6 +61,7 @@ /* Bitmask of DB_SUBSCR_FLAG_* */ uint8_t subscr_create_on_demand_flags; unsigned int subscr_create_on_demand_rand_msisdn_len; + struct ipa_keepalive_params* ka_params; }; extern struct hlr *g_hlr; diff --git a/src/hlr_vty.c b/src/hlr_vty.c index e6567cc..c975c7f 100644 --- a/src/hlr_vty.c +++ b/src/hlr_vty.c @@ -102,6 +102,9 @@ vty_out(vty, " gsup%s", VTY_NEWLINE); if (g_hlr->gsup_bind_addr) vty_out(vty, " bind ip %s%s", g_hlr->gsup_bind_addr, VTY_NEWLINE); + if (g_hlr->ka_params) + vty_out(vty, " keepalive %d %d%s", g_hlr->ka_params->interval, + g_hlr->ka_params->wait_for_resp, VTY_NEWLINE); return CMD_SUCCESS; } @@ -146,6 +149,22 @@ return CMD_SUCCESS; } +DEFUN(cfg_hlr_gsup_keepalive, + cfg_hlr_gsup_keepalive_cmd, + "keepalive <0-300> <1-300>", + "Enable keepalive probing\n" + "Idle interval in seconds before probes are sent, 0 disables keepalive\n" + "Timeout waiting for PONG response\n") +{ + if(atoi(argv[0]) > 0){ + g_hlr->ka_params = talloc_zero(g_hlr, struct ipa_keepalive_params); + g_hlr->ka_params->interval = atoi(argv[0]); + g_hlr->ka_params->wait_for_resp = atoi(argv[1]); + } + + return CMD_SUCCESS; +} + /*********************************************************************** * USSD Entity ***********************************************************************/ @@ -444,6 +463,7 @@ install_node(&gsup_node, config_write_hlr_gsup); install_element(GSUP_NODE, &cfg_hlr_gsup_bind_ip_cmd); + install_element(GSUP_NODE, &cfg_hlr_gsup_keepalive_cmd); install_element(HLR_NODE, &cfg_database_cmd); diff --git a/src/osmo-euse-demo.c b/src/osmo-euse-demo.c index 4e4ef78..5cb5c40 100644 --- a/src/osmo-euse-demo.c +++ b/src/osmo-euse-demo.c @@ -44,6 +44,8 @@ #include +#include + #include "logging.h" static struct osmo_gsup_client *g_gc; @@ -212,6 +214,7 @@ { char *server_host = "127.0.0.1"; uint16_t server_port = OSMO_GSUP_PORT; + struct ipa_keepalive_params kap = {.interval = 10, .wait_for_resp = 5}; void *ctx = talloc_named_const(NULL, 0, "demo-euse"); osmo_init_logging2(ctx, &gsup_log_info); @@ -228,7 +231,7 @@ if (argc > 2) server_port = atoi(argv[2]); - g_gc = osmo_gsup_client_create(ctx, "EUSE-foobar", server_host, server_port, gsupc_read_cb, NULL); + g_gc = osmo_gsup_client_create(ctx, "EUSE-foobar", server_host, server_port, gsupc_read_cb, NULL, &kap); while (1) { osmo_select_main(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14741 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I01654d4a023e76a2b9245817a0096148c8bd44c1 Gerrit-Change-Number: 14741 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 16:20:39 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 10 Jul 2019 16:20:39 +0000 Subject: Change in ...libosmo-abis[master]: extend the ipa keepalive fsm Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14742 Change subject: extend the ipa keepalive fsm ...................................................................... extend the ipa keepalive fsm The new and improved fsm supports multipe use cases: 1) plain old ipa server/client operation 2) ipa client/server operation with custom send callback (i.e. to bypass the tx queue) 3) all of the above + custom timeout callback 4) fully generic operation that will pass opaque data to the callbacks The current code will always kill the fsm and deallocate it upon timeout, so the timeout callback will now return a value: 1 means the fsm will be automatically terminated, 0 means no action, which allows manually stopping/starting the fsm to reuse it. Change-Id: Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b --- M include/osmocom/abis/ipa.h M src/input/ipa_keepalive.c 2 files changed, 58 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/42/14742/1 diff --git a/include/osmocom/abis/ipa.h b/include/osmocom/abis/ipa.h index 4f6081f..71441aa 100644 --- a/include/osmocom/abis/ipa.h +++ b/include/osmocom/abis/ipa.h @@ -113,7 +113,9 @@ unsigned int wait_for_resp; }; -typedef void ipa_keepalive_timeout_cb_t(struct osmo_fsm_inst *fi, void *conn); +typedef int ipa_keepalive_timeout_cb_t(struct osmo_fsm_inst *fi, void *conn); + +typedef void ipa_keepalive_send_cb_t(struct osmo_fsm_inst *fi, void *conn, struct msgb *msg); struct osmo_fsm_inst *ipa_client_conn_alloc_keepalive_fsm(struct ipa_client_conn *client, const struct ipa_keepalive_params *params, @@ -123,12 +125,14 @@ const struct ipa_keepalive_params *params, const char *id); -struct osmo_fsm_inst *ipa_keepalive_alloc_server(struct ipa_server_conn *server, - const struct ipa_keepalive_params *params, - const char *id); +struct osmo_fsm_inst *ipa_generic_conn_alloc_keepalive_fsm(void *ctx, void* data, + const struct ipa_keepalive_params *params, + const char *id); void ipa_keepalive_fsm_set_timeout_cb(struct osmo_fsm_inst *fi, ipa_keepalive_timeout_cb_t *cb); +void ipa_keepalive_fsm_set_send_cb(struct osmo_fsm_inst *fi, ipa_keepalive_send_cb_t *fn); + void ipa_keepalive_fsm_start(struct osmo_fsm_inst *fi); void ipa_keepalive_fsm_stop(struct osmo_fsm_inst *fi); diff --git a/src/input/ipa_keepalive.c b/src/input/ipa_keepalive.c index 81b5a26..7207be5 100644 --- a/src/input/ipa_keepalive.c +++ b/src/input/ipa_keepalive.c @@ -76,7 +76,9 @@ struct ipa_server_conn *srv_conn; struct ipa_client_conn *client_conn; + void* generic; ipa_keepalive_timeout_cb_t *timeout_cb; + ipa_keepalive_send_cb_t *send_fn; }; static void ipa_ka_init(struct osmo_fsm_inst *fi, uint32_t event, void *data) @@ -103,11 +105,23 @@ msg = gen_ipa_ping(); OSMO_ASSERT(msg); - if (ifp->srv_conn) - ipa_server_conn_send(ifp->srv_conn, msg); + if(ifp->send_fn && ifp->generic){ + ifp->send_fn(fi, ifp->generic, msg); + return; + } + + if (ifp->srv_conn){ + if(ifp->send_fn) + ifp->send_fn(fi, ifp->srv_conn, msg); + else + ipa_server_conn_send(ifp->srv_conn, msg); + } else { OSMO_ASSERT(ifp->client_conn); - ipa_client_conn_send(ifp->client_conn, msg); + if(ifp->send_fn) + ifp->send_fn(fi, ifp->client_conn, msg); + else + ipa_client_conn_send(ifp->client_conn, msg); } } @@ -140,10 +154,12 @@ /* PONG not received within time */ if (ifp->srv_conn) conn = ifp->srv_conn; - else + else if (ifp->client_conn) conn = ifp->client_conn; + else + conn = ifp->generic; if (ifp->timeout_cb) - ifp->timeout_cb(fi, conn); + return ifp->timeout_cb(fi, conn); /* ask fsm core to terminate us */ return 1; default: @@ -261,6 +277,27 @@ return fi; } +/*! Create a new instance of an IPA keepalive FSM: Periodically transmit PING and expect PONG. + * \param[in] ctx Talloc context. + * \param[in] data Data to pass to write/timeout cb. + * \param[in] params Parameters describing the keepalive FSM time-outs. + * \param[in] id String used as identifier for the FSM. + * \returns pointer to the newly-created FSM instance; NULL in case of error. */ +struct osmo_fsm_inst *ipa_generic_conn_alloc_keepalive_fsm(void *ctx, void* data, + const struct ipa_keepalive_params *params, + const char *id) +{ + struct osmo_fsm_inst *fi; + struct ipa_fsm_priv *ifp; + + fi = __ipa_conn_alloc_keepalive_fsm(ctx, params, id); + if (!fi) + return NULL; + ifp = fi->priv; + ifp->generic = data; + return fi; +} + /*! Set a timeout call-back which is to be called once the peer doesn't respond anymore */ void ipa_keepalive_fsm_set_timeout_cb(struct osmo_fsm_inst *fi, ipa_keepalive_timeout_cb_t *cb) { @@ -269,6 +306,14 @@ ifp->timeout_cb = cb; } +/*! Set a custom send callback for sending pings */ +void ipa_keepalive_fsm_set_send_cb(struct osmo_fsm_inst *fi, ipa_keepalive_send_cb_t *fn) +{ + struct ipa_fsm_priv *ifp = fi->priv; + OSMO_ASSERT(fi->fsm == &ipa_keepalive_fsm); + ifp->send_fn = fn; +} + /*! Inform IPA Keepalive FSM that a PONG has been received. */ void ipa_keepalive_fsm_pong_received(struct osmo_fsm_inst *fi) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14742 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b Gerrit-Change-Number: 14742 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 16:20:40 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Wed, 10 Jul 2019 16:20:40 +0000 Subject: Change in ...libosmo-abis[master]: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14743 Change subject: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc ...................................................................... add ipa pingp/pong keepalive for OML/RSL links between bts and bsc Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a --- M include/osmocom/abis/e1_input.h M src/e1_input_vty.c M src/input/ipaccess.c 3 files changed, 186 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/43/14743/1 diff --git a/include/osmocom/abis/e1_input.h b/include/osmocom/abis/e1_input.h index e6d5154..4459392 100644 --- a/include/osmocom/abis/e1_input.h +++ b/include/osmocom/abis/e1_input.h @@ -187,11 +187,14 @@ char *sock_path; struct rate_ctr_group *rate_ctr; - /* keepalive configuration */ + /* tcp keepalive configuration */ int keepalive_num_probes; /* 0: disable, num, or E1INP_USE_DEFAULT */ int keepalive_idle_timeout; /* secs, or E1INP_USE_DEFAULT */ int keepalive_probe_interval; /* secs or E1INP_USE_DEFAULT */ + /* ipa ping/pong keepalive params */ + struct ipa_keepalive_params* ipa_kap; + /* array of timestlots */ struct e1inp_ts ts[NUM_E1_TS]; unsigned int num_ts; diff --git a/src/e1_input_vty.c b/src/e1_input_vty.c index d81c859..3c6a268 100644 --- a/src/e1_input_vty.c +++ b/src/e1_input_vty.c @@ -38,6 +38,7 @@ #include #include +#include /* CONFIG */ @@ -169,6 +170,40 @@ return set_keepalive_params(vty, atoi(argv[0]), 0, 0, 0); } +DEFUN(cfg_e1line_ipakeepalive, cfg_e1_line_ipakeepalive_cmd, + "e1_line <0-255> ipakeepalive <0-300> <1-300>", + E1_LINE_HELP "Enable IPA PING/PONG keepalive\n" + "Idle interval in seconds before probes are sent, 0 disables keepalive\n" + "Time to wait for PONG response\n") +{ + int e1_nr = atoi(argv[0]); + int interval = atoi(argv[1]); + int waittime = atoi(argv[2]); + struct e1inp_line *line = e1inp_line_find(e1_nr); + + if (!line) { + vty_out(vty, "%% Line %d doesn't exist%s", e1_nr, VTY_NEWLINE); + return CMD_WARNING; + } + if(strcmp(line->driver->name, "ipa") != 0){ + vty_out(vty, "%% Line %d doesn't use the ipa driver%s", e1_nr, VTY_NEWLINE); + return CMD_WARNING; + } + + if (!line->driver->has_keepalive) { + vty_out(vty, "%% Driver '%s' does not support keep alive%s", + line->driver->name, VTY_NEWLINE); + return CMD_WARNING; + } + + if(interval){ + line->ipa_kap = talloc_zero(line, struct ipa_keepalive_params); + line->ipa_kap->wait_for_resp = waittime; + line->ipa_kap->interval = interval; + } + return CMD_SUCCESS; +} + DEFUN(cfg_e1line_name, cfg_e1_line_name_cmd, "e1_line <0-255> name .LINE", E1_LINE_HELP "Set name for this line\n" "Human readable name\n") @@ -242,7 +277,10 @@ line->keepalive_num_probes, line->keepalive_probe_interval, VTY_NEWLINE); - + if (line->ipa_kap) + vty_out(vty, " e1_line %u ipakeepalive %d %d%s", line->num, + line->ipa_kap->interval, line->ipa_kap->wait_for_resp, + VTY_NEWLINE); } const char *ipa_bind = e1inp_ipa_get_bind_addr(); @@ -398,6 +436,7 @@ install_element(L_E1INP_NODE, &cfg_e1_line_keepalive_cmd); install_element(L_E1INP_NODE, &cfg_e1_line_keepalive_params_cmd); install_element(L_E1INP_NODE, &cfg_e1_line_no_keepalive_cmd); + install_element(L_E1INP_NODE, &cfg_e1_line_ipakeepalive_cmd); install_element(L_E1INP_NODE, &cfg_ipa_bind_cmd); diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index fb6ad10..b2b6a6b 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -59,15 +59,28 @@ #define DEFAULT_TCP_KEEPALIVE_INTERVAL 3 #define DEFAULT_TCP_KEEPALIVE_RETRY_COUNT 10 +#define ka_fsm_for_ts(ipaline,ofd) (ipaline->ka_fsm[ofd->priv_nr-1]) + +struct ipaccess_line { + int line_already_initialized; + struct osmo_fsm_inst* ka_fsm[NUM_E1_TS]; +}; + static int ipaccess_drop(struct osmo_fd *bfd, struct e1inp_line *line) { int ret = 1; struct e1inp_ts *e1i_ts; + struct ipaccess_line *il = line->driver_data; + struct osmo_fsm_inst* f = ka_fsm_for_ts(il, bfd); + if (bfd->priv_nr == E1INP_SIGN_OML) e1i_ts = e1inp_line_ipa_oml_ts(line); else e1i_ts = e1inp_line_ipa_rsl_ts(line, bfd->priv_nr - E1INP_SIGN_RSL); + if(f) + ipa_keepalive_fsm_stop(f); + /* Error case: we did not see any ID_RESP yet for this socket. */ if (bfd->fd != -1) { LOGP(DLINP, LOGL_ERROR, "Forcing socket shutdown with " @@ -87,6 +100,29 @@ return ret; } +static void ipa_bsc_keepalive_write_server_cb(struct osmo_fsm_inst *fi, void *conn, struct msgb *msg){ + struct osmo_fd *bfd = (struct osmo_fd *)conn; + int ret = 0; + + ret = send(bfd->fd, msg->data, msg->len, 0); + msgb_free(msg); +} + +static int ipa_bsc_keepalive_timeout_cb(struct osmo_fsm_inst *fi, void *data){ + struct osmo_fd *bfd = (struct osmo_fd *)data; + + if (bfd->fd == -1) + return 1; + + struct e1inp_line *line = (struct e1inp_line *) bfd->data; + struct ipaccess_line *il = line->driver_data; + + ipaccess_drop(bfd, line); + /* fsm will free itself upon returning */ + ka_fsm_for_ts(il, bfd) = NULL; + return 1; +} + /* Returns -1 on error, and 0 or 1 on success. If -1 or 1 is returned, line has * been released and should not be used anymore by the caller. */ static int ipaccess_rcvmsg(struct e1inp_line *line, struct msgb *msg, @@ -98,6 +134,11 @@ struct e1inp_sign_link *sign_link; char *unitid; int len, ret; + struct ipaccess_line *il = line->driver_data; + + /* peek the pong for our keepalive fsm */ + if(ka_fsm_for_ts(il,bfd) && msg_type == IPAC_MSGT_PONG) + ipa_keepalive_fsm_pong_received(ka_fsm_for_ts(il,bfd)); /* Handle IPA PING, PONG and ID_ACK messages. */ ret = ipa_ccm_rcvmsg_base(msg, bfd); @@ -152,6 +193,7 @@ } /* the BSC creates the new sign links at this stage. */ if (bfd->priv_nr == E1INP_SIGN_OML) { + struct osmo_fsm_inst** f = &ka_fsm_for_ts(il,bfd); sign_link = line->ops->sign_link_up(&unit_data, line, E1INP_SIGN_OML); @@ -161,10 +203,22 @@ "closing socket.\n"); goto err; } + + if(*f) + osmo_fsm_inst_free(*f); + if(line->ipa_kap){ + *f = ipa_generic_conn_alloc_keepalive_fsm(tall_ipa_ctx, bfd, line->ipa_kap, "oml_bsc_to_bts"); + if(line->ipa_kap && f){ + ipa_keepalive_fsm_set_timeout_cb(*f, ipa_bsc_keepalive_timeout_cb); + ipa_keepalive_fsm_set_send_cb(*f, ipa_bsc_keepalive_write_server_cb); + ipa_keepalive_fsm_start(*f); + } + } } else if (bfd->priv_nr == E1INP_SIGN_RSL) { struct e1inp_ts *ts; - struct osmo_fd *newbfd; + struct osmo_fd *newbfd; struct e1inp_line *new_line; + struct osmo_fsm_inst** f; sign_link = line->ops->sign_link_up(&unit_data, line, @@ -205,6 +259,19 @@ } /* now we can release the dummy RSL line. */ e1inp_line_put(line); + + il = new_line->driver_data; + f = &ka_fsm_for_ts(il,newbfd); + if(*f) + osmo_fsm_inst_free(*f); + if(new_line->ipa_kap) { + *f = ipa_generic_conn_alloc_keepalive_fsm(tall_ipa_ctx, newbfd, new_line->ipa_kap, "rsl_bsc_to_bts"); + if(f){ + ipa_keepalive_fsm_set_timeout_cb(*f, ipa_bsc_keepalive_timeout_cb); + ipa_keepalive_fsm_set_send_cb(*f, ipa_bsc_keepalive_write_server_cb); + ipa_keepalive_fsm_start(*f); + } + } return 1; } break; @@ -231,6 +298,9 @@ struct ipaccess_head *hh; struct msgb *msg = NULL; int ret, rc; + struct ipaccess_line *il = line->driver_data; + struct osmo_fsm_inst** f = &ka_fsm_for_ts(il,bfd); + if (bfd->priv_nr == E1INP_SIGN_OML) e1i_ts = e1inp_line_ipa_oml_ts(line); @@ -291,6 +361,9 @@ err_msg: msgb_free(msg); err: + if(*f) + osmo_fsm_inst_free(*f); + *f = NULL; ipaccess_drop(bfd, line); return -EBADF; } @@ -306,6 +379,14 @@ { struct e1inp_ts *e1i_ts = sign_link->ts; struct osmo_fd *bfd = &e1i_ts->driver.ipaccess.fd; + /* line might not exist if != bsc||bts */ + struct e1inp_line *line = e1i_ts->line; + struct ipaccess_line *il = line ? line->driver_data : 0; + + /* depending on caller the fsm might be dead */ + if(il && ka_fsm_for_ts(il,bfd)) + ipa_keepalive_fsm_stop(ka_fsm_for_ts(il,bfd)); + return e1inp_close_socket(e1i_ts, sign_link, bfd); } @@ -324,6 +405,8 @@ struct e1inp_sign_link *sign_link; struct msgb *msg; int ret; + struct ipaccess_line *il = line->driver_data; + struct osmo_fsm_inst** f = &ka_fsm_for_ts(il,bfd); if (bfd->priv_nr == E1INP_SIGN_OML) e1i_ts = e1inp_line_ipa_oml_ts(line); @@ -372,6 +455,9 @@ msgb_free(msg); return ret; err: + if(*f) + osmo_fsm_inst_free(*f); + *f = NULL; ipaccess_drop(bfd, line); msgb_free(msg); return ret; @@ -677,11 +763,15 @@ static void ipaccess_bts_updown_cb(struct ipa_client_conn *link, int up) { struct e1inp_line *line = link->line; + struct ipaccess_line *il = line->driver_data; + struct osmo_fsm_inst *f = ka_fsm_for_ts(il,link->ofd); - if (up) { - update_fd_settings(line, link->ofd->fd); - return; - } + if (up) { + update_fd_settings(line, link->ofd->fd); + if(f && line->ipa_kap) + ipa_keepalive_fsm_start(f); + return; + } if (line->ops->sign_link_down) line->ops->sign_link_down(line); @@ -695,11 +785,18 @@ struct ipaccess_head *hh = (struct ipaccess_head *) msg->data; struct msgb *rmsg; int ret = 0; + /* line might not exist if != bsc||bts */ + struct e1inp_line *line = link->line; + struct ipaccess_line *il = line ? line->driver_data : 0; /* special handling for IPA CCM. */ if (hh->proto == IPAC_PROTO_IPACCESS) { uint8_t msg_type = *(msg->l2h); + /* peek the pong for our keepalive fsm */ + if(il && ka_fsm_for_ts(il,link->ofd) && msg_type == IPAC_MSGT_PONG) + ipa_keepalive_fsm_pong_received(ka_fsm_for_ts(il,link->ofd)); + /* ping, pong and acknowledgment cases. */ ret = ipa_ccm_rcvmsg_bts_base(msg, link->ofd); if (ret < 0) @@ -823,9 +920,21 @@ return -EBADF; } -struct ipaccess_line { - int line_already_initialized; -}; +static void ipa_bts_keepalive_write_client_cb(struct osmo_fsm_inst *fi, void *conn, struct msgb *msg){ + struct ipa_client_conn *link = (struct ipa_client_conn *)conn; + int ret = 0; + + ret = ipa_send(link->ofd->fd, msg->data, msg->len); + if (ret != msg->len) { + LOGP(DLINP, LOGL_ERROR, "cannot send message. Reason: %s\n", strerror(errno)); + } + msgb_free(msg); +} + +static int ipa_bts_keepalive_timeout_cb(struct osmo_fsm_inst *fi, void *conn){ + ipaccess_bts_updown_cb(conn, false); + return 1; +} static int ipaccess_line_update(struct e1inp_line *line) { @@ -889,6 +998,7 @@ } case E1INP_LINE_R_BTS: { struct ipa_client_conn *link; + struct osmo_fsm_inst** f = &il->ka_fsm[0]; LOGP(DLINP, LOGL_NOTICE, "enabling ipaccess BTS mode, " "OML connecting to %s:%u\n", line->ops->cfg.ipa.addr, @@ -915,6 +1025,17 @@ ipa_client_conn_destroy(link); return -EIO; } + + if(*f) + osmo_fsm_inst_free(*f); + if(line->ipa_kap){ + *f = ipa_client_conn_alloc_keepalive_fsm(link, line->ipa_kap, "oml_bts_to_bsc"); + if(*f){ + ipa_keepalive_fsm_set_timeout_cb(*f, ipa_bts_keepalive_timeout_cb); + ipa_keepalive_fsm_set_send_cb(*f, ipa_bts_keepalive_write_client_cb); + } + } + ret = 0; break; } @@ -924,7 +1045,6 @@ return ret; } - /* backwards compatibility */ int e1inp_ipa_bts_rsl_connect(struct e1inp_line *line, const char *rem_addr, uint16_t rem_port) @@ -937,6 +1057,8 @@ uint8_t trx_nr) { struct ipa_client_conn *rsl_link; + struct ipaccess_line *il = line->driver_data; + struct osmo_fsm_inst** f = &il->ka_fsm[1+trx_nr]; if (E1INP_SIGN_RSL+trx_nr-1 >= NUM_E1_TS) { LOGP(DLINP, LOGL_ERROR, "cannot create RSL BTS link: " @@ -964,6 +1086,17 @@ ipa_client_conn_destroy(rsl_link); return -EIO; } + + if(*f) + osmo_fsm_inst_free(*f); + if(line->ipa_kap){ + *f = ipa_client_conn_alloc_keepalive_fsm(rsl_link, line->ipa_kap, "rsl_bts_to_bsc"); + if(*f){ + ipa_keepalive_fsm_set_timeout_cb(*f, ipa_bts_keepalive_timeout_cb); + ipa_keepalive_fsm_set_send_cb(*f, ipa_bts_keepalive_write_client_cb); + } + } + return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a Gerrit-Change-Number: 14743 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 16:38:26 2019 From: gerrit-no-reply at lists.osmocom.org (ipse) Date: Wed, 10 Jul 2019 16:38:26 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX In-Reply-To: References: Message-ID: ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14684 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14684/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14684/1/src/osmo-bts-trx/scheduler_trx.c at 796 PS1, Line 796: /* Handover RACH cannot be extended (11-bit) */ > Sure, but in a separate change. No, it makes more sense to do it right here while you're changing the IF content. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1e654a2e49cb83c5f1e6249c0de688f99bc466b0 Gerrit-Change-Number: 14684 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Jul 2019 16:38:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy Comment-In-Reply-To: ipse Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 16:49:13 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 16:49:13 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14685 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c at 800 PS1, Line 800: synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, NULL); > What does this change has to do with debugging messages? We don't need to expose the matching score from rach_get_synch_seq() because we will not print it anymore. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 Gerrit-Change-Number: 14685 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: ipse Gerrit-Comment-Date: Wed, 10 Jul 2019 16:49:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ipse Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 16:54:54 2019 From: gerrit-no-reply at lists.osmocom.org (ipse) Date: Wed, 10 Jul 2019 16:54:54 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message In-Reply-To: References: Message-ID: ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14685 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c at 800 PS1, Line 800: synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, NULL); > We don't need to expose the matching score from rach_get_synch_seq() because we will not print it an [?] Why are you not printing it anymore? I thought you're enriching messages, not vice versa ;) Just print it conditionally. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 Gerrit-Change-Number: 14685 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: ipse Gerrit-Comment-Date: Wed, 10 Jul 2019 16:54:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Vadim Yanitskiy Comment-In-Reply-To: ipse Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 18:01:19 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Wed, 10 Jul 2019 18:01:19 +0000 Subject: Change in ...osmo-pcu[master]: Use libosmocore for IMSI parsing In-Reply-To: References: Message-ID: lynxis lazus has uploaded a new patch set (#2) to the change originally created by Max. ( https://gerrit.osmocom.org/c/osmo-pcu/+/13395 ) Change subject: Use libosmocore for IMSI parsing ...................................................................... Use libosmocore for IMSI parsing Change-Id: Iec5c65776fc54b2f9e5dd55c711ace2471662db1 --- M src/gprs_bssgp_pcu.cpp 1 file changed, 4 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/95/13395/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/13395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iec5c65776fc54b2f9e5dd55c711ace2471662db1 Gerrit-Change-Number: 13395 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: msuraev Gerrit-CC: Vadim Yanitskiy Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 18:07:24 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 18:07:24 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14685 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c at 800 PS1, Line 800: synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, NULL); > Why are you not printing it anymore? I thought you're enriching messages, not vice versa ;) Just pri [?] Printing either C/I or the match rate conditionally would complicate the LOGL1S(...) statement below, or at least make the code harder to read. I think I could use LOGPC() to solve the problem, but do we really need to care about the matching rate that much? If you insist, I will update the change. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 Gerrit-Change-Number: 14685 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: ipse Gerrit-Comment-Date: Wed, 10 Jul 2019 18:07:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy Comment-In-Reply-To: ipse Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 18:11:20 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 18:11:20 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14684 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14684/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14684/1/src/osmo-bts-trx/scheduler_trx.c at 796 PS1, Line 796: /* Handover RACH cannot be extended (11-bit) */ > No, it makes more sense to do it right here while you're changing the IF content. As you noticed, I am changing the content, but not the meaning of this 'if'. That comment was introduced before this change, and IMHO should be changed separately. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1e654a2e49cb83c5f1e6249c0de688f99bc466b0 Gerrit-Change-Number: 14684 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 10 Jul 2019 18:11:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy Comment-In-Reply-To: ipse Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 18:13:31 2019 From: gerrit-no-reply at lists.osmocom.org (ipse) Date: Wed, 10 Jul 2019 18:13:31 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message In-Reply-To: References: Message-ID: ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14685 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c at 800 PS1, Line 800: synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, NULL); > Printing either C/I or the match rate conditionally would complicate the LOGL1S(... [?] What's more important - the simplicity of debugging or reducing the code by one line? I would appreciate if you return the printing. Don't reduce debugging functionality - only increase it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 Gerrit-Change-Number: 14685 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: ipse Gerrit-Comment-Date: Wed, 10 Jul 2019 18:13:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy Comment-In-Reply-To: ipse Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 18:16:01 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 18:16:01 +0000 Subject: Change in ...osmo-pcu[master]: Use libosmocore for IMSI parsing In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/13395 ) Change subject: Use libosmocore for IMSI parsing ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/13395/2/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/13395/2/src/gprs_bssgp_pcu.cpp at 88 PS2, Line 88: 16 In the recent libosmocore we have OSMO_IMSI_BUF_SIZE. https://gerrit.osmocom.org/#/c/13395/2/src/gprs_bssgp_pcu.cpp at 116 PS2, Line 116: 16 How about sizeof(imsi)? https://gerrit.osmocom.org/#/c/13395/2/src/gprs_bssgp_pcu.cpp at 179 PS2, Line 179: 16 same -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/13395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iec5c65776fc54b2f9e5dd55c711ace2471662db1 Gerrit-Change-Number: 13395 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: msuraev Gerrit-CC: Vadim Yanitskiy Gerrit-Comment-Date: Wed, 10 Jul 2019 18:16:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 18:19:25 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Wed, 10 Jul 2019 18:19:25 +0000 Subject: Change in ...osmo-pcu[master]: Use libosmocore for IMSI parsing In-Reply-To: References: Message-ID: lynxis lazus has uploaded a new patch set (#3) to the change originally created by Max. ( https://gerrit.osmocom.org/c/osmo-pcu/+/13395 ) Change subject: Use libosmocore for IMSI parsing ...................................................................... Use libosmocore for IMSI parsing Change-Id: Iec5c65776fc54b2f9e5dd55c711ace2471662db1 --- M src/gprs_bssgp_pcu.cpp 1 file changed, 4 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/95/13395/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/13395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iec5c65776fc54b2f9e5dd55c711ace2471662db1 Gerrit-Change-Number: 13395 Gerrit-PatchSet: 3 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: msuraev Gerrit-CC: Vadim Yanitskiy Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 19:04:08 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Wed, 10 Jul 2019 19:04:08 +0000 Subject: Change in ...osmo-pcu[master]: bts.cpp: ensure left-shift operation does not exceed uint32_t Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14744 Change subject: bts.cpp: ensure left-shift operation does not exceed uint32_t ...................................................................... bts.cpp: ensure left-shift operation does not exceed uint32_t Found by Asan Relates: OS#4029 Change-Id: I21640e40e689016d6fb80a8db4257b22e85b303b --- M src/bts.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/44/14744/1 diff --git a/src/bts.cpp b/src/bts.cpp index e07b840..8799c3d 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -551,7 +551,7 @@ } /* get TLLI from downlink assignment */ - tlli = (*data++) << 28; + tlli = ((*data++) & 0xf) << 28; tlli |= (*data++) << 20; tlli |= (*data++) << 12; tlli |= (*data++) << 4; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14744 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I21640e40e689016d6fb80a8db4257b22e85b303b Gerrit-Change-Number: 14744 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 19:19:41 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 19:19:41 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14612 to look at the new patch set (#6). Change subject: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers ...................................................................... osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers This change needs to be done in order avoid adding more and more arguments to the UL logical channel handlers (such as rx_rach_fn). Since we have different versions of the TRXD header, and may have other burst-based PHYs in the future, some fields of an Uplink burst indication have conditional presence. Change-Id: Iae6b78bafa4b86d0c681684de47320d641d3f7c0 Related: OS#4006, OS#1855 --- M include/osmo-bts/scheduler_backend.h M src/common/scheduler.c M src/osmo-bts-trx/scheduler_trx.c M src/osmo-bts-virtual/scheduler_virtbts.c 4 files changed, 191 insertions(+), 152 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/12/14612/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iae6b78bafa4b86d0c681684de47320d641d3f7c0 Gerrit-Change-Number: 14612 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 19:19:41 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 19:19:41 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message In-Reply-To: References: Message-ID: Hello ipse, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14685 to look at the new patch set (#2). Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message ...................................................................... osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/85/14685/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 Gerrit-Change-Number: 14685 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: ipse Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 19:19:41 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 19:19:41 +0000 Subject: Change in ...osmo-bts[master]: Move Access Burst link quality handling to L1SAP In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14687 to look at the new patch set (#3). Change subject: Move Access Burst link quality handling to L1SAP ...................................................................... Move Access Burst link quality handling to L1SAP Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Depends: (libosmocore) Ie2a66ebd040b61d6daf49e04bf8a84d3d64764ee --- M src/common/l1sap.c M src/osmo-bts-litecell15/l1_if.c M src/osmo-bts-oc2g/l1_if.c M src/osmo-bts-sysmo/l1_if.c M src/osmo-bts-trx/scheduler_trx.c 5 files changed, 17 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/14687/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Gerrit-Change-Number: 14687 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 19:19:41 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 19:19:41 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14688 to look at the new patch set (#3). Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP ...................................................................... osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP Change-Id: I8d86dec7ebc039cbfd038c4342ff328b11281865 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/14688/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8d86dec7ebc039cbfd038c4342ff328b11281865 Gerrit-Change-Number: 14688 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 19:19:44 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 19:19:44 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: encode actual TRXD header version Message-ID: Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14745 Change subject: osmo-bts-trx/trx_if.c: encode actual TRXD header version ...................................................................... osmo-bts-trx/trx_if.c: encode actual TRXD header version Both TRX2L1 (Uplink) and L12TRX (Downlink) messages should use the same TRXD header format (and version) as was negotiated. Change-Id: Idbc598ef7c1871ee8da830f3fbe0a5cc386f873d Related: OS#4006 --- M src/osmo-bts-trx/trx_if.c 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/45/14745/1 diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index 3e53fdb..b966bbe 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -1054,6 +1054,7 @@ int trx_if_send_burst(struct trx_l1h *l1h, uint8_t tn, uint32_t fn, uint8_t pwr, const ubit_t *bits, uint16_t nbits) { + uint8_t hdr_ver = l1h->config.trxd_hdr_ver_use; uint8_t buf[TRX_DATA_MSG_MAX_LEN]; if ((nbits != GSM_BURST_LEN) && (nbits != EGPRS_BURST_LEN)) { @@ -1061,9 +1062,23 @@ return -1; } - LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG, "TX burst tn=%u fn=%u pwr=%u\n", tn, fn, pwr); + LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG, + "Tx burst (hdr_ver=%u): tn=%u fn=%u pwr=%u\n", + hdr_ver, tn, fn, pwr); - buf[0] = tn; + switch (hdr_ver) { + case 0: + case 1: + /* Both versions have the same header format */ + break; + + default: + LOGPPHI(l1h->phy_inst, DTRX, LOGL_ERROR, + "Requested TRXD header version %u is not supported\n", hdr_ver); + return -ENOTSUP; + } + + buf[0] = ((hdr_ver & 0x0f) << 4) | tn; buf[1] = (fn >> 24) & 0xff; buf[2] = (fn >> 16) & 0xff; buf[3] = (fn >> 8) & 0xff; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14745 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idbc598ef7c1871ee8da830f3fbe0a5cc386f873d Gerrit-Change-Number: 14745 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 19:19:44 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 19:19:44 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): clarify handover RACH handling Message-ID: Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14746 Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): clarify handover RACH handling ...................................................................... osmo-bts-trx/scheduler: rx_rach_fn(): clarify handover RACH handling Change-Id: I3da39d48052af1759297f4ad75c220b3046c0691 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/46/14746/1 diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 00d7bbb..cd3dbf4 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -793,7 +793,8 @@ enum rach_synch_seq_t synch_seq = RACH_SYNCH_SEQ_TS0; int best_score = 127 * RACH_SYNCH_SEQ_LEN; - /* Handover RACH cannot be extended (11-bit) */ + /* If chan != TRXC_RACH, this is a handover RACH, which is always encoded + * as 8-bit and should contain the generic training sequence (TS0). */ if (chan == TRXC_RACH) { if (bi->flags & TRX_BI_F_TS_INFO) synch_seq = (enum rach_synch_seq_t) bi->tsc; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14746 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3da39d48052af1759297f4ad75c220b3046c0691 Gerrit-Change-Number: 14746 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 19:19:58 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 19:19:58 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: add TRXD header version negotiation In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: add TRXD header version negotiation ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8afe950bd1ec2afaf3347ff848ee46e69c4f5011 Gerrit-Change-Number: 14611 Gerrit-PatchSet: 7 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: ipse Gerrit-Comment-Date: Wed, 10 Jul 2019 19:19:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 19:20:16 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 19:20:16 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 ) Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-CC: ipse Gerrit-Comment-Date: Wed, 10 Jul 2019 19:20:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 19:50:59 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Wed, 10 Jul 2019 19:50:59 +0000 Subject: Change in ...libosmo-abis[master]: extend the ipa keepalive fsm In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14742 ) Change subject: extend the ipa keepalive fsm ...................................................................... Patch Set 1: Code-Review-1 (2 comments) I know my comments can be annoying, but I believe we should keep the code consistent. https://gerrit.osmocom.org/#/c/14742/1/include/osmocom/abis/ipa.h File include/osmocom/abis/ipa.h: https://gerrit.osmocom.org/#/c/14742/1/include/osmocom/abis/ipa.h at 129 PS1, Line 129: You're changing tabs to spaces, keeping code unchanged. https://gerrit.osmocom.org/#/c/14742/1/src/input/ipa_keepalive.c File src/input/ipa_keepalive.c: https://gerrit.osmocom.org/#/c/14742/1/src/input/ipa_keepalive.c at 290 PS1, Line 290: Same here. Tabs are used in the existing code. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14742 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b Gerrit-Change-Number: 14742 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Wed, 10 Jul 2019 19:50:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 10 20:43:46 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Wed, 10 Jul 2019 20:43:46 +0000 Subject: Change in ...osmo-pcu[master]: schedule: do not use DL TBF with no extra data Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14747 Change subject: schedule: do not use DL TBF with no extra data ...................................................................... schedule: do not use DL TBF with no extra data There is no need in sending acked packets. TODO: write a test case for this Change-Id: I8bbd4570f70bb712edd2f78520bf1643c9157aff --- M src/gprs_rlcmac_sched.cpp 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/47/14747/1 diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp index 57756e3..61d3e39 100644 --- a/src/gprs_rlcmac_sched.cpp +++ b/src/gprs_rlcmac_sched.cpp @@ -265,6 +265,9 @@ if (tbf->m_wait_confirm) continue; + if (tbf->window()->window_empty() && !tbf->have_data()) + continue; + age = tbf->frames_since_last_poll(fn); /* compute priority */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14747 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8bbd4570f70bb712edd2f78520bf1643c9157aff Gerrit-Change-Number: 14747 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Wed Jul 10 21:10:00 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 10 Jul 2019 21:10:00 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d265443be80f_70ce112e5fc527858@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sysmon failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 261s] #define PACKAGE "osmo-sysmon" [ 261s] #define VERSION "0.1.0" [ 261s] #define STDC_HEADERS 1 [ 261s] #define HAVE_SYS_TYPES_H 1 [ 261s] #define HAVE_SYS_STAT_H 1 [ 261s] #define HAVE_STDLIB_H 1 [ 261s] #define HAVE_STRING_H 1 [ 261s] #define HAVE_MEMORY_H 1 [ 261s] #define HAVE_STRINGS_H 1 [ 261s] #define HAVE_INTTYPES_H 1 [ 261s] #define HAVE_STDINT_H 1 [ 261s] #define HAVE_UNISTD_H 1 [ 261s] #define HAVE_DLFCN_H 1 [ 261s] #define LT_OBJDIR ".libs/" [ 261s] [ 261s] configure: exit 1 [ 261s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking returned exit code 1 [ 261s] make: *** [debian/rules:45: build] Error 2 [ 261s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 261s] [ 261s] lamb22 failed "build osmo-sysmon_0.1.0.dsc" at Wed Jul 10 21:09:49 UTC 2019. [ 261s] [ 261s] ### VM INTERACTION START ### [ 264s] [ 246.512335] sysrq: SysRq : Power Off [ 264s] [ 246.532630] reboot: Power down [ 264s] ### VM INTERACTION END ### [ 264s] [ 264s] lamb22 failed "build osmo-sysmon_0.1.0.dsc" at Wed Jul 10 21:09:53 UTC 2019. [ 264s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Wed Jul 10 21:10:34 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 10 Jul 2019 21:10:34 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2654641df94_70ce112e5fc5279a8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_Unstable/x86_64 Package network:osmocom:latest/openbsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 171s] | #define HAVE_MEMORY_H 1 [ 171s] | #define HAVE_STRINGS_H 1 [ 171s] | #define HAVE_INTTYPES_H 1 [ 171s] | #define HAVE_STDINT_H 1 [ 171s] | #define HAVE_UNISTD_H 1 [ 171s] | #define HAVE_DLFCN_H 1 [ 171s] | #define LT_OBJDIR ".libs/" [ 171s] | #define BUILD_SMPP 1 [ 171s] | #define STDC_HEADERS 1 [ 171s] | #define HAVE_DBI_DBD_H 1 [ 171s] | #define HAVE_PCAP_PCAP_H 1 [ 171s] | #define HAVE_TM_GMTOFF_IN_TM 1 [ 171s] | [ 171s] | configure: exit 0 [ 171s] [ 171s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 171s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 171s] make: *** [debian/rules:13: build] Error 2 [ 171s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 171s] [ 171s] lamb64 failed "build openbsc_1.2.0.dsc" at Wed Jul 10 21:10:28 UTC 2019. [ 171s] [ 171s] ### VM INTERACTION START ### [ 174s] [ 160.574414] sysrq: SysRq : Power Off [ 174s] [ 160.579919] reboot: Power down [ 175s] ### VM INTERACTION END ### [ 175s] [ 175s] lamb64 failed "build openbsc_1.2.0.dsc" at Wed Jul 10 21:10:32 UTC 2019. [ 175s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Jul 10 22:45:51 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Wed, 10 Jul 2019 22:45:51 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for... In-Reply-To: References: Message-ID: lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14696 ) Change subject: Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for rest_bits ...................................................................... Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for rest_bits The rest_bits are never read after calling this function nor are rest_bits updated properly. Change-Id: Ic350b0365b125638a6c752f692bef981ad6b9d89 --- M src/encoding.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Vadim Yanitskiy: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/encoding.cpp b/src/encoding.cpp index a290c65..d253dac 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -830,7 +830,7 @@ static void write_packet_ack_nack_desc_egprs( bitvec * dest, unsigned& wp, - gprs_rlc_ul_window *window, bool is_final, unsigned& rest_bits) + gprs_rlc_ul_window *window, bool is_final, unsigned rest_bits) { unsigned int urbb_len = 0; uint8_t crbb_len = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14696 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic350b0365b125638a6c752f692bef981ad6b9d89 Gerrit-Change-Number: 14696 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Thu Jul 11 02:38:51 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 11 Jul 2019 02:38:51 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d26a14191c66_70ce112e5fc55178@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 430s] | am_cv_prog_cc_c_o=yes [ 430s] | lt_cv_ar_at_file=@ [ 430s] | lt_cv_archive_cmds_need_lc=no [ 430s] | lt_cv_deplibs_check_method=pass_all [ 430s] | lt_cv_file_magic_cmd='$MAGIC_CMD' [ 430s] | lt_cv_file_magic_test_file= [ 430s] | lt_cv_ld_reload_flag=-r [ 430s] | lt_cv_nm_interface='BSD nm' [ 430s] | lt_cv_objdir=.libs [ 430s] | lt_cv_path_LD=/usr/bin/ld [ 430s] | lt_cv_path_NM='/usr/bin/nm -B' [ 430s] | lt_cv_path_mainfest_tool=no [ 430s] | lt_cv_prog_compiler_c_o=yes [ 430s] | lt_cv_prog_compiler_pic='-fPIC -DPIC' [ 430s] | lt_cv_prog_compiler_pic_works=yes [ 430s] | lt_cv_prog_compiler_rtti_exceptions=no [ 430s] | lt_cv_prog_compiler_static_works=yes [ 430s] | lt_cv_prog_gnu_ld=yes [ 430s] | lt_cv_sharedlib_from_linklib_cmd='printf %s\n' [ 430s] | lt_cv_shlibpath_overrides_runpath=no [ 430s] | lt_cv_sys_global_symbol_pipe='sed -n -e '\''s/^.*[ ]\([ABCDGIRSTW][ABCDGIRSTW]*\)[ ][ ]*\([_A-Za-z][_A-Za-z0-9]*\)$/\1 \2 \2/p'\'' | sed '\''/ __gnu_lto/d'\''' [ 430s] | lt_cv_sys_global_symbol_to_c_name_address='sed -n -e '\''s/^: \(.*\) .*$/ {"\1", (void *) 0},/p'\'' -e '\''s/^[ABCDGIRSTW][ABCDGIRSTW]* .* \(.*\)$/ {"\1", (void *) \&\1},/p'\''' [ 430s] | lt_cv_sys_global_symbol_to_c_name_address_lib_prefix='sed -n -e '\''s/^: \(.*\) .*$/ {"\1", (void *) 0},/p'\'' -e '\''s/^[ABCDGIRSTW][ABCDGIRSTW]* .* \(lib.*\)$/ {"\1", (void *) \&\1},/p'\'' -e '\''s/^[ABCDGIRSTW][ABCDGIRSTW]* .* \(.*\)$/ {"lib\1", (void *) \&\1},/p'\''' [ 432s] | lt_cv_sys_global_symbol_to_cdecl='sed[ 409.916698] sysrq: SysRq : Power Off [ 432s] [ 409.918835] reboot: Power down [ 433s] ### VM INTERACTION END ### [ 433s] [ 433s] armbuild26 failed "build libosmocore_1.1.0.78.d1f1.dsc" at Thu Jul 11 02:38:50 UTC 2019. [ 433s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Thu Jul 11 02:43:08 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 11 Jul 2019 02:43:08 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in xUbuntu_18.10/x86_64 In-Reply-To: References: Message-ID: <5d26a252b77f9_70ce112e5fc5524b2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/xUbuntu_18.10/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in xUbuntu_18.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 143s] | #define HAVE_STDINT_H 1 [ 143s] | #define HAVE_UNISTD_H 1 [ 143s] | #define HAVE_DLFCN_H 1 [ 143s] | #define LT_OBJDIR ".libs/" [ 143s] | #define STDC_HEADERS 1 [ 143s] | #define HAVE_EXECINFO_H 1 [ 143s] | #define HAVE_SYS_SELECT_H 1 [ 143s] | #define HAVE_SYS_SOCKET_H 1 [ 143s] | #define HAVE_SYSLOG_H 1 [ 143s] | #define HAVE_CTYPE_H 1 [ 143s] | #define HAVE_LIBSCTP 1 [ 143s] | #define HAVE_PCAP_H 1 [ 143s] | [ 143s] | configure: exit 0 [ 143s] [ 143s] make[1]: *** [debian/rules:27: override_dh_auto_test] Error 1 [ 143s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 143s] make: *** [debian/rules:13: build] Error 2 [ 143s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 143s] [ 143s] lamb12 failed "build libosmo-netif_0.5.0.1.f0f1.dsc" at Thu Jul 11 02:42:50 UTC 2019. [ 143s] [ 143s] ### VM INTERACTION START ### [ 146s] [ 134.263919] sysrq: SysRq : Power Off [ 146s] [ 134.270434] reboot: Power down [ 146s] ### VM INTERACTION END ### [ 146s] [ 146s] lamb12 failed "build libosmo-netif_0.5.0.1.f0f1.dsc" at Thu Jul 11 02:42:53 UTC 2019. [ 146s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Thu Jul 11 02:53:08 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 11 Jul 2019 02:53:08 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d26a4a94eb32_70ce112e5fc55277f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 538s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 538s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 538s] collect2: error: ld returned 1 exit status [ 538s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 538s] make[4]: *** [osmo-bts-virtual] Error 1 [ 538s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 538s] Makefile:385: recipe for target 'all-recursive' failed [ 538s] make[3]: *** [all-recursive] Error 1 [ 538s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 538s] Makefile:434: recipe for target 'all-recursive' failed [ 538s] make[2]: *** [all-recursive] Error 1 [ 538s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 538s] Makefile:366: recipe for target 'all' failed [ 538s] make[1]: *** [all] Error 2 [ 538s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 538s] dh_auto_build: make -j1 returned exit code 2 [ 538s] debian/rules:12: recipe for target 'build' failed [ 538s] make: *** [build] Error 2 [ 538s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 538s] [ 538s] obs-arm-5 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Thu Jul 11 02:53:03 UTC 2019. [ 538s] [ 538s] ### VM INTERACTION START ### [ 541s] [ 504.730153] sysrq: SysRq : Power Off [ 541s] [ 504.731976] reboot: Power down [ 542s] ### VM INTERACTION END ### [ 542s] [ 542s] obs-arm-5 failed "build osmo-bts_0.8.1.335.7d1d.dsc" at Thu Jul 11 02:53:07 UTC 2019. [ 542s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:15:41 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:15:41 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: encode actual TRXD header version In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14745 ) Change subject: osmo-bts-trx/trx_if.c: encode actual TRXD header version ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14745 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idbc598ef7c1871ee8da830f3fbe0a5cc386f873d Gerrit-Change-Number: 14745 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:15:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:16:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:16:05 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14612 ) Change subject: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iae6b78bafa4b86d0c681684de47320d641d3f7c0 Gerrit-Change-Number: 14612 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 11 Jul 2019 03:16:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:16:26 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:16:26 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): clarify handover RACH handling In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14746 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): clarify handover RACH handling ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14746 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3da39d48052af1759297f4ad75c220b3046c0691 Gerrit-Change-Number: 14746 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:16:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:17:06 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:17:06 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14685 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 Gerrit-Change-Number: 14685 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:17:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:19:27 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:19:27 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 ) Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: ipse Gerrit-Comment-Date: Thu, 11 Jul 2019 03:19:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:20:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:20:22 +0000 Subject: Change in ...osmo-bts[master]: Move Access Burst link quality handling to L1SAP In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14687 ) Change subject: Move Access Burst link quality handling to L1SAP ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Gerrit-Change-Number: 14687 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:20:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:21:04 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:21:04 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14688 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8d86dec7ebc039cbfd038c4342ff328b11281865 Gerrit-Change-Number: 14688 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:21:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:22:08 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:22:08 +0000 Subject: Change in ...osmo-pcu[master]: bts.cpp: ensure left-shift operation does not exceed uint32_t In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14744 ) Change subject: bts.cpp: ensure left-shift operation does not exceed uint32_t ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14744 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I21640e40e689016d6fb80a8db4257b22e85b303b Gerrit-Change-Number: 14744 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:22:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:22:15 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:22:15 +0000 Subject: Change in ...osmo-pcu[master]: bts.cpp: ensure left-shift operation does not exceed uint32_t In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14744 ) Change subject: bts.cpp: ensure left-shift operation does not exceed uint32_t ...................................................................... bts.cpp: ensure left-shift operation does not exceed uint32_t Found by Asan Relates: OS#4029 Change-Id: I21640e40e689016d6fb80a8db4257b22e85b303b --- M src/bts.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bts.cpp b/src/bts.cpp index e07b840..8799c3d 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -551,7 +551,7 @@ } /* get TLLI from downlink assignment */ - tlli = (*data++) << 28; + tlli = ((*data++) & 0xf) << 28; tlli |= (*data++) << 20; tlli |= (*data++) << 12; tlli |= (*data++) << 4; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14744 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I21640e40e689016d6fb80a8db4257b22e85b303b Gerrit-Change-Number: 14744 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:22:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:22:36 +0000 Subject: Change in ...docker-playground[master]: ttcn3-*: enable GSMTAP logging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14712 ) Change subject: ttcn3-*: enable GSMTAP logging ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I99e74f6ffb5b7d566cec35995bf067df414968d8 Gerrit-Change-Number: 14712 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Jul 2019 03:22:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:22:48 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:22:48 +0000 Subject: Change in ...docker-playground[master]: ttcn3-*: enable GSMTAP logging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14712 ) Change subject: ttcn3-*: enable GSMTAP logging ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I99e74f6ffb5b7d566cec35995bf067df414968d8 Gerrit-Change-Number: 14712 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Jul 2019 03:22:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:23:48 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:23:48 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: use uint16_t when interacting with the window object In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14571 ) Change subject: Encoding: use uint16_t when interacting with the window object ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If62fa09d7bfa8e91ce707824f7019edb1b83da9e Gerrit-Change-Number: 14571 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:23:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:23:52 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:23:52 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: use uint16_t when interacting with the window object In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14571 ) Change subject: Encoding: use uint16_t when interacting with the window object ...................................................................... Encoding: use uint16_t when interacting with the window object The ESN, SSN and uncompress bitmap len are uint16_t. The Window is using uint16_t in function arguments and return values. Don't do so many integer conversions. Change-Id: If62fa09d7bfa8e91ce707824f7019edb1b83da9e --- M src/encoding.cpp 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Vadim Yanitskiy: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/encoding.cpp b/src/encoding.cpp index d253dac..48f3829 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -837,14 +837,14 @@ uint8_t len; bool bow = true; bool eow = true; - int ssn = window->mod_sns(window->v_q() + 1); + uint16_t ssn = window->mod_sns(window->v_q() + 1); unsigned int num_blocks = window->mod_sns(window->v_r() - window->v_q()); - int esn_crbb = window->mod_sns(ssn - 1); + uint16_t esn_crbb = window->mod_sns(ssn - 1); static uint8_t rbb[RLC_EGPRS_MAX_WS] = {'\0'}; uint8_t iter = 0; int is_compressed = 0; bool try_compression = false; - uint8_t ucmp_bmplen; + uint16_t ucmp_bmplen; uint8_t crbb_bitmap[23] = {'\0'}; bitvec ucmp_vec; bitvec crbb_vec; @@ -972,7 +972,7 @@ bitvec_write_field(dest, &wp, 0, 1); // CRBB_Exist } LOGP(DRLCMACUL, LOGL_DEBUG, - "EGPRS URBB, urbb len = %d, SSN = %d, ESN_CRBB = %d, " + "EGPRS URBB, urbb len = %d, SSN = %u, ESN_CRBB = %u, " "len present = %s,desc len = %d, " "SNS = %d, WS = %d, V(Q) = %d, V(R) = %d%s%s\n", urbb_len, ssn, esn_crbb, len_coded ? "yes" : "No" , len, -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If62fa09d7bfa8e91ce707824f7019edb1b83da9e Gerrit-Change-Number: 14571 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:24:58 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:24:58 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: ACK/NACK: always encode with length field present In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14697 ) Change subject: Encoding: ACK/NACK: always encode with length field present ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb Gerrit-Change-Number: 14697 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:24:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:28:10 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:28:10 +0000 Subject: Change in ...osmo-hlr[master]: add keepalive for gsup client/server, osmo-hlr In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14741 ) Change subject: add keepalive for gsup client/server, osmo-hlr ...................................................................... Patch Set 1: (2 comments) looks good, except for some stylistic comments, sorry:/ https://gerrit.osmocom.org/#/c/14741/1/src/gsupclient/gsup_client.c File src/gsupclient/gsup_client.c: https://gerrit.osmocom.org/#/c/14741/1/src/gsupclient/gsup_client.c at 279 PS1, Line 279: if(params){ if only if was a function, we would not use spaces in front of the parenthesis. I'm willing to ignore a single outlier somewhere occasionally, but all of the if statements added by this patc don't follow our coding style, sorry. https://gerrit.osmocom.org/#/c/14741/1/src/hlr.h File src/hlr.h: https://gerrit.osmocom.org/#/c/14741/1/src/hlr.h at 64 PS1, Line 64: struct ipa_keepalive_params* ka_params; we generally use the asterisk on the right side (ka_params). -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14741 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I01654d4a023e76a2b9245817a0096148c8bd44c1 Gerrit-Change-Number: 14741 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:28:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:30:07 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:30:07 +0000 Subject: Change in ...libosmo-abis[master]: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14743 ) Change subject: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc ...................................................................... Patch Set 1: (1 comment) this also needs an entry in TODO-RELEASE as it breaks ABI+API https://gerrit.osmocom.org/#/c/14743/1/src/e1_input_vty.c File src/e1_input_vty.c: https://gerrit.osmocom.org/#/c/14743/1/src/e1_input_vty.c at 184 PS1, Line 184: if (!line) { : vty_out(vty, "%% Line %d doesn't exist%s", e1_nr, VTY_NEWLINE); : return CMD_WARNING; : } : if(strcmp(line->driver->name, "ipa") != 0){ : vty_out(vty, "%% Line %d doesn't use the ipa driver%s", e1_nr, VTY_NEWLINE); : return CMD_WARNING; : } same stylitsic comments as in the other patch. here it's even two if-clauses with space and two without, -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a Gerrit-Change-Number: 14743 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:30:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:35:12 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:35:12 +0000 Subject: Change in ...osmo-bts[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14725 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9d9b2412f005e4bda0ed35ba715cfb4dca1b04c1 Gerrit-Change-Number: 14725 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:35:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:35:17 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:35:17 +0000 Subject: Change in ...osmo-bts[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14725 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I9d9b2412f005e4bda0ed35ba715cfb4dca1b04c1 --- M contrib/jenkins_common.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins_common.sh b/contrib/jenkins_common.sh index fd0359b..6e4fa7e 100644 --- a/contrib/jenkins_common.sh +++ b/contrib/jenkins_common.sh @@ -57,4 +57,6 @@ if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then $MAKE -C "$base/doc/manuals" publish fi + + $MAKE maintainer-clean } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9d9b2412f005e4bda0ed35ba715cfb4dca1b04c1 Gerrit-Change-Number: 14725 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:35:32 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:35:32 +0000 Subject: Change in ...gapk[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/14713 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/14713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: Ifb581662b05d938acc04636c2a408e43bbe10bf0 Gerrit-Change-Number: 14713 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:35:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:35:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:35:35 +0000 Subject: Change in ...gapk[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/gapk/+/14713 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ifb581662b05d938acc04636c2a408e43bbe10bf0 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index cf53c3a..2e9035d 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -38,5 +38,6 @@ $MAKE $PARALLEL_MAKE LD_LIBRARY_PATH="$inst/lib" $MAKE check || cat-testlogs.sh LD_LIBRARY_PATH="$inst/lib" DISTCHECK_CONFIGURE_FLAGS="" $MAKE distcheck || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/gapk/+/14713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: Ifb581662b05d938acc04636c2a408e43bbe10bf0 Gerrit-Change-Number: 14713 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:35:45 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:35:45 +0000 Subject: Change in ...libgtpnl[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/14715 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/14715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I20997b986b24ced9bb8d6d66a66d5ec2bafd00f2 Gerrit-Change-Number: 14715 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:35:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:35:48 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:35:48 +0000 Subject: Change in ...libgtpnl[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libgtpnl/+/14715 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I20997b986b24ced9bb8d6d66a66d5ec2bafd00f2 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index ebdc6ea..43e81a1 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -8,5 +8,6 @@ ./configure --enable-sanitize CFLAGS="-Werror" CPPFLAGS="-Werror" $MAKE $PARALLEL_MAKE $MAKE distcheck +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/14715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I20997b986b24ced9bb8d6d66a66d5ec2bafd00f2 Gerrit-Change-Number: 14715 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:35:53 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:35:53 +0000 Subject: Change in ...libasn1c[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libasn1c/+/14714 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/14714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: If91b10d37cb4c940e009c12b232d042305d57886 Gerrit-Change-Number: 14714 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:35:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:35:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:35:56 +0000 Subject: Change in ...libasn1c[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libasn1c/+/14714 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: If91b10d37cb4c940e009c12b232d042305d57886 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7d68736..c23bdec 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -17,5 +17,6 @@ $MAKE $PARALLEL_MAKE $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/14714 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: If91b10d37cb4c940e009c12b232d042305d57886 Gerrit-Change-Number: 14714 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:36:21 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:36:21 +0000 Subject: Change in ...libosmo-abis[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14716 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib261f25e2c7b48283a6142259991aadfcf40cdec Gerrit-Change-Number: 14716 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:36:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:36:23 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:36:23 +0000 Subject: Change in ...libosmo-abis[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14716 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ib261f25e2c7b48283a6142259991aadfcf40cdec --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 6a76044..a465d5a 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -37,5 +37,6 @@ $MAKE $PARALLEL_MAKE $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib261f25e2c7b48283a6142259991aadfcf40cdec Gerrit-Change-Number: 14716 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:36:26 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 03:36:26 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: ACK/NACK: always encode with length field present In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/14697 to look at the new patch set (#3). Change subject: Encoding: ACK/NACK: always encode with length field present ...................................................................... Encoding: ACK/NACK: always encode with length field present In most cases the length field was present and this field takes 7 bits of the maximum available 110 rest bits. The length field was only removed when encoding huge bitmaps usually only happen on lossy connections with packet lost. However the cases without length field were encoded incorrect, because all remaining bits must be used by the uncompressed bitmaps, but the PCU violates this by encoding always the "release 5" bit. Rather than fixing the encoding without length field, simply remove it and always encode with length field. This also reduces the code complexity. Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb --- M src/encoding.cpp 1 file changed, 39 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/97/14697/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb Gerrit-Change-Number: 14697 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:36:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:36:36 +0000 Subject: Change in ...libtelnet[master]: contrib/jenkins.sh: run "make {distcheck, maintainer-clean}" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libtelnet/+/14721 ) Change subject: contrib/jenkins.sh: run "make {distcheck,maintainer-clean}" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libtelnet/+/14721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libtelnet Gerrit-Branch: master Gerrit-Change-Id: I0c7cd8f8b2a3821e5c55fc84b24eca5e199ebbd8 Gerrit-Change-Number: 14721 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:36:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:36:46 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:36:46 +0000 Subject: Change in ...libtelnet[master]: contrib/jenkins.sh: run "make {distcheck, maintainer-clean}" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libtelnet/+/14721 ) Change subject: contrib/jenkins.sh: run "make {distcheck,maintainer-clean}" ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/libtelnet/+/14721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libtelnet Gerrit-Branch: master Gerrit-Change-Id: I0c7cd8f8b2a3821e5c55fc84b24eca5e199ebbd8 Gerrit-Change-Number: 14721 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:36:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:36:49 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:36:49 +0000 Subject: Change in ...libtelnet[master]: contrib/jenkins.sh: run "make {distcheck, maintainer-clean}" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libtelnet/+/14721 ) Change subject: contrib/jenkins.sh: run "make {distcheck,maintainer-clean}" ...................................................................... contrib/jenkins.sh: run "make {distcheck,maintainer-clean}" Related: OS#3047 Change-Id: I0c7cd8f8b2a3821e5c55fc84b24eca5e199ebbd8 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 57da9fa..d75beda 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -5,3 +5,5 @@ autoreconf --install --force ./configure $MAKE $PARALLEL_MAKE +$MAKE distcheck +$MAKE maintainer-clean -- To view, visit https://gerrit.osmocom.org/c/libtelnet/+/14721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libtelnet Gerrit-Branch: master Gerrit-Change-Id: I0c7cd8f8b2a3821e5c55fc84b24eca5e199ebbd8 Gerrit-Change-Number: 14721 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:37:01 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:37:01 +0000 Subject: Change in ...libusrp[master]: contrib/jenkins.sh: run "make {distcheck, maintainer-clean}" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libusrp/+/14722 ) Change subject: contrib/jenkins.sh: run "make {distcheck,maintainer-clean}" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/14722 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Ic277f37413cb338f4f9bdf4c5fc033d94a2cd5db Gerrit-Change-Number: 14722 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:37:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:37:07 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:37:07 +0000 Subject: Change in ...libosmo-netif[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/14717 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/14717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I37908c12dae9d268b8bde186e2743a2d7fd13536 Gerrit-Change-Number: 14717 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:37:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:37:09 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:37:09 +0000 Subject: Change in ...libosmo-netif[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-netif/+/14717 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I37908c12dae9d268b8bde186e2743a2d7fd13536 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index f2013a5..5cfa8cb 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -39,5 +39,6 @@ $MAKE $PARALLEL_MAKE $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/14717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I37908c12dae9d268b8bde186e2743a2d7fd13536 Gerrit-Change-Number: 14717 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:37:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:37:16 +0000 Subject: Change in ...libosmo-sccp[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14718 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14718 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia6ebe5add2c1ce6891d596fb2987e46f8ff8a6d6 Gerrit-Change-Number: 14718 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:37:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:37:19 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:37:19 +0000 Subject: Change in ...libosmo-sccp[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14718 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ia6ebe5add2c1ce6891d596fb2987e46f8ff8a6d6 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index c54c1ac..da96c5e 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -54,6 +54,7 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14718 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia6ebe5add2c1ce6891d596fb2987e46f8ff8a6d6 Gerrit-Change-Number: 14718 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:37:26 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:37:26 +0000 Subject: Change in ...libsmpp34[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/14720 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/14720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I78fc465169b9ed95a2f9aaef93f28e1ce47b551a Gerrit-Change-Number: 14720 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:37:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:37:28 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:37:28 +0000 Subject: Change in ...libsmpp34[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libsmpp34/+/14720 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I78fc465169b9ed95a2f9aaef93f28e1ce47b551a --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 8680cde..3b4e639 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -10,5 +10,6 @@ $MAKE $MAKE $PARALLEL_MAKE $MAKE distcheck || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/14720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I78fc465169b9ed95a2f9aaef93f28e1ce47b551a Gerrit-Change-Number: 14720 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:37:34 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:37:34 +0000 Subject: Change in ...libosmocore[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14719 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic147678e7906a8b9ad7fac8367602b656f4172e6 Gerrit-Change-Number: 14719 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:37:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:37:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:37:36 +0000 Subject: Change in ...libosmocore[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14719 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ic147678e7906a8b9ad7fac8367602b656f4172e6 --- M contrib/jenkins_amd64.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins_amd64.sh b/contrib/jenkins_amd64.sh index 9b83793..c79e26a 100755 --- a/contrib/jenkins_amd64.sh +++ b/contrib/jenkins_amd64.sh @@ -31,5 +31,6 @@ DISTCHECK_CONFIGURE_FLAGS=--enable-external-tests \ $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic147678e7906a8b9ad7fac8367602b656f4172e6 Gerrit-Change-Number: 14719 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:38:00 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:38:00 +0000 Subject: Change in ...openbsc[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14723 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I3324f96ea0ec25b210562e0523b21f1a94db12ec Gerrit-Change-Number: 14723 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:38:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:38:03 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:38:03 +0000 Subject: Change in ...openbsc[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/openbsc/+/14723 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I3324f96ea0ec25b210562e0523b21f1a94db12ec --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 277fece..da8703a 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -46,6 +46,7 @@ "$MAKE" $PARALLEL_MAKE "$MAKE" check || cat-testlogs.sh "$MAKE" distcheck || cat-testlogs.sh + "$MAKE" maintainer-clean } . osmo-build.sh -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14723 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I3324f96ea0ec25b210562e0523b21f1a94db12ec Gerrit-Change-Number: 14723 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:38:10 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:38:10 +0000 Subject: Change in ...osmo-bsc[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14724 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14724 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c257e21376cdccd6e2f413c7df6dd8caef497f1 Gerrit-Change-Number: 14724 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:38:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:38:13 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:38:13 +0000 Subject: Change in ...osmo-bsc[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14724 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I5c257e21376cdccd6e2f413c7df6dd8caef497f1 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index a47935f..524971b 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -61,6 +61,7 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-vty-tests --enable-external-tests --enable-werror $CONFIG" \ $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14724 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5c257e21376cdccd6e2f413c7df6dd8caef497f1 Gerrit-Change-Number: 14724 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:38:34 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:38:34 +0000 Subject: Change in ...osmo-pcu[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14734 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I733df8f8bfaf448a6507c9c9d75d2f076fedb342 Gerrit-Change-Number: 14734 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:38:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:38:37 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:38:37 +0000 Subject: Change in ...osmo-pcu[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14734 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I733df8f8bfaf448a6507c9c9d75d2f076fedb342 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index e805080..8c32cbb 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -104,4 +104,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I733df8f8bfaf448a6507c9c9d75d2f076fedb342 Gerrit-Change-Number: 14734 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:39:24 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:39:24 +0000 Subject: Change in ...osmo-gsm-manuals[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14728 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I99b9cd46e564cc1c5c1e92b9870368ff515a9356 Gerrit-Change-Number: 14728 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:39:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:39:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:39:36 +0000 Subject: Change in ...osmo-gsm-manuals[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14728 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I99b9cd46e564cc1c5c1e92b9870368ff515a9356 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7d4d8df..0c40e2f 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -16,5 +16,6 @@ $MAKE $PARALLEL_MAKE $MAKE $PARALLEL_MAKE check $MAKE $PARALLEL_MAKE distcheck +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I99b9cd46e564cc1c5c1e92b9870368ff515a9356 Gerrit-Change-Number: 14728 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:39:48 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:39:48 +0000 Subject: Change in ...osmo-ggsn[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14727 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14727 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I0ad159a3973d28ac79ea7fb433401c72b247c2b0 Gerrit-Change-Number: 14727 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:39:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:39:54 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:39:54 +0000 Subject: Change in ...osmo-ggsn[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14727 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I0ad159a3973d28ac79ea7fb433401c72b247c2b0 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index b512334..2c03c09 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -60,4 +60,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14727 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I0ad159a3973d28ac79ea7fb433401c72b247c2b0 Gerrit-Change-Number: 14727 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:40:03 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:40:03 +0000 Subject: Change in ...osmo-pcap[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14733 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ieae88eec72801e143daa631e7d01a5e11e9befae Gerrit-Change-Number: 14733 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:40:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:40:07 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:40:07 +0000 Subject: Change in ...osmo-pcap[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14733 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ieae88eec72801e143daa631e7d01a5e11e9befae --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7ec1463..f1779dc 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -41,5 +41,6 @@ DISTCHECK_CONFIGURE_FLAGS="--with-pcap-config=/bin/true" \ PCAP_LIBS="-lpcap" PCAP_CFLAGS="" \ $MAKE distcheck || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14733 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ieae88eec72801e143daa631e7d01a5e11e9befae Gerrit-Change-Number: 14733 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:40:25 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:40:25 +0000 Subject: Change in ...osmo-hlr[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14729 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I63808c5c2724b8f4c3cf40db682f74eec54f1e76 Gerrit-Change-Number: 14729 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:40:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:40:29 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:40:29 +0000 Subject: Change in ...osmo-hlr[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14729 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I63808c5c2724b8f4c3cf40db682f74eec54f1e76 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 1dadac3..5914182 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -58,4 +58,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I63808c5c2724b8f4c3cf40db682f74eec54f1e76 Gerrit-Change-Number: 14729 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:40:38 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:40:38 +0000 Subject: Change in ...osmo-remsim[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14735 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14735 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I619499ce68c8e0ddef597021329d9bfd4d2f1a77 Gerrit-Change-Number: 14735 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:40:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:40:42 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:40:42 +0000 Subject: Change in ...osmo-remsim[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14735 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I619499ce68c8e0ddef597021329d9bfd4d2f1a77 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 1a14278..249df64 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -39,5 +39,6 @@ $MAKE $PARALLEL_MAKE $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14735 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I619499ce68c8e0ddef597021329d9bfd4d2f1a77 Gerrit-Change-Number: 14735 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:40:51 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:40:51 +0000 Subject: Change in ...osmo-mgw[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14731 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I60c713a64ef629f0cb88121632ea6adc017fd0ae Gerrit-Change-Number: 14731 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:40:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:40:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:40:56 +0000 Subject: Change in ...osmo-mgw[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14731 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I60c713a64ef629f0cb88121632ea6adc017fd0ae --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 9777d4b..706ad5c 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -63,4 +63,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I60c713a64ef629f0cb88121632ea6adc017fd0ae Gerrit-Change-Number: 14731 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:41:06 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:41:06 +0000 Subject: Change in ...osmo-iuh[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14730 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6f9274efeb2fdda54feaa54eb299f7aafaaec1eb Gerrit-Change-Number: 14730 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:41:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:41:10 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:41:10 +0000 Subject: Change in ...osmo-iuh[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14730 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I6f9274efeb2fdda54feaa54eb299f7aafaaec1eb --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 617aeac..5754f2c 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -55,5 +55,6 @@ || cat-testlogs.sh $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I6f9274efeb2fdda54feaa54eb299f7aafaaec1eb Gerrit-Change-Number: 14730 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:41:17 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:41:17 +0000 Subject: Change in ...osmocom-bb[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14740 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I11c37f72b6e4294d1dc7b6d1751627ccf4f5c87a Gerrit-Change-Number: 14740 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:41:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:41:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:41:22 +0000 Subject: Change in ...osmocom-bb[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14740 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I11c37f72b6e4294d1dc7b6d1751627ccf4f5c87a --- M contrib/jenkins.sh 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index dc8cda6..52c6566 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -61,4 +61,10 @@ fi fi +# Test 'maintainer-clean' +for dir in gprsdecode layer23 gsmmap osmocon trxcon virt_phy; do + cd "$base/src/host/$dir" + make maintainer-clean +done + osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14740 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I11c37f72b6e4294d1dc7b6d1751627ccf4f5c87a Gerrit-Change-Number: 14740 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:42:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:42:22 +0000 Subject: Change in ...osmo-trx[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14739 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6d541b47e68f5a8a61ac139a3ea85a9cb33856c1 Gerrit-Change-Number: 14739 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:42:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:42:28 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:42:28 +0000 Subject: Change in ...osmo-trx[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14739 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I6d541b47e68f5a8a61ac139a3ea85a9cb33856c1 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index dedec81..1dd8478 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -107,4 +107,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14739 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6d541b47e68f5a8a61ac139a3ea85a9cb33856c1 Gerrit-Change-Number: 14739 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:42:33 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:42:33 +0000 Subject: Change in ...osmo-msc[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14732 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ifc91733c7fe0c5a002037523116014bf270997ef Gerrit-Change-Number: 14732 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:42:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:42:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:42:36 +0000 Subject: Change in ...osmo-msc[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14732 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ifc91733c7fe0c5a002037523116014bf270997ef --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index be8dadc..dca33bb 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -78,4 +78,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ifc91733c7fe0c5a002037523116014bf270997ef Gerrit-Change-Number: 14732 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:42:42 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:42:42 +0000 Subject: Change in ...osmo-sgsn[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14736 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14736 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic887518bd149f325a92c3517ee90c655b1368fd8 Gerrit-Change-Number: 14736 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:42:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:42:47 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:42:47 +0000 Subject: Change in ...osmo-sgsn[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14736 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ic887518bd149f325a92c3517ee90c655b1368fd8 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index a9d871f..51583f8 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -77,4 +77,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14736 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic887518bd149f325a92c3517ee90c655b1368fd8 Gerrit-Change-Number: 14736 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:42:52 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:42:52 +0000 Subject: Change in ...osmo-sysmon[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/14738 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/14738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I7b39a97243de93383c77a0e172d737263d48053a Gerrit-Change-Number: 14738 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:42:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:42:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:42:56 +0000 Subject: Change in ...osmo-sysmon[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/14738 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: I7b39a97243de93383c77a0e172d737263d48053a --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 631f95a..ff93c40 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -46,4 +46,5 @@ $MAKE distcheck \ || cat-testlogs.sh +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/14738 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I7b39a97243de93383c77a0e172d737263d48053a Gerrit-Change-Number: 14738 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:43:01 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:43:01 +0000 Subject: Change in ...osmo-sip-connector[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14737 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ie2e181a6e74053c407f7ed3db17631ae041c9754 Gerrit-Change-Number: 14737 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 03:43:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:43:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:43:05 +0000 Subject: Change in ...osmo-sip-connector[master]: contrib/jenkins.sh: run "make maintainer-clean" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14737 ) Change subject: contrib/jenkins.sh: run "make maintainer-clean" ...................................................................... contrib/jenkins.sh: run "make maintainer-clean" Related: OS#3047 Change-Id: Ie2e181a6e74053c407f7ed3db17631ae041c9754 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 579a9b1..6d9a9d9 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -52,4 +52,5 @@ make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14737 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ie2e181a6e74053c407f7ed3db17631ae041c9754 Gerrit-Change-Number: 14737 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 03:46:02 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 11 Jul 2019 03:46:02 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: log_merge.sh: format logs after merging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 ) Change subject: log_merge.sh: format logs after merging ...................................................................... Patch Set 2: Code-Review-1 I don't think it's good to double the size of our build artefacts without any good reason. Having to type "ttcn3_logformat foo.log | less" vs. typing "less foo.log" does not sound like a "good reason" to me, sorry. I'm happy to align with what the majority of the developers thinks, but to me it doesn't really seem to offer much gain. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I671ffa2761c6e503dae9f3b16764d430131b16af Gerrit-Change-Number: 14707 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Jul 2019 03:46:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Thu Jul 11 04:19:26 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 11 Jul 2019 04:19:26 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d26b8d1a3eab_70ce112e5fc563019@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 628s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 628s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 628s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 628s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 628s] make[4]: *** [gb_proxy.o] Error 1 [ 628s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 628s] Makefile:391: recipe for target 'all-recursive' failed [ 628s] make[3]: *** [all-recursive] Error 1 [ 628s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 628s] Makefile:453: recipe for target 'all-recursive' failed [ 628s] make[2]: *** [all-recursive] Error 1 [ 628s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 628s] Makefile:385: recipe for target 'all' failed [ 628s] make[1]: *** [all] Error 2 [ 628s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 628s] dh_auto_build: make -j1 returned exit code 2 [ 628s] debian/rules:45: recipe for target 'build' failed [ 628s] make: *** [build] Error 2 [ 628s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 629s] [ 629s] obs-arm-6 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Thu Jul 11 04:19:07 UTC 2019. [ 629s] [ 629s] ### VM INTERACTION START ### [ 632s] [ 602.406552] sysrq: SysRq : Power Off [ 632s] [ 602.445719] reboot: Power down [ 633s] ### VM INTERACTION END ### [ 633s] [ 633s] obs-arm-6 failed "build osmo-sgsn_1.4.0.27.43c5.dsc" at Thu Jul 11 04:19:12 UTC 2019. [ 633s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Thu Jul 11 04:21:44 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 11 Jul 2019 04:21:44 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d26b96746d88_70ce112e5fc563255@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 788s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 788s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 788s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 788s] Makefile:442: recipe for target 'vlr.o' failed [ 788s] make[4]: *** [vlr.o] Error 1 [ 788s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 788s] Makefile:422: recipe for target 'all-recursive' failed [ 788s] make[3]: *** [all-recursive] Error 1 [ 788s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 788s] Makefile:462: recipe for target 'all-recursive' failed [ 788s] make[2]: *** [all-recursive] Error 1 [ 788s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 788s] Makefile:394: recipe for target 'all' failed [ 788s] make[1]: *** [all] Error 2 [ 788s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 788s] dh_auto_build: make -j1 returned exit code 2 [ 788s] debian/rules:45: recipe for target 'build' failed [ 788s] make: *** [build] Error 2 [ 788s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 788s] [ 788s] obs-arm-5 failed "build osmo-msc_1.3.1.177.09ce3.dsc" at Thu Jul 11 04:21:33 UTC 2019. [ 788s] [ 788s] ### VM INTERACTION START ### [ 791s] [ 746.591961] sysrq: SysRq : Power Off [ 791s] [ 746.602839] reboot: Power down [ 793s] ### VM INTERACTION END ### [ 793s] [ 793s] obs-arm-5 failed "build osmo-msc_1.3.1.177.09ce3.dsc" at Thu Jul 11 04:21:38 UTC 2019. [ 793s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Jul 11 04:57:50 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Thu, 11 Jul 2019 04:57:50 +0000 Subject: Change in ...osmo-bts[master]: Move Access Burst link quality handling to L1SAP In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14687 to look at the new patch set (#4). Change subject: Move Access Burst link quality handling to L1SAP ...................................................................... Move Access Burst link quality handling to L1SAP Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Depends: (libosmocore) Ie2a66ebd040b61d6daf49e04bf8a84d3d64764ee --- M src/common/l1sap.c M src/osmo-bts-litecell15/l1_if.c M src/osmo-bts-oc2g/l1_if.c M src/osmo-bts-sysmo/l1_if.c M src/osmo-bts-trx/scheduler_trx.c M tests/handover/handover_test.c 6 files changed, 19 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/14687/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Gerrit-Change-Number: 14687 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 07:35:45 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 07:35:45 +0000 Subject: Change in ...libosmo-sccp[master]: contrib/jenkins.sh: "maintainer-clean" after "publish" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14748 Change subject: contrib/jenkins.sh: "maintainer-clean" after "publish" ...................................................................... contrib/jenkins.sh: "maintainer-clean" after "publish" Run "make maintainer-clean" after publishing manuals, not the other way around. Otherwise jenkins.sh fails when running for the master branch, because docs/manuals/Makefile gets deleted although it is still needed to publish the manuals. Related: OS#3047 Fixes: 55f03b898a3113f7b73a3abd1c2dfe2edd6135ac ("contrib/jenkins.sh: run "make maintainer-clean"") Change-Id: I8bcee9069743b76966a78e1c13d0be9ba62d992c --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/48/14748/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index da96c5e..23ff522 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -54,10 +54,10 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ $MAKE distcheck \ || cat-testlogs.sh -$MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14748 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8bcee9069743b76966a78e1c13d0be9ba62d992c Gerrit-Change-Number: 14748 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 07:35:53 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 07:35:53 +0000 Subject: Change in ...osmo-bsc[master]: contrib/jenkins.sh: "maintainer-clean" after "publish" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14749 Change subject: contrib/jenkins.sh: "maintainer-clean" after "publish" ...................................................................... contrib/jenkins.sh: "maintainer-clean" after "publish" Run "make maintainer-clean" after publishing manuals, not the other way around. Otherwise jenkins.sh fails when running for the master branch, because docs/manuals/Makefile gets deleted although it is still needed to publish the manuals. Related: OS#3047 Fixes: 471fd92170297f1c857bb448bbf21a162c2ed655 ("contrib/jenkins.sh: run "make maintainer-clean"") Change-Id: I8ba5369b0948b61c68f43d807312c52465119aa5 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/49/14749/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 524971b..73f1174 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -61,10 +61,10 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-vty-tests --enable-external-tests --enable-werror $CONFIG" \ $MAKE distcheck \ || cat-testlogs.sh -$MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14749 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8ba5369b0948b61c68f43d807312c52465119aa5 Gerrit-Change-Number: 14749 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 07:41:48 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 07:41:48 +0000 Subject: Change in ...libusrp[master]: firmware/src/usrp2/Makefile.am: fix "distcheck" Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libusrp/+/14750 Change subject: firmware/src/usrp2/Makefile.am: fix "distcheck" ...................................................................... firmware/src/usrp2/Makefile.am: fix "distcheck" Properly remove lk files to fix the following error during "make distcheck". ERROR: files left in build directory after distclean: ./firmware/src/usrp2/eeprom_boot.lk ./firmware/src/usrp2/std.lk Change-Id: I5f1b1f5ad72112ba7212800da7f85846bb6e7187 --- M firmware/src/usrp2/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libusrp refs/changes/50/14750/1 diff --git a/firmware/src/usrp2/Makefile.am b/firmware/src/usrp2/Makefile.am index 6d44320..52492dc 100644 --- a/firmware/src/usrp2/Makefile.am +++ b/firmware/src/usrp2/Makefile.am @@ -146,7 +146,7 @@ $(XCC) $(LINKOPTS) -o $@ $(USRP_OBJS) CLEANFILES = \ - *.ihx *.lnk *.lst *.map *.mem *.rel *.rst *.sym *.asm *.lib \ + *.ihx *.lnk *.lst *.map *.mem *.rel *.rst *.sym *.asm *.lib *.lk \ usrp_gpif.c usrp_gpif_inline.h \ burn-usrp2-eeprom \ burn-usrp4-eeprom -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/14750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: I5f1b1f5ad72112ba7212800da7f85846bb6e7187 Gerrit-Change-Number: 14750 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 07:44:42 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 07:44:42 +0000 Subject: Change in ...libusrp[master]: firmware/src/usrp2/Makefile.am: fix "distcheck" In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libusrp/+/14750 ) Change subject: firmware/src/usrp2/Makefile.am: fix "distcheck" ...................................................................... Patch Set 1: "make distcheck" is enabled with this follow-up commit, and it passes on jenkins: https://gerrit.osmocom.org/c/libusrp/+/14722 -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/14750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: I5f1b1f5ad72112ba7212800da7f85846bb6e7187 Gerrit-Change-Number: 14750 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Jul 2019 07:44:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 07:46:32 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 07:46:32 +0000 Subject: Change in ...osmo-bsc[master]: contrib/jenkins.sh: "maintainer-clean" after "publish" In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14749 ) Change subject: contrib/jenkins.sh: "maintainer-clean" after "publish" ...................................................................... Patch Set 1: Code-Review+2 This is a trivial and urgent fix for making jenkins.sh work again on master, therefore giving this a +2 myself. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14749 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8ba5369b0948b61c68f43d807312c52465119aa5 Gerrit-Change-Number: 14749 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Jul 2019 07:46:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 07:46:40 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 07:46:40 +0000 Subject: Change in ...osmo-bsc[master]: contrib/jenkins.sh: "maintainer-clean" after "publish" In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14749 ) Change subject: contrib/jenkins.sh: "maintainer-clean" after "publish" ...................................................................... contrib/jenkins.sh: "maintainer-clean" after "publish" Run "make maintainer-clean" after publishing manuals, not the other way around. Otherwise jenkins.sh fails when running for the master branch, because docs/manuals/Makefile gets deleted although it is still needed to publish the manuals. Related: OS#3047 Fixes: 471fd92170297f1c857bb448bbf21a162c2ed655 ("contrib/jenkins.sh: run "make maintainer-clean"") Change-Id: I8ba5369b0948b61c68f43d807312c52465119aa5 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 524971b..73f1174 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -61,10 +61,10 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-vty-tests --enable-external-tests --enable-werror $CONFIG" \ $MAKE distcheck \ || cat-testlogs.sh -$MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14749 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8ba5369b0948b61c68f43d807312c52465119aa5 Gerrit-Change-Number: 14749 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 07:46:55 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 07:46:55 +0000 Subject: Change in ...libosmo-sccp[master]: contrib/jenkins.sh: "maintainer-clean" after "publish" In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14748 ) Change subject: contrib/jenkins.sh: "maintainer-clean" after "publish" ...................................................................... Patch Set 1: Code-Review+2 This is a trivial and urgent fix for making jenkins.sh work again on master, therefore giving this a +2 myself. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14748 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8bcee9069743b76966a78e1c13d0be9ba62d992c Gerrit-Change-Number: 14748 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Jul 2019 07:46:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 07:47:03 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 07:47:03 +0000 Subject: Change in ...libosmo-sccp[master]: contrib/jenkins.sh: "maintainer-clean" after "publish" In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14748 ) Change subject: contrib/jenkins.sh: "maintainer-clean" after "publish" ...................................................................... contrib/jenkins.sh: "maintainer-clean" after "publish" Run "make maintainer-clean" after publishing manuals, not the other way around. Otherwise jenkins.sh fails when running for the master branch, because docs/manuals/Makefile gets deleted although it is still needed to publish the manuals. Related: OS#3047 Fixes: 55f03b898a3113f7b73a3abd1c2dfe2edd6135ac ("contrib/jenkins.sh: run "make maintainer-clean"") Change-Id: I8bcee9069743b76966a78e1c13d0be9ba62d992c --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index da96c5e..23ff522 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -54,10 +54,10 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-external-tests $CONFIG" \ $MAKE distcheck \ || cat-testlogs.sh -$MAKE maintainer-clean if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then make -C "$base/doc/manuals" publish fi +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14748 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I8bcee9069743b76966a78e1c13d0be9ba62d992c Gerrit-Change-Number: 14748 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 08:37:41 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 08:37:41 +0000 Subject: Change in ...docker-playground[master]: ttcn3-*: enable GSMTAP logging In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14712 ) Change subject: ttcn3-*: enable GSMTAP logging ...................................................................... ttcn3-*: enable GSMTAP logging Configure each osmo-* program to send GSMTAP log output to the IP of the docker container, which runs the testsuite (and therefore runs tcpdump). Related: https://lists.osmocom.org/pipermail/openbsc/2019-June/012946.html Change-Id: I99e74f6ffb5b7d566cec35995bf067df414968d8 --- M ttcn3-bsc-test/osmo-bsc.cfg M ttcn3-bsc-test/osmo-stp.cfg M ttcn3-bsc-test/sccplite/osmo-bsc.cfg M ttcn3-bscnat-test/osmo-bsc-nat.cfg M ttcn3-bts-test/oml/osmo-bts.cfg M ttcn3-bts-test/osmo-bsc.cfg M ttcn3-bts-test/osmo-bts.cfg M ttcn3-bts-test/virtphy/osmo-bts.cfg M ttcn3-ggsn-test/osmo-ggsn.cfg M ttcn3-hlr-test/osmo-hlr.cfg M ttcn3-mgw-test/osmo-mgw.cfg M ttcn3-msc-test/osmo-msc.cfg M ttcn3-msc-test/osmo-stp.cfg M ttcn3-pcu-test/osmo-pcu.cfg M ttcn3-pcu-test/sns/osmo-pcu.cfg M ttcn3-sgsn-test/osmo-sgsn.cfg M ttcn3-sip-test/osmo-sip-connector.cfg 17 files changed, 51 insertions(+), 0 deletions(-) Approvals: osmith: Verified Hoernchen: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ttcn3-bsc-test/osmo-bsc.cfg b/ttcn3-bsc-test/osmo-bsc.cfg index 783563a..3d226e9 100644 --- a/ttcn3-bsc-test/osmo-bsc.cfg +++ b/ttcn3-bsc-test/osmo-bsc.cfg @@ -3,6 +3,9 @@ !! password foo ! +log gsmtap 172.18.2.203 + logging level set-all debug +! log file /data/osmo-bsc.log logging filter all 1 logging color 0 diff --git a/ttcn3-bsc-test/osmo-stp.cfg b/ttcn3-bsc-test/osmo-stp.cfg index 7cee48b..f58fe64 100644 --- a/ttcn3-bsc-test/osmo-stp.cfg +++ b/ttcn3-bsc-test/osmo-stp.cfg @@ -2,6 +2,9 @@ ! OsmoSTP (0.8.1) configuration saved from vty !! ! +log gsmtap 172.18.2.203 + logging level set-all debug +! log file /data/osmo-stp.log logging filter all 1 logging color 0 diff --git a/ttcn3-bsc-test/sccplite/osmo-bsc.cfg b/ttcn3-bsc-test/sccplite/osmo-bsc.cfg index 3f29361..f7d640c 100644 --- a/ttcn3-bsc-test/sccplite/osmo-bsc.cfg +++ b/ttcn3-bsc-test/sccplite/osmo-bsc.cfg @@ -3,6 +3,9 @@ !! password foo ! +log gsmtap 172.18.12.203 + logging level set-all debug +! log file /data/osmo-bsc.log logging filter all 1 logging color 0 diff --git a/ttcn3-bscnat-test/osmo-bsc-nat.cfg b/ttcn3-bscnat-test/osmo-bsc-nat.cfg index 80d7095..66ecdc9 100644 --- a/ttcn3-bscnat-test/osmo-bsc-nat.cfg +++ b/ttcn3-bscnat-test/osmo-bsc-nat.cfg @@ -2,6 +2,9 @@ ! OsmoBSCNAT (0.12.0.266-2daa9) configuration saved from vty !! ! +log gsmtap 172.18.15.203 + logging level set-all debug +! log file /data/osmo-bsc_nat.log logging filter all 1 logging color 0 diff --git a/ttcn3-bts-test/oml/osmo-bts.cfg b/ttcn3-bts-test/oml/osmo-bts.cfg index 4ed1951..562440b 100644 --- a/ttcn3-bts-test/oml/osmo-bts.cfg +++ b/ttcn3-bts-test/oml/osmo-bts.cfg @@ -2,6 +2,9 @@ ! OsmoBTS (0.4.0.446-e0fb) configuration saved from vty !! ! +log gsmtap 172.18.9.10 + logging level set-all debug +! log file /data/osmo-bts.log logging filter all 1 logging color 0 diff --git a/ttcn3-bts-test/osmo-bsc.cfg b/ttcn3-bts-test/osmo-bsc.cfg index e98cc57..b2a45bc 100644 --- a/ttcn3-bts-test/osmo-bsc.cfg +++ b/ttcn3-bts-test/osmo-bsc.cfg @@ -3,6 +3,9 @@ !! password foo ! +log gsmtap 172.18.9.10 + logging level set-all debug +! log file /data/osmo-bsc.log logging filter all 1 logging color 0 diff --git a/ttcn3-bts-test/osmo-bts.cfg b/ttcn3-bts-test/osmo-bts.cfg index 611355b..11afc0d 100644 --- a/ttcn3-bts-test/osmo-bts.cfg +++ b/ttcn3-bts-test/osmo-bts.cfg @@ -2,6 +2,9 @@ ! OsmoBTS (0.4.0.446-e0fb) configuration saved from vty !! ! +log gsmtap 172.18.9.10 + logging level set-all debug +! log file /data/osmo-bts.log logging filter all 1 logging color 0 diff --git a/ttcn3-bts-test/virtphy/osmo-bts.cfg b/ttcn3-bts-test/virtphy/osmo-bts.cfg index 5957f03..540dcc3 100644 --- a/ttcn3-bts-test/virtphy/osmo-bts.cfg +++ b/ttcn3-bts-test/virtphy/osmo-bts.cfg @@ -2,6 +2,9 @@ ! OsmoBTS (0.4.0.446-e0fb) configuration saved from vty !! ! +log gsmtap 172.18.9.10 + logging level set-all debug +! log file /data/osmo-bts.log logging filter all 1 logging color 0 diff --git a/ttcn3-ggsn-test/osmo-ggsn.cfg b/ttcn3-ggsn-test/osmo-ggsn.cfg index ddbbf6c..fd1ea95 100644 --- a/ttcn3-ggsn-test/osmo-ggsn.cfg +++ b/ttcn3-ggsn-test/osmo-ggsn.cfg @@ -2,6 +2,9 @@ ! OpenGGSN (0.94.1-adac) configuration saved from vty !! ! +log gsmtap 172.18.3.202 + logging level set-all debug +! log file /data/osmo-ggsn.log logging filter all 1 logging color 0 diff --git a/ttcn3-hlr-test/osmo-hlr.cfg b/ttcn3-hlr-test/osmo-hlr.cfg index 47bbd23..57c1701 100644 --- a/ttcn3-hlr-test/osmo-hlr.cfg +++ b/ttcn3-hlr-test/osmo-hlr.cfg @@ -1,6 +1,9 @@ ! ! OsmoHLR example configuration ! +log gsmtap 172.18.10.103 + logging level set-all debug +! log stderr logging filter all 1 logging color 1 diff --git a/ttcn3-mgw-test/osmo-mgw.cfg b/ttcn3-mgw-test/osmo-mgw.cfg index 882c7d0..86645ba 100644 --- a/ttcn3-mgw-test/osmo-mgw.cfg +++ b/ttcn3-mgw-test/osmo-mgw.cfg @@ -2,6 +2,9 @@ ! OsmoMGW (1.2.0.17-52e3) configuration saved from vty !! ! +log gsmtap 172.18.4.181 + logging level set-all debug +! log stderr logging filter all 1 logging color 1 diff --git a/ttcn3-msc-test/osmo-msc.cfg b/ttcn3-msc-test/osmo-msc.cfg index db2029c..98a1a01 100644 --- a/ttcn3-msc-test/osmo-msc.cfg +++ b/ttcn3-msc-test/osmo-msc.cfg @@ -2,6 +2,9 @@ ! OsmoMSC (1.1.2.66-629c4-dirty) configuration saved from vty !! ! +log gsmtap 172.18.1.103 + logging level set-all debug +! log file /data/osmo-msc.log logging filter all 1 logging color 0 diff --git a/ttcn3-msc-test/osmo-stp.cfg b/ttcn3-msc-test/osmo-stp.cfg index cefaef1..1310be2 100644 --- a/ttcn3-msc-test/osmo-stp.cfg +++ b/ttcn3-msc-test/osmo-stp.cfg @@ -2,6 +2,9 @@ ! OsmoSTP (0.8.1) configuration saved from vty !! ! +log gsmtap 172.18.1.103 + logging level set-all debug +! log file /data/osmo-stp.log logging filter all 1 logging color 0 diff --git a/ttcn3-pcu-test/osmo-pcu.cfg b/ttcn3-pcu-test/osmo-pcu.cfg index e8a8552..ed31269 100644 --- a/ttcn3-pcu-test/osmo-pcu.cfg +++ b/ttcn3-pcu-test/osmo-pcu.cfg @@ -1,3 +1,6 @@ +log gsmtap 172.18.13.10 + logging level set-all debug + log file /data/osmo-pcu.log logging filter all 1 logging color 0 diff --git a/ttcn3-pcu-test/sns/osmo-pcu.cfg b/ttcn3-pcu-test/sns/osmo-pcu.cfg index f9bce3a..b7c57d1 100644 --- a/ttcn3-pcu-test/sns/osmo-pcu.cfg +++ b/ttcn3-pcu-test/sns/osmo-pcu.cfg @@ -1,3 +1,6 @@ +log gsmtap 172.18.14.10 + logging level set-all debug + log file /data/osmo-pcu.log logging filter all 1 logging color 0 diff --git a/ttcn3-sgsn-test/osmo-sgsn.cfg b/ttcn3-sgsn-test/osmo-sgsn.cfg index 37f4ed8..996d251 100644 --- a/ttcn3-sgsn-test/osmo-sgsn.cfg +++ b/ttcn3-sgsn-test/osmo-sgsn.cfg @@ -2,6 +2,9 @@ ! OsmoSGSN (1.2.0.46-e77e-dirty) configuration saved from vty !! ! +log gsmtap 172.18.8.103 + logging level set-all debug +! log stderr logging filter all 1 logging color 1 diff --git a/ttcn3-sip-test/osmo-sip-connector.cfg b/ttcn3-sip-test/osmo-sip-connector.cfg index 5df7468..efdee58 100644 --- a/ttcn3-sip-test/osmo-sip-connector.cfg +++ b/ttcn3-sip-test/osmo-sip-connector.cfg @@ -2,6 +2,9 @@ ! OsmoMNCC (1.1.0-dirty) configuration saved from vty !! ! +log gsmtap 172.18.11.103 + logging level set-all debug +! log file /data/osmo-sip-connector.log logging filter all 1 logging color 0 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I99e74f6ffb5b7d566cec35995bf067df414968d8 Gerrit-Change-Number: 14712 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 08:47:54 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 08:47:54 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: log_merge.sh: format logs after merging In-Reply-To: References: Message-ID: osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 ) Change subject: log_merge.sh: format logs after merging ...................................................................... Abandoned Ok, fine with me. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14707 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I671ffa2761c6e503dae9f3b16764d430131b16af Gerrit-Change-Number: 14707 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 09:07:50 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 09:07:50 +0000 Subject: Change in ...osmo-ci[master]: gerrit-verifications: add libtelnet Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14751 Change subject: gerrit-verifications: add libtelnet ...................................................................... gerrit-verifications: add libtelnet Related: OS#3047 Change-Id: Iafffd9d938ee310bb729b3e2a0a4d80870d4b3b5 --- M jobs/gerrit-verifications.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/51/14751/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index fd9fec3..a696d86 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -55,6 +55,7 @@ cmd: './contrib/jenkins_arch.sh "$arch"' - libsmpp34 + - libtelnet - libusrp - openbsc: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14751 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iafffd9d938ee310bb729b3e2a0a4d80870d4b3b5 Gerrit-Change-Number: 14751 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 09:07:50 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 09:07:50 +0000 Subject: Change in ...osmo-ci[master]: jobs/master-builds: libosmo-dsp: use jenkins.sh Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14752 Change subject: jobs/master-builds: libosmo-dsp: use jenkins.sh ...................................................................... jobs/master-builds: libosmo-dsp: use jenkins.sh Be consistent with other Osmocom repositories by using a contrib/jenkins.sh script for continuous integration testing. Depends: 56d60f52960171e4de340f24abefd33fba3ae961 in libosmo-dsp.git ("contrib/jenkins.sh: add jenkins build script") Related: OS#3047 Change-Id: I05c597c0806a2e14665c0e073ea7ffb0cac8761d --- M jobs/master-builds.yml 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/52/14752/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 373e975..8c4b05c 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -50,11 +50,6 @@ master-libosmo-netif, master-osmo-bts - libosmo-dsp: - cmd: | - autoreconf --install --force - ./configure - $MAKE $PARALLEL_MAKE - $MAKE distcheck trigger: master-osmo-gmr email: gerrit-log at lists.osmocom.org laforge at gnumonks.org 246tnt at gmail.com -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14752 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I05c597c0806a2e14665c0e073ea7ffb0cac8761d Gerrit-Change-Number: 14752 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 09:08:15 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 09:08:15 +0000 Subject: Change in ...osmo-ci[master]: jobs/master-builds: libosmo-dsp: use jenkins.sh In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14752 ) Change subject: jobs/master-builds: libosmo-dsp: use jenkins.sh ...................................................................... Patch Set 1: Setting to WIP until the libosmo-dsp patch is merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14752 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I05c597c0806a2e14665c0e073ea7ffb0cac8761d Gerrit-Change-Number: 14752 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Jul 2019 09:08:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 09:23:46 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 09:23:46 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: add check IMEI tests In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 ) Change subject: msc: add check IMEI tests ...................................................................... Patch Set 3: Vadim, if you have time it would be great if you could take another look at this. Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d Gerrit-Change-Number: 14694 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Jul 2019 09:23:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 10:06:36 2019 From: gerrit-no-reply at lists.osmocom.org (ipse) Date: Thu, 11 Jul 2019 10:06:36 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling In-Reply-To: References: Message-ID: ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 ) Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Patch Set 4: Code-Review-1 > This value is an estimation based on very few samples, thus it is very "noisy" and we don't need that much precision. This is only correct for the specific implementation we currently have in osmo-trx. That implementation is a bit of a quick fix and thus has these limitations. A proper implementation involving equalizer and channel estimation can give much more precise result. Also, other BTS models may have more precise C/I estimators. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 10:06:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 10:08:39 2019 From: gerrit-no-reply at lists.osmocom.org (ipse) Date: Thu, 11 Jul 2019 10:08:39 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message In-Reply-To: References: Message-ID: ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14685 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 Gerrit-Change-Number: 14685 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 10:08:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 10:11:22 2019 From: gerrit-no-reply at lists.osmocom.org (ipse) Date: Thu, 11 Jul 2019 10:11:22 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX In-Reply-To: References: Message-ID: ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14684 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14684/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14684/1/src/osmo-bts-trx/scheduler_trx.c at 796 PS1, Line 796: /* Handover RACH cannot be extended (11-bit) */ > As you noticed, I am changing the content, but not the meaning of this 'if'. [?] Ok, please change in a separate patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1e654a2e49cb83c5f1e6249c0de688f99bc466b0 Gerrit-Change-Number: 14684 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 11 Jul 2019 10:11:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy Comment-In-Reply-To: ipse Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 10:50:21 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 11 Jul 2019 10:50:21 +0000 Subject: Change in ...libosmo-abis[master]: extend the ipa keepalive fsm In-Reply-To: References: Message-ID: Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/14742 to look at the new patch set (#2). Change subject: extend the ipa keepalive fsm ...................................................................... extend the ipa keepalive fsm The new and improved fsm supports multipe use cases: 1) plain old ipa server/client operation 2) ipa client/server operation with custom send callback (i.e. to bypass the tx queue) 3) all of the above + custom timeout callback 4) fully generic operation that will pass opaque data to the callbacks The current code will always kill the fsm and deallocate it upon timeout, so the timeout callback will now return a value: 1 means the fsm will be automatically terminated, 0 means no action, which allows manually stopping/starting the fsm to reuse it. Change-Id: Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b --- M include/osmocom/abis/ipa.h M src/input/ipa_keepalive.c 2 files changed, 58 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/42/14742/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14742 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b Gerrit-Change-Number: 14742 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 10:50:21 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 11 Jul 2019 10:50:21 +0000 Subject: Change in ...libosmo-abis[master]: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 to look at the new patch set (#2). Change subject: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc ...................................................................... add ipa pingp/pong keepalive for OML/RSL links between bts and bsc Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a --- M include/osmocom/abis/e1_input.h M src/e1_input_vty.c M src/input/ipaccess.c 3 files changed, 186 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/43/14743/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a Gerrit-Change-Number: 14743 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 10:50:35 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 11 Jul 2019 10:50:35 +0000 Subject: Change in ...osmo-hlr[master]: add keepalive for gsup client/server, osmo-hlr In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/14741 to look at the new patch set (#2). Change subject: add keepalive for gsup client/server, osmo-hlr ...................................................................... add keepalive for gsup client/server, osmo-hlr Change-Id: I01654d4a023e76a2b9245817a0096148c8bd44c1 Depends: (libosmo-abis) Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b --- M doc/manuals/vty/hlr_vty_reference.xml M include/osmocom/gsupclient/gsup_client.h M src/gsup_server.c M src/gsup_server.h M src/gsupclient/gsup_client.c M src/gsupclient/gsup_test_client.c M src/hlr.c M src/hlr.h M src/hlr_vty.c M src/osmo-euse-demo.c 10 files changed, 110 insertions(+), 61 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/41/14741/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14741 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I01654d4a023e76a2b9245817a0096148c8bd44c1 Gerrit-Change-Number: 14741 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 11:27:22 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 11 Jul 2019 11:27:22 +0000 Subject: Change in ...libosmo-abis[master]: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 to look at the new patch set (#3). Change subject: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc ...................................................................... add ipa pingp/pong keepalive for OML/RSL links between bts and bsc Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a --- M TODO-RELEASE M include/osmocom/abis/e1_input.h M src/e1_input_vty.c M src/input/ipaccess.c 4 files changed, 187 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/43/14743/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a Gerrit-Change-Number: 14743 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 11:51:21 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 11 Jul 2019 11:51:21 +0000 Subject: Change in ...meta-telephony[201705]: Add recipe for osmo-pcap, both server and client In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/3534 ) Change subject: Add recipe for osmo-pcap, both server and client ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Just noticed the typo, otherwise fine https://gerrit.osmocom.org/#/c/3534/2/recipes-osmocom/osmo-pcap/osmo-pcap.inc File recipes-osmocom/osmo-pcap/osmo-pcap.inc: https://gerrit.osmocom.org/#/c/3534/2/recipes-osmocom/osmo-pcap/osmo-pcap.inc at 1 PS2, Line 1: clint client -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/3534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I5bb85b118029d1559a958803184690a9d0f23e4a Gerrit-Change-Number: 3534 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Assignee: pespin Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Max Gerrit-Comment-Date: Thu, 11 Jul 2019 11:51:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 12:22:19 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 11 Jul 2019 12:22:19 +0000 Subject: Change in ...osmo-msc[master]: add ipa keepalive for gsup connections to the hlr Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14753 Change subject: add ipa keepalive for gsup connections to the hlr ...................................................................... add ipa keepalive for gsup connections to the hlr Change-Id: I7d0beb9357ab9b1baeb030d726f312008f2fc533 --- M doc/manuals/vty/msc_vty_reference.xml M include/osmocom/msc/gsm_data.h M include/osmocom/msc/gsup_client_mux.h M src/libmsc/gsup_client_mux.c M src/libmsc/msc_net_init.c M src/libmsc/msc_vty.c 6 files changed, 36 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/53/14753/1 diff --git a/doc/manuals/vty/msc_vty_reference.xml b/doc/manuals/vty/msc_vty_reference.xml index 0e5d04d..7f7b753 100644 --- a/doc/manuals/vty/msc_vty_reference.xml +++ b/doc/manuals/vty/msc_vty_reference.xml @@ -2796,6 +2796,13 @@ + + + + + + + config-sgs diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h index f6e3ed9..20176ad 100644 --- a/include/osmocom/msc/gsm_data.h +++ b/include/osmocom/msc/gsm_data.h @@ -235,6 +235,8 @@ /* Whether we want to use Osmux against BSCs. Controlled via VTY */ enum osmux_usage use_osmux; + + struct ipa_keepalive_params *ka_params; }; struct osmo_esme; diff --git a/include/osmocom/msc/gsup_client_mux.h b/include/osmocom/msc/gsup_client_mux.h index 07f17c2..46dfee9 100644 --- a/include/osmocom/msc/gsup_client_mux.h +++ b/include/osmocom/msc/gsup_client_mux.h @@ -5,6 +5,7 @@ struct gsup_client_mux; struct ipaccess_unit; +struct ipa_keepalive_params; struct gsup_client_mux_rx_cb { int (* func )(struct gsup_client_mux *gcm, void *data, const struct osmo_gsup_message *gsup_msg); @@ -25,7 +26,7 @@ struct gsup_client_mux *gsup_client_mux_alloc(void *talloc_ctx); int gsup_client_mux_start(struct gsup_client_mux *gcm, const char *gsup_server_addr_str, uint16_t gsup_server_port, - struct ipaccess_unit *ipa_dev); + struct ipaccess_unit *ipa_dev, struct ipa_keepalive_params *kap); int gsup_client_mux_tx(struct gsup_client_mux *gcm, const struct osmo_gsup_message *gsup_msg); void gsup_client_mux_tx_error_reply(struct gsup_client_mux *gcm, const struct osmo_gsup_message *gsup_orig, diff --git a/src/libmsc/gsup_client_mux.c b/src/libmsc/gsup_client_mux.c index e425651..b9ee285 100644 --- a/src/libmsc/gsup_client_mux.c +++ b/src/libmsc/gsup_client_mux.c @@ -108,12 +108,12 @@ /* Start a GSUP client to serve this gsup_client_mux. */ int gsup_client_mux_start(struct gsup_client_mux *gcm, const char *gsup_server_addr_str, uint16_t gsup_server_port, - struct ipaccess_unit *ipa_dev) + struct ipaccess_unit *ipa_dev, struct ipa_keepalive_params *kap) { gcm->gsup_client = osmo_gsup_client_create2(gcm, ipa_dev, gsup_server_addr_str, gsup_server_port, - &gsup_client_mux_rx, NULL); + &gsup_client_mux_rx, NULL, kap); if (!gcm->gsup_client) return -ENOMEM; gcm->gsup_client->data = gcm; diff --git a/src/libmsc/msc_net_init.c b/src/libmsc/msc_net_init.c index 4a752bf..3b05e65 100644 --- a/src/libmsc/msc_net_init.c +++ b/src/libmsc/msc_net_init.c @@ -122,5 +122,5 @@ }, }; - return gsup_client_mux_start(net->gcm, net->gsup_server_addr_str, net->gsup_server_port, ipa_dev); + return gsup_client_mux_start(net->gcm, net->gsup_server_addr_str, net->gsup_server_port, ipa_dev, net->ka_params); } diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c index 8a976cb..1068de1 100644 --- a/src/libmsc/msc_vty.c +++ b/src/libmsc/msc_vty.c @@ -34,6 +34,8 @@ #include #include +#include + #include #include @@ -1846,6 +1848,22 @@ return CMD_SUCCESS; } +DEFUN(cfg_hlr_gsup_keepalive, + cfg_hlr_gsup_keepalive_cmd, + "keepalive <0-300> <1-300>", + "Enable keepalive probing\n" + "Idle interval in seconds before probes are sent, 0 disables keepalive\n" + "Timeout waiting for PONG response\n") +{ + if (atoi(argv[0]) > 0) { + gsmnet->ka_params = talloc_zero(gsmnet, struct ipa_keepalive_params); + gsmnet->ka_params->interval = atoi(argv[0]); + gsmnet->ka_params->wait_for_resp = atoi(argv[1]); + } + + return CMD_SUCCESS; +} + static int config_write_hlr(struct vty *vty) { vty_out(vty, "hlr%s", VTY_NEWLINE); @@ -1855,6 +1873,9 @@ gsmnet->gsup_server_port, VTY_NEWLINE); if (gsmnet->msc_ipa_name) vty_out(vty, " ipa-name %s%s", gsmnet->msc_ipa_name, VTY_NEWLINE); + if (gsmnet->ka_params) + vty_out(vty, " keepalive %d %d%s", gsmnet->ka_params->interval, + gsmnet->ka_params->wait_for_resp, VTY_NEWLINE); return CMD_SUCCESS; } @@ -1956,4 +1977,5 @@ install_element(HLR_NODE, &cfg_hlr_remote_ip_cmd); install_element(HLR_NODE, &cfg_hlr_remote_port_cmd); install_element(HLR_NODE, &cfg_hlr_ipa_name_cmd); + install_element(HLR_NODE, &cfg_hlr_gsup_keepalive_cmd); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14753 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7d0beb9357ab9b1baeb030d726f312008f2fc533 Gerrit-Change-Number: 14753 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 13:04:03 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Thu, 11 Jul 2019 13:04:03 +0000 Subject: Change in ...osmo-bts[master]: Move Access Burst link quality handling to L1SAP In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14687 to look at the new patch set (#5). Change subject: Move Access Burst link quality handling to L1SAP ...................................................................... Move Access Burst link quality handling to L1SAP Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Depends: (libosmocore) Ie2a66ebd040b61d6daf49e04bf8a84d3d64764ee --- M src/common/l1sap.c M src/osmo-bts-litecell15/l1_if.c M src/osmo-bts-oc2g/l1_if.c M src/osmo-bts-sysmo/l1_if.c M src/osmo-bts-trx/scheduler_trx.c M tests/handover/handover_test.c 6 files changed, 19 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/14687/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Gerrit-Change-Number: 14687 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 13:05:57 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Thu, 11 Jul 2019 13:05:57 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 ) Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Patch Set 4: > This is only correct for the specific implementation we currently have in osmo-trx [...] Should I just change the commit message? Or are you against using int16_t instead of float too? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 13:05:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 13:33:58 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 11 Jul 2019 13:33:58 +0000 Subject: Change in ...libosmo-abis[master]: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 to look at the new patch set (#4). Change subject: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc ...................................................................... add ipa pingp/pong keepalive for OML/RSL links between bts and bsc Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a Depends: (libosmo-abis) Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b --- M TODO-RELEASE M include/osmocom/abis/e1_input.h M src/e1_input_vty.c M src/input/ipaccess.c 4 files changed, 187 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/43/14743/4 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a Gerrit-Change-Number: 14743 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 13:34:42 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 11 Jul 2019 13:34:42 +0000 Subject: Change in ...osmo-msc[master]: add ipa keepalive for gsup connections to the hlr In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/14753 to look at the new patch set (#2). Change subject: add ipa keepalive for gsup connections to the hlr ...................................................................... add ipa keepalive for gsup connections to the hlr Change-Id: I7d0beb9357ab9b1baeb030d726f312008f2fc533 Depends: (libosmo-abis) Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b --- M doc/manuals/vty/msc_vty_reference.xml M include/osmocom/msc/gsm_data.h M include/osmocom/msc/gsup_client_mux.h M src/libmsc/gsup_client_mux.c M src/libmsc/msc_net_init.c M src/libmsc/msc_vty.c 6 files changed, 36 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/53/14753/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14753 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7d0beb9357ab9b1baeb030d726f312008f2fc533 Gerrit-Change-Number: 14753 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 13:37:53 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 13:37:53 +0000 Subject: Change in ...docker-playground[master]: osmocom-bb-host-master: install python-enum as fake_trx dependency Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14754 Change subject: osmocom-bb-host-master: install python-enum as fake_trx dependency ...................................................................... osmocom-bb-host-master: install python-enum as fake_trx dependency 62825cc8eb4e26d58d32a0af72b17256b185af61 (osmocom-bb) started to use the python module enum which not part of the standard libary of python 2. Change-Id: I70b7f1b43a1e121114a924c09614d6eddc801881 --- M osmocom-bb-host-master/Dockerfile 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/54/14754/1 diff --git a/osmocom-bb-host-master/Dockerfile b/osmocom-bb-host-master/Dockerfile index a4c8c16..1d79f06 100644 --- a/osmocom-bb-host-master/Dockerfile +++ b/osmocom-bb-host-master/Dockerfile @@ -13,10 +13,11 @@ rm /tmp/Release.key && \ echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list +# python-enum34 is a dependecy of fake_trx as long we're using python2 ADD $OSMOCOM_REPO/Release /tmp/Release RUN apt-get update && \ apt-get install -y --no-install-recommends \ - libosmocore-dev && \ + libosmocore-dev python-enum34 && \ apt-get clean WORKDIR /tmp -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I70b7f1b43a1e121114a924c09614d6eddc801881 Gerrit-Change-Number: 14754 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 13:59:15 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Thu, 11 Jul 2019 13:59:15 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: add check IMEI tests In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 ) Change subject: msc: add check IMEI tests ...................................................................... Patch Set 3: Code-Review+1 Fine by me ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d Gerrit-Change-Number: 14694 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 11 Jul 2019 13:59:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:02:31 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Thu, 11 Jul 2019 14:02:31 +0000 Subject: Change in ...docker-playground[master]: osmocom-bb-host-master: install python-enum as fake_trx dependency In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14754 ) Change subject: osmocom-bb-host-master: install python-enum as fake_trx dependency ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I70b7f1b43a1e121114a924c09614d6eddc801881 Gerrit-Change-Number: 14754 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Thu, 11 Jul 2019 14:02:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:05:29 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 14:05:29 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: fix TC_lu_by_imei Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 Change subject: msc: fix TC_lu_by_imei ...................................................................... msc: fix TC_lu_by_imei Explicitly state the kind of ID request we want to ignore in the TC_lu_by_imei test. This prevents the following dynamic test case error: Performing a valueof or send operation on a non-specific template of enumerated type @L3_Templates.CmIdentityType. This is fine for the test case in question. However I am not sure how it would be possible to check for tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req(?) with the CmIdentityType enum that we have now. If this becomes a problem in the future, we might need to revert that commit and simply not use an enum for the Identity Type. Fixes: 328984591372ad5abf51655a51d45d880bfed182 ("L3_Templates: add enum CmIdentityType") Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b --- M msc/MSC_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/14755/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 6f9eecd..f21002d 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -781,10 +781,10 @@ if (pars.ran_is_geran) { BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); } - /* wait for LU reject, ignore any ID REQ */ + /* wait for LU reject, ignore IMSI ID REQ */ alt { [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { } - [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req)) { repeat; } + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req(CM_ID_TYPE_IMSI))) { repeat; } } /* wait for normal teardown */ f_expect_clear(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b Gerrit-Change-Number: 14755 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:06:07 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 11 Jul 2019 14:06:07 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: fix TC_lu_by_imei In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 to look at the new patch set (#2). Change subject: msc: fix TC_lu_by_imei ...................................................................... msc: fix TC_lu_by_imei Explicitly state the kind of ID request we want to ignore in the TC_lu_by_imei test. This prevents the following dynamic test case error: Performing a valueof or send operation on a non-specific template of enumerated type @L3_Templates.CmIdentityType. This is fine for the test case in question. However I am not sure how it would be possible to check for tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req(?)) with the CmIdentityType enum that we have now. If this becomes a problem in the future, we might need to revert that commit and simply not use an enum for the Identity Type. Fixes: 328984591372ad5abf51655a51d45d880bfed182 ("L3_Templates: add enum CmIdentityType") Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b --- M msc/MSC_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/14755/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b Gerrit-Change-Number: 14755 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:14:44 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 14:14:44 +0000 Subject: Change in ...osmocom-bb[master]: firmware/solve_envs.py: make it compatible with python3 Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14756 Change subject: firmware/solve_envs.py: make it compatible with python3 ...................................................................... firmware/solve_envs.py: make it compatible with python3 Change-Id: I711df515012f5542de5e5008c8fe4e601609759e --- M src/target/firmware/solve_envs.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/56/14756/1 diff --git a/src/target/firmware/solve_envs.py b/src/target/firmware/solve_envs.py index 0e5f5e8..d4cee80 100755 --- a/src/target/firmware/solve_envs.py +++ b/src/target/firmware/solve_envs.py @@ -34,7 +34,7 @@ envs = solve(board_envs, app_envs) # Result - print ' '.join(envs) + print(' '.join(envs)) if __name__ == '__main__': -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14756 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I711df515012f5542de5e5008c8fe4e601609759e Gerrit-Change-Number: 14756 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:14:45 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 14:14:45 +0000 Subject: Change in ...osmocom-bb[master]: target_dsp/bin2cfile.py: make it compatible with python3 Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14757 Change subject: target_dsp/bin2cfile.py: make it compatible with python3 ...................................................................... target_dsp/bin2cfile.py: make it compatible with python3 Change-Id: I2659c2e4633bd120cc6cd76942eff5b66d2057bb --- M src/target_dsp/calypso/bin2cfile.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/57/14757/1 diff --git a/src/target_dsp/calypso/bin2cfile.py b/src/target_dsp/calypso/bin2cfile.py index 9456a6a..4d5a193 100755 --- a/src/target_dsp/calypso/bin2cfile.py +++ b/src/target_dsp/calypso/bin2cfile.py @@ -31,7 +31,7 @@ name = filename.split('.',1)[0] # Header / footer - print """ + print(""" #define _SA_DECL (const uint16_t *)&(const uint16_t []) static const struct dsp_section %s[] = { @@ -50,7 +50,7 @@ }; #undef _SA_DECL -""" % (name, len(d)/2, ops) +""" % (name, len(d)/2, ops)) if __name__ == "__main__": -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14757 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2659c2e4633bd120cc6cd76942eff5b66d2057bb Gerrit-Change-Number: 14757 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:14:45 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 14:14:45 +0000 Subject: Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3 Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14758 Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 ...................................................................... fb_tools/bdf_to_c.py: make it compatible with python3 Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 --- M src/host/fb_tools/bdf_to_c.py 1 file changed, 32 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/58/14758/1 diff --git a/src/host/fb_tools/bdf_to_c.py b/src/host/fb_tools/bdf_to_c.py index 86be6a6..81b3b44 100755 --- a/src/host/fb_tools/bdf_to_c.py +++ b/src/host/fb_tools/bdf_to_c.py @@ -133,7 +133,7 @@ arr = l.split(None,1) if len(arr) < 2 and \ arr[0].lower() != 'STARTCHAR' : - print >>sys.stderr,'Not start of glyph: %s'%(l) + print('Not start of glyph: %s'%(l), file=sys.stderr) continue inchar = unique_name(arr[1],self.glyphs) continue @@ -159,7 +159,7 @@ continue if len(arr) < 2 : - print >>sys.stderr,'Bad line in font: %s'%(l) + print('Bad line in font: %s'%(l), file=sys.stderr) continue data[arr[0].lower()] = arr[1] @@ -183,40 +183,40 @@ if opts.firstchar == None : opts.firstchar = min(font.enc) - print 'First character in font: %d, %s'%(opts.firstchar, - font.enc[opts.firstchar]) + print('First character in font: %d, %s'%(opts.firstchar, + font.enc[opts.firstchar])) if opts.lastchar == None : opts.lastchar = max(font.enc) - print 'Last character in font: %d, %s'%(opts.lastchar, - font.enc[opts.lastchar]) + print('Last character in font: %d, %s'%(opts.lastchar, + font.enc[opts.lastchar])) if opts.base == None : opts.base = 'font_'+os.path.basename(args[0]) if opts.base[-4:] == '.bdf' : opts.base = opts.base[:-4] - print >>sys.stderr,'Guessing symbol prefix to be %s.'%(opts.base) + print('Guessing symbol prefix to be %s.'%(opts.base), file=sys.stderr) if opts.out == None : opts.out = os.path.basename(args[0]) if opts.out[-4:] == '.bdf' : opts.out = opts.out[:-4] opts.out = opts.out + '.c' - print >>sys.stderr,'Guessing output filename to be %s.'%(opts.out) + print('Guessing output filename to be %s.'%(opts.out), file=sys.stderr) if os.path.exists(opts.out) : - print >>sys.stderr,'Will *NOT* overwrite existing file when guessing output!' + print('Will *NOT* overwrite existing file when guessing output!', file=sys.stderr) sys.exit(1) of = file(opts.out,'w') - print >>of,'#include ' - print >>of,'/* file autogenerated by %s */'%(sys.argv[0]) + print('#include ', file=of) + print('/* file autogenerated by %s */' %(sys.argv[0]), file=of) offsets = list() glyphnames = list() - print >>of,'static const uint8_t %s_data[] = {'%(opts.base) + print('static const uint8_t %s_data[] = {'%(opts.base), file=of) pos = 0 @@ -236,8 +236,8 @@ bitmap = glyph['bitmap'] if bbx[1] != len(bitmap) : - print >>sys.stderr,'ERROR: glyph',charname,'has wrong number of lines of data!' - print >>sys.stderr,' want: ',bbx[1],'but have',len(bitmap) + print('ERROR: glyph',charname,'has wrong number of lines of data!', file=sys.stderr) + print(' want: ',bbx[1],'but have',len(bitmap), file=sys.stderr) sys.exit(1) removedrows = 0 @@ -254,40 +254,40 @@ bitmap = bitmap[:-1] if removedrows > 0 : - print "Glyph %s: removed %d rows."%(charname,removedrows) + print("Glyph %s: removed %d rows."%(charname,removedrows)) w = int(glyph['dwidth'].split(None,1)[0]) - print >>of,'/* --- new character %s %s starting at offset 0x%04x --- */'%( - charname,ascii_charnum(i),pos) - print >>of,'\t/*%04x:*/\t%d, %d, %d, %d, %d, /* width and bbox (w,h,x,y) */'%( - pos,w,bbx[0],bbx[1],bbx[2],bbx[3]) + print('/* --- new character %s %s starting at offset 0x%04x --- */'%( + charname,ascii_charnum(i),pos), file=of) + print('\t/*%04x:*/\t%d, %d, %d, %d, %d, /* width and bbox (w,h,x,y) */'%( + pos,w,bbx[0],bbx[1],bbx[2],bbx[3]), file=of) pos += 5 for k,l in enumerate(bitmap) : bytes = [ int(l[i:i+2],16) for i in range(0,len(l),2) ] if len(bytes) != (bbx[0]+7)/8 : - print >>sys.stderr,'ERROR: glyph',charname,'has wrong # of bytes' - print >>sys.stderr,' per line. Want',(bbx[0]+7)/8,'have',len(bytes) + print('ERROR: glyph',charname,'has wrong # of bytes', file=sys.stderr) + print(' per line. Want',(bbx[0]+7)/8,'have',len(bytes), file=sys.stderr) sys.exit(1) cdata = ','.join([ '0x%02x'%v for v in bytes ]) comment = ''.join([ byte_to_bits(b) for b in bytes ]) - print >>of,'\t/*%04x:*/\t'%(pos)+cdata+', /* '+comment+' */' + print('\t/*%04x:*/\t'%(pos)+cdata+', /* '+comment+' */', file=of) pos += len(bytes) - print >>of,"};" + print("};", file=of) x = ',\n\t'.join(['0x%04x /* %s */'%(w,n) for w,n in zip(offsets,glyphnames)]) - print >>of,'static const uint16_t %s_offsets[] = {\n\t%s\n};'%(opts.base,x) + print('static const uint16_t %s_offsets[] = {\n\t%s\n};'%(opts.base,x), file=of) height = font.ascent + font.descent - print >>of,'const struct fb_font %s = {'%(opts.base) - print >>of,'\t.height = %d,'%(height) - print >>of,'\t.ascent = %d,'%(font.ascent) - print >>of,'\t.firstchar = %d, /* %s */'%(opts.firstchar,font.enc.get(opts.firstchar,"?")) - print >>of,'\t.lastchar = %d, /* %s */'%(opts.lastchar,font.enc.get(opts.lastchar,"?")) - print >>of,'\t.chardata = %s_data,'%(opts.base) - print >>of,'\t.charoffs = %s_offsets,'%(opts.base) - print >>of,'};' + print('const struct fb_font %s = {'%(opts.base), file=of) + print('\t.height = %d,'%(height), file=of) + print('\t.ascent = %d,'%(font.ascent), file=of) + print('\t.firstchar = %d, /* %s */'%(opts.firstchar,font.enc.get(opts.firstchar,"?")), file=of) + print('\t.lastchar = %d, /* %s */'%(opts.lastchar,font.enc.get(opts.lastchar,"?")), file=of) + print('\t.chardata = %s_data,'%(opts.base), file=of) + print('\t.charoffs = %s_offsets,'%(opts.base), file=of) + print('};', file=of) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:14:45 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 14:14:45 +0000 Subject: Change in ...osmocom-bb[master]: target/*.py: use python3 Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14759 Change subject: target/*.py: use python3 ...................................................................... target/*.py: use python3 python2 is already in only-maintained state and dead. It will walk as zombie till 1. Jan 2020 FIXME: untested Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 --- M src/target/firmware/solve_envs.py M src/target/trx_toolkit/app_common.py M src/target/trx_toolkit/burst_fwd.py M src/target/trx_toolkit/burst_gen.py M src/target/trx_toolkit/burst_send.py M src/target/trx_toolkit/clck_gen.py M src/target/trx_toolkit/ctrl_cmd.py M src/target/trx_toolkit/ctrl_if.py M src/target/trx_toolkit/ctrl_if_trx.py M src/target/trx_toolkit/data_dump.py M src/target/trx_toolkit/data_if.py M src/target/trx_toolkit/data_msg.py M src/target/trx_toolkit/fake_pm.py M src/target/trx_toolkit/fake_trx.py M src/target/trx_toolkit/gsm_shared.py M src/target/trx_toolkit/rand_burst_gen.py M src/target/trx_toolkit/transceiver.py M src/target/trx_toolkit/trx_list.py M src/target/trx_toolkit/trx_sniff.py M src/target/trx_toolkit/udp_link.py 20 files changed, 20 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/59/14759/1 diff --git a/src/target/firmware/solve_envs.py b/src/target/firmware/solve_envs.py index d4cee80..da1b0e1 100755 --- a/src/target/firmware/solve_envs.py +++ b/src/target/firmware/solve_envs.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 import sys diff --git a/src/target/trx_toolkit/app_common.py b/src/target/trx_toolkit/app_common.py index 9bcd593..38a0d60 100644 --- a/src/target/trx_toolkit/app_common.py +++ b/src/target/trx_toolkit/app_common.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/burst_fwd.py b/src/target/trx_toolkit/burst_fwd.py index 164271f..5acd163 100644 --- a/src/target/trx_toolkit/burst_fwd.py +++ b/src/target/trx_toolkit/burst_fwd.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/burst_gen.py b/src/target/trx_toolkit/burst_gen.py index b62f48c..7cc6dfb 100755 --- a/src/target/trx_toolkit/burst_gen.py +++ b/src/target/trx_toolkit/burst_gen.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/burst_send.py b/src/target/trx_toolkit/burst_send.py index 6c19e6f..f768cfa 100755 --- a/src/target/trx_toolkit/burst_send.py +++ b/src/target/trx_toolkit/burst_send.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/clck_gen.py b/src/target/trx_toolkit/clck_gen.py index a4b83b5..add15ca 100755 --- a/src/target/trx_toolkit/clck_gen.py +++ b/src/target/trx_toolkit/clck_gen.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/ctrl_cmd.py b/src/target/trx_toolkit/ctrl_cmd.py index bdacb64..07ca7b5 100755 --- a/src/target/trx_toolkit/ctrl_cmd.py +++ b/src/target/trx_toolkit/ctrl_cmd.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/ctrl_if.py b/src/target/trx_toolkit/ctrl_if.py index 902af18..ebecf0e 100644 --- a/src/target/trx_toolkit/ctrl_if.py +++ b/src/target/trx_toolkit/ctrl_if.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/ctrl_if_trx.py b/src/target/trx_toolkit/ctrl_if_trx.py index 26a844f..6f7a9cd 100644 --- a/src/target/trx_toolkit/ctrl_if_trx.py +++ b/src/target/trx_toolkit/ctrl_if_trx.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/data_dump.py b/src/target/trx_toolkit/data_dump.py index 71e1261..f7bf252 100644 --- a/src/target/trx_toolkit/data_dump.py +++ b/src/target/trx_toolkit/data_dump.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/data_if.py b/src/target/trx_toolkit/data_if.py index 027fd85..2b9a33a 100644 --- a/src/target/trx_toolkit/data_if.py +++ b/src/target/trx_toolkit/data_if.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py index e946229..aab0d00 100644 --- a/src/target/trx_toolkit/data_msg.py +++ b/src/target/trx_toolkit/data_msg.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/fake_pm.py b/src/target/trx_toolkit/fake_pm.py index 1992f8d..d84e9d8 100644 --- a/src/target/trx_toolkit/fake_pm.py +++ b/src/target/trx_toolkit/fake_pm.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py index 928333f..0601ad1 100755 --- a/src/target/trx_toolkit/fake_trx.py +++ b/src/target/trx_toolkit/fake_trx.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/gsm_shared.py b/src/target/trx_toolkit/gsm_shared.py index d2f8278..d756478 100644 --- a/src/target/trx_toolkit/gsm_shared.py +++ b/src/target/trx_toolkit/gsm_shared.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/rand_burst_gen.py b/src/target/trx_toolkit/rand_burst_gen.py index 46c1e09..9aa33ff 100644 --- a/src/target/trx_toolkit/rand_burst_gen.py +++ b/src/target/trx_toolkit/rand_burst_gen.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py index 9c234fd..9180f70 100644 --- a/src/target/trx_toolkit/transceiver.py +++ b/src/target/trx_toolkit/transceiver.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/trx_list.py b/src/target/trx_toolkit/trx_list.py index 7bea560..9bf6149 100644 --- a/src/target/trx_toolkit/trx_list.py +++ b/src/target/trx_toolkit/trx_list.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/trx_sniff.py b/src/target/trx_toolkit/trx_sniff.py index 19ea8e6..90f5ae1 100755 --- a/src/target/trx_toolkit/trx_sniff.py +++ b/src/target/trx_toolkit/trx_sniff.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/udp_link.py b/src/target/trx_toolkit/udp_link.py index b378b63..34985e8 100644 --- a/src/target/trx_toolkit/udp_link.py +++ b/src/target/trx_toolkit/udp_link.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python3 # -*- coding: utf-8 -*- # TRX Toolkit -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 Gerrit-Change-Number: 14759 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:21:21 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 14:21:21 +0000 Subject: Change in ...docker-playground[master]: osmocom-bb-host-master: install python-enum as fake_trx dependency In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14754 ) Change subject: osmocom-bb-host-master: install python-enum as fake_trx dependency ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I70b7f1b43a1e121114a924c09614d6eddc801881 Gerrit-Change-Number: 14754 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Thu, 11 Jul 2019 14:21:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:21:41 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 14:21:41 +0000 Subject: Change in ...docker-playground[master]: osmocom-bb-host-master: install python-enum as fake_trx dependency In-Reply-To: References: Message-ID: lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14754 ) Change subject: osmocom-bb-host-master: install python-enum as fake_trx dependency ...................................................................... osmocom-bb-host-master: install python-enum as fake_trx dependency 62825cc8eb4e26d58d32a0af72b17256b185af61 (osmocom-bb) started to use the python module enum which not part of the standard libary of python 2. Change-Id: I70b7f1b43a1e121114a924c09614d6eddc801881 --- M osmocom-bb-host-master/Dockerfile 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Vadim Yanitskiy: Looks good to me, approved lynxis lazus: Verified diff --git a/osmocom-bb-host-master/Dockerfile b/osmocom-bb-host-master/Dockerfile index a4c8c16..1d79f06 100644 --- a/osmocom-bb-host-master/Dockerfile +++ b/osmocom-bb-host-master/Dockerfile @@ -13,10 +13,11 @@ rm /tmp/Release.key && \ echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list +# python-enum34 is a dependecy of fake_trx as long we're using python2 ADD $OSMOCOM_REPO/Release /tmp/Release RUN apt-get update && \ apt-get install -y --no-install-recommends \ - libosmocore-dev && \ + libosmocore-dev python-enum34 && \ apt-get clean WORKDIR /tmp -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14754 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I70b7f1b43a1e121114a924c09614d6eddc801881 Gerrit-Change-Number: 14754 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:31:40 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Thu, 11 Jul 2019 14:31:40 +0000 Subject: Change in ...osmocom-bb[master]: firmware/solve_envs.py: make it compatible with python3 In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14756 ) Change subject: firmware/solve_envs.py: make it compatible with python3 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14756 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I711df515012f5542de5e5008c8fe4e601609759e Gerrit-Change-Number: 14756 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Thu, 11 Jul 2019 14:31:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:32:11 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Thu, 11 Jul 2019 14:32:11 +0000 Subject: Change in ...osmocom-bb[master]: target_dsp/bin2cfile.py: make it compatible with python3 In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14757 ) Change subject: target_dsp/bin2cfile.py: make it compatible with python3 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14757 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2659c2e4633bd120cc6cd76942eff5b66d2057bb Gerrit-Change-Number: 14757 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Thu, 11 Jul 2019 14:32:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:33:28 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Thu, 11 Jul 2019 14:33:28 +0000 Subject: Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3 In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14758 ) Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Thu, 11 Jul 2019 14:33:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:38:04 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 14:38:04 +0000 Subject: Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3 In-Reply-To: References: Message-ID: Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 to look at the new patch set (#2). Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 ...................................................................... fb_tools/bdf_to_c.py: make it compatible with python3 This would break python2 compatibility. Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 --- M src/host/fb_tools/bdf_to_c.py 1 file changed, 32 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/58/14758/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:40:01 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 14:40:01 +0000 Subject: Change in ...osmocom-bb[master]: firmware/solve_envs.py: make it compatible with python3 In-Reply-To: References: Message-ID: lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14756 ) Change subject: firmware/solve_envs.py: make it compatible with python3 ...................................................................... firmware/solve_envs.py: make it compatible with python3 Change-Id: I711df515012f5542de5e5008c8fe4e601609759e --- M src/target/firmware/solve_envs.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Vadim Yanitskiy: Looks good to me, approved diff --git a/src/target/firmware/solve_envs.py b/src/target/firmware/solve_envs.py index 0e5f5e8..d4cee80 100755 --- a/src/target/firmware/solve_envs.py +++ b/src/target/firmware/solve_envs.py @@ -34,7 +34,7 @@ envs = solve(board_envs, app_envs) # Result - print ' '.join(envs) + print(' '.join(envs)) if __name__ == '__main__': -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14756 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I711df515012f5542de5e5008c8fe4e601609759e Gerrit-Change-Number: 14756 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:40:10 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 14:40:10 +0000 Subject: Change in ...osmocom-bb[master]: target_dsp/bin2cfile.py: make it compatible with python3 In-Reply-To: References: Message-ID: lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14757 ) Change subject: target_dsp/bin2cfile.py: make it compatible with python3 ...................................................................... target_dsp/bin2cfile.py: make it compatible with python3 Change-Id: I2659c2e4633bd120cc6cd76942eff5b66d2057bb --- M src/target_dsp/calypso/bin2cfile.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified Vadim Yanitskiy: Looks good to me, approved diff --git a/src/target_dsp/calypso/bin2cfile.py b/src/target_dsp/calypso/bin2cfile.py index 9456a6a..4d5a193 100755 --- a/src/target_dsp/calypso/bin2cfile.py +++ b/src/target_dsp/calypso/bin2cfile.py @@ -31,7 +31,7 @@ name = filename.split('.',1)[0] # Header / footer - print """ + print(""" #define _SA_DECL (const uint16_t *)&(const uint16_t []) static const struct dsp_section %s[] = { @@ -50,7 +50,7 @@ }; #undef _SA_DECL -""" % (name, len(d)/2, ops) +""" % (name, len(d)/2, ops)) if __name__ == "__main__": -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14757 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2659c2e4633bd120cc6cd76942eff5b66d2057bb Gerrit-Change-Number: 14757 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:43:42 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Thu, 11 Jul 2019 14:43:42 +0000 Subject: Change in ...osmocom-bb[master]: target/*.py: use python3 In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14759 ) Change subject: target/*.py: use python3 ...................................................................... Patch Set 1: TRX Toolkit should work with both Python 2 and 3 versions in general. I think we can use '#!/usr/bin/env python' to make it work with both. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 Gerrit-Change-Number: 14759 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Vadim Yanitskiy Gerrit-Comment-Date: Thu, 11 Jul 2019 14:43:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 14:50:00 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 14:50:00 +0000 Subject: Change in ...osmocom-bb[master]: target/*.py: use python3 In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14759 ) Change subject: target/*.py: use python3 ...................................................................... Patch Set 2: > Patch Set 1: > > TRX Toolkit should work with both Python 2 and 3 versions in general. > I think we can use '#!/usr/bin/env python' to make it work with both. Sounds possible. However I would like to drop python2 support in general. It's really dead already ;) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 Gerrit-Change-Number: 14759 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-CC: Vadim Yanitskiy Gerrit-Comment-Date: Thu, 11 Jul 2019 14:50:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 15:21:42 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 15:21:42 +0000 Subject: Change in ...osmo-pcu[master]: tests: test encoding of egprs ul ack/nacks Message-ID: lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14760 Change subject: tests: test encoding of egprs ul ack/nacks ...................................................................... tests: test encoding of egprs ul ack/nacks Test the encoding with uncompressed and compressed acknowledgements. Change-Id: I35d6b5e312faeb116ddda6b33c550840da1496fe --- M tests/types/TypesTest.cpp 1 file changed, 290 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/60/14760/1 diff --git a/tests/types/TypesTest.cpp b/tests/types/TypesTest.cpp index 589f156..c3fa4d6 100644 --- a/tests/types/TypesTest.cpp +++ b/tests/types/TypesTest.cpp @@ -2,6 +2,7 @@ * TypesTest.cpp Test the primitive data types * * Copyright (C) 2013 by Holger Hans Peter Freyther + * Copyright (C) 2019 by Sysmocom s.f.m.c. GmbH * * All Rights Reserved * @@ -26,6 +27,7 @@ #include "encoding.h" #include "decoding.h" #include "gprs_rlcmac.h" +#include "egprs_rlc_compression.h" extern "C" { #include @@ -431,6 +433,292 @@ } } +struct crbb_test { + bool has_crbb; + bitvec *crbb; + uint8_t length; + bool color_code; +}; + +static void extract_egprs_ul_ack_nack( + struct gprs_rlcmac_ul_tbf *tbf, + struct bitvec *dest, + uint16_t *ssn, + struct crbb_test *crbb_test, + struct bitvec **urbb, + bool is_final) +{ + uint8_t bytelength; + + /* Start of Ack/Nack Description struct */ + uint8_t startbit_ack_nack = 0; + + bool has_length = false; + uint8_t length = 0; + + bool bow = false; + bool has_urbb = false; + uint8_t urbb_length = 0; + dest->cur_bit = 0; + + /* ignore the first 8 bit */ + bitvec_get_uint(dest, 8); + + /* uplink ack/nack message content */ + OSMO_ASSERT(bitvec_get_uint(dest, 6) == 0b001001); + + /* ignore page mode*/ + bitvec_get_uint(dest, 2); + + /* fix 00 */ + OSMO_ASSERT(bitvec_get_uint(dest, 2) == 0); + + OSMO_ASSERT(bitvec_get_uint(dest, 5) == tbf->tfi()); + + /* egprs ack/nack */ + OSMO_ASSERT(bitvec_get_uint(dest, 1) == 1); + + /* fix 00 */ + OSMO_ASSERT(bitvec_get_uint(dest, 2) == 0); + + /* ignore Channel Coding Command */ + bitvec_get_uint(dest, 4); + + /* we always allow resegmentation */ + OSMO_ASSERT(bitvec_get_uint(dest, 1) == 1); + + /* ignore pre emptive transmission */ + bitvec_get_uint(dest, 1); + + /* ignore PRR retransmission request */ + bitvec_get_uint(dest, 1); + + /* ignore ARAC retransmission request */ + bitvec_get_uint(dest, 1); + + if (bitvec_get_uint(dest, 1)) { + OSMO_ASSERT(bitvec_get_uint(dest, 32) == tbf->tlli()); + } + + /* ignore TBF_EST */ + bitvec_get_uint(dest, 1); + + /* Timing Advance */ + if (bitvec_get_uint(dest, 1)) { + /* Timing Advance Value */ + if (bitvec_get_uint(dest, 1)) + bitvec_get_uint(dest, 6); + + /* Timing Advance Index*/ + if (bitvec_get_uint(dest, 1)) + bitvec_get_uint(dest, 6); + /* Timing Advance Timeslot Number */ + bitvec_get_uint(dest, 3); + } + + /* Packet Extended Timing Advance */ + if (bitvec_get_uint(dest, 1)) + bitvec_get_uint(dest, 2); + + /* Power Control Parameters */ + if (bitvec_get_uint(dest, 1)) { + /* Alpha */ + bitvec_get_uint(dest, 4); + for (int i=0; i<8 ; i++) { + /* Gamma */ + if (bitvec_get_uint(dest, 1)) + bitvec_get_uint(dest, 5); + } + } + + /* Extension Bits */ + if (bitvec_get_uint(dest, 1)) { + int length = bitvec_get_uint(dest, 6); + bitvec_get_uint(dest, length); + } + + /* Beging of the EGPRS Ack/Nack */ + has_length = bitvec_get_uint(dest, 1); + if (has_length) { + length = bitvec_get_uint(dest, 8); + } else { + /* remaining bits is the length */ + length = dest->data_len * 8 - dest->cur_bit; + } + startbit_ack_nack = dest->cur_bit; + + OSMO_ASSERT(bitvec_get_uint(dest, 1) == is_final); + + /* bow Begin Of Window */ + bow = bitvec_get_uint(dest, 1); + /* TODO: check if bow is always present in our implementation */ + + /* eow End Of Window */ + /* TODO: eow checking */ + bitvec_get_uint(dest, 1); + + *ssn = bitvec_get_uint(dest, 11); + if (bow) { + OSMO_ASSERT(*ssn == tbf->window()->v_q() + 1); + } + + crbb_test->has_crbb = bitvec_get_uint(dest, 1); + if (crbb_test->has_crbb) { + crbb_test->length = bitvec_get_uint(dest, 7); + crbb_test->color_code = bitvec_get_uint(dest, 1); + if (crbb_test->length % 8) + bytelength = crbb_test->length * 8 + 1; + else + bytelength = crbb_test->length * 8; + + crbb_test->crbb = bitvec_alloc(bytelength, tall_pcu_ctx); + for (int i=0; ilength; i++) + bitvec_set_bit(crbb_test->crbb, bitvec_get_bit_pos(dest, dest->cur_bit + i)); + + dest->cur_bit += crbb_test->length; + } + + OSMO_ASSERT(dest->cur_bit < dest->data_len * 8); + urbb_length = length - (dest->cur_bit - startbit_ack_nack); + + if (urbb_length > 0) { + has_urbb = true; + + if (urbb_length % 8) + bytelength = urbb_length / 8 + 1; + else + bytelength = urbb_length / 8; + + *urbb = bitvec_alloc(bytelength, tall_pcu_ctx); + for (int i=urbb_length; i>0; i--) { + bitvec_set_bit(*urbb, bitvec_get_bit_pos(dest, dest->cur_bit + i - 1)); + } + } +} + +static void check_egprs_bitmap(struct gprs_rlcmac_ul_tbf *tbf, uint16_t ssn, struct crbb_test *crbb_test, bitvec *urbb, unsigned int *rbb_size) +{ + uint8_t rbb_should[RLC_EGPRS_MAX_WS] = {0}; + bitvec rbb_should_bv; + rbb_should_bv.data = rbb_should; + rbb_should_bv.data_len = RLC_EGPRS_MAX_WS; + rbb_should_bv.cur_bit = 0; + + /* rbb starting at ssn without mod */ + bitvec *rbb_ssn_bv = bitvec_alloc(RLC_EGPRS_MAX_WS, tall_pcu_ctx); + + /* even any ssn is allowed, pcu should only use v_q() at least for now */ + OSMO_ASSERT(ssn == (tbf->window()->v_q() + 1)); + + if (crbb_test->has_crbb) { + OSMO_ASSERT(0 == egprs_compress::decompress_crbb( + crbb_test->length, + crbb_test->color_code, + crbb_test->crbb->data, + rbb_ssn_bv)); + } + + if (urbb && urbb->cur_bit > 0) { + for (unsigned int i=0; icur_bit; i++) { + bitvec_set_bit(rbb_ssn_bv, bitvec_get_bit_pos(urbb, i)); + } + } + + /* check our rbb is equal the decompressed */ + rbb_should_bv.cur_bit = tbf->window()->update_egprs_rbb(rbb_should); + + bool failed = 0; + for (int i=0; i < rbb_ssn_bv->cur_bit; i++) { + if (bitvec_get_bit_pos(&rbb_should_bv, i) != + bitvec_get_bit_pos(rbb_ssn_bv, i)) + failed = true; + } + if (failed) { + char to_dump[256] = { 0 }; + bitvec_to_string_r(&rbb_should_bv, to_dump); + fprintf(stderr, "should: %s\n", to_dump); + memset(to_dump, 0x0, 256); + bitvec_to_string_r(rbb_ssn_bv, to_dump); + fprintf(stderr, "is : %s\n", to_dump); + OSMO_ASSERT(false); + } + + if (rbb_size) + *rbb_size = rbb_ssn_bv->cur_bit; +} + +static void free_egprs_ul_ack_nack(bitvec **rbb, struct crbb_test *crbb_test) +{ + if (*rbb) { + bitvec_free(*rbb); + *rbb = NULL; + } + + if (crbb_test->crbb) { + bitvec_free(crbb_test->crbb); + crbb_test->crbb = NULL; + } +} + +static void test_egprs_ul_ack_nack() +{ + bitvec *dest = bitvec_alloc(23, tall_pcu_ctx); + + BTS the_bts; + the_bts.bts_data()->egprs_enabled = true; + the_bts.bts_data()->alloc_algorithm = alloc_algorithm_a; + the_bts.bts_data()->trx[0].pdch[4].enable(); + + struct gprs_rlcmac_ul_tbf *tbf = tbf_alloc_ul_tbf(the_bts.bts_data(), NULL, 0, 1, 1, true); + struct crbb_test crbb_test = {0}; + bitvec *rbb = NULL; + unsigned int rbb_size; + uint16_t ssn = 0; + gprs_rlc_ul_window *win = tbf->window(); + + printf("Test with empty window\n"); + win->reset_state(); + win->set_ws(256); + + Encoding::write_packet_uplink_ack(dest, tbf, false, 0); + extract_egprs_ul_ack_nack(tbf, dest, &ssn, &crbb_test, &rbb, false); + check_egprs_bitmap(tbf, ssn, &crbb_test, rbb, &rbb_size); + free_egprs_ul_ack_nack(&rbb, &crbb_test); + OSMO_ASSERT(rbb_size == 0); + + fprintf(stderr, "************** Test with 1 lost packet\n"); + win->reset_state(); + win->set_ws(256); + win->receive_bsn(1); + + Encoding::write_packet_uplink_ack(dest, tbf, false, 0); + extract_egprs_ul_ack_nack(tbf, dest, &ssn, &crbb_test, &rbb, false); + check_egprs_bitmap(tbf, ssn, &crbb_test, rbb, &rbb_size); + free_egprs_ul_ack_nack(&rbb, &crbb_test); + OSMO_ASSERT(rbb_size == 1); + + fprintf(stderr, "************** Test with compressed window\n"); + win->reset_state(); + win->set_ws(128); + win->receive_bsn(127); + + Encoding::write_packet_uplink_ack(dest, tbf, false, 0); + extract_egprs_ul_ack_nack(tbf, dest, &ssn, &crbb_test, &rbb, false); + check_egprs_bitmap(tbf, ssn, &crbb_test, rbb, &rbb_size); + free_egprs_ul_ack_nack(&rbb, &crbb_test); + + fprintf(stderr, "************** Provoke an uncompressed ACK without EOW\n"); + win->reset_state(); + win->set_ws(384); + for (uint16_t i=1; i<384; i++) + win->receive_bsn(i*2); + + Encoding::write_packet_uplink_ack(dest, tbf, false, 0); + extract_egprs_ul_ack_nack(tbf, dest, &ssn, &crbb_test, &rbb, false); + check_egprs_bitmap(tbf, ssn, &crbb_test, rbb, &rbb_size); + free_egprs_ul_ack_nack(&rbb, &crbb_test); +} + static void check_imm_ass(struct gprs_rlcmac_tbf *tbf, bool dl, enum ph_burst_type bt, const uint8_t *exp, uint8_t len, const char *kind) { @@ -619,6 +907,7 @@ log_set_print_filename(osmo_stderr_target, 0); printf("Making some basic type testing.\n"); + test_llc(); test_rlc(); test_rlc_v_b(); @@ -631,6 +920,7 @@ test_immediate_assign_ul1s(); test_immediate_assign_rej(); test_lsb(); + test_egprs_ul_ack_nack(); return EXIT_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I35d6b5e312faeb116ddda6b33c550840da1496fe Gerrit-Change-Number: 14760 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 15:23:53 2019 From: gerrit-no-reply at lists.osmocom.org (ipse) Date: Thu, 11 Jul 2019 15:23:53 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling In-Reply-To: References: Message-ID: ipse has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 ) Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Patch Set 4: > Patch Set 4: > > > This is only correct for the specific implementation we currently have in osmo-trx [...] > > Should I just change the commit message? > Or are you against using int16_t instead of float too? Have you done the fixed point precision analysis for these values? it's probably quite simple but it's not possible to do only looking into the diffs. In general, I'm all for fixed-point arithmetic if it doesn't affect precision. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 11 Jul 2019 15:23:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 15:29:46 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 15:29:46 +0000 Subject: Change in ...osmo-pcu[master]: tests: test encoding of egprs ul ack/nacks In-Reply-To: References: Message-ID: lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/14760 ) Change subject: tests: test encoding of egprs ul ack/nacks ...................................................................... tests: test encoding of egprs ul ack/nacks Test the encoding with uncompressed and compressed acknowledgements. Change-Id: I35d6b5e312faeb116ddda6b33c550840da1496fe --- M tests/types/TypesTest.cpp M tests/types/TypesTest.err 2 files changed, 299 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/60/14760/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I35d6b5e312faeb116ddda6b33c550840da1496fe Gerrit-Change-Number: 14760 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 16:01:27 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 16:01:27 +0000 Subject: Change in ...osmo-msc[master]: replace osmo_counter with stat_items In-Reply-To: References: Message-ID: Hello pespin, daniel, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/13802 to look at the new patch set (#10). Change subject: replace osmo_counter with stat_items ...................................................................... replace osmo_counter with stat_items osmo_counter will be soon deprecated. Use the newer and more flexible osmo_stat_item instead. Depends on: Id2462c4866bd22bc2338c9c8f69b775f88ae7511 (libosmocore) Change-Id: I6a20123b263f4f808153794ee8a735092deb399e --- M include/osmocom/msc/gsm_data.h M src/libmsc/gsm_04_08_cc.c M src/libmsc/gsm_09_11.c M src/libmsc/msc_net_init.c M tests/msc_vlr/msc_vlr_test_authen_reuse.err M tests/msc_vlr/msc_vlr_test_call.err M tests/msc_vlr/msc_vlr_test_gsm_authen.err M tests/msc_vlr/msc_vlr_test_gsm_ciph.err M tests/msc_vlr/msc_vlr_test_hlr_reject.err M tests/msc_vlr/msc_vlr_test_hlr_timeout.err M tests/msc_vlr/msc_vlr_test_ms_timeout.err M tests/msc_vlr/msc_vlr_test_no_authen.err M tests/msc_vlr/msc_vlr_test_reject_concurrency.err M tests/msc_vlr/msc_vlr_test_rest.err M tests/msc_vlr/msc_vlr_test_ss.err M tests/msc_vlr/msc_vlr_test_umts_authen.err M tests/msc_vlr/msc_vlr_tests.c 17 files changed, 149 insertions(+), 127 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/02/13802/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/13802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6a20123b263f4f808153794ee8a735092deb399e Gerrit-Change-Number: 13802 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 16:41:38 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 16:41:38 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: ACK/NACK: always encode with length field present In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/14697 to look at the new patch set (#5). Change subject: Encoding: ACK/NACK: always encode with length field present ...................................................................... Encoding: ACK/NACK: always encode with length field present In most cases the length field was present and this field takes 7 bits of the maximum available 110 rest bits. The length field was only removed when encoding huge bitmaps usually only happen on lossy connections with packet lost. However the cases without length field were encoded incorrect, because all remaining bits must be used by the uncompressed bitmaps, but the PCU violates this by encoding always the "release 5" bit. Rather than fixing the encoding without length field, simply remove it and always encode with length field. This also reduces the code complexity. Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb --- M src/encoding.cpp 1 file changed, 39 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/97/14697/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb Gerrit-Change-Number: 14697 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 16:41:38 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 11 Jul 2019 16:41:38 +0000 Subject: Change in ...osmo-pcu[master]: tests: test encoding of egprs ul ack/nacks In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/14760 to look at the new patch set (#3). Change subject: tests: test encoding of egprs ul ack/nacks ...................................................................... tests: test encoding of egprs ul ack/nacks Test the encoding with uncompressed and compressed acknowledgements. Change-Id: I35d6b5e312faeb116ddda6b33c550840da1496fe --- M tests/types/TypesTest.cpp M tests/types/TypesTest.err 2 files changed, 304 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/60/14760/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I35d6b5e312faeb116ddda6b33c550840da1496fe Gerrit-Change-Number: 14760 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 11 19:17:05 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 11 Jul 2019 19:17:05 +0000 Subject: Change in ...osmo-bts[master]: Merge branch 'master' of ssh://og/osmo-bts Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14761 Change subject: Merge branch 'master' of ssh://og/osmo-bts ...................................................................... Merge branch 'master' of ssh://og/osmo-bts Change-Id: I2d9b9593a4633d78091da43f0017cbb4ec3da4ba --- 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/61/14761/1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2d9b9593a4633d78091da43f0017cbb4ec3da4ba Gerrit-Change-Number: 14761 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Thu Jul 11 21:38:16 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 11 Jul 2019 21:38:16 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d27ac4c879e8_261c12765f41955ab@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sysmon failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 106s] #define PACKAGE "osmo-sysmon" [ 106s] #define VERSION "0.1.0" [ 106s] #define STDC_HEADERS 1 [ 106s] #define HAVE_SYS_TYPES_H 1 [ 106s] #define HAVE_SYS_STAT_H 1 [ 106s] #define HAVE_STDLIB_H 1 [ 106s] #define HAVE_STRING_H 1 [ 106s] #define HAVE_MEMORY_H 1 [ 106s] #define HAVE_STRINGS_H 1 [ 106s] #define HAVE_INTTYPES_H 1 [ 106s] #define HAVE_STDINT_H 1 [ 106s] #define HAVE_UNISTD_H 1 [ 106s] #define HAVE_DLFCN_H 1 [ 106s] #define LT_OBJDIR ".libs/" [ 106s] [ 106s] configure: exit 1 [ 106s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking returned exit code 1 [ 106s] make: *** [debian/rules:45: build] Error 2 [ 106s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 106s] [ 106s] lamb52 failed "build osmo-sysmon_0.1.0.dsc" at Thu Jul 11 21:38:11 UTC 2019. [ 106s] [ 106s] ### VM INTERACTION START ### [ 109s] [ 95.948255] sysrq: SysRq : Power Off [ 109s] [ 95.954765] reboot: Power down [ 109s] ### VM INTERACTION END ### [ 109s] [ 109s] lamb52 failed "build osmo-sysmon_0.1.0.dsc" at Thu Jul 11 21:38:14 UTC 2019. [ 109s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Thu Jul 11 21:41:59 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 11 Jul 2019 21:41:59 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d27ad3beef60_261c12765f4195690@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_Unstable/x86_64 Package network:osmocom:latest/openbsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 124s] | configure: exit 0 [ 124s] [ 124s] # -*- compilation -*- [ 124s] 4. testsuite.at:23: testing db ... [ 124s] ./testsuite.at:28: $abs_top_builddir/tests/db/db_test [ 124s] --- expout 2019-07-11 21:41:46.000000000 +0000 [ 124s] +++ /usr/src/packages/BUILD/openbsc/tests/testsuite.dir/at-groups/4/stdout 2019-07-11 21:41:46.136000000 +0000 [ 124s] @@ -1,4 +1,6 @@ [ 124s] Testing subscriber database code. [ 124s] DB: Database initialized. [ 124s] +no tables in statement ! [ 124s] +no tables in statement ! [ 124s] DB: Database prepared. [ 124s] Done [ 124s] 4. testsuite.at:23: 4. db (testsuite.at:23): FAILED (testsuite.at:28) [ 124s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 124s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 124s] make: *** [debian/rules:13: build] Error 2 [ 124s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 124s] [ 124s] sheep81 failed "build openbsc_1.2.0.dsc" at Thu Jul 11 21:41:47 UTC 2019. [ 124s] [ 124s] ### VM INTERACTION START ### [ 127s] [ 117.451643] sysrq: SysRq : Power Off [ 127s] [ 117.457811] reboot: Power down [ 127s] ### VM INTERACTION END ### [ 127s] [ 127s] sheep81 failed "build openbsc_1.2.0.dsc" at Thu Jul 11 21:41:49 UTC 2019. [ 127s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 12 02:43:08 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 12 Jul 2019 02:43:08 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d27f3c926e76_261c12765f4222353@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 671s] | This file was extended by libosmocore config.status 1.1.0.79-a3dec, which was [ 671s] | generated by GNU Autoconf 2.69. Invocation command line was [ 671s] | [ 671s] | CONFIG_FILES = [ 671s] | CONFIG_HEADERS = [ 671s] | CONFIG_LINKS = [ 671s] | CONFIG_COMMANDS = [ 671s] | $ ./config.status Doxyfile.core [ 671s] | [ 671s] | on armbuild04 [ 671s] | [ 671s] | config.status:1200: creating Doxyfile.core [ 671s] [ 671s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 671s] make[1]: *** [override_dh_auto_test] Error 1 [ 671s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 671s] debian/rules:15: recipe for target 'build' failed [ 671s] make: *** [build] Error 2 [ 671s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 671s] [ 671s] armbuild04 failed "build libosmocore_1.1.0.79.a3dec.dsc" at Fri Jul 12 02:43:02 UTC 2019. [ 671s] [ 671s] ### VM INTERACTION START ### [ 673s] [ 619.144091] sysrq: SysRq : Power Off [ 673s] [ 619.147601] reboot: Power down [ 673s] ### VM INTERACTION END ### [ 673s] [ 673s] armbuild04 failed "build libosmocore_1.1.0.79.a3dec.dsc" at Fri Jul 12 02:43:06 UTC 2019. [ 673s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 12 03:02:34 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 12 Jul 2019 03:02:34 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d27f85950b74_261c12765f42230b6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 587s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 587s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 587s] collect2: error: ld returned 1 exit status [ 587s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 587s] make[4]: *** [osmo-bts-virtual] Error 1 [ 587s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 587s] Makefile:385: recipe for target 'all-recursive' failed [ 587s] make[3]: *** [all-recursive] Error 1 [ 587s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 587s] Makefile:434: recipe for target 'all-recursive' failed [ 587s] make[2]: *** [all-recursive] Error 1 [ 587s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 587s] Makefile:366: recipe for target 'all' failed [ 587s] make[1]: *** [all] Error 2 [ 587s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 587s] dh_auto_build: make -j1 returned exit code 2 [ 587s] debian/rules:12: recipe for target 'build' failed [ 587s] make: *** [build] Error 2 [ 587s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 587s] [ 587s] obs-arm-5 failed "build osmo-bts_0.8.1.336.04e9.dsc" at Fri Jul 12 03:02:14 UTC 2019. [ 587s] [ 587s] ### VM INTERACTION START ### [ 590s] [ 550.119193] sysrq: SysRq : Power Off [ 590s] [ 550.135136] reboot: Power down [ 591s] ### VM INTERACTION END ### [ 591s] [ 591s] obs-arm-5 failed "build osmo-bts_0.8.1.336.04e9.dsc" at Fri Jul 12 03:02:18 UTC 2019. [ 591s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 12 03:43:08 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 12 Jul 2019 03:43:08 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2801d77fe50_261c12765f42254b6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 552s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 552s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 552s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 552s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 552s] make[4]: *** [gb_proxy.o] Error 1 [ 552s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 552s] Makefile:391: recipe for target 'all-recursive' failed [ 552s] make[3]: *** [all-recursive] Error 1 [ 552s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 552s] Makefile:453: recipe for target 'all-recursive' failed [ 552s] make[2]: *** [all-recursive] Error 1 [ 552s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 552s] Makefile:385: recipe for target 'all' failed [ 552s] make[1]: *** [all] Error 2 [ 552s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 552s] dh_auto_build: make -j1 returned exit code 2 [ 552s] debian/rules:45: recipe for target 'build' failed [ 552s] make: *** [build] Error 2 [ 552s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 552s] [ 552s] armbuild21 failed "build osmo-sgsn_1.4.0.28.43f16.dsc" at Fri Jul 12 03:42:56 UTC 2019. [ 552s] [ 552s] ### VM INTERACTION START ### [ 555s] [ 506.848029] sysrq: SysRq : Power Off [ 555s] [ 506.850211] reboot: Power down [ 555s] ### VM INTERACTION END ### [ 555s] [ 555s] armbuild21 failed "build osmo-sgsn_1.4.0.28.43f16.dsc" at Fri Jul 12 03:42:59 UTC 2019. [ 555s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 12 03:44:34 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 12 Jul 2019 03:44:34 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d28022ecc5a6_261c12765f4225875@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 642s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 642s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 642s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 642s] Makefile:442: recipe for target 'vlr.o' failed [ 642s] make[4]: *** [vlr.o] Error 1 [ 642s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 642s] Makefile:422: recipe for target 'all-recursive' failed [ 642s] make[3]: *** [all-recursive] Error 1 [ 642s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 642s] Makefile:462: recipe for target 'all-recursive' failed [ 642s] make[2]: *** [all-recursive] Error 1 [ 642s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 642s] Makefile:394: recipe for target 'all' failed [ 642s] make[1]: *** [all] Error 2 [ 642s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 642s] dh_auto_build: make -j1 returned exit code 2 [ 642s] debian/rules:45: recipe for target 'build' failed [ 642s] make: *** [build] Error 2 [ 642s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 642s] [ 642s] armbuild16 failed "build osmo-msc_1.3.1.178.aa0a.dsc" at Fri Jul 12 03:44:23 UTC 2019. [ 642s] [ 642s] ### VM INTERACTION START ### [ 646s] [ 586.378706] sysrq: SysRq : Power Off [ 646s] [ 586.380789] reboot: Power down [ 646s] ### VM INTERACTION END ### [ 647s] [ 647s] armbuild16 failed "build osmo-msc_1.3.1.178.aa0a.dsc" at Fri Jul 12 03:44:28 UTC 2019. [ 647s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Jul 12 05:09:12 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Fri, 12 Jul 2019 05:09:12 +0000 Subject: Change in ...osmo-bts[master]: Merge branch 'master' of ssh://og/osmo-bts In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14761 ) Change subject: Merge branch 'master' of ssh://og/osmo-bts ...................................................................... Patch Set 1: (1 comment) Could you please explain in the commit message from where does this change come from (this magic ssh://og/... is not obvious to me), and what is going to be changed? I see some changes to the manuals, but at the same time I see some changes that have already been merged. https://gerrit.osmocom.org/#/c/14761/1/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: https://gerrit.osmocom.org/#/c/14761/1/src/osmo-bts-trx/trx_if.c at 589 PS1, Line 589: TRX_DATA_MSG_MAX_LEN Wait, this change has already been merged to the master, together with a few related ones... -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2d9b9593a4633d78091da43f0017cbb4ec3da4ba Gerrit-Change-Number: 14761 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Vadim Yanitskiy Gerrit-Comment-Date: Fri, 12 Jul 2019 05:09:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 12 05:53:41 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Fri, 12 Jul 2019 05:53:41 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14689 to look at the new patch set (#6). Change subject: osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP ...................................................................... osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP Change-Id: Iea0dad65e9bc511f99375fd3ee2eb44e47a6168f --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/14689/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea0dad65e9bc511f99375fd3ee2eb44e47a6168f Gerrit-Change-Number: 14689 Gerrit-PatchSet: 6 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 12 06:05:25 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 12 Jul 2019 06:05:25 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: add check IMEI tests In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 ) Change subject: msc: add check IMEI tests ...................................................................... Patch Set 3: Code-Review+2 1+1=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d Gerrit-Change-Number: 14694 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 12 Jul 2019 06:05:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 12 06:05:39 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 12 Jul 2019 06:05:39 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: add check IMEI tests In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 ) Change subject: msc: add check IMEI tests ...................................................................... msc: add check IMEI tests Extend BSC_ConnHdlr with new check IMEI related parameters. Add tests for check IMEI and check IMEI early for multiple auth variations, as well as variants where the HLR would respond with NOK or ERR. Note that we can safely set "check-imei-rqd 0" in f_init(), because the latest OsmoMSC version already suppors this VTY command. Two tests do not always pass, sometimes the RAN connection breaks before the test finishes (TC_lu_imsi_auth_tmsi_check_imei_err and TC_lu_imsi_auth_tmsi_check_imei_nack). I have added them as expected errors in the expected-results.xml. Related: OS#2542 Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d --- M library/GSUP_Types.ttcn M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn M msc/expected-results.xml 4 files changed, 420 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Vadim Yanitskiy: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn index e627538..74fbfc4 100644 --- a/library/GSUP_Types.ttcn +++ b/library/GSUP_Types.ttcn @@ -538,10 +538,30 @@ ts_GSUP(OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST, { valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_IMEI(imei)) }); +template GSUP_PDU tr_GSUP_CHECK_IMEI_REQ( + template hexstring imsi, + template hexstring imei +) := tr_GSUP( + OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST, + { + tr_GSUP_IE_IMSI(imsi), + tr_GSUP_IE_IMEI(imei), + tr_GSUP_IE_Message_Class(OSMO_GSUP_MESSAGE_CLASS_SUBSCRIBER_MANAGEMENT) + } +); + +template (value) GSUP_PDU ts_GSUP_CHECK_IMEI_RES(hexstring imsi, GSUP_IMEIResult result) := + ts_GSUP(OSMO_GSUP_MSGT_CHECK_IMEI_RESULT, { + valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_IMEI_Result(result)) }); + template GSUP_PDU tr_GSUP_CHECK_IMEI_RES(template hexstring imsi, template GSUP_IMEIResult result) := tr_GSUP(OSMO_GSUP_MSGT_CHECK_IMEI_RESULT, { tr_GSUP_IE_IMSI(imsi), tr_GSUP_IE_IMEI_Result(result) }); +template (value) GSUP_PDU ts_GSUP_CHECK_IMEI_ERR(hexstring imsi, integer cause) := + ts_GSUP(OSMO_GSUP_MSGT_CHECK_IMEI_ERROR, { + valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_Cause(cause)) }); + template GSUP_PDU tr_GSUP_CHECK_IMEI_ERR(template hexstring imsi, template integer cause) := tr_GSUP(OSMO_GSUP_MSGT_CHECK_IMEI_ERROR, { tr_GSUP_IE_IMSI(imsi), tr_GSUP_IE_Cause(cause) }); diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index 1dd4d05..e951400 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -70,7 +70,11 @@ OCT1 kc_support, boolean expect_tmsi, boolean expect_auth, - boolean expect_ciph + boolean expect_ciph, + boolean expect_imei, + boolean expect_imei_early, + GSUP_IMEIResult check_imei_result, + boolean check_imei_error } type record BSC_ConnHdlrPars { @@ -433,6 +437,82 @@ } } +function f_mm_imei() runs on BSC_ConnHdlr +{ + var PDU_DTAP_MT dtap_mt; + var GSUP_PDU gsup_msg; + var MobileL3_CommonIE_Types.MobileIdentityLV mi; + + if (not g_pars.net.expect_imei) { + return + } + + /* MSC <-> BSC: ID req/rsp for IMEI */ + alt { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req(CM_ID_TYPE_IMEI))) { + mi := valueof(ts_MI_IMEI_LV(g_pars.imei)); + BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_MM_ID_Rsp(mi))); + } + [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { + setverdict(fail, "Expected ID REQ for IMEI DTAP MT message, but got: ", dtap_mt); + mtc.stop; + } + } + + /* MSC <-> HLR: Check IMEI req/res/err */ + alt { + [g_pars.net.check_imei_error] GSUP.receive(tr_GSUP_CHECK_IMEI_REQ(g_pars.imsi, g_pars.imei)) { + GSUP.send(ts_GSUP_CHECK_IMEI_ERR(g_pars.imsi, 96 /* Invalid Mandatory Information */)); + } + [not g_pars.net.check_imei_error] GSUP.receive(tr_GSUP_CHECK_IMEI_REQ(g_pars.imsi, g_pars.imei)) { + GSUP.send(ts_GSUP_CHECK_IMEI_RES(g_pars.imsi, g_pars.net.check_imei_result)); + } + [] GSUP.receive(?) -> value gsup_msg { + setverdict(fail, "Expected CHECK IMEI REQ GSUP message (with IMEI:", g_pars.imei, " and IMSI: ", + g_pars.imsi, "), but got: ", gsup_msg); + mtc.stop; + } + } +} + +function f_mm_imei_early() runs on BSC_ConnHdlr +{ + var PDU_DTAP_MT dtap_mt; + var GSUP_PDU gsup_msg; + var MobileL3_CommonIE_Types.MobileIdentityLV mi; + + if (not g_pars.net.expect_imei_early) { + return + } + + /* MSC <-> BSC: ID req/rsp for IMEISV */ + alt { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_MM_ID_Req(CM_ID_TYPE_IMEISV))) { + mi := valueof(ts_MI_IMEISV_LV(g_pars.imei)); + BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_MM_ID_Rsp(mi))); + } + [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { + setverdict(fail, "Expected ID REQ for IMEISV DTAP MT message, but got: ", dtap_mt); + mtc.stop; + } + } + + /* MSC <-> HLR: Check IMEI req/res/err */ + alt { + [g_pars.net.check_imei_error] GSUP.receive(tr_GSUP_CHECK_IMEI_REQ(g_pars.imsi, g_pars.imei)) { + GSUP.send(ts_GSUP_CHECK_IMEI_ERR(g_pars.imsi, 96 /* Invalid Mandatory Information */)); + } + [not g_pars.net.check_imei_error] GSUP.receive(tr_GSUP_CHECK_IMEI_REQ(g_pars.imsi, g_pars.imei)) { + GSUP.send(ts_GSUP_CHECK_IMEI_RES(g_pars.imsi, g_pars.net.check_imei_result)); + } + [] GSUP.receive(?) -> value gsup_msg { + setverdict(fail, "Expected CHECK IMEI REQ GSUP message (with IMEI:", g_pars.imei, " and IMSI: ", + g_pars.imsi, "), but got: ", gsup_msg); + mtc.stop; + } + } +} + function f_mm_common() runs on BSC_ConnHdlr { f_mm_auth(); @@ -508,8 +588,10 @@ f_ranap_initial_ue(l3_lu); } + f_mm_imei_early(); f_mm_common(); f_msc_lu_hlr(); + f_mm_imei(); f_accept_reject_lu(); /* FIXME: there could be pending SMS or other common procedures by the MSC, let's ignore them */ f_expect_clear(); diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 6f9eecd..c7c96eb 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -335,6 +335,7 @@ /* set some defaults */ f_vty_config(MSCVTY, "network", "authentication optional"); f_vty_config(MSCVTY, "msc", "assign-tmsi"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd 0"); f_vty_config(MSCVTY, "network", "encryption a5 0"); if (mp_enable_osmux_test) { if (osmux) { @@ -367,7 +368,11 @@ kc_support := '0A'O, /* A5/1 and A5/3 enabled */ expect_tmsi := true, expect_auth := false, - expect_ciph := false + expect_ciph := false, + expect_imei := false, + expect_imei_early := false, + check_imei_result := OSMO_GSUP_IMEI_RESULT_ACK, + check_imei_error := false }; var BSC_ConnHdlrPars pars := { sccp_addr_own := g_bssap[ran_idx].sccp_addr_own, @@ -5531,6 +5536,287 @@ vc_conn.done; } +private function f_tc_lu_imsi_auth_tmsi_check_imei(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_auth := true; + pars.net.expect_imei := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_auth_tmsi_check_imei() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd 1"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth_tmsi_check_imei), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_auth3g_tmsi_check_imei(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_auth := true; + pars.use_umts_aka := true; + pars.net.expect_imei := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_auth3g_tmsi_check_imei() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd 1"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth3g_tmsi_check_imei), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_noauth_tmsi_check_imei(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_imei := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_noauth_tmsi_check_imei() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "msc", "check-imei-rqd 1"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_noauth_tmsi_check_imei), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_noauth_notmsi_check_imei(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_tmsi := false; + pars.net.expect_imei := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_noauth_notmsi_check_imei() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "msc", "no assign-tmsi"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd 1"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_noauth_notmsi_check_imei), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_auth_tmsi_check_imei_nack(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + var PDU_ML3_MS_NW l3_lu; + var PDU_DTAP_MT dtap_mt; + + pars.net.expect_auth := true; + pars.net.expect_imei := true; + pars.net.check_imei_result := OSMO_GSUP_IMEI_RESULT_NACK; + f_init_handler(pars); + + /* Cannot use f_perform_lu() as we expect a reject */ + l3_lu := f_build_lu_imsi(g_pars.imsi) + f_create_gsup_expect(hex2str(g_pars.imsi)); + f_bssap_compl_l3(l3_lu); + BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); + + f_mm_common(); + f_msc_lu_hlr(); + f_mm_imei(); + + /* Expect reject. As of writing, sometimes it passes, sometimes we get a broken pipe (race condition)! */ + alt { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { + setverdict(pass); + } + [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { + setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); + mtc.stop; + } + } +} +testcase TC_lu_imsi_auth_tmsi_check_imei_nack() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd 1"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth_tmsi_check_imei_nack), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_auth_tmsi_check_imei_err(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + var PDU_ML3_MS_NW l3_lu; + var PDU_DTAP_MT dtap_mt; + + pars.net.expect_auth := true; + pars.net.expect_imei := true; + pars.net.check_imei_error := true; + f_init_handler(pars); + + /* Cannot use f_perform_lu() as we expect a reject */ + l3_lu := f_build_lu_imsi(g_pars.imsi) + f_create_gsup_expect(hex2str(g_pars.imsi)); + f_bssap_compl_l3(l3_lu); + BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); + + f_mm_common(); + f_msc_lu_hlr(); + f_mm_imei(); + + /* Expect reject. As of writing, sometimes it passes, sometimes we get a broken pipe (race condition)! */ + alt { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { + setverdict(pass); + } + [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { + setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); + mtc.stop; + } + } +} +testcase TC_lu_imsi_auth_tmsi_check_imei_err() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd 1"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth_tmsi_check_imei_err), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_auth_tmsi_check_imei_early(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_auth := true; + pars.net.expect_imei_early := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_auth_tmsi_check_imei_early() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd early"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth_tmsi_check_imei_early), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_auth3g_tmsi_check_imei_early(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_auth := true; + pars.use_umts_aka := true; + pars.net.expect_imei_early := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_auth3g_tmsi_check_imei_early() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd early"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth3g_tmsi_check_imei_early), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_noauth_tmsi_check_imei_early(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_imei_early := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_noauth_tmsi_check_imei_early() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "msc", "check-imei-rqd early"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_noauth_tmsi_check_imei_early), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_noauth_notmsi_check_imei_early(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + pars.net.expect_tmsi := false; + pars.net.expect_imei_early := true; + f_init_handler(pars); + f_perform_lu(); +} +testcase TC_lu_imsi_noauth_notmsi_check_imei_early() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "msc", "no assign-tmsi"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd early"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_noauth_notmsi_check_imei_early), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_auth_tmsi_check_imei_early_nack(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + var PDU_ML3_MS_NW l3_lu; + var PDU_DTAP_MT dtap_mt; + + pars.net.expect_auth := true; + pars.net.expect_imei_early := true; + pars.net.check_imei_result := OSMO_GSUP_IMEI_RESULT_NACK; + f_init_handler(pars); + + /* Cannot use f_perform_lu() as we expect a reject */ + l3_lu := f_build_lu_imsi(g_pars.imsi) + f_create_gsup_expect(hex2str(g_pars.imsi)); + f_bssap_compl_l3(l3_lu); + BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); + + f_mm_imei_early(); + + /* Expect reject */ + alt { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { + setverdict(pass); + } + [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { + setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); + mtc.stop; + } + } +} +testcase TC_lu_imsi_auth_tmsi_check_imei_early_nack() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd early"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth_tmsi_check_imei_early_nack), 5); + vc_conn.done; +} + +private function f_tc_lu_imsi_auth_tmsi_check_imei_early_err(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { + var PDU_ML3_MS_NW l3_lu; + var PDU_DTAP_MT dtap_mt; + + pars.net.expect_auth := true; + pars.net.expect_imei_early := true; + pars.net.check_imei_error := true; + f_init_handler(pars); + + /* Cannot use f_perform_lu() as we expect a reject */ + l3_lu := f_build_lu_imsi(g_pars.imsi) + f_create_gsup_expect(hex2str(g_pars.imsi)); + f_bssap_compl_l3(l3_lu); + BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); + + f_mm_imei_early(); + + /* Expect reject */ + alt { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { + setverdict(pass); + } + [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { + setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); + mtc.stop; + } + } +} +testcase TC_lu_imsi_auth_tmsi_check_imei_early_err() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + f_vty_config(MSCVTY, "network", "authentication required"); + f_vty_config(MSCVTY, "msc", "check-imei-rqd early"); + + vc_conn := f_start_handler(refers(f_tc_lu_imsi_auth_tmsi_check_imei_early_err), 5); + vc_conn.done; +} control { execute( TC_cr_before_reset() ); @@ -5642,6 +5928,19 @@ execute( TC_ho_inter_msc_out() ); + execute( TC_lu_imsi_auth_tmsi_check_imei() ); + execute( TC_lu_imsi_auth3g_tmsi_check_imei() ); + execute( TC_lu_imsi_noauth_tmsi_check_imei() ); + execute( TC_lu_imsi_noauth_notmsi_check_imei() ); + execute( TC_lu_imsi_auth_tmsi_check_imei_nack() ); + execute( TC_lu_imsi_auth_tmsi_check_imei_err() ); + execute( TC_lu_imsi_auth_tmsi_check_imei_early() ); + execute( TC_lu_imsi_auth3g_tmsi_check_imei_early() ); + execute( TC_lu_imsi_noauth_tmsi_check_imei_early() ); + execute( TC_lu_imsi_noauth_notmsi_check_imei_early() ); + execute( TC_lu_imsi_auth_tmsi_check_imei_early_nack() ); + execute( TC_lu_imsi_auth_tmsi_check_imei_early_err() ); + /* Run this last: at the time of writing this test crashes the MSC */ execute( TC_lu_imsi_auth_tmsi_encr_3_1_log_msc_debug() ); execute( TC_mo_cc_bssmap_clear() ); diff --git a/msc/expected-results.xml b/msc/expected-results.xml index a60e2ec..ca8edd2 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -1,5 +1,5 @@ - + @@ -97,4 +97,20 @@ + + + + + + + + + + + + + + + + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14694 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic34bb8dc8547cafb5a53df03884554dd4f72956d Gerrit-Change-Number: 14694 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 12 06:29:06 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Fri, 12 Jul 2019 06:29:06 +0000 Subject: Change in ...osmo-msc[master]: replace osmo_counter with stat_items In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13802 ) Change subject: replace osmo_counter with stat_items ...................................................................... Patch Set 10: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/13802/10/include/osmocom/msc/gsm_data.h File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/#/c/13802/10/include/osmocom/msc/gsm_data.h at 102 PS10, Line 102: MSC_STAT_NC_SS MSC_STAT_ACTIVE_NC_SS then? ;) IMHO this way it would be cleaner. https://gerrit.osmocom.org/#/c/13802/10/src/libmsc/msc_net_init.c File src/libmsc/msc_net_init.c: https://gerrit.osmocom.org/#/c/13802/10/src/libmsc/msc_net_init.c at 71 PS10, Line 71: net->statg I would call OSMO_ASSERT() here, to be sure. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/13802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6a20123b263f4f808153794ee8a735092deb399e Gerrit-Change-Number: 13802 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 12 Jul 2019 06:29:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 12 09:13:22 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 12 Jul 2019 09:13:22 +0000 Subject: Change in ...osmo-bts[master]: Merge branch 'master' of ssh://og/osmo-bts In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14761 ) Change subject: Merge branch 'master' of ssh://og/osmo-bts ...................................................................... Patch Set 1: I have honestly no idea what this is and how I pushed it and why.. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2d9b9593a4633d78091da43f0017cbb4ec3da4ba Gerrit-Change-Number: 14761 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Vadim Yanitskiy Gerrit-Comment-Date: Fri, 12 Jul 2019 09:13:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 12 09:13:33 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 12 Jul 2019 09:13:33 +0000 Subject: Change in ...osmo-bts[master]: Merge branch 'master' of ssh://og/osmo-bts In-Reply-To: References: Message-ID: Hoernchen has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14761 ) Change subject: Merge branch 'master' of ssh://og/osmo-bts ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2d9b9593a4633d78091da43f0017cbb4ec3da4ba Gerrit-Change-Number: 14761 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Vadim Yanitskiy Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Fri Jul 12 10:36:50 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 12 Jul 2019 10:36:50 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d2862de2bca1_261c12765f428002e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-sysmon failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 84s] #define VERSION "0.1.0" [ 84s] #define STDC_HEADERS 1 [ 84s] [ 73.668252] serial8250: too much work for irq4 [ 84s] #define HAVE_SYS_TYPES_H 1 [ 84s] #define HAVE_SYS_STAT_H 1 [ 84s] #define HAVE_STDLIB_H 1 [ 84s] #define HAVE_STRING_H 1 [ 84s] #define HAVE_MEMORY_H 1 [ 84s] #define HAVE_STRINGS_H 1 [ 84s] #define HAVE_INTTYPES_H 1 [ 84s] #define HAVE_STDINT_H 1 [ 84s] #define HAVE_UNISTD_H 1 [ 84s] #define HAVE_DLFCN_H 1 [ 84s] #define LT_OBJDIR ".libs/" [ 84s] [ 84s] configure: exit 1 [ 84s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking returned exit code 1 [ 84s] make: *** [debian/rules:45: build] Error 2 [ 84s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 84s] [ 84s] sheep84 failed "build osmo-sysmon_0.1.0.dsc" at Fri Jul 12 10:36:30 UTC 2019. [ 84s] [ 84s] ### VM INTERACTION START ### [ 87s] [ 76.807521] sysrq: SysRq : Power Off [ 87s] [ 76.812533] reboot: Power down [ 87s] ### VM INTERACTION END ### [ 87s] [ 87s] sheep84 failed "build osmo-sysmon_0.1.0.dsc" at Fri Jul 12 10:36:33 UTC 2019. [ 87s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 12 10:51:07 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 12 Jul 2019 10:51:07 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d286627e46bb_261c12765f42835df@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_Testing/x86_64 Package network:osmocom:latest/openbsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 798s] | #define HAVE_MEMORY_H 1 [ 798s] | #define HAVE_STRINGS_H 1 [ 798s] | #define HAVE_INTTYPES_H 1 [ 798s] | #define HAVE_STDINT_H 1 [ 798s] | #define HAVE_UNISTD_H 1 [ 798s] | #define HAVE_DLFCN_H 1 [ 798s] | #define LT_OBJDIR ".libs/" [ 798s] | #define BUILD_SMPP 1 [ 798s] | #define STDC_HEADERS 1 [ 798s] | #define HAVE_DBI_DBD_H 1 [ 798s] | #define HAVE_PCAP_PCAP_H 1 [ 798s] | #define HAVE_TM_GMTOFF_IN_TM 1 [ 798s] | [ 798s] | configure: exit 0 [ 798s] [ 798s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 798s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 798s] make: *** [debian/rules:13: build] Error 2 [ 798s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 798s] [ 798s] lamb59 failed "build openbsc_1.2.0.dsc" at Fri Jul 12 10:50:52 UTC 2019. [ 798s] [ 798s] ### VM INTERACTION START ### [ 800s] [ 736.863631] sysrq: SysRq : Power Off [ 800s] [ 736.925166] reboot: Power down [ 801s] ### VM INTERACTION END ### [ 801s] [ 801s] lamb59 failed "build openbsc_1.2.0.dsc" at Fri Jul 12 10:50:57 UTC 2019. [ 801s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 12 13:50:51 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 12 Jul 2019 13:50:51 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d28905728faf_261c12765f4336346@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sysmon failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 106s] smon" [ 106s] #define VERSION "0.1.0" [ 106s] #define STDC_HEADERS 1 [ 106s] #define HAVE_SYS_TYPES_H 1 [ 106s] #define HAVE_SYS_STAT_H 1 [ 106s] #define HAVE_STDLIB_H 1 [ 106s] #define HAVE_STRING_H 1 [ 106s] #define HAVE_MEMORY_H 1 [ 106s] #define HAVE_STRINGS_H 1 [ 106s] #define HAVE_INTTYPES_H 1 [ 106s] #define HAVE_STDINT_H 1 [ 106s] #define HAVE_UNISTD_H 1 [ 106s] #define HAVE_DLFCN_H 1 [ 106s] #define LT_OBJDIR ".libs/" [ 106s] [ 106s] configure: exit 1 [ 106s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking returned exit code 1 [ 106s] make: *** [debian/rules:45: build] Error 2 [ 106s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 106s] [ 106s] lamb26 failed "build osmo-sysmon_0.1.0.dsc" at Fri Jul 12 13:50:34 UTC 2019. [ 106s] [ 106s] ### VM INTERACTION START ### [ 109s] [ 94.248282] sysrq: SysRq : Power Off [ 109s] [ 94.255823] reboot: Power down [ 109s] ### VM INTERACTION END ### [ 109s] [ 109s] lamb26 failed "build osmo-sysmon_0.1.0.dsc" at Fri Jul 12 13:50:38 UTC 2019. [ 109s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 12 13:54:17 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 12 Jul 2019 13:54:17 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d28912a61be2_261c12765f4337377@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_Unstable/x86_64 Package network:osmocom:latest/openbsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 171s] | #define HAVE_MEMORY_H 1 [ 171s] | #define HAVE_STRINGS_H 1 [ 171s] | #define HAVE_INTTYPES_H 1 [ 171s] | #define HAVE_STDINT_H 1 [ 171s] | #define HAVE_UNISTD_H 1 [ 171s] | #define HAVE_DLFCN_H 1 [ 171s] | #define LT_OBJDIR ".libs/" [ 171s] | #define BUILD_SMPP 1 [ 171s] | #define STDC_HEADERS 1 [ 171s] | #define HAVE_DBI_DBD_H 1 [ 171s] | #define HAVE_PCAP_PCAP_H 1 [ 171s] | #define HAVE_TM_GMTOFF_IN_TM 1 [ 171s] | [ 171s] | configure: exit 0 [ 171s] [ 171s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 171s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 171s] make: *** [debian/rules:13: build] Error 2 [ 171s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 171s] [ 171s] lamb58 failed "build openbsc_1.2.0.dsc" at Fri Jul 12 13:53:55 UTC 2019. [ 171s] [ 171s] ### VM INTERACTION START ### [ 175s] [ 161.047586] sysrq: SysRq : Power Off [ 175s] [ 161.055148] reboot: Power down [ 175s] ### VM INTERACTION END ### [ 175s] [ 175s] lamb58 failed "build openbsc_1.2.0.dsc" at Fri Jul 12 13:53:59 UTC 2019. [ 175s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 12 16:15:25 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 12 Jul 2019 16:15:25 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d28b235547ca_261c12765f435923d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_Unstable/x86_64 Package network:osmocom:latest/osmo-sysmon failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 103s] smon" [ 103s] #define VERSION "0.1.0" [ 103s] #define STDC_HEADERS 1 [ 103s] #define HAVE_SYS_TYPES_H 1 [ 103s] #define HAVE_SYS_STAT_H 1 [ 103s] #define HAVE_STDLIB_H 1 [ 103s] #define HAVE_STRING_H 1 [ 103s] #define HAVE_MEMORY_H 1 [ 103s] #define HAVE_STRINGS_H 1 [ 103s] #define HAVE_INTTYPES_H 1 [ 103s] #define HAVE_STDINT_H 1 [ 103s] #define HAVE_UNISTD_H 1 [ 103s] #define HAVE_DLFCN_H 1 [ 103s] #define LT_OBJDIR ".libs/" [ 103s] [ 103s] configure: exit 1 [ 103s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking returned exit code 1 [ 103s] make: *** [debian/rules:45: build] Error 2 [ 103s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 103s] [ 103s] lamb58 failed "build osmo-sysmon_0.1.0.dsc" at Fri Jul 12 16:15:08 UTC 2019. [ 103s] [ 103s] ### VM INTERACTION START ### [ 106s] [ 92.277883] sysrq: SysRq : Power Off [ 106s] [ 92.286077] reboot: Power down [ 106s] ### VM INTERACTION END ### [ 106s] [ 106s] lamb58 failed "build osmo-sysmon_0.1.0.dsc" at Fri Jul 12 16:15:12 UTC 2019. [ 106s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 12 16:19:42 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 12 Jul 2019 16:19:42 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d28b32393a5b_261c12765f43604d8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_Unstable/x86_64 Package network:osmocom:latest/openbsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 163s] | configure: exit 0 [ 163s] [ 163s] # -*- compilation -*- [ 163s] 4. testsuite.at:23: testing db ... [ 163s] ./testsuite.at:28: $abs_top_builddir/tests/db/db_test [ 163s] --- expout 2019-07-12 16:19:28.712000000 +0000 [ 163s] +++ /usr/src/packages/BUILD/openbsc/tests/testsuite.dir/at-groups/4/stdout 2019-07-12 16:19:28.852000000 +0000 [ 163s] @@ -1,4 +1,6 @@ [ 163s] Testing subscriber database code. [ 163s] DB: Database initialized. [ 163s] +no tables in statement ! [ 163s] +no tables in statement ! [ 163s] DB: Database prepared. [ 163s] Done [ 163s] 4. testsuite.at:23: 4. db (testsuite.at:23): FAILED (testsuite.at:28) [ 163s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 163s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 163s] make: *** [debian/rules:13: build] Error 2 [ 163s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 163s] [ 163s] morla5 failed "build openbsc_1.2.0.dsc" at Fri Jul 12 16:19:30 UTC 2019. [ 163s] [ 163s] ### VM INTERACTION START ### [ 166s] [ 151.446035] sysrq: SysRq : Power Off [ 166s] [ 151.451616] reboot: Power down [ 166s] ### VM INTERACTION END ### [ 166s] [ 166s] morla5 failed "build openbsc_1.2.0.dsc" at Fri Jul 12 16:19:33 UTC 2019. [ 166s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Jul 12 16:22:31 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 12 Jul 2019 16:22:31 +0000 Subject: Change in ...osmo-bts[master]: remove dummy UL measurement results for lost sacch frames Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14762 Change subject: remove dummy UL measurement results for lost sacch frames ...................................................................... remove dummy UL measurement results for lost sacch frames The current measurement code is able to work with too few measurement results, so adding dmumy measurements upon loss detection at the next tx time is pointless. Related: OS#3780 Change-Id: Idfa123f8d02a9d8be1f6de6923fc2a8628020145 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/62/14762/1 diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index ade3cff..72764ae 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -198,9 +198,6 @@ /* TODO: Should we pass old TOA here? Otherwise we risk * unnecessary decreasing TA */ - /* Send uplink measurement information to L2 */ - l1if_process_meas_res(l1t->trx, tn, fn, trx_chan_desc[chan].chan_nr | tn, - 456, 456, -110, 0); /* FIXME: use actual values for BER etc */ _sched_compose_ph_data_ind(l1t, tn, 0, chan, NULL, 0, -110, 0, 0, 10000, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idfa123f8d02a9d8be1f6de6923fc2a8628020145 Gerrit-Change-Number: 14762 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 12 16:23:36 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 12 Jul 2019 16:23:36 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: unbreak some measurement tests Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14763 Change subject: unbreak some measurement tests ...................................................................... unbreak some measurement tests Trxc port mapping got lost. Change-Id: I8eb766685dbf16e2eb2a973567016be3976e5840 --- M bts/BTS_Tests.ttcn 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/14763/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 3b27469..46560bb 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -2464,7 +2464,8 @@ f_init(); for (var integer ss := 0; ss <= 1; ss := ss+1) { pars := valueof(t_Pars(t_RslChanNr_Lm(5, ss), ts_RSL_ChanMode_SIGN)); - vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars); + vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars, + pcu_comp := false, trxc_comp := true); vc_conn.done; } Misc_Helpers.f_shutdown(__BFILE__, __LINE__); @@ -2475,7 +2476,8 @@ f_init(); for (var integer ss := 0; ss <= 3; ss := ss+1) { pars := valueof(t_Pars(t_RslChanNr_SDCCH4(0, ss), ts_RSL_ChanMode_SIGN)); - vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars); + vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars, + pcu_comp := false, trxc_comp := true); vc_conn.done; } Misc_Helpers.f_shutdown(__BFILE__, __LINE__); @@ -2486,7 +2488,8 @@ f_init(); for (var integer ss := 0; ss <= 7; ss := ss+1) { pars := valueof(t_Pars(t_RslChanNr_SDCCH8(6, ss), ts_RSL_ChanMode_SIGN)); - vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars); + vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars, + pcu_comp := false, trxc_comp := true); vc_conn.done; } Misc_Helpers.f_shutdown(__BFILE__, __LINE__); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8eb766685dbf16e2eb2a973567016be3976e5840 Gerrit-Change-Number: 14763 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 12 18:57:35 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Fri, 12 Jul 2019 18:57:35 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: unbreak some measurement tests In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14763 ) Change subject: unbreak some measurement tests ...................................................................... Patch Set 1: Code-Review+1 Fine by me, excluding the "misaligned alignment". -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8eb766685dbf16e2eb2a973567016be3976e5840 Gerrit-Change-Number: 14763 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Fri, 12 Jul 2019 18:57:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 12 19:14:57 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 12 Jul 2019 19:14:57 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: unbreak some measurement tests In-Reply-To: References: Message-ID: Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14763 to look at the new patch set (#2). Change subject: unbreak some measurement tests ...................................................................... unbreak some measurement tests Trxc port mapping got lost. Change-Id: I8eb766685dbf16e2eb2a973567016be3976e5840 --- M bts/BTS_Tests.ttcn 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/14763/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8eb766685dbf16e2eb2a973567016be3976e5840 Gerrit-Change-Number: 14763 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 12 19:32:00 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Fri, 12 Jul 2019 19:32:00 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: unbreak some measurement tests In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14763 ) Change subject: unbreak some measurement tests ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8eb766685dbf16e2eb2a973567016be3976e5840 Gerrit-Change-Number: 14763 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Fri, 12 Jul 2019 19:32:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Sat Jul 13 02:44:24 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 02:44:24 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d29458a4da2d_261c12765f4422038@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 745s] | configure:12572: checking execinfo.h usability [ 746s] | configure:12572: gcc -c -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 conftest.c >&5 [ 746s] | configure:12572: $? = 0 [ 746s] | configure:12572: result: yes [ 746s] | configure:12572: checking execinfo.h presence [ 746s] | configure:12572: gcc -E -Wdate-time -D_FORTIFY_SOURCE=2 conftest.c [ 746s] | configure:12572: $? = 0 [ 746s] | configure:12572: result: yes [ 746s] | configure:12572: checking for execinfo.h [ 746s] | configure:12572: result: yes [ 746s] | configure:12572: checking sys/select.h usability [ 746s] | configure:12572: gcc -c -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 conftest.c >&5 [ 746s] | configure:12572: $? = 0 [ 746s] | configure:12572: result: yes [ 746s] | configure:12572: checking sys/select.h presence [ 746s] | configure:12572: gcc -E -Wdate-time -D_FORTIFY_SOURCE=2 conftest.c [ 746s] | configure:12572: $? = 0 [ 746s] | configure:12572: result: yes [ 746s] | configure:12572: checking for sys/select.h [ 746s] | configure:12572: result: yes [ 746s] | configure:12572: checking sys/socket.h usability [ 746s] | configure:12572: gcc -c -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 conftest.c >&5 [ 746s] | configure:12572: $? = 0 [ 748s] | c[ 699.871292] sysrq: SysRq : Power Off [ 748s] [ 699.873349] reboot: Power down [ 748s] ### VM INTERACTION END ### [ 748s] [ 748s] armbuild18 failed "build libosmocore_1.1.0.79.a3dec.dsc" at Sat Jul 13 02:44:15 UTC 2019. [ 748s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 03:07:33 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 03:07:33 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d294b0b60b69_261c12765f44228df@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 664s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 664s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 664s] collect2: error: ld returned 1 exit status [ 664s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 664s] make[4]: *** [osmo-bts-virtual] Error 1 [ 664s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 664s] Makefile:385: recipe for target 'all-recursive' failed [ 664s] make[3]: *** [all-recursive] Error 1 [ 664s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 664s] Makefile:434: recipe for target 'all-recursive' failed [ 664s] make[2]: *** [all-recursive] Error 1 [ 664s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 664s] Makefile:366: recipe for target 'all' failed [ 664s] make[1]: *** [all] Error 2 [ 664s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 664s] dh_auto_build: make -j1 returned exit code 2 [ 664s] debian/rules:12: recipe for target 'build' failed [ 664s] make: *** [build] Error 2 [ 664s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 664s] [ 664s] obs-arm-6 failed "build osmo-bts_0.8.1.336.04e9.dsc" at Sat Jul 13 03:07:23 UTC 2019. [ 664s] [ 664s] ### VM INTERACTION START ### [ 667s] [ 602.279357] sysrq: SysRq : Power Off [ 667s] [ 602.298916] reboot: Power down [ 667s] ### VM INTERACTION END ### [ 667s] [ 667s] obs-arm-6 failed "build osmo-bts_0.8.1.336.04e9.dsc" at Sat Jul 13 03:07:26 UTC 2019. [ 667s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 03:36:41 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 03:36:41 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2951d8d6034_261c12765f4426338@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 475s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 475s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 475s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 475s] Makefile:442: recipe for target 'vlr.o' failed [ 475s] make[4]: *** [vlr.o] Error 1 [ 475s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 475s] Makefile:422: recipe for target 'all-recursive' failed [ 475s] make[3]: *** [all-recursive] Error 1 [ 475s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 475s] Makefile:462: recipe for target 'all-recursive' failed [ 475s] make[2]: *** [all-recursive] Error 1 [ 475s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 475s] Makefile:394: recipe for target 'all' failed [ 475s] make[1]: *** [all] Error 2 [ 475s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 475s] dh_auto_build: make -j1 returned exit code 2 [ 475s] debian/rules:45: recipe for target 'build' failed [ 475s] make: *** [build] Error 2 [ 475s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 475s] [ 475s] armbuild21 failed "build osmo-msc_1.3.1.178.aa0a.dsc" at Sat Jul 13 03:36:31 UTC 2019. [ 475s] [ 475s] ### VM INTERACTION START ### [ 478s] [ 457.787285] sysrq: SysRq : Power Off [ 478s] [ 457.839087] reboot: Power down [ 479s] ### VM INTERACTION END ### [ 479s] [ 479s] armbuild21 failed "build osmo-msc_1.3.1.178.aa0a.dsc" at Sat Jul 13 03:36:35 UTC 2019. [ 479s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 03:37:32 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 03:37:32 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d29521691998_261c12765f44264da@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-sysmon failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 97s] #define VERSION "0.1.0" [ 97s] #define STDC_HEADERS 1 [ 97s] [ 80.612115] serial8250: too much work for irq4 [ 97s] #define HAVE_SYS_TYPES_H 1 [ 97s] #define HAVE_SYS_STAT_H 1 [ 97s] #define HAVE_STDLIB_H 1 [ 97s] #define HAVE_STRING_H 1 [ 97s] #define HAVE_MEMORY_H 1 [ 97s] #define HAVE_STRINGS_H 1 [ 97s] #define HAVE_INTTYPES_H 1 [ 97s] #define HAVE_STDINT_H 1 [ 97s] #define HAVE_UNISTD_H 1 [ 97s] #define HAVE_DLFCN_H 1 [ 97s] #define LT_OBJDIR ".libs/" [ 97s] [ 97s] configure: exit 1 [ 97s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking returned exit code 1 [ 97s] make: *** [debian/rules:45: build] Error 2 [ 97s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 97s] [ 97s] build32 failed "build osmo-sysmon_0.1.0.dsc" at Sat Jul 13 03:37:14 UTC 2019. [ 97s] [ 97s] ### VM INTERACTION START ### [ 100s] [ 83.797704] sysrq: SysRq : Power Off [ 100s] [ 83.805707] reboot: Power down [ 100s] ### VM INTERACTION END ### [ 101s] [ 101s] build32 failed "build osmo-sysmon_0.1.0.dsc" at Sat Jul 13 03:37:18 UTC 2019. [ 101s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 03:37:49 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 03:37:49 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d295217bad05_261c12765f4426562@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 521s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 521s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 521s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 521s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 521s] make[4]: *** [gb_proxy.o] Error 1 [ 521s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 521s] Makefile:391: recipe for target 'all-recursive' failed [ 521s] make[3]: *** [all-recursive] Error 1 [ 521s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 521s] Makefile:453: recipe for target 'all-recursive' failed [ 521s] make[2]: *** [all-recursive] Error 1 [ 521s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 521s] Makefile:385: recipe for target 'all' failed [ 521s] make[1]: *** [all] Error 2 [ 521s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 521s] dh_auto_build: make -j1 returned exit code 2 [ 521s] debian/rules:45: recipe for target 'build' failed [ 521s] make: *** [build] Error 2 [ 521s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 521s] [ 521s] armbuild04 failed "build osmo-sgsn_1.4.0.28.43f16.dsc" at Sat Jul 13 03:37:30 UTC 2019. [ 521s] [ 521s] ### VM INTERACTION START ### [ 524s] [ 490.504549] sysrq: SysRq : Power Off [ 524s] [ 490.526165] reboot: Power down [ 525s] ### VM INTERACTION END ### [ 525s] [ 525s] armbuild04 failed "build osmo-sgsn_1.4.0.28.43f16.dsc" at Sat Jul 13 03:37:34 UTC 2019. [ 525s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 03:38:59 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 03:38:59 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d29526fce18e_261c12765f4426737@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_Testing/x86_64 Package network:osmocom:latest/openbsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 99s] | configure: exit 0 [ 99s] [ 99s] # -*- compilation -*- [ 99s] 4. testsuite.at:23: testing db ... [ 99s] ./testsuite.at:28: $abs_top_builddir/tests/db/db_test [ 99s] --- expout 2019-07-13 03:38:46.410645527 +0000 [ 99s] +++ /usr/src/packages/BUILD/openbsc/tests/testsuite.dir/at-groups/4/stdout 2019-07-13 03:38:46.494645525 +0000 [ 99s] @@ -1,4 +1,6 @@ [ 99s] Testing subscriber database code. [ 99s] DB: Database initialized. [ 99s] +no tables in statement ! [ 99s] +no tables in statement ! [ 99s] DB: Database prepared. [ 99s] Done [ 99s] 4. testsuite.at:23: 4. db (testsuite.at:23): FAILED (testsuite.at:28) [ 99s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 99s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 99s] make: *** [debian/rules:13: build] Error 2 [ 99s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 99s] [ 99s] build70 failed "build openbsc_1.2.0.dsc" at Sat Jul 13 03:38:47 UTC 2019. [ 99s] [ 99s] ### VM INTERACTION START ### [ 102s] [ 92.752899] sysrq: SysRq : Power Off [ 102s] [ 92.754654] reboot: Power down [ 102s] ### VM INTERACTION END ### [ 102s] [ 102s] build70 failed "build openbsc_1.2.0.dsc" at Sat Jul 13 03:38:50 UTC 2019. [ 102s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Sat Jul 13 03:48:48 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Jul 2019 03:48:48 +0000 Subject: Change in ...docker-playground[master]: adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7 Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14764 Change subject: adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7 ...................................................................... adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7 - Actually enable handover. - Add bts 3 Related: osmo-ttcn3-hacks Ia4ba0e75abd3d45a3422b2525e5f938cdc5a04cc Change-Id: I1c57a04747f5ec004ccf4657954dcb0b003c24fc --- M ttcn3-bsc-test/osmo-bsc.cfg 1 file changed, 30 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/64/14764/1 diff --git a/ttcn3-bsc-test/osmo-bsc.cfg b/ttcn3-bsc-test/osmo-bsc.cfg index 3d226e9..6cfaf7c 100644 --- a/ttcn3-bsc-test/osmo-bsc.cfg +++ b/ttcn3-bsc-test/osmo-bsc.cfg @@ -66,7 +66,7 @@ encryption a5 0 1 3 neci 1 paging any use tch 0 - handover 0 + handover 1 handover window rxlev averaging 10 handover window rxqual averaging 1 handover window rxlev neighbor averaging 10 @@ -350,6 +350,35 @@ timeslot 7 phys_chan_config PDCH hopping enabled 0 + bts 3 + type sysmobts + band DCS1800 + cell_identity 3 + location_area_code 3 + # re-use bts 2's ARFCN 871 and BSIC 12 (to test handover config) + base_station_id_code 12 + trx 0 + rf_locked 0 + arfcn 871 + nominal power 23 + max_power_red 20 + rsl e1 tei 0 + timeslot 0 + phys_chan_config CCCH+SDCCH4 + timeslot 1 + phys_chan_config TCH/F + timeslot 2 + phys_chan_config TCH/F + timeslot 3 + phys_chan_config TCH/F + timeslot 4 + phys_chan_config TCH/F + timeslot 5 + phys_chan_config TCH/H + timeslot 6 + phys_chan_config PDCH + timeslot 7 + phys_chan_config PDCH msc 0 ip.access rtp-base 4000 no bsc-welcome-text -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14764 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1c57a04747f5ec004ccf4657954dcb0b003c24fc Gerrit-Change-Number: 14764 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 13 03:49:18 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Jul 2019 03:49:18 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: bsc: add TC_ho_neighbor_config_1 thru _7 Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14765 Change subject: bsc: add TC_ho_neighbor_config_1 thru _7 ...................................................................... bsc: add TC_ho_neighbor_config_1 thru _7 Add tests to play through various neighbor configurations. Tests will pass as soon as osmo-bsc I29bca59ab232eddc74e0d4698efb9c9992443983 is merged. Add RSL2 to allow triggering handover to BTS 2. Adjust osmo-bsc.cfg to match the new tests. Also applied in docker-playground I1c57a04747f5ec004ccf4657954dcb0b003c24fc. - Actually enable handover. - Add bts 3 Depends: osmo-bsc I8623ab581639e9f8af6a9ff1eca990518d1b1211 ('no neighbors') Related: OS#4056 Change-Id: Ia4ba0e75abd3d45a3422b2525e5f938cdc5a04cc --- M bsc/BSC_Tests.ttcn M bsc/BSC_Tests_LCLS.ttcn M bsc/osmo-bsc.cfg M library/RSL_Emulation.ttcn 4 files changed, 395 insertions(+), 171 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/14765/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 44a9172..adffdf9 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1719,6 +1719,10 @@ connect(vc_conn:RSL1, bts[1].rsl.vc_RSL:CLIENT_PT); connect(vc_conn:RSL1_PROC, bts[1].rsl.vc_RSL:RSL_PROC); } + if (isvalue(bts[2])) { + connect(vc_conn:RSL2, bts[2].rsl.vc_RSL:CLIENT_PT); + connect(vc_conn:RSL2_PROC, bts[2].rsl.vc_RSL:RSL_PROC); + } connect(vc_conn:BSSAP, g_bssap.vc_RAN:CLIENT); connect(vc_conn:MGCP, vc_MGCP:MGCP_CLIENT); connect(vc_conn:MGCP_MULTI, vc_MGCP:MGCP_CLIENT_MULTI); @@ -2837,6 +2841,11 @@ f_vty_transceive(BSCVTY, cmd & suffix); } +/* Even though the VTY command to trigger handover takes a new BTS number as argument, behind the scenes osmo-bsc always + * translates that to a target ARFCN+BSIC first. See bsc_vty.c trigger_ho_or_as(), which puts the selected BTS' neighbor + * ident key (ARFCN + BSIC) in the struct passed on to handover_request(). handover_start() then resolves that to a + * viable actual neighbor cell. So from the internal osmo-bsc perspective, we always request handover to an ARFCN + BSIC + * pair, not really to a specific BTS number. */ private function f_vty_handover(integer bts_nr, integer trx_nr, RslChannelNr chan_nr, integer new_bts_nr) runs on MSC_ConnHdlr { @@ -3587,6 +3596,353 @@ vc_conn.done; } +type record of charstring Commands; + +private function f_bts_0_cfg(Commands cmds := {}) runs on MSC_ConnHdlr +{ + f_vty_enter_cfg_bts(BSCVTY, 0); + for (var integer i := 0; i < sizeof(cmds); i := i+1) { + f_vty_transceive(BSCVTY, cmds[i]); + } + f_vty_transceive(BSCVTY, "end"); +} + +private function f_probe_for_handover(charstring log_label, + charstring log_descr, + charstring handover_vty_cmd, + boolean expect_handover, + boolean is_inter_bsc_handover := false) +runs on MSC_ConnHdlr +{ + var RSL_Message rsl; + + var charstring log_msg := " (expecting handover)" + if (not expect_handover) { + log_msg := " (expecting NO handover)"; + } + log("f_probe_for_handover starting: " & log_label & ": " & log_descr & log_msg); + f_vty_transceive(BSCVTY, handover_vty_cmd); + + /* We're going to thwart any and all handover attempts, just be ready to handle (and ignore) handover target + * lchans to be established on bts 1 or bts 2. */ + f_rslem_suspend(RSL1_PROC); + f_rslem_suspend(RSL2_PROC); + + timer T := 2.0; + T.start; + + alt { + [] RSL.receive(tr_RSL_DATA_REQ(g_chan_nr)) -> value rsl { + var PDU_ML3_NW_MS l3 := dec_PDU_ML3_NW_MS(rsl.ies[2].body.l3_info.payload); + log("Rx L3 from net: ", l3); + if (ischosen(l3.msgs.rrm.handoverCommand)) { + var RslChannelNr new_chan_nr; + var GsmArfcn arfcn; + f_ChDesc2RslChanNr(l3.msgs.rrm.handoverCommand.channelDescription2, + new_chan_nr, arfcn); + log("Handover to new chan ", new_chan_nr, " on ARFCN ", arfcn); + log(l3.msgs.rrm.handoverCommand); + + /* Need to register for new lchan on new BTS -- it's either bts 1 or bts 2. It doesn't really + * matter on which BTS it really is, we're not going to follow through an entire handover + * anyway. */ + f_rslem_register(0, new_chan_nr, RSL1_PROC); + f_rslem_resume(RSL1_PROC); + f_rslem_register(0, new_chan_nr, RSL2_PROC); + f_rslem_resume(RSL2_PROC); + + if (expect_handover and not is_inter_bsc_handover) { + setverdict(pass); + log("f_probe_for_handover(" & log_label & "): Got RSL Handover Command as expected."); + } else { + setverdict(fail, "f_probe_for_handover(" & log_label & "): Expected none, but got RSL Handover Command. " + & log_label & ": " & log_descr); + } + + log("f_probe_for_handover(" & log_label & "): Ending the test: Handover Failure stops the procedure."); + /* osmo-bsc has triggered Handover. That's all we need to know for this test, reply with + * Handover Failure. */ + f_rsl_send_l3(ts_RRM_HandoverFailure('00'O)); + + /* target BTS is told to release lchan again; don't care which BTS nor what messages. */ + f_sleep(0.5); + RSL1.clear; + RSL2.clear; + log("f_probe_for_handover(" & log_label & "): done (got RSL Handover Command)"); + break; + } else { + repeat; + } + } + [] BSSAP.receive(tr_BSSMAP_HandoverRequired) { + if (expect_handover and is_inter_bsc_handover) { + setverdict(pass); + log("f_probe_for_handover(" & log_label & "): Got BSSMAP Handover Required as expected."); + } else { + setverdict(fail, "f_probe_for_handover(" & log_label & "): Expected none, but got BSSMAP Handover Required. " + & log_label & ": " & log_descr); + } + + log("f_probe_for_handover(" & log_label & "): done (got BSSMAP Handover Required)"); + + /* Note: f_tc_ho_neighbor_config_start() sets T7, the timeout for BSSMAP Handover Required, to + * 1 second. There is no legal way to quickly abort a handover after a BSSMAP Handover Required, + * setting a short timeout and waiting is the only way. */ + log("f_probe_for_handover(" & log_label & "): waiting for inter-BSC HO to time out..."); + f_sleep(1.5); + log("f_probe_for_handover(" & log_label & "): ...done"); + + break; + } + [] T.timeout { + if (expect_handover) { + setverdict(fail, "f_probe_for_handover(" & log_label & "): Expected Handover, but got none. " + & log_label & ": " & log_descr); + } else { + setverdict(pass); + log("f_probe_for_handover(" & log_label & "): Got no Handover, as expected."); + } + log("f_probe_for_handover(" & log_label & "): done (got no Handover)"); + break; + } + } + + f_rslem_resume(RSL1_PROC); + f_rslem_resume(RSL2_PROC); + f_sleep(3.0); + RSL.clear; + + log("f_probe_for_handover(" & log_label & "): done clearing"); +} + +/* Test the effect of various neighbor configuration scenarios: + * + * To avoid complexity, block off any actual handover operation, and always remain on the lchan at bts 0. + * Reconfigure the neighbors for bts 0, trigger a Handover, and probe whether osmo-bsc does or doesn't start HO. + */ +private function f_tc_ho_neighbor_config_start() runs on MSC_ConnHdlr { + g_pars := f_gen_test_hdlr_pars(); + var template PDU_BSSAP exp_compl := f_gen_exp_compl(); + var PDU_BSSAP ass_cmd := f_gen_ass_req(); + const OCT8 kc := '0001020304050607'O; + + ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelType); + ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR})); + + /* Establish lchan at bts 0 */ + f_establish_fully(ass_cmd, exp_compl); + + /* Shorten the inter-BSC Handover timeout, to not wait so long for inter-BSC Handovers */ + f_vty_enter_cfg_network(BSCVTY); + f_vty_transceive(BSCVTY, "timer T7 1"); + f_vty_transceive(BSCVTY, "end"); +} + +private function f_tc_ho_neighbor_config_1(charstring id) runs on MSC_ConnHdlr { + f_tc_ho_neighbor_config_start(); + + /* + * bts 0 ARFCN 871 BSIC 10 + * bts 1 ARFCN 871 BSIC 11 + * bts 2 ARFCN 871 BSIC 12 + * bts 3 ARFCN 871 BSIC 12 serves as ambiguity for bts 2, re-using the ARFCN+BSIC + */ + + log("f_tc_ho_neighbor_config: 1. No 'neighbor' config"); + f_bts_0_cfg({"no neighbors"}); + f_probe_for_handover("1.a", "HO to bts 1 works, implicitly listed as neighbor (legacy behavior when none are configured)", + "handover any to arfcn 871 bsic 11", + true); + + f_probe_for_handover("1.b", "HO to unknown cell does not start", + "handover any to arfcn 13 bsic 39", + false); + + f_probe_for_handover("1.c", "HO to 871-12 is ambiguous = error", + "handover any to arfcn 871 bsic 12", + false); + + f_probe_for_handover("1.d", "HO to 871-11 still works (verify that this test properly cleans up)", + "handover any to arfcn 871 bsic 11", + true); +} +private function f_tc_ho_neighbor_config_2(charstring id) runs on MSC_ConnHdlr { + f_tc_ho_neighbor_config_start(); + + /* + * bts 0 ARFCN 871 BSIC 10 + * bts 1 ARFCN 871 BSIC 11 + * bts 2 ARFCN 871 BSIC 12 + * bts 3 ARFCN 871 BSIC 12 serves as ambiguity for bts 2, re-using the ARFCN+BSIC + */ + + log("f_tc_ho_neighbor_config: 2. explicit local neighbor: 'neighbor bts 1'"); + f_bts_0_cfg({"neighbor bts 1"}); + f_sleep(0.5); + + f_probe_for_handover("2.a", "HO to bts 1 works, explicitly listed as neighbor", + "handover any to arfcn 871 bsic 11", + true); + + f_probe_for_handover("2.b", "HO to bts 2 doesn't work, not listed as neighbor", + "handover any to arfcn 871 bsic 12", + false); +} +private function f_tc_ho_neighbor_config_3(charstring id) runs on MSC_ConnHdlr { + f_tc_ho_neighbor_config_start(); + + /* + * bts 0 ARFCN 871 BSIC 10 + * bts 1 ARFCN 871 BSIC 11 + * bts 2 ARFCN 871 BSIC 12 + * bts 3 ARFCN 871 BSIC 12 serves as ambiguity for bts 2, re-using the ARFCN+BSIC + */ + + log("f_tc_ho_neighbor_config: 3. explicit local neighbor: 'neighbor bts 2'"); + f_bts_0_cfg({"no neighbors", "neighbor bts 2"}); + f_sleep(0.5); + + f_probe_for_handover("3.a", "HO to bts 1 doesn't work, not listed as neighbor", + "handover any to arfcn 871 bsic 11", + false); + f_probe_for_handover("3.b", "HO to bts 2 works, explicitly listed as neighbor; no ambiguity because bts 3 is not listed as neighbor", + "handover any to arfcn 871 bsic 12", + true); +} +private function f_tc_ho_neighbor_config_4(charstring id) runs on MSC_ConnHdlr { + f_tc_ho_neighbor_config_start(); + + /* + * bts 0 ARFCN 871 BSIC 10 + * bts 1 ARFCN 871 BSIC 11 + * bts 2 ARFCN 871 BSIC 12 + * bts 3 ARFCN 871 BSIC 12 serves as ambiguity for bts 2, re-using the ARFCN+BSIC + */ + + log("f_tc_ho_neighbor_config: 4. explicit remote neighbor: 'neighbor lac 99 arfcn 123 bsic 45'"); + f_bts_0_cfg({"no neighbors", "neighbor lac 99 arfcn 123 bsic 45"}); + f_sleep(0.5); + + f_probe_for_handover("4.a", "HO to bts 1 doesn't work, not listed as neighbor", + "handover any to arfcn 871 bsic 11", + false); + f_probe_for_handover("4.b", "HO to bts 2 doesn't work, not listed as neighbor", + "handover any to arfcn 871 bsic 12", + false); + f_probe_for_handover("4.c", "HO to 123-45 triggers inter-BSC HO", + "handover any to arfcn 123 bsic 45", + true, true); +} +private function f_tc_ho_neighbor_config_5(charstring id) runs on MSC_ConnHdlr { + f_tc_ho_neighbor_config_start(); + + /* + * bts 0 ARFCN 871 BSIC 10 + * bts 1 ARFCN 871 BSIC 11 + * bts 2 ARFCN 871 BSIC 12 + * bts 3 ARFCN 871 BSIC 12 serves as ambiguity for bts 2, re-using the ARFCN+BSIC + */ + + log("f_tc_ho_neighbor_config: 5. explicit remote neighbor re-using ARFCN+BSIC: 'neighbor lac 99 arfcn 871 bsic 12'"); + f_bts_0_cfg({"no neighbors", "neighbor lac 99 arfcn 871 bsic 12"}); + f_sleep(0.5); + + f_probe_for_handover("5.a", "HO to 871-12 triggers inter-BSC HO (ignoring local cells with same ARFCN+BSIC)", + "handover any to arfcn 871 bsic 12", + true, true); +} +private function f_tc_ho_neighbor_config_6(charstring id) runs on MSC_ConnHdlr { + f_tc_ho_neighbor_config_start(); + + /* + * bts 0 ARFCN 871 BSIC 10 + * bts 1 ARFCN 871 BSIC 11 + * bts 2 ARFCN 871 BSIC 12 + * bts 3 ARFCN 871 BSIC 12 serves as ambiguity for bts 2, re-using the ARFCN+BSIC + */ + + log("f_tc_ho_neighbor_config: 6. config error: explicit local and remote neighbors with ambiguous ARFCN+BSIC:" + & " 'neighbor bts 2; neighbor lac 99 arfcn 871 bsic 12'"); + f_bts_0_cfg({"no neighbors", "neighbor bts 2", "neighbor lac 99 arfcn 871 bsic 12"}); + f_sleep(0.5); + + f_probe_for_handover("6.a", "HO to 871-12 is ambiguous = error", + "handover any to arfcn 871 bsic 12", + false); +} +private function f_tc_ho_neighbor_config_7(charstring id) runs on MSC_ConnHdlr { + f_tc_ho_neighbor_config_start(); + + /* + * bts 0 ARFCN 871 BSIC 10 + * bts 1 ARFCN 871 BSIC 11 + * bts 2 ARFCN 871 BSIC 12 + * bts 3 ARFCN 871 BSIC 12 serves as ambiguity for bts 2, re-using the ARFCN+BSIC + */ + + log("f_tc_ho_neighbor_config: 7. explicit local and remote neighbors:" + & " 'neighbor bts 2; neighbor lac 99 arfcn 123 bsic 45'"); + f_bts_0_cfg({"no neighbors", "neighbor bts 2", "neighbor lac 99 arfcn 123 bsic 45"}); + f_sleep(0.5); + + f_probe_for_handover("7.a", "HO to 871-12 does HO to bts 2", + "handover any to arfcn 871 bsic 12", + true); + f_probe_for_handover("7.b", "HO to 123-45 triggers inter-BSC HO", + "handover any to arfcn 123 bsic 45", + true, true); +} + +testcase TC_ho_neighbor_config_1() runs on test_CT { + var MSC_ConnHdlr vc_conn; + f_init(3, true); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_1)); + vc_conn.done; +} +testcase TC_ho_neighbor_config_2() runs on test_CT { + var MSC_ConnHdlr vc_conn; + f_init(3, true); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_2)); + vc_conn.done; +} +testcase TC_ho_neighbor_config_3() runs on test_CT { + var MSC_ConnHdlr vc_conn; + f_init(3, true); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_3)); + vc_conn.done; +} +testcase TC_ho_neighbor_config_4() runs on test_CT { + var MSC_ConnHdlr vc_conn; + f_init(3, true); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_4)); + vc_conn.done; +} +testcase TC_ho_neighbor_config_5() runs on test_CT { + var MSC_ConnHdlr vc_conn; + f_init(3, true); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_5)); + vc_conn.done; +} +testcase TC_ho_neighbor_config_6() runs on test_CT { + var MSC_ConnHdlr vc_conn; + f_init(3, true); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_6)); + vc_conn.done; +} +testcase TC_ho_neighbor_config_7() runs on test_CT { + var MSC_ConnHdlr vc_conn; + f_init(3, true); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_tc_ho_neighbor_config_7)); + vc_conn.done; +} + /* OS#3041: Open and close N connections in a normal fashion, and expect no * BSSMAP Reset just because of that. */ testcase TC_bssap_rlsd_does_not_cause_bssmap_reset() runs on test_CT { @@ -4001,161 +4357,13 @@ */ control { - /* CTRL interface testing */ - execute( TC_ctrl_msc_connection_status() ); - execute( TC_ctrl_msc0_connection_status() ); - execute( TC_ctrl() ); - if (mp_bssap_cfg.transport == BSSAP_TRANSPORT_SCCPlite_SERVER) { - execute( TC_ctrl_location() ); - } - - /* RSL DCHAN Channel ACtivation / Deactivation */ - execute( TC_chan_act_noreply() ); - execute( TC_chan_act_counter() ); - execute( TC_chan_act_ack_noest() ); - execute( TC_chan_act_ack_est_ind_noreply() ); - execute( TC_chan_act_ack_est_ind_refused() ); - execute( TC_chan_act_nack() ); - execute( TC_chan_exhaustion() ); - execute( TC_chan_deact_silence() ); - execute( TC_chan_rel_rll_rel_ind() ); - execute( TC_chan_rel_conn_fail() ); - execute( TC_chan_rel_hard_clear() ); - execute( TC_chan_rel_hard_clear_csfb() ); - execute( TC_chan_rel_hard_rlsd() ); - execute( TC_chan_rel_hard_rlsd_ms_dead() ); - execute( TC_chan_rel_a_reset() ); - - execute( TC_outbound_connect() ); - - /* Assignment related */ - execute( TC_assignment_cic_only() ); - execute( TC_assignment_csd() ); - execute( TC_assignment_ctm() ); - execute( TC_assignment_sign() ); - execute( TC_assignment_fr_a5_0() ); - execute( TC_assignment_fr_a5_1() ); - if (mp_bssap_cfg.transport == BSSAP_TRANSPORT_AoIP) { - execute( TC_assignment_fr_a5_1_codec_missing() ); - } - execute( TC_assignment_fr_a5_3() ); - execute( TC_assignment_fr_a5_4() ); - execute( TC_ciph_mode_a5_0() ); - execute( TC_ciph_mode_a5_1() ); - execute( TC_ciph_mode_a5_3() ); - - execute( TC_assignment_codec_fr() ); - execute( TC_assignment_codec_hr() ); - execute( TC_assignment_codec_efr() ); - execute( TC_assignment_codec_amr_f() ); - execute( TC_assignment_codec_amr_h() ); - - if (mp_bssap_cfg.transport == BSSAP_TRANSPORT_AoIP) { - execute( TC_assignment_codec_amr_f_S1() ); - execute( TC_assignment_codec_amr_h_S1() ); - execute( TC_assignment_codec_amr_f_S124() ); - execute( TC_assignment_codec_amr_h_S124() ); - execute( TC_assignment_codec_amr_f_S0() ); - execute( TC_assignment_codec_amr_f_S02() ); - execute( TC_assignment_codec_amr_f_S024() ); - execute( TC_assignment_codec_amr_f_S0247() ); - execute( TC_assignment_codec_amr_h_S0() ); - execute( TC_assignment_codec_amr_h_S02() ); - execute( TC_assignment_codec_amr_h_S024() ); - execute( TC_assignment_codec_amr_h_S0247() ); - execute( TC_assignment_codec_amr_f_S01234567() ); - execute( TC_assignment_codec_amr_f_S0234567() ); - execute( TC_assignment_codec_amr_f_zero() ); - execute( TC_assignment_codec_amr_f_unsupp() ); - execute( TC_assignment_codec_amr_h_S7() ); - } - - execute( TC_assignment_codec_fr_exhausted_req_hr() ); - execute( TC_assignment_codec_fr_exhausted_req_fr() ); - execute( TC_assignment_codec_fr_exhausted_req_fr_hr() ); - execute( TC_assignment_codec_fr_exhausted_req_hr_fr() ); - execute( TC_assignment_codec_hr_exhausted_req_fr() ); - execute( TC_assignment_codec_hr_exhausted_req_hr() ); - execute( TC_assignment_codec_hr_exhausted_req_hr_fr() ); - execute( TC_assignment_codec_hr_exhausted_req_fr_hr() ); - execute( TC_assignment_codec_req_hr_fr() ); - execute( TC_assignment_codec_req_fr_hr() ); - - if (mp_enable_osmux_test) { - execute( TC_assignment_osmux() ); - } - - /* RLL Establish Indication on inactive DCHAN / SAPI */ - execute( TC_rll_est_ind_inact_lchan() ); - execute( TC_rll_est_ind_inval_sapi1() ); - execute( TC_rll_est_ind_inval_sapi3() ); - execute( TC_rll_est_ind_inval_sacch() ); - - /* Paging related tests */ - execute( TC_paging_imsi_nochan() ); - execute( TC_paging_tmsi_nochan() ); - execute( TC_paging_tmsi_any() ); - execute( TC_paging_tmsi_sdcch() ); - execute( TC_paging_tmsi_tch_f() ); - execute( TC_paging_tmsi_tch_hf() ); - execute( TC_paging_imsi_nochan_cgi() ); - execute( TC_paging_imsi_nochan_lac_ci() ); - execute( TC_paging_imsi_nochan_ci() ); - execute( TC_paging_imsi_nochan_lai() ); - execute( TC_paging_imsi_nochan_lac() ); - execute( TC_paging_imsi_nochan_all() ); - execute( TC_paging_imsi_nochan_plmn_lac_rnc() ); - execute( TC_paging_imsi_nochan_rnc() ); - execute( TC_paging_imsi_nochan_lac_rnc() ); - execute( TC_paging_imsi_nochan_lacs() ); - execute( TC_paging_imsi_nochan_lacs_empty() ); - execute( TC_paging_imsi_nochan_cgi_unknown_cid() ); - execute( TC_paging_imsi_a_reset() ); - execute( TC_paging_imsi_load() ); - execute( TC_paging_counter() ); - execute( TC_paging_resp_unsol() ); - - execute( TC_rsl_drop_counter() ); - execute( TC_rsl_unknown_unit_id() ); - - execute( TC_oml_unknown_unit_id() ); - - execute( TC_classmark() ); - execute( TC_unsol_ass_fail() ); - execute( TC_unsol_ass_compl() ); - execute( TC_unsol_ho_fail() ); - execute( TC_err_82_short_msg() ); - execute( TC_err_84_unknown_msg() ); - - execute( TC_ho_int() ); - - execute( TC_ho_out_of_this_bsc() ); - execute( TC_ho_out_fail_no_msc_response() ); - execute( TC_ho_out_fail_rr_ho_failure() ); - execute( TC_ho_out_fail_no_result_after_ho_cmd() ); - - execute( TC_ho_into_this_bsc() ); - execute( TC_ho_in_fail_msc_clears() ); - execute( TC_ho_in_fail_msc_clears_after_ho_detect() ); - execute( TC_ho_in_fail_no_detect() ); - execute( TC_ho_in_fail_no_detect2() ); - - execute( TC_bssap_rlsd_does_not_cause_bssmap_reset() ); - execute( TC_bssmap_clear_does_not_cause_bssmap_reset() ); - execute( TC_ms_rel_ind_does_not_cause_bssmap_reset() ); - - execute( TC_dyn_pdch_ipa_act_deact() ); - execute( TC_dyn_pdch_ipa_act_nack() ); - execute( TC_dyn_pdch_osmo_act_deact() ); - execute( TC_dyn_pdch_osmo_act_nack() ); - - execute( TC_chopped_ipa_ping() ); - execute( TC_chopped_ipa_payload() ); - - /* at bottom as they might crash OsmoBSC before OS#3182 is fixed */ - execute( TC_early_conn_fail() ); - execute( TC_late_conn_fail() ); - + execute( TC_ho_neighbor_config_1() ); + execute( TC_ho_neighbor_config_2() ); + execute( TC_ho_neighbor_config_3() ); + execute( TC_ho_neighbor_config_4() ); + execute( TC_ho_neighbor_config_5() ); + execute( TC_ho_neighbor_config_6() ); + execute( TC_ho_neighbor_config_7() ); } } diff --git a/bsc/BSC_Tests_LCLS.ttcn b/bsc/BSC_Tests_LCLS.ttcn index 6087133..c57cbfa 100644 --- a/bsc/BSC_Tests_LCLS.ttcn +++ b/bsc/BSC_Tests_LCLS.ttcn @@ -739,21 +739,6 @@ control { - execute( TC_lcls_gcr_only() ); - execute( TC_lcls_gcr_bway_connect() ); - execute( TC_lcls_gcr_bway_connect_hr() ); - execute( TC_lcls_gcr_bway_codec_mismatch() ); - execute( TC_lcls_gcr_nomatch_bway_connect() ); - execute( TC_lcls_gcr_bway_dont_connect() ); - execute( TC_lcls_gcr_unsuppported_cfg() ); - execute( TC_lcls_gcr_unsuppported_csc() ); - execute( TC_lcls_gcr_bway_dont_connect_csc() ); - execute( TC_lcls_connect_break() ); - execute( TC_lcls_connect_clear() ); - - execute( TC_lcls_bts_gcr_bway_connect() ); - execute( TC_lcls_bts_gcr_bway_connect_hr() ); - execute( TC_lcls_bts_connect_break() ); } diff --git a/bsc/osmo-bsc.cfg b/bsc/osmo-bsc.cfg index bca5b20..9384491 100644 --- a/bsc/osmo-bsc.cfg +++ b/bsc/osmo-bsc.cfg @@ -57,7 +57,7 @@ encryption a5 0 1 3 neci 1 paging any use tch 0 - handover 0 + handover 1 handover window rxlev averaging 10 handover window rxqual averaging 1 handover window rxlev neighbor averaging 10 @@ -339,6 +339,35 @@ timeslot 7 phys_chan_config PDCH hopping enabled 0 + bts 3 + type sysmobts + band DCS1800 + cell_identity 3 + location_area_code 3 + # re-use bts 2's ARFCN 871 and BSIC 12 (to test handover config) + base_station_id_code 12 + trx 0 + rf_locked 0 + arfcn 871 + nominal power 23 + max_power_red 20 + rsl e1 tei 0 + timeslot 0 + phys_chan_config CCCH+SDCCH4 + timeslot 1 + phys_chan_config TCH/F + timeslot 2 + phys_chan_config TCH/F + timeslot 3 + phys_chan_config TCH/F + timeslot 4 + phys_chan_config TCH/F + timeslot 5 + phys_chan_config TCH/H + timeslot 6 + phys_chan_config PDCH + timeslot 7 + phys_chan_config PDCH msc 0 ip.access rtp-base 4000 no bsc-welcome-text diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn index 790dd7a..309ec13 100644 --- a/library/RSL_Emulation.ttcn +++ b/library/RSL_Emulation.ttcn @@ -45,6 +45,8 @@ /* second BTS / DChan during hand-over */ port RSL_DCHAN_PT RSL1; port RSLEM_PROC_PT RSL1_PROC; + port RSL_DCHAN_PT RSL2; + port RSLEM_PROC_PT RSL2_PROC; }; type record RSLDC_ChanRqd { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia4ba0e75abd3d45a3422b2525e5f938cdc5a04cc Gerrit-Change-Number: 14765 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 13 03:49:50 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Jul 2019 03:49:50 +0000 Subject: Change in ...osmo-bsc[master]: comment and VTY doc tweaks Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14766 Change subject: comment and VTY doc tweaks ...................................................................... comment and VTY doc tweaks Clarify some in-code comments. Fix descriptions of some handover timers, which still talked of "MO" and "MT" handover -- which we now call "inter-BSC out" or "inter-BSC in" instead. Change-Id: I8429a830edd0325893ac90f22fcc05309617bd2d --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/handover_fsm.c M src/osmo-bsc/net_init.c 3 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/66/14766/1 diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index a464001..d82d1ba 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -1505,7 +1505,7 @@ struct llist_head bts_list; struct llist_head bts_rejected; - /* shall reference gsm_network_T[] */ + /* see gsm_network_T_defs */ struct osmo_tdef *T_defs; enum gsm_chan_t ctype_by_chreq[_NUM_CHREQ_T]; diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 22618c5..7406a97 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -200,7 +200,8 @@ conn = req->old_lchan->conn; OSMO_ASSERT(conn && conn->fi); - /* To make sure we're allowed to start a handover, go through a gscon event dispatch. */ + /* To make sure we're allowed to start a handover, go through a gscon event dispatch. If that is accepted, the + * same req is passed to handover_start(). */ osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_HANDOVER_START, req); } diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c index 1ef9bd5..34403fa 100644 --- a/src/osmo-bsc/net_init.c +++ b/src/osmo-bsc/net_init.c @@ -26,10 +26,10 @@ #include static struct osmo_tdef gsm_network_T_defs[] = { - { .T=7, .default_val=10, .desc="inter-BSC Handover MO, HO Required to HO Command" }, - { .T=8, .default_val=10, .desc="inter-BSC Handover MO, HO Command to final Clear" }, + { .T=7, .default_val=10, .desc="inter-BSC/MSC Handover outgoing, BSSMAP HO Required to HO Command timeout" }, + { .T=8, .default_val=10, .desc="inter-BSC/MSC Handover outgoing, BSSMAP HO Command to final Clear timeout" }, { .T=10, .default_val=6, .desc="RR Assignment" }, - { .T=101, .default_val=10, .desc="inter-BSC Handover MT, HO Request to HO Accept" }, + { .T=101, .default_val=10, .desc="inter-BSC/MSC Handover incoming, BSSMAP HO Request to HO Accept" }, { .T=3101, .default_val=3, .desc="RR Immediate Assignment" }, { .T=3103, .default_val=5, .desc="Handover" }, { .T=3105, .default_val=100, .unit=OSMO_TDEF_MS, .desc="Physical Information" }, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8429a830edd0325893ac90f22fcc05309617bd2d Gerrit-Change-Number: 14766 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 13 03:49:51 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Jul 2019 03:49:51 +0000 Subject: Change in ...osmo-bsc[master]: silence error for "invalid enum handover_scope value: none" Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14767 Change subject: silence error for "invalid enum handover_scope value: none" ...................................................................... silence error for "invalid enum handover_scope value: none" If no target cell got selected in a handover attempt, enum value NO_HANDOVER is used. In that case, do not log a lot of errors saying "invalid enum handover_scope value: none" -- they are misleading. Change-Id: I98e748bea58ebb02812b6aaa6431c7d4b813242d --- M src/osmo-bsc/handover_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/67/14767/1 diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 7406a97..6d0c2d4 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -694,6 +694,7 @@ LOGP(DHO, LOGL_ERROR, "invalid enum handover_scope value: %s\n", handover_scope_name(scope)); /* use "normal" HO_INTRA_BSC counter... */ + case HO_NO_HANDOVER: case HO_INTRA_BSC: return result_counter_HANDOVER(result); case HO_INTER_BSC_OUT: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I98e748bea58ebb02812b6aaa6431c7d4b813242d Gerrit-Change-Number: 14767 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 13 03:49:51 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Jul 2019 03:49:51 +0000 Subject: Change in ...osmo-bsc[master]: add vty 'no neighbors' to remove all HO targets Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14768 Change subject: add vty 'no neighbors' to remove all HO targets ...................................................................... add vty 'no neighbors' to remove all HO targets This is required for an upcoming TTCN3 test that plays through various neighbor configurations. Change-Id: I8623ab581639e9f8af6a9ff1eca990518d1b1211 --- M src/osmo-bsc/neighbor_ident_vty.c M tests/neighbor_ident.vty 2 files changed, 93 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/68/14768/1 diff --git a/src/osmo-bsc/neighbor_ident_vty.c b/src/osmo-bsc/neighbor_ident_vty.c index 203b150..715ee8b 100644 --- a/src/osmo-bsc/neighbor_ident_vty.c +++ b/src/osmo-bsc/neighbor_ident_vty.c @@ -372,6 +372,85 @@ return CMD_SUCCESS; } +struct nil_match_bts_data { + int bts_nr; + const struct neighbor_ident_key *found; +}; + +static bool nil_match_bts(const struct neighbor_ident_key *key, + const struct gsm0808_cell_id_list2 *val, + void *cb_data) +{ + struct nil_match_bts_data *d = cb_data; + if (key->from_bts == d->bts_nr) { + d->found = key; + return false; + } + return true; +} + +static int del_all(struct vty *vty) +{ + int rc; + int removed = 0; + struct gsm_bts *bts = vty->index; + + if (vty->node != BTS_NODE) { + vty_out(vty, "%% Error: cannot remove BTS neighbor, not on BTS node%s", + VTY_NEWLINE); + return CMD_WARNING; + } + if (!bts) { + vty_out(vty, "%% Error: cannot remove BTS neighbor, no BTS on this node%s", + VTY_NEWLINE); + return CMD_WARNING; + } + + /* Remove all local neighbors */ + while (1) { + struct gsm_bts_ref *neigh = llist_first_entry_or_null(&bts->local_neighbors, struct gsm_bts_ref, entry); + struct gsm_bts *neigh_bts = neigh ? neigh->bts : NULL; + if (!neigh) + break; + + rc = gsm_bts_local_neighbor_del(bts, neigh_bts); + if (rc > 0) { + vty_out(vty, "%% Removed local neighbor bts %u to bts %u%s", + bts->nr, neigh_bts->nr, VTY_NEWLINE); + removed += rc; + } else { + vty_out(vty, "%% Error while removing local neigbor bts %u to bts %u, aborted%s", + bts->nr, neigh_bts->nr, VTY_NEWLINE); + return CMD_WARNING; + } + } + + /* Remove all remote-BSS neighbors */ + while (1) { + struct neighbor_ident_key k; + struct nil_match_bts_data d = {}; + neighbor_ident_iter(g_neighbor_cells, nil_match_bts, &d); + if (!d.found) + break; + k = *d.found; + if (neighbor_ident_del(g_neighbor_cells, &k)) { + vty_out(vty, "%% Removed remote BSS neighbor %s%s", + neighbor_ident_key_name(&k), VTY_NEWLINE); + removed++; + } else { + vty_out(vty, "%% Error while removing remote BSS neighbor %s, aborted%s", + neighbor_ident_key_name(&k), VTY_NEWLINE); + return CMD_WARNING; + } + } + + if (!removed) { + vty_out(vty, "%% Cannot remove, no neighbors configured%s", VTY_NEWLINE); + return CMD_WARNING; + } + return CMD_SUCCESS; +} + DEFUN(cfg_neighbor_add_lac_arfcn_bsic, cfg_neighbor_add_lac_arfcn_bsic_cmd, NEIGHBOR_ADD_CMD LAC_PARAMS " " NEIGHBOR_IDENT_VTY_KEY_PARAMS, NEIGHBOR_ADD_DOC LAC_DOC NEIGHBOR_IDENT_VTY_KEY_DOC) @@ -430,6 +509,15 @@ return del_by_key(vty, &key); } +DEFUN(cfg_neighbor_del_all, cfg_neighbor_del_all_cmd, + "no neighbors", + NO_STR + "Remove all local and remote-BSS neighbor config for this cell." + " Note that this falls back to the legacy behavior of regarding all local cells as neighbors.\n") +{ + return del_all(vty); +} + struct write_neighbor_ident_entry_data { struct vty *vty; const char *indent; @@ -576,5 +664,6 @@ install_element(BTS_NODE, &cfg_neighbor_add_cgi_arfcn_bsic_cmd); install_element(BTS_NODE, &cfg_neighbor_del_bts_nr_cmd); install_element(BTS_NODE, &cfg_neighbor_del_arfcn_bsic_cmd); + install_element(BTS_NODE, &cfg_neighbor_del_all_cmd); install_element_ve(&show_bts_neighbor_cmd); } diff --git a/tests/neighbor_ident.vty b/tests/neighbor_ident.vty index 4aeb6cc..224e8b3 100644 --- a/tests/neighbor_ident.vty +++ b/tests/neighbor_ident.vty @@ -89,6 +89,7 @@ neighbor cgi <0-999> <0-999> <0-65535> <0-65535> arfcn <0-1023> bsic (<0-63>|any) no neighbor bts <0-255> no neighbor arfcn <0-1023> bsic (<0-63>|any) + no neighbors ... OsmoBSC(config-net-bts)# neighbor? @@ -158,6 +159,9 @@ OsmoBSC(config-net-bts)# neighbor cgi 0 0 0 0 arfcn 0 bsic 0 ? +OsmoBSC(config-net-bts)# no neighbors? + neighbors Remove all local and remote-BSS neighbor config for this cell. Note that this falls back to the legacy behavior of regarding all local cells as neighbors. + OsmoBSC(config-net-bts)# no neighbor? neighbor Remove local or remote-BSS neighbor cell -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8623ab581639e9f8af6a9ff1eca990518d1b1211 Gerrit-Change-Number: 14768 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 13 03:49:51 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Jul 2019 03:49:51 +0000 Subject: Change in ...osmo-bsc[master]: neighbor config: allow re-using ARFCN+BSIC pairs Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14769 Change subject: neighbor config: allow re-using ARFCN+BSIC pairs ...................................................................... neighbor config: allow re-using ARFCN+BSIC pairs Fix neighbor config to match OsmoBSC manual: implement the plan for neighbor configuration that was so far only described in the manual without actually being in operation. This first allows re-using ARFCN+BSIC pairs in and across BSS. So far the handover_start() code always looked for handover target cells across *all* local cells, even if they were not listed as neighbors to a source cell. Imply all cells as neighbors only as long as there are no explicit neighbors configured. As soon as the first 'neighbor' line appears in a 'bts' config, only the listed neighbors are regarded as handover target cells. (The 'neighbor-list' commands are not related to this, only the relatively new 'neighbor (bts|lac|cgi|...)' commands affect actual handover procedures.) TTCN3 tests TC_ho_neighbor_config_1 thru _7 play through the various aspects of neighbor configuration: both the legacy implicit all-cells-are-neighbors as well as allowing only explicit neighbors by config. Related: OS#4056 Related: osmo-ttcn3-hacks Ia4ba0e75abd3d45a3422b2525e5f938cdc5a04cc Change-Id: I29bca59ab232eddc74e0d4698efb9c9992443983 --- M include/osmocom/bsc/handover.h M include/osmocom/bsc/handover_fsm.h M include/osmocom/bsc/neighbor_ident.h M src/osmo-bsc/handover_decision_2.c M src/osmo-bsc/handover_fsm.c M src/osmo-bsc/handover_logic.c M src/osmo-bsc/neighbor_ident_vty.c M tests/bsc/bsc_test.c 8 files changed, 244 insertions(+), 62 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/69/14769/1 diff --git a/include/osmocom/bsc/handover.h b/include/osmocom/bsc/handover.h index 322913d..b00ee60 100644 --- a/include/osmocom/bsc/handover.h +++ b/include/osmocom/bsc/handover.h @@ -10,6 +10,15 @@ #include #include +#define LOG_HO(conn, level, fmt, args...) do { \ + if (conn->ho.fi) \ + LOGPFSML(conn->ho.fi, level, "%s: " fmt, \ + handover_status(conn), ## args); \ + else \ + LOGP(DHODEC, level, "%s: " fmt, \ + handover_status(conn), ## args); \ + } while(0) + struct gsm_network; struct gsm_lchan; struct gsm_bts; @@ -25,6 +34,8 @@ HO_RESULT_ERROR, }; +const char *handover_status(struct gsm_subscriber_connection *conn); + extern const struct value_string handover_result_names[]; inline static const char *handover_result_name(enum handover_result val) { return get_value_string(handover_result_names, val); } @@ -70,8 +81,11 @@ struct gsm_lchan *lchan); void bsc_tx_bssmap_ho_failure(struct gsm_subscriber_connection *conn); -struct gsm_bts *bts_by_neighbor_ident(const struct gsm_network *net, - const struct neighbor_ident_key *search_for); +int find_handover_target_cell(struct gsm_bts **local_target_cell_p, + const struct gsm0808_cell_id_list2 **remote_target_cell_p, + struct gsm_subscriber_connection *conn, const struct neighbor_ident_key *search_for, + bool log_errors); + struct neighbor_ident_key *bts_ident_key(const struct gsm_bts *bts); void handover_parse_inter_bsc_mt(struct gsm_subscriber_connection *conn, diff --git a/include/osmocom/bsc/handover_fsm.h b/include/osmocom/bsc/handover_fsm.h index 7c2145e..1628d8f 100644 --- a/include/osmocom/bsc/handover_fsm.h +++ b/include/osmocom/bsc/handover_fsm.h @@ -4,18 +4,6 @@ #include #include -const char *handover_status(struct gsm_subscriber_connection *conn); - -/* This macro automatically includes a final \n, if omitted. */ -#define LOG_HO(conn, level, fmt, args...) do { \ - if (conn->ho.fi) \ - LOGPFSML(conn->ho.fi, level, "%s: " fmt, \ - handover_status(conn), ## args); \ - else \ - LOGP(DHODEC, level, "%s: " fmt, \ - handover_status(conn), ## args); \ - } while(0) - /* Terminology: * Intra-Cell: stays within one BTS, this should actually be an Assignment. * Intra-BSC: stays within one BSC, but moves between BTSes. diff --git a/include/osmocom/bsc/neighbor_ident.h b/include/osmocom/bsc/neighbor_ident.h index 17bffbc..aa38276 100644 --- a/include/osmocom/bsc/neighbor_ident.h +++ b/include/osmocom/bsc/neighbor_ident.h @@ -47,6 +47,8 @@ void neighbor_ident_vty_init(struct gsm_network *net, struct neighbor_ident_list *nil); void neighbor_ident_vty_write(struct vty *vty, const char *indent, struct gsm_bts *bts); +bool neighbor_ident_bts_entry_exists(uint8_t from_bts); + #define NEIGHBOR_IDENT_VTY_KEY_PARAMS "arfcn <0-1023> bsic (<0-63>|any)" #define NEIGHBOR_IDENT_VTY_KEY_DOC \ "ARFCN of neighbor cell\n" "ARFCN value\n" \ diff --git a/src/osmo-bsc/handover_decision_2.c b/src/osmo-bsc/handover_decision_2.c index a8fff63..0e24c0d 100644 --- a/src/osmo-bsc/handover_decision_2.c +++ b/src/osmo-bsc/handover_decision_2.c @@ -900,18 +900,8 @@ return; } - neighbor_bts = bts_by_neighbor_ident(bts->network, &ni); - - neighbor_cil = neighbor_ident_get(bts->network->neighbor_bss_cells, &ni); - - if (neighbor_bts && neighbor_cil) { - LOGPHOBTS(bts, LOGL_ERROR, "Configuration error: %s exists as both local" - " neighbor (bts %u) and remote-BSS neighbor (%s). Will consider only" - " the local-BSS neighbor.\n", - neighbor_ident_key_name(&ni), - neighbor_bts->nr, gsm0808_cell_id_list_name(neighbor_cil)); - neighbor_cil = NULL; - } + find_handover_target_cell(&neighbor_bts, &neighbor_cil, + lchan->conn, &ni, false); if (!neighbor_bts && !neighbor_cil) { LOGPHOBTS(bts, LOGL_DEBUG, "no neighbor ARFCN %u BSIC %u configured for this cell\n", diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 6d0c2d4..d159347 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -31,6 +31,7 @@ #include #include +#include #include #include #include @@ -200,6 +201,9 @@ conn = req->old_lchan->conn; OSMO_ASSERT(conn && conn->fi); + /* Make sure the handover target neighbor_ident_key contains the correct source bts nr */ + req->target_nik.from_bts = req->old_lchan->ts->trx->bts->nr; + /* To make sure we're allowed to start a handover, go through a gscon event dispatch. If that is accepted, the * same req is passed to handover_start(). */ osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_HANDOVER_START, req); @@ -285,9 +289,10 @@ OSMO_ASSERT(req && req->old_lchan && req->old_lchan->conn); struct gsm_subscriber_connection *conn = req->old_lchan->conn; + const struct neighbor_ident_key *search_for = &req->target_nik; struct handover *ho = &conn->ho; - struct gsm_bts *bts; - const struct gsm0808_cell_id_list2 *cil; + struct gsm_bts *local_target_cell = NULL; + const struct gsm0808_cell_id_list2 *remote_target_cell = NULL; if (conn->ho.fi) { LOG_HO(conn, LOGL_ERROR, "Handover requested while another handover is ongoing; Ignore\n"); @@ -295,6 +300,9 @@ } handover_reset(conn); + /* When handover_start() is invoked by the gscon, it expects a HANDOVER_END event. The best way to ensure this + * is to always create a handover_fsm instance, even if the target cell is not resolved yet. Any failure should + * then call handover_end(), which ensures that the conn snaps back to a valid state. */ handover_fsm_alloc(conn); ho->from_hodec_id = req->from_hodec_id; @@ -302,21 +310,25 @@ req->old_lchan->type : req->new_lchan_type; ho->target_cell = req->target_nik; - bts = bts_by_neighbor_ident(conn->network, &req->target_nik); - if (bts) { - ho->new_bts = bts; + if (find_handover_target_cell(&local_target_cell, &remote_target_cell, + conn, search_for, true)) + goto no_handover; + + if (local_target_cell) { + ho->new_bts = local_target_cell; handover_start_intra_bsc(conn); return; } - cil = neighbor_ident_get(conn->network->neighbor_bss_cells, &req->target_nik); - if (cil) { - handover_start_inter_bsc_out(conn, cil); + if (remote_target_cell) { + handover_start_inter_bsc_out(conn, remote_target_cell); return; } - LOG_HO(conn, LOGL_ERROR, "Cannot handover %s: neighbor unknown\n", - neighbor_ident_key_name(&req->target_nik)); + /* should never reach this, because find_handover_target_cell() would have returned error. */ + OSMO_ASSERT(false); + +no_handover: handover_end(conn, HO_RESULT_FAIL_NO_CHANNEL); } diff --git a/src/osmo-bsc/handover_logic.c b/src/osmo-bsc/handover_logic.c index 5725213..5be8383 100644 --- a/src/osmo-bsc/handover_logic.c +++ b/src/osmo-bsc/handover_logic.c @@ -125,42 +125,205 @@ return count; } -struct gsm_bts *bts_by_neighbor_ident(const struct gsm_network *net, - const struct neighbor_ident_key *search_for) +/* Find out a handover target cell for the given neighbor_ident_key, + * and make sure there are no ambiguous matches. + * Given a source BTS and a target ARFCN+BSIC, find which cell is the right handover target. + * ARFCN+BSIC may be re-used within and/or across BSS, so make sure that only those cells that are explicitly + * listed as neighbor of the source cell are viable handover targets. + * The (legacy) default configuration is that, when no explicit neighbors are listed, that all local cells are + * neighbors, in which case each ARFCN+BSIC must exist at most once. + * If there is more than one viable handover target cell found for the given ARFCN+BSIC, that constitutes a + * configuration error and should not result in handover, so that the system's misconfiguration is more likely + * to be found. + */ +int find_handover_target_cell(struct gsm_bts **local_target_cell_p, + const struct gsm0808_cell_id_list2 **remote_target_cell_p, + struct gsm_subscriber_connection *conn, const struct neighbor_ident_key *search_for, + bool log_errors) { - struct gsm_bts *found = NULL; - struct gsm_bts *bts; - struct gsm_bts *wildcard_match = NULL; + struct gsm_network *net = conn->network; + struct gsm_bts *from_bts; + struct gsm_bts *local_target_cell = NULL; + const struct gsm0808_cell_id_list2 *remote_target_cell = NULL; + struct gsm_bts_ref *neigh; + bool ho_active; + bool as_active; - llist_for_each_entry(bts, &net->bts_list, list) { - struct neighbor_ident_key entry = { - .from_bts = NEIGHBOR_IDENT_KEY_ANY_BTS, - .arfcn = bts->c0->arfcn, - .bsic = bts->bsic, - }; - if (neighbor_ident_key_match(&entry, search_for, true)) { - if (found) { - LOGP(DHO, LOGL_ERROR, "CONFIG ERROR: Multiple BTS match %s: %d and %d\n", - neighbor_ident_key_name(search_for), - found->nr, bts->nr); - return found; - } - found = bts; - } - if (neighbor_ident_key_match(&entry, search_for, false)) - wildcard_match = bts; + if (local_target_cell_p) + *local_target_cell_p = NULL; + if (remote_target_cell_p) + *remote_target_cell_p = NULL; + + if (!search_for) { + if (log_errors) + LOG_HO(conn, LOGL_ERROR, "Handover without target cell\n"); + return -EINVAL; } - if (found) - return found; + from_bts = gsm_bts_num(net, search_for->from_bts); + if (!from_bts) { + if (log_errors) + LOG_HO(conn, LOGL_ERROR, "Handover without source cell\n"); + return -EINVAL; + } - return wildcard_match; + ho_active = ho_get_ho_active(from_bts->ho); + as_active = (ho_get_algorithm(from_bts->ho) == 2) + && ho_get_hodec2_as_active(from_bts->ho); + if (!ho_active && !as_active) { + if (log_errors) + LOG_HO(conn, LOGL_ERROR, "Cannot start Handover: Handover and Assignment disabled for this source cell (%s)\n", + neighbor_ident_key_name(search_for)); + return -EINVAL; + } + + if (llist_empty(&from_bts->local_neighbors) + && !neighbor_ident_bts_entry_exists(from_bts->nr)) { + /* No explicit neighbor entries exist for this BTS. Hence apply the legacy default behavior that all + * local cells are neighbors. */ + struct gsm_bts *bts; + struct gsm_bts *wildcard_match = NULL; + + LOG_HO(conn, LOGL_DEBUG, "No explicit neighbors, regarding all local cells as neighbors\n"); + + llist_for_each_entry(bts, &net->bts_list, list) { + struct neighbor_ident_key bts_key = *bts_ident_key(bts); + if (neighbor_ident_key_match(&bts_key, search_for, true)) { + if (local_target_cell) { + if (log_errors) + LOG_HO(conn, LOGL_ERROR, + "NEIGHBOR CONFIGURATION ERROR: Multiple local cells match %s" + " (BTS %d and BTS %d)." + " Aborting Handover because of ambiguous network topology.\n", + neighbor_ident_key_name(search_for), + local_target_cell->nr, bts->nr); + return -EINVAL; + } + local_target_cell = bts; + } + if (neighbor_ident_key_match(&bts_key, search_for, false)) + wildcard_match = bts; + } + + if (!local_target_cell) + local_target_cell = wildcard_match; + + if (!local_target_cell) { + if (log_errors) + LOG_HO(conn, LOGL_ERROR, "Cannot Handover, no cell matches %s\n", + neighbor_ident_key_name(search_for)); + return -EINVAL; + } + + if (local_target_cell == from_bts && !as_active) { + if (log_errors) + LOG_HO(conn, LOGL_ERROR, + "Cannot start re-assignment, Assignment disabled for this cell (%s)\n", + neighbor_ident_key_name(search_for)); + return -EINVAL; + } + if (local_target_cell != from_bts && !ho_active) { + if (log_errors) + LOG_HO(conn, LOGL_ERROR, + "Cannot start Handover, Handover disabled for this cell (%s)\n", + neighbor_ident_key_name(search_for)); + return -EINVAL; + } + + if (local_target_cell_p) + *local_target_cell_p = local_target_cell; + return 0; + } + + /* One or more local- or remote-BSS cell neighbors are configured. Find a match among those, but also detect + * ambiguous matches (if multiple cells match, it is a configuration error). */ + + LOG_HO(conn, LOGL_DEBUG, "There are explicit neighbors configured for this cell\n"); + + /* Iterate explicit local neighbor cells */ + llist_for_each_entry(neigh, &from_bts->local_neighbors, entry) { + struct gsm_bts *neigh_bts = neigh->bts; + struct neighbor_ident_key neigh_bts_key = *bts_ident_key(neigh_bts); + neigh_bts_key.from_bts = from_bts->nr; + + LOG_HO(conn, LOGL_DEBUG, "Local neighbor %s\n", neighbor_ident_key_name(&neigh_bts_key)); + + if (!neighbor_ident_key_match(&neigh_bts_key, search_for, true)) { + LOG_HO(conn, LOGL_DEBUG, "Doesn't match %s\n", neighbor_ident_key_name(search_for)); + continue; + } + + if (local_target_cell) { + if (log_errors) + LOG_HO(conn, LOGL_ERROR, + "NEIGHBOR CONFIGURATION ERROR: Multiple BTS match %s (BTS %d and BTS %d)." + " Aborting Handover because of ambiguous network topology.\n", + neighbor_ident_key_name(search_for), local_target_cell->nr, neigh_bts->nr); + return -EINVAL; + } + + local_target_cell = neigh_bts; + } + + /* Any matching remote-BSS neighbor cell? */ + remote_target_cell = neighbor_ident_get(net->neighbor_bss_cells, search_for); + + if (remote_target_cell) + LOG_HO(conn, LOGL_DEBUG, "Found remote target cell %s\n", + gsm0808_cell_id_list_name(remote_target_cell)); + + if (local_target_cell && remote_target_cell) { + if (log_errors) + LOG_HO(conn, LOGL_ERROR, "NEIGHBOR CONFIGURATION ERROR: Both a local and a remote-BSS cell match %s" + " (BTS %d and remote %s)." + " Aborting Handover because of ambiguous network topology.\n", + neighbor_ident_key_name(search_for), local_target_cell->nr, + gsm0808_cell_id_list_name(remote_target_cell)); + return -EINVAL; + } + + if (local_target_cell == from_bts && !as_active) { + if (log_errors) + LOG_HO(conn, LOGL_ERROR, + "Cannot start re-assignment, Assignment disabled for this cell (%s)\n", + neighbor_ident_key_name(search_for)); + return -EINVAL; + } + + if (((local_target_cell && local_target_cell != from_bts) + || remote_target_cell) + && !ho_active) { + if (log_errors) + LOG_HO(conn, LOGL_ERROR, + "Cannot start Handover, Handover disabled for this cell (%s)\n", + neighbor_ident_key_name(search_for)); + return -EINVAL; + } + + if (local_target_cell) { + if (local_target_cell_p) + *local_target_cell_p = local_target_cell; + return 0; + } + + if (remote_target_cell) { + if (remote_target_cell_p) + *remote_target_cell_p = remote_target_cell; + return 0; + } + + if (log_errors) + LOG_HO(conn, LOGL_ERROR, "Cannot handover %s: neighbor unknown\n", + neighbor_ident_key_name(search_for)); + + return -ENODEV; } struct neighbor_ident_key *bts_ident_key(const struct gsm_bts *bts) { static struct neighbor_ident_key key; key = (struct neighbor_ident_key){ + .from_bts = NEIGHBOR_IDENT_KEY_ANY_BTS, .arfcn = bts->c0->arfcn, .bsic = bts->bsic, }; diff --git a/src/osmo-bsc/neighbor_ident_vty.c b/src/osmo-bsc/neighbor_ident_vty.c index 715ee8b..f4b6407 100644 --- a/src/osmo-bsc/neighbor_ident_vty.c +++ b/src/osmo-bsc/neighbor_ident_vty.c @@ -389,6 +389,15 @@ return true; } +bool neighbor_ident_bts_entry_exists(uint8_t from_bts) +{ + struct nil_match_bts_data d = { + .bts_nr = from_bts, + }; + neighbor_ident_iter(g_neighbor_cells, nil_match_bts, &d); + return (bool)d.found; +} + static int del_all(struct vty *vty) { int rc; @@ -428,7 +437,9 @@ /* Remove all remote-BSS neighbors */ while (1) { struct neighbor_ident_key k; - struct nil_match_bts_data d = {}; + struct nil_match_bts_data d = { + .bts_nr = bts->nr, + }; neighbor_ident_iter(g_neighbor_cells, nil_match_bts, &d); if (!d.found) break; diff --git a/tests/bsc/bsc_test.c b/tests/bsc/bsc_test.c index 492f0c5..103e0bb 100644 --- a/tests/bsc/bsc_test.c +++ b/tests/bsc/bsc_test.c @@ -250,3 +250,5 @@ struct msgb *msg, int link_id, int allow_sacch) {} void ts_fsm_alloc(struct gsm_bts_trx_ts *ts) {} void lchan_activate(struct gsm_lchan *lchan, void *info) {} +bool neighbor_ident_bts_entry_exists(uint8_t from_bts) { return false; } +const char *handover_status(struct gsm_subscriber_connection *conn) { return "x"; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29bca59ab232eddc74e0d4698efb9c9992443983 Gerrit-Change-Number: 14769 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 13 03:55:39 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Sat, 13 Jul 2019 03:55:39 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: bsc: add TC_ho_neighbor_config_1 thru _7 In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14765 to look at the new patch set (#2). Change subject: bsc: add TC_ho_neighbor_config_1 thru _7 ...................................................................... bsc: add TC_ho_neighbor_config_1 thru _7 Add tests to play through various neighbor configurations. Tests will pass as soon as osmo-bsc I29bca59ab232eddc74e0d4698efb9c9992443983 is merged. Add RSL2 to allow triggering handover to BTS 2. Adjust osmo-bsc.cfg to match the new tests. Also applied in docker-playground I1c57a04747f5ec004ccf4657954dcb0b003c24fc. - Actually enable handover. - Add bts 3 Depends: osmo-bsc I8623ab581639e9f8af6a9ff1eca990518d1b1211 ('no neighbors') Related: OS#4056 Change-Id: Ia4ba0e75abd3d45a3422b2525e5f938cdc5a04cc --- M bsc/BSC_Tests.ttcn M bsc/osmo-bsc.cfg M library/RSL_Emulation.ttcn 3 files changed, 396 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/14765/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia4ba0e75abd3d45a3422b2525e5f938cdc5a04cc Gerrit-Change-Number: 14765 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Sat Jul 13 15:39:17 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 15:39:17 +0000 Subject: Build failure of network:osmocom:nightly/binutils-arm-osmo-eabi in Debian_10/x86_64 In-Reply-To: References: Message-ID: <5d29fb387de1c_261c12765f428483f1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/binutils-arm-osmo-eabi/Debian_10/x86_64 Package network:osmocom:nightly/binutils-arm-osmo-eabi failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly binutils-arm-osmo-eabi Last lines of build log: [ 152s] ^~~~~~~~~~~~~~~~~~~~~~ [ 152s] cc1: all warnings being treated as errors [ 152s] cc1: all warnings being treated as errors [ 152s] make[5]: *** [Makefile:1517: tekhex.lo] Error 1 [ 152s] make[5]: *** [Makefile:1517: srec.lo] Error 1 [ 152s] cc1: all warnings being treated as errors [ 152s] make[5]: *** [Makefile:1517: ihex.lo] Error 1 [ 153s] make[5]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 153s] make[4]: *** [Makefile:1555: all-recursive] Error 1 [ 153s] make[4]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 153s] make[3]: *** [Makefile:1066: all] Error 2 [ 153s] make[3]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 153s] make[2]: *** [Makefile:3331: all-bfd] Error 2 [ 153s] make[2]: Leaving directory '/usr/src/packages/BUILD/build' [ 153s] make[1]: *** [Makefile:850: all] Error 2 [ 153s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 153s] dh_auto_build: cd build && make -j8 returned exit code 2 [ 153s] make: *** [debian/rules:43: build] Error 2 [ 153s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 153s] [ 153s] lamb27 failed "build binutils-arm-osmo-eabi_2.21.1a.dsc" at Sat Jul 13 15:39:03 UTC 2019. [ 153s] [ 153s] ### VM INTERACTION START ### [ 156s] [ 142.761523] sysrq: SysRq : Power Off [ 156s] [ 142.770263] reboot: Power down [ 156s] ### VM INTERACTION END ### [ 156s] [ 156s] lamb27 failed "build binutils-arm-osmo-eabi_2.21.1a.dsc" at Sat Jul 13 15:39:06 UTC 2019. [ 156s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 15:55:00 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 15:55:00 +0000 Subject: Build failure of network:osmocom:nightly/binutils-arm-osmo-eabi in Debian_10/i586 In-Reply-To: References: Message-ID: <5d29fef4e0732_261c12765f4293074a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/binutils-arm-osmo-eabi/Debian_10/i586 Package network:osmocom:nightly/binutils-arm-osmo-eabi failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly binutils-arm-osmo-eabi Last lines of build log: [ 157s] NAME##_canonicalize_dynamic_reloc [ 157s] ^~~~ [ 157s] ../../bfd/srec.c:1372:3: note: in expansion of macro 'BFD_JUMP_TABLE_DYNAMIC' [ 157s] BFD_JUMP_TABLE_DYNAMIC (_bfd_nodynamic), [ 157s] ^~~~~~~~~~~~~~~~~~~~~~ [ 157s] cc1: all warnings being treated as errors [ 157s] make[5]: *** [Makefile:1517: srec.lo] Error 1 [ 157s] make[5]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 157s] make[4]: *** [Makefile:1555: all-recursive] Error 1 [ 157s] make[4]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 157s] make[3]: *** [Makefile:1066: all] Error 2 [ 157s] make[3]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 157s] make[2]: *** [Makefile:3333: all-bfd] Error 2 [ 157s] make[2]: Leaving directory '/usr/src/packages/BUILD/build' [ 157s] make[1]: *** [Makefile:852: all] Error 2 [ 157s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 157s] dh_auto_build: cd build && make -j8 returned exit code 2 [ 157s] make: *** [debian/rules:43: build] Error 2 [ 157s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 157s] [ 157s] lamb57 failed "build binutils-arm-osmo-eabi_2.21.1a.dsc" at Sat Jul 13 15:54:49 UTC 2019. [ 157s] [ 157s] ### VM INTERACTION START ### [ 160s] [ 146.995767] sysrq: SysRq : Power Off [ 160s] [ 147.004359] reboot: Power down [ 160s] ### VM INTERACTION END ### [ 160s] [ 160s] lamb57 failed "build binutils-arm-osmo-eabi_2.21.1a.dsc" at Sat Jul 13 15:54:52 UTC 2019. [ 160s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 16:22:09 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 16:22:09 +0000 Subject: Build failure of network:osmocom:nightly/binutils-arm-osmo-eabi in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <5d2a054badb45_261c12765f430595b6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/binutils-arm-osmo-eabi/Raspbian_10/armv7l Package network:osmocom:nightly/binutils-arm-osmo-eabi failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly binutils-arm-osmo-eabi Last lines of build log: [ 181s] cc1: all warnings being treated as errors [ 181s] make[5]: *** [Makefile:1517: binary.lo] Error 1 [ 181s] make[5]: *** Waiting for unfinished jobs.... [ 181s] cc1: all warnings being treated as errors [ 181s] make[5]: *** [Makefile:1517: srec.lo] Error 1 [ 181s] cc1: all warnings being treated as errors [ 181s] make[5]: *** [Makefile:1517: tekhex.lo] Error 1 [ 181s] make[5]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 181s] make[4]: *** [Makefile:1555: all-recursive] Error 1 [ 181s] make[4]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 181s] make[3]: *** [Makefile:1066: all] Error 2 [ 181s] make[3]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 181s] make[2]: *** [Makefile:3331: all-bfd] Error 2 [ 181s] make[2]: Leaving directory '/usr/src/packages/BUILD/build' [ 181s] make[1]: *** [Makefile:850: all] Error 2 [ 181s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 181s] dh_auto_build: cd build && make -j4 returned exit code 2 [ 181s] make: *** [debian/rules:43: build] Error 2 [ 181s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 181s] [ 181s] armbuild04 failed "build binutils-arm-osmo-eabi_2.21.1a.dsc" at Sat Jul 13 16:21:58 UTC 2019. [ 181s] [ 181s] ### VM INTERACTION START ### [ 184s] [ 164.042111] sysrq: SysRq : Power Off [ 184s] [ 164.043903] reboot: Power down [ 184s] ### VM INTERACTION END ### [ 184s] [ 184s] armbuild04 failed "build binutils-arm-osmo-eabi_2.21.1a.dsc" at Sat Jul 13 16:22:01 UTC 2019. [ 184s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 16:24:26 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 16:24:26 +0000 Subject: Build failure of network:osmocom:nightly/binutils-arm-osmo-eabi in Debian_10/armv7l In-Reply-To: References: Message-ID: <5d2a05e2d43c7_261c12765f4306913d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/binutils-arm-osmo-eabi/Debian_10/armv7l Package network:osmocom:nightly/binutils-arm-osmo-eabi failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly binutils-arm-osmo-eabi Last lines of build log: [ 326s] NAME##_canonicalize_dynamic_reloc [ 327s] ^~~~ [ 327s] ../../bfd/srec.c:1372:3: note: in expansion of macro 'BFD_JUMP_TABLE_DYNAMIC' [ 327s] BFD_JUMP_TABLE_DYNAMIC (_bfd_nodynamic), [ 327s] ^~~~~~~~~~~~~~~~~~~~~~ [ 327s] cc1: all warnings being treated as errors [ 327s] make[5]: *** [Makefile:1517: srec.lo] Error 1 [ 327s] make[5]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 327s] make[4]: *** [Makefile:1555: all-recursive] Error 1 [ 327s] make[4]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 327s] make[3]: *** [Makefile:1066: all] Error 2 [ 327s] make[3]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 327s] make[2]: *** [Makefile:3331: all-bfd] Error 2 [ 327s] make[2]: Leaving directory '/usr/src/packages/BUILD/build' [ 327s] make[1]: *** [Makefile:850: all] Error 2 [ 327s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 327s] dh_auto_build: cd build && make -j1 returned exit code 2 [ 327s] make: *** [debian/rules:43: build] Error 2 [ 327s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 327s] [ 327s] armbuild10 failed "build binutils-arm-osmo-eabi_2.21.1a.dsc" at Sat Jul 13 16:24:12 UTC 2019. [ 327s] [ 327s] ### VM INTERACTION START ### [ 330s] [ 290.926585] sysrq: SysRq : Power Off [ 330s] [ 290.928381] reboot: Power down [ 330s] ### VM INTERACTION END ### [ 330s] [ 330s] armbuild10 failed "build binutils-arm-osmo-eabi_2.21.1a.dsc" at Sat Jul 13 16:24:15 UTC 2019. [ 330s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 16:28:43 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 16:28:43 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_10/aarch64 In-Reply-To: References: Message-ID: <5d2a06e1c77e3_261c12765f43090190@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_10/aarch64 Package network:osmocom:latest/osmo-sysmon failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 75s] #define PACKAGE "osmo-sysmon" [ 75s] #define VERSION "0.1.0" [ 75s] #define STDC_HEADERS 1 [ 75s] #define HAVE_SYS_TYPES_H 1 [ 75s] #define HAVE_SYS_STAT_H 1 [ 75s] #define HAVE_STDLIB_H 1 [ 75s] #define HAVE_STRING_H 1 [ 75s] #define HAVE_MEMORY_H 1 [ 75s] #define HAVE_STRINGS_H 1 [ 75s] #define HAVE_INTTYPES_H 1 [ 75s] #define HAVE_STDINT_H 1 [ 75s] #define HAVE_UNISTD_H 1 [ 75s] #define HAVE_DLFCN_H 1 [ 75s] #define LT_OBJDIR ".libs/" [ 75s] [ 75s] configure: exit 1 [ 75s] dh_auto_configure: ./configure --build=aarch64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/aarch64-linux-gnu --libexecdir=\${prefix}/lib/aarch64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking returned exit code 1 [ 75s] make: *** [debian/rules:45: build] Error 2 [ 75s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 75s] [ 75s] obs-arm-7 failed "build osmo-sysmon_0.1.0.dsc" at Sat Jul 13 16:28:27 UTC 2019. [ 75s] [ 75s] ### VM INTERACTION START ### [ 78s] [ 64.108458] sysrq: SysRq : Power Off [ 78s] [ 64.211614] reboot: Power down [ 78s] ### VM INTERACTION END ### [ 78s] [ 78s] obs-arm-7 failed "build osmo-sysmon_0.1.0.dsc" at Sat Jul 13 16:28:31 UTC 2019. [ 78s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 16:29:17 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 16:29:17 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_10/x86_64 In-Reply-To: References: Message-ID: <5d2a06f8a68d5_261c12765f4309278e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_10/x86_64 Package network:osmocom:latest/osmo-sysmon failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 58s] #define PACKAGE "osmo-sysmon" [ 58s] #define VERSION "0.1.0" [ 58s] #define STDC_HEADERS 1 [ 58s] #define HAVE_SYS_TYPES_H 1 [ 58s] #define HAVE_SYS_STAT_H 1 [ 58s] #define HAVE_STDLIB_H 1 [ 58s] #define HAVE_STRING_H 1 [ 58s] #define HAVE_MEMORY_H 1 [ 58s] #define HAVE_STRINGS_H 1 [ 58s] #define HAVE_INTTYPES_H 1 [ 58s] #define HAVE_STDINT_H 1 [ 58s] #define HAVE_UNISTD_H 1 [ 58s] #define HAVE_DLFCN_H 1 [ 58s] #define LT_OBJDIR ".libs/" [ 58s] [ 58s] configure: exit 1 [ 58s] dh_auto_configure: ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu --libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking returned exit code 1 [ 58s] make: *** [debian/rules:45: build] Error 2 [ 58s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 58s] [ 58s] build74 failed "build osmo-sysmon_0.1.0.dsc" at Sat Jul 13 16:29:07 UTC 2019. [ 58s] [ 58s] ### VM INTERACTION START ### [ 61s] [ 51.967768] sysrq: SysRq : Power Off [ 61s] [ 51.969991] reboot: Power down [ 61s] ### VM INTERACTION END ### [ 61s] [ 61s] build74 failed "build osmo-sysmon_0.1.0.dsc" at Sat Jul 13 16:29:11 UTC 2019. [ 61s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 16:32:44 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 16:32:44 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_10/aarch64 In-Reply-To: References: Message-ID: <5d2a07c82406a_261c12765f43110644@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_10/aarch64 Package network:osmocom:latest/openbsc failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 141s] | configure: exit 0 [ 141s] [ 141s] # -*- compilation -*- [ 141s] 4. testsuite.at:23: testing db ... [ 141s] ./testsuite.at:28: $abs_top_builddir/tests/db/db_test [ 141s] --- expout 2019-07-13 16:32:36.580000000 +0000 [ 141s] +++ /usr/src/packages/BUILD/openbsc/tests/testsuite.dir/at-groups/4/stdout 2019-07-13 16:32:36.670000000 +0000 [ 141s] @@ -1,4 +1,6 @@ [ 141s] Testing subscriber database code. [ 141s] DB: Database initialized. [ 141s] +no tables in statement ! [ 141s] +no tables in statement ! [ 141s] DB: Database prepared. [ 141s] Done [ 141s] 4. testsuite.at:23: 4. db (testsuite.at:23): FAILED (testsuite.at:28) [ 141s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 141s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 141s] make: *** [debian/rules:13: build] Error 2 [ 141s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 141s] [ 141s] obs-arm-7 failed "build openbsc_1.2.0.dsc" at Sat Jul 13 16:32:37 UTC 2019. [ 141s] [ 141s] ### VM INTERACTION START ### [ 144s] [ 130.443574] sysrq: SysRq : Power Off [ 144s] [ 130.444723] reboot: Power down [ 144s] ### VM INTERACTION END ### [ 144s] [ 144s] obs-arm-7 failed "build openbsc_1.2.0.dsc" at Sat Jul 13 16:32:40 UTC 2019. [ 144s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 16:35:17 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 16:35:17 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_10/i586 In-Reply-To: References: Message-ID: <5d2a085538698_261c12765f43121140@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_10/i586 Package network:osmocom:latest/osmo-sysmon failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 59s] #define VERSION "0.1.0" [ 59s] #define STDC_HEADERS 1 [ 59s] #define HAVE_SYS_TYPES_H 1 [ 59s] #define HAVE_SYS_STAT_H 1 [ 59s] #define HAVE_STDLIB_H 1 [ 59s] #define HAVE_STRING_H 1 [ 59s] #define HAVE_MEMORY_H 1 [ 59s] #define HAVE_STRINGS_H 1 [ 59s] #define HAVE_INTTYPES_H 1 [ 59s] #define HAVE_STDINT_H 1 [ 59s] #define HAVE_UNISTD_H 1 [ 59s] #define HAVE_DLFCN_H 1 [ 59s] #define LT_OBJDIR ".libs/" [ 59s] [ 59s] configure: exit 1 [ 59s] dh_auto_configure: ./configure --build=i686-linux-gnu --prefix=/usr --includedir=\${prefix}/incl[ 49.628340] serial8250: too much work for irq4 [ 59s] ude --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/i386-linux-gnu --libexecdir=\${prefix}/lib/i386-linux-gnu --disable-maintainer-mode --disable-dependency-tracking returned exit code 1 [ 59s] make: *** [debian/rules:45: build] Error 2 [ 59s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 59s] [ 59s] build72 failed "build osmo-sysmon_0.1.0.dsc" at Sat Jul 13 16:35:07 UTC 2019. [ 59s] [ 59s] ### VM INTERACTION START ### [ 62s] [ 52.767039] sysrq: SysRq : Power Off [ 62s] [ 52.769413] reboot: Power down [ 62s] ### VM INTERACTION END ### [ 62s] [ 62s] build72 failed "build osmo-sysmon_0.1.0.dsc" at Sat Jul 13 16:35:10 UTC 2019. [ 62s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 16:36:26 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 16:36:26 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_10/x86_64 In-Reply-To: References: Message-ID: <5d2a089bd009d_261c12765f431255da@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_10/x86_64 Package network:osmocom:latest/openbsc failed to build in Debian_10/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 201s] | pkg_cv_LIBOSMOABIS_CFLAGS=-I/usr/include/ [ 201s] | pkg_cv_LIBOSMOABIS_LIBS=-losmoabis [ 201s] | pkg_cv_LIBOSMOCORE_CFLAGS=-I/usr/include/ [ 201s] | pkg_cv_LIBOSMOCORE_LIBS='-ltalloc -losmocore' [ 201s] | pkg_cv_LIBOSMOCTRL_CFLAGS=-I/usr/include/ [ 201s] | pkg_cv_LIBOSMOCTRL_LIBS='-ltalloc -losmoctrl -losmogsm -losmocore' [ 201s] | pkg_cv_LIBOSMOGB_CFLAGS='-fno-strict-aliasing -I/usr/include/' [ 201s] | pkg_cv_LIBOSMOGB_LIBS='-ltalloc -losmogb -losmovty -losmocore' [ 201s] | pkg_cv_LIBOSMOGSM_CFLAGS=-I/usr/include/ [ 201s] | pkg_cv_LIBOSMOGSM_LIBS='-ltalloc -losmogsm -losmocore' [ 201s] | pkg_cv_LIBOSMONETIF_CFLAGS=-I/usr/include/ [ 201s] | pkg_cv_LIBOSMONETIF_LIBS=-losmonetif [ 201s] | pkg_cv_LIBOSMOSCCP_CFLAGS=-I/usr/include/ [ 201s] | pkg_cv_LIBOSMOSCCP_LIBS=-lsccp [ 201s] | pkg_cv_LIBOSMOVTY_CFLAGS=-I/usr/include/ [ 201s] | pkg_cv_LIBOSMOVTY_LIBS='-ltalloc -losmovty -losmocore' [ 201s] | pkg_cv_LIBSMPP34_CFLAGS=-I/usr/include/ [ 201s] | pkg_cv_LIBSMPP34_LIBS=-lsmpp34 [ 201s] | [ 201s] | ## ----------------- ## [ 201s] | ## Output variables. ## [ 201s] | ## ----------------- ## [ 201s] | [ 204s] | ACLOCAL='${SHELL} /usr[ 174.164467] sysrq: SysRq : Power Off [ 204s] [ 174.169117] reboot: Power down [ 206s] ### VM INTERACTION END ### [ 206s] [ 206s] cloud124 failed "build openbsc_1.2.0.dsc" at Sat Jul 13 16:36:17 UTC 2019. [ 206s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 16:37:01 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 16:37:01 +0000 Subject: Build failure of network:osmocom:nightly/binutils-arm-osmo-eabi in Debian_10/aarch64 In-Reply-To: References: Message-ID: <5d2a08cfa50d7_261c12765f43128973@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/binutils-arm-osmo-eabi/Debian_10/aarch64 Package network:osmocom:nightly/binutils-arm-osmo-eabi failed to build in Debian_10/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly binutils-arm-osmo-eabi Last lines of build log: [ 127s] ^~~~~~~~~~~~~~~~~~~~~~ [ 127s] cc1: all warnings being treated as errors [ 127s] make[5]: *** [Makefile:1517: tekhex.lo] Error 1 [ 127s] cc1: all warnings being treated as errors [ 127s] make[5]: *** [Makefile:1517: srec.lo] Error 1 [ 127s] cc1: all warnings being treated as errors [ 127s] make[5]: *** [Makefile:1517: ihex.lo] Error 1 [ 127s] make[5]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 127s] make[4]: *** [Makefile:1555: all-recursive] Error 1 [ 127s] make[4]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 127s] make[3]: *** [Makefile:1066: all] Error 2 [ 127s] make[3]: Leaving directory '/usr/src/packages/BUILD/build/bfd' [ 127s] make[2]: *** [Makefile:3331: all-bfd] Error 2 [ 127s] make[2]: Leaving directory '/usr/src/packages/BUILD/build' [ 127s] make[1]: *** [Makefile:850: all] Error 2 [ 127s] make[1]: Leaving directory '/usr/src/packages/BUILD/build' [ 127s] dh_auto_build: cd build && make -j8 returned exit code 2 [ 127s] make: *** [debian/rules:43: build] Error 2 [ 127s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 127s] [ 127s] obs-arm-7 failed "build binutils-arm-osmo-eabi_2.21.1a.dsc" at Sat Jul 13 16:36:49 UTC 2019. [ 127s] [ 127s] ### VM INTERACTION START ### [ 130s] [ 117.048625] sysrq: SysRq : Power Off [ 130s] [ 117.056356] reboot: Power down [ 130s] ### VM INTERACTION END ### [ 130s] [ 130s] obs-arm-7 failed "build binutils-arm-osmo-eabi_2.21.1a.dsc" at Sat Jul 13 16:36:52 UTC 2019. [ 130s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 16:40:09 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 16:40:09 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_10/i586 In-Reply-To: References: Message-ID: <5d2a09843cafd_261c12765f4314224f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_10/i586 Package network:osmocom:latest/openbsc failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 99s] | #define HAVE_MEMORY_H 1 [ 99s] | #define HAVE_STRINGS_H 1 [ 99s] | #define HAVE_INTTYPES_H 1 [ 99s] | #define HAVE_STDINT_H 1 [ 99s] | #define HAVE_UNISTD_H 1 [ 99s] | #define HAVE_DLFCN_H 1 [ 99s] | #define LT_OBJDIR ".libs/" [ 99s] | #define BUILD_SMPP 1 [ 99s] | #define STDC_HEADERS 1 [ 99s] | #define HAVE_DBI_DBD_H 1 [ 99s] | #define HAVE_PCAP_PCAP_H 1 [ 99s] | #define HAVE_TM_GMTOFF_IN_TM 1 [ 99s] | [ 99s] | configure: exit 0 [ 99s] [ 99s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 99s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 99s] make: *** [debian/rules:13: build] Error 2 [ 99s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 99s] [ 99s] build73 failed "build openbsc_1.2.0.dsc" at Sat Jul 13 16:39:59 UTC 2019. [ 99s] [ 99s] ### VM INTERACTION START ### [ 102s] [ 93.097907] sysrq: SysRq : Power Off [ 102s] [ 93.100006] reboot: Power down [ 102s] ### VM INTERACTION END ### [ 102s] [ 102s] build73 failed "build openbsc_1.2.0.dsc" at Sat Jul 13 16:40:03 UTC 2019. [ 102s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 17:03:51 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 17:03:51 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Debian_10/armv7l In-Reply-To: References: Message-ID: <5d2a0f159e7c7_261c12765f4324448e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Debian_10/armv7l Package network:osmocom:latest/osmo-sysmon failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 162s] #define PACKAGE "osmo-sysmon" [ 162s] #define VERSION "0.1.0" [ 162s] #define STDC_HEADERS 1 [ 162s] #define HAVE_SYS_TYPES_H 1 [ 162s] #define HAVE_SYS_STAT_H 1 [ 162s] #define HAVE_STDLIB_H 1 [ 162s] #define HAVE_STRING_H 1 [ 162s] #define HAVE_MEMORY_H 1 [ 162s] #define HAVE_STRINGS_H 1 [ 162s] #define HAVE_INTTYPES_H 1 [ 162s] #define HAVE_STDINT_H 1 [ 162s] #define HAVE_UNISTD_H 1 [ 162s] #define HAVE_DLFCN_H 1 [ 162s] #define LT_OBJDIR ".libs/" [ 162s] [ 162s] configure: exit 1 [ 162s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/arm-linux-gnueabihf --libexecdir=\${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode --disable-dependency-tracking returned exit code 1 [ 162s] make: *** [debian/rules:45: build] Error 2 [ 162s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 162s] [ 162s] armbuild15 failed "build osmo-sysmon_0.1.0.dsc" at Sat Jul 13 17:03:39 UTC 2019. [ 162s] [ 162s] ### VM INTERACTION START ### [ 164s] [ 123.374224] sysrq: SysRq : Power Off [ 164s] [ 123.376312] reboot: Power down [ 164s] ### VM INTERACTION END ### [ 164s] [ 164s] armbuild15 failed "build osmo-sysmon_0.1.0.dsc" at Sat Jul 13 17:03:42 UTC 2019. [ 164s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 17:03:51 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 17:03:51 +0000 Subject: Build failure of network:osmocom:latest/osmo-sysmon in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <5d2a0f16578ea_261c12765f4324453c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-sysmon/Raspbian_10/armv7l Package network:osmocom:latest/osmo-sysmon failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:latest osmo-sysmon Last lines of build log: [ 163s] #define PACKAGE "osmo-sysmon" [ 163s] #define VERSION "0.1.0" [ 163s] #define STDC_HEADERS 1 [ 163s] #define HAVE_SYS_TYPES_H 1 [ 163s] #define HAVE_SYS_STAT_H 1 [ 163s] #define HAVE_STDLIB_H 1 [ 163s] #define HAVE_STRING_H 1 [ 163s] #define HAVE_MEMORY_H 1 [ 163s] #define HAVE_STRINGS_H 1 [ 163s] #define HAVE_INTTYPES_H 1 [ 163s] #define HAVE_STDINT_H 1 [ 163s] #define HAVE_UNISTD_H 1 [ 163s] #define HAVE_DLFCN_H 1 [ 163s] #define LT_OBJDIR ".libs/" [ 163s] [ 163s] configure: exit 1 [ 163s] dh_auto_configure: ./configure --build=arm-linux-gnueabihf --prefix=/usr --includedir=\${prefix}/include --mandir=\${prefix}/share/man --infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-silent-rules --libdir=\${prefix}/lib/arm-linux-gnueabihf --libexecdir=\${prefix}/lib/arm-linux-gnueabihf --disable-maintainer-mode --disable-dependency-tracking returned exit code 1 [ 163s] make: *** [debian/rules:45: build] Error 2 [ 163s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 163s] [ 163s] armbuild10 failed "build osmo-sysmon_0.1.0.dsc" at Sat Jul 13 17:03:40 UTC 2019. [ 163s] [ 163s] ### VM INTERACTION START ### [ 165s] [ 130.244890] sysrq: SysRq : Power Off [ 165s] [ 130.247069] reboot: Power down [ 166s] ### VM INTERACTION END ### [ 166s] [ 166s] armbuild10 failed "build osmo-sysmon_0.1.0.dsc" at Sat Jul 13 17:03:44 UTC 2019. [ 166s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 17:07:34 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 17:07:34 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_10/armv7l In-Reply-To: References: Message-ID: <5d2a0ff16aae0_261c12765f432625c9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_10/armv7l Package network:osmocom:latest/openbsc failed to build in Debian_10/armv7l Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 222s] | #define HAVE_MEMORY_H 1 [ 222s] | #define HAVE_STRINGS_H 1 [ 222s] | #define HAVE_INTTYPES_H 1 [ 222s] | #define HAVE_STDINT_H 1 [ 222s] | #define HAVE_UNISTD_H 1 [ 222s] | #define HAVE_DLFCN_H 1 [ 222s] | #define LT_OBJDIR ".libs/" [ 222s] | #define BUILD_SMPP 1 [ 222s] | #define STDC_HEADERS 1 [ 222s] | #define HAVE_DBI_DBD_H 1 [ 222s] | #define HAVE_PCAP_PCAP_H 1 [ 222s] | #define HAVE_TM_GMTOFF_IN_TM 1 [ 222s] | [ 222s] | configure: exit 0 [ 222s] [ 222s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 222s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 222s] make: *** [debian/rules:13: build] Error 2 [ 222s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 222s] [ 222s] obs-arm-6 failed "build openbsc_1.2.0.dsc" at Sat Jul 13 17:07:14 UTC 2019. [ 222s] [ 222s] ### VM INTERACTION START ### [ 225s] [ 203.469972] sysrq: SysRq : Power Off [ 225s] [ 203.502235] reboot: Power down [ 226s] ### VM INTERACTION END ### [ 226s] [ 226s] obs-arm-6 failed "build openbsc_1.2.0.dsc" at Sat Jul 13 17:07:19 UTC 2019. [ 226s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 17:11:35 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 17:11:35 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <5d2a10e8c38a1_261c12765f432814e6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Raspbian_10/armv7l Package network:osmocom:latest/openbsc failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 251s] | configure: exit 0 [ 251s] [ 251s] # -*- compilation -*- [ 251s] 4. testsuite.at:23: testing db ... [ 251s] ./testsuite.at:28: $abs_top_builddir/tests/db/db_test [ 251s] --- expout 2019-07-13 17:11:25.535000000 +0000 [ 251s] +++ /usr/src/packages/BUILD/openbsc/tests/testsuite.dir/at-groups/4/stdout 2019-07-13 17:11:25.760000000 +0000 [ 251s] @@ -1,4 +1,6 @@ [ 251s] Testing subscriber database code. [ 251s] DB: Database initialized. [ 251s] +no tables in statement ! [ 251s] +no tables in statement ! [ 251s] DB: Database prepared. [ 251s] Done [ 251s] 4. testsuite.at:23: 4. db (testsuite.at:23): FAILED (testsuite.at:28) [ 251s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 251s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 251s] make: *** [debian/rules:13: build] Error 2 [ 251s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 251s] [ 251s] armbuild24 failed "build openbsc_1.2.0.dsc" at Sat Jul 13 17:11:26 UTC 2019. [ 251s] [ 251s] ### VM INTERACTION START ### [ 254s] [ 235.252017] sysrq: SysRq : Power Off [ 254s] [ 235.253500] reboot: Power down [ 254s] ### VM INTERACTION END ### [ 254s] [ 254s] armbuild24 failed "build openbsc_1.2.0.dsc" at Sat Jul 13 17:11:30 UTC 2019. [ 254s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 13 21:46:34 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 13 Jul 2019 21:46:34 +0000 Subject: Build failure of network:osmocom:nightly/osmo-trx in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <5d2a515dd5bce_261c12765f4363415@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-trx failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 1181s] g++ -DHAVE_CONFIG_H -I. -I.. -Wall -I../CommonLibs -I../GSM -I./arch/common -I./device/common -I/usr/include/libusb-1.0 -Wdate-time -D_FORTIFY_SOURCE=2 -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -c -o osmo_trx_usrp1-osmo-trx.o `test -f 'osmo-trx.cpp' || echo './'`osmo-trx.cpp [ 1190s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-usrp1 osmo_trx_usrp1-osmo-trx.o ./device/usrp1/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -lusrp -lusb-1.0 [ 1191s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-usrp1 osmo_trx_usrp1-osmo-trx.o ./device/usrp1/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/arm-linux-gnueabihf/libosmoctrl.so /usr/lib/arm-linux-gnueabihf/libosmogsm.so -ltalloc /usr/lib/arm-linux-gnueabihf/libosmovty.so /usr/lib/arm-linux-gnueabihf/libosmocore.so /usr/lib/arm-linux-gnueabihf/libusrp.so -lusb-1.0 [ 1192s] g++ -DHAVE_CONFIG_H -I. -I.. -Wall -I../CommonLibs -I../GSM -I./arch/common -I./device/common -Wdate-time -D_FORTIFY_SOURCE=2 -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -c -o osmo_trx_lms-osmo-trx.o `test -f 'osmo-trx.cpp' || echo './'`osmo-trx.cpp [ 1201s] /bin/bash ../libtool --tag=CXX --mode=link g++ -lpthread -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z,relro -Wl,-z,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/libdevice.la libtransceiver_common.la ../Transceiver52M/arch/x86/libarch.la ../GSM/libGSM.la ../CommonLibs/libcommon.la -lfftw3f -ltalloc -losmocore -ltalloc -losmoctrl -losmogsm -losmocore -ltalloc -losmovty -losmocore -lLimeSuite [ 1202s] libtool: link: g++ -I/usr/include/ -I/usr/include/ -I/usr/include/ -g -O2 -fdebug-prefix-map=/usr/src/packages/BUILD=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-z -Wl,relro -Wl,-z -Wl,now -o osmo-trx-lms osmo_trx_lms-osmo-trx.o ./device/lms/.libs/libdevice.a ./.libs/libtransceiver_common.a ../Transceiver52M/arch/x86/.libs/libarch.a ../GSM/.libs/libGSM.a ../CommonLibs/.libs/libcommon.a -lpthread -lfftw3f /usr/lib/arm-linux-gnueabihf/libosmoctrl.so /usr/lib/arm-linux-gnueabihf/libosmogsm.so -ltalloc /usr/lib/arm-linux-gnueabihf/libosmovty.so /usr/lib/arm-linux-gnueabihf/libosmocore.so -lLimeSuite [ 1203s] /usr/bin/ld: cannot find -lLimeSuite [ 1203s] collect2: error: ld returned 1 exit status [ 1203s] make[4]: *** [Makefile:693: osmo-trx-lms] Error 1 [ 1203s] make[4]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 1203s] make[3]: *** [Makefile:853: all-recursive] Error 1 [ 1203s] make[3]: Leaving directory '/usr/src/packages/BUILD/Transceiver52M' [ 1203s] make[2]: *** [Makefile:516: all-recursive] Error 1 [ 1203s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1203s] make[1]: *** [Makefile:447: all] Error 2 [ 1203s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1203s] dh_auto_build: make -j1 returned exit code 2 [ 1203s] make: *** [debian/rules:6: build] Error 2 [ 1203s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 1203s] [ 1203s] armbuild04 failed "build osmo-trx_1.0.0.62.2ded5.dsc" at Sat Jul 13 21:46:14 UTC 2019. [ 1203s] [ 1203s] ### VM INTERACTION START ### [ 1206s] [ 1108.343633] sysrq: SysRq : Power Off [ 1206s] [ 1108.370997] reboot: Power down [ 1207s] ### VM INTERACTION END ### [ 1207s] [ 1207s] armbuild04 failed "build osmo-trx_1.0.0.62.2ded5.dsc" at Sat Jul 13 21:46:18 UTC 2019. [ 1207s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:06:25 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:06:25 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-sysmon=5Bmaster=5D=3A_Bump_version=3A_0=2E1=2E1=2E52-c187_=E2=86=92_0=2E2=2E0?= Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/14770 Change subject: Bump version: 0.1.1.52-c187 ? 0.2.0 ...................................................................... Bump version: 0.1.1.52-c187 ? 0.2.0 Change-Id: I34ef32535a0d6a07feeb43a7e4ebf405d7d68c44 --- M debian/changelog 1 file changed, 85 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sysmon refs/changes/70/14770/1 diff --git a/debian/changelog b/debian/changelog index a2b0789..2d78a68 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,88 @@ +osmo-sysmon (0.2.0) unstable; urgency=medium + + [ Harald Welte ] + * Initial empty repository + * initial checkin + * simple_ctrl: Add timeout to blocking I/O + * simple_ctrl.c: Support an indefinite timeout (using tout_msec=0) + * simple_ctrl.c: API for setting timeout + raw CTRL msgb read + * osmo-ctrl-client: Implement "monitor" mode + * simple-ctrl-client: Add basic help/usage information + * simple_ctrl: Abstract out timeval_from_msec() function + * simple_ctrl: Non-blocking connect() with timeout + * initial implementation of 'osysmon' main program + CTRL client + * add osysmon_sysinfo for uptime/ram/load + * osysmon_ctrl: Use variable name, not ctrl-client name as val->name + * osysmon_main: Show hierarchical/tree structure during printing + * value_node: add combined find_or_add() and avoid duplicate names + * value_node: Add 'idx' member to handle lookup by ifindex. + * Add network link + address monitiring via osysmon_rtnl.c + * add osysmon_file.c for reading/monitoring files (like sysfs) + * migrate to autoconf + * add .gitignore file + * rename to osmo-sysmon + * simple_ctrl: Check for NULL return of simple_ctrl_xceive + * add contrib/jenkins.sh for build verification + + [ Daniel Willmann ] + * Remove unused function + * Fix compilation issue on my machine, remove unused include + * Remove unused last_value handling code + * Add zero termination char to received ctrl cmd message + * Disconnect properly on errors so we can reconnect + * git-version-gen: Don't check for .git directory + + [ Martin Hauke ] + * Makefile.am: Fix typo + + [ Max ] + * Add git-review config + * Update gitignore + * Report config file name on error + * Update default config + * Expand default config + * Add OpenVPN status helper example from corresponding ticket + * Move shared libs into common LDADD + * Drop unused parameter + * ctrl: separate config structure + * Update Makefile.am + * Add ping probe support + * jenkins.sh: remove obsolete comments + * Install signal handlers before processing config + * ctrl: log host/port on errors + * Introduce generic host config and related helpers + * Add OpenVPN probe + * OpenVPN: track interface disconnect + * Update config example + + [ Stefan Sperling ] + * fix file descriptor leak in osysmon_file_read + + [ Pau Espin Pedrol ] + * Add m4 missing files to fix build + * Move source code to src subdir + * Add cmdline option parsing support + * Integrate sleeping/printing loop into osmo main loop + * openvpn: Improve logging and status information + * openvpn: Set reconnect timeout to a much lower value + * openvpn: String returned from openvpn is not null-terminated + * openvpn: log status description + * openvpn: Fix garbage printed after remote port + * openvpn: Remove useless conditional block in parse_state + * openvn: Fix missing break in last commit + * Add vty option to print output of shell cmd on every poll step + * Makefile.am: Add missing bits to have make release working + * Add debian packaging content + * Bump version: 0.0.1.66-d4c3-dirty ? 0.1.0 + * debian: Add missing libmnl-dev dependency + * Depend on liboping 1.7.0 instead of 1.9.0 + + [ Oliver Smith ] + * osmo-sysmon -h: s/OsmoHLR/osmo-sysmon/ + * contrib/jenkins.sh: run "make maintainer-clean" + + -- Harald Welte Sun, 14 Jul 2019 08:04:51 +0800 + osmo-sysmon (0.1.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/14770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I34ef32535a0d6a07feeb43a7e4ebf405d7d68c44 Gerrit-Change-Number: 14770 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:07:48 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:07:48 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: unbreak some measurement tests In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14763 ) Change subject: unbreak some measurement tests ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8eb766685dbf16e2eb2a973567016be3976e5840 Gerrit-Change-Number: 14763 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 00:07:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:07:50 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:07:50 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: unbreak some measurement tests In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14763 ) Change subject: unbreak some measurement tests ...................................................................... unbreak some measurement tests Trxc port mapping got lost. Change-Id: I8eb766685dbf16e2eb2a973567016be3976e5840 --- M bts/BTS_Tests.ttcn 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Vadim Yanitskiy: Looks good to me, approved Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 3b27469..6972806 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -2464,7 +2464,8 @@ f_init(); for (var integer ss := 0; ss <= 1; ss := ss+1) { pars := valueof(t_Pars(t_RslChanNr_Lm(5, ss), ts_RSL_ChanMode_SIGN)); - vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars); + vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars, + pcu_comp := false, trxc_comp := true); vc_conn.done; } Misc_Helpers.f_shutdown(__BFILE__, __LINE__); @@ -2475,7 +2476,8 @@ f_init(); for (var integer ss := 0; ss <= 3; ss := ss+1) { pars := valueof(t_Pars(t_RslChanNr_SDCCH4(0, ss), ts_RSL_ChanMode_SIGN)); - vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars); + vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars, + pcu_comp := false, trxc_comp := true); vc_conn.done; } Misc_Helpers.f_shutdown(__BFILE__, __LINE__); @@ -2486,7 +2488,8 @@ f_init(); for (var integer ss := 0; ss <= 7; ss := ss+1) { pars := valueof(t_Pars(t_RslChanNr_SDCCH8(6, ss), ts_RSL_ChanMode_SIGN)); - vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars); + vc_conn := f_start_handler(refers(f_TC_meas_res_periodic), pars, + pcu_comp := false, trxc_comp := true); vc_conn.done; } Misc_Helpers.f_shutdown(__BFILE__, __LINE__); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14763 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8eb766685dbf16e2eb2a973567016be3976e5840 Gerrit-Change-Number: 14763 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:09:48 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:09:48 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14710 ) Change subject: rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_ho_cmd ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If84a1d4535ee12e33a50588e178bf1ebb6fb2cd5 Gerrit-Change-Number: 14710 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Sun, 14 Jul 2019 00:09:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:09:59 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:09:59 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: bsc: add TC_ho_neighbor_config_1 thru _7 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14765 ) Change subject: bsc: add TC_ho_neighbor_config_1 thru _7 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia4ba0e75abd3d45a3422b2525e5f938cdc5a04cc Gerrit-Change-Number: 14765 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 00:09:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:10:04 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:10:04 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_... In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14710 ) Change subject: rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_ho_cmd ...................................................................... rename TC_ho_out_fail_no_ho_detect to TC_ho_out_fail_no_result_after_ho_cmd Change-Id: If84a1d4535ee12e33a50588e178bf1ebb6fb2cd5 --- M bsc/BSC_Tests.ttcn M bsc/expected-results.xml 2 files changed, 6 insertions(+), 9 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 854dbbc..44a9172 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -3121,11 +3121,8 @@ /* BSC asks for inter-BSC-out HO, receives BSSMAP Handover Command, but then no reply is received about HO outcome * (neither BSSMAP Clear Command for success nor RR Handover Failure). 48.008 3.1.5.3.3 "Abnormal Conditions" applies - * and the lchan is released. - * Note: this test is a misnomer. On missing HO Detect, normally the old BSS receives an RR Handover Failure from the - * MS. Instead, this test is about the scenario in "Abnormal Conditions" as explained above. Leaving the test's name - * unchanged to not confuse jenkins result reports. */ -private function f_tc_ho_out_fail_no_ho_detect(charstring id) runs on MSC_ConnHdlr { + * and the lchan is released. */ +private function f_tc_ho_out_fail_no_result_after_ho_cmd(charstring id) runs on MSC_ConnHdlr { g_pars := f_gen_test_hdlr_pars(); var PDU_BSSAP ass_req := f_gen_ass_req(); @@ -3198,13 +3195,13 @@ setverdict(pass); f_sleep(1.0); } -testcase TC_ho_out_fail_no_ho_detect() runs on test_CT { +testcase TC_ho_out_fail_no_result_after_ho_cmd() runs on test_CT { var MSC_ConnHdlr vc_conn; f_init(1, true); f_sleep(1.0); - vc_conn := f_start_handler(refers(f_tc_ho_out_fail_no_ho_detect)); + vc_conn := f_start_handler(refers(f_tc_ho_out_fail_no_result_after_ho_cmd)); vc_conn.done; } @@ -4135,7 +4132,7 @@ execute( TC_ho_out_of_this_bsc() ); execute( TC_ho_out_fail_no_msc_response() ); execute( TC_ho_out_fail_rr_ho_failure() ); - execute( TC_ho_out_fail_no_ho_detect() ); + execute( TC_ho_out_fail_no_result_after_ho_cmd() ); execute( TC_ho_into_this_bsc() ); execute( TC_ho_in_fail_msc_clears() ); diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml index d2c474c..3ea202c 100644 --- a/bsc/expected-results.xml +++ b/bsc/expected-results.xml @@ -87,7 +87,7 @@ - + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If84a1d4535ee12e33a50588e178bf1ebb6fb2cd5 Gerrit-Change-Number: 14710 Gerrit-PatchSet: 4 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:10:40 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:10:40 +0000 Subject: Change in ...osmo-bsc[master]: comment and VTY doc tweaks In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14766 ) Change subject: comment and VTY doc tweaks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8429a830edd0325893ac90f22fcc05309617bd2d Gerrit-Change-Number: 14766 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 00:10:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:10:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:10:56 +0000 Subject: Change in ...osmo-bsc[master]: silence error for "invalid enum handover_scope value: none" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14767 ) Change subject: silence error for "invalid enum handover_scope value: none" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I98e748bea58ebb02812b6aaa6431c7d4b813242d Gerrit-Change-Number: 14767 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 00:10:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:17:18 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:17:18 +0000 Subject: Change in ...osmo-bsc[master]: add vty 'no neighbors' to remove all HO targets In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14768 ) Change subject: add vty 'no neighbors' to remove all HO targets ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c File src/osmo-bsc/neighbor_ident_vty.c: https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c at 392 PS1, Line 392: static int del_all(struct vty *vty) let's make this a bit more descriptive like neighbor_del_all, neigh_del_all, bts_remove_all_neighbors, or the like. https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c at 397 PS1, Line 397: : if (vty->node != BTS_NODE) { : vty_out(vty, "%% Error: cannot remove BTS neighbor, not on BTS node%s", : VTY_NEWLINE); : return CMD_WARNING; : } I would actually OSMO_ASSERT here, as this would mean that the VTY command was registered to the wrong node, a clear "must not happen" situation. https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c at 403 PS1, Line 403: if (!bts) { : vty_out(vty, "%% Error: cannot remove BTS neighbor, no BTS on this node%s", : VTY_NEWLINE); : return CMD_WARNING; : } it's arguable whether the removal of 0 neighbors is successful or an error (warning esentially is the error, as they only altrenative is CMD_FATAL which terminates the process). https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c at 410 PS1, Line 410: while (1) { : struct gsm_bts_ref *neigh = llist_first_entry_or_null(&bts->local_neighbors, struct gsm_bts_ref, entry); why are we not using llist_for_each_entry() here? It seems more natural to me. Actually, as we are deleting members, llist_for_each_entry_safe() would be the more "natural" choice here. Using while(1) loops always makes me twitchy, for the off chance they could never terminate... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8623ab581639e9f8af6a9ff1eca990518d1b1211 Gerrit-Change-Number: 14768 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 00:17:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:17:26 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:17:26 +0000 Subject: Change in ...osmo-bsc[master]: comment and VTY doc tweaks In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14766 ) Change subject: comment and VTY doc tweaks ...................................................................... comment and VTY doc tweaks Clarify some in-code comments. Fix descriptions of some handover timers, which still talked of "MO" and "MT" handover -- which we now call "inter-BSC out" or "inter-BSC in" instead. Change-Id: I8429a830edd0325893ac90f22fcc05309617bd2d --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/handover_fsm.c M src/osmo-bsc/net_init.c 3 files changed, 6 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index a464001..d82d1ba 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -1505,7 +1505,7 @@ struct llist_head bts_list; struct llist_head bts_rejected; - /* shall reference gsm_network_T[] */ + /* see gsm_network_T_defs */ struct osmo_tdef *T_defs; enum gsm_chan_t ctype_by_chreq[_NUM_CHREQ_T]; diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 22618c5..7406a97 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -200,7 +200,8 @@ conn = req->old_lchan->conn; OSMO_ASSERT(conn && conn->fi); - /* To make sure we're allowed to start a handover, go through a gscon event dispatch. */ + /* To make sure we're allowed to start a handover, go through a gscon event dispatch. If that is accepted, the + * same req is passed to handover_start(). */ osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_HANDOVER_START, req); } diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c index 1ef9bd5..34403fa 100644 --- a/src/osmo-bsc/net_init.c +++ b/src/osmo-bsc/net_init.c @@ -26,10 +26,10 @@ #include static struct osmo_tdef gsm_network_T_defs[] = { - { .T=7, .default_val=10, .desc="inter-BSC Handover MO, HO Required to HO Command" }, - { .T=8, .default_val=10, .desc="inter-BSC Handover MO, HO Command to final Clear" }, + { .T=7, .default_val=10, .desc="inter-BSC/MSC Handover outgoing, BSSMAP HO Required to HO Command timeout" }, + { .T=8, .default_val=10, .desc="inter-BSC/MSC Handover outgoing, BSSMAP HO Command to final Clear timeout" }, { .T=10, .default_val=6, .desc="RR Assignment" }, - { .T=101, .default_val=10, .desc="inter-BSC Handover MT, HO Request to HO Accept" }, + { .T=101, .default_val=10, .desc="inter-BSC/MSC Handover incoming, BSSMAP HO Request to HO Accept" }, { .T=3101, .default_val=3, .desc="RR Immediate Assignment" }, { .T=3103, .default_val=5, .desc="Handover" }, { .T=3105, .default_val=100, .unit=OSMO_TDEF_MS, .desc="Physical Information" }, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14766 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8429a830edd0325893ac90f22fcc05309617bd2d Gerrit-Change-Number: 14766 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:17:27 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:17:27 +0000 Subject: Change in ...osmo-bsc[master]: silence error for "invalid enum handover_scope value: none" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14767 ) Change subject: silence error for "invalid enum handover_scope value: none" ...................................................................... silence error for "invalid enum handover_scope value: none" If no target cell got selected in a handover attempt, enum value NO_HANDOVER is used. In that case, do not log a lot of errors saying "invalid enum handover_scope value: none" -- they are misleading. Change-Id: I98e748bea58ebb02812b6aaa6431c7d4b813242d --- M src/osmo-bsc/handover_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c index 7406a97..6d0c2d4 100644 --- a/src/osmo-bsc/handover_fsm.c +++ b/src/osmo-bsc/handover_fsm.c @@ -694,6 +694,7 @@ LOGP(DHO, LOGL_ERROR, "invalid enum handover_scope value: %s\n", handover_scope_name(scope)); /* use "normal" HO_INTRA_BSC counter... */ + case HO_NO_HANDOVER: case HO_INTRA_BSC: return result_counter_HANDOVER(result); case HO_INTER_BSC_OUT: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I98e748bea58ebb02812b6aaa6431c7d4b813242d Gerrit-Change-Number: 14767 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:18:12 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:18:12 +0000 Subject: Change in ...osmo-bsc[master]: neighbor config: allow re-using ARFCN+BSIC pairs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14769 ) Change subject: neighbor config: allow re-using ARFCN+BSIC pairs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29bca59ab232eddc74e0d4698efb9c9992443983 Gerrit-Change-Number: 14769 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 00:18:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:18:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:18:22 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-sysmon=5Bmaster=5D=3A_Bump_version=3A_0=2E1=2E1=2E52-c187_=E2=86=92_0=2E2=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/14770 ) Change subject: Bump version: 0.1.1.52-c187 ? 0.2.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/14770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I34ef32535a0d6a07feeb43a7e4ebf405d7d68c44 Gerrit-Change-Number: 14770 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 00:18:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:18:25 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:18:25 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-sysmon=5Bmaster=5D=3A_Bump_version=3A_0=2E1=2E1=2E52-c187_=E2=86=92_0=2E2=2E0?= In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/14770 ) Change subject: Bump version: 0.1.1.52-c187 ? 0.2.0 ...................................................................... Bump version: 0.1.1.52-c187 ? 0.2.0 Change-Id: I34ef32535a0d6a07feeb43a7e4ebf405d7d68c44 --- M debian/changelog 1 file changed, 85 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index a2b0789..2d78a68 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,88 @@ +osmo-sysmon (0.2.0) unstable; urgency=medium + + [ Harald Welte ] + * Initial empty repository + * initial checkin + * simple_ctrl: Add timeout to blocking I/O + * simple_ctrl.c: Support an indefinite timeout (using tout_msec=0) + * simple_ctrl.c: API for setting timeout + raw CTRL msgb read + * osmo-ctrl-client: Implement "monitor" mode + * simple-ctrl-client: Add basic help/usage information + * simple_ctrl: Abstract out timeval_from_msec() function + * simple_ctrl: Non-blocking connect() with timeout + * initial implementation of 'osysmon' main program + CTRL client + * add osysmon_sysinfo for uptime/ram/load + * osysmon_ctrl: Use variable name, not ctrl-client name as val->name + * osysmon_main: Show hierarchical/tree structure during printing + * value_node: add combined find_or_add() and avoid duplicate names + * value_node: Add 'idx' member to handle lookup by ifindex. + * Add network link + address monitiring via osysmon_rtnl.c + * add osysmon_file.c for reading/monitoring files (like sysfs) + * migrate to autoconf + * add .gitignore file + * rename to osmo-sysmon + * simple_ctrl: Check for NULL return of simple_ctrl_xceive + * add contrib/jenkins.sh for build verification + + [ Daniel Willmann ] + * Remove unused function + * Fix compilation issue on my machine, remove unused include + * Remove unused last_value handling code + * Add zero termination char to received ctrl cmd message + * Disconnect properly on errors so we can reconnect + * git-version-gen: Don't check for .git directory + + [ Martin Hauke ] + * Makefile.am: Fix typo + + [ Max ] + * Add git-review config + * Update gitignore + * Report config file name on error + * Update default config + * Expand default config + * Add OpenVPN status helper example from corresponding ticket + * Move shared libs into common LDADD + * Drop unused parameter + * ctrl: separate config structure + * Update Makefile.am + * Add ping probe support + * jenkins.sh: remove obsolete comments + * Install signal handlers before processing config + * ctrl: log host/port on errors + * Introduce generic host config and related helpers + * Add OpenVPN probe + * OpenVPN: track interface disconnect + * Update config example + + [ Stefan Sperling ] + * fix file descriptor leak in osysmon_file_read + + [ Pau Espin Pedrol ] + * Add m4 missing files to fix build + * Move source code to src subdir + * Add cmdline option parsing support + * Integrate sleeping/printing loop into osmo main loop + * openvpn: Improve logging and status information + * openvpn: Set reconnect timeout to a much lower value + * openvpn: String returned from openvpn is not null-terminated + * openvpn: log status description + * openvpn: Fix garbage printed after remote port + * openvpn: Remove useless conditional block in parse_state + * openvn: Fix missing break in last commit + * Add vty option to print output of shell cmd on every poll step + * Makefile.am: Add missing bits to have make release working + * Add debian packaging content + * Bump version: 0.0.1.66-d4c3-dirty ? 0.1.0 + * debian: Add missing libmnl-dev dependency + * Depend on liboping 1.7.0 instead of 1.9.0 + + [ Oliver Smith ] + * osmo-sysmon -h: s/OsmoHLR/osmo-sysmon/ + * contrib/jenkins.sh: run "make maintainer-clean" + + -- Harald Welte Sun, 14 Jul 2019 08:04:51 +0800 + osmo-sysmon (0.1.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/14770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I34ef32535a0d6a07feeb43a7e4ebf405d7d68c44 Gerrit-Change-Number: 14770 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 00:44:40 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 00:44:40 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eopenbsc=5Bmaster=5D=3A_Bump_version=3A_1=2E2=2E0=2E20-cf711_=E2=86=92_1=2E3=2E0?= Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/openbsc/+/14771 Change subject: Bump version: 1.2.0.20-cf711 ? 1.3.0 ...................................................................... Bump version: 1.2.0.20-cf711 ? 1.3.0 Change-Id: I4654650ae90463442dc7017ea86b6910732e30bb --- M debian/changelog 1 file changed, 36 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/71/14771/1 diff --git a/debian/changelog b/debian/changelog index 20ffc81..51bc211 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,39 @@ +openbsc (1.3.0) unstable; urgency=medium + + [ Keith ] + * Don't deliver alert notifications to an ESME that is not yet bound. + * Write configuration correctly from vty (alert notifications) + * tests: Mute stdout during db_prepare() + + [ Pau Espin Pedrol ] + * osmo-bsc-mgcp.service: Fix parsing of cmdline option s + * talloc_ctx_init: Use public API osmo_signal_talloc_ctx_init + * Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id ones + * vty_test_runner: Handle MGCP message recv len dynamically + * nat: Return error code in queue_for_msc + * tests: Fix selection of python version + * nat: Fix crash (double-free) in forward_sccp_to_msc + * nat: Allocate bsc_nat_parsed on the stack instead of heap + * mgcp: Handle CI and X-Osmux param name as case insensitive + * bsc-nat: Remove whitespace at the end of CTR descriptions + + [ Max ] + * Drop openggsn from build dependencies + * Drop Iu*S support and related dependencies + + [ Rafael Diniz ] + * Fixed MNCC_RTP_CREATE after MNCC_DISC_IND. + + [ Daniel Willmann ] + * osmo-bsc_nat: Parse MGCP Connection ID as hex + * libmgcp: Parse CI as hex string in verify_ci() + * manuals: Add script to regenerate counter/vty documentation + + [ Oliver Smith ] + * contrib/jenkins.sh: run "make maintainer-clean" + + -- Harald Welte Sun, 14 Jul 2019 08:42:36 +0800 + openbsc (1.2.0) unstable; urgency=medium [ Pau Espin Pedrol ] -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14771 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I4654650ae90463442dc7017ea86b6910732e30bb Gerrit-Change-Number: 14771 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Sun Jul 14 01:22:18 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 14 Jul 2019 01:22:18 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2a83ceee4ed_261c12765f43756852@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_Unstable/x86_64 Package network:osmocom:latest/openbsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 163s] | #define HAVE_MEMORY_H 1 [ 163s] | #define HAVE_STRINGS_H 1 [ 163s] | #define HAVE_INTTYPES_H 1 [ 163s] | #define HAVE_STDINT_H 1 [ 163s] | #define HAVE_UNISTD_H 1 [ 163s] | #define HAVE_DLFCN_H 1 [ 163s] | #define LT_OBJDIR ".libs/" [ 163s] | #define BUILD_SMPP 1 [ 163s] | #define STDC_HEADERS 1 [ 163s] | #define HAVE_DBI_DBD_H 1 [ 163s] | #define HAVE_PCAP_PCAP_H 1 [ 163s] | #define HAVE_TM_GMTOFF_IN_TM 1 [ 163s] | [ 163s] | configure: exit 0 [ 163s] [ 163s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 163s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 163s] make: *** [debian/rules:13: build] Error 2 [ 163s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 163s] [ 163s] lamb74 failed "build openbsc_1.2.0.dsc" at Sun Jul 14 01:22:09 UTC 2019. [ 163s] [ 163s] ### VM INTERACTION START ### [ 166s] [ 152.625915] sysrq: SysRq : Power Off [ 166s] [ 152.633295] reboot: Power down [ 166s] ### VM INTERACTION END ### [ 166s] [ 166s] lamb74 failed "build openbsc_1.2.0.dsc" at Sun Jul 14 01:22:13 UTC 2019. [ 166s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 14 02:44:34 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 14 Jul 2019 02:44:34 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in Debian_9.0/i586 In-Reply-To: References: Message-ID: <5d2a972025bca_261c12765f43779772@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_9.0/i586 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 170s] | #define HAVE_DLFCN_H 1 [ 170s] | #define LT_OBJDIR ".libs/" [ 170s] | #define STDC_HEADERS 1 [ 170s] | #define HAVE_EXECINFO_H 1 [ 170s] | #define HAVE_SYS_SELECT_H 1 [ 170s] | #define HAVE_SYS_SOCKET_H 1 [ 170s] | #define HAVE_SYSLOG_H 1 [ 170s] | #define HAVE_CTYPE_H 1 [ 170s] | #define HAVE_LIBSCTP 1 [ 170s] | #define HAVE_PCAP_H 1 [ 170s] | [ 170s] | configure: exit 0 [ 170s] [ 170s] debian/rules:27: recipe for target 'override_dh_auto_test' failed [ 170s] make[1]: *** [override_dh_auto_test] Error 1 [ 170s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 170s] debian/rules:13: recipe for target 'build' failed [ 170s] make: *** [build] Error 2 [ 170s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 170s] [ 170s] lamb25 failed "build libosmo-netif_0.5.0.2.6563.dsc" at Sun Jul 14 02:44:22 UTC 2019. [ 170s] [ 170s] ### VM INTERACTION START ### [ 172s] [ 156.396612] sysrq: SysRq : Power Off [ 172s] [ 156.407457] reboot: Power down [ 172s] ### VM INTERACTION END ### [ 172s] [ 172s] lamb25 failed "build libosmo-netif_0.5.0.2.6563.dsc" at Sun Jul 14 02:44:25 UTC 2019. [ 172s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 14 02:47:25 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 14 Jul 2019 02:47:25 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in Debian_8.0/x86_64 In-Reply-To: References: Message-ID: <5d2a97d9597a3_261c12765f4378056e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_8.0/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 109s] autoreconnecting test step 3 [client OK, server OK], FD reg 1 [ 109s] [ 109s] autoreconnecting test step 2 [client OK, server OK], FD reg 0 [ 109s] + [ 109s] +autoreconnecting test step 1 [client OK, server OK], FD reg 0 [ 109s] connection closed with srv [ 109s] [ 109s] -autoreconnecting test step 1 [client OK, server NA], FD reg 0 [ 109s] +autoreconnecting test step 0 [client OK, server NA], FD reg 0 [ 109s] [ 109s] non-reconnecting test step 7 [client NA, server OK], FD reg 1 [ 109s] [ 109s] 1. testsuite.at:4: 1. stream_test (testsuite.at:4): FAILED (testsuite.at:8) [ 109s] debian/rules:27: recipe for target 'override_dh_auto_test' failed [ 109s] make[1]: *** [override_dh_auto_test] Error 1 [ 109s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 109s] debian/rules:13: recipe for target 'build' failed [ 109s] make: *** [build] Error 2 [ 109s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 109s] [ 109s] lamb54 failed "build libosmo-netif_0.5.0.2.6563.dsc" at Sun Jul 14 02:47:13 UTC 2019. [ 109s] [ 109s] ### VM INTERACTION START ### [ 110s] Powering off. [ 110s] [ 98.299941] reboot: Power down [ 110s] ### VM INTERACTION END ### [ 110s] [ 110s] lamb54 failed "build libosmo-netif_0.5.0.2.6563.dsc" at Sun Jul 14 02:47:15 UTC 2019. [ 110s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 14 02:48:34 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 14 Jul 2019 02:48:34 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2a980fa3758_261c12765f437808a0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 432s] | This file was extended by libosmocore config.status 1.1.0.79-a3dec, which was [ 432s] | generated by GNU Autoconf 2.69. Invocation command line was [ 432s] | [ 432s] | CONFIG_FILES = [ 432s] | CONFIG_HEADERS = [ 432s] | CONFIG_LINKS = [ 432s] | CONFIG_COMMANDS = [ 432s] | $ ./config.status Doxyfile.core [ 432s] | [ 432s] | on armbuild26 [ 432s] | [ 432s] | config.status:1200: creating Doxyfile.core [ 432s] [ 432s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 432s] make[1]: *** [override_dh_auto_test] Error 1 [ 432s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 432s] debian/rules:15: recipe for target 'build' failed [ 432s] make: *** [build] Error 2 [ 432s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 432s] [ 432s] armbuild26 failed "build libosmocore_1.1.0.79.a3dec.dsc" at Sun Jul 14 02:48:18 UTC 2019. [ 432s] [ 432s] ### VM INTERACTION START ### [ 434s] [ 411.810531] sysrq: SysRq : Power Off [ 434s] [ 411.812858] reboot: Power down [ 434s] ### VM INTERACTION END ### [ 434s] [ 434s] armbuild26 failed "build libosmocore_1.1.0.79.a3dec.dsc" at Sun Jul 14 02:48:21 UTC 2019. [ 434s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Sun Jul 14 03:53:18 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 03:53:18 +0000 Subject: Change in ...osmo-bts[master]: remove dummy UL measurement results for lost sacch frames In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14762 ) Change subject: remove dummy UL measurement results for lost sacch frames ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idfa123f8d02a9d8be1f6de6923fc2a8628020145 Gerrit-Change-Number: 14762 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 14 Jul 2019 03:53:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 03:54:54 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 03:54:54 +0000 Subject: Change in ...osmo-pcu[master]: Use libosmocore for IMSI parsing In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/13395 ) Change subject: Use libosmocore for IMSI parsing ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/13395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iec5c65776fc54b2f9e5dd55c711ace2471662db1 Gerrit-Change-Number: 13395 Gerrit-PatchSet: 4 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: msuraev Gerrit-CC: Vadim Yanitskiy Gerrit-Comment-Date: Sun, 14 Jul 2019 03:54:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 03:55:14 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 03:55:14 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: ACK/NACK: always encode with length field present In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14697 ) Change subject: Encoding: ACK/NACK: always encode with length field present ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb Gerrit-Change-Number: 14697 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 03:55:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 03:55:19 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 03:55:19 +0000 Subject: Change in ...osmo-pcu[master]: Encoding: ACK/NACK: always encode with length field present In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14697 ) Change subject: Encoding: ACK/NACK: always encode with length field present ...................................................................... Encoding: ACK/NACK: always encode with length field present In most cases the length field was present and this field takes 7 bits of the maximum available 110 rest bits. The length field was only removed when encoding huge bitmaps usually only happen on lossy connections with packet lost. However the cases without length field were encoded incorrect, because all remaining bits must be used by the uncompressed bitmaps, but the PCU violates this by encoding always the "release 5" bit. Rather than fixing the encoding without length field, simply remove it and always encode with length field. This also reduces the code complexity. Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb --- M src/encoding.cpp 1 file changed, 39 insertions(+), 43 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/encoding.cpp b/src/encoding.cpp index 48f3829..ca9e906 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -828,6 +828,17 @@ bitvec_write_field(dest, &wp, 0, 1); // 0: don't have REL 5 }; +/* Encode the Ack/Nack for EGPRS. 44.060 + * The PCU encodes to receive block bitmap to the following rules: + * - always encode the lenght field + * - use compressed receive block bitmap if it's smaller than uncompressed + * receive block bitmap + * - use the remaining bits for an uncompressed receive block bitmap if needed + * + * Note: The spec also defines an Ack/Nack without length field, but the PCU's + * doesn't support this in UL. It would require a lot more code complexity + * and only saves 7 bit in lossy sitations. + */ static void write_packet_ack_nack_desc_egprs( bitvec * dest, unsigned& wp, gprs_rlc_ul_window *window, bool is_final, unsigned rest_bits) @@ -849,12 +860,12 @@ bitvec ucmp_vec; bitvec crbb_vec; uint8_t uclen_crbb = 0; - bool len_coded = true; uint8_t crbb_start_clr_code; uint8_t i; /* static size of 16 bits - ..0. .... = ACKNACK: (Union) + ..1. .... = ACKNACK: (Union) + 0 0000 000 Length Desc ...0 .... = FINAL_ACK_INDICATION: False @@ -865,8 +876,9 @@ .... ..10 0101 0001 1... .... = STARTING_SEQUENCE_NUMBER: 1187 - .0.. .... = CRBB Exist: 0 */ - rest_bits -= 16; + .0.. .... = CRBB Exist: 0 + minimal size is 24 rest_bits */ + rest_bits -= 24; if (num_blocks > 0) /* V(Q) is NACK and omitted -> SSN = V(Q) + 1 */ @@ -903,47 +915,31 @@ crbb_len = crbb_vec.cur_bit; } - if (is_compressed == 0) { - /* length field takes 8 bits*/ - if (num_blocks > rest_bits - 8) { - eow = false; - urbb_len = rest_bits; - len_coded = false; - } else if (num_blocks == rest_bits) { - urbb_len = rest_bits; - len_coded = false; - } else - urbb_len = num_blocks; - len = urbb_len + 15; + if (is_compressed) { + /* 8 = 7 (CRBBlength) + 1 (CRBB starting color code) */ + rest_bits -= 8; } else { - if (num_blocks > uclen_crbb) { - eow = false; - urbb_len = num_blocks - uclen_crbb; - } - /* Union bit takes 1 bit */ - /* Other fields in descr of compresed bitmap takes 23 bits - * -8 = CRBB_STARTING_COLOR_CODE + CRBB_LENGTH */ - if (urbb_len > (rest_bits - crbb_len - 8)) { - eow = false; - len_coded = false; - urbb_len = rest_bits - crbb_len - 8; - /* -16 = ACKNACK Dissector length + CRBB_STARTING_COLOR_CODE + CRBB_LENGTH */ - } else if (urbb_len > (rest_bits - crbb_len - 16)) { - eow = false; - len_coded = false; - urbb_len = rest_bits - crbb_len - 16; - } + uclen_crbb = 0; + crbb_len = 0; + } + + if (num_blocks > uclen_crbb + rest_bits) { + eow = false; + urbb_len = rest_bits - crbb_len; + } else + urbb_len = num_blocks - uclen_crbb; + + if (is_compressed) len = urbb_len + crbb_len + 23; - } + else + len = urbb_len + 15; - /* EGPRS Ack/Nack Description IE */ - if (len_coded == false) { - bitvec_write_field(dest, &wp, 0, 1); // 0: don't have length - } else { - bitvec_write_field(dest, &wp, 1, 1); // 1: have length - bitvec_write_field(dest, &wp, len, 8); // length - } + + /* EGPRS Ack/Nack Description IE + * do not support Ack/Nack without length */ + bitvec_write_field(dest, &wp, 1, 1); // 1: have length + bitvec_write_field(dest, &wp, len, 8); // length bitvec_write_field(dest, &wp, is_final, 1); // FINAL_ACK_INDICATION bitvec_write_field(dest, &wp, bow, 1); // BEGINNING_OF_WINDOW @@ -973,9 +969,9 @@ } LOGP(DRLCMACUL, LOGL_DEBUG, "EGPRS URBB, urbb len = %d, SSN = %u, ESN_CRBB = %u, " - "len present = %s,desc len = %d, " + "desc len = %d, " "SNS = %d, WS = %d, V(Q) = %d, V(R) = %d%s%s\n", - urbb_len, ssn, esn_crbb, len_coded ? "yes" : "No" , len, + urbb_len, ssn, esn_crbb, len, window->sns(), window->ws(), window->v_q(), window->v_r(), bow ? ", BOW" : "", eow ? ", EOW" : ""); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14697 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7bc2e18d647b72b8f17ba7a5c9c5e421d88275fb Gerrit-Change-Number: 14697 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 03:55:58 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 03:55:58 +0000 Subject: Change in ...osmo-pcu[master]: tests: test encoding of egprs ul ack/nacks In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14760 ) Change subject: tests: test encoding of egprs ul ack/nacks ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I35d6b5e312faeb116ddda6b33c550840da1496fe Gerrit-Change-Number: 14760 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 03:55:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 03:59:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 03:59:22 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 ) Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Patch Set 4: No matter what we do, the resolutoin of 1/10th of dB (centi-bel) is for sure more than sufficient for the purpose of in terms of range, using uint16_t gives a range of 0..655.35 dB, which is certainly sufficient ;) So both from a resolution and from a range point of view, uint16_t is fine. What I'm a bit more worried is whether there could be negative values? But I guess if the interference is stronger than the carrier, we wouldn't detect the training sequence anymore? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 03:59:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 04:01:03 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 04:01:03 +0000 Subject: Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14758 ) Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 04:01:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 04:03:11 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 04:03:11 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: fix TC_lu_by_imei In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 ) Change subject: msc: fix TC_lu_by_imei ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14755/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14755/2//COMMIT_MSG at 12 PS2, Line 12: erforming a valueof or send operation on a non-specific template of enumerated type where is that valueof() or send() operation? I can see you are only touching the use of a receive template here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b Gerrit-Change-Number: 14755 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 04:03:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 04:15:11 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 04:15:11 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eopenbsc=5Bmaster=5D=3A_Bump_version=3A_1=2E2=2E0=2E20-cf711_=E2=86=92_1=2E3=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14771 ) Change subject: Bump version: 1.2.0.20-cf711 ? 1.3.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14771 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I4654650ae90463442dc7017ea86b6910732e30bb Gerrit-Change-Number: 14771 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 04:15:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 04:15:14 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 04:15:14 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eopenbsc=5Bmaster=5D=3A_Bump_version=3A_1=2E2=2E0=2E20-cf711_=E2=86=92_1=2E3=2E0?= In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/openbsc/+/14771 ) Change subject: Bump version: 1.2.0.20-cf711 ? 1.3.0 ...................................................................... Bump version: 1.2.0.20-cf711 ? 1.3.0 Change-Id: I4654650ae90463442dc7017ea86b6910732e30bb --- M debian/changelog 1 file changed, 36 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 20ffc81..51bc211 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,39 @@ +openbsc (1.3.0) unstable; urgency=medium + + [ Keith ] + * Don't deliver alert notifications to an ESME that is not yet bound. + * Write configuration correctly from vty (alert notifications) + * tests: Mute stdout during db_prepare() + + [ Pau Espin Pedrol ] + * osmo-bsc-mgcp.service: Fix parsing of cmdline option s + * talloc_ctx_init: Use public API osmo_signal_talloc_ctx_init + * Replace broken ipa_ccm_idtag APIs with new ipa_ccm_id ones + * vty_test_runner: Handle MGCP message recv len dynamically + * nat: Return error code in queue_for_msc + * tests: Fix selection of python version + * nat: Fix crash (double-free) in forward_sccp_to_msc + * nat: Allocate bsc_nat_parsed on the stack instead of heap + * mgcp: Handle CI and X-Osmux param name as case insensitive + * bsc-nat: Remove whitespace at the end of CTR descriptions + + [ Max ] + * Drop openggsn from build dependencies + * Drop Iu*S support and related dependencies + + [ Rafael Diniz ] + * Fixed MNCC_RTP_CREATE after MNCC_DISC_IND. + + [ Daniel Willmann ] + * osmo-bsc_nat: Parse MGCP Connection ID as hex + * libmgcp: Parse CI as hex string in verify_ci() + * manuals: Add script to regenerate counter/vty documentation + + [ Oliver Smith ] + * contrib/jenkins.sh: run "make maintainer-clean" + + -- Harald Welte Sun, 14 Jul 2019 08:42:36 +0800 + openbsc (1.2.0) unstable; urgency=medium [ Pau Espin Pedrol ] -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14771 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: I4654650ae90463442dc7017ea86b6910732e30bb Gerrit-Change-Number: 14771 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 04:15:54 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 04:15:54 +0000 Subject: Change in ...osmo-bts[master]: Move Access Burst link quality handling to L1SAP In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14687 ) Change subject: Move Access Burst link quality handling to L1SAP ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Gerrit-Change-Number: 14687 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 04:15:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 04:17:06 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 04:17:06 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support SETFORMAT command In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14665 ) Change subject: Transceiver: Support SETFORMAT command ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9fc22f9987238a5ff870df7718de4efc9e04289 Gerrit-Change-Number: 14665 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 14 Jul 2019 04:17:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 04:18:34 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 14 Jul 2019 04:18:34 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support TRXD v1 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14657 ) Change subject: Transceiver: Support TRXD v1 ...................................................................... Patch Set 9: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14657/9/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/14657/9/Transceiver52M/Transceiver.cpp at 622 PS9, Line 622: bi->tss = 0; > I just checked 3GPP TS 45.002, tables 5.2.3a-d. [?] might make sense to have a comment (or even an enum) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 14 Jul 2019 04:18:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 14 04:20:14 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 14 Jul 2019 04:20:14 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 ) Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Patch Set 4: > using uint16_t gives a range of 0..655.35 dB, which is certainly sufficient ;) > So both from a resolution and from a range point of view, uint16_t is fine. > What I'm a bit more worried is whether there could be negative values? I am actually changing to signed (int16_t) which gives us a range of -3276.8 .. 3276.7 dB, or -32768 .. 32767 cB. This is still more than enough. Moreover, on all interfaces such as PCUIF or L1SAP, we need a value in centiBels stored in int16_t. So I think it should be ok. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 14 Jul 2019 04:20:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Sun Jul 14 07:03:29 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 14 Jul 2019 07:03:29 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d2ad3d435e04_261c12765f438511ba@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_Testing/x86_64 Package network:osmocom:latest/openbsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 224s] | #define HAVE_MEMORY_H 1 [ 224s] | #define HAVE_STRINGS_H 1 [ 224s] | #define HAVE_INTTYPES_H 1 [ 224s] | #define HAVE_STDINT_H 1 [ 224s] | #define HAVE_UNISTD_H 1 [ 224s] | #define HAVE_DLFCN_H 1 [ 224s] | #define LT_OBJDIR ".libs/" [ 224s] | #define BUILD_SMPP 1 [ 224s] | #define STDC_HEADERS 1 [ 224s] | #define HAVE_DBI_DBD_H 1 [ 224s] | #define HAVE_PCAP_PCAP_H 1 [ 224s] | #define HAVE_TM_GMTOFF_IN_TM 1 [ 224s] | [ 224s] | configure: exit 0 [ 224s] [ 224s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 224s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 224s] make: *** [debian/rules:13: build] Error 2 [ 224s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 224s] [ 224s] build83 failed "build openbsc_1.2.0.dsc" at Sun Jul 14 07:03:15 UTC 2019. [ 224s] [ 224s] ### VM INTERACTION START ### [ 227s] [ 213.949564] sysrq: SysRq : Power Off [ 227s] [ 213.965702] reboot: Power down [ 227s] ### VM INTERACTION END ### [ 227s] [ 227s] build83 failed "build openbsc_1.2.0.dsc" at Sun Jul 14 07:03:19 UTC 2019. [ 227s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 14 09:07:28 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 14 Jul 2019 09:07:28 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2af0e3111b7_261c12765f438962a8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 414s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 414s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 414s] collect2: error: ld returned 1 exit status [ 414s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 414s] make[4]: *** [osmo-bts-virtual] Error 1 [ 414s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 414s] Makefile:385: recipe for target 'all-recursive' failed [ 414s] make[3]: *** [all-recursive] Error 1 [ 414s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 414s] Makefile:434: recipe for target 'all-recursive' failed [ 414s] make[2]: *** [all-recursive] Error 1 [ 414s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 414s] Makefile:366: recipe for target 'all' failed [ 414s] make[1]: *** [all] Error 2 [ 414s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 414s] dh_auto_build: make -j1 returned exit code 2 [ 414s] debian/rules:12: recipe for target 'build' failed [ 414s] make: *** [build] Error 2 [ 414s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 414s] [ 414s] armbuild25 failed "build osmo-bts_0.8.1.336.04e9.dsc" at Sun Jul 14 09:07:21 UTC 2019. [ 414s] [ 414s] ### VM INTERACTION START ### [ 417s] [ 390.462093] sysrq: SysRq : Power Off [ 417s] [ 390.479288] reboot: Power down [ 417s] ### VM INTERACTION END ### [ 417s] [ 417s] armbuild25 failed "build osmo-bts_0.8.1.336.04e9.dsc" at Sun Jul 14 09:07:24 UTC 2019. [ 417s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 14 13:25:32 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 14 Jul 2019 13:25:32 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2b2d65f1d34_404ea1a5f459793@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 588s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 588s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 588s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 589s] Makefile:442: recipe for target 'vlr.o' failed [ 589s] make[4]: *** [vlr.o] Error 1 [ 589s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 589s] Makefile:422: recipe for target 'all-recursive' failed [ 589s] make[3]: *** [all-recursive] Error 1 [ 589s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 589s] Makefile:462: recipe for target 'all-recursive' failed [ 589s] make[2]: *** [all-recursive] Error 1 [ 589s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 589s] Makefile:394: recipe for target 'all' failed [ 589s] make[1]: *** [all] Error 2 [ 589s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 589s] dh_auto_build: make -j1 returned exit code 2 [ 589s] debian/rules:45: recipe for target 'build' failed [ 589s] make: *** [build] Error 2 [ 589s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 589s] [ 589s] armbuild01 failed "build osmo-msc_1.3.1.178.aa0a.dsc" at Sun Jul 14 13:25:13 UTC 2019. [ 589s] [ 589s] ### VM INTERACTION START ### [ 592s] [ 555.789012] sysrq: SysRq : Power Off [ 592s] [ 555.792047] reboot: Power down [ 592s] ### VM INTERACTION END ### [ 592s] [ 592s] armbuild01 failed "build osmo-msc_1.3.1.178.aa0a.dsc" at Sun Jul 14 13:25:16 UTC 2019. [ 592s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 14 13:48:41 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 14 Jul 2019 13:48:41 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2b32c7c8b71_404ea1a5f4684d2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 562s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 562s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 562s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 562s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 562s] make[4]: *** [gb_proxy.o] Error 1 [ 562s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 562s] Makefile:391: recipe for target 'all-recursive' failed [ 562s] make[3]: *** [all-recursive] Error 1 [ 562s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 562s] Makefile:453: recipe for target 'all-recursive' failed [ 562s] make[2]: *** [all-recursive] Error 1 [ 562s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 562s] Makefile:385: recipe for target 'all' failed [ 562s] make[1]: *** [all] Error 2 [ 562s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 562s] dh_auto_build: make -j1 returned exit code 2 [ 562s] debian/rules:45: recipe for target 'build' failed [ 562s] make: *** [build] Error 2 [ 562s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 562s] [ 562s] armbuild25 failed "build osmo-sgsn_1.4.0.28.43f16.dsc" at Sun Jul 14 13:48:20 UTC 2019. [ 562s] [ 562s] ### VM INTERACTION START ### [ 565s] [ 475.178688] sysrq: SysRq : Power Off [ 565s] [ 475.205413] reboot: Power down [ 566s] ### VM INTERACTION END ### [ 566s] [ 566s] armbuild25 failed "build osmo-sgsn_1.4.0.28.43f16.dsc" at Sun Jul 14 13:48:24 UTC 2019. [ 566s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 14 15:43:15 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 14 Jul 2019 15:43:15 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2b4da04400d_404ea1a5f496393@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 105s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 105s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 105s] dh_installdocs [ 105s] dh_installchangelogs [ 105s] dh_python2 [ 106s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 106s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 106s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 106s] dh_python3 [ 106s] debian/rules override_dh_installinit [ 106s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 106s] # Install service file with different name than package name: [ 106s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 106s] dh_installinit --name=osmo-ctrl2cgi [ 106s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script not found [ 106s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 106s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 106s] make: *** [debian/rules:4: binary] Error 2 [ 106s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 106s] [ 106s] lamb13 failed "build osmo-python-tests_0.0.9.20190714.dsc" at Sun Jul 14 15:43:07 UTC 2019. [ 106s] [ 106s] ### VM INTERACTION START ### [ 109s] [ 95.379719] sysrq: SysRq : Power Off [ 109s] [ 95.387221] reboot: Power down [ 109s] ### VM INTERACTION END ### [ 109s] [ 109s] lamb13 failed "build osmo-python-tests_0.0.9.20190714.dsc" at Sun Jul 14 15:43:11 UTC 2019. [ 109s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 14 15:55:32 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 14 Jul 2019 15:55:32 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2b508abdf50_404ea1a5f499946@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_Unstable/x86_64 Package network:osmocom:latest/openbsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 165s] | #define HAVE_MEMORY_H 1 [ 165s] | #define HAVE_STRINGS_H 1 [ 165s] | #define HAVE_INTTYPES_H 1 [ 165s] | #define HAVE_STDINT_H 1 [ 165s] | #define HAVE_UNISTD_H 1 [ 165s] | #define HAVE_DLFCN_H 1 [ 165s] | #define LT_OBJDIR ".libs/" [ 165s] | #define BUILD_SMPP 1 [ 165s] | #define STDC_HEADERS 1 [ 165s] | #define HAVE_DBI_DBD_H 1 [ 165s] | #define HAVE_PCAP_PCAP_H 1 [ 165s] | #define HAVE_TM_GMTOFF_IN_TM 1 [ 165s] | [ 165s] | configure: exit 0 [ 165s] [ 165s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 165s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 165s] make: *** [debian/rules:13: build] Error 2 [ 165s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 165s] [ 165s] lamb06 failed "build openbsc_1.2.0.dsc" at Sun Jul 14 15:55:23 UTC 2019. [ 165s] [ 165s] ### VM INTERACTION START ### [ 168s] [ 154.638987] sysrq: SysRq : Power Off [ 168s] [ 154.647200] reboot: Power down [ 168s] ### VM INTERACTION END ### [ 168s] [ 168s] lamb06 failed "build openbsc_1.2.0.dsc" at Sun Jul 14 15:55:26 UTC 2019. [ 168s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 14 21:43:38 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 14 Jul 2019 21:43:38 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2ba21d722bf_34405a05f0860bc@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 105s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 105s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 105s] dh_installdocs [ 105s] dh_installchangelogs [ 105s] dh_python2 [ 105s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 105s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 105s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 105s] dh_python3 [ 106s] debian/rules override_dh_installinit [ 106s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 106s] # Install service file with different name than package name: [ 106s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 106s] dh_installinit --name=osmo-ctrl2cgi [ 106s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script not found [ 106s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 106s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 106s] make: *** [debian/rules:4: binary] Error 2 [ 106s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 106s] [ 106s] lamb51 failed "build osmo-python-tests_0.0.9.20190714.dsc" at Sun Jul 14 21:43:33 UTC 2019. [ 106s] [ 106s] ### VM INTERACTION START ### [ 109s] [ 95.599930] sysrq: SysRq : Power Off [ 109s] [ 95.607163] reboot: Power down [ 109s] ### VM INTERACTION END ### [ 109s] [ 109s] lamb51 failed "build osmo-python-tests_0.0.9.20190714.dsc" at Sun Jul 14 21:43:36 UTC 2019. [ 109s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 14 21:57:04 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 14 Jul 2019 21:57:04 +0000 Subject: Build failure of network:osmocom:latest/openbsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2ba54714404_34405a05f0886f5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/openbsc/Debian_Unstable/x86_64 Package network:osmocom:latest/openbsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest openbsc Last lines of build log: [ 164s] | #define HAVE_MEMORY_H 1 [ 164s] | #define HAVE_STRINGS_H 1 [ 164s] | #define HAVE_INTTYPES_H 1 [ 164s] | #define HAVE_STDINT_H 1 [ 164s] | #define HAVE_UNISTD_H 1 [ 164s] | #define HAVE_DLFCN_H 1 [ 164s] | #define LT_OBJDIR ".libs/" [ 164s] | #define BUILD_SMPP 1 [ 164s] | #define STDC_HEADERS 1 [ 164s] | #define HAVE_DBI_DBD_H 1 [ 164s] | #define HAVE_PCAP_PCAP_H 1 [ 164s] | #define HAVE_TM_GMTOFF_IN_TM 1 [ 164s] | [ 164s] | configure: exit 0 [ 164s] [ 164s] make[1]: *** [debian/rules:30: override_dh_auto_test] Error 1 [ 164s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 164s] make: *** [debian/rules:13: build] Error 2 [ 164s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 164s] [ 164s] lamb20 failed "build openbsc_1.2.0.dsc" at Sun Jul 14 21:56:57 UTC 2019. [ 164s] [ 164s] ### VM INTERACTION START ### [ 168s] [ 153.548380] sysrq: SysRq : Power Off [ 168s] [ 153.557146] reboot: Power down [ 168s] ### VM INTERACTION END ### [ 168s] [ 168s] lamb20 failed "build openbsc_1.2.0.dsc" at Sun Jul 14 21:57:02 UTC 2019. [ 168s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 15 02:36:16 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 15 Jul 2019 02:36:16 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2be6ab76178_34405a05f01319cd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 59s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 59s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 59s] dh_installdocs [ 59s] dh_installchangelogs [ 59s] dh_python2 [ 59s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 59s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 59s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 59s] dh_python3 [ 59s] debian/rules override_dh_installinit [ 59s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 59s] # Install service file with different name than package name: [ 59s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 59s] dh_installinit --name=osmo-ctrl2cgi [ 59s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script not found [ 59s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 59s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 59s] make: *** [debian/rules:4: binary] Error 2 [ 59s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 59s] [ 59s] build83 failed "build osmo-python-tests_0.0.9.20190715.dsc" at Mon Jul 15 02:36:12 UTC 2019. [ 59s] [ 59s] ### VM INTERACTION START ### [ 62s] [ 53.035478] sysrq: SysRq : Power Off [ 62s] [ 53.037182] reboot: Power down [ 62s] ### VM INTERACTION END ### [ 62s] [ 62s] build83 failed "build osmo-python-tests_0.0.9.20190715.dsc" at Mon Jul 15 02:36:15 UTC 2019. [ 62s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 15 02:54:00 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 15 Jul 2019 02:54:00 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2beae65066f_34405a05f013456c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 1060s] -Returned: 0, Current node: 1 '%s> ' [ 1060s] -Going to execute 'ambiguous_str' [ 1060s] -Called: 'ambiguous_str [ARG]' (argc=0) [ 1060s] -Returned: 0, Current node: 1 '%s> ' [ 1060s] -Going to execute 'ambiguous_str arg' [ 1060s] -Called: 'ambiguous_str [ARG]' (argc=1) [ 1060s] -Returned: 0, Current node: 1 '%s> ' [ 1060s] -Going to execute 'ambiguous_str arg keyword' [ 1060s] -Called: 'ambiguous_str ARG keyword' [ 1060s] -Returned: 0, Current node: 1 '%s> ' [ 1060s] -All tests passed [ 1060s] ./testsuite.at:196: exit code was 139, expected 0 [ 1060s] 31. testsuite.at:192: 31. vty (testsuite.at:192): FAILED (testsuite.at:196) [ 1060s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 1060s] make[1]: *** [override_dh_auto_test] Error 1 [ 1060s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1060s] debian/rules:15: recipe for target 'build' failed [ 1060s] make: *** [build] Error 2 [ 1060s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 1060s] [ 1060s] obs-arm-5 failed "build libosmocore_1.1.0.79.a3dec.dsc" at Mon Jul 15 02:53:39 UTC 2019. [ 1060s] [ 1060s] ### VM INTERACTION START ### [ 1062s] [ 1033.771924] sysrq: SysRq : Power Off [ 1062s] [ 1033.808924] reboot: Power down [ 1063s] ### VM INTERACTION END ### [ 1063s] [ 1063s] obs-arm-5 failed "build libosmocore_1.1.0.79.a3dec.dsc" at Mon Jul 15 02:53:43 UTC 2019. [ 1063s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 15 03:45:08 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 15 Jul 2019 03:45:08 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2bf6d78bf3b_34405a05f0138652@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 105s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 105s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 105s] dh_installdocs [ 105s] dh_installchangelogs [ 105s] dh_python2 [ 105s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 105s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 105s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 105s] dh_python3 [ 105s] debian/rules override_dh_installinit [ 105s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 105s] # Install service file with different name than package name: [ 105s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 105s] dh_installinit --name=osmo-ctrl2cgi [ 106s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script not found [ 106s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 106s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 106s] make: *** [debian/rules:4: binary] Error 2 [ 106s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 106s] [ 106s] lamb19 failed "build osmo-python-tests_0.0.9.20190715.dsc" at Mon Jul 15 03:44:51 UTC 2019. [ 106s] [ 106s] ### VM INTERACTION START ### [ 109s] [ 95.140851] sysrq: SysRq : Power Off [ 109s] [ 95.147511] reboot: Power down [ 109s] ### VM INTERACTION END ### [ 109s] [ 109s] lamb19 failed "build osmo-python-tests_0.0.9.20190715.dsc" at Mon Jul 15 03:44:55 UTC 2019. [ 109s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 15 06:35:08 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 15 Jul 2019 06:35:08 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2c1eb2b8bb7_34405a05f018787d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 529s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 529s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 529s] collect2: error: ld returned 1 exit status [ 529s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 529s] make[4]: *** [osmo-bts-virtual] Error 1 [ 529s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 529s] Makefile:385: recipe for target 'all-recursive' failed [ 529s] make[3]: *** [all-recursive] Error 1 [ 529s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 529s] Makefile:434: recipe for target 'all-recursive' failed [ 529s] make[2]: *** [all-recursive] Error 1 [ 529s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 529s] Makefile:366: recipe for target 'all' failed [ 529s] make[1]: *** [all] Error 2 [ 529s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 529s] dh_auto_build: make -j1 returned exit code 2 [ 529s] debian/rules:12: recipe for target 'build' failed [ 529s] make: *** [build] Error 2 [ 529s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 529s] [ 529s] obs-arm-6 failed "build osmo-bts_0.8.1.336.04e9.dsc" at Mon Jul 15 06:35:01 UTC 2019. [ 529s] [ 529s] ### VM INTERACTION START ### [ 532s] [ 486.500239] sysrq: SysRq : Power Off [ 532s] [ 486.502045] reboot: Power down [ 532s] ### VM INTERACTION END ### [ 532s] [ 532s] obs-arm-6 failed "build osmo-bts_0.8.1.336.04e9.dsc" at Mon Jul 15 06:35:04 UTC 2019. [ 532s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Jul 15 06:37:18 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Jul 2019 06:37:18 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: fix TC_lu_by_imei In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 ) Change subject: msc: fix TC_lu_by_imei ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14755/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14755/2//COMMIT_MSG at 12 PS2, Line 12: erforming a valueof or send operation on a non-specific template of enumerated type > where is that valueof() or send() operation? I can see you are only touching the use of a receive t [?] It is in the tr_ML3_MT_MM_ID_Req template: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14706/2/library/L3_Templates.ttcn#886 As I wrote in the commit message, maybe it makes more sense to revert the commit that introduced the enum? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b Gerrit-Change-Number: 14755 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 15 Jul 2019 06:37:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 07:21:20 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Jul 2019 07:21:20 +0000 Subject: Change in ...osmo-hlr[master]: manuals: improve subscribers create on demand Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14777 Change subject: manuals: improve subscribers create on demand ...................................................................... manuals: improve subscribers create on demand Write all VTY commands in monospace and add configuration example blocks. Realted: OS#2542 Change-Id: I54f80810db3dac7a4a56ad42c5d2154b6006108c --- M doc/manuals/chapters/subscribers.adoc 1 file changed, 25 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/77/14777/1 diff --git a/doc/manuals/chapters/subscribers.adoc b/doc/manuals/chapters/subscribers.adoc index 9f87131..a1b5fac 100644 --- a/doc/manuals/chapters/subscribers.adoc +++ b/doc/manuals/chapters/subscribers.adoc @@ -72,19 +72,40 @@ Usually a HLR will only allow mobile equipment (ME) on the network, if the HLR has a subscriber entry with the ME's IMSI. But OsmoHLR can also be configured to automatically create new entries for new IMSIs, with the -subscriber-create-on-demand VTY option. The obvious use case is creating the +`subscriber-create-on-demand` VTY option. The obvious use case is creating the new subscriber entry and then allowing the ME to use both the CS (Circuit Switched) and PS (Packet Switched) NAM (Network Access Mode). +---- +hlr + subscriber-create-on-demand 5 cs+ps +---- + On the other hand, operators might only want to give network access to IMSIs, of which they know the owner. In order to do that, one can set the default NAM to -"none" and manually approve new subscribers by enabling their nam_cs and nam_ps +`none` and manually approve new subscribers by enabling their `nam_cs` and `nam_ps` parameters (e.g. over the VTY). +---- +hlr + subscriber-create-on-demand 5 none +---- + Oftentimes it is hard to know, which IMSI belongs to which ME, but the IMEI is readily available. If you configure your MSC to send IMEI checking requests to the HLR, before sending location update requests, the subscribers created on demand can also have the IMEI stored in the HLR database. With OsmoMSC, this -is done by writing "check-imei-rqd early" in the "msc" section of osmo-msc.cfg. +is done by writing `check-imei-rqd early` in the `msc` section of osmo-msc.cfg. Then enable storing the IMEI when receiving check IMEI requests with -"store-imei" in the OsmoHLR configuration. +`store-imei` in the OsmoHLR configuration. + +---- +msc + check-imei-rqd early +---- + +---- +hlr + subscriber-create-on-demand 5 none + store-imei +---- -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I54f80810db3dac7a4a56ad42c5d2154b6006108c Gerrit-Change-Number: 14777 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Mon Jul 15 07:56:00 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 15 Jul 2019 07:56:00 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2c31ad4a7ae_34405a05f019335@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 955s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 955s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 955s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 955s] Makefile:442: recipe for target 'vlr.o' failed [ 955s] make[4]: *** [vlr.o] Error 1 [ 955s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 955s] Makefile:422: recipe for target 'all-recursive' failed [ 955s] make[3]: *** [all-recursive] Error 1 [ 955s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 955s] Makefile:462: recipe for target 'all-recursive' failed [ 955s] make[2]: *** [all-recursive] Error 1 [ 955s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 955s] Makefile:394: recipe for target 'all' failed [ 955s] make[1]: *** [all] Error 2 [ 955s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 955s] dh_auto_build: make -j1 returned exit code 2 [ 955s] debian/rules:45: recipe for target 'build' failed [ 955s] make: *** [build] Error 2 [ 955s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 955s] [ 955s] obs-arm-5 failed "build osmo-msc_1.3.1.178.aa0a.dsc" at Mon Jul 15 07:55:44 UTC 2019. [ 955s] [ 955s] ### VM INTERACTION START ### [ 958s] [ 925.400763] sysrq: SysRq : Power Off [ 958s] [ 925.405113] reboot: Power down [ 959s] ### VM INTERACTION END ### [ 959s] [ 959s] obs-arm-5 failed "build osmo-msc_1.3.1.178.aa0a.dsc" at Mon Jul 15 07:55:48 UTC 2019. [ 959s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 15 08:10:51 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 15 Jul 2019 08:10:51 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2c3514a7da5_34405a05f0195177@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 1253s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 1253s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 1253s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 1253s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 1253s] make[4]: *** [gb_proxy.o] Error 1 [ 1253s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 1253s] Makefile:391: recipe for target 'all-recursive' failed [ 1253s] make[3]: *** [all-recursive] Error 1 [ 1253s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 1253s] Makefile:453: recipe for target 'all-recursive' failed [ 1253s] make[2]: *** [all-recursive] Error 1 [ 1253s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1253s] Makefile:385: recipe for target 'all' failed [ 1253s] make[1]: *** [all] Error 2 [ 1253s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1253s] dh_auto_build: make -j1 returned exit code 2 [ 1253s] debian/rules:45: recipe for target 'build' failed [ 1253s] make: *** [build] Error 2 [ 1253s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 1253s] [ 1253s] obs-arm-6 failed "build osmo-sgsn_1.4.0.28.43f16.dsc" at Mon Jul 15 08:10:36 UTC 2019. [ 1253s] [ 1253s] ### VM INTERACTION START ### [ 1256s] [ 1212.851541] sysrq: SysRq : Power Off [ 1256s] [ 1212.889235] reboot: Power down [ 1257s] ### VM INTERACTION END ### [ 1257s] [ 1257s] obs-arm-6 failed "build osmo-sgsn_1.4.0.28.43f16.dsc" at Mon Jul 15 08:10:40 UTC 2019. [ 1257s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Jul 15 09:30:15 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Jul 2019 09:30:15 +0000 Subject: Change in ...osmo-hlr[master]: VTY: add subscriber update nam Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14778 Change subject: VTY: add subscriber update nam ...................................................................... VTY: add subscriber update nam Allow updating the NAM (Network Access Mode) of subscribers with the VTY. This is important for the subscriber create on demand use case where subscribers get created without access to PS and CS NAM by default. Regenerate hlr_vty_reference.xml. Related: OS#2542 Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b --- A doc/manuals/chapters/counters_generated.adoc M doc/manuals/vty/hlr_vty_reference.xml M src/hlr_vty_subscr.c M tests/test_subscriber.vty 4 files changed, 93 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/78/14778/1 diff --git a/doc/manuals/chapters/counters_generated.adoc b/doc/manuals/chapters/counters_generated.adoc new file mode 100644 index 0000000..f8f64f5 --- /dev/null +++ b/doc/manuals/chapters/counters_generated.adoc @@ -0,0 +1,14 @@ + +// autogenerated by show asciidoc counters +These counters and their description based on OsmoHLR 1.0.0.41-16e4 (OsmoHLR). + +=== Rate Counters + +// generating tables for rate_ctr_group +== Osmo Stat Items + +// generating tables for osmo_stat_items +== Osmo Counters + +// generating tables for osmo_counters +// there are no ungrouped osmo_counters diff --git a/doc/manuals/vty/hlr_vty_reference.xml b/doc/manuals/vty/hlr_vty_reference.xml index e5fd0f2..ef3c360 100644 --- a/doc/manuals/vty/hlr_vty_reference.xml +++ b/doc/manuals/vty/hlr_vty_reference.xml @@ -811,6 +811,22 @@ + + + + + + + + + + + + + + + + config @@ -1027,8 +1043,7 @@ - - + diff --git a/src/hlr_vty_subscr.c b/src/hlr_vty_subscr.c index 3078577..4c57831 100644 --- a/src/hlr_vty_subscr.c +++ b/src/hlr_vty_subscr.c @@ -577,6 +577,33 @@ return CMD_SUCCESS; } +DEFUN(subscriber_nam, + subscriber_nam_cmd, + SUBSCR_UPDATE "nam (none|cs|ps|cs+ps)", + SUBSCR_UPDATE_HELP + "Set NAM (Network Access Mode) of the subscriber\n" + "Do not allow any NAM\n" + "Allow access to circuit switched NAM\n" + "Allow access to packet switched NAM\n" + "Allow access to circuit and packet switched NAM\n") +{ + struct hlr_subscriber subscr; + const char *id_type = argv[0]; + const char *id = argv[1]; + bool nam_cs = strstr(argv[2], "cs"); + bool nam_ps = strstr(argv[2], "ps"); + + if (get_subscr_by_argv(vty, id_type, id, &subscr)) + return CMD_WARNING; + + if (nam_cs != subscr.nam_cs) + hlr_subscr_nam(g_hlr, &subscr, nam_cs, 0); + if (nam_ps != subscr.nam_ps) + hlr_subscr_nam(g_hlr, &subscr, nam_ps, 1); + + return CMD_SUCCESS; +} + void hlr_vty_subscriber_init(void) { @@ -590,4 +617,5 @@ install_element(ENABLE_NODE, &subscriber_no_aud3g_cmd); install_element(ENABLE_NODE, &subscriber_aud3g_cmd); install_element(ENABLE_NODE, &subscriber_imei_cmd); + install_element(ENABLE_NODE, &subscriber_nam_cmd); } diff --git a/tests/test_subscriber.vty b/tests/test_subscriber.vty index 265f8fa..2627ee3 100644 --- a/tests/test_subscriber.vty +++ b/tests/test_subscriber.vty @@ -12,6 +12,7 @@ subscriber (imsi|msisdn|id|imei) IDENT update aud3g none subscriber (imsi|msisdn|id|imei) IDENT update aud3g milenage k K (op|opc) OP_C [ind-bitlen] [<0-28>] subscriber (imsi|msisdn|id|imei) IDENT update imei (none|IMEI) + subscriber (imsi|msisdn|id|imei) IDENT update nam (none|cs|ps|cs+ps) OsmoHLR# subscriber? subscriber Subscriber management commands @@ -129,6 +130,7 @@ aud2g Set 2G authentication data aud3g Set UMTS authentication data (3G, and 2G with UMTS AKA) imei Set IMEI of the subscriber (normally populated from MSC, no need to set this manually) + nam Set NAM (Network Access Mode) of the subscriber OsmoHLR# subscriber imsi 123456789023000 update msisdn ? none Remove MSISDN (phone number) @@ -437,3 +439,35 @@ IMSI: 000000000000099 MSISDN: none IMEI: 12345 (INVALID LENGTH!) + +OsmoHLR# subscriber imsi 123456789023000 create +% Created subscriber 123456789023000 + ID: 101 + IMSI: 123456789023000 + MSISDN: none +OsmoHLR# subscriber imsi 123456789023000 update nam none +OsmoHLR# subscriber imsi 123456789023000 show + ID: 101 + IMSI: 123456789023000 + MSISDN: none + CS disabled + PS disabled +OsmoHLR# subscriber imsi 123456789023000 update nam cs +OsmoHLR# subscriber imsi 123456789023000 show + ID: 101 + IMSI: 123456789023000 + MSISDN: none + PS disabled +OsmoHLR# subscriber imsi 123456789023000 update nam ps +OsmoHLR# subscriber imsi 123456789023000 show + ID: 101 + IMSI: 123456789023000 + MSISDN: none + CS disabled +OsmoHLR# subscriber imsi 123456789023000 update nam cs+ps +OsmoHLR# subscriber imsi 123456789023000 show + ID: 101 + IMSI: 123456789023000 + MSISDN: none +OsmoHLR# subscriber imsi 123456789023000 delete +% Deleted subscriber for IMSI '123456789023000' -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b Gerrit-Change-Number: 14778 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 09:32:52 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Jul 2019 09:32:52 +0000 Subject: Change in ...osmo-hlr[master]: VTY: add subscriber update nam In-Reply-To: References: Message-ID: osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-hlr/+/14778 ) Change subject: VTY: add subscriber update nam ...................................................................... VTY: add subscriber update nam Allow updating the NAM (Network Access Mode) of subscribers with the VTY. This is important for the subscriber create on demand use case where subscribers get created without access to PS and CS NAM by default. Regenerate hlr_vty_reference.xml. Related: OS#2542 Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b --- M doc/manuals/vty/hlr_vty_reference.xml M src/hlr_vty_subscr.c M tests/test_subscriber.vty 3 files changed, 79 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/78/14778/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b Gerrit-Change-Number: 14778 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 09:34:23 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Jul 2019 09:34:23 +0000 Subject: Change in ...osmo-hlr[master]: manuals: improve subscribers create on demand In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14777 ) Change subject: manuals: improve subscribers create on demand ...................................................................... Patch Set 3: As written on the ML, I've noticed that the VTY command for changing CS and PS NAM was missing. Added it here: https://gerrit.osmocom.org/c/osmo-hlr/+/14778/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I54f80810db3dac7a4a56ad42c5d2154b6006108c Gerrit-Change-Number: 14777 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 15 Jul 2019 09:34:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 09:55:00 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Jul 2019 09:55:00 +0000 Subject: Change in ...osmo-hlr[master]: manuals: improve subscribers create on demand In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14777 ) Change subject: manuals: improve subscribers create on demand ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I54f80810db3dac7a4a56ad42c5d2154b6006108c Gerrit-Change-Number: 14777 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 15 Jul 2019 09:55:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 09:56:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 15 Jul 2019 09:56:35 +0000 Subject: Change in ...osmo-hlr[master]: VTY: add subscriber update nam In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14778 ) Change subject: VTY: add subscriber update nam ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14778/2/src/hlr_vty_subscr.c File src/hlr_vty_subscr.c: https://gerrit.osmocom.org/#/c/14778/2/src/hlr_vty_subscr.c at 582 PS2, Line 582: nam one might expand this to network-access-mode which maybe more people understand than 'nam', which I have never read anywhere outside [few] 3GPP specs, particularly not in any third party literature. so it's not as well known as 'imsi' or the like. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b Gerrit-Change-Number: 14778 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 15 Jul 2019 09:56:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Mon Jul 15 10:06:17 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 15 Jul 2019 10:06:17 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2c502463c62_34405a05f02225c4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 109s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 109s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 109s] dh_installdocs [ 109s] dh_installchangelogs [ 109s] dh_python2 [ 109s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 109s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 109s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 109s] dh_python3 [ 109s] debian/rules override_dh_installinit [ 109s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 109s] # Install service file with different name than package name: [ 109s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 109s] dh_installinit --name=osmo-ctrl2cgi [ 110s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script not found [ 110s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 110s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 110s] make: *** [debian/rules:4: binary] Error 2 [ 110s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 110s] [ 110s] lamb59 failed "build osmo-python-tests_0.0.9.20190715.dsc" at Mon Jul 15 10:06:01 UTC 2019. [ 110s] [ 110s] ### VM INTERACTION START ### [ 113s] [ 97.833429] sysrq: SysRq : Power Off [ 113s] [ 97.838960] reboot: Power down [ 113s] ### VM INTERACTION END ### [ 113s] [ 113s] lamb59 failed "build osmo-python-tests_0.0.9.20190715.dsc" at Mon Jul 15 10:06:05 UTC 2019. [ 113s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Jul 15 11:40:07 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Jul 2019 11:40:07 +0000 Subject: Change in ...osmo-hlr[master]: VTY: add subscriber update network-access-mode In-Reply-To: References: Message-ID: Hello Vadim Yanitskiy, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/14778 to look at the new patch set (#3). Change subject: VTY: add subscriber update network-access-mode ...................................................................... VTY: add subscriber update network-access-mode Allow updating the NAM (Network Access Mode) of subscribers with the VTY. This is important for the subscriber create on demand use case where subscribers get created without access to PS and CS NAM by default. Regenerate hlr_vty_reference.xml. Related: OS#2542 Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b --- M doc/manuals/vty/hlr_vty_reference.xml M src/hlr_vty_subscr.c M tests/test_subscriber.vty 3 files changed, 82 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/78/14778/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b Gerrit-Change-Number: 14778 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 11:40:07 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Jul 2019 11:40:07 +0000 Subject: Change in ...osmo-hlr[master]: manuals: improve subscribers create on demand In-Reply-To: References: Message-ID: Hello Vadim Yanitskiy, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/14777 to look at the new patch set (#4). Change subject: manuals: improve subscribers create on demand ...................................................................... manuals: improve subscribers create on demand Write all VTY commands in monospace and add configuration example blocks. Add an example VTY session for enabling CS and PS NAM. Realted: OS#2542 Change-Id: I54f80810db3dac7a4a56ad42c5d2154b6006108c --- M doc/manuals/chapters/subscribers.adoc 1 file changed, 44 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/77/14777/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I54f80810db3dac7a4a56ad42c5d2154b6006108c Gerrit-Change-Number: 14777 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 11:41:12 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Jul 2019 11:41:12 +0000 Subject: Change in ...osmo-hlr[master]: VTY: add subscriber update network-access-mode In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14778 ) Change subject: VTY: add subscriber update network-access-mode ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14778/2/src/hlr_vty_subscr.c File src/hlr_vty_subscr.c: https://gerrit.osmocom.org/#/c/14778/2/src/hlr_vty_subscr.c at 582 PS2, Line 582: nam > one might expand this to network-access-mode which maybe more people understand than 'nam', which I [?] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b Gerrit-Change-Number: 14778 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 15 Jul 2019 11:41:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 11:51:17 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Jul 2019 11:51:17 +0000 Subject: Change in ...osmo-hlr[master]: VTY: add subscriber update network-access-mode In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14778 ) Change subject: VTY: add subscriber update network-access-mode ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14778/3/doc/manuals/vty/hlr_vty_reference.xml File doc/manuals/vty/hlr_vty_reference.xml: https://gerrit.osmocom.org/#/c/14778/3/doc/manuals/vty/hlr_vty_reference.xml at 825 PS3, Line 825: NAM I would also avoid using this abbreviation here. How about "Allow access to circuit switched services only", "Allow access to packet switched services only", "Allow access to both circuit and packet switched services"? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b Gerrit-Change-Number: 14778 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 15 Jul 2019 11:51:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 12:15:01 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Jul 2019 12:15:01 +0000 Subject: Change in ...osmo-hlr[master]: VTY: add subscriber update network-access-mode In-Reply-To: References: Message-ID: Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/14778 to look at the new patch set (#4). Change subject: VTY: add subscriber update network-access-mode ...................................................................... VTY: add subscriber update network-access-mode Allow updating the NAM (Network Access Mode) of subscribers with the VTY. This is important for the subscriber create on demand use case where subscribers get created without access to PS and CS NAM by default. Regenerate hlr_vty_reference.xml. Related: OS#2542 Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b --- M doc/manuals/vty/hlr_vty_reference.xml M src/hlr_vty_subscr.c M tests/test_subscriber.vty 3 files changed, 82 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/78/14778/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b Gerrit-Change-Number: 14778 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 12:15:55 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Jul 2019 12:15:55 +0000 Subject: Change in ...osmo-hlr[master]: VTY: add subscriber update network-access-mode In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14778 ) Change subject: VTY: add subscriber update network-access-mode ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/14778/3/doc/manuals/vty/hlr_vty_reference.xml File doc/manuals/vty/hlr_vty_reference.xml: https://gerrit.osmocom.org/#/c/14778/3/doc/manuals/vty/hlr_vty_reference.xml at 825 PS3, Line 825: NAM > I would also avoid using this abbreviation here. [?] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b Gerrit-Change-Number: 14778 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 15 Jul 2019 12:15:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 12:33:27 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Jul 2019 12:33:27 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add docker container Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14779 Change subject: debian-repo-install-test: add docker container ...................................................................... debian-repo-install-test: add docker container Add own container with systemd, so we can (in a follow-up commit) run the Osmocom systemd services in this test job. Rewrite the "interactive shell" logic to support the new systemd docker container, and enable it with an INTERACTIVE environment variable instead of hardcoding 'interactive="true"' in the script. While at it, move the Repository.key install to the Dockerfile so it works more like the other docker containers we have. Related: OS#3369 Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 --- A debian-repo-install-test/Dockerfile A debian-repo-install-test/Makefile R debian-repo-install-test/Release.key M debian-repo-install-test/jenkins.sh M debian-repo-install-test/testdata/repo-install-test.sh 5 files changed, 43 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/79/14779/1 diff --git a/debian-repo-install-test/Dockerfile b/debian-repo-install-test/Dockerfile new file mode 100644 index 0000000..5448fd6 --- /dev/null +++ b/debian-repo-install-test/Dockerfile @@ -0,0 +1,12 @@ +ARG USER +FROM debian:stretch + +COPY Release.key /tmp/Release.key + +RUN apt-get update && \ + apt-get install -y --no-install-recommends \ + aptitude \ + gnupg \ + systemd && \ + apt-key add /tmp/Release.key && \ + rm /tmp/Release.key diff --git a/debian-repo-install-test/Makefile b/debian-repo-install-test/Makefile new file mode 100644 index 0000000..8d0e10b --- /dev/null +++ b/debian-repo-install-test/Makefile @@ -0,0 +1 @@ +include ../make/Makefile diff --git a/debian-repo-install-test/testdata/Release.key b/debian-repo-install-test/Release.key similarity index 100% rename from debian-repo-install-test/testdata/Release.key rename to debian-repo-install-test/Release.key diff --git a/debian-repo-install-test/jenkins.sh b/debian-repo-install-test/jenkins.sh index 9dd4565..865ba22 100755 --- a/debian-repo-install-test/jenkins.sh +++ b/debian-repo-install-test/jenkins.sh @@ -1,18 +1,41 @@ #!/bin/sh . ../jenkins-common.sh +docker_images_require "debian-repo-install-test" -# Configuration [ -z "$FEED" ] && FEED="nightly" -interactive="false" # Run the container -extra_args="" -[ "$interactive" = "true" ] && extra_args="-it" +# Note that this does not output anything. For debugging, add -it and remove &. docker run --rm \ -v "$PWD/testdata:/testdata:ro" \ -v "$VOL_BASE_DIR:/data" \ --name "${BUILD_TAG}" \ -e FEED="$FEED" \ - $extra_args \ - debian:stretch \ - "/testdata/repo-install-test.sh" + -e container=docker \ + --tmpfs /run \ + --tmpfs /tmp \ + -v /sys/fs/cgroup:/sys/fs/cgroup:ro \ + --cap-add SYS_ADMIN \ + "$REPO_USER/debian-stretch-systemd" \ + /lib/systemd/systemd & +sleep 1 + +# Check if systemd is running +if ! docker exec "$BUILD_TAG" systemctl status; then + echo "ERROR: systemd is not running properly." + docker container kill "$BUILD_TAG" + exit 1 +fi + +# Run the test script +docker exec "$BUILD_TAG" /testdata/repo-install-test.sh +ret="$?" + +# Interactive shell +if [ -n "$INTERACTIVE" ]; then + docker exec -it "$BUILD_TAG" bash +fi + +docker container kill "$BUILD_TAG" + +exit $ret diff --git a/debian-repo-install-test/testdata/repo-install-test.sh b/debian-repo-install-test/testdata/repo-install-test.sh index f45908b..38a982f 100755 --- a/debian-repo-install-test/testdata/repo-install-test.sh +++ b/debian-repo-install-test/testdata/repo-install-test.sh @@ -12,15 +12,8 @@ fi } -install_depends() { - echo "Installing dependencies" - apt-get update - apt-get install -y gnupg aptitude -} - configure_osmocom_repo() { echo "Configuring Osmocom repository" - apt-key add /testdata/Release.key echo "deb $HTTP ./" \ > /etc/apt/sources.list.d/osmocom-latest.list apt-get update @@ -87,21 +80,7 @@ osmo-trx-usrp1 } -finish() { - echo "Test finished successfully!" - - # When docker-run is called with "-it", then stdin and a tty are available. - # The container will still exit when the entrypoint script (this file) is - # through, so in order to be able to type in commands, we execute a bash shell. - if [ -t 0 ]; then - echo "Dropping to interactive shell" - bash - fi -} - check_env -install_depends configure_osmocom_repo install_repo_packages test_binaries -finish -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 Gerrit-Change-Number: 14779 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 12:33:28 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Jul 2019 12:33:28 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: kill already running Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14780 Change subject: debian-repo-install-test: kill already running ...................................................................... debian-repo-install-test: kill already running The container grows heavily in size as the test runs, so make sure to always kill existing ones (from stopped jobs) before starting a new one. In order to do that, do not use $BUILD_TAG as container name, which changes with every new jenkins run. Hardcode "repo-install-test" instead. Related: OS#3369 Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f --- M debian-repo-install-test/jenkins.sh 1 file changed, 12 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/80/14780/1 diff --git a/debian-repo-install-test/jenkins.sh b/debian-repo-install-test/jenkins.sh index 865ba22..909aa1f 100755 --- a/debian-repo-install-test/jenkins.sh +++ b/debian-repo-install-test/jenkins.sh @@ -3,13 +3,19 @@ docker_images_require "debian-repo-install-test" [ -z "$FEED" ] && FEED="nightly" +CONTAINER="repo-install-test" + +# Kill already running container +if [ "$(docker inspect -f '{{.State.Running}}' "$CONTAINER" 2> /dev/null)" = "true" ]; then + docker container kill "$CONTAINER" +fi # Run the container # Note that this does not output anything. For debugging, add -it and remove &. docker run --rm \ -v "$PWD/testdata:/testdata:ro" \ -v "$VOL_BASE_DIR:/data" \ - --name "${BUILD_TAG}" \ + --name "$CONTAINER" \ -e FEED="$FEED" \ -e container=docker \ --tmpfs /run \ @@ -21,21 +27,21 @@ sleep 1 # Check if systemd is running -if ! docker exec "$BUILD_TAG" systemctl status; then +if ! docker exec "$CONTAINER" systemctl status; then echo "ERROR: systemd is not running properly." - docker container kill "$BUILD_TAG" + docker container kill "$CONTAINER" exit 1 fi # Run the test script -docker exec "$BUILD_TAG" /testdata/repo-install-test.sh +docker exec "$CONTAINER" /testdata/repo-install-test.sh ret="$?" # Interactive shell if [ -n "$INTERACTIVE" ]; then - docker exec -it "$BUILD_TAG" bash + docker exec -it "$CONTAINER" bash fi -docker container kill "$BUILD_TAG" +docker container kill "$CONTAINER" exit $ret -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f Gerrit-Change-Number: 14780 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 12:33:28 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Jul 2019 12:33:28 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: run systemd services Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14781 Change subject: debian-repo-install-test: run systemd services ...................................................................... debian-repo-install-test: run systemd services Run systemd services of Osmocom programs, to check if any are not starting properly. Use a whitelist to determine which services must start up, because some are currently broken. Modify the docker run command to support changing the CPU scheduling policy/priority in systemd service files (used by osmo-bts). Related: OS#3369 Change-Id: Ie6385f85560fefa7e7c9dca72cb5e2e914d4507a --- M debian-repo-install-test/jenkins.sh M debian-repo-install-test/testdata/repo-install-test.sh 2 files changed, 58 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/81/14781/1 diff --git a/debian-repo-install-test/jenkins.sh b/debian-repo-install-test/jenkins.sh index 909aa1f..647d66b 100755 --- a/debian-repo-install-test/jenkins.sh +++ b/debian-repo-install-test/jenkins.sh @@ -11,7 +11,9 @@ fi # Run the container -# Note that this does not output anything. For debugging, add -it and remove &. +# * This does not output anything, for debugging add -it and remove &. +# * /run, /tmp, cgroups, SYS_ADMIN: needed for systemd +# * SYS_NICE: needed for changing CPUScheduling{Policy,Priority} (osmo-bts systemd service files) docker run --rm \ -v "$PWD/testdata:/testdata:ro" \ -v "$VOL_BASE_DIR:/data" \ @@ -22,6 +24,7 @@ --tmpfs /tmp \ -v /sys/fs/cgroup:/sys/fs/cgroup:ro \ --cap-add SYS_ADMIN \ + --cap-add SYS_NICE \ "$REPO_USER/debian-stretch-systemd" \ /lib/systemd/systemd & sleep 1 diff --git a/debian-repo-install-test/testdata/repo-install-test.sh b/debian-repo-install-test/testdata/repo-install-test.sh index 38a982f..bbd2352 100755 --- a/debian-repo-install-test/testdata/repo-install-test.sh +++ b/debian-repo-install-test/testdata/repo-install-test.sh @@ -1,5 +1,29 @@ #!/bin/sh -ex +# Systemd services that must start up successfully after installing all packages (OS#3369) +# Disabled services: +# * osmo-ctrl2cgi (missing config: /etc/osmocom/ctrl2cgi.ini) +# * osmo-trap2cgi (missing config: /etc/osmocom/%N.ini) +# * osmo-sgsn (port 2123 already used by osmo-ggsn) +# * osmo-pcu (expects missing /tmp/pcu_bts socket) +# * osmo-hnbgw (tries to listen on 10.23.24.1) +# * osmo-bts-virtual (unit_id is not matching osmo-bsc's config) +SERVICES=" + osmo-bsc + osmo-gbproxy + osmo-ggsn + osmo-gtphub + osmo-hlr + osmo-mgw + osmo-msc + osmo-pcap-server + osmo-pcap-client + osmo-sip-connector + osmo-stp +" +# Services working in nightly, but not yet in latest +SERVICES_NIGHTLY="" + HTTP="http://download.opensuse.org/repositories/network:/osmocom:/$FEED/Debian_9.0/" OBS="obs://build.opensuse.org/network:osmocom:$FEED/Debian_9.0" @@ -80,7 +104,37 @@ osmo-trx-usrp1 } +services_check() { + local service + local services_feed="$SERVICES" + local failed="" + + if [ "$FEED" = "nightly" ]; then + services_feed="$services_feed $SERVICES_NIGHTLY" + fi + + systemctl start $services_feed + sleep 2 + + for service in $services_feed; do + if ! systemctl --no-pager -l status $service; then + failed="$failed $service" + fi + done + + systemctl stop $services_feed + + if [ -n "$failed" ]; then + set +x + echo + echo "ERROR: services failed to start: $failed" + echo + exit 1 + fi +} + check_env configure_osmocom_repo install_repo_packages test_binaries +services_check -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie6385f85560fefa7e7c9dca72cb5e2e914d4507a Gerrit-Change-Number: 14781 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 12:45:36 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 15 Jul 2019 12:45:36 +0000 Subject: Change in ...osmo-iuh[master]: osmo-hnbgw.cfg: set local-ip to 127.0.0.1 Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14782 Change subject: osmo-hnbgw.cfg: set local-ip to 127.0.0.1 ...................................................................... osmo-hnbgw.cfg: set local-ip to 127.0.0.1 Make the config work out of the box for anyone. Related: OS#3369 Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec --- M doc/examples/osmo-hnbgw.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/82/14782/1 diff --git a/doc/examples/osmo-hnbgw.cfg b/doc/examples/osmo-hnbgw.cfg index cba7f51..5a7b52d 100644 --- a/doc/examples/osmo-hnbgw.cfg +++ b/doc/examples/osmo-hnbgw.cfg @@ -21,5 +21,5 @@ logging level lstats notice hnbgw iuh - local-ip 10.23.24.1 + local-ip 127.0.0.1 hnbap-allow-tmsi 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec Gerrit-Change-Number: 14782 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 15:01:37 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Jul 2019 15:01:37 +0000 Subject: Change in ...osmo-iuh[master]: osmo-hnbgw.cfg: set local-ip to 127.0.0.1 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14782 ) Change subject: osmo-hnbgw.cfg: set local-ip to 127.0.0.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec Gerrit-Change-Number: 14782 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 15 Jul 2019 15:01:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 16:28:41 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Jul 2019 16:28:41 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support TRXD v1 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14657 ) Change subject: Transceiver: Support TRXD v1 ...................................................................... Patch Set 9: Verified-1 Code-Review-1 There are some issues observed with EDGE bursts. I will upload the fixes soon. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 15 Jul 2019 16:28:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Mon Jul 15 17:31:31 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 15 Jul 2019 17:31:31 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2cb880be924_3c0b3da5f471367@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 147s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 147s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 147s] dh_installdocs [ 147s] dh_installchangelogs [ 148s] dh_python2 [ 148s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 148s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 148s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 148s] dh_python3 [ 148s] debian/rules override_dh_installinit [ 148s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 148s] # Install service file with different name than package name: [ 148s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 148s] dh_installinit --name=osmo-ctrl2cgi [ 148s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script not found [ 148s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 148s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 148s] make: *** [debian/rules:4: binary] Error 2 [ 148s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 148s] [ 148s] lamb55 failed "build osmo-python-tests_0.0.9.20190715.dsc" at Mon Jul 15 17:31:23 UTC 2019. [ 148s] [ 148s] ### VM INTERACTION START ### [ 151s] [ 136.290105] sysrq: SysRq : Power Off [ 151s] [ 136.296829] reboot: Power down [ 151s] ### VM INTERACTION END ### [ 151s] [ 151s] lamb55 failed "build osmo-python-tests_0.0.9.20190715.dsc" at Mon Jul 15 17:31:27 UTC 2019. [ 151s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 15 17:40:57 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 15 Jul 2019 17:40:57 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2cbac68ea13_3c0b3da5f471970@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_Unstable/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 183s] +++ /usr/src/packages/BUILD/tests/testsuite.dir/at-groups/1/stderr 2019-07-15 17:40:37.908838355 +0000 [ 183s] @@ -20,9 +20,11 @@ [ 183s] autoreconnecting test step 3 [client OK, server OK], FD reg 1 [ 183s] [ 183s] autoreconnecting test step 2 [client OK, server OK], FD reg 0 [ 183s] + [ 183s] +autoreconnecting test step 1 [client OK, server OK], FD reg 0 [ 183s] connection closed with srv [ 183s] [ 183s] -autoreconnecting test step 1 [client OK, server NA], FD reg 0 [ 183s] +autoreconnecting test step 0 [client OK, server NA], FD reg 0 [ 183s] [ 183s] non-reconnecting test step 7 [client NA, server OK], FD reg 1 [ 183s] [ 183s] 1. testsuite.at:4: 1. stream_test (testsuite.at:4): FAILED (testsuite.at:8) [ 183s] make[1]: *** [debian/rules:27: override_dh_auto_test] Error 1 [ 183s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 183s] make: *** [debian/rules:13: build] Error 2 [ 183s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 183s] [ 183s] cloud108 failed "build libosmo-netif_0.5.0.2.6563.dsc" at Mon Jul 15 17:40:39 UTC 2019. [ 183s] [ 183s] ### VM INTERACTION START ### [ 186s] [ 155.493827] sysrq: SysRq : Power Off [ 186s] [ 155.502975] reboot: Power down [ 187s] ### VM INTERACTION END ### [ 187s] [ 187s] cloud108 failed "build libosmo-netif_0.5.0.2.6563.dsc" at Mon Jul 15 17:40:44 UTC 2019. [ 187s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Jul 15 18:09:17 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Jul 2019 18:09:17 +0000 Subject: Change in ...osmo-trx[master]: fixup: trxd_hdr_v1_specific: fix MTS encoding Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14783 Change subject: fixup: trxd_hdr_v1_specific: fix MTS encoding ...................................................................... fixup: trxd_hdr_v1_specific: fix MTS encoding Somehow having the union causes overflows between the bit-fields of the MTS (Modulation and Training Sequence). I could not figure out why and how is that possible. gdb-peda$ p *v1 $0 = { mts = 0x0, tsc = 0x0, modulation = 0x0, idle = 0x0, ci = 0x0 } gdb-peda$ set v1->tsc = 7 gdb-peda$ p *v1 $0 = { mts = 0x7, tsc = 0x7, modulation = 0x7, // WTF?!? idle = 0x0, ci = 0x0 } Getting rid of that union fixes the problem. Change-Id: I9c0b7eef1464524e93fe0945acbdbf3d557c5664 --- M Transceiver52M/proto_trxd.h 1 file changed, 6 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/83/14783/1 diff --git a/Transceiver52M/proto_trxd.h b/Transceiver52M/proto_trxd.h index a047be4..7eb5dac 100644 --- a/Transceiver52M/proto_trxd.h +++ b/Transceiver52M/proto_trxd.h @@ -74,18 +74,15 @@ #define TRXD_MODULATION_32QAM(ts_set) (0b1010 | (ts_set & 0b0001)) struct trxd_hdr_v1_specific { - union { - uint8_t mts; #if OSMO_IS_LITTLE_ENDIAN - uint8_t tsc:3, - modulation:4, - idle:1; + uint8_t tsc:3, + modulation:4, + idle:1; #elif OSMO_IS_BIG_ENDIAN - uint8_t idle:1, - modulation:4, - tsc:3; + uint8_t idle:1, + modulation:4, + tsc:3; #endif - }; int16_t ci; /* big endian, in centiBels */ } __attribute__ ((packed)); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9c0b7eef1464524e93fe0945acbdbf3d557c5664 Gerrit-Change-Number: 14783 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 18:09:17 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Jul 2019 18:09:17 +0000 Subject: Change in ...osmo-trx[master]: fixup: pullRadioVector(): properly set modulation type Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14784 Change subject: fixup: pullRadioVector(): properly set modulation type ...................................................................... fixup: pullRadioVector(): properly set modulation type Change-Id: Ie576762b8074047dc77bddc32d16fc8ad7ed9c5d --- M Transceiver52M/Transceiver.cpp 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/84/14784/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 57a602c..b73e698 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -618,7 +618,7 @@ bi->toa = 0.0; bi->noise = 0.0; bi->idle = false; - bi->modulation = (type == EDGE) ? MODULATION_8PSK : MODULATION_GMSK; + bi->modulation = MODULATION_GMSK; bi->tss = 0; /* TODO: we only support tss 0 right now */ bi->tsc = 0; bi->ci = 0.0; @@ -674,10 +674,13 @@ rxBurst = demodAnyBurst(*burst, mSPSRx, ebp.amp, ebp.toa, type); /* EDGE demodulator returns 444 (gSlotLen * 3) bits */ - if (rxBurst->size() == EDGE_BURST_NBITS) + if (rxBurst->size() == EDGE_BURST_NBITS) { + bi->modulation = MODULATION_8PSK; bi->nbits = EDGE_BURST_NBITS; - else /* size() here is actually gSlotLen + 8, due to guard periods */ + } else { /* size() here is actually gSlotLen + 8, due to guard periods */ + bi->modulation = MODULATION_GMSK; bi->nbits = gSlotLen; + } // Convert -1..+1 soft bits to 0..1 soft bits vectorSlicer(bi->rx_burst, rxBurst->begin(), bi->nbits); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie576762b8074047dc77bddc32d16fc8ad7ed9c5d Gerrit-Change-Number: 14784 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 18:09:17 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Jul 2019 18:09:17 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14785 Change subject: driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN ...................................................................... driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN Change-Id: I8396004616754f84fb465c972fde9e91b18cc49b --- M Transceiver52M/Transceiver.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/85/14785/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index b73e698..1e0339b 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -935,7 +935,7 @@ } int timeSlot = (int) buffer[0]; - uint64_t frameNum = 0; + uint32_t frameNum = 0; for (int i = 0; i < 4; i++) frameNum = (frameNum << 8) | (0x0ff & buffer[i+1]); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8396004616754f84fb465c972fde9e91b18cc49b Gerrit-Change-Number: 14785 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 18:09:17 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Jul 2019 18:09:17 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): use trxd_hdr_common for message parsing Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14786 Change subject: driveTxPriorityQueue(): use trxd_hdr_common for message parsing ...................................................................... driveTxPriorityQueue(): use trxd_hdr_common for message parsing Change-Id: If6a93e2b7fc9ada55edbdd16352cd4f7040e3d2a --- M Transceiver52M/Transceiver.cpp 1 file changed, 8 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/86/14786/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 1e0339b..4cd8637 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -914,6 +914,7 @@ int msgLen; int burstLen; char buffer[EDGE_BURST_NBITS + 50]; + struct trxd_hdr_common *chdr; // check data socket msgLen = read(mDataSockets[chan], buffer, sizeof(buffer)); @@ -934,12 +935,13 @@ return false; } - int timeSlot = (int) buffer[0]; - uint32_t frameNum = 0; - for (int i = 0; i < 4; i++) - frameNum = (frameNum << 8) | (0x0ff & buffer[i+1]); + /* Common header part: HDR version, TDMA TN & FN */ + chdr = (struct trxd_hdr_common *) buffer; - LOG(DEBUG) << "rcvd. burst at: " << GSM::Time(frameNum,timeSlot); + /* Convert TDMA FN to the host endianness */ + chdr->fn = ntohl(chdr->fn); + + LOG(DEBUG) << "rcvd. burst at: " << GSM::Time(chdr->fn, chdr->tn); int RSSI = (int) buffer[5]; BitVector newBurst(burstLen); @@ -948,7 +950,7 @@ while (itr < newBurst.end()) *itr++ = *bufferItr++; - GSM::Time currTime = GSM::Time(frameNum,timeSlot); + GSM::Time currTime = GSM::Time(chdr->fn, chdr->tn); addRadioVector(chan, newBurst, RSSI, currTime); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If6a93e2b7fc9ada55edbdd16352cd4f7040e3d2a Gerrit-Change-Number: 14786 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 18:09:18 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Jul 2019 18:09:18 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): check if message header format is supported Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14787 Change subject: driveTxPriorityQueue(): check if message header format is supported ...................................................................... driveTxPriorityQueue(): check if message header format is supported Change-Id: I17abf95f5e23236abccc50476cd59931580f5cd3 --- M Transceiver52M/Transceiver.cpp 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/87/14787/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 4cd8637..eae8d53 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -941,6 +941,18 @@ /* Convert TDMA FN to the host endianness */ chdr->fn = ntohl(chdr->fn); + /* Make sure we support the received header format */ + switch (chdr->version) { + case 0: + /* Version 1 has the same format */ + case 1: + break; + + default: + LOG(ERR) << "Rx TRXD message with unknown header version " << chdr->version; + return false; + } + LOG(DEBUG) << "rcvd. burst at: " << GSM::Time(chdr->fn, chdr->tn); int RSSI = (int) buffer[5]; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I17abf95f5e23236abccc50476cd59931580f5cd3 Gerrit-Change-Number: 14787 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 15 18:09:18 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Jul 2019 18:09:18 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): enrich logging message Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14788 Change subject: driveTxPriorityQueue(): enrich logging message ...................................................................... driveTxPriorityQueue(): enrich logging message Change-Id: If25c2171f7d1ab98d65f0dbf93d0d8a5a635caf7 --- M Transceiver52M/Transceiver.cpp 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/88/14788/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index eae8d53..9182fec 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -953,7 +953,9 @@ return false; } - LOG(DEBUG) << "rcvd. burst at: " << GSM::Time(chdr->fn, chdr->tn); + LOG(DEBUG) << "Rx TRXD message (hdr_ver=" << chdr->version << "): " + << "fn=" << chdr->fn << ", tn=" << chdr->tn << ", " + << "burst_len=" << burstLen; int RSSI = (int) buffer[5]; BitVector newBurst(burstLen); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If25c2171f7d1ab98d65f0dbf93d0d8a5a635caf7 Gerrit-Change-Number: 14788 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Mon Jul 15 18:23:47 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 15 Jul 2019 18:23:47 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2cc4bceac92_3c0b3da5f4748d6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 4s] [18/73] preinstalling libdb5.3... [ 4s] [19/73] preinstalling libdebconfclient0... [ 4s] [20/73] preinstalling liblzma5... [ 4s] [21/73] preinstalling libncurses5... [ 4s] [22/73] preinstalling libpcre2-8-0... [ 4s] [23/73] preinstalling libpcre3... [ 4s] [24/73] preinstalling libsepol1... [ 4s] [25/73] preinstalling libsigsegv2... [ 5s] [26/73] preinstalling libslang2... [ 5s] [27/73] preinstalling libsmartcols1... [ 5s] [28/73] preinstalling libtinfo6... [ 5s] [29/73] preinstalling libustr-1.0-1... [ 5s] [30/73] preinstalling libuuid1... [ 5s] [31/73] preinstalling multiarch-support... [ 5s] [32/73] preinstalling zlib1g... [ 5s] [33/73] preinstalling base-passwd... [ 5s] [34/73] preinstalling libacl1... [ 5s] [35/73] preinstalling libblkid1... [ 6s] [36/73] preinstalling libselinux1... [ 6s] [37/73] preinstalling libss2... [ 6s] [38/73] preinstalling ncurses-bin... [ 6s] [39/73] preinstalling xz-utils... [ 6s] [40/73] preinstalling libperl5.28... [ 6s] [41/73] preinstalling findutils... [ 7s] [42/73] preinstalling libmount1... [ 7s] [43/73] preinstalling sed... [ 7s] [44/73] preinstalling tar... [ 7s] [45/73] preinstalling coreutils... [ 7s] [46/73] preinstalling e2fsprogs... -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Jul 15 19:27:29 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 15 Jul 2019 19:27:29 +0000 Subject: Change in ...osmo-trx[master]: fixup: trxd_hdr_v1_specific: fix MTS encoding In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14783 ) Change subject: fixup: trxd_hdr_v1_specific: fix MTS encoding ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14783/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14783/1//COMMIT_MSG at 9 PS1, Line 9: Somehow I found a Russian article with a brief explanation of the problem: https://www.stableit.ru/2016/02/union-bit-fields-c.html. As it turns out, all bit-fields of the union share the same chunk of memory with the same offset. Changing one of them would change the other ones... -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9c0b7eef1464524e93fe0945acbdbf3d557c5664 Gerrit-Change-Number: 14783 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Mon, 15 Jul 2019 19:27:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Mon Jul 15 22:16:52 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 15 Jul 2019 22:16:52 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2cfb5fc07c2_3c0b3da5f41038c1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 87s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 87s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 87s] dh_installdocs [ 87s] dh_installchangelogs [ 87s] dh_python2 [ 87s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 87s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 87s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 88s] dh_python3 [ 88s] debian/rules override_dh_installinit [ 88s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 88s] # Install service file with different name than package name: [ 88s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 88s] dh_installinit --name=osmo-ctrl2cgi [ 88s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script not found [ 88s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 88s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 88s] make: *** [debian/rules:4: binary] Error 2 [ 88s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 88s] [ 88s] sheep81 failed "build osmo-python-tests_0.0.9.20190715.dsc" at Mon Jul 15 22:16:45 UTC 2019. [ 88s] [ 88s] ### VM INTERACTION START ### [ 91s] [ 80.513730] sysrq: SysRq : Power Off [ 91s] [ 80.518794] reboot: Power down [ 91s] ### VM INTERACTION END ### [ 91s] [ 91s] sheep81 failed "build osmo-python-tests_0.0.9.20190715.dsc" at Mon Jul 15 22:16:48 UTC 2019. [ 91s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 16 02:36:53 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 16 Jul 2019 02:36:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2d385175f8c_3c0b3da5f413214a@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 104s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 104s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 104s] dh_installdocs [ 104s] dh_installchangelogs [ 104s] dh_python2 [ 104s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 104s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 104s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 104s] dh_python3 [ 104s] debian/rules override_dh_installinit [ 104s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 104s] # Install service file with different name than package name: [ 104s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 104s] dh_installinit --name=osmo-ctrl2cgi [ 104s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script not found [ 104s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 104s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 104s] make: *** [debian/rules:4: binary] Error 2 [ 104s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 104s] [ 104s] lamb62 failed "build osmo-python-tests_0.0.9.20190716.dsc" at Tue Jul 16 02:36:33 UTC 2019. [ 104s] [ 104s] ### VM INTERACTION START ### [ 108s] [ 94.190886] sysrq: SysRq : Power Off [ 108s] [ 94.199119] reboot: Power down [ 108s] ### VM INTERACTION END ### [ 108s] [ 108s] lamb62 failed "build osmo-python-tests_0.0.9.20190716.dsc" at Tue Jul 16 02:36:37 UTC 2019. [ 108s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 16 02:43:27 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 16 Jul 2019 02:43:27 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in xUbuntu_18.04/x86_64 In-Reply-To: References: Message-ID: <5d2d39d481410_3c0b3da5f4140658@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/xUbuntu_18.04/x86_64 Package network:osmocom:nightly/libosmo-netif failed to build in xUbuntu_18.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 140s] | #define HAVE_DLFCN_H 1 [ 140s] | #define LT_OBJDIR ".libs/" [ 140s] | #define STDC_HEADERS 1 [ 140s] | #define HAVE_EXECINFO_H 1 [ 140s] | #define HAVE_SYS_SELECT_H 1 [ 140s] | #define HAVE_SYS_SOCKET_H 1 [ 140s] | #define HAVE_SYSLOG_H 1 [ 140s] | #define HAVE_CTYPE_H 1 [ 140s] | #define HAVE_LIBSCTP 1 [ 140s] | #define HAVE_PCAP_H 1 [ 140s] | [ 140s] | configure: exit 0 [ 140s] [ 140s] debian/rules:27: recipe for target 'override_dh_auto_test' failed [ 140s] make[1]: *** [override_dh_auto_test] Error 1 [ 140s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 140s] debian/rules:13: recipe for target 'build' failed [ 140s] make: *** [build] Error 2 [ 140s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 140s] [ 140s] lamb62 failed "build libosmo-netif_0.5.0.2.6563.dsc" at Tue Jul 16 02:43:14 UTC 2019. [ 140s] [ 140s] ### VM INTERACTION START ### [ 143s] [ 130.184931] sysrq: SysRq : Power Off [ 143s] [ 130.192826] reboot: Power down [ 143s] ### VM INTERACTION END ### [ 143s] [ 143s] lamb62 failed "build libosmo-netif_0.5.0.2.6563.dsc" at Tue Jul 16 02:43:18 UTC 2019. [ 143s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 16 03:01:32 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 16 Jul 2019 03:01:32 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2d3e0e1dacd_3c0b3da5f41411dd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 905s] -Returned: 0, Current node: 1 '%s> ' [ 905s] -Going to execute 'ambiguous_str' [ 905s] -Called: 'ambiguous_str [ARG]' (argc=0) [ 905s] -Returned: 0, Current node: 1 '%s> ' [ 905s] -Going to execute 'ambiguous_str arg' [ 905s] -Called: 'ambiguous_str [ARG]' (argc=1) [ 905s] -Returned: 0, Current node: 1 '%s> ' [ 905s] -Going to execute 'ambiguous_str arg keyword' [ 905s] -Called: 'ambiguous_str ARG keyword' [ 905s] -Returned: 0, Current node: 1 '%s> ' [ 905s] -All tests passed [ 905s] ./testsuite.at:196: exit code was 139, expected 0 [ 905s] 31. testsuite.at:192: 31. vty (testsuite.at:192): FAILED (testsuite.at:196) [ 905s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 905s] make[1]: *** [override_dh_auto_test] Error 1 [ 905s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 905s] debian/rules:15: recipe for target 'build' failed [ 905s] make: *** [build] Error 2 [ 905s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 905s] [ 905s] obs-arm-5 failed "build libosmocore_1.1.0.79.a3dec.dsc" at Tue Jul 16 03:01:11 UTC 2019. [ 905s] [ 905s] ### VM INTERACTION START ### [ 908s] [ 873.583552] sysrq: SysRq : Power Off [ 908s] [ 873.598045] reboot: Power down [ 909s] ### VM INTERACTION END ### [ 909s] [ 909s] obs-arm-5 failed "build libosmocore_1.1.0.79.a3dec.dsc" at Tue Jul 16 03:01:15 UTC 2019. [ 909s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Jul 16 03:43:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 03:43:22 +0000 Subject: Change in ...osmo-trx[master]: fixup: trxd_hdr_v1_specific: fix MTS encoding In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14783 ) Change subject: fixup: trxd_hdr_v1_specific: fix MTS encoding ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9c0b7eef1464524e93fe0945acbdbf3d557c5664 Gerrit-Change-Number: 14783 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 03:43:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 03:43:53 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 03:43:53 +0000 Subject: Change in ...osmo-trx[master]: fixup: pullRadioVector(): properly set modulation type In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14784 ) Change subject: fixup: pullRadioVector(): properly set modulation type ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie576762b8074047dc77bddc32d16fc8ad7ed9c5d Gerrit-Change-Number: 14784 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 03:43:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 03:44:11 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 03:44:11 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14785 ) Change subject: driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8396004616754f84fb465c972fde9e91b18cc49b Gerrit-Change-Number: 14785 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 03:44:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 03:46:06 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 03:46:06 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): use trxd_hdr_common for message parsing In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14786 ) Change subject: driveTxPriorityQueue(): use trxd_hdr_common for message parsing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If6a93e2b7fc9ada55edbdd16352cd4f7040e3d2a Gerrit-Change-Number: 14786 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 03:46:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 03:46:09 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 03:46:09 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14785 ) Change subject: driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8396004616754f84fb465c972fde9e91b18cc49b Gerrit-Change-Number: 14785 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 03:46:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 03:46:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 03:46:36 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): check if message header format is supported In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14787 ) Change subject: driveTxPriorityQueue(): check if message header format is supported ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I17abf95f5e23236abccc50476cd59931580f5cd3 Gerrit-Change-Number: 14787 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 03:46:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 03:47:24 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 03:47:24 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): enrich logging message In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14788 ) Change subject: driveTxPriorityQueue(): enrich logging message ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If25c2171f7d1ab98d65f0dbf93d0d8a5a635caf7 Gerrit-Change-Number: 14788 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 03:47:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Tue Jul 16 03:47:32 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 16 Jul 2019 03:47:32 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2d48d5a1c5e_3c0b3da5f4142816@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 106s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 106s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 106s] dh_installdocs [ 107s] dh_installchangelogs [ 107s] dh_python2 [ 107s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 107s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 107s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 107s] dh_python3 [ 107s] debian/rules override_dh_installinit [ 107s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 107s] # Install service file with different name than package name: [ 107s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 107s] dh_installinit --name=osmo-ctrl2cgi [ 107s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script not found [ 107s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 107s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 107s] make: *** [debian/rules:4: binary] Error 2 [ 107s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 107s] [ 107s] lamb71 failed "build osmo-python-tests_0.0.9.20190716.dsc" at Tue Jul 16 03:47:12 UTC 2019. [ 107s] [ 107s] ### VM INTERACTION START ### [ 110s] [ 96.222821] sysrq: SysRq : Power Off [ 110s] [ 96.231032] reboot: Power down [ 110s] ### VM INTERACTION END ### [ 110s] [ 110s] lamb71 failed "build osmo-python-tests_0.0.9.20190716.dsc" at Tue Jul 16 03:47:15 UTC 2019. [ 110s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Jul 16 03:47:54 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 03:47:54 +0000 Subject: Change in ...osmo-hlr[master]: VTY: add subscriber update network-access-mode In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14778 ) Change subject: VTY: add subscriber update network-access-mode ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b Gerrit-Change-Number: 14778 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Jul 2019 03:47:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 03:47:57 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 03:47:57 +0000 Subject: Change in ...osmo-hlr[master]: VTY: add subscriber update network-access-mode In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14778 ) Change subject: VTY: add subscriber update network-access-mode ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b Gerrit-Change-Number: 14778 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Jul 2019 03:47:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 03:48:24 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 03:48:24 +0000 Subject: Change in ...osmo-hlr[master]: manuals: improve subscribers create on demand In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14777 ) Change subject: manuals: improve subscribers create on demand ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I54f80810db3dac7a4a56ad42c5d2154b6006108c Gerrit-Change-Number: 14777 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Jul 2019 03:48:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:00:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:00:16 +0000 Subject: Change in ...osmo-bsc[master]: logging: introduce LOG_BTS and LOG_TRX and use it everywhere In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14439 ) Change subject: logging: introduce LOG_BTS and LOG_TRX and use it everywhere ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4a7814d164384eecfb6913c31802cf2faead6e6c Gerrit-Change-Number: 14439 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 04:00:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:00:19 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:00:19 +0000 Subject: Change in ...osmo-bsc[master]: logging: introduce LOG_BTS and LOG_TRX and use it everywhere In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14439 ) Change subject: logging: introduce LOG_BTS and LOG_TRX and use it everywhere ...................................................................... logging: introduce LOG_BTS and LOG_TRX and use it everywhere It's quite ugly to have manual "bts=%d" printf-statements all over the BSC code. Let's change this to use shared logging helper functions all over the place, whenever we need to log something related to one BTS or one TRX. This can also help us as the first step to later add alternative logging of BTS identities, e.g. by printing the Cell Global Identifier or LAC+CI, or even a human-readable/vty-defined 'name' of the BTS, rather than its numeric bts number. With this change in place, we can introduce such changes at a single location in the code. Change-Id: I4a7814d164384eecfb6913c31802cf2faead6e6c --- M include/osmocom/bsc/debug.h M src/osmo-bsc/abis_nm.c M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/acc_ramp.c M src/osmo-bsc/bts_ipaccess_nanobts.c M src/osmo-bsc/chan_alloc.c M src/osmo-bsc/e1_config.c M src/osmo-bsc/lchan_select.c M src/osmo-bsc/paging.c 9 files changed, 89 insertions(+), 105 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/bsc/debug.h b/include/osmocom/bsc/debug.h index e78ba59..3260121 100644 --- a/include/osmocom/bsc/debug.h +++ b/include/osmocom/bsc/debug.h @@ -29,3 +29,9 @@ DAS, Debug_LastEntry, }; + +#define LOG_BTS(bts, subsys, level, fmt, args...) \ + LOGP(subsys, level, "(bts=%d) " fmt, (bts)->nr, ## args) + +#define LOG_TRX(trx, subsys, level, fmt, args...) \ + LOGP(subsys, level, "(bts=%d,trx=%d) " fmt, (trx)->bts->nr, (trx)->nr, ## args) diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index bff6c12..7d059b5 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -1713,7 +1713,7 @@ return -EINVAL; } - DEBUGP(DNM, "Get Attr (bts=%u,trx=%u)\n", bts->nr, trx_nr); + LOG_BTS(bts, DNM, LOGL_DEBUG, "Get Attr (trx=%u)\n", trx_nr); msg = nm_msgb_alloc(); oh = (struct abis_om_hdr *) msgb_put(msg, ABIS_OM_FOM_HDR_SIZE); @@ -1731,7 +1731,7 @@ struct msgb *msg = nm_msgb_alloc(); uint8_t *cur; - DEBUGP(DNM, "Set BTS Attr (bts=%u)\n", bts->nr); + LOG_BTS(bts, DNM, LOGL_DEBUG, "Set BTS Attr\n"); oh = (struct abis_om_hdr *) msgb_put(msg, ABIS_OM_FOM_HDR_SIZE); fill_om_fom_hdr(oh, attr_len, NM_MT_SET_BTS_ATTR, NM_OC_BTS, bts->bts_nr, 0xff, 0xff); @@ -1748,7 +1748,7 @@ struct msgb *msg = nm_msgb_alloc(); uint8_t *cur; - DEBUGP(DNM, "Set TRX Attr (bts=%u,trx=%u)\n", trx->bts->nr, trx->nr); + LOG_TRX(trx, DNM, LOGL_DEBUG, "Set TRX Attr\n"); oh = (struct abis_om_hdr *) msgb_put(msg, ABIS_OM_FOM_HDR_SIZE); fill_om_fom_hdr(oh, attr_len, NM_MT_SET_RADIO_ATTR, NM_OC_RADIO_CARRIER, @@ -2849,7 +2849,7 @@ struct gsm_bts_trx *trx = data; struct ipacc_ack_signal_data signal; - LOGP(DRSL, LOGL_NOTICE, "(bts=%u,trx=%u) RSL connection request timed out\n", trx->bts->nr, trx->nr); + LOG_TRX(trx, DRSL, LOGL_NOTICE, "RSL connection request timed out\n"); /* Fake an RSL CONECT NACK message from the BTS. */ signal.trx = trx; @@ -2880,8 +2880,8 @@ if (ip == 0) attr_len -= 5; - LOGP(DNM, LOGL_INFO, "(bts=%u,trx=%u) IPA RSL CONNECT IP=%s PORT=%u STREAM=0x%02x\n", - trx->bts->nr, trx->nr, inet_ntoa(ia), port, stream); + LOG_TRX(trx, DNM, LOGL_INFO, "IPA RSL CONNECT IP=%s PORT=%u STREAM=0x%02x\n", + inet_ntoa(ia), port, stream); error = abis_nm_ipaccess_msg(trx->bts, NM_MT_IPACC_RSL_CONNECT, NM_OC_BASEB_TRANSC, trx->bts->bts_nr, @@ -2935,8 +2935,7 @@ return; } - LOGP(DNM, LOGL_NOTICE, "(bts=%u,trx=%u) Requesting administrative state change %s -> %s [%s]\n", - trx->bts->nr, trx->nr, + LOG_TRX(trx, DNM, LOGL_NOTICE, "Requesting administrative state change %s -> %s [%s]\n", get_value_string(abis_nm_adm_state_names, trx->mo.nm_state.administrative), get_value_string(abis_nm_adm_state_names, new_state), reason); diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 9db2115..0b68d7c 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1357,10 +1357,8 @@ /* Determine channel request cause code */ chreq_reason = get_reason_by_chreq(rqd_ref->ra, bts->network->neci); - LOGP(DRSL, LOGL_NOTICE, "(bts=%d) CHAN RQD: reason: %s (ra=0x%02x, neci=0x%02x, chreq_reason=0x%02x)\n", - msg->lchan->ts->trx->bts->nr, - get_value_string(gsm_chreq_descs, chreq_reason), - rqd_ref->ra, bts->network->neci, chreq_reason); + LOG_BTS(bts, DRSL, LOGL_NOTICE, "CHAN RQD: reason: %s (ra=0x%02x, neci=0x%02x, chreq_reason=0x%02x)\n", + get_value_string(gsm_chreq_descs, chreq_reason), rqd_ref->ra, bts->network->neci, chreq_reason); /* Handle PDCH related rach requests (in case of BSC-co-located-PCU */ if (chreq_reason == GSM_CHREQ_REASON_PDCH) @@ -1381,24 +1379,18 @@ */ lchan = lchan_select_by_type(bts, GSM_LCHAN_SDCCH); if (!lchan) { - LOGP(DRSL, LOGL_NOTICE, "(bts=%d) CHAN RQD: no resources for %s " - "0x%x, retrying with %s\n", - msg->lchan->ts->trx->bts->nr, - gsm_lchant_name(GSM_LCHAN_SDCCH), rqd_ref->ra, - gsm_lchant_name(GSM_LCHAN_TCH_H)); + LOG_BTS(bts, DRSL, LOGL_NOTICE, "CHAN RQD: no resources for %s 0x%x, retrying with %s\n", + gsm_lchant_name(GSM_LCHAN_SDCCH), rqd_ref->ra, gsm_lchant_name(GSM_LCHAN_TCH_H)); lchan = lchan_select_by_type(bts, GSM_LCHAN_TCH_H); } if (!lchan) { - LOGP(DRSL, LOGL_NOTICE, "(bts=%d) CHAN RQD: no resources for %s " - "0x%x, retrying with %s\n", - msg->lchan->ts->trx->bts->nr, - gsm_lchant_name(GSM_LCHAN_SDCCH), rqd_ref->ra, - gsm_lchant_name(GSM_LCHAN_TCH_F)); + LOG_BTS(bts, DRSL, LOGL_NOTICE, "CHAN RQD: no resources for %s 0x%x, retrying with %s\n", + gsm_lchant_name(GSM_LCHAN_SDCCH), rqd_ref->ra, gsm_lchant_name(GSM_LCHAN_TCH_F)); lchan = lchan_select_by_type(bts, GSM_LCHAN_TCH_F); } if (!lchan) { - LOGP(DRSL, LOGL_NOTICE, "(bts=%d) CHAN RQD: no resources for %s 0x%x\n", - msg->lchan->ts->trx->bts->nr, gsm_lchant_name(lctype), rqd_ref->ra); + LOG_BTS(bts, DRSL, LOGL_NOTICE, "CHAN RQD: no resources for %s 0x%x\n", + gsm_lchant_name(lctype), rqd_ref->ra); rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_CHREQ_NO_CHANNEL]); rsl_tx_imm_ass_rej(bts, rqd_ref); return 0; diff --git a/src/osmo-bsc/acc_ramp.c b/src/osmo-bsc/acc_ramp.c index bc2e3fb..b79c0c2 100644 --- a/src/osmo-bsc/acc_ramp.c +++ b/src/osmo-bsc/acc_ramp.c @@ -46,7 +46,8 @@ { OSMO_ASSERT(acc <= 9); if (acc_ramp->barred_accs & (1 << acc)) - LOGP(DRSL, LOGL_NOTICE, "(bts=%d) ACC RAMP: allowing Access Control Class %u\n", acc_ramp->bts->nr, acc); + LOG_BTS(acc_ramp->bts, DRSL, LOGL_NOTICE, + "ACC RAMP: allowing Access Control Class %u\n", acc); acc_ramp->barred_accs &= ~(1 << acc); } @@ -54,7 +55,8 @@ { OSMO_ASSERT(acc <= 9); if ((acc_ramp->barred_accs & (1 << acc)) == 0) - LOGP(DRSL, LOGL_NOTICE, "(bts=%d) ACC RAMP: barring Access Control Class %u\n", acc_ramp->bts->nr, acc); + LOG_BTS(acc_ramp->bts, DRSL, LOGL_NOTICE, + "ACC RAMP: barring Access Control Class %u\n", acc); acc_ramp->barred_accs |= (1 << acc); } @@ -92,8 +94,9 @@ else if (acc_ramp->step_interval_sec > ACC_RAMP_STEP_INTERVAL_MAX) acc_ramp->step_interval_sec = ACC_RAMP_STEP_INTERVAL_MAX; - LOGP(DRSL, LOGL_DEBUG, "(bts=%d) ACC RAMP: step interval set to %u seconds based on %u%% channel load average\n", - bts->nr, acc_ramp->step_interval_sec, bts->chan_load_avg); + LOG_BTS(bts, DRSL, LOGL_DEBUG, + "ACC RAMP: step interval set to %u seconds based on %u%% channel load average\n", + acc_ramp->step_interval_sec, bts->chan_load_avg); return acc_ramp->step_interval_sec; } @@ -156,12 +159,10 @@ trx = nsd->obj; - LOGP(DRSL, LOGL_DEBUG, "(bts=%d,trx=%d) ACC RAMP: administrative state %s -> %s\n", - acc_ramp->bts->nr, trx->nr, + LOG_TRX(trx, DRSL, LOGL_DEBUG, "ACC RAMP: administrative state %s -> %s\n", get_value_string(abis_nm_adm_state_names, nsd->old_state->administrative), get_value_string(abis_nm_adm_state_names, nsd->new_state->administrative)); - LOGP(DRSL, LOGL_DEBUG, "(bts=%d,trx=%d) ACC RAMP: operational state %s -> %s\n", - acc_ramp->bts->nr, trx->nr, + LOG_TRX(trx, DRSL, LOGL_DEBUG, "ACC RAMP: operational state %s -> %s\n", abis_nm_opstate_name(nsd->old_state->operational), abis_nm_opstate_name(nsd->new_state->operational)); @@ -171,8 +172,8 @@ /* RSL must already be up. We cannot send RACH system information to the BTS otherwise. */ if (trx->rsl_link == NULL) { - LOGP(DRSL, LOGL_DEBUG, "(bts=%d,trx=%d) ACC RAMP: ignoring state change because RSL link is down\n", - acc_ramp->bts->nr, trx->nr); + LOG_TRX(trx, DRSL, LOGL_DEBUG, + "ACC RAMP: ignoring state change because RSL link is down\n"); return 0; } @@ -188,10 +189,10 @@ if (nsd->new_state->operational == NM_OPSTATE_ENABLED) trigger_ramping = true; else - LOGP(DRSL, LOGL_DEBUG, "(bts=%d,trx=%d) ACC RAMP: ignoring state change " - "because TRX is transitioning into operational state '%s'\n", - acc_ramp->bts->nr, trx->nr, - abis_nm_opstate_name(nsd->new_state->operational)); + LOG_TRX(trx, DRSL, LOGL_DEBUG, + "ACC RAMP: ignoring state change because TRX is " + "transitioning into operational state '%s'\n", + abis_nm_opstate_name(nsd->new_state->operational)); } else { /* * Operational state has not changed. @@ -200,8 +201,8 @@ if (trx_is_usable(trx)) trigger_ramping = true; else - LOGP(DRSL, LOGL_DEBUG, "(bts=%d,trx=%d) ACC RAMP: ignoring state change " - "because TRX is not usable\n", acc_ramp->bts->nr, trx->nr); + LOG_TRX(trx, DRSL, LOGL_DEBUG, "ACC RAMP: ignoring state change " + "because TRX is not usable\n"); } break; case NM_STATE_LOCKED: @@ -210,8 +211,8 @@ break; case NM_STATE_NULL: default: - LOGP(DRSL, LOGL_ERROR, "(bts=%d) ACC RAMP: unrecognized administrative state '0x%x' " - "reported for TRX 0\n", acc_ramp->bts->nr, nsd->new_state->administrative); + LOG_TRX(trx, DRSL, LOGL_ERROR, "ACC RAMP: unrecognized administrative state '0x%x' " + "reported for TRX 0\n", nsd->new_state->administrative); break; } } @@ -226,10 +227,9 @@ if (nsd->new_state->administrative == NM_STATE_UNLOCKED) trigger_ramping = true; else - LOGP(DRSL, LOGL_DEBUG, "(bts=%d,trx=%d) ACC RAMP: ignoring state change " - "because TRX is transitioning into administrative state '%s'\n", - acc_ramp->bts->nr, trx->nr, - get_value_string(abis_nm_adm_state_names, nsd->new_state->administrative)); + LOG_TRX(trx, DRSL, LOGL_DEBUG, "ACC RAMP: ignoring state change " + "because TRX is transitioning into administrative state '%s'\n", + get_value_string(abis_nm_adm_state_names, nsd->new_state->administrative)); } else { /* * Administrative state has not changed. @@ -238,10 +238,9 @@ if (trx->mo.nm_state.administrative == NM_STATE_UNLOCKED) trigger_ramping = true; else - LOGP(DRSL, LOGL_DEBUG, "(bts=%d,trx=%d) ACC RAMP: ignoring state change " - "because TRX is in administrative state '%s'\n", - acc_ramp->bts->nr, trx->nr, - get_value_string(abis_nm_adm_state_names, trx->mo.nm_state.administrative)); + LOG_TRX(trx, DRSL, LOGL_DEBUG, "ACC RAMP: ignoring state change " + "because TRX is in administrative state '%s'\n", + get_value_string(abis_nm_adm_state_names, trx->mo.nm_state.administrative)); } break; case NM_OPSTATE_DISABLED: @@ -249,8 +248,8 @@ break; case NM_OPSTATE_NULL: default: - LOGP(DRSL, LOGL_ERROR, "(bts=%d) ACC RAMP: unrecognized operational state '0x%x' " - "reported for TRX 0\n", acc_ramp->bts->nr, nsd->new_state->administrative); + LOG_TRX(trx, DRSL, LOGL_ERROR, "ACC RAMP: unrecognized operational state '0x%x' " + "reported for TRX 0\n", nsd->new_state->administrative); break; } } @@ -296,7 +295,7 @@ return -ERANGE; acc_ramp->step_size = step_size; - LOGP(DRSL, LOGL_DEBUG, "(bts=%d) ACC RAMP: ramping step size set to %u\n", acc_ramp->bts->nr, step_size); + LOG_BTS(acc_ramp->bts, DRSL, LOGL_DEBUG, "ACC RAMP: ramping step size set to %u\n", step_size); return 0; } @@ -313,8 +312,8 @@ acc_ramp->step_interval_sec = step_interval; acc_ramp->step_interval_is_fixed = true; - LOGP(DRSL, LOGL_DEBUG, "(bts=%d) ACC RAMP: ramping step interval set to %u seconds\n", - acc_ramp->bts->nr, step_interval); + LOG_BTS(acc_ramp->bts, DRSL, LOGL_DEBUG, "ACC RAMP: ramping step interval set to %u seconds\n", + step_interval); return 0; } @@ -326,8 +325,7 @@ void acc_ramp_set_step_interval_dynamic(struct acc_ramp *acc_ramp) { acc_ramp->step_interval_is_fixed = false; - LOGP(DRSL, LOGL_DEBUG, "(bts=%d) ACC RAMP: ramping step interval set to 'dynamic'\n", - acc_ramp->bts->nr); + LOG_BTS(acc_ramp->bts, DRSL, LOGL_DEBUG, "ACC RAMP: ramping step interval set to 'dynamic'\n"); } /*! diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c index 56103b6..a5e697b 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts.c @@ -394,7 +394,7 @@ if (!trx->rsl_link) return; - LOGP(DLINP, LOGL_NOTICE, "(bts=%d,trx=%d) Dropping RSL link: %s\n", trx->bts->nr, trx->nr, reason); + LOG_TRX(trx, DLINP, LOGL_NOTICE, "Dropping RSL link: %s\n", reason); e1inp_sign_link_destroy(trx->rsl_link); trx->rsl_link = NULL; @@ -413,7 +413,7 @@ if (!bts->oml_link) return; - LOGP(DLINP, LOGL_NOTICE, "(bts=%d) Dropping OML link: %s\n", bts->nr, reason); + LOG_BTS(bts, DLINP, LOGL_NOTICE, "Dropping OML link: %s\n", reason); e1inp_sign_link_destroy(bts->oml_link); bts->oml_link = NULL; bts->uptime = 0; @@ -459,7 +459,7 @@ void ipaccess_drop_oml_deferred(struct gsm_bts *bts) { if (!osmo_timer_pending(&bts->oml_drop_link_timer) && bts->oml_link) { - LOGP(DLINP, LOGL_NOTICE, "(bts=%d) Deferring Drop of OML link.\n", bts->nr); + LOG_BTS(bts, DLINP, LOGL_NOTICE, "Deferring Drop of OML link.\n"); osmo_timer_setup(&bts->oml_drop_link_timer, ipaccess_drop_oml_deferred_cb, bts); osmo_timer_schedule(&bts->oml_drop_link_timer, 0, 0); } diff --git a/src/osmo-bsc/chan_alloc.c b/src/osmo-bsc/chan_alloc.c index 7f0aa31..669eb8e 100644 --- a/src/osmo-bsc/chan_alloc.c +++ b/src/osmo-bsc/chan_alloc.c @@ -113,8 +113,8 @@ /* Ignore samples too large for fixed-point calculations (shouldn't happen). */ if (lc->used > UINT16_MAX || lc->total > UINT16_MAX) { - LOGP(DRLL, LOGL_NOTICE, "(bts=%d) numbers in channel load sample " - "too large (used=%u / total=%u)\n", bts->nr, lc->used, lc->total); + LOG_BTS(bts, DRLL, LOGL_NOTICE, "numbers in channel load sample " + "too large (used=%u / total=%u)\n", lc->used, lc->total); continue; } @@ -124,8 +124,8 @@ /* Check for invalid samples (shouldn't happen). */ if (total == 0 || used > total) { - LOGP(DRLL, LOGL_NOTICE, "(bts=%d) bogus channel load sample (used=%"PRIu64" / total=%"PRIu32")\n", - bts->nr, used, total); + LOG_BTS(bts, DRLL, LOGL_NOTICE, "bogus channel load sample (used=%"PRIu64" / total=%"PRIu32")\n", + used, total); bts->T3122 = 0; /* disable override of network-wide default value */ bts->chan_load_samples_idx = 0; /* invalidate other samples collected so far */ return; @@ -153,8 +153,8 @@ /* Log channel load average. */ load = ((used / total) * 100); - LOGP(DRLL, LOGL_DEBUG, "(bts=%d) channel load average is %"PRIu64".%.2"PRIu64"%%\n", - bts->nr, (load & 0xffffff00) >> 8, (load & 0xff) / 10); + LOG_BTS(bts, DRLL, LOGL_DEBUG, "channel load average is %"PRIu64".%.2"PRIu64"%%\n", + (load & 0xffffff00) >> 8, (load & 0xff) / 10); bts->chan_load_avg = ((load & 0xffffff00) >> 8); OSMO_ASSERT(bts->chan_load_avg <= 100); osmo_stat_item_set(bts->bts_statg->items[BTS_STAT_CHAN_LOAD_AVERAGE], bts->chan_load_avg); @@ -167,7 +167,7 @@ else if (wait_ind > max_wait_ind) wait_ind = max_wait_ind; - LOGP(DRLL, LOGL_DEBUG, "(bts=%d) T3122 wait indicator set to %"PRIu64" seconds\n", bts->nr, wait_ind); + LOG_BTS(bts, DRLL, LOGL_DEBUG, "T3122 wait indicator set to %"PRIu64" seconds\n", wait_ind); bts->T3122 = (uint8_t)wait_ind; osmo_stat_item_set(bts->bts_statg->items[BTS_STAT_T3122], wait_ind); } diff --git a/src/osmo-bsc/e1_config.c b/src/osmo-bsc/e1_config.c index e7398ed..4389f66 100644 --- a/src/osmo-bsc/e1_config.c +++ b/src/osmo-bsc/e1_config.c @@ -72,17 +72,15 @@ int i; if (!e1_link->e1_ts) { - LOGP(DLINP, LOGL_ERROR, "TRX (%u/%u) RSL link without " - "timeslot?\n", trx->bts->nr, trx->nr); + LOG_TRX(trx, DLINP, LOGL_ERROR, "RSL link without timeslot?\n"); return -EINVAL; } /* RSL Link */ line = e1inp_line_find(e1_link->e1_nr); if (!line) { - LOGP(DLINP, LOGL_ERROR, "TRX (%u/%u) RSL link referring " - "to non-existing E1 line %u\n", trx->bts->nr, - trx->nr, e1_link->e1_nr); + LOG_TRX(trx, DLINP, LOGL_ERROR, "TRX RSL link referring to non-existing E1 line %u\n", + e1_link->e1_nr); return -ENOMEM; } sign_ts = &line->ts[e1_link->e1_ts-1]; @@ -93,8 +91,7 @@ oml_link = e1inp_sign_link_create(sign_ts, E1INP_SIGN_OML, trx, trx->rsl_tei, SAPI_OML); if (!oml_link) { - LOGP(DLINP, LOGL_ERROR, "TRX (%u/%u) OML link creation " - "failed\n", trx->bts->nr, trx->nr); + LOG_TRX(trx, DLINP, LOGL_ERROR, "TRX OML link creation failed\n"); return -ENOMEM; } if (trx->oml_link) @@ -104,8 +101,7 @@ rsl_link = e1inp_sign_link_create(sign_ts, E1INP_SIGN_RSL, trx, trx->rsl_tei, SAPI_RSL); if (!rsl_link) { - LOGP(DLINP, LOGL_ERROR, "TRX (%u/%u) RSL link creation " - "failed\n", trx->bts->nr, trx->nr); + LOG_TRX(trx, DLINP, LOGL_ERROR, "TRX RSL link creation failed\n"); return -ENOMEM; } if (trx->rsl_link) @@ -132,8 +128,8 @@ break; case E1INP_SIGN_RSL: if (link->trx->mo.nm_state.administrative == NM_STATE_LOCKED) { - LOGP(DLMI, LOGL_ERROR, "(bts=%d/trx=%d) discarding RSL message received " - "in locked administrative state\n", link->trx->bts->nr, link->trx->nr); + LOG_TRX(link->trx, DLMI, LOGL_ERROR, "discarding RSL message received " + "in locked administrative state\n"); msgb_free(msg); break; } @@ -161,17 +157,17 @@ struct timespec tp; int rc; - DEBUGP(DLMI, "e1_reconfig_bts(%u)\n", bts->nr); + LOG_BTS(bts, DLMI, LOGL_DEBUG, "e1_reconfig_bts\n"); line = e1inp_line_find(e1_link->e1_nr); if (!line) { - LOGP(DLINP, LOGL_ERROR, "BTS %u OML link referring to " - "non-existing E1 line %u\n", bts->nr, e1_link->e1_nr); + LOG_BTS(bts, DLINP, LOGL_ERROR, "BTS OML link referring to " + "non-existing E1 line %u\n", e1_link->e1_nr); return -ENOMEM; } if (!bts->model->e1line_bind_ops) { - LOGP(DLINP, LOGL_ERROR, "no callback to bind E1 line operations\n"); + LOG_BTS(bts, DLINP, LOGL_ERROR, "no callback to bind E1 line operations\n"); return -EINVAL; } if (!line->ops) @@ -184,8 +180,7 @@ /* OML link */ if (!e1_link->e1_ts) { - LOGP(DLINP, LOGL_ERROR, "BTS %u OML link without timeslot?\n", - bts->nr); + LOG_BTS(bts, DLINP, LOGL_ERROR, "BTS OML link without timeslot?\n"); return -EINVAL; } @@ -194,8 +189,7 @@ oml_link = e1inp_sign_link_create(sign_ts, E1INP_SIGN_OML, bts->c0, bts->oml_tei, SAPI_OML); if (!oml_link) { - LOGP(DLINP, LOGL_ERROR, "BTS %u OML link creation failed\n", - bts->nr); + LOG_BTS(bts, DLINP, LOGL_ERROR, "BTS OML link creation failed\n"); return -ENOMEM; } if (bts->oml_link) diff --git a/src/osmo-bsc/lchan_select.c b/src/osmo-bsc/lchan_select.c index 0a9752e..6df3b4a 100644 --- a/src/osmo-bsc/lchan_select.c +++ b/src/osmo-bsc/lchan_select.c @@ -169,7 +169,7 @@ struct gsm_lchan *lchan = NULL; enum gsm_phys_chan_config first, first_cbch, second, second_cbch; - LOGP(DRLL, LOGL_DEBUG, "(bts=%d) lchan_select_by_type(%s)\n", bts->nr, gsm_lchant_name(type)); + LOG_BTS(bts, DRLL, LOGL_DEBUG, "lchan_select_by_type(%s)\n", gsm_lchant_name(type)); switch (type) { case GSM_LCHAN_SDCCH: @@ -227,15 +227,15 @@ } break; default: - LOGP(DRLL, LOGL_ERROR, "Unknown gsm_chan_t %u\n", type); + LOG_BTS(bts, DRLL, LOGL_ERROR, "Unknown gsm_chan_t %u\n", type); } if (lchan) { lchan->type = type; LOG_LCHAN(lchan, LOGL_INFO, "Selected\n"); } else - LOGP(DRLL, LOGL_ERROR, "(bts=%d) Failed to select %s channel\n", - bts->nr, gsm_lchant_name(type)); + LOG_BTS(bts, DRLL, LOGL_ERROR, "Failed to select %s channel\n", + gsm_lchant_name(type)); return lchan; } diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index f1fd2ad..ca52ee7 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -85,9 +85,9 @@ log_set_context(LOG_CTX_BSC_SUBSCR, request->bsub); - LOGP(DPAG, LOGL_INFO, "(bts=%d) Going to send paging commands: imsi: %s tmsi: " - "0x%08x for ch. type %d (attempt %d)\n", bts->nr, request->bsub->imsi, - request->bsub->tmsi, request->chan_type, request->attempts); + LOG_BTS(bts, DPAG, LOGL_INFO, "Going to send paging commands: imsi: %s tmsi: " + "0x%08x for ch. type %d (attempt %d)\n", request->bsub->imsi, + request->bsub->tmsi, request->chan_type, request->attempts); if (request->bsub->tmsi == GSM_RESERVED_TMSI) mi_len = gsm48_generate_mid_from_imsi(mi, request->bsub->imsi); @@ -115,8 +115,7 @@ { struct gsm_bts_paging_state *paging_bts = data; - LOGP(DPAG, LOGL_NOTICE, "(bts=%d) No PCH LOAD IND, adding 20 slots)\n", - paging_bts->bts->nr); + LOG_BTS(paging_bts->bts, DPAG, LOGL_NOTICE, "No PCH LOAD IND, adding 20 slots)\n"); paging_bts->available_slots = 20; paging_handle_pending_requests(paging_bts); } @@ -315,8 +314,7 @@ /* ceiling in seconds + extra time */ to = (to_us + 999999) / 1000000 + d->val; - LOGP(DPAG, LOGL_DEBUG, "(bts=%d) Paging request: T3113 expires in %u seconds\n", - bts->nr, to); + LOG_BTS(bts, DPAG, LOGL_DEBUG, "Paging request: T3113 expires in %u seconds\n", to); return to; } @@ -336,14 +334,13 @@ rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_PAGING_ATTEMPTED]); if (paging_pending_request(bts_entry, bsub)) { - LOGP(DPAG, LOGL_INFO, "(bts=%d) Paging request already pending for %s\n", - bts->nr, bsc_subscr_name(bsub)); + LOG_BTS(bts, DPAG, LOGL_INFO, "Paging request already pending for %s\n", + bsc_subscr_name(bsub)); rate_ctr_inc(&bts->bts_ctrs->ctr[BTS_CTR_PAGING_ALREADY]); return -EEXIST; } - LOGP(DPAG, LOGL_DEBUG, "(bts=%d) Start paging of subscriber %s\n", bts->nr, - bsc_subscr_name(bsub)); + LOG_BTS(bts, DPAG, LOGL_DEBUG, "Start paging of subscriber %s\n", bsc_subscr_name(bsub)); req = talloc_zero(tall_paging_ctx, struct gsm_paging_request); OSMO_ASSERT(req); req->bsub = bsc_subscr_get(bsub); @@ -407,8 +404,7 @@ if (req->bsub == bsub) { /* now give up the data structure */ paging_remove_request(&bts->paging, req); - LOGP(DPAG, LOGL_DEBUG, "(bts=%d) Stop paging %s\n", bts->nr, - bsc_subscr_name(bsub)); + LOG_BTS(bts, DPAG, LOGL_DEBUG, "Stop paging %s\n", bsc_subscr_name(bsub)); return 0; } } @@ -498,8 +494,7 @@ if (msc && req->msc != msc) continue; /* now give up the data structure */ - LOGP(DPAG, LOGL_DEBUG, "(bts=%d) Stop paging %s (flush)\n", bts->nr, - bsc_subscr_name(req->bsub)); + LOG_BTS(bts, DPAG, LOGL_DEBUG, "Stop paging %s (flush)\n", bsc_subscr_name(req->bsub)); paging_remove_request(&bts->paging, req); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14439 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4a7814d164384eecfb6913c31802cf2faead6e6c Gerrit-Change-Number: 14439 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:02:09 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:02:09 +0000 Subject: Change in ...openbsc[master]: manuals: Update osmonitb counter/vty documentation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14529 ) Change subject: manuals: Update osmonitb counter/vty documentation ...................................................................... Patch Set 1: daniel, ping? -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ia598124fbb98b3ec8dee606f9d028bb3cc6ff002 Gerrit-Change-Number: 14529 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 04:02:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:05:26 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:05:26 +0000 Subject: Change in ...libosmocore[master]: bitvec: bitvec_get_uint() should return an unsigned int In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14577 ) Change subject: bitvec: bitvec_get_uint() should return an unsigned int ...................................................................... Patch Set 2: Code-Review-1 as the (likey?) orignal author of the code, I would say the function does exactly what it is supposed to do: parse input as unsigned integer and return it, just as long as it is below the maximum of a signed integer. return negative in case of error. If there is anything to change, then it could be bounds checking, i.e. ASSERT that the caller doesn't pass num_bits leading to potential overflows of INT_MAX. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d50d375ccf63ecb45061682ede0b46b6087d11a Gerrit-Change-Number: 14577 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Tue, 16 Jul 2019 04:05:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:05:54 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:05:54 +0000 Subject: Change in ...osmo-bts[master]: RSL: Fix fixed MS power control in RSL CHAN ACTIV In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14489 ) Change subject: RSL: Fix fixed MS power control in RSL CHAN ACTIV ...................................................................... RSL: Fix fixed MS power control in RSL CHAN ACTIV Dynamic MS power control should only be active if a power parameters IE was supplied. Change-Id: I0bbe171a287b10d71fc853cd721f66e4c84db8c5 --- M src/common/rsl.c 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/rsl.c b/src/common/rsl.c index 7630a8c..0a613bb 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1116,6 +1116,14 @@ /* 9.3.32 BS Power Parameters */ /* 9.3.31 MS Power Parameters */ + if (TLVP_PRESENT(&tp, RSL_IE_MS_POWER_PARAM)) + lchan->ms_power_ctrl.fixed = 0; + else { + /* Spec explicitly states BTS should only perform + * autonomous MS power control loop in BTS if 'MS Power + * Parameters' IE is present! */ + lchan->ms_power_ctrl.fixed = 1; + } /* 9.3.16 Physical Context */ /* 9.3.29 SACCH Information */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14489 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0bbe171a287b10d71fc853cd721f66e4c84db8c5 Gerrit-Change-Number: 14489 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:06:29 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:06:29 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14660 ) Change subject: BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I67d89b2f0e13a7a6f74f001b19d37add77ec06f5 Gerrit-Change-Number: 14660 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 04:06:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:06:31 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:06:31 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14660 ) Change subject: BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb ...................................................................... BTS_Tests.ttcn: introduce TC_pcu_data_ind_lqual_cb The idea of this test case is to verify that the link quality measurements, in particular C/I (Carrier-to-Interference ratio), are delivered to the PCU (as a part of PCUIF_DATA.ind). The C/I ratio needs to be calculated by the transceiver from the training sequence of each burst, where we can compare the "ideal" training sequence with the actual training sequence and then express that in cB (centiBels). This test case can only be executed with fake_trx.py and trxcon, because this pair allows us to simulate C/I values. Also, the new TRXD header format needs to be supported (see OS#4006). Change-Id: I67d89b2f0e13a7a6f74f001b19d37add77ec06f5 Depends: (OsmocomBB) I7080effbbc1022d1884c6d6f0cb580eba8e514ff Related: OS#1855 --- M bts/BTS_Tests.ttcn 1 file changed, 77 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 6972806..ebe74c0 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -422,6 +422,8 @@ /* Start with a default moderate timing offset equalling TA=2, and RSSI=-60 */ ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_TIMING(2*256))); ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_RSSI(-60))); + /* FIXME: OsmoBTS may have different AB / NB threshold (see MIN_QUAL_NORM, MIN_QUAL_RACH) */ + ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_CI(0))); } /* Wait some extra time to make sure the BTS emits a stable carrier. @@ -4315,6 +4317,80 @@ setverdict(pass); } +private function f_TC_pcu_data_ind_lqual_cb(int16_t lqual_cb_exp, int16_t thresh) +runs on test_CT { + var template PCUIF_send_data sdt; + var PCUIF_send_data sd; + var int16_t lqual_cb; + timer T := 1.0; + + /* PCUIF_DATA.ind is encapsulated into a supplementary record */ + sdt := t_SD_PCUIF_MSGT(g_pcu_conn_id, PCU_IF_MSG_DATA_IND); + + /* Send a random PDTCH frame over Um */ + L1CTL.send(ts_L1CTL_TRAFFIC_REQ(ts_RslChanNr_PDCH(7), ts_RslLinkID_DCCH(0), + '0000'O & f_rnd_octstring(21))); + + T.start; + alt { + /* If expected link quality is above the threshold */ + [lqual_cb_exp >= thresh] PCU.receive(sdt) -> value sd { + lqual_cb := sd.data.u.data_ind.lqual_cb; + log("Rx PCUIF_DATA.ind (lqual_cb=", lqual_cb, ")"); + + /* Make sure the actual link quality matches the expected value */ + if (not match(lqual_cb, lqual_cb_exp)) { + setverdict(fail, log2str("Link quality ", lqual_cb, " does not match ", + "expected value ", lqual_cb_exp)); + } else { + setverdict(pass); + } + } + /* If expected link quality is below the threshold */ + [lqual_cb_exp < thresh] PCU.receive(sdt) -> value sd { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Rx unexpected PCUIF_DATA.ind: ", sd.data)); + } + /* Ignore PCUIF_RTS.req and PCUIF_TIME.ind */ + [] PCU.receive { repeat; } + [lqual_cb_exp < thresh] T.timeout { + log("Rx nothing, as expected"); + setverdict(pass); + } + [lqual_cb_exp >= thresh] T.timeout { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + "Timeout waiting for PCUIF_DATA.ind"); + } + } +} + +/* Verify C/I (Carrier-to-Interference ratio) processing of PDTCH frames */ +testcase TC_pcu_data_ind_lqual_cb() runs on test_CT { + f_init_pcu_test(); + PCU.clear; + + f_init_l1ctl(); + f_l1_tune(L1CTL); + + /* Activate a PDCH channel on TS7 */ + f_TC_pcu_act_req(0, 0, 7, true); + + /* Tune trxcon to that PDCH channel on TS7 */ + f_L1CTL_DM_EST_REQ(L1CTL, { false, mp_trx0_arfcn }, + valueof(ts_RslChanNr_PDCH(7)), 7); + + /* C/I in centiBels, test range: -256 .. +1280, step 128 */ + for (var int16_t i := -256; i <= 1280; i := i + 128) { + var TrxcMessage ret; + + ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, + valueof(ts_TRXC_FAKE_CI(i))); + + /* FIXME: OsmoBTS may have different threshold (see MIN_QUAL_NORM) */ + f_TC_pcu_data_ind_lqual_cb(i, thresh := 0); + } +} + /* Send PAGING via RSL, expect it to shw up on PCU socket */ testcase TC_pcu_paging_from_rsl() runs on test_CT { f_init_pcu_test(); @@ -6163,6 +6239,7 @@ execute( TC_pcu_data_req_imm_ass_pch() ); execute( TC_pcu_rach_content() ); execute( TC_pcu_ext_rach_content() ); + execute( TC_pcu_data_ind_lqual_cb() ); execute( TC_pcu_paging_from_rsl() ); execute( TC_pcu_time_ind() ); execute( TC_pcu_rts_req() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14660 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I67d89b2f0e13a7a6f74f001b19d37add77ec06f5 Gerrit-Change-Number: 14660 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:06:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:06:56 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E0=2E6=2E100-e524_=E2=86=92_0=2E1=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14676 ) Change subject: Bump version: 0.0.6.100-e524 ? 0.1.0 ...................................................................... Patch Set 1: how does this relate to https://gerrit.osmocom.org/#/c/osmo-pcap/+/14677/ with the same subject? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14676 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Id122ff79aa3f339afb5a35f758c67a350cf94830 Gerrit-Change-Number: 14676 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 04:06:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:07:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:07:05 +0000 Subject: Change in ...osmo-pcap[master]: debian/changelog: Mark 0.0.11 as released In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14675 ) Change subject: debian/changelog: Mark 0.0.11 as released ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I08a722be405f667797d180ec66e08ba0dc9f59d8 Gerrit-Change-Number: 14675 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 04:07:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:07:09 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:07:09 +0000 Subject: Change in ...osmo-pcap[master]: debian/changelog: Mark 0.0.11 as released In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14675 ) Change subject: debian/changelog: Mark 0.0.11 as released ...................................................................... debian/changelog: Mark 0.0.11 as released Change-Id: I08a722be405f667797d180ec66e08ba0dc9f59d8 --- M debian/changelog 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/changelog b/debian/changelog index 13bce30..1345f93 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,4 +1,4 @@ -osmo-pcap (0.0.11) UNRELEASED; urgency=medium +osmo-pcap (0.0.11) unstable; urgency=medium * Add "source ip A.B.C.D" option to use specific address. * Add osmo-pcap-client-dbg/osmo-pcap-server-dbg package -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14675 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I08a722be405f667797d180ec66e08ba0dc9f59d8 Gerrit-Change-Number: 14675 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:07:34 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:07:34 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/gsm_shared.py: introduce a new enum TrainingSeqGMSK In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14690 ) Change subject: trx_toolkit/gsm_shared.py: introduce a new enum TrainingSeqGMSK ...................................................................... trx_toolkit/gsm_shared.py: introduce a new enum TrainingSeqGMSK Training Sequences are defined in 3GPP TS 45.002, and used by the transceiver for detecting bursts. This change introduces an enum with training sequences for GMSK for Access and Normal bursts. This enumeration is needed for the follow-up changes that implement TRXD header version 1 support, and can now be used by RandBurstGen. Change-Id: If3bf102019ef53d6ee9ad230ef98bb45845b5af5 --- M src/target/trx_toolkit/gsm_shared.py 1 file changed, 78 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/target/trx_toolkit/gsm_shared.py b/src/target/trx_toolkit/gsm_shared.py index d2f8278..d76978e 100644 --- a/src/target/trx_toolkit/gsm_shared.py +++ b/src/target/trx_toolkit/gsm_shared.py @@ -4,7 +4,7 @@ # TRX Toolkit # Common GSM constants # -# (C) 2018 by Vadim Yanitskiy +# (C) 2018-2019 by Vadim Yanitskiy # # All Rights Reserved # @@ -22,6 +22,8 @@ # with this program; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +from enum import Enum + # TDMA definitions GSM_SUPERFRAME = 26 * 51 GSM_HYPERFRAME = 2048 * GSM_SUPERFRAME @@ -29,3 +31,78 @@ # Burst length GSM_BURST_LEN = 148 EDGE_BURST_LEN = GSM_BURST_LEN * 3 + +class BurstType(Enum): + """ Burst types defined in 3GPP TS 45.002 """ + DUMMY = ("DB") # Dummy burst (5.2.6) + SYNC = ("SB") # Synchronization Burst (5.2.5) + FREQ = ("FB") # Frequency correction Burst (5.2.4) + ACCESS = ("AB") # Access Burst (5.2.7) + NORMAL = ("NB") # Normal Burst (5.2.3) + # HSR = ("HB") # Higher symbol rate burst (5.2.3a) + +class TrainingSeqGMSK(Enum): + """ Training Sequences defined in 3GPP TS 45.002 """ + + # Training Sequences for Access Burst (table 5.2.7-3) + AB_TS0 = (0, BurstType.ACCESS, "01001011011111111001100110101010001111000") + AB_TS1 = (1, BurstType.ACCESS, "01010100111110001000011000101111001001101") + AB_TS2 = (2, BurstType.ACCESS, "11101111001001110101011000001101101110111") + AB_TS4 = (4, BurstType.ACCESS, "11001001110001001110000000001101010110010") + + # Training Sequences for Access Burst (table 5.2.7-4) + AB_TS3 = (3, BurstType.ACCESS, "10001000111010111011010000010000101100010") + AB_TS5 = (5, BurstType.ACCESS, "01010000111111110101110101101100110010100") + AB_TS6 = (6, BurstType.ACCESS, "01011110011101011110110100010011000010111") + AB_TS7 = (7, BurstType.ACCESS, "01000010110000011101001010111011100010000") + + # Training Sequences for Synchronization Burst (table 5.2.5-3) + SB_TS0 = (0, BurstType.SYNC, "1011100101100010000001000000111100101101010001010111011000011011") + SB_TS1 = (1, BurstType.SYNC, "1110111001101011001010000011111011110100011111101100101100010101") + SB_TS2 = (2, BurstType.SYNC, "1110110000110111010100010101101001111000000100000010001101001110") + SB_TS3 = (3, BurstType.SYNC, "1011101000111101110101101111010010001011010000001000111010011000") + + # Training Sequences for Normal Burst (table 5.2.3a, TSC set 1) + NB_TS0 = (0, BurstType.NORMAL, "00100101110000100010010111") + NB_TS1 = (1, BurstType.NORMAL, "00101101110111100010110111") + NB_TS2 = (2, BurstType.NORMAL, "01000011101110100100001110") + NB_TS3 = (3, BurstType.NORMAL, "01000111101101000100011110") + NB_TS4 = (4, BurstType.NORMAL, "00011010111001000001101011") + NB_TS5 = (5, BurstType.NORMAL, "01001110101100000100111010") + NB_TS6 = (6, BurstType.NORMAL, "10100111110110001010011111") + NB_TS7 = (7, BurstType.NORMAL, "11101111000100101110111100") + + # TODO: more TSC sets from tables 5.2.3b-d + + def __init__(self, tsc, bt, seq_str, tsc_set = 0): + # Training Sequence Code + self.tsc = tsc + # Burst type + self.bt = bt + + # Training Sequence Code set + # NOTE: unlike the specs. we count from zero + self.tsc_set = tsc_set + + # Generate Training Sequence bits + self.seq = [int(x) for x in seq_str] + + @classmethod + def pick(self, burst): + # Normal burst TS (26 bits) + nb_seq = burst[3 + 57 + 1:][:26] + # Access burst TS (41 bits) + ab_seq = burst[8:][:41] + # Sync Burst TS (64 bits) + sb_seq = burst[3 + 39:][:64] + + for ts in list(self): + # Ugly Python way of writing 'switch' statement + if ts.bt is BurstType.NORMAL and ts.seq == nb_seq: + return ts + elif ts.bt is BurstType.ACCESS and ts.seq == ab_seq: + return ts + elif ts.bt is BurstType.SYNC and ts.seq == sb_seq: + return ts + + return None -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If3bf102019ef53d6ee9ad230ef98bb45845b5af5 Gerrit-Change-Number: 14690 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:07:34 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:07:34 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/rand_burst_gen.py: use TrainingSeqGMSK and BurstType enums In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14691 ) Change subject: trx_toolkit/rand_burst_gen.py: use TrainingSeqGMSK and BurstType enums ...................................................................... trx_toolkit/rand_burst_gen.py: use TrainingSeqGMSK and BurstType enums Change-Id: I8a3faceae4a8d9b57d86d42600db839da073dad6 --- M src/target/trx_toolkit/rand_burst_gen.py 1 file changed, 16 insertions(+), 56 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/target/trx_toolkit/rand_burst_gen.py b/src/target/trx_toolkit/rand_burst_gen.py index 46c1e09..80ff3f2 100644 --- a/src/target/trx_toolkit/rand_burst_gen.py +++ b/src/target/trx_toolkit/rand_burst_gen.py @@ -28,50 +28,6 @@ class RandBurstGen: - # GSM 05.02 Chapter 5.2.3 Normal Burst - nb_tsc_list = [ - [ - 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, - 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, - ], - [ - 0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, - 1, 1, 0, 0, 0, 1, 0, 1, 1, 0, 1, 1, 1, - ], - [ - 0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, - 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0, - ], - [ - 0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, - 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0, - ], - [ - 0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, - 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1, - ], - [ - 0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, - 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0, - ], - [ - 1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, - 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1, - ], - [ - 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, - 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, - ], - ] - - # GSM 05.02 Chapter 5.2.5 SCH training sequence - sb_tsc = [ - 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0, - 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, - 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1, - 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1, - ] - # GSM 05.02 Chapter 5.2.6 Dummy Burst db_bits = [ 0, 0, 0, @@ -87,15 +43,13 @@ 0, 0, 0, ] - # GSM 05.02 Chapter 5.2.7 Access burst - ab_tsc = [ - 0, 1, 0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 1, 1, - 1, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 1, 0, - 1, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 0, 0, - ] + # Pick a random TSC for a given burst type + def get_rand_tsc(self, bt): + tsc_list = filter(lambda seq: seq.bt == bt, list(TrainingSeqGMSK)) + return random.choice(tsc_list) # Generate a normal burst - def gen_nb(self, seq_idx = 0): + def gen_nb(self, tsc = None): buf = [] # Tailing bits @@ -109,7 +63,9 @@ buf.append(random.randint(0, 1)) # Training sequence - buf += self.nb_tsc_list[seq_idx] + if tsc is None: + tsc = self.get_rand_tsc(BurstType.NORMAL) + buf += tsc.seq # Steal flag 2 / 2 buf.append(random.randint(0, 1)) @@ -128,7 +84,7 @@ return [0] * GSM_BURST_LEN # Generate a synchronization burst - def gen_sb(self): + def gen_sb(self, tsc = None): buf = [] # Tailing bits @@ -139,7 +95,9 @@ buf.append(random.randint(0, 1)) # Training sequence - buf += self.sb_tsc + if tsc is None: + tsc = self.get_rand_tsc(BurstType.SYNC) + buf += tsc.seq # Random data 2 / 2 for i in range(0, 39): @@ -155,14 +113,16 @@ return self.db_bits # Generate an access burst - def gen_ab(self): + def gen_ab(self, tsc = None): buf = [] # Tailing bits buf += [0] * 8 # Training sequence - buf += self.ab_tsc + if tsc is None: + tsc = self.get_rand_tsc(BurstType.ACCESS) + buf += tsc.seq # Random data for i in range(0, 36): -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14691 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8a3faceae4a8d9b57d86d42600db839da073dad6 Gerrit-Change-Number: 14691 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:07:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:07:35 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14585 ) Change subject: trx_toolkit/fake_trx.py: basic TRXD version 0x01 support ...................................................................... trx_toolkit/fake_trx.py: basic TRXD version 0x01 support Since the new TRXD header format has been introduced, FakeTRX needs to be able to fill it correctly. In particular, the following: - Modulation, which can be determined from the burst length; - Training Sequence Code (and set), which needs to be detected by comparing the burst bits of L12TRX message against known training sequences (only GMSK and the default TS set for now); - C/I (Carrier-to-Interference ratio), which can be simulated later on, as instructed on the TRXC interface ('FAKE_CI'). The actual TRXD header version is stored in the instance of class DATAInterface. By default (at startup), legacy version 0 is used. The version negotiation is supposed to be performed on the TRXC interface, and to be implemented in a follow-up change. Different Transceivers may use different header versions, thus in FakeTRX.send_data_msg() we need to override the original version of the L12TRX message, and generate the corresponding PDU. Limitations: - NOPE / IDLE indications are not (yet) supported; - TSC detection: GMSK modulation only. Change-Id: I164f5ae4ce7694d6e324aab927a04e96d489ebd8 Related: OS#4006 --- M src/target/trx_toolkit/burst_fwd.py M src/target/trx_toolkit/data_if.py M src/target/trx_toolkit/fake_trx.py 3 files changed, 78 insertions(+), 5 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/target/trx_toolkit/burst_fwd.py b/src/target/trx_toolkit/burst_fwd.py index 164271f..1d5dd7b 100644 --- a/src/target/trx_toolkit/burst_fwd.py +++ b/src/target/trx_toolkit/burst_fwd.py @@ -84,4 +84,4 @@ if tx_msg.tn not in trx.ts_list: continue - trx.send_data_msg(src_trx, tx_msg) + trx.send_data_msg(src_trx, rx_msg, tx_msg) diff --git a/src/target/trx_toolkit/data_if.py b/src/target/trx_toolkit/data_if.py index 027fd85..10df438 100644 --- a/src/target/trx_toolkit/data_if.py +++ b/src/target/trx_toolkit/data_if.py @@ -4,7 +4,7 @@ # TRX Toolkit # DATA interface implementation # -# (C) 2017-2018 by Vadim Yanitskiy +# (C) 2017-2019 by Vadim Yanitskiy # # All Rights Reserved # @@ -29,9 +29,29 @@ class DATAInterface(UDPLink): def __init__(self, *udp_link_args): + # Default header version (legacy) + self._hdr_ver = 0x00 + UDPLink.__init__(self, *udp_link_args) log.debug("Init TRXD interface (%s)" % self.desc_link()) + def set_hdr_ver(self, ver): + if not ver in DATAMSG.known_versions: + return False + + self._hdr_ver = ver + return True + + def match_hdr_ver(self, msg): + if msg.ver == self._hdr_ver: + return True + + log.error("(%s) Rx DATA message (%s) with unexpected header " + "version %u (!= expected %u), ignoring..." + % (self.desc_link(), msg.desc_hdr(), + msg.ver, self._hdr_ver)) + return False + def recv_raw_data(self): data, _ = self.sock.recvfrom(512) return data @@ -49,6 +69,11 @@ "from R:%s:%u" % (self.remote_addr, self.remote_port)) return None + # Make sure the header version matches + # the configured one (self._hdr_ver) + if not self.match_hdr_ver(msg): + return None + return msg def recv_trx2l1_msg(self): @@ -64,6 +89,11 @@ "from R:%s:%u" % (self.remote_addr, self.remote_port)) return None + # Make sure the header version matches + # the configured one (self._hdr_ver) + if not self.match_hdr_ver(msg): + return None + return msg def send_msg(self, msg, legacy = False): diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py index 928333f..de0e6ff 100755 --- a/src/target/trx_toolkit/fake_trx.py +++ b/src/target/trx_toolkit/fake_trx.py @@ -35,9 +35,11 @@ from app_common import ApplicationBase from burst_fwd import BurstForwarder from transceiver import Transceiver +from data_msg import Modulation from clck_gen import CLCKGen from trx_list import TRXList from fake_pm import FakePM +from gsm_shared import * class FakeTRX(Transceiver): """ Fake transceiver with RF path (burst loss, RSSI, TA, ToA) simulation. @@ -98,18 +100,21 @@ TOA256_BASE_DEFAULT = 0 RSSI_BASE_DEFAULT = -60 + CI_BASE_DEFAULT = 90 def __init__(self, *trx_args, **trx_kwargs): Transceiver.__init__(self, *trx_args, **trx_kwargs) - # Actual ToA / RSSI / TA values + # Actual ToA, RSSI, C/I, TA values self.toa256_base = self.TOA256_BASE_DEFAULT self.rssi_base = self.RSSI_BASE_DEFAULT + self.ci_base = self.CI_BASE_DEFAULT self.ta = 0 - # ToA / RSSI randomization threshold + # ToA, RSSI, C/I randomization thresholds self.toa256_rand_threshold = 0 self.rssi_rand_threshold = 0 + self.ci_rand_threshold = 0 # Path loss simulation (burst dropping) self.burst_drop_amount = 0 @@ -137,6 +142,17 @@ rssi_max = self.rssi_base + self.rssi_rand_threshold return random.randint(rssi_min, rssi_max) + @property + def ci(self): + # Check if randomization is required + if self.ci_rand_threshold is 0: + return self.ci_base + + # Generate a random C/I value in required range + ci_min = self.ci_base - self.ci_rand_threshold + ci_max = self.ci_base + self.ci_rand_threshold + return random.randint(ci_min, ci_max) + # Path loss simulation: burst dropping # Returns: True - drop, False - keep def sim_burst_drop(self, msg): @@ -152,14 +168,41 @@ return False + def _handle_data_msg_v1(self, src_msg, msg): + # TODO: NOPE indications are not (yet) supported + msg.nope_ind = False + + # C/I (Carrier-to-Interference ratio) + msg.ci = self.ci + + # Pick modulation type by burst length + bl = len(src_msg.burst) + msg.mod_type = Modulation.pick_by_bl(bl) + + # Pick TSC (Training Sequence Code) and TSC set + if msg.mod_type is Modulation.ModGMSK: + ss = TrainingSeqGMSK.pick(src_msg.burst) + msg.tsc = ss.tsc if ss is not None else 0 + msg.tsc_set = ss.tsc_set if ss is not None else 0 + else: # TODO: other modulation types (at least 8-PSK) + msg.tsc_set = 0 + msg.tsc = 0 + # Takes (partially initialized) TRX2L1 message, # simulates RF path parameters (such as RSSI), # and sends towards the L1 - def send_data_msg(self, src_trx, msg): + def send_data_msg(self, src_trx, src_msg, msg): + # Override header version + msg.ver = self.data_if._hdr_ver + # Complete message header msg.toa256 = self.toa256 msg.rssi = self.rssi + # Version specific fields + if msg.ver >= 0x01: + self._handle_data_msg_v1(src_msg, msg) + # Apply optional Timing Advance if src_trx.ta is not 0: msg.toa256 -= src_trx.ta * 256 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14585 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I164f5ae4ce7694d6e324aab927a04e96d489ebd8 Gerrit-Change-Number: 14585 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:08:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:08:05 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14692 ) Change subject: trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8d441b2559863d2dbd680db371062e4f3a2f9ff9 Gerrit-Change-Number: 14692 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 04:08:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:10:18 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:10:18 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14195 ) Change subject: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler ...................................................................... Patch Set 3: I think we should rather tag a new libosmocore and update the dependency requirement everywhere. I'm not against this single fix, but I guess we'd have to fix lots of places if we want to avoid any trouble with old libosmocore? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: If9b0c0d031477ca87786aab5c269d00748e896c8 Gerrit-Change-Number: 14195 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 04:10:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:11:18 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:11:18 +0000 Subject: Change in ...osmo-pcu[master]: src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14704 ) Change subject: src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0fd6c35e8cf0b1314f4e3c336b233b5f7e42dfc6 Gerrit-Change-Number: 14704 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Jul 2019 04:11:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:11:20 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:11:20 +0000 Subject: Change in ...osmo-pcu[master]: src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14704 ) Change subject: src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF ...................................................................... src/pcu_l1_if.cpp: fix: properly pass measurements from PCUIF The recent versions of OsmoBTS do provide the following measurements: - RSSI (Received Signal Strength Indication), - ToA (Timing of Arrival), - BER (Bit Error Rate), as well as C/I (Carrier-to-Interference ratio) since [1] (OS#4006). [1] https://gerrit.osmocom.org/r/Ia58043bd2381a4d34d604522e02899ae64ee0d26 Change-Id: I0fd6c35e8cf0b1314f4e3c336b233b5f7e42dfc6 Related: OS#1855 --- M src/pcu_l1_if.cpp 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 5cabe4f..bc712fd 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -289,14 +289,14 @@ switch (data_ind->sapi) { case PCU_IF_SAPI_PDTCH: meas.set_rssi(data_ind->rssi); -#ifndef ENABLE_DIRECT_PHY /* convert BER to % value */ meas.set_ber(data_ind->ber10k / 100); meas.set_bto(data_ind->ta_offs_qbits); meas.set_link_qual(data_ind->lqual_cb / 10); + LOGP(DL1IF, LOGL_DEBUG, "Data indication with raw measurements received: BER10k = %d, BTO = %d, Q = %d\n", data_ind->ber10k, data_ind->ta_offs_qbits, data_ind->lqual_cb); -#endif + rc = pcu_rx_data_ind_pdtch(data_ind->trx_nr, data_ind->ts_nr, data_ind->data, data_ind->len, data_ind->fn, &meas); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14704 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I0fd6c35e8cf0b1314f4e3c336b233b5f7e42dfc6 Gerrit-Change-Number: 14704 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:15:17 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:15:17 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: add TRXD header version negotiation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: add TRXD header version negotiation ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8afe950bd1ec2afaf3347ff848ee46e69c4f5011 Gerrit-Change-Number: 14611 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: ipse Gerrit-Comment-Date: Tue, 16 Jul 2019 04:15:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:15:21 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:15:21 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: encode actual TRXD header version In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14745 ) Change subject: osmo-bts-trx/trx_if.c: encode actual TRXD header version ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14745 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idbc598ef7c1871ee8da830f3fbe0a5cc386f873d Gerrit-Change-Number: 14745 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 04:15:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:15:27 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:15:27 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14612 ) Change subject: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iae6b78bafa4b86d0c681684de47320d641d3f7c0 Gerrit-Change-Number: 14612 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 04:15:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:16:02 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:16:02 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14684 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1e654a2e49cb83c5f1e6249c0de688f99bc466b0 Gerrit-Change-Number: 14684 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 04:16:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:16:13 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:16:13 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: add TRXD header version negotiation In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14611 ) Change subject: osmo-bts-trx/trx_if.c: add TRXD header version negotiation ...................................................................... osmo-bts-trx/trx_if.c: add TRXD header version negotiation This change introduces a new command for TRXD header format negotiation - SETFORMAT. If the transceiver does not support the format negotiation, it would reject this command with 'RSP ERR 1'. If the requested version is not supported by the transceiver, status code of the response message should indicate a preferred (basically, the latest) version. The format of SETFORMAT command is the following: L1 -> TRX: CMD SETFORMAT VER_REQ L1 <- TRX: RSP SETFORMAT VER_RSP VER_REQ where: - VER_REQ is the requested version (suggested by the L1), - VER_RSP is either the applied version if matches VER_REQ, or a preferred version if VER_REQ is not supported. If the transceiver indicates VER_RSP different than VER_REQ, OsmoBTS is supposed to reinitiate the version negotiation using the suggested VER_RSP. For example: L1 -> TRX: CMD SETFORMAT 2 L1 <- TRX: RSP SETFORMAT 1 2 L1 -> TRX: CMD SETFORMAT 1 L1 <- TRX: RSP SETFORMAT 1 1 If no suitable VER_RSP is found, or the VER_REQ is incorrect, the status code in the response would be -1. As soon as VER_RSP matches VER_REQ in the response, the process of negotiation is complete. Changing the header version is supposed to be done before POWERON. Change-Id: I8afe950bd1ec2afaf3347ff848ee46e69c4f5011 Related: OS#4006 --- M src/osmo-bts-trx/l1_if.c M src/osmo-bts-trx/l1_if.h M src/osmo-bts-trx/trx_if.c M src/osmo-bts-trx/trx_if.h 4 files changed, 91 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c index e6e384a..9c1dc18 100644 --- a/src/osmo-bts-trx/l1_if.c +++ b/src/osmo-bts-trx/l1_if.c @@ -208,6 +208,13 @@ l1h->config.bsic_sent = 1; } + /* Ask transceiver to use the newest TRXD header version */ + if (!l1h->config.setformat_sent) { + trx_if_cmd_setformat(l1h, TRX_DATA_FORMAT_VER); + l1h->config.trxd_hdr_ver_req = TRX_DATA_FORMAT_VER; + l1h->config.setformat_sent = 1; + } + if (!l1h->config.poweron_sent) { trx_if_cmd_poweron(l1h); l1h->config.poweron_sent = 1; @@ -264,6 +271,9 @@ llist_for_each_entry(trx, &bts->trx_list, list) { struct phy_instance *pinst = trx_phy_instance(trx); struct trx_l1h *l1h = pinst->u.osmotrx.hdl; + l1h->config.trxd_hdr_ver_req = 0; + l1h->config.trxd_hdr_ver_use = 0; + l1h->config.setformat_sent = 0; l1h->config.arfcn_sent = 0; l1h->config.tsc_sent = 0; l1h->config.bsic_sent = 0; diff --git a/src/osmo-bts-trx/l1_if.h b/src/osmo-bts-trx/l1_if.h index 9c95c53..87df951 100644 --- a/src/osmo-bts-trx/l1_if.h +++ b/src/osmo-bts-trx/l1_if.h @@ -6,6 +6,10 @@ #include "trx_if.h" struct trx_config { + uint8_t trxd_hdr_ver_req; /* requested TRXD header version */ + uint8_t trxd_hdr_ver_use; /* actual TRXD header version in use */ + int setformat_sent; + uint8_t poweron; /* poweron(1) or poweroff(0) */ int poweron_sent; diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index e9193ca..3e53fdb 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -269,6 +269,15 @@ return 0; } +/*! Send "SETFORMAT" command to TRX: change TRXD header format version */ +int trx_if_cmd_setformat(struct trx_l1h *l1h, uint8_t ver) +{ + LOGPPHI(l1h->phy_inst, DTRX, LOGL_INFO, + "Requesting TRXD header format version %u\n", ver); + + return trx_ctrl_cmd(l1h, 0, "SETFORMAT", "%u", ver); +} + /*! Send "SETTSC" command to TRX */ int trx_if_cmd_settsc(struct trx_l1h *l1h, uint8_t tsc) { @@ -433,6 +442,8 @@ expected that they can return different values */ if (strcmp(tcm->cmd, "SETSLOT") == 0 && strcmp(tcm->params, rsp->params)) return false; + else if (strcmp(tcm->cmd, "SETFORMAT") == 0 && strcmp(tcm->params, rsp->params)) + return false; return true; } @@ -460,11 +471,59 @@ return rsp->status == 0 ? 0 : -EINVAL; } +/* TRXD header format negotiation handler. + * + * If the transceiver does not support the format negotiation, it would + * reject SETFORMAT with 'RSP ERR 1'. If the requested version is not + * supported by the transceiver, status code of the response message + * should indicate a preferred (basically, the latest) version. + */ +static int trx_ctrl_rx_rsp_setformat(struct trx_l1h *l1h, + struct trx_ctrl_rsp *rsp) +{ + /* Old transceivers reject 'SETFORMAT' with 'RSP ERR 1' */ + if (strcmp(rsp->cmd, "SETFORMAT") != 0) { + LOGPPHI(l1h->phy_inst, DTRX, LOGL_NOTICE, + "Transceiver rejected the format negotiation command, " + "using legacy TRXD header format version (0)\n"); + l1h->config.trxd_hdr_ver_use = 0; + return 0; + } + + /* Status shall indicate a proper version supported by the transceiver */ + if (rsp->status < 0 || rsp->status > l1h->config.trxd_hdr_ver_req) { + LOGPPHI(l1h->phy_inst, DTRX, LOGL_ERROR, + "Transceiver indicated an out of range " + "header format version %d (requested %u)\n", + rsp->status, l1h->config.trxd_hdr_ver_req); + return -EINVAL; + } + + /* Transceiver may suggest a lower version (than requested) */ + if (rsp->status == l1h->config.trxd_hdr_ver_req) { + l1h->config.trxd_hdr_ver_use = rsp->status; + LOGPPHI(l1h->phy_inst, DTRX, LOGL_INFO, + "Using TRXD header format version %u\n", + l1h->config.trxd_hdr_ver_use); + } else { + LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG, + "Transceiver suggests TRXD header version %u (requested %u)\n", + rsp->status, l1h->config.trxd_hdr_ver_req); + /* Send another SETFORMAT with suggested version */ + l1h->config.trxd_hdr_ver_req = rsp->status; + trx_if_cmd_setformat(l1h, rsp->status); + } + + return 0; +} + /* -EINVAL: unrecoverable error, exit BTS * N > 0: try sending originating command again after N seconds * 0: Done with response, get originating command out from send queue */ -static int trx_ctrl_rx_rsp(struct trx_l1h *l1h, struct trx_ctrl_rsp *rsp, bool critical) +static int trx_ctrl_rx_rsp(struct trx_l1h *l1h, + struct trx_ctrl_rsp *rsp, + struct trx_ctrl_msg *tcm) { struct phy_instance *pinst = l1h->phy_inst; @@ -484,14 +543,18 @@ } } else if (strcmp(rsp->cmd, "SETSLOT") == 0) { return trx_ctrl_rx_rsp_setslot(l1h, rsp); + /* We may get 'RSP ERR 1' if 'SETFORMAT' is not supported, + * so that's why we should use tcm instead of rsp. */ + } else if (strcmp(tcm->cmd, "SETFORMAT") == 0) { + return trx_ctrl_rx_rsp_setformat(l1h, rsp); } if (rsp->status) { - LOGPPHI(l1h->phy_inst, DTRX, critical ? LOGL_FATAL : LOGL_NOTICE, + LOGPPHI(l1h->phy_inst, DTRX, tcm->critical ? LOGL_FATAL : LOGL_NOTICE, "transceiver rejected TRX command with response: '%s%s%s %d'\n", rsp->cmd, rsp->params[0] != '\0' ? " ":"", rsp->params, rsp->status); - if (critical) + if (tcm->critical) return -EINVAL; } return 0; @@ -547,13 +610,16 @@ "Response message '%s' does not match command " "message 'CMD %s%s%s'\n", buf, tcm->cmd, tcm->params_len ? " ":"", tcm->params); - goto rsp_error; + + /* We may get 'RSP ERR 1' for non-critical commands */ + if (tcm->critical) + goto rsp_error; } rsp.cb = tcm->cb; /* check for response code */ - rc = trx_ctrl_rx_rsp(l1h, &rsp, tcm->critical); + rc = trx_ctrl_rx_rsp(l1h, &rsp, tcm); if (rc == -EINVAL) goto rsp_error; diff --git a/src/osmo-bts-trx/trx_if.h b/src/osmo-bts-trx/trx_if.h index cdfbd41..dda7116 100644 --- a/src/osmo-bts-trx/trx_if.h +++ b/src/osmo-bts-trx/trx_if.h @@ -35,4 +35,10 @@ const ubit_t *bits, uint16_t nbits); int trx_if_powered(struct trx_l1h *l1h); +/* The latest supported TRXD header format version */ +#define TRX_DATA_FORMAT_VER 1 + +/* Format negotiation command */ +int trx_if_cmd_setformat(struct trx_l1h *l1h, uint8_t ver); + #endif /* TRX_IF_H */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8afe950bd1ec2afaf3347ff848ee46e69c4f5011 Gerrit-Change-Number: 14611 Gerrit-PatchSet: 9 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: ipse Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:16:14 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:16:14 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/trx_if.c: encode actual TRXD header version In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14745 ) Change subject: osmo-bts-trx/trx_if.c: encode actual TRXD header version ...................................................................... osmo-bts-trx/trx_if.c: encode actual TRXD header version Both TRX2L1 (Uplink) and L12TRX (Downlink) messages should use the same TRXD header format (and version) as was negotiated. Change-Id: Idbc598ef7c1871ee8da830f3fbe0a5cc386f873d Related: OS#4006 --- M src/osmo-bts-trx/trx_if.c 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index 3e53fdb..b966bbe 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -1054,6 +1054,7 @@ int trx_if_send_burst(struct trx_l1h *l1h, uint8_t tn, uint32_t fn, uint8_t pwr, const ubit_t *bits, uint16_t nbits) { + uint8_t hdr_ver = l1h->config.trxd_hdr_ver_use; uint8_t buf[TRX_DATA_MSG_MAX_LEN]; if ((nbits != GSM_BURST_LEN) && (nbits != EGPRS_BURST_LEN)) { @@ -1061,9 +1062,23 @@ return -1; } - LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG, "TX burst tn=%u fn=%u pwr=%u\n", tn, fn, pwr); + LOGPPHI(l1h->phy_inst, DTRX, LOGL_DEBUG, + "Tx burst (hdr_ver=%u): tn=%u fn=%u pwr=%u\n", + hdr_ver, tn, fn, pwr); - buf[0] = tn; + switch (hdr_ver) { + case 0: + case 1: + /* Both versions have the same header format */ + break; + + default: + LOGPPHI(l1h->phy_inst, DTRX, LOGL_ERROR, + "Requested TRXD header version %u is not supported\n", hdr_ver); + return -ENOTSUP; + } + + buf[0] = ((hdr_ver & 0x0f) << 4) | tn; buf[1] = (fn >> 24) & 0xff; buf[2] = (fn >> 16) & 0xff; buf[3] = (fn >> 8) & 0xff; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14745 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idbc598ef7c1871ee8da830f3fbe0a5cc386f873d Gerrit-Change-Number: 14745 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:16:14 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:16:14 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14612 ) Change subject: osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers ...................................................................... osmo-bts-trx/scheduler: pass trx_ul_burst_ind to lchan handlers This change needs to be done in order avoid adding more and more arguments to the UL logical channel handlers (such as rx_rach_fn). Since we have different versions of the TRXD header, and may have other burst-based PHYs in the future, some fields of an Uplink burst indication have conditional presence. Change-Id: Iae6b78bafa4b86d0c681684de47320d641d3f7c0 Related: OS#4006, OS#1855 --- M include/osmo-bts/scheduler_backend.h M src/common/scheduler.c M src/osmo-bts-trx/scheduler_trx.c M src/osmo-bts-virtual/scheduler_virtbts.c 4 files changed, 191 insertions(+), 152 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmo-bts/scheduler_backend.h b/include/osmo-bts/scheduler_backend.h index 505f4d7..d713900 100644 --- a/include/osmo-bts/scheduler_backend.h +++ b/include/osmo-bts/scheduler_backend.h @@ -13,10 +13,8 @@ uint32_t fn, enum trx_chan_type chan, uint8_t bid, uint16_t *nbits); -typedef int trx_sched_ul_func(struct l1sched_trx *l1t, uint8_t tn, - uint32_t fn, enum trx_chan_type chan, - uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256); +typedef int trx_sched_ul_func(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi); struct trx_chan_desc { /*! \brief Human-readable name */ @@ -70,21 +68,16 @@ enum trx_chan_type chan, uint8_t bid, uint16_t *nbits); ubit_t *tx_tchh_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, enum trx_chan_type chan, uint8_t bid, uint16_t *nbits); -int rx_rach_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256); -int rx_data_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256); -int rx_pdtch_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256); -int rx_tchf_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256); -int rx_tchh_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256); +int rx_rach_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi); +int rx_data_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi); +int rx_pdtch_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi); +int rx_tchf_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi); +int rx_tchh_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi); const ubit_t *_sched_dl_burst(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, uint16_t *nbits); diff --git a/src/common/scheduler.c b/src/common/scheduler.c index 83779d7..95a1b00 100644 --- a/src/common/scheduler.c +++ b/src/common/scheduler.c @@ -1287,9 +1287,19 @@ * Instead of doing this, it makes sense to use the * amount of lost frames in measurement calculations. */ - static sbit_t zero_burst[GSM_BURST_LEN] = { 0 }; trx_sched_ul_func *func; + /* Prepare dummy burst indication */ + struct trx_ul_burst_ind bi = { + .flags = TRX_BI_F_NOPE_IND, + .burst_len = GSM_BURST_LEN, + .burst = { 0 }, + .rssi = -128, + .toa256 = 0, + /* TDMA FN is set below */ + .tn = tn, + }; + for (i = 1; i < elapsed_fs; i++) { fn_i = TDMA_FN_SUM(l1cs->last_tdma_fn, i); offset = fn_i % l1ts->mf_period; @@ -1303,8 +1313,8 @@ "Substituting lost TDMA frame=%u by all-zero " "dummy burst\n", fn_i); - func(l1t, tn, fn_i, frame->ul_chan, frame->ul_bid, - zero_burst, GSM_BURST_LEN, -128, 0); + bi.fn = fn_i; + func(l1t, frame->ul_chan, frame->ul_bid, &bi); l1cs->lost_tdma_fs--; } @@ -1365,9 +1375,8 @@ } } - /* put burst to function - * TODO: rather pass a pointer to trx_ul_burst_ind */ - func(l1t, bi->tn, bi->fn, chan, bid, bi->burst, bi->burst_len, bi->rssi, bi->toa256); + /* Invoke the logical channel handler */ + func(l1t, chan, bid, bi); return 0; } diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index ade3cff..294e73c 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -775,9 +775,8 @@ return seq; } -int rx_rach_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256) +int rx_rach_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi) { struct osmo_phsap_prim l1sap; int n_errors, n_bits_total; @@ -796,31 +795,33 @@ /* Handover RACH cannot be extended (11-bit) */ if (chan == TRXC_RACH) - synch_seq = rach_get_synch_seq(bits, &best_score); + /* TODO: check for TRX_BI_F_TS_INFO flag! */ + synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, &best_score); - LOGL1S(DL1P, LOGL_DEBUG, l1t, tn, chan, fn, + LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, "Received RACH (%s; match=%.1f%%) toa=%d\n", get_value_string(rach_synch_seq_names, synch_seq), best_score * 100.0 / (127 * RACH_SYNCH_SEQ_LEN), - toa256); + bi->toa256); /* Compose a new L1SAP primitive */ memset(&l1sap, 0x00, sizeof(l1sap)); osmo_prim_init(&l1sap.oph, SAP_GSM_PH, PRIM_PH_RACH, PRIM_OP_INDICATION, NULL); - l1sap.u.rach_ind.chan_nr = trx_chan_desc[chan].chan_nr | tn; - l1sap.u.rach_ind.acc_delay = (toa256 >= 0) ? toa256 / 256 : 0; - l1sap.u.rach_ind.acc_delay_256bits = toa256; - l1sap.u.rach_ind.rssi = rssi; - l1sap.u.rach_ind.fn = fn; + l1sap.u.rach_ind.chan_nr = trx_chan_desc[chan].chan_nr | bi->tn; + l1sap.u.rach_ind.acc_delay = (bi->toa256 >= 0) ? bi->toa256 / 256 : 0; + l1sap.u.rach_ind.acc_delay_256bits = bi->toa256; + l1sap.u.rach_ind.rssi = bi->rssi; + l1sap.u.rach_ind.fn = bi->fn; /* Decode RACH depending on its synch. sequence */ switch (synch_seq) { case RACH_SYNCH_SEQ_TS1: case RACH_SYNCH_SEQ_TS2: - rc = gsm0503_rach_ext_decode_ber(&ra11, bits + RACH_EXT_TAIL_LEN + RACH_SYNCH_SEQ_LEN, + rc = gsm0503_rach_ext_decode_ber(&ra11, bi->burst + RACH_EXT_TAIL_LEN + RACH_SYNCH_SEQ_LEN, l1t->trx->bts->bsic, &n_errors, &n_bits_total); if (rc) { - LOGL1S(DL1P, LOGL_DEBUG, l1t, tn, chan, fn, "Received bad Access Burst\n"); + LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, + "Received bad Access Burst\n"); return 0; } @@ -837,14 +838,16 @@ default: /* Fall-back to the default TS0 if needed */ if (synch_seq != RACH_SYNCH_SEQ_TS0) { - LOGL1S(DL1P, LOGL_DEBUG, l1t, tn, chan, fn, "Falling-back to the default TS0\n"); + LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, + "Falling-back to the default TS0\n"); synch_seq = RACH_SYNCH_SEQ_TS0; } - rc = gsm0503_rach_decode_ber(&ra, bits + RACH_EXT_TAIL_LEN + RACH_SYNCH_SEQ_LEN, + rc = gsm0503_rach_decode_ber(&ra, bi->burst + RACH_EXT_TAIL_LEN + RACH_SYNCH_SEQ_LEN, l1t->trx->bts->bsic, &n_errors, &n_bits_total); if (rc) { - LOGL1S(DL1P, LOGL_DEBUG, l1t, tn, chan, fn, "Received bad Access Burst\n"); + LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, + "Received bad Access Burst\n"); return 0; } @@ -863,11 +866,10 @@ } /*! \brief a single (SDCCH/SACCH) burst was received by the PHY, process it */ -int rx_data_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256) +int rx_data_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi) { - struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, tn); + struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, bi->tn); struct l1sched_chan_state *chan_state = &l1ts->chan_state[chan]; sbit_t *burst, **bursts_p = &chan_state->ul_bursts; uint32_t *first_fn = &chan_state->ul_first_fn; @@ -883,9 +885,10 @@ /* handle RACH, if handover RACH detection is turned on */ if (chan_state->ho_rach_detect == 1) - return rx_rach_fn(l1t, tn, fn, chan, bid, bits, GSM_BURST_LEN, rssi, toa256); + return rx_rach_fn(l1t, chan, bid, bi); - LOGL1S(DL1P, LOGL_DEBUG, l1t, tn, chan, fn, "Received Data, bid=%u\n", bid); + LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, + "Received Data, bid=%u\n", bid); /* allocate burst memory, if not already */ if (!*bursts_p) { @@ -898,7 +901,7 @@ if (bid == 0) { memset(*bursts_p, 0, 464); *mask = 0x0; - *first_fn = fn; + *first_fn = bi->fn; *rssi_sum = 0; *rssi_num = 0; *toa256_sum = 0; @@ -907,20 +910,20 @@ /* update mask + RSSI */ *mask |= (1 << bid); - *rssi_sum += rssi; + *rssi_sum += bi->rssi; (*rssi_num)++; - *toa256_sum += toa256; + *toa256_sum += bi->toa256; (*toa_num)++; /* copy burst to buffer of 4 bursts */ burst = *bursts_p + bid * 116; - memcpy(burst, bits + 3, 58); - memcpy(burst + 58, bits + 87, 58); + memcpy(burst, bi->burst + 3, 58); + memcpy(burst + 58, bi->burst + 87, 58); /* send burst information to loops process */ if (L1SAP_IS_LINK_SACCH(trx_chan_desc[chan].link_id)) { - trx_loop_sacch_input(l1t, trx_chan_desc[chan].chan_nr | tn, - chan_state, rssi, toa256); + trx_loop_sacch_input(l1t, trx_chan_desc[chan].chan_nr | bi->tn, + chan_state, bi->rssi, bi->toa256); } /* wait until complete set of bursts */ @@ -929,7 +932,8 @@ /* check for complete set of bursts */ if ((*mask & 0xf) != 0xf) { - LOGL1S(DL1P, LOGL_NOTICE, l1t, tn, chan, fn, "Received incomplete data (%u/%u)\n", + LOGL1S(DL1P, LOGL_NOTICE, l1t, bi->tn, chan, bi->fn, + "Received incomplete data (%u/%u)\n", *first_fn, (*first_fn) % l1ts->mf_period); /* we require first burst to have correct FN */ @@ -943,28 +947,33 @@ /* decode */ rc = gsm0503_xcch_decode(l2, *bursts_p, &n_errors, &n_bits_total); if (rc) { - LOGL1S(DL1P, LOGL_NOTICE, l1t, tn, chan, fn, "Received bad data (%u/%u)\n", + LOGL1S(DL1P, LOGL_NOTICE, l1t, bi->tn, chan, bi->fn, + "Received bad data (%u/%u)\n", *first_fn, (*first_fn) % l1ts->mf_period); l2_len = 0; } else l2_len = GSM_MACBLOCK_LEN; /* Send uplink measurement information to L2 */ - l1if_process_meas_res(l1t->trx, tn, *first_fn, trx_chan_desc[chan].chan_nr | tn, - n_errors, n_bits_total, *rssi_sum / *rssi_num, *toa256_sum / *toa_num); + l1if_process_meas_res(l1t->trx, bi->tn, *first_fn, + trx_chan_desc[chan].chan_nr | bi->tn, + n_errors, n_bits_total, + *rssi_sum / *rssi_num, + *toa256_sum / *toa_num); ber10k = compute_ber10k(n_bits_total, n_errors); - return _sched_compose_ph_data_ind(l1t, tn, *first_fn, chan, l2, l2_len, + return _sched_compose_ph_data_ind(l1t, bi->tn, *first_fn, + chan, l2, l2_len, *rssi_sum / *rssi_num, - *toa256_sum / *toa_num, 0, ber10k, - PRES_INFO_UNKNOWN); + *toa256_sum / *toa_num, + 0 /* FIXME: AVG C/I */, + ber10k, PRES_INFO_UNKNOWN); } /*! \brief a single PDTCH burst was received by the PHY, process it */ -int rx_pdtch_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256) +int rx_pdtch_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi) { - struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, tn); + struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, bi->tn); struct l1sched_chan_state *chan_state = &l1ts->chan_state[chan]; sbit_t *burst, **bursts_p = &chan_state->ul_bursts; uint32_t *first_fn = &chan_state->ul_first_fn; @@ -978,7 +987,8 @@ uint16_t ber10k; int rc; - LOGL1S(DL1P, LOGL_DEBUG, l1t, tn, chan, fn, "Received PDTCH bid=%u\n", bid); + LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, + "Received PDTCH bid=%u\n", bid); /* allocate burst memory, if not already */ if (!*bursts_p) { @@ -992,7 +1002,7 @@ if (bid == 0) { memset(*bursts_p, 0, GSM0503_EGPRS_BURSTS_NBITS); *mask = 0x0; - *first_fn = fn; + *first_fn = bi->fn; *rssi_sum = 0; *rssi_num = 0; *toa256_sum = 0; @@ -1001,21 +1011,21 @@ /* update mask + rssi */ *mask |= (1 << bid); - *rssi_sum += rssi; + *rssi_sum += bi->rssi; (*rssi_num)++; - *toa256_sum += toa256; + *toa256_sum += bi->toa256; (*toa_num)++; /* copy burst to buffer of 4 bursts */ - if (nbits == EGPRS_BURST_LEN) { + if (bi->burst_len == EGPRS_BURST_LEN) { burst = *bursts_p + bid * 348; - memcpy(burst, bits + 9, 174); - memcpy(burst + 174, bits + 261, 174); + memcpy(burst, bi->burst + 9, 174); + memcpy(burst + 174, bi->burst + 261, 174); n_bursts_bits = GSM0503_EGPRS_BURSTS_NBITS; } else { burst = *bursts_p + bid * 116; - memcpy(burst, bits + 3, 58); - memcpy(burst + 58, bits + 87, 58); + memcpy(burst, bi->burst + 3, 58); + memcpy(burst + 58, bi->burst + 87, 58); n_bursts_bits = GSM0503_GPRS_BURSTS_NBITS; } @@ -1025,8 +1035,9 @@ /* check for complete set of bursts */ if ((*mask & 0xf) != 0xf) { - LOGL1S(DL1P, LOGL_DEBUG, l1t, tn, chan, fn, "Received incomplete frame (%u/%u)\n", - fn % l1ts->mf_period, l1ts->mf_period); + LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, + "Received incomplete frame (%u/%u)\n", + bi->fn % l1ts->mf_period, l1ts->mf_period); } *mask = 0x0; @@ -1039,33 +1050,39 @@ rc = gsm0503_pdtch_egprs_decode(l2, *bursts_p, n_bursts_bits, NULL, &n_errors, &n_bits_total); - if ((nbits == GSM_BURST_LEN) && (rc < 0)) { + if ((bi->burst_len == GSM_BURST_LEN) && (rc < 0)) { rc = gsm0503_pdtch_decode(l2, *bursts_p, NULL, &n_errors, &n_bits_total); } /* Send uplink measurement information to L2 */ - l1if_process_meas_res(l1t->trx, tn, *first_fn, trx_chan_desc[chan].chan_nr | tn, - n_errors, n_bits_total, *rssi_sum / *rssi_num, *toa256_sum / *toa_num); + l1if_process_meas_res(l1t->trx, bi->tn, *first_fn, + trx_chan_desc[chan].chan_nr | bi->tn, + n_errors, n_bits_total, + *rssi_sum / *rssi_num, + *toa256_sum / *toa_num); if (rc <= 0) { - LOGL1S(DL1P, LOGL_DEBUG, l1t, tn, chan, fn, "Received bad PDTCH (%u/%u)\n", - fn % l1ts->mf_period, l1ts->mf_period); + LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, + "Received bad PDTCH (%u/%u)\n", + bi->fn % l1ts->mf_period, l1ts->mf_period); return 0; } ber10k = compute_ber10k(n_bits_total, n_errors); - return _sched_compose_ph_data_ind(l1t, tn, *first_fn, chan, - l2, rc, *rssi_sum / *rssi_num, *toa256_sum / *toa_num, 0, + return _sched_compose_ph_data_ind(l1t, bi->tn, + *first_fn, chan, l2, rc, + *rssi_sum / *rssi_num, + *toa256_sum / *toa_num, + 0 /* FIXME: AVG C/I */, ber10k, PRES_INFO_BOTH); } /*! \brief a single TCH/F burst was received by the PHY, process it */ -int rx_tchf_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256) +int rx_tchf_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi) { - struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, tn); + struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, bi->tn); struct l1sched_chan_state *chan_state = &l1ts->chan_state[chan]; sbit_t *burst, **bursts_p = &chan_state->ul_bursts; uint32_t *first_fn = &chan_state->ul_first_fn; @@ -1077,13 +1094,14 @@ int n_errors, n_bits_total; bool bfi_flag = false; struct gsm_lchan *lchan = - get_lchan_by_chan_nr(l1t->trx, trx_chan_desc[chan].chan_nr | tn); + get_lchan_by_chan_nr(l1t->trx, trx_chan_desc[chan].chan_nr | bi->tn); /* handle rach, if handover rach detection is turned on */ if (chan_state->ho_rach_detect == 1) - return rx_rach_fn(l1t, tn, fn, chan, bid, bits, GSM_BURST_LEN, rssi, toa256); + return rx_rach_fn(l1t, chan, bid, bi); - LOGL1S(DL1P, LOGL_DEBUG, l1t, tn, chan, fn, "Received TCH/F, bid=%u\n", bid); + LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, + "Received TCH/F, bid=%u\n", bid); /* allocate burst memory, if not already */ if (!*bursts_p) { @@ -1096,7 +1114,7 @@ if (bid == 0) { memset(*bursts_p + 464, 0, 464); *mask = 0x0; - *first_fn = fn; + *first_fn = bi->fn; } /* update mask */ @@ -1104,8 +1122,8 @@ /* copy burst to end of buffer of 8 bursts */ burst = *bursts_p + bid * 116 + 464; - memcpy(burst, bits + 3, 58); - memcpy(burst + 58, bits + 87, 58); + memcpy(burst, bi->burst + 3, 58); + memcpy(burst + 58, bi->burst + 87, 58); /* wait until complete set of bursts */ if (bid != 3) @@ -1113,8 +1131,9 @@ /* check for complete set of bursts */ if ((*mask & 0xf) != 0xf) { - LOGL1S(DL1P, LOGL_NOTICE, l1t, tn, chan, fn, "Received incomplete frame (%u/%u)\n", - fn % l1ts->mf_period, l1ts->mf_period); + LOGL1S(DL1P, LOGL_NOTICE, l1t, bi->tn, chan, bi->fn, + "Received incomplete frame (%u/%u)\n", + bi->fn % l1ts->mf_period, l1ts->mf_period); } *mask = 0x0; @@ -1136,12 +1155,12 @@ * NOTE: A frame ends 7 FN after start. */ rc = gsm0503_tch_afs_decode(tch_data + 2, *bursts_p, - (((fn + 26 - 7) % 26) >> 2) & 1, chan_state->codec, + (((bi->fn + 26 - 7) % 26) >> 2) & 1, chan_state->codec, chan_state->codecs, &chan_state->ul_ft, &chan_state->ul_cmr, &n_errors, &n_bits_total); if (rc) trx_loop_amr_input(l1t, - trx_chan_desc[chan].chan_nr | tn, chan_state, + trx_chan_desc[chan].chan_nr | bi->tn, chan_state, (float)n_errors/(float)n_bits_total); amr = 2; /* we store tch_data + 2 header bytes */ /* only good speech frames get rtp header */ @@ -1152,26 +1171,31 @@ } break; default: - LOGL1S(DL1P, LOGL_ERROR, l1t, tn, chan, fn, "TCH mode %u invalid, please fix!\n", + LOGL1S(DL1P, LOGL_ERROR, l1t, bi->tn, chan, bi->fn, + "TCH mode %u invalid, please fix!\n", tch_mode); return -EINVAL; } memcpy(*bursts_p, *bursts_p + 464, 464); /* Send uplink measurement information to L2 */ - l1if_process_meas_res(l1t->trx, tn, *first_fn, trx_chan_desc[chan].chan_nr|tn, - n_errors, n_bits_total, rssi, toa256); + l1if_process_meas_res(l1t->trx, bi->tn, *first_fn, + trx_chan_desc[chan].chan_nr | bi->tn, + n_errors, n_bits_total, + bi->rssi, bi->toa256); /* Check if the frame is bad */ if (rc < 0) { - LOGL1S(DL1P, LOGL_NOTICE, l1t, tn, chan, fn, "Received bad data (%u/%u)\n", - fn % l1ts->mf_period, l1ts->mf_period); + LOGL1S(DL1P, LOGL_NOTICE, l1t, bi->tn, chan, bi->fn, + "Received bad data (%u/%u)\n", + bi->fn % l1ts->mf_period, l1ts->mf_period); bfi_flag = true; goto bfi; } if (rc < 4) { - LOGL1S(DL1P, LOGL_NOTICE, l1t, tn, chan, fn, "Received bad data (%u/%u) " - "with invalid codec mode %d\n", fn % l1ts->mf_period, l1ts->mf_period, rc); + LOGL1S(DL1P, LOGL_NOTICE, l1t, bi->tn, chan, bi->fn, + "Received bad data (%u/%u) with invalid codec mode %d\n", + bi->fn % l1ts->mf_period, l1ts->mf_period, rc); bfi_flag = true; goto bfi; } @@ -1179,9 +1203,14 @@ /* FACCH */ if (rc == GSM_MACBLOCK_LEN) { uint16_t ber10k = compute_ber10k(n_bits_total, n_errors); - _sched_compose_ph_data_ind(l1t, tn, (fn + GSM_HYPERFRAME - 7) % GSM_HYPERFRAME, chan, - tch_data + amr, GSM_MACBLOCK_LEN, rssi, toa256, 0, - ber10k, PRES_INFO_UNKNOWN); + _sched_compose_ph_data_ind(l1t, bi->tn, + /* FIXME: this calculation is wrong */ + (bi->fn + GSM_HYPERFRAME - 7) % GSM_HYPERFRAME, chan, + tch_data + amr, GSM_MACBLOCK_LEN, + /* FIXME: AVG RSSI and ToA256 */ + bi->rssi, bi->toa256, + 0 /* FIXME: AVG C/I */, + ber10k, PRES_INFO_UNKNOWN); bfi: if (rsl_cmode == RSL_CMOD_SPD_SPEECH) { /* indicate bad frame */ @@ -1217,7 +1246,7 @@ memset(tch_data + 2, 0, rc - 2); break; default: - LOGL1S(DL1P, LOGL_ERROR, l1t, tn, chan, fn, + LOGL1S(DL1P, LOGL_ERROR, l1t, bi->tn, chan, bi->fn, "TCH mode %u invalid, please fix!\n", tch_mode); return -EINVAL; } @@ -1233,16 +1262,17 @@ /* TCH or BFI */ compose_l1sap: - return _sched_compose_tch_ind(l1t, tn, (fn + GSM_HYPERFRAME - 7) % GSM_HYPERFRAME, chan, + return _sched_compose_tch_ind(l1t, bi->tn, + /* FIXME: this calculation is wrong */ + (bi->fn + GSM_HYPERFRAME - 7) % GSM_HYPERFRAME, chan, tch_data, rc); } /*! \brief a single TCH/H burst was received by the PHY, process it */ -int rx_tchh_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256) +int rx_tchh_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi) { - struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, tn); + struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, bi->tn); struct l1sched_chan_state *chan_state = &l1ts->chan_state[chan]; sbit_t *burst, **bursts_p = &chan_state->ul_bursts; uint32_t *first_fn = &chan_state->ul_first_fn; @@ -1253,18 +1283,19 @@ int rc, amr = 0; int n_errors, n_bits_total; struct gsm_lchan *lchan = - get_lchan_by_chan_nr(l1t->trx, trx_chan_desc[chan].chan_nr | tn); + get_lchan_by_chan_nr(l1t->trx, trx_chan_desc[chan].chan_nr | bi->tn); /* Note on FN-10: If we are at FN 10, we decoded an even aligned * TCH/FACCH frame, because our burst buffer carries 6 bursts. * Even FN ending at: 10,11,19,20,2,3 */ - int fn_is_odd = (((fn + 26 - 10) % 26) >> 2) & 1; + int fn_is_odd = (((bi->fn + 26 - 10) % 26) >> 2) & 1; /* handle RACH, if handover RACH detection is turned on */ if (chan_state->ho_rach_detect == 1) - return rx_rach_fn(l1t, tn, fn, chan, bid, bits, GSM_BURST_LEN, rssi, toa256); + return rx_rach_fn(l1t, chan, bid, bi); - LOGL1S(DL1P, LOGL_DEBUG, l1t, tn, chan, fn, "Received TCH/H, bid=%u\n", bid); + LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, + "Received TCH/H, bid=%u\n", bid); /* allocate burst memory, if not already */ if (!*bursts_p) { @@ -1277,7 +1308,7 @@ if (bid == 0) { memset(*bursts_p + 464, 0, 232); *mask = 0x0; - *first_fn = fn; + *first_fn = bi->fn; } /* update mask */ @@ -1285,8 +1316,8 @@ /* copy burst to end of buffer of 6 bursts */ burst = *bursts_p + bid * 116 + 464; - memcpy(burst, bits + 3, 58); - memcpy(burst + 58, bits + 87, 58); + memcpy(burst, bi->burst + 3, 58); + memcpy(burst + 58, bi->burst + 87, 58); /* wait until complete set of bursts */ if (bid != 1) @@ -1294,8 +1325,9 @@ /* check for complete set of bursts */ if ((*mask & 0x3) != 0x3) { - LOGL1S(DL1P, LOGL_NOTICE, l1t, tn, chan, fn, "Received incomplete frame (%u/%u)\n", - fn % l1ts->mf_period, l1ts->mf_period); + LOGL1S(DL1P, LOGL_NOTICE, l1t, bi->tn, chan, bi->fn, + "Received incomplete frame (%u/%u)\n", + bi->fn % l1ts->mf_period, l1ts->mf_period); } *mask = 0x0; @@ -1332,7 +1364,7 @@ &chan_state->ul_cmr, &n_errors, &n_bits_total); if (rc) trx_loop_amr_input(l1t, - trx_chan_desc[chan].chan_nr | tn, chan_state, + trx_chan_desc[chan].chan_nr | bi->tn, chan_state, (float)n_errors/(float)n_bits_total); amr = 2; /* we store tch_data + 2 two */ /* only good speech frames get rtp header */ @@ -1343,7 +1375,8 @@ } break; default: - LOGL1S(DL1P, LOGL_ERROR, l1t, tn, chan, fn, "TCH mode %u invalid, please fix!\n", + LOGL1S(DL1P, LOGL_ERROR, l1t, bi->tn, chan, bi->fn, + "TCH mode %u invalid, please fix!\n", tch_mode); return -EINVAL; } @@ -1351,18 +1384,22 @@ memcpy(*bursts_p + 232, *bursts_p + 464, 232); /* Send uplink measurement information to L2 */ - l1if_process_meas_res(l1t->trx, tn, *first_fn, trx_chan_desc[chan].chan_nr|tn, - n_errors, n_bits_total, rssi, toa256); + l1if_process_meas_res(l1t->trx, bi->tn, + *first_fn /* FIXME: this is wrong */, + trx_chan_desc[chan].chan_nr | bi->tn, + n_errors, n_bits_total, bi->rssi, bi->toa256); /* Check if the frame is bad */ if (rc < 0) { - LOGL1S(DL1P, LOGL_NOTICE, l1t, tn, chan, fn, "Received bad data (%u/%u)\n", - fn % l1ts->mf_period, l1ts->mf_period); + LOGL1S(DL1P, LOGL_NOTICE, l1t, bi->tn, chan, bi->fn, + "Received bad data (%u/%u)\n", + bi->fn % l1ts->mf_period, l1ts->mf_period); goto bfi; } if (rc < 4) { - LOGL1S(DL1P, LOGL_NOTICE, l1t, tn, chan, fn, "Received bad data (%u/%u) " - "with invalid codec mode %d\n", fn % l1ts->mf_period, l1ts->mf_period, rc); + LOGL1S(DL1P, LOGL_NOTICE, l1t, bi->tn, chan, bi->fn, + "Received bad data (%u/%u) with invalid codec mode %d\n", + bi->fn % l1ts->mf_period, l1ts->mf_period, rc); goto bfi; } @@ -1370,10 +1407,14 @@ if (rc == GSM_MACBLOCK_LEN) { chan_state->ul_ongoing_facch = 1; uint16_t ber10k = compute_ber10k(n_bits_total, n_errors); - _sched_compose_ph_data_ind(l1t, tn, - (fn + GSM_HYPERFRAME - 10 - ((fn % 26) >= 19)) % GSM_HYPERFRAME, chan, - tch_data + amr, GSM_MACBLOCK_LEN, rssi, toa256, 0, - ber10k, PRES_INFO_UNKNOWN); + _sched_compose_ph_data_ind(l1t, bi->tn, + /* FIXME: what the hell is this?!? */ + (bi->fn + GSM_HYPERFRAME - 10 - ((bi->fn % 26) >= 19)) % GSM_HYPERFRAME, chan, + tch_data + amr, GSM_MACBLOCK_LEN, + /* FIXME: AVG both RSSI and ToA */ + bi->rssi, bi->toa256, + 0 /* FIXME: AVG C/I */, + ber10k, PRES_INFO_UNKNOWN); bfi: if (rsl_cmode == RSL_CMOD_SPD_SPEECH) { /* indicate bad frame */ @@ -1398,7 +1439,7 @@ memset(tch_data + 2, 0, rc - 2); break; default: - LOGL1S(DL1P, LOGL_ERROR, l1t, tn, chan, fn, + LOGL1S(DL1P, LOGL_ERROR, l1t, bi->tn, chan, bi->fn, "TCH mode %u invalid, please fix!\n", tch_mode); return -EINVAL; } @@ -1415,8 +1456,9 @@ * with the slot 12, so an extra FN must be subtracted to get correct * start of frame. */ - return _sched_compose_tch_ind(l1t, tn, - (fn + GSM_HYPERFRAME - 10 - ((fn%26)==19) - ((fn%26)==20)) % GSM_HYPERFRAME, + return _sched_compose_tch_ind(l1t, bi->tn, + /* FIXME: what the hell is this?!? */ + (bi->fn + GSM_HYPERFRAME - 10 - ((bi->fn%26)==19) - ((bi->fn%26)==20)) % GSM_HYPERFRAME, chan, tch_data, rc); } diff --git a/src/osmo-bts-virtual/scheduler_virtbts.c b/src/osmo-bts-virtual/scheduler_virtbts.c index 25f6583..259a573 100644 --- a/src/osmo-bts-virtual/scheduler_virtbts.c +++ b/src/osmo-bts-virtual/scheduler_virtbts.c @@ -479,38 +479,33 @@ * directly into the L1SAP, bypassing the TDMA multiplex logic oriented * towards receiving bursts */ -int rx_rach_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256) +int rx_rach_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi) { return 0; } /*! \brief a single burst was received by the PHY, process it */ -int rx_data_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256) +int rx_data_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi) { return 0; } -int rx_pdtch_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256) +int rx_pdtch_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi) { return 0; } -int rx_tchf_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256) +int rx_tchf_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi) { return 0; } -int rx_tchh_fn(struct l1sched_trx *l1t, uint8_t tn, uint32_t fn, - enum trx_chan_type chan, uint8_t bid, sbit_t *bits, uint16_t nbits, - int8_t rssi, int16_t toa256) +int rx_tchh_fn(struct l1sched_trx *l1t, enum trx_chan_type chan, + uint8_t bid, const struct trx_ul_burst_ind *bi) { return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iae6b78bafa4b86d0c681684de47320d641d3f7c0 Gerrit-Change-Number: 14612 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:16:15 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:16:15 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts/scheduler: provide actual C/I values to OsmoPCU In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14613 ) Change subject: osmo-bts/scheduler: provide actual C/I values to OsmoPCU ...................................................................... osmo-bts/scheduler: provide actual C/I values to OsmoPCU C/I (Carrier-to-Interference ratio) is a value in cB (centiBels), computed from the training sequence of each received burst, by comparing the "ideal" training sequence with the actual one. So far, there was no way to expose more measurements from OsmoTRX, excluding both RSSI and ToA. Since the new version of TRXD header, we can receive C/I indications and send the averaged (per 4 bursts) values to OsmoPCU (as a part of PCUIF_DATA.ind). Please note that we also need to attach C/I measurements to the following L1SAP primitives: - PRIM_PH_RACH.ind, - PRIM_PH_DATA.ind, - PRIM_TCH.ind, but this will be done in the follow up changes. Change-Id: Ia58043bd2381a4d34d604522e02899ae64ee0d26 Fixes: OS#1855 --- M include/osmo-bts/scheduler.h M src/osmo-bts-trx/scheduler_trx.c 2 files changed, 18 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmo-bts/scheduler.h b/include/osmo-bts/scheduler.h index 4f40636..e693e3e 100644 --- a/include/osmo-bts/scheduler.h +++ b/include/osmo-bts/scheduler.h @@ -79,11 +79,13 @@ uint32_t ul_first_fn; /* fn of first burst */ uint8_t ul_mask; /* mask of received bursts */ - /* RSSI / TOA */ + /* measurements */ uint8_t rssi_num; /* number of RSSI values */ float rssi_sum; /* sum of RSSI values */ uint8_t toa_num; /* number of TOA values */ int32_t toa256_sum; /* sum of TOA values (1/256 symbol) */ + uint8_t ci_cb_num; /* number of C/I values */ + int32_t ci_cb_sum; /* sum of C/I values (in centiBels) */ /* loss detection */ uint8_t lost_frames; /* how many L2 frames were lost */ diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 294e73c..7bdbc4f 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -982,8 +982,11 @@ uint8_t *rssi_num = &chan_state->rssi_num; int32_t *toa256_sum = &chan_state->toa256_sum; uint8_t *toa_num = &chan_state->toa_num; + int32_t *ci_cb_sum = &chan_state->ci_cb_sum; + uint8_t *ci_cb_num = &chan_state->ci_cb_num; uint8_t l2[EGPRS_0503_MAX_BYTES]; int n_errors, n_bursts_bits, n_bits_total; + int16_t lqual_cb; uint16_t ber10k; int rc; @@ -1007,6 +1010,8 @@ *rssi_num = 0; *toa256_sum = 0; *toa_num = 0; + *ci_cb_sum = 0; + *ci_cb_num = 0; } /* update mask + rssi */ @@ -1016,6 +1021,12 @@ *toa256_sum += bi->toa256; (*toa_num)++; + /* C/I: Carrier-to-Interference ratio (in centiBels) */ + if (bi->flags & TRX_BI_F_CI_CB) { + *ci_cb_sum += bi->ci_cb; + (*ci_cb_num)++; + } + /* copy burst to buffer of 4 bursts */ if (bi->burst_len == EGPRS_BURST_LEN) { burst = *bursts_p + bid * 348; @@ -1069,13 +1080,15 @@ bi->fn % l1ts->mf_period, l1ts->mf_period); return 0; } + + lqual_cb = *ci_cb_num ? (*ci_cb_sum / *ci_cb_num) : 0; ber10k = compute_ber10k(n_bits_total, n_errors); return _sched_compose_ph_data_ind(l1t, bi->tn, *first_fn, chan, l2, rc, *rssi_sum / *rssi_num, *toa256_sum / *toa_num, - 0 /* FIXME: AVG C/I */, - ber10k, PRES_INFO_BOTH); + lqual_cb, ber10k, + PRES_INFO_BOTH); } /*! \brief a single TCH/F burst was received by the PHY, process it */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia58043bd2381a4d34d604522e02899ae64ee0d26 Gerrit-Change-Number: 14613 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:16:15 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:16:15 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14684 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX ...................................................................... osmo-bts-trx/scheduler: rx_rach_fn(): use optional TSC info from TRX TSC (Training Sequence Code) is an optional parameter of the UL burst indication. We need this information in order to decide whether an Access Burst is 11-bit encoded or not (see OS#1854). If this information is absent, we try to correlate the received synch. sequence with the known ones (3GPP TS 05.02, section 5.2.7), and fall-back to the default TS0 if it fails. Since the new TRXD header version, the training sequence code is indicated by the transceiver. Let's use it! Change-Id: I1e654a2e49cb83c5f1e6249c0de688f99bc466b0 Related: OS#1854, OS#4006 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 12 insertions(+), 9 deletions(-) Approvals: laforge: Looks good to me, approved ipse: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 7bdbc4f..00d7bbb 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -784,19 +784,22 @@ uint8_t ra; int rc; - /* It would be great if the transceiver were doing some kind of tagging, - * whether it is extended (11-bit) RACH or not. We would not need to guess - * it here. For now, let's try to correlate the synch. sequence of a received - * Access Burst with the known ones (3GPP TS 05.02, section 5.2.7), and - * fall-back to the default TS0 if it fails. This would save some CPU - * power, and what is more important - prevent possible collisions. */ + /* TSC (Training Sequence Code) is an optional parameter of the UL burst + * indication. We need this information in order to decide whether an + * Access Burst is 11-bit encoded or not (see OS#1854). If this information + * is absent, we try to correlate the received synch. sequence with the + * known ones (3GPP TS 05.02, section 5.2.7), and fall-back to the default + * TS0 if it fails. */ enum rach_synch_seq_t synch_seq = RACH_SYNCH_SEQ_TS0; int best_score = 127 * RACH_SYNCH_SEQ_LEN; /* Handover RACH cannot be extended (11-bit) */ - if (chan == TRXC_RACH) - /* TODO: check for TRX_BI_F_TS_INFO flag! */ - synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, &best_score); + if (chan == TRXC_RACH) { + if (bi->flags & TRX_BI_F_TS_INFO) + synch_seq = (enum rach_synch_seq_t) bi->tsc; + else + synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, &best_score); + } LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, "Received RACH (%s; match=%.1f%%) toa=%d\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14684 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1e654a2e49cb83c5f1e6249c0de688f99bc466b0 Gerrit-Change-Number: 14684 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:16:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:16:16 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): clarify handover RACH handling In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14746 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): clarify handover RACH handling ...................................................................... osmo-bts-trx/scheduler: rx_rach_fn(): clarify handover RACH handling Change-Id: I3da39d48052af1759297f4ad75c220b3046c0691 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 00d7bbb..cd3dbf4 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -793,7 +793,8 @@ enum rach_synch_seq_t synch_seq = RACH_SYNCH_SEQ_TS0; int best_score = 127 * RACH_SYNCH_SEQ_LEN; - /* Handover RACH cannot be extended (11-bit) */ + /* If chan != TRXC_RACH, this is a handover RACH, which is always encoded + * as 8-bit and should contain the generic training sequence (TS0). */ if (chan == TRXC_RACH) { if (bi->flags & TRX_BI_F_TS_INFO) synch_seq = (enum rach_synch_seq_t) bi->tsc; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14746 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3da39d48052af1759297f4ad75c220b3046c0691 Gerrit-Change-Number: 14746 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:16:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:16:16 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14685 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message ...................................................................... osmo-bts-trx/scheduler: rx_rach_fn(): enrich debug message Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 9 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve ipse: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index cd3dbf4..79e42e1 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -803,10 +803,16 @@ } LOGL1S(DL1P, LOGL_DEBUG, l1t, bi->tn, chan, bi->fn, - "Received RACH (%s; match=%.1f%%) toa=%d\n", + "Received%s RACH (%s): rssi=%d toa256=%d", + (chan != TRXC_RACH) ? " handover" : "", get_value_string(rach_synch_seq_names, synch_seq), - best_score * 100.0 / (127 * RACH_SYNCH_SEQ_LEN), - bi->toa256); + bi->rssi, bi->toa256); + if (bi->flags & TRX_BI_F_CI_CB) + LOGPC(DL1P, LOGL_DEBUG, " C/I=%d cB", bi->ci_cb); + else + LOGPC(DL1P, LOGL_DEBUG, " match=%.1f%%", + best_score * 100.0 / (127 * RACH_SYNCH_SEQ_LEN)); + LOGPC(DL1P, LOGL_DEBUG, "\n"); /* Compose a new L1SAP primitive */ memset(&l1sap, 0x00, sizeof(l1sap)); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 Gerrit-Change-Number: 14685 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:16:53 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:16:53 +0000 Subject: Change in ...libusrp[master]: firmware/src/usrp2/Makefile.am: fix "distcheck" In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libusrp/+/14750 ) Change subject: firmware/src/usrp2/Makefile.am: fix "distcheck" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/14750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: I5f1b1f5ad72112ba7212800da7f85846bb6e7187 Gerrit-Change-Number: 14750 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Jul 2019 04:16:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:16:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:16:56 +0000 Subject: Change in ...libusrp[master]: firmware/src/usrp2/Makefile.am: fix "distcheck" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libusrp/+/14750 ) Change subject: firmware/src/usrp2/Makefile.am: fix "distcheck" ...................................................................... firmware/src/usrp2/Makefile.am: fix "distcheck" Properly remove lk files to fix the following error during "make distcheck". ERROR: files left in build directory after distclean: ./firmware/src/usrp2/eeprom_boot.lk ./firmware/src/usrp2/std.lk Change-Id: I5f1b1f5ad72112ba7212800da7f85846bb6e7187 --- M firmware/src/usrp2/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/src/usrp2/Makefile.am b/firmware/src/usrp2/Makefile.am index 6d44320..52492dc 100644 --- a/firmware/src/usrp2/Makefile.am +++ b/firmware/src/usrp2/Makefile.am @@ -146,7 +146,7 @@ $(XCC) $(LINKOPTS) -o $@ $(USRP_OBJS) CLEANFILES = \ - *.ihx *.lnk *.lst *.map *.mem *.rel *.rst *.sym *.asm *.lib \ + *.ihx *.lnk *.lst *.map *.mem *.rel *.rst *.sym *.asm *.lib *.lk \ usrp_gpif.c usrp_gpif_inline.h \ burn-usrp2-eeprom \ burn-usrp4-eeprom -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/14750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: I5f1b1f5ad72112ba7212800da7f85846bb6e7187 Gerrit-Change-Number: 14750 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:17:06 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:17:06 +0000 Subject: Change in ...libusrp[master]: contrib/jenkins.sh: run "make {distcheck, maintainer-clean}" In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libusrp/+/14722 ) Change subject: contrib/jenkins.sh: run "make {distcheck,maintainer-clean}" ...................................................................... contrib/jenkins.sh: run "make {distcheck,maintainer-clean}" Related: OS#3047 Change-Id: Ic277f37413cb338f4f9bdf4c5fc033d94a2cd5db --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 57da9fa..d75beda 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -5,3 +5,5 @@ autoreconf --install --force ./configure $MAKE $PARALLEL_MAKE +$MAKE distcheck +$MAKE maintainer-clean -- To view, visit https://gerrit.osmocom.org/c/libusrp/+/14722 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libusrp Gerrit-Branch: master Gerrit-Change-Id: Ic277f37413cb338f4f9bdf4c5fc033d94a2cd5db Gerrit-Change-Number: 14722 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:17:20 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:17:20 +0000 Subject: Change in ...osmo-ci[master]: gerrit-verifications: add libtelnet In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14751 ) Change subject: gerrit-verifications: add libtelnet ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14751 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iafffd9d938ee310bb729b3e2a0a4d80870d4b3b5 Gerrit-Change-Number: 14751 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 04:17:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:17:26 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:17:26 +0000 Subject: Change in ...osmo-ci[master]: gerrit-verifications: add libtelnet In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14751 ) Change subject: gerrit-verifications: add libtelnet ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14751 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iafffd9d938ee310bb729b3e2a0a4d80870d4b3b5 Gerrit-Change-Number: 14751 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 04:17:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:17:28 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:17:28 +0000 Subject: Change in ...osmo-ci[master]: gerrit-verifications: add libtelnet In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/14751 ) Change subject: gerrit-verifications: add libtelnet ...................................................................... gerrit-verifications: add libtelnet Related: OS#3047 Change-Id: Iafffd9d938ee310bb729b3e2a0a4d80870d4b3b5 --- M jobs/gerrit-verifications.yml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index fd9fec3..a696d86 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -55,6 +55,7 @@ cmd: './contrib/jenkins_arch.sh "$arch"' - libsmpp34 + - libtelnet - libusrp - openbsc: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14751 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iafffd9d938ee310bb729b3e2a0a4d80870d4b3b5 Gerrit-Change-Number: 14751 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:19:19 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:19:19 +0000 Subject: Change in ...osmo-pcu[master]: Use libosmocore for IMSI parsing In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/13395 ) Change subject: Use libosmocore for IMSI parsing ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/13395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iec5c65776fc54b2f9e5dd55c711ace2471662db1 Gerrit-Change-Number: 13395 Gerrit-PatchSet: 4 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: msuraev Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 16 Jul 2019 04:19:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:19:21 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:19:21 +0000 Subject: Change in ...osmo-pcu[master]: Use libosmocore for IMSI parsing In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/13395 ) Change subject: Use libosmocore for IMSI parsing ...................................................................... Use libosmocore for IMSI parsing Change-Id: Iec5c65776fc54b2f9e5dd55c711ace2471662db1 --- M src/gprs_bssgp_pcu.cpp 1 file changed, 4 insertions(+), 32 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index 22abc6b..a4a5875 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -54,35 +54,6 @@ static void bvc_timeout(void *_priv); static int gprs_ns_reconnect(struct gprs_nsvc *nsvc); -static int parse_imsi(struct tlv_parsed *tp, char *imsi) -{ - uint8_t imsi_len; - uint8_t *bcd_imsi; - int i, j; - - if (!TLVP_PRESENT(tp, BSSGP_IE_IMSI)) - return -EINVAL; - - imsi_len = TLVP_LEN(tp, BSSGP_IE_IMSI); - bcd_imsi = (uint8_t *) TLVP_VAL(tp, BSSGP_IE_IMSI); - - if ((bcd_imsi[0] & 0x08)) - imsi_len = imsi_len * 2 - 1; - else - imsi_len = (imsi_len - 1) * 2; - for (i = 0, j = 0; j < imsi_len && j < 15; j++) - { - if (!(j & 1)) { - imsi[j] = (bcd_imsi[i] >> 4) + '0'; - i++; - } else - imsi[j] = (bcd_imsi[i] & 0xf) + '0'; - } - imsi[j] = '\0'; - - return 0; -} - #if 0 static int parse_ra_cap(struct tlv_parsed *tp, MS_Radio_Access_capability_t *rac) { @@ -147,7 +118,7 @@ /* read IMSI. if no IMSI exists, use first paging block (any paging), * because during attachment the IMSI might not be known, so the MS * will listen to all paging blocks. */ - parse_imsi(tp, imsi); + gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), TLVP_LEN(tp, BSSGP_IE_IMSI)); #if 0 /* Do not rely on this IE. TODO: make this configurable */ /* parse ms radio access capability */ @@ -205,12 +176,13 @@ } LOGPC(DBSSGP, LOGL_NOTICE, "\n"); - if (parse_imsi(tp, imsi)) - { + if (!TLVP_PRESENT(tp, BSSGP_IE_IMSI)) { LOGP(DBSSGP, LOGL_ERROR, "No IMSI\n"); return -EINVAL; } + gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), TLVP_LEN(tp, BSSGP_IE_IMSI)); + return gprs_rlcmac_paging_request(ptmsi, ptmsi_len, imsi); } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/13395 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iec5c65776fc54b2f9e5dd55c711ace2471662db1 Gerrit-Change-Number: 13395 Gerrit-PatchSet: 5 Gerrit-Owner: Max Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: msuraev Gerrit-CC: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:21:04 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:21:04 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add docker container In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14779 ) Change subject: debian-repo-install-test: add docker container ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 Gerrit-Change-Number: 14779 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 04:21:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:21:15 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:21:15 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: kill already running In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14780 ) Change subject: debian-repo-install-test: kill already running ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f Gerrit-Change-Number: 14780 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 04:21:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 04:21:39 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 16 Jul 2019 04:21:39 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: run systemd services In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14781 ) Change subject: debian-repo-install-test: run systemd services ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie6385f85560fefa7e7c9dca72cb5e2e914d4507a Gerrit-Change-Number: 14781 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 16 Jul 2019 04:21:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 07:19:00 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 07:19:00 +0000 Subject: Change in ...osmo-hlr[master]: VTY: add subscriber update network-access-mode In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14778 ) Change subject: VTY: add subscriber update network-access-mode ...................................................................... VTY: add subscriber update network-access-mode Allow updating the NAM (Network Access Mode) of subscribers with the VTY. This is important for the subscriber create on demand use case where subscribers get created without access to PS and CS NAM by default. Regenerate hlr_vty_reference.xml. Related: OS#2542 Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b --- M doc/manuals/vty/hlr_vty_reference.xml M src/hlr_vty_subscr.c M tests/test_subscriber.vty 3 files changed, 82 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/manuals/vty/hlr_vty_reference.xml b/doc/manuals/vty/hlr_vty_reference.xml index e5fd0f2..71a0236 100644 --- a/doc/manuals/vty/hlr_vty_reference.xml +++ b/doc/manuals/vty/hlr_vty_reference.xml @@ -811,6 +811,22 @@ + + + + + + + + + + + + + + + + config diff --git a/src/hlr_vty_subscr.c b/src/hlr_vty_subscr.c index 3078577..73dfab6 100644 --- a/src/hlr_vty_subscr.c +++ b/src/hlr_vty_subscr.c @@ -577,6 +577,33 @@ return CMD_SUCCESS; } +DEFUN(subscriber_nam, + subscriber_nam_cmd, + SUBSCR_UPDATE "network-access-mode (none|cs|ps|cs+ps)", + SUBSCR_UPDATE_HELP + "Set Network Access Mode (NAM) of the subscriber\n" + "Do not allow access to circuit switched or packet switched services\n" + "Allow access to circuit switched services only\n" + "Allow access to packet switched services only\n" + "Allow access to both circuit and packet switched services\n") +{ + struct hlr_subscriber subscr; + const char *id_type = argv[0]; + const char *id = argv[1]; + bool nam_cs = strstr(argv[2], "cs"); + bool nam_ps = strstr(argv[2], "ps"); + + if (get_subscr_by_argv(vty, id_type, id, &subscr)) + return CMD_WARNING; + + if (nam_cs != subscr.nam_cs) + hlr_subscr_nam(g_hlr, &subscr, nam_cs, 0); + if (nam_ps != subscr.nam_ps) + hlr_subscr_nam(g_hlr, &subscr, nam_ps, 1); + + return CMD_SUCCESS; +} + void hlr_vty_subscriber_init(void) { @@ -590,4 +617,5 @@ install_element(ENABLE_NODE, &subscriber_no_aud3g_cmd); install_element(ENABLE_NODE, &subscriber_aud3g_cmd); install_element(ENABLE_NODE, &subscriber_imei_cmd); + install_element(ENABLE_NODE, &subscriber_nam_cmd); } diff --git a/tests/test_subscriber.vty b/tests/test_subscriber.vty index 265f8fa..8e9026d 100644 --- a/tests/test_subscriber.vty +++ b/tests/test_subscriber.vty @@ -12,6 +12,7 @@ subscriber (imsi|msisdn|id|imei) IDENT update aud3g none subscriber (imsi|msisdn|id|imei) IDENT update aud3g milenage k K (op|opc) OP_C [ind-bitlen] [<0-28>] subscriber (imsi|msisdn|id|imei) IDENT update imei (none|IMEI) + subscriber (imsi|msisdn|id|imei) IDENT update network-access-mode (none|cs|ps|cs+ps) OsmoHLR# subscriber? subscriber Subscriber management commands @@ -125,10 +126,11 @@ MSISDN: 423 OsmoHLR# subscriber imsi 123456789023000 update ? - msisdn Set MSISDN (phone number) of the subscriber - aud2g Set 2G authentication data - aud3g Set UMTS authentication data (3G, and 2G with UMTS AKA) - imei Set IMEI of the subscriber (normally populated from MSC, no need to set this manually) + msisdn Set MSISDN (phone number) of the subscriber + aud2g Set 2G authentication data + aud3g Set UMTS authentication data (3G, and 2G with UMTS AKA) + imei Set IMEI of the subscriber (normally populated from MSC, no need to set this manually) + network-access-mode Set Network Access Mode (NAM) of the subscriber OsmoHLR# subscriber imsi 123456789023000 update msisdn ? none Remove MSISDN (phone number) @@ -437,3 +439,35 @@ IMSI: 000000000000099 MSISDN: none IMEI: 12345 (INVALID LENGTH!) + +OsmoHLR# subscriber imsi 123456789023000 create +% Created subscriber 123456789023000 + ID: 101 + IMSI: 123456789023000 + MSISDN: none +OsmoHLR# subscriber imsi 123456789023000 update network-access-mode none +OsmoHLR# subscriber imsi 123456789023000 show + ID: 101 + IMSI: 123456789023000 + MSISDN: none + CS disabled + PS disabled +OsmoHLR# subscriber imsi 123456789023000 update network-access-mode cs +OsmoHLR# subscriber imsi 123456789023000 show + ID: 101 + IMSI: 123456789023000 + MSISDN: none + PS disabled +OsmoHLR# subscriber imsi 123456789023000 update network-access-mode ps +OsmoHLR# subscriber imsi 123456789023000 show + ID: 101 + IMSI: 123456789023000 + MSISDN: none + CS disabled +OsmoHLR# subscriber imsi 123456789023000 update network-access-mode cs+ps +OsmoHLR# subscriber imsi 123456789023000 show + ID: 101 + IMSI: 123456789023000 + MSISDN: none +OsmoHLR# subscriber imsi 123456789023000 delete +% Deleted subscriber for IMSI '123456789023000' -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I231e03219355ebe6467d62ae2e40bef9d8303e3b Gerrit-Change-Number: 14778 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 07:19:02 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 07:19:02 +0000 Subject: Change in ...osmo-hlr[master]: manuals: improve subscribers create on demand In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14777 ) Change subject: manuals: improve subscribers create on demand ...................................................................... manuals: improve subscribers create on demand Write all VTY commands in monospace and add configuration example blocks. Add an example VTY session for enabling CS and PS NAM. Realted: OS#2542 Change-Id: I54f80810db3dac7a4a56ad42c5d2154b6006108c --- M doc/manuals/chapters/subscribers.adoc 1 file changed, 44 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/subscribers.adoc b/doc/manuals/chapters/subscribers.adoc index 9f87131..e09e99a 100644 --- a/doc/manuals/chapters/subscribers.adoc +++ b/doc/manuals/chapters/subscribers.adoc @@ -72,19 +72,58 @@ Usually a HLR will only allow mobile equipment (ME) on the network, if the HLR has a subscriber entry with the ME's IMSI. But OsmoHLR can also be configured to automatically create new entries for new IMSIs, with the -subscriber-create-on-demand VTY option. The obvious use case is creating the +`subscriber-create-on-demand` VTY option. The obvious use case is creating the new subscriber entry and then allowing the ME to use both the CS (Circuit Switched) and PS (Packet Switched) NAM (Network Access Mode). +.osmo-hlr.cfg +---- +hlr + subscriber-create-on-demand 5 cs+ps +---- + On the other hand, operators might only want to give network access to IMSIs, of which they know the owner. In order to do that, one can set the default NAM to -"none" and manually approve new subscribers by enabling their nam_cs and nam_ps -parameters (e.g. over the VTY). +`none` and manually approve new subscribers by changing the NAM (e.g. over the +VTY, see the example below). Oftentimes it is hard to know, which IMSI belongs to which ME, but the IMEI is readily available. If you configure your MSC to send IMEI checking requests to the HLR, before sending location update requests, the subscribers created on demand can also have the IMEI stored in the HLR database. With OsmoMSC, this -is done by writing "check-imei-rqd early" in the "msc" section of osmo-msc.cfg. +is done by writing `check-imei-rqd early` in the `msc` section of osmo-msc.cfg. Then enable storing the IMEI when receiving check IMEI requests with -"store-imei" in the OsmoHLR configuration. +`store-imei` in the OsmoHLR configuration. + +.osmo-msc.cfg +---- +msc + check-imei-rqd early +---- + +.osmo-hlr.cfg +---- +hlr + subscriber-create-on-demand 5 none + store-imei +---- + +.Example: Enabling CS and PS NAM via VTY for a known IMEI +---- +OsmoHLR> enable +OsmoHLR# subscriber imei 35761300444848 show + ID: 1 + IMSI: 123456789023000 + MSISDN: 58192 <1> + IMEI: 35761300444848 + CS disabled <2> + PS disabled <2> +OsmoHLR# subscriber imei 35761300444848 update network-access-mode cs+ps +OsmoHLR# subscriber imei 35761300444848 show + ID: 1 + IMSI: 123456789023000 + MSISDN: 58192 + IMEI: 35761300444848 +---- +<1> Randomly generated 5 digit MSISDN +<2> Disabled CS and PS NAM prevent the subscriber from accessing the network -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14777 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I54f80810db3dac7a4a56ad42c5d2154b6006108c Gerrit-Change-Number: 14777 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 08:02:06 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Jul 2019 08:02:06 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14692 ) Change subject: trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation ...................................................................... trx_toolkit/ctrl_if_trx.py: implement TRXD header version negotiation Messages on DATA interface may have different header formats, defined by a version number, which can be negotiated on the control interface. By default, the Transceiver will use the legacy header version (0). The header format negotiation can be initiated by the L1 using the 'SETFORMAT' command. If the requested version is not supported by the transceiver, status code of the response message should indicate a preferred (basically, the latest) version. The format of this message is the following: L1 -> TRX: CMD SETFORMAT VER_REQ L1 <- TRX: RSP SETFORMAT VER_RSP VER_REQ where: - VER_REQ is the requested version (suggested by the L1), - VER_RSP is either the applied version if matches VER_REQ, or a preferred version if VER_REQ is not supported. If the transceiver indicates VER_RSP different than VER_REQ, the L1 is supposed to reinitiate the version negotiation using the suggested VER_RSP. For example: L1 -> TRX: CMD SETFORMAT 2 L1 <- TRX: RSP SETFORMAT 1 2 L1 -> TRX: CMD SETFORMAT 1 L1 <- TRX: RSP SETFORMAT 1 1 If no suitable VER_RSP is found, or the VER_REQ is incorrect, the status code in the response shall be -1. As soon as VER_RSP matches VER_REQ in the response, the process of negotiation is complete. Changing the header version is supposed to be done before POWERON, but can be also done after. Change-Id: I8d441b2559863d2dbd680db371062e4f3a2f9ff9 Related: OS#4006 --- M src/target/trx_toolkit/ctrl_if_trx.py M src/target/trx_toolkit/data_if.py 2 files changed, 75 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/target/trx_toolkit/ctrl_if_trx.py b/src/target/trx_toolkit/ctrl_if_trx.py index 26a844f..8cb5c1a 100644 --- a/src/target/trx_toolkit/ctrl_if_trx.py +++ b/src/target/trx_toolkit/ctrl_if_trx.py @@ -4,7 +4,7 @@ # TRX Toolkit # CTRL interface implementation (common commands) # -# (C) 2016-2018 by Vadim Yanitskiy +# (C) 2016-2019 by Vadim Yanitskiy # # All Rights Reserved # @@ -25,6 +25,7 @@ import logging as log from ctrl_if import CTRLInterface +from data_msg import DATAMSG class CTRLInterfaceTRX(CTRLInterface): """ CTRL interface handler for common transceiver management commands. @@ -42,6 +43,45 @@ that is prioritized, i.e. it can overwrite any commands mentioned above. If None is returned, a command is considered as unhandled. + == TRXD header version negotiation + + Messages on DATA interface may have different header formats, + defined by a version number, which can be negotiated on the + control interface. By default, the Transceiver will use the + legacy header version (0). + + The header format negotiation can be initiated by the L1 + using 'SETFORMAT' command. If the requested version is not + supported by the transceiver, status code of the response + message should indicate a preferred (basically, the latest) + version. The format of this message is the following: + + L1 -> TRX: CMD SETFORMAT VER_REQ + L1 <- TRX: RSP SETFORMAT VER_RSP VER_REQ + + where: + + - VER_REQ is the requested version (suggested by the L1), + - VER_RSP is either the applied version if matches VER_REQ, + or a preferred version if VER_REQ is not supported. + + If the transceiver indicates VER_RSP different than VER_REQ, + the L1 is supposed to reinitiate the version negotiation + using the suggested VER_RSP. For example: + + L1 -> TRX: CMD SETFORMAT 2 + L1 <- TRX: RSP SETFORMAT 1 2 + + L1 -> TRX: CMD SETFORMAT 1 + L1 <- TRX: RSP SETFORMAT 1 1 + + If no suitable VER_RSP is found, or the VER_REQ is incorrect, + the status code in the response shall be -1. + + As soon as VER_RSP matches VER_REQ in the response, the process + of negotiation is complete. Changing the header version is + supposed to be done before POWERON, but can be also done after. + """ def __init__(self, trx, *udp_link_args): @@ -147,6 +187,31 @@ return (0, [str(meas_dbm)]) + # TRXD header version negotiation + if self.verify_cmd(request, "SETFORMAT", 1): + log.debug("(%s) Recv SETFORMAT cmd" % self.trx) + + # Parse the requested version + ver_req = int(request[1]) + # ... and store current for logging + ver_cur = self.trx.data_if._hdr_ver + + if ver_req < 0 or ver_req > DATAMSG.CHDR_VERSION_MAX: + log.error("(%s) Incorrect TRXD header version %u" + % (self.trx, ver_req)) + return -1 + + if not self.trx.data_if.set_hdr_ver(ver_req): + ver_rsp = self.trx.data_if.pick_hdr_ver(ver_req) + log.warn("(%s) Requested TRXD header version %u " + "is not supported, suggesting %u..." + % (self.trx, ver_req, ver_rsp)) + return ver_rsp + + log.info("(%s) TRXD header version %u -> %u" + % (self.trx, ver_cur, ver_req)) + return ver_req + # Wrong / unknown command else: # We don't care about other commands, diff --git a/src/target/trx_toolkit/data_if.py b/src/target/trx_toolkit/data_if.py index 10df438..11df756 100644 --- a/src/target/trx_toolkit/data_if.py +++ b/src/target/trx_toolkit/data_if.py @@ -42,6 +42,15 @@ self._hdr_ver = ver return True + def pick_hdr_ver(self, ver_req): + # Pick a version that is lower or equal to ver_req + for ver in DATAMSG.known_versions[::-1]: + if ver <= ver_req: + return ver + + # No suitable version found + return -1 + def match_hdr_ver(self, msg): if msg.ver == self._hdr_ver: return True -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8d441b2559863d2dbd680db371062e4f3a2f9ff9 Gerrit-Change-Number: 14692 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 08:02:07 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Jul 2019 08:02:07 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14586 ) Change subject: trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation ...................................................................... trx_toolkit/fake_trx.py: introduce a TRXC command for C/I simulation C/I (Carrier-to-Interference ratio) is a value in cB (centiBels), computed from the training sequence of each received burst, by comparing the "ideal" training sequence with the received one. This change introduces a new command similar to FAKE_TOA and FAKE_RSSI, so it can be used by TTCN-3 test case 'TC_pcu_data_ind_lqual_cb' to verify that the link quality measurements are delivered to the PCU. Change-Id: I7080effbbc1022d1884c6d6f0cb580eba8e514ff Related: OS#1855 --- M src/target/trx_toolkit/fake_trx.py 1 file changed, 29 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py index de0e6ff..69cdd86 100755 --- a/src/target/trx_toolkit/fake_trx.py +++ b/src/target/trx_toolkit/fake_trx.py @@ -64,8 +64,16 @@ from (rssi_base - rssi_rand_threshold) to (rssi_base + rssi_rand_threshold). - Please note that randomization of both RSSI and ToA is optional, - and can be enabled from the control interface. + - C/I (Carrier-to-Interference ratio) - value in cB (centiBels), + computed from the training sequence of each received burst, by + comparing the "ideal" training sequence with the actual one. + A pair of both base and threshold values defines a range of + C/I randomization: + + from (ci_base - ci_rand_threshold) + to (ci_base + ci_rand_threshold). + + Please note that the randomization is optional and disabled by default. == Timing Advance handling @@ -263,6 +271,25 @@ self.rssi_base += int(request[1]) return 0 + # C/I simulation + # Absolute form: CMD FAKE_CI + elif self.ctrl_if.verify_cmd(request, "FAKE_CI", 2): + log.debug("(%s) Recv FAKE_CI cmd" % self) + + # Parse and apply both base and threshold + self.ci_base = int(request[1]) + self.ci_rand_threshold = int(request[2]) + return 0 + + # C/I simulation + # Relative form: CMD FAKE_CI <+-BASE_DELTA> + elif self.ctrl_if.verify_cmd(request, "FAKE_CI", 1): + log.debug("(%s) Recv FAKE_CI cmd" % self) + + # Parse and apply delta + self.ci_base += int(request[1]) + return 0 + # Path loss simulation: burst dropping # Syntax: CMD FAKE_DROP # Dropping pattern: fn % 1 == 0 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7080effbbc1022d1884c6d6f0cb580eba8e514ff Gerrit-Change-Number: 14586 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 08:16:45 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 08:16:45 +0000 Subject: Change in ...osmo-ci[master]: osmocom-debian-install.yml: update description Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14789 Change subject: osmocom-debian-install.yml: update description ...................................................................... osmocom-debian-install.yml: update description Replace "Generated by job-builder" with a proper description. The job builder automatically adds "" to the description (which is visible when editing the job), so we don't need to mention it in the description at all. Related: OS#3369 Change-Id: I17d2e9e0ac7fe77fb0306724a1f1e15641d76854 --- M jobs/osmocom-debian-install.yml 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/89/14789/1 diff --git a/jobs/osmocom-debian-install.yml b/jobs/osmocom-debian-install.yml index 2e88cbf..80abeec 100644 --- a/jobs/osmocom-debian-install.yml +++ b/jobs/osmocom-debian-install.yml @@ -12,7 +12,11 @@ project-type: freestyle defaults: global - description: 'Generated by job-builder' + description: | +
    +
  • Install all Osmocom debian packages (OS#3176) +
  • Check if Osmocom systemd services start properly (OS#3369) +
node: osmocom-master-debian9 builders: - shell: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I17d2e9e0ac7fe77fb0306724a1f1e15641d76854 Gerrit-Change-Number: 14789 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 08:16:46 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 08:16:46 +0000 Subject: Change in ...osmo-ci[master]: osmocom-debian-install.yml: add BRANCH variable Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14790 Change subject: osmocom-debian-install.yml: add BRANCH variable ...................................................................... osmocom-debian-install.yml: add BRANCH variable Allow changing the branch in the jenkins UI when starting the build. We already have this in other jobs, and it is very useful to test changes. Change-Id: Ice4662551625b3c96ca105629a934a0a081db2e4 --- M jobs/osmocom-debian-install.yml 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/90/14790/1 diff --git a/jobs/osmocom-debian-install.yml b/jobs/osmocom-debian-install.yml index 80abeec..1f6c62a 100644 --- a/jobs/osmocom-debian-install.yml +++ b/jobs/osmocom-debian-install.yml @@ -18,13 +18,19 @@
  • Check if Osmocom systemd services start properly (OS#3369) node: osmocom-master-debian9 + parameters: + - string: + name: BRANCH + description: | + docker-playground.git branch + default: '*/master' builders: - shell: cd debian-repo-install-test && FEED={type} ./jenkins.sh scm: - git: branches: - - '*/master' + - '$BRANCH' url: git://git.osmocom.org/docker-playground git-config-name: 'Jenkins Builder' git-config-email: 'jenkins at osmocom.org' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ice4662551625b3c96ca105629a934a0a081db2e4 Gerrit-Change-Number: 14790 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 08:31:26 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 08:31:26 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add docker container In-Reply-To: References: Message-ID: Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/14779 to look at the new patch set (#2). Change subject: debian-repo-install-test: add docker container ...................................................................... debian-repo-install-test: add docker container Add own container with systemd, so we can (in a follow-up commit) run the Osmocom systemd services in this test job. Rewrite the "interactive shell" logic to support the new systemd docker container, and enable it with an INTERACTIVE environment variable instead of hardcoding 'interactive="true"' in the script. While at it, move the Repository.key install to the Dockerfile so it works more like the other docker containers we have. Related: OS#3369 Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 --- A debian-repo-install-test/Dockerfile A debian-repo-install-test/Makefile R debian-repo-install-test/Release.key M debian-repo-install-test/jenkins.sh M debian-repo-install-test/testdata/repo-install-test.sh 5 files changed, 43 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/79/14779/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 Gerrit-Change-Number: 14779 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 08:31:26 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 08:31:26 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: run systemd services In-Reply-To: References: Message-ID: Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/14781 to look at the new patch set (#2). Change subject: debian-repo-install-test: run systemd services ...................................................................... debian-repo-install-test: run systemd services Run systemd services of Osmocom programs, to check if any are not starting properly. Use a whitelist to determine which services must start up, because some are currently broken. Modify the docker run command to support changing the CPU scheduling policy/priority in systemd service files (used by osmo-bts). Related: OS#3369 Change-Id: Ie6385f85560fefa7e7c9dca72cb5e2e914d4507a --- M debian-repo-install-test/jenkins.sh M debian-repo-install-test/testdata/repo-install-test.sh 2 files changed, 58 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/81/14781/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie6385f85560fefa7e7c9dca72cb5e2e914d4507a Gerrit-Change-Number: 14781 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 09:23:51 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 09:23:51 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: kill already running In-Reply-To: References: Message-ID: Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/14780 to look at the new patch set (#3). Change subject: debian-repo-install-test: kill already running ...................................................................... debian-repo-install-test: kill already running The container grows heavily in size as the test runs, so make sure to always kill existing ones (from stopped jobs) before starting a new one. In order to do that, do not use $BUILD_TAG as container name, which changes with every new jenkins run. Related: OS#3369 Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f --- M debian-repo-install-test/jenkins.sh 1 file changed, 13 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/80/14780/3 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f Gerrit-Change-Number: 14780 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 09:23:51 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 09:23:51 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: run systemd services In-Reply-To: References: Message-ID: Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/14781 to look at the new patch set (#3). Change subject: debian-repo-install-test: run systemd services ...................................................................... debian-repo-install-test: run systemd services Run systemd services of Osmocom programs, to check if any are not starting properly. Use a whitelist to determine which services must start up, because some are currently broken. Modify the docker run command to support changing the CPU scheduling policy/priority in systemd service files (used by osmo-bts). Related: OS#3369 Change-Id: Ie6385f85560fefa7e7c9dca72cb5e2e914d4507a --- M debian-repo-install-test/jenkins.sh M debian-repo-install-test/testdata/repo-install-test.sh 2 files changed, 60 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/81/14781/3 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie6385f85560fefa7e7c9dca72cb5e2e914d4507a Gerrit-Change-Number: 14781 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 09:25:51 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 09:25:51 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add docker container In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14779 ) Change subject: debian-repo-install-test: add docker container ...................................................................... Patch Set 2: Verified+1 This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 Gerrit-Change-Number: 14779 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Jul 2019 09:25:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 09:25:59 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 09:25:59 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: kill already running In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14780 ) Change subject: debian-repo-install-test: kill already running ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f Gerrit-Change-Number: 14780 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Jul 2019 09:25:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 09:26:04 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 09:26:04 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: run systemd services In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14781 ) Change subject: debian-repo-install-test: run systemd services ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie6385f85560fefa7e7c9dca72cb5e2e914d4507a Gerrit-Change-Number: 14781 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Jul 2019 09:26:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 09:59:20 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 09:59:20 +0000 Subject: Change in ...osmo-bsc[master]: osmo-bsc.cfg: work with osmo-bts example cfg Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14791 Change subject: osmo-bsc.cfg: work with osmo-bts example cfg ...................................................................... osmo-bsc.cfg: work with osmo-bts example cfg Change cell_identity and unit-id to match osmo-bts-virtual.cfg. Related: OS#3369 Change-Id: Ie8001611756b661ff1871508c6248b2e990ba1d7 --- M doc/examples/osmo-bsc/osmo-bsc.cfg 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/91/14791/1 diff --git a/doc/examples/osmo-bsc/osmo-bsc.cfg b/doc/examples/osmo-bsc/osmo-bsc.cfg index 926951b..9b312f0 100644 --- a/doc/examples/osmo-bsc/osmo-bsc.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc.cfg @@ -22,7 +22,7 @@ bts 0 type sysmobts band DCS1800 - cell_identity 0 + cell_identity 6969 location_area_code 1 base_station_id_code 63 ms max power 15 @@ -36,7 +36,7 @@ channel-descrption bs-pa-mfrms 5 channel-descrption bs-ag-blks-res 1 early-classmark-sending forbidden - ipa unit-id 0 0 + ipa unit-id 6969 0 oml ipa stream-id 255 line 0 codec-support fr gprs mode none -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie8001611756b661ff1871508c6248b2e990ba1d7 Gerrit-Change-Number: 14791 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 10:23:52 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 10:23:52 +0000 Subject: Change in ...osmo-bsc[master]: osmo-bsc.cfg: work with osmo-bts example cfg In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/14791 to look at the new patch set (#2). Change subject: osmo-bsc.cfg: work with osmo-bts example cfg ...................................................................... osmo-bsc.cfg: work with osmo-bts example cfg Change cell_identity and unit-id to match osmo-bts-virtual.cfg. Related: OS#3369 Change-Id: Ie8001611756b661ff1871508c6248b2e990ba1d7 --- M doc/examples/osmo-bsc/osmo-bsc.cfg M tests/ctrl_test_runner.py 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/91/14791/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie8001611756b661ff1871508c6248b2e990ba1d7 Gerrit-Change-Number: 14791 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 12:23:14 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 12:23:14 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-gtphub.cfg: fix conflict with osmo-sgsn.cfg Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14792 Change subject: osmo-gtphub.cfg: fix conflict with osmo-sgsn.cfg ...................................................................... osmo-gtphub.cfg: fix conflict with osmo-sgsn.cfg Change bind-to-sgsns from 127.0.0.1 to 127.0.0.10, so osmo-gtphub's default config does not conflict with the osmo-sgsn default config. The value of bind-to-ggsns does not clash with osmo-ggsn's config, so it was left unchanged. Related: OS#3369 Change-Id: Id892e1f4ab2daabbe9824b819b5fed985373b97a --- M doc/examples/osmo-gtphub/osmo-gtphub.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/92/14792/1 diff --git a/doc/examples/osmo-gtphub/osmo-gtphub.cfg b/doc/examples/osmo-gtphub/osmo-gtphub.cfg index 0dc4150..0bb63e3 100644 --- a/doc/examples/osmo-gtphub/osmo-gtphub.cfg +++ b/doc/examples/osmo-gtphub/osmo-gtphub.cfg @@ -8,7 +8,7 @@ gtphub ! Local addresses to listen on and send from, each on standard ports ! 2123 and 2152. Setting these addresses is mandatory. - bind-to-sgsns 127.0.0.1 + bind-to-sgsns 127.0.0.10 bind-to-ggsns 127.0.0.2 ! Local nonstandard ports or separate IPs: -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id892e1f4ab2daabbe9824b819b5fed985373b97a Gerrit-Change-Number: 14792 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 12:55:12 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 12:55:12 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add fixed services Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14793 Change subject: debian-repo-install-test: add fixed services ...................................................................... debian-repo-install-test: add fixed services Enable test of systemd services for osmo-sgsn, osmo-pcu, osmo-hnbgw and osmo-bts-virtual. Add issue ID to failing osmo-ctrl2cgi and osmo-trap2cgi services. Depends: Id892e1f4ab2daabbe9824b819b5fed985373b97a (osmo-sgsn) Depends: Ie8001611756b661ff1871508c6248b2e990ba1d7 (osmo-bsc) Depends: I354140f014854f1755b649e40a65e5d88b99c0ec (osmo-iuh) Related: OS#3369 Change-Id: I4e182b396e1a2e36a73384233b1a38a70c7cd5d9 --- M debian-repo-install-test/testdata/repo-install-test.sh 1 file changed, 10 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/93/14793/1 diff --git a/debian-repo-install-test/testdata/repo-install-test.sh b/debian-repo-install-test/testdata/repo-install-test.sh index e2cedd2..338fe8d 100755 --- a/debian-repo-install-test/testdata/repo-install-test.sh +++ b/debian-repo-install-test/testdata/repo-install-test.sh @@ -2,12 +2,8 @@ # Systemd services that must start up successfully after installing all packages (OS#3369) # Disabled services: -# * osmo-ctrl2cgi (missing config: /etc/osmocom/ctrl2cgi.ini) -# * osmo-trap2cgi (missing config: /etc/osmocom/%N.ini) -# * osmo-sgsn (port 2123 already used by osmo-ggsn) -# * osmo-pcu (expects missing /tmp/pcu_bts socket) -# * osmo-hnbgw (tries to listen on 10.23.24.1) -# * osmo-bts-virtual (unit_id is not matching osmo-bsc's config) +# * osmo-ctrl2cgi (missing config: /etc/osmocom/ctrl2cgi.ini, OS#4108) +# * osmo-trap2cgi (missing config: /etc/osmocom/%N.ini, OS#4108) SERVICES=" osmo-bsc osmo-gbproxy @@ -22,8 +18,16 @@ " # Services working in nightly, but not yet in latest # * osmo-pcap-server: service not included in osmo-pcap 0.0.11 +# * osmo-sgsn: conflicts with osmo-gtphub config in osmo-sgsn 1.4.0 +# * osmo-pcu: needs osmo-bts-virtual to start up properly +# * osmo-hnbgw: tries to listen on 10.23.24.1 in osmo-iuh 0.4.0 +# * osmo-bts-virtual: unit id not matching osmo-bsc's config in osmo-bsc 1.4.0 SERVICES_NIGHTLY=" osmo-pcap-server + osmo-sgsn + osmo-pcu + osmo-hnbgw + osmo-bts-virtual " HTTP="http://download.opensuse.org/repositories/network:/osmocom:/$FEED/Debian_9.0/" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14793 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4e182b396e1a2e36a73384233b1a38a70c7cd5d9 Gerrit-Change-Number: 14793 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 12:55:47 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 16 Jul 2019 12:55:47 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add fixed services In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14793 ) Change subject: debian-repo-install-test: add fixed services ...................................................................... Patch Set 1: Setting to WIP until depending patches are merged. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14793 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4e182b396e1a2e36a73384233b1a38a70c7cd5d9 Gerrit-Change-Number: 14793 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 16 Jul 2019 12:55:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 13:30:26 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 13:30:26 +0000 Subject: Change in ...osmo-mgw[master]: doc: Document X-Osmux extension In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14681 ) Change subject: doc: Document X-Osmux extension ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14681/1/doc/manuals/chapters/mgcp_extensions.adoc File doc/manuals/chapters/mgcp_extensions.adoc: https://gerrit.osmocom.org/#/c/14681/1/doc/manuals/chapters/mgcp_extensions.adoc at 73 PS1, Line 73: endpoint has to be configured in order to handle Osmux frames instead of RTP > s/has to be/can be/ ? If the other side ignores it osmux support stays disabled, right? Not really, I changed the behavior a bit since anyway it doesn't make sense to accept (MGCP OK) an osmux CRCX/MDCX without X-Osmux (hence falling back to RTP) since the passed parameters during request already belong to an Osmux peer socket (remote ip+port), so current implementation will answer with MGCP FAIL if it cannot use Osmux. So use of Osmux is negotiated beforehand and at the time of requesting it through MGCP to MGW it should either be Osmux or fail. Behavior can be a bit different in BSCNAT case, but it's really specific to it. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 Gerrit-Change-Number: 14681 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 13:30:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Tue Jul 16 14:09:48 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 16 Jul 2019 14:09:48 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2ddac02aeb3_d2612a45f89639e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 725s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 725s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 725s] collect2: error: ld returned 1 exit status [ 725s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 725s] make[4]: *** [osmo-bts-virtual] Error 1 [ 725s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 725s] Makefile:385: recipe for target 'all-recursive' failed [ 725s] make[3]: *** [all-recursive] Error 1 [ 725s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 725s] Makefile:434: recipe for target 'all-recursive' failed [ 725s] make[2]: *** [all-recursive] Error 1 [ 725s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 725s] Makefile:366: recipe for target 'all' failed [ 725s] make[1]: *** [all] Error 2 [ 725s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 725s] dh_auto_build: make -j1 returned exit code 2 [ 725s] debian/rules:12: recipe for target 'build' failed [ 725s] make: *** [build] Error 2 [ 725s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 725s] [ 725s] obs-arm-5 failed "build osmo-bts_0.8.1.336.04e9.dsc" at Tue Jul 16 14:09:43 UTC 2019. [ 725s] [ 725s] ### VM INTERACTION START ### [ 728s] [ 691.918637] sysrq: SysRq : Power Off [ 728s] [ 691.937202] reboot: Power down [ 729s] ### VM INTERACTION END ### [ 729s] [ 729s] obs-arm-5 failed "build osmo-bts_0.8.1.336.04e9.dsc" at Tue Jul 16 14:09:47 UTC 2019. [ 729s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Jul 16 16:34:53 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 16:34:53 +0000 Subject: Change in ...libosmocore[master]: tell ubsan to ignore SUN_LEN In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14682 ) Change subject: tell ubsan to ignore SUN_LEN ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14682/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14682/1//COMMIT_MSG at 9 PS1, Line 9: SUN_LEN is awful and ubsan will report this, so let's ignore it. > SUN_LEN(ptr) ((size_t) (((struct sockaddr_un *) 0)->sun_path) + strlen((ptr)->sun_path)) [?] I still don't get why is this reported as a runtime error. Please explain better what the change exactly does (and how), and put that into the commit description. Information about the mentioned runtime error line is also useful. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 Gerrit-Change-Number: 14682 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 16:34:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: Hoernchen Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 16:46:46 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 16:46:46 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 ) Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Patch Set 5: Code-Review+1 Fine for me, but afaiu we are changing the value meaning of an already existing VTY command, we should be careful there. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 16:46:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 16:49:16 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 16:49:16 +0000 Subject: Change in ...osmo-bts[master]: Move Access Burst link quality handling to L1SAP In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14687 ) Change subject: Move Access Burst link quality handling to L1SAP ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Gerrit-Change-Number: 14687 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 16:49:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 16:49:44 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 16:49:44 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14688 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8d86dec7ebc039cbfd038c4342ff328b11281865 Gerrit-Change-Number: 14688 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 16:49:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 16:50:52 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 16:50:52 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14689 ) Change subject: osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea0dad65e9bc511f99375fd3ee2eb44e47a6168f Gerrit-Change-Number: 14689 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 16:50:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 16:58:33 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 16:58:33 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E0=2E6=2E100-e524_=E2=86=92_0=2E1=2E0?= In-Reply-To: References: Message-ID: pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14677 ) Change subject: Bump version: 0.0.6.100-e524 ? 0.1.0 ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14677 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I2ca3555ef5e19c6920d916618dee788bf18a6218 Gerrit-Change-Number: 14677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 16:58:49 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 16:58:49 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E0=2E6=2E100-e524_=E2=86=92_0=2E1=2E0?= In-Reply-To: References: Message-ID: pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14676 ) Change subject: Bump version: 0.0.6.100-e524 ? 0.1.0 ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14676 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Id122ff79aa3f339afb5a35f758c67a350cf94830 Gerrit-Change-Number: 14676 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 17:02:30 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 17:02:30 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E0=2E11_=E2=86=92_0=2E1=2E0?= Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14794 Change subject: Bump version: 0.0.11 ? 0.1.0 ...................................................................... Bump version: 0.0.11 ? 0.1.0 Change-Id: I4f0d75163fcb7d8d9b5540f8970382ce873680d4 --- M debian/changelog 1 file changed, 51 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/94/14794/1 diff --git a/debian/changelog b/debian/changelog index 1345f93..f2da97e 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,54 @@ +osmo-pcap (0.1.0) unstable; urgency=medium + + [ Harald Welte ] + * sock_src_init(): Don't freeaddrinfo() undefined src_result + * Use TCP port numbers for VTY that don't overlap with other Osmocom Software + * Rename osmo_pcap_{client_server} executables to osmo-pcap-{client,server} + * Use libosmocore osmo_sock_init2() instead of local implementation + * client: Move to osmo_sock_init2_ofd() + * Add support for generating IPIP to osmo-pcap-client + * debian/control: Fix URLs for homepage, git, gitweb + * change binary builds URL to network:osmocom as that's more maintained + * Fix compiler warning about deprecated _BSD_SOURCE + + [ Max ] + * Add gitreview config + * Use release helper from libosmocore + + [ Pau Espin Pedrol ] + * cosmetic: client: rename forward_packet function + * vty: skip installing cmds now always installed by default + * client: Properly name main talloc ctx + * server: Properly name main talloc ctx + * Drop osmo_init_logging and use osmo_init_logging2 + * osmo_client_send_data: Fix wrong log format + * configure.ac: Add --enable-werror flag + * configure.ac: Add --enable-sanitize flag + * jenkins.sh: enable werror and sanitize configure flags + * Replace '.' in counter names with ':' + * Use enum for PKT_LINK_* + * client: Set snaplen to MAXIMUM_SNAPLEN + * client: Add pcap snaplen VTY cmd + * client_send_link: snaplen not needed during allocation + * server: Improve verification of messages from client + * server: Add pcap snaplen VTY cmd + * contrib/jenkins.sh: Update to current osmocom infra + * debian: Clean up to look like other osmocom projects + * Install systemd services with autotools + * Install cfg files with autotools + * gitignore: Add compile + * debian: Install osmo_pcap_clean_old in osmo-pcap-server pkg + * tests/Makefile.am: Fix "./configure && make clean && make" + * debian/changelog: Mark 0.0.11 as released + + [ Oliver Smith ] + * Fix DISTCHECK_CONFIGURE_FLAGS override + * contrib: fix makedistcheck with disabled systemd + * gitignore: fix application names + * contrib/jenkins.sh: run "make maintainer-clean" + + -- Pau Espin Pedrol Tue, 16 Jul 2019 19:01:15 +0200 + osmo-pcap (0.0.11) unstable; urgency=medium * Add "source ip A.B.C.D" option to use specific address. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14794 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I4f0d75163fcb7d8d9b5540f8970382ce873680d4 Gerrit-Change-Number: 14794 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 17:03:23 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 17:03:23 +0000 Subject: Change in ...meta-telephony[201705]: Add recipe for osmo-pcap, both server and client In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/3534 ) Change subject: Add recipe for osmo-pcap, both server and client ...................................................................... Patch Set 2: Thanks, I'll resubmit with typo fixed once I merge https://gerrit.osmocom.org/c/osmo-pcap/+/14794 and have 0.11 available. -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/3534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I5bb85b118029d1559a958803184690a9d0f23e4a Gerrit-Change-Number: 3534 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Assignee: pespin Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Max Gerrit-Comment-Date: Tue, 16 Jul 2019 17:03:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 17:05:29 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Jul 2019 17:05:29 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 ) Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Patch Set 5: > afaiu we are changing the value meaning of an already existing VTY command [...] Nope, we don't. We always expected the value in centiBels, I just changed the command description a bit. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 17:05:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 17:06:34 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 17:06:34 +0000 Subject: Change in ...osmocom-bb[master]: target/*.py: use python3 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14759 ) Change subject: target/*.py: use python3 ...................................................................... Patch Set 2: > Patch Set 2: > Sounds possible. However I would like to drop python2 support in general. It's really dead already ;) +1 to not cate about python2 anymore. I wouldn't invest time in removing python2 stuff, but let it rote by not caring about it. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 Gerrit-Change-Number: 14759 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus Gerrit-CC: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 17:06:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 17:09:14 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 17:09:14 +0000 Subject: Change in ...osmo-bts[master]: remove dummy UL measurement results for lost sacch frames In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14762 ) Change subject: remove dummy UL measurement results for lost sacch frames ...................................................................... Patch Set 1: @fixeria please have a look at this one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idfa123f8d02a9d8be1f6de6923fc2a8628020145 Gerrit-Change-Number: 14762 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 17:09:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 17:09:52 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 17:09:52 +0000 Subject: Change in ...docker-playground[master]: adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14764 ) Change subject: adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14764 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1c57a04747f5ec004ccf4657954dcb0b003c24fc Gerrit-Change-Number: 14764 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 17:09:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 17:10:53 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 17:10:53 +0000 Subject: Change in ...docker-playground[master]: adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14764 ) Change subject: adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7 ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14764/1/ttcn3-bsc-test/osmo-bsc.cfg File ttcn3-bsc-test/osmo-bsc.cfg: https://gerrit.osmocom.org/#/c/14764/1/ttcn3-bsc-test/osmo-bsc.cfg at 69 PS1, Line 69: handover 1 is this enabling handover? do we want to enable it by default? or only in related tests? (not sure if it will change behavior of BSC in unrelated tests). -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14764 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1c57a04747f5ec004ccf4657954dcb0b003c24fc Gerrit-Change-Number: 14764 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 17:10:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 17:15:57 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 17:15:57 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: bsc: add TC_ho_neighbor_config_1 thru _7 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14765 ) Change subject: bsc: add TC_ho_neighbor_config_1 thru _7 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia4ba0e75abd3d45a3422b2525e5f938cdc5a04cc Gerrit-Change-Number: 14765 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 17:15:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Tue Jul 16 17:20:05 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 16 Jul 2019 17:20:05 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2e07647dfdb_d2612a45f815323b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 708s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 708s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 708s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 708s] Makefile:442: recipe for target 'vlr.o' failed [ 708s] make[4]: *** [vlr.o] Error 1 [ 708s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 708s] Makefile:422: recipe for target 'all-recursive' failed [ 708s] make[3]: *** [all-recursive] Error 1 [ 708s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 708s] Makefile:462: recipe for target 'all-recursive' failed [ 708s] make[2]: *** [all-recursive] Error 1 [ 708s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 708s] Makefile:394: recipe for target 'all' failed [ 708s] make[1]: *** [all] Error 2 [ 708s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 708s] dh_auto_build: make -j1 returned exit code 2 [ 708s] debian/rules:45: recipe for target 'build' failed [ 708s] make: *** [build] Error 2 [ 708s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 708s] [ 708s] obs-arm-5 failed "build osmo-msc_1.3.1.178.aa0a.dsc" at Tue Jul 16 17:19:57 UTC 2019. [ 708s] [ 708s] ### VM INTERACTION START ### [ 711s] [ 675.272300] sysrq: SysRq : Power Off [ 711s] [ 675.282678] reboot: Power down [ 713s] ### VM INTERACTION END ### [ 713s] [ 713s] obs-arm-5 failed "build osmo-msc_1.3.1.178.aa0a.dsc" at Tue Jul 16 17:20:02 UTC 2019. [ 713s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Jul 16 17:33:34 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 17:33:34 +0000 Subject: Change in ...osmo-bsc[master]: neighbor config: allow re-using ARFCN+BSIC pairs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14769 ) Change subject: neighbor config: allow re-using ARFCN+BSIC pairs ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14769/1/src/osmo-bsc/handover_decision_2.c File src/osmo-bsc/handover_decision_2.c: https://gerrit.osmocom.org/#/c/14769/1/src/osmo-bsc/handover_decision_2.c at 903 PS1, Line 903: find_handover_target_cell(&neighbor_bts, &neighbor_cil, no check for return code? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29bca59ab232eddc74e0d4698efb9c9992443983 Gerrit-Change-Number: 14769 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 17:33:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 17:34:54 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 17:34:54 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-sysmon=5Bmaster=5D=3A_Bump_version=3A_0=2E1=2E1=2E52-c187_=E2=86=92_0=2E2=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sysmon/+/14770 ) Change subject: Bump version: 0.1.1.52-c187 ? 0.2.0 ...................................................................... Patch Set 1: Was there any speciifc reason to have a new release here? -- To view, visit https://gerrit.osmocom.org/c/osmo-sysmon/+/14770 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-Change-Id: I34ef32535a0d6a07feeb43a7e4ebf405d7d68c44 Gerrit-Change-Number: 14770 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: blobb Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 17:34:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Tue Jul 16 17:53:13 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 16 Jul 2019 17:53:13 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2e0f1d23795_d2612a45f81626c6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 610s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 610s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 610s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 610s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 610s] make[4]: *** [gb_proxy.o] Error 1 [ 610s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 610s] Makefile:391: recipe for target 'all-recursive' failed [ 610s] make[3]: *** [all-recursive] Error 1 [ 610s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 610s] Makefile:453: recipe for target 'all-recursive' failed [ 610s] make[2]: *** [all-recursive] Error 1 [ 610s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 610s] Makefile:385: recipe for target 'all' failed [ 610s] make[1]: *** [all] Error 2 [ 610s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 610s] dh_auto_build: make -j1 returned exit code 2 [ 610s] debian/rules:45: recipe for target 'build' failed [ 610s] make: *** [build] Error 2 [ 610s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 610s] [ 610s] armbuild25 failed "build osmo-sgsn_1.4.0.28.43f16.dsc" at Tue Jul 16 17:53:04 UTC 2019. [ 610s] [ 610s] ### VM INTERACTION START ### [ 613s] [ 544.428949] sysrq: SysRq : Power Off [ 613s] [ 544.446429] reboot: Power down [ 614s] ### VM INTERACTION END ### [ 614s] [ 614s] armbuild25 failed "build osmo-sgsn_1.4.0.28.43f16.dsc" at Tue Jul 16 17:53:08 UTC 2019. [ 614s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Jul 16 17:53:40 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 17:53:40 +0000 Subject: Change in ...osmo-trx[master]: fixup: trxd_hdr_v1_specific: fix MTS encoding In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14783 ) Change subject: fixup: trxd_hdr_v1_specific: fix MTS encoding ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/14783/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14783/1//COMMIT_MSG at 9 PS1, Line 9: Somehow > I found a Russian article with a brief explanation of the problem: https://www.stableit. [?] The article explains the issue but not really WHY it happens (reason for it to be that way). In my understanding it looks like a compiler bug. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9c0b7eef1464524e93fe0945acbdbf3d557c5664 Gerrit-Change-Number: 14783 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 17:53:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 17:54:23 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Jul 2019 17:54:23 +0000 Subject: Change in ...osmocom-bb[master]: target/*.py: use python3 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14759 ) Change subject: target/*.py: use python3 ...................................................................... Patch Set 2: Code-Review-1 (1 comment) I still don't think we should enforce Python3 for TRX Toolkit. Yes, Python2 is almost dead, but what would we gain from that right now? Any new features? or bug fixes? Let's just make it work with both by changing to '#!/usr/bin/env python'. https://gerrit.osmocom.org/#/c/14759/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14759/2//COMMIT_MSG at 12 PS2, Line 12: FIXME: untested We need to be sure that everything works smooth with python3 first. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 Gerrit-Change-Number: 14759 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 17:54:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 17:58:07 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 17:58:07 +0000 Subject: Change in ...osmo-trx[master]: fixup: pullRadioVector(): properly set modulation type In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14784 ) Change subject: fixup: pullRadioVector(): properly set modulation type ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie576762b8074047dc77bddc32d16fc8ad7ed9c5d Gerrit-Change-Number: 14784 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 17:58:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 18:00:23 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 18:00:23 +0000 Subject: Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14758 ) Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 18:00:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 18:12:52 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 18:12:52 +0000 Subject: Change in ...osmo-iuh[master]: osmo-hnbgw.cfg: set local-ip to 127.0.0.1 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14782 ) Change subject: osmo-hnbgw.cfg: set local-ip to 127.0.0.1 ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14782/1/doc/examples/osmo-hnbgw.cfg File doc/examples/osmo-hnbgw.cfg: https://gerrit.osmocom.org/#/c/14782/1/doc/examples/osmo-hnbgw.cfg at 24 PS1, Line 24: local-ip 127.0.0.1 be careful with that, iirc usually this IP needs to be non-localhost since it has to connect to the nano3g or whatever, which is in another host. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec Gerrit-Change-Number: 14782 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 18:12:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 18:19:32 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 18:19:32 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14785 ) Change subject: driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8396004616754f84fb465c972fde9e91b18cc49b Gerrit-Change-Number: 14785 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 18:19:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 18:20:47 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 18:20:47 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): enrich logging message In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14788 ) Change subject: driveTxPriorityQueue(): enrich logging message ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If25c2171f7d1ab98d65f0dbf93d0d8a5a635caf7 Gerrit-Change-Number: 14788 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 18:20:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 18:25:43 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 18:25:43 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14195 ) Change subject: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler ...................................................................... Patch Set 3: > Patch Set 3: > > I think we should rather tag a new libosmocore and update the dependency requirement everywhere. I'm not against this single fix, but I guess we'd have to fix lots of places if we want to avoid any trouble with old libosmocore? Agree with Harald, same reasons he explained. So I'm strongly against merging this change. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: If9b0c0d031477ca87786aab5c269d00748e896c8 Gerrit-Change-Number: 14195 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 18:25:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 18:33:37 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Jul 2019 18:33:37 +0000 Subject: Change in ...osmo-iuh[master]: osmo-hnbgw.cfg: set local-ip to 127.0.0.1 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14782 ) Change subject: osmo-hnbgw.cfg: set local-ip to 127.0.0.1 ...................................................................... Patch Set 1: -Code-Review (1 comment) https://gerrit.osmocom.org/#/c/14782/1/doc/examples/osmo-hnbgw.cfg File doc/examples/osmo-hnbgw.cfg: https://gerrit.osmocom.org/#/c/14782/1/doc/examples/osmo-hnbgw.cfg at 24 PS1, Line 24: local-ip 127.0.0.1 > be careful with that, iirc usually this IP needs to be non-localhost since it has to connect to the [?] ACK. How about 0.0.0.0 then? -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec Gerrit-Change-Number: 14782 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 18:33:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 18:34:37 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Jul 2019 18:34:37 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler In-Reply-To: References: Message-ID: fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14195 ) Change subject: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: If9b0c0d031477ca87786aab5c269d00748e896c8 Gerrit-Change-Number: 14195 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 18:41:13 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 18:41:13 +0000 Subject: Change in ...osmo-ci[master]: osmocom-debian-install.yml: update description In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14789 ) Change subject: osmocom-debian-install.yml: update description ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I17d2e9e0ac7fe77fb0306724a1f1e15641d76854 Gerrit-Change-Number: 14789 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 18:41:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 18:41:49 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 18:41:49 +0000 Subject: Change in ...osmo-ci[master]: osmocom-debian-install.yml: add BRANCH variable In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14790 ) Change subject: osmocom-debian-install.yml: add BRANCH variable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ice4662551625b3c96ca105629a934a0a081db2e4 Gerrit-Change-Number: 14790 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 18:41:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 18:45:50 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 18:45:50 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add docker container In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14779 ) Change subject: debian-repo-install-test: add docker container ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14779/2/debian-repo-install-test/jenkins.sh File debian-repo-install-test/jenkins.sh: https://gerrit.osmocom.org/#/c/14779/2/debian-repo-install-test/jenkins.sh at 24 PS2, Line 24: if ! docker exec "$BUILD_TAG" systemctl status; then In order to avoid race conditions on busy/slow systems, it would make more sense to have a 10 time loop here with a sleep 1, and after 10 seconds then exit 1. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 Gerrit-Change-Number: 14779 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 18:45:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 18:50:50 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 18:50:50 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: kill already running In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14780 ) Change subject: debian-repo-install-test: kill already running ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f Gerrit-Change-Number: 14780 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 18:50:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 18:59:20 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 18:59:20 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: run systemd services In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14781 ) Change subject: debian-repo-install-test: run systemd services ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14781/3/debian-repo-install-test/jenkins.sh File debian-repo-install-test/jenkins.sh: https://gerrit.osmocom.org/#/c/14781/3/debian-repo-install-test/jenkins.sh at 17 PS3, Line 17: # * SYS_NICE: needed for changing CPUScheduling{Policy,Priority} (osmo-bts systemd service files) osmo-trx also needs this one, in case it's of interest in here. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie6385f85560fefa7e7c9dca72cb5e2e914d4507a Gerrit-Change-Number: 14781 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 18:59:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:00:55 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 19:00:55 +0000 Subject: Change in ...osmo-bsc[master]: osmo-bsc.cfg: work with osmo-bts example cfg In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14791 ) Change subject: osmo-bsc.cfg: work with osmo-bts example cfg ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie8001611756b661ff1871508c6248b2e990ba1d7 Gerrit-Change-Number: 14791 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 19:00:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:01:49 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 19:01:49 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-gtphub.cfg: fix conflict with osmo-sgsn.cfg In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14792 ) Change subject: osmo-gtphub.cfg: fix conflict with osmo-sgsn.cfg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id892e1f4ab2daabbe9824b819b5fed985373b97a Gerrit-Change-Number: 14792 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 19:01:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:03:50 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 19:03:50 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 ) Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Patch Set 5: > Nope, we don't. We always expected the value in centiBels, I just changed the command description a bit. Ok, fine then! -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 19:03:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:35:50 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:35:50 +0000 Subject: Change in ...libosmocore[master]: Set HTML_TIMESTAMP to NO to make build reproducible Message-ID: Hello Ruben Undheim, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14795 to review the following change. Change subject: Set HTML_TIMESTAMP to NO to make build reproducible ...................................................................... Set HTML_TIMESTAMP to NO to make build reproducible Change-Id: I56cce5cda0621f5e9f1c28aaad4646e9e267d17d --- M Doxyfile.codec.in M Doxyfile.core.in M Doxyfile.gsm.in M Doxyfile.vty.in 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/95/14795/1 diff --git a/Doxyfile.codec.in b/Doxyfile.codec.in index 307e3e1..88f0d27 100644 --- a/Doxyfile.codec.in +++ b/Doxyfile.codec.in @@ -891,7 +891,7 @@ # page will contain the date and time when the page was generated. Setting # this to NO can help when comparing the output of multiple runs. -HTML_TIMESTAMP = YES +HTML_TIMESTAMP = NO # If the HTML_ALIGN_MEMBERS tag is set to YES, the members of classes, # files or namespaces will be aligned in HTML using tables. If set to diff --git a/Doxyfile.core.in b/Doxyfile.core.in index f83205a..c2bfcd5 100644 --- a/Doxyfile.core.in +++ b/Doxyfile.core.in @@ -891,7 +891,7 @@ # page will contain the date and time when the page was generated. Setting # this to NO can help when comparing the output of multiple runs. -HTML_TIMESTAMP = YES +HTML_TIMESTAMP = NO # If the HTML_ALIGN_MEMBERS tag is set to YES, the members of classes, # files or namespaces will be aligned in HTML using tables. If set to diff --git a/Doxyfile.gsm.in b/Doxyfile.gsm.in index aae0e89..fd89390 100644 --- a/Doxyfile.gsm.in +++ b/Doxyfile.gsm.in @@ -891,7 +891,7 @@ # page will contain the date and time when the page was generated. Setting # this to NO can help when comparing the output of multiple runs. -HTML_TIMESTAMP = YES +HTML_TIMESTAMP = NO # If the HTML_ALIGN_MEMBERS tag is set to YES, the members of classes, # files or namespaces will be aligned in HTML using tables. If set to diff --git a/Doxyfile.vty.in b/Doxyfile.vty.in index fb1cabf..9f56fd7 100644 --- a/Doxyfile.vty.in +++ b/Doxyfile.vty.in @@ -891,7 +891,7 @@ # page will contain the date and time when the page was generated. Setting # this to NO can help when comparing the output of multiple runs. -HTML_TIMESTAMP = YES +HTML_TIMESTAMP = NO # If the HTML_ALIGN_MEMBERS tag is set to YES, the members of classes, # files or namespaces will be aligned in HTML using tables. If set to -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I56cce5cda0621f5e9f1c28aaad4646e9e267d17d Gerrit-Change-Number: 14795 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Ruben Undheim Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:35:51 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:35:51 +0000 Subject: Change in ...libosmocore[master]: TIMER constants not on some architectures Message-ID: Hello Ruben Undheim, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14796 to review the following change. Change subject: TIMER constants not on some architectures ...................................................................... TIMER constants not on some architectures Change-Id: If24616c3dbf9f1eb6053caed90a63b590d3f5833 --- M src/timer_clockgettime.c M tests/timer/clk_override_test.c 2 files changed, 17 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/96/14796/1 diff --git a/src/timer_clockgettime.c b/src/timer_clockgettime.c index 7b17fd1..b610b30 100644 --- a/src/timer_clockgettime.c +++ b/src/timer_clockgettime.c @@ -75,20 +75,26 @@ switch(clk_id) { case CLOCK_REALTIME: return &realtime; - case CLOCK_REALTIME_COARSE: - return &realtime_coarse; case CLOCK_MONOTONIC: return &mono; - case CLOCK_MONOTONIC_COARSE: - return &mono_coarse; - case CLOCK_MONOTONIC_RAW: - return &mono_raw; - case CLOCK_BOOTTIME: - return &boottime; case CLOCK_PROCESS_CPUTIME_ID: return &proc_cputime_id; case CLOCK_THREAD_CPUTIME_ID: return &th_cputime_id; +#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) +#else + case CLOCK_REALTIME_COARSE: + return &realtime_coarse; + case CLOCK_MONOTONIC_COARSE: + return &mono_coarse; + case CLOCK_MONOTONIC_RAW: + return &mono_raw; +#endif +#if defined(__GNU__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__) +#else + case CLOCK_BOOTTIME: + return &boottime; +#endif default: return NULL; } diff --git a/tests/timer/clk_override_test.c b/tests/timer/clk_override_test.c index 308e821..73673a2 100644 --- a/tests/timer/clk_override_test.c +++ b/tests/timer/clk_override_test.c @@ -40,12 +40,15 @@ struct timespec read1, read2, res; struct timespec *mono; +#if defined(__GNU__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__) +#else osmo_clock_gettime(CLOCK_BOOTTIME, &read1); usleep(500); osmo_clock_gettime(CLOCK_BOOTTIME, &read2); if (!timespeccmp(&read2, &read1, >)) return EXIT_FAILURE; printf("Non implemented clocks work fine\n"); +#endif osmo_clock_gettime(CLOCK_MONOTONIC, &read1); usleep(500); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14796 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If24616c3dbf9f1eb6053caed90a63b590d3f5833 Gerrit-Change-Number: 14796 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Ruben Undheim Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:35:51 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:35:51 +0000 Subject: Change in ...libosmocore[master]: MAXPATHLEN set if not defined Message-ID: Hello Ruben Undheim, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14797 to review the following change. Change subject: MAXPATHLEN set if not defined ...................................................................... MAXPATHLEN set if not defined Change-Id: I1dce8ace228814b5a7246a00b31309ab9461d266 --- M src/vty/command.c M src/vty/vty.c 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/97/14797/1 diff --git a/src/vty/command.c b/src/vty/command.c index 454a10c..35169eb 100644 --- a/src/vty/command.c +++ b/src/vty/command.c @@ -47,6 +47,11 @@ #include #include +#ifndef MAXPATHLEN + #define MAXPATHLEN 4096 +#endif + + /*! \addtogroup command * @{ * VTY command handling diff --git a/src/vty/vty.c b/src/vty/vty.c index 98b332d..9a998eb 100644 --- a/src/vty/vty.c +++ b/src/vty/vty.c @@ -67,6 +67,11 @@ #include #include +#ifndef MAXPATHLEN + #define MAXPATHLEN 4096 +#endif + + /* \addtogroup vty * @{ * \file vty.c */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14797 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1dce8ace228814b5a7246a00b31309ab9461d266 Gerrit-Change-Number: 14797 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Ruben Undheim Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:35:52 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:35:52 +0000 Subject: Change in ...libosmocore[master]: No fail if no /proc/cpuinfo Message-ID: Hello Ruben Undheim, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14798 to review the following change. Change subject: No fail if no /proc/cpuinfo ...................................................................... No fail if no /proc/cpuinfo Change-Id: I4b9e12e34f69d98fa87179c7ee390e31001ec943 --- M tests/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/98/14798/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index a8a06c5..4a8a7cf 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -331,7 +331,7 @@ TESTSUITE = $(srcdir)/testsuite check-local: atconfig $(TESTSUITE) - cat /proc/cpuinfo + cat /proc/cpuinfo || true $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) $(MAKE) $(AM_MAKEFLAGS) ext-tests -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14798 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4b9e12e34f69d98fa87179c7ee390e31001ec943 Gerrit-Change-Number: 14798 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Ruben Undheim Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:39:55 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:39:55 +0000 Subject: Change in ...libosmo-abis[master]: spelling Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14800 Change subject: spelling ...................................................................... spelling =================================================================== Change-Id: I22c98915648760a83abd5f0004af26d426a5e518 --- M src/input/ipa.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/00/14800/1 diff --git a/src/input/ipa.c b/src/input/ipa.c index 25eeb4a..8aed7b3 100644 --- a/src/input/ipa.c +++ b/src/input/ipa.c @@ -272,7 +272,7 @@ ret = link->accept_cb(link, fd); if (ret < 0) { LOGP(DLINP, LOGL_ERROR, - "failed to processs accept()ed new link, " + "failed to process accept()ed new link, " "reason=`%s'\n", strerror(-ret)); close(fd); return ret; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14800 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I22c98915648760a83abd5f0004af26d426a5e518 Gerrit-Change-Number: 14800 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:41:12 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:41:12 +0000 Subject: Change in ...osmo-pcu[master]: fix spelling errors detected by lintian Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14801 Change subject: fix spelling errors detected by lintian ...................................................................... fix spelling errors detected by lintian Change-Id: I381618eb55cc513cfa9c2e384c27cead0935c8bf --- M src/bts.cpp M src/decoding.cpp M src/encoding.cpp M src/gsm_rlcmac.cpp M src/gsm_rlcmac.h M src/pcu_l1_if.cpp M src/pdch.cpp M src/tbf.cpp M src/tbf.h 9 files changed, 14 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/01/14801/1 diff --git a/src/bts.cpp b/src/bts.cpp index e07b840..2da78ea 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -611,7 +611,7 @@ * we roll back the rounded frame number by one RFN_MODULUS */ if (abs(rfn - m_cur_rfn) > RFN_THRESHOLD) { LOGP(DRLCMAC, LOGL_DEBUG, - "Race condition between rfn (%u) and m_cur_fn (%u) detected: rfn belongs to the previos modulus %u cycle, wrappng...\n", + "Race condition between rfn (%u) and m_cur_fn (%u) detected: rfn belongs to the previous modulus %u cycle, wrapping...\n", rfn, m_cur_fn, RFN_MODULUS); if (fn_rounded < RFN_MODULUS) { LOGP(DRLCMAC, LOGL_DEBUG, diff --git a/src/decoding.cpp b/src/decoding.cpp index d439e30..99a17dc 100644 --- a/src/decoding.cpp +++ b/src/decoding.cpp @@ -77,7 +77,7 @@ /* TS 44.060, table 10.4.14a.1, row 3 & 5 */ /* only filling bytes left */ LOGP(DRLCMACUL, LOGL_DEBUG, "UL DATA LI contains " - "only filling bytes with extention octet: LI=%d, E=%d, count=%d\n", + "only filling bytes with extension octet: LI=%d, E=%d, count=%d\n", li->li, li->e, num_chunks); break; } else if (li->li > 0) { @@ -92,7 +92,7 @@ } LOGP(DRLCMACUL, LOGL_DEBUG, "UL DATA LI contains " - "extention octet: LI=%d, E=%d, count=%d\n", + "extension octet: LI=%d, E=%d, count=%d\n", li->li, li->e, num_chunks); num_chunks += 1; @@ -168,7 +168,7 @@ chunks[num_chunks].is_complete = li->li || is_last_block; LOGP(DRLCMACUL, LOGL_DEBUG, "UL DATA LI contains " - "extention octet: LI=%d, M=%d, E=%d, count=%d\n", + "extension octet: LI=%d, M=%d, E=%d, count=%d\n", li->li, li->m, li->e, num_chunks); num_chunks += 1; diff --git a/src/encoding.cpp b/src/encoding.cpp index a290c65..0b3e16d 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -532,7 +532,7 @@ if (rc < 0) { LOGP(DRLCMAC, LOGL_ERROR, - "Failed to create IMMEDIATE ASSIGMENT (%s) for %s\n", + "Failed to create IMMEDIATE ASSIGNMENT (%s) for %s\n", downlink ? "downlink" : "uplink", tbf ? tbf->name() : "single block allocation"); return rc; diff --git a/src/gsm_rlcmac.cpp b/src/gsm_rlcmac.cpp index 6323b09..ef7abcd 100644 --- a/src/gsm_rlcmac.cpp +++ b/src/gsm_rlcmac.cpp @@ -1363,8 +1363,8 @@ static const CSN_DESCR_BEGIN(PCCF_AdditionsR5_t) - M_NEXT_EXIST (PCCF_AdditionsR5_t, Exist_G_RNTI_extention, 1), - M_UINT (PCCF_AdditionsR5_t, G_RNTI_extention, 4), + M_NEXT_EXIST (PCCF_AdditionsR5_t, Exist_G_RNTI_extension, 1), + M_UINT (PCCF_AdditionsR5_t, G_RNTI_extension, 4), M_NEXT_EXIST_OR_NULL(PCCF_AdditionsR5_t, Exist_AdditionsR8, 1), M_TYPE (PCCF_AdditionsR5_t, AdditionsR8, PCCF_AdditionsR8_t), CSN_DESCR_END (PCCF_AdditionsR5_t) diff --git a/src/gsm_rlcmac.h b/src/gsm_rlcmac.h index 2ad1937..a4750e8 100644 --- a/src/gsm_rlcmac.h +++ b/src/gsm_rlcmac.h @@ -1602,8 +1602,8 @@ typedef struct { - guint8 Exist_G_RNTI_extention; - guint8 G_RNTI_extention; + guint8 Exist_G_RNTI_extension; + guint8 G_RNTI_extension; guint8 Exist_AdditionsR8; PCCF_AdditionsR8_t AdditionsR8; } PCCF_AdditionsR5_t; diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 5cabe4f..5b0acf4 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -650,7 +650,7 @@ rc = pcu_rx_susp_req(&pcu_prim->u.susp_req); break; default: - LOGP(DL1IF, LOGL_ERROR, "Received unknwon PCU msg type %d\n", + LOGP(DL1IF, LOGL_ERROR, "Received unknown PCU msg type %d\n", msg_type); rc = -EINVAL; } diff --git a/src/pdch.cpp b/src/pdch.cpp index 8003105..7488b96 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -632,7 +632,7 @@ int8_t tfi = request->ID.u.Global_TFI.u.DOWNLINK_TFI; dl_tbf = bts()->dl_tbf_by_tfi(tfi, trx_no(), ts_no); if (!dl_tbf) { - LOGP(DRLCMAC, LOGL_NOTICE, "PACKET RESSOURCE REQ unknown downlink TFI=%d\n", tfi); + LOGP(DRLCMAC, LOGL_NOTICE, "PACKET RESOURCE REQ unknown downlink TFI=%d\n", tfi); return; } LOGPTBFDL(dl_tbf, LOGL_ERROR, @@ -645,7 +645,7 @@ int8_t tfi = request->ID.u.Global_TFI.u.UPLINK_TFI; ul_tbf = bts()->ul_tbf_by_tfi(tfi, trx_no(), ts_no); if (!ul_tbf) { - LOGP(DRLCMAC, LOGL_NOTICE, "PACKET RESSOURCE REQ unknown uplink TFI=%d\n", tfi); + LOGP(DRLCMAC, LOGL_NOTICE, "PACKET RESOURCE REQ unknown uplink TFI=%d\n", tfi); return; } LOGPTBFUL(ul_tbf, LOGL_ERROR, diff --git a/src/tbf.cpp b/src/tbf.cpp index a099322..9856c7f 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -1208,7 +1208,7 @@ if (direction == GPRS_RLCMAC_DL_TBF && !is_control_ts(ts)) { LOGPTBF(this, LOGL_NOTICE, - "Cannot poll for downlink assigment, because MS cannot reply. (TS=%d, first common TS=%d)\n", + "Cannot poll for downlink assignment, because MS cannot reply. (TS=%d, first common TS=%d)\n", ts, first_common_ts); poll_ass_dl = 0; } diff --git a/src/tbf.h b/src/tbf.h index 0a58862..34e8101 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -43,7 +43,7 @@ */ #define T_ASS_AGCH_USEC 200000 /* waiting after IMM.ASS confirm */ -#define T_ASS_PACCH_SEC 2 /* timeout for pacch assigment */ +#define T_ASS_PACCH_SEC 2 /* timeout for pacch assignment */ #define T_REJ_PACCH_USEC 2000 /* timeout for tbf reject for PRR*/ enum gprs_rlcmac_tbf_state { -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14801 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I381618eb55cc513cfa9c2e384c27cead0935c8bf Gerrit-Change-Number: 14801 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:41:12 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:41:12 +0000 Subject: Change in ...osmo-pcu[master]: Add structs for big-endian Message-ID: Hello Ruben Undheim, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/14802 to review the following change. Change subject: Add structs for big-endian ...................................................................... Add structs for big-endian Change-Id: I6af6d5ef05a8b240acfd9da747d9657bb6aa0ef8 --- M src/rlc.h 1 file changed, 35 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/02/14802/1 diff --git a/src/rlc.h b/src/rlc.h index 5b6a0dd..7881256 100644 --- a/src/rlc.h +++ b/src/rlc.h @@ -409,7 +409,41 @@ li:7; } __attribute__ ((packed)); #else -# error "Only little endian headers are supported yet. TODO: add missing structs" +struct rlc_ul_header { + uint8_t pt:2, + cv:4, + si:1, + r:1; + uint8_t spare:1, + pi:1, + tfi:5, + ti:1; + uint8_t bsn:7, + e:1; +} __attribute__ ((packed)); + +struct rlc_dl_header { + uint8_t pt:2, + rrbp:2, + s_p:1, + usf:3; + uint8_t pr:2, + tfi:5, + fbi:1; + uint8_t bsn:7, + e:1; +} __attribute__ ((packed)); + +struct rlc_li_field { + uint8_t li:6, + m:1, + e:1; +} __attribute__ ((packed)); + +struct rlc_li_field_egprs { + uint8_t li:7, + e:1; +} __attribute__ ((packed)); #endif } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6af6d5ef05a8b240acfd9da747d9657bb6aa0ef8 Gerrit-Change-Number: 14802 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Ruben Undheim Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:42:19 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:42:19 +0000 Subject: Change in ...libosmo-sccp[master]: This patch fixes typos on which Lintian complains Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14803 Change subject: This patch fixes typos on which Lintian complains ...................................................................... This patch fixes typos on which Lintian complains Change-Id: I657c694a9a7474182a97f90aa8424403ca9c58db --- M src/m3ua.c M stp/stp_main.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/03/14803/1 diff --git a/src/m3ua.c b/src/m3ua.c index d7ede40..d733b51 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -91,7 +91,7 @@ }; const struct value_string m3ua_ntfy_other_names[] = { - { M3UA_NOTIFY_I_OT_INS_RES, "Insufficient ASP Resouces active in AS" }, + { M3UA_NOTIFY_I_OT_INS_RES, "Insufficient ASP Resources active in AS" }, { M3UA_NOTIFY_I_OT_ALT_ASP_ACT, "Alternative ASP Active" }, { M3UA_NOTIFY_I_OT_ASP_FAILURE, "ASP Failure" }, { 0, NULL } diff --git a/stp/stp_main.c b/stp/stp_main.c index 6a47403..ff33959 100644 --- a/stp/stp_main.c +++ b/stp/stp_main.c @@ -85,7 +85,7 @@ static void print_help(void) { printf(" -h --help This text.\n"); - printf(" -D --daemonize Fork teh process into a background daemon\n"); + printf(" -D --daemonize Fork the process into a background daemon\n"); printf(" -c --config-file filename The config file to use. Default: ./osmo-stp.cfg\n"); printf(" -V --version Print the version of OsmoSTP\n"); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14803 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I657c694a9a7474182a97f90aa8424403ca9c58db Gerrit-Change-Number: 14803 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:42:19 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:42:19 +0000 Subject: Change in ...libosmo-sccp[master]: _change_systemd_service_file Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14804 Change subject: _change_systemd_service_file ...................................................................... _change_systemd_service_file Change-Id: Ia112dec6b61853cbfe1222cf4b7aecfe305ddb99 Documentation: This patch adds Documentation field to systemd service file --- M contrib/systemd/osmo-stp.service 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/04/14804/1 diff --git a/contrib/systemd/osmo-stp.service b/contrib/systemd/osmo-stp.service index 5d06870..87b414b 100644 --- a/contrib/systemd/osmo-stp.service +++ b/contrib/systemd/osmo-stp.service @@ -1,5 +1,6 @@ [Unit] Description=Osmocom STP (Signal Transfer Point) +Documentation=https://osmocom.org/projects/osmo-stp/wiki [Service] Type=simple -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia112dec6b61853cbfe1222cf4b7aecfe305ddb99 Gerrit-Change-Number: 14804 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:46:13 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:46:13 +0000 Subject: Change in ...osmo-hlr[master]: Fix test for return codes on mipsel and alpha archs Message-ID: Hello Ruben Undheim, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/14805 to review the following change. Change subject: Fix test for return codes on mipsel and alpha archs ...................................................................... Fix test for return codes on mipsel and alpha archs Change-Id: Ia64f1d9f39fe2b1fb704f7b6c4d9cce93ab708cd --- M tests/db/db_test.c M tests/db/db_test.err 2 files changed, 27 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/05/14805/1 diff --git a/tests/db/db_test.c b/tests/db/db_test.c index fdd62c5..1243cab 100644 --- a/tests/db/db_test.c +++ b/tests/db/db_test.c @@ -51,7 +51,12 @@ * The return code is then available in g_rc. */ #define ASSERT_RC(call, expect_rc) \ do { \ - fprintf(stderr, #call " --> " #expect_rc "\n"); \ + if ((expect_rc) == -ENOKEY) \ + fprintf(stderr, #call " --> -ENOKEY\n"); \ + else if ((expect_rc) == -ENOTSUP) \ + fprintf(stderr, #call " --> -ENOTSUP\n"); \ + else \ + fprintf(stderr, #call " --> " #expect_rc "\n"); \ g_rc = call; \ if (g_rc != (expect_rc)) \ fprintf(stderr, " MISMATCH: got rc = %d, expected: " \ @@ -67,7 +72,12 @@ do { \ int rc; \ fill_invalid(g_subscr); \ - fprintf(stderr, "db_subscr_get_by_" #by "(dbc, " #val ", &g_subscr) --> " \ + if ((expect_rc) == -ENOKEY) \ + fprintf(stderr, "db_subscr_get_by_" #by "(dbc, " #val ", &g_subscr) --> -ENOKEY \n"); \ + else if ((expect_rc) == -ENOTSUP) \ + fprintf(stderr, "db_subscr_get_by_" #by "(dbc, " #val ", &g_subscr) --> -ENOTSUP \n"); \ + else \ + fprintf(stderr, "db_subscr_get_by_" #by "(dbc, " #val ", &g_subscr) --> " \ #expect_rc "\n"); \ rc = db_subscr_get_by_##by(dbc, val, &g_subscr); \ if (rc != (expect_rc)) \ diff --git a/tests/db/db_test.err b/tests/db/db_test.err index 4dc77e8..98546ce 100644 --- a/tests/db/db_test.err +++ b/tests/db/db_test.err @@ -828,12 +828,12 @@ .imsi = '123456789000000', } -db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -126 +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data -db_get_auc(dbc, imsi0, 3, vec, N_VECTORS, NULL, NULL) --> -126 +db_get_auc(dbc, imsi0, 3, vec, N_VECTORS, NULL, NULL) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data @@ -910,12 +910,12 @@ db_subscr_update_aud_by_id(dbc, id, mk_aud_2g(OSMO_AUTH_ALG_NONE, NULL)) --> 0 -db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -126 +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data -db_get_auc(dbc, imsi0, 3, vec, N_VECTORS, NULL, NULL) --> -126 +db_get_auc(dbc, imsi0, 3, vec, N_VECTORS, NULL, NULL) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data @@ -935,12 +935,12 @@ db_subscr_update_aud_by_id(dbc, id, mk_aud_2g(OSMO_AUTH_ALG_NONE, "f000000000000f00000000000f000000")) --> 0 -db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -126 +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data -db_get_auc(dbc, imsi0, 3, vec, N_VECTORS, NULL, NULL) --> -126 +db_get_auc(dbc, imsi0, 3, vec, N_VECTORS, NULL, NULL) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data @@ -1037,12 +1037,12 @@ db_subscr_update_aud_by_id(dbc, id, mk_aud_3g(OSMO_AUTH_ALG_NONE, NULL, false, NULL, 0)) --> 0 -db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -126 +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data -db_get_auc(dbc, imsi0, 3, vec, N_VECTORS, NULL, NULL) --> -126 +db_get_auc(dbc, imsi0, 3, vec, N_VECTORS, NULL, NULL) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data @@ -1072,12 +1072,12 @@ db_subscr_update_aud_by_id(dbc, id, mk_aud_3g(OSMO_AUTH_ALG_NONE, "asdfasdfasd", false, "asdfasdfasdf", 99999)) --> 0 -db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -126 +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data -db_get_auc(dbc, imsi0, 3, vec, N_VECTORS, NULL, NULL) --> -126 +db_get_auc(dbc, imsi0, 3, vec, N_VECTORS, NULL, NULL) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data @@ -1318,12 +1318,12 @@ .imsi = '123456789000000', } -db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -126 +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data -db_get_auc(dbc, imsi0, 3, vec, N_VECTORS, NULL, NULL) --> -126 +db_get_auc(dbc, imsi0, 3, vec, N_VECTORS, NULL, NULL) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data @@ -1365,7 +1365,7 @@ .imsi = '123456789000000', } -db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -126 +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data @@ -1376,7 +1376,7 @@ db_update_sqn(dbc, id, 123) --> -ENOENT DAUC Cannot update SQN for subscriber ID=1: no auc_3g entry for such subscriber -db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -126 +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data @@ -1384,7 +1384,7 @@ db_update_sqn(dbc, id, 543) --> -ENOENT DAUC Cannot update SQN for subscriber ID=1: no auc_3g entry for such subscriber -db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -126 +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -ENOKEY DAUC IMSI='123456789000000': No 2G Auth Data DAUC IMSI='123456789000000': No 3G Auth Data -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ia64f1d9f39fe2b1fb704f7b6c4d9cce93ab708cd Gerrit-Change-Number: 14805 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Ruben Undheim Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:46:13 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:46:13 +0000 Subject: Change in ...osmo-hlr[master]: fix spelling errors detected by lintian Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14806 Change subject: fix spelling errors detected by lintian ...................................................................... fix spelling errors detected by lintian Change-Id: I2a1a21aceabc20fadc5dd28985a94689d2b873a2 --- M src/ctrl.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/06/14806/1 diff --git a/src/ctrl.c b/src/ctrl.c index 05a0107..c610d92 100644 --- a/src/ctrl.c +++ b/src/ctrl.c @@ -95,7 +95,7 @@ cmd->reply = "No such subscriber."; return false; default: - cmd->reply = "An unknown error has occured during get_subscriber()."; + cmd->reply = "An unknown error has occurred during get_subscriber()."; return false; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14806 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I2a1a21aceabc20fadc5dd28985a94689d2b873a2 Gerrit-Change-Number: 14806 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:46:41 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:46:41 +0000 Subject: Change in ...osmo-trx[master]: Fix spelling discovered by lintian Message-ID: Hello Ruben Undheim, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14807 to review the following change. Change subject: Fix spelling discovered by lintian ...................................................................... Fix spelling discovered by lintian Change-Id: I5ab9b9c7c47d0d6e674c1f5242e2b3a05006293e --- M Transceiver52M/osmo-trx.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/07/14807/1 diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index 06b1a18..b8cf968 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -255,7 +255,7 @@ { LOG(WARNING) << "Cmd line option '" << opt << "' is deprecated and will be soon removed." << " Please use VTY cfg option instead." - << " All cmd line options are already being overriden by VTY options if set."; + << " All cmd line options are already being overridden by VTY options if set."; } static void handle_options(int argc, char **argv, struct trx_ctx* trx) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14807 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5ab9b9c7c47d0d6e674c1f5242e2b3a05006293e Gerrit-Change-Number: 14807 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Ruben Undheim Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:48:53 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:48:53 +0000 Subject: Change in ...osmo-iuh[master]: spelling stuff found by lintian Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14808 Change subject: spelling stuff found by lintian ...................................................................... spelling stuff found by lintian Change-Id: I8434640701746d5db8707472d1d26c313e0814e9 --- M src/hnbgw_rua.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/08/14808/1 diff --git a/src/hnbgw_rua.c b/src/hnbgw_rua.c index 40d1d94..71c3f8e 100644 --- a/src/hnbgw_rua.c +++ b/src/hnbgw_rua.c @@ -505,7 +505,7 @@ static int rua_rx_successful_outcome_msg(struct msgb *msg, RUA_SuccessfulOutcome_t *in) { /* FIXME */ - LOGP(DRUA, LOGL_NOTICE, "Unexpected RUA Sucessful Outcome\n"); + LOGP(DRUA, LOGL_NOTICE, "Unexpected RUA Successful Outcome\n"); return -1; } -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8434640701746d5db8707472d1d26c313e0814e9 Gerrit-Change-Number: 14808 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:49:32 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 19:49:32 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support TRXD v1 In-Reply-To: References: Message-ID: Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 to look at the new patch set (#11). Change subject: Transceiver: Support TRXD v1 ...................................................................... Transceiver: Support TRXD v1 C/I value still needs to be computed and set in bi in pullRadioVector(). Related: OS#4006 Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/proto_trxd.c M Transceiver52M/proto_trxd.h 3 files changed, 98 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/57/14657/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 11 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:49:32 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 19:49:32 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): use trxd_hdr_common for message parsing In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#2) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/14786 ) Change subject: driveTxPriorityQueue(): use trxd_hdr_common for message parsing ...................................................................... driveTxPriorityQueue(): use trxd_hdr_common for message parsing Change-Id: If6a93e2b7fc9ada55edbdd16352cd4f7040e3d2a --- M Transceiver52M/Transceiver.cpp 1 file changed, 10 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/86/14786/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If6a93e2b7fc9ada55edbdd16352cd4f7040e3d2a Gerrit-Change-Number: 14786 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:49:32 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 19:49:32 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): check if message header format is supported In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#2) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/14787 ) Change subject: driveTxPriorityQueue(): check if message header format is supported ...................................................................... driveTxPriorityQueue(): check if message header format is supported Change-Id: I17abf95f5e23236abccc50476cd59931580f5cd3 --- M Transceiver52M/Transceiver.cpp 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/87/14787/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I17abf95f5e23236abccc50476cd59931580f5cd3 Gerrit-Change-Number: 14787 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:49:32 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 19:49:32 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): enrich logging message In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#2) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/14788 ) Change subject: driveTxPriorityQueue(): enrich logging message ...................................................................... driveTxPriorityQueue(): enrich logging message Change-Id: If25c2171f7d1ab98d65f0dbf93d0d8a5a635caf7 --- M Transceiver52M/Transceiver.cpp 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/88/14788/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If25c2171f7d1ab98d65f0dbf93d0d8a5a635caf7 Gerrit-Change-Number: 14788 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:51:04 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:51:04 +0000 Subject: Change in ...osmo-bsc[master]: bsc_subscr_conn_fsm: Log Tx of BSSMAP Clear Request with cause Message-ID: Hello pespin, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/14809 to review the following change. Change subject: bsc_subscr_conn_fsm: Log Tx of BSSMAP Clear Request with cause ...................................................................... bsc_subscr_conn_fsm: Log Tx of BSSMAP Clear Request with cause Change-Id: I75a92e990d78824367caa8836787d799e6e653bd --- M src/osmo-bsc/bsc_subscr_conn_fsm.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/09/14809/1 diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index 0830dee..bc5cb27 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -133,8 +133,12 @@ static void gscon_bssmap_clear(struct gsm_subscriber_connection *conn, enum gsm0808_cause cause) { - struct msgb *resp = gsm0808_create_clear_rqst(cause); + + struct msgb *resp; int rc; + + LOGPFSML(conn->fi, LOGL_DEBUG, "Tx BSSMAP CLEAR REQUEST(%s) to MSC\n", gsm0808_cause_name(cause)); + resp = gsm0808_create_clear_rqst(cause); if (!resp) { LOGPFSML(conn->fi, LOGL_ERROR, "Unable to compose BSSMAP Clear Request message\n"); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14809 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75a92e990d78824367caa8836787d799e6e653bd Gerrit-Change-Number: 14809 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:51:04 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:51:04 +0000 Subject: Change in ...osmo-bsc[master]: Fix some spelling errors found by lintian Message-ID: Hello Ruben Undheim, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/14810 to review the following change. Change subject: Fix some spelling errors found by lintian ...................................................................... Fix some spelling errors found by lintian Change-Id: I63a733f8bea69f355a6686d99c3aa194c8ac9012 --- M doc/manuals/vty/bsc_vty_reference.xml M src/osmo-bsc/a_reset.c M src/osmo-bsc/abis_om2000_vty.c M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/osmo_bsc_main.c M src/osmo-bsc/osmo_bsc_sigtran.c M src/osmo-bsc/osmo_bsc_vty.c M src/osmo-bsc/pcu_sock.c 8 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/10/14810/1 diff --git a/doc/manuals/vty/bsc_vty_reference.xml b/doc/manuals/vty/bsc_vty_reference.xml index 4d25e69..db4f2c1 100644 --- a/doc/manuals/vty/bsc_vty_reference.xml +++ b/doc/manuals/vty/bsc_vty_reference.xml @@ -2958,7 +2958,7 @@ - + @@ -4830,7 +4830,7 @@ - + @@ -4841,7 +4841,7 @@ - + diff --git a/src/osmo-bsc/a_reset.c b/src/osmo-bsc/a_reset.c index 3c21142..fc59ff4 100644 --- a/src/osmo-bsc/a_reset.c +++ b/src/osmo-bsc/a_reset.c @@ -71,7 +71,7 @@ { struct reset_ctx *reset_ctx = (struct reset_ctx *)fi->priv; OSMO_ASSERT(reset_ctx); - LOGPFSML(fi, LOGL_NOTICE, "SIGTRAN connection succeded.\n"); + LOGPFSML(fi, LOGL_NOTICE, "SIGTRAN connection succeeded.\n"); reset_ctx->conn_loss_counter = 0; osmo_fsm_inst_state_chg(fi, ST_CONN, 0, 0); diff --git a/src/osmo-bsc/abis_om2000_vty.c b/src/osmo-bsc/abis_om2000_vty.c index faf39c1..3ae870e 100644 --- a/src/osmo-bsc/abis_om2000_vty.c +++ b/src/osmo-bsc/abis_om2000_vty.c @@ -368,7 +368,7 @@ #define CON_PATH_HELP "CON Path (In/Out)\n" \ "Add CON Path to Concentration Group\n" \ "Delete CON Path from Concentration Group\n" \ - "CON Conection Point\n" \ + "CON Connection Point\n" \ "Contiguity Index\n" \ DEFUN(cfg_om2k_con_path_dec, cfg_om2k_con_path_dec_cmd, diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index c4e091c..24f8313 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -2371,7 +2371,7 @@ DEFUN(cfg_bts_challoc, cfg_bts_challoc_cmd, "channel allocator (ascending|descending)", - "Channnel Allocator\n" "Channel Allocator\n" + "Channel Allocator\n" "Channel Allocator\n" "Allocate Timeslots and Transceivers in ascending order\n" "Allocate Timeslots and Transceivers in descending order\n") { diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index 0e0e8ca..aba8c40 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -906,7 +906,7 @@ } if (osmo_bsc_sigtran_init(&bsc_gsmnet->bsc_data->mscs) != 0) { - LOGP(DNM, LOGL_ERROR, "Failed to initalize sigtran backhaul.\n"); + LOGP(DNM, LOGL_ERROR, "Failed to initialize sigtran backhaul.\n"); exit(1); } diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index 763e1e1..0bf48a7 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -564,7 +564,7 @@ /* Start MSC-Reset procedure */ a_reset_alloc(msc, msc_name, osmo_bsc_sigtran_reset_cb); - /* If we have detected that the SS7 configuration of the MSC we have just initalized + /* If we have detected that the SS7 configuration of the MSC we have just initialized * was incomplete or completely missing, we can not tolerate another incomplete * configuration. The reson for this is that we do only specify exactly one default * pointcode pair. We also specify localhost as default IP-Address. If we have wanted diff --git a/src/osmo-bsc/osmo_bsc_vty.c b/src/osmo-bsc/osmo_bsc_vty.c index 4591ad1..e656d70 100644 --- a/src/osmo-bsc/osmo_bsc_vty.c +++ b/src/osmo-bsc/osmo_bsc_vty.c @@ -569,7 +569,7 @@ if (addr->presence & OSMO_SCCP_ADDR_T_SSN) { if (addr->ssn != OSMO_SCCP_SSN_BSSAP) vty_out(vty, - "setting an SSN (%u) different from the standard (%u) is not allowd, will use standard SSN for address: %s%s", + "setting an SSN (%u) different from the standard (%u) is not allowed, will use standard SSN for address: %s%s", addr->ssn, OSMO_SCCP_SSN_BSSAP, osmo_sccp_addr_dump(addr), VTY_NEWLINE); } diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index b71621d..4425117 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -421,7 +421,7 @@ rc = pcu_rx_data_req(bts, msg_type, &pcu_prim->u.data_req); break; default: - LOGP(DPCU, LOGL_ERROR, "Received unknwon PCU msg type %d\n", + LOGP(DPCU, LOGL_ERROR, "Received unknown PCU msg type %d\n", msg_type); rc = -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14810 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I63a733f8bea69f355a6686d99c3aa194c8ac9012 Gerrit-Change-Number: 14810 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Ruben Undheim Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:51:04 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:51:04 +0000 Subject: Change in ...osmo-bsc[master]: Fix one struct for big-endian archs Message-ID: Hello Ruben Undheim, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/14811 to review the following change. Change subject: Fix one struct for big-endian archs ...................................................................... Fix one struct for big-endian archs Change-Id: Ic6e654e0d95d662942c6485097f0b96e1fa46ead --- M src/ipaccess/network_listen.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/11/14811/1 diff --git a/src/ipaccess/network_listen.c b/src/ipaccess/network_listen.c index bbaf798..d4fa4de 100644 --- a/src/ipaccess/network_listen.c +++ b/src/ipaccess/network_listen.c @@ -39,6 +39,8 @@ #include #include +#include + #define WHITELIST_MAX_SIZE ((NUM_ARFCNS*2)+2+1) int ipac_rxlevstat2whitelist(uint16_t *buf, const struct rxlev_stats *st, uint8_t min_rxlev, @@ -119,8 +121,13 @@ } __attribute__((packed)); struct ipacc_cusage_elem { +#if OSMO_IS_LITTLE_ENDIAN == 1 uint16_t arfcn:10, rxlev:6; +#else + uint16_t rxlev:6, + arfcn:10; +#endif } __attribute__ ((packed)); static int test_rep(void *_msg) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic6e654e0d95d662942c6485097f0b96e1fa46ead Gerrit-Change-Number: 14811 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Ruben Undheim Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:51:32 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:51:32 +0000 Subject: Change in ...osmo-msc[master]: add ipa keepalive for gsup connections to the hlr In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/14753 to look at the new patch set (#3). Change subject: add ipa keepalive for gsup connections to the hlr ...................................................................... add ipa keepalive for gsup connections to the hlr Change-Id: I7d0beb9357ab9b1baeb030d726f312008f2fc533 --- M doc/manuals/vty/msc_vty_reference.xml M include/osmocom/msc/gsm_data.h M include/osmocom/msc/gsup_client_mux.h M src/libmsc/gsup_client_mux.c M src/libmsc/msc_net_init.c M src/libmsc/msc_vty.c 6 files changed, 36 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/53/14753/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14753 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7d0beb9357ab9b1baeb030d726f312008f2fc533 Gerrit-Change-Number: 14753 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:51:35 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:51:35 +0000 Subject: Change in ...osmo-msc[master]: fix spelling detected by lintian Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14812 Change subject: fix spelling detected by lintian ...................................................................... fix spelling detected by lintian Change-Id: I01e54b5cf111677079a8ad57645d3ceb7834702a --- M doc/manuals/chapters/counters_generated.adoc M include/osmocom/msc/gsm_data.h M include/osmocom/msc/signal.h M src/libmsc/gsm_04_08.c 4 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/12/14812/1 diff --git a/doc/manuals/chapters/counters_generated.adoc b/doc/manuals/chapters/counters_generated.adoc index 6a3a3d2..1b40d8b 100644 --- a/doc/manuals/chapters/counters_generated.adoc +++ b/doc/manuals/chapters/counters_generated.adoc @@ -25,7 +25,7 @@ | sms:delivered | <> | Global SMS Deliver attempts. | sms:rp_err_mem | <> | CAUSE_MT_MEM_EXCEEDED errors of MS responses on a sms deliver attempt. | sms:rp_err_other | <> | Other error of MS responses on a sms delive attempt. -| sms:deliver_unknown_error | <> | Unknown error occured during sms delivery. +| sms:deliver_unknown_error | <> | Unknown error occurred during sms delivery. | call:mo_setup | <> | Received setup requests from a MS to init a MO call. | call:mo_connect_ack | <> | Received a connect ack from MS of a MO call. Call is now succesful connected up. | call:mt_setup | <> | Sent setup requests to the MS (MT). diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h index 20176ad..6c43379 100644 --- a/include/osmocom/msc/gsm_data.h +++ b/include/osmocom/msc/gsm_data.h @@ -79,7 +79,7 @@ [MSC_CTR_SMS_DELIVERED] = {"sms:delivered", "Global SMS Deliver attempts."}, [MSC_CTR_SMS_RP_ERR_MEM] = {"sms:rp_err_mem", "CAUSE_MT_MEM_EXCEEDED errors of MS responses on a sms deliver attempt."}, [MSC_CTR_SMS_RP_ERR_OTHER] = {"sms:rp_err_other", "Other error of MS responses on a sms delive attempt."}, - [MSC_CTR_SMS_DELIVER_UNKNOWN_ERROR] = {"sms:deliver_unknown_error", "Unknown error occured during sms delivery."}, + [MSC_CTR_SMS_DELIVER_UNKNOWN_ERROR] = {"sms:deliver_unknown_error", "Unknown error occurred during sms delivery."}, /* FIXME: count also sms delivered */ [MSC_CTR_CALL_MO_SETUP] = {"call:mo_setup", "Received setup requests from a MS to init a MO call."}, [MSC_CTR_CALL_MO_CONNECT_ACK] = {"call:mo_connect_ack", "Received a connect ack from MS of a MO call. Call is now succesful connected up."}, diff --git a/include/osmocom/msc/signal.h b/include/osmocom/msc/signal.h index 16b5678..c7f8991 100644 --- a/include/osmocom/msc/signal.h +++ b/include/osmocom/msc/signal.h @@ -89,7 +89,7 @@ struct vty *vty; }; struct sms_signal_data { - /* The transaction where this occured */ + /* The transaction where this occurred */ struct gsm_trans *trans; /* Can be NULL for SMMA */ struct gsm_sms *sms; diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index 57dff41..ee31747 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -389,7 +389,7 @@ /* From vlr_loc_update() we expect an implicit dispatch of * VLR_ULA_E_UPDATE_LA, and thus we expect msc_vlr_subscr_assoc() to - * already have been called and completed. Has an error occured? */ + * already have been called and completed. Has an error occurred? */ vsub = msc_a_vsub(msc_a); if (!vsub) { @@ -786,7 +786,7 @@ is_utran); /* From vlr_proc_acc_req() we expect an implicit dispatch of PR_ARQ_E_START we expect - * msc_vlr_subscr_assoc() to already have been called and completed. Has an error occured? */ + * msc_vlr_subscr_assoc() to already have been called and completed. Has an error occurred? */ vsub = msc_a_vsub(msc_a); if (!vsub) { LOG_MSC_A(msc_a, LOGL_ERROR, "subscriber not allowed to do a CM Service Request\n"); @@ -1158,7 +1158,7 @@ is_utran); /* >From vlr_proc_acc_req() we expect an implicit dispatch of PR_ARQ_E_START we expect - * msc_vlr_subscr_assoc() to already have been called and completed. Has an error occured? */ + * msc_vlr_subscr_assoc() to already have been called and completed. Has an error occurred? */ vsub = msc_a_vsub(msc_a); if (!vsub) { LOG_MSC_A(msc_a, LOGL_ERROR, "subscriber not allowed to do a Paging Response\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14812 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I01e54b5cf111677079a8ad57645d3ceb7834702a Gerrit-Change-Number: 14812 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:56:53 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:56:53 +0000 Subject: Change in ...osmo-bts[master]: fix spelling stuff mentioned by lintian Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14813 Change subject: fix spelling stuff mentioned by lintian ...................................................................... fix spelling stuff mentioned by lintian Change-Id: I3d6cb6fc1b182d8520ba60e431ab9b74e71d5e3c --- M src/common/pcu_sock.c M src/common/rsl.c M src/osmo-bts-octphy/l1_if.c M src/osmo-bts-trx/trx_vty.c 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/13/14813/1 diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 39b4568..1d9fa72 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -677,7 +677,7 @@ rc = pcu_rx_txt_ind(bts, &pcu_prim->u.txt_ind); break; default: - LOGP(DPCU, LOGL_ERROR, "Received unknwon PCU msg type %d\n", + LOGP(DPCU, LOGL_ERROR, "Received unknown PCU msg type %d\n", msg_type); rc = -EINVAL; } diff --git a/src/common/rsl.c b/src/common/rsl.c index 7630a8c..f7b68cb 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -3082,7 +3082,7 @@ msg->lchan = lchan_lookup(trx, dch->chan_nr, "RSL rx IPACC: "); if (!msg->lchan) { - LOGP(DRSL, LOGL_ERROR, "Rx RSL %s for unknow lchan\n", + LOGP(DRSL, LOGL_ERROR, "Rx RSL %s for unknown lchan\n", rsl_msg_name(dch->c.msg_type)); return rsl_reject_unknown_lchan(msg); } diff --git a/src/osmo-bts-octphy/l1_if.c b/src/osmo-bts-octphy/l1_if.c index 32e738f..612c29a 100644 --- a/src/osmo-bts-octphy/l1_if.c +++ b/src/osmo-bts-octphy/l1_if.c @@ -1175,7 +1175,7 @@ if (ra_ind->ulMsgLength != 1) { LOGPFN(DL1C, LOGL_ERROR, ra_ind->ulFrameNumber, - "Rx PH-RACH.ind has lenghth %d > 1\n", ra_ind->ulMsgLength); + "Rx PH-RACH.ind has length %d > 1\n", ra_ind->ulMsgLength); msgb_free(l1p_msg); return 0; } diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c index e9710ac..b9af445 100644 --- a/src/osmo-bts-trx/trx_vty.c +++ b/src/osmo-bts-trx/trx_vty.c @@ -237,7 +237,7 @@ OSMOTRX_STR "Set the maximum acceptable delay of a Normal Burst (in GSM symbols)." " USE FOR TESTING ONLY, DON'T CHANGE IN PRODUCTION USE!" - " During normal operation, Normal Bursts delay are controled by a Timing" + " During normal operation, Normal Bursts delay are controlled by a Timing" " Advance control loop and thus Normal Bursts arrive to a BTS with no more" " than a couple GSM symbols, which is already taken into account in osmo-trx." " So changing this setting will have no effect in production installations" -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3d6cb6fc1b182d8520ba60e431ab9b74e71d5e3c Gerrit-Change-Number: 14813 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:57:11 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 19:57:11 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Initialize mExtRACH in constructor Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14814 Change subject: Transceiver: Initialize mExtRACH in constructor ...................................................................... Transceiver: Initialize mExtRACH in constructor Doing so should make Coverity happy: >>> CID 200212: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "mExtRACH" is not initialized in this constructor nor in any functions that it calls. The current status is actually harmless since the field will be set during init() time, and the variable is never used before init() is called. Fixes: Coverity CID#200212 Change-Id: I17286570a9a6db695a75147e5cbb18c9da7d0fe6 --- M Transceiver52M/Transceiver.cpp 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/14/14814/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 0a832f0..17e0476 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -124,7 +124,8 @@ : mBasePort(wBasePort), mLocalAddr(TRXAddress), mRemoteAddr(GSMcoreAddress), mClockSocket(-1), mTransmitLatency(wTransmitLatency), mRadioInterface(wRadioInterface), rssiOffset(wRssiOffset), stackSize(wStackSize), - mSPSTx(tx_sps), mSPSRx(rx_sps), mChans(chans), mEdge(false), mOn(false), mForceClockInterface(false), + mSPSTx(tx_sps), mSPSRx(rx_sps), mChans(chans), mExtRACH(false), mEdge(false), + mOn(false), mForceClockInterface(false), mTxFreq(0.0), mRxFreq(0.0), mTSC(0), mMaxExpectedDelayAB(0), mMaxExpectedDelayNB(0), mWriteBurstToDiskMask(0), mVersionTRXD(0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I17286570a9a6db695a75147e5cbb18c9da7d0fe6 Gerrit-Change-Number: 14814 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:57:14 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:57:14 +0000 Subject: Change in ...osmo-sgsn[master]: Spelling fixes Message-ID: Hello Ruben Undheim, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14815 to review the following change. Change subject: Spelling fixes ...................................................................... Spelling fixes Change-Id: Id1511c5022a239db5d0b44ec7adf048cca307751 --- M src/gprs/gprs_gmm.c M src/gprs/gprs_sgsn.c M src/gprs/gprs_sndcp_dcomp.c M src/gprs/gprs_sndcp_pcomp.c M src/gprs/gtphub_main.c M src/gprs/sgsn_vty.c 6 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/15/14815/1 diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c index e7f0bfe..3465a52 100644 --- a/src/gprs/gprs_gmm.c +++ b/src/gprs/gprs_gmm.c @@ -2213,7 +2213,7 @@ rc = gsm48_tx_gmm_auth_ciph_req(mm, &at->vec, at->key_seq, false); if (rc < 0) - LOGMMCTXP(LOGL_ERROR, mm, "failed sending Auth. & Ciph. Reuqest: %s \n", strerror(-rc)); + LOGMMCTXP(LOGL_ERROR, mm, "failed sending Auth. & Ciph. Request: %s \n", strerror(-rc)); else osmo_timer_schedule(&mm->timer, sgsn->cfg.timers.T3360, 0); break; diff --git a/src/gprs/gprs_sgsn.c b/src/gprs/gprs_sgsn.c index 8d3de7b..fae09ae 100644 --- a/src/gprs/gprs_sgsn.c +++ b/src/gprs/gprs_sgsn.c @@ -103,9 +103,9 @@ static const struct rate_ctr_desc sgsn_ctr_description[] = { { "llc:dl_bytes", "Count sent LLC bytes before giving it to the bssgp layer" }, - { "llc:ul_bytes", "Count sucessful received LLC bytes (encrypt & fcs correct)" }, - { "llc:dl_packets", "Count sucessful sent LLC packets before giving it to the bssgp layer" }, - { "llc:ul_packets", "Count sucessful received LLC packets (encrypt & fcs correct)" }, + { "llc:ul_bytes", "Count successful received LLC bytes (encrypt & fcs correct)" }, + { "llc:dl_packets", "Count successful sent LLC packets before giving it to the bssgp layer" }, + { "llc:ul_packets", "Count successful received LLC packets (encrypt & fcs correct)" }, { "gprs:attach_requested", "Received attach requests" }, { "gprs:attach_accepted", "Sent attach accepts" }, { "gprs:attach_rejected", "Sent attach rejects" }, diff --git a/src/gprs/gprs_sndcp_dcomp.c b/src/gprs/gprs_sndcp_dcomp.c index 00e40a7..c0da84d 100644 --- a/src/gprs/gprs_sndcp_dcomp.c +++ b/src/gprs/gprs_sndcp_dcomp.c @@ -94,7 +94,7 @@ &rx_v42bis_data_handler, NULL, V42BIS_MAX_OUTPUT_LENGTH); LOGP(DSNDCP, LOGL_INFO, - "V.42bis data compression initalized.\n"); + "V.42bis data compression initialized.\n"); return 0; } diff --git a/src/gprs/gprs_sndcp_pcomp.c b/src/gprs/gprs_sndcp_pcomp.c index 5f7f22a..8c2fc97 100644 --- a/src/gprs/gprs_sndcp_pcomp.c +++ b/src/gprs/gprs_sndcp_pcomp.c @@ -59,7 +59,7 @@ slhc_init(ctx, comp_field->rfc1144_params->s01 + 1, comp_field->rfc1144_params->s01 + 1); LOGP(DSNDCP, LOGL_INFO, - "RFC1144 header compression initalized.\n"); + "RFC1144 header compression initialized.\n"); return 0; } diff --git a/src/gprs/gtphub_main.c b/src/gprs/gtphub_main.c index 0369ed7..585a3cb 100644 --- a/src/gprs/gtphub_main.c +++ b/src/gprs/gtphub_main.c @@ -243,7 +243,7 @@ static void list_categories(void) { - printf("Avaliable debug categories:\n"); + printf("Available debug categories:\n"); int i; for (i = 0; i < gtphub_log_info.num_cat; ++i) { if (!gtphub_log_info.cat[i].name) diff --git a/src/gprs/sgsn_vty.c b/src/gprs/sgsn_vty.c index edc5b09..d1d53e6 100644 --- a/src/gprs/sgsn_vty.c +++ b/src/gprs/sgsn_vty.c @@ -1309,7 +1309,7 @@ DEFUN(cfg_comp_rfc1144, cfg_comp_rfc1144_cmd, "compression rfc1144 active slots <1-256>", COMPRESSION_STR - "RFC1144 Header compresion scheme\n" + "RFC1144 Header compression scheme\n" "Compression is actively proposed\n" "Number of compression state slots\n" "Number of compression state slots\n") @@ -1323,7 +1323,7 @@ DEFUN(cfg_comp_rfc1144p, cfg_comp_rfc1144p_cmd, "compression rfc1144 passive", COMPRESSION_STR - "RFC1144 Header compresion scheme\n" + "RFC1144 Header compression scheme\n" "Compression is available on request\n") { g_cfg->pcomp_rfc1144.active = 0; @@ -1343,7 +1343,7 @@ DEFUN(cfg_comp_v42bis, cfg_comp_v42bis_cmd, "compression v42bis active direction (ms|sgsn|both) codewords <512-65535> strlen <6-250>", COMPRESSION_STR - "V.42bis data compresion scheme\n" + "V.42bis data compression scheme\n" "Compression is actively proposed\n" "Direction in which the compression shall be active (p0)\n" "Compress ms->sgsn direction only\n" @@ -1376,7 +1376,7 @@ DEFUN(cfg_comp_v42bisp, cfg_comp_v42bisp_cmd, "compression v42bis passive", COMPRESSION_STR - "V.42bis data compresion scheme\n" + "V.42bis data compression scheme\n" "Compression is available on request\n") { g_cfg->dcomp_v42bis.active = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14815 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id1511c5022a239db5d0b44ec7adf048cca307751 Gerrit-Change-Number: 14815 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Ruben Undheim Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:57:15 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 19:57:15 +0000 Subject: Change in ...osmo-sgsn[master]: Compare with -ENOTSUP to fix build on mipsel/mips64el/alpha Message-ID: Hello Ruben Undheim, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14816 to review the following change. Change subject: Compare with -ENOTSUP to fix build on mipsel/mips64el/alpha ...................................................................... Compare with -ENOTSUP to fix build on mipsel/mips64el/alpha Change-Id: I591d37377495829d2a2bbb350e2c78fe4bddc745 --- M tests/sgsn/sgsn_test.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/16/14816/1 diff --git a/tests/sgsn/sgsn_test.c b/tests/sgsn/sgsn_test.c index 23cb4fb..ff6ce2f 100644 --- a/tests/sgsn/sgsn_test.c +++ b/tests/sgsn/sgsn_test.c @@ -647,7 +647,7 @@ /* Inject DeleteSubscrData GSUP message */ last_updated_subscr = NULL; rc = rx_gsup_message(delete_data_req, sizeof(delete_data_req)); - if (rc != -GMM_CAUSE_SEM_INCORR_MSG) + if (rc != -ENOTSUP) printf("Unexpected response to DSD: %d\n", rc); OSMO_ASSERT(last_updated_subscr == NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I591d37377495829d2a2bbb350e2c78fe4bddc745 Gerrit-Change-Number: 14816 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Ruben Undheim Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:57:55 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Jul 2019 19:57:55 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Initialize mExtRACH in constructor In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14814 ) Change subject: Transceiver: Initialize mExtRACH in constructor ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I17286570a9a6db695a75147e5cbb18c9da7d0fe6 Gerrit-Change-Number: 14814 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: fixeria Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 16 Jul 2019 19:57:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:58:12 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 19:58:12 +0000 Subject: Change in ...libosmocore[master]: Set HTML_TIMESTAMP to NO to make build reproducible In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14795 ) Change subject: Set HTML_TIMESTAMP to NO to make build reproducible ...................................................................... Patch Set 1: Just wondering, why do we want it to be reproducible? explanation or reference to a ticket is missing here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I56cce5cda0621f5e9f1c28aaad4646e9e267d17d Gerrit-Change-Number: 14795 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 19:58:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 19:59:33 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 19:59:33 +0000 Subject: Change in ...libosmocore[master]: MAXPATHLEN set if not defined In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14797 ) Change subject: MAXPATHLEN set if not defined ...................................................................... Patch Set 1: May be worth adding an OSMO_MAX_PATHLEN instead (different systems having different define names which provide this info). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14797 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1dce8ace228814b5a7246a00b31309ab9461d266 Gerrit-Change-Number: 14797 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 19:59:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:01:21 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:01:21 +0000 Subject: Change in ...libosmocore[master]: TIMER constants not on some architectures In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14796 ) Change subject: TIMER constants not on some architectures ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14796 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If24616c3dbf9f1eb6053caed90a63b590d3f5833 Gerrit-Change-Number: 14796 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:01:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:02:33 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:02:33 +0000 Subject: Change in ...libosmocore[master]: No fail if no /proc/cpuinfo In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14798 ) Change subject: No fail if no /proc/cpuinfo ...................................................................... Patch Set 1: Are there systems we know don't have /proc/cpuinfo? may be known adding that kind of information in commit message... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14798 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4b9e12e34f69d98fa87179c7ee390e31001ec943 Gerrit-Change-Number: 14798 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:02:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:03:03 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:03:03 +0000 Subject: Change in ...libosmo-abis[master]: spelling In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14800 ) Change subject: spelling ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14800 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I22c98915648760a83abd5f0004af26d426a5e518 Gerrit-Change-Number: 14800 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:03:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:04:10 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:04:10 +0000 Subject: Change in ...osmo-pcu[master]: fix spelling errors detected by lintian In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14801 ) Change subject: fix spelling errors detected by lintian ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14801 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I381618eb55cc513cfa9c2e384c27cead0935c8bf Gerrit-Change-Number: 14801 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:04:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:05:16 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:05:16 +0000 Subject: Change in ...osmo-pcu[master]: Add structs for big-endian In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14802 ) Change subject: Add structs for big-endian ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6af6d5ef05a8b240acfd9da747d9657bb6aa0ef8 Gerrit-Change-Number: 14802 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 16 Jul 2019 20:05:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:05:36 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:05:36 +0000 Subject: Change in ...libosmo-sccp[master]: This patch fixes typos on which Lintian complains In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14803 ) Change subject: This patch fixes typos on which Lintian complains ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14803 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I657c694a9a7474182a97f90aa8424403ca9c58db Gerrit-Change-Number: 14803 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:05:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:06:19 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:06:19 +0000 Subject: Change in ...libosmo-sccp[master]: _change_systemd_service_file In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14804 ) Change subject: _change_systemd_service_file ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14804/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14804/1//COMMIT_MSG at 7 PS1, Line 7: _change_systemd_service_file You did something wrong here with line 10 and this one... -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia112dec6b61853cbfe1222cf4b7aecfe305ddb99 Gerrit-Change-Number: 14804 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:06:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:08:20 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:08:20 +0000 Subject: Change in ...osmo-hlr[master]: Fix test for return codes on mipsel and alpha archs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14805 ) Change subject: Fix test for return codes on mipsel and alpha archs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ia64f1d9f39fe2b1fb704f7b6c4d9cce93ab708cd Gerrit-Change-Number: 14805 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:08:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:08:41 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:08:41 +0000 Subject: Change in ...osmo-hlr[master]: fix spelling errors detected by lintian In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14806 ) Change subject: fix spelling errors detected by lintian ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14806 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I2a1a21aceabc20fadc5dd28985a94689d2b873a2 Gerrit-Change-Number: 14806 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:08:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:08:58 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:08:58 +0000 Subject: Change in ...osmo-trx[master]: Fix spelling discovered by lintian In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14807 ) Change subject: Fix spelling discovered by lintian ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14807 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5ab9b9c7c47d0d6e674c1f5242e2b3a05006293e Gerrit-Change-Number: 14807 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:08:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:09:14 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:09:14 +0000 Subject: Change in ...osmo-iuh[master]: spelling stuff found by lintian In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14808 ) Change subject: spelling stuff found by lintian ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8434640701746d5db8707472d1d26c313e0814e9 Gerrit-Change-Number: 14808 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:09:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:09:51 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:09:51 +0000 Subject: Change in ...osmo-bsc[master]: Fix one struct for big-endian archs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14811 ) Change subject: Fix one struct for big-endian archs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14811/1/src/ipaccess/network_listen.c File src/ipaccess/network_listen.c: https://gerrit.osmocom.org/#/c/14811/1/src/ipaccess/network_listen.c at 124 PS1, Line 124: #if OSMO_IS_LITTLE_ENDIAN == 1 that == 1 is not needed afaict -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic6e654e0d95d662942c6485097f0b96e1fa46ead Gerrit-Change-Number: 14811 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:09:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:11:10 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:11:10 +0000 Subject: Change in ...osmo-bsc[master]: bsc_subscr_conn_fsm: Log Tx of BSSMAP Clear Request with cause In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14809 ) Change subject: bsc_subscr_conn_fsm: Log Tx of BSSMAP Clear Request with cause ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14809/1/src/osmo-bsc/bsc_subscr_conn_fsm.c File src/osmo-bsc/bsc_subscr_conn_fsm.c: https://gerrit.osmocom.org/#/c/14809/1/src/osmo-bsc/bsc_subscr_conn_fsm.c at 140 PS1, Line 140: LOGPFSML(conn->fi, LOGL_DEBUG, "Tx BSSMAP CLEAR REQUEST(%s) to MSC\n", gsm0808_cause_name(cause)); Ugh strange, I'm pretty sure I added a similar message (due to measing reason) not that long ago somewhere. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14809 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75a92e990d78824367caa8836787d799e6e653bd Gerrit-Change-Number: 14809 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:11:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:11:24 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 20:11:24 +0000 Subject: Change in ...libosmo-sccp[master]: _change_systemd_service_file In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14804 to look at the new patch set (#2). Change subject: _change_systemd_service_file ...................................................................... _change_systemd_service_file Documentation: This patch adds Documentation field to systemd service file Change-Id: Ia112dec6b61853cbfe1222cf4b7aecfe305ddb99 --- M contrib/systemd/osmo-stp.service 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/04/14804/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia112dec6b61853cbfe1222cf4b7aecfe305ddb99 Gerrit-Change-Number: 14804 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:11:35 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:11:35 +0000 Subject: Change in ...osmo-bsc[master]: Fix some spelling errors found by lintian In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14810 ) Change subject: Fix some spelling errors found by lintian ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14810 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I63a733f8bea69f355a6686d99c3aa194c8ac9012 Gerrit-Change-Number: 14810 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:11:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:13:21 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:13:21 +0000 Subject: Change in ...osmo-bts[master]: fix spelling stuff mentioned by lintian In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14813 ) Change subject: fix spelling stuff mentioned by lintian ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3d6cb6fc1b182d8520ba60e431ab9b74e71d5e3c Gerrit-Change-Number: 14813 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:13:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:13:51 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:13:51 +0000 Subject: Change in ...osmo-sgsn[master]: Spelling fixes In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14815 ) Change subject: Spelling fixes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14815 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id1511c5022a239db5d0b44ec7adf048cca307751 Gerrit-Change-Number: 14815 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:13:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:14:40 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:14:40 +0000 Subject: Change in ...osmo-sgsn[master]: Compare with -ENOTSUP to fix build on mipsel/mips64el/alpha In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14816 ) Change subject: Compare with -ENOTSUP to fix build on mipsel/mips64el/alpha ...................................................................... Patch Set 1: Not sure what's the rationale behind this change and whether it's correct... -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I591d37377495829d2a2bbb350e2c78fe4bddc745 Gerrit-Change-Number: 14816 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:14:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:16:00 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 20:16:00 +0000 Subject: Change in ...libosmo-sccp[master]: _change_systemd_service_file In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14804 ) Change subject: _change_systemd_service_file ...................................................................... Patch Set 2: Code-Review-1 Still looks incorrect. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia112dec6b61853cbfe1222cf4b7aecfe305ddb99 Gerrit-Change-Number: 14804 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:16:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:16:21 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 20:16:21 +0000 Subject: Change in ...osmo-bsc[master]: bsc_subscr_conn_fsm: Log Tx of BSSMAP Clear Request with cause In-Reply-To: References: Message-ID: Hoernchen has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14809 ) Change subject: bsc_subscr_conn_fsm: Log Tx of BSSMAP Clear Request with cause ...................................................................... Abandoned wrong relation chain -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14809 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75a92e990d78824367caa8836787d799e6e653bd Gerrit-Change-Number: 14809 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:24:28 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 20:24:28 +0000 Subject: Change in ...libosmo-sccp[master]: _change_systemd_service_file In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14804 to look at the new patch set (#3). Change subject: _change_systemd_service_file ...................................................................... _change_systemd_service_file Documentation: This patch adds Documentation field to systemd service file Change-Id: Ia112dec6b61853cbfe1222cf4b7aecfe305ddb99 --- M contrib/systemd/osmo-stp.service 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/04/14804/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia112dec6b61853cbfe1222cf4b7aecfe305ddb99 Gerrit-Change-Number: 14804 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:43:54 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Jul 2019 20:43:54 +0000 Subject: Change in ...osmo-bsc[master]: Fix some spelling errors found by lintian In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14810 ) Change subject: Fix some spelling errors found by lintian ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14810 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I63a733f8bea69f355a6686d99c3aa194c8ac9012 Gerrit-Change-Number: 14810 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 20:43:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:45:14 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Jul 2019 20:45:14 +0000 Subject: Change in ...osmo-bsc[master]: Fix one struct for big-endian archs In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14811 ) Change subject: Fix one struct for big-endian archs ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14811/1/src/ipaccess/network_listen.c File src/ipaccess/network_listen.c: https://gerrit.osmocom.org/#/c/14811/1/src/ipaccess/network_listen.c at 129 PS1, Line 129: arfcn:10; Please fix spacing, it looks confusing otherwise. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic6e654e0d95d662942c6485097f0b96e1fa46ead Gerrit-Change-Number: 14811 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 16 Jul 2019 20:45:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:46:55 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Jul 2019 20:46:55 +0000 Subject: Change in ...osmo-msc[master]: fix spelling detected by lintian In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14812 ) Change subject: fix spelling detected by lintian ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14812 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I01e54b5cf111677079a8ad57645d3ceb7834702a Gerrit-Change-Number: 14812 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 16 Jul 2019 20:46:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 20:50:54 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 16 Jul 2019 20:50:54 +0000 Subject: Change in ...osmo-hlr[master]: Fix test for return codes on mipsel and alpha archs In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14805 ) Change subject: Fix test for return codes on mipsel and alpha archs ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14805/1/tests/db/db_test.c File tests/db/db_test.c: https://gerrit.osmocom.org/#/c/14805/1/tests/db/db_test.c at 54 PS1, Line 54: if ((expect_rc) == -ENOKEY) \ This alignment also looks odd... -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ia64f1d9f39fe2b1fb704f7b6c4d9cce93ab708cd Gerrit-Change-Number: 14805 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 16 Jul 2019 20:50:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 21:19:04 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 21:19:04 +0000 Subject: Change in ...libosmo-sccp[master]: _change_systemd_service_file In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14804 ) Change subject: _change_systemd_service_file ...................................................................... Patch Set 3: Code-Review-1 Still wrong.... -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia112dec6b61853cbfe1222cf4b7aecfe305ddb99 Gerrit-Change-Number: 14804 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 21:19:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 21:27:44 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 16 Jul 2019 21:27:44 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): use trxd_hdr_common for message parsing In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14786 ) Change subject: driveTxPriorityQueue(): use trxd_hdr_common for message parsing ...................................................................... Patch Set 2: Code-Review+1 I fixed some bits in this one when pushing. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If6a93e2b7fc9ada55edbdd16352cd4f7040e3d2a Gerrit-Change-Number: 14786 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 21:27:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 21:30:16 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 21:30:16 +0000 Subject: Change in ...libosmo-sccp[master]: _change_systemd_service_file In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14804 ) Change subject: _change_systemd_service_file ...................................................................... Patch Set 3: > Patch Set 3: Code-Review-1 > > Still wrong.... https://salsa.debian.org/debian-mobcom-team/libosmo-sccp/raw/master/debian/patches/04_change_systemd_service_file.patch -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14804 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ia112dec6b61853cbfe1222cf4b7aecfe305ddb99 Gerrit-Change-Number: 14804 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 21:30:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 21:34:49 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 16 Jul 2019 21:34:49 +0000 Subject: Change in ...osmo-hlr[master]: Fix test for return codes on mipsel and alpha archs In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14805 ) Change subject: Fix test for return codes on mipsel and alpha archs ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14805/1/tests/db/db_test.c File tests/db/db_test.c: https://gerrit.osmocom.org/#/c/14805/1/tests/db/db_test.c at 54 PS1, Line 54: if ((expect_rc) == -ENOKEY) \ > This alignment also looks odd... I assume the alignment was chosen because "proper" indentation would exceed the line width due to nested conditions -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ia64f1d9f39fe2b1fb704f7b6c4d9cce93ab708cd Gerrit-Change-Number: 14805 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 16 Jul 2019 21:34:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 22:45:21 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Tue, 16 Jul 2019 22:45:21 +0000 Subject: Change in ...osmocom-bb[master]: target/*.py: shebang: use /usr/bin/env python In-Reply-To: References: Message-ID: Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/14759 to look at the new patch set (#3). Change subject: target/*.py: shebang: use /usr/bin/env python ...................................................................... target/*.py: shebang: use /usr/bin/env python Use the system default python instead of a hardcoded python2 Allow to use python2 and python3. Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 --- M src/target/firmware/solve_envs.py M src/target/trx_toolkit/app_common.py M src/target/trx_toolkit/burst_fwd.py M src/target/trx_toolkit/burst_gen.py M src/target/trx_toolkit/burst_send.py M src/target/trx_toolkit/clck_gen.py M src/target/trx_toolkit/ctrl_cmd.py M src/target/trx_toolkit/ctrl_if.py M src/target/trx_toolkit/ctrl_if_trx.py M src/target/trx_toolkit/data_dump.py M src/target/trx_toolkit/data_if.py M src/target/trx_toolkit/data_msg.py M src/target/trx_toolkit/fake_pm.py M src/target/trx_toolkit/fake_trx.py M src/target/trx_toolkit/gsm_shared.py M src/target/trx_toolkit/rand_burst_gen.py M src/target/trx_toolkit/transceiver.py M src/target/trx_toolkit/trx_list.py M src/target/trx_toolkit/trx_sniff.py M src/target/trx_toolkit/udp_link.py 20 files changed, 20 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/59/14759/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 Gerrit-Change-Number: 14759 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 22:51:03 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Tue, 16 Jul 2019 22:51:03 +0000 Subject: Change in ...libosmocore[master]: No fail if no /proc/cpuinfo In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14798 ) Change subject: No fail if no /proc/cpuinfo ...................................................................... Patch Set 1: It would be better to check before using it. e.g. [ -e /proc/cpuinfo ] && cat /proc/cpuinfo. Otherwise there would be an error message shown to the builder/user. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14798 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4b9e12e34f69d98fa87179c7ee390e31001ec943 Gerrit-Change-Number: 14798 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-CC: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 22:51:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 23:01:01 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Tue, 16 Jul 2019 23:01:01 +0000 Subject: Change in ...osmo-msc[master]: replace osmo_counter with stat_items In-Reply-To: References: Message-ID: Hello fixeria, pespin, daniel, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/13802 to look at the new patch set (#11). Change subject: replace osmo_counter with stat_items ...................................................................... replace osmo_counter with stat_items osmo_counter will be soon deprecated. Use the newer and more flexible osmo_stat_item instead. Depends on: Id2462c4866bd22bc2338c9c8f69b775f88ae7511 (libosmocore) Change-Id: I6a20123b263f4f808153794ee8a735092deb399e --- M include/osmocom/msc/gsm_data.h M src/libmsc/gsm_04_08_cc.c M src/libmsc/gsm_09_11.c M src/libmsc/msc_net_init.c M tests/msc_vlr/msc_vlr_test_authen_reuse.err M tests/msc_vlr/msc_vlr_test_call.err M tests/msc_vlr/msc_vlr_test_gsm_authen.err M tests/msc_vlr/msc_vlr_test_gsm_ciph.err M tests/msc_vlr/msc_vlr_test_hlr_reject.err M tests/msc_vlr/msc_vlr_test_hlr_timeout.err M tests/msc_vlr/msc_vlr_test_ms_timeout.err M tests/msc_vlr/msc_vlr_test_no_authen.err M tests/msc_vlr/msc_vlr_test_reject_concurrency.err M tests/msc_vlr/msc_vlr_test_rest.err M tests/msc_vlr/msc_vlr_test_ss.err M tests/msc_vlr/msc_vlr_test_umts_authen.err M tests/msc_vlr/msc_vlr_tests.c 17 files changed, 155 insertions(+), 127 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/02/13802/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/13802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6a20123b263f4f808153794ee8a735092deb399e Gerrit-Change-Number: 13802 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 16 23:02:55 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Tue, 16 Jul 2019 23:02:55 +0000 Subject: Change in ...osmo-msc[master]: replace osmo_counter with stat_items In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13802 ) Change subject: replace osmo_counter with stat_items ...................................................................... Patch Set 11: (1 comment) https://gerrit.osmocom.org/#/c/13802/10/include/osmocom/msc/gsm_data.h File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/#/c/13802/10/include/osmocom/msc/gsm_data.h at 102 PS10, Line 102: MSC_STAT_NC_SS > MSC_STAT_ACTIVE_NC_SS then? ;) [?] oh thanks. I overlooked it. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/13802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6a20123b263f4f808153794ee8a735092deb399e Gerrit-Change-Number: 13802 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 16 Jul 2019 23:02:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Wed Jul 17 02:46:51 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 17 Jul 2019 02:46:51 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2e8c33af06f_d2612a45f832808c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 135s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 135s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 135s] dh_installdocs [ 135s] dh_installchangelogs [ 135s] dh_python2 [ 135s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 135s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 135s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 135s] dh_python3 [ 135s] debian/rules override_dh_installinit [ 135s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 135s] # Install service file with different name than package name: [ 136s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 136s] dh_installinit --name=osmo-ctrl2cgi [ 136s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script not found [ 136s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 136s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 136s] make: *** [debian/rules:4: binary] Error 2 [ 136s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 136s] [ 136s] lamb07 failed "build osmo-python-tests_0.0.9.20190717.dsc" at Wed Jul 17 02:46:31 UTC 2019. [ 136s] [ 136s] ### VM INTERACTION START ### [ 139s] [ 124.540921] sysrq: SysRq : Power Off [ 139s] [ 124.561216] reboot: Power down [ 139s] ### VM INTERACTION END ### [ 139s] [ 139s] lamb07 failed "build osmo-python-tests_0.0.9.20190717.dsc" at Wed Jul 17 02:46:35 UTC 2019. [ 139s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Wed Jul 17 02:48:00 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 17 Jul 2019 02:48:00 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in xUbuntu_18.10/i586 In-Reply-To: References: Message-ID: <5d2e8c70dd2ea_d2612a45f83285a8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/xUbuntu_18.10/i586 Package network:osmocom:nightly/libosmo-netif failed to build in xUbuntu_18.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 220s] +++ /usr/src/packages/BUILD/tests/testsuite.dir/at-groups/1/stdout 2019-07-17 02:47:40.444000000 +0000 [ 220s] @@ -40,12 +40,6 @@ [ 220s] [NA] Client's read_cb_cli(): received 11(11) bytes: 72 65 61 64 5f 63 62 5f 73 72 76 [ 220s] [NA] Client's read_cb_cli(): initial read, contacting server [ 220s] [OK] Client's read_cb_cli(): sent 29 bytes message: 44 6f 68 2c 20 72 65 73 70 6f 6e 64 69 6e 67 20 74 6f 20 73 65 72 76 65 72 20 3a 2d 44 [ 220s] -[OK|OK] Server's read_cb_srv(): callback triggered [ 220s] -[OK|OK] Server's read_cb_srv(): received 29(29) bytes: 44 6f 68 2c 20 72 65 73 70 6f 6e 64 69 6e 67 20 74 6f 20 73 65 72 76 65 72 20 3a 2d 44 [ 220s] -[OK|OK] Server's read_cb_srv(): sent 11 bytes message: 72 65 61 64 5f 63 62 5f 73 72 76 [ 220s] -[OK|OK] Server's read_cb_srv(): force client disconnect on subsequent call [ 220s] -[OK] Client's read_cb_cli(): callback triggered [ 220s] -[OK] Client's read_cb_cli(): 0-byte read, auto-reconnect will be triggered if enabled [ 220s] non-reconnecting test complete. [ 220s] [ 220s] Stream tests completed [ 220s] 1. testsuite.at:4: 1. stream_test (testsuite.at:4): FAILED (testsuite.at:8) [ 220s] make[1]: *** [debian/rules:27: override_dh_auto_test] Error 1 [ 220s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 220s] make: *** [debian/rules:13: build] Error 2 [ 220s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 220s] [ 220s] lamb19 failed "build libosmo-netif_0.5.0.2.6563.dsc" at Wed Jul 17 02:47:42 UTC 2019. [ 220s] [ 220s] ### VM INTERACTION START ### [ 223s] [ 209.885129] sysrq: SysRq : Power Off [ 223s] [ 209.900592] reboot: Power down [ 223s] ### VM INTERACTION END ### [ 223s] [ 223s] lamb19 failed "build libosmo-netif_0.5.0.2.6563.dsc" at Wed Jul 17 02:47:46 UTC 2019. [ 223s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Wed Jul 17 03:02:17 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 17 Jul 2019 03:02:17 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2e8fd2b33ba_d2612a45f83349f7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 591s] -Returned: 0, Current node: 1 '%s> ' [ 591s] -Going to execute 'ambiguous_str' [ 591s] -Called: 'ambiguous_str [ARG]' (argc=0) [ 591s] -Returned: 0, Current node: 1 '%s> ' [ 591s] -Going to execute 'ambiguous_str arg' [ 591s] -Called: 'ambiguous_str [ARG]' (argc=1) [ 591s] -Returned: 0, Current node: 1 '%s> ' [ 591s] -Going to execute 'ambiguous_str arg keyword' [ 591s] -Called: 'ambiguous_str ARG keyword' [ 591s] -Returned: 0, Current node: 1 '%s> ' [ 591s] -All tests passed [ 591s] ./testsuite.at:196: exit code was 139, expected 0 [ 591s] 31. testsuite.at:192: 31. vty (testsuite.at:192): FAILED (testsuite.at:196) [ 591s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 591s] make[1]: *** [override_dh_auto_test] Error 1 [ 591s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 591s] debian/rules:15: recipe for target 'build' failed [ 591s] make: *** [build] Error 2 [ 591s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 591s] [ 591s] armbuild21 failed "build libosmocore_1.1.0.79.a3dec.dsc" at Wed Jul 17 03:02:01 UTC 2019. [ 591s] [ 591s] ### VM INTERACTION START ### [ 593s] [ 574.146456] sysrq: SysRq : Power Off [ 593s] [ 574.214132] reboot: Power down [ 594s] ### VM INTERACTION END ### [ 594s] [ 594s] armbuild21 failed "build libosmocore_1.1.0.79.a3dec.dsc" at Wed Jul 17 03:02:04 UTC 2019. [ 594s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Jul 17 06:59:12 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Jul 2019 06:59:12 +0000 Subject: Change in ...osmocom-bb[master]: target/*.py: shebang: use /usr/bin/env python In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14759 ) Change subject: target/*.py: shebang: use /usr/bin/env python ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 Gerrit-Change-Number: 14759 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 06:59:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 07:02:53 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Jul 2019 07:02:53 +0000 Subject: Change in ...osmo-msc[master]: replace osmo_counter with stat_items In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13802 ) Change subject: replace osmo_counter with stat_items ...................................................................... Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/13802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6a20123b263f4f808153794ee8a735092deb399e Gerrit-Change-Number: 13802 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 07:02:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:49:45 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:49:45 +0000 Subject: Change in ...osmocom-bb[master]: target/*.py: shebang: use /usr/bin/env python In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14759 ) Change subject: target/*.py: shebang: use /usr/bin/env python ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 Gerrit-Change-Number: 14759 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:49:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:50:28 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:50:28 +0000 Subject: Change in ...osmo-msc[master]: replace osmo_counter with stat_items In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13802 ) Change subject: replace osmo_counter with stat_items ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/13802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6a20123b263f4f808153794ee8a735092deb399e Gerrit-Change-Number: 13802 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:50:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:51:21 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:51:21 +0000 Subject: Change in ...libosmocore[master]: Set HTML_TIMESTAMP to NO to make build reproducible In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14795 ) Change subject: Set HTML_TIMESTAMP to NO to make build reproducible ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I56cce5cda0621f5e9f1c28aaad4646e9e267d17d Gerrit-Change-Number: 14795 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:51:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:54:42 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:54:42 +0000 Subject: Change in ...libosmocore[master]: TIMER constants not on some architectures In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14796 ) Change subject: TIMER constants not on some architectures ...................................................................... Patch Set 1: Code-Review-1 Historically, we once supported (in form of build-test verification integrated into gerrit) FreeBSD. However, it was causing significant effort to maintain FreeBSD compatibility, while nobody in the active Osmocom developer community is using FreeBSD for their development. Also, we never ever received report from even a single user of Osmocom on FreeBSD. As a result, we decided to drop FreeBSD compatibility and stated we'd re-introduce it if somebody from the user/developer community was willing to actively maintain it and provide related patches. This hasn't happened so far, so I'm against merging the occasional one-off patch which creates the impression of supporting non-Linux platforms while in reality nobody is testing/maintaining it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14796 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If24616c3dbf9f1eb6053caed90a63b590d3f5833 Gerrit-Change-Number: 14796 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:54:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:54:52 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:54:52 +0000 Subject: Change in ...libosmocore[master]: MAXPATHLEN set if not defined In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14797 ) Change subject: MAXPATHLEN set if not defined ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14797 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1dce8ace228814b5a7246a00b31309ab9461d266 Gerrit-Change-Number: 14797 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:54:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:55:42 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:55:42 +0000 Subject: Change in ...libosmo-abis[master]: spelling In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14800 ) Change subject: spelling ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14800 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I22c98915648760a83abd5f0004af26d426a5e518 Gerrit-Change-Number: 14800 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:55:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:55:43 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:55:43 +0000 Subject: Change in ...libosmo-abis[master]: spelling In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14800 ) Change subject: spelling ...................................................................... spelling =================================================================== Change-Id: I22c98915648760a83abd5f0004af26d426a5e518 --- M src/input/ipa.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/input/ipa.c b/src/input/ipa.c index 25eeb4a..8aed7b3 100644 --- a/src/input/ipa.c +++ b/src/input/ipa.c @@ -272,7 +272,7 @@ ret = link->accept_cb(link, fd); if (ret < 0) { LOGP(DLINP, LOGL_ERROR, - "failed to processs accept()ed new link, " + "failed to process accept()ed new link, " "reason=`%s'\n", strerror(-ret)); close(fd); return ret; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14800 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I22c98915648760a83abd5f0004af26d426a5e518 Gerrit-Change-Number: 14800 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:56:18 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:56:18 +0000 Subject: Change in ...osmo-pcu[master]: fix spelling errors detected by lintian In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14801 ) Change subject: fix spelling errors detected by lintian ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14801 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I381618eb55cc513cfa9c2e384c27cead0935c8bf Gerrit-Change-Number: 14801 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:56:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:56:19 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:56:19 +0000 Subject: Change in ...osmo-pcu[master]: fix spelling errors detected by lintian In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14801 ) Change subject: fix spelling errors detected by lintian ...................................................................... fix spelling errors detected by lintian Change-Id: I381618eb55cc513cfa9c2e384c27cead0935c8bf --- M src/bts.cpp M src/decoding.cpp M src/encoding.cpp M src/gsm_rlcmac.cpp M src/gsm_rlcmac.h M src/pcu_l1_if.cpp M src/pdch.cpp M src/tbf.cpp M src/tbf.h 9 files changed, 14 insertions(+), 14 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bts.cpp b/src/bts.cpp index 8799c3d..395fc73 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -611,7 +611,7 @@ * we roll back the rounded frame number by one RFN_MODULUS */ if (abs(rfn - m_cur_rfn) > RFN_THRESHOLD) { LOGP(DRLCMAC, LOGL_DEBUG, - "Race condition between rfn (%u) and m_cur_fn (%u) detected: rfn belongs to the previos modulus %u cycle, wrappng...\n", + "Race condition between rfn (%u) and m_cur_fn (%u) detected: rfn belongs to the previous modulus %u cycle, wrapping...\n", rfn, m_cur_fn, RFN_MODULUS); if (fn_rounded < RFN_MODULUS) { LOGP(DRLCMAC, LOGL_DEBUG, diff --git a/src/decoding.cpp b/src/decoding.cpp index d439e30..99a17dc 100644 --- a/src/decoding.cpp +++ b/src/decoding.cpp @@ -77,7 +77,7 @@ /* TS 44.060, table 10.4.14a.1, row 3 & 5 */ /* only filling bytes left */ LOGP(DRLCMACUL, LOGL_DEBUG, "UL DATA LI contains " - "only filling bytes with extention octet: LI=%d, E=%d, count=%d\n", + "only filling bytes with extension octet: LI=%d, E=%d, count=%d\n", li->li, li->e, num_chunks); break; } else if (li->li > 0) { @@ -92,7 +92,7 @@ } LOGP(DRLCMACUL, LOGL_DEBUG, "UL DATA LI contains " - "extention octet: LI=%d, E=%d, count=%d\n", + "extension octet: LI=%d, E=%d, count=%d\n", li->li, li->e, num_chunks); num_chunks += 1; @@ -168,7 +168,7 @@ chunks[num_chunks].is_complete = li->li || is_last_block; LOGP(DRLCMACUL, LOGL_DEBUG, "UL DATA LI contains " - "extention octet: LI=%d, M=%d, E=%d, count=%d\n", + "extension octet: LI=%d, M=%d, E=%d, count=%d\n", li->li, li->m, li->e, num_chunks); num_chunks += 1; diff --git a/src/encoding.cpp b/src/encoding.cpp index ca9e906..3fac75e 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -532,7 +532,7 @@ if (rc < 0) { LOGP(DRLCMAC, LOGL_ERROR, - "Failed to create IMMEDIATE ASSIGMENT (%s) for %s\n", + "Failed to create IMMEDIATE ASSIGNMENT (%s) for %s\n", downlink ? "downlink" : "uplink", tbf ? tbf->name() : "single block allocation"); return rc; diff --git a/src/gsm_rlcmac.cpp b/src/gsm_rlcmac.cpp index 6323b09..ef7abcd 100644 --- a/src/gsm_rlcmac.cpp +++ b/src/gsm_rlcmac.cpp @@ -1363,8 +1363,8 @@ static const CSN_DESCR_BEGIN(PCCF_AdditionsR5_t) - M_NEXT_EXIST (PCCF_AdditionsR5_t, Exist_G_RNTI_extention, 1), - M_UINT (PCCF_AdditionsR5_t, G_RNTI_extention, 4), + M_NEXT_EXIST (PCCF_AdditionsR5_t, Exist_G_RNTI_extension, 1), + M_UINT (PCCF_AdditionsR5_t, G_RNTI_extension, 4), M_NEXT_EXIST_OR_NULL(PCCF_AdditionsR5_t, Exist_AdditionsR8, 1), M_TYPE (PCCF_AdditionsR5_t, AdditionsR8, PCCF_AdditionsR8_t), CSN_DESCR_END (PCCF_AdditionsR5_t) diff --git a/src/gsm_rlcmac.h b/src/gsm_rlcmac.h index 2ad1937..a4750e8 100644 --- a/src/gsm_rlcmac.h +++ b/src/gsm_rlcmac.h @@ -1602,8 +1602,8 @@ typedef struct { - guint8 Exist_G_RNTI_extention; - guint8 G_RNTI_extention; + guint8 Exist_G_RNTI_extension; + guint8 G_RNTI_extension; guint8 Exist_AdditionsR8; PCCF_AdditionsR8_t AdditionsR8; } PCCF_AdditionsR5_t; diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index bc712fd..da85df4 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -650,7 +650,7 @@ rc = pcu_rx_susp_req(&pcu_prim->u.susp_req); break; default: - LOGP(DL1IF, LOGL_ERROR, "Received unknwon PCU msg type %d\n", + LOGP(DL1IF, LOGL_ERROR, "Received unknown PCU msg type %d\n", msg_type); rc = -EINVAL; } diff --git a/src/pdch.cpp b/src/pdch.cpp index 8003105..7488b96 100644 --- a/src/pdch.cpp +++ b/src/pdch.cpp @@ -632,7 +632,7 @@ int8_t tfi = request->ID.u.Global_TFI.u.DOWNLINK_TFI; dl_tbf = bts()->dl_tbf_by_tfi(tfi, trx_no(), ts_no); if (!dl_tbf) { - LOGP(DRLCMAC, LOGL_NOTICE, "PACKET RESSOURCE REQ unknown downlink TFI=%d\n", tfi); + LOGP(DRLCMAC, LOGL_NOTICE, "PACKET RESOURCE REQ unknown downlink TFI=%d\n", tfi); return; } LOGPTBFDL(dl_tbf, LOGL_ERROR, @@ -645,7 +645,7 @@ int8_t tfi = request->ID.u.Global_TFI.u.UPLINK_TFI; ul_tbf = bts()->ul_tbf_by_tfi(tfi, trx_no(), ts_no); if (!ul_tbf) { - LOGP(DRLCMAC, LOGL_NOTICE, "PACKET RESSOURCE REQ unknown uplink TFI=%d\n", tfi); + LOGP(DRLCMAC, LOGL_NOTICE, "PACKET RESOURCE REQ unknown uplink TFI=%d\n", tfi); return; } LOGPTBFUL(ul_tbf, LOGL_ERROR, diff --git a/src/tbf.cpp b/src/tbf.cpp index a099322..9856c7f 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -1208,7 +1208,7 @@ if (direction == GPRS_RLCMAC_DL_TBF && !is_control_ts(ts)) { LOGPTBF(this, LOGL_NOTICE, - "Cannot poll for downlink assigment, because MS cannot reply. (TS=%d, first common TS=%d)\n", + "Cannot poll for downlink assignment, because MS cannot reply. (TS=%d, first common TS=%d)\n", ts, first_common_ts); poll_ass_dl = 0; } diff --git a/src/tbf.h b/src/tbf.h index 0a58862..34e8101 100644 --- a/src/tbf.h +++ b/src/tbf.h @@ -43,7 +43,7 @@ */ #define T_ASS_AGCH_USEC 200000 /* waiting after IMM.ASS confirm */ -#define T_ASS_PACCH_SEC 2 /* timeout for pacch assigment */ +#define T_ASS_PACCH_SEC 2 /* timeout for pacch assignment */ #define T_REJ_PACCH_USEC 2000 /* timeout for tbf reject for PRR*/ enum gprs_rlcmac_tbf_state { -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14801 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I381618eb55cc513cfa9c2e384c27cead0935c8bf Gerrit-Change-Number: 14801 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:56:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:56:36 +0000 Subject: Change in ...libosmo-sccp[master]: This patch fixes typos on which Lintian complains In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14803 ) Change subject: This patch fixes typos on which Lintian complains ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14803 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I657c694a9a7474182a97f90aa8424403ca9c58db Gerrit-Change-Number: 14803 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:56:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:56:37 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:56:37 +0000 Subject: Change in ...libosmo-sccp[master]: This patch fixes typos on which Lintian complains In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/14803 ) Change subject: This patch fixes typos on which Lintian complains ...................................................................... This patch fixes typos on which Lintian complains Change-Id: I657c694a9a7474182a97f90aa8424403ca9c58db --- M src/m3ua.c M stp/stp_main.c 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/m3ua.c b/src/m3ua.c index d7ede40..d733b51 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -91,7 +91,7 @@ }; const struct value_string m3ua_ntfy_other_names[] = { - { M3UA_NOTIFY_I_OT_INS_RES, "Insufficient ASP Resouces active in AS" }, + { M3UA_NOTIFY_I_OT_INS_RES, "Insufficient ASP Resources active in AS" }, { M3UA_NOTIFY_I_OT_ALT_ASP_ACT, "Alternative ASP Active" }, { M3UA_NOTIFY_I_OT_ASP_FAILURE, "ASP Failure" }, { 0, NULL } diff --git a/stp/stp_main.c b/stp/stp_main.c index 6a47403..ff33959 100644 --- a/stp/stp_main.c +++ b/stp/stp_main.c @@ -85,7 +85,7 @@ static void print_help(void) { printf(" -h --help This text.\n"); - printf(" -D --daemonize Fork teh process into a background daemon\n"); + printf(" -D --daemonize Fork the process into a background daemon\n"); printf(" -c --config-file filename The config file to use. Default: ./osmo-stp.cfg\n"); printf(" -V --version Print the version of OsmoSTP\n"); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/14803 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I657c694a9a7474182a97f90aa8424403ca9c58db Gerrit-Change-Number: 14803 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:58:21 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:58:21 +0000 Subject: Change in ...osmo-trx[master]: Fix spelling discovered by lintian In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14807 ) Change subject: Fix spelling discovered by lintian ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14807 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5ab9b9c7c47d0d6e674c1f5242e2b3a05006293e Gerrit-Change-Number: 14807 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:58:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:58:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:58:22 +0000 Subject: Change in ...osmo-trx[master]: Fix spelling discovered by lintian In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14807 ) Change subject: Fix spelling discovered by lintian ...................................................................... Fix spelling discovered by lintian Change-Id: I5ab9b9c7c47d0d6e674c1f5242e2b3a05006293e --- M Transceiver52M/osmo-trx.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index 06b1a18..b8cf968 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -255,7 +255,7 @@ { LOG(WARNING) << "Cmd line option '" << opt << "' is deprecated and will be soon removed." << " Please use VTY cfg option instead." - << " All cmd line options are already being overriden by VTY options if set."; + << " All cmd line options are already being overridden by VTY options if set."; } static void handle_options(int argc, char **argv, struct trx_ctx* trx) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14807 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5ab9b9c7c47d0d6e674c1f5242e2b3a05006293e Gerrit-Change-Number: 14807 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:58:37 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:58:37 +0000 Subject: Change in ...osmo-iuh[master]: spelling stuff found by lintian In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14808 ) Change subject: spelling stuff found by lintian ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8434640701746d5db8707472d1d26c313e0814e9 Gerrit-Change-Number: 14808 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:58:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:58:38 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:58:38 +0000 Subject: Change in ...osmo-iuh[master]: spelling stuff found by lintian In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14808 ) Change subject: spelling stuff found by lintian ...................................................................... spelling stuff found by lintian Change-Id: I8434640701746d5db8707472d1d26c313e0814e9 --- M src/hnbgw_rua.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/hnbgw_rua.c b/src/hnbgw_rua.c index 40d1d94..71c3f8e 100644 --- a/src/hnbgw_rua.c +++ b/src/hnbgw_rua.c @@ -505,7 +505,7 @@ static int rua_rx_successful_outcome_msg(struct msgb *msg, RUA_SuccessfulOutcome_t *in) { /* FIXME */ - LOGP(DRUA, LOGL_NOTICE, "Unexpected RUA Sucessful Outcome\n"); + LOGP(DRUA, LOGL_NOTICE, "Unexpected RUA Successful Outcome\n"); return -1; } -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8434640701746d5db8707472d1d26c313e0814e9 Gerrit-Change-Number: 14808 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:58:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:58:56 +0000 Subject: Change in ...osmo-bts[master]: fix spelling stuff mentioned by lintian In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14813 ) Change subject: fix spelling stuff mentioned by lintian ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3d6cb6fc1b182d8520ba60e431ab9b74e71d5e3c Gerrit-Change-Number: 14813 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:58:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:58:57 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:58:57 +0000 Subject: Change in ...osmo-bts[master]: fix spelling stuff mentioned by lintian In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14813 ) Change subject: fix spelling stuff mentioned by lintian ...................................................................... fix spelling stuff mentioned by lintian Change-Id: I3d6cb6fc1b182d8520ba60e431ab9b74e71d5e3c --- M src/common/pcu_sock.c M src/common/rsl.c M src/osmo-bts-octphy/l1_if.c M src/osmo-bts-trx/trx_vty.c 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 39b4568..1d9fa72 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -677,7 +677,7 @@ rc = pcu_rx_txt_ind(bts, &pcu_prim->u.txt_ind); break; default: - LOGP(DPCU, LOGL_ERROR, "Received unknwon PCU msg type %d\n", + LOGP(DPCU, LOGL_ERROR, "Received unknown PCU msg type %d\n", msg_type); rc = -EINVAL; } diff --git a/src/common/rsl.c b/src/common/rsl.c index 0a613bb..0a6a4e5 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -3090,7 +3090,7 @@ msg->lchan = lchan_lookup(trx, dch->chan_nr, "RSL rx IPACC: "); if (!msg->lchan) { - LOGP(DRSL, LOGL_ERROR, "Rx RSL %s for unknow lchan\n", + LOGP(DRSL, LOGL_ERROR, "Rx RSL %s for unknown lchan\n", rsl_msg_name(dch->c.msg_type)); return rsl_reject_unknown_lchan(msg); } diff --git a/src/osmo-bts-octphy/l1_if.c b/src/osmo-bts-octphy/l1_if.c index 32e738f..612c29a 100644 --- a/src/osmo-bts-octphy/l1_if.c +++ b/src/osmo-bts-octphy/l1_if.c @@ -1175,7 +1175,7 @@ if (ra_ind->ulMsgLength != 1) { LOGPFN(DL1C, LOGL_ERROR, ra_ind->ulFrameNumber, - "Rx PH-RACH.ind has lenghth %d > 1\n", ra_ind->ulMsgLength); + "Rx PH-RACH.ind has length %d > 1\n", ra_ind->ulMsgLength); msgb_free(l1p_msg); return 0; } diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c index e9710ac..b9af445 100644 --- a/src/osmo-bts-trx/trx_vty.c +++ b/src/osmo-bts-trx/trx_vty.c @@ -237,7 +237,7 @@ OSMOTRX_STR "Set the maximum acceptable delay of a Normal Burst (in GSM symbols)." " USE FOR TESTING ONLY, DON'T CHANGE IN PRODUCTION USE!" - " During normal operation, Normal Bursts delay are controled by a Timing" + " During normal operation, Normal Bursts delay are controlled by a Timing" " Advance control loop and thus Normal Bursts arrive to a BTS with no more" " than a couple GSM symbols, which is already taken into account in osmo-trx." " So changing this setting will have no effect in production installations" -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3d6cb6fc1b182d8520ba60e431ab9b74e71d5e3c Gerrit-Change-Number: 14813 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:59:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:59:22 +0000 Subject: Change in ...osmo-sgsn[master]: Spelling fixes In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14815 ) Change subject: Spelling fixes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14815 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id1511c5022a239db5d0b44ec7adf048cca307751 Gerrit-Change-Number: 14815 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 10:59:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 10:59:24 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 10:59:24 +0000 Subject: Change in ...osmo-sgsn[master]: Spelling fixes In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14815 ) Change subject: Spelling fixes ...................................................................... Spelling fixes Change-Id: Id1511c5022a239db5d0b44ec7adf048cca307751 --- M src/gprs/gprs_gmm.c M src/gprs/gprs_sgsn.c M src/gprs/gprs_sndcp_dcomp.c M src/gprs/gprs_sndcp_pcomp.c M src/gprs/gtphub_main.c M src/gprs/sgsn_vty.c 6 files changed, 11 insertions(+), 11 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c index e7f0bfe..3465a52 100644 --- a/src/gprs/gprs_gmm.c +++ b/src/gprs/gprs_gmm.c @@ -2213,7 +2213,7 @@ rc = gsm48_tx_gmm_auth_ciph_req(mm, &at->vec, at->key_seq, false); if (rc < 0) - LOGMMCTXP(LOGL_ERROR, mm, "failed sending Auth. & Ciph. Reuqest: %s \n", strerror(-rc)); + LOGMMCTXP(LOGL_ERROR, mm, "failed sending Auth. & Ciph. Request: %s \n", strerror(-rc)); else osmo_timer_schedule(&mm->timer, sgsn->cfg.timers.T3360, 0); break; diff --git a/src/gprs/gprs_sgsn.c b/src/gprs/gprs_sgsn.c index 8d3de7b..fae09ae 100644 --- a/src/gprs/gprs_sgsn.c +++ b/src/gprs/gprs_sgsn.c @@ -103,9 +103,9 @@ static const struct rate_ctr_desc sgsn_ctr_description[] = { { "llc:dl_bytes", "Count sent LLC bytes before giving it to the bssgp layer" }, - { "llc:ul_bytes", "Count sucessful received LLC bytes (encrypt & fcs correct)" }, - { "llc:dl_packets", "Count sucessful sent LLC packets before giving it to the bssgp layer" }, - { "llc:ul_packets", "Count sucessful received LLC packets (encrypt & fcs correct)" }, + { "llc:ul_bytes", "Count successful received LLC bytes (encrypt & fcs correct)" }, + { "llc:dl_packets", "Count successful sent LLC packets before giving it to the bssgp layer" }, + { "llc:ul_packets", "Count successful received LLC packets (encrypt & fcs correct)" }, { "gprs:attach_requested", "Received attach requests" }, { "gprs:attach_accepted", "Sent attach accepts" }, { "gprs:attach_rejected", "Sent attach rejects" }, diff --git a/src/gprs/gprs_sndcp_dcomp.c b/src/gprs/gprs_sndcp_dcomp.c index 00e40a7..c0da84d 100644 --- a/src/gprs/gprs_sndcp_dcomp.c +++ b/src/gprs/gprs_sndcp_dcomp.c @@ -94,7 +94,7 @@ &rx_v42bis_data_handler, NULL, V42BIS_MAX_OUTPUT_LENGTH); LOGP(DSNDCP, LOGL_INFO, - "V.42bis data compression initalized.\n"); + "V.42bis data compression initialized.\n"); return 0; } diff --git a/src/gprs/gprs_sndcp_pcomp.c b/src/gprs/gprs_sndcp_pcomp.c index 5f7f22a..8c2fc97 100644 --- a/src/gprs/gprs_sndcp_pcomp.c +++ b/src/gprs/gprs_sndcp_pcomp.c @@ -59,7 +59,7 @@ slhc_init(ctx, comp_field->rfc1144_params->s01 + 1, comp_field->rfc1144_params->s01 + 1); LOGP(DSNDCP, LOGL_INFO, - "RFC1144 header compression initalized.\n"); + "RFC1144 header compression initialized.\n"); return 0; } diff --git a/src/gprs/gtphub_main.c b/src/gprs/gtphub_main.c index 0369ed7..585a3cb 100644 --- a/src/gprs/gtphub_main.c +++ b/src/gprs/gtphub_main.c @@ -243,7 +243,7 @@ static void list_categories(void) { - printf("Avaliable debug categories:\n"); + printf("Available debug categories:\n"); int i; for (i = 0; i < gtphub_log_info.num_cat; ++i) { if (!gtphub_log_info.cat[i].name) diff --git a/src/gprs/sgsn_vty.c b/src/gprs/sgsn_vty.c index edc5b09..d1d53e6 100644 --- a/src/gprs/sgsn_vty.c +++ b/src/gprs/sgsn_vty.c @@ -1309,7 +1309,7 @@ DEFUN(cfg_comp_rfc1144, cfg_comp_rfc1144_cmd, "compression rfc1144 active slots <1-256>", COMPRESSION_STR - "RFC1144 Header compresion scheme\n" + "RFC1144 Header compression scheme\n" "Compression is actively proposed\n" "Number of compression state slots\n" "Number of compression state slots\n") @@ -1323,7 +1323,7 @@ DEFUN(cfg_comp_rfc1144p, cfg_comp_rfc1144p_cmd, "compression rfc1144 passive", COMPRESSION_STR - "RFC1144 Header compresion scheme\n" + "RFC1144 Header compression scheme\n" "Compression is available on request\n") { g_cfg->pcomp_rfc1144.active = 0; @@ -1343,7 +1343,7 @@ DEFUN(cfg_comp_v42bis, cfg_comp_v42bis_cmd, "compression v42bis active direction (ms|sgsn|both) codewords <512-65535> strlen <6-250>", COMPRESSION_STR - "V.42bis data compresion scheme\n" + "V.42bis data compression scheme\n" "Compression is actively proposed\n" "Direction in which the compression shall be active (p0)\n" "Compress ms->sgsn direction only\n" @@ -1376,7 +1376,7 @@ DEFUN(cfg_comp_v42bisp, cfg_comp_v42bisp_cmd, "compression v42bis passive", COMPRESSION_STR - "V.42bis data compresion scheme\n" + "V.42bis data compression scheme\n" "Compression is available on request\n") { g_cfg->dcomp_v42bis.active = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14815 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id1511c5022a239db5d0b44ec7adf048cca307751 Gerrit-Change-Number: 14815 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 11:00:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 11:00:05 +0000 Subject: Change in ...osmo-sgsn[master]: Compare with -ENOTSUP to fix build on mipsel/mips64el/alpha In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14816 ) Change subject: Compare with -ENOTSUP to fix build on mipsel/mips64el/alpha ...................................................................... Patch Set 1: Code-Review-1 same here, I'm really not convinced at all this is a valid fix. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14816 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I591d37377495829d2a2bbb350e2c78fe4bddc745 Gerrit-Change-Number: 14816 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 11:00:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 11:01:24 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 11:01:24 +0000 Subject: Change in ...osmo-pcu[master]: Add structs for big-endian In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14802 ) Change subject: Add structs for big-endian ...................................................................... Patch Set 1: we do have osmo-ci/scripts/libosmocore/contrib/struct_endianess.py to do this in an automatic/programmatic way, which I'd prefer over manual patches. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6af6d5ef05a8b240acfd9da747d9657bb6aa0ef8 Gerrit-Change-Number: 14802 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 17 Jul 2019 11:01:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 11:01:50 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 11:01:50 +0000 Subject: Change in ...osmo-bsc[master]: Fix some spelling errors found by lintian In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14810 ) Change subject: Fix some spelling errors found by lintian ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14810 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I63a733f8bea69f355a6686d99c3aa194c8ac9012 Gerrit-Change-Number: 14810 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 11:01:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 11:01:51 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 11:01:51 +0000 Subject: Change in ...osmo-bsc[master]: Fix some spelling errors found by lintian In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14810 ) Change subject: Fix some spelling errors found by lintian ...................................................................... Fix some spelling errors found by lintian Change-Id: I63a733f8bea69f355a6686d99c3aa194c8ac9012 --- M doc/manuals/vty/bsc_vty_reference.xml M src/osmo-bsc/a_reset.c M src/osmo-bsc/abis_om2000_vty.c M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/osmo_bsc_main.c M src/osmo-bsc/osmo_bsc_sigtran.c M src/osmo-bsc/osmo_bsc_vty.c M src/osmo-bsc/pcu_sock.c 8 files changed, 10 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/doc/manuals/vty/bsc_vty_reference.xml b/doc/manuals/vty/bsc_vty_reference.xml index 4d25e69..db4f2c1 100644 --- a/doc/manuals/vty/bsc_vty_reference.xml +++ b/doc/manuals/vty/bsc_vty_reference.xml @@ -2958,7 +2958,7 @@ - + @@ -4830,7 +4830,7 @@ - + @@ -4841,7 +4841,7 @@ - + diff --git a/src/osmo-bsc/a_reset.c b/src/osmo-bsc/a_reset.c index 3c21142..fc59ff4 100644 --- a/src/osmo-bsc/a_reset.c +++ b/src/osmo-bsc/a_reset.c @@ -71,7 +71,7 @@ { struct reset_ctx *reset_ctx = (struct reset_ctx *)fi->priv; OSMO_ASSERT(reset_ctx); - LOGPFSML(fi, LOGL_NOTICE, "SIGTRAN connection succeded.\n"); + LOGPFSML(fi, LOGL_NOTICE, "SIGTRAN connection succeeded.\n"); reset_ctx->conn_loss_counter = 0; osmo_fsm_inst_state_chg(fi, ST_CONN, 0, 0); diff --git a/src/osmo-bsc/abis_om2000_vty.c b/src/osmo-bsc/abis_om2000_vty.c index faf39c1..3ae870e 100644 --- a/src/osmo-bsc/abis_om2000_vty.c +++ b/src/osmo-bsc/abis_om2000_vty.c @@ -368,7 +368,7 @@ #define CON_PATH_HELP "CON Path (In/Out)\n" \ "Add CON Path to Concentration Group\n" \ "Delete CON Path from Concentration Group\n" \ - "CON Conection Point\n" \ + "CON Connection Point\n" \ "Contiguity Index\n" \ DEFUN(cfg_om2k_con_path_dec, cfg_om2k_con_path_dec_cmd, diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index c4e091c..24f8313 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -2371,7 +2371,7 @@ DEFUN(cfg_bts_challoc, cfg_bts_challoc_cmd, "channel allocator (ascending|descending)", - "Channnel Allocator\n" "Channel Allocator\n" + "Channel Allocator\n" "Channel Allocator\n" "Allocate Timeslots and Transceivers in ascending order\n" "Allocate Timeslots and Transceivers in descending order\n") { diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index 0e0e8ca..aba8c40 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -906,7 +906,7 @@ } if (osmo_bsc_sigtran_init(&bsc_gsmnet->bsc_data->mscs) != 0) { - LOGP(DNM, LOGL_ERROR, "Failed to initalize sigtran backhaul.\n"); + LOGP(DNM, LOGL_ERROR, "Failed to initialize sigtran backhaul.\n"); exit(1); } diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index 763e1e1..0bf48a7 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -564,7 +564,7 @@ /* Start MSC-Reset procedure */ a_reset_alloc(msc, msc_name, osmo_bsc_sigtran_reset_cb); - /* If we have detected that the SS7 configuration of the MSC we have just initalized + /* If we have detected that the SS7 configuration of the MSC we have just initialized * was incomplete or completely missing, we can not tolerate another incomplete * configuration. The reson for this is that we do only specify exactly one default * pointcode pair. We also specify localhost as default IP-Address. If we have wanted diff --git a/src/osmo-bsc/osmo_bsc_vty.c b/src/osmo-bsc/osmo_bsc_vty.c index 4591ad1..e656d70 100644 --- a/src/osmo-bsc/osmo_bsc_vty.c +++ b/src/osmo-bsc/osmo_bsc_vty.c @@ -569,7 +569,7 @@ if (addr->presence & OSMO_SCCP_ADDR_T_SSN) { if (addr->ssn != OSMO_SCCP_SSN_BSSAP) vty_out(vty, - "setting an SSN (%u) different from the standard (%u) is not allowd, will use standard SSN for address: %s%s", + "setting an SSN (%u) different from the standard (%u) is not allowed, will use standard SSN for address: %s%s", addr->ssn, OSMO_SCCP_SSN_BSSAP, osmo_sccp_addr_dump(addr), VTY_NEWLINE); } diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index b71621d..4425117 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -421,7 +421,7 @@ rc = pcu_rx_data_req(bts, msg_type, &pcu_prim->u.data_req); break; default: - LOGP(DPCU, LOGL_ERROR, "Received unknwon PCU msg type %d\n", + LOGP(DPCU, LOGL_ERROR, "Received unknown PCU msg type %d\n", msg_type); rc = -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14810 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I63a733f8bea69f355a6686d99c3aa194c8ac9012 Gerrit-Change-Number: 14810 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 11:02:12 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 11:02:12 +0000 Subject: Change in ...osmo-bsc[master]: Fix one struct for big-endian archs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14811 ) Change subject: Fix one struct for big-endian archs ...................................................................... Patch Set 1: osmo-ci/scripts/libosmocore/contrib/struct_endianess.py preferred -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic6e654e0d95d662942c6485097f0b96e1fa46ead Gerrit-Change-Number: 14811 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 17 Jul 2019 11:02:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 11:02:40 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 11:02:40 +0000 Subject: Change in ...osmo-msc[master]: fix spelling detected by lintian In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14812 ) Change subject: fix spelling detected by lintian ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14812 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I01e54b5cf111677079a8ad57645d3ceb7834702a Gerrit-Change-Number: 14812 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 17 Jul 2019 11:02:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 11:02:41 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 11:02:41 +0000 Subject: Change in ...osmo-msc[master]: fix spelling detected by lintian In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14812 ) Change subject: fix spelling detected by lintian ...................................................................... fix spelling detected by lintian Change-Id: I01e54b5cf111677079a8ad57645d3ceb7834702a --- M doc/manuals/chapters/counters_generated.adoc M include/osmocom/msc/gsm_data.h M include/osmocom/msc/signal.h M src/libmsc/gsm_04_08.c 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/counters_generated.adoc b/doc/manuals/chapters/counters_generated.adoc index 6a3a3d2..1b40d8b 100644 --- a/doc/manuals/chapters/counters_generated.adoc +++ b/doc/manuals/chapters/counters_generated.adoc @@ -25,7 +25,7 @@ | sms:delivered | <> | Global SMS Deliver attempts. | sms:rp_err_mem | <> | CAUSE_MT_MEM_EXCEEDED errors of MS responses on a sms deliver attempt. | sms:rp_err_other | <> | Other error of MS responses on a sms delive attempt. -| sms:deliver_unknown_error | <> | Unknown error occured during sms delivery. +| sms:deliver_unknown_error | <> | Unknown error occurred during sms delivery. | call:mo_setup | <> | Received setup requests from a MS to init a MO call. | call:mo_connect_ack | <> | Received a connect ack from MS of a MO call. Call is now succesful connected up. | call:mt_setup | <> | Sent setup requests to the MS (MT). diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h index f6e3ed9..6050113 100644 --- a/include/osmocom/msc/gsm_data.h +++ b/include/osmocom/msc/gsm_data.h @@ -79,7 +79,7 @@ [MSC_CTR_SMS_DELIVERED] = {"sms:delivered", "Global SMS Deliver attempts."}, [MSC_CTR_SMS_RP_ERR_MEM] = {"sms:rp_err_mem", "CAUSE_MT_MEM_EXCEEDED errors of MS responses on a sms deliver attempt."}, [MSC_CTR_SMS_RP_ERR_OTHER] = {"sms:rp_err_other", "Other error of MS responses on a sms delive attempt."}, - [MSC_CTR_SMS_DELIVER_UNKNOWN_ERROR] = {"sms:deliver_unknown_error", "Unknown error occured during sms delivery."}, + [MSC_CTR_SMS_DELIVER_UNKNOWN_ERROR] = {"sms:deliver_unknown_error", "Unknown error occurred during sms delivery."}, /* FIXME: count also sms delivered */ [MSC_CTR_CALL_MO_SETUP] = {"call:mo_setup", "Received setup requests from a MS to init a MO call."}, [MSC_CTR_CALL_MO_CONNECT_ACK] = {"call:mo_connect_ack", "Received a connect ack from MS of a MO call. Call is now succesful connected up."}, diff --git a/include/osmocom/msc/signal.h b/include/osmocom/msc/signal.h index 16b5678..c7f8991 100644 --- a/include/osmocom/msc/signal.h +++ b/include/osmocom/msc/signal.h @@ -89,7 +89,7 @@ struct vty *vty; }; struct sms_signal_data { - /* The transaction where this occured */ + /* The transaction where this occurred */ struct gsm_trans *trans; /* Can be NULL for SMMA */ struct gsm_sms *sms; diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index 57dff41..ee31747 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -389,7 +389,7 @@ /* From vlr_loc_update() we expect an implicit dispatch of * VLR_ULA_E_UPDATE_LA, and thus we expect msc_vlr_subscr_assoc() to - * already have been called and completed. Has an error occured? */ + * already have been called and completed. Has an error occurred? */ vsub = msc_a_vsub(msc_a); if (!vsub) { @@ -786,7 +786,7 @@ is_utran); /* From vlr_proc_acc_req() we expect an implicit dispatch of PR_ARQ_E_START we expect - * msc_vlr_subscr_assoc() to already have been called and completed. Has an error occured? */ + * msc_vlr_subscr_assoc() to already have been called and completed. Has an error occurred? */ vsub = msc_a_vsub(msc_a); if (!vsub) { LOG_MSC_A(msc_a, LOGL_ERROR, "subscriber not allowed to do a CM Service Request\n"); @@ -1158,7 +1158,7 @@ is_utran); /* From vlr_proc_acc_req() we expect an implicit dispatch of PR_ARQ_E_START we expect - * msc_vlr_subscr_assoc() to already have been called and completed. Has an error occured? */ + * msc_vlr_subscr_assoc() to already have been called and completed. Has an error occurred? */ vsub = msc_a_vsub(msc_a); if (!vsub) { LOG_MSC_A(msc_a, LOGL_ERROR, "subscriber not allowed to do a Paging Response\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14812 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I01e54b5cf111677079a8ad57645d3ceb7834702a Gerrit-Change-Number: 14812 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 11:03:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 11:03:35 +0000 Subject: Change in ...osmo-hlr[master]: fix spelling errors detected by lintian In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14806 ) Change subject: fix spelling errors detected by lintian ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14806 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I2a1a21aceabc20fadc5dd28985a94689d2b873a2 Gerrit-Change-Number: 14806 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 11:03:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 11:03:45 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 11:03:45 +0000 Subject: Change in ...libosmocore[master]: Set HTML_TIMESTAMP to NO to make build reproducible In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14795 ) Change subject: Set HTML_TIMESTAMP to NO to make build reproducible ...................................................................... Set HTML_TIMESTAMP to NO to make build reproducible Change-Id: I56cce5cda0621f5e9f1c28aaad4646e9e267d17d --- M Doxyfile.codec.in M Doxyfile.core.in M Doxyfile.gsm.in M Doxyfile.vty.in 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/Doxyfile.codec.in b/Doxyfile.codec.in index 307e3e1..88f0d27 100644 --- a/Doxyfile.codec.in +++ b/Doxyfile.codec.in @@ -891,7 +891,7 @@ # page will contain the date and time when the page was generated. Setting # this to NO can help when comparing the output of multiple runs. -HTML_TIMESTAMP = YES +HTML_TIMESTAMP = NO # If the HTML_ALIGN_MEMBERS tag is set to YES, the members of classes, # files or namespaces will be aligned in HTML using tables. If set to diff --git a/Doxyfile.core.in b/Doxyfile.core.in index f83205a..c2bfcd5 100644 --- a/Doxyfile.core.in +++ b/Doxyfile.core.in @@ -891,7 +891,7 @@ # page will contain the date and time when the page was generated. Setting # this to NO can help when comparing the output of multiple runs. -HTML_TIMESTAMP = YES +HTML_TIMESTAMP = NO # If the HTML_ALIGN_MEMBERS tag is set to YES, the members of classes, # files or namespaces will be aligned in HTML using tables. If set to diff --git a/Doxyfile.gsm.in b/Doxyfile.gsm.in index aae0e89..fd89390 100644 --- a/Doxyfile.gsm.in +++ b/Doxyfile.gsm.in @@ -891,7 +891,7 @@ # page will contain the date and time when the page was generated. Setting # this to NO can help when comparing the output of multiple runs. -HTML_TIMESTAMP = YES +HTML_TIMESTAMP = NO # If the HTML_ALIGN_MEMBERS tag is set to YES, the members of classes, # files or namespaces will be aligned in HTML using tables. If set to diff --git a/Doxyfile.vty.in b/Doxyfile.vty.in index fb1cabf..9f56fd7 100644 --- a/Doxyfile.vty.in +++ b/Doxyfile.vty.in @@ -891,7 +891,7 @@ # page will contain the date and time when the page was generated. Setting # this to NO can help when comparing the output of multiple runs. -HTML_TIMESTAMP = YES +HTML_TIMESTAMP = NO # If the HTML_ALIGN_MEMBERS tag is set to YES, the members of classes, # files or namespaces will be aligned in HTML using tables. If set to -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I56cce5cda0621f5e9f1c28aaad4646e9e267d17d Gerrit-Change-Number: 14795 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Ruben Undheim Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Wed Jul 17 11:08:01 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 17 Jul 2019 11:08:01 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2f01ad4cd02_1ae288860099786@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 542s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 542s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 542s] collect2: error: ld returned 1 exit status [ 542s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 542s] make[4]: *** [osmo-bts-virtual] Error 1 [ 542s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 542s] Makefile:385: recipe for target 'all-recursive' failed [ 542s] make[3]: *** [all-recursive] Error 1 [ 542s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 542s] Makefile:434: recipe for target 'all-recursive' failed [ 542s] make[2]: *** [all-recursive] Error 1 [ 542s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 542s] Makefile:366: recipe for target 'all' failed [ 542s] make[1]: *** [all] Error 2 [ 542s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 542s] dh_auto_build: make -j1 returned exit code 2 [ 542s] debian/rules:12: recipe for target 'build' failed [ 542s] make: *** [build] Error 2 [ 542s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 542s] [ 542s] armbuild17 failed "build osmo-bts_0.8.1.344.af6f.dsc" at Wed Jul 17 11:07:49 UTC 2019. [ 542s] [ 542s] ### VM INTERACTION START ### [ 545s] [ 492.243361] sysrq: SysRq : Power Off [ 545s] [ 492.246871] reboot: Power down [ 546s] ### VM INTERACTION END ### [ 546s] [ 546s] armbuild17 failed "build osmo-bts_0.8.1.344.af6f.dsc" at Wed Jul 17 11:07:53 UTC 2019. [ 546s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Jul 17 11:22:38 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Wed, 17 Jul 2019 11:22:38 +0000 Subject: Change in ...osmocom-bb[master]: target/*.py: shebang: use /usr/bin/env python In-Reply-To: References: Message-ID: lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14759 ) Change subject: target/*.py: shebang: use /usr/bin/env python ...................................................................... target/*.py: shebang: use /usr/bin/env python Use the system default python instead of a hardcoded python2 Allow to use python2 and python3. Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 --- M src/target/firmware/solve_envs.py M src/target/trx_toolkit/app_common.py M src/target/trx_toolkit/burst_fwd.py M src/target/trx_toolkit/burst_gen.py M src/target/trx_toolkit/burst_send.py M src/target/trx_toolkit/clck_gen.py M src/target/trx_toolkit/ctrl_cmd.py M src/target/trx_toolkit/ctrl_if.py M src/target/trx_toolkit/ctrl_if_trx.py M src/target/trx_toolkit/data_dump.py M src/target/trx_toolkit/data_if.py M src/target/trx_toolkit/data_msg.py M src/target/trx_toolkit/fake_pm.py M src/target/trx_toolkit/fake_trx.py M src/target/trx_toolkit/gsm_shared.py M src/target/trx_toolkit/rand_burst_gen.py M src/target/trx_toolkit/transceiver.py M src/target/trx_toolkit/trx_list.py M src/target/trx_toolkit/trx_sniff.py M src/target/trx_toolkit/udp_link.py 20 files changed, 20 insertions(+), 20 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/target/firmware/solve_envs.py b/src/target/firmware/solve_envs.py index d4cee80..b010897 100755 --- a/src/target/firmware/solve_envs.py +++ b/src/target/firmware/solve_envs.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python import sys diff --git a/src/target/trx_toolkit/app_common.py b/src/target/trx_toolkit/app_common.py index 9bcd593..f2a47c5 100644 --- a/src/target/trx_toolkit/app_common.py +++ b/src/target/trx_toolkit/app_common.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/burst_fwd.py b/src/target/trx_toolkit/burst_fwd.py index 1d5dd7b..b418aef 100644 --- a/src/target/trx_toolkit/burst_fwd.py +++ b/src/target/trx_toolkit/burst_fwd.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/burst_gen.py b/src/target/trx_toolkit/burst_gen.py index b62f48c..6db8219 100755 --- a/src/target/trx_toolkit/burst_gen.py +++ b/src/target/trx_toolkit/burst_gen.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/burst_send.py b/src/target/trx_toolkit/burst_send.py index 6c19e6f..2565f4a 100755 --- a/src/target/trx_toolkit/burst_send.py +++ b/src/target/trx_toolkit/burst_send.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/clck_gen.py b/src/target/trx_toolkit/clck_gen.py index a4b83b5..3e479e3 100755 --- a/src/target/trx_toolkit/clck_gen.py +++ b/src/target/trx_toolkit/clck_gen.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/ctrl_cmd.py b/src/target/trx_toolkit/ctrl_cmd.py index bdacb64..7deeeac 100755 --- a/src/target/trx_toolkit/ctrl_cmd.py +++ b/src/target/trx_toolkit/ctrl_cmd.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/ctrl_if.py b/src/target/trx_toolkit/ctrl_if.py index 902af18..89dfe46 100644 --- a/src/target/trx_toolkit/ctrl_if.py +++ b/src/target/trx_toolkit/ctrl_if.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/ctrl_if_trx.py b/src/target/trx_toolkit/ctrl_if_trx.py index 8cb5c1a..e44f8a9 100644 --- a/src/target/trx_toolkit/ctrl_if_trx.py +++ b/src/target/trx_toolkit/ctrl_if_trx.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/data_dump.py b/src/target/trx_toolkit/data_dump.py index 71e1261..97518bd 100644 --- a/src/target/trx_toolkit/data_dump.py +++ b/src/target/trx_toolkit/data_dump.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/data_if.py b/src/target/trx_toolkit/data_if.py index 11df756..e43b388 100644 --- a/src/target/trx_toolkit/data_if.py +++ b/src/target/trx_toolkit/data_if.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/data_msg.py b/src/target/trx_toolkit/data_msg.py index e946229..ebb7a0f 100644 --- a/src/target/trx_toolkit/data_msg.py +++ b/src/target/trx_toolkit/data_msg.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/fake_pm.py b/src/target/trx_toolkit/fake_pm.py index 1992f8d..51dc057 100644 --- a/src/target/trx_toolkit/fake_pm.py +++ b/src/target/trx_toolkit/fake_pm.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py index 69cdd86..ab90af4 100755 --- a/src/target/trx_toolkit/fake_trx.py +++ b/src/target/trx_toolkit/fake_trx.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/gsm_shared.py b/src/target/trx_toolkit/gsm_shared.py index d76978e..71f43a7 100644 --- a/src/target/trx_toolkit/gsm_shared.py +++ b/src/target/trx_toolkit/gsm_shared.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/rand_burst_gen.py b/src/target/trx_toolkit/rand_burst_gen.py index 80ff3f2..c449418 100644 --- a/src/target/trx_toolkit/rand_burst_gen.py +++ b/src/target/trx_toolkit/rand_burst_gen.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py index 9c234fd..37680e7 100644 --- a/src/target/trx_toolkit/transceiver.py +++ b/src/target/trx_toolkit/transceiver.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/trx_list.py b/src/target/trx_toolkit/trx_list.py index 7bea560..8b4013d 100644 --- a/src/target/trx_toolkit/trx_list.py +++ b/src/target/trx_toolkit/trx_list.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/trx_sniff.py b/src/target/trx_toolkit/trx_sniff.py index 19ea8e6..add04e1 100755 --- a/src/target/trx_toolkit/trx_sniff.py +++ b/src/target/trx_toolkit/trx_sniff.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit diff --git a/src/target/trx_toolkit/udp_link.py b/src/target/trx_toolkit/udp_link.py index b378b63..8da15db 100644 --- a/src/target/trx_toolkit/udp_link.py +++ b/src/target/trx_toolkit/udp_link.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python2 +#!/usr/bin/env python # -*- coding: utf-8 -*- # TRX Toolkit -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14759 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab185759b574eff1ca1b189dcbb4e1a3eec52132 Gerrit-Change-Number: 14759 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 11:42:32 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 17 Jul 2019 11:42:32 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add docker container In-Reply-To: References: Message-ID: Hello laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/14779 to look at the new patch set (#3). Change subject: debian-repo-install-test: add docker container ...................................................................... debian-repo-install-test: add docker container Add own container with systemd, so we can (in a follow-up commit) run the Osmocom systemd services in this test job. Rewrite the "interactive shell" logic to support the new systemd docker container, and enable it with an INTERACTIVE environment variable instead of hardcoding 'interactive="true"' in the script. While at it, move the Repository.key install to the Dockerfile so it works more like the other docker containers we have. Related: OS#3369 Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 --- A debian-repo-install-test/Dockerfile A debian-repo-install-test/Makefile R debian-repo-install-test/Release.key M debian-repo-install-test/jenkins.sh M debian-repo-install-test/testdata/repo-install-test.sh 5 files changed, 50 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/79/14779/3 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 Gerrit-Change-Number: 14779 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 11:42:32 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 17 Jul 2019 11:42:32 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: kill already running In-Reply-To: References: Message-ID: Hello pespin, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/14780 to look at the new patch set (#4). Change subject: debian-repo-install-test: kill already running ...................................................................... debian-repo-install-test: kill already running The container grows heavily in size as the test runs, so make sure to always kill existing ones (from stopped jobs) before starting a new one. In order to do that, do not use $BUILD_TAG as container name, which changes with every new jenkins run. Related: OS#3369 Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f --- M debian-repo-install-test/jenkins.sh 1 file changed, 13 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/80/14780/4 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f Gerrit-Change-Number: 14780 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 11:43:51 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 17 Jul 2019 11:43:51 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add docker container In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14779 ) Change subject: debian-repo-install-test: add docker container ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14779/2/debian-repo-install-test/jenkins.sh File debian-repo-install-test/jenkins.sh: https://gerrit.osmocom.org/#/c/14779/2/debian-repo-install-test/jenkins.sh at 24 PS2, Line 24: if ! docker exec "$BUILD_TAG" systemctl status; then > In order to avoid race conditions on busy/slow systems, it would make more sense to have a 10 time l [?] Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 Gerrit-Change-Number: 14779 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 11:43:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 11:46:32 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Jul 2019 11:46:32 +0000 Subject: Change in ...osmo-bts[master]: common/rsl.c: fix: properly handle SI3 Rest Octets Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14817 Change subject: common/rsl.c: fix: properly handle SI3 Rest Octets ...................................................................... common/rsl.c: fix: properly handle SI3 Rest Octets It was noticed with old Sony Ericsson phones (like W595 and K510i) that the service provided by Osmocom network becomes unreliable from time to time. The RSSI indicator on those phones shows that the signal is lost, so neither CS nor PS services are working. As it then turned out, System Information 3 broadcasted on the Um interface is different than the one received from the BSC. In particular, the content SI3 Rest Octets IE is different. Among with the 'GPRS Indicator', which is actually expected to indicate whether the PCU is connected or now, SI3 Rest Octets on the Um interface contain both 'Optional Power Offset' and 'Scheduling if and where' IEs, which are not present in the original messages from the BSC. Moreover, as soon as the PCU is connected, 'GPRS Indicator' IE contains different 'GPRS RA Colour' value, and informs the MS that System Information 13 is sent on extended BCCH, which is not even supported by OsmoBTS! The culprit is in rsl_rx_bcch_info(), where we pass a pointer to osmo_gsm48_rest_octets_si3_decode(). Instead of passing a pointer to the beginning of SI3 buffer, we actually need to shift it to the beginning of the SI3 Rest Octets IE. This change makes my Sony Ericsson phones happy ;) Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 --- M src/common/rsl.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/17/14817/1 diff --git a/src/common/rsl.c b/src/common/rsl.c index 0a613bb..d66fd4e 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -368,7 +368,9 @@ LCHAN_REL_ACT_REACT; } /* decode original SI3 Rest Octets as sent by BSC */ - osmo_gsm48_rest_octets_si3_decode(&bts->si3_ro_decoded, GSM_BTS_SI(bts, osmo_si)); + const uint8_t *si3_ro_buf = bts->si_buf[osmo_si]; + si3_ro_buf += offsetof(struct gsm48_system_information_type_3, rest_octets); + osmo_gsm48_rest_octets_si3_decode(&bts->si3_ro_decoded, si3_ro_buf); /* patch out GPRS indicator from binary if PCU is not connected; will be enabled * after PCU connects */ regenerate_si3_restoctets(bts); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 Gerrit-Change-Number: 14817 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 12:01:29 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 17 Jul 2019 12:01:29 +0000 Subject: Change in ...osmo-bts[master]: common/rsl.c: fix: properly handle SI3 Rest Octets In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14817 ) Change subject: common/rsl.c: fix: properly handle SI3 Rest Octets ...................................................................... Patch Set 1: Code-Review+1 rsl.c:371:32: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] const uint8_t *si3_ro_buf = bts->si_buf[osmo_si]; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 Gerrit-Change-Number: 14817 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: tnt Gerrit-Comment-Date: Wed, 17 Jul 2019 12:01:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 12:05:08 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 17 Jul 2019 12:05:08 +0000 Subject: Change in ...osmo-iuh[master]: osmo-hnbgw.cfg: set local-ip to 0.0.0.0 In-Reply-To: References: Message-ID: Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 to look at the new patch set (#2). Change subject: osmo-hnbgw.cfg: set local-ip to 0.0.0.0 ...................................................................... osmo-hnbgw.cfg: set local-ip to 0.0.0.0 Make the config work out of the box for anyone. Related: OS#3369 Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec --- M doc/examples/osmo-hnbgw.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/82/14782/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec Gerrit-Change-Number: 14782 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 12:06:27 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 17 Jul 2019 12:06:27 +0000 Subject: Change in ...osmo-iuh[master]: osmo-hnbgw.cfg: set local-ip to 0.0.0.0 In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14782 ) Change subject: osmo-hnbgw.cfg: set local-ip to 0.0.0.0 ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14782/1/doc/examples/osmo-hnbgw.cfg File doc/examples/osmo-hnbgw.cfg: https://gerrit.osmocom.org/#/c/14782/1/doc/examples/osmo-hnbgw.cfg at 24 PS1, Line 24: local-ip 127.0.0.1 > ACK. How about 0.0.0. [?] Fine with me, changed to 0.0.0.0 (and checked that it works). -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec Gerrit-Change-Number: 14782 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 12:06:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 12:19:50 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Jul 2019 12:19:50 +0000 Subject: Change in ...osmo-bts[master]: common/rsl.c: fix: properly handle SI3 Rest Octets In-Reply-To: References: Message-ID: Hello laforge, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 to look at the new patch set (#2). Change subject: common/rsl.c: fix: properly handle SI3 Rest Octets ...................................................................... common/rsl.c: fix: properly handle SI3 Rest Octets It was noticed with old Sony Ericsson phones (like W595 and K510i) that the service provided by Osmocom network becomes unreliable from time to time. The RSSI indicator on those phones shows that the signal is lost, so neither CS nor PS services are working. As it then turned out, System Information 3 broadcasted on the Um interface is different than the one received from the BSC. In particular, the content SI3 Rest Octets IE is different. Among with the 'GPRS Indicator', which is actually expected to indicate whether the PCU is connected or now, SI3 Rest Octets on the Um interface contain both 'Optional Power Offset' and 'Scheduling if and where' IEs, which are not present in the original messages from the BSC. Moreover, as soon as the PCU is connected, 'GPRS Indicator' IE contains different 'GPRS RA Colour' value, and informs the MS that System Information 13 is sent on extended BCCH, which is not even supported by OsmoBTS! The culprit is in rsl_rx_bcch_info(), where we pass a pointer to osmo_gsm48_rest_octets_si3_decode(). Instead of passing a pointer to the beginning of SI3 buffer, we actually need to shift it to the beginning of the SI3 Rest Octets IE. This change makes my Sony Ericsson phones happy ;) Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 --- M src/common/rsl.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/17/14817/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 Gerrit-Change-Number: 14817 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: tnt Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 12:21:02 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Jul 2019 12:21:02 +0000 Subject: Change in ...osmo-iuh[master]: osmo-hnbgw.cfg: set local-ip to 0.0.0.0 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14782 ) Change subject: osmo-hnbgw.cfg: set local-ip to 0.0.0.0 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec Gerrit-Change-Number: 14782 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 12:21:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 13:47:21 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Jul 2019 13:47:21 +0000 Subject: Change in ...osmo-bts[master]: common/rsl.c: fix: properly handle SI3 Rest Octets In-Reply-To: References: Message-ID: Hello laforge, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 to look at the new patch set (#3). Change subject: common/rsl.c: fix: properly handle SI3 Rest Octets ...................................................................... common/rsl.c: fix: properly handle SI3 Rest Octets It was noticed with old Sony Ericsson phones (like W595 and K510i) that the service provided by Osmocom network becomes unreliable from time to time. The RSSI indicator on those phones shows that the signal is lost, so neither CS nor PS services are working. As it then turned out, System Information 3 broadcasted on the Um interface is different than the one received from the BSC. In particular, the content of SI3 Rest Octets IE is different. Among with the 'GPRS Indicator', which is actually expected to indicate whether the PCU is connected or not, SI3 Rest Octets on the Um interface contain both 'Optional Power Offset' and 'Scheduling if and where' IEs, which are not present in the original messages from the BSC. Moreover, as soon as the PCU is connected, 'GPRS Indicator' IE contains different 'GPRS RA Colour' value, and informs the MS that System Information 13 is sent on extended BCCH, which is not even supported by OsmoBTS! The culprit is in rsl_rx_bcch_info(), where we pass a pointer to osmo_gsm48_rest_octets_si3_decode(). Instead of passing a pointer to the beginning of SI3 buffer, we actually need to shift it to the beginning of the SI3 Rest Octets IE. This change makes my Sony Ericsson phones happy ;) Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 --- M src/common/rsl.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/17/14817/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 Gerrit-Change-Number: 14817 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: tnt Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Wed Jul 17 14:54:51 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 17 Jul 2019 14:54:51 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2f36c27e288_1ae2888600183551@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 209s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 209s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 209s] dh_installdocs [ 209s] dh_installchangelogs [ 209s] dh_python2 [ 209s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 209s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 209s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 209s] dh_python3 [ 209s] debian/rules override_dh_installinit [ 209s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 209s] # Install service file with different name than package name: [ 209s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 209s] dh_installinit --name=osmo-ctrl2cgi [ 209s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script nor default file not found [ 209s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 209s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 209s] make: *** [debian/rules:4: binary] Error 2 [ 209s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 209s] [ 209s] lamb56 failed "build osmo-python-tests_0.0.9.20190717.dsc" at Wed Jul 17 14:54:33 UTC 2019. [ 209s] [ 209s] ### VM INTERACTION START ### [ 213s] [ 194.914009] sysrq: SysRq : Power Off [ 213s] [ 194.919603] reboot: Power down [ 213s] ### VM INTERACTION END ### [ 213s] [ 213s] lamb56 failed "build osmo-python-tests_0.0.9.20190717.dsc" at Wed Jul 17 14:54:38 UTC 2019. [ 213s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Wed Jul 17 17:43:26 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 17 Jul 2019 17:43:26 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2f5e5e31219_1ae2888600214547@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 669s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 669s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 669s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 669s] Makefile:442: recipe for target 'vlr.o' failed [ 669s] make[4]: *** [vlr.o] Error 1 [ 669s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 669s] Makefile:422: recipe for target 'all-recursive' failed [ 669s] make[3]: *** [all-recursive] Error 1 [ 669s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 669s] Makefile:462: recipe for target 'all-recursive' failed [ 669s] make[2]: *** [all-recursive] Error 1 [ 669s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 669s] Makefile:394: recipe for target 'all' failed [ 669s] make[1]: *** [all] Error 2 [ 669s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 669s] dh_auto_build: make -j1 returned exit code 2 [ 669s] debian/rules:45: recipe for target 'build' failed [ 669s] make: *** [build] Error 2 [ 669s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 669s] [ 669s] armbuild16 failed "build osmo-msc_1.3.1.178.aa0a.dsc" at Wed Jul 17 17:43:15 UTC 2019. [ 669s] [ 669s] ### VM INTERACTION START ### [ 672s] [ 617.737477] sysrq: SysRq : Power Off [ 672s] [ 617.739848] reboot: Power down [ 672s] ### VM INTERACTION END ### [ 672s] [ 672s] armbuild16 failed "build osmo-msc_1.3.1.178.aa0a.dsc" at Wed Jul 17 17:43:19 UTC 2019. [ 672s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Wed Jul 17 18:07:43 2019 From: admin at opensuse.org (OBS Notification) Date: Wed, 17 Jul 2019 18:07:43 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2f6400559ad_1ae2888600218925@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 501s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 501s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 501s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 501s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 501s] make[4]: *** [gb_proxy.o] Error 1 [ 501s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 501s] Makefile:391: recipe for target 'all-recursive' failed [ 501s] make[3]: *** [all-recursive] Error 1 [ 501s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 501s] Makefile:453: recipe for target 'all-recursive' failed [ 501s] make[2]: *** [all-recursive] Error 1 [ 501s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 501s] Makefile:385: recipe for target 'all' failed [ 501s] make[1]: *** [all] Error 2 [ 501s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 501s] dh_auto_build: make -j1 returned exit code 2 [ 501s] debian/rules:45: recipe for target 'build' failed [ 501s] make: *** [build] Error 2 [ 501s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 501s] [ 501s] armbuild25 failed "build osmo-sgsn_1.4.0.28.43f16.dsc" at Wed Jul 17 18:07:27 UTC 2019. [ 501s] [ 501s] ### VM INTERACTION START ### [ 504s] [ 458.751946] sysrq: SysRq : Power Off [ 504s] [ 458.778271] reboot: Power down [ 504s] ### VM INTERACTION END ### [ 504s] [ 504s] armbuild25 failed "build osmo-sgsn_1.4.0.28.43f16.dsc" at Wed Jul 17 18:07:30 UTC 2019. [ 504s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Wed Jul 17 19:52:01 2019 From: gerrit-no-reply at lists.osmocom.org (roox) Date: Wed, 17 Jul 2019 19:52:01 +0000 Subject: Change in ...osmocom-bb[master]: Fix common misspellings and typos Message-ID: roox has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14818 Change subject: Fix common misspellings and typos ...................................................................... Fix common misspellings and typos Change-Id: I75df25d3bc2ecb4985bf6fefdde6e44b21bffed9 --- M src/host/layer23/README M src/host/layer23/include/osmocom/bb/misc/layer3.h M src/host/layer23/src/common/sap_proto.c M src/host/layer23/src/common/sim.c M src/host/layer23/src/misc/app_bcch_scan.c M src/host/layer23/src/misc/app_cbch_sniff.c M src/host/layer23/src/misc/cell_log.c M src/host/layer23/src/mobile/gsm322.c M src/host/layer23/src/mobile/gsm48_mm.c M src/host/layer23/src/mobile/gsm48_rr.c M src/host/layer23/src/mobile/main.c M src/host/layer23/src/mobile/mnccms.c M src/host/virt_phy/src/gsmtapl1_if.c M src/shared/libosmocore/Doxyfile.codec.in M src/shared/libosmocore/Doxyfile.core.in M src/shared/libosmocore/Doxyfile.gsm.in M src/shared/libosmocore/Doxyfile.vty.in M src/shared/libosmocore/doc/vty/example.xml M src/shared/libosmocore/include/osmocom/vty/command.h M src/shared/libosmocore/include/osmocom/vty/vector.h M src/shared/libosmocore/src/gb/gprs_ns.c M src/shared/libosmocore/src/gsm/auth_core.c M src/shared/libosmocore/src/gsm/gsm0411_smr.c M src/shared/libosmocore/src/gsm/gsm48.c M src/shared/libosmocore/src/gsm/lapd_core.c M src/shared/libosmocore/src/gsm/lapdm.c M src/shared/libosmocore/src/logging.c M src/shared/libosmocore/src/talloc.c M src/shared/libosmocore/src/utils.c M src/shared/libosmocore/src/vty/command.c M src/target/firmware/apps/rssi/main.c M src/target/firmware/apps/simtest/main.c M src/target/firmware/calypso/sim.c M src/target/firmware/comm/sercomm.c M src/target/firmware/fb/fb_s6b33b1x.c M src/target/firmware/include/fb/fb_bw8.h M src/target/firmware/layer1/prim_fbsb.c M src/target/firmware/layer1/prim_tch.c M src/target/firmware/layer1/sync.c M src/target/firmware/rf/trf6151.c M src/target/trx_toolkit/data_dump.py 41 files changed, 62 insertions(+), 62 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/18/14818/1 diff --git a/src/host/layer23/README b/src/host/layer23/README index dd59823..c52e7bc 100644 --- a/src/host/layer23/README +++ b/src/host/layer23/README @@ -30,7 +30,7 @@ RSL header (struct abis_rsl_common_hdr). There are utility functions like rslms_tx_rll_req() and rslms_tx_rsll_req_l3() -for creating msgb's with the apropriate RSL/RLL headers. +for creating msgb's with the appropriate RSL/RLL headers. === LAPDm === diff --git a/src/host/layer23/include/osmocom/bb/misc/layer3.h b/src/host/layer23/include/osmocom/bb/misc/layer3.h index bbf242d..ffafe76 100644 --- a/src/host/layer23/include/osmocom/bb/misc/layer3.h +++ b/src/host/layer23/include/osmocom/bb/misc/layer3.h @@ -11,7 +11,7 @@ /* Initialize layer3 for the MS, hook it to L2 */ int layer3_init(struct osmocom_ms *ms); -/* Reset the 'aplication' state */ +/* Reset the 'application' state */ void layer3_app_reset(void); #endif diff --git a/src/host/layer23/src/common/sap_proto.c b/src/host/layer23/src/common/sap_proto.c index c3d202f..ecacfe0 100644 --- a/src/host/layer23/src/common/sap_proto.c +++ b/src/host/layer23/src/common/sap_proto.c @@ -177,7 +177,7 @@ * \param[in] sap_msg pointer to SAP message header * \param[in] param_type parameter type (see sap_param_type enum) * \param[out] param_len parameter length (if found) - * \returns pointer to a given parameter withing the message, NULL otherwise + * \returns pointer to a given parameter within the message, NULL otherwise */ struct sap_param *sap_get_param(const struct sap_message *sap_msg, enum sap_param_type param_type, uint16_t *param_len) diff --git a/src/host/layer23/src/common/sim.c b/src/host/layer23/src/common/sim.c index ed7f54a..1e2bc51 100644 --- a/src/host/layer23/src/common/sim.c +++ b/src/host/layer23/src/common/sim.c @@ -1132,7 +1132,7 @@ case SIM_JOB_INCREASE: if (length != 4) { LOGP(DSIM, LOGL_ERROR, "expecting uint32_t as " - "value lenght, but got %d bytes\n", + "value length, but got %d bytes\n", length); goto request_error; } diff --git a/src/host/layer23/src/misc/app_bcch_scan.c b/src/host/layer23/src/misc/app_bcch_scan.c index 22e6f1b..5818530 100644 --- a/src/host/layer23/src/misc/app_bcch_scan.c +++ b/src/host/layer23/src/misc/app_bcch_scan.c @@ -53,7 +53,7 @@ int l23_app_init(struct osmocom_ms *ms) { - /* don't do layer3_init() as we don't want an actualy L3 */ + /* don't do layer3_init() as we don't want an actually L3 */ fps_init(); l1ctl_tx_reset_req(ms, L1CTL_RES_T_FULL); return osmo_signal_register_handler(SS_L1CTL, &signal_cb, NULL); diff --git a/src/host/layer23/src/misc/app_cbch_sniff.c b/src/host/layer23/src/misc/app_cbch_sniff.c index 8256eaf..ac222f7 100644 --- a/src/host/layer23/src/misc/app_cbch_sniff.c +++ b/src/host/layer23/src/misc/app_cbch_sniff.c @@ -179,7 +179,7 @@ int l23_app_init(struct osmocom_ms *ms) { - /* don't do layer3_init() as we don't want an actualy L3 */ + /* don't do layer3_init() as we don't want an actually L3 */ g_ms = ms; lapdm_channel_set_l3(&ms->lapdm_channel, &rcv_rsl, ms); diff --git a/src/host/layer23/src/misc/cell_log.c b/src/host/layer23/src/misc/cell_log.c index 7340dcb..9edd742 100644 --- a/src/host/layer23/src/misc/cell_log.c +++ b/src/host/layer23/src/misc/cell_log.c @@ -438,7 +438,7 @@ return 0; } -/* match request reference agains request */ +/* match request reference against request */ static int match_ra(struct osmocom_ms *ms, struct gsm48_req_ref *ref) { uint8_t ia_t1, ia_t2, ia_t3; diff --git a/src/host/layer23/src/mobile/gsm322.c b/src/host/layer23/src/mobile/gsm322.c index cfd70d8..fcb7edf 100644 --- a/src/host/layer23/src/mobile/gsm322.c +++ b/src/host/layer23/src/mobile/gsm322.c @@ -156,7 +156,7 @@ * * * subscr->plmn_list * - * The "PLMN Selector list" stores prefered networks to select during PLMN + * The "PLMN Selector list" stores preferred networks to select during PLMN * search process. This list is also stored in the SIM. * * * subscr->plmn_na @@ -201,7 +201,7 @@ * the BCCH data after 5 minutes. This timer is also used if sync or read * fails. * - * The C1 and C2 criterion is calculated for the currently monitored neigbour + * The C1 and C2 criterion is calculated for the currently monitored neighbour * cells. During this process, a better neighbour cell will trigger cell * re-selection. * @@ -427,14 +427,14 @@ return c2; } - /* penatly time reached */ + /* penalty time reached */ if (t >= (penalty_time + 1) * 20) { LOGP(DNB, LOGL_INFO, "C2 = C1 + CELL_RESELECT_OFFSET (%d) = %d " "(PENALTY_TIME reached)\n", cell_resel_off, c2); return c2; } - /* penalty time not reached, substract temporary offset */ + /* penalty time not reached, subtract temporary offset */ if (temp_offset < 7) c2 -= temp_offset * 10; else @@ -1865,7 +1865,7 @@ continue; } - /* check C1 criteria not fullfilled */ + /* check C1 criteria not fulfilled */ // TODO: class 3 DCS mobile gsm_arfcn2band_rc(index2arfcn(i), &band); class = class_of_band(ms, band); @@ -3490,7 +3490,7 @@ if (lower == higher) break; lower++; - /* wrap arround, only if not PCS */ + /* wrap around, only if not PCS */ if (lower == 1024) lower = 0; } @@ -4523,7 +4523,7 @@ if (!changed && cs->nb_meas_set) return 0; - /* start neigbour cell measurement task */ + /* start neighbour cell measurement task */ num = 0; llist_for_each_entry(nb, &cs->nb_list, entry) { if (nb->state == GSM322_NB_NOT_SUP) diff --git a/src/host/layer23/src/mobile/gsm48_mm.c b/src/host/layer23/src/mobile/gsm48_mm.c index 872dce5..fc87f12 100644 --- a/src/host/layer23/src/mobile/gsm48_mm.c +++ b/src/host/layer23/src/mobile/gsm48_mm.c @@ -193,7 +193,7 @@ * * * gsm48_mm_set_plmn_search() is used enter PLMN SEARCH or PLMN SEARCH NORMAL - * state. Depending on the conditions above, the appropiate state is selected. + * state. Depending on the conditions above, the appropriate state is selected. * * * gsm48_mm_return_idle() is used to select the Service state when returning @@ -1006,7 +1006,7 @@ if (s->t3212) /* still required? */ gsm48_mm_loc_upd_periodic(ms, NULL); else - LOGP(DMM, LOGL_INFO, "but not requred\n"); + LOGP(DMM, LOGL_INFO, "but not required\n"); /* must exit, because this function can be called * recursively */ @@ -2938,7 +2938,7 @@ /* release MM connection(s) */ gsm48_mm_release_mm_conn(ms, abort_any, 16, 0, 0); - /* state depends on the existance of remaining MM connections */ + /* state depends on the existence of remaining MM connections */ if (llist_empty(&mm->mm_conn)) new_mm_state(mm, GSM48_MM_ST_WAIT_NETWORK_CMD, 0); else @@ -3395,7 +3395,7 @@ /* release pending connection */ gsm48_mm_release_mm_conn(ms, 0, 102, 0, 0); - /* state depends on the existance of remaining MM connections */ + /* state depends on the existence of remaining MM connections */ if (llist_empty(&mm->mm_conn)) { /* start RR release timer */ start_mm_t3240(mm); @@ -3470,7 +3470,7 @@ if (conn) mm_conn_free(conn); - /* state depends on the existance of remaining MM connections */ + /* state depends on the existence of remaining MM connections */ if (llist_empty(&mm->mm_conn)) { /* start RR release timer */ start_mm_t3240(mm); @@ -4059,7 +4059,7 @@ msgb_free(msg); return 0; } - break; /* follow the selection proceedure below */ + break; /* follow the selection procedure below */ case GSM48_PDISC_CC: rc = gsm48_rcv_cc(ms, msg); diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index a94fc99..3e0c992 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -2077,7 +2077,7 @@ RR_EST_CAUSE_ANS_PAG_TCH_ANY }; -/* given LV of mobile identity is checked agains ms */ +/* given LV of mobile identity is checked against ms */ static uint8_t gsm_match_mi(struct osmocom_ms *ms, uint8_t *mi) { struct gsm322_cellsel *cs = &ms->cellsel; @@ -2305,7 +2305,7 @@ } else LOGP(DPAG, LOGL_INFO, " TMSI %08x (not for us)\n", ntohl(pa->tmsi2)); - /* thrid MI */ + /* third MI */ if (ms->subscr.tmsi == ntohl(pa->tmsi3) && ms->subscr.mcc == cs->sel_mcc && ms->subscr.mnc == cs->sel_mnc @@ -2335,7 +2335,7 @@ * (immediate) assignment */ -/* match request reference agains request history */ +/* match request reference against request history */ static int gsm48_match_ra(struct osmocom_ms *ms, struct gsm48_req_ref *ref) { struct gsm48_rrlayer *rr = &ms->rrlayer; @@ -3054,7 +3054,7 @@ LOGP(DRR, LOGL_INFO, "using cell channel descr.\n"); if (cd->cell_desc_lv[0] != 16) { LOGP(DRR, LOGL_ERROR, "cell channel descr. " - "has invalid lenght\n"); + "has invalid length\n"); return GSM48_RR_CAUSE_ABNORMAL_UNSPEC; } gsm48_decode_freq_list(freq, cd->cell_desc_lv + 1, 16, diff --git a/src/host/layer23/src/mobile/main.c b/src/host/layer23/src/mobile/main.c index 9764b33..3002a94 100644 --- a/src/host/layer23/src/mobile/main.c +++ b/src/host/layer23/src/mobile/main.c @@ -166,7 +166,7 @@ /* The first signal causes initiating of shutdown with detach * procedure. The second signal causes initiating of shutdown * without detach procedure. The third signal will exit process - * immidiately. (in case it hangs) + * immediately. (in case it hangs) */ if (count_int == 0) { fprintf(stderr, "Performing shutdown with clean " diff --git a/src/host/layer23/src/mobile/mnccms.c b/src/host/layer23/src/mobile/mnccms.c index 2243291..9a37b97 100644 --- a/src/host/layer23/src/mobile/mnccms.c +++ b/src/host/layer23/src/mobile/mnccms.c @@ -153,7 +153,7 @@ mncc->bearer_cap.speech_ctm = 0; /* if no specific speech_ver is given */ if (speech_ver < 0) { - /* if half rate is supported and prefered */ + /* if half rate is supported and preferred */ if (set->half_v3 && set->half && set->half_prefer) { mncc->bearer_cap.speech_ver[i++] = 5; LOGP(DMNCC, LOGL_INFO, " support half rate v3\n"); @@ -175,7 +175,7 @@ mncc->bearer_cap.speech_ver[i++] = 0; LOGP(DMNCC, LOGL_INFO, " support full rate v1\n"); } - /* if half rate is supported and not prefered */ + /* if half rate is supported and not preferred */ if (set->half_v3 && set->half && !set->half_prefer) { mncc->bearer_cap.speech_ver[i++] = 5; LOGP(DMNCC, LOGL_INFO, " support half rate v3\n"); @@ -331,7 +331,7 @@ vty_notify(ms, "Call: Remote out of order\n"); break; case GSM48_CC_CAUSE_INV_NR_FORMAT: - vty_notify(ms, "Call: Number invalid or imcomplete\n"); + vty_notify(ms, "Call: Number invalid or incomplete\n"); break; case GSM48_CC_CAUSE_NO_CIRCUIT_CHAN: vty_notify(ms, "Call: No channel available\n"); diff --git a/src/host/virt_phy/src/gsmtapl1_if.c b/src/host/virt_phy/src/gsmtapl1_if.c index 2cf9d2d..2b21c6d 100644 --- a/src/host/virt_phy/src/gsmtapl1_if.c +++ b/src/host/virt_phy/src/gsmtapl1_if.c @@ -135,7 +135,7 @@ return true; break; case 1: /* RLC/MAC Control without optional octets */ - /* forward all RLC/MAC control blocks without optional octets, i.e. not adressed + /* forward all RLC/MAC control blocks without optional octets, i.e. not addressed * to a specific TFI */ return true; case 2: /* RLC/MAC with optional control octets */ diff --git a/src/shared/libosmocore/Doxyfile.codec.in b/src/shared/libosmocore/Doxyfile.codec.in index fcd5122..07f3fe7 100644 --- a/src/shared/libosmocore/Doxyfile.codec.in +++ b/src/shared/libosmocore/Doxyfile.codec.in @@ -831,7 +831,7 @@ # standard header. Note that when using a custom header you are responsible # for the proper inclusion of any scripts and style sheets that doxygen # needs, which is dependent on the configuration options used. -# It is adviced to generate a default header using "doxygen -w html +# It is advised to generate a default header using "doxygen -w html # header.html footer.html stylesheet.css YourConfigFile" and then modify # that header. Note that the header is subject to change so you typically # have to redo this when upgrading to a newer version of doxygen or when changing the value of configuration settings such as GENERATE_TREEVIEW! diff --git a/src/shared/libosmocore/Doxyfile.core.in b/src/shared/libosmocore/Doxyfile.core.in index 18eb226..581baa0 100644 --- a/src/shared/libosmocore/Doxyfile.core.in +++ b/src/shared/libosmocore/Doxyfile.core.in @@ -831,7 +831,7 @@ # standard header. Note that when using a custom header you are responsible # for the proper inclusion of any scripts and style sheets that doxygen # needs, which is dependent on the configuration options used. -# It is adviced to generate a default header using "doxygen -w html +# It is advised to generate a default header using "doxygen -w html # header.html footer.html stylesheet.css YourConfigFile" and then modify # that header. Note that the header is subject to change so you typically # have to redo this when upgrading to a newer version of doxygen or when changing the value of configuration settings such as GENERATE_TREEVIEW! diff --git a/src/shared/libosmocore/Doxyfile.gsm.in b/src/shared/libosmocore/Doxyfile.gsm.in index ab25b22..20b4654 100644 --- a/src/shared/libosmocore/Doxyfile.gsm.in +++ b/src/shared/libosmocore/Doxyfile.gsm.in @@ -831,7 +831,7 @@ # standard header. Note that when using a custom header you are responsible # for the proper inclusion of any scripts and style sheets that doxygen # needs, which is dependent on the configuration options used. -# It is adviced to generate a default header using "doxygen -w html +# It is advised to generate a default header using "doxygen -w html # header.html footer.html stylesheet.css YourConfigFile" and then modify # that header. Note that the header is subject to change so you typically # have to redo this when upgrading to a newer version of doxygen or when changing the value of configuration settings such as GENERATE_TREEVIEW! diff --git a/src/shared/libosmocore/Doxyfile.vty.in b/src/shared/libosmocore/Doxyfile.vty.in index 57f19ad..a6bc357 100644 --- a/src/shared/libosmocore/Doxyfile.vty.in +++ b/src/shared/libosmocore/Doxyfile.vty.in @@ -831,7 +831,7 @@ # standard header. Note that when using a custom header you are responsible # for the proper inclusion of any scripts and style sheets that doxygen # needs, which is dependent on the configuration options used. -# It is adviced to generate a default header using "doxygen -w html +# It is advised to generate a default header using "doxygen -w html # header.html footer.html stylesheet.css YourConfigFile" and then modify # that header. Note that the header is subject to change so you typically # have to redo this when upgrading to a newer version of doxygen or when changing the value of configuration settings such as GENERATE_TREEVIEW! diff --git a/src/shared/libosmocore/doc/vty/example.xml b/src/shared/libosmocore/doc/vty/example.xml index 400c634..fdb5080 100644 --- a/src/shared/libosmocore/doc/vty/example.xml +++ b/src/shared/libosmocore/doc/vty/example.xml @@ -1,6 +1,6 @@ - + diff --git a/src/shared/libosmocore/include/osmocom/vty/command.h b/src/shared/libosmocore/include/osmocom/vty/command.h index 8fbb482..baf53ae 100644 --- a/src/shared/libosmocore/include/osmocom/vty/command.h +++ b/src/shared/libosmocore/include/osmocom/vty/command.h @@ -299,7 +299,7 @@ #define IN_STR "Filter incoming routing updates\n" #define V4NOTATION_STR "specify by IPv4 address notation(e.g. 0.0.0.0)\n" #define OSPF6_NUMBER_STR "Specify by number\n" -#define INTERFACE_STR "Interface infomation\n" +#define INTERFACE_STR "Interface information\n" #define IFNAME_STR "Interface name(e.g. ep0)\n" #define IP6_STR "IPv6 Information\n" #define OSPF6_STR "Open Shortest Path First (OSPF) for IPv6\n" diff --git a/src/shared/libosmocore/include/osmocom/vty/vector.h b/src/shared/libosmocore/include/osmocom/vty/vector.h index 22a184d..48e32fb 100644 --- a/src/shared/libosmocore/include/osmocom/vty/vector.h +++ b/src/shared/libosmocore/include/osmocom/vty/vector.h @@ -33,7 +33,7 @@ #define VECTOR_MIN_SIZE 1 -/* (Sometimes) usefull macros. This macro convert index expression to +/* (Sometimes) useful macros. This macro convert index expression to array expression. */ /* Reference slot at given index, caller must ensure slot is active */ #define vector_slot(V,I) ((V)->index[(I)]) diff --git a/src/shared/libosmocore/src/gb/gprs_ns.c b/src/shared/libosmocore/src/gb/gprs_ns.c index cdcf36e..e3b664c 100644 --- a/src/shared/libosmocore/src/gb/gprs_ns.c +++ b/src/shared/libosmocore/src/gb/gprs_ns.c @@ -32,7 +32,7 @@ * * Some introduction into NS: NS is used typically on top of frame relay, * but in the ip.access world it is encapsulated in UDP packets. It serves - * as an intermediate shim betwen BSSGP and the underlying medium. It doesn't + * as an intermediate shim between BSSGP and the underlying medium. It doesn't * do much, apart from providing congestion notification and status indication. * * Terms: @@ -910,7 +910,7 @@ nsi->timeout[NS_TOUT_TNS_ALIVE_RETRIES] = 10; /* Create the dummy NSVC that we use for sending - * messages to non-existant/unknown NS-VC's */ + * messages to non-existent/unknown NS-VC's */ nsi->unknown_nsvc = gprs_nsvc_create(nsi, 0xfffe); llist_del(&nsi->unknown_nsvc->list); diff --git a/src/shared/libosmocore/src/gsm/auth_core.c b/src/shared/libosmocore/src/gsm/auth_core.c index 5cf8dfc..0f790b7 100644 --- a/src/shared/libosmocore/src/gsm/auth_core.c +++ b/src/shared/libosmocore/src/gsm/auth_core.c @@ -132,7 +132,7 @@ * based on the permanent subscriber data, a random value as well as the * AUTS and RAND values returned by the SIM/MS. This special variant is * needed if the sequence numbers between MS and AUC have for some - * reason become diffrent. + * reason become different. */ int osmo_auth_gen_vec_auts(struct osmo_auth_vector *vec, struct osmo_sub_auth_data *aud, diff --git a/src/shared/libosmocore/src/gsm/gsm0411_smr.c b/src/shared/libosmocore/src/gsm/gsm0411_smr.c index 7dd8f72..41a2e23 100644 --- a/src/shared/libosmocore/src/gsm/gsm0411_smr.c +++ b/src/shared/libosmocore/src/gsm/gsm0411_smr.c @@ -117,7 +117,7 @@ { GSM411_RP_CAUSE_INV_TRANS_REF, "Invalid Transaction Reference" }, { GSM411_RP_CAUSE_SEMANT_INC_MSG, "Semantically Incorrect Message" }, { GSM411_RP_CAUSE_INV_MAND_INF, "Invalid Mandatory Information" }, - { GSM411_RP_CAUSE_MSGTYPE_NOTEXIST, "Message Type non-existant" }, + { GSM411_RP_CAUSE_MSGTYPE_NOTEXIST, "Message Type non-existent" }, { GSM411_RP_CAUSE_MSG_INCOMP_STATE, "Message incompatible with protocol state" }, { GSM411_RP_CAUSE_IE_NOTEXIST, "Information Element not existing" }, { GSM411_RP_CAUSE_PROTOCOL_ERR, "Protocol Error" }, diff --git a/src/shared/libosmocore/src/gsm/gsm48.c b/src/shared/libosmocore/src/gsm/gsm48.c index ea05d45..6dbb990 100644 --- a/src/shared/libosmocore/src/gsm/gsm48.c +++ b/src/shared/libosmocore/src/gsm/gsm48.c @@ -152,7 +152,7 @@ { GSM48_RR_CAUSE_CALL_CLEARED, "Call already cleared" }, { GSM48_RR_CAUSE_SEMANT_INCORR, "Semantically incorrect message" }, { GSM48_RR_CAUSE_INVALID_MAND_INF, "Invalid mandatory information" }, - { GSM48_RR_CAUSE_MSG_TYPE_N, "Message type non-existant or not implemented" }, + { GSM48_RR_CAUSE_MSG_TYPE_N, "Message type non-existent or not implemented" }, { GSM48_RR_CAUSE_MSG_TYPE_N_COMPAT, "Message type not compatible with protocol state" }, { GSM48_RR_CAUSE_COND_IE_ERROR, "Conditional IE error" }, { GSM48_RR_CAUSE_NO_CELL_ALLOC_A, "No cell allocation available" }, diff --git a/src/shared/libosmocore/src/gsm/lapd_core.c b/src/shared/libosmocore/src/gsm/lapd_core.c index 96099ed..651271e 100644 --- a/src/shared/libosmocore/src/gsm/lapd_core.c +++ b/src/shared/libosmocore/src/gsm/lapd_core.c @@ -833,7 +833,7 @@ #endif if (memcmp(dl->cont_res, msg->data, length)) { LOGP(DLLAPD, LOGL_INFO, "Another SABM " - "with diffrent content - " + "with different content - " "ignoring!\n"); msgb_free(msg); return 0; @@ -1037,7 +1037,7 @@ * parameters" is sent to the mobile management entity. */ LOGP(DLLAPD, LOGL_NOTICE, - "U frame iwth incorrect parameters "); + "U frame with incorrect parameters "); msgb_free(msg); mdl_error(MDL_CAUSE_UFRM_INC_PARAM, lctx); return -EIO; @@ -1216,7 +1216,7 @@ if (lctx->cr == dl->cr.rem2loc.resp && lctx->p_f && dl->state != LAPD_STATE_TIMER_RECOV) { - /* 5.4.2.2: Inidcate error on supervisory reponse F=1 */ + /* 5.4.2.2: Inidcate error on supervisory response F=1 */ LOGP(DLLAPD, LOGL_NOTICE, "S frame response with F=1 error\n"); mdl_error(MDL_CAUSE_UNSOL_SPRV_RESP, lctx); } diff --git a/src/shared/libosmocore/src/gsm/lapdm.c b/src/shared/libosmocore/src/gsm/lapdm.c index 1c08113..b244855 100644 --- a/src/shared/libosmocore/src/gsm/lapdm.c +++ b/src/shared/libosmocore/src/gsm/lapdm.c @@ -570,7 +570,7 @@ rsl_rll_error(RLL_CAUSE_FRM_UNIMPL, &mctx); return -EINVAL; } - /* adress field */ + /* address field */ lctx.lpd = LAPDm_ADDR_LPD(msg->l2h[0]); lctx.sapi = LAPDm_ADDR_SAPI(msg->l2h[0]); lctx.cr = LAPDm_ADDR_CR(msg->l2h[0]); diff --git a/src/shared/libosmocore/src/logging.c b/src/shared/libosmocore/src/logging.c index f58265f..447515d 100644 --- a/src/shared/libosmocore/src/logging.c +++ b/src/shared/libosmocore/src/logging.c @@ -113,7 +113,7 @@ "Log simply everything", "Log debug messages and higher levels", "Log informational messages and higher levels", - "Log noticable messages and higher levels", + "Log noticeable messages and higher levels", "Log error messages and higher levels", "Log only fatal messages", NULL, diff --git a/src/shared/libosmocore/src/talloc.c b/src/shared/libosmocore/src/talloc.c index d3a0690..fdeda40 100644 --- a/src/shared/libosmocore/src/talloc.c +++ b/src/shared/libosmocore/src/talloc.c @@ -701,7 +701,7 @@ /* remove a specific parent context from a pointer. This is a more - controlled varient of talloc_free() + controlled variant of talloc_free() */ int talloc_unlink(const void *context, void *ptr) { diff --git a/src/shared/libosmocore/src/utils.c b/src/shared/libosmocore/src/utils.c index cf0c934..7c05879 100644 --- a/src/shared/libosmocore/src/utils.c +++ b/src/shared/libosmocore/src/utils.c @@ -37,7 +37,7 @@ /*! \brief get numeric value for given human-readable string * \param[in] vs Array of value_string tuples * \param[in] str human-readable string - * \returns numeric value (>0) or negative numer in case of error + * \returns numeric value (>0) or negative number in case of error */ int get_string_value(const struct value_string *vs, const char *str) { diff --git a/src/shared/libosmocore/src/vty/command.c b/src/shared/libosmocore/src/vty/command.c index 7f83a5e..6938f45 100644 --- a/src/shared/libosmocore/src/vty/command.c +++ b/src/shared/libosmocore/src/vty/command.c @@ -1790,7 +1790,7 @@ } else index = vector_active(vline) - 1; - /* First, filter by preceeding command string */ + /* First, filter by preceding command string */ for (i = 0; i < index; i++) if ((command = vector_slot(vline, i))) { enum match_type match; diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index 5020486..e137806 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -1260,7 +1260,7 @@ /* Main Program */ const char *hr = "======================================================================\n"; -/* match request reference agains request history */ +/* match request reference against request history */ static int gsm48_match_ra(struct gsm48_req_ref *ref) { uint8_t ia_t1, ia_t2, ia_t3; diff --git a/src/target/firmware/apps/simtest/main.c b/src/target/firmware/apps/simtest/main.c index e20c52a..6c021db 100755 --- a/src/target/firmware/apps/simtest/main.c +++ b/src/target/firmware/apps/simtest/main.c @@ -214,7 +214,7 @@ uint8_t testDataBody[257]; uint8_t testStatusWord[2]; - int recivedChars; + int receivedChars; int i; uint8_t atr[20]; diff --git a/src/target/firmware/calypso/sim.c b/src/target/firmware/calypso/sim.c index 752628f..dc5885c 100644 --- a/src/target/firmware/calypso/sim.c +++ b/src/target/firmware/calypso/sim.c @@ -58,7 +58,7 @@ #define L3_MSG_HEAD 4 static uint8_t sim_data[256]; /* buffer for SIM command */ -static volatile uint16_t sim_len = 0; /* lenght of data in sim_data[] */ +static volatile uint16_t sim_len = 0; /* length of data in sim_data[] */ static volatile uint8_t sim_state = SIM_STATE_IDLE; /* current state of SIM process */ static volatile uint8_t sim_ignore_waiting_char = 0; diff --git a/src/target/firmware/comm/sercomm.c b/src/target/firmware/comm/sercomm.c index 490e225..cebd37d 100644 --- a/src/target/firmware/comm/sercomm.c +++ b/src/target/firmware/comm/sercomm.c @@ -182,7 +182,7 @@ sercomm_unlock(&flags); return 1; } else { - /* no more data avilable */ + /* no more data available */ sercomm_unlock(&flags); return 0; } diff --git a/src/target/firmware/fb/fb_s6b33b1x.c b/src/target/firmware/fb/fb_s6b33b1x.c index 788ada7..e36c547 100644 --- a/src/target/firmware/fb/fb_s6b33b1x.c +++ b/src/target/firmware/fb/fb_s6b33b1x.c @@ -72,7 +72,7 @@ { DATA, 0x0a }, /* DATA: fPCK = fOSC/6 */ { CMD, 0x2a }, /* CMD Contrast Control */ { DATA, 0x2d }, /* DATA: default contrast */ - { CMD, 0x30 }, /* CMD Adressing mode set */ + { CMD, 0x30 }, /* CMD Addressing mode set */ { DATA, 0x0b }, /* DATA: 65536 color mode */ { CMD, 0x10 }, /* CMD Driver output mode set */ { DATA, 0x03 }, /* DATA: Display duty: 1/132 */ diff --git a/src/target/firmware/include/fb/fb_bw8.h b/src/target/firmware/include/fb/fb_bw8.h index c77fa71..d84f91a 100644 --- a/src/target/firmware/include/fb/fb_bw8.h +++ b/src/target/firmware/include/fb/fb_bw8.h @@ -3,7 +3,7 @@ /* 8bit monochrome framebuffer, organized with 8 stacked pixels per byte, backed by local memory. fb_bw8.c lists functions that - are common to simmilar organized displays. */ + are common to similar organized displays. */ /* Sketch of Memory Layout diff --git a/src/target/firmware/layer1/prim_fbsb.c b/src/target/firmware/layer1/prim_fbsb.c index 50acefc..b4c1c1f 100644 --- a/src/target/firmware/layer1/prim_fbsb.c +++ b/src/target/firmware/layer1/prim_fbsb.c @@ -234,7 +234,7 @@ synchronize_tdma(&l1s.serving_cell); - /* if we have recived a SYNC burst, update our local GSM time */ + /* if we have received a SYNC burst, update our local GSM time */ gsm_fn2gsmtime(&l1s.current_time, fbs.mon.time.fn + SB2_LATENCY); /* compute next time from new current time */ l1s.next_time = l1s.current_time; diff --git a/src/target/firmware/layer1/prim_tch.c b/src/target/firmware/layer1/prim_tch.c index a8036d2..0254654 100644 --- a/src/target/firmware/layer1/prim_tch.c +++ b/src/target/firmware/layer1/prim_tch.c @@ -607,7 +607,7 @@ * ------------------------------------------------------------------------- */ /* - * SACCH data are spread over 4 bursts, however they are so far appart that + * SACCH data are spread over 4 bursts, however they are so far apart that * we can't use the normal scheduler to schedule all them at once in a single * set. * Therefore, the task code itself decides in which burst it is, if it's the diff --git a/src/target/firmware/layer1/sync.c b/src/target/firmware/layer1/sync.c index 36f4297..b1eedd0 100644 --- a/src/target/firmware/layer1/sync.c +++ b/src/target/firmware/layer1/sync.c @@ -168,7 +168,7 @@ dsp_api.ndb->d_dsp_page = 0; /* we have to really reset the TPU, otherwise FB detection - * somtimes returns wrong TOA values. */ + * sometimes returns wrong TOA values. */ tpu_reset(1); tpu_reset(0); tpu_rewind(); diff --git a/src/target/firmware/rf/trf6151.c b/src/target/firmware/rf/trf6151.c index 9de2cc8..6457e03 100644 --- a/src/target/firmware/rf/trf6151.c +++ b/src/target/firmware/rf/trf6151.c @@ -300,7 +300,7 @@ /* Low band. We have 3 possible PLL modes that output on * the right port: GSM900, GSM850_HIGH, GSM850_LOW. * - * The transistion points have been chosen looking at the VCO + * The transition points have been chosen looking at the VCO * and IF frequencies for various frequencies for theses modes */ if (freq_khz < 837100) { diff --git a/src/target/trx_toolkit/data_dump.py b/src/target/trx_toolkit/data_dump.py index 97518bd..11cd866 100644 --- a/src/target/trx_toolkit/data_dump.py +++ b/src/target/trx_toolkit/data_dump.py @@ -94,7 +94,7 @@ # True in case of success, # or False in case of EOF or header parsing error. def _seek2msg(self, idx): - # Seek to the begining of the capture + # Seek to the beginning of the capture self.f.seek(0) # Read the capture in loop... @@ -161,7 +161,7 @@ # or None in case of EOF or header parsing error, # or False in case of message parsing error or out of range. def parse_msg(self, idx): - # Move descriptor to the begining of requested message + # Move descriptor to the beginning of requested message rc = self._seek2msg(idx) if not rc: log.error("Couldn't find requested message") @@ -179,7 +179,7 @@ # Should we skip some messages? if skip is None: - # Seek to the begining of the capture + # Seek to the beginning of the capture self.f.seek(0) else: rc = self._seek2msg(skip) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14818 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I75df25d3bc2ecb4985bf6fefdde6e44b21bffed9 Gerrit-Change-Number: 14818 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 20:07:37 2019 From: gerrit-no-reply at lists.osmocom.org (roox) Date: Wed, 17 Jul 2019 20:07:37 +0000 Subject: Change in ...osmo-trx[master]: Fix common misspellings and typos Message-ID: roox has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14819 Change subject: Fix common misspellings and typos ...................................................................... Fix common misspellings and typos Change-Id: I8e0fe9d67d1e1e8dfce319610de63cde170694c5 --- M CommonLibs/Interthread.h M CommonLibs/Threads.h M CommonLibs/trx_vty.c M README M Transceiver52M/Resampler.h M Transceiver52M/Transceiver.h M Transceiver52M/arch/x86/convert.c M Transceiver52M/arch/x86/convolve.c M Transceiver52M/device/common/smpl_buf.h M Transceiver52M/inband-signaling-usb M autogen.sh M debian/changelog M doc/manuals/vty/trx_vty_reference.xml 13 files changed, 17 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/19/14819/1 diff --git a/CommonLibs/Interthread.h b/CommonLibs/Interthread.h index 42e6f7f..abb11c6 100644 --- a/CommonLibs/Interthread.h +++ b/CommonLibs/Interthread.h @@ -45,7 +45,7 @@ // (pat) The elements in the queue are type T*, and // the Fifo class implements the underlying queue. // The default is class PointerFIFO, which does not place any restrictions on the type of T, -// and is implemented by allocating auxilliary structures for the queue, +// and is implemented by allocating auxiliary structures for the queue, // or SingleLinkedList, which implements the queue using an internal pointer in type T, // which must implement the functional interface of class SingleLinkListNode, // namely: functions T*next() and void setNext(T*). diff --git a/CommonLibs/Threads.h b/CommonLibs/Threads.h index 8a6ba47..a914d51 100644 --- a/CommonLibs/Threads.h +++ b/CommonLibs/Threads.h @@ -182,7 +182,7 @@ } } - /** Send cancelation to thread */ + /** Send cancellation to thread */ void cancel() { pthread_cancel(mThread); } }; diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c index e184f49..3f1047e 100644 --- a/CommonLibs/trx_vty.c +++ b/CommonLibs/trx_vty.c @@ -222,7 +222,7 @@ DEFUN(cfg_clock_ref, cfg_clock_ref_cmd, "clock-ref (internal|external|gpsdo)", "Set the Reference Clock\n" - "Enable internal referece (default)\n" + "Enable internal reference (default)\n" "Enable external 10 MHz reference\n" "Enable GPSDO reference\n") { diff --git a/README b/README index 502d661..0d8cdcd 100644 --- a/README +++ b/README @@ -22,7 +22,7 @@ Commands on the Per-ARFCN Control Interface -The per-ARFCN control interface uses a command-reponse protocol. +The per-ARFCN control interface uses a command-response protocol. Commands are NULL-terminated ASCII strings, one per UDP socket. Each command has a corresponding response. Every command is of the form: diff --git a/Transceiver52M/Resampler.h b/Transceiver52M/Resampler.h index caffc08..14870fe 100644 --- a/Transceiver52M/Resampler.h +++ b/Transceiver52M/Resampler.h @@ -38,7 +38,7 @@ * @return false on error, zero otherwise * * Automatic setting is to compute the filter to prevent aliasing with - * a Blackman-Harris window. Adjustment is made through a bandwith + * a Blackman-Harris window. Adjustment is made through a bandwidth * factor to shift the cutoff and/or the constituent filter lengths. * Calculation of specific rolloff factors or 3-dB cutoff points is * left as an excersize for the reader. diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index a66c962..1d192d8 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -236,7 +236,7 @@ bool start(); void stop(); - /** Protect destructor accessable stop call */ + /** Protect destructor accessible stop call */ Mutex mLock; protected: diff --git a/Transceiver52M/arch/x86/convert.c b/Transceiver52M/arch/x86/convert.c index 07cdf59..bbcfd67 100644 --- a/Transceiver52M/arch/x86/convert.c +++ b/Transceiver52M/arch/x86/convert.c @@ -27,7 +27,7 @@ #include "config.h" #endif -/* Architecture dependant function pointers */ +/* Architecture dependent function pointers */ struct convert_cpu_context { void (*convert_si16_ps_16n) (float *, const short *, int); void (*convert_si16_ps) (float *, const short *, int); diff --git a/Transceiver52M/arch/x86/convolve.c b/Transceiver52M/arch/x86/convolve.c index 209d377..f25e2a7 100644 --- a/Transceiver52M/arch/x86/convolve.c +++ b/Transceiver52M/arch/x86/convolve.c @@ -27,7 +27,7 @@ #include "config.h" #endif -/* Architecture dependant function pointers */ +/* Architecture dependent function pointers */ struct convolve_cpu_context { void (*conv_cmplx_4n) (const float *, int, const float *, int, float *, int, int, int); diff --git a/Transceiver52M/device/common/smpl_buf.h b/Transceiver52M/device/common/smpl_buf.h index 24d3ce9..36e06b5 100644 --- a/Transceiver52M/device/common/smpl_buf.h +++ b/Transceiver52M/device/common/smpl_buf.h @@ -31,7 +31,7 @@ /* Sample Buffer - Allows reading and writing of timed samples using osmo-trx timestamps. Time conversions are handled - internally or accessable through the static convert calls. + internally or accessible through the static convert calls. */ class smpl_buf { public: diff --git a/Transceiver52M/inband-signaling-usb b/Transceiver52M/inband-signaling-usb index 14f8347..f3b038b 100644 --- a/Transceiver52M/inband-signaling-usb +++ b/Transceiver52M/inband-signaling-usb @@ -1,6 +1,6 @@ This file specifies the format of USB packets used for in-band data transmission and signaling on the USRP. All packets are 512-byte long, -and are transfered using USB "bulk" transfers. +and are transferred using USB "bulk" transfers. IN packets are sent towards the host. OUT packets are sent away from the host. diff --git a/autogen.sh b/autogen.sh index b2ed160..f1e8a2a 100755 --- a/autogen.sh +++ b/autogen.sh @@ -77,15 +77,15 @@ # ###################################################################### -# set to minimum acceptible version of autoconf +# set to minimum acceptable version of autoconf if [ "x$AUTOCONF_VERSION" = "x" ] ; then AUTOCONF_VERSION=2.52 fi -# set to minimum acceptible version of automake +# set to minimum acceptable version of automake if [ "x$AUTOMAKE_VERSION" = "x" ] ; then AUTOMAKE_VERSION=1.6.0 fi -# set to minimum acceptible version of libtool +# set to minimum acceptable version of libtool if [ "x$LIBTOOL_VERSION" = "x" ] ; then LIBTOOL_VERSION=1.4.2 fi @@ -970,7 +970,7 @@ if test ! -d "$_aux_dir" ; then _aux_dir=. else - $VERBOSE_ECHO "Detected auxillary directory: $_aux_dir" + $VERBOSE_ECHO "Detected auxiliary directory: $_aux_dir" fi ################################ @@ -1196,7 +1196,7 @@ $ECHO "Warning: $AUTORECONF failed" if test -f ltmain.sh ; then - $ECHO "libtoolize being run by autoreconf is not creating ltmain.sh in the auxillary directory like it should" + $ECHO "libtoolize being run by autoreconf is not creating ltmain.sh in the auxiliary directory like it should" fi $ECHO "Attempting to run the preparation steps individually" diff --git a/debian/changelog b/debian/changelog index dc20ec8..8dab530 100644 --- a/debian/changelog +++ b/debian/changelog @@ -226,7 +226,7 @@ * use osmo_init_logging2() * tests: Makefile.am: Fix typo in include path * configure.ac: Add --enable-sanitize option - * Move arch specific fiels to arch subdir + * Move arch specific files to arch subdir * Move device specific files to device subdir * Change configure define USRP1 to DEVICE_USRP1 * Move device specific code out of radioInterface diff --git a/doc/manuals/vty/trx_vty_reference.xml b/doc/manuals/vty/trx_vty_reference.xml index ce6d335..a3f38ae 100644 --- a/doc/manuals/vty/trx_vty_reference.xml +++ b/doc/manuals/vty/trx_vty_reference.xml @@ -1196,7 +1196,7 @@ - + -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14819 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8e0fe9d67d1e1e8dfce319610de63cde170694c5 Gerrit-Change-Number: 14819 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 20:11:59 2019 From: gerrit-no-reply at lists.osmocom.org (roox) Date: Wed, 17 Jul 2019 20:11:59 +0000 Subject: Change in ...osmo-remsim[master]: Fix common misspellings and typos Message-ID: roox has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14820 Change subject: Fix common misspellings and typos ...................................................................... Fix common misspellings and typos Change-Id: I8152acaccd33a4b646d56cba0748aeefa0c16b35 --- M doc/manuals/chapters/remsim-bankd.adoc M include/osmocom/rspro/INTEGER.h M include/osmocom/rspro/constr_TYPE.h M include/osmocom/rspro/per_support.h M src/rspro/NativeInteger.c M src/rspro/OCTET_STRING.c M src/rspro/ber_tlv_tag.c M src/rspro/constr_CHOICE.c M src/rspro/constr_SEQUENCE.c M src/rspro/converter-sample.c M src/rspro/per_opentype.c M src/simtrace2/apdu_dispatch.c 12 files changed, 14 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/20/14820/1 diff --git a/doc/manuals/chapters/remsim-bankd.adoc b/doc/manuals/chapters/remsim-bankd.adoc index d35056b..a3a1921 100644 --- a/doc/manuals/chapters/remsim-bankd.adoc +++ b/doc/manuals/chapters/remsim-bankd.adoc @@ -127,4 +127,4 @@ ---- In this example, there's only a single PC/SC reader available, and it has a string of -"Alcor Micro AU9560 00 00" whcih needs to be copy-pasted into the CSV file. +"Alcor Micro AU9560 00 00" which needs to be copy-pasted into the CSV file. diff --git a/include/osmocom/rspro/INTEGER.h b/include/osmocom/rspro/INTEGER.h index e8b36c7..c8edf12 100644 --- a/include/osmocom/rspro/INTEGER.h +++ b/include/osmocom/rspro/INTEGER.h @@ -68,8 +68,8 @@ ASN_STRTOL_ERROR_RANGE = -3, /* Input outside of numeric range for long type */ ASN_STRTOL_ERROR_INVAL = -2, /* Invalid data encountered (e.g., "+-") */ ASN_STRTOL_EXPECT_MORE = -1, /* More data expected (e.g. "+") */ - ASN_STRTOL_OK = 0, /* Conversion succeded, number ends at (*end) */ - ASN_STRTOL_EXTRA_DATA = 1, /* Conversion succeded, but the string has extra stuff */ + ASN_STRTOL_OK = 0, /* Conversion succeeded, number ends at (*end) */ + ASN_STRTOL_EXTRA_DATA = 1, /* Conversion succeeded, but the string has extra stuff */ }; enum asn_strtol_result_e asn_strtol_lim(const char *str, const char **end, long *l); diff --git a/include/osmocom/rspro/constr_TYPE.h b/include/osmocom/rspro/constr_TYPE.h index 13c60f3..e244d20 100644 --- a/include/osmocom/rspro/constr_TYPE.h +++ b/include/osmocom/rspro/constr_TYPE.h @@ -158,8 +158,8 @@ typedef struct asn_TYPE_tag2member_s { ber_tlv_tag_t el_tag; /* Outmost tag of the member */ int el_no; /* Index of the associated member, base 0 */ - int toff_first; /* First occurence of the el_tag, relative */ - int toff_last; /* Last occurence of the el_tag, relatvie */ + int toff_first; /* First occurrence of the el_tag, relative */ + int toff_last; /* Last occurrence of the el_tag, relatvie */ } asn_TYPE_tag2member_t; /* diff --git a/include/osmocom/rspro/per_support.h b/include/osmocom/rspro/per_support.h index 181fe24..ed945ce 100644 --- a/include/osmocom/rspro/per_support.h +++ b/include/osmocom/rspro/per_support.h @@ -53,7 +53,7 @@ */ int32_t per_get_few_bits(asn_per_data_t *per_data, int get_nbits); -/* Undo the immediately preceeding "get_few_bits" operation */ +/* Undo the immediately preceding "get_few_bits" operation */ void per_get_undo(asn_per_data_t *per_data, int get_nbits); /* diff --git a/src/rspro/NativeInteger.c b/src/rspro/NativeInteger.c index ef17bee..17a58ea 100644 --- a/src/rspro/NativeInteger.c +++ b/src/rspro/NativeInteger.c @@ -94,7 +94,7 @@ /* * ASN.1 encoded INTEGER: buf_ptr, length * Fill the native, at the same time checking for overflow. - * If overflow occured, return with RC_FAIL. + * If overflow occurred, return with RC_FAIL. */ { INTEGER_t tmp; diff --git a/src/rspro/OCTET_STRING.c b/src/rspro/OCTET_STRING.c index 3e424e7..6df9a0a 100644 --- a/src/rspro/OCTET_STRING.c +++ b/src/rspro/OCTET_STRING.c @@ -109,7 +109,7 @@ /* * The main reason why ASN.1 is still alive is that too much time and effort * is necessary for learning it more or less adequately, thus creating a gut - * necessity to demonstrate that aquired skill everywhere afterwards. + * necessity to demonstrate that acquired skill everywhere afterwards. * No, I am not going to explain what the following stuff is. */ struct _stack_el { diff --git a/src/rspro/ber_tlv_tag.c b/src/rspro/ber_tlv_tag.c index 4270876..adf3a25 100644 --- a/src/rspro/ber_tlv_tag.c +++ b/src/rspro/ber_tlv_tag.c @@ -42,7 +42,7 @@ */ if(val >> ((8 * sizeof(val)) - 9)) { /* - * We would not be able to accomodate + * We would not be able to accommodate * any more tag bits. */ return -1; diff --git a/src/rspro/constr_CHOICE.c b/src/rspro/constr_CHOICE.c index 18c24cd..6a88b29 100644 --- a/src/rspro/constr_CHOICE.c +++ b/src/rspro/constr_CHOICE.c @@ -156,7 +156,7 @@ } if(ctx->left >= 0) { - /* ?Substracted below! */ + /* ?Subtracted below! */ ctx->left += rval.consumed; } ADVANCE(rval.consumed); diff --git a/src/rspro/constr_SEQUENCE.c b/src/rspro/constr_SEQUENCE.c index 21e5190..0ffa282 100644 --- a/src/rspro/constr_SEQUENCE.c +++ b/src/rspro/constr_SEQUENCE.c @@ -166,7 +166,7 @@ } if(ctx->left >= 0) - ctx->left += rval.consumed; /* ?Substracted below! */ + ctx->left += rval.consumed; /* ?Subtracted below! */ ADVANCE(rval.consumed); NEXT_PHASE(ctx); diff --git a/src/rspro/converter-sample.c b/src/rspro/converter-sample.c index 2f74a80..6047273 100644 --- a/src/rspro/converter-sample.c +++ b/src/rspro/converter-sample.c @@ -390,7 +390,7 @@ /* * Move the buffer content left N bits, possibly joining it with - * preceeding content. + * preceding content. */ static void buffer_shift_left(size_t offset, int bits) { diff --git a/src/rspro/per_opentype.c b/src/rspro/per_opentype.c index 8c42f8b..e697cbb 100644 --- a/src/rspro/per_opentype.c +++ b/src/rspro/per_opentype.c @@ -154,7 +154,7 @@ } else { FREEMEM(buf); /* rv.code could be RC_WMORE, nonsense in this context */ - rv.code = RC_FAIL; /* Noone would give us more */ + rv.code = RC_FAIL; /* No one would give us more */ } return rv; diff --git a/src/simtrace2/apdu_dispatch.c b/src/simtrace2/apdu_dispatch.c index 7c7ed01..b9dc3b7 100644 --- a/src/simtrace2/apdu_dispatch.c +++ b/src/simtrace2/apdu_dispatch.c @@ -59,7 +59,7 @@ } /*! \brief input function for APDU segmentation - * \param ac APDU context accross successive calls + * \param ac APDU context across successive calls * \param[in] apdu_buf APDU inpud data buffer * \param[in] apdu_len Length of apdu_buf * \param[in] new_apdu Is this the beginning of a new APDU? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8152acaccd33a4b646d56cba0748aeefa0c16b35 Gerrit-Change-Number: 14820 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 20:38:31 2019 From: gerrit-no-reply at lists.osmocom.org (roox) Date: Wed, 17 Jul 2019 20:38:31 +0000 Subject: Change in ...osmo-bts[master]: Fix common misspellings and typos Message-ID: roox has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14821 Change subject: Fix common misspellings and typos ...................................................................... Fix common misspellings and typos Change-Id: I00ebf013104b55decbdd7f758756a19b220dc7b3 --- M README.md M debian/changelog M doc/manuals/rtp-amr.adoc M doc/manuals/vty/bts_vty_reference.xml M src/common/l1sap.c M src/osmo-bts-litecell15/misc/lc15bts_mgr_calib.c M src/osmo-bts-litecell15/misc/lc15bts_mgr_vty.c M src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c M src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c M src/osmo-bts-octphy/l1_oml.c M src/osmo-bts-sysmo/misc/sysmobts-layer1.c M src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c M src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c M tests/meas/meas_test.c 14 files changed, 118 insertions(+), 118 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/21/14821/1 diff --git a/README.md b/README.md index 7e26d82..1fca596 100644 --- a/README.md +++ b/README.md @@ -45,7 +45,7 @@ as well as a [VTY Reference Manual](http://ftp.osmocom.org/docs/latest/osmobsc-vty-reference.pdf) and a -[Abis refrence MAnual](http://ftp.osmocom.org/docs/latest/osmobts-abis.pdf) +[Abis reference MAnual](http://ftp.osmocom.org/docs/latest/osmobts-abis.pdf) describing the OsmoBTS specific A-bis dialect. Mailing List diff --git a/debian/changelog b/debian/changelog index a33d21f..0dce96c 100644 --- a/debian/changelog +++ b/debian/changelog @@ -133,7 +133,7 @@ * bts_model: Allow TS connect to be processed asynchronously * OsmoBTS/chapters/configuration.adoc: Add bts index in example * OsmoBTS: Update osmotrx ip to diff between local and remote - * rtp-amr: Describe requirement to recieve all PH-DATA.ind events + * rtp-amr: Describe requirement to receive all PH-DATA.ind events * rtp-amr: Fix typo and trailing whitespace * Allow easily disabling GFDL references * OsmoBTS: bts-models: Add Lime Microsystems devices as supported osmo-trx @@ -341,7 +341,7 @@ * RSL: Implement DELETE INDICATION on AGCH overflow * RSL: Send ERROR REPORT on too short/truncated messages + wrong discriminator * BTS: add rate_ctr about CCCH (paging, agch, pch) - * paging: Drop + Log paging requests for non-existant paging groups + * paging: Drop + Log paging requests for non-existent paging groups * paging.c: Fix encoding of optional Mobile ID RR PAGING TYPE 1 / 2 * rsl: Improve ERROR REPORTing * paging: Fix encoding of PAGING TYPE 3 Rest Octets @@ -601,7 +601,7 @@ * Add Abis OML failure event reporting * Alarm on various errors * Remove obsolete define TLVP_PRES_LEN - * scheduler: log lchan on which prim error occured + * scheduler: log lchan on which prim error occurred * deb: use gsm_data_shared.* from openbsc-dev * OML: internalize failure reporting * Add ctrl command to send OML alert diff --git a/doc/manuals/rtp-amr.adoc b/doc/manuals/rtp-amr.adoc index 5a36aea..0c733d1 100644 --- a/doc/manuals/rtp-amr.adoc +++ b/doc/manuals/rtp-amr.adoc @@ -95,10 +95,10 @@ phy => bts [label="PH-DATA.ind GsmL1_TchPlType_Amr (SID_FIRST)"]; bts => mgw [label="RTP (AMR FT=SID,Q=1)"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; @@ -110,10 +110,10 @@ bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind GsmL1_TchPlType_Amr (SID_UPDATE)"]; bts => mgw [label="RTP (AMR FT=SID,Q=1)"]; } @@ -123,7 +123,7 @@ the SID_FIRST frame is immediately followed by a speech frame. It has been observed that some phone does not transmit the last 4 bursts even if it is not followed by a speech frame. -ULSU2:: There must be exactly two supressed voice frames between the +ULSU2:: There must be exactly two suppressed voice frames between the SID_FIRST and the SID_UPDATE, i.e. there's 60ms between SID_FIRST and SID_UPDATE. @@ -152,52 +152,52 @@ phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind GsmL1_TchPlType_Amr (SID_UPDATE)"]; bts => mgw [label="RTP (AMR FT=SID,Q=1)"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; @@ -208,10 +208,10 @@ phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind GsmL1_TchPlType_Amr (SID_UPDATE)"]; bts => mgw [label="RTP (AMR FT=SID,Q=1)"]; } @@ -254,10 +254,10 @@ ...; --- [label="Once voice is active again"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; @@ -345,10 +345,10 @@ ...; --- [label="FACCH/F Frame During DTX"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; @@ -368,10 +368,10 @@ phy => bts [label="PH-DATA.ind FACCH/F"]; bts => mgw [label="FACCH/F"]; - ms -x phy [label="Supressed L1 burst", id="ULSF2"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst", id="ULSF2"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind GsmL1_TchPlType_Amr (SID_FIRST)"]; bts => mgw [label="RTP (AMR FT=SID,Q=1)"]; ...; @@ -660,10 +660,10 @@ phy => bts [label="PH-RTS.ind (TCH)"]; phy <= bts [label="PH-EMPTY-FRAME.req (FACCH/F)"]; phy <= bts [label="PH-EMPTY-FRAME.req (TCH/F)"]; - ms x- phy [label="Supressed burst"]; - ms x- phy [label="Supressed burst"]; - ms x- phy [label="Supressed burst"]; - ms x- phy [label="Supressed burst"]; + ms x- phy [label="Suppressed burst"]; + ms x- phy [label="Suppressed burst"]; + ms x- phy [label="Suppressed burst"]; + ms x- phy [label="Suppressed burst"]; } ---- @@ -738,8 +738,8 @@ phy => bts [label="PH-DATA.ind GsmL1_TchPlType_Amr (N)"]; bts => mgw [label="RTP (AMR FT=0..7,Q=1)"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind GsmL1_TchPlType_Amr_SidFirstP1", id="ULSF1"]; bts => mgw [label="RTP (AMR FT=SID,Q=1)"]; @@ -753,8 +753,8 @@ phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind GsmL1_TchPlType_Amr (SID_UPDATE)"]; bts => mgw [label="RTP (AMR FT=SID,Q=1)"]; } @@ -764,7 +764,7 @@ NOTE:: It has been observed that not all phones transmit SID_FIRST_P2 so the PH-DATA.ind GsmL1_TchPlType_Amr_SidFirstP2 is not guaranteed to be sent to the BTS. -ULSU1:: There must be exactly two supressed voice frames between the +ULSU1:: There must be exactly two suppressed voice frames between the SID_FIRST and the SID_UPDATE, i.e. there's 60ms between SID_FIRST and SID_UPDATE. @@ -795,33 +795,33 @@ phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind GsmL1_TchPlType_Amr (SID_UPDATE)"]; bts => mgw [label="RTP (AMR FT=SID,Q=1)"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; @@ -834,8 +834,8 @@ phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind GsmL1_TchPlType_Amr (SID_UPDATE)"]; bts => mgw [label="RTP (AMR FT=SID,Q=1)"]; } @@ -910,7 +910,7 @@ been transmitted yet, SID_FIRST can be inhibited by means of a SID_FIRST_INH frame. This allows the first voice frame to be transmitted with minimal delay, compared to first completing -the regular SID_FIRTS_P2 and SID_ONSET procedure. +the regular SID_FIRST_P2 and SID_ONSET procedure. ["mscgen"] ---- @@ -999,8 +999,8 @@ ...; ms .. mgw [label="FACCH/H during DTX operation"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; @@ -1026,8 +1026,8 @@ phy => bts [label="PH-DATA.ind with empty payload"]; bts -x mgw [label="Suppressed RTP frame"]; - ms -x phy [label="Supressed L1 burst"]; - ms -x phy [label="Supressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; + ms -x phy [label="Suppressed L1 burst"]; phy => bts [label="PH-DATA.ind GsmL1_TchPlType_Amr_SidFirstP1"]; bts => mgw [label="RTP (AMR FT=SID,Q=1)"]; } diff --git a/doc/manuals/vty/bts_vty_reference.xml b/doc/manuals/vty/bts_vty_reference.xml index b50ac1b..c2035dd 100644 --- a/doc/manuals/vty/bts_vty_reference.xml +++ b/doc/manuals/vty/bts_vty_reference.xml @@ -173,7 +173,7 @@ - + @@ -542,7 +542,7 @@ - + @@ -1113,7 +1113,7 @@ - + diff --git a/src/common/l1sap.c b/src/common/l1sap.c index b730b85..389f4cf 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -160,7 +160,7 @@ } /* allocate a msgb containing a osmo_phsap_prim + optional l2 data - * in order to wrap femtobts header arround l2 data, there must be enough space + * in order to wrap femtobts header around l2 data, there must be enough space * in front and behind data pointer */ struct msgb *l1sap_msgb_alloc(unsigned int l2_len) { @@ -715,7 +715,7 @@ int is_ccch_for_agch(struct gsm_bts_trx *trx, uint32_t fn) { /* Note: The number of available access grant channels is set by the * parameter BS_AG_BLKS_RES via system information type 3. This SI is - * transfered to osmo-bts via RSL */ + * transferred to osmo-bts via RSL */ return l1sap_fn2ccch_block(fn) < num_agch(trx, "PH-RTS-IND"); } diff --git a/src/osmo-bts-litecell15/misc/lc15bts_mgr_calib.c b/src/osmo-bts-litecell15/misc/lc15bts_mgr_calib.c index badb545..903c5cd 100644 --- a/src/osmo-bts-litecell15/misc/lc15bts_mgr_calib.c +++ b/src/osmo-bts-litecell15/misc/lc15bts_mgr_calib.c @@ -233,7 +233,7 @@ */ int timeout = 60; //int timeout = 2 * 60 * 60; - //if (outcome != CALIB_SUCESS) } + //if (outcome != CALIB_SUCCESS) } // timeout = 5 * 60; //} diff --git a/src/osmo-bts-litecell15/misc/lc15bts_mgr_vty.c b/src/osmo-bts-litecell15/misc/lc15bts_mgr_vty.c index 80751fb..424ff18 100644 --- a/src/osmo-bts-litecell15/misc/lc15bts_mgr_vty.c +++ b/src/osmo-bts-litecell15/misc/lc15bts_mgr_vty.c @@ -584,39 +584,39 @@ lc15bts_mgr_sensor_get_state(s_mgr->state.state), VTY_NEWLINE); vty_out(vty, "Current Temperatures%s", VTY_NEWLINE); lc15bts_temp_get(LC15BTS_TEMP_SUPPLY, &temp); - vty_out(vty, " Main Supply : %4.2f Celcius%s", + vty_out(vty, " Main Supply : %4.2f Celsius%s", temp/ 1000.0f, VTY_NEWLINE); lc15bts_temp_get(LC15BTS_TEMP_SOC, &temp); - vty_out(vty, " SoC : %4.2f Celcius%s", + vty_out(vty, " SoC : %4.2f Celsius%s", temp / 1000.0f, VTY_NEWLINE); lc15bts_temp_get(LC15BTS_TEMP_FPGA, &temp); - vty_out(vty, " FPGA : %4.2f Celcius%s", + vty_out(vty, " FPGA : %4.2f Celsius%s", temp / 1000.0f, VTY_NEWLINE); lc15bts_temp_get(LC15BTS_TEMP_RMSDET, &temp); - vty_out(vty, " RMSDet : %4.2f Celcius%s", + vty_out(vty, " RMSDet : %4.2f Celsius%s", temp / 1000.0f, VTY_NEWLINE); lc15bts_temp_get(LC15BTS_TEMP_OCXO, &temp); - vty_out(vty, " OCXO : %4.2f Celcius%s", + vty_out(vty, " OCXO : %4.2f Celsius%s", temp / 1000.0f, VTY_NEWLINE); lc15bts_temp_get(LC15BTS_TEMP_TX0, &temp); - vty_out(vty, " TX 0 : %4.2f Celcius%s", + vty_out(vty, " TX 0 : %4.2f Celsius%s", temp / 1000.0f, VTY_NEWLINE); lc15bts_temp_get(LC15BTS_TEMP_TX1, &temp); - vty_out(vty, " TX 1 : %4.2f Celcius%s", + vty_out(vty, " TX 1 : %4.2f Celsius%s", temp / 1000.0f, VTY_NEWLINE); lc15bts_temp_get(LC15BTS_TEMP_PA0, &temp); - vty_out(vty, " Power Amp #0: %4.2f Celcius%s", + vty_out(vty, " Power Amp #0: %4.2f Celsius%s", temp / 1000.0f, VTY_NEWLINE); lc15bts_temp_get(LC15BTS_TEMP_PA1, &temp); - vty_out(vty, " Power Amp #1: %4.2f Celcius%s", + vty_out(vty, " Power Amp #1: %4.2f Celsius%s", temp / 1000.0f, VTY_NEWLINE); diff --git a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c index 3ddf0e8..5775065 100644 --- a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c +++ b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c @@ -518,7 +518,7 @@ */ int timeout = 60; //int timeout = 2 * 60 * 60; - //if (outcome != CALIB_SUCESS) } + //if (outcome != CALIB_SUCCESS) } // timeout = 5 * 60; //} diff --git a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c index 7e80e03..9693eab 100644 --- a/src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c +++ b/src/osmo-bts-oc2g/misc/oc2gbts_mgr_vty.c @@ -512,35 +512,35 @@ oc2gbts_mgr_sensor_get_state(s_mgr->state.state), VTY_NEWLINE); vty_out(vty, "Current Temperatures%s", VTY_NEWLINE); oc2gbts_temp_get(OC2GBTS_TEMP_SUPPLY, &temp); - vty_out(vty, " Main Supply : %4.2f Celcius%s", + vty_out(vty, " Main Supply : %4.2f Celsius%s", temp/ 1000.0f, VTY_NEWLINE); oc2gbts_temp_get(OC2GBTS_TEMP_SOC, &temp); - vty_out(vty, " SoC : %4.2f Celcius%s", + vty_out(vty, " SoC : %4.2f Celsius%s", temp / 1000.0f, VTY_NEWLINE); oc2gbts_temp_get(OC2GBTS_TEMP_FPGA, &temp); - vty_out(vty, " FPGA : %4.2f Celcius%s", + vty_out(vty, " FPGA : %4.2f Celsius%s", temp / 1000.0f, VTY_NEWLINE); if (oc2gbts_option_get(OC2GBTS_OPTION_RMS_FWD) || oc2gbts_option_get(OC2GBTS_OPTION_RMS_REFL)) { oc2gbts_temp_get(OC2GBTS_TEMP_RMSDET, &temp); - vty_out(vty, " RMSDet : %4.2f Celcius%s", + vty_out(vty, " RMSDet : %4.2f Celsius%s", temp / 1000.0f, VTY_NEWLINE); } oc2gbts_temp_get(OC2GBTS_TEMP_OCXO, &temp); - vty_out(vty, " OCXO : %4.2f Celcius%s", + vty_out(vty, " OCXO : %4.2f Celsius%s", temp / 1000.0f, VTY_NEWLINE); oc2gbts_temp_get(OC2GBTS_TEMP_TX, &temp); - vty_out(vty, " TX : %4.2f Celcius%s", + vty_out(vty, " TX : %4.2f Celsius%s", temp / 1000.0f, VTY_NEWLINE); if (oc2gbts_option_get(OC2GBTS_OPTION_PA_TEMP)) { oc2gbts_temp_get(OC2GBTS_TEMP_PA, &temp); - vty_out(vty, " Power Amp : %4.2f Celcius%s", + vty_out(vty, " Power Amp : %4.2f Celsius%s", temp / 1000.0f, VTY_NEWLINE); } diff --git a/src/osmo-bts-octphy/l1_oml.c b/src/osmo-bts-octphy/l1_oml.c index d44f721..d306c11 100644 --- a/src/osmo-bts-octphy/l1_oml.c +++ b/src/osmo-bts-octphy/l1_oml.c @@ -506,7 +506,7 @@ * sub-channel, only th request contains this information :( */ lchan = &ts->lchan[(unsigned long) data]; - /* TODO: This state machine should be shared accross BTS models? */ + /* TODO: This state machine should be shared across BTS models? */ switch (lchan->ciph_state) { case LCHAN_CIPH_RX_REQ: lchan->ciph_state = LCHAN_CIPH_RX_CONF; diff --git a/src/osmo-bts-sysmo/misc/sysmobts-layer1.c b/src/osmo-bts-sysmo/misc/sysmobts-layer1.c index 4b34f50..20ca6f5 100644 --- a/src/osmo-bts-sysmo/misc/sysmobts-layer1.c +++ b/src/osmo-bts-sysmo/misc/sysmobts-layer1.c @@ -622,7 +622,7 @@ return -1; } if (prim.u.rfClockSetupCnf.status != GsmL1_Status_Success) { - printf("Clock setup was not successfull.\n"); + printf("Clock setup was not successful.\n"); return -2; } diff --git a/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c b/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c index a0ba649..d769ce7 100644 --- a/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c +++ b/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c @@ -54,7 +54,7 @@ CALIB_FAIL_START, CALIB_FAIL_GPS, CALIB_FAIL_CTRL, - CALIB_SUCESS, + CALIB_SUCCESS, }; static inline int compat_gps_read(struct gps_data_t *data) @@ -271,7 +271,7 @@ * and in case of a failure in some minutes. */ int timeout = 2 * 60 * 60; - if (outcome != CALIB_SUCESS) + if (outcome != CALIB_SUCCESS) timeout = 5 * 60; mgr->calib.calib_timeout.data = mgr; @@ -390,7 +390,7 @@ LOGP(DCALIB, LOGL_NOTICE, "Calibration process completed\n"); - calib_state_reset(mgr, CALIB_SUCESS); + calib_state_reset(mgr, CALIB_SUCCESS); } static void handle_ctrl(struct sysmobts_mgr_instance *mgr, struct msgb *msg) diff --git a/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c b/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c index 444ee7c..fb3987b 100644 --- a/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c +++ b/src/osmo-bts-sysmo/misc/sysmobts_mgr_vty.c @@ -380,11 +380,11 @@ vty_out(vty, "Temperature control state: %s%s", sysmobts_mgr_temp_get_state(s_mgr->state), VTY_NEWLINE); vty_out(vty, "Current Temperatures%s", VTY_NEWLINE); - vty_out(vty, " Digital: %f Celcius%s", + vty_out(vty, " Digital: %f Celsius%s", sysmobts_temp_get(SYSMOBTS_TEMP_DIGITAL, SYSMOBTS_TEMP_INPUT) / 1000.0f, VTY_NEWLINE); - vty_out(vty, " RF: %f Celcius%s", + vty_out(vty, " RF: %f Celsius%s", sysmobts_temp_get(SYSMOBTS_TEMP_RF, SYSMOBTS_TEMP_INPUT) / 1000.0f, VTY_NEWLINE); @@ -396,8 +396,8 @@ is_sbts2050_master() ? "master" : "slave", VTY_NEWLINE); sbts2050_uc_check_temp(&temp_pa, &temp_board); - vty_out(vty, " sysmoBTS 2050 PA: %d Celcius%s", temp_pa, VTY_NEWLINE); - vty_out(vty, " sysmoBTS 2050 PA: %d Celcius%s", temp_board, VTY_NEWLINE); + vty_out(vty, " sysmoBTS 2050 PA: %d Celsius%s", temp_pa, VTY_NEWLINE); + vty_out(vty, " sysmoBTS 2050 PA: %d Celsius%s", temp_board, VTY_NEWLINE); sbts2050_uc_get_status(&status); vty_out(vty, "Power Status%s", VTY_NEWLINE); diff --git a/tests/meas/meas_test.c b/tests/meas/meas_test.c index b2bf80e..c8f06b6 100644 --- a/tests/meas/meas_test.c +++ b/tests/meas/meas_test.c @@ -306,7 +306,7 @@ * received. The process must still go on when measurement indications (blocks) * are lost or otherwise spaced out. Even the complete absence of the * measurement indications from the SACCH which are used to detect the interval - * end must not keep the interval from beeing processed. */ + * end must not keep the interval from being processed. */ void test_lchan_meas_process_measurement(bool no_sacch, bool dropouts) { struct gsm_lchan *lchan = &trx->ts[2].lchan[0]; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00ebf013104b55decbdd7f758756a19b220dc7b3 Gerrit-Change-Number: 14821 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 20:45:32 2019 From: gerrit-no-reply at lists.osmocom.org (roox) Date: Wed, 17 Jul 2019 20:45:32 +0000 Subject: Change in ...gapk[master]: Fix typos Message-ID: roox has uploaded this change for review. ( https://gerrit.osmocom.org/c/gapk/+/14822 Change subject: Fix typos ...................................................................... Fix typos Change-Id: Ie8054f3d484fe5d82cc5d91f159906a470fc4511 --- M src/pq_alsa.c M src/pq_file.c M src/pq_rtp.c 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/22/14822/1 diff --git a/src/pq_alsa.c b/src/pq_alsa.c index 3550221..50479e6 100644 --- a/src/pq_alsa.c +++ b/src/pq_alsa.c @@ -176,7 +176,7 @@ * \param pq Processing Queue to add the ALSA input to * \param[in] hwdev ALSA hardware device to use * \param[in] blk_len block length to be read from device - * \returns 0 on sucess; negative on error */ + * \returns 0 on success; negative on error */ int osmo_gapk_pq_queue_alsa_input(struct osmo_gapk_pq *pq, const char *hwdev, unsigned int blk_len) { @@ -190,7 +190,7 @@ * \param pq Processing Queue to add the ALSA output to * \param[in] hwdev ALSA hardware device to use * \param[in] blk_len block length to be written to device - * \returns 0 on sucess; negative on error */ + * \returns 0 on success; negative on error */ int osmo_gapk_pq_queue_alsa_output(struct osmo_gapk_pq *pq, const char *hwdev, unsigned int blk_len) { diff --git a/src/pq_file.c b/src/pq_file.c index 22dc9cd..d496eec 100644 --- a/src/pq_file.c +++ b/src/pq_file.c @@ -103,7 +103,7 @@ * \param pq Processing Queue to add the input file to * \param[in] src caller-fopen()ed input file * \param[in] blk_len block length to be read from file - * \returns 0 on sucess; negative on error */ + * \returns 0 on success; negative on error */ int osmo_gapk_pq_queue_file_input(struct osmo_gapk_pq *pq, FILE *src, unsigned int blk_len) { @@ -117,7 +117,7 @@ * \param pq Processing Queue to add the output file to * \param[in] dst caller-fopen()ed output file * \param[in] blk_len block length to be written to file - * \returns 0 on sucess; negative on error */ + * \returns 0 on success; negative on error */ int osmo_gapk_pq_queue_file_output(struct osmo_gapk_pq *pq, FILE *dst, unsigned int blk_len) { diff --git a/src/pq_rtp.c b/src/pq_rtp.c index 81eeb19..3a09ba7 100644 --- a/src/pq_rtp.c +++ b/src/pq_rtp.c @@ -116,7 +116,7 @@ payload = buf + sizeof(struct rtp_hdr) + (rtph->csrc_count << 2); payload_len = rv - sizeof(struct rtp_hdr) - (rtph->csrc_count << 2); if (payload_len < 0) { - rtp_err("non-existant RTP payload length %d\n", payload_len); + rtp_err("non-existent RTP payload length %d\n", payload_len); return -1; } -- To view, visit https://gerrit.osmocom.org/c/gapk/+/14822 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: Ie8054f3d484fe5d82cc5d91f159906a470fc4511 Gerrit-Change-Number: 14822 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 20:51:09 2019 From: gerrit-no-reply at lists.osmocom.org (roox) Date: Wed, 17 Jul 2019 20:51:09 +0000 Subject: Change in ...osmo-tetra[master]: Fix typos Message-ID: roox has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-tetra/+/14823 Change subject: Fix typos ...................................................................... Fix typos Change-Id: I1aae0a52fcf978900fa847a3f813beb2a5ad4a84 --- M etsi_codec-patches/README M src/demod/cqpsk.py 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-tetra refs/changes/23/14823/1 diff --git a/etsi_codec-patches/README b/etsi_codec-patches/README index 1c95c83..9b59b74 100644 --- a/etsi_codec-patches/README +++ b/etsi_codec-patches/README @@ -33,5 +33,5 @@ Due to the use of uppercase file names in the zip file, you should use the "-L" flag to the unzip program, which ensures all files are completely lower-case. -Please apply all of the patches foudn in this directory to the +Please apply all of the patches found in this directory to the resulting source code. diff --git a/src/demod/cqpsk.py b/src/demod/cqpsk.py index 6be6ee7..c5a8f3d 100644 --- a/src/demod/cqpsk.py +++ b/src/demod/cqpsk.py @@ -151,7 +151,7 @@ Adds QPSK modulation-specific options to the standard parser """ parser.add_option("", "--excess-bw", type="float", default=_def_excess_bw, - help="set RRC excess bandwith factor [default=%default] (PSK)") + help="set RRC excess bandwidth factor [default=%default] (PSK)") parser.add_option("", "--no-gray-code", dest="gray_code", action="store_false", default=_def_gray_code, help="disable gray coding on modulated bits (PSK)") @@ -325,7 +325,7 @@ Adds modulation-specific options to the standard parser """ parser.add_option("", "--excess-bw", type="float", default=_def_excess_bw, - help="set RRC excess bandwith factor [default=%default] (PSK)") + help="set RRC excess bandwidth factor [default=%default] (PSK)") parser.add_option("", "--no-gray-code", dest="gray_code", action="store_false", default=_def_gray_code, help="disable gray coding on modulated bits (PSK)") -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/14823 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I1aae0a52fcf978900fa847a3f813beb2a5ad4a84 Gerrit-Change-Number: 14823 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 21:23:19 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Jul 2019 21:23:19 +0000 Subject: Change in ...libosmocore[master]: osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in comment Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14824 Change subject: osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in comment ...................................................................... osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in comment Change-Id: I57a330e16cc2910597672e1b27cf971499cea5bc --- M src/gsm/gsm48_rest_octets.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/24/14824/1 diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c index 84136c6..518572e 100644 --- a/src/gsm/gsm48_rest_octets.c +++ b/src/gsm/gsm48_rest_octets.c @@ -966,7 +966,7 @@ memset(si3, 0, sizeof(*si3)); - /* Optional Selection Paraosmo_gsm48_si_ro_infometers */ + /* Optional Selection Parameters */ if (bitvec_get_bit_high(&bv) == H) { sp->present = 1; sp->cbq = bitvec_get_uint(&bv, 1); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14824 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I57a330e16cc2910597672e1b27cf971499cea5bc Gerrit-Change-Number: 14824 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 21:23:19 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 17 Jul 2019 21:23:19 +0000 Subject: Change in ...libosmocore[master]: bitvec/bitval2mask(): cosmetic: get rid of temporary int variable Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14825 Change subject: bitvec/bitval2mask(): cosmetic: get rid of temporary int variable ...................................................................... bitvec/bitval2mask(): cosmetic: get rid of temporary int variable Change-Id: I9d6f6b66c99c43107d1ad3e80af332e967bb19e8 --- M src/bitvec.c 1 file changed, 4 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/14825/1 diff --git a/src/bitvec.c b/src/bitvec.c index dac0401..0c263ad 100644 --- a/src/bitvec.c +++ b/src/bitvec.c @@ -58,25 +58,18 @@ /* convert ZERO/ONE/L/H to a bitmask at given pos in a byte */ static uint8_t bitval2mask(enum bit_value bit, uint8_t bitnum) { - int bitval; - switch (bit) { case ZERO: - bitval = (0 << bitnum); - break; + return (0 << bitnum); case ONE: - bitval = (1 << bitnum); - break; + return (1 << bitnum); case L: - bitval = ((0x2b ^ (0 << bitnum)) & (1 << bitnum)); - break; + return ((0x2b ^ (0 << bitnum)) & (1 << bitnum)); case H: - bitval = ((0x2b ^ (1 << bitnum)) & (1 << bitnum)); - break; + return ((0x2b ^ (1 << bitnum)) & (1 << bitnum)); default: return 0; } - return bitval; } /*! check if the bit is 0 or 1 for a given position inside a bitvec -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14825 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d6f6b66c99c43107d1ad3e80af332e967bb19e8 Gerrit-Change-Number: 14825 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 21:43:41 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Jul 2019 21:43:41 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: kill already running In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14780 ) Change subject: debian-repo-install-test: kill already running ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f Gerrit-Change-Number: 14780 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 21:43:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 21:44:51 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Jul 2019 21:44:51 +0000 Subject: Change in ...osmo-iuh[master]: osmo-hnbgw.cfg: set local-ip to 0.0.0.0 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14782 ) Change subject: osmo-hnbgw.cfg: set local-ip to 0.0.0.0 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec Gerrit-Change-Number: 14782 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 21:44:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 22:03:22 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Jul 2019 22:03:22 +0000 Subject: Change in ...osmo-bts[master]: common/rsl.c: fix: properly handle SI3 Rest Octets In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14817 ) Change subject: common/rsl.c: fix: properly handle SI3 Rest Octets ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 Gerrit-Change-Number: 14817 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: tnt Gerrit-Comment-Date: Wed, 17 Jul 2019 22:03:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 22:12:17 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Jul 2019 22:12:17 +0000 Subject: Change in ...osmocom-bb[master]: Fix common misspellings and typos In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14818 ) Change subject: Fix common misspellings and typos ...................................................................... Patch Set 1: (1 comment) I'd remove the variable name from this change, looks not the same kind of fix. https://gerrit.osmocom.org/#/c/14818/1/src/target/firmware/apps/simtest/main.c File src/target/firmware/apps/simtest/main.c: https://gerrit.osmocom.org/#/c/14818/1/src/target/firmware/apps/simtest/main.c at 217 PS1, Line 217: int receivedChars; this one looks suspicious. Variable name changed but no issue? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14818 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I75df25d3bc2ecb4985bf6fefdde6e44b21bffed9 Gerrit-Change-Number: 14818 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 22:12:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 22:14:15 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Jul 2019 22:14:15 +0000 Subject: Change in ...osmo-trx[master]: Fix common misspellings and typos In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14819 ) Change subject: Fix common misspellings and typos ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14819/1/debian/changelog File debian/changelog: https://gerrit.osmocom.org/#/c/14819/1/debian/changelog at 229 PS1, Line 229: * Move arch specific files to arch subdir I wouldn't change stuff from changelog, since that stuff comes from commit messages. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14819 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8e0fe9d67d1e1e8dfce319610de63cde170694c5 Gerrit-Change-Number: 14819 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 22:14:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 22:20:24 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Jul 2019 22:20:24 +0000 Subject: Change in ...osmo-bts[master]: Fix common misspellings and typos In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14821 ) Change subject: Fix common misspellings and typos ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14821/1/debian/changelog File debian/changelog: https://gerrit.osmocom.org/#/c/14821/1/debian/changelog at 136 PS1, Line 136: * rtp-amr: Describe requirement to receive all PH-DATA.ind events Same, not sure we want to fix stuff in changelog comming frm commit logs. https://gerrit.osmocom.org/#/c/14821/1/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c File src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c: https://gerrit.osmocom.org/#/c/14821/1/src/osmo-bts-sysmo/misc/sysmobts_mgr_calib.c at 57 PS1, Line 57: CALIB_SUCCESS, Probably this change and related modifications deserve a separate patch (not a simple comment typo). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00ebf013104b55decbdd7f758756a19b220dc7b3 Gerrit-Change-Number: 14821 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 22:20:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 22:21:02 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Jul 2019 22:21:02 +0000 Subject: Change in ...gapk[master]: Fix typos In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/14822 ) Change subject: Fix typos ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/14822 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: Ie8054f3d484fe5d82cc5d91f159906a470fc4511 Gerrit-Change-Number: 14822 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 22:21:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 22:21:35 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Jul 2019 22:21:35 +0000 Subject: Change in ...osmo-tetra[master]: Fix typos In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/14823 ) Change subject: Fix typos ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/14823 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I1aae0a52fcf978900fa847a3f813beb2a5ad4a84 Gerrit-Change-Number: 14823 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 22:21:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 22:22:03 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Jul 2019 22:22:03 +0000 Subject: Change in ...libosmocore[master]: osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in comment In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14824 ) Change subject: osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14824 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I57a330e16cc2910597672e1b27cf971499cea5bc Gerrit-Change-Number: 14824 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 22:22:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 17 22:22:33 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 17 Jul 2019 22:22:33 +0000 Subject: Change in ...libosmocore[master]: bitvec/bitval2mask(): cosmetic: get rid of temporary int variable In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14825 ) Change subject: bitvec/bitval2mask(): cosmetic: get rid of temporary int variable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14825 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d6f6b66c99c43107d1ad3e80af332e967bb19e8 Gerrit-Change-Number: 14825 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 17 Jul 2019 22:22:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Thu Jul 18 04:23:07 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 18 Jul 2019 04:23:07 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d2ff43a640d1_1ae2888600350147@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 112s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 112s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 112s] dh_installdocs [ 112s] dh_installchangelogs [ 113s] dh_python2 [ 113s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 113s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 113s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 113s] dh_python3 [ 113s] debian/rules override_dh_installinit [ 113s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 113s] # Install service file with different name than package name: [ 113s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 113s] dh_installinit --name=osmo-ctrl2cgi [ 113s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script nor default file not found [ 113s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 113s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 113s] make: *** [debian/rules:4: binary] Error 2 [ 113s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 113s] [ 113s] cloud109 failed "build osmo-python-tests_0.0.9.20190718.dsc" at Thu Jul 18 04:23:02 UTC 2019. [ 113s] [ 113s] ### VM INTERACTION START ### [ 116s] [ 99.422146] sysrq: SysRq : Power Off [ 116s] [ 99.426478] reboot: Power down [ 116s] ### VM INTERACTION END ### [ 116s] [ 116s] cloud109 failed "build osmo-python-tests_0.0.9.20190718.dsc" at Thu Jul 18 04:23:06 UTC 2019. [ 116s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Thu Jul 18 04:45:07 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 18 Jul 2019 04:45:07 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d2ff9651ebf0_1ae28886003511aa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 771s] | This file was extended by libosmocore config.status 1.1.0.80-8f67, which was [ 771s] | generated by GNU Autoconf 2.69. Invocation command line was [ 771s] | [ 771s] | CONFIG_FILES = [ 771s] | CONFIG_HEADERS = [ 771s] | CONFIG_LINKS = [ 771s] | CONFIG_COMMANDS = [ 771s] | $ ./config.status Doxyfile.core [ 771s] | [ 771s] | on obs-arm-5 [ 771s] | [ 771s] | config.status:1200: creating Doxyfile.core [ 771s] [ 771s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 771s] make[1]: *** [override_dh_auto_test] Error 1 [ 771s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 771s] debian/rules:15: recipe for target 'build' failed [ 771s] make: *** [build] Error 2 [ 771s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 771s] [ 771s] obs-arm-5 failed "build libosmocore_1.1.0.80.8f67.dsc" at Thu Jul 18 04:44:53 UTC 2019. [ 771s] [ 771s] ### VM INTERACTION START ### [ 773s] [ 739.650671] sysrq: SysRq : Power Off [ 773s] [ 739.652896] reboot: Power down [ 774s] ### VM INTERACTION END ### [ 774s] [ 774s] obs-arm-5 failed "build libosmocore_1.1.0.80.8f67.dsc" at Thu Jul 18 04:44:58 UTC 2019. [ 774s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Jul 18 08:07:38 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Jul 2019 08:07:38 +0000 Subject: Change in ...osmo-sgsn[master]: sgsn_mm_ctx_find_ggsn_ctx(): fix: always set gsm_cause Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14826 Change subject: sgsn_mm_ctx_find_ggsn_ctx(): fix: always set gsm_cause ...................................................................... sgsn_mm_ctx_find_ggsn_ctx(): fix: always set gsm_cause GCC 9 complains that variable 'gsm_cause' in do_act_pdp_req() may be uninitialized. This may happen if sgsn_mm_ctx_find_ggsn_ctx() would return NULL due to no static GGSN configured. Change-Id: I09c608045dd35b9898b82e236a306ab9a6c2c0b9 --- M src/gprs/gprs_sgsn.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/26/14826/1 diff --git a/src/gprs/gprs_sgsn.c b/src/gprs/gprs_sgsn.c index fae09ae..9a5de41 100644 --- a/src/gprs/gprs_sgsn.c +++ b/src/gprs/gprs_sgsn.c @@ -920,7 +920,8 @@ LOGMMCTXP(LOGL_NOTICE, mmctx, "No static GGSN configured. Selected APN '%s'\n", selected_apn_str); - return NULL; + *gsm_cause = GSM_CAUSE_MISSING_APN; + return NULL; } LOGMMCTXP(LOGL_INFO, mmctx, -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14826 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I09c608045dd35b9898b82e236a306ab9a6c2c0b9 Gerrit-Change-Number: 14826 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 08:08:03 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Jul 2019 08:08:03 +0000 Subject: Change in ...osmo-sgsn[master]: sgsn_mm_ctx_find_ggsn_ctx(): fix: always set gsm_cause In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14826 ) Change subject: sgsn_mm_ctx_find_ggsn_ctx(): fix: always set gsm_cause ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14826/1/src/gprs/gprs_sgsn.c File src/gprs/gprs_sgsn.c: https://gerrit.osmocom.org/#/c/14826/1/src/gprs/gprs_sgsn.c at 923 PS1, Line 923: GSM_CAUSE_MISSING_APN Not sure if this is the correct cause value. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14826 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I09c608045dd35b9898b82e236a306ab9a6c2c0b9 Gerrit-Change-Number: 14826 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: fixeria Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 18 Jul 2019 08:08:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 08:17:03 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Jul 2019 08:17:03 +0000 Subject: Change in ...osmo-bts[master]: common/rsl.c: fix: properly handle SI3 Rest Octets In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14817 ) Change subject: common/rsl.c: fix: properly handle SI3 Rest Octets ...................................................................... Patch Set 3: Code-Review+2 The fix is obvious. Let's merge it ASAP. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 Gerrit-Change-Number: 14817 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: tnt Gerrit-Comment-Date: Thu, 18 Jul 2019 08:17:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 08:17:36 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Jul 2019 08:17:36 +0000 Subject: Change in ...osmo-bts[master]: common/rsl.c: fix: properly handle SI3 Rest Octets In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14817 ) Change subject: common/rsl.c: fix: properly handle SI3 Rest Octets ...................................................................... common/rsl.c: fix: properly handle SI3 Rest Octets It was noticed with old Sony Ericsson phones (like W595 and K510i) that the service provided by Osmocom network becomes unreliable from time to time. The RSSI indicator on those phones shows that the signal is lost, so neither CS nor PS services are working. As it then turned out, System Information 3 broadcasted on the Um interface is different than the one received from the BSC. In particular, the content of SI3 Rest Octets IE is different. Among with the 'GPRS Indicator', which is actually expected to indicate whether the PCU is connected or not, SI3 Rest Octets on the Um interface contain both 'Optional Power Offset' and 'Scheduling if and where' IEs, which are not present in the original messages from the BSC. Moreover, as soon as the PCU is connected, 'GPRS Indicator' IE contains different 'GPRS RA Colour' value, and informs the MS that System Information 13 is sent on extended BCCH, which is not even supported by OsmoBTS! The culprit is in rsl_rx_bcch_info(), where we pass a pointer to osmo_gsm48_rest_octets_si3_decode(). Instead of passing a pointer to the beginning of SI3 buffer, we actually need to shift it to the beginning of the SI3 Rest Octets IE. This change makes my Sony Ericsson phones happy ;) Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 --- M src/common/rsl.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/common/rsl.c b/src/common/rsl.c index 0a6a4e5..d09dc4a 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -368,7 +368,9 @@ LCHAN_REL_ACT_REACT; } /* decode original SI3 Rest Octets as sent by BSC */ - osmo_gsm48_rest_octets_si3_decode(&bts->si3_ro_decoded, GSM_BTS_SI(bts, osmo_si)); + const uint8_t *si3_ro_buf = (uint8_t *) GSM_BTS_SI(bts, osmo_si); + si3_ro_buf += offsetof(struct gsm48_system_information_type_3, rest_octets); + osmo_gsm48_rest_octets_si3_decode(&bts->si3_ro_decoded, si3_ro_buf); /* patch out GPRS indicator from binary if PCU is not connected; will be enabled * after PCU connects */ regenerate_si3_restoctets(bts); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia962cf21903ba674057cf52746996dd3254bc1c6 Gerrit-Change-Number: 14817 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: tnt Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 08:26:16 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 18 Jul 2019 08:26:16 +0000 Subject: Change in ...osmo-iuh[master]: osmo-hnbgw.cfg: set local-ip to 0.0.0.0 In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14782 ) Change subject: osmo-hnbgw.cfg: set local-ip to 0.0.0.0 ...................................................................... osmo-hnbgw.cfg: set local-ip to 0.0.0.0 Make the config work out of the box for anyone. Related: OS#3369 Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec --- M doc/examples/osmo-hnbgw.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/doc/examples/osmo-hnbgw.cfg b/doc/examples/osmo-hnbgw.cfg index cba7f51..9286b2a 100644 --- a/doc/examples/osmo-hnbgw.cfg +++ b/doc/examples/osmo-hnbgw.cfg @@ -21,5 +21,5 @@ logging level lstats notice hnbgw iuh - local-ip 10.23.24.1 + local-ip 0.0.0.0 hnbap-allow-tmsi 1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I354140f014854f1755b649e40a65e5d88b99c0ec Gerrit-Change-Number: 14782 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:05:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:05:35 +0000 Subject: Change in ...osmocom-bb[master]: Fix common misspellings and typos In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14818 ) Change subject: Fix common misspellings and typos ...................................................................... Patch Set 1: agreeing with pau. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14818 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I75df25d3bc2ecb4985bf6fefdde6e44b21bffed9 Gerrit-Change-Number: 14818 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 09:05:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:05:45 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:05:45 +0000 Subject: Change in ...osmo-trx[master]: Fix common misspellings and typos In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14819 ) Change subject: Fix common misspellings and typos ...................................................................... Patch Set 1: Code-Review-1 agreeing with pau -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14819 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8e0fe9d67d1e1e8dfce319610de63cde170694c5 Gerrit-Change-Number: 14819 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 09:05:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:06:21 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:06:21 +0000 Subject: Change in ...osmo-remsim[master]: Fix common misspellings and typos In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14820 ) Change subject: Fix common misspellings and typos ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8152acaccd33a4b646d56cba0748aeefa0c16b35 Gerrit-Change-Number: 14820 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: tsaitgaist Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 09:06:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:06:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:06:22 +0000 Subject: Change in ...osmo-remsim[master]: Fix common misspellings and typos In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14820 ) Change subject: Fix common misspellings and typos ...................................................................... Fix common misspellings and typos Change-Id: I8152acaccd33a4b646d56cba0748aeefa0c16b35 --- M doc/manuals/chapters/remsim-bankd.adoc M include/osmocom/rspro/INTEGER.h M include/osmocom/rspro/constr_TYPE.h M include/osmocom/rspro/per_support.h M src/rspro/NativeInteger.c M src/rspro/OCTET_STRING.c M src/rspro/ber_tlv_tag.c M src/rspro/constr_CHOICE.c M src/rspro/constr_SEQUENCE.c M src/rspro/converter-sample.c M src/rspro/per_opentype.c M src/simtrace2/apdu_dispatch.c 12 files changed, 14 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/remsim-bankd.adoc b/doc/manuals/chapters/remsim-bankd.adoc index d35056b..a3a1921 100644 --- a/doc/manuals/chapters/remsim-bankd.adoc +++ b/doc/manuals/chapters/remsim-bankd.adoc @@ -127,4 +127,4 @@ ---- In this example, there's only a single PC/SC reader available, and it has a string of -"Alcor Micro AU9560 00 00" whcih needs to be copy-pasted into the CSV file. +"Alcor Micro AU9560 00 00" which needs to be copy-pasted into the CSV file. diff --git a/include/osmocom/rspro/INTEGER.h b/include/osmocom/rspro/INTEGER.h index e8b36c7..c8edf12 100644 --- a/include/osmocom/rspro/INTEGER.h +++ b/include/osmocom/rspro/INTEGER.h @@ -68,8 +68,8 @@ ASN_STRTOL_ERROR_RANGE = -3, /* Input outside of numeric range for long type */ ASN_STRTOL_ERROR_INVAL = -2, /* Invalid data encountered (e.g., "+-") */ ASN_STRTOL_EXPECT_MORE = -1, /* More data expected (e.g. "+") */ - ASN_STRTOL_OK = 0, /* Conversion succeded, number ends at (*end) */ - ASN_STRTOL_EXTRA_DATA = 1, /* Conversion succeded, but the string has extra stuff */ + ASN_STRTOL_OK = 0, /* Conversion succeeded, number ends at (*end) */ + ASN_STRTOL_EXTRA_DATA = 1, /* Conversion succeeded, but the string has extra stuff */ }; enum asn_strtol_result_e asn_strtol_lim(const char *str, const char **end, long *l); diff --git a/include/osmocom/rspro/constr_TYPE.h b/include/osmocom/rspro/constr_TYPE.h index 13c60f3..e244d20 100644 --- a/include/osmocom/rspro/constr_TYPE.h +++ b/include/osmocom/rspro/constr_TYPE.h @@ -158,8 +158,8 @@ typedef struct asn_TYPE_tag2member_s { ber_tlv_tag_t el_tag; /* Outmost tag of the member */ int el_no; /* Index of the associated member, base 0 */ - int toff_first; /* First occurence of the el_tag, relative */ - int toff_last; /* Last occurence of the el_tag, relatvie */ + int toff_first; /* First occurrence of the el_tag, relative */ + int toff_last; /* Last occurrence of the el_tag, relatvie */ } asn_TYPE_tag2member_t; /* diff --git a/include/osmocom/rspro/per_support.h b/include/osmocom/rspro/per_support.h index 181fe24..ed945ce 100644 --- a/include/osmocom/rspro/per_support.h +++ b/include/osmocom/rspro/per_support.h @@ -53,7 +53,7 @@ */ int32_t per_get_few_bits(asn_per_data_t *per_data, int get_nbits); -/* Undo the immediately preceeding "get_few_bits" operation */ +/* Undo the immediately preceding "get_few_bits" operation */ void per_get_undo(asn_per_data_t *per_data, int get_nbits); /* diff --git a/src/rspro/NativeInteger.c b/src/rspro/NativeInteger.c index ef17bee..17a58ea 100644 --- a/src/rspro/NativeInteger.c +++ b/src/rspro/NativeInteger.c @@ -94,7 +94,7 @@ /* * ASN.1 encoded INTEGER: buf_ptr, length * Fill the native, at the same time checking for overflow. - * If overflow occured, return with RC_FAIL. + * If overflow occurred, return with RC_FAIL. */ { INTEGER_t tmp; diff --git a/src/rspro/OCTET_STRING.c b/src/rspro/OCTET_STRING.c index 3e424e7..6df9a0a 100644 --- a/src/rspro/OCTET_STRING.c +++ b/src/rspro/OCTET_STRING.c @@ -109,7 +109,7 @@ /* * The main reason why ASN.1 is still alive is that too much time and effort * is necessary for learning it more or less adequately, thus creating a gut - * necessity to demonstrate that aquired skill everywhere afterwards. + * necessity to demonstrate that acquired skill everywhere afterwards. * No, I am not going to explain what the following stuff is. */ struct _stack_el { diff --git a/src/rspro/ber_tlv_tag.c b/src/rspro/ber_tlv_tag.c index 4270876..adf3a25 100644 --- a/src/rspro/ber_tlv_tag.c +++ b/src/rspro/ber_tlv_tag.c @@ -42,7 +42,7 @@ */ if(val >> ((8 * sizeof(val)) - 9)) { /* - * We would not be able to accomodate + * We would not be able to accommodate * any more tag bits. */ return -1; diff --git a/src/rspro/constr_CHOICE.c b/src/rspro/constr_CHOICE.c index 18c24cd..6a88b29 100644 --- a/src/rspro/constr_CHOICE.c +++ b/src/rspro/constr_CHOICE.c @@ -156,7 +156,7 @@ } if(ctx->left >= 0) { - /* ?Substracted below! */ + /* ?Subtracted below! */ ctx->left += rval.consumed; } ADVANCE(rval.consumed); diff --git a/src/rspro/constr_SEQUENCE.c b/src/rspro/constr_SEQUENCE.c index 21e5190..0ffa282 100644 --- a/src/rspro/constr_SEQUENCE.c +++ b/src/rspro/constr_SEQUENCE.c @@ -166,7 +166,7 @@ } if(ctx->left >= 0) - ctx->left += rval.consumed; /* ?Substracted below! */ + ctx->left += rval.consumed; /* ?Subtracted below! */ ADVANCE(rval.consumed); NEXT_PHASE(ctx); diff --git a/src/rspro/converter-sample.c b/src/rspro/converter-sample.c index 2f74a80..6047273 100644 --- a/src/rspro/converter-sample.c +++ b/src/rspro/converter-sample.c @@ -390,7 +390,7 @@ /* * Move the buffer content left N bits, possibly joining it with - * preceeding content. + * preceding content. */ static void buffer_shift_left(size_t offset, int bits) { diff --git a/src/rspro/per_opentype.c b/src/rspro/per_opentype.c index 8c42f8b..e697cbb 100644 --- a/src/rspro/per_opentype.c +++ b/src/rspro/per_opentype.c @@ -154,7 +154,7 @@ } else { FREEMEM(buf); /* rv.code could be RC_WMORE, nonsense in this context */ - rv.code = RC_FAIL; /* Noone would give us more */ + rv.code = RC_FAIL; /* No one would give us more */ } return rv; diff --git a/src/simtrace2/apdu_dispatch.c b/src/simtrace2/apdu_dispatch.c index 7c7ed01..b9dc3b7 100644 --- a/src/simtrace2/apdu_dispatch.c +++ b/src/simtrace2/apdu_dispatch.c @@ -59,7 +59,7 @@ } /*! \brief input function for APDU segmentation - * \param ac APDU context accross successive calls + * \param ac APDU context across successive calls * \param[in] apdu_buf APDU inpud data buffer * \param[in] apdu_len Length of apdu_buf * \param[in] new_apdu Is this the beginning of a new APDU? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14820 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8152acaccd33a4b646d56cba0748aeefa0c16b35 Gerrit-Change-Number: 14820 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: tsaitgaist Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:06:44 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:06:44 +0000 Subject: Change in ...osmo-bts[master]: Fix common misspellings and typos In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14821 ) Change subject: Fix common misspellings and typos ...................................................................... Patch Set 1: Code-Review-1 agreeing with Pau -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00ebf013104b55decbdd7f758756a19b220dc7b3 Gerrit-Change-Number: 14821 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 09:06:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:06:57 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:06:57 +0000 Subject: Change in ...gapk[master]: Fix typos In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/14822 ) Change subject: Fix typos ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/gapk/+/14822 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: Ie8054f3d484fe5d82cc5d91f159906a470fc4511 Gerrit-Change-Number: 14822 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 09:06:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:06:58 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:06:58 +0000 Subject: Change in ...gapk[master]: Fix typos In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/gapk/+/14822 ) Change subject: Fix typos ...................................................................... Fix typos Change-Id: Ie8054f3d484fe5d82cc5d91f159906a470fc4511 --- M src/pq_alsa.c M src/pq_file.c M src/pq_rtp.c 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/pq_alsa.c b/src/pq_alsa.c index 3550221..50479e6 100644 --- a/src/pq_alsa.c +++ b/src/pq_alsa.c @@ -176,7 +176,7 @@ * \param pq Processing Queue to add the ALSA input to * \param[in] hwdev ALSA hardware device to use * \param[in] blk_len block length to be read from device - * \returns 0 on sucess; negative on error */ + * \returns 0 on success; negative on error */ int osmo_gapk_pq_queue_alsa_input(struct osmo_gapk_pq *pq, const char *hwdev, unsigned int blk_len) { @@ -190,7 +190,7 @@ * \param pq Processing Queue to add the ALSA output to * \param[in] hwdev ALSA hardware device to use * \param[in] blk_len block length to be written to device - * \returns 0 on sucess; negative on error */ + * \returns 0 on success; negative on error */ int osmo_gapk_pq_queue_alsa_output(struct osmo_gapk_pq *pq, const char *hwdev, unsigned int blk_len) { diff --git a/src/pq_file.c b/src/pq_file.c index 22dc9cd..d496eec 100644 --- a/src/pq_file.c +++ b/src/pq_file.c @@ -103,7 +103,7 @@ * \param pq Processing Queue to add the input file to * \param[in] src caller-fopen()ed input file * \param[in] blk_len block length to be read from file - * \returns 0 on sucess; negative on error */ + * \returns 0 on success; negative on error */ int osmo_gapk_pq_queue_file_input(struct osmo_gapk_pq *pq, FILE *src, unsigned int blk_len) { @@ -117,7 +117,7 @@ * \param pq Processing Queue to add the output file to * \param[in] dst caller-fopen()ed output file * \param[in] blk_len block length to be written to file - * \returns 0 on sucess; negative on error */ + * \returns 0 on success; negative on error */ int osmo_gapk_pq_queue_file_output(struct osmo_gapk_pq *pq, FILE *dst, unsigned int blk_len) { diff --git a/src/pq_rtp.c b/src/pq_rtp.c index 81eeb19..3a09ba7 100644 --- a/src/pq_rtp.c +++ b/src/pq_rtp.c @@ -116,7 +116,7 @@ payload = buf + sizeof(struct rtp_hdr) + (rtph->csrc_count << 2); payload_len = rv - sizeof(struct rtp_hdr) - (rtph->csrc_count << 2); if (payload_len < 0) { - rtp_err("non-existant RTP payload length %d\n", payload_len); + rtp_err("non-existent RTP payload length %d\n", payload_len); return -1; } -- To view, visit https://gerrit.osmocom.org/c/gapk/+/14822 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: Ie8054f3d484fe5d82cc5d91f159906a470fc4511 Gerrit-Change-Number: 14822 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:07:08 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:07:08 +0000 Subject: Change in ...osmo-tetra[master]: Fix typos In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/14823 ) Change subject: Fix typos ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/14823 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I1aae0a52fcf978900fa847a3f813beb2a5ad4a84 Gerrit-Change-Number: 14823 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 09:07:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:07:09 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:07:09 +0000 Subject: Change in ...osmo-tetra[master]: Fix typos In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-tetra/+/14823 ) Change subject: Fix typos ...................................................................... Fix typos Change-Id: I1aae0a52fcf978900fa847a3f813beb2a5ad4a84 --- M etsi_codec-patches/README M src/demod/cqpsk.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/etsi_codec-patches/README b/etsi_codec-patches/README index 1c95c83..9b59b74 100644 --- a/etsi_codec-patches/README +++ b/etsi_codec-patches/README @@ -33,5 +33,5 @@ Due to the use of uppercase file names in the zip file, you should use the "-L" flag to the unzip program, which ensures all files are completely lower-case. -Please apply all of the patches foudn in this directory to the +Please apply all of the patches found in this directory to the resulting source code. diff --git a/src/demod/cqpsk.py b/src/demod/cqpsk.py index 6be6ee7..c5a8f3d 100644 --- a/src/demod/cqpsk.py +++ b/src/demod/cqpsk.py @@ -151,7 +151,7 @@ Adds QPSK modulation-specific options to the standard parser """ parser.add_option("", "--excess-bw", type="float", default=_def_excess_bw, - help="set RRC excess bandwith factor [default=%default] (PSK)") + help="set RRC excess bandwidth factor [default=%default] (PSK)") parser.add_option("", "--no-gray-code", dest="gray_code", action="store_false", default=_def_gray_code, help="disable gray coding on modulated bits (PSK)") @@ -325,7 +325,7 @@ Adds modulation-specific options to the standard parser """ parser.add_option("", "--excess-bw", type="float", default=_def_excess_bw, - help="set RRC excess bandwith factor [default=%default] (PSK)") + help="set RRC excess bandwidth factor [default=%default] (PSK)") parser.add_option("", "--no-gray-code", dest="gray_code", action="store_false", default=_def_gray_code, help="disable gray coding on modulated bits (PSK)") -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/14823 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I1aae0a52fcf978900fa847a3f813beb2a5ad4a84 Gerrit-Change-Number: 14823 Gerrit-PatchSet: 1 Gerrit-Owner: roox Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:07:28 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:07:28 +0000 Subject: Change in ...libosmocore[master]: osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in comment In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14824 ) Change subject: osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14824 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I57a330e16cc2910597672e1b27cf971499cea5bc Gerrit-Change-Number: 14824 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 09:07:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:07:30 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:07:30 +0000 Subject: Change in ...libosmocore[master]: osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in comment In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14824 ) Change subject: osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in comment ...................................................................... osmo_gsm48_rest_octets_si3_decode(): fix copy-paste error in comment Change-Id: I57a330e16cc2910597672e1b27cf971499cea5bc --- M src/gsm/gsm48_rest_octets.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gsm/gsm48_rest_octets.c b/src/gsm/gsm48_rest_octets.c index 84136c6..518572e 100644 --- a/src/gsm/gsm48_rest_octets.c +++ b/src/gsm/gsm48_rest_octets.c @@ -966,7 +966,7 @@ memset(si3, 0, sizeof(*si3)); - /* Optional Selection Paraosmo_gsm48_si_ro_infometers */ + /* Optional Selection Parameters */ if (bitvec_get_bit_high(&bv) == H) { sp->present = 1; sp->cbq = bitvec_get_uint(&bv, 1); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14824 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I57a330e16cc2910597672e1b27cf971499cea5bc Gerrit-Change-Number: 14824 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:07:52 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:07:52 +0000 Subject: Change in ...libosmocore[master]: bitvec/bitval2mask(): cosmetic: get rid of temporary int variable In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14825 ) Change subject: bitvec/bitval2mask(): cosmetic: get rid of temporary int variable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14825 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d6f6b66c99c43107d1ad3e80af332e967bb19e8 Gerrit-Change-Number: 14825 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 09:07:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:07:53 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:07:53 +0000 Subject: Change in ...libosmocore[master]: bitvec/bitval2mask(): cosmetic: get rid of temporary int variable In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14825 ) Change subject: bitvec/bitval2mask(): cosmetic: get rid of temporary int variable ...................................................................... bitvec/bitval2mask(): cosmetic: get rid of temporary int variable Change-Id: I9d6f6b66c99c43107d1ad3e80af332e967bb19e8 --- M src/bitvec.c 1 file changed, 4 insertions(+), 11 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bitvec.c b/src/bitvec.c index dac0401..0c263ad 100644 --- a/src/bitvec.c +++ b/src/bitvec.c @@ -58,25 +58,18 @@ /* convert ZERO/ONE/L/H to a bitmask at given pos in a byte */ static uint8_t bitval2mask(enum bit_value bit, uint8_t bitnum) { - int bitval; - switch (bit) { case ZERO: - bitval = (0 << bitnum); - break; + return (0 << bitnum); case ONE: - bitval = (1 << bitnum); - break; + return (1 << bitnum); case L: - bitval = ((0x2b ^ (0 << bitnum)) & (1 << bitnum)); - break; + return ((0x2b ^ (0 << bitnum)) & (1 << bitnum)); case H: - bitval = ((0x2b ^ (1 << bitnum)) & (1 << bitnum)); - break; + return ((0x2b ^ (1 << bitnum)) & (1 << bitnum)); default: return 0; } - return bitval; } /*! check if the bit is 0 or 1 for a given position inside a bitvec -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14825 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d6f6b66c99c43107d1ad3e80af332e967bb19e8 Gerrit-Change-Number: 14825 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:08:18 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:08:18 +0000 Subject: Change in ...osmo-sgsn[master]: sgsn_mm_ctx_find_ggsn_ctx(): fix: always set gsm_cause In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14826 ) Change subject: sgsn_mm_ctx_find_ggsn_ctx(): fix: always set gsm_cause ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14826 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I09c608045dd35b9898b82e236a306ab9a6c2c0b9 Gerrit-Change-Number: 14826 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 18 Jul 2019 09:08:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 09:08:19 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 09:08:19 +0000 Subject: Change in ...osmo-sgsn[master]: sgsn_mm_ctx_find_ggsn_ctx(): fix: always set gsm_cause In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14826 ) Change subject: sgsn_mm_ctx_find_ggsn_ctx(): fix: always set gsm_cause ...................................................................... sgsn_mm_ctx_find_ggsn_ctx(): fix: always set gsm_cause GCC 9 complains that variable 'gsm_cause' in do_act_pdp_req() may be uninitialized. This may happen if sgsn_mm_ctx_find_ggsn_ctx() would return NULL due to no static GGSN configured. Change-Id: I09c608045dd35b9898b82e236a306ab9a6c2c0b9 --- M src/gprs/gprs_sgsn.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gprs/gprs_sgsn.c b/src/gprs/gprs_sgsn.c index fae09ae..9a5de41 100644 --- a/src/gprs/gprs_sgsn.c +++ b/src/gprs/gprs_sgsn.c @@ -920,7 +920,8 @@ LOGMMCTXP(LOGL_NOTICE, mmctx, "No static GGSN configured. Selected APN '%s'\n", selected_apn_str); - return NULL; + *gsm_cause = GSM_CAUSE_MISSING_APN; + return NULL; } LOGMMCTXP(LOGL_INFO, mmctx, -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14826 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I09c608045dd35b9898b82e236a306ab9a6c2c0b9 Gerrit-Change-Number: 14826 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 14:50:52 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 18 Jul 2019 14:50:52 +0000 Subject: Change in ...osmo-msc[master]: replace osmo_counter with stat_items In-Reply-To: References: Message-ID: lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/13802 ) Change subject: replace osmo_counter with stat_items ...................................................................... replace osmo_counter with stat_items osmo_counter will be soon deprecated. Use the newer and more flexible osmo_stat_item instead. Depends on: Id2462c4866bd22bc2338c9c8f69b775f88ae7511 (libosmocore) Change-Id: I6a20123b263f4f808153794ee8a735092deb399e --- M include/osmocom/msc/gsm_data.h M src/libmsc/gsm_04_08_cc.c M src/libmsc/gsm_09_11.c M src/libmsc/msc_net_init.c M tests/msc_vlr/msc_vlr_test_authen_reuse.err M tests/msc_vlr/msc_vlr_test_call.err M tests/msc_vlr/msc_vlr_test_gsm_authen.err M tests/msc_vlr/msc_vlr_test_gsm_ciph.err M tests/msc_vlr/msc_vlr_test_hlr_reject.err M tests/msc_vlr/msc_vlr_test_hlr_timeout.err M tests/msc_vlr/msc_vlr_test_ms_timeout.err M tests/msc_vlr/msc_vlr_test_no_authen.err M tests/msc_vlr/msc_vlr_test_reject_concurrency.err M tests/msc_vlr/msc_vlr_test_rest.err M tests/msc_vlr/msc_vlr_test_ss.err M tests/msc_vlr/msc_vlr_test_umts_authen.err M tests/msc_vlr/msc_vlr_tests.c 17 files changed, 155 insertions(+), 127 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/msc/gsm_data.h b/include/osmocom/msc/gsm_data.h index 6050113..e926b3f 100644 --- a/include/osmocom/msc/gsm_data.h +++ b/include/osmocom/msc/gsm_data.h @@ -10,6 +10,7 @@ #include #include #include +#include #include #include @@ -96,6 +97,11 @@ [MSC_CTR_BSSMAP_CIPHER_MODE_COMPLETE] = {"bssmap:cipher_mode_complete", "Number of CIPHER MODE COMPLETE messages processed by BSSMAP layer"}, }; +enum { + MSC_STAT_ACTIVE_CALLS, + MSC_STAT_ACTIVE_NC_SS, +}; + static const struct rate_ctr_group_desc msc_ctrg_desc = { "msc", "mobile switching center", @@ -104,6 +110,19 @@ msc_ctr_description, }; +static const struct osmo_stat_item_desc msc_stat_item_description[] = { + [MSC_STAT_ACTIVE_CALLS] = { "msc.active_calls", "Currently active calls " , OSMO_STAT_ITEM_NO_UNIT, 4, 0}, + [MSC_STAT_ACTIVE_NC_SS] = { "msc.active_nc_ss", "Currently active SS/USSD sessions", OSMO_STAT_ITEM_NO_UNIT, 4, 0}, +}; + +static const struct osmo_stat_item_group_desc msc_statg_desc = { + "net", + "network statistics", + OSMO_STATS_CLASS_GLOBAL, + ARRAY_SIZE(msc_stat_item_description), + msc_stat_item_description, +}; + #define MSC_PAGING_RESPONSE_TIMER_DEFAULT 10 struct gsm_tz { @@ -131,8 +150,7 @@ int send_mm_info; struct rate_ctr_group *msc_ctrs; - struct osmo_counter *active_calls; - struct osmo_counter *active_nc_ss; + struct osmo_stat_item_group *statg; /* layer 4 */ char *mncc_sock_path; diff --git a/src/libmsc/gsm_04_08_cc.c b/src/libmsc/gsm_04_08_cc.c index 2869bba..03830de 100644 --- a/src/libmsc/gsm_04_08_cc.c +++ b/src/libmsc/gsm_04_08_cc.c @@ -161,7 +161,7 @@ /* state incoming */ switch (new_state) { case GSM_CSTATE_ACTIVE: - osmo_counter_inc(trans->net->active_calls); + osmo_stat_item_inc(trans->net->statg->items[MSC_STAT_ACTIVE_CALLS], 1); rate_ctr_inc(&msc->ctr[MSC_CTR_CALL_ACTIVE]); break; } @@ -169,7 +169,7 @@ /* state outgoing */ switch (old_state) { case GSM_CSTATE_ACTIVE: - osmo_counter_dec(trans->net->active_calls); + osmo_stat_item_dec(trans->net->statg->items[MSC_STAT_ACTIVE_CALLS], 1); if (new_state == GSM_CSTATE_DISCONNECT_REQ || new_state == GSM_CSTATE_DISCONNECT_IND) rate_ctr_inc(&msc->ctr[MSC_CTR_CALL_COMPLETE]); diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c index 79fcb5a..8a13cda 100644 --- a/src/libmsc/gsm_09_11.c +++ b/src/libmsc/gsm_09_11.c @@ -32,6 +32,7 @@ #include #include +#include #include #include @@ -158,7 +159,7 @@ ncss_session_timeout_handler, trans); /* Count active NC SS/USSD sessions */ - osmo_counter_inc(net->active_nc_ss); + osmo_stat_item_inc(net->statg->items[MSC_STAT_ACTIVE_NC_SS], 1); trans->dlci = OMSC_LINKID_CB(msg); trans->msc_a = msc_a; @@ -362,7 +363,7 @@ } /* Count active NC SS/USSD sessions */ - osmo_counter_inc(net->active_nc_ss); + osmo_stat_item_inc(net->statg->items[MSC_STAT_ACTIVE_NC_SS], 1); /* Init inactivity timer */ osmo_timer_setup(&trans->ss.timer_guard, @@ -414,7 +415,7 @@ osmo_timer_del(&trans->ss.timer_guard); /* One session less */ - osmo_counter_dec(trans->net->active_nc_ss); + osmo_stat_item_dec(trans->net->statg->items[MSC_STAT_ACTIVE_NC_SS], 1); } int gsm0911_gsup_rx(struct gsup_client_mux *gcm, void *data, const struct osmo_gsup_message *gsup_msg) diff --git a/src/libmsc/msc_net_init.c b/src/libmsc/msc_net_init.c index 4a752bf..11920f3 100644 --- a/src/libmsc/msc_net_init.c +++ b/src/libmsc/msc_net_init.c @@ -35,6 +35,8 @@ {} }; +#include + struct gsm_network *gsm_network_init(void *ctx, mncc_recv_cb_t mncc_recv) { struct gsm_network *net; @@ -66,8 +68,13 @@ talloc_free(net); return NULL; } - net->active_calls = osmo_counter_alloc("msc.active_calls"); - net->active_nc_ss = osmo_counter_alloc("msc.active_nc_ss"); + + net->statg = osmo_stat_item_group_alloc(net, &msc_statg_desc, 0); + if (!net->statg) { + rate_ctr_group_free(net->msc_ctrs); + talloc_free(net); + return NULL; + } net->mncc_tdefs = mncc_tdefs; net->mncc_recv = mncc_recv; diff --git a/tests/msc_vlr/msc_vlr_test_authen_reuse.err b/tests/msc_vlr/msc_vlr_test_authen_reuse.err index ea156de..aa78cdb 100644 --- a/tests/msc_vlr/msc_vlr_test_authen_reuse.err +++ b/tests/msc_vlr/msc_vlr_test_authen_reuse.err @@ -1,6 +1,6 @@ DLMGCP MGCP client: using endpoint domain '@mgw' full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_auth_use_twice_geran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -502,7 +502,7 @@ ===== test_auth_use_twice_geran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_auth_use_twice_utran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -1034,7 +1034,7 @@ ===== test_auth_use_twice_utran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_auth_use_infinitely_geran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -1639,7 +1639,7 @@ ===== test_auth_use_infinitely_geran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_auth_use_infinitely_utran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -2283,7 +2283,7 @@ ===== test_auth_use_infinitely_utran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_no_auth_reuse_geran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -2670,7 +2670,7 @@ ===== test_no_auth_reuse_geran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_no_auth_reuse_utran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -3078,8 +3078,8 @@ ===== test_no_auth_reuse_utran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 diff --git a/tests/msc_vlr/msc_vlr_test_call.err b/tests/msc_vlr/msc_vlr_test_call.err index 0eaa2f3..d5fd893 100644 --- a/tests/msc_vlr/msc_vlr_test_call.err +++ b/tests/msc_vlr/msc_vlr_test_call.err @@ -1,6 +1,6 @@ DLMGCP MGCP client: using endpoint domain '@mgw' full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_call_mo - Total time passed: 0.000000 s @@ -426,7 +426,7 @@ ===== test_call_mo: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_call_mt - Total time passed: 0.000000 s @@ -850,7 +850,7 @@ ===== test_call_mt: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_call_mt2 - Total time passed: 0.000000 s @@ -1233,7 +1233,7 @@ ===== test_call_mt2: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_call_mo_to_unknown - Total time passed: 0.000000 s @@ -1618,7 +1618,7 @@ ===== test_call_mo_to_unknown: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_call_mo_to_unknown_timeout - Total time passed: 0.000000 s @@ -1999,8 +1999,8 @@ ===== test_call_mo_to_unknown_timeout: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 diff --git a/tests/msc_vlr/msc_vlr_test_gsm_authen.err b/tests/msc_vlr/msc_vlr_test_gsm_authen.err index 45b047d..0a18302 100644 --- a/tests/msc_vlr/msc_vlr_test_gsm_authen.err +++ b/tests/msc_vlr/msc_vlr_test_gsm_authen.err @@ -1,6 +1,6 @@ DLMGCP MGCP client: using endpoint domain '@mgw' full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_gsm_authen - Location Update request causes a GSUP Send Auth Info request to HLR @@ -581,7 +581,7 @@ ===== test_gsm_authen: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_gsm_authen_tmsi - Location Update request causes a GSUP Send Auth Info request to HLR @@ -1401,7 +1401,7 @@ ===== test_gsm_authen_tmsi: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_gsm_authen_imei - Location Update request causes a GSUP Send Auth Info request to HLR @@ -1712,7 +1712,7 @@ ===== test_gsm_authen_imei: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_gsm_authen_imei_nack - Location Update request causes a GSUP Send Auth Info request to HLR @@ -1978,7 +1978,7 @@ ===== test_gsm_authen_imei_nack: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_gsm_authen_imei_err - Location Update request causes a GSUP Send Auth Info request to HLR @@ -2245,7 +2245,7 @@ ===== test_gsm_authen_imei_err: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_gsm_authen_tmsi_imei - Location Update request causes a GSUP Send Auth Info request to HLR @@ -2597,7 +2597,7 @@ ===== test_gsm_authen_tmsi_imei: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_gsm_milenage_authen - Location Update request causes a GSUP Send Auth Info request to HLR @@ -3152,7 +3152,7 @@ ===== test_gsm_milenage_authen: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_wrong_sres_length - Total time passed: 0.000000 s @@ -3297,8 +3297,8 @@ ===== test_wrong_sres_length: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 diff --git a/tests/msc_vlr/msc_vlr_test_gsm_ciph.err b/tests/msc_vlr/msc_vlr_test_gsm_ciph.err index b527f05..893203e 100644 --- a/tests/msc_vlr/msc_vlr_test_gsm_ciph.err +++ b/tests/msc_vlr/msc_vlr_test_gsm_ciph.err @@ -1,6 +1,6 @@ DLMGCP MGCP client: using endpoint domain '@mgw' full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_ciph - Location Update request causes a GSUP Send Auth Info request to HLR @@ -650,7 +650,7 @@ ===== test_ciph: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_ciph_tmsi - Location Update request causes a GSUP Send Auth Info request to HLR @@ -1348,7 +1348,7 @@ ===== test_ciph_tmsi: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_ciph_imei - Location Update request causes a GSUP Send Auth Info request to HLR @@ -1666,7 +1666,7 @@ ===== test_ciph_imei: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_ciph_imeisv - Location Update request causes a GSUP Send Auth Info request to HLR @@ -1951,7 +1951,7 @@ ===== test_ciph_imeisv: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_ciph_tmsi_imei - Location Update request causes a GSUP Send Auth Info request to HLR @@ -2310,7 +2310,7 @@ ===== test_ciph_tmsi_imei: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_gsm_ciph_in_umts_env - Location Update request causes a GSUP Send Auth Info request to HLR @@ -2905,7 +2905,7 @@ ===== test_gsm_ciph_in_umts_env: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_a5_3_supported - Location Update request causes a GSUP Send Auth Info request to HLR @@ -3547,7 +3547,7 @@ ===== test_a5_3_supported: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_cm_service_needs_classmark_update - Location Update request causes a GSUP Send Auth Info request to HLR @@ -4167,8 +4167,8 @@ ===== test_cm_service_needs_classmark_update: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 diff --git a/tests/msc_vlr/msc_vlr_test_hlr_reject.err b/tests/msc_vlr/msc_vlr_test_hlr_reject.err index 2dd6a52..9d0737a 100644 --- a/tests/msc_vlr/msc_vlr_test_hlr_reject.err +++ b/tests/msc_vlr/msc_vlr_test_hlr_reject.err @@ -1,6 +1,6 @@ DLMGCP MGCP client: using endpoint domain '@mgw' full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_hlr_rej_auth_info_unknown_imsi - Location Update request causes a GSUP Send Auth Info request to HLR @@ -102,7 +102,7 @@ ===== test_hlr_rej_auth_info_unknown_imsi: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_hlr_rej_auth_info_net_fail - Location Update request causes a GSUP Send Auth Info request to HLR @@ -204,7 +204,7 @@ ===== test_hlr_rej_auth_info_net_fail: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_hlr_rej_auth_info_net_fail_reuse_tuples @@ -530,7 +530,7 @@ ===== test_hlr_rej_auth_info_net_fail_reuse_tuples: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_hlr_rej_auth_info_net_fail_no_reuse_tuples @@ -797,7 +797,7 @@ ===== test_hlr_rej_auth_info_net_fail_no_reuse_tuples: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_hlr_rej_auth_info_unkown_imsi_no_reuse_tuples @@ -1065,7 +1065,7 @@ ===== test_hlr_rej_auth_info_unkown_imsi_no_reuse_tuples: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_hlr_acc_but_no_auth_tuples - Location Update request causes a GSUP Send Auth Info request to HLR @@ -1166,7 +1166,7 @@ ===== test_hlr_acc_but_no_auth_tuples: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_hlr_rej_lu - Location Update request causes a GSUP LU request to HLR @@ -1270,7 +1270,7 @@ ===== test_hlr_rej_lu: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_hlr_no_insert_data - Location Update request causes a GSUP LU request to HLR @@ -1386,8 +1386,8 @@ ===== test_hlr_no_insert_data: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 diff --git a/tests/msc_vlr/msc_vlr_test_hlr_timeout.err b/tests/msc_vlr/msc_vlr_test_hlr_timeout.err index 60b240d..68368c0 100644 --- a/tests/msc_vlr/msc_vlr_test_hlr_timeout.err +++ b/tests/msc_vlr/msc_vlr_test_hlr_timeout.err @@ -1,6 +1,6 @@ DLMGCP MGCP client: using endpoint domain '@mgw' full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_hlr_timeout_lu_auth_info - Total time passed: 0.000000 s @@ -111,7 +111,7 @@ ===== test_hlr_timeout_lu_auth_info: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_hlr_timeout_lu_upd_loc_result - Total time passed: 0.000000 s @@ -239,8 +239,8 @@ ===== test_hlr_timeout_lu_upd_loc_result: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 diff --git a/tests/msc_vlr/msc_vlr_test_ms_timeout.err b/tests/msc_vlr/msc_vlr_test_ms_timeout.err index 07f2b5b..2018528 100644 --- a/tests/msc_vlr/msc_vlr_test_ms_timeout.err +++ b/tests/msc_vlr/msc_vlr_test_ms_timeout.err @@ -1,6 +1,6 @@ DLMGCP MGCP client: using endpoint domain '@mgw' full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_ms_timeout_lu_auth_resp - Total time passed: 0.000000 s @@ -130,7 +130,7 @@ ===== test_ms_timeout_lu_auth_resp: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_ms_timeout_cm_auth_resp - Total time passed: 0.000000 s @@ -403,7 +403,7 @@ ===== test_ms_timeout_cm_auth_resp: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_ms_timeout_paging - Total time passed: 0.000000 s @@ -711,7 +711,7 @@ ===== test_ms_timeout_paging: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_classmark_update_timeout - Total time passed: 0.000000 s @@ -864,8 +864,8 @@ ===== test_classmark_update_timeout: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 diff --git a/tests/msc_vlr/msc_vlr_test_no_authen.err b/tests/msc_vlr/msc_vlr_test_no_authen.err index b6c0698..d533976 100644 --- a/tests/msc_vlr/msc_vlr_test_no_authen.err +++ b/tests/msc_vlr/msc_vlr_test_no_authen.err @@ -1,6 +1,6 @@ DLMGCP MGCP client: using endpoint domain '@mgw' full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_no_authen - Location Update request causes a GSUP LU request to HLR @@ -448,7 +448,7 @@ ===== test_no_authen: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_no_authen_tmsi - Location Update request causes a GSUP LU request to HLR @@ -1128,7 +1128,7 @@ ===== test_no_authen_tmsi: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_no_authen_imei - Location Update request causes a GSUP LU request to HLR @@ -1378,7 +1378,7 @@ ===== test_no_authen_imei: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_no_authen_tmsi_imei - Location Update request causes a GSUP LU request to HLR @@ -1663,7 +1663,7 @@ ===== test_no_authen_tmsi_imei: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_no_authen_imeisv - Location Update request causes an IMEISV ID request back to the MS @@ -1883,7 +1883,7 @@ ===== test_no_authen_imeisv: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_no_authen_imeisv_imei - Location Update request causes an IMEISV ID request back to the MS @@ -2114,7 +2114,7 @@ ===== test_no_authen_imeisv_imei: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_no_authen_imeisv_tmsi - Location Update request causes an IMEISV ID request back to the MS @@ -2578,7 +2578,7 @@ ===== test_no_authen_imeisv_tmsi: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_no_authen_imeisv_tmsi_imei - Location Update request causes an IMEISV ID request back to the MS @@ -2846,7 +2846,7 @@ ===== test_no_authen_imeisv_tmsi_imei: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_no_authen_subscr_expire - Total time passed: 0.000000 s @@ -2981,8 +2981,8 @@ ===== test_no_authen_subscr_expire: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 diff --git a/tests/msc_vlr/msc_vlr_test_reject_concurrency.err b/tests/msc_vlr/msc_vlr_test_reject_concurrency.err index e1df2db..5101b06 100644 --- a/tests/msc_vlr/msc_vlr_test_reject_concurrency.err +++ b/tests/msc_vlr/msc_vlr_test_reject_concurrency.err @@ -1,6 +1,6 @@ DLMGCP MGCP client: using endpoint domain '@mgw' full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_reject_2nd_conn - Location Update Request on one connection @@ -190,7 +190,7 @@ ===== test_reject_2nd_conn: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_reject_lu_during_lu - Location Update Request @@ -331,7 +331,7 @@ ===== test_reject_lu_during_lu: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_reject_cm_during_lu - Location Update Request @@ -476,7 +476,7 @@ ===== test_reject_cm_during_lu: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_reject_paging_resp_during_lu - Location Update Request @@ -616,7 +616,7 @@ ===== test_reject_paging_resp_during_lu: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_reject_lu_during_cm @@ -851,7 +851,7 @@ ===== test_reject_lu_during_cm: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_reject_cm_during_cm @@ -1090,7 +1090,7 @@ ===== test_reject_cm_during_cm: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_reject_paging_resp_during_cm @@ -1314,7 +1314,7 @@ ===== test_reject_paging_resp_during_cm: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_reject_lu_during_paging_resp @@ -1612,7 +1612,7 @@ ===== test_reject_lu_during_paging_resp: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_accept_cm_during_paging_resp @@ -1933,7 +1933,7 @@ ===== test_accept_cm_during_paging_resp: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_reject_paging_resp_during_paging_resp @@ -2228,8 +2228,8 @@ ===== test_reject_paging_resp_during_paging_resp: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 diff --git a/tests/msc_vlr/msc_vlr_test_rest.err b/tests/msc_vlr/msc_vlr_test_rest.err index 3990d10..fb10e6a 100644 --- a/tests/msc_vlr/msc_vlr_test_rest.err +++ b/tests/msc_vlr/msc_vlr_test_rest.err @@ -1,6 +1,6 @@ DLMGCP MGCP client: using endpoint domain '@mgw' full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_cm_service_without_lu - CM Service Request without a prior Location Updating @@ -65,7 +65,7 @@ ===== test_cm_service_without_lu: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_two_lu - Location Update request causes a GSUP LU request to HLR @@ -404,7 +404,7 @@ ===== test_two_lu: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_lu_unknown_tmsi - Location Update request with unknown TMSI sends ID Request for IMSI @@ -583,8 +583,8 @@ ===== test_lu_unknown_tmsi: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 diff --git a/tests/msc_vlr/msc_vlr_test_ss.err b/tests/msc_vlr/msc_vlr_test_ss.err index 9f47dba..243f7e0 100644 --- a/tests/msc_vlr/msc_vlr_test_ss.err +++ b/tests/msc_vlr/msc_vlr_test_ss.err @@ -1,6 +1,6 @@ DLMGCP MGCP client: using endpoint domain '@mgw' full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_ss_ussd_mo_geran - Location Update request causes a GSUP LU request to HLR @@ -235,7 +235,7 @@ ===== test_ss_ussd_mo_geran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_ss_ussd_no_geran - Location Update request causes a GSUP LU request to HLR @@ -495,8 +495,8 @@ ===== test_ss_ussd_no_geran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 diff --git a/tests/msc_vlr/msc_vlr_test_umts_authen.err b/tests/msc_vlr/msc_vlr_test_umts_authen.err index b11f077..63f1bba 100644 --- a/tests/msc_vlr/msc_vlr_test_umts_authen.err +++ b/tests/msc_vlr/msc_vlr_test_umts_authen.err @@ -1,6 +1,6 @@ DLMGCP MGCP client: using endpoint domain '@mgw' full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_umts_authen_geran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -599,7 +599,7 @@ ===== test_umts_authen_geran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_umts_authen_utran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -1229,7 +1229,7 @@ ===== test_umts_authen_utran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_umts_authen_resync_geran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -1461,7 +1461,7 @@ ===== test_umts_authen_resync_geran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_umts_authen_resync_utran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -1705,7 +1705,7 @@ ===== test_umts_authen_resync_utran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_umts_authen_too_short_res_geran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -1823,7 +1823,7 @@ ===== test_umts_authen_too_short_res_geran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_umts_authen_too_short_res_utran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -1941,7 +1941,7 @@ ===== test_umts_authen_too_short_res_utran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_umts_authen_too_long_res_geran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -2059,7 +2059,7 @@ ===== test_umts_authen_too_long_res_geran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_umts_authen_too_long_res_utran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -2177,7 +2177,7 @@ ===== test_umts_authen_too_long_res_utran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_umts_authen_only_sres_geran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -2295,7 +2295,7 @@ ===== test_umts_authen_only_sres_geran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 ===== test_umts_authen_only_sres_utran - Location Update request causes a GSUP Send Auth Info request to HLR @@ -2413,8 +2413,8 @@ ===== test_umts_authen_only_sres_utran: SUCCESS full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 full talloc report on 'msgb' (total 0 bytes in 1 blocks) -talloc_total_blocks(tall_bsc_ctx) == 17 +talloc_total_blocks(tall_bsc_ctx) == 19 diff --git a/tests/msc_vlr/msc_vlr_tests.c b/tests/msc_vlr/msc_vlr_tests.c index 35401ba..4ccaee9 100644 --- a/tests/msc_vlr/msc_vlr_tests.c +++ b/tests/msc_vlr/msc_vlr_tests.c @@ -922,28 +922,30 @@ talloc_report_full(msgb_ctx, stderr); /* Expecting these to stick around in msc_vlr_tests_ctx: * full talloc report on 'msgb' (total 0 bytes in 1 blocks) - * talloc_total_blocks(tall_bsc_ctx) == 17 - * full talloc report on 'msc_vlr_tests_ctx' (total 6336 bytes in 17 blocks) - * struct osmo_gsup_client contains 256 bytes in 1 blocks (ref 0) 0x613000000260 - * struct gsm_network contains 4647 bytes in 9 blocks (ref 0) 0x6190000000e0 - * struct mgcp_client contains 688 bytes in 1 blocks (ref 0) 0x6180000000e0 - * struct sccp_ran_inst contains 152 bytes in 1 blocks (ref 0) 0x611000000460 - * struct sccp_ran_inst contains 152 bytes in 1 blocks (ref 0) 0x611000000320 - * struct gsup_client_mux contains 200 bytes in 2 blocks (ref 0) 0x6110000001e0 - * struct ipaccess_unit contains 64 bytes in 1 blocks (ref 0) 0x60e000023180 - * struct vlr_instance contains 248 bytes in 1 blocks (ref 0) 0x6130000000a0 - * no_gsup_server contains 15 bytes in 1 blocks (ref 0) 0x60b000000150 - * ../../../src/libosmocore/src/rate_ctr.c:234 contains 2352 bytes in 1 blocks (ref 0) 0x61e0000000e0 - * logging contains 1433 bytes in 5 blocks (ref 0) 0x60b0000000a0 - * struct log_target contains 240 bytes in 2 blocks (ref 0) 0x6120000000a0 - * struct log_category contains 72 bytes in 1 blocks (ref 0) 0x60f0000000a0 - * struct log_info contains 1192 bytes in 2 blocks (ref 0) 0x60d0000000a0 - * struct log_info_cat contains 1152 bytes in 1 blocks (ref 0) 0x61a0000000e0 - * msgb contains 0 bytes in 1 blocks (ref 0) 0x608000000100 + * talloc_total_blocks(tall_bsc_ctx) == 19 + * full talloc report on 'msc_vlr_tests_ctx' (total 6532 bytes in 19 blocks) + * struct osmo_gsup_client contains 256 bytes in 1 blocks (ref 0) 0x56143306aa10 + * struct gsm_network contains 4775 bytes in 11 blocks (ref 0) 0x5614330697e0 + * struct mgcp_client contains 688 bytes in 1 blocks (ref 0) 0x56143306ad80 + * struct sccp_ran_inst contains 152 bytes in 1 blocks (ref 0) 0x56143306ac80 + * struct sccp_ran_inst contains 152 bytes in 1 blocks (ref 0) 0x56143306ab80 + * struct gsup_client_mux contains 152 bytes in 2 blocks (ref 0) 0x56143306a8a0 + * struct ipaccess_unit contains 64 bytes in 1 blocks (ref 0) 0x56143306a960 + * struct vlr_instance contains 248 bytes in 1 blocks (ref 0) 0x56143306a740 + * no_gsup_server contains 15 bytes in 1 blocks (ref 0) 0x56143306a6c0 + * stat_item.c:96 contains 144 bytes in 2 blocks (ref 0) 0x56143306a550 + * stat_item.c:118 contains 96 bytes in 1 blocks (ref 0) 0x56143306a5f0 + * rate_ctr.c:234 contains 2352 bytes in 1 blocks (ref 0) 0x561433069bb0 + * logging contains 1501 bytes in 5 blocks (ref 0) 0x561433068fe0 + * struct log_target contains 244 bytes in 2 blocks (ref 0) 0x561433069610 + * struct log_category contains 76 bytes in 1 blocks (ref 0) 0x561433069720 + * struct log_info contains 1256 bytes in 2 blocks (ref 0) 0x561433069050 + * struct log_info_cat contains 1216 bytes in 1 blocks (ref 0) 0x5614330690e0 + * msgb contains 0 bytes in 1 blocks (ref 0) 0x561433068f70 */ fprintf(stderr, "talloc_total_blocks(tall_bsc_ctx) == %zu\n", talloc_total_blocks(msc_vlr_tests_ctx)); - if (talloc_total_blocks(msc_vlr_tests_ctx) != 17) + if (talloc_total_blocks(msc_vlr_tests_ctx) != 19) talloc_report_full(msc_vlr_tests_ctx, stderr); fprintf(stderr, "\n"); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/13802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6a20123b263f4f808153794ee8a735092deb399e Gerrit-Change-Number: 13802 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 14:51:22 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Thu, 18 Jul 2019 14:51:22 +0000 Subject: Change in ...libosmocore[master]: bitvec: bitvec_get_uint() should return an unsigned int In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14577 ) Change subject: bitvec: bitvec_get_uint() should return an unsigned int ...................................................................... Patch Set 2: Code-Review-2 I'll leave this patch open until it I fixed the size check -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14577 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d50d375ccf63ecb45061682ede0b46b6087d11a Gerrit-Change-Number: 14577 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Thu, 18 Jul 2019 14:51:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 15:41:02 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Jul 2019 15:41:02 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E0=2E11_=E2=86=92_0=2E1=2E0?= In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14794 ) Change subject: Bump version: 0.0.11 ? 0.1.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14794 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I4f0d75163fcb7d8d9b5540f8970382ce873680d4 Gerrit-Change-Number: 14794 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 15:41:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 15:41:09 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Jul 2019 15:41:09 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-pcap=5Bmaster=5D=3A_Bump_version=3A_0=2E0=2E11_=E2=86=92_0=2E1=2E0?= In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcap/+/14794 ) Change subject: Bump version: 0.0.11 ? 0.1.0 ...................................................................... Bump version: 0.0.11 ? 0.1.0 Change-Id: I4f0d75163fcb7d8d9b5540f8970382ce873680d4 --- M debian/changelog 1 file changed, 51 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 1345f93..f2da97e 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,54 @@ +osmo-pcap (0.1.0) unstable; urgency=medium + + [ Harald Welte ] + * sock_src_init(): Don't freeaddrinfo() undefined src_result + * Use TCP port numbers for VTY that don't overlap with other Osmocom Software + * Rename osmo_pcap_{client_server} executables to osmo-pcap-{client,server} + * Use libosmocore osmo_sock_init2() instead of local implementation + * client: Move to osmo_sock_init2_ofd() + * Add support for generating IPIP to osmo-pcap-client + * debian/control: Fix URLs for homepage, git, gitweb + * change binary builds URL to network:osmocom as that's more maintained + * Fix compiler warning about deprecated _BSD_SOURCE + + [ Max ] + * Add gitreview config + * Use release helper from libosmocore + + [ Pau Espin Pedrol ] + * cosmetic: client: rename forward_packet function + * vty: skip installing cmds now always installed by default + * client: Properly name main talloc ctx + * server: Properly name main talloc ctx + * Drop osmo_init_logging and use osmo_init_logging2 + * osmo_client_send_data: Fix wrong log format + * configure.ac: Add --enable-werror flag + * configure.ac: Add --enable-sanitize flag + * jenkins.sh: enable werror and sanitize configure flags + * Replace '.' in counter names with ':' + * Use enum for PKT_LINK_* + * client: Set snaplen to MAXIMUM_SNAPLEN + * client: Add pcap snaplen VTY cmd + * client_send_link: snaplen not needed during allocation + * server: Improve verification of messages from client + * server: Add pcap snaplen VTY cmd + * contrib/jenkins.sh: Update to current osmocom infra + * debian: Clean up to look like other osmocom projects + * Install systemd services with autotools + * Install cfg files with autotools + * gitignore: Add compile + * debian: Install osmo_pcap_clean_old in osmo-pcap-server pkg + * tests/Makefile.am: Fix "./configure && make clean && make" + * debian/changelog: Mark 0.0.11 as released + + [ Oliver Smith ] + * Fix DISTCHECK_CONFIGURE_FLAGS override + * contrib: fix makedistcheck with disabled systemd + * gitignore: fix application names + * contrib/jenkins.sh: run "make maintainer-clean" + + -- Pau Espin Pedrol Tue, 16 Jul 2019 19:01:15 +0200 + osmo-pcap (0.0.11) unstable; urgency=medium * Add "source ip A.B.C.D" option to use specific address. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/14794 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I4f0d75163fcb7d8d9b5540f8970382ce873680d4 Gerrit-Change-Number: 14794 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 15:44:15 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Jul 2019 15:44:15 +0000 Subject: Change in ...meta-telephony[201705]: Add recipe for osmo-pcap, both server and client In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#3) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/meta-telephony/+/3534 ) Change subject: Add recipe for osmo-pcap, both server and client ...................................................................... Add recipe for osmo-pcap, both server and client Change-Id: I5bb85b118029d1559a958803184690a9d0f23e4a --- A recipes-osmocom/osmo-pcap/osmo-pcap.inc A recipes-osmocom/osmo-pcap/osmo-pcap_git.bb 2 files changed, 46 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/34/3534/3 -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/3534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I5bb85b118029d1559a958803184690a9d0f23e4a Gerrit-Change-Number: 3534 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Assignee: pespin Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Max Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 15:45:31 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Jul 2019 15:45:31 +0000 Subject: Change in ...meta-telephony[201705]: Add recipe for osmo-pcap, both server and client In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/meta-telephony/+/3534 ) Change subject: Add recipe for osmo-pcap, both server and client ...................................................................... Patch Set 3: Verified+1 Code-Review+2 Re-adding votes after fixing small things I mentioned. -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/3534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I5bb85b118029d1559a958803184690a9d0f23e4a Gerrit-Change-Number: 3534 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Assignee: pespin Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Max Gerrit-Comment-Date: Thu, 18 Jul 2019 15:45:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 15:45:35 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Jul 2019 15:45:35 +0000 Subject: Change in ...meta-telephony[201705]: Add recipe for osmo-pcap, both server and client In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/meta-telephony/+/3534 ) Change subject: Add recipe for osmo-pcap, both server and client ...................................................................... Add recipe for osmo-pcap, both server and client Change-Id: I5bb85b118029d1559a958803184690a9d0f23e4a --- A recipes-osmocom/osmo-pcap/osmo-pcap.inc A recipes-osmocom/osmo-pcap/osmo-pcap_git.bb 2 files changed, 46 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/recipes-osmocom/osmo-pcap/osmo-pcap.inc b/recipes-osmocom/osmo-pcap/osmo-pcap.inc new file mode 100644 index 0000000..a7d3a60 --- /dev/null +++ b/recipes-osmocom/osmo-pcap/osmo-pcap.inc @@ -0,0 +1,39 @@ +DESCRITOPN = "Osmocom PCAP client (probe) and server (aggregator)" +HOMEPAGE = "https://osmocom.org/" +LICENSE = "AGPLv3+" +LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788" + +DEPENDS = "libosmocore zeromq libpcap gnutls" + +INC_PR="r0.${META_TELEPHONY_OSMO_INC}" + +inherit autotools pkgconfig systemd + +PACKAGECONFIG ??= "\ + ${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \ + " +PACKAGECONFIG[systemd] = "--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir" + +PACKAGES =+ "osmo-pcap-server osmo-pcap-client" + +SYSTEMD_PACKAGES = "osmo-pcap-server osmo-pcap-client" +SYSTEMD_SERVICE_osmo-pcap-server = "osmo-pcap-server.service" +SYSTEMD_SERVICE_osmo-pcap-client = "osmo-pcap-client.service" + +CONFFILES_osmo-pcap-server = "${sysconfdir}/osmocom/osmo-pcap-server.cfg" +CONFFILES_osmo-pcap-client = "${sysconfdir}/osmocom/osmo-pcap-client.cfg" + +EXTRA_OECONF += "--with-pcap-config=no" + +do_configure_prepend() { + export PCAP_LIBS="-lpcap" +} + +FILES_osmo-pcap-server = "${bindir}/osmo-pcap-server \ + ${sysconfdir}/osmocom/osmo-pcap-server.cfg \ + ${datadir}/osmo-pcap/osmo_pcap_clean_old \ + " + +FILES_osmo-pcap-client = "${bindir}/osmo-pcap-client \ + ${sysconfdir}/osmocom/osmo-pcap-client.cfg \ + " diff --git a/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb b/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb new file mode 100644 index 0000000..9ffb510 --- /dev/null +++ b/recipes-osmocom/osmo-pcap/osmo-pcap_git.bb @@ -0,0 +1,7 @@ +require ${PN}.inc + +S = "${WORKDIR}/git" +SRCREV = "901543a78846cc4e3a0cdae91dead4913b1be961" +SRC_URI = "git://git.osmocom.org/osmo-pcap.git;protocol=git" +PV = "0.1.0+gitr${SRCPV}" +PR = "${INC_PR}.0" -- To view, visit https://gerrit.osmocom.org/c/meta-telephony/+/3534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: meta-telephony Gerrit-Branch: 201705 Gerrit-Change-Id: I5bb85b118029d1559a958803184690a9d0f23e4a Gerrit-Change-Number: 3534 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Assignee: pespin Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Max Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 16:19:18 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 16:19:18 +0000 Subject: Change in ...osmo-remsim[master]: rspro_server.c: Fix memory leak in processing inbound RSPRO Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14827 Change subject: rspro_server.c: Fix memory leak in processing inbound RSPRO ...................................................................... rspro_server.c: Fix memory leak in processing inbound RSPRO We need to unconditionally free the msgb that gets handed into sock_read_cb() by the ipa server. Change-Id: I12b4a22854eea79c9e9c3e565dd4803e4dc0ed5a --- M src/server/rspro_server.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/27/14827/1 diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 7cf98ad..c753f16 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -613,6 +613,7 @@ default: goto invalid; } + msgb_free(msg); return rc; invalid: -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14827 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I12b4a22854eea79c9e9c3e565dd4803e4dc0ed5a Gerrit-Change-Number: 14827 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 16:47:31 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 16:47:31 +0000 Subject: Change in ...osmo-remsim[master]: remsim_server: Enable talloc tracking of msgb allocations Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14828 Change subject: remsim_server: Enable talloc tracking of msgb allocations ...................................................................... remsim_server: Enable talloc tracking of msgb allocations Change-Id: Ia8c729756da6bb85e61a65addae4d4c83e7b6fde --- M src/server/remsim_server.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/28/14828/1 diff --git a/src/server/remsim_server.c b/src/server/remsim_server.c index 57e0733..a8502e4 100644 --- a/src/server/remsim_server.c +++ b/src/server/remsim_server.c @@ -31,6 +31,7 @@ g_tall_ctx = talloc_named_const(NULL, 0, "global"); talloc_asn1_ctx = talloc_named_const(g_tall_ctx, 0, "asn1"); + msgb_talloc_ctx_init(g_tall_ctx, 0); osmo_init_logging2(g_tall_ctx, &log_info); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14828 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia8c729756da6bb85e61a65addae4d4c83e7b6fde Gerrit-Change-Number: 14828 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 16:56:00 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 16:56:00 +0000 Subject: Change in ...osmo-remsim[master]: remsim_client: Fix memory leak receiving RSPRO messages Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14829 Change subject: remsim_client: Fix memory leak receiving RSPRO messages ...................................................................... remsim_client: Fix memory leak receiving RSPRO messages Change-Id: Ic3b5b7b03d557557a245fcd5c31bd687e11c7477 Closes: OS#4119 --- M src/simtrace2-remsim_client.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/29/14829/1 diff --git a/src/simtrace2-remsim_client.c b/src/simtrace2-remsim_client.c index d30965a..c770641 100644 --- a/src/simtrace2-remsim_client.c +++ b/src/simtrace2-remsim_client.c @@ -627,7 +627,7 @@ LOGPFSML(bc->bankd_fi, LOGL_DEBUG, "Received RSPRO %s\n", msgb_hexdump(msg)); rc = bankd_handle_msg(bc, msg); - + msgb_free(msg); return rc; invalid: -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic3b5b7b03d557557a245fcd5c31bd687e11c7477 Gerrit-Change-Number: 14829 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 16:56:00 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 16:56:00 +0000 Subject: Change in ...osmo-remsim[master]: remsim_client: Enable talloc tracking of msgb allocations Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14830 Change subject: remsim_client: Enable talloc tracking of msgb allocations ...................................................................... remsim_client: Enable talloc tracking of msgb allocations Change-Id: I45f90f1a841b5b1f29bdb41671085eeebf934a6f --- M src/remsim_client.c M src/simtrace2-remsim_client.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/30/14830/1 diff --git a/src/remsim_client.c b/src/remsim_client.c index de926f7..88ac4cd 100644 --- a/src/remsim_client.c +++ b/src/remsim_client.c @@ -230,6 +230,7 @@ g_tall_ctx = talloc_named_const(NULL, 0, "global"); talloc_asn1_ctx = talloc_named_const(g_tall_ctx, 0, "asn1"); + msgb_talloc_ctx_init(g_tall_ctx, 0); osmo_init_logging2(g_tall_ctx, &log_info); diff --git a/src/simtrace2-remsim_client.c b/src/simtrace2-remsim_client.c index c770641..04aa0c6 100644 --- a/src/simtrace2-remsim_client.c +++ b/src/simtrace2-remsim_client.c @@ -818,6 +818,7 @@ g_tall_ctx = talloc_named_const(NULL, 0, "global"); talloc_asn1_ctx = talloc_named_const(g_tall_ctx, 0, "asn1"); + msgb_talloc_ctx_init(g_tall_ctx, 0); osmo_init_logging2(g_tall_ctx, &log_info); rc = libusb_init(NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14830 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I45f90f1a841b5b1f29bdb41671085eeebf934a6f Gerrit-Change-Number: 14830 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 17:01:50 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 17:01:50 +0000 Subject: Change in ...osmo-remsim[master]: remsim_client: Enable talloc tracking of msgb allocations In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14830 ) Change subject: remsim_client: Enable talloc tracking of msgb allocations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14830 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I45f90f1a841b5b1f29bdb41671085eeebf934a6f Gerrit-Change-Number: 14830 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 18 Jul 2019 17:01:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 17:01:54 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 17:01:54 +0000 Subject: Change in ...osmo-remsim[master]: remsim_server: Enable talloc tracking of msgb allocations In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14828 ) Change subject: remsim_server: Enable talloc tracking of msgb allocations ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14828 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia8c729756da6bb85e61a65addae4d4c83e7b6fde Gerrit-Change-Number: 14828 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 18 Jul 2019 17:01:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 17:02:48 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 17:02:48 +0000 Subject: Change in ...osmo-remsim[master]: rspro_server.c: Fix memory leak in processing inbound RSPRO In-Reply-To: References: Message-ID: Hello roh, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/14827 to look at the new patch set (#2). Change subject: rspro_server.c: Fix memory leak in processing inbound RSPRO ...................................................................... rspro_server.c: Fix memory leak in processing inbound RSPRO We need to unconditionally free the msgb that gets handed into sock_read_cb() by the ipa server. Closes: OS#4096 Change-Id: I12b4a22854eea79c9e9c3e565dd4803e4dc0ed5a --- M src/server/rspro_server.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/27/14827/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14827 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I12b4a22854eea79c9e9c3e565dd4803e4dc0ed5a Gerrit-Change-Number: 14827 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: roh Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 17:06:20 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 17:06:20 +0000 Subject: Change in ...osmo-remsim[master]: rspro_client_fsm: Fix memory leak processing RSPRO Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14831 Change subject: rspro_client_fsm: Fix memory leak processing RSPRO ...................................................................... rspro_client_fsm: Fix memory leak processing RSPRO Change-Id: I2c3710d152ce31d293a3693a70718c8712e2ac2b Closes: OS#4097 --- M src/rspro_client_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/31/14831/1 diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 1527eff..768c15f 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -152,7 +152,7 @@ default: goto invalid; } - + msgb_free(msg); return rc; invalid: -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14831 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2c3710d152ce31d293a3693a70718c8712e2ac2b Gerrit-Change-Number: 14831 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 17:13:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 17:13:56 +0000 Subject: Change in ...osmo-remsim[master]: remsim_server: Enable talloc tracking of msgb allocations In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14828 ) Change subject: remsim_server: Enable talloc tracking of msgb allocations ...................................................................... remsim_server: Enable talloc tracking of msgb allocations Change-Id: Ia8c729756da6bb85e61a65addae4d4c83e7b6fde --- M src/server/remsim_server.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/server/remsim_server.c b/src/server/remsim_server.c index 57e0733..a8502e4 100644 --- a/src/server/remsim_server.c +++ b/src/server/remsim_server.c @@ -31,6 +31,7 @@ g_tall_ctx = talloc_named_const(NULL, 0, "global"); talloc_asn1_ctx = talloc_named_const(g_tall_ctx, 0, "asn1"); + msgb_talloc_ctx_init(g_tall_ctx, 0); osmo_init_logging2(g_tall_ctx, &log_info); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14828 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia8c729756da6bb85e61a65addae4d4c83e7b6fde Gerrit-Change-Number: 14828 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 17:13:57 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 17:13:57 +0000 Subject: Change in ...osmo-remsim[master]: remsim_client: Enable talloc tracking of msgb allocations In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14830 ) Change subject: remsim_client: Enable talloc tracking of msgb allocations ...................................................................... remsim_client: Enable talloc tracking of msgb allocations Change-Id: I45f90f1a841b5b1f29bdb41671085eeebf934a6f --- M src/remsim_client.c M src/simtrace2-remsim_client.c 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/remsim_client.c b/src/remsim_client.c index de926f7..88ac4cd 100644 --- a/src/remsim_client.c +++ b/src/remsim_client.c @@ -230,6 +230,7 @@ g_tall_ctx = talloc_named_const(NULL, 0, "global"); talloc_asn1_ctx = talloc_named_const(g_tall_ctx, 0, "asn1"); + msgb_talloc_ctx_init(g_tall_ctx, 0); osmo_init_logging2(g_tall_ctx, &log_info); diff --git a/src/simtrace2-remsim_client.c b/src/simtrace2-remsim_client.c index d30965a..9bedf71 100644 --- a/src/simtrace2-remsim_client.c +++ b/src/simtrace2-remsim_client.c @@ -818,6 +818,7 @@ g_tall_ctx = talloc_named_const(NULL, 0, "global"); talloc_asn1_ctx = talloc_named_const(g_tall_ctx, 0, "asn1"); + msgb_talloc_ctx_init(g_tall_ctx, 0); osmo_init_logging2(g_tall_ctx, &log_info); rc = libusb_init(NULL); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14830 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I45f90f1a841b5b1f29bdb41671085eeebf934a6f Gerrit-Change-Number: 14830 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 17:24:11 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Jul 2019 17:24:11 +0000 Subject: Change in ...osmo-remsim[master]: rspro_client_fsm: Fix memory leak processing RSPRO In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14831 ) Change subject: rspro_client_fsm: Fix memory leak processing RSPRO ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14831 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2c3710d152ce31d293a3693a70718c8712e2ac2b Gerrit-Change-Number: 14831 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: roh Gerrit-Comment-Date: Thu, 18 Jul 2019 17:24:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 17:56:01 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 18 Jul 2019 17:56:01 +0000 Subject: Change in ...osmo-bts[master]: manuals: Add counter documentation In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14524 to look at the new patch set (#3). Change subject: manuals: Add counter documentation ...................................................................... manuals: Add counter documentation Change-Id: I994ad6aae7f409e0f15ff1d388127e16243b378a Related: OS#1700 --- A doc/manuals/chapters/counters.adoc A doc/manuals/chapters/counters_generated.adoc M doc/manuals/osmobts-usermanual.adoc 3 files changed, 72 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/24/14524/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I994ad6aae7f409e0f15ff1d388127e16243b378a Gerrit-Change-Number: 14524 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 18:18:22 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Jul 2019 18:18:22 +0000 Subject: Change in ...osmo-bts[master]: manuals: Add counter documentation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14524 ) Change subject: manuals: Add counter documentation ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I994ad6aae7f409e0f15ff1d388127e16243b378a Gerrit-Change-Number: 14524 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 18:18:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 18:19:06 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Jul 2019 18:19:06 +0000 Subject: Change in ...osmo-bts[master]: manuals: Update vty documentation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14523 ) Change subject: manuals: Update vty documentation ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icc0c96d173f31f2eb5fcb6385525a17f94ead852 Gerrit-Change-Number: 14523 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 18:19:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 18:27:20 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 18 Jul 2019 18:27:20 +0000 Subject: Change in ...openbsc[master]: manuals: Update osmonitb counter/vty documentation In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/openbsc/+/14529 to look at the new patch set (#2). Change subject: manuals: Update osmonitb counter/vty documentation ...................................................................... manuals: Update osmonitb counter/vty documentation Change-Id: Ia598124fbb98b3ec8dee606f9d028bb3cc6ff002 Related: OS#1700 --- A manuals/OsmoNITB/chapters/counters.adoc A manuals/OsmoNITB/chapters/counters_generated.adoc M manuals/OsmoNITB/osmonitb-usermanual.adoc M manuals/OsmoNITB/vty/nitb_vty_reference.xml 4 files changed, 4,176 insertions(+), 4,724 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/29/14529/2 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ia598124fbb98b3ec8dee606f9d028bb3cc6ff002 Gerrit-Change-Number: 14529 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 18:27:20 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 18 Jul 2019 18:27:20 +0000 Subject: Change in ...openbsc[master]: manuals: Generate vty/counter documentation for osmo-bscnat In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/openbsc/+/14530 to look at the new patch set (#2). Change subject: manuals: Generate vty/counter documentation for osmo-bscnat ...................................................................... manuals: Generate vty/counter documentation for osmo-bscnat Change-Id: Ice7f15192a57e2c964d07d364732af888972ba0f Depends: I44bb395009582f5e1399f277e15203553c2dcf78 (docker-playground.git) Depends: I52c3cb2cdcfb143e71ac2c1aa40bb466e41a0f5c (docker-playground.git) Related: OS#1700 --- A manuals/OsmoBSCNAT/chapters/counters_generated.adoc M manuals/OsmoBSCNAT/vty/nat_vty_reference.xml M openbsc/doc/regen_doc.sh 3 files changed, 2,353 insertions(+), 2,064 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/30/14530/2 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ice7f15192a57e2c964d07d364732af888972ba0f Gerrit-Change-Number: 14530 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 18:31:21 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 18 Jul 2019 18:31:21 +0000 Subject: Change in ...openbsc[master]: manuals: Update osmonitb counter/vty documentation In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/openbsc/+/14529 to look at the new patch set (#3). Change subject: manuals: Update osmonitb counter/vty documentation ...................................................................... manuals: Update osmonitb counter/vty documentation Change-Id: Ia598124fbb98b3ec8dee606f9d028bb3cc6ff002 Related: OS#1700 --- A manuals/OsmoNITB/chapters/counters.adoc A manuals/OsmoNITB/chapters/counters_generated.adoc M manuals/OsmoNITB/osmonitb-usermanual.adoc M manuals/OsmoNITB/vty/nitb_vty_reference.xml 4 files changed, 4,176 insertions(+), 4,724 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/29/14529/3 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ia598124fbb98b3ec8dee606f9d028bb3cc6ff002 Gerrit-Change-Number: 14529 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 18:31:50 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 18 Jul 2019 18:31:50 +0000 Subject: Change in ...openbsc[master]: manuals: Update osmonitb counter/vty documentation In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14529 ) Change subject: manuals: Update osmonitb counter/vty documentation ...................................................................... Patch Set 1: Reran with new libosmocore. White space issues should be gone now. -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ia598124fbb98b3ec8dee606f9d028bb3cc6ff002 Gerrit-Change-Number: 14529 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 18 Jul 2019 18:31:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 18:42:08 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 18 Jul 2019 18:42:08 +0000 Subject: Change in ...openbsc[master]: manuals: Generate vty/counter documentation for osmo-bscnat In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/openbsc/+/14530 to look at the new patch set (#4). Change subject: manuals: Generate vty/counter documentation for osmo-bscnat ...................................................................... manuals: Generate vty/counter documentation for osmo-bscnat Change-Id: Ice7f15192a57e2c964d07d364732af888972ba0f Depends: I44bb395009582f5e1399f277e15203553c2dcf78 (docker-playground.git) Depends: I52c3cb2cdcfb143e71ac2c1aa40bb466e41a0f5c (docker-playground.git) Related: OS#1700 --- A manuals/OsmoBSCNAT/chapters/counters_generated.adoc M manuals/OsmoBSCNAT/vty/nat_vty_reference.xml M openbsc/doc/regen_doc.sh 3 files changed, 2,345 insertions(+), 2,064 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/30/14530/4 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ice7f15192a57e2c964d07d364732af888972ba0f Gerrit-Change-Number: 14530 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 18:44:16 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Jul 2019 18:44:16 +0000 Subject: Change in ...openbsc[master]: manuals: Update osmonitb counter/vty documentation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14529 ) Change subject: manuals: Update osmonitb counter/vty documentation ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ia598124fbb98b3ec8dee606f9d028bb3cc6ff002 Gerrit-Change-Number: 14529 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Thu, 18 Jul 2019 18:44:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 18:45:20 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Jul 2019 18:45:20 +0000 Subject: Change in ...openbsc[master]: manuals: Generate vty/counter documentation for osmo-bscnat In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14530 ) Change subject: manuals: Generate vty/counter documentation for osmo-bscnat ...................................................................... Patch Set 4: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14530/4/openbsc/doc/regen_doc.sh File openbsc/doc/regen_doc.sh: https://gerrit.osmocom.org/#/c/14530/4/openbsc/doc/regen_doc.sh at 19 PS4, Line 19: OSMO_BSCNAT_BRANCH=$COMMIT ./regen_doc.sh osmo-nitb 4244 \ osmo-nitb? that looks wrong! -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ice7f15192a57e2c964d07d364732af888972ba0f Gerrit-Change-Number: 14530 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 18:45:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 18:45:28 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 18 Jul 2019 18:45:28 +0000 Subject: Change in ...docker-playground[master]: osmo-nitb-master: Include only one access-list in config Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14832 Change subject: osmo-nitb-master: Include only one access-list in config ...................................................................... osmo-nitb-master: Include only one access-list in config Each access list will have their own counters. Have only one in the config so the script generating the counter documentation doesn't repeat itself. Change-Id: I01b6e5af9cf84cf1b8d313ac47ab6b77fc598f4c --- M osmo-nitb-master/osmo-bsc-nat.cfg 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/32/14832/1 diff --git a/osmo-nitb-master/osmo-bsc-nat.cfg b/osmo-nitb-master/osmo-bsc-nat.cfg index 0179a94..db74d7e 100644 --- a/osmo-nitb-master/osmo-bsc-nat.cfg +++ b/osmo-nitb-master/osmo-bsc-nat.cfg @@ -38,4 +38,3 @@ ip-dscp 0 bscs-config-file bscs.config access-list msceven imsi-allow ^[0-9]*[24680]$ - access-list mscodd imsi-allow ^[0-9]*[13579]$ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14832 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I01b6e5af9cf84cf1b8d313ac47ab6b77fc598f4c Gerrit-Change-Number: 14832 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 18:46:56 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 18 Jul 2019 18:46:56 +0000 Subject: Change in ...openbsc[master]: manuals: Generate vty/counter documentation for osmo-bscnat In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14530 ) Change subject: manuals: Generate vty/counter documentation for osmo-bscnat ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/#/c/14530/1/manuals/OsmoBSCNAT/chapters/counters_generated.adoc File manuals/OsmoBSCNAT/chapters/counters_generated.adoc: https://gerrit.osmocom.org/#/c/14530/1/manuals/OsmoBSCNAT/chapters/counters_generated.adoc at 79 PS1, Line 79: | conn:other | <> | Conn Other > Found where the whitespace come, providing fix for it. [?] Done https://gerrit.osmocom.org/#/c/14530/3/manuals/OsmoBSCNAT/chapters/counters_generated.adoc File manuals/OsmoBSCNAT/chapters/counters_generated.adoc: https://gerrit.osmocom.org/#/c/14530/3/manuals/OsmoBSCNAT/chapters/counters_generated.adoc at 23 PS3, Line 23: |=== This section is also duplicated. I changed the config to only include one access-list. -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ice7f15192a57e2c964d07d364732af888972ba0f Gerrit-Change-Number: 14530 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 18:46:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 18:48:24 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 18 Jul 2019 18:48:24 +0000 Subject: Change in ...docker-playground[master]: osmo-nitb-master: Include only one access-list in config In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14832 ) Change subject: osmo-nitb-master: Include only one access-list in config ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14832 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I01b6e5af9cf84cf1b8d313ac47ab6b77fc598f4c Gerrit-Change-Number: 14832 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 18:48:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 20:15:46 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Jul 2019 20:15:46 +0000 Subject: Change in ...osmo-bts[master]: manuals: Update vty documentation In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14523 ) Change subject: manuals: Update vty documentation ...................................................................... Patch Set 4: Wait, you're basically rewriting the whole file without visible changes? Line endings? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icc0c96d173f31f2eb5fcb6385525a17f94ead852 Gerrit-Change-Number: 14523 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 18 Jul 2019 20:15:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 20:17:09 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 18 Jul 2019 20:17:09 +0000 Subject: Change in ...osmo-bts[master]: manuals: Add counter documentation In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14524 ) Change subject: manuals: Add counter documentation ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I994ad6aae7f409e0f15ff1d388127e16243b378a Gerrit-Change-Number: 14524 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 20:17:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 20:40:29 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 20:40:29 +0000 Subject: Change in ...openbsc[master]: manuals: Update osmonitb counter/vty documentation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14529 ) Change subject: manuals: Update osmonitb counter/vty documentation ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ia598124fbb98b3ec8dee606f9d028bb3cc6ff002 Gerrit-Change-Number: 14529 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 20:40:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 20:40:32 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 20:40:32 +0000 Subject: Change in ...openbsc[master]: manuals: Update osmonitb counter/vty documentation In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/openbsc/+/14529 ) Change subject: manuals: Update osmonitb counter/vty documentation ...................................................................... manuals: Update osmonitb counter/vty documentation Change-Id: Ia598124fbb98b3ec8dee606f9d028bb3cc6ff002 Related: OS#1700 --- A manuals/OsmoNITB/chapters/counters.adoc A manuals/OsmoNITB/chapters/counters_generated.adoc M manuals/OsmoNITB/osmonitb-usermanual.adoc M manuals/OsmoNITB/vty/nitb_vty_reference.xml 4 files changed, 4,176 insertions(+), 4,724 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ia598124fbb98b3ec8dee606f9d028bb3cc6ff002 Gerrit-Change-Number: 14529 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 20:41:33 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 20:41:33 +0000 Subject: Change in ...openbsc[master]: manuals: Generate vty/counter documentation for osmo-bscnat In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14530 ) Change subject: manuals: Generate vty/counter documentation for osmo-bscnat ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ice7f15192a57e2c964d07d364732af888972ba0f Gerrit-Change-Number: 14530 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 18 Jul 2019 20:41:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 20:41:47 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 20:41:47 +0000 Subject: Change in ...openbsc[master]: manuals: Generate vty/counter documentation for osmo-bscnat In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/openbsc/+/14530 ) Change subject: manuals: Generate vty/counter documentation for osmo-bscnat ...................................................................... manuals: Generate vty/counter documentation for osmo-bscnat Change-Id: Ice7f15192a57e2c964d07d364732af888972ba0f Depends: I44bb395009582f5e1399f277e15203553c2dcf78 (docker-playground.git) Depends: I52c3cb2cdcfb143e71ac2c1aa40bb466e41a0f5c (docker-playground.git) Related: OS#1700 --- A manuals/OsmoBSCNAT/chapters/counters_generated.adoc M manuals/OsmoBSCNAT/vty/nat_vty_reference.xml M openbsc/doc/regen_doc.sh 3 files changed, 2,345 insertions(+), 2,064 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified Objections: pespin: I would prefer this is not merged as is diff --git a/manuals/OsmoBSCNAT/chapters/counters_generated.adoc b/manuals/OsmoBSCNAT/chapters/counters_generated.adoc new file mode 100644 index 0000000..16aa724 --- /dev/null +++ b/manuals/OsmoBSCNAT/chapters/counters_generated.adoc @@ -0,0 +1,52 @@ + +// autogenerated by show asciidoc counters +These counters and their description based on OsmoBSCNAT 1.3.0 (OsmoBSCNAT). + +=== Rate Counters + +// generating tables for rate_ctr_group +// rate_ctr_group table NAT Access-List Statistics +.nat:filter - NAT Access-List Statistics +[options="header"] +|=== +| Name | Reference | Description +| access-list:local-filter | <> | Rejected by rule for local +| access-list:global-filter | <> | Rejected by rule for global +|=== +// rate_ctr_group table NAT BSC Statistics +.nat:bsc - NAT BSC Statistics +[options="header"] +|=== +| Name | Reference | Description +| sccp:conn | <> | SCCP Connections +| sccp:calls | <> | SCCP Assignment Commands +| net:reconnects | <> | Network reconnects +| dropped:sccp | <> | Dropped SCCP connections +| dropped:calls | <> | Dropped active calls. +| rejected:cr | <> | Rejected CR due filter +| rejected:msg | <> | Rejected MSG due filter +| rejected:ill | <> | Rejected due parse error +| conn:lu | <> | Conn Location Update +| conn:rq | <> | Conn CM Service Req +| conn:pag | <> | Conn Paging Response +| conn:ssa | <> | Conn USSD +| conn:other | <> | Conn Other +|=== +== Osmo Stat Items + +// generating tables for osmo_stat_items +== Osmo Counters + +// generating tables for osmo_counters +// ungrouped osmo_counters +.ungrouped osmo counters +[options="header"] +|=== +| Name | Reference | Description +| nat.sccp.conn | <> | +| nat.sccp.calls | <> | +| nat.bsc.conn | <> | +| nat.bsc.auth_fail | <> | +| nat.msc.conn | <> | +| nat.ussd.conn | <> | +|=== diff --git a/manuals/OsmoBSCNAT/vty/nat_vty_reference.xml b/manuals/OsmoBSCNAT/vty/nat_vty_reference.xml index 80fe08f..3ed4903 100644 --- a/manuals/OsmoBSCNAT/vty/nat_vty_reference.xml +++ b/manuals/OsmoBSCNAT/vty/nat_vty_reference.xml @@ -1,2061 +1,2289 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file + + + Common Commands + These commands are available on all VTY nodes. They are listed here only once, to unclutter the VTY reference. + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + view + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + enable + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-log + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-stats + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-line + + + + + + + + + + + + + + + + + + + + + config-ctrl + + + + + + + + + config-mgcp + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-nat + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-nat-bsc + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-mgcp-trunk + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-nat-paging-group + + + + + + + + + + + + + + + diff --git a/openbsc/doc/regen_doc.sh b/openbsc/doc/regen_doc.sh index 5552dec..12bb878 100755 --- a/openbsc/doc/regen_doc.sh +++ b/openbsc/doc/regen_doc.sh @@ -16,6 +16,7 @@ "$MANUAL_DIR/OsmoNITB/chapters/counters_generated.adoc" \ "$MANUAL_DIR/OsmoNITB/vty/nitb_vty_reference.xml" -#OSMO_BSCNAT_BRANCH=$COMMIT ./regen_doc.sh osmo-bscnat 4244 \ -# "$MANUAL_DIR/OsmoBSCNAT/chapters/counters_generated.adoc" \ -# "$MANUAL_DIR/OsmoBSCNAT/vty/nat_vty_reference.xml" +OSMO_BSCNAT_BRANCH=$COMMIT ./regen_doc.sh osmo-nitb 4244 \ + "$MANUAL_DIR/OsmoBSCNAT/chapters/counters_generated.adoc" \ + "$MANUAL_DIR/OsmoBSCNAT/vty/nat_vty_reference.xml" \ + "osmo-bsc_nat -c /data/osmo-bsc-nat.cfg" -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ice7f15192a57e2c964d07d364732af888972ba0f Gerrit-Change-Number: 14530 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 20:42:02 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Thu, 18 Jul 2019 20:42:02 +0000 Subject: Change in ...osmo-bts[master]: manuals: Add counter documentation In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14524 ) Change subject: manuals: Add counter documentation ...................................................................... manuals: Add counter documentation Change-Id: I994ad6aae7f409e0f15ff1d388127e16243b378a Related: OS#1700 --- A doc/manuals/chapters/counters.adoc A doc/manuals/chapters/counters_generated.adoc M doc/manuals/osmobts-usermanual.adoc 3 files changed, 72 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/doc/manuals/chapters/counters.adoc b/doc/manuals/chapters/counters.adoc new file mode 100644 index 0000000..7fbb10c --- /dev/null +++ b/doc/manuals/chapters/counters.adoc @@ -0,0 +1,4 @@ +[[counters]] +== Counters + +include::./counters_generated.adoc[] diff --git a/doc/manuals/chapters/counters_generated.adoc b/doc/manuals/chapters/counters_generated.adoc new file mode 100644 index 0000000..6a37ffa --- /dev/null +++ b/doc/manuals/chapters/counters_generated.adoc @@ -0,0 +1,64 @@ + +// autogenerated by show asciidoc counters +These counters and their description based on OsmoBTS 0.8.1.346-33ed (OsmoBTS). + +=== Rate Counters + +// generating tables for rate_ctr_group +// rate_ctr_group table E1 Input subsystem +.e1inp - E1 Input subsystem +[options="header"] +|=== +| Name | Reference | Description +| hdlc:abort | <> | HDLC abort +| hdlc:bad_fcs | <> | HLDC Bad FCS +| hdlc:overrun | <> | HDLC Overrun +| alarm | <> | Alarm +| removed | <> | Line removed +|=== +// rate_ctr_group table cell broadcast channel +.cbch - cell broadcast channel +[options="header"] +|=== +| Name | Reference | Description +| cbch:rcvd_queued | <> | Received + queued CBCH messages (Abis) +| cbch:rcvd_dropped | <> | Received + dropped CBCH messages (Abis) +| cbch:sent_single | <> | Sent single CBCH messages (Um) +| cbch:sent_default | <> | Sent default CBCH messages (Um) +| cbch:sent_null | <> | Sent NULL CBCH messages (Um) +|=== +// rate_ctr_group table cell broadcast channel +.cbch - cell broadcast channel +[options="header"] +|=== +| Name | Reference | Description +| cbch:rcvd_queued | <> | Received + queued CBCH messages (Abis) +| cbch:rcvd_dropped | <> | Received + dropped CBCH messages (Abis) +| cbch:sent_single | <> | Sent single CBCH messages (Um) +| cbch:sent_default | <> | Sent default CBCH messages (Um) +| cbch:sent_null | <> | Sent NULL CBCH messages (Um) +|=== +// rate_ctr_group table base transceiver station +.bts - base transceiver station +[options="header"] +|=== +| Name | Reference | Description +| paging:rcvd | <> | Received paging requests (Abis) +| paging:drop | <> | Dropped paging requests (Abis) +| paging:sent | <> | Sent paging requests (Um) +| rach:rcvd | <> | Received RACH requests (Um) +| rach:drop | <> | Dropped RACH requests (Um) +| rach:handover | <> | Received RACH requests (Handover) +| rach:cs | <> | Received RACH requests (CS/Abis) +| rach:ps | <> | Received RACH requests (PS/PCU) +| agch:rcvd | <> | Received AGCH requests (Abis) +| agch:sent | <> | Sent AGCH requests (Abis) +| agch:delete | <> | Sent AGCH DELETE IND (Abis) +|=== +== Osmo Stat Items + +// generating tables for osmo_stat_items +== Osmo Counters + +// generating tables for osmo_counters +// there are no ungrouped osmo_counters diff --git a/doc/manuals/osmobts-usermanual.adoc b/doc/manuals/osmobts-usermanual.adoc index 40db72b..55087b2 100644 --- a/doc/manuals/osmobts-usermanual.adoc +++ b/doc/manuals/osmobts-usermanual.adoc @@ -14,6 +14,10 @@ include::{srcdir}/chapters/control.adoc[] +include::./common/chapters/counters-overview.adoc[] + +include::{srcdir}/chapters/counters.adoc[] + include::./common/chapters/vty.adoc[] include::./common/chapters/logging.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I994ad6aae7f409e0f15ff1d388127e16243b378a Gerrit-Change-Number: 14524 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Thu Jul 18 22:25:38 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 18 Jul 2019 22:25:38 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d30f200ad1cc_1ae28886006662fd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 607s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 607s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 607s] collect2: error: ld returned 1 exit status [ 607s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 607s] make[4]: *** [osmo-bts-virtual] Error 1 [ 607s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 607s] Makefile:385: recipe for target 'all-recursive' failed [ 607s] make[3]: *** [all-recursive] Error 1 [ 607s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 607s] Makefile:434: recipe for target 'all-recursive' failed [ 607s] make[2]: *** [all-recursive] Error 1 [ 607s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 607s] Makefile:366: recipe for target 'all' failed [ 607s] make[1]: *** [all] Error 2 [ 607s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 607s] dh_auto_build: make -j1 returned exit code 2 [ 607s] debian/rules:12: recipe for target 'build' failed [ 607s] make: *** [build] Error 2 [ 607s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 607s] [ 607s] obs-arm-6 failed "build osmo-bts_0.8.1.345.2131.dsc" at Thu Jul 18 22:25:24 UTC 2019. [ 607s] [ 607s] ### VM INTERACTION START ### [ 610s] [ 568.672604] sysrq: SysRq : Power Off [ 610s] [ 568.690873] reboot: Power down [ 611s] ### VM INTERACTION END ### [ 611s] [ 611s] obs-arm-6 failed "build osmo-bts_0.8.1.345.2131.dsc" at Thu Jul 18 22:25:28 UTC 2019. [ 611s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Thu Jul 18 22:29:21 2019 From: admin at opensuse.org (OBS Notification) Date: Thu, 18 Jul 2019 22:29:21 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d30f2d0612ea_1ae28886006669c1@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 136s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 136s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 136s] dh_installdocs [ 136s] dh_installchangelogs [ 136s] dh_python2 [ 136s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 136s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 136s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 136s] dh_python3 [ 137s] debian/rules override_dh_installinit [ 137s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 137s] # Install service file with different name than package name: [ 137s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 137s] dh_installinit --name=osmo-ctrl2cgi [ 137s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script nor default file not found [ 137s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 137s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 137s] make: *** [debian/rules:4: binary] Error 2 [ 137s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 137s] [ 137s] lamb17 failed "build osmo-python-tests_0.0.9.20190718.dsc" at Thu Jul 18 22:29:09 UTC 2019. [ 137s] [ 137s] ### VM INTERACTION START ### [ 140s] [ 126.037402] sysrq: SysRq : Power Off [ 140s] [ 126.043228] reboot: Power down [ 140s] ### VM INTERACTION END ### [ 140s] [ 140s] lamb17 failed "build osmo-python-tests_0.0.9.20190718.dsc" at Thu Jul 18 22:29:13 UTC 2019. [ 140s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Thu Jul 18 22:48:08 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Jul 2019 22:48:08 +0000 Subject: Change in ...osmo-bsc[master]: turn -Werror=null-dereference into a warning Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14833 Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Change-Id: I571a85b6ea53af7661248afd84e61cf34b7b5641 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/33/14833/1 diff --git a/configure.ac b/configure.ac index cdee90c..72b966f 100644 --- a/configure.ac +++ b/configure.ac @@ -117,7 +117,7 @@ AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"]) +AX_CHECK_COMPILE_FLAG([-Wenull-dereference], [CFLAGS="$CFLAGS -Wenull-dereference"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14833 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I571a85b6ea53af7661248afd84e61cf34b7b5641 Gerrit-Change-Number: 14833 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 22:48:53 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Jul 2019 22:48:53 +0000 Subject: Change in ...osmo-sgsn[master]: turn -Werror=null-dereference into a warning Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Change-Id: I4d1219bf84d3b8dcaf925a60cf54abe733fba263 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/34/14834/1 diff --git a/configure.ac b/configure.ac index e72e9d6..a7f908a 100644 --- a/configure.ac +++ b/configure.ac @@ -116,7 +116,7 @@ AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"]) +AX_CHECK_COMPILE_FLAG([-Wenull-dereference], [CFLAGS="$CFLAGS -Wenull-dereference"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4d1219bf84d3b8dcaf925a60cf54abe733fba263 Gerrit-Change-Number: 14834 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 22:49:14 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Jul 2019 22:49:14 +0000 Subject: Change in ...osmo-msc[master]: turn -Werror=null-dereference into a warning Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14835 Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Change-Id: I615bb5be3671022c6b821575a61f945b50e8f2a5 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/35/14835/1 diff --git a/configure.ac b/configure.ac index a2dfa5b..e2e128e 100644 --- a/configure.ac +++ b/configure.ac @@ -117,7 +117,7 @@ AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"]) +AX_CHECK_COMPILE_FLAG([-Wenull-dereference], [CFLAGS="$CFLAGS -Wenull-dereference"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14835 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I615bb5be3671022c6b821575a61f945b50e8f2a5 Gerrit-Change-Number: 14835 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 22:49:25 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Jul 2019 22:49:25 +0000 Subject: Change in ...osmo-mgw[master]: turn -Werror=null-dereference into a warning Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14836 Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Change-Id: Ib157bd2e110b271dbe5ac928c98251e016477f56 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/36/14836/1 diff --git a/configure.ac b/configure.ac index a14c276..307c60f 100644 --- a/configure.ac +++ b/configure.ac @@ -79,7 +79,7 @@ AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"]) +AX_CHECK_COMPILE_FLAG([-Wenull-dereference], [CFLAGS="$CFLAGS -Wenull-dereference"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib157bd2e110b271dbe5ac928c98251e016477f56 Gerrit-Change-Number: 14836 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 22:51:56 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Jul 2019 22:51:56 +0000 Subject: Change in ...osmo-bsc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: Hoernchen has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/14833 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Change-Id: I571a85b6ea53af7661248afd84e61cf34b7b5641 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/33/14833/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14833 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I571a85b6ea53af7661248afd84e61cf34b7b5641 Gerrit-Change-Number: 14833 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 22:51:59 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Jul 2019 22:51:59 +0000 Subject: Change in ...osmo-sgsn[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: Hoernchen has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Change-Id: I4d1219bf84d3b8dcaf925a60cf54abe733fba263 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/34/14834/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4d1219bf84d3b8dcaf925a60cf54abe733fba263 Gerrit-Change-Number: 14834 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 22:52:02 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Jul 2019 22:52:02 +0000 Subject: Change in ...osmo-msc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: Hoernchen has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-msc/+/14835 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Change-Id: I615bb5be3671022c6b821575a61f945b50e8f2a5 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/35/14835/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14835 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I615bb5be3671022c6b821575a61f945b50e8f2a5 Gerrit-Change-Number: 14835 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 22:52:05 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Jul 2019 22:52:05 +0000 Subject: Change in ...osmo-mgw[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/14836 to look at the new patch set (#2). Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Change-Id: Ib157bd2e110b271dbe5ac928c98251e016477f56 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/36/14836/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib157bd2e110b271dbe5ac928c98251e016477f56 Gerrit-Change-Number: 14836 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 22:54:05 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Jul 2019 22:54:05 +0000 Subject: Change in ...osmo-bsc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: Hoernchen has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/osmo-bsc/+/14833 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Change-Id: I571a85b6ea53af7661248afd84e61cf34b7b5641 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/33/14833/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14833 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I571a85b6ea53af7661248afd84e61cf34b7b5641 Gerrit-Change-Number: 14833 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 22:54:08 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Jul 2019 22:54:08 +0000 Subject: Change in ...osmo-sgsn[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 to look at the new patch set (#3). Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Change-Id: I4d1219bf84d3b8dcaf925a60cf54abe733fba263 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/34/14834/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4d1219bf84d3b8dcaf925a60cf54abe733fba263 Gerrit-Change-Number: 14834 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 22:54:13 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Jul 2019 22:54:13 +0000 Subject: Change in ...osmo-msc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: Hoernchen has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/osmo-msc/+/14835 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Change-Id: I615bb5be3671022c6b821575a61f945b50e8f2a5 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/35/14835/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14835 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I615bb5be3671022c6b821575a61f945b50e8f2a5 Gerrit-Change-Number: 14835 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 18 22:54:17 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Thu, 18 Jul 2019 22:54:17 +0000 Subject: Change in ...osmo-mgw[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/14836 to look at the new patch set (#3). Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Change-Id: Ib157bd2e110b271dbe5ac928c98251e016477f56 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/36/14836/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib157bd2e110b271dbe5ac928c98251e016477f56 Gerrit-Change-Number: 14836 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Fri Jul 19 02:07:38 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 19 Jul 2019 02:07:38 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d3125fede50c_1ae28886007112f0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 1046s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 1046s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 1046s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 1047s] Makefile:442: recipe for target 'vlr.o' failed [ 1047s] make[4]: *** [vlr.o] Error 1 [ 1047s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 1047s] Makefile:422: recipe for target 'all-recursive' failed [ 1047s] make[3]: *** [all-recursive] Error 1 [ 1047s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 1047s] Makefile:462: recipe for target 'all-recursive' failed [ 1047s] make[2]: *** [all-recursive] Error 1 [ 1047s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1047s] Makefile:394: recipe for target 'all' failed [ 1047s] make[1]: *** [all] Error 2 [ 1047s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1047s] dh_auto_build: make -j1 returned exit code 2 [ 1047s] debian/rules:45: recipe for target 'build' failed [ 1047s] make: *** [build] Error 2 [ 1047s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 1047s] [ 1047s] obs-arm-6 failed "build osmo-msc_1.3.1.179.3a357d.dsc" at Fri Jul 19 02:07:23 UTC 2019. [ 1047s] [ 1047s] ### VM INTERACTION START ### [ 1050s] [ 994.854597] sysrq: SysRq : Power Off [ 1050s] [ 994.890427] reboot: Power down [ 1051s] ### VM INTERACTION END ### [ 1051s] [ 1051s] obs-arm-6 failed "build osmo-msc_1.3.1.179.3a357d.dsc" at Fri Jul 19 02:07:28 UTC 2019. [ 1051s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 19 02:40:13 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 19 Jul 2019 02:40:13 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d312d9dd6242_1ae2888600717263@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 298s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 298s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 298s] dh_installdocs [ 298s] dh_installchangelogs [ 299s] dh_python2 [ 299s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 299s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 299s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 299s] dh_python3 [ 299s] debian/rules override_dh_installinit [ 299s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 299s] # Install service file with different name than package name: [ 299s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 299s] dh_installinit --name=osmo-ctrl2cgi [ 299s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script nor default file not found [ 299s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 299s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 299s] make: *** [debian/rules:4: binary] Error 2 [ 299s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 299s] [ 299s] lamb51 failed "build osmo-python-tests_0.0.9.20190719.dsc" at Fri Jul 19 02:39:55 UTC 2019. [ 299s] [ 299s] ### VM INTERACTION START ### [ 302s] [ 264.563381] sysrq: SysRq : Power Off [ 302s] [ 264.591706] reboot: Power down [ 302s] ### VM INTERACTION END ### [ 302s] [ 302s] lamb51 failed "build osmo-python-tests_0.0.9.20190719.dsc" at Fri Jul 19 02:39:58 UTC 2019. [ 302s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 19 03:01:38 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 19 Jul 2019 03:01:38 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d3132a642f00_1ae2888600719276@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 1142s] | This file was extended by libosmocore config.status 1.1.0.82-00a55a, which was [ 1142s] | generated by GNU Autoconf 2.69. Invocation command line was [ 1142s] | [ 1142s] | CONFIG_FILES = [ 1142s] | CONFIG_HEADERS = [ 1142s] | CONFIG_LINKS = [ 1142s] | CONFIG_COMMANDS = [ 1142s] | $ ./config.status Doxyfile.core [ 1142s] | [ 1142s] | on obs-arm-5 [ 1142s] | [ 1142s] | config.status:1200: creating Doxyfile.core [ 1142s] [ 1142s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 1142s] make[1]: *** [override_dh_auto_test] Error 1 [ 1142s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1142s] debian/rules:15: recipe for target 'build' failed [ 1142s] make: *** [build] Error 2 [ 1142s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 1142s] [ 1142s] obs-arm-5 failed "build libosmocore_1.1.0.82.00a55a.dsc" at Fri Jul 19 03:01:21 UTC 2019. [ 1142s] [ 1142s] ### VM INTERACTION START ### [ 1144s] [ 1109.326470] sysrq: SysRq : Power Off [ 1144s] [ 1109.338732] reboot: Power down [ 1144s] ### VM INTERACTION END ### [ 1144s] [ 1144s] obs-arm-5 failed "build libosmocore_1.1.0.82.00a55a.dsc" at Fri Jul 19 03:01:24 UTC 2019. [ 1144s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 19 04:20:31 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 19 Jul 2019 04:20:31 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d31451038abc_1ae28886007374fd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 117s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 117s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 117s] dh_installdocs [ 117s] dh_installchangelogs [ 118s] dh_python2 [ 118s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 118s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 118s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 118s] dh_python3 [ 118s] debian/rules override_dh_installinit [ 118s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 118s] # Install service file with different name than package name: [ 118s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 118s] dh_installinit --name=osmo-ctrl2cgi [ 118s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script nor default file not found [ 118s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 118s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 118s] make: *** [debian/rules:4: binary] Error 2 [ 118s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 118s] [ 118s] lamb61 failed "build osmo-python-tests_0.0.9.20190719.dsc" at Fri Jul 19 04:20:21 UTC 2019. [ 118s] [ 118s] ### VM INTERACTION START ### [ 121s] [ 106.848250] sysrq: SysRq : Power Off [ 121s] [ 106.855524] reboot: Power down [ 121s] ### VM INTERACTION END ### [ 121s] [ 121s] lamb61 failed "build osmo-python-tests_0.0.9.20190719.dsc" at Fri Jul 19 04:20:24 UTC 2019. [ 121s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Jul 19 04:47:28 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 04:47:28 +0000 Subject: Change in ...osmo-sgsn[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14834/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14834/3//COMMIT_MSG at 10 PS3, Line 10: and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed having a more verbose explanation why what exactly cannot be fixed, would be useful. If you don't want to write it here, write the gory details into the related issue and link the issue from here ("Closes: OS#....). The latter should be done either way, as we have related bug reports. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4d1219bf84d3b8dcaf925a60cf54abe733fba263 Gerrit-Change-Number: 14834 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Fri, 19 Jul 2019 04:47:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 04:47:34 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 04:47:34 +0000 Subject: Change in ...osmo-bsc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14833 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... Patch Set 3: having a more verbose explanation why what exactly cannot be fixed, would be useful. If you don't want to write it here, write the gory details into the related issue and link the issue from here ("Closes: OS#....). The latter should be done either way, as we have related bug reports. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14833 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I571a85b6ea53af7661248afd84e61cf34b7b5641 Gerrit-Change-Number: 14833 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Fri, 19 Jul 2019 04:47:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 04:47:41 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 04:47:41 +0000 Subject: Change in ...osmo-mgw[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14836 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... Patch Set 3: having a more verbose explanation why what exactly cannot be fixed, would be useful. If you don't want to write it here, write the gory details into the related issue and link the issue from here ("Closes: OS#....). The latter should be done either way, as we have related bug reports. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib157bd2e110b271dbe5ac928c98251e016477f56 Gerrit-Change-Number: 14836 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Fri, 19 Jul 2019 04:47:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 05:05:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 05:05:16 +0000 Subject: Change in ...osmo-bsc[master]: vty: Fix typo in VTY command descrption -> description Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14837 Change subject: vty: Fix typo in VTY command descrption -> description ...................................................................... vty: Fix typo in VTY command descrption -> description Let's add deprecated aliases for backwards compatibility Change-Id: I0e5da9d702910cf2571486e22a56f3ec17d0d67b --- M doc/examples/osmo-bsc/osmo-bsc.cfg M doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg M doc/manuals/vty/bsc_vty_reference.xml M doc/manuals/vty/libbsc_vty_additions.xml M src/osmo-bsc/bsc_vty.c 5 files changed, 42 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/37/14837/1 diff --git a/doc/examples/osmo-bsc/osmo-bsc.cfg b/doc/examples/osmo-bsc/osmo-bsc.cfg index 926951b..77b6094 100644 --- a/doc/examples/osmo-bsc/osmo-bsc.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc.cfg @@ -32,9 +32,9 @@ channel allocator ascending rach tx integer 9 rach max transmission 7 - channel-descrption attach 1 - channel-descrption bs-pa-mfrms 5 - channel-descrption bs-ag-blks-res 1 + channel-description attach 1 + channel-description bs-pa-mfrms 5 + channel-description bs-ag-blks-res 1 early-classmark-sending forbidden ipa unit-id 0 0 oml ipa stream-id 255 line 0 diff --git a/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg b/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg index 80a38ba..c250fac 100644 --- a/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg @@ -31,9 +31,9 @@ channel allocator ascending rach tx integer 9 rach max transmission 7 - channel-descrption attach 1 - channel-descrption bs-pa-mfrms 5 - channel-descrption bs-ag-blks-res 1 + channel-description attach 1 + channel-description bs-pa-mfrms 5 + channel-description bs-ag-blks-res 1 early-classmark-sending forbidden ipa unit-id 0 0 oml ipa stream-id 255 line 0 diff --git a/doc/manuals/vty/bsc_vty_reference.xml b/doc/manuals/vty/bsc_vty_reference.xml index db4f2c1..85c0cb7 100644 --- a/doc/manuals/vty/bsc_vty_reference.xml +++ b/doc/manuals/vty/bsc_vty_reference.xml @@ -2983,24 +2983,24 @@ - + - + - + - + - + - + diff --git a/doc/manuals/vty/libbsc_vty_additions.xml b/doc/manuals/vty/libbsc_vty_additions.xml index cf61961..dbf4080 100644 --- a/doc/manuals/vty/libbsc_vty_additions.xml +++ b/doc/manuals/vty/libbsc_vty_additions.xml @@ -34,7 +34,7 @@ Only applies to Ericsson OML2000 based BTSs. - + Configure whether the IMSI ATTACH (and DETACH) procedures shall be used by MS in this cell. The default should be enabled. @@ -160,7 +160,7 @@ 0) - which is also the default configuration. - + Using this command, you can specify how many blocks of the downlink CCCH should be reserved for exclusive usage as AGCH. diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index 24f8313..b19c950 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -841,11 +841,11 @@ rach_max_trans_raw2val(bts->si_common.rach_control.max_trans), VTY_NEWLINE); - vty_out(vty, " channel-descrption attach %u%s", + vty_out(vty, " channel-description attach %u%s", bts->si_common.chan_desc.att, VTY_NEWLINE); - vty_out(vty, " channel-descrption bs-pa-mfrms %u%s", + vty_out(vty, " channel-description bs-pa-mfrms %u%s", bts->si_common.chan_desc.bs_pa_mfrms + 2, VTY_NEWLINE); - vty_out(vty, " channel-descrption bs-ag-blks-res %u%s", + vty_out(vty, " channel-description bs-ag-blks-res %u%s", bts->si_common.chan_desc.bs_ag_blks_res, VTY_NEWLINE); if (bts->ccch_load_ind_thresh != 10) @@ -2420,7 +2420,7 @@ DEFUN(cfg_bts_chan_desc_att, cfg_bts_chan_desc_att_cmd, - "channel-descrption attach (0|1)", + "channel-description attach (0|1)", CD_STR "Set if attachment is required\n" "Attachment is NOT required\n" @@ -2430,10 +2430,17 @@ bts->si_common.chan_desc.att = atoi(argv[0]); return CMD_SUCCESS; } +ALIAS_DEPRECATED(cfg_bts_chan_desc_att, + cfg_bts_chan_dscr_att_cmd, + "channel-descrption attach (0|1)", + CD_STR + "Set if attachment is required\n" + "Attachment is NOT required\n" + "Attachment is required (standard)\n"); DEFUN(cfg_bts_chan_desc_bs_pa_mfrms, cfg_bts_chan_desc_bs_pa_mfrms_cmd, - "channel-descrption bs-pa-mfrms <2-9>", + "channel-description bs-pa-mfrms <2-9>", CD_STR "Set number of multiframe periods for paging groups\n" "Number of multiframe periods for paging groups\n") @@ -2444,10 +2451,16 @@ bts->si_common.chan_desc.bs_pa_mfrms = bs_pa_mfrms - 2; return CMD_SUCCESS; } +ALIAS_DEPRECATED(cfg_bts_chan_desc_bs_pa_mfrms, + cfg_bts_chan_dscr_bs_pa_mfrms_cmd, + "channel-descrption bs-pa-mfrms <2-9>", + CD_STR + "Set number of multiframe periods for paging groups\n" + "Number of multiframe periods for paging groups\n"); DEFUN(cfg_bts_chan_desc_bs_ag_blks_res, cfg_bts_chan_desc_bs_ag_blks_res_cmd, - "channel-descrption bs-ag-blks-res <0-7>", + "channel-description bs-ag-blks-res <0-7>", CD_STR "Set number of blocks reserved for access grant\n" "Number of blocks reserved for access grant\n") @@ -2458,6 +2471,12 @@ bts->si_common.chan_desc.bs_ag_blks_res = bs_ag_blks_res; return CMD_SUCCESS; } +ALIAS_DEPRECATED(cfg_bts_chan_desc_bs_ag_blks_res, + cfg_bts_chan_dscr_bs_ag_blks_res_cmd, + "channel-descrption bs-ag-blks-res <0-7>", + CD_STR + "Set number of blocks reserved for access grant\n" + "Number of blocks reserved for access grant\n"); #define CCCH_STR "Common Control Channel\n" @@ -5273,8 +5292,11 @@ install_element(BTS_NODE, &cfg_bts_rach_tx_integer_cmd); install_element(BTS_NODE, &cfg_bts_rach_max_trans_cmd); install_element(BTS_NODE, &cfg_bts_chan_desc_att_cmd); + install_element(BTS_NODE, &cfg_bts_chan_dscr_att_cmd); install_element(BTS_NODE, &cfg_bts_chan_desc_bs_pa_mfrms_cmd); + install_element(BTS_NODE, &cfg_bts_chan_dscr_bs_pa_mfrms_cmd); install_element(BTS_NODE, &cfg_bts_chan_desc_bs_ag_blks_res_cmd); + install_element(BTS_NODE, &cfg_bts_chan_dscr_bs_ag_blks_res_cmd); install_element(BTS_NODE, &cfg_bts_ccch_load_ind_thresh_cmd); install_element(BTS_NODE, &cfg_bts_rach_nm_b_thresh_cmd); install_element(BTS_NODE, &cfg_bts_rach_nm_ldavg_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0e5da9d702910cf2571486e22a56f3ec17d0d67b Gerrit-Change-Number: 14837 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 05:10:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 05:10:36 +0000 Subject: Change in ...libosmocore[master]: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14360 ) Change subject: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 Gerrit-Change-Number: 14360 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 19 Jul 2019 05:10:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 05:11:09 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 05:11:09 +0000 Subject: Change in ...libosmocore[master]: cbsp: Introduce osmo_cbsp_errstr In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14478 ) Change subject: cbsp: Introduce osmo_cbsp_errstr ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9a5a595a76ba278647aee9470ded213d8464103 Gerrit-Change-Number: 14478 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 05:11:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 08:31:31 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 08:31:31 +0000 Subject: Change in ...osmo-remsim[master]: rspro_server.c: Fix memory leak in processing inbound RSPRO In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14827 ) Change subject: rspro_server.c: Fix memory leak in processing inbound RSPRO ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14827 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I12b4a22854eea79c9e9c3e565dd4803e4dc0ed5a Gerrit-Change-Number: 14827 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: roh Gerrit-Comment-Date: Fri, 19 Jul 2019 08:31:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 08:31:49 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 08:31:49 +0000 Subject: Change in ...osmo-remsim[master]: remsim_client: Fix memory leak receiving RSPRO messages In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14829 ) Change subject: remsim_client: Fix memory leak receiving RSPRO messages ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic3b5b7b03d557557a245fcd5c31bd687e11c7477 Gerrit-Change-Number: 14829 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: roh Gerrit-Comment-Date: Fri, 19 Jul 2019 08:31:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 08:42:55 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 08:42:55 +0000 Subject: Change in ...osmo-bsc[master]: vty: Fix typo in VTY command descrption -> description In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14837 ) Change subject: vty: Fix typo in VTY command descrption -> description ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0e5da9d702910cf2571486e22a56f3ec17d0d67b Gerrit-Change-Number: 14837 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 19 Jul 2019 08:42:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 09:44:32 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 09:44:32 +0000 Subject: Change in ...osmo-msc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14835 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... Patch Set 3: Why cannot they be fixed? which are those errors? Please provide more information, and/or link to a ticket. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14835 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I615bb5be3671022c6b821575a61f945b50e8f2a5 Gerrit-Change-Number: 14835 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 09:44:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 10:21:59 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 10:21:59 +0000 Subject: Change in ...libosmocore[master]: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14360 ) Change subject: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support ...................................................................... Patch Set 5: (7 comments) Some stuff from cbsp.c and gsm48049.c looks duplicated, or at least they look quite similar. https://gerrit.osmocom.org/#/c/14360/5/include/osmocom/gsm/cbsp.h File include/osmocom/gsm/cbsp.h: https://gerrit.osmocom.org/#/c/14360/5/include/osmocom/gsm/cbsp.h at 22 PS5, Line 22: struct llist_head list; Could add /* osmo_cbsp_cell_ent */ https://gerrit.osmocom.org/#/c/14360/5/include/osmocom/gsm/cbsp.h at 45 PS5, Line 45: struct llist_head list; Could add /* osmo_cbsp_loading_ent */ https://gerrit.osmocom.org/#/c/14360/5/include/osmocom/gsm/protocol/gsm_48_049.h File include/osmocom/gsm/protocol/gsm_48_049.h: https://gerrit.osmocom.org/#/c/14360/5/include/osmocom/gsm/protocol/gsm_48_049.h at 16 PS5, Line 16: #define CBSP_TCP_PORT 48049 Missing: /* 5.2 TCP/IP */ https://gerrit.osmocom.org/#/c/14360/5/include/osmocom/gsm/protocol/gsm_48_049.h at 116 PS5, Line 116: /* not explicitly specified, but every message starts with those mandatory eleemnts */ typo: eleemnts https://gerrit.osmocom.org/#/c/14360/5/src/gsm/cbsp.c File src/gsm/cbsp.c: https://gerrit.osmocom.org/#/c/14360/5/src/gsm/cbsp.c at 39 PS5, Line 39: return msgb_alloc_headroom_c(ctx, 65535, 16, name); Wow, really, that long? https://gerrit.osmocom.org/#/c/14360/5/src/gsm/cbsp.c at 1303 PS5, Line 1303: #ifdef HAVE_SYS_SOCKET_H so if sys/socket.h is not available, then API osmo_cbsp_recv_buffered() is not present? sys/socket.h is only needed for recv(), isn't it? https://gerrit.osmocom.org/#/c/14360/5/src/gsm/gsm48049.c File src/gsm/gsm48049.c: https://gerrit.osmocom.org/#/c/14360/5/src/gsm/gsm48049.c at 211 PS5, Line 211: This looks wrong, code directly on the file, not inside any function? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 Gerrit-Change-Number: 14360 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 10:21:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 10:24:47 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 10:24:47 +0000 Subject: Change in ...osmo-bsc[master]: vty: Fix typo in VTY command descrption -> description In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14837 ) Change subject: vty: Fix typo in VTY command descrption -> description ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0e5da9d702910cf2571486e22a56f3ec17d0d67b Gerrit-Change-Number: 14837 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 10:24:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 10:41:07 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 10:41:07 +0000 Subject: Change in ...osmo-bsc[master]: vty: Fix typo in VTY command descrption -> description In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14837 ) Change subject: vty: Fix typo in VTY command descrption -> description ...................................................................... vty: Fix typo in VTY command descrption -> description Let's add deprecated aliases for backwards compatibility Change-Id: I0e5da9d702910cf2571486e22a56f3ec17d0d67b --- M doc/examples/osmo-bsc/osmo-bsc.cfg M doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg M doc/manuals/vty/bsc_vty_reference.xml M doc/manuals/vty/libbsc_vty_additions.xml M src/osmo-bsc/bsc_vty.c 5 files changed, 42 insertions(+), 20 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/doc/examples/osmo-bsc/osmo-bsc.cfg b/doc/examples/osmo-bsc/osmo-bsc.cfg index 926951b..77b6094 100644 --- a/doc/examples/osmo-bsc/osmo-bsc.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc.cfg @@ -32,9 +32,9 @@ channel allocator ascending rach tx integer 9 rach max transmission 7 - channel-descrption attach 1 - channel-descrption bs-pa-mfrms 5 - channel-descrption bs-ag-blks-res 1 + channel-description attach 1 + channel-description bs-pa-mfrms 5 + channel-description bs-ag-blks-res 1 early-classmark-sending forbidden ipa unit-id 0 0 oml ipa stream-id 255 line 0 diff --git a/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg b/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg index 80a38ba..c250fac 100644 --- a/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc_custom-sccp.cfg @@ -31,9 +31,9 @@ channel allocator ascending rach tx integer 9 rach max transmission 7 - channel-descrption attach 1 - channel-descrption bs-pa-mfrms 5 - channel-descrption bs-ag-blks-res 1 + channel-description attach 1 + channel-description bs-pa-mfrms 5 + channel-description bs-ag-blks-res 1 early-classmark-sending forbidden ipa unit-id 0 0 oml ipa stream-id 255 line 0 diff --git a/doc/manuals/vty/bsc_vty_reference.xml b/doc/manuals/vty/bsc_vty_reference.xml index db4f2c1..85c0cb7 100644 --- a/doc/manuals/vty/bsc_vty_reference.xml +++ b/doc/manuals/vty/bsc_vty_reference.xml @@ -2983,24 +2983,24 @@ - + - + - + - + - + - + diff --git a/doc/manuals/vty/libbsc_vty_additions.xml b/doc/manuals/vty/libbsc_vty_additions.xml index cf61961..dbf4080 100644 --- a/doc/manuals/vty/libbsc_vty_additions.xml +++ b/doc/manuals/vty/libbsc_vty_additions.xml @@ -34,7 +34,7 @@ Only applies to Ericsson OML2000 based BTSs. - + Configure whether the IMSI ATTACH (and DETACH) procedures shall be used by MS in this cell. The default should be enabled. @@ -160,7 +160,7 @@ 0) - which is also the default configuration. - + Using this command, you can specify how many blocks of the downlink CCCH should be reserved for exclusive usage as AGCH. diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index 24f8313..b19c950 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -841,11 +841,11 @@ rach_max_trans_raw2val(bts->si_common.rach_control.max_trans), VTY_NEWLINE); - vty_out(vty, " channel-descrption attach %u%s", + vty_out(vty, " channel-description attach %u%s", bts->si_common.chan_desc.att, VTY_NEWLINE); - vty_out(vty, " channel-descrption bs-pa-mfrms %u%s", + vty_out(vty, " channel-description bs-pa-mfrms %u%s", bts->si_common.chan_desc.bs_pa_mfrms + 2, VTY_NEWLINE); - vty_out(vty, " channel-descrption bs-ag-blks-res %u%s", + vty_out(vty, " channel-description bs-ag-blks-res %u%s", bts->si_common.chan_desc.bs_ag_blks_res, VTY_NEWLINE); if (bts->ccch_load_ind_thresh != 10) @@ -2420,7 +2420,7 @@ DEFUN(cfg_bts_chan_desc_att, cfg_bts_chan_desc_att_cmd, - "channel-descrption attach (0|1)", + "channel-description attach (0|1)", CD_STR "Set if attachment is required\n" "Attachment is NOT required\n" @@ -2430,10 +2430,17 @@ bts->si_common.chan_desc.att = atoi(argv[0]); return CMD_SUCCESS; } +ALIAS_DEPRECATED(cfg_bts_chan_desc_att, + cfg_bts_chan_dscr_att_cmd, + "channel-descrption attach (0|1)", + CD_STR + "Set if attachment is required\n" + "Attachment is NOT required\n" + "Attachment is required (standard)\n"); DEFUN(cfg_bts_chan_desc_bs_pa_mfrms, cfg_bts_chan_desc_bs_pa_mfrms_cmd, - "channel-descrption bs-pa-mfrms <2-9>", + "channel-description bs-pa-mfrms <2-9>", CD_STR "Set number of multiframe periods for paging groups\n" "Number of multiframe periods for paging groups\n") @@ -2444,10 +2451,16 @@ bts->si_common.chan_desc.bs_pa_mfrms = bs_pa_mfrms - 2; return CMD_SUCCESS; } +ALIAS_DEPRECATED(cfg_bts_chan_desc_bs_pa_mfrms, + cfg_bts_chan_dscr_bs_pa_mfrms_cmd, + "channel-descrption bs-pa-mfrms <2-9>", + CD_STR + "Set number of multiframe periods for paging groups\n" + "Number of multiframe periods for paging groups\n"); DEFUN(cfg_bts_chan_desc_bs_ag_blks_res, cfg_bts_chan_desc_bs_ag_blks_res_cmd, - "channel-descrption bs-ag-blks-res <0-7>", + "channel-description bs-ag-blks-res <0-7>", CD_STR "Set number of blocks reserved for access grant\n" "Number of blocks reserved for access grant\n") @@ -2458,6 +2471,12 @@ bts->si_common.chan_desc.bs_ag_blks_res = bs_ag_blks_res; return CMD_SUCCESS; } +ALIAS_DEPRECATED(cfg_bts_chan_desc_bs_ag_blks_res, + cfg_bts_chan_dscr_bs_ag_blks_res_cmd, + "channel-descrption bs-ag-blks-res <0-7>", + CD_STR + "Set number of blocks reserved for access grant\n" + "Number of blocks reserved for access grant\n"); #define CCCH_STR "Common Control Channel\n" @@ -5273,8 +5292,11 @@ install_element(BTS_NODE, &cfg_bts_rach_tx_integer_cmd); install_element(BTS_NODE, &cfg_bts_rach_max_trans_cmd); install_element(BTS_NODE, &cfg_bts_chan_desc_att_cmd); + install_element(BTS_NODE, &cfg_bts_chan_dscr_att_cmd); install_element(BTS_NODE, &cfg_bts_chan_desc_bs_pa_mfrms_cmd); + install_element(BTS_NODE, &cfg_bts_chan_dscr_bs_pa_mfrms_cmd); install_element(BTS_NODE, &cfg_bts_chan_desc_bs_ag_blks_res_cmd); + install_element(BTS_NODE, &cfg_bts_chan_dscr_bs_ag_blks_res_cmd); install_element(BTS_NODE, &cfg_bts_ccch_load_ind_thresh_cmd); install_element(BTS_NODE, &cfg_bts_rach_nm_b_thresh_cmd); install_element(BTS_NODE, &cfg_bts_rach_nm_ldavg_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0e5da9d702910cf2571486e22a56f3ec17d0d67b Gerrit-Change-Number: 14837 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 10:59:40 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 10:59:40 +0000 Subject: Change in ...libosmocore[master]: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14360 ) Change subject: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support ...................................................................... Patch Set 5: (1 comment) all of your comments adressed in the next version to be pushed in the next few minutes. https://gerrit.osmocom.org/#/c/14360/5/src/gsm/cbsp.c File src/gsm/cbsp.c: https://gerrit.osmocom.org/#/c/14360/5/src/gsm/cbsp.c at 39 PS5, Line 39: return msgb_alloc_headroom_c(ctx, 65535, 16, name); > Wow, really, that long? well, there can be many cells in a network (real-world GSM networks in Germany used to have something like ~ 8k cells, today with smaller cells likely many more). And most CBSP messages can contain arbitrary-length lists of cell identifiers... The 64k limit is due to the 16bit length field in the protocol. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 Gerrit-Change-Number: 14360 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 10:59:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:00:03 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 11:00:03 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: detectAnyBurst() family: Use struct to gather all out params In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14672 ) Change subject: sigProcLib: detectAnyBurst() family: Use struct to gather all out params ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I05cfa0ceaa2e633a5e6e404e2eae497ff4442dea Gerrit-Change-Number: 14672 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 19 Jul 2019 11:00:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:00:07 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 11:00:07 +0000 Subject: Change in ...libosmocore[master]: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14360 to look at the new patch set (#6). Change subject: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support ...................................................................... CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support This introduces definitions as well as a parser+encoder for the Cell Broadcast Service Protocol (CBSP) as specified in 3GPP TS 48.049. CBSP is used on the interface between CBC and BSC. Related: OS#3537 Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 --- M include/Makefile.am A include/osmocom/gsm/cbsp.h A include/osmocom/gsm/protocol/gsm_48_049.h M src/gsm/Makefile.am A src/gsm/cbsp.c A src/gsm/gsm48049.c M src/gsm/libosmogsm.map 7 files changed, 1,954 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/60/14360/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 Gerrit-Change-Number: 14360 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:02:03 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 11:02:03 +0000 Subject: Change in ...libosmocore[master]: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14360 ) Change subject: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/14360/5/src/gsm/cbsp.c File src/gsm/cbsp.c: https://gerrit.osmocom.org/#/c/14360/5/src/gsm/cbsp.c at 1303 PS5, Line 1303: #ifdef HAVE_SYS_SOCKET_H > so if sys/socket.h is not available, then API osmo_cbsp_recv_buffered() is not present? sys/socket. [?] yes, the code will be absent on builds without sys/socket.h, wich in practice are the 'bare iron' arm-none-eabi builds. And yes, it's about recv(). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 Gerrit-Change-Number: 14360 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 11:02:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:02:25 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 11:02:25 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: detectAnyBurst() family: Use struct to gather all out params In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14672 ) Change subject: sigProcLib: detectAnyBurst() family: Use struct to gather all out params ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I05cfa0ceaa2e633a5e6e404e2eae497ff4442dea Gerrit-Change-Number: 14672 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 19 Jul 2019 11:02:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:05:31 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 11:05:31 +0000 Subject: Change in ...osmo-trx[master]: Logger: global Log mutex is now available from C code In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14645 ) Change subject: Logger: global Log mutex is now available from C code ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I473e57479f8ae98a84ad00b76ff338f79f732236 Gerrit-Change-Number: 14645 Gerrit-PatchSet: 8 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 11:05:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:09:30 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 11:09:30 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move out TRXD socket send code to prepare for TRXDv1 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14646 ) Change subject: Transceiver: Move out TRXD socket send code to prepare for TRXDv1 ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed Gerrit-Change-Number: 14646 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 19 Jul 2019 11:09:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:12:11 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 11:12:11 +0000 Subject: Change in ...libosmocore[master]: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14360 ) Change subject: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support ...................................................................... Patch Set 6: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/14360/6/include/osmocom/gsm/protocol/gsm_48_049.h File include/osmocom/gsm/protocol/gsm_48_049.h: https://gerrit.osmocom.org/#/c/14360/6/include/osmocom/gsm/protocol/gsm_48_049.h at 119 PS6, Line 119: /* not explicitly specified, but every message starts with those mandatory eleemnts */ Typo not fixed. https://gerrit.osmocom.org/#/c/14360/6/src/gsm/gsm48049.c File src/gsm/gsm48049.c: https://gerrit.osmocom.org/#/c/14360/6/src/gsm/gsm48049.c at 112 PS6, Line 112: Not sure if there's a bug with gerrit here, but I used to see more stuff behind, and after adding my comment I was unable to see it? or maybe I'm confused myself I don't know. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 Gerrit-Change-Number: 14360 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 11:12:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:15:19 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 11:15:19 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support TRXD v1 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14657 ) Change subject: Transceiver: Support TRXD v1 ...................................................................... Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 11 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 11:15:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:43:43 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 11:43:43 +0000 Subject: Change in ...osmo-trx[master]: Logger: global Log mutex is now available from C code In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14645 ) Change subject: Logger: global Log mutex is now available from C code ...................................................................... Patch Set 8: Code-Review+2 +1+1=+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I473e57479f8ae98a84ad00b76ff338f79f732236 Gerrit-Change-Number: 14645 Gerrit-PatchSet: 8 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 11:43:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:43:51 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 11:43:51 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move out TRXD socket send code to prepare for TRXDv1 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14646 ) Change subject: Transceiver: Move out TRXD socket send code to prepare for TRXDv1 ...................................................................... Patch Set 9: Code-Review+2 +1+1=+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed Gerrit-Change-Number: 14646 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 11:43:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:44:01 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 11:44:01 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support SETFORMAT command In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14665 ) Change subject: Transceiver: Support SETFORMAT command ...................................................................... Patch Set 8: Code-Review+2 +1+1=+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9fc22f9987238a5ff870df7718de4efc9e04289 Gerrit-Change-Number: 14665 Gerrit-PatchSet: 8 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 11:44:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:44:13 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 11:44:13 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: detectAnyBurst() family: Use struct to gather all out params In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14672 ) Change subject: sigProcLib: detectAnyBurst() family: Use struct to gather all out params ...................................................................... sigProcLib: detectAnyBurst() family: Use struct to gather all out params Currently we have 2 out parameters, but in forthcoming commits will add a third one. All those functions already have too many parameters, so let's put together all the output params in a struct to pass them easily and make it easier to understand they are the estimated output values. Related: OS#4006 Change-Id: I05cfa0ceaa2e633a5e6e404e2eae497ff4442dea --- M Transceiver52M/Transceiver.cpp M Transceiver52M/sigProcLib.cpp M Transceiver52M/sigProcLib.h 3 files changed, 45 insertions(+), 45 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 4462cdd..5c5707b 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -575,8 +575,8 @@ bool Transceiver::pullRadioVector(size_t chan, struct trx_ul_burst_ind *bi) { int rc; - complex amp; - float toa, max = -1.0, avg = 0.0; + struct estim_burst_params ebp; + float max = -1.0, avg = 0.0; unsigned max_toa; int max_i = -1; signalVector *burst; @@ -654,7 +654,7 @@ mMaxExpectedDelayAB : mMaxExpectedDelayNB; /* Detect normal or RACH bursts */ - rc = detectAnyBurst(*burst, mTSC, BURST_THRESH, mSPSRx, type, amp, toa, max_toa); + rc = detectAnyBurst(*burst, mTSC, BURST_THRESH, mSPSRx, type, max_toa, &ebp); if (rc <= 0) { if (rc == -SIGERR_CLIP) LOG(WARNING) << "Clipping detected on received RACH or Normal Burst"; @@ -664,8 +664,8 @@ } type = (CorrType) rc; - bi->toa = toa; - rxBurst = demodAnyBurst(*burst, mSPSRx, amp, toa, type); + bi->toa = ebp.toa; + rxBurst = demodAnyBurst(*burst, mSPSRx, ebp.amp, ebp.toa, type); /* EDGE demodulator returns 444 (gSlotLen * 3) bits */ if (rxBurst->size() == EDGE_BURST_NBITS) diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp index cff7825..52a6701 100644 --- a/Transceiver52M/sigProcLib.cpp +++ b/Transceiver52M/sigProcLib.cpp @@ -1463,8 +1463,8 @@ */ static int detectBurst(const signalVector &burst, signalVector &corr, CorrelationSequence *sync, - float thresh, int sps, complex *amp, float *toa, - int start, int len) + float thresh, int sps, int start, int len, + struct estim_burst_params *ebp) { const signalVector *corr_in; signalVector *dec = NULL; @@ -1490,23 +1490,23 @@ sps = 1; /* Peak detection - place restrictions at correlation edges */ - *amp = fastPeakDetect(corr, toa); + ebp->amp = fastPeakDetect(corr, &ebp->toa); - if ((*toa < 3 * sps) || (*toa > len - 3 * sps)) + if ((ebp->toa < 3 * sps) || (ebp->toa > len - 3 * sps)) return 0; /* Peak -to-average ratio */ - if (computePeakRatio(&corr, sps, *toa, *amp) < thresh) + if (computePeakRatio(&corr, sps, ebp->toa, ebp->amp) < thresh) return 0; /* Compute peak-to-average ratio. Reject if we don't have enough values */ - *amp = peakDetect(corr, toa, NULL); + ebp->amp = peakDetect(corr, &ebp->toa, NULL); /* Normalize our channel gain */ - *amp = *amp / sync->gain; + ebp->amp = ebp->amp / sync->gain; /* Compensate for residuate time lag */ - *toa = *toa - sync->toa; + ebp->toa = ebp->toa - sync->toa; return 1; } @@ -1532,13 +1532,10 @@ * head: Search symbols before target * tail: Search symbols after target */ -static int detectGeneralBurst(const signalVector &rxBurst, - float thresh, - int sps, - complex &, - float &toa, +static int detectGeneralBurst(const signalVector &rxBurst, float thresh, int sps, int target, int head, int tail, - CorrelationSequence *sync) + CorrelationSequence *sync, + struct estim_burst_params *ebp) { int rc, start, len; bool clipping = false; @@ -1560,17 +1557,17 @@ signalVector corr(len); rc = detectBurst(rxBurst, corr, sync, - thresh, sps, &, &toa, start, len); + thresh, sps, start, len, ebp); if (rc < 0) { return -SIGERR_INTERNAL; } else if (!rc) { - amp = 0.0f; - toa = 0.0f; + ebp->amp = 0.0f; + ebp->toa = 0.0f; return clipping?-SIGERR_CLIP:SIGERR_NONE; } /* Subtract forward search bits from delay */ - toa -= head; + ebp->toa -= head; return 1; } @@ -1585,7 +1582,7 @@ * tail: Search 8 symbols + maximum expected delay */ static int detectRACHBurst(const signalVector &burst, float threshold, int sps, - complex &litude, float &toa, unsigned max_toa, bool ext) + unsigned max_toa, bool ext, struct estim_burst_params *ebp) { int rc, target, head, tail; int i, num_seq; @@ -1596,8 +1593,8 @@ num_seq = ext ? 3 : 1; for (i = 0; i < num_seq; i++) { - rc = detectGeneralBurst(burst, threshold, sps, amplitude, toa, - target, head, tail, gRACHSequences[i]); + rc = detectGeneralBurst(burst, threshold, sps, target, head, tail, + gRACHSequences[i], ebp); if (rc > 0) break; } @@ -1614,7 +1611,7 @@ * tail: Search 6 symbols + maximum expected delay */ static int analyzeTrafficBurst(const signalVector &burst, unsigned tsc, float threshold, - int sps, complex &litude, float &toa, unsigned max_toa) + int sps, unsigned max_toa, struct estim_burst_params *ebp) { int rc, target, head, tail; CorrelationSequence *sync; @@ -1627,13 +1624,12 @@ tail = 6 + max_toa; sync = gMidambles[tsc]; - rc = detectGeneralBurst(burst, threshold, sps, amplitude, toa, - target, head, tail, sync); + rc = detectGeneralBurst(burst, threshold, sps, target, head, tail, sync, ebp); return rc; } static int detectEdgeBurst(const signalVector &burst, unsigned tsc, float threshold, - int sps, complex &litude, float &toa, unsigned max_toa) + int sps, unsigned max_toa, struct estim_burst_params *ebp) { int rc, target, head, tail; CorrelationSequence *sync; @@ -1646,33 +1642,30 @@ tail = 6 + max_toa; sync = gEdgeMidambles[tsc]; - rc = detectGeneralBurst(burst, threshold, sps, amplitude, toa, - target, head, tail, sync); + rc = detectGeneralBurst(burst, threshold, sps, + target, head, tail, sync, ebp); return rc; } int detectAnyBurst(const signalVector &burst, unsigned tsc, float threshold, - int sps, CorrType type, complex &, float &toa, - unsigned max_toa) + int sps, CorrType type, unsigned max_toa, + struct estim_burst_params *ebp) { int rc = 0; switch (type) { case EDGE: - rc = detectEdgeBurst(burst, tsc, threshold, sps, - amp, toa, max_toa); + rc = detectEdgeBurst(burst, tsc, threshold, sps, max_toa, ebp); if (rc > 0) break; else type = TSC; case TSC: - rc = analyzeTrafficBurst(burst, tsc, threshold, sps, - amp, toa, max_toa); + rc = analyzeTrafficBurst(burst, tsc, threshold, sps, max_toa, ebp); break; case EXT_RACH: case RACH: - rc = detectRACHBurst(burst, threshold, sps, amp, toa, - max_toa, type == EXT_RACH); + rc = detectRACHBurst(burst, threshold, sps, max_toa, type == EXT_RACH, ebp); break; default: LOG(ERR) << "Invalid correlation type"; diff --git a/Transceiver52M/sigProcLib.h b/Transceiver52M/sigProcLib.h index bae2127..8442cfc 100644 --- a/Transceiver52M/sigProcLib.h +++ b/Transceiver52M/sigProcLib.h @@ -101,15 +101,23 @@ */ float energyDetect(const signalVector &rxBurst, unsigned windowLength); + +/** Struct used to fill out parameters in detectAnyBurst(): estimated burst parameters + at param amplitude The estimated amplitude of received TSC burst. + at param toa The estimated time-of-arrival of received TSC burst (in symbols). +*/ +struct estim_burst_params { + complex amp; + float toa; +}; /** 8-PSK/GMSK/RACH burst detector @param burst The received GSM burst of interest @param tsc Midamble type (0..7) also known as TSC @param threshold The threshold that the received burst's post-correlator SNR is compared against to determine validity. @param sps The number of samples per GSM symbol. - @param amplitude The estimated amplitude of received TSC burst. - @param toa The estimate time-of-arrival of received TSC burst (in symbols). @param max_toa The maximum expected time-of-arrival (in symbols). + @param ebp The estimated parameters of the detected burst. @return positive value (CorrType) if threshold value is reached, negative value (-SignalError) on error, zero (SIGERR_NONE) if no burst is detected @@ -119,9 +127,8 @@ float threshold, int sps, CorrType type, - complex &, - float &toa, - unsigned max_toa); + unsigned max_toa, + struct estim_burst_params *ebp); /** Demodulate burst basde on type and output soft bits */ SoftVector *demodAnyBurst(const signalVector &burst, int sps, -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14672 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I05cfa0ceaa2e633a5e6e404e2eae497ff4442dea Gerrit-Change-Number: 14672 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:44:14 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 11:44:14 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: detectAnyBurst(): make TSC used to detect burst available... In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14673 ) Change subject: sigProcLib: detectAnyBurst(): make TSC used to detect burst available to caller ...................................................................... sigProcLib: detectAnyBurst(): make TSC used to detect burst available to caller This value will be sent in TRXDv1 protocol. Related: OS#4006 Change-Id: I603b7b52f957cf897b036dbaeb22c01a55de08c3 --- M Transceiver52M/sigProcLib.cpp M Transceiver52M/sigProcLib.h 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp index 52a6701..c22009a 100644 --- a/Transceiver52M/sigProcLib.cpp +++ b/Transceiver52M/sigProcLib.cpp @@ -1595,8 +1595,10 @@ for (i = 0; i < num_seq; i++) { rc = detectGeneralBurst(burst, threshold, sps, target, head, tail, gRACHSequences[i], ebp); - if (rc > 0) + if (rc > 0) { + ebp->tsc = i; break; + } } return rc; @@ -1624,6 +1626,7 @@ tail = 6 + max_toa; sync = gMidambles[tsc]; + ebp->tsc = tsc; rc = detectGeneralBurst(burst, threshold, sps, target, head, tail, sync, ebp); return rc; } @@ -1642,6 +1645,7 @@ tail = 6 + max_toa; sync = gEdgeMidambles[tsc]; + ebp->tsc = tsc; rc = detectGeneralBurst(burst, threshold, sps, target, head, tail, sync, ebp); return rc; diff --git a/Transceiver52M/sigProcLib.h b/Transceiver52M/sigProcLib.h index 8442cfc..6d4ca9b 100644 --- a/Transceiver52M/sigProcLib.h +++ b/Transceiver52M/sigProcLib.h @@ -105,10 +105,12 @@ /** Struct used to fill out parameters in detectAnyBurst(): estimated burst parameters @param amplitude The estimated amplitude of received TSC burst. @param toa The estimated time-of-arrival of received TSC burst (in symbols). + at param tsc The TSC used to detect the burst. */ struct estim_burst_params { complex amp; float toa; + uint8_t tsc; }; /** 8-PSK/GMSK/RACH burst detector -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14673 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I603b7b52f957cf897b036dbaeb22c01a55de08c3 Gerrit-Change-Number: 14673 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:44:14 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 11:44:14 +0000 Subject: Change in ...osmo-trx[master]: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14674 ) Change subject: sigProcLib: Add C/I (Carrier-to-Interference ratio) computation ...................................................................... sigProcLib: Add C/I (Carrier-to-Interference ratio) computation Related: OS#4006 Change-Id: Ib4ceec553f2e5f77bf3f6777724968456a180f5e --- M Transceiver52M/sigProcLib.cpp M Transceiver52M/sigProcLib.h 2 files changed, 51 insertions(+), 13 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp index c22009a..860bbe4 100644 --- a/Transceiver52M/sigProcLib.cpp +++ b/Transceiver52M/sigProcLib.cpp @@ -1454,6 +1454,33 @@ }; /* + * Computes C/I (Carrier-to-Interference ratio) in dB (deciBels). + * It is computed from the training sequence of each received burst, + * by comparing the "ideal" training sequence with the actual one. + */ +static float computeCI(const signalVector *burst, CorrelationSequence *sync, + float toa, int start, complex xcorr) +{ + float S, C; + int ps; + + /* Integer position where the sequence starts */ + ps = start + 1 - sync->sequence->size() + (int)roundf(toa); + + /* Estimate Signal power */ + S = 0.0f; + for (int i=0, j=ps; i<(int)sync->sequence->size(); i++,j++) + S += (*burst)[j].norm2(); + S /= sync->sequence->size(); + + /* Esimate Carrier power */ + C = xcorr.norm2() / ((sync->sequence->size() - 1) * sync->gain.abs()); + + /* Interference = Signal - Carrier, so C/I = C / (S - C) */ + return 3.0103f * log2f(C / (S - C)); +} + +/* * Detect a burst based on correlation and peak-to-average ratio * * For one sampler-per-symbol, perform fast peak detection (no interpolation) @@ -1468,6 +1495,8 @@ { const signalVector *corr_in; signalVector *dec = NULL; + complex xcorr; + int rc = 1; if (sps == 4) { dec = downsampleBurst(burst); @@ -1480,35 +1509,42 @@ /* Correlate */ if (!convolve(corr_in, sync->sequence, &corr, CUSTOM, start, len)) { - delete dec; - return -1; + rc = -1; + goto del_ret; } - delete dec; - /* Running at the downsampled rate at this point */ sps = 1; /* Peak detection - place restrictions at correlation edges */ ebp->amp = fastPeakDetect(corr, &ebp->toa); - if ((ebp->toa < 3 * sps) || (ebp->toa > len - 3 * sps)) - return 0; + if ((ebp->toa < 3 * sps) || (ebp->toa > len - 3 * sps)) { + rc = 0; + goto del_ret; + } - /* Peak -to-average ratio */ - if (computePeakRatio(&corr, sps, ebp->toa, ebp->amp) < thresh) - return 0; + /* Peak-to-average ratio */ + if (computePeakRatio(&corr, sps, ebp->toa, ebp->amp) < thresh) { + rc = 0; + goto del_ret; + } - /* Compute peak-to-average ratio. Reject if we don't have enough values */ - ebp->amp = peakDetect(corr, &ebp->toa, NULL); + /* Refine TOA and correlation value */ + xcorr = peakDetect(corr, &ebp->toa, NULL); + + /* Compute C/I */ + ebp->ci = computeCI(corr_in, sync, ebp->toa, start, xcorr); /* Normalize our channel gain */ - ebp->amp = ebp->amp / sync->gain; + ebp->amp = xcorr / sync->gain; /* Compensate for residuate time lag */ ebp->toa = ebp->toa - sync->toa; - return 1; +del_ret: + delete dec; + return rc; } static float maxAmplitude(const signalVector &burst) @@ -1563,6 +1599,7 @@ } else if (!rc) { ebp->amp = 0.0f; ebp->toa = 0.0f; + ebp->ci = 0.0f; return clipping?-SIGERR_CLIP:SIGERR_NONE; } diff --git a/Transceiver52M/sigProcLib.h b/Transceiver52M/sigProcLib.h index 6d4ca9b..fd9a5f0 100644 --- a/Transceiver52M/sigProcLib.h +++ b/Transceiver52M/sigProcLib.h @@ -111,6 +111,7 @@ complex amp; float toa; uint8_t tsc; + float ci; }; /** 8-PSK/GMSK/RACH burst detector -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14674 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib4ceec553f2e5f77bf3f6777724968456a180f5e Gerrit-Change-Number: 14674 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Reviewer: tnt Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:44:15 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 11:44:15 +0000 Subject: Change in ...osmo-trx[master]: Logger: global Log mutex is now available from C code In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14645 ) Change subject: Logger: global Log mutex is now available from C code ...................................................................... Logger: global Log mutex is now available from C code This way the C++ logging API can still be used while allowing for C files to use the same mutex. Change-Id: I473e57479f8ae98a84ad00b76ff338f79f732236 --- M CommonLibs/Logger.cpp M CommonLibs/debug.c M CommonLibs/debug.h M Transceiver52M/osmo-trx.cpp 4 files changed, 79 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/CommonLibs/Logger.cpp b/CommonLibs/Logger.cpp index 171c635..f68fab5 100644 --- a/CommonLibs/Logger.cpp +++ b/CommonLibs/Logger.cpp @@ -35,8 +35,6 @@ using namespace std; -Mutex gLogToLock; - std::ostream& operator<<(std::ostream& os, std::ostringstream& ss) { return os << ss.str(); @@ -45,15 +43,13 @@ Log::~Log() { int old_state; - pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &old_state); int mlen = mStream.str().size(); int neednl = (mlen==0 || mStream.str()[mlen-1] != '\n'); const char *fmt = neednl ? "%s\n" : "%s"; - ScopedLock lock(gLogToLock); - // The COUT() macro prevents messages from stomping each other but adds uninteresting thread numbers, - // so just use std::cout. + + log_mutex_lock_canceldisable(&old_state); LOGPSRC(mCategory, mPriority, filename, line, fmt, mStream.str().c_str()); - pthread_setcancelstate(old_state, NULL); + log_mutex_unlock_canceldisable(old_state); } ostringstream& Log::get() diff --git a/CommonLibs/debug.c b/CommonLibs/debug.c index 294924d..17ef5bc 100644 --- a/CommonLibs/debug.c +++ b/CommonLibs/debug.c @@ -1,3 +1,5 @@ +#include + #include #include #include "debug.h" @@ -34,3 +36,49 @@ .cat = default_categories, .num_cat = ARRAY_SIZE(default_categories), }; + +pthread_mutex_t log_mutex; + +bool log_mutex_init() { + int rc; + pthread_mutexattr_t attr; + + if ((rc = pthread_mutexattr_init(&attr))) { + fprintf(stderr, "pthread_mutexattr_init() failed: %d\n", rc); + return false; + } + if ((rc = pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE))) { + fprintf(stderr, "pthread_mutexattr_settype() failed: %d\n", rc); + return false; + } + if ((rc = pthread_mutex_init(&log_mutex, &attr))) { + fprintf(stderr, "pthread_mutex_init() failed: %d\n", rc); + return false; + } + if ((rc = pthread_mutexattr_destroy(&attr))) { + fprintf(stderr, "pthread_mutexattr_destroy() failed: %d\n", rc); + return false; + } + return true; + /* FIXME: do we need to call pthread_mutex_destroy() during process exit? */ +} + +/* If called inside a C++ destructor, use log_mutex_(un)lock_canceldisable() APIs instead. + See osmo-trx commit 86be40b4eb762d5c12e8e3f7388ca9f254e77b36 for more information */ +void log_mutex_lock() { + OSMO_ASSERT(!pthread_mutex_lock(&log_mutex)); +} + +void log_mutex_unlock() { + OSMO_ASSERT(!pthread_mutex_unlock(&log_mutex)); +} + +void log_mutex_lock_canceldisable(int *st) { + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, st); + log_mutex_lock(); +} + +void log_mutex_unlock_canceldisable(int st) { + log_mutex_unlock(); + pthread_setcancelstate(st, NULL); +} diff --git a/CommonLibs/debug.h b/CommonLibs/debug.h index a5b9271..760ab32 100644 --- a/CommonLibs/debug.h +++ b/CommonLibs/debug.h @@ -1,5 +1,10 @@ #pragma once +#include +#include + +#include + extern const struct log_info log_info; /* Debug Areas of the code */ @@ -9,3 +14,22 @@ DDEV, DLMS, }; + + +bool log_mutex_init(); +void log_mutex_lock(); +void log_mutex_unlock(); +void log_mutex_lock_canceldisable(int *st); +void log_mutex_unlock_canceldisable(int st); + +#define CLOGC(category, level, fmt, args...) do { \ + log_mutex_lock(); \ + LOGP(category, level, "[tid=%lu] " fmt, pthread_self(), ##args); \ + log_mutex_unlock(); \ +} while(0) + +#define CLOGCHAN(chan, category, level, fmt, args...) do { \ + log_mutex_lock(); \ + LOGP(category, level, "[tid=%lu][chan=%lu] " fmt, pthread_self(), chan, ##args); \ + log_mutex_unlock(); \ +} while(0) diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index b8cf968..8a3f1e3 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -569,6 +569,10 @@ #endif #endif + if (!log_mutex_init()) { + fprintf(stderr, "Failed to initialize log mutex!\n"); + exit(2); + } convolve_init(); convert_init(); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I473e57479f8ae98a84ad00b76ff338f79f732236 Gerrit-Change-Number: 14645 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:44:15 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 11:44:15 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Move out TRXD socket send code to prepare for TRXDv1 In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14646 ) Change subject: Transceiver: Move out TRXD socket send code to prepare for TRXDv1 ...................................................................... Transceiver: Move out TRXD socket send code to prepare for TRXDv1 Only old v0 is supported so far. TRXD protocol related data/logic is moved to its own file out of Transceiver class. Code is refactored so it can be re-used later by TRXDv1. Related: OS#4006 Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed --- M Transceiver52M/Makefile.am M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h A Transceiver52M/proto_trxd.c M Transceiver52M/proto_trxd.h 5 files changed, 128 insertions(+), 54 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/Makefile.am b/Transceiver52M/Makefile.am index 4adf474..791c586 100644 --- a/Transceiver52M/Makefile.am +++ b/Transceiver52M/Makefile.am @@ -47,7 +47,8 @@ Transceiver.cpp \ ChannelizerBase.cpp \ Channelizer.cpp \ - Synthesis.cpp + Synthesis.cpp \ + proto_trxd.c libtransceiver_common_la_SOURCES = \ $(COMMON_SOURCES) \ diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 5c5707b..6bbf3a3 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -31,7 +31,7 @@ #include "osmo_signal.h" #include "proto_trxd.h" -#include +#include #include } @@ -125,7 +125,7 @@ rssiOffset(wRssiOffset), stackSize(wStackSize), mSPSTx(tx_sps), mSPSRx(rx_sps), mChans(chans), mEdge(false), mOn(false), mForceClockInterface(false), mTxFreq(0.0), mRxFreq(0.0), mTSC(0), mMaxExpectedDelayAB(0), mMaxExpectedDelayNB(0), - mWriteBurstToDiskMask(0) + mWriteBurstToDiskMask(0), mVersionTRXD(0) { txFullScale = mRadioInterface->fullScaleInputValue(); rxFullScale = mRadioInterface->fullScaleOutputValue(); @@ -971,36 +971,20 @@ void Transceiver::driveReceiveFIFO(size_t chan) { - int msgLen; - int TOAint; // in 1/256 symbols - struct trx_ul_burst_ind bi; - if (!pullRadioVector(chan, &bi) || bi.idle) + if (!pullRadioVector(chan, &bi)) return; + if (!bi.idle) + logRxBurst(chan, &bi); - logRxBurst(chan, &bi); - - TOAint = (int) (bi.toa * 256.0 + 0.5); // round to closest integer - - char burstString[sizeof(struct trxd_hdr_v0) + bi.nbits + 2]; - struct trxd_hdr_v0* pkt = (struct trxd_hdr_v0*)burstString; - pkt->common.version = 0; - pkt->common.reserved = 0; - pkt->common.tn = bi.tn; - osmo_store32be(bi.fn, &pkt->common.fn); - pkt->v0.rssi = bi.rssi; - osmo_store16be(TOAint, &pkt->v0.toa); - - for (unsigned i = 0; i < bi.nbits; i++) - pkt->soft_bits[i] = (char) round(bi.rx_burst[i] * 255.0); - - /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi.nbits] */ - pkt->soft_bits[bi.nbits + 1] = '\0'; - - msgLen = write(mDataSockets[chan], burstString, sizeof(struct trxd_hdr_v0) + bi.nbits + 2); - if (msgLen <= 0) - LOGCHAN(chan, DTRXCTRL, WARNING) << "mDataSockets write(" << mCtrlSockets[chan] << ") failed: " << msgLen; + switch (mVersionTRXD) { + case 0: + trxd_send_burst_ind_v0(chan, mDataSockets[chan], &bi); + break; + default: + OSMO_ASSERT(false); + } } void Transceiver::driveTxFIFO() diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index a66c962..aa2a716 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -34,19 +34,6 @@ #include "config_defs.h" } -#define MAX_RX_BURST_BUF_SIZE EDGE_BURST_NBITS - -struct trx_ul_burst_ind { - float rx_burst[MAX_RX_BURST_BUF_SIZE]; /* soft bits normalized 0..1 */ - unsigned nbits; // number of symbols per slot in rxBurst, not counting guard periods - uint32_t fn; // TDMA frame number - uint8_t tn; // TDMA time-slot number - double rssi; // in dBFS - double toa; // in symbols - double noise; // noise level in dBFS - bool idle; // true if no valid burst is included -}; - class Transceiver; /** Channel descriptor for transceiver object and channel number pair */ @@ -229,6 +216,7 @@ unsigned mMaxExpectedDelayAB; ///< maximum expected time-of-arrival offset in GSM symbols for Access Bursts (RACH) unsigned mMaxExpectedDelayNB; ///< maximum expected time-of-arrival offset in GSM symbols for Normal Bursts unsigned mWriteBurstToDiskMask; ///< debug: bitmask to indicate which timeslots to dump to disk + unsigned mVersionTRXD; ///< Format version to use for TRXD protocol communication std::vector mStates; diff --git a/Transceiver52M/proto_trxd.c b/Transceiver52M/proto_trxd.c new file mode 100644 index 0000000..5cf22e6 --- /dev/null +++ b/Transceiver52M/proto_trxd.c @@ -0,0 +1,77 @@ +/* + * Copyright (C) 2019 sysmocom - s.f.m.c. GmbH + * All Rights Reserved + * + * SPDX-License-Identifier: AGPL-3.0+ + * + * Author: Pau Espin Pedrol + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * See the COPYING file in the main directory for details. + */ + +#include "proto_trxd.h" + +#include + +static void trxd_fill_common(struct trxd_hdr_common *common, const struct trx_ul_burst_ind *bi, uint8_t version) +{ + common->version = version && 0x07; + common->reserved = 0; + common->tn = bi->tn; + osmo_store32be(bi->fn, &common->fn); +} + +static void trxd_fill_v0_specific(struct trxd_hdr_v0_specific *v0, const struct trx_ul_burst_ind *bi) +{ + int toa_int; + + /* in 1/256 symbols, round to closest integer */ + toa_int = (int) (bi->toa * 256.0 + 0.5); + v0->rssi = bi->rssi; + osmo_store16be(toa_int, &v0->toa); +} + +static void trxd_fill_burst_normalized255(uint8_t* soft_bits, const struct trx_ul_burst_ind *bi) +{ + unsigned i; + for (i = 0; i < bi->nbits; i++) + soft_bits[i] = (char) round(bi->rx_burst[i] * 255.0); +} + +bool trxd_send_burst_ind_v0(size_t chan, int fd, const struct trx_ul_burst_ind *bi) { + int rc; + + /* v0 doesn't support idle frames, they are simply dropped, not sent */ + if(bi->idle) + return true; + + /* +2: Historically (OpenBTS times), two extra non-used bytes are sent appeneded to each burst */ + char buf[sizeof(struct trxd_hdr_v0) + bi->nbits + 2]; + struct trxd_hdr_v0* pkt = (struct trxd_hdr_v0*)buf; + + trxd_fill_common(&pkt->common, bi, 0); + trxd_fill_v0_specific(&pkt->v0, bi); + trxd_fill_burst_normalized255(&pkt->soft_bits[0], bi); + + /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi->nbits] */ + pkt->soft_bits[bi->nbits + 1] = '\0'; + + rc = write(fd, buf, sizeof(struct trxd_hdr_v0) + bi->nbits + 2); + if (rc <= 0) { + CLOGCHAN(chan, DMAIN, LOGL_NOTICE, "mDataSockets write(%d) failed: %d\n", fd, rc); + return false; + } + return true; +} diff --git a/Transceiver52M/proto_trxd.h b/Transceiver52M/proto_trxd.h index 9da18db..2e5ad52 100644 --- a/Transceiver52M/proto_trxd.h +++ b/Transceiver52M/proto_trxd.h @@ -1,28 +1,52 @@ #pragma once #include +#include +#include +#include + #include +#include "debug.h" + +#define MAX_RX_BURST_BUF_SIZE 444 /* 444 = EDGE_BURST_NBITS */ + +struct trx_ul_burst_ind { + float rx_burst[MAX_RX_BURST_BUF_SIZE]; /* soft bits normalized 0..1 */ + unsigned nbits; // number of symbols per slot in rxBurst, not counting guard periods + uint32_t fn; // TDMA frame number + uint8_t tn; // TDMA time-slot number + double rssi; // in dBFS + double toa; // in symbols + double noise; // noise level in dBFS + bool idle; // true if no valid burst is included +}; + +bool trxd_send_burst_ind_v0(size_t chan, int fd, const struct trx_ul_burst_ind *bi); + +/* The latest supported TRXD header format version */ +#define TRX_DATA_FORMAT_VER 0 + struct trxd_hdr_common { #if OSMO_IS_LITTLE_ENDIAN - uint8_t tn:3, - reserved:1, - version:4; + uint8_t tn:3, + reserved:1, + version:4; #elif OSMO_IS_BIG_ENDIAN - uint8_t version:4, - reserved:1, - tn:3; + uint8_t version:4, + reserved:1, + tn:3; #endif - uint32_t fn; /* big endian */ + uint32_t fn; /* big endian */ } __attribute__ ((packed)); struct trxd_hdr_v0_specific { - uint8_t rssi; - uint16_t toa; /* big endian */ + uint8_t rssi; + uint16_t toa; /* big endian */ } __attribute__ ((packed)); struct trxd_hdr_v0 { - struct trxd_hdr_common common; - struct trxd_hdr_v0_specific v0; - uint8_t soft_bits[0]; + struct trxd_hdr_common common; + struct trxd_hdr_v0_specific v0; + uint8_t soft_bits[0]; } __attribute__ ((packed)); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed Gerrit-Change-Number: 14646 Gerrit-PatchSet: 10 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:44:16 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 11:44:16 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support SETFORMAT command In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14665 ) Change subject: Transceiver: Support SETFORMAT command ...................................................................... Transceiver: Support SETFORMAT command Only old v0 is supported so far. Related: OS#4006 Change-Id: If9fc22f9987238a5ff870df7718de4efc9e04289 --- M Transceiver52M/Transceiver.cpp 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 6bbf3a3..080afd1 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -868,6 +868,20 @@ mStates[chan].chanType[timeslot] = (ChannelCombination) corrCode; setModulus(timeslot, chan); sprintf(response,"RSP SETSLOT 0 %d %d",timeslot,corrCode); + } else if (match_cmd(command, "SETFORMAT", ¶ms)) { + // set TRXD protocol version + unsigned version_recv; + sscanf(params, "%u", &version_recv); + LOGC(DTRXCTRL, INFO) << "BTS requests TRXD version switch: " << version_recv; + if (version_recv > TRX_DATA_FORMAT_VER) { + LOGC(DTRXCTRL, INFO) << "rejecting TRXD version " << version_recv + << "in favor of " << TRX_DATA_FORMAT_VER; + sprintf(response, "RSP SETFORMAT %u %u", TRX_DATA_FORMAT_VER, version_recv); + } else { + LOGC(DTRXCTRL, NOTICE) << "switching to TRXD version " << version_recv; + mVersionTRXD = version_recv; + sprintf(response, "RSP SETFORMAT %u %u", version_recv, version_recv); + } } else if (match_cmd(command, "_SETBURSTTODISKMASK", ¶ms)) { // debug command! may change or disapear without notice // set a mask which bursts to dump to disk -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14665 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9fc22f9987238a5ff870df7718de4efc9e04289 Gerrit-Change-Number: 14665 Gerrit-PatchSet: 9 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:50:11 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 11:50:11 +0000 Subject: Change in ...osmo-trx[master]: fixup: pullRadioVector(): properly set modulation type In-Reply-To: References: Message-ID: fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14784 ) Change subject: fixup: pullRadioVector(): properly set modulation type ...................................................................... Abandoned Squashed to I53db2678458a7377c87875b58b58b76a1b900517. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie576762b8074047dc77bddc32d16fc8ad7ed9c5d Gerrit-Change-Number: 14784 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 11:52:13 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 11:52:13 +0000 Subject: Change in ...osmo-trx[master]: fixup: trxd_hdr_v1_specific: fix MTS encoding In-Reply-To: References: Message-ID: fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14783 ) Change subject: fixup: trxd_hdr_v1_specific: fix MTS encoding ...................................................................... Abandoned Squashed to I53db2678458a7377c87875b58b58b76a1b900517. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14783 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9c0b7eef1464524e93fe0945acbdbf3d557c5664 Gerrit-Change-Number: 14783 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:04:19 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 12:04:19 +0000 Subject: Change in ...osmo-bts[master]: OML: Send Failure Event Report on short OML messages In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/12872 ) Change subject: OML: Send Failure Event Report on short OML messages ...................................................................... Patch Set 1: Code-Review-2 Similar change has been already merged as a part of I5b19b82a4874617c7c584cf3eac55eb9c756710a, so please abandon. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/12872 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4a1b64aa35fa7051d9eb190f3f6f5ea0b28bab8f Gerrit-Change-Number: 12872 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 12:04:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:28:50 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 19 Jul 2019 12:28:50 +0000 Subject: Change in ...libosmocore[master]: tell ubsan to ignore SUN_LEN In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14682 to look at the new patch set (#2). Change subject: tell ubsan to ignore SUN_LEN ...................................................................... tell ubsan to ignore SUN_LEN ubsan will report undefined behavior due to the SUN_LEN macros interaction with a null pointer, so let's tell ubsan to ignore this function. Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 --- M src/socket.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/14682/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 Gerrit-Change-Number: 14682 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:32:57 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Fri, 19 Jul 2019 12:32:57 +0000 Subject: Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3 In-Reply-To: References: Message-ID: Hello pespin, fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 to look at the new patch set (#3). Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 ...................................................................... fb_tools/bdf_to_c.py: make it compatible with python3 This would break python2 compatibility. Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 --- M src/host/fb_tools/bdf_to_c.py 1 file changed, 33 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/58/14758/3 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:33:29 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Fri, 19 Jul 2019 12:33:29 +0000 Subject: Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3 In-Reply-To: References: Message-ID: lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14758 ) Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 ...................................................................... Patch Set 3: updated shebang -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 12:33:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:35:26 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 12:35:26 +0000 Subject: Change in ...libosmocore[master]: tell ubsan to ignore SUN_LEN In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14682 ) Change subject: tell ubsan to ignore SUN_LEN ...................................................................... Patch Set 2: Code-Review+1 +1, but I still think information in this commit can be improved by adding: * clang/ubsan version triggering the bug (because it's a compiler bug imho, C code in SUN_LEN is fine) * Actual error line being printed. * A comment in the added ifef __atribute__ line explaining it's there due to ubsan and SUN_LEN() -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 Gerrit-Change-Number: 14682 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 12:35:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:36:01 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 12:36:01 +0000 Subject: Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14758 ) Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 12:36:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:43:47 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 12:43:47 +0000 Subject: Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14758 ) Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 12:43:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:44:59 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 12:44:59 +0000 Subject: Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14758 ) Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 ...................................................................... Patch Set 3: -Code-Review (1 comment) https://gerrit.osmocom.org/#/c/14758/3/src/host/fb_tools/bdf_to_c.py File src/host/fb_tools/bdf_to_c.py: https://gerrit.osmocom.org/#/c/14758/3/src/host/fb_tools/bdf_to_c.py at 1 PS3, Line 1: /usr/bin/python3 wait, let's do it properly '/usr/bin/env python3'. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 12:44:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:46:32 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 12:46:32 +0000 Subject: Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14758 ) Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 ...................................................................... Patch Set 3: -Code-Review Indeed, good catch :) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 12:46:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:56:47 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 12:56:47 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support TRXD v1 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14657 ) Change subject: Transceiver: Support TRXD v1 ...................................................................... Patch Set 12: (1 comment) https://gerrit.osmocom.org/#/c/14657/12//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14657/12//COMMIT_MSG at 9 PS12, Line 9: C/I value still needs to be computed and set in bi in pullRadioVector(). I guess this comment is outdated. We already do C/I computation. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 12 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 12:56:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:58:36 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 12:58:36 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support TRXD v1 In-Reply-To: References: Message-ID: Hello fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 to look at the new patch set (#13). Change subject: Transceiver: Support TRXD v1 ...................................................................... Transceiver: Support TRXD v1 Related: OS#4006 Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/proto_trxd.c M Transceiver52M/proto_trxd.h 3 files changed, 98 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/57/14657/13 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 13 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:58:36 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 12:58:36 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#4) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/14785 ) Change subject: driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN ...................................................................... driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN Change-Id: I8396004616754f84fb465c972fde9e91b18cc49b --- M Transceiver52M/Transceiver.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/85/14785/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8396004616754f84fb465c972fde9e91b18cc49b Gerrit-Change-Number: 14785 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:58:36 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 12:58:36 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): use trxd_hdr_common for message parsing In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#4) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/14786 ) Change subject: driveTxPriorityQueue(): use trxd_hdr_common for message parsing ...................................................................... driveTxPriorityQueue(): use trxd_hdr_common for message parsing Change-Id: If6a93e2b7fc9ada55edbdd16352cd4f7040e3d2a --- M Transceiver52M/Transceiver.cpp 1 file changed, 10 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/86/14786/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If6a93e2b7fc9ada55edbdd16352cd4f7040e3d2a Gerrit-Change-Number: 14786 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:58:36 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 12:58:36 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): check if message header format is supported In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#4) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/14787 ) Change subject: driveTxPriorityQueue(): check if message header format is supported ...................................................................... driveTxPriorityQueue(): check if message header format is supported Change-Id: I17abf95f5e23236abccc50476cd59931580f5cd3 --- M Transceiver52M/Transceiver.cpp 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/87/14787/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I17abf95f5e23236abccc50476cd59931580f5cd3 Gerrit-Change-Number: 14787 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:58:36 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 12:58:36 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): enrich logging message In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#4) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/14788 ) Change subject: driveTxPriorityQueue(): enrich logging message ...................................................................... driveTxPriorityQueue(): enrich logging message Change-Id: If25c2171f7d1ab98d65f0dbf93d0d8a5a635caf7 --- M Transceiver52M/Transceiver.cpp 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/88/14788/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If25c2171f7d1ab98d65f0dbf93d0d8a5a635caf7 Gerrit-Change-Number: 14788 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 12:58:36 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 12:58:36 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Initialize mExtRACH in constructor In-Reply-To: References: Message-ID: Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14814 to look at the new patch set (#3). Change subject: Transceiver: Initialize mExtRACH in constructor ...................................................................... Transceiver: Initialize mExtRACH in constructor Doing so should make Coverity happy: >>> CID 200212: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "mExtRACH" is not initialized in this constructor nor in any functions that it calls. The current status is actually harmless since the field will be set during init() time, and the variable is never used before init() is called. Fixes: Coverity CID#200212 Change-Id: I17286570a9a6db695a75147e5cbb18c9da7d0fe6 --- M Transceiver52M/Transceiver.cpp 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/14/14814/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I17286570a9a6db695a75147e5cbb18c9da7d0fe6 Gerrit-Change-Number: 14814 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 13:33:29 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 19 Jul 2019 13:33:29 +0000 Subject: Change in ...openbsc[master]: manuals: Generate vty/counter documentation for osmo-bscnat In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14530 ) Change subject: manuals: Generate vty/counter documentation for osmo-bscnat ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/#/c/14530/4/openbsc/doc/regen_doc.sh File openbsc/doc/regen_doc.sh: https://gerrit.osmocom.org/#/c/14530/4/openbsc/doc/regen_doc.sh at 19 PS4, Line 19: OSMO_BSCNAT_BRANCH=$COMMIT ./regen_doc.sh osmo-nitb 4244 \ > osmo-nitb? that looks wrong! That tells the script which docker container to use. the osmo-nitb one also has osmo-bsc_nat built, which is why the last argument overrides the default of the container. https://gerrit.osmocom.org/#/c/14530/4/openbsc/doc/regen_doc.sh at 22 PS4, Line 22: osmo-bsc_nat This starts osmo-bsc_nat instead of osmo-nitb -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ice7f15192a57e2c964d07d364732af888972ba0f Gerrit-Change-Number: 14530 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 13:33:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 13:57:17 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 13:57:17 +0000 Subject: Change in ...openbsc[master]: manuals: Generate vty/counter documentation for osmo-bscnat In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/14530 ) Change subject: manuals: Generate vty/counter documentation for osmo-bscnat ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/openbsc/+/14530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Change-Id: Ice7f15192a57e2c964d07d364732af888972ba0f Gerrit-Change-Number: 14530 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 13:57:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 14:03:29 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 14:03:29 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support TRXD v1 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14657 ) Change subject: Transceiver: Support TRXD v1 ...................................................................... Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 13 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 14:03:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 14:40:57 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 14:40:57 +0000 Subject: Change in ...osmo-gsm-manuals[master]: Makefile.asciidoc.inc: Export commondir attribute to asciidoc files Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14838 Change subject: Makefile.asciidoc.inc: Export commondir attribute to asciidoc files ...................................................................... Makefile.asciidoc.inc: Export commondir attribute to asciidoc files Otherwise, adoc files in osmo-*/doc/manuals/chapters/*.adoc cannot include files from osmo-gsm-manuals/common/chapters/*.adoc, since symbolic link to common/ is only available in builddir, but not in srcdir. This way, those files can include commons files like this: include::{commondir}/chapters/foobar.adoc Change-Id: Ifc2fdaf1a87d0715213b4eab13c6c9a4f8a987fd --- M build/Makefile.asciidoc.inc 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/38/14838/1 diff --git a/build/Makefile.asciidoc.inc b/build/Makefile.asciidoc.inc index fb44a63..1bed968 100644 --- a/build/Makefile.asciidoc.inc +++ b/build/Makefile.asciidoc.inc @@ -17,6 +17,7 @@ # osmo_yada.pdf: yada/*.adoc yada/*.msc BUILDDIR = $(OSMO_GSM_MANUALS_DIR)/build +COMMONDIR = $(OSMO_GSM_MANUALS_DIR)/common GIT_VERSION := $(shell git describe --abbrev=4 --dirty --always --tags) GIT_DATE := $(shell $(OSMO_GSM_MANUALS_DIR)/build/unix-time-to-fmt.py `git log -n 1 "--pretty=%at" ../.`) @@ -36,7 +37,7 @@ CLEAN_FILES += $(ASCIIDOC_PDF) $(ASCIIDOC_NAME:%=%.html) UPLOAD_FILES += $(ASCIIDOC_PDF) -ASCIIDOC_OPTS := -f $(BUILDDIR)/mscgen-filter.conf -f $(BUILDDIR)/diag-filter.conf -f $(BUILDDIR)/docinfo-releaseinfo.conf -f $(BUILDDIR)/python2-filter.conf -a srcdir='$(srcdir)' +ASCIIDOC_OPTS := -f $(BUILDDIR)/mscgen-filter.conf -f $(BUILDDIR)/diag-filter.conf -f $(BUILDDIR)/docinfo-releaseinfo.conf -f $(BUILDDIR)/python2-filter.conf -a srcdir='$(srcdir)' -a commondir='$(COMMONDIR)' DBLATEX_OPTS := -s $(ASCIIDOCSTYLE) -P draft.mode=yes -P draft.watermark=0 ifeq (,$(BUILD_RELEASE)) @@ -53,8 +54,8 @@ $(ASCIIDOC_PDF): %.pdf: %.adoc %-docinfo.xml \ $(ASCIIDOC_DEPS) \ $(ASCIIDOCSTYLE) \ - $(OSMO_GSM_MANUALS_DIR)/common/*/*.adoc \ - $(OSMO_GSM_MANUALS_DIR)/common/images/* \ + $(COMMONDIR)/*/*.adoc \ + $(COMMONDIR)/images/* \ build common # a2x can't use a different output file. To support out-of-tree builds, @@ -79,7 +80,7 @@ $(ASCIIDOC_CHECKS): %.check: %.adoc %-docinfo.xml \ $(ASCIIDOCSTYLE) \ - $(OSMO_GSM_MANUALS_DIR)/common/chapters/*.adoc \ + $(COMMONDIR)/chapters/*.adoc \ $(ASCIIDOC_DEPS) \ build common -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14838 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ifc2fdaf1a87d0715213b4eab13c6c9a4f8a987fd Gerrit-Change-Number: 14838 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 14:40:57 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 14:40:57 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: Introduce Osmux documentation Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 Change subject: common: Introduce Osmux documentation ...................................................................... common: Introduce Osmux documentation Change-Id: I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e --- A common/chapters/osmux/mgcp_extension_osmux.adoc A common/chapters/osmux/mo_call_osmux_aoip.msc A common/chapters/osmux/mo_call_osmux_sccplite.msc A common/chapters/osmux/mo_call_osmux_sccplite_nat.msc A common/chapters/osmux/network_osmux_aoip.dot A common/chapters/osmux/network_osmux_sccplite.dot A common/chapters/osmux/network_osmux_sccplite_nat.dot A common/chapters/osmux/osmux.adoc 8 files changed, 549 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/39/14839/1 diff --git a/common/chapters/osmux/mgcp_extension_osmux.adoc b/common/chapters/osmux/mgcp_extension_osmux.adoc new file mode 100644 index 0000000..c12e9ef --- /dev/null +++ b/common/chapters/osmux/mgcp_extension_osmux.adoc @@ -0,0 +1,115 @@ +[[mgcp-extension-osmux]] +=== Osmux and MGCP + +`X-Osmux` indicates to OsmoMGW that a given connection of an `rtpbridge` +endpoint has to be configured in order to handle Osmux frames instead of RTP +messages on the data plane. + +==== `X-Osmux` Format + +The value part of `X-Osmux` must be one integer in range [0..255], or +alternatively only on request messages, an asterisk (*) if the value is not yet +known. + +`X-Osmux` must be issued in the MGCP header section (typically as its last +item), before the SDP section starts. + +`X-Osmux` can be included inside `CRCX` and `MDCX` request messages, as well as +their respective response messages. + +In request messages, the value part of `X-Osmux` specifies the CID to be used by +OsmoMGW to _send_ Osmux frames to the remote peer for that connection, also +known as _sendCID_. + +In response messages, the value part of `X-Osmux` specifies the CID where +OsmoMGW expect to _receive_ Osmux frames from the remote peer for that +connection, also known as _recvCID_. + +.Example: `X-Osmux` format with a known CID 3. +---- +X-Osmux: 3 +---- + +.Example: `X-Osmux` format with a wildcard (not yet known) CID. +---- +X-Osmux: * +---- + +==== `X-Osmux` Considerations + +If the MGCP client is willing to use Osmux for a given connection, it shall +specify so during `CRCX` time, and not later. If at `CRCX` time the MGCP client +doesn't yet know the _sendCID_, it can use an astersik (*) and provide +_sendCID_ later within `MDCX` messages. + +All subsequent `MDCX` messages sent towards an Osmux connection must contain the +original _sendCID_ sent during `CRCX`. The same way, all `MDCX` response shall +contain the _recvCID_ sent during `CRCX`. + +The other required connection address parameters, such as IP address, port, and +codecs, are negotiated through MGCP and SDP as usual, but in this case the IP +address and port specific the Osmux socket IP address and port to use, that +together with the Osmux CID conform the entire tuple identifying a Osmux stream. + +Since Osmux only supports AMR codec payloads, the SDP must specify use of AMR +codec. + +.Example: `CRCX` message that instructs OsmoMGW to create an Osmux connection +---- +CRCX 189 rtpbridge/1 at mgw MGCP 1.0 +C: 36 +M: sendrecv +X-Osmux: 2 + +v=0 +o=- 36 23 IN IP4 172.18.2.20 +s=- +c=IN IP4 1.2.3.4 +t=0 0 +m=audio 2342 RTP/AVP 112 +a=fmtp:112 +a=rtpmap:112 AMR/8000/1 +a=ptime:20 +---- + +.Example: response to `CRCX` containing the <> +---- +200 189 OK +I: 07E41584 +X-Osmux: 2 +Z: rtpbridge/1 at mgw + +v=0 +o=- foo 21 IN IP4 172.18.1.20 +s=- +c=IN IP4 172.18.1.20 +t=0 0 +m=audio 11002 RTP/AVP 112 +a=rtpmap:112 AMR/8000 +a=ptime:20 +---- + +==== `X-Osmux` Support + +`X-Osmux` is known to be supported by OsmoMGW on the MGCP server side, and by +OsmoBSC as well as OsmoMSC on the MGCP client side (through libosmo-mgcp-cli). +No other programs supporting this feature are known or envisioned at the time of +writing this document. + +In OmoMGW, Osmux support is managed through VTY. + +.Example: Sample config file section with Osmux configuation +---- +mgcp + ... + osmux on <1> + osmux bind-ip 172.18.1.20 <2> + osmux port 1984 <3> + osmux batch-factor 4 <4> + osmux dummy on <5> +---- +<1> Allow clients to set allocate Osmux connections in `rtpbridge` endpoints, while still allowing RTP connections +<2> Bind the Osmux socket to the provided IP address +<3> Bind the Osmux socket to the provided UDP port +<4> Batch up to 4 RTP payloads of the same stream on each Osmux frame +<5> Periodically send Osmux dummy frames, useful to punch a hole in NATs and maintain connections opened. diff --git a/common/chapters/osmux/mo_call_osmux_aoip.msc b/common/chapters/osmux/mo_call_osmux_aoip.msc new file mode 100644 index 0000000..9cb2e50 --- /dev/null +++ b/common/chapters/osmux/mo_call_osmux_aoip.msc @@ -0,0 +1,54 @@ +# MO-call with Osmux enable on 3GPP AoIP +msc { + hscale=2; + ms [label="MS"], bts [label="OsmoBTS"], bsc[label="OsmoBSC"], mgw_bsc[label="OsmoMGW(bsc)"], m_sc[label="MSC"], mgw_msc[label="OsmoMGW(msc)"]; + + bsc <- m_sc [label="BSSMAP RESET (with extension IE: Osmux Support)"]; + bsc -> m_sc [label="BSSMAP RESET ACK (with extension IE: Osmux Support)"]; + ...; + ms box mgw_msc [label="We assume a SDCCH is already established"]; + ...; + + ms -> bsc [label="DTAP CM Service Request"]; + bsc -> m_sc [label="Complete Layer 3 Information DTAP CM Service Request"]; + + # Allocate MGW/MSC Osmux endpoint + m_sc -> mgw_msc [label="MGCP CRCX rtpbridge/*@mgw, X-Osmux: *"]; + mgw_msc box mgw_msc [label="Bind to MGW-local Osmux Port (1984)\nAllocate new endpoint 1, recvCID 5"]; + mgw_msc -> m_sc [label="MGCP CRCX rtpbridge/1 at mgw OK (MGW:1984, X-Osmux: 5)"]; + + bsc <- m_sc [label="BSSAP ASSGN REQ (3GPP AoIP, extension IE: Osmux CID 5)"]; + bts <- bsc [label="RSL CHAN ACT"]; + bts -> bsc [label="RSL CHAN ACT ACK"]; + ms <- bsc [label="Assignment Command"]; + ms -> bsc [label="Assignment Complete"]; + ...; + + # connect BTS RTP with BSC-MGW RTP + bts <- bsc [label="IPA CRCX"]; + bts box bts [label="Bind to BTS-local RTP Port (1000)"]; + bts -> bsc [label="IPA CRCX ACK (BTS:1000)"]; + bsc -> mgw_bsc [label="MGCP CRCX rtpbridge/2 at mgw (BTS:1000)"]; + mgw_bsc box mgw_bsc [label="Bind to MGW-local RTP Port (2000)\nConnect to BTS:1000"]; + bsc <- mgw_bsc [label="MGCP CRCX rtpbridge/2 at mgw OK (MGW:2000)"]; + bts <- bsc [label="IPA MDCX (MGW:2000)"]; + bts box bts [label="Connect RTP socket to remote (MGW) RTP Port"]; + bts -> bsc [label="IPA MDCX ACK"]; + ...; + + mgw_bsc <- bsc [label="MGCP CRCX rtpbridge/2 at mgw (MSC:1984, X-Osmux: 5)"]; + mgw_bsc box mgw_bsc [label="Bind to MGW-local Osmux Port (1985)\nConnect to MSC:1984\nAllocate new recvCID 7"]; + mgw_bsc -> bsc [label="MGCP CRCX rtpbridge/2 at mgw OK (MGW:1985, X-Osmux: 7)"]; + ...; + + bsc -> m_sc [label="BSSAP ASSGN CMPL (3GPP AoIP MGW:1985, extension IE: Osmux CID 7)"]; + m_sc box m_sc [label="Connect remote Osmux to MGW addr from ASSGN CMPL"]; + m_sc -> mgw_msc [label="MGCP MDCX rtpbridge/1 at mgw (MGW:1985, X-Osmux: 7)"]; + m_sc <- mgw_msc [label="MGCP MDCX rtpbridge/1 at mgw OK (X-Osmux: 5)"]; + ...; + + mgw_bsc <=> mgw_msc [label="Osmux Audio MGW:1985 MSC:1984, CID(uplink):5, CID(downlink):7"]; + bts <=> mgw_bsc [label="RTP Audio BTS:1000 MGW:2000"]; + ms <=> bts [label="Um Audio (bidirectional)"]; + ms <-> m_sc [label="DTAP CC ALERTING"]; +} diff --git a/common/chapters/osmux/mo_call_osmux_sccplite.msc b/common/chapters/osmux/mo_call_osmux_sccplite.msc new file mode 100644 index 0000000..903da46 --- /dev/null +++ b/common/chapters/osmux/mo_call_osmux_sccplite.msc @@ -0,0 +1,58 @@ +# MO-call with Osmux enable on 3GPP AoIP using A/IP with IPA/SCCPlite +msc { + hscale=2; + ms [label="MS"], bts [label="OsmoBTS"], bsc[label="OsmoBSC"], mgw_bsc[label="OsmoMGW(bsc)"], m_sc[label="MSC"], mgw_msc[label="OsmoMGW(msc)"]; + + ms box m_sc [label="We assume a SDCCH is already established"]; + ...; + + ms -> bsc [label="DTAP CM Service Request"]; + bsc -> m_sc [label="Complete Layer 3 Information DTAP CM Service Request"]; + bsc <- m_sc [label="Connection Confirmed"]; + + # Allocate MGW/MSC Osmux endpoint + m_sc -> mgw_msc [label="MGCP CRCX *@mgw, X-Osmux: *"]; + mgw_msc box mgw_msc [label="Bind to MGW-local Osmux Port (1984)\nAllocate new endpoint 1, recvCID 5"]; + mgw_msc -> m_sc [label="MGCP CRCX rtpbridge/1 at mgw OK (MGW:1984, X-Osmux: 5)"]; + + bsc <- m_sc [label="BSSAP ASSGN REQ (CIC:1)"]; + bts <- bsc [label="RSL CHAN ACT"]; + bts -> bsc [label="RSL CHAN ACT ACK"]; + ms <- bsc [label="Assignment Command"]; + ms -> bsc [label="Assignment Complete"]; + ...; + + # connect BTS RTP with BSC-MGW RTP, CIC is used as MGW endpoint + bts <- bsc [label="IPA CRCX"]; + bts box bts [label="Bind to BTS-local RTP Port (1000)"]; + bts -> bsc [label="IPA CRCX ACK (BTS:1000)"]; + bsc -> mgw_bsc [label="MGCP CRCX 1 at mgw (BTS:1000)"]; + mgw_bsc box mgw_bsc [label="Bind to MGW-local RTP Port (2000)\nConnect to BTS:1000"]; + bsc <- mgw_bsc [label="MGCP CRCX 1 at mgw OK (MGW:2000)"]; + bts <- bsc [label="IPA MDCX (MGW:2000)"]; + bts box bts [label="Connect RTP socket to remote (MGW) RTP Port"]; + bts -> bsc [label="IPA MDCX ACK"]; + ...; + + bsc -> m_sc [label="BSSMAP ASSGN Complete"]; + ...; + + # MSC configures BSC-MGW MSC-side of the endpoint through MGCP UDP forwarding + mgw_bsc <- m_sc [label="MGCP CRCX 1 at mgw (MSC:1984, X-Osmux: 5)"]; + mgw_bsc box mgw_bsc [label="Bind to BTS-local Osmux Port (1985)\nAllocate new recvCID 7"]; + mgw_bsc -> m_sc [label="MGCP CRCX 1 at mgw OK (MGW:1985, X-Osmux: 7)"]; + mgw_bsc <- m_sc [label="MGCP MDCX 1 at mgw (recvonly) "]; + mgw_bsc box mgw_bsc [label="Connect Osmux socket to remote (MSC) Osmux Port"]; + mgw_bsc -> m_sc [label="MGCP MDCX 1 at mgw OK"]; + mgw_bsc <= mgw_msc [label="Osmux Audio MGW:1985 MSC:1984, CID(downlink):7"]; + bts <= mgw_bsc [label="RTP Audio BTS:1000 MGW:2000"]; + ms <= bts [label="Um Audio (unidirectional)"]; + ms <- m_sc [label="DTAP CC ALERTING"]; + ...; + mgw_bsc <- m_sc [label="MGCP MDCX 1 at mgw (sndrecv) "]; + mgw_bsc box mgw_bsc [label="Switch to bi-directional audio"]; + mgw_bsc -> m_sc [label="MGCP MDCX 1 at mgw OK"]; + mgw_bsc <=> mgw_msc [label="Osmux Audio MGW:1985 MSC:1984, CID(uplink):5, CID(downlink):7"]; + bts <=> mgw_bsc [label="RTP Audio BTS:1000 MGW:2000"]; + ms <=> bts [label="Um Audio (bidirectional)"]; +} diff --git a/common/chapters/osmux/mo_call_osmux_sccplite_nat.msc b/common/chapters/osmux/mo_call_osmux_sccplite_nat.msc new file mode 100644 index 0000000..2aa8105 --- /dev/null +++ b/common/chapters/osmux/mo_call_osmux_sccplite_nat.msc @@ -0,0 +1,77 @@ +# MO-call with Osmux enable on 3GPP AoIP using A/IP with IPA/SCCPlite with a BSC-NAT between BSC and MSC +msc { + hscale=2; + ms [label="MS"], bts [label="OsmoBTS"], bsc[label="OsmoBSC"], mgw_bsc[label="OsmoMGW(bsc)"], bscnat[label="OsmoBSCNAT"], m_sc[label="MSC"], mgw_msc[label="OsmoMGW(msc)"]; + + ms box m_sc [label="We assume a SDCCH is already established"]; + ...; + + ms -> bsc [label="DTAP CM Service Request"]; + bsc -> m_sc [label="Complete Layer 3 Information DTAP CM Service Request"]; + bsc <- m_sc [label="Connection Confirmed"]; + + # Allocate MGW/MSC RTP endpoint + m_sc -> mgw_msc [label="MGCP CRCX *@mgw"]; + mgw_msc box mgw_msc [label="Bind to MGW-local RTP Port (3000)\nAllocate new endpoint 1"]; + mgw_msc -> m_sc [label="MGCP CRCX rtpbridge/1 at mgw OK (MGW:3000)"]; + bscnat <- m_sc [label="BSSAP ASSGN REQ (CIC:1)"]; + + # NAT: MGW/MSC Osmux endpoint + #bscnat -> bscnat [label="MGCP CRCX *@mgw, X-Osmux: *"]; + mgw_msc box mgw_msc [label="Bind to MGW-local Osmux Port (1984)\nAllocate new endpoint 2, recvCID 5"]; + #mgw_msc -> m_sc [label="MGCP CRCX rtpbridge/1 at mgw OK (MGW:1984, X-Osmux: 5)"]; + bsc <- bscnat [label="BSSAP ASSGN REQ (CIC:2)"]; + + bts <- bsc [label="RSL CHAN ACT"]; + bts -> bsc [label="RSL CHAN ACT ACK"]; + ms <- bsc [label="Assignment Command"]; + ms -> bsc [label="Assignment Complete"]; + ...; + + # connect BTS RTP with BSC-MGW RTP, CIC is used as MGW endpoint + bts <- bsc [label="IPA CRCX"]; + bts box bts [label="Bind to BTS-local RTP Port (1000)"]; + bts -> bsc [label="IPA CRCX ACK (BTS:1000)"]; + bsc -> mgw_bsc [label="MGCP CRCX 1 at mgw (BTS:1000)"]; + mgw_bsc box mgw_bsc [label="Bind to MGW-local RTP Port (2000)\nConnect to BTS:1000"]; + bsc <- mgw_bsc [label="MGCP CRCX 1 at mgw OK (MGW:2000)"]; + bts <- bsc [label="IPA MDCX (MGW:2000)"]; + bts box bts [label="Connect RTP socket to remote (MGW) RTP Port"]; + bts -> bsc [label="IPA MDCX ACK"]; + #bsc -> mgw_bsc [label="MGCP MDCX 1 at mgw (optional)"]; + #bsc <- mgw_bsc [label="MGCP MDCX 1 at mgw OK (optional)"]; + ...; + + bsc -> bscnat [label="BSSMAP ASSGN Complete"]; + bscnat -> m_sc [label="BSSMAP ASSGN Complete"]; + ...; + + # MSC configures BSC-MGW MSC-side of the endpoint through MGCP UDP forwarding + bscnat <- m_sc [label="MGCP CRCX 1 at mgw (MSC:3000)"]; + bscnat box bscnat [label="Allocate new endpoint 2\nAllocate new recvCID 5\nBind to local Osmux Port (1984)\nBind to local RTP port 4000"]; + mgw_bsc <- bscnat [label="MGCP CRCX 2 at mgw (MSC:1984, X-Osmux: 5)"]; + mgw_bsc -> bscnat [label="MGCP CRCX 2 at mgw OK (MGW:1985, X-Osmux: 7)"]; + bscnat -> m_sc [label="MGCP CRCX 1 at mgw OK (MGW:4000)"]; + bscnat <- m_sc [label="MGCP MDCX 1 at mgw (recvonly) "]; + mgw_bsc <- bscnat [label="MGCP MDCX 2 at mgw (recvonly) "]; + mgw_bsc box mgw_bsc [label="Connect Osmux socket to remote (MSC) Osmux Port"]; + mgw_bsc -> bscnat [label="MGCP MDCX 2 at mgw OK"]; + bscnat -> m_sc [label="MGCP MDCX 1 at mgw OK"]; + + bscnat <= mgw_msc [label="RTP Audio BSCNAT:4000 MGW:3000"]; + mgw_bsc <= bscnat [label="Osmux Audio MGW:1985 BSCNAT:1984, CID(downlink):7"]; + bts <= mgw_bsc [label="RTP Audio BTS:1000 MGW:2000"]; + ms <= bts [label="Um Audio (unidirectional)"]; + ms <- m_sc [label="DTAP CC ALERTING"]; + ...; + bscnat <- m_sc [label="MGCP MDCX 1 at mgw (sndrecv) "]; + mgw_bsc <- bscnat [label="MGCP MDCX 2 at mgw (sndrecv) "]; + mgw_bsc box mgw_bsc [label="Switch to bi-directional audio"]; + mgw_bsc -> bscnat [label="MGCP MDCX 2 at mgw OK"]; + bscnat -> m_sc [label="MGCP MDCX 1 at mgw OK"]; + + bscnat <=> mgw_msc [label="RTP Audio BSCNAT:4000 MGW:3000"]; + mgw_bsc <=> bscnat [label="Osmux Audio MGW:1985 MSC:1984, CID(uplink):5, CID(downlink):7"]; + bts <=> mgw_bsc [label="RTP Audio BTS:1000 MGW:2000"]; + ms <=> bts [label="Um Audio (bidirectional)"]; +} diff --git a/common/chapters/osmux/network_osmux_aoip.dot b/common/chapters/osmux/network_osmux_aoip.dot new file mode 100644 index 0000000..7531e6a --- /dev/null +++ b/common/chapters/osmux/network_osmux_aoip.dot @@ -0,0 +1,32 @@ +digraph G { + rankdir = LR; + subgraph cluster_RAN { + OsmoBTS1 [label="OsmoBTS"]; + OsmoBTS2 [label="OsmoBTS"]; + OsmoBSC; + OsmoMGW [label="OsmoMGW\n(for BSC)"]; + + OsmoBTS1 -> OsmoBSC [label="Abis/IP", dir="both"]; + OsmoBTS2 -> OsmoBSC [label="Abis/IP", dir="both"]; + OsmoBSC -> OsmoMGW [label="MGCP", dir="both"]; + { rank = same; OsmoBSC; OsmoMGW } + + OsmoBTS1 -> OsmoMGW [label="RTP", dir="both"]; + OsmoBTS2 -> OsmoMGW [label="RTP", dir="both"]; + + label = "RAN"; + } + subgraph cluster_CN { + OsmoMGW1 [label="OsmoMGW\n(for MSC)"]; + OsmoMSC [label="MSC\ne.g. OsmoMSC"]; + Core [label="Other CN Elements"]; + OsmoMSC -> Core [label="MAP/ISUP/SIP/GSUP", dir="both"]; + OsmoMSC -> OsmoMGW1 [label="MGCP", dir="both"]; + { rank = same; OsmoMSC; OsmoMGW1 } + OsmoMGW -> OsmoMGW1 [label="Osmux", dir="both", color=red]; + OsmoMGW1 -> Core [label="RTP", dir="both"]; + label = "CN"; + } + + OsmoBSC -> OsmoMSC [label="3GPP AoIP\nvia SIGTRAN/STP", dir="both"]; +} diff --git a/common/chapters/osmux/network_osmux_sccplite.dot b/common/chapters/osmux/network_osmux_sccplite.dot new file mode 100644 index 0000000..678a61e --- /dev/null +++ b/common/chapters/osmux/network_osmux_sccplite.dot @@ -0,0 +1,33 @@ +digraph G { + rankdir = LR; + subgraph cluster_RAN { + OsmoBTS1 [label="OsmoBTS"]; + OsmoBTS2 [label="OsmoBTS"]; + OsmoBSC; + OsmoMGW [label="OsmoMGW\n(for BSC)"]; + + OsmoBTS1 -> OsmoBSC [label="Abis/IP", dir="both"]; + OsmoBTS2 -> OsmoBSC [label="Abis/IP", dir="both"]; + OsmoBSC -> OsmoMGW [label="MGCP (BTS side)", dir="both"]; + { rank = same; OsmoBSC; OsmoMGW } + + OsmoBTS1 -> OsmoMGW [label="RTP", dir="both"]; + OsmoBTS2 -> OsmoMGW [label="RTP", dir="both"]; + + label = "RAN"; + } + subgraph cluster_CN { + OsmoMGW1 [label="OsmoMGW\n(for MSC)"]; + OsmoMSC [label="MSC\ne.g. OsmoMSC"]; + Core [label="Other CN Elements"]; + OsmoMSC -> Core [label="MAP/ISUP/SIP/GSUP", dir="both"]; + OsmoMSC -> OsmoMGW1 [label="MGCP", dir="both"]; + { rank = same; OsmoMSC; OsmoMGW1 } + OsmoMGW -> OsmoMGW1 [label="Osmux", dir="both", color=red]; + OsmoMGW1 -> Core [label="RTP", dir="both"]; + label = "CN"; + } + + OsmoBSC -> OsmoMSC [label="3GPP AoIP\nvia IPA/SCCPlite", dir="both"]; + OsmoMGW -> OsmoMSC [label="MGCP (CN side)\n(IPA/UDP forwarding via BSC)", dir="both"]; +} diff --git a/common/chapters/osmux/network_osmux_sccplite_nat.dot b/common/chapters/osmux/network_osmux_sccplite_nat.dot new file mode 100644 index 0000000..021d0ec --- /dev/null +++ b/common/chapters/osmux/network_osmux_sccplite_nat.dot @@ -0,0 +1,40 @@ +digraph G { + rankdir = LR; + subgraph cluster_RAN { + OsmoBTS1 [label="OsmoBTS"]; + OsmoBTS2 [label="OsmoBTS"]; + OsmoBSC; + OsmoMGW [label="OsmoMGW\n(for BSC)"]; + + OsmoBTS1 -> OsmoBSC [label="Abis/IP", dir="both"]; + OsmoBTS2 -> OsmoBSC [label="Abis/IP", dir="both"]; + OsmoBSC -> OsmoMGW [label="MGCP (BTS side)", dir="both"]; + { rank = same; OsmoBSC; OsmoMGW } + + OsmoBTS1 -> OsmoMGW [label="RTP", dir="both"]; + OsmoBTS2 -> OsmoMGW [label="RTP", dir="both"]; + + label = "RAN"; + } + subgraph cluster_BSCNAT { + OsmoBSCNAT; + label = "BSCNAT"; + } + subgraph cluster_CN { + OsmoMGW1 [label="OsmoMGW\n(for MSC)"]; + OsmoMSC [label="MSC\ne.g. OsmoMSC"]; + Core [label="Other CN Elements"]; + OsmoMSC -> Core [label="MAP/ISUP/SIP/GSUP", dir="both"]; + OsmoMSC -> OsmoMGW1 [label="MGCP", dir="both"]; + { rank = same; OsmoMSC; OsmoMGW1 } + OsmoMGW -> OsmoBSCNAT [label="Osmux", dir="both", color=red]; + OsmoMGW1 -> Core [label="RTP", dir="both"]; + label = "CN"; + } + + OsmoBSC -> OsmoBSCNAT [label="3GPP AoIP\nvia IPA/SCCPlite", dir="both"]; + OsmoMGW -> OsmoBSCNAT [label="MGCP (CN side)\n(IPA/UDP forwarding via BSC)", dir="both"]; + OsmoBSCNAT -> OsmoMSC [label="3GPP AoIP\nvia IPA/SCCPlite", dir="both"]; + OsmoBSCNAT -> OsmoMSC [label="MGCP\nvia UDP", dir="both"]; + OsmoBSCNAT -> OsmoMGW1 [label="RTP", dir="both"]; +} diff --git a/common/chapters/osmux/osmux.adoc b/common/chapters/osmux/osmux.adoc new file mode 100644 index 0000000..1e2a7cc --- /dev/null +++ b/common/chapters/osmux/osmux.adoc @@ -0,0 +1,140 @@ +== Osmux + +`Osmux` is a protocol aimed at multiplexing and transmitting voice and +signalling traffic from multiple sources in order to reduce the overall +bandwidth consumption. This feature becomes specially meaningful in case of +satellite based GSM systems, where the transmission cost on the back-haul is +relatively expensive. In such environment, even seemingly small protocol +optimizations, eg. message batching and trunking, can result in significant cost +reduction. + +Full reference document for the osmux protocol can be found here: +http://ftp.osmocom.org/docs/latest/osmux-reference.pdf + +In Osmocom satellite based GSM networks, the satellite link is envisioned to be +in between the BSS and the core network, that is, between the BSC and the MSC +(or BSC-NAT). Hence, Osmocom components can make use of `Osmux` protocol to +multiplex payload audio streams from call legs between OsmoBSC and OsmoMSC (or +OsmoBSCNAT). The MGW attached those components need of course also be aware of +`Osmux` existence in order to properly set up the audio data plane. + +=== Osmux and NAT + +It is quite usual for satellite based links to use NATs, which means any or both +of the two components at each side of the satellite link (BSC and MSC/BSC-NAT) +may end up being behind a NAT and being unable to provide the real public +address to its peer on the other side of the satellite. + +As a result, upon call parameter negotiation (RTP/Osmux IP address and port), +those parameters won't be entirely useful and some specific logic needs to be +introduced into the network components to circumvent the NAT under those cases. + +For instance, if the BSC and its co-located MGW (BSC/MGW from now on) is under a +NAT, it may end up providing its private address and port as RTP/Osmux +parameters to the MSC/MGW through GSM protocols, but MSC will fail to send any +message to that tuple because of the NAT or routing issues (due to IP address +being a private address). In that scenario, MSC/MGW needs to be aware that +there's a NAT and wait until an RTP/Osmux message arrives from the BSC/MGW host. +It then can, from that message source IP address and port (and CID in case of +Osmux), discover the real public IP address and port of the peer (BSC/MGW). From +that point on, the BSC/MGW punched a hole in the NAT (its connection table is +updated) and MSC/MGW is able to send data back to it on that connection. + +Moreover, NATs tend to drop connections from their connection tables after some +inactivity time, meaning a peer may receive notice about the other end not being +available while it actually is. This means the GSM network needs to be +configured in a way to ensure inactivity periods are short enough that this +cannot occur. That's the reason why OsmoMGW provides the `osmux dummy` VTY +command to enable sending dummy packets from time to time to keep the +connections alive. + +=== CID allocation + +Each peer (BSC/MGW and MSC/MGW) allocates its own _recvCID_, and receives from +the peer through the used GSM protocol the peer's _recvCID_, which becomes +the local _sendCID_ for that connection. + +---- +BSC/MGW(recvCID=Y,sendCID=?)<-X--MSC/MGW(recvCID=X,sendCID=?) +BSC/MGW(recvCID=Y,sendCID=X)--Y->MSC/MGW(recvCID=X,sendCID=Y) +---- + +This way each peer is responsible for allocating and managing their own local +address (CID) space. This is basically the same that happens with regular IP +address and port in the RTP case (and those also apply when Osmux is used, but +an extra identifier, the CID, is allocated). + +In an ideal scenario, without NAT, each BSC/MGW would have a public, +differentiated and unique IP and port set tuple, And MSC/MGW should be able to +identify messages coming from them by easily matching source IP address, port +(and CID in Osmux case) against the parameters negotiated during call set up. + +In this kind of scenario, MSC/MGW could easily open and manage one Osmux socket +per BSC (based on SDP IPaddr and port parameters), with same tuple, allowing for 256 Osmux CIDs per BSC and hence call legs per +BSC. Each of the peers could actually have more than one Osmux socket towards +the other peer, by using a pool of ports or IP addresses, so there's really not +limit if required as long as there's a way to infer the initially negotiated + tuple from the received audio packets. + +However, due to some constrains from in between NATs explained in section above, +BSC/MGW IP address and port are not a priory known, and could change between +different connections coming from it. As a result, it is difficult to infer the +entire tuple, so for now MGW needs to allocate its Osmux _recvCID_ in a clever +way, in order to be able to identify the full tuple from it. + +Hence, currently OsmoMGW CID allocation implementation shares CID between all +connections, which means it can only handle up to 256 concurrent Osmux +connections (call legs). + +Future work in OsmoMGW (_OS#4092_) plans to use a set of local ports for Osmux +sockets instead of only 1 currently used. This way local ports can be matched +against specific tuples and have an entire 256 Osmux CID +space per (aka per peer). + +=== 3GPP AoIP network setup with Osmux + +[[fig-network-osmux-aoip]] +.Sample node diagram of a 3GPP AoIP network with Osmux enabled +[graphviz] +---- +include::network_osmux_aoip.dot[] +---- + +.MO-call with Osmux enable on 3GPP AoIP +[mscgen] +---- +include::mo_call_osmux_aoip.msc[] +---- + +=== SCCPLite network setup with Osmux + +[[fig-network-osmux-sccplite]] +.Sample node diagram of a 3GPP AoIP using A/IP with IPA/SCCPlite network with Osmux enabled +[graphviz] +---- +include::network_osmux_sccplite.dot[] +---- + +.MO-call with Osmux enable on 3GPP AoIP using A/IP with IPA/SCCPlite +["mscgen"] +---- +include::mo_call_osmux_sccplite.msc[] +---- + +=== SCCPLite network setup with Osmux + BSC-NAT + +[[fig-network-osmux-sccplite-nat]] +.Sample node diagram of a 3GPP AoIP using A/IP with IPA/SCCPlite network and BSC-NAT with Osmux enabled +[graphviz] +---- +include::network_osmux_sccplite_nat.dot[] +---- + +.MO-call with Osmux enable on 3GPP AoIP using A/IP with IPA/SCCPlite with a BSC-NAT between BSC and MSC +["mscgen"] +---- +include::mo_call_osmux_sccplite_nat.msc[] +---- + +include::mgcp_extension_osmux.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e Gerrit-Change-Number: 14839 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:02:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 15:02:36 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support TRXD v1 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14657 ) Change subject: Transceiver: Support TRXD v1 ...................................................................... Patch Set 13: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 13 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 15:02:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:02:51 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 15:02:51 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): use trxd_hdr_common for message parsing In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14786 ) Change subject: driveTxPriorityQueue(): use trxd_hdr_common for message parsing ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If6a93e2b7fc9ada55edbdd16352cd4f7040e3d2a Gerrit-Change-Number: 14786 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 15:02:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:03:02 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 15:03:02 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): check if message header format is supported In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14787 ) Change subject: driveTxPriorityQueue(): check if message header format is supported ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I17abf95f5e23236abccc50476cd59931580f5cd3 Gerrit-Change-Number: 14787 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 15:03:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:03:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 15:03:22 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Initialize mExtRACH in constructor In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14814 ) Change subject: Transceiver: Initialize mExtRACH in constructor ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I17286570a9a6db695a75147e5cbb18c9da7d0fe6 Gerrit-Change-Number: 14814 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 19 Jul 2019 15:03:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:03:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 15:03:35 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): enrich logging message In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14788 ) Change subject: driveTxPriorityQueue(): enrich logging message ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If25c2171f7d1ab98d65f0dbf93d0d8a5a635caf7 Gerrit-Change-Number: 14788 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 15:03:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:04:13 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 15:04:13 +0000 Subject: Change in ...osmo-gsm-manuals[master]: Makefile.asciidoc.inc: Export commondir attribute to asciidoc files In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14838 ) Change subject: Makefile.asciidoc.inc: Export commondir attribute to asciidoc files ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14838 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ifc2fdaf1a87d0715213b4eab13c6c9a4f8a987fd Gerrit-Change-Number: 14838 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 15:04:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:16:14 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 15:16:14 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): check if message header format is supported In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14787 ) Change subject: driveTxPriorityQueue(): check if message header format is supported ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I17abf95f5e23236abccc50476cd59931580f5cd3 Gerrit-Change-Number: 14787 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 15:16:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:16:26 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 15:16:26 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): enrich logging message In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14788 ) Change subject: driveTxPriorityQueue(): enrich logging message ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If25c2171f7d1ab98d65f0dbf93d0d8a5a635caf7 Gerrit-Change-Number: 14788 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 15:16:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:16:35 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 15:16:35 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Support TRXD v1 In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14657 ) Change subject: Transceiver: Support TRXD v1 ...................................................................... Transceiver: Support TRXD v1 Related: OS#4006 Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 --- M Transceiver52M/Transceiver.cpp M Transceiver52M/proto_trxd.c M Transceiver52M/proto_trxd.h 3 files changed, 98 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 080afd1..b73e698 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -618,6 +618,10 @@ bi->toa = 0.0; bi->noise = 0.0; bi->idle = false; + bi->modulation = MODULATION_GMSK; + bi->tss = 0; /* TODO: we only support tss 0 right now */ + bi->tsc = 0; + bi->ci = 0.0; /* Select the diversity channel with highest energy */ for (size_t i = 0; i < radio_burst->chans(); i++) { @@ -665,13 +669,18 @@ type = (CorrType) rc; bi->toa = ebp.toa; + bi->tsc = ebp.tsc; + bi->ci = ebp.ci; rxBurst = demodAnyBurst(*burst, mSPSRx, ebp.amp, ebp.toa, type); /* EDGE demodulator returns 444 (gSlotLen * 3) bits */ - if (rxBurst->size() == EDGE_BURST_NBITS) + if (rxBurst->size() == EDGE_BURST_NBITS) { + bi->modulation = MODULATION_8PSK; bi->nbits = EDGE_BURST_NBITS; - else /* size() here is actually gSlotLen + 8, due to guard periods */ + } else { /* size() here is actually gSlotLen + 8, due to guard periods */ + bi->modulation = MODULATION_GMSK; bi->nbits = gSlotLen; + } // Convert -1..+1 soft bits to 0..1 soft bits vectorSlicer(bi->rx_burst, rxBurst->begin(), bi->nbits); @@ -980,6 +989,7 @@ << " noise: " << std::setw(5) << std::setprecision(1) << (bi->noise - rssiOffset) << "dBFS/" << std::setw(6) << -bi->noise << "dBm" << " TOA: " << std::setw(5) << std::setprecision(2) << bi->toa + << " C/I: " << std::setw(5) << std::setprecision(2) << bi->ci << "dB" << " bits: " << os; } @@ -996,6 +1006,9 @@ case 0: trxd_send_burst_ind_v0(chan, mDataSockets[chan], &bi); break; + case 1: + trxd_send_burst_ind_v1(chan, mDataSockets[chan], &bi); + break; default: OSMO_ASSERT(false); } diff --git a/Transceiver52M/proto_trxd.c b/Transceiver52M/proto_trxd.c index 5cf22e6..fff23da 100644 --- a/Transceiver52M/proto_trxd.c +++ b/Transceiver52M/proto_trxd.c @@ -43,6 +43,21 @@ osmo_store16be(toa_int, &v0->toa); } +static void trxd_fill_v1_specific(struct trxd_hdr_v1_specific *v1, const struct trx_ul_burst_ind *bi) +{ + int16_t ci_int_cB; + + /* deciBels->centiBels, round to closest integer */ + ci_int_cB = (int16_t)((bi->ci * 10) + 0.5); + + v1->idle = !!bi->idle; + v1->modulation = (bi->modulation == MODULATION_GMSK) ? + TRXD_MODULATION_GMSK(bi->tss) : + TRXD_MODULATION_8PSK(bi->tss); + v1->tsc = bi->tsc; + osmo_store16be(ci_int_cB, &v1->ci); +} + static void trxd_fill_burst_normalized255(uint8_t* soft_bits, const struct trx_ul_burst_ind *bi) { unsigned i; @@ -75,3 +90,28 @@ } return true; } + +bool trxd_send_burst_ind_v1(size_t chan, int fd, const struct trx_ul_burst_ind *bi) { + int rc; + size_t buf_len; + + buf_len = sizeof(struct trxd_hdr_v1); + if (!bi->idle) + buf_len += bi->nbits; + char buf[buf_len]; + + struct trxd_hdr_v1* pkt = (struct trxd_hdr_v1*)buf; + trxd_fill_common(&pkt->common, bi, 1); + trxd_fill_v0_specific(&pkt->v0, bi); + trxd_fill_v1_specific(&pkt->v1, bi); + + if (!bi->idle) + trxd_fill_burst_normalized255(&pkt->soft_bits[0], bi); + + rc = write(fd, buf, buf_len); + if (rc <= 0) { + CLOGCHAN(chan, DMAIN, LOGL_NOTICE, "mDataSockets write(%d) failed: %d\n", fd, rc); + return false; + } + return true; +} diff --git a/Transceiver52M/proto_trxd.h b/Transceiver52M/proto_trxd.h index 2e5ad52..7eb5dac 100644 --- a/Transceiver52M/proto_trxd.h +++ b/Transceiver52M/proto_trxd.h @@ -11,6 +11,16 @@ #define MAX_RX_BURST_BUF_SIZE 444 /* 444 = EDGE_BURST_NBITS */ +enum Modulation { + MODULATION_GMSK, + MODULATION_8PSK, +/* Not supported yet: + MODULATION_AQPSK, + MODULATION_16QAM, + MODULATION_32QAM +*/ +}; + struct trx_ul_burst_ind { float rx_burst[MAX_RX_BURST_BUF_SIZE]; /* soft bits normalized 0..1 */ unsigned nbits; // number of symbols per slot in rxBurst, not counting guard periods @@ -20,12 +30,17 @@ double toa; // in symbols double noise; // noise level in dBFS bool idle; // true if no valid burst is included + enum Modulation modulation; // modulation type + uint8_t tss; // training sequence set + uint8_t tsc; // training sequence code + float ci; // Carrier-to-Interference ratio, in dB }; bool trxd_send_burst_ind_v0(size_t chan, int fd, const struct trx_ul_burst_ind *bi); +bool trxd_send_burst_ind_v1(size_t chan, int fd, const struct trx_ul_burst_ind *bi); /* The latest supported TRXD header format version */ -#define TRX_DATA_FORMAT_VER 0 +#define TRX_DATA_FORMAT_VER 1 struct trxd_hdr_common { #if OSMO_IS_LITTLE_ENDIAN @@ -50,3 +65,30 @@ struct trxd_hdr_v0_specific v0; uint8_t soft_bits[0]; } __attribute__ ((packed)); + + +#define TRXD_MODULATION_GMSK(ts_set) (0b0000 | (ts_set & 0b0011)) +#define TRXD_MODULATION_8PSK(ts_set) (0b0100 | (ts_set & 0b0001)) +#define TRXD_MODULATION_AQPSK(ts_set) (0b0110 | (ts_set & 0b0001)) +#define TRXD_MODULATION_16QAM(ts_set) (0b1000 | (ts_set & 0b0001)) +#define TRXD_MODULATION_32QAM(ts_set) (0b1010 | (ts_set & 0b0001)) + +struct trxd_hdr_v1_specific { +#if OSMO_IS_LITTLE_ENDIAN + uint8_t tsc:3, + modulation:4, + idle:1; +#elif OSMO_IS_BIG_ENDIAN + uint8_t idle:1, + modulation:4, + tsc:3; +#endif + int16_t ci; /* big endian, in centiBels */ +} __attribute__ ((packed)); + +struct trxd_hdr_v1 { + struct trxd_hdr_common common; + struct trxd_hdr_v0_specific v0; + struct trxd_hdr_v1_specific v1; + uint8_t soft_bits[0]; +} __attribute__ ((packed)); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14657 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 Gerrit-Change-Number: 14657 Gerrit-PatchSet: 13 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:16:36 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 15:16:36 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14785 ) Change subject: driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN ...................................................................... driveTxPriorityQueue(): cosmetic: use proper type for TDMA TN Change-Id: I8396004616754f84fb465c972fde9e91b18cc49b --- M Transceiver52M/Transceiver.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index b73e698..1e0339b 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -935,7 +935,7 @@ } int timeSlot = (int) buffer[0]; - uint64_t frameNum = 0; + uint32_t frameNum = 0; for (int i = 0; i < 4; i++) frameNum = (frameNum << 8) | (0x0ff & buffer[i+1]); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8396004616754f84fb465c972fde9e91b18cc49b Gerrit-Change-Number: 14785 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:16:36 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 15:16:36 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): use trxd_hdr_common for message parsing In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14786 ) Change subject: driveTxPriorityQueue(): use trxd_hdr_common for message parsing ...................................................................... driveTxPriorityQueue(): use trxd_hdr_common for message parsing Change-Id: If6a93e2b7fc9ada55edbdd16352cd4f7040e3d2a --- M Transceiver52M/Transceiver.cpp 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 1e0339b..368ed3f 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -33,6 +33,7 @@ #include #include +#include } #ifdef HAVE_CONFIG_H @@ -914,6 +915,8 @@ int msgLen; int burstLen; char buffer[EDGE_BURST_NBITS + 50]; + struct trxd_hdr_common *chdr; + uint32_t fn; // check data socket msgLen = read(mDataSockets[chan], buffer, sizeof(buffer)); @@ -934,12 +937,13 @@ return false; } - int timeSlot = (int) buffer[0]; - uint32_t frameNum = 0; - for (int i = 0; i < 4; i++) - frameNum = (frameNum << 8) | (0x0ff & buffer[i+1]); + /* Common header part: HDR version, TDMA TN & FN */ + chdr = (struct trxd_hdr_common *) buffer; - LOG(DEBUG) << "rcvd. burst at: " << GSM::Time(frameNum,timeSlot); + /* Convert TDMA FN to the host endianness */ + fn = osmo_load32be(&chdr->fn); + + LOG(DEBUG) << "rcvd. burst at: " << GSM::Time(fn, chdr->tn); int RSSI = (int) buffer[5]; BitVector newBurst(burstLen); @@ -948,7 +952,7 @@ while (itr < newBurst.end()) *itr++ = *bufferItr++; - GSM::Time currTime = GSM::Time(frameNum,timeSlot); + GSM::Time currTime = GSM::Time(fn, chdr->tn); addRadioVector(chan, newBurst, RSSI, currTime); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If6a93e2b7fc9ada55edbdd16352cd4f7040e3d2a Gerrit-Change-Number: 14786 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:16:37 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 15:16:37 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): check if message header format is supported In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14787 ) Change subject: driveTxPriorityQueue(): check if message header format is supported ...................................................................... driveTxPriorityQueue(): check if message header format is supported Change-Id: I17abf95f5e23236abccc50476cd59931580f5cd3 --- M Transceiver52M/Transceiver.cpp 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 368ed3f..a12c5bc 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -943,6 +943,18 @@ /* Convert TDMA FN to the host endianness */ fn = osmo_load32be(&chdr->fn); + /* Make sure we support the received header format */ + switch (chdr->version) { + case 0: + /* Version 1 has the same format */ + case 1: + break; + + default: + LOG(ERR) << "Rx TRXD message with unknown header version " << chdr->version; + return false; + } + LOG(DEBUG) << "rcvd. burst at: " << GSM::Time(fn, chdr->tn); int RSSI = (int) buffer[5]; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I17abf95f5e23236abccc50476cd59931580f5cd3 Gerrit-Change-Number: 14787 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:16:37 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 15:16:37 +0000 Subject: Change in ...osmo-trx[master]: driveTxPriorityQueue(): enrich logging message In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14788 ) Change subject: driveTxPriorityQueue(): enrich logging message ...................................................................... driveTxPriorityQueue(): enrich logging message Change-Id: If25c2171f7d1ab98d65f0dbf93d0d8a5a635caf7 --- M Transceiver52M/Transceiver.cpp 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index a12c5bc..0a832f0 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -955,7 +955,9 @@ return false; } - LOG(DEBUG) << "rcvd. burst at: " << GSM::Time(fn, chdr->tn); + LOG(DEBUG) << "Rx TRXD message (hdr_ver=" << chdr->version << "): " + << "fn=" << fn << ", tn=" << chdr->tn << ", " + << "burst_len=" << burstLen; int RSSI = (int) buffer[5]; BitVector newBurst(burstLen); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If25c2171f7d1ab98d65f0dbf93d0d8a5a635caf7 Gerrit-Change-Number: 14788 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:16:38 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 15:16:38 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Initialize mExtRACH in constructor In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14814 ) Change subject: Transceiver: Initialize mExtRACH in constructor ...................................................................... Transceiver: Initialize mExtRACH in constructor Doing so should make Coverity happy: >>> CID 200212: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "mExtRACH" is not initialized in this constructor nor in any functions that it calls. The current status is actually harmless since the field will be set during init() time, and the variable is never used before init() is called. Fixes: Coverity CID#200212 Change-Id: I17286570a9a6db695a75147e5cbb18c9da7d0fe6 --- M Transceiver52M/Transceiver.cpp 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 0a832f0..17e0476 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -124,7 +124,8 @@ : mBasePort(wBasePort), mLocalAddr(TRXAddress), mRemoteAddr(GSMcoreAddress), mClockSocket(-1), mTransmitLatency(wTransmitLatency), mRadioInterface(wRadioInterface), rssiOffset(wRssiOffset), stackSize(wStackSize), - mSPSTx(tx_sps), mSPSRx(rx_sps), mChans(chans), mEdge(false), mOn(false), mForceClockInterface(false), + mSPSTx(tx_sps), mSPSRx(rx_sps), mChans(chans), mExtRACH(false), mEdge(false), + mOn(false), mForceClockInterface(false), mTxFreq(0.0), mRxFreq(0.0), mTSC(0), mMaxExpectedDelayAB(0), mMaxExpectedDelayNB(0), mWriteBurstToDiskMask(0), mVersionTRXD(0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I17286570a9a6db695a75147e5cbb18c9da7d0fe6 Gerrit-Change-Number: 14814 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:21:42 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 15:21:42 +0000 Subject: Change in ...osmo-bsc[master]: doc: Add Osmux documentation to User Manual Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14840 Change subject: doc: Add Osmux documentation to User Manual ...................................................................... doc: Add Osmux documentation to User Manual Depends: osmo-gsm-manuals.git f3a734e6777a902abfb03257277454c7a879aeb7 Change-Id: I75dcdddc713b0dc43e2ba577ca377c20fc511f38 --- A doc/manuals/chapters/osmux_bsc.adoc M doc/manuals/osmobsc-usermanual.adoc 2 files changed, 43 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/40/14840/1 diff --git a/doc/manuals/chapters/osmux_bsc.adoc b/doc/manuals/chapters/osmux_bsc.adoc new file mode 100644 index 0000000..7c73903 --- /dev/null +++ b/doc/manuals/chapters/osmux_bsc.adoc @@ -0,0 +1,40 @@ +include::{commondir}/chapters/osmux/osmux.adoc[] + +=== Osmux Support in OsmoBSC + +==== OsmoBSC in a A/IP with IPA/SCCPlite network setup + +In this kind of setup, Osmux is transparent to {program-name} and no specific +configuration is required here, since the CN-side of the BSC-attached MGW is +managed directly by the MSC. + +So, in this case, only MSC and MGW (both for MSC-attached one and BSC-attached +one) need to be configured explicitly. + +==== OsmoBSC in a 3GPP AoIP network setup + +Osmux usage in {program-name} in managed through the VTY command `osmux +(on|off|only)`. Once enabled (`on` or `only`), {program-name} will start +appending the _Osmux Support_ IE in _BSSMAP RESET_ and _BSSMAP RESET ACK_ +message towards the MSC in order to announce it supports Osmux. This way, the +MSC can decide whether to use Osmux or not based on this information when +setting up a call (this time using _Osmux CID_ IE). + +{program-name} will behave differently during call set up based on the VTY +command presented above: + +* `off`: If _BSSMAP Assign Request_ from MSC contains _Osmux CID_ IE, meaning + MSC wants to use Osmux for this call, then {program-name} will reject the + assignment and the call set up will fail. +* `on`: BSC will support and accept both Osmux and non-Osmux (RTP) upon call set + up. If _BSSMAP Assign Request_ from MSC contains _Osmux CID_ IE, + {program-name} will instruct its MGW to set up an Osmux connection on the + CN-side of the MGCP endpoint, and will provide the MSC with its _recvCID_ + through the extension IE _Osmux CID_ appened to the _BSSMAP Assign Complete_ + message. On the other hand, if _BSSMAP Assign Request_ doesn't contain an + _Osmux CID_ IE, {program-name} will instruct its MGW to set up a regular RTP + connection on the CN-side of the MGCP endpoint. +* `only`: Same as per `on`, except that {program-name} will accept only Osmux + calls on the CN-side, this is, if _BSSMAP Assign Request_ from MSC doesn't + contain an _Osmux CID_ IE, it will reject the assignment and the call set up + will fail. diff --git a/doc/manuals/osmobsc-usermanual.adoc b/doc/manuals/osmobsc-usermanual.adoc index 3515aaa..766a11f 100644 --- a/doc/manuals/osmobsc-usermanual.adoc +++ b/doc/manuals/osmobsc-usermanual.adoc @@ -1,4 +1,5 @@ :gfdl-enabled: +:program-name: OsmoBSC OsmoBSC User Manual =================== @@ -35,6 +36,8 @@ include::./common/chapters/cell-broadcast.adoc[] +include::{srcdir}/chapters/osmux_bsc.adoc[] + include::./common/chapters/port_numbers.adoc[] include::./common/chapters/bibliography.adoc[] @@ -42,4 +45,3 @@ include::./common/chapters/glossary.adoc[] include::./common/chapters/gfdl.adoc[] - -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75dcdddc713b0dc43e2ba577ca377c20fc511f38 Gerrit-Change-Number: 14840 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 15:58:24 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 19 Jul 2019 15:58:24 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling In-Reply-To: References: Message-ID: Hello pespin, ipse, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 to look at the new patch set (#6). Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Clarify and refactor link quality (C/I) handling The radio link quality is defined by C/I (Carrier-to-Interference ratio), which is computed from the training sequence of each received burst, by comparing the "ideal" training sequence with the actual (received) one. Link quality measurements are used by L1SAP to filter out "ghost" Access Bursts, and by the link quality adaptation algorithms. One can define minimum link quality values using the VTY interface. On the VTY interface we expect integer C/I values in centiBels (cB, 10e-2 B), while the internal structures are using float values in deciBels (dB, 10e-1 B). Some PHYs (sysmo, octphy, oc2g, and litecell15) expose C/I measurements in deciBels, while on the L1SAP interface we finally send then in centiBels. Let's avoid this confusion and stick to a single format, that will be used by the internal logic of OsmoBTS - integer values (int16_t) in centiBels. This will give us the range of: -32768 .. 32767 centiBels, or -3276.8 .. 3276.7 deciBels, which is certainly sufficient. Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 --- M doc/manuals/vty/bts_vty_reference.xml M include/osmo-bts/gsm_data_shared.h M src/common/bts.c M src/common/l1sap.c M src/common/pcu_sock.c M src/common/vty.c M src/osmo-bts-litecell15/l1_if.c M src/osmo-bts-oc2g/l1_if.c M src/osmo-bts-sysmo/l1_if.c 9 files changed, 22 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/86/14686/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 16:01:30 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 16:01:30 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 ) Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 16:01:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 16:03:22 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 16:03:22 +0000 Subject: Change in ...osmo-msc[master]: doc: Add Osmux documentation to User Manual Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14841 Change subject: doc: Add Osmux documentation to User Manual ...................................................................... doc: Add Osmux documentation to User Manual Depends: osmo-gsm-manuals.git f3a734e6777a902abfb03257277454c7a879aeb7 Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 --- A doc/manuals/chapters/osmux_msc.adoc M doc/manuals/osmomsc-usermanual.adoc 2 files changed, 64 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/14841/1 diff --git a/doc/manuals/chapters/osmux_msc.adoc b/doc/manuals/chapters/osmux_msc.adoc new file mode 100644 index 0000000..1d22bba --- /dev/null +++ b/doc/manuals/chapters/osmux_msc.adoc @@ -0,0 +1,62 @@ +include::{commondir}/chapters/osmux/osmux.adoc[] + +=== Osmux Support in OsmoMSC + +==== OsmoMSC in a A/IP with IPA/SCCPlite network setup + +In this kind of setup, the CN side of BSC co-located MGW is managed by the MSC, +meaning the use of Osmux is transparent to BSC since MSC takes care of both peer +MGW connections. Moreover, in this case the MSC has no dynamic information on +Osmux support in the BSC co-located MGW until `CRCX` time, which means +configuration on both nodes need to be carefully set up so they can work +together. + +Osmux usage in {program-name} in managed through the VTY command `osmux +(on|off|only)`. Since there's no dynamic information on Osmux support, it may be +required in the future to have an extra VTY command which can be set per BSC to +fine-tune which ones should use Osmux and which shouldn't. + +{program-name} will behave differently during call set up based on the VTY +command presented above: + +* `off`: {program-name} won't include an `X-Osmux` extension to `CRCX` sent to + the BSC co-located MGW when configuring the CN side of the MGW endpoint. If + the MGW answers with a `CRCX ACK` containing an `X-Osmux`, {program-name} will + cancel the call establishment. +* `on`: {program-name} will initially configure its co-located MGW to use Osmux, then + similarly send a `CRCX` with an `X-Osmux` extension towrds the BSC co-located + MGW. Under this configuration, if the BSC co-located MGW didn't support Osmux, + it could send a `CRCX ACK` without `X-Osmux` extension or fail (depending on + its own configuration), and {program-name} could choose to re-create its local + connection as non-Osmux (RTP) (and possibly try again against BSC co-located + MGW), but this behavior is currently not implemented. As a result, currently + `on` behaves the same as `only`. +* `only`: {program-name} will configure its co-located MGW as well as the BSC + co-located MGW to use Osmux by including the `X-Osmux` MGCP extension. If MGW + rejects to use Osmux, {program-name} will reject the call and the call + establishment will fail. + +==== OsmoMSC in a 3GPP AoIP network setup + +Osmux usage in {program-name} in managed through the VTY command `osmux +(on|off|only)`. Once enabled (`on` or `only`), {program-name} will start +appending the _Osmux Support_ IE in _BSSMAP RESET_ and _BSSMAP RESET ACK_ +message towards the BSC in order to announce it supports Osmux, and BSC will do +the same. This way, the MSC can decide whether to use Osmux or not based on this +information when setting up a call (this time using _Osmux CID_ IE). + +{program-name} will behave differently during call set up based on the VTY +command presented above: + +* `off`: {program-name} won't use Osmux. That is, it will send a _BSSMAP Assign + Request_ without the _Osmux CID_ IE, and will send a `CRCX` without `X-Osmux` + extension towards its co-located MGW. +* `on`: If BSC announced Osmux support to {program-name} during _BSSMAP RESET_ + time, then {program-name} will set up the call to use Osmux (by adding + `X-Osmux` to MGCP `CRCX` and _Osmux CID_ IE to _BSSMAP Assign Request_). If + the BSC didn't announce Osmux support to {program-name}, then {program-name} + will use RTP to set up the call (by avoiding addition of previously described + bits). +* `only`: Same as per `on`, except that {program-name} will allow to set up only + Osmux calls on the CN-side, this is, it will reject to set up voice calls for + BSC which didn't announce Osmux support. diff --git a/doc/manuals/osmomsc-usermanual.adoc b/doc/manuals/osmomsc-usermanual.adoc index 3c69d7b..d680a51 100644 --- a/doc/manuals/osmomsc-usermanual.adoc +++ b/doc/manuals/osmomsc-usermanual.adoc @@ -28,6 +28,8 @@ include::./common/chapters/mncc.adoc[] +include::{srcdir}/chapters/osmux_msc.adoc[] + include::./common/chapters/control_if.adoc[] include::./common/chapters/gsup.adoc[] @@ -39,4 +41,3 @@ include::./common/chapters/glossary.adoc[] include::./common/chapters/gfdl.adoc[] - -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 Gerrit-Change-Number: 14841 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 16:07:57 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 19 Jul 2019 16:07:57 +0000 Subject: Change in ...osmo-mgw[master]: doc: Add Osmux documentation to OsmoMGW User Manual In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14681 ) Change subject: doc: Add Osmux documentation to OsmoMGW User Manual ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 Gerrit-Change-Number: 14681 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 19 Jul 2019 16:07:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 16:59:30 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 16:59:30 +0000 Subject: Change in ...simtrace2[master]: contrib/jenkins.sh: also push the .elf files to the ftp (for gdb/objd... Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/14842 Change subject: contrib/jenkins.sh: also push the .elf files to the ftp (for gdb/objdump) ...................................................................... contrib/jenkins.sh: also push the .elf files to the ftp (for gdb/objdump) Change-Id: Ibccf92e30c84f34ff61b3e823151cf33f20a1c4f --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/42/14842/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 99a6f00..1f6fe15 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -64,7 +64,7 @@ [rita.osmocom.org]:48 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIK8iivY70EiR5NiGChV39gRLjNpC8lvu1ZdHtdMw2zuX EOF SSH_COMMAND="ssh -o 'UserKnownHostsFile=$WORKSPACE/known_hosts' -p 48" - rsync -avz --delete -e "$SSH_COMMAND" $TOPDIR/firmware/bin/*.bin binaries at rita.osmocom.org:web-files/simtrace2/firmware/ + rsync -avz --delete -e "$SSH_COMMAND" $TOPDIR/firmware/bin/*.{bin,elf} binaries at rita.osmocom.org:web-files/simtrace2/firmware/ fi echo -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/14842 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ibccf92e30c84f34ff61b3e823151cf33f20a1c4f Gerrit-Change-Number: 14842 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 16:59:31 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 19 Jul 2019 16:59:31 +0000 Subject: Change in ...simtrace2[master]: contrib/jenkins.sh: don't delete old builds from ftp Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/14843 Change subject: contrib/jenkins.sh: don't delete old builds from ftp ...................................................................... contrib/jenkins.sh: don't delete old builds from ftp Change-Id: I2b34b5d4525d62564d34a6583ee3739b82c07c68 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/43/14843/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 1f6fe15..16420f7 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -64,7 +64,7 @@ [rita.osmocom.org]:48 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIK8iivY70EiR5NiGChV39gRLjNpC8lvu1ZdHtdMw2zuX EOF SSH_COMMAND="ssh -o 'UserKnownHostsFile=$WORKSPACE/known_hosts' -p 48" - rsync -avz --delete -e "$SSH_COMMAND" $TOPDIR/firmware/bin/*.{bin,elf} binaries at rita.osmocom.org:web-files/simtrace2/firmware/ + rsync -avz -e "$SSH_COMMAND" $TOPDIR/firmware/bin/*.{bin,elf} binaries at rita.osmocom.org:web-files/simtrace2/firmware/ fi echo -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/14843 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I2b34b5d4525d62564d34a6583ee3739b82c07c68 Gerrit-Change-Number: 14843 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Fri Jul 19 18:07:25 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 19 Jul 2019 18:07:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d3206e94bd9f_d3a6545f024574e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 147s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 147s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 147s] dh_installdocs [ 147s] dh_installchangelogs [ 147s] dh_python2 [ 147s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 147s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 147s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 147s] dh_python3 [ 147s] debian/rules override_dh_installinit [ 147s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 147s] # Install service file with different name than package name: [ 147s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 147s] dh_installinit --name=osmo-ctrl2cgi [ 147s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script nor default file not found [ 147s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 147s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 147s] make: *** [debian/rules:4: binary] Error 2 [ 147s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 147s] [ 147s] lamb61 failed "build osmo-python-tests_0.0.9.20190719.dsc" at Fri Jul 19 18:07:07 UTC 2019. [ 147s] [ 147s] ### VM INTERACTION START ### [ 150s] [ 135.556223] sysrq: SysRq : Power Off [ 150s] [ 135.564951] reboot: Power down [ 150s] ### VM INTERACTION END ### [ 151s] [ 151s] lamb61 failed "build osmo-python-tests_0.0.9.20190719.dsc" at Fri Jul 19 18:07:12 UTC 2019. [ 151s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 19 21:50:24 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 19 Jul 2019 21:50:24 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d323b3e1e90a_d3a6545f026409f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 87s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 87s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 87s] dh_installdocs [ 87s] dh_installchangelogs [ 87s] dh_python2 [ 87s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 87s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 87s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 87s] dh_python3 [ 87s] debian/rules override_dh_installinit [ 87s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 87s] # Install service file with different name than package name: [ 87s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 87s] dh_installinit --name=osmo-ctrl2cgi [ 87s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script nor default file not found [ 87s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 87s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 87s] make: *** [debian/rules:4: binary] Error 2 [ 87s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 87s] [ 87s] sheep84 failed "build osmo-python-tests_0.0.9.20190719.dsc" at Fri Jul 19 21:50:09 UTC 2019. [ 87s] [ 87s] ### VM INTERACTION START ### [ 90s] [ 80.603978] sysrq: SysRq : Power Off [ 90s] [ 80.611175] reboot: Power down [ 90s] ### VM INTERACTION END ### [ 90s] [ 90s] sheep84 failed "build osmo-python-tests_0.0.9.20190719.dsc" at Fri Jul 19 21:50:12 UTC 2019. [ 90s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Jul 19 23:27:48 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 19 Jul 2019 23:27:48 +0000 Subject: Change in ...osmo-bsc[master]: turn -Werror=null-dereference into a warning Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14844 Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Related: OS#4123 Change-Id: I5a78e75f6fb7ae243ef7d9b093266aeccf0a50a3 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/44/14844/1 diff --git a/configure.ac b/configure.ac index cdee90c..694a9a7 100644 --- a/configure.ac +++ b/configure.ac @@ -117,7 +117,7 @@ AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"]) +AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14844 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5a78e75f6fb7ae243ef7d9b093266aeccf0a50a3 Gerrit-Change-Number: 14844 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 23:28:40 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 19 Jul 2019 23:28:40 +0000 Subject: Change in ...osmo-bsc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: Hoernchen has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14844 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14844 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5a78e75f6fb7ae243ef7d9b093266aeccf0a50a3 Gerrit-Change-Number: 14844 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-CC: Jenkins Builder Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 23:28:58 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 19 Jul 2019 23:28:58 +0000 Subject: Change in ...osmo-sgsn[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 to look at the new patch set (#4). Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed "error: potential null pointer dereference" Related: OS#4123 Change-Id: I4d1219bf84d3b8dcaf925a60cf54abe733fba263 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/34/14834/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4d1219bf84d3b8dcaf925a60cf54abe733fba263 Gerrit-Change-Number: 14834 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 23:29:06 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 19 Jul 2019 23:29:06 +0000 Subject: Change in ...osmo-msc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/14835 to look at the new patch set (#4). Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Related: OS#4123 Change-Id: I615bb5be3671022c6b821575a61f945b50e8f2a5 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/35/14835/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14835 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I615bb5be3671022c6b821575a61f945b50e8f2a5 Gerrit-Change-Number: 14835 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 23:29:14 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 19 Jul 2019 23:29:14 +0000 Subject: Change in ...osmo-mgw[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/14836 to look at the new patch set (#4). Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Related: OS#4123 Change-Id: Ib157bd2e110b271dbe5ac928c98251e016477f56 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/36/14836/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib157bd2e110b271dbe5ac928c98251e016477f56 Gerrit-Change-Number: 14836 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 23:29:22 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 19 Jul 2019 23:29:22 +0000 Subject: Change in ...osmo-bsc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/14833 to look at the new patch set (#4). Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Related: OS#4123 Change-Id: I571a85b6ea53af7661248afd84e61cf34b7b5641 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/33/14833/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14833 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I571a85b6ea53af7661248afd84e61cf34b7b5641 Gerrit-Change-Number: 14833 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 19 23:47:23 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Fri, 19 Jul 2019 23:47:23 +0000 Subject: Change in ...libosmocore[master]: tell ubsan to ignore SUN_LEN In-Reply-To: References: Message-ID: Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14682 to look at the new patch set (#3). Change subject: tell ubsan to ignore SUN_LEN ...................................................................... tell ubsan to ignore SUN_LEN ubsan will report undefined behavior due to the SUN_LEN macros interaction with a null pointer, so let's tell ubsan to ignore this function. After carefully reviewing the final publically availlable drafts of the C99,C11 and C18 standards I can confirm that dereferencing null pointers is still undefined behavior, as such ubsan will always warn with absolutely every existing compiler version. Since the sanitizers are periodically synced between llvm and gcc I'm also fairly confident that rebuilding everything with compiler_rt to use the integrated sanitizers would result in the same message. I sincerly hope that this explanation provides to be sufficient, If not I'd be willing to show up at the next llvm dev meeting to provide quotes from actual sanitizer developers to back up these claims. Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 --- M src/socket.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/14682/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 Gerrit-Change-Number: 14682 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Sat Jul 20 02:36:05 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 20 Jul 2019 02:36:05 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Unstable/x86_64 In-Reply-To: References: Message-ID: <5d327e2b8202_d3a6545f0308563@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Unstable/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 84s] rm -rf /usr/src/packages/BUILD/debian/python3-osmopy-utils/usr/lib [ 84s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 84s] dh_installdocs [ 84s] dh_installchangelogs [ 84s] dh_python2 [ 85s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmodumpdoc.py [ 85s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestvty.py [ 85s] I: dh_python2 tools:114: replacing shebang in debian/python2-osmopy-utils/usr/bin/osmotestconfig.py [ 85s] dh_python3 [ 85s] debian/rules override_dh_installinit [ 85s] make[1]: Entering directory '/usr/src/packages/BUILD' [ 85s] # Install service file with different name than package name: [ 85s] # https://unix.stackexchange.com/questions/306234/is-it-possible-to-install-two-services-for-one-package-using-dh-installinit-how [ 85s] dh_installinit --name=osmo-ctrl2cgi [ 85s] dh_installinit: --name=osmo-ctrl2cgi option specified, but init script nor default file not found [ 85s] make[1]: *** [debian/rules:19: override_dh_installinit] Error 255 [ 85s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 85s] make: *** [debian/rules:4: binary] Error 2 [ 85s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 85s] [ 85s] sheep83 failed "build osmo-python-tests_0.0.9.20190720.dsc" at Sat Jul 20 02:35:48 UTC 2019. [ 85s] [ 85s] ### VM INTERACTION START ### [ 88s] [ 77.736161] sysrq: SysRq : Power Off [ 88s] [ 77.742165] reboot: Power down [ 88s] ### VM INTERACTION END ### [ 88s] [ 88s] sheep83 failed "build osmo-python-tests_0.0.9.20190720.dsc" at Sat Jul 20 02:35:52 UTC 2019. [ 88s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 20 02:42:05 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 20 Jul 2019 02:42:05 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in Debian_10/i586 In-Reply-To: References: Message-ID: <5d327f90c124e_d3a6545f030926e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_10/i586 Package network:osmocom:nightly/libosmo-netif failed to build in Debian_10/i586 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 185s] | am__nodep='' [ 185s] | am__quote='' [ 185s] | am__tar='$${TAR-tar} chof - "$$tardir"' [ 185s] | am__untar='$${TAR-tar} xf -' [ 185s] | bindir='${exec_prefix}/bin' [ 185s] | build='i686-pc-linux-gnu' [ 185s] | build_alias='i686-linux-gnu' [ 185s] | build_cpu='i686' [ 185s] | build_os='linux-gnu' [ 185s] | build_vendor='pc' [ 185s] | datadir='${datarootdir}' [ 185s] | datarootdir='${prefix}/share' [ 185s] | docdir='${datarootdir}/doc/${PACKAGE_TARNAME}' [ 185s] | dvidir='${docdir}' [ 185s] | exec_prefix='${prefix}' [ 185s] | host='i686-pc-linux-gnu' [ 185s] | host_alias='' [ 185s] | host_cpu='i686' [ 185s] | host_os='linux-gnu' [ 185s] | host_vendor='pc' [ 185s] | htmldir='${docdir}' [ 185s] | includedir='${prefix}/include' [ 185s] | infodir='${prefix}/share/info' [ 185s] | install_sh='${SHELL} /usr/[ 158.396290] sysrq: SysRq : Power Off [ 185s] [ 158.407120] reboot: Power down [ 188s] ### VM INTERACTION END ### [ 189s] [ 189s] cloud106 failed "build libosmo-netif_0.5.0.2.6563.dsc" at Sat Jul 20 02:41:52 UTC 2019. [ 189s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sat Jul 20 03:58:57 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 20 Jul 2019 03:58:57 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d3291a0556c0_d3a6545f031228c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 599s] | This file was extended by libosmocore config.status 1.1.0.82-00a55a, which was [ 599s] | generated by GNU Autoconf 2.69. Invocation command line was [ 599s] | [ 599s] | CONFIG_FILES = [ 599s] | CONFIG_HEADERS = [ 599s] | CONFIG_LINKS = [ 599s] | CONFIG_COMMANDS = [ 599s] | $ ./config.status Doxyfile.core [ 599s] | [ 599s] | on armbuild04 [ 599s] | [ 599s] | config.status:1200: creating Doxyfile.core [ 599s] [ 599s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 599s] make[1]: *** [override_dh_auto_test] Error 1 [ 599s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 599s] debian/rules:15: recipe for target 'build' failed [ 599s] make: *** [build] Error 2 [ 599s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 599s] [ 599s] armbuild04 failed "build libosmocore_1.1.0.82.00a55a.dsc" at Sat Jul 20 03:58:46 UTC 2019. [ 599s] [ 599s] ### VM INTERACTION START ### [ 602s] [ 577.470482] sysrq: SysRq : Power Off [ 602s] [ 577.480683] reboot: Power down [ 602s] ### VM INTERACTION END ### [ 602s] [ 602s] armbuild04 failed "build libosmocore_1.1.0.82.00a55a.dsc" at Sat Jul 20 03:58:50 UTC 2019. [ 602s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Sat Jul 20 06:05:32 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 06:05:32 +0000 Subject: Change in ...osmo-sgsn[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4d1219bf84d3b8dcaf925a60cf54abe733fba263 Gerrit-Change-Number: 14834 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 20 Jul 2019 06:05:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 06:05:37 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 06:05:37 +0000 Subject: Change in ...osmo-mgw[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14836 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib157bd2e110b271dbe5ac928c98251e016477f56 Gerrit-Change-Number: 14836 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 20 Jul 2019 06:05:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 06:05:44 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 06:05:44 +0000 Subject: Change in ...osmo-msc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14835 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14835 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I615bb5be3671022c6b821575a61f945b50e8f2a5 Gerrit-Change-Number: 14835 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Sat, 20 Jul 2019 06:05:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 06:05:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 06:05:56 +0000 Subject: Change in ...osmo-bsc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14833 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14833 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I571a85b6ea53af7661248afd84e61cf34b7b5641 Gerrit-Change-Number: 14833 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 20 Jul 2019 06:05:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 06:08:34 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 06:08:34 +0000 Subject: Change in ...libosmocore[master]: tell ubsan to ignore SUN_LEN In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14682 ) Change subject: tell ubsan to ignore SUN_LEN ...................................................................... Patch Set 3: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/14682/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14682/3//COMMIT_MSG at 15 PS3, Line 15: I sincerly hope that this explanation provides to be sufficient, If not I'd be willing to show up at : the next llvm dev meeting to provide quotes from actual sanitizer developers to back up these claims. The commit log may appear excessively verbose to you, but that's only because it appears you have much more insight into [modern?] compiler/toolchain topics than most other Osmocom developers, at the very leat myself. So it really helps, thanks! -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 Gerrit-Change-Number: 14682 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 20 Jul 2019 06:08:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 06:08:44 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 06:08:44 +0000 Subject: Change in ...simtrace2[master]: contrib/jenkins.sh: also push the .elf files to the ftp (for gdb/objd... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/14842 ) Change subject: contrib/jenkins.sh: also push the .elf files to the ftp (for gdb/objdump) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/14842 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ibccf92e30c84f34ff61b3e823151cf33f20a1c4f Gerrit-Change-Number: 14842 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 20 Jul 2019 06:08:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 06:08:48 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 06:08:48 +0000 Subject: Change in ...simtrace2[master]: contrib/jenkins.sh: don't delete old builds from ftp In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/14843 ) Change subject: contrib/jenkins.sh: don't delete old builds from ftp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/14843 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I2b34b5d4525d62564d34a6583ee3739b82c07c68 Gerrit-Change-Number: 14843 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 20 Jul 2019 06:08:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 06:08:50 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 06:08:50 +0000 Subject: Change in ...simtrace2[master]: contrib/jenkins.sh: also push the .elf files to the ftp (for gdb/objd... In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/simtrace2/+/14842 ) Change subject: contrib/jenkins.sh: also push the .elf files to the ftp (for gdb/objdump) ...................................................................... contrib/jenkins.sh: also push the .elf files to the ftp (for gdb/objdump) Change-Id: Ibccf92e30c84f34ff61b3e823151cf33f20a1c4f --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 99a6f00..1f6fe15 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -64,7 +64,7 @@ [rita.osmocom.org]:48 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIK8iivY70EiR5NiGChV39gRLjNpC8lvu1ZdHtdMw2zuX EOF SSH_COMMAND="ssh -o 'UserKnownHostsFile=$WORKSPACE/known_hosts' -p 48" - rsync -avz --delete -e "$SSH_COMMAND" $TOPDIR/firmware/bin/*.bin binaries at rita.osmocom.org:web-files/simtrace2/firmware/ + rsync -avz --delete -e "$SSH_COMMAND" $TOPDIR/firmware/bin/*.{bin,elf} binaries at rita.osmocom.org:web-files/simtrace2/firmware/ fi echo -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/14842 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ibccf92e30c84f34ff61b3e823151cf33f20a1c4f Gerrit-Change-Number: 14842 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 06:08:50 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 06:08:50 +0000 Subject: Change in ...simtrace2[master]: contrib/jenkins.sh: don't delete old builds from ftp In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/simtrace2/+/14843 ) Change subject: contrib/jenkins.sh: don't delete old builds from ftp ...................................................................... contrib/jenkins.sh: don't delete old builds from ftp Change-Id: I2b34b5d4525d62564d34a6583ee3739b82c07c68 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 1f6fe15..16420f7 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -64,7 +64,7 @@ [rita.osmocom.org]:48 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIK8iivY70EiR5NiGChV39gRLjNpC8lvu1ZdHtdMw2zuX EOF SSH_COMMAND="ssh -o 'UserKnownHostsFile=$WORKSPACE/known_hosts' -p 48" - rsync -avz --delete -e "$SSH_COMMAND" $TOPDIR/firmware/bin/*.{bin,elf} binaries at rita.osmocom.org:web-files/simtrace2/firmware/ + rsync -avz -e "$SSH_COMMAND" $TOPDIR/firmware/bin/*.{bin,elf} binaries at rita.osmocom.org:web-files/simtrace2/firmware/ fi echo -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/14843 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I2b34b5d4525d62564d34a6583ee3739b82c07c68 Gerrit-Change-Number: 14843 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 06:12:17 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 06:12:17 +0000 Subject: Change in ...osmo-msc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14841 ) Change subject: doc: Add Osmux documentation to User Manual ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14841/1/doc/manuals/chapters/osmux_msc.adoc File doc/manuals/chapters/osmux_msc.adoc: https://gerrit.osmocom.org/#/c/14841/1/doc/manuals/chapters/osmux_msc.adoc at 43 PS1, Line 43: appending the _Osmux Support_ IE in _BSSMAP RESET_ and _BSSMAP RESET ACK_ "proprietary / vendor specific Osmux Support IE". It might be useful to state that unless the BSC is OsmoBSC, one should better not enable it as the 3rd-party BSC might refuse the rleated RESET/RESET-ACK messages. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 Gerrit-Change-Number: 14841 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Sat, 20 Jul 2019 06:12:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 06:13:47 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 06:13:47 +0000 Subject: Change in ...osmo-bsc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14840 ) Change subject: doc: Add Osmux documentation to User Manual ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14840/1/doc/manuals/chapters/osmux_bsc.adoc File doc/manuals/chapters/osmux_bsc.adoc: https://gerrit.osmocom.org/#/c/14840/1/doc/manuals/chapters/osmux_bsc.adoc at 18 PS1, Line 18: appending the _Osmux Support_ IE in _BSSMAP RESET_ and _BSSMAP RESET ACK_ same comment about non-standard nature of the IE applies here, also the comment about recommending to switch it off when talking to any 3rd party MSC. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75dcdddc713b0dc43e2ba577ca377c20fc511f38 Gerrit-Change-Number: 14840 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Sat, 20 Jul 2019 06:13:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 07:22:42 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 20 Jul 2019 07:22:42 +0000 Subject: Change in ...osmo-trx[master]: trxd_fill_common(): fix TRXD header version coding Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14845 Change subject: trxd_fill_common(): fix TRXD header version coding ...................................................................... trxd_fill_common(): fix TRXD header version coding The expression "version && 0x07" is wrong because it performs a Boolean operation on a constant other than 0 or 1. We actually need a binary AND here. Also, version field is 4 bit long, so the mask 0x07 == 0b111 should actually be 0b1111. Change-Id: I290931559ce01cf6e43470b18855c46808d6c2a5 Fixes: CID#202038 Integer handling issues --- M Transceiver52M/proto_trxd.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/45/14845/1 diff --git a/Transceiver52M/proto_trxd.c b/Transceiver52M/proto_trxd.c index fff23da..fbef77a 100644 --- a/Transceiver52M/proto_trxd.c +++ b/Transceiver52M/proto_trxd.c @@ -27,7 +27,7 @@ static void trxd_fill_common(struct trxd_hdr_common *common, const struct trx_ul_burst_ind *bi, uint8_t version) { - common->version = version && 0x07; + common->version = version & 0b1111; common->reserved = 0; common->tn = bi->tn; osmo_store32be(bi->fn, &common->fn); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14845 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I290931559ce01cf6e43470b18855c46808d6c2a5 Gerrit-Change-Number: 14845 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 08:14:15 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 08:14:15 +0000 Subject: Change in ...osmo-trx[master]: proto_trxd.c: Use bit-wise AND, not boolean AND Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14846 Change subject: proto_trxd.c: Use bit-wise AND, not boolean AND ...................................................................... proto_trxd.c: Use bit-wise AND, not boolean AND Change-Id: I974c91be7cc119b44c2fb0c53d08009c87de7bf1 Related: CID#202038 --- M Transceiver52M/proto_trxd.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/46/14846/1 diff --git a/Transceiver52M/proto_trxd.c b/Transceiver52M/proto_trxd.c index fff23da..cd82d55 100644 --- a/Transceiver52M/proto_trxd.c +++ b/Transceiver52M/proto_trxd.c @@ -27,7 +27,7 @@ static void trxd_fill_common(struct trxd_hdr_common *common, const struct trx_ul_burst_ind *bi, uint8_t version) { - common->version = version && 0x07; + common->version = version & 0x07; common->reserved = 0; common->tn = bi->tn; osmo_store32be(bi->fn, &common->fn); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I974c91be7cc119b44c2fb0c53d08009c87de7bf1 Gerrit-Change-Number: 14846 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 08:14:52 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 08:14:52 +0000 Subject: Change in ...osmo-trx[master]: proto_trxd.c: Use bit-wise AND, not boolean AND In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14846 ) Change subject: proto_trxd.c: Use bit-wise AND, not boolean AND ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I974c91be7cc119b44c2fb0c53d08009c87de7bf1 Gerrit-Change-Number: 14846 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sat, 20 Jul 2019 08:14:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 09:40:42 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 09:40:42 +0000 Subject: Change in ...osmo-trx[master]: proto_trxd.c: Use bit-wise AND, not boolean AND In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14846 ) Change subject: proto_trxd.c: Use bit-wise AND, not boolean AND ...................................................................... proto_trxd.c: Use bit-wise AND, not boolean AND Change-Id: I974c91be7cc119b44c2fb0c53d08009c87de7bf1 Related: CID#202038 --- M Transceiver52M/proto_trxd.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/proto_trxd.c b/Transceiver52M/proto_trxd.c index fff23da..cd82d55 100644 --- a/Transceiver52M/proto_trxd.c +++ b/Transceiver52M/proto_trxd.c @@ -27,7 +27,7 @@ static void trxd_fill_common(struct trxd_hdr_common *common, const struct trx_ul_burst_ind *bi, uint8_t version) { - common->version = version && 0x07; + common->version = version & 0x07; common->reserved = 0; common->tn = bi->tn; osmo_store32be(bi->fn, &common->fn); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I974c91be7cc119b44c2fb0c53d08009c87de7bf1 Gerrit-Change-Number: 14846 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:09:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:09:35 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: Introduce Osmux documentation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 ) Change subject: common: Introduce Osmux documentation ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14839/1/common/chapters/osmux/osmux.adoc File common/chapters/osmux/osmux.adoc: https://gerrit.osmocom.org/#/c/14839/1/common/chapters/osmux/osmux.adoc at 90 PS1, Line 90: OS#4092 manuals are for users who may not understand this notation used in our development process, providing a hyperlink may be more user-friendly. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e Gerrit-Change-Number: 14839 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sat, 20 Jul 2019 10:09:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:11:01 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:11:01 +0000 Subject: Change in ...libosmocore[master]: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14360 ) Change subject: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/14360/6/src/gsm/gsm48049.c File src/gsm/gsm48049.c: https://gerrit.osmocom.org/#/c/14360/6/src/gsm/gsm48049.c at 112 PS6, Line 112: > Not sure if there's a bug with gerrit here, but I used to see more stuff behind, and after adding my [?] the only part that existed here was a comment about "protocol implementation" which I removed as there never was any code following the comment. There never was any actual code, at least not that I know of. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 Gerrit-Change-Number: 14360 Gerrit-PatchSet: 6 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 20 Jul 2019 10:11:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:11:45 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:11:45 +0000 Subject: Change in ...libosmocore[master]: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14360 to look at the new patch set (#7). Change subject: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support ...................................................................... CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support This introduces definitions as well as a parser+encoder for the Cell Broadcast Service Protocol (CBSP) as specified in 3GPP TS 48.049. CBSP is used on the interface between CBC and BSC. Related: OS#3537 Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 --- M include/Makefile.am A include/osmocom/gsm/cbsp.h A include/osmocom/gsm/protocol/gsm_48_049.h M src/gsm/Makefile.am A src/gsm/cbsp.c A src/gsm/gsm48049.c M src/gsm/libosmogsm.map 7 files changed, 1,954 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/60/14360/7 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 Gerrit-Change-Number: 14360 Gerrit-PatchSet: 7 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:19:15 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:19:15 +0000 Subject: Change in ...libosmocore[master]: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14360 ) Change subject: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 Gerrit-Change-Number: 14360 Gerrit-PatchSet: 7 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 20 Jul 2019 10:19:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:19:19 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:19:19 +0000 Subject: Change in ...libosmocore[master]: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14360 ) Change subject: CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support ...................................................................... CBSP (Cell Broadcast Service Protocol; 3GPP TS 48.049) support This introduces definitions as well as a parser+encoder for the Cell Broadcast Service Protocol (CBSP) as specified in 3GPP TS 48.049. CBSP is used on the interface between CBC and BSC. Related: OS#3537 Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 --- M include/Makefile.am A include/osmocom/gsm/cbsp.h A include/osmocom/gsm/protocol/gsm_48_049.h M src/gsm/Makefile.am A src/gsm/cbsp.c A src/gsm/gsm48049.c M src/gsm/libosmogsm.map 7 files changed, 1,954 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/Makefile.am b/include/Makefile.am index 7b9e347..7835fab 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -72,6 +72,7 @@ osmocom/gsm/abis_nm.h \ osmocom/gsm/apn.h \ osmocom/gsm/bts_features.h \ + osmocom/gsm/cbsp.h \ osmocom/gsm/comp128.h \ osmocom/gsm/comp128v23.h \ osmocom/gsm/bitvec_gsm.h \ @@ -124,6 +125,7 @@ osmocom/gsm/protocol/gsm_23_003.h \ osmocom/gsm/protocol/gsm_29_118.h \ osmocom/gsm/protocol/gsm_44_318.h \ + osmocom/gsm/protocol/gsm_48_049.h \ osmocom/gsm/protocol/ipaccess.h \ osmocom/gsm/protocol/smpp34_osmocom.h \ osmocom/gsm/rsl.h \ diff --git a/include/osmocom/gsm/cbsp.h b/include/osmocom/gsm/cbsp.h new file mode 100644 index 0000000..d47b37b --- /dev/null +++ b/include/osmocom/gsm/cbsp.h @@ -0,0 +1,292 @@ +#pragma once + +#include +#include +#include +#include + +/* Definitions for parsed / abstract representation of messages in the + * CBSP (Cell Broadcast Service Protocol). Data here is *not* formatted + * like the * on-the-wire format. Any similarities are coincidetial ;) */ + +/* Copyright (C) 2019 Harald Welte + * + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + */ + +/* Decoded 8.2.3 Message Content */ +struct osmo_cbsp_content { + struct llist_head list; + uint8_t user_len; + uint8_t data[82]; +}; + +/* Decoded Entry in a 8.2.6 Cell List */ +struct osmo_cbsp_cell_ent { + struct llist_head list; /* entry in osmo_cbsp_cell_list.list */ + union gsm0808_cell_id_u cell_id; +}; +struct osmo_cbsp_cell_list { + enum CELL_IDENT id_discr; + struct llist_head list; /* list of osmo_cbsp_cell_ent */ +}; + +/* Decoded Entry in a 8.2.10 Completed List */ +struct osmo_cbsp_num_compl_ent { + struct llist_head list; /* entry in osmo_cbsp_num_compl_list.list */ + union gsm0808_cell_id_u cell_id; + uint16_t num_compl; + uint8_t num_bcast_info; +}; +struct osmo_cbsp_num_compl_list { + enum CELL_IDENT id_discr; + struct llist_head list; /* list of osmo_cbsp_num_compl_ent */ +}; + +/* Decoded Entry in a 8.2.12 Radio Resource Loading List */ +struct osmo_cbsp_loading_ent { + struct llist_head list; /* entry in osmo_cbsp_loading_list */ + union gsm0808_cell_id_u cell_id; + uint8_t load[2]; +}; +struct osmo_cbsp_loading_list { + enum CELL_IDENT id_discr; + struct llist_head list; /* list of osmo_cbsp_loading_ent */ +}; + +/* Decoded Entry in a 8.2.11 Failure List */ +struct osmo_cbsp_fail_ent { + struct llist_head list; /* entry in a fail_list below */ + enum CELL_IDENT id_discr; + union gsm0808_cell_id_u cell_id; + uint8_t cause; +}; + + +/* 8.1.3.1 */ +struct osmo_cbsp_write_replace { + uint16_t msg_id; /* 8.2.16 M */ + uint16_t new_serial_nr; /* 8.2.5 M */ + uint16_t *old_serial_nr; /* 8.2.4 */ + struct osmo_cbsp_cell_list cell_list; + + bool is_cbs; + union { + struct { + enum cbsp_channel_ind channel_ind; + enum cbsp_category category; + uint16_t rep_period; + uint16_t num_bcast_req; + /* num_of_pages implicit as llist_count(msg_content) */ + uint8_t dcs; + struct llist_head msg_content; + } cbs; + struct { + uint8_t indicator; + uint16_t warning_type; + uint8_t warning_sec_info[50]; + uint32_t warning_period; /* in seconds; 0xffffffff = unlimited */ + } emergency; + } u; +}; + +/* 8.1.3.2 */ +struct osmo_cbsp_write_replace_complete { + uint16_t msg_id; + uint16_t new_serial_nr; + uint16_t *old_serial_nr; + struct osmo_cbsp_num_compl_list num_compl_list; + struct osmo_cbsp_cell_list cell_list; + enum cbsp_channel_ind *channel_ind; +}; + +/* 8.1.3.3 */ +struct osmo_cbsp_write_replace_failure { + uint16_t msg_id; + uint16_t new_serial_nr; + uint16_t *old_serial_nr; + struct llist_head fail_list; /* list of osmo_cbsp_fail_ent */ + struct osmo_cbsp_num_compl_list num_compl_list; + struct osmo_cbsp_cell_list cell_list; + enum cbsp_channel_ind *channel_ind; +}; + +/* 8.1.3.4 */ +struct osmo_cbsp_kill { + uint16_t msg_id; + uint16_t old_serial_nr; + struct osmo_cbsp_cell_list cell_list; + enum cbsp_channel_ind *channel_ind; +}; + +/* 8.1.3.5 */ +struct osmo_cbsp_kill_complete { + uint16_t msg_id; + uint16_t old_serial_nr; + struct osmo_cbsp_num_compl_list num_compl_list; + struct osmo_cbsp_cell_list cell_list; + enum cbsp_channel_ind *channel_ind; +}; + +/* 8.1.3.6 */ +struct osmo_cbsp_kill_failure { + uint16_t msg_id; + uint16_t old_serial_nr; + struct llist_head fail_list; /* list of osmo_cbsp_fail_ent */ + struct osmo_cbsp_num_compl_list num_compl_list; + struct osmo_cbsp_cell_list cell_list; + enum cbsp_channel_ind *channel_ind; +}; + +/* 8.1.3.7 */ +struct osmo_cbsp_load_query { + struct osmo_cbsp_cell_list cell_list; + enum cbsp_channel_ind channel_ind; +}; + +/* 8.1.3.8 */ +struct osmo_cbsp_load_query_complete { + struct osmo_cbsp_loading_list loading_list; + enum cbsp_channel_ind channel_ind; +}; + +/* 8.1.3.9 */ +struct osmo_cbsp_load_query_failure { + struct llist_head fail_list; /* list of osmo_cbsp_fail_ent */ + enum cbsp_channel_ind channel_ind; + struct osmo_cbsp_loading_list loading_list; +}; + +/* 8.1.3.10 */ +struct osmo_cbsp_msg_status_query { + uint16_t msg_id; + uint16_t old_serial_nr; + struct osmo_cbsp_cell_list cell_list; + enum cbsp_channel_ind channel_ind; +}; + +/* 8.1.3.11 */ +struct osmo_cbsp_msg_status_query_complete { + uint16_t msg_id; + uint16_t old_serial_nr; + struct osmo_cbsp_num_compl_list num_compl_list; + enum cbsp_channel_ind channel_ind; +}; + +/* 8.1.3.12 */ +struct osmo_cbsp_msg_status_query_failure { + uint16_t msg_id; + uint16_t old_serial_nr; + struct llist_head fail_list; /* list of osmo_cbsp_fail_ent */ + enum cbsp_channel_ind channel_ind; + struct osmo_cbsp_num_compl_list num_compl_list; +}; + +/* 8.1.3.16 */ +struct osmo_cbsp_reset { + struct osmo_cbsp_cell_list cell_list; +}; + +/* 8.1.3.17 */ +struct osmo_cbsp_reset_complete { + struct osmo_cbsp_cell_list cell_list; +}; + +/* 8.1.3.18 */ +struct osmo_cbsp_reset_failure { + struct llist_head fail_list; /* list of osmo_cbsp_fail_ent */ + struct osmo_cbsp_cell_list cell_list; +}; + +/* 8.1.3.18a */ +struct osmo_cbsp_keep_alive { + uint8_t repetition_period; +}; + +/* 8.1.3.18b */ +struct osmo_cbsp_keep_alive_complete { +}; + +/* 8.1.3.19 */ +struct osmo_cbsp_restart { + struct osmo_cbsp_cell_list cell_list; + uint8_t bcast_msg_type; + uint8_t recovery_ind; +}; + +/* 8.1.3.20 */ +struct osmo_cbsp_failure { + struct llist_head fail_list; /* list of osmo_cbsp_fail_ent */ + uint8_t bcast_msg_type; +}; + +/* 8.1.3.21 */ +struct osmo_cbsp_error_ind { + enum cbsp_cell_id_cause cause; + uint16_t *msg_id; + uint16_t *new_serial_nr; + uint16_t *old_serial_nr; + enum cbsp_channel_ind *channel_ind; +}; + + +/* decoded CBSP message */ +struct osmo_cbsp_decoded { + enum cbsp_msg_type msg_type; + union { + struct osmo_cbsp_write_replace write_replace; + struct osmo_cbsp_write_replace_complete write_replace_compl; + struct osmo_cbsp_write_replace_failure write_replace_fail; + + struct osmo_cbsp_kill kill; + struct osmo_cbsp_kill_complete kill_compl; + struct osmo_cbsp_kill_failure kill_fail; + + struct osmo_cbsp_load_query load_query; + struct osmo_cbsp_load_query_complete load_query_compl; + struct osmo_cbsp_load_query_failure load_query_fail; + + struct osmo_cbsp_msg_status_query msg_status_query; + struct osmo_cbsp_msg_status_query_complete msg_status_query_compl; + struct osmo_cbsp_msg_status_query_failure msg_status_query_fail; + + /* TODO: set DRX */ + + struct osmo_cbsp_reset reset; + struct osmo_cbsp_reset_complete reset_compl; + struct osmo_cbsp_reset_failure reset_fail; + + struct osmo_cbsp_restart restart; + + struct osmo_cbsp_failure failure; + + struct osmo_cbsp_error_ind error_ind; + + struct osmo_cbsp_keep_alive keep_alive; + struct osmo_cbsp_keep_alive_complete keep_alive_compl; + } u; +}; + +struct msgb *osmo_cbsp_msgb_alloc(void *ctx, const char *name); +struct msgb *osmo_cbsp_encode(void *ctx, const struct osmo_cbsp_decoded *in); +struct osmo_cbsp_decoded *osmo_cbsp_decode(void *ctx, struct msgb *in); +void osmo_cbsp_init_struct(struct osmo_cbsp_decoded *cbsp, enum cbsp_msg_type msg_type); +struct osmo_cbsp_decoded *osmo_cbsp_decoded_alloc(void *ctx, enum cbsp_msg_type msg_type); + +int osmo_cbsp_recv_buffered(void *ctx, int fd, struct msgb **rmsg, struct msgb **tmp_msg); diff --git a/include/osmocom/gsm/protocol/gsm_48_049.h b/include/osmocom/gsm/protocol/gsm_48_049.h new file mode 100644 index 0000000..27fc9d0 --- /dev/null +++ b/include/osmocom/gsm/protocol/gsm_48_049.h @@ -0,0 +1,128 @@ +#pragma once +#include +#include + +/* CBSP is an ETSI/3GPP standard protocol used between CBC (Cell + * Brodadcast Centre) and BSC (Base Station Controller) in 2G/GSM/GERAN + * networks. It is specified in 3GPP TS 48.049. + * + * (C) 2019 by Harald Welte + * All rights reserved. + * + * SPDX-License-Identifier: GPL-2.0+ + * + * Released under the terms of the GNU General Public License, Version 2 or + * (at your option) any later version. + */ + +/* 5.2 TCP/IP */ +#define CBSP_TCP_PORT 48049 + +/* 8.2.1 Information Element Identifiers */ +enum cbsp_iei { + CBSP_IEI_MSG_CONTENT = 0x01, + CBSP_IEI_OLD_SERIAL_NR = 0x02, + CBSP_IEI_NEW_SERIAL_NR = 0x03, + CBSP_IEI_CELL_LIST = 0x04, + CBSP_IEI_CATEGORY = 0x05, + CBSP_IEI_REP_PERIOD = 0x06, + CBSP_IEI_NUM_BCAST_REQ = 0x07, + CBSP_IEI_NUM_BCAST_COMPL_LIST = 0x08, + CBSP_IEI_FAILURE_LIST = 0x09, + CBSP_IEI_RR_LOADING_LIST = 0x0a, + CBSP_IEI_CAUSE = 0x0b, + CBSP_IEI_DCS = 0x0c, + CBSP_IEI_RECOVERY_IND = 0x0d, + CBSP_IEI_MSG_ID = 0x0e, + CBSP_IEI_EMERG_IND = 0x0f, + CBSP_IEI_WARN_TYPE = 0x10, + CBSP_IEI_WARN_SEC_INFO = 0x11, + CBSP_IEI_CHANNEL_IND = 0x12, + CBSP_IEI_NUM_OF_PAGES = 0x13, + CBSP_IEI_SCHEDULE_PERIOD = 0x14, + CBSP_IEI_NUM_OF_RES_SLOTS = 0x15, + CBSP_IEI_BCAST_MSG_TYPE = 0x16, + CBSP_IEI_WARNING_PERIOD = 0x17, + CBSP_IEI_KEEP_ALIVE_REP_PERIOD = 0x18, +}; + +/* 8.2.2 Message Type */ +enum cbsp_msg_type { + CBSP_MSGT_WRITE_REPLACE = 0x01, + CBSP_MSGT_WRITE_REPLACE_COMPL = 0x02, + CBSP_MSGT_WRITE_REPLACE_FAIL = 0x03, + CBSP_MSGT_KILL = 0x04, + CBSP_MSGT_KILL_COMPL = 0x05, + CBSP_MSGT_KILL_FAIL = 0x06, + CBSP_MSGT_LOAD_QUERY = 0x07, + CBSP_MSGT_LOAD_QUERY_COMPL = 0x08, + CBSP_MSGT_LOAD_QUERY_FAIL = 0x09, + CBSP_MSGT_MSG_STATUS_QUERY = 0x0a, + CBSP_MSGT_MSG_STATUS_QUERY_COMPL= 0x0b, + CBSP_MSGT_MSG_STATUS_QUERY_FAIL = 0x0c, + CBSP_MSGT_SET_DRX = 0x0d, + CBSP_MSGT_SET_DRX_COMPL = 0x0e, + CBSP_MSGT_SET_DRX_FAIL = 0x0f, + CBSP_MSGT_RESET = 0x10, + CBSP_MSGT_RESET_COMPL = 0x11, + CBSP_MSGT_RESET_FAIL = 0x12, + CBSP_MSGT_RESTART = 0x13, + CBSP_MSGT_FAILURE = 0x14, + CBSP_MSGT_ERROR_IND = 0x15, + CBSP_MSGT_KEEP_ALIVE = 0x16, + CBSP_MSGT_KEEP_ALIVE_COMPL = 0x17, +}; + +/* 8.2.7 Category */ +enum cbsp_category { + CBSP_CATEG_HIGH_PRIO = 0x00, + CBSP_CATEG_BACKGROUND = 0x01, + CBSP_CATEG_NORMAL = 0x02, +}; + +/* Cell ID Discriminator (8.2.11, ...) */ +enum cbsp_cell_id_disc { + CBSP_CIDD_WHOLE_CGI = 0x0, + CBSP_CIDD_LAC_CI = 0x1, + CBSP_CIDD_CI = 0x2, + CBSP_CIDD_LAI = 0x4, + CBSP_CIDD_LAC = 0x5, + CBSP_CIDD_ALL_IN_BSC = 0x6, +}; + +/* 8.2.13 Cause */ +enum cbsp_cell_id_cause { + CBSP_CAUSE_PARAM_NOT_RECOGNISED = 0x00, + CBSP_CAUSE_PARAM_VAL_INVALID = 0x01, + CBSP_CAUSE_MSG_REF_NOT_IDENTIFIED = 0x02, + CBSP_CAUSE_CELL_ID_NOT_VALID = 0x03, + CBSP_CAUSE_UNRECOGNISED_MSG = 0x04, + CBSP_CAUSE_MISSING_MAND_IE = 0x05, + CBSP_CAUSE_BSC_CAPACITY_EXCEEDED = 0x06, + CBSP_CAUSE_CELL_MEMORY_EXCEEDED = 0x07, + CBSP_CAUSE_BSC_MEMORY_EXCEEDED = 0x08, + CBSP_CAUSE_CB_NOT_SUPPORTED = 0x09, + CBSP_CAUSE_CB_NOT_OPERATIONAL = 0x0a, + CBSP_CAUSE_INCOMPATIBLE_DRX_PARAM = 0x0b, + CBSP_CAUSE_EXT_CHAN_NOT_SUPPORTED = 0x0c, + CBSP_CAUSE_MSG_REF_ALREADY_USED = 0x0d, + CBSP_CAUSE_UNSPECIFIED_ERROR = 0x0e, + CBSP_CAUSE_LAI_OR_LAC_NPT_VALID = 0x0f, +}; + +/* 8.2.20 Chanel Indicator */ +enum cbsp_channel_ind { + CBSP_CHAN_IND_BASIC = 0, + CBSP_CHAN_IND_EXTENDED = 1, +}; + +/* not explicitly specified, but every message starts with those mandatory elements */ +struct cbsp_header { + uint8_t msg_type; + uint8_t len[3]; /* excluding the header */ +} __attribute__((packed)); + +extern const struct value_string cbsp_msg_type_names[]; +extern const struct value_string cbsp_iei_names[]; +extern const struct value_string cbsp_category_names[]; +extern const struct tlv_definition cbsp_att_tlvdef; diff --git a/src/gsm/Makefile.am b/src/gsm/Makefile.am index 5740b67..006e78c 100644 --- a/src/gsm/Makefile.am +++ b/src/gsm/Makefile.am @@ -32,7 +32,7 @@ milenage/milenage.c gan.c ipa.c gsm0341.c apn.c \ gsup.c gsup_sms.c gprs_gea.c gsm0503_conv.c oap.c gsm0808_utils.c \ gsm23003.c mncc.c bts_features.c oap_client.c \ - gsm29118.c gsm48_rest_octets.c + gsm29118.c gsm48_rest_octets.c cbsp.c gsm48049.c libgsmint_la_LDFLAGS = -no-undefined libgsmint_la_LIBADD = $(top_builddir)/src/libosmocore.la diff --git a/src/gsm/cbsp.c b/src/gsm/cbsp.c new file mode 100644 index 0000000..a891c52 --- /dev/null +++ b/src/gsm/cbsp.c @@ -0,0 +1,1409 @@ +/* + * Copyright (C) 2019 Harald Welte + * + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + */ + +#include "config.h" + +#include + +#include + +#include +#include + +#include +#include +#include + +struct msgb *osmo_cbsp_msgb_alloc(void *ctx, const char *name) +{ + /* make the messages rather large as the cell lists can be long! */ + return msgb_alloc_headroom_c(ctx, 65535, 16, name); +} + +/*********************************************************************** + * IE Encoding + ***********************************************************************/ + +/* 8.2.6 Cell List */ +static void msgb_put_cbsp_cell_list(struct msgb *msg, const struct osmo_cbsp_cell_list *cl) +{ + const struct osmo_cbsp_cell_ent *ent; + uint8_t *lenptr; + + /* put tag; reserve space for length; put discriminator */ + msgb_put_u8(msg, CBSP_IEI_CELL_LIST); + lenptr = msgb_put(msg, sizeof(uint16_t)); + msgb_put_u8(msg, cl->id_discr); + /* put list elements */ + llist_for_each_entry(ent, &cl->list, list) { + gsm0808_msgb_put_cell_id_u(msg, cl->id_discr, &ent->cell_id); + } + /* update IE length */ + osmo_store16be(msg->tail - (lenptr+2), lenptr); +} + +/* 8.2.11 Failure List (discriminator per entry) */ +static void msgb_put_cbsp_fail_list(struct msgb *msg, const struct llist_head *fl) +{ + const struct osmo_cbsp_fail_ent *ent; + uint8_t *lenptr; + + /* put tag; reserve space for length; put discriminator */ + msgb_put_u8(msg, CBSP_IEI_FAILURE_LIST); + lenptr = msgb_put(msg, sizeof(uint16_t)); + /* put list elements */ + llist_for_each_entry(ent, fl, list) { + msgb_put_u8(msg, ent->id_discr); + gsm0808_msgb_put_cell_id_u(msg, ent->id_discr, &ent->cell_id); + msgb_put_u8(msg, ent->cause); + } + /* update IE length */ + osmo_store16be(msg->tail - (lenptr+2), lenptr); +} + +/* 8.2.12 Radio Resource Loading List */ +static void msgb_put_cbsp_loading_list(struct msgb *msg, const struct osmo_cbsp_loading_list *ll) +{ + const struct osmo_cbsp_loading_ent *ent; + uint8_t *lenptr; + + /* put tag; reserve space for length; put discriminator */ + msgb_put_u8(msg, CBSP_IEI_RR_LOADING_LIST); + lenptr = msgb_put(msg, sizeof(uint16_t)); + msgb_put_u8(msg, ll->id_discr); + /* put list elements */ + llist_for_each_entry(ent, &ll->list, list) { + gsm0808_msgb_put_cell_id_u(msg, ll->id_discr, &ent->cell_id); + msgb_put_u8(msg, ent->load[0]); + msgb_put_u8(msg, ent->load[1]); + } + /* update IE length */ + osmo_store16be(msg->tail - (lenptr+2), lenptr); +} + +/* 8.2.10 Completed List */ +static void msgb_put_cbsp_num_compl_list(struct msgb *msg, const struct osmo_cbsp_num_compl_list *cl) +{ + const struct osmo_cbsp_num_compl_ent *ent; + uint8_t *lenptr; + + /* put tag; reserve space for length; put discriminator */ + msgb_put_u8(msg, CBSP_IEI_NUM_BCAST_COMPL_LIST); + lenptr = msgb_put(msg, sizeof(uint16_t)); + msgb_put_u8(msg, cl->id_discr); + /* put list elements */ + llist_for_each_entry(ent, &cl->list, list) { + gsm0808_msgb_put_cell_id_u(msg, cl->id_discr, &ent->cell_id); + msgb_put_u16(msg, ent->num_compl); + msgb_put_u8(msg, ent->num_bcast_info); + } + /* update IE length */ + osmo_store16be(msg->tail - (lenptr+2), lenptr); +} + +static int encode_wperiod(uint32_t secs) +{ + if (secs == 0xffffffff) + return 0; /* infinite */ + if (secs <= 10) + return secs; + if (secs <= 30) + return (secs-10)/2; + if (secs <= 120) + return (secs-30)/5; + if (secs <= 600) + return (secs-120)/10; + if (secs <= 60*60) + return (secs-600)/30; + return -1; +} + +/*********************************************************************** + * Message Encoding + ***********************************************************************/ + +/* 8.1.3.1 WRITE REPLACE */ +static int cbsp_enc_write_repl(struct msgb *msg, const struct osmo_cbsp_write_replace *in) +{ + msgb_tv16_put(msg, CBSP_IEI_MSG_ID, in->msg_id); + msgb_tv16_put(msg, CBSP_IEI_NEW_SERIAL_NR, in->new_serial_nr); + if (in->old_serial_nr) + msgb_tv16_put(msg, CBSP_IEI_OLD_SERIAL_NR, *in->old_serial_nr); + msgb_put_cbsp_cell_list(msg, &in->cell_list); + if (in->is_cbs) { + int num_of_pages = llist_count(&in->u.cbs.msg_content); + struct osmo_cbsp_content *ce; + if (num_of_pages == 0 || num_of_pages > 15) + return -EINVAL; + msgb_tv_put(msg, CBSP_IEI_CHANNEL_IND, in->u.cbs.channel_ind); + msgb_tv_put(msg, CBSP_IEI_CATEGORY, in->u.cbs.category); + msgb_tv16_put(msg, CBSP_IEI_REP_PERIOD, in->u.cbs.rep_period); + msgb_tv16_put(msg, CBSP_IEI_NUM_BCAST_REQ, in->u.cbs.num_bcast_req); + msgb_tv_put(msg, CBSP_IEI_NUM_OF_PAGES, num_of_pages); + msgb_tv_put(msg, CBSP_IEI_DCS, in->u.cbs.dcs); + llist_for_each_entry(ce, &in->u.cbs.msg_content, list) { + uint8_t *out; + /* cannot use msgb_tlv_put() as 'len' isn't actually the length of + * the data field */ + msgb_put_u8(msg, CBSP_IEI_MSG_CONTENT); + msgb_put_u8(msg, ce->user_len); + out = msgb_put(msg, sizeof(ce->data)); + memcpy(out, ce->data, sizeof(ce->data)); + } + } else { + int wperiod = encode_wperiod(in->u.emergency.warning_period); + if (wperiod < 0) + return -EINVAL; + msgb_tv_put(msg, CBSP_IEI_EMERG_IND, in->u.emergency.indicator); + msgb_tv16_put(msg, CBSP_IEI_WARN_TYPE, in->u.emergency.warning_type); + msgb_tlv_put(msg, CBSP_IEI_WARN_SEC_INFO, sizeof(in->u.emergency.warning_sec_info), + in->u.emergency.warning_sec_info); + msgb_tv_put(msg, CBSP_IEI_WARNING_PERIOD, wperiod); + } + return 0; +} + +/* 8.1.3.2 WRITE REPLACE COMPLETE*/ +static int cbsp_enc_write_repl_compl(struct msgb *msg, const struct osmo_cbsp_write_replace_complete *in) +{ + msgb_tv16_put(msg, CBSP_IEI_MSG_ID, in->msg_id); + msgb_tv16_put(msg, CBSP_IEI_NEW_SERIAL_NR, in->new_serial_nr); + if (in->old_serial_nr) + msgb_tv16_put(msg, CBSP_IEI_OLD_SERIAL_NR, *in->old_serial_nr); + + if (!llist_empty(&in->num_compl_list.list)) + msgb_put_cbsp_num_compl_list(msg, &in->num_compl_list); + if (!llist_empty(&in->cell_list.list)) + msgb_put_cbsp_cell_list(msg, &in->cell_list); + if (in->channel_ind) + msgb_tv_put(msg, CBSP_IEI_CHANNEL_IND, *in->channel_ind); + return 0; +} + +/* 8.1.3.3 WRITE REPLACE FAILURE */ +static int cbsp_enc_write_repl_fail(struct msgb *msg, const struct osmo_cbsp_write_replace_failure *in) +{ + msgb_tv16_put(msg, CBSP_IEI_MSG_ID, in->msg_id); + msgb_tv16_put(msg, CBSP_IEI_NEW_SERIAL_NR, in->new_serial_nr); + if (in->old_serial_nr) + msgb_tv16_put(msg, CBSP_IEI_OLD_SERIAL_NR, *in->old_serial_nr); + + msgb_put_cbsp_fail_list(msg, &in->fail_list); + if (!llist_empty(&in->num_compl_list.list)) + msgb_put_cbsp_num_compl_list(msg, &in->num_compl_list); + if (!llist_empty(&in->cell_list.list)) + msgb_put_cbsp_cell_list(msg, &in->cell_list); + if (in->channel_ind) + msgb_tv_put(msg, CBSP_IEI_CHANNEL_IND, *in->channel_ind); + return 0; +} + +/* 8.1.3.4 KILL */ +static int cbsp_enc_kill(struct msgb *msg, const struct osmo_cbsp_kill *in) +{ + msgb_tv16_put(msg, CBSP_IEI_MSG_ID, in->msg_id); + msgb_tv16_put(msg, CBSP_IEI_OLD_SERIAL_NR, in->old_serial_nr); + msgb_put_cbsp_cell_list(msg, &in->cell_list); + if (in->channel_ind) + msgb_tv_put(msg, CBSP_IEI_CHANNEL_IND, *in->channel_ind); + return 0; +} + +/* 8.1.3.5 KILL COMPLETE */ +static int cbsp_enc_kill_compl(struct msgb *msg, const struct osmo_cbsp_kill_complete *in) +{ + msgb_tv16_put(msg, CBSP_IEI_MSG_ID, in->msg_id); + msgb_tv16_put(msg, CBSP_IEI_OLD_SERIAL_NR, in->old_serial_nr); + if (!llist_empty(&in->num_compl_list.list)) + msgb_put_cbsp_num_compl_list(msg, &in->num_compl_list); + if (!llist_empty(&in->cell_list.list)) + msgb_put_cbsp_cell_list(msg, &in->cell_list); + if (in->channel_ind) + msgb_tv_put(msg, CBSP_IEI_CHANNEL_IND, *in->channel_ind); + return 0; +} + +/* 8.1.3.6 KILL FAILURE */ +static int cbsp_enc_kill_fail(struct msgb *msg, const struct osmo_cbsp_kill_failure *in) +{ + msgb_tv16_put(msg, CBSP_IEI_MSG_ID, in->msg_id); + msgb_tv16_put(msg, CBSP_IEI_OLD_SERIAL_NR, in->old_serial_nr); + msgb_put_cbsp_fail_list(msg, &in->fail_list); + if (!llist_empty(&in->num_compl_list.list)) + msgb_put_cbsp_num_compl_list(msg, &in->num_compl_list); + if (!llist_empty(&in->cell_list.list)) + msgb_put_cbsp_cell_list(msg, &in->cell_list); + if (in->channel_ind) + msgb_tv_put(msg, CBSP_IEI_CHANNEL_IND, *in->channel_ind); + return 0; +} + +/* 8.1.3.7 LOAD QUERY */ +static int cbsp_enc_load_query(struct msgb *msg, const struct osmo_cbsp_load_query *in) +{ + msgb_put_cbsp_cell_list(msg, &in->cell_list); + msgb_tv_put(msg, CBSP_IEI_CHANNEL_IND, in->channel_ind); + return 0; +} + +/* 8.1.3.8 LOAD QUERY COMPLETE */ +static int cbsp_enc_load_query_compl(struct msgb *msg, const struct osmo_cbsp_load_query_complete *in) +{ + msgb_put_cbsp_loading_list(msg, &in->loading_list); + msgb_tv_put(msg, CBSP_IEI_CHANNEL_IND, in->channel_ind); + return 0; +} + +/* 8.1.3.9 LOAD QUERY FAILURE */ +static int cbsp_enc_load_query_fail(struct msgb *msg, const struct osmo_cbsp_load_query_failure *in) +{ + msgb_put_cbsp_fail_list(msg, &in->fail_list); + msgb_tv_put(msg, CBSP_IEI_CHANNEL_IND, in->channel_ind); + if (!llist_empty(&in->loading_list.list)) + msgb_put_cbsp_loading_list(msg, &in->loading_list); + return 0; +} + +/* 8.1.3.10 STATUS QUERY */ +static int cbsp_enc_msg_status_query(struct msgb *msg, const struct osmo_cbsp_msg_status_query *in) +{ + msgb_tv16_put(msg, CBSP_IEI_MSG_ID, in->msg_id); + msgb_tv16_put(msg, CBSP_IEI_OLD_SERIAL_NR, in->old_serial_nr); + msgb_put_cbsp_cell_list(msg, &in->cell_list); + msgb_tv_put(msg, CBSP_IEI_CHANNEL_IND, in->channel_ind); + return 0; +} + +/* 8.1.3.11 STATUS QUERY COMPLETE */ +static int cbsp_enc_msg_status_query_compl(struct msgb *msg, + const struct osmo_cbsp_msg_status_query_complete *in) +{ + msgb_tv16_put(msg, CBSP_IEI_MSG_ID, in->msg_id); + msgb_tv16_put(msg, CBSP_IEI_OLD_SERIAL_NR, in->old_serial_nr); + msgb_put_cbsp_num_compl_list(msg, &in->num_compl_list); + msgb_tv_put(msg, CBSP_IEI_CHANNEL_IND, in->channel_ind); + return 0; +} + +/* 8.1.3.12 STATUS QUERY FAILURE */ +static int cbsp_enc_msg_status_query_fail(struct msgb *msg, + const struct osmo_cbsp_msg_status_query_failure *in) +{ + msgb_tv16_put(msg, CBSP_IEI_MSG_ID, in->msg_id); + msgb_tv16_put(msg, CBSP_IEI_OLD_SERIAL_NR, in->old_serial_nr); + msgb_put_cbsp_fail_list(msg, &in->fail_list); + msgb_tv_put(msg, CBSP_IEI_CHANNEL_IND, in->channel_ind); + if (!llist_empty(&in->num_compl_list.list)) + msgb_put_cbsp_num_compl_list(msg, &in->num_compl_list); + return 0; +} + +/* 8.1.3.16 RESET */ +static int cbsp_enc_reset(struct msgb *msg, const struct osmo_cbsp_reset *in) +{ + msgb_put_cbsp_cell_list(msg, &in->cell_list); + return 0; +} + +/* 8.1.3.17 RESET COMPLETE */ +static int cbsp_enc_reset_compl(struct msgb *msg, const struct osmo_cbsp_reset_complete *in) +{ + msgb_put_cbsp_cell_list(msg, &in->cell_list); + return 0; +} + +/* 8.1.3.18 RESET FAILURE */ +static int cbsp_enc_reset_fail(struct msgb *msg, const struct osmo_cbsp_reset_failure *in) +{ + msgb_put_cbsp_fail_list(msg, &in->fail_list); + if (!llist_empty(&in->cell_list.list)) + msgb_put_cbsp_cell_list(msg, &in->cell_list); + return 0; +} + +/* 8.1.3.18a KEEP ALIVE */ +static int cbsp_enc_keep_alive(struct msgb *msg, const struct osmo_cbsp_keep_alive *in) +{ + msgb_tv_put(msg, CBSP_IEI_KEEP_ALIVE_REP_PERIOD, in->repetition_period); + return 0; +} + +/* 8.1.3.18b KEEP ALIVE COMPLETE */ +static int cbsp_enc_keep_alive_compl(struct msgb *msg, const struct osmo_cbsp_keep_alive_complete *in) +{ + return 0; +} + +/* 8.1.3.19 RESTART */ +static int cbsp_enc_restart(struct msgb *msg, const struct osmo_cbsp_restart *in) +{ + msgb_put_cbsp_cell_list(msg, &in->cell_list); + msgb_tv_put(msg, CBSP_IEI_BCAST_MSG_TYPE, in->bcast_msg_type); + msgb_tv_put(msg, CBSP_IEI_RECOVERY_IND, in->recovery_ind); + return 0; +} + +/* 8.1.3.20 FAILURE */ +static int cbsp_enc_failure(struct msgb *msg, const struct osmo_cbsp_failure *in) +{ + msgb_put_cbsp_fail_list(msg, &in->fail_list); + msgb_tv_put(msg, CBSP_IEI_BCAST_MSG_TYPE, in->bcast_msg_type); + return 0; +} + +/* 8.1.3.21 ERROR INDICATION */ +static int cbsp_enc_error_ind(struct msgb *msg, const struct osmo_cbsp_error_ind *in) +{ + msgb_tv_put(msg, CBSP_IEI_CAUSE, in->cause); + if (in->msg_id) + msgb_tv16_put(msg, CBSP_IEI_MSG_ID, *in->msg_id); + if (in->new_serial_nr) + msgb_tv16_put(msg, CBSP_IEI_NEW_SERIAL_NR, *in->new_serial_nr); + if (in->old_serial_nr) + msgb_tv16_put(msg, CBSP_IEI_OLD_SERIAL_NR, *in->old_serial_nr); + if (in->channel_ind) + msgb_tv_put(msg, CBSP_IEI_CHANNEL_IND, *in->channel_ind); + return 0; +} + +/*! Encode a CBSP message from the decoded/parsed structure representation to binary PDU. + * \param[in] ctx talloc context from which to allocate returned msgb. + * \param[in] in decoded CBSP message which is to be encoded. Ownership not transferred. + * \return callee-allocated message buffer containing binary CBSP PDU; NULL on error */ +struct msgb *osmo_cbsp_encode(void *ctx, const struct osmo_cbsp_decoded *in) +{ + struct msgb *msg = osmo_cbsp_msgb_alloc(ctx, __func__); + unsigned int len; + int rc; + + if (!msg) + return NULL; + + switch (in->msg_type) { + case CBSP_MSGT_WRITE_REPLACE: + rc = cbsp_enc_write_repl(msg, &in->u.write_replace); + break; + case CBSP_MSGT_WRITE_REPLACE_COMPL: + rc = cbsp_enc_write_repl_compl(msg, &in->u.write_replace_compl); + break; + case CBSP_MSGT_WRITE_REPLACE_FAIL: + rc = cbsp_enc_write_repl_fail(msg, &in->u.write_replace_fail); + break; + case CBSP_MSGT_KILL: + rc = cbsp_enc_kill(msg, &in->u.kill); + break; + case CBSP_MSGT_KILL_COMPL: + rc = cbsp_enc_kill_compl(msg, &in->u.kill_compl); + break; + case CBSP_MSGT_KILL_FAIL: + rc = cbsp_enc_kill_fail(msg, &in->u.kill_fail); + break; + case CBSP_MSGT_LOAD_QUERY: + rc = cbsp_enc_load_query(msg, &in->u.load_query); + break; + case CBSP_MSGT_LOAD_QUERY_COMPL: + rc = cbsp_enc_load_query_compl(msg, &in->u.load_query_compl); + break; + case CBSP_MSGT_LOAD_QUERY_FAIL: + rc = cbsp_enc_load_query_fail(msg, &in->u.load_query_fail); + break; + case CBSP_MSGT_MSG_STATUS_QUERY: + rc = cbsp_enc_msg_status_query(msg, &in->u.msg_status_query); + break; + case CBSP_MSGT_MSG_STATUS_QUERY_COMPL: + rc = cbsp_enc_msg_status_query_compl(msg, &in->u.msg_status_query_compl); + break; + case CBSP_MSGT_MSG_STATUS_QUERY_FAIL: + rc = cbsp_enc_msg_status_query_fail(msg, &in->u.msg_status_query_fail); + break; + case CBSP_MSGT_RESET: + rc = cbsp_enc_reset(msg, &in->u.reset); + break; + case CBSP_MSGT_RESET_COMPL: + rc = cbsp_enc_reset_compl(msg, &in->u.reset_compl); + break; + case CBSP_MSGT_RESET_FAIL: + rc = cbsp_enc_reset_fail(msg, &in->u.reset_fail); + break; + case CBSP_MSGT_RESTART: + rc = cbsp_enc_restart(msg, &in->u.restart); + break; + case CBSP_MSGT_FAILURE: + rc = cbsp_enc_failure(msg, &in->u.failure); + break; + case CBSP_MSGT_ERROR_IND: + rc = cbsp_enc_error_ind(msg, &in->u.error_ind); + break; + case CBSP_MSGT_KEEP_ALIVE: + rc = cbsp_enc_keep_alive(msg, &in->u.keep_alive); + break; + case CBSP_MSGT_KEEP_ALIVE_COMPL: + rc = cbsp_enc_keep_alive_compl(msg, &in->u.keep_alive_compl); + break; + case CBSP_MSGT_SET_DRX: + case CBSP_MSGT_SET_DRX_COMPL: + case CBSP_MSGT_SET_DRX_FAIL: + rc = -1; + break; + default: + rc = -1; + break; + } + + if (rc < 0) { + msgb_free(msg); + return NULL; + } + + /* push header in front */ + len = msgb_length(msg); + msgb_push_u8(msg, len & 0xff); + msgb_push_u8(msg, (len >> 8) & 0xff); + msgb_push_u8(msg, (len >> 16) & 0xff); + msgb_push_u8(msg, in->msg_type); + + return msg; +} + +/*********************************************************************** + * IE Decoding + ***********************************************************************/ + +/* 8.2.6 Cell List */ +static int cbsp_decode_cell_list(struct osmo_cbsp_cell_list *cl, void *ctx, + const uint8_t *buf, unsigned int len) +{ + const uint8_t *cur = buf; + int rc; + + cl->id_discr = *cur++; + + while (cur < buf + len) { + struct osmo_cbsp_cell_ent *ent = talloc_zero(ctx, struct osmo_cbsp_cell_ent); + unsigned int len_remain = len - (cur - buf); + OSMO_ASSERT(ent); + rc = gsm0808_decode_cell_id_u(&ent->cell_id, cl->id_discr, cur, len_remain); + if (rc < 0) + return rc; + cur += rc; + llist_add_tail(&ent->list, &cl->list); + } + return 0; +} + +/* 8.2.11 Failure List (discriminator per entry) */ +static int cbsp_decode_fail_list(struct llist_head *fl, void *ctx, + const uint8_t *buf, unsigned int len) +{ + const uint8_t *cur = buf; + int rc; + + while (cur < buf + len) { + struct osmo_cbsp_fail_ent *ent = talloc_zero(ctx, struct osmo_cbsp_fail_ent); + unsigned int len_remain = len - (cur - buf); + OSMO_ASSERT(ent); + ent->id_discr = cur[0]; + rc = gsm0808_decode_cell_id_u(&ent->cell_id, ent->id_discr, cur+1, len_remain-1); + if (rc < 0) + return rc; + cur += rc; + ent->cause = *cur++; + llist_add_tail(&ent->list, fl); + } + return 0; +} + +/* 8.2.12 Radio Resource Loading List */ +static int cbsp_decode_loading_list(struct osmo_cbsp_loading_list *ll, void *ctx, + const uint8_t *buf, unsigned int len) +{ + const uint8_t *cur = buf; + int rc; + + ll->id_discr = *cur++; + while (cur < buf + len) { + struct osmo_cbsp_loading_ent *ent = talloc_zero(ctx, struct osmo_cbsp_loading_ent); + unsigned int len_remain = len - (cur - buf); + OSMO_ASSERT(ent); + rc = gsm0808_decode_cell_id_u(&ent->cell_id, ll->id_discr, cur, len_remain); + if (rc < 0) + return rc; + cur += rc; + if (cur + 2 > buf + len) { + talloc_free(ent); + return -EINVAL; + } + ent->load[0] = *cur++; + ent->load[1] = *cur++; + llist_add_tail(&ent->list, &ll->list); + } + return 0; +} + +/* 8.2.10 Completed List */ +static int cbsp_decode_num_compl_list(struct osmo_cbsp_num_compl_list *cl, void *ctx, + const uint8_t *buf, unsigned int len) +{ + const uint8_t *cur = buf; + int rc; + + cl->id_discr = *cur++; + while (cur < buf + len) { + struct osmo_cbsp_num_compl_ent *ent = talloc_zero(ctx, struct osmo_cbsp_num_compl_ent); + unsigned int len_remain = len - (cur - buf); + OSMO_ASSERT(ent); + rc = gsm0808_decode_cell_id_u(&ent->cell_id, cl->id_discr, cur, len_remain); + if (rc < 0) + return rc; + cur += rc; + if (cur + 3 > buf + len) { + talloc_free(ent); + return -EINVAL; + } + ent->num_compl = osmo_load16be(cur); cur += 2; + ent->num_bcast_info = *cur++; + llist_add_tail(&ent->list, &cl->list); + } + return 0; +} + +/* 8.2.25 */ +static uint32_t decode_wperiod(uint8_t in) +{ + if (in == 0x00) + return 0xffffffff; /* infinite */ + if (in <= 10) + return in; + if (in <= 20) + return 10 + (in - 10)*2; + if (in <= 38) + return 30 + (in - 20)*5; + if (in <= 86) + return 120 + (in - 38)*10; + if (in <= 186) + return 600 + (in - 86)*30; + else + return 0; +} + + +/*********************************************************************** + * Message Decoding + ***********************************************************************/ + +/* 8.1.3.1 WRITE REPLACE */ +static int cbsp_dec_write_repl(struct osmo_cbsp_write_replace *out, const struct tlv_parsed *tp, + struct msgb *in, void *ctx) +{ + unsigned int i; + + /* check for mandatory IEs */ + if (!TLVP_PRESENT(tp, CBSP_IEI_MSG_ID) || + !TLVP_PRESENT(tp, CBSP_IEI_NEW_SERIAL_NR) || + !TLVP_PRESENT(tp, CBSP_IEI_CELL_LIST)) + return -EINVAL; + + out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); + out->new_serial_nr = tlvp_val16be(tp, CBSP_IEI_NEW_SERIAL_NR); + if (TLVP_PRESENT(tp, CBSP_IEI_OLD_SERIAL_NR)) { + out->old_serial_nr = talloc(ctx, uint16_t); + *out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); + } + + INIT_LLIST_HEAD(&out->cell_list.list); + cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), + TLVP_LEN(tp, CBSP_IEI_CELL_LIST)); + + if (TLVP_PRESENT(tp, CBSP_IEI_CHANNEL_IND)) { + uint8_t num_of_pages; + INIT_LLIST_HEAD(&out->u.cbs.msg_content); + if (TLVP_PRESENT(tp, CBSP_IEI_EMERG_IND)) + return -EINVAL; + if (!TLVP_PRESENT(tp, CBSP_IEI_CATEGORY) || + !TLVP_PRESENT(tp, CBSP_IEI_REP_PERIOD) || + !TLVP_PRESENT(tp, CBSP_IEI_NUM_BCAST_REQ) || + !TLVP_PRESENT(tp, CBSP_IEI_NUM_OF_PAGES) || + !TLVP_PRESENT(tp, CBSP_IEI_DCS)) + return -EINVAL; + out->is_cbs = true; + out->u.cbs.channel_ind = *TLVP_VAL(tp, CBSP_IEI_CHANNEL_IND); + out->u.cbs.category = *TLVP_VAL(tp, CBSP_IEI_CATEGORY); + out->u.cbs.rep_period = tlvp_val16be(tp, CBSP_IEI_REP_PERIOD); + out->u.cbs.num_bcast_req = tlvp_val16be(tp, CBSP_IEI_NUM_BCAST_REQ); + num_of_pages = *TLVP_VAL(tp, CBSP_IEI_NUM_OF_PAGES); + if (num_of_pages < 1) + return -EINVAL; + /* parse pages */ + for (i = 0; i < num_of_pages; i++) { + const uint8_t *ie = TLVP_VAL(&tp[i], CBSP_IEI_MSG_CONTENT); + struct osmo_cbsp_content *page; + if (!ie) + return -EINVAL; + page = talloc_zero(ctx, struct osmo_cbsp_content); + OSMO_ASSERT(page); + page->user_len = *(ie-1); /* length byte before payload */ + memcpy(page->data, ie, sizeof(page->data)); + llist_add_tail(&page->list, &out->u.cbs.msg_content); + } + } else { + if (!TLVP_PRES_LEN(tp, CBSP_IEI_EMERG_IND, 1) || + !TLVP_PRES_LEN(tp, CBSP_IEI_WARN_TYPE, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_WARN_SEC_INFO, 50) || + !TLVP_PRES_LEN(tp, CBSP_IEI_WARNING_PERIOD, 1)) + return -EINVAL; + out->u.emergency.indicator = *TLVP_VAL(tp, CBSP_IEI_EMERG_IND); + out->u.emergency.warning_type = tlvp_val16be(tp, CBSP_IEI_WARN_TYPE); + memcpy(&out->u.emergency.warning_sec_info, TLVP_VAL(tp, CBSP_IEI_WARN_SEC_INFO), + sizeof(out->u.emergency.warning_sec_info)); + out->u.emergency.warning_period = decode_wperiod(*TLVP_VAL(tp, CBSP_IEI_WARNING_PERIOD)); + } + return 0; +} + +/* 8.1.3.2 WRITE REPLACE COMPLETE*/ +static int cbsp_dec_write_repl_compl(struct osmo_cbsp_write_replace_complete *out, + const struct tlv_parsed *tp, struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_NEW_SERIAL_NR, 2)) + return -EINVAL; + + out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); + out->new_serial_nr = tlvp_val16be(tp, CBSP_IEI_NEW_SERIAL_NR); + if (TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2)) { + out->old_serial_nr = talloc(ctx, uint16_t); + *out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); + } + + INIT_LLIST_HEAD(&out->num_compl_list.list); + if (TLVP_PRES_LEN(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST, 7)) { + cbsp_decode_num_compl_list(&out->num_compl_list, ctx, + TLVP_VAL(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST), + TLVP_LEN(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST)); + } + + INIT_LLIST_HEAD(&out->cell_list.list); + cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), + TLVP_LEN(tp, CBSP_IEI_CELL_LIST)); + + if (TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) { + out->channel_ind = talloc(ctx, enum cbsp_channel_ind); + *out->channel_ind = *TLVP_VAL(tp, CBSP_IEI_CHANNEL_IND); + } + return 0; +} + +/* 8.1.3.3 WRITE REPLACE FAILURE */ +static int cbsp_dec_write_repl_fail(struct osmo_cbsp_write_replace_failure *out, + const struct tlv_parsed *tp, struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_NEW_SERIAL_NR, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5)) + return -EINVAL; + + out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); + out->new_serial_nr = tlvp_val16be(tp, CBSP_IEI_NEW_SERIAL_NR); + if (TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2)) { + out->old_serial_nr = talloc(ctx, uint16_t); + *out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); + } + + INIT_LLIST_HEAD(&out->fail_list); + cbsp_decode_fail_list(&out->fail_list, ctx, + TLVP_VAL(tp, CBSP_IEI_FAILURE_LIST), + TLVP_LEN(tp, CBSP_IEI_FAILURE_LIST)); + + INIT_LLIST_HEAD(&out->num_compl_list.list); + if (TLVP_PRES_LEN(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST, 7)) { + cbsp_decode_num_compl_list(&out->num_compl_list, ctx, + TLVP_VAL(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST), + TLVP_LEN(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST)); + } + + INIT_LLIST_HEAD(&out->cell_list.list); + if (TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) { + cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), + TLVP_LEN(tp, CBSP_IEI_CELL_LIST)); + } + + if (TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) { + out->channel_ind = talloc(ctx, enum cbsp_channel_ind); + *out->channel_ind = *TLVP_VAL(tp, CBSP_IEI_CHANNEL_IND); + } + return 0; +} + +/* 8.1.3.4 KILL */ +static int cbsp_dec_kill(struct osmo_cbsp_kill *out, const struct tlv_parsed *tp, + struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) + return -EINVAL; + out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); + out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); + + INIT_LLIST_HEAD(&out->cell_list.list); + cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), + TLVP_LEN(tp, CBSP_IEI_CELL_LIST)); + + if (TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) { + out->channel_ind = talloc(ctx, enum cbsp_channel_ind); + *out->channel_ind = *TLVP_VAL(tp, CBSP_IEI_CHANNEL_IND); + } + return 0; +} + +/* 8.1.3.5 KILL COMPLETE */ +static int cbsp_dec_kill_compl(struct osmo_cbsp_kill_complete *out, const struct tlv_parsed *tp, + struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) + return -EINVAL; + + out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); + out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); + + INIT_LLIST_HEAD(&out->num_compl_list.list); + if (TLVP_PRES_LEN(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST, 7)) { + cbsp_decode_num_compl_list(&out->num_compl_list, ctx, + TLVP_VAL(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST), + TLVP_LEN(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST)); + } + + INIT_LLIST_HEAD(&out->cell_list.list); + cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), + TLVP_LEN(tp, CBSP_IEI_CELL_LIST)); + + if (TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) { + out->channel_ind = talloc(ctx, enum cbsp_channel_ind); + *out->channel_ind = *TLVP_VAL(tp, CBSP_IEI_CHANNEL_IND); + } + return 0; +} + +/* 8.1.3.6 KILL FAILURE */ +static int cbsp_dec_kill_fail(struct osmo_cbsp_kill_failure *out, const struct tlv_parsed *tp, + struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5)) + return -EINVAL; + + out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); + out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); + + INIT_LLIST_HEAD(&out->fail_list); + cbsp_decode_fail_list(&out->fail_list, ctx, + TLVP_VAL(tp, CBSP_IEI_FAILURE_LIST), + TLVP_LEN(tp, CBSP_IEI_FAILURE_LIST)); + + INIT_LLIST_HEAD(&out->num_compl_list.list); + if (TLVP_PRES_LEN(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST, 7)) { + cbsp_decode_num_compl_list(&out->num_compl_list, ctx, + TLVP_VAL(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST), + TLVP_LEN(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST)); + } + + INIT_LLIST_HEAD(&out->cell_list.list); + if (TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) { + cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), + TLVP_LEN(tp, CBSP_IEI_CELL_LIST)); + } + + if (TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) { + out->channel_ind = talloc(ctx, enum cbsp_channel_ind); + *out->channel_ind = *TLVP_VAL(tp, CBSP_IEI_CHANNEL_IND); + } + return 0; +} + +/* 8.1.3.7 LOAD QUERY */ +static int cbsp_dec_load_query(struct osmo_cbsp_load_query *out, const struct tlv_parsed *tp, + struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1) || + !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) + return -EINVAL; + + INIT_LLIST_HEAD(&out->cell_list.list); + cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), + TLVP_LEN(tp, CBSP_IEI_CELL_LIST)); + + out->channel_ind = *TLVP_VAL(tp, CBSP_IEI_CHANNEL_IND); + return 0; +} + +/* 8.1.3.8 LOAD QUERY COMPLETE */ +static int cbsp_dec_load_query_compl(struct osmo_cbsp_load_query_complete *out, + const struct tlv_parsed *tp, struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_RR_LOADING_LIST, 6) || + !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) + return -EINVAL; + + INIT_LLIST_HEAD(&out->loading_list.list); + cbsp_decode_loading_list(&out->loading_list, ctx, + TLVP_VAL(tp, CBSP_IEI_RR_LOADING_LIST), + TLVP_LEN(tp, CBSP_IEI_RR_LOADING_LIST)); + + out->channel_ind = *TLVP_VAL(tp, CBSP_IEI_CHANNEL_IND); + return 0; +} + +/* 8.1.3.9 LOAD QUERY FAILURE */ +static int cbsp_dec_load_query_fail(struct osmo_cbsp_load_query_failure *out, + const struct tlv_parsed *tp, struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5) || + !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) + return -EINVAL; + + INIT_LLIST_HEAD(&out->fail_list); + cbsp_decode_fail_list(&out->fail_list, ctx, + TLVP_VAL(tp, CBSP_IEI_FAILURE_LIST), + TLVP_LEN(tp, CBSP_IEI_FAILURE_LIST)); + + out->channel_ind = *TLVP_VAL(tp, CBSP_IEI_CHANNEL_IND); + + INIT_LLIST_HEAD(&out->loading_list.list); + if (TLVP_PRES_LEN(tp, CBSP_IEI_RR_LOADING_LIST, 6)) { + cbsp_decode_loading_list(&out->loading_list, ctx, + TLVP_VAL(tp, CBSP_IEI_RR_LOADING_LIST), + TLVP_LEN(tp, CBSP_IEI_RR_LOADING_LIST)); + } + return 0; +} + +/* 8.1.3.10 STATUS QUERY */ +static int cbsp_dec_msg_status_query(struct osmo_cbsp_msg_status_query *out, + const struct tlv_parsed *tp, struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1) || + !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) + return -EINVAL; + out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); + out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); + + INIT_LLIST_HEAD(&out->cell_list.list); + cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), + TLVP_LEN(tp, CBSP_IEI_CELL_LIST)); + + out->channel_ind = *TLVP_VAL(tp, CBSP_IEI_CHANNEL_IND); + return 0; +} + +/* 8.1.3.11 STATUS QUERY COMPLETE */ +static int cbsp_dec_msg_status_query_compl(struct osmo_cbsp_msg_status_query_complete *out, + const struct tlv_parsed *tp, struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST, 7) || + !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) + return -EINVAL; + + out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); + out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); + + INIT_LLIST_HEAD(&out->num_compl_list.list); + cbsp_decode_num_compl_list(&out->num_compl_list, ctx, + TLVP_VAL(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST), + TLVP_LEN(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST)); + out->channel_ind = *TLVP_VAL(tp, CBSP_IEI_CHANNEL_IND); + return 0; +} + +/* 8.1.3.12 STATUS QUERY FAILURE */ +static int cbsp_dec_msg_status_query_fail(struct osmo_cbsp_msg_status_query_failure *out, + const struct tlv_parsed *tp, struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2) || + !TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5) || + !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) + return -EINVAL; + + out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); + out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); + + INIT_LLIST_HEAD(&out->fail_list); + cbsp_decode_fail_list(&out->fail_list, ctx, + TLVP_VAL(tp, CBSP_IEI_FAILURE_LIST), + TLVP_LEN(tp, CBSP_IEI_FAILURE_LIST)); + + out->channel_ind = *TLVP_VAL(tp, CBSP_IEI_CHANNEL_IND); + + INIT_LLIST_HEAD(&out->num_compl_list.list); + if (TLVP_PRES_LEN(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST, 7)) { + cbsp_decode_num_compl_list(&out->num_compl_list, ctx, + TLVP_VAL(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST), + TLVP_LEN(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST)); + } + return 0; +} + +/* 8.1.3.16 RESET */ +static int cbsp_dec_reset(struct osmo_cbsp_reset *out, const struct tlv_parsed *tp, + struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) + return -EINVAL; + + INIT_LLIST_HEAD(&out->cell_list.list); + cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), + TLVP_LEN(tp, CBSP_IEI_CELL_LIST)); + return 0; +} + +/* 8.1.3.17 RESET COMPLETE */ +static int cbsp_dec_reset_compl(struct osmo_cbsp_reset_complete *out, const struct tlv_parsed *tp, + struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) + return -EINVAL; + + INIT_LLIST_HEAD(&out->cell_list.list); + cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), + TLVP_LEN(tp, CBSP_IEI_CELL_LIST)); + return 0; +} + +/* 8.1.3.18 RESET FAILURE */ +static int cbsp_dec_reset_fail(struct osmo_cbsp_reset_failure *out, const struct tlv_parsed *tp, + struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5)) + return -EINVAL; + + INIT_LLIST_HEAD(&out->fail_list); + cbsp_decode_fail_list(&out->fail_list, ctx, + TLVP_VAL(tp, CBSP_IEI_FAILURE_LIST), + TLVP_LEN(tp, CBSP_IEI_FAILURE_LIST)); + + INIT_LLIST_HEAD(&out->cell_list.list); + if (TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) { + cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), + TLVP_LEN(tp, CBSP_IEI_CELL_LIST)); + } + return 0; +} + +/* 8.1.3.18a KEEP ALIVE */ +static int cbsp_dec_keep_alive(struct osmo_cbsp_keep_alive *out, const struct tlv_parsed *tp, + struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_KEEP_ALIVE_REP_PERIOD, 1)) + return -EINVAL; + + out->repetition_period = *TLVP_VAL(tp, CBSP_IEI_KEEP_ALIVE_REP_PERIOD); + return 0; +} + +/* 8.1.3.18b KEEP ALIVE COMPLETE */ +static int cbsp_dec_keep_alive_compl(struct osmo_cbsp_keep_alive_complete *out, + const struct tlv_parsed *tp, struct msgb *in, void *ctx) +{ + return 0; +} + +/* 8.1.3.19 RESTART */ +static int cbsp_dec_restart(struct osmo_cbsp_restart *out, const struct tlv_parsed *tp, + struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1) || + !TLVP_PRES_LEN(tp, CBSP_IEI_BCAST_MSG_TYPE, 1) || + !TLVP_PRES_LEN(tp, CBSP_IEI_RECOVERY_IND, 1)) + return -EINVAL; + + INIT_LLIST_HEAD(&out->cell_list.list); + cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), + TLVP_LEN(tp, CBSP_IEI_CELL_LIST)); + + out->bcast_msg_type = *TLVP_VAL(tp, CBSP_IEI_BCAST_MSG_TYPE); + out->recovery_ind = *TLVP_VAL(tp, CBSP_IEI_RECOVERY_IND); + return 0; +} + +/* 8.1.3.20 FAILURE */ +static int cbsp_dec_failure(struct osmo_cbsp_failure *out, const struct tlv_parsed *tp, + struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5) || + !TLVP_PRES_LEN(tp, CBSP_IEI_BCAST_MSG_TYPE, 1)) + return -EINVAL; + + INIT_LLIST_HEAD(&out->fail_list); + cbsp_decode_fail_list(&out->fail_list, ctx, + TLVP_VAL(tp, CBSP_IEI_FAILURE_LIST), + TLVP_LEN(tp, CBSP_IEI_FAILURE_LIST)); + + out->bcast_msg_type = *TLVP_VAL(tp, CBSP_IEI_BCAST_MSG_TYPE); + return 0; +} + +/* 8.1.3.21 ERROR INDICATION */ +static int cbsp_dec_error_ind(struct osmo_cbsp_error_ind *out, const struct tlv_parsed *tp, + struct msgb *in, void *ctx) +{ + if (!TLVP_PRES_LEN(tp, CBSP_IEI_CAUSE, 1)) + return -EINVAL; + + out->cause = *TLVP_VAL(tp, CBSP_IEI_CAUSE); + if (TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2)) { + out->msg_id = talloc(ctx, uint16_t); + *out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); + } + if (TLVP_PRES_LEN(tp, CBSP_IEI_NEW_SERIAL_NR, 2)) { + out->new_serial_nr = talloc(ctx, uint16_t); + *out->new_serial_nr = tlvp_val16be(tp, CBSP_IEI_NEW_SERIAL_NR); + } + if (TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2)) { + out->old_serial_nr = talloc(ctx, uint16_t); + *out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); + } + if (TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) { + out->channel_ind = talloc(ctx, enum cbsp_channel_ind); + *out->channel_ind = *TLVP_VAL(tp, CBSP_IEI_CHANNEL_IND); + } + return 0; +} + +/*! Decode a CBSP message from wire formwat to pased structure. + * \param[in] ctx talloc context from which to allocate decoded output. + * \param[in] in message buffer contiaining binary CBSP message. + * \returns callee-allocated decoded representation of CBSP message; NULL on error */ +struct osmo_cbsp_decoded *osmo_cbsp_decode(void *ctx, struct msgb *in) +{ + struct osmo_cbsp_decoded *out = talloc_zero(ctx, struct osmo_cbsp_decoded); + const struct cbsp_header *h = msgb_l1(in); + struct tlv_parsed tp[16]; /* max. number of pages in a given CBS message */ + unsigned int len; + int rc; + + if (!out) + return NULL; + + if (msgb_l1len(in) < sizeof(*h)) { + goto out_err; + } + len = h->len[0] << 16 | h->len[1] << 8 | h->len[2]; + + /* discard messages where indicated length is more than we have */ + if (len > msgb_l2len(in)) { + goto out_err; + } + + /* trim any messages with extra payload at the end */ + if (len < msgb_l2len(in)) + msgb_trim(in, (in->l2h - in->data) + msgb_l2len(in)); + out->msg_type = h->msg_type; + + rc = tlv_parse2(tp, ARRAY_SIZE(tp), &cbsp_att_tlvdef, msgb_l2(in), msgb_l2len(in), 0, 0); + if (rc < 0) { + goto out_err; + } + + switch (h->msg_type) { + case CBSP_MSGT_WRITE_REPLACE: + rc = cbsp_dec_write_repl(&out->u.write_replace, tp, in, out); + break; + case CBSP_MSGT_WRITE_REPLACE_COMPL: + rc = cbsp_dec_write_repl_compl(&out->u.write_replace_compl, tp, in, out); + break; + case CBSP_MSGT_WRITE_REPLACE_FAIL: + rc = cbsp_dec_write_repl_fail(&out->u.write_replace_fail, tp, in, out); + break; + case CBSP_MSGT_KILL: + rc = cbsp_dec_kill(&out->u.kill, tp, in, out); + break; + case CBSP_MSGT_KILL_COMPL: + rc = cbsp_dec_kill_compl(&out->u.kill_compl, tp, in, out); + break; + case CBSP_MSGT_KILL_FAIL: + rc = cbsp_dec_kill_fail(&out->u.kill_fail, tp, in, out); + break; + case CBSP_MSGT_LOAD_QUERY: + rc = cbsp_dec_load_query(&out->u.load_query, tp, in, out); + break; + case CBSP_MSGT_LOAD_QUERY_COMPL: + rc = cbsp_dec_load_query_compl(&out->u.load_query_compl, tp, in, out); + break; + case CBSP_MSGT_LOAD_QUERY_FAIL: + rc = cbsp_dec_load_query_fail(&out->u.load_query_fail, tp, in, out); + break; + case CBSP_MSGT_MSG_STATUS_QUERY: + rc = cbsp_dec_msg_status_query(&out->u.msg_status_query, tp, in, out); + break; + case CBSP_MSGT_MSG_STATUS_QUERY_COMPL: + rc = cbsp_dec_msg_status_query_compl(&out->u.msg_status_query_compl, tp, in, out); + break; + case CBSP_MSGT_MSG_STATUS_QUERY_FAIL: + rc = cbsp_dec_msg_status_query_fail(&out->u.msg_status_query_fail, tp, in, out); + break; + case CBSP_MSGT_RESET: + rc = cbsp_dec_reset(&out->u.reset, tp, in, out); + break; + case CBSP_MSGT_RESET_COMPL: + rc = cbsp_dec_reset_compl(&out->u.reset_compl, tp, in, out); + break; + case CBSP_MSGT_RESET_FAIL: + rc = cbsp_dec_reset_fail(&out->u.reset_fail, tp, in, out); + break; + case CBSP_MSGT_RESTART: + rc = cbsp_dec_restart(&out->u.restart, tp, in, out); + break; + case CBSP_MSGT_FAILURE: + rc = cbsp_dec_failure(&out->u.failure, tp, in, out); + break; + case CBSP_MSGT_ERROR_IND: + rc = cbsp_dec_error_ind(&out->u.error_ind, tp, in, out); + break; + case CBSP_MSGT_KEEP_ALIVE: + rc = cbsp_dec_keep_alive(&out->u.keep_alive, tp, in, out); + break; + case CBSP_MSGT_KEEP_ALIVE_COMPL: + rc = cbsp_dec_keep_alive_compl(&out->u.keep_alive_compl, tp, in, out); + break; + case CBSP_MSGT_SET_DRX: + case CBSP_MSGT_SET_DRX_COMPL: + case CBSP_MSGT_SET_DRX_FAIL: + rc = -1; + break; + default: + rc = -1; + break; + } + + if (rc < 0) { + goto out_err; + } + + return out; + +out_err: + talloc_free(out); + return NULL; +} + +/* initialization of 'decoded' structure of given message type */ +void osmo_cbsp_init_struct(struct osmo_cbsp_decoded *cbsp, enum cbsp_msg_type msg_type) +{ + memset(cbsp, 0, sizeof(*cbsp)); + cbsp->msg_type = msg_type; + + switch (msg_type) { + case CBSP_MSGT_WRITE_REPLACE: + INIT_LLIST_HEAD(&cbsp->u.write_replace.cell_list.list); + break; + case CBSP_MSGT_WRITE_REPLACE_COMPL: + INIT_LLIST_HEAD(&cbsp->u.write_replace_compl.num_compl_list.list); + INIT_LLIST_HEAD(&cbsp->u.write_replace_compl.cell_list.list); + break; + case CBSP_MSGT_WRITE_REPLACE_FAIL: + INIT_LLIST_HEAD(&cbsp->u.write_replace_fail.fail_list); + INIT_LLIST_HEAD(&cbsp->u.write_replace_fail.num_compl_list.list); + INIT_LLIST_HEAD(&cbsp->u.write_replace_fail.cell_list.list); + break; + case CBSP_MSGT_KILL: + INIT_LLIST_HEAD(&cbsp->u.kill.cell_list.list); + break; + case CBSP_MSGT_KILL_COMPL: + INIT_LLIST_HEAD(&cbsp->u.kill_compl.num_compl_list.list); + INIT_LLIST_HEAD(&cbsp->u.kill_compl.cell_list.list); + break; + case CBSP_MSGT_KILL_FAIL: + INIT_LLIST_HEAD(&cbsp->u.kill_fail.fail_list); + INIT_LLIST_HEAD(&cbsp->u.kill_fail.num_compl_list.list); + INIT_LLIST_HEAD(&cbsp->u.kill_fail.cell_list.list); + break; + case CBSP_MSGT_LOAD_QUERY: + INIT_LLIST_HEAD(&cbsp->u.load_query.cell_list.list); + break; + case CBSP_MSGT_LOAD_QUERY_COMPL: + INIT_LLIST_HEAD(&cbsp->u.load_query_compl.loading_list.list); + break; + case CBSP_MSGT_LOAD_QUERY_FAIL: + INIT_LLIST_HEAD(&cbsp->u.load_query_fail.fail_list); + break; + case CBSP_MSGT_MSG_STATUS_QUERY: + INIT_LLIST_HEAD(&cbsp->u.msg_status_query.cell_list.list); + break; + case CBSP_MSGT_MSG_STATUS_QUERY_COMPL: + INIT_LLIST_HEAD(&cbsp->u.msg_status_query_compl.num_compl_list.list); + break; + case CBSP_MSGT_MSG_STATUS_QUERY_FAIL: + INIT_LLIST_HEAD(&cbsp->u.msg_status_query_fail.fail_list); + INIT_LLIST_HEAD(&cbsp->u.msg_status_query_fail.num_compl_list.list); + break; + case CBSP_MSGT_RESET: + INIT_LLIST_HEAD(&cbsp->u.reset.cell_list.list); + break; + case CBSP_MSGT_RESET_COMPL: + INIT_LLIST_HEAD(&cbsp->u.reset_compl.cell_list.list); + break; + case CBSP_MSGT_RESET_FAIL: + INIT_LLIST_HEAD(&cbsp->u.reset_fail.fail_list); + INIT_LLIST_HEAD(&cbsp->u.reset_fail.cell_list.list); + break; + case CBSP_MSGT_RESTART: + INIT_LLIST_HEAD(&cbsp->u.restart.cell_list.list); + break; + case CBSP_MSGT_FAILURE: + INIT_LLIST_HEAD(&cbsp->u.failure.fail_list); + break; + default: + break; + } +} + +/*! Dynamically allocate and initialize decoded CBSP structure. + * \param[in] ctx talloc context from which to allocate + * \param[in] msg_type CBSP message type for which to initialize result + * \returns allocated + initialized decoded CBSP structure; NULL on talloc failure */ +struct osmo_cbsp_decoded *osmo_cbsp_decoded_alloc(void *ctx, enum cbsp_msg_type msg_type) +{ + struct osmo_cbsp_decoded *cbsp = talloc_zero(ctx, struct osmo_cbsp_decoded); + if (!cbsp) + return NULL; + osmo_cbsp_init_struct(cbsp, msg_type); + return cbsp; +} + +/*********************************************************************** + * Message Reception + ***********************************************************************/ + +#ifdef HAVE_SYS_SOCKET_H +#include + +/*! Read one CBSP message from socket fd or store part if still not fully received. + * \param[in] ctx talloc context from which to allocate new msgb. + * \param[in] fd The fd for the socket to read from. + * \param[out] rmsg internally allocated msgb containing a fully received CBSP message. + * \param[inout] tmp_msg internally allocated msgb caching data for not yet fully received message. + * + * Function is designed just like ipa_msg_recv_buffered() + */ +int osmo_cbsp_recv_buffered(void *ctx, int fd, struct msgb **rmsg, struct msgb **tmp_msg) +{ + struct msgb *msg = tmp_msg ? *tmp_msg : NULL; + struct cbsp_header *h; + int len, rc; + int needed; + + if (!msg) { + msg = osmo_cbsp_msgb_alloc(ctx, __func__); + if (!msg) { + return -ENOMEM; + goto discard_msg; + } + msg->l1h = msg->tail; + } + + if (msg->l2h == NULL) { + /* first read the [missing part of the] header */ + needed = sizeof(*h) - msg->len; + rc = recv(fd, msg->tail, needed, 0); + if (rc == 0) + goto discard_msg; + else if (rc < 0) { + if (errno == EAGAIN || errno == EINTR) + rc = 0; + else { + rc = -errno; + goto discard_msg; + } + } + msgb_put(msg, rc); + if (rc < needed) { + if (msg->len == 0) { + rc = -EAGAIN; + goto discard_msg; + } + + if (!tmp_msg) { + rc = -EIO; + goto discard_msg; + } + *tmp_msg = msg; + return -EAGAIN; + } + msg->l2h = msg->tail; + } + + h = (struct cbsp_header *) msg->data; + /* then read the length as specified in the header */ + len = h->len[0] << 16 | h->len[1] << 8 | h->len[2]; + + needed = len - msgb_l2len(msg); + if (needed > 0) { + rc = recv(fd, msg->tail, needed, 0); + if (rc == 0) + goto discard_msg; + else if (rc < 0) { + if (errno == EAGAIN || errno == EINTR) + rc = 0; + else { + rc = -errno; + goto discard_msg; + } + } + msgb_put(msg, rc); + /* still not all of payload received? */ + if (rc < needed) { + if (!tmp_msg) { + rc = -EIO; + goto discard_msg; + } + *tmp_msg = msg; + return -EAGAIN; + } + } + /* else: complete message received */ + rc = msgb_l2len(msg); + if (rc == 0) { + /* drop empty message */ + rc = -EAGAIN; + goto discard_msg; + } + if (tmp_msg) + *tmp_msg = NULL; + *rmsg = msg; + return rc; + +discard_msg: + printf("discard_msg\n"); + if (tmp_msg) + *tmp_msg = NULL; + msgb_free(msg); + return rc; +} + +#endif /* HAVE_SYS_SOCKET_H */ diff --git a/src/gsm/gsm48049.c b/src/gsm/gsm48049.c new file mode 100644 index 0000000..5e74356 --- /dev/null +++ b/src/gsm/gsm48049.c @@ -0,0 +1,111 @@ +/* CBSP is an ETSI/3GPP standard protocol used between CBC (Cell Brodadcast Centre) + * and BSC (Base Station Controller0 in 2G/GSM/GERAN networks. It is specified + * in 3GPP TS 48.049 + * + * (C) 2019 by Harald Welte + * All rights reserved. + * + * SPDX-License-Identifier: GPL-2.0+ + * + * Released under the terms of the GNU General Public License, Version 2 or + * (at your option) any later version. + */ + +#include +#include +#include + +/*********************************************************************** + * Protocol Definitions + ***********************************************************************/ + +const struct value_string cbsp_msg_type_names[] = { + { CBSP_MSGT_WRITE_REPLACE, "WRITE-REPLACE" }, + { CBSP_MSGT_WRITE_REPLACE_COMPL, "WRITE-REPLACE COMPLETE" }, + { CBSP_MSGT_WRITE_REPLACE_FAIL, "WRITE-REPLACE FAILURE" }, + { CBSP_MSGT_KILL, "KILL" }, + { CBSP_MSGT_KILL_COMPL, "KILL COMPLETE" }, + { CBSP_MSGT_KILL_FAIL, "KILL FAILURE" }, + { CBSP_MSGT_LOAD_QUERY, "LOAD QUERY" }, + { CBSP_MSGT_LOAD_QUERY_COMPL, "LOAD QUERY COMPLETE" }, + { CBSP_MSGT_LOAD_QUERY_FAIL, "LOAD QUERY FAILURE" }, + { CBSP_MSGT_MSG_STATUS_QUERY, "MESSAGE STATUS QUERY" }, + { CBSP_MSGT_MSG_STATUS_QUERY_COMPL, "MESSAGE STATUS QUERY COMPLETE" }, + { CBSP_MSGT_MSG_STATUS_QUERY_FAIL, "MESSAGE STATUS QUERY FAILURE" }, + { CBSP_MSGT_SET_DRX, "SET-DRX" }, + { CBSP_MSGT_SET_DRX_COMPL, "SET-DRX COMPLETE" }, + { CBSP_MSGT_SET_DRX_FAIL, "SET-DRX FAILURE" }, + { CBSP_MSGT_RESET, "RESET" }, + { CBSP_MSGT_RESET_COMPL, "RESET COMPLETE" }, + { CBSP_MSGT_RESET_FAIL, "RESET FAILURE" }, + { CBSP_MSGT_RESTART, "RESTART" }, + { CBSP_MSGT_FAILURE, "FAILURE" }, + { CBSP_MSGT_ERROR_IND, "ERROR INDICATION" }, + { CBSP_MSGT_KEEP_ALIVE, "KEEP-ALIVE" }, + { CBSP_MSGT_KEEP_ALIVE_COMPL, "KEEP-ALIVE COMPLETE" }, + { 0, NULL } +}; + +const struct value_string cbsp_iei_names[] = { + { CBSP_IEI_MSG_CONTENT, "Message Content" }, + { CBSP_IEI_OLD_SERIAL_NR, "Old Serial Number" }, + { CBSP_IEI_NEW_SERIAL_NR, "New Serial Number" }, + { CBSP_IEI_CELL_LIST, "Cell List" }, + { CBSP_IEI_CATEGORY, "Category" }, + { CBSP_IEI_REP_PERIOD, "Repetition Period" }, + { CBSP_IEI_NUM_BCAST_REQ, "Number of Broadcasts Requested" }, + { CBSP_IEI_NUM_BCAST_COMPL_LIST,"Number of Broadcasts Completed List" }, + { CBSP_IEI_FAILURE_LIST, "Failure List" }, + { CBSP_IEI_RR_LOADING_LIST, "Radio Resource Loading List" }, + { CBSP_IEI_CAUSE, "Cause" }, + { CBSP_IEI_DCS, "Data Coding Scheme" }, + { CBSP_IEI_RECOVERY_IND, "Recovery Indication" }, + { CBSP_IEI_MSG_ID, "Message Identifier" }, + { CBSP_IEI_EMERG_IND, "Emergency Indicator" }, + { CBSP_IEI_WARN_TYPE, "Warning Type" }, + { CBSP_IEI_WARN_SEC_INFO, "warning Security Information" }, + { CBSP_IEI_CHANNEL_IND, "Channel Indicator" }, + { CBSP_IEI_NUM_OF_PAGES, "Number of Pages" }, + { CBSP_IEI_SCHEDULE_PERIOD, "Schedule Period" }, + { CBSP_IEI_NUM_OF_RES_SLOTS, "Number of Reserved Slots" }, + { CBSP_IEI_BCAST_MSG_TYPE, "Broadcast Message Type" }, + { CBSP_IEI_WARNING_PERIOD, "Waring Period" }, + { CBSP_IEI_KEEP_ALIVE_REP_PERIOD, "Keep Alive Repetition Period" }, + { 0, NULL } +}; + +const struct value_string cbsp_category_names[] = { + { CBSP_CATEG_HIGH_PRIO, "High Priority" }, + { CBSP_CATEG_BACKGROUND, "Background" }, + { CBSP_CATEG_NORMAL, "Normal" }, + { 0, NULL } +}; + +const struct tlv_definition cbsp_att_tlvdef = { + .def = { + [CBSP_IEI_MSG_CONTENT] = { TLV_TYPE_FIXED, 83 }, + [CBSP_IEI_OLD_SERIAL_NR] = { TLV_TYPE_FIXED, 2 }, + [CBSP_IEI_NEW_SERIAL_NR] = { TLV_TYPE_FIXED, 2 }, + [CBSP_IEI_CELL_LIST] = { TLV_TYPE_TL16V }, + [CBSP_IEI_CATEGORY] = { TLV_TYPE_TV }, + [CBSP_IEI_REP_PERIOD] = { TLV_TYPE_FIXED, 2 }, + [CBSP_IEI_NUM_BCAST_REQ] = { TLV_TYPE_FIXED, 2 }, + [CBSP_IEI_NUM_BCAST_COMPL_LIST] = { TLV_TYPE_TL16V }, + [CBSP_IEI_FAILURE_LIST] = { TLV_TYPE_TL16V }, + [CBSP_IEI_RR_LOADING_LIST] = { TLV_TYPE_TL16V }, + [CBSP_IEI_CAUSE] = { TLV_TYPE_TV }, + [CBSP_IEI_DCS] = { TLV_TYPE_TV }, + [CBSP_IEI_RECOVERY_IND] { TLV_TYPE_TV }, + [CBSP_IEI_MSG_ID] = { TLV_TYPE_FIXED, 2 }, + [CBSP_IEI_EMERG_IND] = { TLV_TYPE_TV }, + [CBSP_IEI_WARN_TYPE] = { TLV_TYPE_FIXED, 2 }, + [CBSP_IEI_WARN_SEC_INFO] = { TLV_TYPE_FIXED, 50 }, + [CBSP_IEI_CHANNEL_IND] = { TLV_TYPE_TV }, + [CBSP_IEI_NUM_OF_PAGES] = { TLV_TYPE_TV }, + [CBSP_IEI_SCHEDULE_PERIOD] = { TLV_TYPE_TV }, + [CBSP_IEI_NUM_OF_RES_SLOTS] = { TLV_TYPE_TV }, + [CBSP_IEI_BCAST_MSG_TYPE] = { TLV_TYPE_TV }, + [CBSP_IEI_WARNING_PERIOD] = { TLV_TYPE_TV }, + [CBSP_IEI_KEEP_ALIVE_REP_PERIOD] = { TLV_TYPE_TV }, + }, +}; diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map index 34a1543..eefcf61 100644 --- a/src/gsm/libosmogsm.map +++ b/src/gsm/libosmogsm.map @@ -646,5 +646,16 @@ osmo_gsm48_classmark_a5_name_c; osmo_gsm48_classmark_update; +cbsp_msg_type_names; +cbsp_iei_names; +cbsp_category_names; +cbsp_att_tlvdef; +osmo_cbsp_msgb_alloc; +osmo_cbsp_decoded_alloc; +osmo_cbsp_init_struct; +osmo_cbsp_encode; +osmo_cbsp_decode; +osmo_cbsp_recv_buffered; + local: *; }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14360 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5b7ae08f67e415967b60ac4b824db9e22ca00935 Gerrit-Change-Number: 14360 Gerrit-PatchSet: 7 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:19:24 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:19:24 +0000 Subject: Change in ...libosmocore[master]: cbsp: Introduce osmo_cbsp_errstr In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14478 ) Change subject: cbsp: Introduce osmo_cbsp_errstr ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9a5a595a76ba278647aee9470ded213d8464103 Gerrit-Change-Number: 14478 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 20 Jul 2019 10:19:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:20:30 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:20:30 +0000 Subject: Change in ...osmo-remsim[master]: rspro_server.c: Fix memory leak in processing inbound RSPRO In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14827 ) Change subject: rspro_server.c: Fix memory leak in processing inbound RSPRO ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14827 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I12b4a22854eea79c9e9c3e565dd4803e4dc0ed5a Gerrit-Change-Number: 14827 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: roh Gerrit-Comment-Date: Sat, 20 Jul 2019 10:20:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:20:39 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:20:39 +0000 Subject: Change in ...osmo-remsim[master]: remsim_client: Fix memory leak receiving RSPRO messages In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14829 ) Change subject: remsim_client: Fix memory leak receiving RSPRO messages ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic3b5b7b03d557557a245fcd5c31bd687e11c7477 Gerrit-Change-Number: 14829 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: roh Gerrit-Comment-Date: Sat, 20 Jul 2019 10:20:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:20:40 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:20:40 +0000 Subject: Change in ...osmo-remsim[master]: rspro_client_fsm: Fix memory leak processing RSPRO In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14831 ) Change subject: rspro_client_fsm: Fix memory leak processing RSPRO ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14831 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2c3710d152ce31d293a3693a70718c8712e2ac2b Gerrit-Change-Number: 14831 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: roh Gerrit-Comment-Date: Sat, 20 Jul 2019 10:20:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:20:41 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:20:41 +0000 Subject: Change in ...osmo-remsim[master]: rspro_server.c: Fix memory leak in processing inbound RSPRO In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14827 ) Change subject: rspro_server.c: Fix memory leak in processing inbound RSPRO ...................................................................... rspro_server.c: Fix memory leak in processing inbound RSPRO We need to unconditionally free the msgb that gets handed into sock_read_cb() by the ipa server. Closes: OS#4096 Change-Id: I12b4a22854eea79c9e9c3e565dd4803e4dc0ed5a --- M src/server/rspro_server.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/server/rspro_server.c b/src/server/rspro_server.c index 7cf98ad..c753f16 100644 --- a/src/server/rspro_server.c +++ b/src/server/rspro_server.c @@ -613,6 +613,7 @@ default: goto invalid; } + msgb_free(msg); return rc; invalid: -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14827 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I12b4a22854eea79c9e9c3e565dd4803e4dc0ed5a Gerrit-Change-Number: 14827 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: roh Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:20:42 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:20:42 +0000 Subject: Change in ...osmo-remsim[master]: remsim_client: Fix memory leak receiving RSPRO messages In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14829 ) Change subject: remsim_client: Fix memory leak receiving RSPRO messages ...................................................................... remsim_client: Fix memory leak receiving RSPRO messages Change-Id: Ic3b5b7b03d557557a245fcd5c31bd687e11c7477 Closes: OS#4119 --- M src/simtrace2-remsim_client.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/simtrace2-remsim_client.c b/src/simtrace2-remsim_client.c index 9bedf71..04aa0c6 100644 --- a/src/simtrace2-remsim_client.c +++ b/src/simtrace2-remsim_client.c @@ -627,7 +627,7 @@ LOGPFSML(bc->bankd_fi, LOGL_DEBUG, "Received RSPRO %s\n", msgb_hexdump(msg)); rc = bankd_handle_msg(bc, msg); - + msgb_free(msg); return rc; invalid: -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ic3b5b7b03d557557a245fcd5c31bd687e11c7477 Gerrit-Change-Number: 14829 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: roh Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:20:42 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:20:42 +0000 Subject: Change in ...osmo-remsim[master]: rspro_client_fsm: Fix memory leak processing RSPRO In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14831 ) Change subject: rspro_client_fsm: Fix memory leak processing RSPRO ...................................................................... rspro_client_fsm: Fix memory leak processing RSPRO Change-Id: I2c3710d152ce31d293a3693a70718c8712e2ac2b Closes: OS#4097 --- M src/rspro_client_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 1527eff..768c15f 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -152,7 +152,7 @@ default: goto invalid; } - + msgb_free(msg); return rc; invalid: -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14831 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2c3710d152ce31d293a3693a70718c8712e2ac2b Gerrit-Change-Number: 14831 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: roh Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:27:17 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:27:17 +0000 Subject: Change in ...libosmocore[master]: cbsp: Introduce osmo_cbsp_errstr In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14478 ) Change subject: cbsp: Introduce osmo_cbsp_errstr ...................................................................... cbsp: Introduce osmo_cbsp_errstr Rather than having the encoder/decoder library print some log messages in case of encoding/decoding errors, let's provide something akin to 'errno', but with a string instead of a numeric error code. The 'osmo_cbsp_errstr' global variable (if set) contains a human-readable string describing the most recent encoding/decoding error. It exists separately for each thread and hence can be used safely in multi-threaded environments. Change-Id: Id9a5a595a76ba278647aee9470ded213d8464103 --- M include/osmocom/gsm/cbsp.h M src/gsm/cbsp.c M src/gsm/libosmogsm.map 3 files changed, 102 insertions(+), 28 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/gsm/cbsp.h b/include/osmocom/gsm/cbsp.h index d47b37b..90516cb 100644 --- a/include/osmocom/gsm/cbsp.h +++ b/include/osmocom/gsm/cbsp.h @@ -283,6 +283,8 @@ } u; }; +extern const __thread char *osmo_cbsp_errstr; + struct msgb *osmo_cbsp_msgb_alloc(void *ctx, const char *name); struct msgb *osmo_cbsp_encode(void *ctx, const struct osmo_cbsp_decoded *in); struct osmo_cbsp_decoded *osmo_cbsp_decode(void *ctx, struct msgb *in); diff --git a/src/gsm/cbsp.c b/src/gsm/cbsp.c index a891c52..23f68de 100644 --- a/src/gsm/cbsp.c +++ b/src/gsm/cbsp.c @@ -33,6 +33,8 @@ #include #include +const __thread char *osmo_cbsp_errstr; + struct msgb *osmo_cbsp_msgb_alloc(void *ctx, const char *name) { /* make the messages rather large as the cell lists can be long! */ @@ -134,6 +136,7 @@ return (secs-120)/10; if (secs <= 60*60) return (secs-600)/30; + osmo_cbsp_errstr = "warning period out of range"; return -1; } @@ -152,8 +155,10 @@ if (in->is_cbs) { int num_of_pages = llist_count(&in->u.cbs.msg_content); struct osmo_cbsp_content *ce; - if (num_of_pages == 0 || num_of_pages > 15) + if (num_of_pages == 0 || num_of_pages > 15) { + osmo_cbsp_errstr = "invalid number of pages"; return -EINVAL; + } msgb_tv_put(msg, CBSP_IEI_CHANNEL_IND, in->u.cbs.channel_ind); msgb_tv_put(msg, CBSP_IEI_CATEGORY, in->u.cbs.category); msgb_tv16_put(msg, CBSP_IEI_REP_PERIOD, in->u.cbs.rep_period); @@ -395,6 +400,8 @@ unsigned int len; int rc; + osmo_cbsp_errstr = NULL; + if (!msg) return NULL; @@ -462,9 +469,11 @@ case CBSP_MSGT_SET_DRX: case CBSP_MSGT_SET_DRX_COMPL: case CBSP_MSGT_SET_DRX_FAIL: + osmo_cbsp_errstr = "message type not implemented"; rc = -1; break; default: + osmo_cbsp_errstr = "message type not known in spec"; rc = -1; break; } @@ -502,8 +511,10 @@ unsigned int len_remain = len - (cur - buf); OSMO_ASSERT(ent); rc = gsm0808_decode_cell_id_u(&ent->cell_id, cl->id_discr, cur, len_remain); - if (rc < 0) + if (rc < 0) { + osmo_cbsp_errstr = "cell list: error decoding cell_id_union"; return rc; + } cur += rc; llist_add_tail(&ent->list, &cl->list); } @@ -523,8 +534,10 @@ OSMO_ASSERT(ent); ent->id_discr = cur[0]; rc = gsm0808_decode_cell_id_u(&ent->cell_id, ent->id_discr, cur+1, len_remain-1); - if (rc < 0) + if (rc < 0) { + osmo_cbsp_errstr = "fail list: error decoding cell_id_union"; return rc; + } cur += rc; ent->cause = *cur++; llist_add_tail(&ent->list, fl); @@ -545,11 +558,14 @@ unsigned int len_remain = len - (cur - buf); OSMO_ASSERT(ent); rc = gsm0808_decode_cell_id_u(&ent->cell_id, ll->id_discr, cur, len_remain); - if (rc < 0) + if (rc < 0) { + osmo_cbsp_errstr = "load list: error decoding cell_id_union"; return rc; + } cur += rc; if (cur + 2 > buf + len) { talloc_free(ent); + osmo_cbsp_errstr = "load list: truncated IE"; return -EINVAL; } ent->load[0] = *cur++; @@ -572,11 +588,14 @@ unsigned int len_remain = len - (cur - buf); OSMO_ASSERT(ent); rc = gsm0808_decode_cell_id_u(&ent->cell_id, cl->id_discr, cur, len_remain); - if (rc < 0) + if (rc < 0) { + osmo_cbsp_errstr = "completed list: error decoding cell_id_union"; return rc; + } cur += rc; if (cur + 3 > buf + len) { talloc_free(ent); + osmo_cbsp_errstr = "completed list: truncated IE"; return -EINVAL; } ent->num_compl = osmo_load16be(cur); cur += 2; @@ -619,8 +638,10 @@ /* check for mandatory IEs */ if (!TLVP_PRESENT(tp, CBSP_IEI_MSG_ID) || !TLVP_PRESENT(tp, CBSP_IEI_NEW_SERIAL_NR) || - !TLVP_PRESENT(tp, CBSP_IEI_CELL_LIST)) + !TLVP_PRESENT(tp, CBSP_IEI_CELL_LIST)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); out->new_serial_nr = tlvp_val16be(tp, CBSP_IEI_NEW_SERIAL_NR); @@ -636,14 +657,18 @@ if (TLVP_PRESENT(tp, CBSP_IEI_CHANNEL_IND)) { uint8_t num_of_pages; INIT_LLIST_HEAD(&out->u.cbs.msg_content); - if (TLVP_PRESENT(tp, CBSP_IEI_EMERG_IND)) + if (TLVP_PRESENT(tp, CBSP_IEI_EMERG_IND)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } if (!TLVP_PRESENT(tp, CBSP_IEI_CATEGORY) || !TLVP_PRESENT(tp, CBSP_IEI_REP_PERIOD) || !TLVP_PRESENT(tp, CBSP_IEI_NUM_BCAST_REQ) || !TLVP_PRESENT(tp, CBSP_IEI_NUM_OF_PAGES) || - !TLVP_PRESENT(tp, CBSP_IEI_DCS)) + !TLVP_PRESENT(tp, CBSP_IEI_DCS)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } out->is_cbs = true; out->u.cbs.channel_ind = *TLVP_VAL(tp, CBSP_IEI_CHANNEL_IND); out->u.cbs.category = *TLVP_VAL(tp, CBSP_IEI_CATEGORY); @@ -656,8 +681,10 @@ for (i = 0; i < num_of_pages; i++) { const uint8_t *ie = TLVP_VAL(&tp[i], CBSP_IEI_MSG_CONTENT); struct osmo_cbsp_content *page; - if (!ie) + if (!ie) { + osmo_cbsp_errstr = "insufficient message content IEs"; return -EINVAL; + } page = talloc_zero(ctx, struct osmo_cbsp_content); OSMO_ASSERT(page); page->user_len = *(ie-1); /* length byte before payload */ @@ -668,8 +695,10 @@ if (!TLVP_PRES_LEN(tp, CBSP_IEI_EMERG_IND, 1) || !TLVP_PRES_LEN(tp, CBSP_IEI_WARN_TYPE, 2) || !TLVP_PRES_LEN(tp, CBSP_IEI_WARN_SEC_INFO, 50) || - !TLVP_PRES_LEN(tp, CBSP_IEI_WARNING_PERIOD, 1)) + !TLVP_PRES_LEN(tp, CBSP_IEI_WARNING_PERIOD, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } out->u.emergency.indicator = *TLVP_VAL(tp, CBSP_IEI_EMERG_IND); out->u.emergency.warning_type = tlvp_val16be(tp, CBSP_IEI_WARN_TYPE); memcpy(&out->u.emergency.warning_sec_info, TLVP_VAL(tp, CBSP_IEI_WARN_SEC_INFO), @@ -684,8 +713,10 @@ const struct tlv_parsed *tp, struct msgb *in, void *ctx) { if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || - !TLVP_PRES_LEN(tp, CBSP_IEI_NEW_SERIAL_NR, 2)) + !TLVP_PRES_LEN(tp, CBSP_IEI_NEW_SERIAL_NR, 2)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); out->new_serial_nr = tlvp_val16be(tp, CBSP_IEI_NEW_SERIAL_NR); @@ -718,8 +749,10 @@ { if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || !TLVP_PRES_LEN(tp, CBSP_IEI_NEW_SERIAL_NR, 2) || - !TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5)) + !TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); out->new_serial_nr = tlvp_val16be(tp, CBSP_IEI_NEW_SERIAL_NR); @@ -759,8 +792,11 @@ { if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || !TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2) || - !TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) + !TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } + out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); @@ -781,8 +817,10 @@ { if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || !TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2) || - !TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) + !TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); @@ -811,8 +849,10 @@ { if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || !TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2) || - !TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5)) + !TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); @@ -847,8 +887,10 @@ struct msgb *in, void *ctx) { if (!TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1) || - !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) + !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } INIT_LLIST_HEAD(&out->cell_list.list); cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), @@ -863,8 +905,10 @@ const struct tlv_parsed *tp, struct msgb *in, void *ctx) { if (!TLVP_PRES_LEN(tp, CBSP_IEI_RR_LOADING_LIST, 6) || - !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) + !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } INIT_LLIST_HEAD(&out->loading_list.list); cbsp_decode_loading_list(&out->loading_list, ctx, @@ -880,8 +924,10 @@ const struct tlv_parsed *tp, struct msgb *in, void *ctx) { if (!TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5) || - !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) + !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } INIT_LLIST_HEAD(&out->fail_list); cbsp_decode_fail_list(&out->fail_list, ctx, @@ -906,8 +952,11 @@ if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || !TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2) || !TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1) || - !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) + !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } + out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); @@ -926,8 +975,10 @@ if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || !TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2) || !TLVP_PRES_LEN(tp, CBSP_IEI_NUM_BCAST_COMPL_LIST, 7) || - !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) + !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); @@ -947,8 +998,10 @@ if (!TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2) || !TLVP_PRES_LEN(tp, CBSP_IEI_OLD_SERIAL_NR, 2) || !TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5) || - !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) + !TLVP_PRES_LEN(tp, CBSP_IEI_CHANNEL_IND, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } out->msg_id = tlvp_val16be(tp, CBSP_IEI_MSG_ID); out->old_serial_nr = tlvp_val16be(tp, CBSP_IEI_OLD_SERIAL_NR); @@ -973,8 +1026,10 @@ static int cbsp_dec_reset(struct osmo_cbsp_reset *out, const struct tlv_parsed *tp, struct msgb *in, void *ctx) { - if (!TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) + if (!TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } INIT_LLIST_HEAD(&out->cell_list.list); cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), @@ -986,8 +1041,10 @@ static int cbsp_dec_reset_compl(struct osmo_cbsp_reset_complete *out, const struct tlv_parsed *tp, struct msgb *in, void *ctx) { - if (!TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) + if (!TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } INIT_LLIST_HEAD(&out->cell_list.list); cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), @@ -999,8 +1056,10 @@ static int cbsp_dec_reset_fail(struct osmo_cbsp_reset_failure *out, const struct tlv_parsed *tp, struct msgb *in, void *ctx) { - if (!TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5)) + if (!TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } INIT_LLIST_HEAD(&out->fail_list); cbsp_decode_fail_list(&out->fail_list, ctx, @@ -1019,8 +1078,10 @@ static int cbsp_dec_keep_alive(struct osmo_cbsp_keep_alive *out, const struct tlv_parsed *tp, struct msgb *in, void *ctx) { - if (!TLVP_PRES_LEN(tp, CBSP_IEI_KEEP_ALIVE_REP_PERIOD, 1)) + if (!TLVP_PRES_LEN(tp, CBSP_IEI_KEEP_ALIVE_REP_PERIOD, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } out->repetition_period = *TLVP_VAL(tp, CBSP_IEI_KEEP_ALIVE_REP_PERIOD); return 0; @@ -1039,8 +1100,10 @@ { if (!TLVP_PRES_LEN(tp, CBSP_IEI_CELL_LIST, 1) || !TLVP_PRES_LEN(tp, CBSP_IEI_BCAST_MSG_TYPE, 1) || - !TLVP_PRES_LEN(tp, CBSP_IEI_RECOVERY_IND, 1)) + !TLVP_PRES_LEN(tp, CBSP_IEI_RECOVERY_IND, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } INIT_LLIST_HEAD(&out->cell_list.list); cbsp_decode_cell_list(&out->cell_list, ctx, TLVP_VAL(tp, CBSP_IEI_CELL_LIST), @@ -1056,8 +1119,10 @@ struct msgb *in, void *ctx) { if (!TLVP_PRES_LEN(tp, CBSP_IEI_FAILURE_LIST, 5) || - !TLVP_PRES_LEN(tp, CBSP_IEI_BCAST_MSG_TYPE, 1)) + !TLVP_PRES_LEN(tp, CBSP_IEI_BCAST_MSG_TYPE, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } INIT_LLIST_HEAD(&out->fail_list); cbsp_decode_fail_list(&out->fail_list, ctx, @@ -1072,8 +1137,10 @@ static int cbsp_dec_error_ind(struct osmo_cbsp_error_ind *out, const struct tlv_parsed *tp, struct msgb *in, void *ctx) { - if (!TLVP_PRES_LEN(tp, CBSP_IEI_CAUSE, 1)) + if (!TLVP_PRES_LEN(tp, CBSP_IEI_CAUSE, 1)) { + osmo_cbsp_errstr = "missing/short mandatory IE"; return -EINVAL; + } out->cause = *TLVP_VAL(tp, CBSP_IEI_CAUSE); if (TLVP_PRES_LEN(tp, CBSP_IEI_MSG_ID, 2)) { @@ -1107,6 +1174,8 @@ unsigned int len; int rc; + osmo_cbsp_errstr = NULL; + if (!out) return NULL; @@ -1194,9 +1263,11 @@ case CBSP_MSGT_SET_DRX: case CBSP_MSGT_SET_DRX_COMPL: case CBSP_MSGT_SET_DRX_FAIL: + osmo_cbsp_errstr = "message type not implemented"; rc = -1; break; default: + osmo_cbsp_errstr = "message type not known in spec"; rc = -1; break; } diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map index eefcf61..ea1f759 100644 --- a/src/gsm/libosmogsm.map +++ b/src/gsm/libosmogsm.map @@ -656,6 +656,7 @@ osmo_cbsp_encode; osmo_cbsp_decode; osmo_cbsp_recv_buffered; +osmo_cbsp_errstr; local: *; }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id9a5a595a76ba278647aee9470ded213d8464103 Gerrit-Change-Number: 14478 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:28:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:28:05 +0000 Subject: Change in ...libosmocore[master]: Add Cell Broadcast related definitions from 3GPP TS 23.041 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14471 ) Change subject: Add Cell Broadcast related definitions from 3GPP TS 23.041 ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1e2c62cb9047648907c91b99f764f6caba8f4493 Gerrit-Change-Number: 14471 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Sat, 20 Jul 2019 10:28:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 10:28:07 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sat, 20 Jul 2019 10:28:07 +0000 Subject: Change in ...libosmocore[master]: Add Cell Broadcast related definitions from 3GPP TS 23.041 In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14471 ) Change subject: Add Cell Broadcast related definitions from 3GPP TS 23.041 ...................................................................... Add Cell Broadcast related definitions from 3GPP TS 23.041 Change-Id: I1e2c62cb9047648907c91b99f764f6caba8f4493 --- M include/Makefile.am A include/osmocom/gsm/protocol/gsm_23_041.h 2 files changed, 90 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/include/Makefile.am b/include/Makefile.am index 7835fab..a82d6ac 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -123,6 +123,7 @@ osmocom/gsm/protocol/gsm_09_02.h \ osmocom/gsm/protocol/gsm_12_21.h \ osmocom/gsm/protocol/gsm_23_003.h \ + osmocom/gsm/protocol/gsm_23_041.h \ osmocom/gsm/protocol/gsm_29_118.h \ osmocom/gsm/protocol/gsm_44_318.h \ osmocom/gsm/protocol/gsm_48_049.h \ diff --git a/include/osmocom/gsm/protocol/gsm_23_041.h b/include/osmocom/gsm/protocol/gsm_23_041.h new file mode 100644 index 0000000..c75c088 --- /dev/null +++ b/include/osmocom/gsm/protocol/gsm_23_041.h @@ -0,0 +1,89 @@ +#pragma once + +/* Section 9.4.1.2: GSM Message Format */ +struct gsm23041_msg_param_gsm { + uint16_t serial_nr; + uint16_t message_id; + uint8_t dcs; + struct { +#if OSMO_IS_LITTLE_ENDIAN + uint8_t num_pages:4, + page_nr:4; +#else + uint8_t page_nr:4, + num_pages:4; +#endif + } page_param; + uint8_t content[0]; +} __attribute__ ((packed)); + +/* Section 9.4.1.2.2 Message Identifier */ +enum { + /* 0 - 999: Allocated by GSM AD.26 */ + CBS_MSGID_LCS_EOTD_ASSIST = 1000, + CBS_MSGID_LCS_DGPS_CORRECTION = 1001, + CBS_MSGID_LCS_GPS_EPHEM_CLOCK = 1002, + CBS_MSGID_LCS_GPS_ALMANAC_OTHER = 1003, + /* 1004 - 4095: RFU */ + /* 4096 - 4223: clear text SIM data download */ + /* 4224 - 4351: secured SIM data download */ + CBS_MSGID_ETWS_EARTHQUAKE = 4352, + CBS_MSGID_ETWS_TSUNAMI = 4353, + CBS_MSGID_ETWS_EARTHQUAKE_TSUNAMI = 4354, + CBS_MSGID_ETWS_TEST = 4355, + CBS_MSGID_ETWS_OTHER = 4356, + /* 4357 - 4359: ETWS RFU */ + /* 4360 - 4369: RFU */ + CBS_MSGID_CMAS_PRESIDENTIAL = 4370, + CBS_MSGID_CMAS_EXTREME_IMMEDIATE_OBSERVED = 4371, + CBS_MSGID_CMAS_EXTREME_IMMEDIATE_LIKELY = 4372, + CBS_MSGID_CMAS_EXTREME_EXPECTED_OBSERVED = 4373, + CBS_MSGID_CMAS_EXTREME_EXPECTED_LIKELY = 4374, + CBS_MSGID_CMAS_SEVERE_IMMEDIATE_OBSERVED = 4375, + CBS_MSGID_CMAS_SEVERE_IMMEDIATE_LIKELY = 4376, + CBS_MSGID_CMAS_SEVERE_EXPECTED_OBSERVED = 4377, + CBS_MSGID_CMAS_SEVERE_EXPECTED_LIKELY = 4378, + CBS_MSGID_CMAS_AMBER = 4379, + CBS_MSGID_CMAS_MONTHLY_TEST = 4380, + CBS_MSGID_CMAS_EXERCISE = 4381, + CBS_MSGID_CMAS_OPERATOR_DEFINED = 4382, + CBS_MSGID_CMAS_PRESIDENTIAL_ADDL = 4383, + CBS_MSGID_CMAS_EXTREME_IMMEDIATE_OBSERVED_ADDL = 4384, + CBS_MSGID_CMAS_EXTREME_IMMEDIATE_LIKELY_ADDL = 4385, + CBS_MSGID_CMAS_EXTREME_EXPECTED_OBSERVED_ADDL = 4386, + CBS_MSGID_CMAS_EXTREME_EXPECTED_LIKELY_ADDL = 4387, + CBS_MSGID_CMAS_SEVERE_IMMEDIATE_OBSERVED_ADDL = 4388, + CBS_MSGID_CMAS_SEVERE_IMMEDIATE_LIKELY_ADDL = 4389, + CBS_MSGID_CMAS_SEVERE_EXPECTED_OBSERVED_ADDL = 4390, + CBS_MSGID_CMAS_SEVERE_EXPECTED_LIKELY_ADDL = 4391, + CBS_MSGID_CMAS_AMBER_ADDL = 4392, + CBS_MSGID_CMAS_MONTHLY_TEST_ADDL = 4393, + CBS_MSGID_CMAS_EXERCISE_ADDL = 4394, + CBS_MSGID_CMAS_OPERATOR_DEFINED_ADDL = 4395, + /* 4396 - 4399: RFU CMAS / EU-Alert */ + /* 4400 - 6399: RFU PWS */ + CBS_MSGID_EU_INFO_LOCAL_LANG = 6400, + /* 6491 - 40959: RFU */ + /* 40960 - 45055: PLMN operator specific range */ + /* 45056 - 61439: PLMN operator specific range RFU */ + /* 61440 - 65534: PLMN operator specific range */ + CBS_MSGID_RESERVED = 65535 +}; + +/* Section 9.4.1.3.2 ETWS Primary Notification Message Parameter */ +struct gsm23041_etws_primary_gsm { + uint16_t serial_nr; + uint16_t message_id; + uint16_t warning_type; + uint8_t warning_sec_info[50]; +} __attribute__ ((packed)); + + +/* Section 9.4.2.2 UMTS Message Parameter */ +struct gsm23041_msg_param_umts { + uint8_t msg_type; /* as per TS 25.324 */ + uint16_t message_id; + uint16_t serial_nr; + uint8_t dcs; + uint8_t content[0]; +} __attribute__ ((packed)); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1e2c62cb9047648907c91b99f764f6caba8f4493 Gerrit-Change-Number: 14471 Gerrit-PatchSet: 5 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 12:39:38 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 20 Jul 2019 12:39:38 +0000 Subject: Change in ...osmo-trx[master]: trxd_fill_common(): fix TRXD header version coding In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14845 to look at the new patch set (#2). Change subject: trxd_fill_common(): fix TRXD header version coding ...................................................................... trxd_fill_common(): fix TRXD header version coding The header version field is 4 bit long, so the mask 0x07 == 0b111 is wrong, it should actually be 0x0f == 0b1111. Change-Id: I290931559ce01cf6e43470b18855c46808d6c2a5 --- M Transceiver52M/proto_trxd.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/45/14845/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14845 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I290931559ce01cf6e43470b18855c46808d6c2a5 Gerrit-Change-Number: 14845 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 16:23:10 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sat, 20 Jul 2019 16:23:10 +0000 Subject: Change in ...osmo-trx[master]: trxd_fill_common(): fix TRXD header version coding In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14845 ) Change subject: trxd_fill_common(): fix TRXD header version coding ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14845 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I290931559ce01cf6e43470b18855c46808d6c2a5 Gerrit-Change-Number: 14845 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sat, 20 Jul 2019 16:23:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 20 16:24:37 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 20 Jul 2019 16:24:37 +0000 Subject: Change in ...osmo-trx[master]: trxd_fill_common(): fix TRXD header version coding In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14845 ) Change subject: trxd_fill_common(): fix TRXD header version coding ...................................................................... trxd_fill_common(): fix TRXD header version coding The header version field is 4 bit long, so the mask 0x07 == 0b111 is wrong, it should actually be 0x0f == 0b1111. Change-Id: I290931559ce01cf6e43470b18855c46808d6c2a5 --- M Transceiver52M/proto_trxd.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/proto_trxd.c b/Transceiver52M/proto_trxd.c index cd82d55..fbef77a 100644 --- a/Transceiver52M/proto_trxd.c +++ b/Transceiver52M/proto_trxd.c @@ -27,7 +27,7 @@ static void trxd_fill_common(struct trxd_hdr_common *common, const struct trx_ul_burst_ind *bi, uint8_t version) { - common->version = version & 0x07; + common->version = version & 0b1111; common->reserved = 0; common->tn = bi->tn; osmo_store32be(bi->fn, &common->fn); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14845 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I290931559ce01cf6e43470b18855c46808d6c2a5 Gerrit-Change-Number: 14845 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Sat Jul 20 19:51:16 2019 From: admin at opensuse.org (OBS Notification) Date: Sat, 20 Jul 2019 19:51:16 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d3370ca6faf_d3a6545f04377c2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 369s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 369s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 369s] collect2: error: ld returned 1 exit status [ 369s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 369s] make[4]: *** [osmo-bts-virtual] Error 1 [ 369s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 369s] Makefile:385: recipe for target 'all-recursive' failed [ 369s] make[3]: *** [all-recursive] Error 1 [ 369s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 369s] Makefile:434: recipe for target 'all-recursive' failed [ 369s] make[2]: *** [all-recursive] Error 1 [ 369s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 369s] Makefile:366: recipe for target 'all' failed [ 369s] make[1]: *** [all] Error 2 [ 369s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 369s] dh_auto_build: make -j1 returned exit code 2 [ 369s] debian/rules:12: recipe for target 'build' failed [ 369s] make: *** [build] Error 2 [ 369s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 369s] [ 369s] armbuild01 failed "build osmo-bts_0.8.1.347.37ea1.dsc" at Sat Jul 20 19:51:01 UTC 2019. [ 369s] [ 369s] ### VM INTERACTION START ### [ 372s] [ 341.596412] sysrq: SysRq : Power Off [ 372s] [ 341.613366] reboot: Power down [ 372s] ### VM INTERACTION END ### [ 372s] [ 372s] armbuild01 failed "build osmo-bts_0.8.1.347.37ea1.dsc" at Sat Jul 20 19:51:04 UTC 2019. [ 372s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 21 00:01:33 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 21 Jul 2019 00:01:33 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d33ab6472a4f_d3a6545f04410e5@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 1963s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 1963s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 1963s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 1963s] Makefile:442: recipe for target 'vlr.o' failed [ 1963s] make[4]: *** [vlr.o] Error 1 [ 1963s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 1963s] Makefile:422: recipe for target 'all-recursive' failed [ 1963s] make[3]: *** [all-recursive] Error 1 [ 1963s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 1963s] Makefile:462: recipe for target 'all-recursive' failed [ 1963s] make[2]: *** [all-recursive] Error 1 [ 1963s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 1963s] Makefile:394: recipe for target 'all' failed [ 1963s] make[1]: *** [all] Error 2 [ 1963s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1963s] dh_auto_build: make -j1 returned exit code 2 [ 1963s] debian/rules:45: recipe for target 'build' failed [ 1963s] make: *** [build] Error 2 [ 1963s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 1963s] [ 1963s] obs-arm-6 failed "build osmo-msc_1.3.1.180.efa7.dsc" at Sun Jul 21 00:01:25 UTC 2019. [ 1963s] [ 1963s] ### VM INTERACTION START ### [ 1966s] [ 1912.511903] sysrq: SysRq : Power Off [ 1966s] [ 1912.526556] reboot: Power down [ 1970s] ### VM INTERACTION END ### [ 1970s] [ 1970s] obs-arm-6 failed "build osmo-msc_1.3.1.180.efa7.dsc" at Sun Jul 21 00:01:32 UTC 2019. [ 1970s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 21 00:16:25 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 21 Jul 2019 00:16:25 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d33aee69a833_d3a6545f044126f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 760s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 760s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 760s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 760s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 760s] make[4]: *** [gb_proxy.o] Error 1 [ 760s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 760s] Makefile:391: recipe for target 'all-recursive' failed [ 760s] make[3]: *** [all-recursive] Error 1 [ 760s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 760s] Makefile:453: recipe for target 'all-recursive' failed [ 760s] make[2]: *** [all-recursive] Error 1 [ 760s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 760s] Makefile:385: recipe for target 'all' failed [ 760s] make[1]: *** [all] Error 2 [ 760s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 760s] dh_auto_build: make -j1 returned exit code 2 [ 760s] debian/rules:45: recipe for target 'build' failed [ 760s] make: *** [build] Error 2 [ 760s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 760s] [ 761s] obs-arm-5 failed "build osmo-sgsn_1.4.0.30.4b8e.dsc" at Sun Jul 21 00:16:11 UTC 2019. [ 761s] [ 761s] ### VM INTERACTION START ### [ 764s] [ 726.354364] sysrq: SysRq : Power Off [ 764s] [ 726.421765] reboot: Power down [ 767s] ### VM INTERACTION END ### [ 767s] [ 767s] obs-arm-5 failed "build osmo-sgsn_1.4.0.30.4b8e.dsc" at Sun Jul 21 00:16:18 UTC 2019. [ 767s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 21 02:57:16 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 21 Jul 2019 02:57:16 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d33d4a62e1f7_d3a6545f044318f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 1121s] -Returned: 0, Current node: 1 '%s> ' [ 1121s] -Going to execute 'ambiguous_str' [ 1121s] -Called: 'ambiguous_str [ARG]' (argc=0) [ 1121s] -Returned: 0, Current node: 1 '%s> ' [ 1121s] -Going to execute 'ambiguous_str arg' [ 1121s] -Called: 'ambiguous_str [ARG]' (argc=1) [ 1121s] -Returned: 0, Current node: 1 '%s> ' [ 1121s] -Going to execute 'ambiguous_str arg keyword' [ 1121s] -Called: 'ambiguous_str ARG keyword' [ 1121s] -Returned: 0, Current node: 1 '%s> ' [ 1121s] -All tests passed [ 1121s] ./testsuite.at:196: exit code was 139, expected 0 [ 1121s] 31. testsuite.at:192: 31. vty (testsuite.at:192): FAILED (testsuite.at:196) [ 1121s] debian/rules:26: recipe for target 'override_dh_auto_test' failed [ 1121s] make[1]: *** [override_dh_auto_test] Error 1 [ 1121s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 1121s] debian/rules:15: recipe for target 'build' failed [ 1121s] make: *** [build] Error 2 [ 1121s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 1121s] [ 1121s] obs-arm-6 failed "build libosmocore_1.1.0.85.3f27f.dsc" at Sun Jul 21 02:57:07 UTC 2019. [ 1121s] [ 1121s] ### VM INTERACTION START ### [ 1124s] [ 1066.166885] sysrq: SysRq : Power Off [ 1124s] [ 1066.172283] reboot: Power down [ 1125s] ### VM INTERACTION END ### [ 1125s] [ 1125s] obs-arm-6 failed "build libosmocore_1.1.0.85.3f27f.dsc" at Sun Jul 21 02:57:12 UTC 2019. [ 1125s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Sun Jul 21 06:00:07 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 06:00:07 +0000 Subject: Change in ...libosmocore[master]: cbsp.c: Remove dead code Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14847 Change subject: cbsp.c: Remove dead code ...................................................................... cbsp.c: Remove dead code Change-Id: I0888fbad0f9094ec1b31e2cceecfc9cd372399bd Closes: CID#202057 --- M src/gsm/cbsp.c 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/14847/1 diff --git a/src/gsm/cbsp.c b/src/gsm/cbsp.c index 23f68de..84b9235 100644 --- a/src/gsm/cbsp.c +++ b/src/gsm/cbsp.c @@ -1391,10 +1391,8 @@ if (!msg) { msg = osmo_cbsp_msgb_alloc(ctx, __func__); - if (!msg) { + if (!msg) return -ENOMEM; - goto discard_msg; - } msg->l1h = msg->tail; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14847 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0888fbad0f9094ec1b31e2cceecfc9cd372399bd Gerrit-Change-Number: 14847 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 06:10:02 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 06:10:02 +0000 Subject: Change in ...osmocom-bb[master]: virtphy: Fix array out of bounds access in getL1ctlPrimName() Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14848 Change subject: virtphy: Fix array out of bounds access in getL1ctlPrimName() ...................................................................... virtphy: Fix array out of bounds access in getL1ctlPrimName() Closes: CID#198573 Change-Id: I6504a7ffcf961d3162e6ab2ec8f5f2016ef12cde --- M src/host/virt_phy/src/logging.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/48/14848/1 diff --git a/src/host/virt_phy/src/logging.c b/src/host/virt_phy/src/logging.c index a3e63bc..7e4e79b 100644 --- a/src/host/virt_phy/src/logging.c +++ b/src/host/virt_phy/src/logging.c @@ -128,7 +128,7 @@ const char *getL1ctlPrimName(uint8_t type) { - if (type <= ARRAY_SIZE(l1ctlPrimNames)) + if (type < ARRAY_SIZE(l1ctlPrimNames)) return l1ctlPrimNames[type]; else return "Unknwon Primitive"; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6504a7ffcf961d3162e6ab2ec8f5f2016ef12cde Gerrit-Change-Number: 14848 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 06:10:04 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 06:10:04 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Fix out-of-bounds for partial reads in un_tool_read() Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14849 Change subject: osmocon: Fix out-of-bounds for partial reads in un_tool_read() ...................................................................... osmocon: Fix out-of-bounds for partial reads in un_tool_read() "uint8_t buf[4096]; ... &buf + 1" renders an offset of 4096, and not 1! Change-Id: Ie1407371fe949c3d5746b9fdc32ececc9443692b Closes: CID#198580 --- M src/host/osmocon/osmocon.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/49/14849/1 diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c index 26416f7..9090d27 100644 --- a/src/host/osmocon/osmocon.c +++ b/src/host/osmocon/osmocon.c @@ -1242,7 +1242,7 @@ c = 0; while(c < 2) { - rc = read(fd->fd, &buf + c, 2 - c); + rc = read(fd->fd, buf + c, 2 - c); if(rc == 0) { // disconnect goto close; @@ -1262,7 +1262,7 @@ c = 0; while(c < length) { - rc = read(fd->fd, &buf + c, length - c); + rc = read(fd->fd, buf + c, length - c); if(rc == 0) { // disconnect goto close; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie1407371fe949c3d5746b9fdc32ececc9443692b Gerrit-Change-Number: 14849 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 07:22:15 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 07:22:15 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Fix fd leak in error path of read_file() Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14850 Change subject: osmocon: Fix fd leak in error path of read_file() ...................................................................... osmocon: Fix fd leak in error path of read_file() Change-Id: Iaae407658df184277f6e6e07d6a48d8b5c75587b Closes: CID#198552 --- M src/host/osmocon/osmocon.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/50/14850/1 diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c index 9090d27..9237214 100644 --- a/src/host/osmocon/osmocon.c +++ b/src/host/osmocon/osmocon.c @@ -290,6 +290,7 @@ if ((st.st_size > MAX_DNLOAD_SIZE) && (dnload.mode != MODE_ROMLOAD)) { fprintf(stderr, "The maximum file size is 64kBytes (%u bytes)\n", MAX_DNLOAD_SIZE); + close(fd); return -EFBIG; } } else { -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaae407658df184277f6e6e07d6a48d8b5c75587b Gerrit-Change-Number: 14850 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 07:22:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 07:22:16 +0000 Subject: Change in ...osmocom-bb[master]: gsm322: Fix resource leak in gsm322_init() while reading BA Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14851 Change subject: gsm322: Fix resource leak in gsm322_init() while reading BA ...................................................................... gsm322: Fix resource leak in gsm322_init() while reading BA Change-Id: Id42102ab8581e247f495fb7e05dc62a6743d28c5 Closes: CID#198546 --- M src/host/layer23/src/mobile/gsm322.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/51/14851/1 diff --git a/src/host/layer23/src/mobile/gsm322.c b/src/host/layer23/src/mobile/gsm322.c index cfd70d8..56dd236 100644 --- a/src/host/layer23/src/mobile/gsm322.c +++ b/src/host/layer23/src/mobile/gsm322.c @@ -5085,8 +5085,10 @@ } else while(!feof(fp)) { ba = talloc_zero(ms, struct gsm322_ba_list); - if (!ba) + if (!ba) { + fclose(fp); return -ENOMEM; + } rc = fread(buf, 4, 1, fp); if (!rc) { talloc_free(ba); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14851 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id42102ab8581e247f495fb7e05dc62a6743d28c5 Gerrit-Change-Number: 14851 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 07:22:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 07:22:16 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Fix file descriptor + mem leak in error path Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14852 Change subject: osmocon: Fix file descriptor + mem leak in error path ...................................................................... osmocon: Fix file descriptor + mem leak in error path Change-Id: I42ceed662889084783dc89f4ca39c3852428d108 Closes: CID#198539 --- M src/host/osmocon/osmocon.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/52/14852/1 diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c index 9237214..1bb0bb7 100644 --- a/src/host/osmocon/osmocon.c +++ b/src/host/osmocon/osmocon.c @@ -1309,6 +1309,7 @@ con = talloc_zero(NULL, struct tool_connection); if (!con) { fprintf(stderr, "Failed to create tool connection.\n"); + close(rc); return -1; } @@ -1320,6 +1321,8 @@ con->fd.data = con; if (osmo_fd_register(&con->fd) != 0) { fprintf(stderr, "Failed to register the fd.\n"); + talloc_free(con); + close(rc); return -1; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14852 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I42ceed662889084783dc89f4ca39c3852428d108 Gerrit-Change-Number: 14852 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 07:22:17 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 07:22:17 +0000 Subject: Change in ...osmocom-bb[master]: mobile: Fix encoding of cause in gsm480_tx_release_compl() Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14853 Change subject: mobile: Fix encoding of cause in gsm480_tx_release_compl() ...................................................................... mobile: Fix encoding of cause in gsm480_tx_release_compl() Change-Id: Iba2ace7d82be5677d28b25f60ab0312fed76f5e5 Closes: CID#198577, CID#198576, CID#198575 --- M src/host/layer23/src/mobile/gsm480_ss.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/53/14853/1 diff --git a/src/host/layer23/src/mobile/gsm480_ss.c b/src/host/layer23/src/mobile/gsm480_ss.c index edc9c97..b114aa6 100644 --- a/src/host/layer23/src/mobile/gsm480_ss.c +++ b/src/host/layer23/src/mobile/gsm480_ss.c @@ -399,10 +399,10 @@ if (cause) { uint8_t *tlv = msgb_put(msg, 4); - *tlv = GSM48_IE_CAUSE; - *tlv = 2; - *tlv = 0x80 | cause; - *tlv = 0x80 | GSM48_CAUSE_LOC_USER; + tlv[0] = GSM48_IE_CAUSE; + tlv[1] = 2; + tlv[2] = 0x80 | cause; + tlv[3] = 0x80 | GSM48_CAUSE_LOC_USER; } return gsm480_to_mm(msg, trans, GSM48_MMSS_DATA_REQ); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14853 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba2ace7d82be5677d28b25f60ab0312fed76f5e5 Gerrit-Change-Number: 14853 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 07:22:17 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 07:22:17 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Add missing check for fstat() return value Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14854 Change subject: osmocon: Add missing check for fstat() return value ...................................................................... osmocon: Add missing check for fstat() return value Change-Id: Ibef6ee00eb41e16d2ef52931f8c22562090cd1ee Closes: CID#198570 --- M src/host/osmocon/osmocon.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/54/14854/1 diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c index 1bb0bb7..61672a3 100644 --- a/src/host/osmocon/osmocon.c +++ b/src/host/osmocon/osmocon.c @@ -287,6 +287,11 @@ } rc = fstat(fd, &st); + if (rc < 0) { + perror("fstat"); + close(fd); + return -EIO; + } if ((st.st_size > MAX_DNLOAD_SIZE) && (dnload.mode != MODE_ROMLOAD)) { fprintf(stderr, "The maximum file size is 64kBytes (%u bytes)\n", MAX_DNLOAD_SIZE); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14854 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibef6ee00eb41e16d2ef52931f8c22562090cd1ee Gerrit-Change-Number: 14854 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 07:22:17 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 07:22:17 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Check write() return code Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14855 Change subject: osmocon: Check write() return code ...................................................................... osmocon: Check write() return code Change-Id: I61d8f104a4d2558fd5b6fb34c7f2fd6c13354c12 Closes: CID#198567 --- M src/host/osmocon/osmocon.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/55/14855/1 diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c index 61672a3..f4d9111 100644 --- a/src/host/osmocon/osmocon.c +++ b/src/host/osmocon/osmocon.c @@ -630,6 +630,7 @@ case MODE_C140xor: case MODE_C123xor: rc = write(dnload.serial_fd.fd, &xor_init, 1); + OSMO_ASSERT(rc == 1); break; default: break; @@ -652,6 +653,7 @@ perror("Error during write"); return rc; } + OSMO_ASSERT(rc == write_len); dnload.write_ptr += rc; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14855 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I61d8f104a4d2558fd5b6fb34c7f2fd6c13354c12 Gerrit-Change-Number: 14855 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 07:22:18 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 07:22:18 +0000 Subject: Change in ...osmocom-bb[master]: virtphy: Handle strtok() returning NULL on first call Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14856 Change subject: virtphy: Handle strtok() returning NULL on first call ...................................................................... virtphy: Handle strtok() returning NULL on first call Change-Id: I37bfb91cf75982bfa2f75bd62d0c13859268cd93 Closes: CID#198565 --- M src/host/virt_phy/src/virtphy.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/56/14856/1 diff --git a/src/host/virt_phy/src/virtphy.c b/src/host/virt_phy/src/virtphy.c index 118e8a1..d0a2ddb 100644 --- a/src/host/virt_phy/src/virtphy.c +++ b/src/host/virt_phy/src/virtphy.c @@ -153,6 +153,8 @@ return; char *token = strtok(arfcn_sig_lev_red_mask, ":"); + if (!token) + return; do { char* colon = strstr(token, ","); uint16_t arfcn; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14856 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I37bfb91cf75982bfa2f75bd62d0c13859268cd93 Gerrit-Change-Number: 14856 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 07:25:41 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 07:25:41 +0000 Subject: Change in ...libosmocore[master]: tdef: remove bogus OSMO_ASSERT(unsigned long >= 0) Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14857 Change subject: tdef: remove bogus OSMO_ASSERT(unsigned long >= 0) ...................................................................... tdef: remove bogus OSMO_ASSERT(unsigned long >= 0) Change-Id: I7a544d2d43b83135def296674f777e48fe5fd80a Closes: CID#190866 --- M src/tdef.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/57/14857/1 diff --git a/src/tdef.c b/src/tdef.c index 9d5d736..3cfb17c 100644 --- a/src/tdef.c +++ b/src/tdef.c @@ -187,7 +187,6 @@ { const struct osmo_tdef *t = osmo_tdef_get_entry((struct osmo_tdef*)tdefs, T); if (!t) { - OSMO_ASSERT(val_if_not_present >= 0); return val_if_not_present; } return osmo_tdef_round(t->val, t->unit, as_unit); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14857 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7a544d2d43b83135def296674f777e48fe5fd80a Gerrit-Change-Number: 14857 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 07:27:19 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 07:27:19 +0000 Subject: Change in ...osmo-pcu[master]: bssgp: Fix dead code: PDUT_STATUS can never reach this part Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14858 Change subject: bssgp: Fix dead code: PDUT_STATUS can never reach this part ...................................................................... bssgp: Fix dead code: PDUT_STATUS can never reach this part Change-Id: Iae4332cd3b87f37164655d3df16554de4876159d Closes: CID#188855 --- M src/gprs_bssgp_pcu.cpp 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/58/14858/1 diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index a4a5875..b34659b 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -369,9 +369,7 @@ if (rc < 0) { LOGP(DBSSGP, LOGL_ERROR, "Failed to parse BSSGP %s message. Invalid message was: %s\n", bssgp_pdu_str(pdu_type), msgb_hexdump(msg)); - if (pdu_type != BSSGP_PDUT_STATUS) - return bssgp_tx_status(BSSGP_CAUSE_INV_MAND_INF, NULL, msg); - return rc; + return bssgp_tx_status(BSSGP_CAUSE_INV_MAND_INF, NULL, msg); } if (pdu_type == BSSGP_PDUT_BVC_RESET) { -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14858 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iae4332cd3b87f37164655d3df16554de4876159d Gerrit-Change-Number: 14858 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 07:28:46 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 07:28:46 +0000 Subject: Change in ...osmo-mgw[master]: mgcp_sdp: Don't check if an unsigned int is below 0 Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14859 Change subject: mgcp_sdp: Don't check if an unsigned int is below 0 ...................................................................... mgcp_sdp: Don't check if an unsigned int is below 0 Change-Id: I129f5c6175a8e961bc08b9768bdf22a2232e2fcb Closes: CID#188849 --- M src/libosmo-mgcp/mgcp_sdp.c 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/59/14859/1 diff --git a/src/libosmo-mgcp/mgcp_sdp.c b/src/libosmo-mgcp/mgcp_sdp.c index 99e764b..ddd4657 100644 --- a/src/libosmo-mgcp/mgcp_sdp.c +++ b/src/libosmo-mgcp/mgcp_sdp.c @@ -417,9 +417,6 @@ int rc; unsigned int i; - if (payload_types_len < 0) - return -EINVAL; - rc = msgb_printf(sdp, "m=audio %d RTP/AVP", local_port); if (rc < 0) return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14859 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I129f5c6175a8e961bc08b9768bdf22a2232e2fcb Gerrit-Change-Number: 14859 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 08:27:54 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 08:27:54 +0000 Subject: Change in ...osmocom-bb[master]: virtphy: Handle strtok() returning NULL on first call In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14856 ) Change subject: virtphy: Handle strtok() returning NULL on first call ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14856 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I37bfb91cf75982bfa2f75bd62d0c13859268cd93 Gerrit-Change-Number: 14856 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 08:27:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 08:29:03 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 08:29:03 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Add missing check for fstat() return value In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14854 ) Change subject: osmocon: Add missing check for fstat() return value ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14854 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibef6ee00eb41e16d2ef52931f8c22562090cd1ee Gerrit-Change-Number: 14854 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 08:29:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 08:48:46 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 08:48:46 +0000 Subject: Change in ...osmocom-bb[master]: mobile: Fix encoding of cause in gsm480_tx_release_compl() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14853 ) Change subject: mobile: Fix encoding of cause in gsm480_tx_release_compl() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/14853/1/src/host/layer23/src/mobile/gsm480_ss.c File src/host/layer23/src/mobile/gsm480_ss.c: https://gerrit.osmocom.org/#/c/14853/1/src/host/layer23/src/mobile/gsm480_ss.c at 404 PS1, Line 404: tlv[2] = 0x80 | cause; : tlv[3] = 0x80 | GSM48_CAUSE_LOC_USER; An idea for another change: cause should actually go after location. Please see section 10.5.4.11, and https://git.osmocom.org/osmo-msc/tree/src/libmsc/gsm_04_80.c#n88. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14853 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba2ace7d82be5677d28b25f60ab0312fed76f5e5 Gerrit-Change-Number: 14853 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 08:48:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 08:49:58 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 08:49:58 +0000 Subject: Change in ...osmocom-bb[master]: virtphy: Fix array out of bounds access in getL1ctlPrimName() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14848 ) Change subject: virtphy: Fix array out of bounds access in getL1ctlPrimName() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6504a7ffcf961d3162e6ab2ec8f5f2016ef12cde Gerrit-Change-Number: 14848 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 08:49:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 08:50:18 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 08:50:18 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Fix fd leak in error path of read_file() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14850 ) Change subject: osmocon: Fix fd leak in error path of read_file() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaae407658df184277f6e6e07d6a48d8b5c75587b Gerrit-Change-Number: 14850 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 08:50:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 08:50:55 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 08:50:55 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Fix file descriptor + mem leak in error path In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14852 ) Change subject: osmocon: Fix file descriptor + mem leak in error path ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14852 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I42ceed662889084783dc89f4ca39c3852428d108 Gerrit-Change-Number: 14852 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 08:50:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 08:52:02 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 08:52:02 +0000 Subject: Change in ...osmocom-bb[master]: gsm322: Fix resource leak in gsm322_init() while reading BA In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14851 ) Change subject: gsm322: Fix resource leak in gsm322_init() while reading BA ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14851 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id42102ab8581e247f495fb7e05dc62a6743d28c5 Gerrit-Change-Number: 14851 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 08:52:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 08:52:42 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 08:52:42 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Fix out-of-bounds for partial reads in un_tool_read() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14849 ) Change subject: osmocon: Fix out-of-bounds for partial reads in un_tool_read() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie1407371fe949c3d5746b9fdc32ececc9443692b Gerrit-Change-Number: 14849 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 08:52:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:03:13 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 09:03:13 +0000 Subject: Change in ...osmocom-bb[master]: mobile/gsm480_ss.c: gsm480_tx_release_compl(): fix cause IE encoding Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14860 Change subject: mobile/gsm480_ss.c: gsm480_tx_release_compl(): fix cause IE encoding ...................................................................... mobile/gsm480_ss.c: gsm480_tx_release_compl(): fix cause IE encoding According to GSM TS 04.08, section 10.5.4.11, location and coding standard are encoded before the cause value, not vice-versa! Also, coding standards other than "1 1 - Standard defined for the GSM PLMNs" shall not be used if the cause can be represented with the GSM standardized coding. Change-Id: Ic6abcfb9a9589f5b0c9c40def863f15ae04d0bdd --- M src/host/layer23/src/mobile/gsm480_ss.c 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/60/14860/1 diff --git a/src/host/layer23/src/mobile/gsm480_ss.c b/src/host/layer23/src/mobile/gsm480_ss.c index b114aa6..e462916 100644 --- a/src/host/layer23/src/mobile/gsm480_ss.c +++ b/src/host/layer23/src/mobile/gsm480_ss.c @@ -397,12 +397,17 @@ gh->proto_discr = GSM48_PDISC_NC_SS | (trans->transaction_id << 4); gh->msg_type = GSM0480_MTYPE_RELEASE_COMPLETE; + /* GSM 04.08, section 10.5.4.11 */ if (cause) { uint8_t *tlv = msgb_put(msg, 4); tlv[0] = GSM48_IE_CAUSE; tlv[1] = 2; - tlv[2] = 0x80 | cause; - tlv[3] = 0x80 | GSM48_CAUSE_LOC_USER; + + /* Coding standard defined for the GSM PLMNs, + * location - USER, cause as given by caller, + * no extension, no diagnostics. */ + cause_ie[2] = (1 << 7) | (0x03 << 5) | (GSM48_CAUSE_LOC_USER & 0x0f); + cause_ie[3] = (1 << 7) | cause; } return gsm480_to_mm(msg, trans, GSM48_MMSS_DATA_REQ); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14860 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic6abcfb9a9589f5b0c9c40def863f15ae04d0bdd Gerrit-Change-Number: 14860 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:05:33 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 09:05:33 +0000 Subject: Change in ...osmocom-bb[master]: mobile/gsm480_ss.c: gsm480_tx_release_compl(): fix cause IE encoding In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/14860 to look at the new patch set (#2). Change subject: mobile/gsm480_ss.c: gsm480_tx_release_compl(): fix cause IE encoding ...................................................................... mobile/gsm480_ss.c: gsm480_tx_release_compl(): fix cause IE encoding According to GSM TS 04.08, section 10.5.4.11, location and coding standard are encoded before the cause value, not vice-versa! Also, coding standards other than "1 1 - Standard defined for the GSM PLMNs" shall not be used if the cause can be represented with the GSM standardized coding. Change-Id: Ic6abcfb9a9589f5b0c9c40def863f15ae04d0bdd --- M src/host/layer23/src/mobile/gsm480_ss.c 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/60/14860/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14860 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic6abcfb9a9589f5b0c9c40def863f15ae04d0bdd Gerrit-Change-Number: 14860 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:08:57 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 09:08:57 +0000 Subject: Change in ...osmo-mgw[master]: mgcp_sdp: Don't check if an unsigned int is below 0 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14859 ) Change subject: mgcp_sdp: Don't check if an unsigned int is below 0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14859 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I129f5c6175a8e961bc08b9768bdf22a2232e2fcb Gerrit-Change-Number: 14859 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 09:08:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:09:15 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 09:09:15 +0000 Subject: Change in ...libosmocore[master]: tdef: remove bogus OSMO_ASSERT(unsigned long >= 0) In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14857 ) Change subject: tdef: remove bogus OSMO_ASSERT(unsigned long >= 0) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14857 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7a544d2d43b83135def296674f777e48fe5fd80a Gerrit-Change-Number: 14857 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 09:09:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:09:28 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 09:09:28 +0000 Subject: Change in ...libosmocore[master]: cbsp.c: Remove dead code In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14847 ) Change subject: cbsp.c: Remove dead code ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14847 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0888fbad0f9094ec1b31e2cceecfc9cd372399bd Gerrit-Change-Number: 14847 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 09:09:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Sun Jul 21 09:26:33 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 21 Jul 2019 09:26:33 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d342fd0a97a1_d3a6545f04942d7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 377s] ../../src/common/libbts.a(bts.o): In function `lchan_init_lapdm': [ 377s] ./src/common/bts.c:424: undefined reference to `lapdm_channel_init2' [ 377s] collect2: error: ld returned 1 exit status [ 377s] Makefile:421: recipe for target 'osmo-bts-virtual' failed [ 377s] make[4]: *** [osmo-bts-virtual] Error 1 [ 377s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/osmo-bts-virtual' [ 377s] Makefile:385: recipe for target 'all-recursive' failed [ 377s] make[3]: *** [all-recursive] Error 1 [ 377s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 377s] Makefile:434: recipe for target 'all-recursive' failed [ 377s] make[2]: *** [all-recursive] Error 1 [ 377s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 377s] Makefile:366: recipe for target 'all' failed [ 377s] make[1]: *** [all] Error 2 [ 377s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 377s] dh_auto_build: make -j1 returned exit code 2 [ 377s] debian/rules:12: recipe for target 'build' failed [ 377s] make: *** [build] Error 2 [ 377s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 377s] [ 377s] armbuild01 failed "build osmo-bts_0.8.1.347.37ea1.dsc" at Sun Jul 21 09:26:17 UTC 2019. [ 377s] [ 377s] ### VM INTERACTION START ### [ 380s] [ 347.894039] sysrq: SysRq : Power Off [ 380s] [ 347.896944] reboot: Power down [ 380s] ### VM INTERACTION END ### [ 380s] [ 380s] armbuild01 failed "build osmo-bts_0.8.1.347.37ea1.dsc" at Sun Jul 21 09:26:21 UTC 2019. [ 380s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:31:27 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 09:31:27 +0000 Subject: Change in ...libosmocore[master]: gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14861 Change subject: gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging ...................................................................... gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging Change-Id: Id38272ff93fae6d2fdf39df4ffc74856d6c9a898 --- M src/gsm/gsm0480.c 1 file changed, 14 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/14861/1 diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c index 9f546cc..cf6c30a 100644 --- a/src/gsm/gsm0480.c +++ b/src/gsm/gsm0480.c @@ -323,7 +323,7 @@ memset(&ss, 0, sizeof(ss)); if (len < sizeof(*hdr) + 2) { - LOGP(0, LOGL_DEBUG, "USSD Request is too short.\n"); + LOGP(DLGLOBAL, LOGL_ERROR, "USSD Request is too short.\n"); return 0; } @@ -345,7 +345,7 @@ } if (!rc) - LOGP(0, LOGL_DEBUG, "Error occurred while parsing received USSD!\n"); + LOGP(DLGLOBAL, LOGL_ERROR, "Error occurred while parsing received USSD!\n"); return rc; } @@ -362,7 +362,7 @@ */ pdisc = gsm48_hdr_pdisc(hdr); if (pdisc != GSM48_PDISC_NC_SS) { - LOGP(0, LOGL_ERROR, "Dropping message with " + LOGP(DLGLOBAL, LOGL_ERROR, "Dropping message with " "unsupported pdisc=%02x\n", pdisc); return 0; } @@ -385,7 +385,7 @@ */ if (msg_type != GSM0480_MTYPE_RELEASE_COMPLETE) { if (len < 2) { - LOGP(0, LOGL_DEBUG, "SS Request is too short.\n"); + LOGP(DLGLOBAL, LOGL_ERROR, "SS Request is too short.\n"); return 0; } } @@ -393,7 +393,7 @@ /* Table 2.1: Messages for call independent SS control */ switch (msg_type) { case GSM0480_MTYPE_RELEASE_COMPLETE: - LOGP(0, LOGL_DEBUG, "SS Release Complete\n"); + LOGP(DLGLOBAL, LOGL_ERROR, "SS Release Complete\n"); /** * Indicates that there is no decoded message. @@ -412,7 +412,7 @@ rc &= parse_ss_facility(&hdr->data[0], len, req); break; default: - LOGP(0, LOGL_DEBUG, "Unknown GSM 04.80 message-type field 0x%02x\n", + LOGP(DLGLOBAL, LOGL_ERROR, "Unknown GSM 04.80 message-type field 0x%02x\n", hdr->msg_type); rc = 0; break; @@ -461,7 +461,7 @@ case GSM0480_IE_SS_VERSION: break; default: - LOGP(0, LOGL_DEBUG, "Unhandled GSM 04.08 or 04.80 IEI 0x%02x\n", + LOGP(DLGLOBAL, LOGL_ERROR, "Unhandled GSM 04.08 or 04.80 IEI 0x%02x\n", iei); rc = 0; break; @@ -497,7 +497,7 @@ /* Make sure that there is no overflow */ if (offset + 2 + component_length > length) { - LOGP(0, LOGL_ERROR, "Component does not fit.\n"); + LOGP(DLGLOBAL, LOGL_ERROR, "Component does not fit.\n"); return -EINVAL; } @@ -517,7 +517,7 @@ case GSM0480_CTYPE_REJECT: break; default: - LOGP(0, LOGL_DEBUG, "Unknown GSM 04.80 Facility " + LOGP(DLGLOBAL, LOGL_ERROR, "Unknown GSM 04.80 Facility " "Component Type 0x%02x\n", component_type); rc = 0; break; @@ -547,7 +547,7 @@ /* mandatory part */ if (invoke_data[0] != GSM0480_COMPIDTAG_INVOKE_ID) { - LOGP(0, LOGL_DEBUG, "Unexpected GSM 04.80 Component-ID tag " + LOGP(DLGLOBAL, LOGL_ERROR, "Unexpected GSM 04.80 Component-ID tag " "0x%02x (expecting Invoke ID tag)\n", invoke_data[0]); } @@ -589,13 +589,13 @@ req); break; default: - LOGP(0, LOGL_DEBUG, "GSM 04.80 operation code 0x%02x " + LOGP(DLGLOBAL, LOGL_ERROR, "GSM 04.80 operation code 0x%02x " "is not yet handled\n", operation_code); rc = 0; break; } } else { - LOGP(0, LOGL_DEBUG, "Unexpected GSM 04.80 Component-ID tag 0x%02x " + LOGP(DLGLOBAL, LOGL_ERROR, "Unexpected GSM 04.80 Component-ID tag 0x%02x " "(expecting Operation Code tag)\n", invoke_data[0]); rc = 0; @@ -616,7 +616,7 @@ /* Mandatory part */ if (rr_data[0] != GSM0480_COMPIDTAG_INVOKE_ID) { - LOGP(0, LOGL_DEBUG, "Unexpected GSM 04.80 Component-ID tag " + LOGP(DLGLOBAL, LOGL_ERROR, "Unexpected GSM 04.80 Component-ID tag " "0x%02x (expecting Invoke ID tag)\n", rr_data[0]); return 0; } @@ -647,7 +647,7 @@ return parse_process_uss_data(rr_data + offset + 3, length - offset - 3, req); default: - LOGP(0, LOGL_DEBUG, "GSM 04.80 operation code 0x%02x " + LOGP(DLGLOBAL, LOGL_ERROR, "GSM 04.80 operation code 0x%02x " "is not yet handled\n", operation_code); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14861 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id38272ff93fae6d2fdf39df4ffc74856d6c9a898 Gerrit-Change-Number: 14861 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:33:53 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 09:33:53 +0000 Subject: Change in ...libsmpp34[master]: bind_receiver_test: Fix "unused value" of writing addr_ton twice Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libsmpp34/+/14862 Change subject: bind_receiver_test: Fix "unused value" of writing addr_ton twice ...................................................................... bind_receiver_test: Fix "unused value" of writing addr_ton twice The constant 0x34 clearly hints that this should be written to interface_version... Closes: CID#135235 Change-Id: I89e16746da5c9f77b721294149a1bce5be5a1eae --- M test_pdu/bind_receiver_test.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libsmpp34 refs/changes/62/14862/1 diff --git a/test_pdu/bind_receiver_test.c b/test_pdu/bind_receiver_test.c index fa94c6f..67eab09 100644 --- a/test_pdu/bind_receiver_test.c +++ b/test_pdu/bind_receiver_test.c @@ -53,7 +53,7 @@ snprintf((char*)b.system_id, sizeof(b.system_id), "%s", "system_id"); snprintf((char*)b.password, sizeof(b.password), "%s", "pass"); snprintf((char*)b.system_type, sizeof(b.system_type), "%s", "syste"); - b.addr_ton = 0x34; + b.interface_version = 0x34; b.addr_ton = 2; b.addr_npi = 1; snprintf((char*)b.address_range, sizeof(b.address_range), "%s", "address_range"); -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/14862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I89e16746da5c9f77b721294149a1bce5be5a1eae Gerrit-Change-Number: 14862 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:43:01 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 09:43:01 +0000 Subject: Change in ...osmo-trx[master]: Timeval: Restore output stream flags after changing them Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14863 Change subject: Timeval: Restore output stream flags after changing them ...................................................................... Timeval: Restore output stream flags after changing them Change-Id: I866505f29ed56d8f3ba3aaba70c0d82479987c64 Closes: OS#149361 --- M CommonLibs/Timeval.cpp 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/63/14863/1 diff --git a/CommonLibs/Timeval.cpp b/CommonLibs/Timeval.cpp index fd1bcda..420dd04 100644 --- a/CommonLibs/Timeval.cpp +++ b/CommonLibs/Timeval.cpp @@ -87,8 +87,9 @@ ostream& operator<<(ostream& os, const Timeval& tv) { - os.setf( ios::fixed, ios::floatfield ); + ios_base::fmtflags flags_backup = os.setf( ios::fixed, ios::floatfield ); os << tv.seconds(); + os.flags( flags_backup ); return os; } -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I866505f29ed56d8f3ba3aaba70c0d82479987c64 Gerrit-Change-Number: 14863 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:47:30 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 09:47:30 +0000 Subject: Change in ...libosmocore[master]: gsm/gsm48_ie.c: fix deprecation warning: use gsm48_decode_bcd_number2() Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14864 Change subject: gsm/gsm48_ie.c: fix deprecation warning: use gsm48_decode_bcd_number2() ...................................................................... gsm/gsm48_ie.c: fix deprecation warning: use gsm48_decode_bcd_number2() Change-Id: I1b0eff1396776900c1286e41da3aee3ff78b326e --- M src/gsm/gsm48_ie.c 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/64/14864/1 diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c index 31028ba..5e67806 100644 --- a/src/gsm/gsm48_ie.c +++ b/src/gsm/gsm48_ie.c @@ -408,7 +408,9 @@ called->type = (lv[1] & 0x70) >> 4; /* octet 4..N */ - gsm48_decode_bcd_number(called->number, sizeof(called->number), lv, 1); + gsm48_decode_bcd_number2(called->number, sizeof(called->number), + /* FIXME: emulate length of lv */ + lv, in_len + 1, 1); return 0; } @@ -463,7 +465,9 @@ } /* octet 4..N */ - gsm48_decode_bcd_number(callerid->number, sizeof(callerid->number), lv, i); + gsm48_decode_bcd_number2(callerid->number, sizeof(callerid->number), + /* FIXME: emulate length of lv */ + lv, in_len + 1, i); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14864 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1b0eff1396776900c1286e41da3aee3ff78b326e Gerrit-Change-Number: 14864 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:51:14 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 09:51:14 +0000 Subject: Change in ...osmo-trx[master]: ChannelizerBase: fix initialization of class members Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14865 Change subject: ChannelizerBase: fix initialization of class members ...................................................................... ChannelizerBase: fix initialization of class members Change-Id: I8c047c8f98e928a62dca1d7b8c003502727c086e Closes: CID#149374 --- M Transceiver52M/ChannelizerBase.cpp 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/65/14865/1 diff --git a/Transceiver52M/ChannelizerBase.cpp b/Transceiver52M/ChannelizerBase.cpp index 430e260..f5b3ed4 100644 --- a/Transceiver52M/ChannelizerBase.cpp +++ b/Transceiver52M/ChannelizerBase.cpp @@ -226,7 +226,8 @@ * Setup channelizer paramaters */ ChannelizerBase::ChannelizerBase(size_t m, size_t blockLen, size_t hLen) - : fftInput(NULL), fftOutput(NULL), fftHandle(NULL) + : subFilters(NULL), hInputs(NULL), hOutputs(NULL), hist(NULL), + fftInput(NULL), fftOutput(NULL), fftHandle(NULL) { this->m = m; this->hLen = hLen; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8c047c8f98e928a62dca1d7b8c003502727c086e Gerrit-Change-Number: 14865 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:51:15 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 09:51:15 +0000 Subject: Change in ...osmo-trx[master]: CorrelationSequence: fix initialization of class members Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14866 Change subject: CorrelationSequence: fix initialization of class members ...................................................................... CorrelationSequence: fix initialization of class members Change-Id: Ia72395f8805e9e2cd700ad1e559a8aa62124aaec Closes: CID#149371 --- M Transceiver52M/sigProcLib.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/66/14866/1 diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp index 860bbe4..1042dbb 100644 --- a/Transceiver52M/sigProcLib.cpp +++ b/Transceiver52M/sigProcLib.cpp @@ -84,7 +84,7 @@ * perform 16-byte memory alignment required by many SSE instructions. */ struct CorrelationSequence { - CorrelationSequence() : sequence(NULL) + CorrelationSequence() : sequence(NULL), buffer(NULL), toa(0.0) { } -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia72395f8805e9e2cd700ad1e559a8aa62124aaec Gerrit-Change-Number: 14866 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:53:25 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 09:53:25 +0000 Subject: Change in ...libosmo-abis[master]: [hack] e1d support Message-ID: Hello tnt, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/14867 to review the following change. Change subject: [hack] e1d support ...................................................................... [hack] e1d support Change-Id: Ia0431c124e3b5b4108aee7b109d8c4bb0d8b45d4 Signed-off-by: Sylvain Munaut --- M configure.ac M include/osmocom/abis/e1_input.h M src/Makefile.am M src/e1_input.c M src/e1_input_vty.c A src/input/e1d.c 6 files changed, 312 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/67/14867/1 diff --git a/configure.ac b/configure.ac index ba33ed9..bed357d 100644 --- a/configure.ac +++ b/configure.ac @@ -66,6 +66,27 @@ AC_CHECK_HEADERS(dahdi/user.h,,AC_MSG_WARN(DAHDI input driver will not be built)) +AC_ARG_ENABLE([e1d], + [AS_HELP_STRING( + [--enable-e1d], + [Enable osmo-e1d driver support] + )], + [ + ENABLE_E1D=$enableval + ], + [ + ENABLE_E1D="no" + ]) +AS_IF([test "x$ENABLE_E1D" = "xyes"], [ + PKG_CHECK_MODULES(LIBOSMOE1D, libosmo-e1d) +]) +AM_CONDITIONAL(ENABLE_E1D, test "x$ENABLE_E1D" = "xyes") +AC_SUBST(ENABLE_E1D) +if test x"$ENABLE_E1D" = x"yes" +then + AC_DEFINE([HAVE_E1D], [1], [Enable osmo-e1d driver support]) +fi + AC_ARG_ENABLE(sanitize, [AS_HELP_STRING( [--enable-sanitize], diff --git a/include/osmocom/abis/e1_input.h b/include/osmocom/abis/e1_input.h index e6d5154..741d679 100644 --- a/include/osmocom/abis/e1_input.h +++ b/include/osmocom/abis/e1_input.h @@ -123,6 +123,10 @@ struct osmo_fd fd; } dahdi; struct { + /* osmo-e1d driver has one fd for each ts */ + struct osmo_fd fd; + } e1d; + struct { struct osmo_fd fd; } rs232; } driver; diff --git a/src/Makefile.am b/src/Makefile.am index 2d2424d..e8f07a1 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -5,9 +5,9 @@ TRAU_LIBVERSION=3:2:1 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir) -AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(COVERAGE_CFLAGS) +AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(LIBOSMOE1D_CFLAGS) $(COVERAGE_CFLAGS) AM_LDFLAGS = $(COVERAGE_LDFLAGS) -COMMONLIBS = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(LIBOSMOVTY_LIBS) +COMMONLIBS = $(LIBOSMOCORE_LIBS) $(LIBOSMOGSM_LIBS) $(LIBOSMOVTY_LIBS) $(LIBOSMOE1D_LIBS) lib_LTLIBRARIES = libosmoabis.la libosmotrau.la @@ -20,6 +20,7 @@ subchan_demux.c \ trau_frame.c \ input/dahdi.c \ + input/e1d.c \ input/ipa.c \ input/ipa_keepalive.c \ input/ipaccess.c \ diff --git a/src/e1_input.c b/src/e1_input.c index 4717830..ca24e11 100644 --- a/src/e1_input.c +++ b/src/e1_input.c @@ -877,6 +877,9 @@ #ifdef HAVE_DAHDI_USER_H e1inp_dahdi_init(); #endif +#ifdef ENABLE_E1D + e1inp_e1d_init(); +#endif e1inp_ipaccess_init(); e1inp_rs232_init(); e1inp_unixsocket_init(); diff --git a/src/e1_input_vty.c b/src/e1_input_vty.c index d81c859..a1943e6 100644 --- a/src/e1_input_vty.c +++ b/src/e1_input_vty.c @@ -41,7 +41,7 @@ /* CONFIG */ -#define E1_DRIVER_NAMES "(misdn|misdn_lapd|dahdi|ipa|unixsocket)" +#define E1_DRIVER_NAMES "(misdn|misdn_lapd|dahdi|e1d|ipa|unixsocket)" #define E1_DRIVER_HELP "mISDN supported E1 Card (kernel LAPD)\n" \ "mISDN supported E1 Card (userspace LAPD)\n" \ "DAHDI supported E1/T1/J1 Card\n" \ diff --git a/src/input/e1d.c b/src/input/e1d.c new file mode 100644 index 0000000..ceeb0c2 --- /dev/null +++ b/src/input/e1d.c @@ -0,0 +1,280 @@ +/* OpenBSC Abis input driver for osmo-e1d */ + +/* (C) 2019 by Sylvain Munaut + * + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + * + */ + +#include "config.h" + +#ifdef HAVE_E1D + +#include +#include +#include + +#include +#include + +#include + +#include +#include +#include + +#include +#include + + +#define TS_SIGN_ALLOC_SIZE 300 + +struct osmo_e1dp_client *g_e1d; + +/* pre-declaration */ +extern struct e1inp_driver e1d_driver; +static int e1d_want_write(struct e1inp_ts *e1i_ts); + + +static int +handle_ts_sign_read(struct osmo_fd *bfd) +{ + struct e1inp_line *line = bfd->data; + unsigned int ts_nr = bfd->priv_nr; + struct e1inp_ts *e1i_ts = &line->ts[ts_nr-1]; + struct msgb *msg = msgb_alloc(TS_SIGN_ALLOC_SIZE, "E1D Signaling TS"); + int ret; + + if (!msg) + return -ENOMEM; + + ret = read(bfd->fd, msg->data, TS_SIGN_ALLOC_SIZE - 16); + if (ret < 0) { + perror("read "); + return ret; + } + + msgb_put(msg, ret); + if (ret <= 1) { + perror("read "); + return ret; + } + + return e1inp_rx_ts_lapd(e1i_ts, msg); +} + +static void +timeout_ts_sign_write(void *data) +{ + struct e1inp_ts *e1i_ts = (struct e1inp_ts *)data; + + /* trigger write of ts1, due to tx delay timer */ + e1d_want_write(e1i_ts); +} + +static int +handle_ts_sign_write(struct osmo_fd *bfd) +{ + struct e1inp_line *line = bfd->data; + unsigned int ts_nr = bfd->priv_nr; + struct e1inp_ts *e1i_ts = &line->ts[ts_nr-1]; + struct e1inp_sign_link *sign_link; + struct msgb *msg; + + bfd->when &= ~BSC_FD_WRITE; + + /* get the next msg for this timeslot */ + msg = e1inp_tx_ts(e1i_ts, &sign_link); + if (!msg) { + /* no message after tx delay timer */ + return 0; + } + + DEBUGP(DLMI, "TX: %s\n", osmo_hexdump(msg->data, msg->len)); + lapd_transmit(e1i_ts->lapd, sign_link->tei, + sign_link->sapi, msg); + + /* set tx delay timer for next event */ + osmo_timer_setup(&e1i_ts->sign.tx_timer, timeout_ts_sign_write, e1i_ts); + osmo_timer_schedule(&e1i_ts->sign.tx_timer, 0, 50000); + + return 0; +} + + +static void +e1d_write_msg(struct msgb *msg, void *cbdata) +{ + struct osmo_fd *bfd = cbdata; + struct e1inp_line *line = bfd->data; + unsigned int ts_nr = bfd->priv_nr; + struct e1inp_ts *e1i_ts = &line->ts[ts_nr-1]; + int ret; + + ret = write(bfd->fd, msg->data, msg->len); + msgb_free(msg); + if (ret < 0) + LOGP(DLMI, LOGL_NOTICE, "%s write failed %d\n", __func__, ret); +} + +static int +e1d_fd_cb(struct osmo_fd *bfd, unsigned int what) +{ + struct e1inp_line *line = bfd->data; + unsigned int ts_nr = bfd->priv_nr; + unsigned int idx = ts_nr-1; + struct e1inp_ts *e1i_ts = &line->ts[idx]; + int ret = 0; + + switch (e1i_ts->type) { + case E1INP_TS_TYPE_SIGN: + //if (what & BSC_FD_EXCEPT) + //FIXME: what to do ?!?! + if (what & BSC_FD_READ) + ret = handle_ts_sign_read(bfd); + if (what & BSC_FD_WRITE) + ret = handle_ts_sign_write(bfd); + break; + default: + LOGP(DLINP, LOGL_NOTICE, + "unknown/unsupported E1 TS type %u\n", e1i_ts->type); + break; + } + + return ret; +} + + +static int +e1d_want_write(struct e1inp_ts *e1i_ts) +{ + /* We never include the DAHDI B-Channel FD into the writeset */ + if (e1i_ts->type == E1INP_TS_TYPE_TRAU) { + LOGP(DLINP, LOGL_DEBUG, "Trying to write TRAU ts\n"); + return 0; + } + + e1i_ts->driver.e1d.fd.when |= BSC_FD_WRITE; + + return 0; +} + +static int +e1d_line_update(struct e1inp_line *line) +{ + int ts; + int ret; + + if (line->driver != &e1d_driver) + return -EINVAL; + + + LOGP(DLINP, LOGL_ERROR, "Line update %d %d %d\n", line->num, line->port_nr, line->num_ts); + + for (ts=1; tsnum_ts; ts++) + { + unsigned int idx = ts-1; + struct e1inp_ts *e1i_ts = &line->ts[idx]; + struct osmo_fd *bfd = &e1i_ts->driver.e1d.fd; + + /* unregister FD if it was already registered */ + if (bfd->list.next && bfd->list.next != LLIST_POISON1) + osmo_fd_unregister(bfd); + + bfd->data = line; + bfd->priv_nr = ts; + bfd->cb = e1d_fd_cb; + + switch (e1i_ts->type) { + case E1INP_TS_TYPE_NONE: + /* close/release LAPD instance, if any */ + if (e1i_ts->lapd) { + lapd_instance_free(e1i_ts->lapd); + e1i_ts->lapd = NULL; + } + if (bfd->fd) { + close(bfd->fd); + bfd->fd = 0; + } + continue; + case E1INP_TS_TYPE_SIGN: + if (bfd->fd <= 0) + bfd->fd = osmo_e1dp_client_ts_open(g_e1d, 0, 0, ts, E1DP_TSMODE_HDLCFCS); + if (bfd->fd < 0) { + LOGP(DLINP, LOGL_ERROR, + "Could not open timeslot %d\n", ts); + return -EIO; + } + bfd->when = BSC_FD_READ | BSC_FD_EXCEPT; + + if (!e1i_ts->lapd) + e1i_ts->lapd = lapd_instance_alloc(1, + e1d_write_msg, bfd, e1inp_dlsap_up, + e1i_ts, &lapd_profile_abis); + break; + case E1INP_TS_TYPE_HDLC: + break; + case E1INP_TS_TYPE_TRAU: + break; + case E1INP_TS_TYPE_RAW: + break; + }; + + ret = osmo_fd_register(bfd); + if (ret < 0) { + LOGP(DLINP, LOGL_ERROR, + "could not register FD: %s\n", + strerror(ret)); + return ret; + } + } + + return 0; +} + +static void +e1d_vty_show(struct vty *vty, struct e1inp_line *line) +{ + /* FIXME */ + vty_out(vty, "Not supported yet%s", VTY_NEWLINE); +} + + +struct e1inp_driver e1d_driver = { + .name = "e1d", + .want_write = e1d_want_write, + .line_update = e1d_line_update, + .vty_show = e1d_vty_show, +}; + +int +e1inp_e1d_init(void) +{ + /* Connect to daemon */ + g_e1d = osmo_e1dp_client_create(NULL, "/tmp/osmo-e1d.ctl"); + if (!g_e1d) { + LOGP(DLINP, LOGL_ERROR, "Unable to connect to osmo-e1d daemon\n"); + return -EPIPE; + } + + /* register the driver with the core */ + return e1inp_driver_register(&e1d_driver); +} + +#endif /* HAVE_E1D */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14867 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia0431c124e3b5b4108aee7b109d8c4bb0d8b45d4 Gerrit-Change-Number: 14867 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: tnt Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:53:26 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 09:53:26 +0000 Subject: Change in ...libosmo-abis[master]: Use HAVE_E1D in C source, not ENABLE_E1D Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14868 Change subject: Use HAVE_E1D in C source, not ENABLE_E1D ...................................................................... Use HAVE_E1D in C source, not ENABLE_E1D The config.g files contains HAVE_E1D. Change-Id: Ib7d2db6703300b7d537c78ad9285948673d8b1d3 --- M src/e1_input.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/68/14868/1 diff --git a/src/e1_input.c b/src/e1_input.c index ca24e11..dc2c3c4 100644 --- a/src/e1_input.c +++ b/src/e1_input.c @@ -877,7 +877,7 @@ #ifdef HAVE_DAHDI_USER_H e1inp_dahdi_init(); #endif -#ifdef ENABLE_E1D +#ifdef HAVE_E1D e1inp_e1d_init(); #endif e1inp_ipaccess_init(); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14868 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib7d2db6703300b7d537c78ad9285948673d8b1d3 Gerrit-Change-Number: 14868 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:53:26 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 09:53:26 +0000 Subject: Change in ...libosmo-abis[master]: add missing forward-declaration of e1inp_e1d_init() Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14869 Change subject: add missing forward-declaration of e1inp_e1d_init() ...................................................................... add missing forward-declaration of e1inp_e1d_init() Change-Id: I0060e2c9772eb5c0293712cb0da7cc0477eb8abd --- M src/e1_input.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/69/14869/1 diff --git a/src/e1_input.c b/src/e1_input.c index dc2c3c4..e5848d7 100644 --- a/src/e1_input.c +++ b/src/e1_input.c @@ -862,6 +862,7 @@ void e1inp_misdn_init(void); void e1inp_dahdi_init(void); +void e1inp_e1d_init(void); void e1inp_ipaccess_init(void); void e1inp_rs232_init(void); void e1inp_unixsocket_init(void); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14869 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0060e2c9772eb5c0293712cb0da7cc0477eb8abd Gerrit-Change-Number: 14869 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:53:26 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 09:53:26 +0000 Subject: Change in ...libosmo-abis[master]: ipaccess.c: Avoid calling close(-1) on error path Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14870 Change subject: ipaccess.c: Avoid calling close(-1) on error path ...................................................................... ipaccess.c: Avoid calling close(-1) on error path Change-Id: Idabb9805a4a10c95ba0e01bc3f80ed8db87a9f85 Closes: CID#157118 --- M src/input/ipaccess.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/70/14870/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 136aa79..0d6d55d 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -215,8 +215,10 @@ return 0; err: osmo_fd_unregister(bfd); - close(bfd->fd); - bfd->fd = -1; + if (bfd->fd != -1) { + close(bfd->fd); + bfd->fd = -1; + } e1inp_line_put(line); return -1; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14870 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Idabb9805a4a10c95ba0e01bc3f80ed8db87a9f85 Gerrit-Change-Number: 14870 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:54:15 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 09:54:15 +0000 Subject: Change in ...osmo-bts[master]: sysmo/l1_if.c: Annotate fall-through in switch statement Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14871 Change subject: sysmo/l1_if.c: Annotate fall-through in switch statement ...................................................................... sysmo/l1_if.c: Annotate fall-through in switch statement Change-Id: I72937e087288fe7681fafe4099e49849657924bd Closes: CID#162019 --- M src/osmo-bts-sysmo/l1_if.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/71/14871/1 diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c index 0777d0e..c431e49 100644 --- a/src/osmo-bts-sysmo/l1_if.c +++ b/src/osmo-bts-sysmo/l1_if.c @@ -1851,6 +1851,7 @@ /* sysmoBTS 1002 without any setting in EEPROM */ LOGP(DL1C, LOGL_NOTICE, "Assuming 1002 for sysmoBTS " "Model number %u\n", fl1h->hw_info.model_nr); + /* fall-through */ case 1002: set_power_param(&trx->power_params, 23, 0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14871 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I72937e087288fe7681fafe4099e49849657924bd Gerrit-Change-Number: 14871 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 09:56:07 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 09:56:07 +0000 Subject: Change in ...osmo-trx[master]: radioInterface.cpp: Fix missing member initialization of RadioInterfa... Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14872 Change subject: radioInterface.cpp: Fix missing member initialization of RadioInterface() ...................................................................... radioInterface.cpp: Fix missing member initialization of RadioInterface() Change-Id: I7264ef35dbe6d3522858eae5b47d150aa1ffe334 Closes: CID#169594 --- M Transceiver52M/radioInterface.cpp 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/72/14872/1 diff --git a/Transceiver52M/radioInterface.cpp b/Transceiver52M/radioInterface.cpp index f488b0d..04b98da 100644 --- a/Transceiver52M/radioInterface.cpp +++ b/Transceiver52M/radioInterface.cpp @@ -34,7 +34,8 @@ size_t rx_sps, size_t chans, int wReceiveOffset, GSM::Time wStartTime) : mRadio(wRadio), mSPSTx(tx_sps), mSPSRx(rx_sps), mChans(chans), - underrun(false), overrun(false), receiveOffset(wReceiveOffset), mOn(false) + underrun(false), overrun(false), writeTimestamp(0), readTimestamp(0), + receiveOffset(wReceiveOffset), mOn(false) { mClock.set(wStartTime); } -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14872 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7264ef35dbe6d3522858eae5b47d150aa1ffe334 Gerrit-Change-Number: 14872 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:06:32 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:06:32 +0000 Subject: Change in ...osmo-bts[master]: pcu_sock: Don't discard fractional part of link_quality Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14873 Change subject: pcu_sock: Don't discard fractional part of link_quality ...................................................................... pcu_sock: Don't discard fractional part of link_quality When comparing the received link quality with the minimum threshold, don't discard any fractional part by first converting to float and then dividing by 10 (rather than the opposite order). Change-Id: I3b9d00d5314f53d4f51e464400fc3e97858adb57 Closes: CID#171992 --- M src/common/pcu_sock.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/73/14873/1 diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 39b4568..7f5fed3 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -320,18 +320,19 @@ int pcu_tx_data_ind(struct gsm_bts_trx_ts *ts, uint8_t sapi, uint32_t fn, uint16_t arfcn, uint8_t block_nr, uint8_t *data, uint8_t len, - int8_t rssi, uint16_t ber10k, int16_t bto, int16_t lqual) + int8_t rssi, uint16_t ber10k, int16_t bto, int16_t lqual_cb) { struct msgb *msg; struct gsm_pcu_if *pcu_prim; struct gsm_pcu_if_data *data_ind; struct gsm_bts *bts = ts->trx->bts; + float lqual = (float) lqual_cb / 10.0f; LOGP(DPCU, LOGL_DEBUG, "Sending data indication: sapi=%s arfcn=%d block=%d data=%s\n", sapi_string[sapi], arfcn, block_nr, osmo_hexdump(data, len)); - if (lqual / 10 < bts->min_qual_norm) { - LOGP(DPCU, LOGL_DEBUG, "Link quality %"PRId16" is below threshold %f, dropping packet\n", + if (lqual < bts->min_qual_norm) { + LOGP(DPCU, LOGL_DEBUG, "Link quality %f is below threshold %f, dropping packet\n", lqual, bts->min_qual_norm); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3b9d00d5314f53d4f51e464400fc3e97858adb57 Gerrit-Change-Number: 14873 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:06:33 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:06:33 +0000 Subject: Change in ...osmo-bts[master]: l1sap: Don't discard fractional part of link_quality Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14874 Change subject: l1sap: Don't discard fractional part of link_quality ...................................................................... l1sap: Don't discard fractional part of link_quality When comparing the received link quality with the minimum threshold, don't discard any fractional part by first converting to float and then dividing by 10 (rather than the opposite order). Change-Id: I1c365cf2b46fc8c5922e4e32fcc55d1f03b1e935 Closes: CID#171993 --- M src/common/l1sap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/74/14874/1 diff --git a/src/common/l1sap.c b/src/common/l1sap.c index b730b85..cd05955 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1218,7 +1218,7 @@ * the content is not available due to decoding issues. Content not * available is expected as empty payload. We also check if quality is * good enough. */ - if (msg->len && tch_ind->lqual_cb / 10 >= bts->min_qual_norm) { + if (msg->len && (float) tch_ind->lqual_cb / 10.0f >= bts->min_qual_norm) { /* hand msg to RTP code for transmission */ if (lchan->abis_ip.rtp_socket) osmo_rtp_send_frame_ext(lchan->abis_ip.rtp_socket, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1c365cf2b46fc8c5922e4e32fcc55d1f03b1e935 Gerrit-Change-Number: 14874 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:09:26 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:09:26 +0000 Subject: Change in ...libosmocore[master]: osmo_get_rand_id(): Avoid dead code by proper #if/#else/#endif Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14875 Change subject: osmo_get_rand_id(): Avoid dead code by proper #if/#else/#endif ...................................................................... osmo_get_rand_id(): Avoid dead code by proper #if/#else/#endif Change-Id: I34e465dead179487f7d4508e0e6ecf0e838c6eb7 Closes: CID#177910 --- M src/gsm/gsm_utils.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/14875/1 diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c index f154c2b..365920f 100644 --- a/src/gsm/gsm_utils.c +++ b/src/gsm/gsm_utils.c @@ -466,8 +466,9 @@ if (rc < 0) { #if (USE_GNUTLS) return gnutls_rnd(GNUTLS_RND_RANDOM, out, len); -#endif +#else return -errno; +#endif } /* getrandom() failed partially due to signal interruption: -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14875 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I34e465dead179487f7d4508e0e6ecf0e838c6eb7 Gerrit-Change-Number: 14875 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:20:06 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:20:06 +0000 Subject: Change in ...osmo-bts[master]: scheduler_trx: Deal with osmo_amr_rtp_enc() returning negative Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14876 Change subject: scheduler_trx: Deal with osmo_amr_rtp_enc() returning negative ...................................................................... scheduler_trx: Deal with osmo_amr_rtp_enc() returning negative We cannot pass the possibly negative return value as length value to _sched_compose_tch_ind() which would use it as the (unsigned) length value of a memcpy. Change-Id: I70ce98c5697b9ce6fac7ab57a5d70f3201db29d9 Closes: CID#178643 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/76/14876/1 diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index ade3cff..22399c1 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -382,6 +382,10 @@ len = osmo_amr_rtp_enc(tch_data, chan_state->codec[chan_state->dl_cmr], chan_state->codec[chan_state->dl_ft], AMR_BAD); + if (len < 0) { + LOGL1S(DL1P, LOGL_ERROR, l1t, tn, chan, fn, "Cannot encode AMR\n"); + len = 0; + } if (len < 2) break; memset(tch_data + 2, 0, len - 2); @@ -1212,6 +1216,11 @@ chan_state->codec[chan_state->dl_cmr], chan_state->codec[chan_state->dl_ft], AMR_BAD); + if (rc < 0) { + LOGL1S(DL1P, LOGL_ERROR, l1t, tn, chan, fn, + "Cannot encode AMR\n"); + rc = 0; + } if (rc < 2) break; memset(tch_data + 2, 0, rc - 2); @@ -1393,6 +1402,11 @@ chan_state->codec[chan_state->dl_cmr], chan_state->codec[chan_state->dl_ft], AMR_BAD); + if (rc < 0) { + LOGL1S(DL1P, LOGL_ERROR, l1t, tn, chan, fn, + "Cannot encode AMR\n"); + rc = 0; + } if (rc < 2) break; memset(tch_data + 2, 0, rc - 2); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14876 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I70ce98c5697b9ce6fac7ab57a5d70f3201db29d9 Gerrit-Change-Number: 14876 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:26:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:26:22 +0000 Subject: Change in ...osmo-bts[master]: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode() Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14877 Change subject: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode() ...................................................................... scheduler_trx: Handle negative return of gsm0503_tch_hr_decode() If gsm0503_tch_hr_decode() returns a negative error, we shouldn't set the marker bit or pass the negative value as length value into osmo_hr_check_sid(). Change-Id: If49ca6926c576a2b17507b6a95b6f3ca17877d66 Closes: CID#187645 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/77/14877/1 diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 22399c1..e18fcdc 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -1327,7 +1327,7 @@ */ rc = gsm0503_tch_hr_decode(tch_data, *bursts_p, fn_is_odd, &n_errors, &n_bits_total); - if (rc) /* DTXu */ + if (rc >= 0) /* DTXu */ lchan_set_marker(osmo_hr_check_sid(tch_data, rc), lchan); break; case GSM48_CMODE_SPEECH_AMR: /* AMR */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If49ca6926c576a2b17507b6a95b6f3ca17877d66 Gerrit-Change-Number: 14877 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:29:34 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:29:34 +0000 Subject: Change in ...osmocom-bb[master]: virtphy: Fix array out of bounds access in getL1ctlPrimName() In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14848 ) Change subject: virtphy: Fix array out of bounds access in getL1ctlPrimName() ...................................................................... virtphy: Fix array out of bounds access in getL1ctlPrimName() Closes: CID#198573 Change-Id: I6504a7ffcf961d3162e6ab2ec8f5f2016ef12cde --- M src/host/virt_phy/src/logging.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/virt_phy/src/logging.c b/src/host/virt_phy/src/logging.c index a3e63bc..7e4e79b 100644 --- a/src/host/virt_phy/src/logging.c +++ b/src/host/virt_phy/src/logging.c @@ -128,7 +128,7 @@ const char *getL1ctlPrimName(uint8_t type) { - if (type <= ARRAY_SIZE(l1ctlPrimNames)) + if (type < ARRAY_SIZE(l1ctlPrimNames)) return l1ctlPrimNames[type]; else return "Unknwon Primitive"; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6504a7ffcf961d3162e6ab2ec8f5f2016ef12cde Gerrit-Change-Number: 14848 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:29:34 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:29:34 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Fix out-of-bounds for partial reads in un_tool_read() In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14849 ) Change subject: osmocon: Fix out-of-bounds for partial reads in un_tool_read() ...................................................................... osmocon: Fix out-of-bounds for partial reads in un_tool_read() "uint8_t buf[4096]; ... &buf + 1" renders an offset of 4096, and not 1! Change-Id: Ie1407371fe949c3d5746b9fdc32ececc9443692b Closes: CID#198580 --- M src/host/osmocon/osmocon.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c index 26416f7..9090d27 100644 --- a/src/host/osmocon/osmocon.c +++ b/src/host/osmocon/osmocon.c @@ -1242,7 +1242,7 @@ c = 0; while(c < 2) { - rc = read(fd->fd, &buf + c, 2 - c); + rc = read(fd->fd, buf + c, 2 - c); if(rc == 0) { // disconnect goto close; @@ -1262,7 +1262,7 @@ c = 0; while(c < length) { - rc = read(fd->fd, &buf + c, length - c); + rc = read(fd->fd, buf + c, length - c); if(rc == 0) { // disconnect goto close; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie1407371fe949c3d5746b9fdc32ececc9443692b Gerrit-Change-Number: 14849 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:29:34 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:29:34 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Fix fd leak in error path of read_file() In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14850 ) Change subject: osmocon: Fix fd leak in error path of read_file() ...................................................................... osmocon: Fix fd leak in error path of read_file() Change-Id: Iaae407658df184277f6e6e07d6a48d8b5c75587b Closes: CID#198552 --- M src/host/osmocon/osmocon.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c index 9090d27..9237214 100644 --- a/src/host/osmocon/osmocon.c +++ b/src/host/osmocon/osmocon.c @@ -290,6 +290,7 @@ if ((st.st_size > MAX_DNLOAD_SIZE) && (dnload.mode != MODE_ROMLOAD)) { fprintf(stderr, "The maximum file size is 64kBytes (%u bytes)\n", MAX_DNLOAD_SIZE); + close(fd); return -EFBIG; } } else { -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaae407658df184277f6e6e07d6a48d8b5c75587b Gerrit-Change-Number: 14850 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:29:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:29:35 +0000 Subject: Change in ...osmocom-bb[master]: gsm322: Fix resource leak in gsm322_init() while reading BA In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14851 ) Change subject: gsm322: Fix resource leak in gsm322_init() while reading BA ...................................................................... gsm322: Fix resource leak in gsm322_init() while reading BA Change-Id: Id42102ab8581e247f495fb7e05dc62a6743d28c5 Closes: CID#198546 --- M src/host/layer23/src/mobile/gsm322.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm322.c b/src/host/layer23/src/mobile/gsm322.c index cfd70d8..56dd236 100644 --- a/src/host/layer23/src/mobile/gsm322.c +++ b/src/host/layer23/src/mobile/gsm322.c @@ -5085,8 +5085,10 @@ } else while(!feof(fp)) { ba = talloc_zero(ms, struct gsm322_ba_list); - if (!ba) + if (!ba) { + fclose(fp); return -ENOMEM; + } rc = fread(buf, 4, 1, fp); if (!rc) { talloc_free(ba); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14851 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id42102ab8581e247f495fb7e05dc62a6743d28c5 Gerrit-Change-Number: 14851 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:29:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:29:35 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Fix file descriptor + mem leak in error path In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14852 ) Change subject: osmocon: Fix file descriptor + mem leak in error path ...................................................................... osmocon: Fix file descriptor + mem leak in error path Change-Id: I42ceed662889084783dc89f4ca39c3852428d108 Closes: CID#198539 --- M src/host/osmocon/osmocon.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c index 9237214..1bb0bb7 100644 --- a/src/host/osmocon/osmocon.c +++ b/src/host/osmocon/osmocon.c @@ -1309,6 +1309,7 @@ con = talloc_zero(NULL, struct tool_connection); if (!con) { fprintf(stderr, "Failed to create tool connection.\n"); + close(rc); return -1; } @@ -1320,6 +1321,8 @@ con->fd.data = con; if (osmo_fd_register(&con->fd) != 0) { fprintf(stderr, "Failed to register the fd.\n"); + talloc_free(con); + close(rc); return -1; } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14852 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I42ceed662889084783dc89f4ca39c3852428d108 Gerrit-Change-Number: 14852 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:29:57 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 10:29:57 +0000 Subject: Change in ...osmo-bts[master]: sysmo/l1_if.c: Annotate fall-through in switch statement In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14871 ) Change subject: sysmo/l1_if.c: Annotate fall-through in switch statement ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14871 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I72937e087288fe7681fafe4099e49849657924bd Gerrit-Change-Number: 14871 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 10:29:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:30:04 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:30:04 +0000 Subject: Change in ...libosmocore[master]: cbsp.c: Remove dead code In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14847 ) Change subject: cbsp.c: Remove dead code ...................................................................... cbsp.c: Remove dead code Change-Id: I0888fbad0f9094ec1b31e2cceecfc9cd372399bd Closes: CID#202057 --- M src/gsm/cbsp.c 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/gsm/cbsp.c b/src/gsm/cbsp.c index 23f68de..84b9235 100644 --- a/src/gsm/cbsp.c +++ b/src/gsm/cbsp.c @@ -1391,10 +1391,8 @@ if (!msg) { msg = osmo_cbsp_msgb_alloc(ctx, __func__); - if (!msg) { + if (!msg) return -ENOMEM; - goto discard_msg; - } msg->l1h = msg->tail; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14847 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0888fbad0f9094ec1b31e2cceecfc9cd372399bd Gerrit-Change-Number: 14847 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:30:12 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:30:12 +0000 Subject: Change in ...libosmocore[master]: tdef: remove bogus OSMO_ASSERT(unsigned long >= 0) In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14857 ) Change subject: tdef: remove bogus OSMO_ASSERT(unsigned long >= 0) ...................................................................... tdef: remove bogus OSMO_ASSERT(unsigned long >= 0) Change-Id: I7a544d2d43b83135def296674f777e48fe5fd80a Closes: CID#190866 --- M src/tdef.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/tdef.c b/src/tdef.c index 9d5d736..3cfb17c 100644 --- a/src/tdef.c +++ b/src/tdef.c @@ -187,7 +187,6 @@ { const struct osmo_tdef *t = osmo_tdef_get_entry((struct osmo_tdef*)tdefs, T); if (!t) { - OSMO_ASSERT(val_if_not_present >= 0); return val_if_not_present; } return osmo_tdef_round(t->val, t->unit, as_unit); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14857 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7a544d2d43b83135def296674f777e48fe5fd80a Gerrit-Change-Number: 14857 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:30:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:30:22 +0000 Subject: Change in ...libosmocore[master]: osmo_get_rand_id(): Avoid dead code by proper #if/#else/#endif In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14875 ) Change subject: osmo_get_rand_id(): Avoid dead code by proper #if/#else/#endif ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14875 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I34e465dead179487f7d4508e0e6ecf0e838c6eb7 Gerrit-Change-Number: 14875 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 10:30:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:30:23 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:30:23 +0000 Subject: Change in ...libosmocore[master]: osmo_get_rand_id(): Avoid dead code by proper #if/#else/#endif In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14875 ) Change subject: osmo_get_rand_id(): Avoid dead code by proper #if/#else/#endif ...................................................................... osmo_get_rand_id(): Avoid dead code by proper #if/#else/#endif Change-Id: I34e465dead179487f7d4508e0e6ecf0e838c6eb7 Closes: CID#177910 --- M src/gsm/gsm_utils.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gsm/gsm_utils.c b/src/gsm/gsm_utils.c index f154c2b..365920f 100644 --- a/src/gsm/gsm_utils.c +++ b/src/gsm/gsm_utils.c @@ -466,8 +466,9 @@ if (rc < 0) { #if (USE_GNUTLS) return gnutls_rnd(GNUTLS_RND_RANDOM, out, len); -#endif +#else return -errno; +#endif } /* getrandom() failed partially due to signal interruption: -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14875 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I34e465dead179487f7d4508e0e6ecf0e838c6eb7 Gerrit-Change-Number: 14875 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:30:33 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:30:33 +0000 Subject: Change in ...osmo-bts[master]: sysmo/l1_if.c: Annotate fall-through in switch statement In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14871 ) Change subject: sysmo/l1_if.c: Annotate fall-through in switch statement ...................................................................... sysmo/l1_if.c: Annotate fall-through in switch statement Change-Id: I72937e087288fe7681fafe4099e49849657924bd Closes: CID#162019 --- M src/osmo-bts-sysmo/l1_if.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c index 0777d0e..c431e49 100644 --- a/src/osmo-bts-sysmo/l1_if.c +++ b/src/osmo-bts-sysmo/l1_if.c @@ -1851,6 +1851,7 @@ /* sysmoBTS 1002 without any setting in EEPROM */ LOGP(DL1C, LOGL_NOTICE, "Assuming 1002 for sysmoBTS " "Model number %u\n", fl1h->hw_info.model_nr); + /* fall-through */ case 1002: set_power_param(&trx->power_params, 23, 0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14871 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I72937e087288fe7681fafe4099e49849657924bd Gerrit-Change-Number: 14871 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:31:38 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:31:38 +0000 Subject: Change in ...libosmo-abis[master]: ipaccess.c: Avoid calling close(-1) on error path In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14870 ) Change subject: ipaccess.c: Avoid calling close(-1) on error path ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14870 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Idabb9805a4a10c95ba0e01bc3f80ed8db87a9f85 Gerrit-Change-Number: 14870 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 10:31:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:31:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:31:56 +0000 Subject: Change in ...osmo-mgw[master]: mgcp_sdp: Don't check if an unsigned int is below 0 In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14859 ) Change subject: mgcp_sdp: Don't check if an unsigned int is below 0 ...................................................................... mgcp_sdp: Don't check if an unsigned int is below 0 Change-Id: I129f5c6175a8e961bc08b9768bdf22a2232e2fcb Closes: CID#188849 --- M src/libosmo-mgcp/mgcp_sdp.c 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_sdp.c b/src/libosmo-mgcp/mgcp_sdp.c index 99e764b..ddd4657 100644 --- a/src/libosmo-mgcp/mgcp_sdp.c +++ b/src/libosmo-mgcp/mgcp_sdp.c @@ -417,9 +417,6 @@ int rc; unsigned int i; - if (payload_types_len < 0) - return -EINVAL; - rc = msgb_printf(sdp, "m=audio %d RTP/AVP", local_port); if (rc < 0) return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14859 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I129f5c6175a8e961bc08b9768bdf22a2232e2fcb Gerrit-Change-Number: 14859 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:32:07 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 10:32:07 +0000 Subject: Change in ...osmo-bts[master]: pcu_sock: Don't discard fractional part of link_quality In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14873 ) Change subject: pcu_sock: Don't discard fractional part of link_quality ...................................................................... Patch Set 1: This problem is going to be addressed by https://gerrit.osmocom.org/#/c/osmo-bts/+/14686/. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3b9d00d5314f53d4f51e464400fc3e97858adb57 Gerrit-Change-Number: 14873 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 10:32:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:32:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:32:22 +0000 Subject: Change in ...osmo-pcu[master]: bssgp: Fix dead code: PDUT_STATUS can never reach this part In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14858 ) Change subject: bssgp: Fix dead code: PDUT_STATUS can never reach this part ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14858 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iae4332cd3b87f37164655d3df16554de4876159d Gerrit-Change-Number: 14858 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 10:32:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:32:23 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:32:23 +0000 Subject: Change in ...osmo-pcu[master]: bssgp: Fix dead code: PDUT_STATUS can never reach this part In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14858 ) Change subject: bssgp: Fix dead code: PDUT_STATUS can never reach this part ...................................................................... bssgp: Fix dead code: PDUT_STATUS can never reach this part Change-Id: Iae4332cd3b87f37164655d3df16554de4876159d Closes: CID#188855 --- M src/gprs_bssgp_pcu.cpp 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index a4a5875..b34659b 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -369,9 +369,7 @@ if (rc < 0) { LOGP(DBSSGP, LOGL_ERROR, "Failed to parse BSSGP %s message. Invalid message was: %s\n", bssgp_pdu_str(pdu_type), msgb_hexdump(msg)); - if (pdu_type != BSSGP_PDUT_STATUS) - return bssgp_tx_status(BSSGP_CAUSE_INV_MAND_INF, NULL, msg); - return rc; + return bssgp_tx_status(BSSGP_CAUSE_INV_MAND_INF, NULL, msg); } if (pdu_type == BSSGP_PDUT_BVC_RESET) { -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14858 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iae4332cd3b87f37164655d3df16554de4876159d Gerrit-Change-Number: 14858 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:34:01 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 10:34:01 +0000 Subject: Change in ...osmo-bts[master]: l1sap: Don't discard fractional part of link_quality In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14874 ) Change subject: l1sap: Don't discard fractional part of link_quality ...................................................................... Patch Set 1: This is also going to be addressed by https://gerrit.osmocom.org/#/c/osmo-bts/+/14686/. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1c365cf2b46fc8c5922e4e32fcc55d1f03b1e935 Gerrit-Change-Number: 14874 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 10:34:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:37:03 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:37:03 +0000 Subject: Change in ...osmo-ggsn[master]: sgsnemu: Fix format string argument count Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14878 Change subject: sgsnemu: Fix format string argument count ...................................................................... sgsnemu: Fix format string argument count Change-Id: I6bb8c3df53a585913d5e0351ecad2e6ae9f0b886 Closes: CID#178643 --- M sgsnemu/sgsnemu.c 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/78/14878/1 diff --git a/sgsnemu/sgsnemu.c b/sgsnemu/sgsnemu.c index 36b52fc..8e41031 100644 --- a/sgsnemu/sgsnemu.c +++ b/sgsnemu/sgsnemu.c @@ -1452,12 +1452,16 @@ if (!accept_ra || !forwarding) printf("Could not open proc file for %s ?!?\n", tun->devname); else { - if (!strcmp(accept_ra, "0") || - (!strcmp(forwarding, "1") && !strcmp(accept_ra, "1"))) { - printf("%s is %s, i.e. your tun device is not configured to accept " - "router advertisements; SLAAC will not suceed, please " + if (!strcmp(accept_ra, "0")) { + printf("accept_ra=0, i.e. your tun device is not configured to accept " + "router advertisements; SLAAC will not succeed, please " "fix your setup!\n"); } + if (!strcmp(forwarding, "1") && !strcmp(accept_ra, "1")) { + printf("forwarding=1 and accept_ra=1, i.e. your tun device is not " + "configured to accept router advertisements; SLAAC will not " + "succeed, please fix your setup!\n"); + } } free(accept_ra); free(forwarding); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14878 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I6bb8c3df53a585913d5e0351ecad2e6ae9f0b886 Gerrit-Change-Number: 14878 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:46:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:46:36 +0000 Subject: Change in ...osmo-ggsn[master]: sgsnemu: Fix format string argument count In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14878 ) Change subject: sgsnemu: Fix format string argument count ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14878 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I6bb8c3df53a585913d5e0351ecad2e6ae9f0b886 Gerrit-Change-Number: 14878 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 10:46:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:46:38 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:46:38 +0000 Subject: Change in ...osmo-ggsn[master]: sgsnemu: Fix format string argument count In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14878 ) Change subject: sgsnemu: Fix format string argument count ...................................................................... sgsnemu: Fix format string argument count Change-Id: I6bb8c3df53a585913d5e0351ecad2e6ae9f0b886 Closes: CID#178643 --- M sgsnemu/sgsnemu.c 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/sgsnemu/sgsnemu.c b/sgsnemu/sgsnemu.c index 36b52fc..8e41031 100644 --- a/sgsnemu/sgsnemu.c +++ b/sgsnemu/sgsnemu.c @@ -1452,12 +1452,16 @@ if (!accept_ra || !forwarding) printf("Could not open proc file for %s ?!?\n", tun->devname); else { - if (!strcmp(accept_ra, "0") || - (!strcmp(forwarding, "1") && !strcmp(accept_ra, "1"))) { - printf("%s is %s, i.e. your tun device is not configured to accept " - "router advertisements; SLAAC will not suceed, please " + if (!strcmp(accept_ra, "0")) { + printf("accept_ra=0, i.e. your tun device is not configured to accept " + "router advertisements; SLAAC will not succeed, please " "fix your setup!\n"); } + if (!strcmp(forwarding, "1") && !strcmp(accept_ra, "1")) { + printf("forwarding=1 and accept_ra=1, i.e. your tun device is not " + "configured to accept router advertisements; SLAAC will not " + "succeed, please fix your setup!\n"); + } } free(accept_ra); free(forwarding); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14878 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I6bb8c3df53a585913d5e0351ecad2e6ae9f0b886 Gerrit-Change-Number: 14878 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:48:30 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:48:30 +0000 Subject: Change in ...osmocom-bb[master]: gsm480_tx_release_compl(): Fix ordering of location/cause in CAUSE_IE Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14879 Change subject: gsm480_tx_release_compl(): Fix ordering of location/cause in CAUSE_IE ...................................................................... gsm480_tx_release_compl(): Fix ordering of location/cause in CAUSE_IE Change-Id: Ie01ffc3fe2752d82a7d2b3d213d6012ef1c9b4ec --- M src/host/layer23/src/mobile/gsm480_ss.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/79/14879/1 diff --git a/src/host/layer23/src/mobile/gsm480_ss.c b/src/host/layer23/src/mobile/gsm480_ss.c index b114aa6..3d9cef1 100644 --- a/src/host/layer23/src/mobile/gsm480_ss.c +++ b/src/host/layer23/src/mobile/gsm480_ss.c @@ -401,8 +401,8 @@ uint8_t *tlv = msgb_put(msg, 4); tlv[0] = GSM48_IE_CAUSE; tlv[1] = 2; - tlv[2] = 0x80 | cause; - tlv[3] = 0x80 | GSM48_CAUSE_LOC_USER; + tlv[2] = 0x80 | GSM48_CAUSE_LOC_USER; + tlv[3] = 0x80 | cause; } return gsm480_to_mm(msg, trans, GSM48_MMSS_DATA_REQ); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie01ffc3fe2752d82a7d2b3d213d6012ef1c9b4ec Gerrit-Change-Number: 14879 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:48:43 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:48:43 +0000 Subject: Change in ...osmocom-bb[master]: mobile: Fix encoding of cause in gsm480_tx_release_compl() In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14853 ) Change subject: mobile: Fix encoding of cause in gsm480_tx_release_compl() ...................................................................... mobile: Fix encoding of cause in gsm480_tx_release_compl() Change-Id: Iba2ace7d82be5677d28b25f60ab0312fed76f5e5 Closes: CID#198577, CID#198576, CID#198575 --- M src/host/layer23/src/mobile/gsm480_ss.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm480_ss.c b/src/host/layer23/src/mobile/gsm480_ss.c index edc9c97..b114aa6 100644 --- a/src/host/layer23/src/mobile/gsm480_ss.c +++ b/src/host/layer23/src/mobile/gsm480_ss.c @@ -399,10 +399,10 @@ if (cause) { uint8_t *tlv = msgb_put(msg, 4); - *tlv = GSM48_IE_CAUSE; - *tlv = 2; - *tlv = 0x80 | cause; - *tlv = 0x80 | GSM48_CAUSE_LOC_USER; + tlv[0] = GSM48_IE_CAUSE; + tlv[1] = 2; + tlv[2] = 0x80 | cause; + tlv[3] = 0x80 | GSM48_CAUSE_LOC_USER; } return gsm480_to_mm(msg, trans, GSM48_MMSS_DATA_REQ); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14853 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iba2ace7d82be5677d28b25f60ab0312fed76f5e5 Gerrit-Change-Number: 14853 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:50:39 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:50:39 +0000 Subject: Change in ...osmocom-bb[master]: gsm411_sms.c: Handle negative return of gsm340_gen_oa() Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14880 Change subject: gsm411_sms.c: Handle negative return of gsm340_gen_oa() ...................................................................... gsm411_sms.c: Handle negative return of gsm340_gen_oa() Change-Id: I36f56e1fbd72d9b31350dc2f8a53e763f79f4c08 Closes: CID#198533 --- M src/host/layer23/src/mobile/gsm411_sms.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/80/14880/1 diff --git a/src/host/layer23/src/mobile/gsm411_sms.c b/src/host/layer23/src/mobile/gsm411_sms.c index 08df0f2..45decfd 100644 --- a/src/host/layer23/src/mobile/gsm411_sms.c +++ b/src/host/layer23/src/mobile/gsm411_sms.c @@ -579,6 +579,9 @@ sms->address + 1); else da_len = gsm340_gen_oa(da, sizeof(da), 0x0, 0x1, sms->address); + if (da_len < 0) + return da_len; + smsp = msgb_put(msg, da_len); memcpy(smsp, da, da_len); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14880 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I36f56e1fbd72d9b31350dc2f8a53e763f79f4c08 Gerrit-Change-Number: 14880 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:52:17 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 10:52:17 +0000 Subject: Change in ...osmo-bts[master]: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14877 ) Change subject: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14877/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14877/1/src/osmo-bts-trx/scheduler_trx.c at 1331 PS1, Line 1331: rc Does it make sense to pass 0 here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If49ca6926c576a2b17507b6a95b6f3ca17877d66 Gerrit-Change-Number: 14877 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 10:52:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:53:46 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:53:46 +0000 Subject: Change in ...osmocom-bb[master]: virt_phy: Fix hexdump of L1CTL SIM REQ in l1ctl_rx_sim_req() Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14881 Change subject: virt_phy: Fix hexdump of L1CTL SIM REQ in l1ctl_rx_sim_req() ...................................................................... virt_phy: Fix hexdump of L1CTL SIM REQ in l1ctl_rx_sim_req() Change-Id: I74e07e2c97bfe5d6e9c6e848ebce58ced1b197aa Closes: CID#198538 --- M src/host/virt_phy/src/l1ctl_sap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/81/14881/1 diff --git a/src/host/virt_phy/src/l1ctl_sap.c b/src/host/virt_phy/src/l1ctl_sap.c index 8944398..f95a4ca 100644 --- a/src/host/virt_phy/src/l1ctl_sap.c +++ b/src/host/virt_phy/src/l1ctl_sap.c @@ -539,7 +539,7 @@ uint8_t *data = msg->data + sizeof(struct l1ctl_hdr); LOGPMS(DL1C, LOGL_ERROR, ms, "Rx SIM Request (length: %u, data: %s): UNSUPPORTED\n", - len, osmo_hexdump(data, sizeof(data))); + len, osmo_hexdump(data, len)); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14881 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I74e07e2c97bfe5d6e9c6e848ebce58ced1b197aa Gerrit-Change-Number: 14881 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:56:19 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 10:56:19 +0000 Subject: Change in ...osmocom-bb[master]: gsm411_sms.c: Handle negative return of gsm340_gen_oa() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14880 ) Change subject: gsm411_sms.c: Handle negative return of gsm340_gen_oa() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14880/1/src/host/layer23/src/mobile/gsm411_sms.c File src/host/layer23/src/mobile/gsm411_sms.c: https://gerrit.osmocom.org/#/c/14880/1/src/host/layer23/src/mobile/gsm411_sms.c at 603 PS1, Line 603: exit(0); WOW! -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14880 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I36f56e1fbd72d9b31350dc2f8a53e763f79f4c08 Gerrit-Change-Number: 14880 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 10:56:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:57:14 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 10:57:14 +0000 Subject: Change in ...osmocom-bb[master]: gsm480_tx_release_compl(): Fix ordering of location/cause in CAUSE_IE In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14879 ) Change subject: gsm480_tx_release_compl(): Fix ordering of location/cause in CAUSE_IE ...................................................................... Patch Set 1: https://gerrit.osmocom.org/#/c/osmocom-bb/+/14860/2 :/ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie01ffc3fe2752d82a7d2b3d213d6012ef1c9b4ec Gerrit-Change-Number: 14879 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 10:57:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:58:14 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 10:58:14 +0000 Subject: Change in ...osmocom-bb[master]: virt_phy: Fix hexdump of L1CTL SIM REQ in l1ctl_rx_sim_req() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14881 ) Change subject: virt_phy: Fix hexdump of L1CTL SIM REQ in l1ctl_rx_sim_req() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14881 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I74e07e2c97bfe5d6e9c6e848ebce58ced1b197aa Gerrit-Change-Number: 14881 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 10:58:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:59:30 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:59:30 +0000 Subject: Change in ...osmocom-bb[master]: mobile/gsm480_ss.c: gsm480_tx_release_compl(): fix cause IE encoding In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14860 ) Change subject: mobile/gsm480_ss.c: gsm480_tx_release_compl(): fix cause IE encoding ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14860 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic6abcfb9a9589f5b0c9c40def863f15ae04d0bdd Gerrit-Change-Number: 14860 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 10:59:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 10:59:52 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 10:59:52 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Add missing check for fstat() return value In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14854 ) Change subject: osmocon: Add missing check for fstat() return value ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14854 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibef6ee00eb41e16d2ef52931f8c22562090cd1ee Gerrit-Change-Number: 14854 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 10:59:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:00:01 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 11:00:01 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Check write() return code In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14855 ) Change subject: osmocon: Check write() return code ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14855 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I61d8f104a4d2558fd5b6fb34c7f2fd6c13354c12 Gerrit-Change-Number: 14855 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 11:00:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:00:04 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 11:00:04 +0000 Subject: Change in ...osmocom-bb[master]: virtphy: Handle strtok() returning NULL on first call In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14856 ) Change subject: virtphy: Handle strtok() returning NULL on first call ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14856 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I37bfb91cf75982bfa2f75bd62d0c13859268cd93 Gerrit-Change-Number: 14856 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 11:00:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:00:07 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 11:00:07 +0000 Subject: Change in ...osmocom-bb[master]: gsm480_tx_release_compl(): Fix ordering of location/cause in CAUSE_IE In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14879 ) Change subject: gsm480_tx_release_compl(): Fix ordering of location/cause in CAUSE_IE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie01ffc3fe2752d82a7d2b3d213d6012ef1c9b4ec Gerrit-Change-Number: 14879 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 11:00:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:00:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 11:00:16 +0000 Subject: Change in ...osmocom-bb[master]: gsm480_tx_release_compl(): Fix ordering of location/cause in CAUSE_IE In-Reply-To: References: Message-ID: laforge has removed a vote on this change. Change subject: gsm480_tx_release_compl(): Fix ordering of location/cause in CAUSE_IE ...................................................................... Removed Code-Review+2 by laforge -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie01ffc3fe2752d82a7d2b3d213d6012ef1c9b4ec Gerrit-Change-Number: 14879 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:00:20 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 11:00:20 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Check write() return code In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14855 ) Change subject: osmocon: Check write() return code ...................................................................... osmocon: Check write() return code Change-Id: I61d8f104a4d2558fd5b6fb34c7f2fd6c13354c12 Closes: CID#198567 --- M src/host/osmocon/osmocon.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c index 61672a3..f4d9111 100644 --- a/src/host/osmocon/osmocon.c +++ b/src/host/osmocon/osmocon.c @@ -630,6 +630,7 @@ case MODE_C140xor: case MODE_C123xor: rc = write(dnload.serial_fd.fd, &xor_init, 1); + OSMO_ASSERT(rc == 1); break; default: break; @@ -652,6 +653,7 @@ perror("Error during write"); return rc; } + OSMO_ASSERT(rc == write_len); dnload.write_ptr += rc; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14855 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I61d8f104a4d2558fd5b6fb34c7f2fd6c13354c12 Gerrit-Change-Number: 14855 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:00:21 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 11:00:21 +0000 Subject: Change in ...osmocom-bb[master]: virtphy: Handle strtok() returning NULL on first call In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14856 ) Change subject: virtphy: Handle strtok() returning NULL on first call ...................................................................... virtphy: Handle strtok() returning NULL on first call Change-Id: I37bfb91cf75982bfa2f75bd62d0c13859268cd93 Closes: CID#198565 --- M src/host/virt_phy/src/virtphy.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/virt_phy/src/virtphy.c b/src/host/virt_phy/src/virtphy.c index 118e8a1..d0a2ddb 100644 --- a/src/host/virt_phy/src/virtphy.c +++ b/src/host/virt_phy/src/virtphy.c @@ -153,6 +153,8 @@ return; char *token = strtok(arfcn_sig_lev_red_mask, ":"); + if (!token) + return; do { char* colon = strstr(token, ","); uint16_t arfcn; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14856 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I37bfb91cf75982bfa2f75bd62d0c13859268cd93 Gerrit-Change-Number: 14856 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:00:19 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 11:00:19 +0000 Subject: Change in ...osmocom-bb[master]: osmocon: Add missing check for fstat() return value In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14854 ) Change subject: osmocon: Add missing check for fstat() return value ...................................................................... osmocon: Add missing check for fstat() return value Change-Id: Ibef6ee00eb41e16d2ef52931f8c22562090cd1ee Closes: CID#198570 --- M src/host/osmocon/osmocon.c 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c index 1bb0bb7..61672a3 100644 --- a/src/host/osmocon/osmocon.c +++ b/src/host/osmocon/osmocon.c @@ -287,6 +287,11 @@ } rc = fstat(fd, &st); + if (rc < 0) { + perror("fstat"); + close(fd); + return -EIO; + } if ((st.st_size > MAX_DNLOAD_SIZE) && (dnload.mode != MODE_ROMLOAD)) { fprintf(stderr, "The maximum file size is 64kBytes (%u bytes)\n", MAX_DNLOAD_SIZE); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14854 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibef6ee00eb41e16d2ef52931f8c22562090cd1ee Gerrit-Change-Number: 14854 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:00:44 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 11:00:44 +0000 Subject: Change in ...osmocom-bb[master]: mobile/gsm480_ss.c: gsm480_tx_release_compl(): fix cause IE encoding In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14860 ) Change subject: mobile/gsm480_ss.c: gsm480_tx_release_compl(): fix cause IE encoding ...................................................................... mobile/gsm480_ss.c: gsm480_tx_release_compl(): fix cause IE encoding According to GSM TS 04.08, section 10.5.4.11, location and coding standard are encoded before the cause value, not vice-versa! Also, coding standards other than "1 1 - Standard defined for the GSM PLMNs" shall not be used if the cause can be represented with the GSM standardized coding. Change-Id: Ic6abcfb9a9589f5b0c9c40def863f15ae04d0bdd --- M src/host/layer23/src/mobile/gsm480_ss.c 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm480_ss.c b/src/host/layer23/src/mobile/gsm480_ss.c index b114aa6..52e43b9 100644 --- a/src/host/layer23/src/mobile/gsm480_ss.c +++ b/src/host/layer23/src/mobile/gsm480_ss.c @@ -397,12 +397,17 @@ gh->proto_discr = GSM48_PDISC_NC_SS | (trans->transaction_id << 4); gh->msg_type = GSM0480_MTYPE_RELEASE_COMPLETE; + /* GSM 04.08, section 10.5.4.11 */ if (cause) { uint8_t *tlv = msgb_put(msg, 4); tlv[0] = GSM48_IE_CAUSE; tlv[1] = 2; - tlv[2] = 0x80 | cause; - tlv[3] = 0x80 | GSM48_CAUSE_LOC_USER; + + /* Coding standard defined for the GSM PLMNs, + * location - USER, cause as given by caller, + * no extension, no diagnostics. */ + tlv[2] = (1 << 7) | (0x03 << 5) | (GSM48_CAUSE_LOC_USER & 0x0f); + tlv[3] = (1 << 7) | cause; } return gsm480_to_mm(msg, trans, GSM48_MMSS_DATA_REQ); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14860 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic6abcfb9a9589f5b0c9c40def863f15ae04d0bdd Gerrit-Change-Number: 14860 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:01:18 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 11:01:18 +0000 Subject: Change in ...osmocom-bb[master]: gsm480_tx_release_compl(): Fix ordering of location/cause in CAUSE_IE In-Reply-To: References: Message-ID: laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14879 ) Change subject: gsm480_tx_release_compl(): Fix ordering of location/cause in CAUSE_IE ...................................................................... Abandoned duplicate of 14860 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie01ffc3fe2752d82a7d2b3d213d6012ef1c9b4ec Gerrit-Change-Number: 14879 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:02:03 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 11:02:03 +0000 Subject: Change in ...osmo-bts[master]: pcu_sock: Don't discard fractional part of link_quality In-Reply-To: References: Message-ID: laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14873 ) Change subject: pcu_sock: Don't discard fractional part of link_quality ...................................................................... Abandoned This problem is going to be addressed by https://gerrit.osmocom.org/#/c/osmo-bts/+/14686/. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3b9d00d5314f53d4f51e464400fc3e97858adb57 Gerrit-Change-Number: 14873 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:02:08 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 11:02:08 +0000 Subject: Change in ...osmo-bts[master]: l1sap: Don't discard fractional part of link_quality In-Reply-To: References: Message-ID: laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14874 ) Change subject: l1sap: Don't discard fractional part of link_quality ...................................................................... Abandoned This problem is going to be addressed by https://gerrit.osmocom.org/#/c/osmo-bts/+/14686/. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1c365cf2b46fc8c5922e4e32fcc55d1f03b1e935 Gerrit-Change-Number: 14874 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:03:01 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 11:03:01 +0000 Subject: Change in ...osmo-bts[master]: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14877 ) Change subject: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14877/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14877/1/src/osmo-bts-trx/scheduler_trx.c at 1331 PS1, Line 1331: rc > Does it make sense to pass 0 here? yes, I think it still makes sense to set the marker for a non-SID frame, as hr_check_sid() would determine that a zero-length frame cannot be a SID frame. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If49ca6926c576a2b17507b6a95b6f3ca17877d66 Gerrit-Change-Number: 14877 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 11:03:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:05:45 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 11:05:45 +0000 Subject: Change in ...osmo-bts[master]: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14877 ) Change subject: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If49ca6926c576a2b17507b6a95b6f3ca17877d66 Gerrit-Change-Number: 14877 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 11:05:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:11:59 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 11:11:59 +0000 Subject: Change in ...osmo-bts[master]: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14877 ) Change subject: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode() ...................................................................... Patch Set 1: Then the code near gsm0503_tch_fr_decode() also needs to be fixed: rc = gsm0503_tch_fr_decode(tch_data, *bursts_p, 1, 0, &n_errors, &n_bits_total); if (rc >= 0) ... Let me know if you can do this, or should I fix this. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If49ca6926c576a2b17507b6a95b6f3ca17877d66 Gerrit-Change-Number: 14877 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 11:11:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:16:23 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 11:16:23 +0000 Subject: Change in ...osmo-bts[master]: scheduler_trx: Deal with osmo_amr_rtp_enc() returning negative In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14876 ) Change subject: scheduler_trx: Deal with osmo_amr_rtp_enc() returning negative ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/14876/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/#/c/14876/1/src/osmo-bts-trx/scheduler_trx.c at 1241 PS1, Line 1241: tch_data This change solves the problem of passing a negative number to memset(). But accessing uninitialized memory is still possible. Just an idea for follow-up changes. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14876 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I70ce98c5697b9ce6fac7ab57a5d70f3201db29d9 Gerrit-Change-Number: 14876 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 11:16:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:18:33 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 11:18:33 +0000 Subject: Change in ...osmo-trx[master]: ChannelizerBase: fix initialization of class members In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14865 ) Change subject: ChannelizerBase: fix initialization of class members ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8c047c8f98e928a62dca1d7b8c003502727c086e Gerrit-Change-Number: 14865 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 11:18:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:19:25 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 11:19:25 +0000 Subject: Change in ...osmo-trx[master]: CorrelationSequence: fix initialization of class members In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14866 ) Change subject: CorrelationSequence: fix initialization of class members ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia72395f8805e9e2cd700ad1e559a8aa62124aaec Gerrit-Change-Number: 14866 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 11:19:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 11:19:52 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 11:19:52 +0000 Subject: Change in ...osmo-trx[master]: radioInterface.cpp: Fix missing member initialization of RadioInterfa... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14872 ) Change subject: radioInterface.cpp: Fix missing member initialization of RadioInterface() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14872 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7264ef35dbe6d3522858eae5b47d150aa1ffe334 Gerrit-Change-Number: 14872 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Sun, 21 Jul 2019 11:19:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Sun Jul 21 11:44:16 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 21 Jul 2019 11:44:16 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d345027952b7_d3a6545f05346bd@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 517s] tmsi |= GSM23003_TMSI_SGSN_MASK; [ 517s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 517s] vlr.c:339:12: note: each undeclared identifier is reported only once for each function it appears in [ 517s] Makefile:442: recipe for target 'vlr.o' failed [ 517s] make[4]: *** [vlr.o] Error 1 [ 517s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/libvlr' [ 517s] Makefile:422: recipe for target 'all-recursive' failed [ 517s] make[3]: *** [all-recursive] Error 1 [ 517s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 517s] Makefile:462: recipe for target 'all-recursive' failed [ 517s] make[2]: *** [all-recursive] Error 1 [ 517s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 517s] Makefile:394: recipe for target 'all' failed [ 517s] make[1]: *** [all] Error 2 [ 517s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 517s] dh_auto_build: make -j1 returned exit code 2 [ 517s] debian/rules:45: recipe for target 'build' failed [ 517s] make: *** [build] Error 2 [ 517s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 517s] [ 517s] armbuild02 failed "build osmo-msc_1.3.1.180.efa7.dsc" at Sun Jul 21 11:44:08 UTC 2019. [ 517s] [ 517s] ### VM INTERACTION START ### [ 520s] [ 485.419471] sysrq: SysRq : Power Off [ 520s] [ 485.453120] reboot: Power down [ 520s] ### VM INTERACTION END ### [ 521s] [ 521s] armbuild02 failed "build osmo-msc_1.3.1.180.efa7.dsc" at Sun Jul 21 11:44:11 UTC 2019. [ 521s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 21 11:55:41 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 21 Jul 2019 11:55:41 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l In-Reply-To: References: Message-ID: <5d3452da2c464_d3a6545f0538070@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 527s] bss_ptmsi = bss_ptmsi | GSM23003_TMSI_SGSN_MASK; [ 527s] ^~~~~~~~~~~~~~~~~~~~~~~ [ 527s] gb_proxy.c:246:28: note: each undeclared identifier is reported only once for each function it appears in [ 527s] Makefile:615: recipe for target 'gb_proxy.o' failed [ 527s] make[4]: *** [gb_proxy.o] Error 1 [ 527s] make[4]: Leaving directory '/usr/src/packages/BUILD/src/gprs' [ 527s] Makefile:391: recipe for target 'all-recursive' failed [ 527s] make[3]: *** [all-recursive] Error 1 [ 527s] make[3]: Leaving directory '/usr/src/packages/BUILD/src' [ 527s] Makefile:453: recipe for target 'all-recursive' failed [ 527s] make[2]: *** [all-recursive] Error 1 [ 527s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 527s] Makefile:385: recipe for target 'all' failed [ 527s] make[1]: *** [all] Error 2 [ 527s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 527s] dh_auto_build: make -j1 returned exit code 2 [ 527s] debian/rules:45: recipe for target 'build' failed [ 527s] make: *** [build] Error 2 [ 527s] dpkg-buildpackage: error: debian/rules build gave error exit status 2 [ 527s] [ 527s] armbuild02 failed "build osmo-sgsn_1.4.0.30.4b8e.dsc" at Sun Jul 21 11:55:34 UTC 2019. [ 527s] [ 527s] ### VM INTERACTION START ### [ 530s] [ 489.800805] sysrq: SysRq : Power Off [ 530s] [ 489.833790] reboot: Power down [ 531s] ### VM INTERACTION END ### [ 531s] [ 531s] armbuild02 failed "build osmo-sgsn_1.4.0.30.4b8e.dsc" at Sun Jul 21 11:55:38 UTC 2019. [ 531s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Sun Jul 21 13:43:08 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 13:43:08 +0000 Subject: Change in ...osmo-bts[master]: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14877 ) Change subject: scheduler_trx: Handle negative return of gsm0503_tch_hr_decode() ...................................................................... Patch Set 1: > Let me know if you can do this, or should I fix this. feel freeo to take over, thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If49ca6926c576a2b17507b6a95b6f3ca17877d66 Gerrit-Change-Number: 14877 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 13:43:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 13:43:18 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 13:43:18 +0000 Subject: Change in ...osmocom-bb[master]: virt_phy: Fix hexdump of L1CTL SIM REQ in l1ctl_rx_sim_req() In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14881 ) Change subject: virt_phy: Fix hexdump of L1CTL SIM REQ in l1ctl_rx_sim_req() ...................................................................... virt_phy: Fix hexdump of L1CTL SIM REQ in l1ctl_rx_sim_req() Change-Id: I74e07e2c97bfe5d6e9c6e848ebce58ced1b197aa Closes: CID#198538 --- M src/host/virt_phy/src/l1ctl_sap.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/virt_phy/src/l1ctl_sap.c b/src/host/virt_phy/src/l1ctl_sap.c index 8944398..f95a4ca 100644 --- a/src/host/virt_phy/src/l1ctl_sap.c +++ b/src/host/virt_phy/src/l1ctl_sap.c @@ -539,7 +539,7 @@ uint8_t *data = msg->data + sizeof(struct l1ctl_hdr); LOGPMS(DL1C, LOGL_ERROR, ms, "Rx SIM Request (length: %u, data: %s): UNSUPPORTED\n", - len, osmo_hexdump(data, sizeof(data))); + len, osmo_hexdump(data, len)); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14881 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I74e07e2c97bfe5d6e9c6e848ebce58ced1b197aa Gerrit-Change-Number: 14881 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 13:43:31 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 13:43:31 +0000 Subject: Change in ...libosmo-abis[master]: ipaccess.c: Avoid calling close(-1) on error path In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14870 ) Change subject: ipaccess.c: Avoid calling close(-1) on error path ...................................................................... ipaccess.c: Avoid calling close(-1) on error path Change-Id: Idabb9805a4a10c95ba0e01bc3f80ed8db87a9f85 Closes: CID#157118 --- M src/input/ipaccess.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index fb6ad10..474bfb4 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -215,8 +215,10 @@ return 0; err: osmo_fd_unregister(bfd); - close(bfd->fd); - bfd->fd = -1; + if (bfd->fd != -1) { + close(bfd->fd); + bfd->fd = -1; + } e1inp_line_put(line); return -1; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14870 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Idabb9805a4a10c95ba0e01bc3f80ed8db87a9f85 Gerrit-Change-Number: 14870 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 13:44:40 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 13:44:40 +0000 Subject: Change in ...libosmocore[master]: gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14861 ) Change subject: gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14861/1/src/gsm/gsm0480.c File src/gsm/gsm0480.c: https://gerrit.osmocom.org/#/c/14861/1/src/gsm/gsm0480.c at 396 PS1, Line 396: LOGP(DLGLOBAL, LOGL_ERROR, "SS Release Complete\n"); this doesn't look like an error? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14861 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id38272ff93fae6d2fdf39df4ffc74856d6c9a898 Gerrit-Change-Number: 14861 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 13:44:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 13:51:55 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 13:51:55 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 ) Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 21 Jul 2019 13:51:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 13:51:57 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 13:51:57 +0000 Subject: Change in ...osmo-bts[master]: Clarify and refactor link quality (C/I) handling In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14686 ) Change subject: Clarify and refactor link quality (C/I) handling ...................................................................... Clarify and refactor link quality (C/I) handling The radio link quality is defined by C/I (Carrier-to-Interference ratio), which is computed from the training sequence of each received burst, by comparing the "ideal" training sequence with the actual (received) one. Link quality measurements are used by L1SAP to filter out "ghost" Access Bursts, and by the link quality adaptation algorithms. One can define minimum link quality values using the VTY interface. On the VTY interface we expect integer C/I values in centiBels (cB, 10e-2 B), while the internal structures are using float values in deciBels (dB, 10e-1 B). Some PHYs (sysmo, octphy, oc2g, and litecell15) expose C/I measurements in deciBels, while on the L1SAP interface we finally send then in centiBels. Let's avoid this confusion and stick to a single format, that will be used by the internal logic of OsmoBTS - integer values (int16_t) in centiBels. This will give us the range of: -32768 .. 32767 centiBels, or -3276.8 .. 3276.7 deciBels, which is certainly sufficient. Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 --- M doc/manuals/vty/bts_vty_reference.xml M include/osmo-bts/gsm_data_shared.h M src/common/bts.c M src/common/l1sap.c M src/common/pcu_sock.c M src/common/vty.c M src/osmo-bts-litecell15/l1_if.c M src/osmo-bts-oc2g/l1_if.c M src/osmo-bts-sysmo/l1_if.c 9 files changed, 22 insertions(+), 22 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/doc/manuals/vty/bts_vty_reference.xml b/doc/manuals/vty/bts_vty_reference.xml index b50ac1b..4697ee7 100644 --- a/doc/manuals/vty/bts_vty_reference.xml +++ b/doc/manuals/vty/bts_vty_reference.xml @@ -1613,14 +1613,14 @@ - - + + - - + + diff --git a/include/osmo-bts/gsm_data_shared.h b/include/osmo-bts/gsm_data_shared.h index a4e326a..dd2a14c 100644 --- a/include/osmo-bts/gsm_data_shared.h +++ b/include/osmo-bts/gsm_data_shared.h @@ -759,8 +759,8 @@ int smscb_queue_max_len; /* maximum queue length */ int smscb_queue_hyst; /* hysteresis for CBCH laod indications */ - float min_qual_rach; /* minimum quality for RACH bursts */ - float min_qual_norm; /* minimum quality for normal daata */ + int16_t min_qual_rach; /* minimum link quality (in centiBels) for Access Bursts */ + int16_t min_qual_norm; /* minimum link quality (in centiBels) for Normal Bursts */ uint16_t max_ber10k_rach; /* Maximum permitted RACH BER in 0.01% */ struct { diff --git a/src/common/bts.c b/src/common/bts.c index f582ebd..5c415e8 100644 --- a/src/common/bts.c +++ b/src/common/bts.c @@ -51,8 +51,8 @@ #include #include -#define MIN_QUAL_RACH 5.0f /* at least 5 dB C/I */ -#define MIN_QUAL_NORM -0.5f /* at least -1 dB C/I */ +#define MIN_QUAL_RACH 50 /* minimum link quality (in centiBels) for Access Bursts */ +#define MIN_QUAL_NORM -5 /* minimum link quality (in centiBels) for Normal Bursts */ static void bts_update_agch_max_queue_length(struct gsm_bts *bts); diff --git a/src/common/l1sap.c b/src/common/l1sap.c index b730b85..79af8e2 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1218,7 +1218,7 @@ * the content is not available due to decoding issues. Content not * available is expected as empty payload. We also check if quality is * good enough. */ - if (msg->len && tch_ind->lqual_cb / 10 >= bts->min_qual_norm) { + if (msg->len && tch_ind->lqual_cb >= bts->min_qual_norm) { /* hand msg to RTP code for transmission */ if (lchan->abis_ip.rtp_socket) osmo_rtp_send_frame_ext(lchan->abis_ip.rtp_socket, diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index 1d9fa72..36cc6ed 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -330,8 +330,8 @@ LOGP(DPCU, LOGL_DEBUG, "Sending data indication: sapi=%s arfcn=%d block=%d data=%s\n", sapi_string[sapi], arfcn, block_nr, osmo_hexdump(data, len)); - if (lqual / 10 < bts->min_qual_norm) { - LOGP(DPCU, LOGL_DEBUG, "Link quality %"PRId16" is below threshold %f, dropping packet\n", + if (lqual < bts->min_qual_norm) { + LOGP(DPCU, LOGL_DEBUG, "Link quality %"PRId16" is below threshold %d, dropping packet\n", lqual, bts->min_qual_norm); return 0; } diff --git a/src/common/vty.c b/src/common/vty.c index f4fc181..e4f5a16 100644 --- a/src/common/vty.c +++ b/src/common/vty.c @@ -300,9 +300,9 @@ sapi_buf = osmo_str_tolower(get_value_string(gsmtap_sapi_names, GSMTAP_CHANNEL_ACCH)); vty_out(vty, " gsmtap-sapi %s%s", sapi_buf, VTY_NEWLINE); } - vty_out(vty, " min-qual-rach %.0f%s", bts->min_qual_rach * 10.0f, + vty_out(vty, " min-qual-rach %d%s", bts->min_qual_rach, VTY_NEWLINE); - vty_out(vty, " min-qual-norm %.0f%s", bts->min_qual_norm * 10.0f, + vty_out(vty, " min-qual-norm %d%s", bts->min_qual_norm, VTY_NEWLINE); vty_out(vty, " max-ber10k-rach %u%s", bts->max_ber10k_rach, VTY_NEWLINE); @@ -618,24 +618,24 @@ DEFUN(cfg_bts_min_qual_rach, cfg_bts_min_qual_rach_cmd, "min-qual-rach <-100-100>", - "Set the minimum quality level of RACH burst to be accpeted\n" - "C/I level in tenth of dB\n") + "Set the minimum link quality level of Access Bursts to be accepted\n" + "C/I (Carrier-to-Interference) ratio in centiBels (10e-2 B or 10e-1 dB)\n") { struct gsm_bts *bts = vty->index; - bts->min_qual_rach = strtof(argv[0], NULL) / 10.0f; + bts->min_qual_rach = atoi(argv[0]); return CMD_SUCCESS; } DEFUN(cfg_bts_min_qual_norm, cfg_bts_min_qual_norm_cmd, "min-qual-norm <-100-100>", - "Set the minimum quality level of normal burst to be accpeted\n" - "C/I level in tenth of dB\n") + "Set the minimum link quality level of Normal Bursts to be accepted\n" + "C/I (Carrier-to-Interference) ratio in centiBels (10e-2 B or 10e-1 dB)\n") { struct gsm_bts *bts = vty->index; - bts->min_qual_norm = strtof(argv[0], NULL) / 10.0f; + bts->min_qual_norm = atoi(argv[0]); return CMD_SUCCESS; } diff --git a/src/osmo-bts-litecell15/l1_if.c b/src/osmo-bts-litecell15/l1_if.c index 3710fa8..77b72bd 100644 --- a/src/osmo-bts-litecell15/l1_if.c +++ b/src/osmo-bts-litecell15/l1_if.c @@ -1004,7 +1004,7 @@ struct ph_rach_ind_param rach_ind_param; /* FIXME: this should be deprecated/obsoleted as it bypasses rach.busy counting */ - if (ra_ind->measParam.fLinkQuality < bts->min_qual_rach) { + if (ra_ind->measParam.fLinkQuality * 10 < bts->min_qual_rach) { msgb_free(l1p_msg); return 0; } diff --git a/src/osmo-bts-oc2g/l1_if.c b/src/osmo-bts-oc2g/l1_if.c index d9c8da0..9affc89 100644 --- a/src/osmo-bts-oc2g/l1_if.c +++ b/src/osmo-bts-oc2g/l1_if.c @@ -1060,7 +1060,7 @@ struct ph_rach_ind_param rach_ind_param; /* FIXME: this should be deprecated/obsoleted as it bypasses rach.busy counting */ - if (ra_ind->measParam.fLinkQuality < bts->min_qual_rach) { + if (ra_ind->measParam.fLinkQuality * 10 < bts->min_qual_rach) { msgb_free(l1p_msg); return 0; } diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c index c431e49..58fc24e 100644 --- a/src/osmo-bts-sysmo/l1_if.c +++ b/src/osmo-bts-sysmo/l1_if.c @@ -998,7 +998,7 @@ struct ph_rach_ind_param rach_ind_param; /* FIXME: this should be deprecated/obsoleted as it bypasses rach.busy counting */ - if (ra_ind->measParam.fLinkQuality < bts->min_qual_rach) { + if (ra_ind->measParam.fLinkQuality * 10 < bts->min_qual_rach) { msgb_free(l1p_msg); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If624d6fdc0270e6813af8700d95f1345903c8a01 Gerrit-Change-Number: 14686 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: ipse Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 14:04:57 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 14:04:57 +0000 Subject: Change in ...libosmocore[master]: gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14861 ) Change subject: gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14861/1/src/gsm/gsm0480.c File src/gsm/gsm0480.c: https://gerrit.osmocom.org/#/c/14861/1/src/gsm/gsm0480.c at 396 PS1, Line 396: LOGP(DLGLOBAL, LOGL_ERROR, "SS Release Complete\n"); > this doesn't look like an error? ACK. I am not sure if we need this debug print at all... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14861 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id38272ff93fae6d2fdf39df4ffc74856d6c9a898 Gerrit-Change-Number: 14861 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 14:04:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 14:59:21 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 14:59:21 +0000 Subject: Change in ...libosmocore[master]: gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14861 to look at the new patch set (#2). Change subject: gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging ...................................................................... gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging Change-Id: Id38272ff93fae6d2fdf39df4ffc74856d6c9a898 --- M src/gsm/gsm0480.c 1 file changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/14861/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14861 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id38272ff93fae6d2fdf39df4ffc74856d6c9a898 Gerrit-Change-Number: 14861 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 14:59:25 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 14:59:25 +0000 Subject: Change in ...libosmocore[master]: gsm/gsm0480.c: parse_ss(): drop needless debug print Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14882 Change subject: gsm/gsm0480.c: parse_ss(): drop needless debug print ...................................................................... gsm/gsm0480.c: parse_ss(): drop needless debug print Change-Id: Ie18c291d0cfe3b246d09ac6cfd9591951a2984c8 --- M src/gsm/gsm0480.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/82/14882/1 diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c index 9f546cc..66a22b6 100644 --- a/src/gsm/gsm0480.c +++ b/src/gsm/gsm0480.c @@ -393,8 +393,6 @@ /* Table 2.1: Messages for call independent SS control */ switch (msg_type) { case GSM0480_MTYPE_RELEASE_COMPLETE: - LOGP(0, LOGL_DEBUG, "SS Release Complete\n"); - /** * Indicates that there is no decoded message. * To be overwriten by the message otherwise. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14882 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie18c291d0cfe3b246d09ac6cfd9591951a2984c8 Gerrit-Change-Number: 14882 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:14:45 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 15:14:45 +0000 Subject: Change in ...osmo-bts[master]: Move Access Burst link quality handling to L1SAP In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14687 ) Change subject: Move Access Burst link quality handling to L1SAP ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Gerrit-Change-Number: 14687 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 21 Jul 2019 15:14:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:16:08 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 15:16:08 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14689 ) Change subject: osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea0dad65e9bc511f99375fd3ee2eb44e47a6168f Gerrit-Change-Number: 14689 Gerrit-PatchSet: 9 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 21 Jul 2019 15:16:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:16:22 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 15:16:22 +0000 Subject: Change in ...osmo-bts[master]: Move Access Burst link quality handling to L1SAP In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14687 ) Change subject: Move Access Burst link quality handling to L1SAP ...................................................................... Move Access Burst link quality handling to L1SAP Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Depends: (libosmocore) Ie2a66ebd040b61d6daf49e04bf8a84d3d64764ee --- M src/common/l1sap.c M src/osmo-bts-litecell15/l1_if.c M src/osmo-bts-oc2g/l1_if.c M src/osmo-bts-sysmo/l1_if.c M src/osmo-bts-trx/scheduler_trx.c M tests/handover/handover_test.c 6 files changed, 19 insertions(+), 21 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 79af8e2..f07e79c 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1272,6 +1272,14 @@ return false; } + /* Link quality defined by C/I (Carrier-to-Interference ratio) */ + if (rach_ind->lqual_cb < bts->min_qual_rach) { + LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring RACH request: " + "link quality (%d) below the minimum (%d)\n", + rach_ind->lqual_cb, bts->min_qual_rach); + return false; + } + return true; } diff --git a/src/osmo-bts-litecell15/l1_if.c b/src/osmo-bts-litecell15/l1_if.c index 77b72bd..2ac0b7a 100644 --- a/src/osmo-bts-litecell15/l1_if.c +++ b/src/osmo-bts-litecell15/l1_if.c @@ -997,18 +997,11 @@ struct msgb *l1p_msg) { struct gsm_bts_trx *trx = lc15l1_hdl_trx(fl1); - struct gsm_bts *bts = trx->bts; struct gsm_lchan *lchan; struct osmo_phsap_prim *l1sap; int rc; struct ph_rach_ind_param rach_ind_param; - /* FIXME: this should be deprecated/obsoleted as it bypasses rach.busy counting */ - if (ra_ind->measParam.fLinkQuality * 10 < bts->min_qual_rach) { - msgb_free(l1p_msg); - return 0; - } - dump_meas_res(LOGL_DEBUG, &ra_ind->measParam); if ((ra_ind->msgUnitParam.u8Size != 1) && @@ -1029,6 +1022,7 @@ .rssi = (int8_t) ra_ind->measParam.fRssi, .ber10k = (unsigned int) (ra_ind->measParam.fBer * 10000.0), .acc_delay_256bits = ra_ind->measParam.i16BurstTiming * 64, + .lqual_cb = (int16_t) ra_ind->measParam.fLinkQuality * 10, /* centiBels */ }; lchan = l1if_hLayer_to_lchan(trx, (uint32_t)ra_ind->hLayer2); diff --git a/src/osmo-bts-oc2g/l1_if.c b/src/osmo-bts-oc2g/l1_if.c index 9affc89..d987bb5 100644 --- a/src/osmo-bts-oc2g/l1_if.c +++ b/src/osmo-bts-oc2g/l1_if.c @@ -1053,18 +1053,11 @@ struct msgb *l1p_msg) { struct gsm_bts_trx *trx = oc2gl1_hdl_trx(fl1); - struct gsm_bts *bts = trx->bts; struct gsm_lchan *lchan; struct osmo_phsap_prim *l1sap; int rc; struct ph_rach_ind_param rach_ind_param; - /* FIXME: this should be deprecated/obsoleted as it bypasses rach.busy counting */ - if (ra_ind->measParam.fLinkQuality * 10 < bts->min_qual_rach) { - msgb_free(l1p_msg); - return 0; - } - dump_meas_res(LOGL_DEBUG, &ra_ind->measParam); if ((ra_ind->msgUnitParam.u8Size != 1) && @@ -1085,6 +1078,7 @@ .rssi = (int8_t) ra_ind->measParam.fRssi, .ber10k = (unsigned int) (ra_ind->measParam.fBer * 10000.0), .acc_delay_256bits = ra_ind->measParam.i16BurstTiming * 64, + .lqual_cb = (int16_t) ra_ind->measParam.fLinkQuality * 10, /* centiBels */ }; lchan = l1if_hLayer_to_lchan(trx, (uint32_t)ra_ind->hLayer2); diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c index 58fc24e..df39e2f 100644 --- a/src/osmo-bts-sysmo/l1_if.c +++ b/src/osmo-bts-sysmo/l1_if.c @@ -991,18 +991,11 @@ struct msgb *l1p_msg) { struct gsm_bts_trx *trx = femtol1_hdl_trx(fl1); - struct gsm_bts *bts = trx->bts; struct gsm_lchan *lchan; struct osmo_phsap_prim *l1sap; int rc; struct ph_rach_ind_param rach_ind_param; - /* FIXME: this should be deprecated/obsoleted as it bypasses rach.busy counting */ - if (ra_ind->measParam.fLinkQuality * 10 < bts->min_qual_rach) { - msgb_free(l1p_msg); - return 0; - } - dump_meas_res(LOGL_DEBUG, &ra_ind->measParam); if ((ra_ind->msgUnitParam.u8Size != 1) && @@ -1024,6 +1017,7 @@ .rssi = (int8_t) ra_ind->measParam.fRssi, .ber10k = (unsigned int) (ra_ind->measParam.fBer * 10000.0), .acc_delay_256bits = ra_ind->measParam.i16BurstTiming * 64, + .lqual_cb = (int16_t) ra_ind->measParam.fLinkQuality * 10, /* centiBels */ }; lchan = l1if_hLayer_to_lchan(trx, ra_ind->hLayer2); diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 79e42e1..ec1d832 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -823,6 +823,12 @@ l1sap.u.rach_ind.rssi = bi->rssi; l1sap.u.rach_ind.fn = bi->fn; + /* Link quality is defined by C/I (Carrier-to-Interference ratio), + * which has optional presence. If it's absent, report the + * minimum acceptable value to pass L1SAP checks. */ + /* TODO: check for TRX_BI_F_CI_CB, and use the value from UL.ind */ + l1sap.u.rach_ind.lqual_cb = l1t->trx->bts->min_qual_rach; + /* Decode RACH depending on its synch. sequence */ switch (synch_seq) { case RACH_SYNCH_SEQ_TS1: diff --git a/tests/handover/handover_test.c b/tests/handover/handover_test.c index a805554..c9799af 100644 --- a/tests/handover/handover_test.c +++ b/tests/handover/handover_test.c @@ -118,6 +118,8 @@ /* send access burst with wrong ref */ memset(&nl1sap, 0, sizeof(nl1sap)); osmo_prim_init(&nl1sap.oph, SAP_GSM_PH, PRIM_PH_RACH, PRIM_OP_INDICATION, NULL); + /* Report the minimum acceptable value to pass L1SAP checks */ + nl1sap.u.rach_ind.lqual_cb = bts->min_qual_rach; nl1sap.u.rach_ind.chan_nr = 0x0a; nl1sap.u.rach_ind.ra = 42; l1sap_up(trx, &nl1sap); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 Gerrit-Change-Number: 14687 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:16:23 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 15:16:23 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14688 ) Change subject: osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP ...................................................................... osmo-bts-trx/scheduler: rx_rach_fn(): provide actual C/I ratio to L1SAP Change-Id: I8d86dec7ebc039cbfd038c4342ff328b11281865 --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index ec1d832..8144956 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -826,8 +826,10 @@ /* Link quality is defined by C/I (Carrier-to-Interference ratio), * which has optional presence. If it's absent, report the * minimum acceptable value to pass L1SAP checks. */ - /* TODO: check for TRX_BI_F_CI_CB, and use the value from UL.ind */ - l1sap.u.rach_ind.lqual_cb = l1t->trx->bts->min_qual_rach; + if (bi->flags & TRX_BI_F_CI_CB) + l1sap.u.rach_ind.lqual_cb = bi->ci_cb; + else + l1sap.u.rach_ind.lqual_cb = l1t->trx->bts->min_qual_rach; /* Decode RACH depending on its synch. sequence */ switch (synch_seq) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8d86dec7ebc039cbfd038c4342ff328b11281865 Gerrit-Change-Number: 14688 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:16:23 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 15:16:23 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14689 ) Change subject: osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP ...................................................................... osmo-bts-trx/scheduler: rx_data_fn(): provide actual C/I ratio to L1SAP Change-Id: Iea0dad65e9bc511f99375fd3ee2eb44e47a6168f --- M src/osmo-bts-trx/scheduler_trx.c 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c index 8144956..532eca5 100644 --- a/src/osmo-bts-trx/scheduler_trx.c +++ b/src/osmo-bts-trx/scheduler_trx.c @@ -896,8 +896,11 @@ uint8_t *rssi_num = &chan_state->rssi_num; int32_t *toa256_sum = &chan_state->toa256_sum; uint8_t *toa_num = &chan_state->toa_num; + int32_t *ci_cb_sum = &chan_state->ci_cb_sum; + uint8_t *ci_cb_num = &chan_state->ci_cb_num; uint8_t l2[GSM_MACBLOCK_LEN], l2_len; int n_errors, n_bits_total; + int16_t lqual_cb; uint16_t ber10k; int rc; @@ -924,6 +927,8 @@ *rssi_num = 0; *toa256_sum = 0; *toa_num = 0; + *ci_cb_sum = 0; + *ci_cb_num = 0; } /* update mask + RSSI */ @@ -933,6 +938,12 @@ *toa256_sum += bi->toa256; (*toa_num)++; + /* C/I: Carrier-to-Interference ratio (in centiBels) */ + if (bi->flags & TRX_BI_F_CI_CB) { + *ci_cb_sum += bi->ci_cb; + (*ci_cb_num)++; + } + /* copy burst to buffer of 4 bursts */ burst = *bursts_p + bid * 116; memcpy(burst, bi->burst + 3, 58); @@ -978,13 +989,14 @@ n_errors, n_bits_total, *rssi_sum / *rssi_num, *toa256_sum / *toa_num); + lqual_cb = *ci_cb_num ? (*ci_cb_sum / *ci_cb_num) : 0; ber10k = compute_ber10k(n_bits_total, n_errors); return _sched_compose_ph_data_ind(l1t, bi->tn, *first_fn, chan, l2, l2_len, *rssi_sum / *rssi_num, *toa256_sum / *toa_num, - 0 /* FIXME: AVG C/I */, - ber10k, PRES_INFO_UNKNOWN); + lqual_cb, ber10k, + PRES_INFO_UNKNOWN); } /*! \brief a single PDTCH burst was received by the PHY, process it */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14689 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea0dad65e9bc511f99375fd3ee2eb44e47a6168f Gerrit-Change-Number: 14689 Gerrit-PatchSet: 9 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:25:19 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 21 Jul 2019 15:25:19 +0000 Subject: Change in ...libsmpp34[master]: bind_receiver_test: Fix "unused value" of writing addr_ton twice In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/14862 ) Change subject: bind_receiver_test: Fix "unused value" of writing addr_ton twice ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/14862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I89e16746da5c9f77b721294149a1bce5be5a1eae Gerrit-Change-Number: 14862 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 21 Jul 2019 15:25:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:31:02 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 21 Jul 2019 15:31:02 +0000 Subject: Change in ...osmo-trx[master]: Timeval: Restore output stream flags after changing them In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14863 ) Change subject: Timeval: Restore output stream flags after changing them ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14863/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14863/1//COMMIT_MSG at 10 PS1, Line 10: Closes: OS#149361 This number doesn't look like an osmocom redmine ticket. Coverity CID maybe? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I866505f29ed56d8f3ba3aaba70c0d82479987c64 Gerrit-Change-Number: 14863 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Sun, 21 Jul 2019 15:31:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:36:19 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 21 Jul 2019 15:36:19 +0000 Subject: Change in ...osmocom-bb[master]: gsm411_sms.c: Handle negative return of gsm340_gen_oa() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14880 ) Change subject: gsm411_sms.c: Handle negative return of gsm340_gen_oa() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14880 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I36f56e1fbd72d9b31350dc2f8a53e763f79f4c08 Gerrit-Change-Number: 14880 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 21 Jul 2019 15:36:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:36:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 21 Jul 2019 15:36:25 +0000 Subject: Change in ...osmocom-bb[master]: gsm411_sms.c: Handle negative return of gsm340_gen_oa() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14880 ) Change subject: gsm411_sms.c: Handle negative return of gsm340_gen_oa() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14880 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I36f56e1fbd72d9b31350dc2f8a53e763f79f4c08 Gerrit-Change-Number: 14880 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 21 Jul 2019 15:36:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:40:36 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 21 Jul 2019 15:40:36 +0000 Subject: Change in ...osmo-trx[master]: ChannelizerBase: fix initialization of class members In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14865 ) Change subject: ChannelizerBase: fix initialization of class members ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8c047c8f98e928a62dca1d7b8c003502727c086e Gerrit-Change-Number: 14865 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 21 Jul 2019 15:40:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:41:30 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 21 Jul 2019 15:41:30 +0000 Subject: Change in ...osmo-trx[master]: CorrelationSequence: fix initialization of class members In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14866 ) Change subject: CorrelationSequence: fix initialization of class members ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia72395f8805e9e2cd700ad1e559a8aa62124aaec Gerrit-Change-Number: 14866 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 21 Jul 2019 15:41:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:41:46 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sun, 21 Jul 2019 15:41:46 +0000 Subject: Change in ...libsmpp34[master]: bind_receiver_test: Fix "unused value" of writing addr_ton twice In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/14862 ) Change subject: bind_receiver_test: Fix "unused value" of writing addr_ton twice ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/14862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I89e16746da5c9f77b721294149a1bce5be5a1eae Gerrit-Change-Number: 14862 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 21 Jul 2019 15:41:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:42:10 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Sun, 21 Jul 2019 15:42:10 +0000 Subject: Change in ...osmo-trx[master]: radioInterface.cpp: Fix missing member initialization of RadioInterfa... In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14872 ) Change subject: radioInterface.cpp: Fix missing member initialization of RadioInterface() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14872 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7264ef35dbe6d3522858eae5b47d150aa1ffe334 Gerrit-Change-Number: 14872 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 21 Jul 2019 15:42:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:45:29 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 15:45:29 +0000 Subject: Change in ...osmo-trx[master]: Timeval: Restore output stream flags after changing them In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14863 to look at the new patch set (#2). Change subject: Timeval: Restore output stream flags after changing them ...................................................................... Timeval: Restore output stream flags after changing them Change-Id: I866505f29ed56d8f3ba3aaba70c0d82479987c64 Closes: CID#149361 --- M CommonLibs/Timeval.cpp 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/63/14863/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I866505f29ed56d8f3ba3aaba70c0d82479987c64 Gerrit-Change-Number: 14863 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:45:42 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 15:45:42 +0000 Subject: Change in ...osmo-trx[master]: Timeval: Restore output stream flags after changing them In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14863 ) Change subject: Timeval: Restore output stream flags after changing them ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I866505f29ed56d8f3ba3aaba70c0d82479987c64 Gerrit-Change-Number: 14863 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Sun, 21 Jul 2019 15:45:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:45:58 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 15:45:58 +0000 Subject: Change in ...osmo-trx[master]: Timeval: Restore output stream flags after changing them In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14863 ) Change subject: Timeval: Restore output stream flags after changing them ...................................................................... Timeval: Restore output stream flags after changing them Change-Id: I866505f29ed56d8f3ba3aaba70c0d82479987c64 Closes: CID#149361 --- M CommonLibs/Timeval.cpp 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/CommonLibs/Timeval.cpp b/CommonLibs/Timeval.cpp index fd1bcda..420dd04 100644 --- a/CommonLibs/Timeval.cpp +++ b/CommonLibs/Timeval.cpp @@ -87,8 +87,9 @@ ostream& operator<<(ostream& os, const Timeval& tv) { - os.setf( ios::fixed, ios::floatfield ); + ios_base::fmtflags flags_backup = os.setf( ios::fixed, ios::floatfield ); os << tv.seconds(); + os.flags( flags_backup ); return os; } -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I866505f29ed56d8f3ba3aaba70c0d82479987c64 Gerrit-Change-Number: 14863 Gerrit-PatchSet: 3 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:46:01 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 15:46:01 +0000 Subject: Change in ...osmo-trx[master]: ChannelizerBase: fix initialization of class members In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14865 ) Change subject: ChannelizerBase: fix initialization of class members ...................................................................... ChannelizerBase: fix initialization of class members Change-Id: I8c047c8f98e928a62dca1d7b8c003502727c086e Closes: CID#149374 --- M Transceiver52M/ChannelizerBase.cpp 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/ChannelizerBase.cpp b/Transceiver52M/ChannelizerBase.cpp index 430e260..f5b3ed4 100644 --- a/Transceiver52M/ChannelizerBase.cpp +++ b/Transceiver52M/ChannelizerBase.cpp @@ -226,7 +226,8 @@ * Setup channelizer paramaters */ ChannelizerBase::ChannelizerBase(size_t m, size_t blockLen, size_t hLen) - : fftInput(NULL), fftOutput(NULL), fftHandle(NULL) + : subFilters(NULL), hInputs(NULL), hOutputs(NULL), hist(NULL), + fftInput(NULL), fftOutput(NULL), fftHandle(NULL) { this->m = m; this->hLen = hLen; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8c047c8f98e928a62dca1d7b8c003502727c086e Gerrit-Change-Number: 14865 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:46:04 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 15:46:04 +0000 Subject: Change in ...osmo-trx[master]: CorrelationSequence: fix initialization of class members In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14866 ) Change subject: CorrelationSequence: fix initialization of class members ...................................................................... CorrelationSequence: fix initialization of class members Change-Id: Ia72395f8805e9e2cd700ad1e559a8aa62124aaec Closes: CID#149371 --- M Transceiver52M/sigProcLib.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp index 860bbe4..1042dbb 100644 --- a/Transceiver52M/sigProcLib.cpp +++ b/Transceiver52M/sigProcLib.cpp @@ -84,7 +84,7 @@ * perform 16-byte memory alignment required by many SSE instructions. */ struct CorrelationSequence { - CorrelationSequence() : sequence(NULL) + CorrelationSequence() : sequence(NULL), buffer(NULL), toa(0.0) { } -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia72395f8805e9e2cd700ad1e559a8aa62124aaec Gerrit-Change-Number: 14866 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:46:06 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 15:46:06 +0000 Subject: Change in ...osmo-trx[master]: radioInterface.cpp: Fix missing member initialization of RadioInterfa... In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14872 ) Change subject: radioInterface.cpp: Fix missing member initialization of RadioInterface() ...................................................................... radioInterface.cpp: Fix missing member initialization of RadioInterface() Change-Id: I7264ef35dbe6d3522858eae5b47d150aa1ffe334 Closes: CID#169594 --- M Transceiver52M/radioInterface.cpp 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/radioInterface.cpp b/Transceiver52M/radioInterface.cpp index f488b0d..04b98da 100644 --- a/Transceiver52M/radioInterface.cpp +++ b/Transceiver52M/radioInterface.cpp @@ -34,7 +34,8 @@ size_t rx_sps, size_t chans, int wReceiveOffset, GSM::Time wStartTime) : mRadio(wRadio), mSPSTx(tx_sps), mSPSRx(rx_sps), mChans(chans), - underrun(false), overrun(false), receiveOffset(wReceiveOffset), mOn(false) + underrun(false), overrun(false), writeTimestamp(0), readTimestamp(0), + receiveOffset(wReceiveOffset), mOn(false) { mClock.set(wStartTime); } -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14872 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7264ef35dbe6d3522858eae5b47d150aa1ffe334 Gerrit-Change-Number: 14872 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:46:39 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 15:46:39 +0000 Subject: Change in ...libsmpp34[master]: bind_receiver_test: Fix "unused value" of writing addr_ton twice In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libsmpp34/+/14862 ) Change subject: bind_receiver_test: Fix "unused value" of writing addr_ton twice ...................................................................... bind_receiver_test: Fix "unused value" of writing addr_ton twice The constant 0x34 clearly hints that this should be written to interface_version... Closes: CID#135235 Change-Id: I89e16746da5c9f77b721294149a1bce5be5a1eae --- M test_pdu/bind_receiver_test.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/test_pdu/bind_receiver_test.c b/test_pdu/bind_receiver_test.c index fa94c6f..67eab09 100644 --- a/test_pdu/bind_receiver_test.c +++ b/test_pdu/bind_receiver_test.c @@ -53,7 +53,7 @@ snprintf((char*)b.system_id, sizeof(b.system_id), "%s", "system_id"); snprintf((char*)b.password, sizeof(b.password), "%s", "pass"); snprintf((char*)b.system_type, sizeof(b.system_type), "%s", "syste"); - b.addr_ton = 0x34; + b.interface_version = 0x34; b.addr_ton = 2; b.addr_npi = 1; snprintf((char*)b.address_range, sizeof(b.address_range), "%s", "address_range"); -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/14862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I89e16746da5c9f77b721294149a1bce5be5a1eae Gerrit-Change-Number: 14862 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:47:19 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 15:47:19 +0000 Subject: Change in ...libosmocore[master]: gsm/gsm0480.c: parse_ss(): drop needless debug print In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14882 ) Change subject: gsm/gsm0480.c: parse_ss(): drop needless debug print ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14882 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie18c291d0cfe3b246d09ac6cfd9591951a2984c8 Gerrit-Change-Number: 14882 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 15:47:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:47:34 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 15:47:34 +0000 Subject: Change in ...libosmocore[master]: gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14861 ) Change subject: gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14861 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id38272ff93fae6d2fdf39df4ffc74856d6c9a898 Gerrit-Change-Number: 14861 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 15:47:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:47:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 15:47:35 +0000 Subject: Change in ...libosmocore[master]: gsm/gsm0480.c: parse_ss(): drop needless debug print In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14882 ) Change subject: gsm/gsm0480.c: parse_ss(): drop needless debug print ...................................................................... gsm/gsm0480.c: parse_ss(): drop needless debug print Change-Id: Ie18c291d0cfe3b246d09ac6cfd9591951a2984c8 --- M src/gsm/gsm0480.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c index 9f546cc..66a22b6 100644 --- a/src/gsm/gsm0480.c +++ b/src/gsm/gsm0480.c @@ -393,8 +393,6 @@ /* Table 2.1: Messages for call independent SS control */ switch (msg_type) { case GSM0480_MTYPE_RELEASE_COMPLETE: - LOGP(0, LOGL_DEBUG, "SS Release Complete\n"); - /** * Indicates that there is no decoded message. * To be overwriten by the message otherwise. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14882 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie18c291d0cfe3b246d09ac6cfd9591951a2984c8 Gerrit-Change-Number: 14882 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:47:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 15:47:35 +0000 Subject: Change in ...libosmocore[master]: gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14861 ) Change subject: gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging ...................................................................... gsm/gsm0480.c: use DLGLOBAL and LOGL_ERROR for logging Change-Id: Id38272ff93fae6d2fdf39df4ffc74856d6c9a898 --- M src/gsm/gsm0480.c 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c index 66a22b6..3ae591a 100644 --- a/src/gsm/gsm0480.c +++ b/src/gsm/gsm0480.c @@ -323,7 +323,7 @@ memset(&ss, 0, sizeof(ss)); if (len < sizeof(*hdr) + 2) { - LOGP(0, LOGL_DEBUG, "USSD Request is too short.\n"); + LOGP(DLGLOBAL, LOGL_ERROR, "USSD Request is too short.\n"); return 0; } @@ -345,7 +345,7 @@ } if (!rc) - LOGP(0, LOGL_DEBUG, "Error occurred while parsing received USSD!\n"); + LOGP(DLGLOBAL, LOGL_ERROR, "Error occurred while parsing received USSD!\n"); return rc; } @@ -362,7 +362,7 @@ */ pdisc = gsm48_hdr_pdisc(hdr); if (pdisc != GSM48_PDISC_NC_SS) { - LOGP(0, LOGL_ERROR, "Dropping message with " + LOGP(DLGLOBAL, LOGL_ERROR, "Dropping message with " "unsupported pdisc=%02x\n", pdisc); return 0; } @@ -385,7 +385,7 @@ */ if (msg_type != GSM0480_MTYPE_RELEASE_COMPLETE) { if (len < 2) { - LOGP(0, LOGL_DEBUG, "SS Request is too short.\n"); + LOGP(DLGLOBAL, LOGL_ERROR, "SS Request is too short.\n"); return 0; } } @@ -410,7 +410,7 @@ rc &= parse_ss_facility(&hdr->data[0], len, req); break; default: - LOGP(0, LOGL_DEBUG, "Unknown GSM 04.80 message-type field 0x%02x\n", + LOGP(DLGLOBAL, LOGL_ERROR, "Unknown GSM 04.80 message-type field 0x%02x\n", hdr->msg_type); rc = 0; break; @@ -459,7 +459,7 @@ case GSM0480_IE_SS_VERSION: break; default: - LOGP(0, LOGL_DEBUG, "Unhandled GSM 04.08 or 04.80 IEI 0x%02x\n", + LOGP(DLGLOBAL, LOGL_ERROR, "Unhandled GSM 04.08 or 04.80 IEI 0x%02x\n", iei); rc = 0; break; @@ -495,7 +495,7 @@ /* Make sure that there is no overflow */ if (offset + 2 + component_length > length) { - LOGP(0, LOGL_ERROR, "Component does not fit.\n"); + LOGP(DLGLOBAL, LOGL_ERROR, "Component does not fit.\n"); return -EINVAL; } @@ -515,7 +515,7 @@ case GSM0480_CTYPE_REJECT: break; default: - LOGP(0, LOGL_DEBUG, "Unknown GSM 04.80 Facility " + LOGP(DLGLOBAL, LOGL_ERROR, "Unknown GSM 04.80 Facility " "Component Type 0x%02x\n", component_type); rc = 0; break; @@ -545,7 +545,7 @@ /* mandatory part */ if (invoke_data[0] != GSM0480_COMPIDTAG_INVOKE_ID) { - LOGP(0, LOGL_DEBUG, "Unexpected GSM 04.80 Component-ID tag " + LOGP(DLGLOBAL, LOGL_ERROR, "Unexpected GSM 04.80 Component-ID tag " "0x%02x (expecting Invoke ID tag)\n", invoke_data[0]); } @@ -587,13 +587,13 @@ req); break; default: - LOGP(0, LOGL_DEBUG, "GSM 04.80 operation code 0x%02x " + LOGP(DLGLOBAL, LOGL_ERROR, "GSM 04.80 operation code 0x%02x " "is not yet handled\n", operation_code); rc = 0; break; } } else { - LOGP(0, LOGL_DEBUG, "Unexpected GSM 04.80 Component-ID tag 0x%02x " + LOGP(DLGLOBAL, LOGL_ERROR, "Unexpected GSM 04.80 Component-ID tag 0x%02x " "(expecting Operation Code tag)\n", invoke_data[0]); rc = 0; @@ -614,7 +614,7 @@ /* Mandatory part */ if (rr_data[0] != GSM0480_COMPIDTAG_INVOKE_ID) { - LOGP(0, LOGL_DEBUG, "Unexpected GSM 04.80 Component-ID tag " + LOGP(DLGLOBAL, LOGL_ERROR, "Unexpected GSM 04.80 Component-ID tag " "0x%02x (expecting Invoke ID tag)\n", rr_data[0]); return 0; } @@ -645,7 +645,7 @@ return parse_process_uss_data(rr_data + offset + 3, length - offset - 3, req); default: - LOGP(0, LOGL_DEBUG, "GSM 04.80 operation code 0x%02x " + LOGP(DLGLOBAL, LOGL_ERROR, "GSM 04.80 operation code 0x%02x " "is not yet handled\n", operation_code); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14861 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id38272ff93fae6d2fdf39df4ffc74856d6c9a898 Gerrit-Change-Number: 14861 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:49:58 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 15:49:58 +0000 Subject: Change in ...libosmocore[master]: tell ubsan to ignore SUN_LEN In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14682 ) Change subject: tell ubsan to ignore SUN_LEN ...................................................................... tell ubsan to ignore SUN_LEN ubsan will report undefined behavior due to the SUN_LEN macros interaction with a null pointer, so let's tell ubsan to ignore this function. After carefully reviewing the final publically availlable drafts of the C99,C11 and C18 standards I can confirm that dereferencing null pointers is still undefined behavior, as such ubsan will always warn with absolutely every existing compiler version. Since the sanitizers are periodically synced between llvm and gcc I'm also fairly confident that rebuilding everything with compiler_rt to use the integrated sanitizers would result in the same message. I sincerly hope that this explanation provides to be sufficient, If not I'd be willing to show up at the next llvm dev meeting to provide quotes from actual sanitizer developers to back up these claims. Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 --- M src/socket.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/socket.c b/src/socket.c index 1e303bf..c50af55 100644 --- a/src/socket.c +++ b/src/socket.c @@ -614,6 +614,9 @@ * type and \a proto and optionally binds or connects it, depending on * the value of \a flags parameter. */ +#if defined(__clang__) && defined(SUN_LEN) +__attribute__((no_sanitize("undefined"))) +#endif int osmo_sock_unix_init(uint16_t type, uint8_t proto, const char *socket_path, unsigned int flags) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0ff445072f1b46390c9f70b21d61c789e39358d5 Gerrit-Change-Number: 14682 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 15:50:37 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 15:50:37 +0000 Subject: Change in ...docker-playground[master]: osmo-nitb-master: Include only one access-list in config In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14832 ) Change subject: osmo-nitb-master: Include only one access-list in config ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14832 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I01b6e5af9cf84cf1b8d313ac47ab6b77fc598f4c Gerrit-Change-Number: 14832 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Sun, 21 Jul 2019 15:50:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 18:43:23 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 18:43:23 +0000 Subject: Change in ...osmo-remsim[master]: track libulfius and jansson memory allocations with talloc Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14883 Change subject: track libulfius and jansson memory allocations with talloc ...................................................................... track libulfius and jansson memory allocations with talloc Change-Id: I0ad63a79a806b420ea0de42b67726da36ebac828 --- M configure.ac M src/server/Makefile.am M src/server/remsim_server.c M src/server/rest_api.c M src/server/rest_api.h 5 files changed, 40 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/83/14883/1 diff --git a/configure.ac b/configure.ac index e87c8c8..2fc603d 100644 --- a/configure.ac +++ b/configure.ac @@ -45,6 +45,7 @@ [osmo_ac_build_server="$enableval"],[osmo_ac_build_server="yes"]) if test "$osmo_ac_build_server" = "yes"; then PKG_CHECK_MODULES(ULFIUS, libulfius) + PKG_CHECK_MODULES(ORCANIA, liborcania) PKG_CHECK_MODULES(JANSSON, jansson) AC_DEFINE(BUILD_SERVER, 1, [Define if we want to build osmo-remsim-server]) fi diff --git a/src/server/Makefile.am b/src/server/Makefile.am index ce114b6..f6278a3 100644 --- a/src/server/Makefile.am +++ b/src/server/Makefile.am @@ -2,7 +2,7 @@ AM_CFLAGS = -Wall -I$(top_srcdir)/include -I$(top_builddir)/include -I$(top_srcdir)/src \ -I$(top_srcdir)/include/osmocom/rspro \ $(OSMOCORE_CFLAGS) $(OSMOGSM_CFLAGS) $(OSMOABIS_CFLAGS) \ - $(ULFIUS_CFLAGS) $(JANSSON_CFLAGS) + $(ULFIUS_CFLAGS) $(JANSSON_CFLAGS) $(ORCANIA_CFLAGS) noinst_HEADERS = rspro_server.h rest_api.h @@ -11,7 +11,7 @@ osmo_remsim_server_SOURCES = remsim_server.c rspro_server.c rest_api.c \ ../rspro_util.c ../slotmap.c ../debug.c osmo_remsim_server_LDADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOABIS_LIBS) \ - $(ULFIUS_LIBS) $(JANSSON_LIBS) \ + $(ULFIUS_LIBS) $(JANSSON_LIBS) $(ORCANIA_LIBS) \ $(top_builddir)/src/libosmo-rspro.la # as suggested in http://lists.gnu.org/archive/html/automake/2009-03/msg00011.html diff --git a/src/server/remsim_server.c b/src/server/remsim_server.c index a8502e4..70cbedc 100644 --- a/src/server/remsim_server.c +++ b/src/server/remsim_server.c @@ -27,10 +27,12 @@ int main(int argc, char **argv) { + void *talloc_rest_ctx; int rc; g_tall_ctx = talloc_named_const(NULL, 0, "global"); talloc_asn1_ctx = talloc_named_const(g_tall_ctx, 0, "asn1"); + talloc_rest_ctx = talloc_named_const(g_tall_ctx, 0, "rest"); msgb_talloc_ctx_init(g_tall_ctx, 0); osmo_init_logging2(g_tall_ctx, &log_info); @@ -56,7 +58,7 @@ signal(SIGUSR1, handle_sig_usr1); - rc = rest_api_init(9997); + rc = rest_api_init(talloc_rest_ctx, 9997); if (rc < 0) goto out_eventfd; diff --git a/src/server/rest_api.c b/src/server/rest_api.c index b990664..969f672 100644 --- a/src/server/rest_api.c +++ b/src/server/rest_api.c @@ -1,9 +1,11 @@ #include #include #include +#include #include #include +#include #include #include @@ -461,13 +463,43 @@ }; static struct _u_instance g_instance; +static pthread_mutex_t g_tall_lock = PTHREAD_MUTEX_INITIALIZER; +static void *g_tall_rest; -int rest_api_init(uint16_t port) +static void *my_o_malloc(size_t sz) +{ + void *obj; + pthread_mutex_lock(&g_tall_lock); + obj = talloc_size(g_tall_rest, sz); + pthread_mutex_unlock(&g_tall_lock); + return obj; +} + +static void *my_o_realloc(void *obj, size_t sz) +{ + pthread_mutex_lock(&g_tall_lock); + obj = talloc_realloc_size(g_tall_rest, obj, sz); + pthread_mutex_unlock(&g_tall_lock); + return obj; +} + +static void my_o_free(void *obj) +{ + pthread_mutex_lock(&g_tall_lock); + talloc_free(obj); + pthread_mutex_unlock(&g_tall_lock); +} + +int rest_api_init(void *ctx, uint16_t port) { int i; + g_tall_rest = ctx; + o_set_alloc_funcs(my_o_malloc, my_o_realloc, my_o_free); + if (ulfius_init_instance(&g_instance, port, NULL, NULL) != U_OK) return -1; + g_instance.mhd_response_copy_data = 1; for (i = 0; i < ARRAY_SIZE(api_endpoints); i++) ulfius_add_endpoint(&g_instance, &api_endpoints[i]); diff --git a/src/server/rest_api.h b/src/server/rest_api.h index 87269e8..dfba65d 100644 --- a/src/server/rest_api.h +++ b/src/server/rest_api.h @@ -1,5 +1,5 @@ #pragma once #include -int rest_api_init(uint16_t port); +int rest_api_init(void *ctx, uint16_t port); void rest_api_fini(void); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14883 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0ad63a79a806b420ea0de42b67726da36ebac828 Gerrit-Change-Number: 14883 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 18:43:23 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 18:43:23 +0000 Subject: Change in ...osmo-remsim[master]: server: rest_api: Fix memory leak in slotmap post Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14884 Change subject: server: rest_api: Fix memory leak in slotmap post ...................................................................... server: rest_api: Fix memory leak in slotmap post We need to decrement the refcount on the json_req object. Change-Id: I1a550eff76e6a72013ab47ef8f240a72d7a7d9cb --- M src/server/rest_api.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/84/14884/1 diff --git a/src/server/rest_api.c b/src/server/rest_api.c index 969f672..abd46b9 100644 --- a/src/server/rest_api.c +++ b/src/server/rest_api.c @@ -309,7 +309,7 @@ struct slot_mapping slotmap, *map; struct rspro_client_conn *conn; json_error_t json_err; - json_t *json_req; + json_t *json_req = NULL; int rc; json_req = ulfius_get_json_body_request(req, &json_err); @@ -341,10 +341,12 @@ pthread_rwlock_unlock(&srv->rwlock); + json_decref(json_req); ulfius_set_empty_body_response(resp, 201); return U_CALLBACK_COMPLETE; err: + json_decref(json_req); ulfius_set_empty_body_response(resp, 400); return U_CALLBACK_COMPLETE; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14884 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I1a550eff76e6a72013ab47ef8f240a72d7a7d9cb Gerrit-Change-Number: 14884 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 18:46:39 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 18:46:39 +0000 Subject: Change in ...osmo-remsim[master]: track libulfius and jansson memory allocations with talloc In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14883 ) Change subject: track libulfius and jansson memory allocations with talloc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14883 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0ad63a79a806b420ea0de42b67726da36ebac828 Gerrit-Change-Number: 14883 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 18:46:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 18:46:52 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 18:46:52 +0000 Subject: Change in ...osmo-remsim[master]: server: rest_api: Fix memory leak in slotmap post In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14884 ) Change subject: server: rest_api: Fix memory leak in slotmap post ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14884 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I1a550eff76e6a72013ab47ef8f240a72d7a7d9cb Gerrit-Change-Number: 14884 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sun, 21 Jul 2019 18:46:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 18:46:58 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 18:46:58 +0000 Subject: Change in ...osmo-remsim[master]: track libulfius and jansson memory allocations with talloc In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14883 ) Change subject: track libulfius and jansson memory allocations with talloc ...................................................................... track libulfius and jansson memory allocations with talloc Change-Id: I0ad63a79a806b420ea0de42b67726da36ebac828 --- M configure.ac M src/server/Makefile.am M src/server/remsim_server.c M src/server/rest_api.c M src/server/rest_api.h 5 files changed, 40 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index e87c8c8..2fc603d 100644 --- a/configure.ac +++ b/configure.ac @@ -45,6 +45,7 @@ [osmo_ac_build_server="$enableval"],[osmo_ac_build_server="yes"]) if test "$osmo_ac_build_server" = "yes"; then PKG_CHECK_MODULES(ULFIUS, libulfius) + PKG_CHECK_MODULES(ORCANIA, liborcania) PKG_CHECK_MODULES(JANSSON, jansson) AC_DEFINE(BUILD_SERVER, 1, [Define if we want to build osmo-remsim-server]) fi diff --git a/src/server/Makefile.am b/src/server/Makefile.am index ce114b6..f6278a3 100644 --- a/src/server/Makefile.am +++ b/src/server/Makefile.am @@ -2,7 +2,7 @@ AM_CFLAGS = -Wall -I$(top_srcdir)/include -I$(top_builddir)/include -I$(top_srcdir)/src \ -I$(top_srcdir)/include/osmocom/rspro \ $(OSMOCORE_CFLAGS) $(OSMOGSM_CFLAGS) $(OSMOABIS_CFLAGS) \ - $(ULFIUS_CFLAGS) $(JANSSON_CFLAGS) + $(ULFIUS_CFLAGS) $(JANSSON_CFLAGS) $(ORCANIA_CFLAGS) noinst_HEADERS = rspro_server.h rest_api.h @@ -11,7 +11,7 @@ osmo_remsim_server_SOURCES = remsim_server.c rspro_server.c rest_api.c \ ../rspro_util.c ../slotmap.c ../debug.c osmo_remsim_server_LDADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOABIS_LIBS) \ - $(ULFIUS_LIBS) $(JANSSON_LIBS) \ + $(ULFIUS_LIBS) $(JANSSON_LIBS) $(ORCANIA_LIBS) \ $(top_builddir)/src/libosmo-rspro.la # as suggested in http://lists.gnu.org/archive/html/automake/2009-03/msg00011.html diff --git a/src/server/remsim_server.c b/src/server/remsim_server.c index a8502e4..70cbedc 100644 --- a/src/server/remsim_server.c +++ b/src/server/remsim_server.c @@ -27,10 +27,12 @@ int main(int argc, char **argv) { + void *talloc_rest_ctx; int rc; g_tall_ctx = talloc_named_const(NULL, 0, "global"); talloc_asn1_ctx = talloc_named_const(g_tall_ctx, 0, "asn1"); + talloc_rest_ctx = talloc_named_const(g_tall_ctx, 0, "rest"); msgb_talloc_ctx_init(g_tall_ctx, 0); osmo_init_logging2(g_tall_ctx, &log_info); @@ -56,7 +58,7 @@ signal(SIGUSR1, handle_sig_usr1); - rc = rest_api_init(9997); + rc = rest_api_init(talloc_rest_ctx, 9997); if (rc < 0) goto out_eventfd; diff --git a/src/server/rest_api.c b/src/server/rest_api.c index b990664..969f672 100644 --- a/src/server/rest_api.c +++ b/src/server/rest_api.c @@ -1,9 +1,11 @@ #include #include #include +#include #include #include +#include #include #include @@ -461,13 +463,43 @@ }; static struct _u_instance g_instance; +static pthread_mutex_t g_tall_lock = PTHREAD_MUTEX_INITIALIZER; +static void *g_tall_rest; -int rest_api_init(uint16_t port) +static void *my_o_malloc(size_t sz) +{ + void *obj; + pthread_mutex_lock(&g_tall_lock); + obj = talloc_size(g_tall_rest, sz); + pthread_mutex_unlock(&g_tall_lock); + return obj; +} + +static void *my_o_realloc(void *obj, size_t sz) +{ + pthread_mutex_lock(&g_tall_lock); + obj = talloc_realloc_size(g_tall_rest, obj, sz); + pthread_mutex_unlock(&g_tall_lock); + return obj; +} + +static void my_o_free(void *obj) +{ + pthread_mutex_lock(&g_tall_lock); + talloc_free(obj); + pthread_mutex_unlock(&g_tall_lock); +} + +int rest_api_init(void *ctx, uint16_t port) { int i; + g_tall_rest = ctx; + o_set_alloc_funcs(my_o_malloc, my_o_realloc, my_o_free); + if (ulfius_init_instance(&g_instance, port, NULL, NULL) != U_OK) return -1; + g_instance.mhd_response_copy_data = 1; for (i = 0; i < ARRAY_SIZE(api_endpoints); i++) ulfius_add_endpoint(&g_instance, &api_endpoints[i]); diff --git a/src/server/rest_api.h b/src/server/rest_api.h index 87269e8..dfba65d 100644 --- a/src/server/rest_api.h +++ b/src/server/rest_api.h @@ -1,5 +1,5 @@ #pragma once #include -int rest_api_init(uint16_t port); +int rest_api_init(void *ctx, uint16_t port); void rest_api_fini(void); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14883 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I0ad63a79a806b420ea0de42b67726da36ebac828 Gerrit-Change-Number: 14883 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 18:47:15 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 18:47:15 +0000 Subject: Change in ...docker-playground[master]: osmo-nitb-master: Include only one access-list in config In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14832 ) Change subject: osmo-nitb-master: Include only one access-list in config ...................................................................... osmo-nitb-master: Include only one access-list in config Each access list will have their own counters. Have only one in the config so the script generating the counter documentation doesn't repeat itself. Change-Id: I01b6e5af9cf84cf1b8d313ac47ab6b77fc598f4c --- M osmo-nitb-master/osmo-bsc-nat.cfg 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved; Verified diff --git a/osmo-nitb-master/osmo-bsc-nat.cfg b/osmo-nitb-master/osmo-bsc-nat.cfg index 0179a94..db74d7e 100644 --- a/osmo-nitb-master/osmo-bsc-nat.cfg +++ b/osmo-nitb-master/osmo-bsc-nat.cfg @@ -38,4 +38,3 @@ ip-dscp 0 bscs-config-file bscs.config access-list msceven imsi-allow ^[0-9]*[24680]$ - access-list mscodd imsi-allow ^[0-9]*[13579]$ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14832 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I01b6e5af9cf84cf1b8d313ac47ab6b77fc598f4c Gerrit-Change-Number: 14832 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 18:47:21 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 18:47:21 +0000 Subject: Change in ...osmocom-bb[master]: gsm411_sms.c: Handle negative return of gsm340_gen_oa() In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14880 ) Change subject: gsm411_sms.c: Handle negative return of gsm340_gen_oa() ...................................................................... gsm411_sms.c: Handle negative return of gsm340_gen_oa() Change-Id: I36f56e1fbd72d9b31350dc2f8a53e763f79f4c08 Closes: CID#198533 --- M src/host/layer23/src/mobile/gsm411_sms.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm411_sms.c b/src/host/layer23/src/mobile/gsm411_sms.c index 08df0f2..45decfd 100644 --- a/src/host/layer23/src/mobile/gsm411_sms.c +++ b/src/host/layer23/src/mobile/gsm411_sms.c @@ -579,6 +579,9 @@ sms->address + 1); else da_len = gsm340_gen_oa(da, sizeof(da), 0x0, 0x1, sms->address); + if (da_len < 0) + return da_len; + smsp = msgb_put(msg, da_len); memcpy(smsp, da, da_len); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14880 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I36f56e1fbd72d9b31350dc2f8a53e763f79f4c08 Gerrit-Change-Number: 14880 Gerrit-PatchSet: 2 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 19:08:53 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 19:08:53 +0000 Subject: Change in ...osmo-remsim[master]: server: rest_api: Fix memory leak in slotmap post In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14884 ) Change subject: server: rest_api: Fix memory leak in slotmap post ...................................................................... server: rest_api: Fix memory leak in slotmap post We need to decrement the refcount on the json_req object. Change-Id: I1a550eff76e6a72013ab47ef8f240a72d7a7d9cb --- M src/server/rest_api.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/server/rest_api.c b/src/server/rest_api.c index 969f672..abd46b9 100644 --- a/src/server/rest_api.c +++ b/src/server/rest_api.c @@ -309,7 +309,7 @@ struct slot_mapping slotmap, *map; struct rspro_client_conn *conn; json_error_t json_err; - json_t *json_req; + json_t *json_req = NULL; int rc; json_req = ulfius_get_json_body_request(req, &json_err); @@ -341,10 +341,12 @@ pthread_rwlock_unlock(&srv->rwlock); + json_decref(json_req); ulfius_set_empty_body_response(resp, 201); return U_CALLBACK_COMPLETE; err: + json_decref(json_req); ulfius_set_empty_body_response(resp, 400); return U_CALLBACK_COMPLETE; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14884 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I1a550eff76e6a72013ab47ef8f240a72d7a7d9cb Gerrit-Change-Number: 14884 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 19:14:12 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 19:14:12 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-remsim=5Bmaster=5D=3A_Bump_version=3A_0=2E1=2E0=2E29-e7f7_=E2=86=92_0=2E2=2E0?= Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14885 Change subject: Bump version: 0.1.0.29-e7f7 ? 0.2.0 ...................................................................... Bump version: 0.1.0.29-e7f7 ? 0.2.0 Change-Id: Id486c05b6564c77df9f04a051ef508fecd7885d6 --- M debian/changelog 1 file changed, 42 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/85/14885/1 diff --git a/debian/changelog b/debian/changelog index ca4d246..d2de5eb 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,45 @@ +osmo-remsim (0.2.0) unstable; urgency=medium + + [ Harald Welte ] + * bankd: move bank_id / num_slots from g_bankd to remsim_srv_conn + * bankd: Use configured bank_id/nr_slots in ConnectBankReq + * cosmetic: remove some FIXME that actually are already fixed + * Makefile.am: Fix dependency of server on libosmo-rspro.la + * Add libosmo-rspro.pc.in for pkg-config integration + * rename executables to include osmo- name prefix + * Add Debian packaging information + * debian/control: add missing libcsv dependency + * configure.ac: Add --disable-remsim-server + * configure.ac: Add --disable-remsim-bankd + * update .gitignore + * README.md: add 'osmo-' prefix to remsim-{server,bankd,client} + * doc: REST API url is /banks, not /bankds + * bankd: Don't read CSV file until _after_ handling options + * doc: Describe how to obtains PC/SC reader string names + * remsim_server: Enable talloc tracking of msgb allocations + * remsim_client: Enable talloc tracking of msgb allocations + * rspro_server.c: Fix memory leak in processing inbound RSPRO + * remsim_client: Fix memory leak receiving RSPRO messages + * rspro_client_fsm: Fix memory leak processing RSPRO + * track libulfius and jansson memory allocations with talloc + * server: rest_api: Fix memory leak in slotmap post + + [ Joachim Steiger ] + * osmo-remsim-bankd: Fix typo in help for --num-slots + * osmo-remsim-server: add systemd service script + * osmo-remsim-bankd: add systemd service script and etc/default config + * osmo-remsim-client: add systemd service script template and etc/default configs + * add examples to the command line options for remsim-bankd and remsim-client + * add examples to remsim-server (json output) + + [ Oliver Smith ] + * contrib/jenkins.sh: run "make maintainer-clean" + + [ Martin Hauke ] + * Fix common misspellings and typos + + -- Harald Welte Sun, 21 Jul 2019 21:12:24 +0200 + osmo-remsim (0.1.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id486c05b6564c77df9f04a051ef508fecd7885d6 Gerrit-Change-Number: 14885 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 19:15:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 19:15:05 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-remsim=5Bmaster=5D=3A_Bump_version=3A_0=2E1=2E0=2E29-e7f7_=E2=86=92_0=2E2=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14885 ) Change subject: Bump version: 0.1.0.29-e7f7 ? 0.2.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id486c05b6564c77df9f04a051ef508fecd7885d6 Gerrit-Change-Number: 14885 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sun, 21 Jul 2019 19:15:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 19:20:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 19:20:05 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-remsim=5Bmaster=5D=3A_Bump_version=3A_0=2E1=2E0=2E29-e7f7_=E2=86=92_0=2E2=2E0?= In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14885 ) Change subject: Bump version: 0.1.0.29-e7f7 ? 0.2.0 ...................................................................... Bump version: 0.1.0.29-e7f7 ? 0.2.0 Change-Id: Id486c05b6564c77df9f04a051ef508fecd7885d6 --- M debian/changelog 1 file changed, 42 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/changelog b/debian/changelog index ca4d246..d2de5eb 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,45 @@ +osmo-remsim (0.2.0) unstable; urgency=medium + + [ Harald Welte ] + * bankd: move bank_id / num_slots from g_bankd to remsim_srv_conn + * bankd: Use configured bank_id/nr_slots in ConnectBankReq + * cosmetic: remove some FIXME that actually are already fixed + * Makefile.am: Fix dependency of server on libosmo-rspro.la + * Add libosmo-rspro.pc.in for pkg-config integration + * rename executables to include osmo- name prefix + * Add Debian packaging information + * debian/control: add missing libcsv dependency + * configure.ac: Add --disable-remsim-server + * configure.ac: Add --disable-remsim-bankd + * update .gitignore + * README.md: add 'osmo-' prefix to remsim-{server,bankd,client} + * doc: REST API url is /banks, not /bankds + * bankd: Don't read CSV file until _after_ handling options + * doc: Describe how to obtains PC/SC reader string names + * remsim_server: Enable talloc tracking of msgb allocations + * remsim_client: Enable talloc tracking of msgb allocations + * rspro_server.c: Fix memory leak in processing inbound RSPRO + * remsim_client: Fix memory leak receiving RSPRO messages + * rspro_client_fsm: Fix memory leak processing RSPRO + * track libulfius and jansson memory allocations with talloc + * server: rest_api: Fix memory leak in slotmap post + + [ Joachim Steiger ] + * osmo-remsim-bankd: Fix typo in help for --num-slots + * osmo-remsim-server: add systemd service script + * osmo-remsim-bankd: add systemd service script and etc/default config + * osmo-remsim-client: add systemd service script template and etc/default configs + * add examples to the command line options for remsim-bankd and remsim-client + * add examples to remsim-server (json output) + + [ Oliver Smith ] + * contrib/jenkins.sh: run "make maintainer-clean" + + [ Martin Hauke ] + * Fix common misspellings and typos + + -- Harald Welte Sun, 21 Jul 2019 21:12:24 +0200 + osmo-remsim (0.1.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id486c05b6564c77df9f04a051ef508fecd7885d6 Gerrit-Change-Number: 14885 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 19:27:38 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 19:27:38 +0000 Subject: Change in ...libosmo-abis[master]: extend the ipa keepalive fsm In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14742 ) Change subject: extend the ipa keepalive fsm ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14742 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b Gerrit-Change-Number: 14742 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 19:27:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 19:27:40 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 19:27:40 +0000 Subject: Change in ...libosmo-abis[master]: extend the ipa keepalive fsm In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14742 ) Change subject: extend the ipa keepalive fsm ...................................................................... extend the ipa keepalive fsm The new and improved fsm supports multipe use cases: 1) plain old ipa server/client operation 2) ipa client/server operation with custom send callback (i.e. to bypass the tx queue) 3) all of the above + custom timeout callback 4) fully generic operation that will pass opaque data to the callbacks The current code will always kill the fsm and deallocate it upon timeout, so the timeout callback will now return a value: 1 means the fsm will be automatically terminated, 0 means no action, which allows manually stopping/starting the fsm to reuse it. Change-Id: Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b --- M include/osmocom/abis/ipa.h M src/input/ipa_keepalive.c 2 files changed, 58 insertions(+), 9 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/abis/ipa.h b/include/osmocom/abis/ipa.h index 4f6081f..ff00697 100644 --- a/include/osmocom/abis/ipa.h +++ b/include/osmocom/abis/ipa.h @@ -113,7 +113,9 @@ unsigned int wait_for_resp; }; -typedef void ipa_keepalive_timeout_cb_t(struct osmo_fsm_inst *fi, void *conn); +typedef int ipa_keepalive_timeout_cb_t(struct osmo_fsm_inst *fi, void *conn); + +typedef void ipa_keepalive_send_cb_t(struct osmo_fsm_inst *fi, void *conn, struct msgb *msg); struct osmo_fsm_inst *ipa_client_conn_alloc_keepalive_fsm(struct ipa_client_conn *client, const struct ipa_keepalive_params *params, @@ -123,12 +125,14 @@ const struct ipa_keepalive_params *params, const char *id); -struct osmo_fsm_inst *ipa_keepalive_alloc_server(struct ipa_server_conn *server, - const struct ipa_keepalive_params *params, - const char *id); +struct osmo_fsm_inst *ipa_generic_conn_alloc_keepalive_fsm(void *ctx, void* data, + const struct ipa_keepalive_params *params, + const char *id); void ipa_keepalive_fsm_set_timeout_cb(struct osmo_fsm_inst *fi, ipa_keepalive_timeout_cb_t *cb); +void ipa_keepalive_fsm_set_send_cb(struct osmo_fsm_inst *fi, ipa_keepalive_send_cb_t *fn); + void ipa_keepalive_fsm_start(struct osmo_fsm_inst *fi); void ipa_keepalive_fsm_stop(struct osmo_fsm_inst *fi); diff --git a/src/input/ipa_keepalive.c b/src/input/ipa_keepalive.c index 81b5a26..d8eec77 100644 --- a/src/input/ipa_keepalive.c +++ b/src/input/ipa_keepalive.c @@ -76,7 +76,9 @@ struct ipa_server_conn *srv_conn; struct ipa_client_conn *client_conn; + void *generic; ipa_keepalive_timeout_cb_t *timeout_cb; + ipa_keepalive_send_cb_t *send_fn; }; static void ipa_ka_init(struct osmo_fsm_inst *fi, uint32_t event, void *data) @@ -103,11 +105,23 @@ msg = gen_ipa_ping(); OSMO_ASSERT(msg); - if (ifp->srv_conn) - ipa_server_conn_send(ifp->srv_conn, msg); + if (ifp->send_fn && ifp->generic) { + ifp->send_fn(fi, ifp->generic, msg); + return; + } + + if (ifp->srv_conn) { + if (ifp->send_fn) + ifp->send_fn(fi, ifp->srv_conn, msg); + else + ipa_server_conn_send(ifp->srv_conn, msg); + } else { OSMO_ASSERT(ifp->client_conn); - ipa_client_conn_send(ifp->client_conn, msg); + if (ifp->send_fn) + ifp->send_fn(fi, ifp->client_conn, msg); + else + ipa_client_conn_send(ifp->client_conn, msg); } } @@ -140,10 +154,12 @@ /* PONG not received within time */ if (ifp->srv_conn) conn = ifp->srv_conn; - else + else if (ifp->client_conn) conn = ifp->client_conn; + else + conn = ifp->generic; if (ifp->timeout_cb) - ifp->timeout_cb(fi, conn); + return ifp->timeout_cb(fi, conn); /* ask fsm core to terminate us */ return 1; default: @@ -261,6 +277,27 @@ return fi; } +/*! Create a new instance of an IPA keepalive FSM: Periodically transmit PING and expect PONG. + * \param[in] ctx Talloc context. + * \param[in] data Data to pass to write/timeout cb. + * \param[in] params Parameters describing the keepalive FSM time-outs. + * \param[in] id String used as identifier for the FSM. + * \returns pointer to the newly-created FSM instance; NULL in case of error. */ +struct osmo_fsm_inst *ipa_generic_conn_alloc_keepalive_fsm(void *ctx, void* data, + const struct ipa_keepalive_params *params, + const char *id) +{ + struct osmo_fsm_inst *fi; + struct ipa_fsm_priv *ifp; + + fi = __ipa_conn_alloc_keepalive_fsm(ctx, params, id); + if (!fi) + return NULL; + ifp = fi->priv; + ifp->generic = data; + return fi; +} + /*! Set a timeout call-back which is to be called once the peer doesn't respond anymore */ void ipa_keepalive_fsm_set_timeout_cb(struct osmo_fsm_inst *fi, ipa_keepalive_timeout_cb_t *cb) { @@ -269,6 +306,14 @@ ifp->timeout_cb = cb; } +/*! Set a custom send callback for sending pings */ +void ipa_keepalive_fsm_set_send_cb(struct osmo_fsm_inst *fi, ipa_keepalive_send_cb_t *fn) +{ + struct ipa_fsm_priv *ifp = fi->priv; + OSMO_ASSERT(fi->fsm == &ipa_keepalive_fsm); + ifp->send_fn = fn; +} + /*! Inform IPA Keepalive FSM that a PONG has been received. */ void ipa_keepalive_fsm_pong_received(struct osmo_fsm_inst *fi) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14742 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b Gerrit-Change-Number: 14742 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 19:33:54 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 19:33:54 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Elibosmo-abis=5Bmaster=5D=3A_Bump_version=3A_0=2E6=2E0=2E13-b4a7_=E2=86=92_0=2E7=2E0?= Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14886 Change subject: Bump version: 0.6.0.13-b4a7 ? 0.7.0 ...................................................................... Bump version: 0.6.0.13-b4a7 ? 0.7.0 Change-Id: Ia5ecb2f69ce5436cae8d7a2d300e446ff24e84bc --- M debian/changelog M src/Makefile.am 2 files changed, 32 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/86/14886/1 diff --git a/debian/changelog b/debian/changelog index 6a6882d..db17338 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,33 @@ +libosmo-abis (0.7.0) unstable; urgency=medium + + [ Max ] + * Set local IP in ipa_server_link properly + * Log peer's port in accept callback + + [ Harald Welte ] + * ipa: Make ipa_server_conn_destroy() re-entrant + * Add IPA keep-alive FSM implementation + * ipa_keepalive_fsm: Fix OSMO_IPA_KA_E_STOP allstate event + * ipa_keepalive_fsm: Suppress error messages for INIT -> INIT transition + * ipaccess.c: Avoid calling close(-1) on error path + + [ Oliver Smith ] + * tests: use -no-install libtool flag to avoid ./lt-* scripts + * contrib/jenkins.sh: run "make maintainer-clean" + + [ Sylvain Munaut ] + * rtp: Add 'autoconnect' feature to the osmo_rtp_socket + + [ Eric Wild ] + * ipaccess: allow tcp keepalive for ipa clients + * add TCP_USER_TIMEOUT to keepalive + * extend the ipa keepalive fsm + + [ Debian Mobcom Maintainers ] + * spelling + + -- Harald Welte Sun, 21 Jul 2019 21:32:08 +0200 + libosmo-abis (0.6.0) unstable; urgency=medium [ Neels Hofmeyr ] diff --git a/src/Makefile.am b/src/Makefile.am index 2d2424d..f4277ae 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,8 +1,8 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -ABIS_LIBVERSION=6:2:0 -TRAU_LIBVERSION=3:2:1 +ABIS_LIBVERSION=7:0:1 +TRAU_LIBVERSION=4:0:2 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir) AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(COVERAGE_CFLAGS) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14886 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia5ecb2f69ce5436cae8d7a2d300e446ff24e84bc Gerrit-Change-Number: 14886 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 19:35:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 19:35:36 +0000 Subject: Change in ...osmo-ci[master]: latest-packages: Enable osmo-remsim as new libosmo-abis is tagged Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14887 Change subject: latest-packages: Enable osmo-remsim as new libosmo-abis is tagged ...................................................................... latest-packages: Enable osmo-remsim as new libosmo-abis is tagged Change-Id: Id1902f8b79357ac280767edba3698450f67b7c37 --- M scripts/osmocom-latest-packages.sh 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/87/14887/1 diff --git a/scripts/osmocom-latest-packages.sh b/scripts/osmocom-latest-packages.sh index 2a9e28d..1074294 100755 --- a/scripts/osmocom-latest-packages.sh +++ b/scripts/osmocom-latest-packages.sh @@ -156,8 +156,7 @@ checkout simtrace2 checkout libosmo-dsp checkout osmo-sysmon - # TODO: enable once libosmo-abis > 0.6.0 is available (IPA keepalive FSM) - # checkout osmo-remsim + checkout osmo-remsim checkout_copy_debian8_jessie "osmo-gsm-manuals" @@ -189,8 +188,7 @@ build simtrace2 build libosmo-dsp build osmo-sysmon - # TODO: enable once libosmo-abis > 0.6.0 is available (IPA keepalive FSM) - # build osmo-remsim + build osmo-remsim cd "$TOP/$PROJ" osc ci -m "Latest Tagged versions of $DT" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id1902f8b79357ac280767edba3698450f67b7c37 Gerrit-Change-Number: 14887 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 19:38:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 19:38:56 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Elibosmo-abis=5Bmaster=5D=3A_Bump_version=3A_0=2E6=2E0=2E13-b4a7_=E2=86=92_0=2E7=2E0?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14886 ) Change subject: Bump version: 0.6.0.13-b4a7 ? 0.7.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14886 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia5ecb2f69ce5436cae8d7a2d300e446ff24e84bc Gerrit-Change-Number: 14886 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 19:38:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 19:39:17 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 19:39:17 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Elibosmo-abis=5Bmaster=5D=3A_Bump_version=3A_0=2E6=2E0=2E13-b4a7_=E2=86=92_0=2E7=2E0?= In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14886 ) Change subject: Bump version: 0.6.0.13-b4a7 ? 0.7.0 ...................................................................... Bump version: 0.6.0.13-b4a7 ? 0.7.0 Change-Id: Ia5ecb2f69ce5436cae8d7a2d300e446ff24e84bc --- M debian/changelog M src/Makefile.am 2 files changed, 32 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 6a6882d..db17338 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,33 @@ +libosmo-abis (0.7.0) unstable; urgency=medium + + [ Max ] + * Set local IP in ipa_server_link properly + * Log peer's port in accept callback + + [ Harald Welte ] + * ipa: Make ipa_server_conn_destroy() re-entrant + * Add IPA keep-alive FSM implementation + * ipa_keepalive_fsm: Fix OSMO_IPA_KA_E_STOP allstate event + * ipa_keepalive_fsm: Suppress error messages for INIT -> INIT transition + * ipaccess.c: Avoid calling close(-1) on error path + + [ Oliver Smith ] + * tests: use -no-install libtool flag to avoid ./lt-* scripts + * contrib/jenkins.sh: run "make maintainer-clean" + + [ Sylvain Munaut ] + * rtp: Add 'autoconnect' feature to the osmo_rtp_socket + + [ Eric Wild ] + * ipaccess: allow tcp keepalive for ipa clients + * add TCP_USER_TIMEOUT to keepalive + * extend the ipa keepalive fsm + + [ Debian Mobcom Maintainers ] + * spelling + + -- Harald Welte Sun, 21 Jul 2019 21:32:08 +0200 + libosmo-abis (0.6.0) unstable; urgency=medium [ Neels Hofmeyr ] diff --git a/src/Makefile.am b/src/Makefile.am index 2d2424d..f4277ae 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,8 +1,8 @@ # This is _NOT_ the library release version, it's an API version. # Please read chapter "Library interface versions" of the libtool documentation # before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html -ABIS_LIBVERSION=6:2:0 -TRAU_LIBVERSION=3:2:1 +ABIS_LIBVERSION=7:0:1 +TRAU_LIBVERSION=4:0:2 AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir) AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(COVERAGE_CFLAGS) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14886 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia5ecb2f69ce5436cae8d7a2d300e446ff24e84bc Gerrit-Change-Number: 14886 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 19:39:26 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 19:39:26 +0000 Subject: Change in ...osmo-ci[master]: latest-packages: Enable osmo-remsim as new libosmo-abis is tagged In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14887 ) Change subject: latest-packages: Enable osmo-remsim as new libosmo-abis is tagged ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id1902f8b79357ac280767edba3698450f67b7c37 Gerrit-Change-Number: 14887 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-Comment-Date: Sun, 21 Jul 2019 19:39:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sun Jul 21 19:39:27 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Sun, 21 Jul 2019 19:39:27 +0000 Subject: Change in ...osmo-ci[master]: latest-packages: Enable osmo-remsim as new libosmo-abis is tagged In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/14887 ) Change subject: latest-packages: Enable osmo-remsim as new libosmo-abis is tagged ...................................................................... latest-packages: Enable osmo-remsim as new libosmo-abis is tagged Change-Id: Id1902f8b79357ac280767edba3698450f67b7c37 --- M scripts/osmocom-latest-packages.sh 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/scripts/osmocom-latest-packages.sh b/scripts/osmocom-latest-packages.sh index 2a9e28d..1074294 100755 --- a/scripts/osmocom-latest-packages.sh +++ b/scripts/osmocom-latest-packages.sh @@ -156,8 +156,7 @@ checkout simtrace2 checkout libosmo-dsp checkout osmo-sysmon - # TODO: enable once libosmo-abis > 0.6.0 is available (IPA keepalive FSM) - # checkout osmo-remsim + checkout osmo-remsim checkout_copy_debian8_jessie "osmo-gsm-manuals" @@ -189,8 +188,7 @@ build simtrace2 build libosmo-dsp build osmo-sysmon - # TODO: enable once libosmo-abis > 0.6.0 is available (IPA keepalive FSM) - # build osmo-remsim + build osmo-remsim cd "$TOP/$PROJ" osc ci -m "Latest Tagged versions of $DT" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14887 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id1902f8b79357ac280767edba3698450f67b7c37 Gerrit-Change-Number: 14887 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 06:24:25 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 22 Jul 2019 06:24:25 +0000 Subject: Change in ...osmo-gsm-manuals[master]: Makefile.asciidoc.inc: Export commondir attribute to asciidoc files In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14838 ) Change subject: Makefile.asciidoc.inc: Export commondir attribute to asciidoc files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14838 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ifc2fdaf1a87d0715213b4eab13c6c9a4f8a987fd Gerrit-Change-Number: 14838 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 22 Jul 2019 06:24:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Mon Jul 22 06:30:39 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 06:30:39 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in xUbuntu_19.04/x86_64 In-Reply-To: References: Message-ID: <5d355816dcbfb_d3a6545f0700876@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/xUbuntu_19.04/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in xUbuntu_19.04/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 127s] | #define HAVE_STDLIB_H 1 [ 127s] | #define HAVE_STRING_H 1 [ 127s] | #define HAVE_MEMORY_H 1 [ 127s] | #define HAVE_STRINGS_H 1 [ 127s] | #define HAVE_INTTYPES_H 1 [ 127s] | #define HAVE_STDINT_H 1 [ 127s] | #define HAVE_UNISTD_H 1 [ 127s] | #define HAVE_DLFCN_H 1 [ 127s] | #define LT_OBJDIR ".libs/" [ 127s] | #define PACKAGE "osmo-hlr" [ 127s] | #define VERSION "1.0.0" [ 127s] | #define STDC_HEADERS 1 [ 127s] | [ 127s] | configure: exit 0 [ 127s] [ 127s] make[1]: *** [debian/rules:17: override_dh_auto_test] Error 1 [ 127s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 127s] make: *** [debian/rules:7: build] Error 2 [ 127s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 127s] [ 127s] morla3 failed "build osmo-hlr_1.0.0.dsc" at Mon Jul 22 06:30:22 UTC 2019. [ 127s] [ 127s] ### VM INTERACTION START ### [ 130s] [ 114.946859] sysrq: SysRq : Power Off [ 130s] [ 114.953523] reboot: Power down [ 130s] ### VM INTERACTION END ### [ 130s] [ 130s] morla3 failed "build osmo-hlr_1.0.0.dsc" at Mon Jul 22 06:30:26 UTC 2019. [ 130s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Jul 22 06:43:16 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 22 Jul 2019 06:43:16 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: Introduce Osmux documentation In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 ) Change subject: common: Introduce Osmux documentation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e Gerrit-Change-Number: 14839 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 22 Jul 2019 06:43:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 06:57:17 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 22 Jul 2019 06:57:17 +0000 Subject: Change in ...osmo-bsc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14840 ) Change subject: doc: Add Osmux documentation to User Manual ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14840/1/doc/manuals/chapters/osmux_bsc.adoc File doc/manuals/chapters/osmux_bsc.adoc: https://gerrit.osmocom.org/#/c/14840/1/doc/manuals/chapters/osmux_bsc.adoc at 7 PS1, Line 7: In this kind of setup, Osmux is transparent to {program-name} and no specific What is the advantage of using {program-name}? Since this file is not in common, it will always be OsmoBSC, right? Also OsmoBSC is hardcoded a few times throughout the document already. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75dcdddc713b0dc43e2ba577ca377c20fc511f38 Gerrit-Change-Number: 14840 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-CC: osmith Gerrit-Comment-Date: Mon, 22 Jul 2019 06:57:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 08:03:51 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 08:03:51 +0000 Subject: Change in ...osmo-bsc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14840 ) Change subject: doc: Add Osmux documentation to User Manual ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14840/1/doc/manuals/chapters/osmux_bsc.adoc File doc/manuals/chapters/osmux_bsc.adoc: https://gerrit.osmocom.org/#/c/14840/1/doc/manuals/chapters/osmux_bsc.adoc at 7 PS1, Line 7: In this kind of setup, Osmux is transparent to {program-name} and no specific > What is the advantage of using {program-name}? Since this file is not in common, it will always be O [?] This way I make sure same content is used everywhere without needing to care about how we really want to call the program, be it osmobsc, OsmoBSC, osmo-bsc, osmo-nitb, whatever. It also makes it easier in case you want to re-use it for other programs/processes. I'll change hardcoded OsmoBSC ones into {program-name}. https://gerrit.osmocom.org/#/c/14840/1/doc/manuals/chapters/osmux_bsc.adoc at 18 PS1, Line 18: appending the _Osmux Support_ IE in _BSSMAP RESET_ and _BSSMAP RESET ACK_ > same comment about non-standard nature of the IE applies here, also the comment about recommending t [?] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75dcdddc713b0dc43e2ba577ca377c20fc511f38 Gerrit-Change-Number: 14840 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-CC: osmith Gerrit-Comment-Date: Mon, 22 Jul 2019 08:03:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Comment-In-Reply-To: osmith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 08:14:42 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 08:14:42 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: Introduce Osmux documentation In-Reply-To: References: Message-ID: Hello laforge, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 to look at the new patch set (#2). Change subject: common: Introduce Osmux documentation ...................................................................... common: Introduce Osmux documentation Change-Id: I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e --- A common/chapters/osmux/mgcp_extension_osmux.adoc A common/chapters/osmux/mo_call_osmux_aoip.msc A common/chapters/osmux/mo_call_osmux_sccplite.msc A common/chapters/osmux/mo_call_osmux_sccplite_nat.msc A common/chapters/osmux/network_osmux_aoip.dot A common/chapters/osmux/network_osmux_sccplite.dot A common/chapters/osmux/network_osmux_sccplite_nat.dot A common/chapters/osmux/osmux.adoc 8 files changed, 550 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/39/14839/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e Gerrit-Change-Number: 14839 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 08:17:39 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 08:17:39 +0000 Subject: Change in ...osmo-gsm-manuals[master]: Makefile.asciidoc.inc: Export commondir attribute to asciidoc files In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14838 ) Change subject: Makefile.asciidoc.inc: Export commondir attribute to asciidoc files ...................................................................... Makefile.asciidoc.inc: Export commondir attribute to asciidoc files Otherwise, adoc files in osmo-*/doc/manuals/chapters/*.adoc cannot include files from osmo-gsm-manuals/common/chapters/*.adoc, since symbolic link to common/ is only available in builddir, but not in srcdir. This way, those files can include commons files like this: include::{commondir}/chapters/foobar.adoc Change-Id: Ifc2fdaf1a87d0715213b4eab13c6c9a4f8a987fd --- M build/Makefile.asciidoc.inc 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/build/Makefile.asciidoc.inc b/build/Makefile.asciidoc.inc index fb44a63..1bed968 100644 --- a/build/Makefile.asciidoc.inc +++ b/build/Makefile.asciidoc.inc @@ -17,6 +17,7 @@ # osmo_yada.pdf: yada/*.adoc yada/*.msc BUILDDIR = $(OSMO_GSM_MANUALS_DIR)/build +COMMONDIR = $(OSMO_GSM_MANUALS_DIR)/common GIT_VERSION := $(shell git describe --abbrev=4 --dirty --always --tags) GIT_DATE := $(shell $(OSMO_GSM_MANUALS_DIR)/build/unix-time-to-fmt.py `git log -n 1 "--pretty=%at" ../.`) @@ -36,7 +37,7 @@ CLEAN_FILES += $(ASCIIDOC_PDF) $(ASCIIDOC_NAME:%=%.html) UPLOAD_FILES += $(ASCIIDOC_PDF) -ASCIIDOC_OPTS := -f $(BUILDDIR)/mscgen-filter.conf -f $(BUILDDIR)/diag-filter.conf -f $(BUILDDIR)/docinfo-releaseinfo.conf -f $(BUILDDIR)/python2-filter.conf -a srcdir='$(srcdir)' +ASCIIDOC_OPTS := -f $(BUILDDIR)/mscgen-filter.conf -f $(BUILDDIR)/diag-filter.conf -f $(BUILDDIR)/docinfo-releaseinfo.conf -f $(BUILDDIR)/python2-filter.conf -a srcdir='$(srcdir)' -a commondir='$(COMMONDIR)' DBLATEX_OPTS := -s $(ASCIIDOCSTYLE) -P draft.mode=yes -P draft.watermark=0 ifeq (,$(BUILD_RELEASE)) @@ -53,8 +54,8 @@ $(ASCIIDOC_PDF): %.pdf: %.adoc %-docinfo.xml \ $(ASCIIDOC_DEPS) \ $(ASCIIDOCSTYLE) \ - $(OSMO_GSM_MANUALS_DIR)/common/*/*.adoc \ - $(OSMO_GSM_MANUALS_DIR)/common/images/* \ + $(COMMONDIR)/*/*.adoc \ + $(COMMONDIR)/images/* \ build common # a2x can't use a different output file. To support out-of-tree builds, @@ -79,7 +80,7 @@ $(ASCIIDOC_CHECKS): %.check: %.adoc %-docinfo.xml \ $(ASCIIDOCSTYLE) \ - $(OSMO_GSM_MANUALS_DIR)/common/chapters/*.adoc \ + $(COMMONDIR)/chapters/*.adoc \ $(ASCIIDOC_DEPS) \ build common -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14838 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ifc2fdaf1a87d0715213b4eab13c6c9a4f8a987fd Gerrit-Change-Number: 14838 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 08:23:09 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 08:23:09 +0000 Subject: Change in ...osmo-msc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 to look at the new patch set (#2). Change subject: doc: Add Osmux documentation to User Manual ...................................................................... doc: Add Osmux documentation to User Manual Depends: osmo-gsm-manuals.git f3a734e6777a902abfb03257277454c7a879aeb7 Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 --- A doc/manuals/chapters/osmux_msc.adoc M doc/manuals/osmomsc-usermanual.adoc 2 files changed, 67 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/14841/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 Gerrit-Change-Number: 14841 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 08:28:16 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 08:28:16 +0000 Subject: Change in ...osmo-msc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 to look at the new patch set (#3). Change subject: doc: Add Osmux documentation to User Manual ...................................................................... doc: Add Osmux documentation to User Manual Depends: osmo-gsm-manuals.git f3a734e6777a902abfb03257277454c7a879aeb7 Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 --- A doc/manuals/chapters/osmux_msc.adoc M doc/manuals/osmomsc-usermanual.adoc 2 files changed, 67 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/14841/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 Gerrit-Change-Number: 14841 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 08:31:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 08:31:25 +0000 Subject: Change in ...osmo-msc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 to look at the new patch set (#4). Change subject: doc: Add Osmux documentation to User Manual ...................................................................... doc: Add Osmux documentation to User Manual Depends: osmo-gsm-manuals.git f3a734e6777a902abfb03257277454c7a879aeb7 Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 --- A doc/manuals/chapters/osmux_msc.adoc M doc/manuals/osmomsc-usermanual.adoc 2 files changed, 67 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/14841/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 Gerrit-Change-Number: 14841 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 08:32:01 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 08:32:01 +0000 Subject: Change in ...osmo-bsc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/14840 to look at the new patch set (#2). Change subject: doc: Add Osmux documentation to User Manual ...................................................................... doc: Add Osmux documentation to User Manual Depends: osmo-gsm-manuals.git f3a734e6777a902abfb03257277454c7a879aeb7 Change-Id: I75dcdddc713b0dc43e2ba577ca377c20fc511f38 --- A doc/manuals/chapters/osmux_bsc.adoc M doc/manuals/osmobsc-usermanual.adoc 2 files changed, 46 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/40/14840/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75dcdddc713b0dc43e2ba577ca377c20fc511f38 Gerrit-Change-Number: 14840 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-CC: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 08:34:05 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 08:34:05 +0000 Subject: Change in ...osmo-msc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 to look at the new patch set (#5). Change subject: doc: Add Osmux documentation to User Manual ...................................................................... doc: Add Osmux documentation to User Manual Depends: osmo-gsm-manuals.git f3a734e6777a902abfb03257277454c7a879aeb7 Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 --- A doc/manuals/chapters/osmux_msc.adoc M doc/manuals/osmomsc-usermanual.adoc 2 files changed, 67 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/14841/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 Gerrit-Change-Number: 14841 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 08:34:28 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 08:34:28 +0000 Subject: Change in ...osmo-bsc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/14840 to look at the new patch set (#3). Change subject: doc: Add Osmux documentation to User Manual ...................................................................... doc: Add Osmux documentation to User Manual Depends: osmo-gsm-manuals.git f3a734e6777a902abfb03257277454c7a879aeb7 Change-Id: I75dcdddc713b0dc43e2ba577ca377c20fc511f38 --- A doc/manuals/chapters/osmux_bsc.adoc M doc/manuals/osmobsc-usermanual.adoc 2 files changed, 46 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/40/14840/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75dcdddc713b0dc43e2ba577ca377c20fc511f38 Gerrit-Change-Number: 14840 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-CC: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 09:36:21 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 22 Jul 2019 09:36:21 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: library: allow "?" in tr_ML3_MT_MM_ID_Req again In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 to look at the new patch set (#3). Change subject: library: allow "?" in tr_ML3_MT_MM_ID_Req again ...................................................................... library: allow "?" in tr_ML3_MT_MM_ID_Req again Fix MSC test TC_lu_by_imei, which uses tr_ML3_MT_MM_ID_Req with the default "?" (AnyElement) parameter. It was failing with the following runtime error: Dynamic test case error: Performing a valueof or send operation on a non-specific template of enumerated type @L3_Templates.CmIdentityType. Fixes: 328984591372ad5abf51655a51d45d880bfed182 ("L3_Templates: add enum CmIdentityType") Related: https://www.eclipse.org/forums/index.php/t/1099816/ Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b --- M library/L3_Templates.ttcn 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/55/14755/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b Gerrit-Change-Number: 14755 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 09:38:00 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 22 Jul 2019 09:38:00 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: library: allow "?" in tr_ML3_MT_MM_ID_Req again In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 ) Change subject: library: allow "?" in tr_ML3_MT_MM_ID_Req again ...................................................................... Patch Set 3: Updated to fix the template with a conversion function, as you've proposed in the meeting. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b Gerrit-Change-Number: 14755 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 22 Jul 2019 09:38:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 10:06:45 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 10:06:45 +0000 Subject: Change in ...osmo-trx[master]: debian/copyright: Remove non existent radioInterfaceDiversity.cpp fro... Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14888 Change subject: debian/copyright: Remove non existent radioInterfaceDiversity.cpp from list ...................................................................... debian/copyright: Remove non existent radioInterfaceDiversity.cpp from list Change-Id: I5cfbbafd411e580421f86df6817f91261aceda7e --- M debian/copyright 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/88/14888/1 diff --git a/debian/copyright b/debian/copyright index b7790f2..970d427 100644 --- a/debian/copyright +++ b/debian/copyright @@ -15,7 +15,6 @@ Transceiver52M/Resampler.cpp Transceiver52M/Resampler.h Transceiver52M/osmo-trx.cpp - Transceiver52M/radioInterfaceDiversity.cpp Copyright: 2012-2013 Thomas Tsou License: LGPL-2.1+ -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14888 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5cfbbafd411e580421f86df6817f91261aceda7e Gerrit-Change-Number: 14888 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 10:06:45 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 10:06:45 +0000 Subject: Change in ...osmo-trx[master]: debian/copyright: Update wrong paths in license list Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14889 Change subject: debian/copyright: Update wrong paths in license list ...................................................................... debian/copyright: Update wrong paths in license list Those paths were moved into a subdir a while ago, but this file was not updated at the time. Change-Id: I1857338b7a19e2a37f62386ceb4a1fad988272ba --- M debian/copyright 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/89/14889/1 diff --git a/debian/copyright b/debian/copyright index 970d427..208eacd 100644 --- a/debian/copyright +++ b/debian/copyright @@ -9,9 +9,9 @@ 2010-2012 Range Networks, Inc. License: AGPL-3+ -Files: Transceiver52M/arm/* - Transceiver52M/x86/* - Transceiver52M/common/* +Files: Transceiver52M/arch/arm/* + Transceiver52M/arch/x86/* + Transceiver52M/arch/common/* Transceiver52M/Resampler.cpp Transceiver52M/Resampler.h Transceiver52M/osmo-trx.cpp -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14889 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1857338b7a19e2a37f62386ceb4a1fad988272ba Gerrit-Change-Number: 14889 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 10:06:46 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 10:06:46 +0000 Subject: Change in ...osmo-trx[master]: debian/copyright: Add missing file Utils.* to LGPL-2.1+ list Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14890 Change subject: debian/copyright: Add missing file Utils.* to LGPL-2.1+ list ...................................................................... debian/copyright: Add missing file Utils.* to LGPL-2.1+ list Change-Id: I36b8b8be48ae8676688786f39008d08b61011ede --- M debian/copyright 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/90/14890/1 diff --git a/debian/copyright b/debian/copyright index 208eacd..4a5d3c1 100644 --- a/debian/copyright +++ b/debian/copyright @@ -14,6 +14,8 @@ Transceiver52M/arch/common/* Transceiver52M/Resampler.cpp Transceiver52M/Resampler.h + Transceiver52M/Utils.cpp + Transceiver52M/Utils.h Transceiver52M/osmo-trx.cpp Copyright: 2012-2013 Thomas Tsou License: LGPL-2.1+ -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36b8b8be48ae8676688786f39008d08b61011ede Gerrit-Change-Number: 14890 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 10:06:47 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 10:06:47 +0000 Subject: Change in ...osmo-trx[master]: cosmetic: Fix trailing whitespace in several files Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14891 Change subject: cosmetic: Fix trailing whitespace in several files ...................................................................... cosmetic: Fix trailing whitespace in several files Change-Id: Ifafb68353960fc5046661854ccfb8d783b0efb14 --- M CommonLibs/Interthread.h M CommonLibs/Timeval.cpp M GSM/GSMCommon.h M Transceiver52M/Channelizer.cpp M Transceiver52M/ChannelizerBase.cpp M Transceiver52M/Resampler.cpp M Transceiver52M/Resampler.h M Transceiver52M/Synthesis.cpp M Transceiver52M/arch/arm/mult_neon.S M Transceiver52M/arch/common/convert_base.c M Transceiver52M/arch/common/fft.c M Transceiver52M/radioBuffer.cpp M tests/CommonLibs/BitVectorTest.cpp 13 files changed, 40 insertions(+), 41 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/91/14891/1 diff --git a/CommonLibs/Interthread.h b/CommonLibs/Interthread.h index 42e6f7f..185112f 100644 --- a/CommonLibs/Interthread.h +++ b/CommonLibs/Interthread.h @@ -53,7 +53,7 @@ protected: - Fifo mQ; + Fifo mQ; mutable Mutex mLock; mutable Signal mWriteSignal; @@ -160,7 +160,7 @@ protected: - Fifo mQ; + Fifo mQ; mutable Mutex mLock; mutable Signal mWriteSignal; @@ -256,7 +256,7 @@ // This recurs (and the InterthreadQueue fills up with data) // until the read thread's accumulated temporary priority causes it to // get a second pre-emptive activation over the writing thread, - // resulting in bursts of activity by the read thread. + // resulting in bursts of activity by the read thread. { ScopedLock lock(mLock); mQ.put(val); } @@ -281,7 +281,7 @@ protected: - PointerFIFO mQ; + PointerFIFO mQ; mutable Mutex mLock; mutable Signal mWriteSignal; mutable Signal mReadSignal; diff --git a/CommonLibs/Timeval.cpp b/CommonLibs/Timeval.cpp index 420dd04..60bf7f6 100644 --- a/CommonLibs/Timeval.cpp +++ b/CommonLibs/Timeval.cpp @@ -81,7 +81,7 @@ int32_t deltaNs = other.nsec() - nsec(); return 1000*deltaS + deltaNs/1000000; } - + diff --git a/GSM/GSMCommon.h b/GSM/GSMCommon.h index f703c30..a3ada26 100644 --- a/GSM/GSMCommon.h +++ b/GSM/GSMCommon.h @@ -166,7 +166,7 @@ unsigned newTN = (mTN + other.mTN) % 8; uint64_t newFN = (mFN+other.mFN + (mTN + other.mTN)/8) % gHyperframe; return Time(newFN,newTN); - } + } int operator-(const Time& other) const { diff --git a/Transceiver52M/Channelizer.cpp b/Transceiver52M/Channelizer.cpp index a18dd03..1e4d7d4 100644 --- a/Transceiver52M/Channelizer.cpp +++ b/Transceiver52M/Channelizer.cpp @@ -1,6 +1,6 @@ /* * Polyphase channelizer - * + * * Copyright (C) 2012-2014 Tom Tsou * Copyright (C) 2015 Ettus Research LLC * @@ -63,7 +63,7 @@ return hInputs[chan]; } -/* +/* * Implementation based on material found in: * * "harris, fred, Multirate Signal Processing, Upper Saddle River, NJ, @@ -78,8 +78,8 @@ deinterleave(in, len, hInputs, blockLen, m); - /* - * Convolve through filterbank while applying and saving sample history + /* + * Convolve through filterbank while applying and saving sample history */ for (size_t i = 0; i < m; i++) { memcpy(&hInputs[i][2 * -hLen], hist[i], hSize); diff --git a/Transceiver52M/ChannelizerBase.cpp b/Transceiver52M/ChannelizerBase.cpp index f5b3ed4..96f76a9 100644 --- a/Transceiver52M/ChannelizerBase.cpp +++ b/Transceiver52M/ChannelizerBase.cpp @@ -1,8 +1,8 @@ /* * Polyphase channelizer - * + * * Copyright (C) 2012-2014 Tom Tsou - * Copyright (C) 2015 Ettus Research LLC + * Copyright (C) 2015 Ettus Research LLC * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by @@ -55,10 +55,10 @@ } } -/* +/* * Create polyphase filterbank * - * Implementation based material found in, + * Implementation based material found in, * * "harris, fred, Multirate Signal Processing, Upper Saddle River, NJ, * Prentice Hall, 2006." @@ -70,7 +70,7 @@ float sum = 0.0f, scale = 0.0f; float midpt = (float) (protoLen - 1.0) / 2.0; - /* + /* * Allocate 'M' partition filters and the temporary prototype * filter. Coefficients are real only and must be 16-byte memory * aligned for SSE usage. @@ -90,7 +90,7 @@ memalign(16, hLen * 2 * sizeof(float)); } - /* + /* * Generate the prototype filter with a Blackman-harris window. * Scale coefficients with DC filter gain set to unity divided * by the number of channels. @@ -110,7 +110,7 @@ } scale = (float) m / sum; - /* + /* * Populate partition filters and reverse the coefficients per * convolution requirements. */ @@ -174,7 +174,7 @@ return true; } -/* +/* * Setup filterbank internals */ bool ChannelizerBase::init() @@ -222,7 +222,7 @@ return true; } -/* +/* * Setup channelizer paramaters */ ChannelizerBase::ChannelizerBase(size_t m, size_t blockLen, size_t hLen) diff --git a/Transceiver52M/Resampler.cpp b/Transceiver52M/Resampler.cpp index ecd8865..f545db8 100644 --- a/Transceiver52M/Resampler.cpp +++ b/Transceiver52M/Resampler.cpp @@ -51,7 +51,7 @@ float cutoff; float sum = 0.0f, scale = 0.0f; - /* + /* * Allocate partition filters and the temporary prototype filter * according to numerator of the rational rate. Coefficients are * real only and must be 16-byte memory aligned for SSE usage. @@ -60,10 +60,10 @@ for (auto &part : partitions) part = (complex *) memalign(16, filt_len * sizeof(complex)); - /* + /* * Generate the prototype filter with a Blackman-harris window. * Scale coefficients with DC filter gain set to unity divided - * by the number of filter partitions. + * by the number of filter partitions. */ float a0 = 0.35875; float a1 = 0.48829; @@ -137,8 +137,8 @@ /* Generate output from precomputed input/output paths */ for (size_t i = 0; i < out_len; i++) { - n = in_index[i]; - path = out_path[i]; + n = in_index[i]; + path = out_path[i]; convolve_real(in, in_len, reinterpret_cast(partitions[path]), diff --git a/Transceiver52M/Resampler.h b/Transceiver52M/Resampler.h index caffc08..bee2436 100644 --- a/Transceiver52M/Resampler.h +++ b/Transceiver52M/Resampler.h @@ -28,7 +28,7 @@ /* Constructor for rational sample rate conversion * @param p numerator of resampling ratio * @param q denominator of resampling ratio - * @param filt_len length of each polyphase subfilter + * @param filt_len length of each polyphase subfilter */ Resampler(size_t p, size_t q, size_t filt_len = 16); ~Resampler(); @@ -58,7 +58,7 @@ int rotate(const float *in, size_t in_len, float *out, size_t out_len); /* Get filter length - * @return number of taps in each filter partition + * @return number of taps in each filter partition */ size_t len(); diff --git a/Transceiver52M/Synthesis.cpp b/Transceiver52M/Synthesis.cpp index 6b62156..a117390 100644 --- a/Transceiver52M/Synthesis.cpp +++ b/Transceiver52M/Synthesis.cpp @@ -1,6 +1,6 @@ /* * Polyphase synthesis filter - * + * * Copyright (C) 2012-2014 Tom Tsou * Copyright (C) 2015 Ettus Research LLC * @@ -74,7 +74,7 @@ return true; } -/* +/* * Implementation based on material found in: * * "harris, fred, Multirate Signal Processing, Upper Saddle River, NJ, @@ -92,8 +92,8 @@ cxvec_fft(fftHandle); - /* - * Convolve through filterbank while applying and saving sample history + /* + * Convolve through filterbank while applying and saving sample history */ for (size_t i = 0; i < m; i++) { memcpy(&hInputs[i][2 * -hLen], hist[i], hSize); diff --git a/Transceiver52M/arch/arm/mult_neon.S b/Transceiver52M/arch/arm/mult_neon.S index 162846e..113e227 100644 --- a/Transceiver52M/arch/arm/mult_neon.S +++ b/Transceiver52M/arch/arm/mult_neon.S @@ -1,5 +1,5 @@ /* - * NEON complex multiplication + * NEON complex multiplication * Copyright (C) 2012,2013 Thomas Tsou * * This library is free software; you can redistribute it and/or diff --git a/Transceiver52M/arch/common/convert_base.c b/Transceiver52M/arch/common/convert_base.c index 5251fb8..8d29310 100644 --- a/Transceiver52M/arch/common/convert_base.c +++ b/Transceiver52M/arch/common/convert_base.c @@ -31,4 +31,3 @@ for (int i = 0; i < len; i++) out[i] = in[i]; } - diff --git a/Transceiver52M/arch/common/fft.c b/Transceiver52M/arch/common/fft.c index 18b2de7..ed79d13 100644 --- a/Transceiver52M/arch/common/fft.c +++ b/Transceiver52M/arch/common/fft.c @@ -1,18 +1,18 @@ /* - * Fast Fourier transform + * Fast Fourier transform * * Copyright (C) 2012 Tom Tsou - * + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. - * + * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU Affero General Public License for more details. - * + * * You should have received a copy of the GNU Affero General Public License * along with this program; if not, see . * See the COPYING file in the main directory for details. @@ -32,9 +32,9 @@ fftwf_plan fft_plan; }; -/*! \brief Initialize FFT backend +/*! \brief Initialize FFT backend * \param[in] reverse FFT direction - * \param[in] m FFT length + * \param[in] m FFT length * \param[in] istride input stride count * \param[in] ostride output stride count * \param[in] in input buffer (FFTW aligned) @@ -92,7 +92,7 @@ free(ptr); } -/*! \brief Free FFT backend resources +/*! \brief Free FFT backend resources */ void free_fft(struct fft_hdl *hdl) { diff --git a/Transceiver52M/radioBuffer.cpp b/Transceiver52M/radioBuffer.cpp index a2b42c4..57de364 100644 --- a/Transceiver52M/radioBuffer.cpp +++ b/Transceiver52M/radioBuffer.cpp @@ -96,7 +96,7 @@ /* * Output direction * - * Write a non-segment length of samples to the buffer. + * Write a non-segment length of samples to the buffer. */ bool RadioBuffer::write(const float *wr, size_t len) { diff --git a/tests/CommonLibs/BitVectorTest.cpp b/tests/CommonLibs/BitVectorTest.cpp index 063138f..74c7d45 100644 --- a/tests/CommonLibs/BitVectorTest.cpp +++ b/tests/CommonLibs/BitVectorTest.cpp @@ -29,7 +29,7 @@ #include "BitVector.h" #include #include - + using namespace std; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ifafb68353960fc5046661854ccfb8d783b0efb14 Gerrit-Change-Number: 14891 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 10:06:48 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 10:06:48 +0000 Subject: Change in ...osmo-trx[master]: Add SPDX annotation Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14892 Change subject: Add SPDX annotation ...................................................................... Add SPDX annotation Related: OS#3515 Change-Id: I3719bd8dc015569ecd81928fc079e27593cdca09 --- M CommonLibs/BitVector.cpp M CommonLibs/BitVector.h M CommonLibs/Interthread.h M CommonLibs/LinkedLists.cpp M CommonLibs/LinkedLists.h M CommonLibs/Logger.cpp M CommonLibs/Logger.h M CommonLibs/PRBS.h M CommonLibs/Threads.cpp M CommonLibs/Threads.h M CommonLibs/Timeval.cpp M CommonLibs/Timeval.h M CommonLibs/Utils.cpp M CommonLibs/Utils.h M CommonLibs/Vector.h M CommonLibs/debug.c M CommonLibs/osmo_signal.h M GSM/GSMCommon.cpp M GSM/GSMCommon.h M Transceiver52M/Channelizer.cpp M Transceiver52M/ChannelizerBase.cpp M Transceiver52M/Resampler.cpp M Transceiver52M/Resampler.h M Transceiver52M/Synthesis.cpp M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h M Transceiver52M/arch/arm/convert.c M Transceiver52M/arch/arm/convert_neon.S M Transceiver52M/arch/arm/convolve.c M Transceiver52M/arch/arm/convolve_neon.S M Transceiver52M/arch/arm/mult.c M Transceiver52M/arch/arm/mult_neon.S M Transceiver52M/arch/arm/scale.c M Transceiver52M/arch/arm/scale_neon.S M Transceiver52M/arch/common/convert_base.c M Transceiver52M/arch/common/convolve_base.c M Transceiver52M/arch/common/fft.c M Transceiver52M/device/common/smpl_buf.cpp M Transceiver52M/device/common/smpl_buf.h M Transceiver52M/device/lms/LMSDevice.cpp M Transceiver52M/device/lms/LMSDevice.h M Transceiver52M/device/uhd/UHDDevice.cpp M Transceiver52M/device/uhd/UHDDevice.h M Transceiver52M/device/usrp1/USRPDevice.cpp M Transceiver52M/device/usrp1/USRPDevice.h M Transceiver52M/osmo-trx.cpp M Transceiver52M/radioBuffer.cpp M Transceiver52M/radioClock.cpp M Transceiver52M/radioClock.h M Transceiver52M/radioInterface.cpp M Transceiver52M/radioInterfaceMulti.cpp M Transceiver52M/radioInterfaceResamp.cpp M Transceiver52M/radioVector.cpp M Transceiver52M/radioVector.h M Transceiver52M/sigProcLib.cpp M tests/CommonLibs/BitVectorTest.cpp M tests/CommonLibs/InterthreadTest.cpp M tests/CommonLibs/LogTest.cpp M tests/CommonLibs/PRBSTest.cpp M tests/CommonLibs/TimevalTest.cpp M tests/CommonLibs/VectorTest.cpp 61 files changed, 139 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/92/14892/1 diff --git a/CommonLibs/BitVector.cpp b/CommonLibs/BitVector.cpp index cf408cd..26b44ee 100644 --- a/CommonLibs/BitVector.cpp +++ b/CommonLibs/BitVector.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008, 2009 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/CommonLibs/BitVector.h b/CommonLibs/BitVector.h index 559dd99..16a1587 100644 --- a/CommonLibs/BitVector.h +++ b/CommonLibs/BitVector.h @@ -1,6 +1,8 @@ /* * Copyright 2008, 2009 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/CommonLibs/Interthread.h b/CommonLibs/Interthread.h index 185112f..8169985 100644 --- a/CommonLibs/Interthread.h +++ b/CommonLibs/Interthread.h @@ -1,6 +1,8 @@ /* * Copyright 2008, 2011 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/CommonLibs/LinkedLists.cpp b/CommonLibs/LinkedLists.cpp index b73a579..3ebf715 100644 --- a/CommonLibs/LinkedLists.cpp +++ b/CommonLibs/LinkedLists.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/CommonLibs/LinkedLists.h b/CommonLibs/LinkedLists.h index 136d13d..e98b41a 100644 --- a/CommonLibs/LinkedLists.h +++ b/CommonLibs/LinkedLists.h @@ -1,7 +1,10 @@ /* * Copyright 2008 Free Software Foundation, Inc. * -* This software is distributed under multiple licenses; see the COPYING file in the main directory for licensing information for this specific distribuion. +* SPDX-License-Identifier: AGPL-3.0+ +* +* This software is distributed under multiple licenses; see the COPYING file in +* the main directory for licensing information for this specific distribuion. * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/CommonLibs/Logger.cpp b/CommonLibs/Logger.cpp index f68fab5..5db7f87 100644 --- a/CommonLibs/Logger.cpp +++ b/CommonLibs/Logger.cpp @@ -1,6 +1,7 @@ /* * Copyright (C) 2018 sysmocom - s.f.m.c. GmbH * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/CommonLibs/Logger.h b/CommonLibs/Logger.h index 9c665cd..ab72303 100644 --- a/CommonLibs/Logger.h +++ b/CommonLibs/Logger.h @@ -2,6 +2,8 @@ * Copyright 2009, 2010 Free Software Foundation, Inc. * Copyright 2010 Kestrel Signal Processing, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/CommonLibs/PRBS.h b/CommonLibs/PRBS.h index 0b7bbc3..9235327 100644 --- a/CommonLibs/PRBS.h +++ b/CommonLibs/PRBS.h @@ -1,6 +1,8 @@ /* * Copyright (C) 2017 Alexander Chemeris * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/CommonLibs/Threads.cpp b/CommonLibs/Threads.cpp index ccea1e7..dd57d40 100644 --- a/CommonLibs/Threads.cpp +++ b/CommonLibs/Threads.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/CommonLibs/Threads.h b/CommonLibs/Threads.h index 8a6ba47..4cc0884 100644 --- a/CommonLibs/Threads.h +++ b/CommonLibs/Threads.h @@ -1,6 +1,8 @@ /* * Copyright 2008, 2011 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/CommonLibs/Timeval.cpp b/CommonLibs/Timeval.cpp index 60bf7f6..cfd01cf 100644 --- a/CommonLibs/Timeval.cpp +++ b/CommonLibs/Timeval.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/CommonLibs/Timeval.h b/CommonLibs/Timeval.h index 7c6a6f6..0826c12 100644 --- a/CommonLibs/Timeval.h +++ b/CommonLibs/Timeval.h @@ -1,6 +1,8 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/CommonLibs/Utils.cpp b/CommonLibs/Utils.cpp index 6cd4f84..e500475 100644 --- a/CommonLibs/Utils.cpp +++ b/CommonLibs/Utils.cpp @@ -1,6 +1,8 @@ /* * Copyright 2018 sysmocom - s.f.m.c. GmbH * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/CommonLibs/Utils.h b/CommonLibs/Utils.h index 4f0fbc0..3c5c802 100644 --- a/CommonLibs/Utils.h +++ b/CommonLibs/Utils.h @@ -1,6 +1,8 @@ /* * Copyright 2018 sysmocom - s.f.m.c. GmbH * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/CommonLibs/Vector.h b/CommonLibs/Vector.h index 4c96b78..0970248 100644 --- a/CommonLibs/Vector.h +++ b/CommonLibs/Vector.h @@ -2,6 +2,8 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/CommonLibs/debug.c b/CommonLibs/debug.c index 17ef5bc..48d4981 100644 --- a/CommonLibs/debug.c +++ b/CommonLibs/debug.c @@ -1,3 +1,26 @@ +/* + * Copyright (C) 2018-2019 sysmocom - s.f.m.c. GmbH + * All Rights Reserved + * + * SPDX-License-Identifier: AGPL-3.0+ + * + * Author: Pau Espin Pedrol + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * See the COPYING file in the main directory for details. + */ + #include #include diff --git a/CommonLibs/osmo_signal.h b/CommonLibs/osmo_signal.h index 6ee1bf9..ee7e2a4 100644 --- a/CommonLibs/osmo_signal.h +++ b/CommonLibs/osmo_signal.h @@ -5,6 +5,8 @@ * * All Rights Reserved * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation; either version 3 of the License, or diff --git a/GSM/GSMCommon.cpp b/GSM/GSMCommon.cpp index 711ca70..5e9e4ae 100644 --- a/GSM/GSMCommon.cpp +++ b/GSM/GSMCommon.cpp @@ -2,6 +2,8 @@ * Copyright 2008 Free Software Foundation, Inc. * Copyright 2011 Range Networks, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/GSM/GSMCommon.h b/GSM/GSMCommon.h index a3ada26..48723b4 100644 --- a/GSM/GSMCommon.h +++ b/GSM/GSMCommon.h @@ -2,6 +2,8 @@ /* * Copyright 2008-2011 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/Transceiver52M/Channelizer.cpp b/Transceiver52M/Channelizer.cpp index 1e4d7d4..341cd0a 100644 --- a/Transceiver52M/Channelizer.cpp +++ b/Transceiver52M/Channelizer.cpp @@ -4,6 +4,8 @@ * Copyright (C) 2012-2014 Tom Tsou * Copyright (C) 2015 Ettus Research LLC * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/ChannelizerBase.cpp b/Transceiver52M/ChannelizerBase.cpp index 96f76a9..f3f07c1 100644 --- a/Transceiver52M/ChannelizerBase.cpp +++ b/Transceiver52M/ChannelizerBase.cpp @@ -4,6 +4,8 @@ * Copyright (C) 2012-2014 Tom Tsou * Copyright (C) 2015 Ettus Research LLC * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/Resampler.cpp b/Transceiver52M/Resampler.cpp index f545db8..7ba0219 100644 --- a/Transceiver52M/Resampler.cpp +++ b/Transceiver52M/Resampler.cpp @@ -2,6 +2,8 @@ * Rational Sample Rate Conversion * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/Resampler.h b/Transceiver52M/Resampler.h index bee2436..139b857 100644 --- a/Transceiver52M/Resampler.h +++ b/Transceiver52M/Resampler.h @@ -2,6 +2,8 @@ * Rational Sample Rate Conversion * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/Synthesis.cpp b/Transceiver52M/Synthesis.cpp index a117390..24da8e6 100644 --- a/Transceiver52M/Synthesis.cpp +++ b/Transceiver52M/Synthesis.cpp @@ -4,6 +4,8 @@ * Copyright (C) 2012-2014 Tom Tsou * Copyright (C) 2015 Ettus Research LLC * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 17e0476..af6b0dd 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -1,6 +1,8 @@ /* * Copyright 2008, 2009, 2010 Free Software Foundation, Inc. * +* SPDX-License-Identifier: GPL-3.0+ +* * This software is distributed under the terms of the GNU Public License. * See the COPYING file in the main directory for details. * diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index aa2a716..8b5a9b1 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -1,6 +1,8 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: GPL-3.0+ +* * This software is distributed under the terms of the GNU Public License. * See the COPYING file in the main directory for details. * diff --git a/Transceiver52M/arch/arm/convert.c b/Transceiver52M/arch/arm/convert.c index c94a3d7..ace1b6f 100644 --- a/Transceiver52M/arch/arm/convert.c +++ b/Transceiver52M/arch/arm/convert.c @@ -2,6 +2,8 @@ * NEON type conversions * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/arm/convert_neon.S b/Transceiver52M/arch/arm/convert_neon.S index 842ed9f..a1fbd40 100644 --- a/Transceiver52M/arch/arm/convert_neon.S +++ b/Transceiver52M/arch/arm/convert_neon.S @@ -2,6 +2,8 @@ * NEON type conversions * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/arm/convolve.c b/Transceiver52M/arch/arm/convolve.c index 5b5bce5..63b1655 100644 --- a/Transceiver52M/arch/arm/convolve.c +++ b/Transceiver52M/arch/arm/convolve.c @@ -2,6 +2,8 @@ * NEON Convolution * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/arm/convolve_neon.S b/Transceiver52M/arch/arm/convolve_neon.S index 8a023ff..a3e1ba5 100644 --- a/Transceiver52M/arch/arm/convolve_neon.S +++ b/Transceiver52M/arch/arm/convolve_neon.S @@ -2,6 +2,8 @@ * NEON Convolution * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/arm/mult.c b/Transceiver52M/arch/arm/mult.c index 245be50..9851626 100644 --- a/Transceiver52M/arch/arm/mult.c +++ b/Transceiver52M/arch/arm/mult.c @@ -2,6 +2,8 @@ * NEON scaling * Copyright (C) 2012,2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/arm/mult_neon.S b/Transceiver52M/arch/arm/mult_neon.S index 113e227..6318c50 100644 --- a/Transceiver52M/arch/arm/mult_neon.S +++ b/Transceiver52M/arch/arm/mult_neon.S @@ -2,6 +2,8 @@ * NEON complex multiplication * Copyright (C) 2012,2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/arm/scale.c b/Transceiver52M/arch/arm/scale.c index 2de13ff..a3214f7 100644 --- a/Transceiver52M/arch/arm/scale.c +++ b/Transceiver52M/arch/arm/scale.c @@ -2,6 +2,8 @@ * NEON scaling * Copyright (C) 2012,2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/arm/scale_neon.S b/Transceiver52M/arch/arm/scale_neon.S index a66fbe5..f10de1e 100644 --- a/Transceiver52M/arch/arm/scale_neon.S +++ b/Transceiver52M/arch/arm/scale_neon.S @@ -2,6 +2,8 @@ * ARM NEON Scaling * Copyright (C) 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/common/convert_base.c b/Transceiver52M/arch/common/convert_base.c index 8d29310..9876e83 100644 --- a/Transceiver52M/arch/common/convert_base.c +++ b/Transceiver52M/arch/common/convert_base.c @@ -2,6 +2,8 @@ * Conversion * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/common/convolve_base.c b/Transceiver52M/arch/common/convolve_base.c index 9bb8d3d..bfda783 100644 --- a/Transceiver52M/arch/common/convolve_base.c +++ b/Transceiver52M/arch/common/convolve_base.c @@ -2,6 +2,8 @@ * Convolution * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/common/fft.c b/Transceiver52M/arch/common/fft.c index ed79d13..ad096b1 100644 --- a/Transceiver52M/arch/common/fft.c +++ b/Transceiver52M/arch/common/fft.c @@ -3,6 +3,8 @@ * * Copyright (C) 2012 Tom Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/device/common/smpl_buf.cpp b/Transceiver52M/device/common/smpl_buf.cpp index c21f306..33161bc 100644 --- a/Transceiver52M/device/common/smpl_buf.cpp +++ b/Transceiver52M/device/common/smpl_buf.cpp @@ -7,6 +7,8 @@ * * Author: Tom Tsou * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/device/common/smpl_buf.h b/Transceiver52M/device/common/smpl_buf.h index 24d3ce9..383c814 100644 --- a/Transceiver52M/device/common/smpl_buf.h +++ b/Transceiver52M/device/common/smpl_buf.h @@ -7,6 +7,8 @@ * * Author: Tom Tsou * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp index 0253d4c..0eaf0a3 100644 --- a/Transceiver52M/device/lms/LMSDevice.cpp +++ b/Transceiver52M/device/lms/LMSDevice.cpp @@ -1,6 +1,8 @@ /* * Copyright 2018 sysmocom - s.f.m.c. GmbH * +* SPDX-License-Identifier: AGPL-3.0+ +* This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/device/lms/LMSDevice.h b/Transceiver52M/device/lms/LMSDevice.h index 9e0944d..906fbee 100644 --- a/Transceiver52M/device/lms/LMSDevice.h +++ b/Transceiver52M/device/lms/LMSDevice.h @@ -1,7 +1,10 @@ /* * Copyright 2018 sysmocom - s.f.m.c. GmbH * -* This software is distributed under multiple licenses; see the COPYING file in the main directory for licensing information for this specific distribuion. +* SPDX-License-Identifier: AGPL-3.0+ +* +* This software is distributed under multiple licenses; see the COPYING file in +* the main directory for licensing information for this specific distribuion. * * This use of this software may be subject to additional restrictions. * See the LEGAL file in the main directory for details. diff --git a/Transceiver52M/device/uhd/UHDDevice.cpp b/Transceiver52M/device/uhd/UHDDevice.cpp index 4e6f49d..8bb94d6 100644 --- a/Transceiver52M/device/uhd/UHDDevice.cpp +++ b/Transceiver52M/device/uhd/UHDDevice.cpp @@ -6,6 +6,8 @@ * * Author: Tom Tsou * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/device/uhd/UHDDevice.h b/Transceiver52M/device/uhd/UHDDevice.h index 0b57ba4..d5a6348 100644 --- a/Transceiver52M/device/uhd/UHDDevice.h +++ b/Transceiver52M/device/uhd/UHDDevice.h @@ -7,6 +7,8 @@ * * Author: Tom Tsou * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/device/usrp1/USRPDevice.cpp b/Transceiver52M/device/usrp1/USRPDevice.cpp index b1d6c56..af0b3de 100644 --- a/Transceiver52M/device/usrp1/USRPDevice.cpp +++ b/Transceiver52M/device/usrp1/USRPDevice.cpp @@ -1,6 +1,8 @@ /* * Copyright 2008, 2009 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/Transceiver52M/device/usrp1/USRPDevice.h b/Transceiver52M/device/usrp1/USRPDevice.h index c02e58c..9a2426c 100644 --- a/Transceiver52M/device/usrp1/USRPDevice.h +++ b/Transceiver52M/device/usrp1/USRPDevice.h @@ -1,7 +1,10 @@ /* * Copyright 2008 Free Software Foundation, Inc. * -* This software is distributed under multiple licenses; see the COPYING file in the main directory for licensing information for this specific distribuion. +* SPDX-License-Identifier: AGPL-3.0+ +* +* This software is distributed under multiple licenses; see the COPYING file in +* the main directory for licensing information for this specific distribuion. * * This use of this software may be subject to additional restrictions. * See the LEGAL file in the main directory for details. diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index 8a3f1e3..cd659a7 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -1,6 +1,8 @@ /* * Copyright (C) 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/radioBuffer.cpp b/Transceiver52M/radioBuffer.cpp index 57de364..62f6553 100644 --- a/Transceiver52M/radioBuffer.cpp +++ b/Transceiver52M/radioBuffer.cpp @@ -5,6 +5,8 @@ * * Author: Tom Tsou * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/radioClock.cpp b/Transceiver52M/radioClock.cpp index 505bb01..2befd0d 100644 --- a/Transceiver52M/radioClock.cpp +++ b/Transceiver52M/radioClock.cpp @@ -4,6 +4,8 @@ * * Copyright 2011 Free Software Foundation, Inc. * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/radioClock.h b/Transceiver52M/radioClock.h index 9c35c44..472f43d 100644 --- a/Transceiver52M/radioClock.h +++ b/Transceiver52M/radioClock.h @@ -4,6 +4,8 @@ * * Copyright 2011 Free Software Foundation, Inc. * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/radioInterface.cpp b/Transceiver52M/radioInterface.cpp index 04b98da..e32848e 100644 --- a/Transceiver52M/radioInterface.cpp +++ b/Transceiver52M/radioInterface.cpp @@ -4,6 +4,8 @@ * Copyright (C) 2008-2014 Free Software Foundation, Inc. * Copyright (C) 2015 Ettus Research LLC * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/radioInterfaceMulti.cpp b/Transceiver52M/radioInterfaceMulti.cpp index 17a015b..0208e82 100644 --- a/Transceiver52M/radioInterfaceMulti.cpp +++ b/Transceiver52M/radioInterfaceMulti.cpp @@ -5,6 +5,8 @@ * * Author: Tom Tsou * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/radioInterfaceResamp.cpp b/Transceiver52M/radioInterfaceResamp.cpp index 8ae4aa1..e2f69f2 100644 --- a/Transceiver52M/radioInterfaceResamp.cpp +++ b/Transceiver52M/radioInterfaceResamp.cpp @@ -6,6 +6,8 @@ * * Author: Tom Tsou * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/radioVector.cpp b/Transceiver52M/radioVector.cpp index 2e3af9d..ad40a11 100644 --- a/Transceiver52M/radioVector.cpp +++ b/Transceiver52M/radioVector.cpp @@ -4,6 +4,8 @@ * * Copyright 2011 Free Software Foundation, Inc. * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/radioVector.h b/Transceiver52M/radioVector.h index 0566123..0a14a4d 100644 --- a/Transceiver52M/radioVector.h +++ b/Transceiver52M/radioVector.h @@ -4,6 +4,8 @@ * * Copyright 2011 Free Software Foundation, Inc. * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp index 1042dbb..011ddff 100644 --- a/Transceiver52M/sigProcLib.cpp +++ b/Transceiver52M/sigProcLib.cpp @@ -1,6 +1,8 @@ /* * Copyright 2008, 2011 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/tests/CommonLibs/BitVectorTest.cpp b/tests/CommonLibs/BitVectorTest.cpp index 74c7d45..440ace1 100644 --- a/tests/CommonLibs/BitVectorTest.cpp +++ b/tests/CommonLibs/BitVectorTest.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/tests/CommonLibs/InterthreadTest.cpp b/tests/CommonLibs/InterthreadTest.cpp index c131c2a..462df08 100644 --- a/tests/CommonLibs/InterthreadTest.cpp +++ b/tests/CommonLibs/InterthreadTest.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/tests/CommonLibs/LogTest.cpp b/tests/CommonLibs/LogTest.cpp index 5e51ce7..0087070 100644 --- a/tests/CommonLibs/LogTest.cpp +++ b/tests/CommonLibs/LogTest.cpp @@ -2,6 +2,7 @@ * Copyright 2009 Free Software Foundation, Inc. * Copyright 2010 Kestrel Signal Processing, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/tests/CommonLibs/PRBSTest.cpp b/tests/CommonLibs/PRBSTest.cpp index b83e93d..cb5ed41 100644 --- a/tests/CommonLibs/PRBSTest.cpp +++ b/tests/CommonLibs/PRBSTest.cpp @@ -1,6 +1,8 @@ /* * Copyright (C) 2017 Alexander Chemeris * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/tests/CommonLibs/TimevalTest.cpp b/tests/CommonLibs/TimevalTest.cpp index b822982..6a45d3b 100644 --- a/tests/CommonLibs/TimevalTest.cpp +++ b/tests/CommonLibs/TimevalTest.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/tests/CommonLibs/VectorTest.cpp b/tests/CommonLibs/VectorTest.cpp index 6958889..292d56a 100644 --- a/tests/CommonLibs/VectorTest.cpp +++ b/tests/CommonLibs/VectorTest.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14892 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3719bd8dc015569ecd81928fc079e27593cdca09 Gerrit-Change-Number: 14892 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 10:10:05 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 10:10:05 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: library: allow "?" in tr_ML3_MT_MM_ID_Req again In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 ) Change subject: library: allow "?" in tr_ML3_MT_MM_ID_Req again ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b Gerrit-Change-Number: 14755 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 22 Jul 2019 10:10:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 10:14:12 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 22 Jul 2019 10:14:12 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: library: allow "?" in tr_ML3_MT_MM_ID_Req again In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 ) Change subject: library: allow "?" in tr_ML3_MT_MM_ID_Req again ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b Gerrit-Change-Number: 14755 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 22 Jul 2019 10:14:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 10:31:01 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 10:31:01 +0000 Subject: Change in ...osmo-trx[master]: Bind CTRL port to IP addr specified in VTY config Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14893 Change subject: Bind CTRL port to IP addr specified in VTY config ...................................................................... Bind CTRL port to IP addr specified in VTY config Before this commit, osmo-trx was always setting its CTRL socket to listen on 127.0.0.1. Change-Id: I61a06c1b9c20a906e7030f824a93370d041be7b9 --- M Transceiver52M/osmo-trx.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/93/14893/1 diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index 8a3f1e3..dee1302 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -600,7 +600,7 @@ if (rc < 0) exit(1); - g_ctrlh = ctrl_interface_setup(NULL, OSMO_CTRL_PORT_TRX, NULL); + g_ctrlh = ctrl_interface_setup_dynip(NULL, ctrl_vty_get_bind_addr(), OSMO_CTRL_PORT_TRX, NULL); if (!g_ctrlh) { LOG(ERROR) << "Failed to create CTRL interface.\n"; exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I61a06c1b9c20a906e7030f824a93370d041be7b9 Gerrit-Change-Number: 14893 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 11:23:07 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 22 Jul 2019 11:23:07 +0000 Subject: Change in ...osmo-ci[master]: OBS: print date/time before git clone and on error Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14894 Change subject: OBS: print date/time before git clone and on error ...................................................................... OBS: print date/time before git clone and on error The OBS job clones a lot of repositories from git.osmocom.org every night, so it is a good candidate to reproduce the "garbage at end of loose object" error we are getting sporadically. Print exact timestamps, so we can check if there is anything related in the server logs, when this error happens again. Related: OS#4083 Change-Id: Ic9a6d3f0c2b8dad2661ede793c21307f1680a52e --- M scripts/common.sh M scripts/osmocom-latest-packages.sh M scripts/osmocom-nightly-packages.sh 3 files changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/94/14894/1 diff --git a/scripts/common.sh b/scripts/common.sh index bf24fc4..6d91101 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -89,6 +89,16 @@ echo "$ret" | cut -d/ -f 3 } +# Pass all arguments to "git clone", but write the current date and time before the clone and on failure. +# This helps analyzing errors with git.osmocom.org (OS#4083). +osmo_git_clone_date() { + date "+%Y-%m-%d %H:%M:%S" + if ! git clone "$@"; then + date "+%Y-%m-%d %H:%M:%S" + exit 1 + fi +} + # Print the subdirectory of the repository where the source lies (configure.ac etc.). # Print nothing when the source is in the topdir of the repository. osmo_source_subdir() { diff --git a/scripts/osmocom-latest-packages.sh b/scripts/osmocom-latest-packages.sh index 1074294..509bced 100755 --- a/scripts/osmocom-latest-packages.sh +++ b/scripts/osmocom-latest-packages.sh @@ -1,4 +1,5 @@ #!/bin/sh +. "$(dirname "$0")/common.sh" . "$(dirname "$0")/common-obs.sh" # requirements @@ -54,7 +55,7 @@ if [ "$project" = "limesuite" ]; then [ -d "$project" ] || git clone "https://github.com/myriadrf/LimeSuite" "$project" else - [ -d "$project" ] || git clone "https://git.osmocom.org/$project" + [ -d "$project" ] || osmo_git_clone_date "https://git.osmocom.org/$project" fi cd "$project" git fetch diff --git a/scripts/osmocom-nightly-packages.sh b/scripts/osmocom-nightly-packages.sh index 172e4e0..1c76cc1 100755 --- a/scripts/osmocom-nightly-packages.sh +++ b/scripts/osmocom-nightly-packages.sh @@ -1,4 +1,5 @@ #!/bin/bash +. "$(dirname "$0")/common.sh" . "$(dirname "$0")/common-obs.sh" # requirements @@ -68,9 +69,9 @@ cd "$REPO" if [ -n "$branch" ] ; then - git clone "$url/$name" -b "$branch" + osmo_git_clone_date "$url/$name" -b "$branch" else - git clone "$url/$name" + osmo_git_clone_date "$url/$name" fi cd - -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic9a6d3f0c2b8dad2661ede793c21307f1680a52e Gerrit-Change-Number: 14894 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 11:27:13 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 22 Jul 2019 11:27:13 +0000 Subject: Change in ...osmo-ci[master]: OBS: print date/time before git clone and on error In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14894 ) Change subject: OBS: print date/time before git clone and on error ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic9a6d3f0c2b8dad2661ede793c21307f1680a52e Gerrit-Change-Number: 14894 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 22 Jul 2019 11:27:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 11:29:48 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 22 Jul 2019 11:29:48 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: library: allow "?" in tr_ML3_MT_MM_ID_Req again In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 ) Change subject: library: allow "?" in tr_ML3_MT_MM_ID_Req again ...................................................................... Patch Set 3: Code-Review+2 1+1=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b Gerrit-Change-Number: 14755 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 22 Jul 2019 11:29:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 11:29:52 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 22 Jul 2019 11:29:52 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: library: allow "?" in tr_ML3_MT_MM_ID_Req again In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 ) Change subject: library: allow "?" in tr_ML3_MT_MM_ID_Req again ...................................................................... library: allow "?" in tr_ML3_MT_MM_ID_Req again Fix MSC test TC_lu_by_imei, which uses tr_ML3_MT_MM_ID_Req with the default "?" (AnyElement) parameter. It was failing with the following runtime error: Dynamic test case error: Performing a valueof or send operation on a non-specific template of enumerated type @L3_Templates.CmIdentityType. Fixes: 328984591372ad5abf51655a51d45d880bfed182 ("L3_Templates: add enum CmIdentityType") Related: https://www.eclipse.org/forums/index.php/t/1099816/ Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b --- M library/L3_Templates.ttcn 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index 3011919..bc0e797 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -873,6 +873,14 @@ } } +private function f_id_type_or_any(template CmIdentityType id_type) return template bitstring { + if (istemplatekind(id_type, "?")) { + return ?; + } else { + return int2bit(enum2int(valueof(id_type)), 3); + } +} + template PDU_ML3_NW_MS tr_ML3_MT_MM_ID_Req(template CmIdentityType id_type := ?) := { discriminator := '0101'B, tiOrSkip := { @@ -883,7 +891,7 @@ identityRequest := { messageType := '011000'B, nsd := '00'B, - identityType := int2bit(enum2int(valueof(id_type)), 3), + identityType := f_id_type_or_any(id_type), spare1_5 := ? } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14755 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7fbe52ac3c0c8f233680dcc311febec77d2ed0b Gerrit-Change-Number: 14755 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 11:34:19 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 22 Jul 2019 11:34:19 +0000 Subject: Change in ...osmo-bsc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14840 ) Change subject: doc: Add Osmux documentation to User Manual ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75dcdddc713b0dc43e2ba577ca377c20fc511f38 Gerrit-Change-Number: 14840 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 11:34:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 11:51:07 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 22 Jul 2019 11:51:07 +0000 Subject: Change in ...osmo-gsm-manuals[master]: tests: pick up subdirs inside common/chapters Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14895 Change subject: tests: pick up subdirs inside common/chapters ...................................................................... tests: pick up subdirs inside common/chapters The Osmux documentation that will be introduced in [1] creates a common/chapters/osmux/ subdir. Update tests/Makefile.am to pick up the files in that directory too, so they get built by jenkins during gerrit verification. [1] I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e Change-Id: I4d1f440b7bfef159c98f918a2d23069594c4bc95 --- M tests/Makefile.am 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/95/14895/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 7dc9544..b2f579d 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -9,7 +9,8 @@ # Generate adoc file that includes all chapters ASCIIDOC = test-usermanual.adoc ASCIIDOC_DEPS = -$(ASCIIDOC): $(OSMO_GSM_MANUALS_DIR)/common/chapters/*.adoc +COMMON_CHAPTERS = $(shell find $(OSMO_GSM_MANUALS_DIR)/common/chapters -name '*.adoc') +$(ASCIIDOC): $(COMMON_CHAPTERS) echo ":gfdl-enabled:" > $@ echo ":program-name: Test" >> $@ echo "" >> $@ @@ -17,7 +18,7 @@ echo "====================================" >> $@ echo "Oliver Smith " >> $@ echo "" >> $@ - for chapter in $(OSMO_GSM_MANUALS_DIR)/common/chapters/*.adoc; do \ + for chapter in $(COMMON_CHAPTERS); do \ echo "include::$${chapter}[]" >> $@; \ done; CLEAN_FILES = $(ASCIIDOC) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I4d1f440b7bfef159c98f918a2d23069594c4bc95 Gerrit-Change-Number: 14895 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 11:54:59 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 22 Jul 2019 11:54:59 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: Introduce Osmux documentation In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 ) Change subject: common: Introduce Osmux documentation ...................................................................... Patch Set 2: The new adoc files don't get built during the gerrit-verification test build, as they are in a subdirectory. Here's a patch to fix that: https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14895 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e Gerrit-Change-Number: 14839 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 22 Jul 2019 11:54:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 12:54:26 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 12:54:26 +0000 Subject: Change in ...osmo-ci[master]: OBS: print date/time before git clone and on error In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14894 ) Change subject: OBS: print date/time before git clone and on error ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14894/1/scripts/common.sh File scripts/common.sh: https://gerrit.osmocom.org/#/c/14894/1/scripts/common.sh at 96 PS1, Line 96: if ! git clone "$@"; then I think you should not use "" here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic9a6d3f0c2b8dad2661ede793c21307f1680a52e Gerrit-Change-Number: 14894 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 22 Jul 2019 12:54:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 12:55:42 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 12:55:42 +0000 Subject: Change in ...osmo-gsm-manuals[master]: tests: pick up subdirs inside common/chapters In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14895 ) Change subject: tests: pick up subdirs inside common/chapters ...................................................................... Patch Set 1: Code-Review+2 Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I4d1f440b7bfef159c98f918a2d23069594c4bc95 Gerrit-Change-Number: 14895 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 22 Jul 2019 12:55:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 13:41:51 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Mon, 22 Jul 2019 13:41:51 +0000 Subject: Change in ...libosmo-abis[master]: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 to look at the new patch set (#6). Change subject: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc ...................................................................... add ipa pingp/pong keepalive for OML/RSL links between bts and bsc Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a Depends: (libosmo-abis) Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b --- M TODO-RELEASE M include/osmocom/abis/e1_input.h M src/e1_input_vty.c M src/input/ipaccess.c 4 files changed, 185 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/43/14743/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a Gerrit-Change-Number: 14743 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 13:47:00 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Mon, 22 Jul 2019 13:47:00 +0000 Subject: Change in ...libosmo-abis[master]: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 to look at the new patch set (#7). Change subject: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc ...................................................................... add ipa pingp/pong keepalive for OML/RSL links between bts and bsc Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a Depends: (libosmo-abis) Ie453fdee8bfd7fc1a3f1ed67ef0331f0abb1d59b --- M TODO-RELEASE M include/osmocom/abis/e1_input.h M src/e1_input_vty.c M src/input/ipaccess.c 4 files changed, 185 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/43/14743/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a Gerrit-Change-Number: 14743 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Mon Jul 22 13:48:26 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 13:48:26 +0000 Subject: Build failure of network:osmocom:latest/libusrp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35bec6e6955_2e5b10845fc148933@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/Debian_Testing/x86_64 Package network:osmocom:latest/libusrp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 50s] [118/361] installing libedit2-3.1-20190324-1 [ 50s] Processing triggers for libc-bin (2.28-10) ... [ 50s] [119/361] installing libhwloc5-1.11.12-3 [ 50s] Processing triggers for libc-bin (2.28-10) ... [ 50s] [120/361] installing libicu63-63.2-2 [ 51s] Processing triggers for libc-bin (2.28-10) ... [ 51s] [121/361] installing libmagic1-1:5.35-4 [ 51s] Processing triggers for libc-bin (2.28-10) ... [ 51s] [122/361] installing libuchardet0-0.0.6-3 [ 51s] Processing triggers for libc-bin (2.28-10) ... [ 51s] [123/361] installing libunwind8-1.2.1-9 [ 51s] Processing triggers for libc-bin (2.28-10) ... [ 52s] [124/361] installing python2.7-minimal-2.7.16-2 [ 52s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 52s] dpkg: error processing package python2.7-minimal (--install): [ 52s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 52s] Errors were encountered while processing: [ 52s] python2.7-minimal [ 52s] exit ... [ 52s] [ 52s] lamb03 failed "build libusrp_3.4.2.dsc" at Mon Jul 22 13:48:19 UTC 2019. [ 52s] [ 52s] ### VM INTERACTION START ### [ 56s] [ 36.198629] sysrq: SysRq : Power Off [ 56s] [ 36.210176] reboot: Power down [ 56s] ### VM INTERACTION END ### [ 56s] [ 56s] lamb03 failed "build libusrp_3.4.2.dsc" at Mon Jul 22 13:48:23 UTC 2019. [ 56s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 13:49:00 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 13:49:00 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35bee725add_2e5b10845fc1492e0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 36s] [156/382] installing libmagic1-1:5.35-4 [ 36s] Processing triggers for libc-bin (2.28-10) ... [ 36s] [157/382] installing libosp5-1.5.2-13+b1 [ 37s] Processing triggers for libc-bin (2.28-10) ... [ 37s] [158/382] installing libostyle1c2-1.4devel1-21.3+b1 [ 37s] Processing triggers for libc-bin (2.28-10) ... [ 37s] [159/382] installing libthai0-0.1.28-2 [ 37s] Processing triggers for libc-bin (2.28-10) ... [ 37s] [160/382] installing libuchardet0-0.0.6-3 [ 37s] Processing triggers for libc-bin (2.28-10) ... [ 37s] [161/382] installing libunwind8-1.2.1-9 [ 37s] Processing triggers for libc-bin (2.28-10) ... [ 37s] [162/382] installing python2.7-minimal-2.7.16-2 [ 37s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 37s] dpkg: error processing package python2.7-minimal (--install): [ 37s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 37s] Errors were encountered while processing: [ 37s] python2.7-minimal [ 37s] exit ... [ 37s] [ 37s] sheep82 failed "build osmo-gsm-manuals-dev_0.1.1.1.5238.dsc" at Mon Jul 22 13:48:41 UTC 2019. [ 37s] [ 37s] ### VM INTERACTION START ### [ 41s] [ 28.224375] sysrq: SysRq : Power Off [ 41s] [ 28.236720] reboot: Power down [ 41s] ### VM INTERACTION END ### [ 41s] [ 41s] sheep82 failed "build osmo-gsm-manuals-dev_0.1.1.1.5238.dsc" at Mon Jul 22 13:48:45 UTC 2019. [ 41s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 13:49:00 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 13:49:00 +0000 Subject: Build failure of network:osmocom:latest/libosmocore in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35bee774cde_2e5b10845fc149338@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/Debian_Testing/x86_64 Package network:osmocom:latest/libosmocore failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmocore Last lines of build log: [ 70s] [106/239] installing libedit2-3.1-20190324-1 [ 70s] Processing triggers for libc-bin (2.28-10) ... [ 70s] [107/239] installing libhogweed4-3.4.1-1 [ 70s] Processing triggers for libc-bin (2.28-10) ... [ 70s] [108/239] installing libicu63-63.2-2 [ 71s] Processing triggers for libc-bin (2.28-10) ... [ 72s] [109/239] installing libmagic1-1:5.35-4 [ 72s] Processing triggers for libc-bin (2.28-10) ... [ 72s] [110/239] installing libuchardet0-0.0.6-3 [ 72s] Processing triggers for libc-bin (2.28-10) ... [ 72s] [111/239] installing libunwind8-1.2.1-9 [ 72s] Processing triggers for libc-bin (2.28-10) ... [ 72s] [112/239] installing python2.7-minimal-2.7.16-2 [ 73s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 73s] dpkg: error processing package python2.7-minimal (--install): [ 73s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 73s] Errors were encountered while processing: [ 73s] python2.7-minimal [ 73s] exit ... [ 73s] [ 73s] cloud127 failed "build libosmocore_1.1.0.dsc" at Mon Jul 22 13:48:40 UTC 2019. [ 73s] [ 73s] ### VM INTERACTION START ### [ 77s] [ 43.743059] sysrq: SysRq : Power Off [ 77s] [ 43.756063] reboot: Power down [ 77s] ### VM INTERACTION END ### [ 77s] [ 77s] cloud127 failed "build libosmocore_1.1.0.dsc" at Mon Jul 22 13:48:45 UTC 2019. [ 77s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 13:49:17 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 13:49:17 +0000 Subject: Build failure of network:osmocom:nightly/libusrp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35bee83c7d9_2e5b10845fc1494b7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Testing/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 56s] [119/363] installing libedit2-3.1-20190324-1 [ 56s] Processing triggers for libc-bin (2.28-10) ... [ 56s] [120/363] installing libhwloc5-1.11.12-3 [ 56s] Processing triggers for libc-bin (2.28-10) ... [ 56s] [121/363] installing libicu63-63.2-2 [ 57s] Processing triggers for libc-bin (2.28-10) ... [ 57s] [122/363] installing libmagic1-1:5.35-4 [ 58s] Processing triggers for libc-bin (2.28-10) ... [ 58s] [123/363] installing libuchardet0-0.0.6-3 [ 58s] Processing triggers for libc-bin (2.28-10) ... [ 58s] [124/363] installing libunwind8-1.2.1-9 [ 58s] Processing triggers for libc-bin (2.28-10) ... [ 58s] [125/363] installing python2.7-minimal-2.7.16-2 [ 59s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 59s] dpkg: error processing package python2.7-minimal (--install): [ 59s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 59s] Errors were encountered while processing: [ 59s] python2.7-minimal [ 59s] exit ... [ 59s] [ 59s] lamb61 failed "build libusrp_3.4.2.20190722.dsc" at Mon Jul 22 13:49:08 UTC 2019. [ 59s] [ 59s] ### VM INTERACTION START ### [ 62s] [ 36.510873] sysrq: SysRq : Power Off [ 62s] [ 36.528819] reboot: Power down [ 62s] ### VM INTERACTION END ### [ 62s] [ 62s] lamb61 failed "build libusrp_3.4.2.20190722.dsc" at Mon Jul 22 13:49:12 UTC 2019. [ 62s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 13:50:09 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 13:50:09 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35bf22c0e27_2e5b10845fc149837@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmocore failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 83s] [106/239] installing libedit2-3.1-20190324-1 [ 84s] Processing triggers for libc-bin (2.28-10) ... [ 84s] [107/239] installing libhogweed4-3.4.1-1 [ 84s] Processing triggers for libc-bin (2.28-10) ... [ 84s] [108/239] installing libicu63-63.2-2 [ 85s] Processing triggers for libc-bin (2.28-10) ... [ 85s] [109/239] installing libmagic1-1:5.35-4 [ 86s] Processing triggers for libc-bin (2.28-10) ... [ 86s] [110/239] installing libuchardet0-0.0.6-3 [ 86s] Processing triggers for libc-bin (2.28-10) ... [ 86s] [111/239] installing libunwind8-1.2.1-9 [ 86s] Processing triggers for libc-bin (2.28-10) ... [ 86s] [112/239] installing python2.7-minimal-2.7.16-2 [ 87s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 87s] dpkg: error processing package python2.7-minimal (--install): [ 87s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 87s] Errors were encountered while processing: [ 87s] python2.7-minimal [ 87s] exit ... [ 87s] [ 87s] cloud120 failed "build libosmocore_1.1.0.91.eb57.dsc" at Mon Jul 22 13:49:42 UTC 2019. [ 87s] [ 87s] ### VM INTERACTION START ### [ 90s] [ 56.388627] sysrq: SysRq : Power Off [ 90s] [ 56.393873] reboot: Power down [ 96s] ### VM INTERACTION END ### [ 96s] [ 96s] cloud120 failed "build libosmocore_1.1.0.91.eb57.dsc" at Mon Jul 22 13:49:52 UTC 2019. [ 96s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 13:51:17 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 13:51:17 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35bf5cce7dc_2e5b10845fc149995@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 36s] [156/382] installing libmagic1-1:5.35-4 [ 36s] Processing triggers for libc-bin (2.28-10) ... [ 36s] [157/382] installing libosp5-1.5.2-13+b1 [ 36s] Processing triggers for libc-bin (2.28-10) ... [ 36s] [158/382] installing libostyle1c2-1.4devel1-21.3+b1 [ 36s] Processing triggers for libc-bin (2.28-10) ... [ 36s] [159/382] installing libthai0-0.1.28-2 [ 36s] Processing triggers for libc-bin (2.28-10) ... [ 36s] [160/382] installing libuchardet0-0.0.6-3 [ 36s] Processing triggers for libc-bin (2.28-10) ... [ 36s] [161/382] installing libunwind8-1.2.1-9 [ 36s] Processing triggers for libc-bin (2.28-10) ... [ 36s] [162/382] installing python2.7-minimal-2.7.16-2 [ 37s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 37s] dpkg: error processing package python2.7-minimal (--install): [ 37s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 37s] Errors were encountered while processing: [ 37s] python2.7-minimal [ 37s] exit ... [ 37s] [ 37s] sheep81 failed "build osmo-gsm-manuals-dev_0.1.1.dsc" at Mon Jul 22 13:50:58 UTC 2019. [ 37s] [ 37s] ### VM INTERACTION START ### [ 40s] [ 28.683449] sysrq: SysRq : Power Off [ 40s] [ 28.689444] reboot: Power down [ 40s] ### VM INTERACTION END ### [ 40s] [ 40s] sheep81 failed "build osmo-gsm-manuals-dev_0.1.1.dsc" at Mon Jul 22 13:51:01 UTC 2019. [ 40s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 13:53:17 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 13:53:17 +0000 Subject: Build failure of network:osmocom:nightly/osmo-ggsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35bfd78fdb6_2e5b10845fc150412@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 117s] [163/406] installing libosmocore12-1.1.0.91.eb57 [ 118s] Processing triggers for libc-bin (2.28-10) ... [ 118s] [164/406] installing libosp5-1.5.2-13+b1 [ 118s] Processing triggers for libc-bin (2.28-10) ... [ 118s] [165/406] installing libostyle1c2-1.4devel1-21.3+b1 [ 119s] Processing triggers for libc-bin (2.28-10) ... [ 119s] [166/406] installing libthai0-0.1.28-2 [ 119s] Processing triggers for libc-bin (2.28-10) ... [ 119s] [167/406] installing libuchardet0-0.0.6-3 [ 119s] Processing triggers for libc-bin (2.28-10) ... [ 119s] [168/406] installing libunwind8-1.2.1-9 [ 120s] Processing triggers for libc-bin (2.28-10) ... [ 120s] [169/406] installing python2.7-minimal-2.7.16-2 [ 121s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 121s] dpkg: error processing package python2.7-minimal (--install): [ 121s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 121s] Errors were encountered while processing: [ 121s] python2.7-minimal [ 121s] exit ... [ 121s] [ 121s] lamb22 failed "build osmo-ggsn_1.3.0.47.f1e0.dsc" at Mon Jul 22 13:53:00 UTC 2019. [ 121s] [ 121s] ### VM INTERACTION START ### [ 125s] [ 96.459886] sysrq: SysRq : Power Off [ 125s] [ 96.486237] reboot: Power down [ 125s] ### VM INTERACTION END ### [ 125s] [ 125s] lamb22 failed "build osmo-ggsn_1.3.0.47.f1e0.dsc" at Mon Jul 22 13:53:04 UTC 2019. [ 125s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 13:53:52 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 13:53:52 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35bff24793e_2e5b10845fc15052@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 123s] Processing triggers for libc-bin (2.28-10) ... [ 123s] [89/208] installing libbinutils-2.31.1-16 [ 124s] Processing triggers for libc-bin (2.28-10) ... [ 124s] [90/208] installing libc6-dev-2.28-10 [ 126s] [91/208] installing libicu63-63.2-2 [ 129s] Processing triggers for libc-bin (2.28-10) ... [ 129s] [92/208] installing libmagic1-1:5.35-4 [ 130s] Processing triggers for libc-bin (2.28-10) ... [ 130s] [93/208] installing libuchardet0-0.0.6-3 [ 130s] Processing triggers for libc-bin (2.28-10) ... [ 130s] [94/208] installing libunwind8-1.2.1-9 [ 131s] Processing triggers for libc-bin (2.28-10) ... [ 131s] [95/208] installing python2.7-minimal-2.7.16-2 [ 132s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 132s] dpkg: error processing package python2.7-minimal (--install): [ 132s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 132s] Errors were encountered while processing: [ 132s] python2.7-minimal [ 132s] exit ... [ 132s] [ 132s] lamb60 failed "build osmo-python-tests_0.0.9.20190722.dsc" at Mon Jul 22 13:53:40 UTC 2019. [ 132s] [ 132s] ### VM INTERACTION START ### [ 136s] [ 75.615155] sysrq: SysRq : Power Off [ 136s] [ 75.636980] reboot: Power down [ 136s] ### VM INTERACTION END ### [ 136s] [ 136s] lamb60 failed "build osmo-python-tests_0.0.9.20190722.dsc" at Mon Jul 22 13:53:44 UTC 2019. [ 136s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 13:55:00 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 13:55:00 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcu in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c04bdd077_2e5b10845fc1510a7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 58s] [160/398] installing libosmocore12-1.1.0.91.eb57 [ 58s] Processing triggers for libc-bin (2.28-10) ... [ 58s] [161/398] installing libosp5-1.5.2-13+b1 [ 58s] Processing triggers for libc-bin (2.28-10) ... [ 58s] [162/398] installing libostyle1c2-1.4devel1-21.3+b1 [ 58s] Processing triggers for libc-bin (2.28-10) ... [ 59s] [163/398] installing libthai0-0.1.28-2 [ 59s] Processing triggers for libc-bin (2.28-10) ... [ 59s] [164/398] installing libuchardet0-0.0.6-3 [ 59s] Processing triggers for libc-bin (2.28-10) ... [ 59s] [165/398] installing libunwind8-1.2.1-9 [ 59s] Processing triggers for libc-bin (2.28-10) ... [ 59s] [166/398] installing python2.7-minimal-2.7.16-2 [ 60s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 60s] dpkg: error processing package python2.7-minimal (--install): [ 60s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 60s] Errors were encountered while processing: [ 60s] python2.7-minimal [ 60s] exit ... [ 60s] [ 60s] lamb06 failed "build osmo-pcu_0.6.0.82.7b7f2.dsc" at Mon Jul 22 13:54:44 UTC 2019. [ 60s] [ 60s] ### VM INTERACTION START ### [ 63s] [ 45.440410] sysrq: SysRq : Power Off [ 63s] [ 45.445829] reboot: Power down [ 63s] ### VM INTERACTION END ### [ 63s] [ 63s] lamb06 failed "build osmo-pcu_0.6.0.82.7b7f2.dsc" at Mon Jul 22 13:54:48 UTC 2019. [ 63s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 13:55:52 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 13:55:52 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sip-connector in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c06c2379b_2e5b10845fc1511f3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sip-connector failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 148s] [164/419] installing libosmocore12-1.1.0.91.eb57 [ 148s] Processing triggers for libc-bin (2.28-10) ... [ 148s] [165/419] installing libosp5-1.5.2-13+b1 [ 148s] Processing triggers for libc-bin (2.28-10) ... [ 149s] [166/419] installing libostyle1c2-1.4devel1-21.3+b1 [ 149s] Processing triggers for libc-bin (2.28-10) ... [ 149s] [167/419] installing libthai0-0.1.28-2 [ 149s] Processing triggers for libc-bin (2.28-10) ... [ 149s] [168/419] installing libuchardet0-0.0.6-3 [ 150s] Processing triggers for libc-bin (2.28-10) ... [ 150s] [169/419] installing libunwind8-1.2.1-9 [ 150s] Processing triggers for libc-bin (2.28-10) ... [ 150s] [170/419] installing python2.7-minimal-2.7.16-2 [ 152s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 152s] dpkg: error processing package python2.7-minimal (--install): [ 152s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 152s] Errors were encountered while processing: [ 152s] python2.7-minimal [ 152s] exit ... [ 152s] [ 152s] lamb51 failed "build osmo-sip-connector_1.2.0.9.a35a.dsc" at Mon Jul 22 13:55:33 UTC 2019. [ 152s] [ 152s] ### VM INTERACTION START ### [ 155s] [ 95.636416] sysrq: SysRq : Power Off [ 155s] [ 95.676418] reboot: Power down [ 155s] ### VM INTERACTION END ### [ 155s] [ 155s] lamb51 failed "build osmo-sip-connector_1.2.0.9.a35a.dsc" at Mon Jul 22 13:55:37 UTC 2019. [ 155s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 13:56:09 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 13:56:09 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c086400b0_2e5b10845fc1512e6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 53s] [163/410] installing libosmocore12-1.1.0.91.eb57 [ 53s] Processing triggers for libc-bin (2.28-10) ... [ 53s] [164/410] installing libosp5-1.5.2-13+b1 [ 54s] Processing triggers for libc-bin (2.28-10) ... [ 54s] [165/410] installing libostyle1c2-1.4devel1-21.3+b1 [ 54s] Processing triggers for libc-bin (2.28-10) ... [ 54s] [166/410] installing libthai0-0.1.28-2 [ 54s] Processing triggers for libc-bin (2.28-10) ... [ 54s] [167/410] installing libuchardet0-0.0.6-3 [ 54s] Processing triggers for libc-bin (2.28-10) ... [ 54s] [168/410] installing libunwind8-1.2.1-9 [ 54s] Processing triggers for libc-bin (2.28-10) ... [ 54s] [169/410] installing python2.7-minimal-2.7.16-2 [ 55s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 55s] dpkg: error processing package python2.7-minimal (--install): [ 55s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 55s] Errors were encountered while processing: [ 55s] python2.7-minimal [ 55s] exit ... [ 55s] [ 55s] lamb04 failed "build osmo-bts_0.8.1.352.aa54.dsc" at Mon Jul 22 13:56:03 UTC 2019. [ 55s] [ 55s] ### VM INTERACTION START ### [ 58s] [ 39.445091] sysrq: SysRq : Power Off [ 58s] [ 39.451212] reboot: Power down [ 58s] ### VM INTERACTION END ### [ 58s] [ 58s] lamb04 failed "build osmo-bts_0.8.1.352.aa54.dsc" at Mon Jul 22 13:56:07 UTC 2019. [ 58s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 13:58:43 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 13:58:43 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c11d9e42c_2e5b10845fc1523a8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 81s] Processing triggers for libc-bin (2.28-10) ... [ 81s] [98/220] installing libc6-dev-2.28-10 [ 82s] [99/220] installing libhogweed4-3.4.1-1 [ 82s] Processing triggers for libc-bin (2.28-10) ... [ 82s] [100/220] installing libicu63-63.2-2 [ 85s] Processing triggers for libc-bin (2.28-10) ... [ 85s] [101/220] installing libmagic1-1:5.35-4 [ 85s] Processing triggers for libc-bin (2.28-10) ... [ 85s] [102/220] installing libuchardet0-0.0.6-3 [ 85s] Processing triggers for libc-bin (2.28-10) ... [ 85s] [103/220] installing libunwind8-1.2.1-9 [ 86s] Processing triggers for libc-bin (2.28-10) ... [ 86s] [104/220] installing python2.7-minimal-2.7.16-2 [ 87s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 87s] dpkg: error processing package python2.7-minimal (--install): [ 87s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 87s] Errors were encountered while processing: [ 87s] python2.7-minimal [ 87s] exit ... [ 87s] [ 87s] lamb51 failed "build osmo-hlr_1.0.0.dsc" at Mon Jul 22 13:58:23 UTC 2019. [ 87s] [ 87s] ### VM INTERACTION START ### [ 90s] [ 55.443988] sysrq: SysRq : Power Off [ 90s] [ 55.494986] reboot: Power down [ 90s] ### VM INTERACTION END ### [ 90s] [ 90s] lamb51 failed "build osmo-hlr_1.0.0.dsc" at Mon Jul 22 13:58:26 UTC 2019. [ 90s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 14:00:26 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 14:00:26 +0000 Subject: Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c19854e79_2e5b10845fc152728@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 43s] [190/559] installing libosmocore12-1.1.0.91.eb57 [ 43s] Processing triggers for libc-bin (2.28-10) ... [ 43s] [191/559] installing libosp5-1.5.2-13+b1 [ 43s] Processing triggers for libc-bin (2.28-10) ... [ 43s] [192/559] installing libostyle1c2-1.4devel1-21.3+b1 [ 43s] Processing triggers for libc-bin (2.28-10) ... [ 43s] [193/559] installing libthai0-0.1.28-2 [ 43s] Processing triggers for libc-bin (2.28-10) ... [ 43s] [194/559] installing libuchardet0-0.0.6-3 [ 43s] Processing triggers for libc-bin (2.28-10) ... [ 43s] [195/559] installing libunwind8-1.2.1-9 [ 43s] Processing triggers for libc-bin (2.28-10) ... [ 43s] [196/559] installing python2.7-minimal-2.7.16-2 [ 44s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 44s] dpkg: error processing package python2.7-minimal (--install): [ 44s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 44s] Errors were encountered while processing: [ 44s] python2.7-minimal [ 44s] exit ... [ 44s] [ 44s] sheep82 failed "build osmo-trx_1.0.0.81.2896.dsc" at Mon Jul 22 14:00:14 UTC 2019. [ 44s] [ 44s] ### VM INTERACTION START ### [ 47s] [ 34.259016] sysrq: SysRq : Power Off [ 47s] [ 34.266113] reboot: Power down [ 47s] ### VM INTERACTION END ### [ 47s] [ 47s] sheep82 failed "build osmo-trx_1.0.0.81.2896.dsc" at Mon Jul 22 14:00:18 UTC 2019. [ 47s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 14:00:26 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 14:00:26 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-sccp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c197f3a7e_2e5b10845fc15264@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 60s] [165/415] installing libosmocore12-1.1.0.91.eb57 [ 60s] Processing triggers for libc-bin (2.28-10) ... [ 60s] [166/415] installing libosp5-1.5.2-13+b1 [ 60s] Processing triggers for libc-bin (2.28-10) ... [ 60s] [167/415] installing libostyle1c2-1.4devel1-21.3+b1 [ 60s] Processing triggers for libc-bin (2.28-10) ... [ 60s] [168/415] installing libthai0-0.1.28-2 [ 60s] Processing triggers for libc-bin (2.28-10) ... [ 60s] [169/415] installing libuchardet0-0.0.6-3 [ 60s] Processing triggers for libc-bin (2.28-10) ... [ 60s] [170/415] installing libunwind8-1.2.1-9 [ 61s] Processing triggers for libc-bin (2.28-10) ... [ 61s] [171/415] installing python2.7-minimal-2.7.16-2 [ 61s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 61s] dpkg: error processing package python2.7-minimal (--install): [ 61s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 61s] Errors were encountered while processing: [ 61s] python2.7-minimal [ 61s] exit ... [ 61s] [ 61s] lamb10 failed "build libosmo-sccp_1.0.0.25.2164.dsc" at Mon Jul 22 14:00:13 UTC 2019. [ 61s] [ 61s] ### VM INTERACTION START ### [ 64s] [ 45.017450] sysrq: SysRq : Power Off [ 64s] [ 45.023831] reboot: Power down [ 64s] ### VM INTERACTION END ### [ 64s] [ 64s] lamb10 failed "build libosmo-sccp_1.0.0.25.2164.dsc" at Mon Jul 22 14:00:16 UTC 2019. [ 64s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 14:00:43 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 14:00:43 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hlr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c1998458e_2e5b10845fc152834@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 74s] [163/411] installing libosmocore12-1.1.0.91.eb57 [ 74s] Processing triggers for libc-bin (2.28-10) ... [ 74s] [164/411] installing libosp5-1.5.2-13+b1 [ 74s] Processing triggers for libc-bin (2.28-10) ... [ 74s] [165/411] installing libostyle1c2-1.4devel1-21.3+b1 [ 74s] Processing triggers for libc-bin (2.28-10) ... [ 75s] [166/411] installing libthai0-0.1.28-2 [ 75s] Processing triggers for libc-bin (2.28-10) ... [ 75s] [167/411] installing libuchardet0-0.0.6-3 [ 75s] Processing triggers for libc-bin (2.28-10) ... [ 75s] [168/411] installing libunwind8-1.2.1-9 [ 75s] Processing triggers for libc-bin (2.28-10) ... [ 75s] [169/411] installing python2.7-minimal-2.7.16-2 [ 76s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 76s] dpkg: error processing package python2.7-minimal (--install): [ 76s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 76s] Errors were encountered while processing: [ 76s] python2.7-minimal [ 76s] exit ... [ 76s] [ 76s] wildcard2 failed "build osmo-hlr_1.0.0.41.b64c.dsc" at Mon Jul 22 14:00:30 UTC 2019. [ 76s] [ 76s] ### VM INTERACTION START ### [ 79s] [ 56.688832] sysrq: SysRq : Power Off [ 79s] [ 56.690867] reboot: Power down [ 81s] ### VM INTERACTION END ### [ 81s] [ 81s] wildcard2 failed "build osmo-hlr_1.0.0.41.b64c.dsc" at Mon Jul 22 14:00:36 UTC 2019. [ 81s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 14:01:17 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 14:01:17 +0000 Subject: Build failure of network:osmocom:nightly/osmo-mgw in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c1b87e217_2e5b10845fc1530d7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-mgw failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 106s] [161/400] installing libosmocore12-1.1.0.91.eb57 [ 106s] Processing triggers for libc-bin (2.28-10) ... [ 106s] [162/400] installing libosp5-1.5.2-13+b1 [ 106s] Processing triggers for libc-bin (2.28-10) ... [ 106s] [163/400] installing libostyle1c2-1.4devel1-21.3+b1 [ 106s] Processing triggers for libc-bin (2.28-10) ... [ 106s] [164/400] installing libthai0-0.1.28-2 [ 106s] Processing triggers for libc-bin (2.28-10) ... [ 106s] [165/400] installing libuchardet0-0.0.6-3 [ 107s] Processing triggers for libc-bin (2.28-10) ... [ 107s] [166/400] installing libunwind8-1.2.1-9 [ 107s] Processing triggers for libc-bin (2.28-10) ... [ 107s] [167/400] installing python2.7-minimal-2.7.16-2 [ 108s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 108s] dpkg: error processing package python2.7-minimal (--install): [ 108s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 108s] Errors were encountered while processing: [ 108s] python2.7-minimal [ 108s] exit ... [ 108s] [ 108s] lamb54 failed "build osmo-mgw_1.5.0.78.06a4.dsc" at Mon Jul 22 14:01:06 UTC 2019. [ 108s] [ 108s] ### VM INTERACTION START ### [ 111s] [ 60.657644] sysrq: SysRq : Power Off [ 111s] [ 60.671304] reboot: Power down [ 111s] ### VM INTERACTION END ### [ 111s] [ 111s] lamb54 failed "build osmo-mgw_1.5.0.78.06a4.dsc" at Mon Jul 22 14:01:10 UTC 2019. [ 111s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 14:03:00 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 14:03:00 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c22caaae_2e5b10845fc153188@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 87s] [106/240] installing libhogweed4-3.4.1-1 [ 87s] Processing triggers for libc-bin (2.28-10) ... [ 87s] [107/240] installing libicu63-63.2-2 [ 89s] Processing triggers for libc-bin (2.28-10) ... [ 90s] [108/240] installing libmagic1-1:5.35-4 [ 90s] Processing triggers for libc-bin (2.28-10) ... [ 90s] [109/240] installing libosmocore12-1.1.0.91.eb57 [ 90s] Processing triggers for libc-bin (2.28-10) ... [ 90s] [110/240] installing libuchardet0-0.0.6-3 [ 91s] Processing triggers for libc-bin (2.28-10) ... [ 91s] [111/240] installing libunwind8-1.2.1-9 [ 91s] Processing triggers for libc-bin (2.28-10) ... [ 91s] [112/240] installing python2.7-minimal-2.7.16-2 [ 92s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 92s] dpkg: error processing package python2.7-minimal (--install): [ 92s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 92s] Errors were encountered while processing: [ 92s] python2.7-minimal [ 92s] exit ... [ 92s] [ 92s] lamb22 failed "build osmo-iuh_0.4.0.11.3030.dsc" at Mon Jul 22 14:02:39 UTC 2019. [ 92s] [ 92s] ### VM INTERACTION START ### [ 95s] [ 63.613412] sysrq: SysRq : Power Off [ 96s] [ 63.659655] reboot: Power down [ 96s] ### VM INTERACTION END ### [ 96s] [ 96s] lamb22 failed "build osmo-iuh_0.4.0.11.3030.dsc" at Mon Jul 22 14:02:44 UTC 2019. [ 96s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 14:03:17 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 14:03:17 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c22e244d4_2e5b10845fc153378@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 110s] [130/389] installing libhogweed4-3.4.1-1 [ 110s] Processing triggers for libc-bin (2.28-10) ... [ 110s] [131/389] installing libhwloc5-1.11.12-3 [ 110s] Processing triggers for libc-bin (2.28-10) ... [ 110s] [132/389] installing libicu63-63.2-2 [ 111s] Processing triggers for libc-bin (2.28-10) ... [ 111s] [133/389] installing libmagic1-1:5.35-4 [ 111s] Processing triggers for libc-bin (2.28-10) ... [ 111s] [134/389] installing libuchardet0-0.0.6-3 [ 111s] Processing triggers for libc-bin (2.28-10) ... [ 111s] [135/389] installing libunwind8-1.2.1-9 [ 111s] Processing triggers for libc-bin (2.28-10) ... [ 111s] [136/389] installing python2.7-minimal-2.7.16-2 [ 112s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 112s] dpkg: error processing package python2.7-minimal (--install): [ 112s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 112s] Errors were encountered while processing: [ 112s] python2.7-minimal [ 112s] exit ... [ 112s] [ 112s] lamb51 failed "build osmo-trx_1.0.0.dsc" at Mon Jul 22 14:02:58 UTC 2019. [ 112s] [ 112s] ### VM INTERACTION START ### [ 115s] [ 64.964180] sysrq: SysRq : Power Off [ 115s] [ 64.972315] reboot: Power down [ 115s] ### VM INTERACTION END ### [ 115s] [ 115s] lamb51 failed "build osmo-trx_1.0.0.dsc" at Mon Jul 22 14:03:01 UTC 2019. [ 115s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 14:03:52 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 14:03:52 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c24a4316a_2e5b10845fc153553@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 33s] Processing triggers for libc-bin (2.28-10) ... [ 33s] [98/224] installing libc6-dev-2.28-10 [ 33s] [99/224] installing libhogweed4-3.4.1-1 [ 34s] Processing triggers for libc-bin (2.28-10) ... [ 34s] [100/224] installing libicu63-63.2-2 [ 35s] Processing triggers for libc-bin (2.28-10) ... [ 35s] [101/224] installing libmagic1-1:5.35-4 [ 35s] Processing triggers for libc-bin (2.28-10) ... [ 35s] [102/224] installing libuchardet0-0.0.6-3 [ 35s] Processing triggers for libc-bin (2.28-10) ... [ 35s] [103/224] installing libunwind8-1.2.1-9 [ 35s] Processing triggers for libc-bin (2.28-10) ... [ 35s] [104/224] installing python2.7-minimal-2.7.16-2 [ 36s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 36s] dpkg: error processing package python2.7-minimal (--install): [ 36s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 36s] Errors were encountered while processing: [ 36s] python2.7-minimal [ 36s] exit ... [ 36s] [ 36s] lamb16 failed "build osmo-bsc_1.4.1.dsc" at Mon Jul 22 14:03:35 UTC 2019. [ 36s] [ 36s] ### VM INTERACTION START ### [ 39s] [ 25.081261] sysrq: SysRq : Power Off [ 39s] [ 25.086586] reboot: Power down [ 39s] ### VM INTERACTION END ### [ 39s] [ 39s] lamb16 failed "build osmo-bsc_1.4.1.dsc" at Mon Jul 22 14:03:38 UTC 2019. [ 39s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 14:04:09 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 14:04:09 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c26954e5f_2e5b10845fc1536ea@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 44s] Processing triggers for libc-bin (2.28-10) ... [ 44s] [105/239] installing libc6-dev-2.28-10 [ 44s] [106/239] installing libhogweed4-3.4.1-1 [ 45s] Processing triggers for libc-bin (2.28-10) ... [ 45s] [107/239] installing libicu63-63.2-2 [ 46s] Processing triggers for libc-bin (2.28-10) ... [ 46s] [108/239] installing libmagic1-1:5.35-4 [ 46s] Processing triggers for libc-bin (2.28-10) ... [ 46s] [109/239] installing libuchardet0-0.0.6-3 [ 46s] Processing triggers for libc-bin (2.28-10) ... [ 46s] [110/239] installing libunwind8-1.2.1-9 [ 46s] Processing triggers for libc-bin (2.28-10) ... [ 46s] [111/239] installing python2.7-minimal-2.7.16-2 [ 47s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 47s] dpkg: error processing package python2.7-minimal (--install): [ 47s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 47s] Errors were encountered while processing: [ 47s] python2.7-minimal [ 47s] exit ... [ 47s] [ 47s] lamb55 failed "build osmo-iuh_0.4.0.dsc" at Mon Jul 22 14:03:49 UTC 2019. [ 47s] [ 47s] ### VM INTERACTION START ### [ 51s] [ 34.128825] sysrq: SysRq : Power Off [ 51s] [ 34.163577] reboot: Power down [ 51s] ### VM INTERACTION END ### [ 51s] [ 51s] lamb55 failed "build osmo-iuh_0.4.0.dsc" at Mon Jul 22 14:03:53 UTC 2019. [ 51s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 14:04:26 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 14:04:26 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c2885c3ec_2e5b10845fc153772@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 54s] [170/425] installing libosmocore12-1.1.0.91.eb57 [ 54s] Processing triggers for libc-bin (2.28-10) ... [ 54s] [171/425] installing libosp5-1.5.2-13+b1 [ 55s] Processing triggers for libc-bin (2.28-10) ... [ 55s] [172/425] installing libostyle1c2-1.4devel1-21.3+b1 [ 55s] Processing triggers for libc-bin (2.28-10) ... [ 55s] [173/425] installing libthai0-0.1.28-2 [ 55s] Processing triggers for libc-bin (2.28-10) ... [ 55s] [174/425] installing libuchardet0-0.0.6-3 [ 55s] Processing triggers for libc-bin (2.28-10) ... [ 55s] [175/425] installing libunwind8-1.2.1-9 [ 55s] Processing triggers for libc-bin (2.28-10) ... [ 55s] [176/425] installing python2.7-minimal-2.7.16-2 [ 56s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 56s] dpkg: error processing package python2.7-minimal (--install): [ 56s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 56s] Errors were encountered while processing: [ 56s] python2.7-minimal [ 56s] exit ... [ 56s] [ 56s] lamb19 failed "build osmo-msc_1.3.1.180.efa7.dsc" at Mon Jul 22 14:04:16 UTC 2019. [ 56s] [ 56s] ### VM INTERACTION START ### [ 59s] [ 40.391787] sysrq: SysRq : Power Off [ 59s] [ 40.402696] reboot: Power down [ 59s] ### VM INTERACTION END ### [ 59s] [ 59s] lamb19 failed "build osmo-msc_1.3.1.180.efa7.dsc" at Mon Jul 22 14:04:20 UTC 2019. [ 59s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 14:04:26 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 14:04:26 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c288bd126_2e5b10845fc1538c9@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 52s] [167/422] installing libosmocore12-1.1.0.91.eb57 [ 52s] Processing triggers for libc-bin (2.28-10) ... [ 52s] [168/422] installing libosp5-1.5.2-13+b1 [ 53s] Processing triggers for libc-bin (2.28-10) ... [ 53s] [169/422] installing libostyle1c2-1.4devel1-21.3+b1 [ 53s] Processing triggers for libc-bin (2.28-10) ... [ 53s] [170/422] installing libthai0-0.1.28-2 [ 53s] Processing triggers for libc-bin (2.28-10) ... [ 53s] [171/422] installing libuchardet0-0.0.6-3 [ 53s] Processing triggers for libc-bin (2.28-10) ... [ 53s] [172/422] installing libunwind8-1.2.1-9 [ 53s] Processing triggers for libc-bin (2.28-10) ... [ 53s] [173/422] installing python2.7-minimal-2.7.16-2 [ 54s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 54s] dpkg: error processing package python2.7-minimal (--install): [ 54s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 54s] Errors were encountered while processing: [ 54s] python2.7-minimal [ 54s] exit ... [ 54s] [ 54s] lamb07 failed "build osmo-sgsn_1.4.0.30.4b8e.dsc" at Mon Jul 22 14:04:19 UTC 2019. [ 54s] [ 54s] ### VM INTERACTION START ### [ 57s] [ 38.966405] sysrq: SysRq : Power Off [ 57s] [ 38.976835] reboot: Power down [ 57s] ### VM INTERACTION END ### [ 57s] [ 57s] lamb07 failed "build osmo-sgsn_1.4.0.30.4b8e.dsc" at Mon Jul 22 14:04:22 UTC 2019. [ 57s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 14:05:00 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 14:05:00 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d35c2a54d60a_2e5b10845fc153934@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 169s] [164/416] installing libosmocore12-1.1.0.91.eb57 [ 170s] Processing triggers for libc-bin (2.28-10) ... [ 170s] [165/416] installing libosp5-1.5.2-13+b1 [ 170s] Processing triggers for libc-bin (2.28-10) ... [ 170s] [166/416] installing libostyle1c2-1.4devel1-21.3+b1 [ 171s] Processing triggers for libc-bin (2.28-10) ... [ 171s] [167/416] installing libthai0-0.1.28-2 [ 171s] Processing triggers for libc-bin (2.28-10) ... [ 171s] [168/416] installing libuchardet0-0.0.6-3 [ 171s] Processing triggers for libc-bin (2.28-10) ... [ 171s] [169/416] installing libunwind8-1.2.1-9 [ 172s] Processing triggers for libc-bin (2.28-10) ... [ 172s] [170/416] installing python2.7-minimal-2.7.16-2 [ 173s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 173s] dpkg: error processing package python2.7-minimal (--install): [ 173s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 173s] Errors were encountered while processing: [ 173s] python2.7-minimal [ 173s] exit ... [ 173s] [ 173s] lamb26 failed "build osmo-bsc_1.4.0.104.7fbcc.dsc" at Mon Jul 22 14:04:46 UTC 2019. [ 173s] [ 173s] ### VM INTERACTION START ### [ 176s] [ 97.088839] sysrq: SysRq : Power Off [ 176s] [ 97.138173] reboot: Power down [ 176s] ### VM INTERACTION END ### [ 177s] [ 177s] lamb26 failed "build osmo-bsc_1.4.0.104.7fbcc.dsc" at Mon Jul 22 14:04:50 UTC 2019. [ 177s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Jul 22 15:13:04 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 15:13:04 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... bts-trx: Introduce VTY command osmotrx trxd-max-version This command allows setting a maximum TRXD format version to negotiate with TRX. osmo-bts-trx will hence end up using that version if supported by TRX, or a lower one otherwise (or fail if TRX doesn't support any of them). Since now the maximum version can be 0, avoid going through SETFORMAT negotiation in that case, since 0 is the default version. This way we keep backward compatibility with TRX implementations that exit upon receival of unknown commands (such as SC5 current one). Related: OS#4006 Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 --- M include/osmo-bts/phy_link.h M src/osmo-bts-trx/l1_if.c M src/osmo-bts-trx/main.c M src/osmo-bts-trx/trx_vty.c 4 files changed, 32 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/96/14896/1 diff --git a/include/osmo-bts/phy_link.h b/include/osmo-bts/phy_link.h index 273103c..3bf5159 100644 --- a/include/osmo-bts/phy_link.h +++ b/include/osmo-bts/phy_link.h @@ -50,6 +50,7 @@ uint32_t clock_advance; uint32_t rts_advance; bool use_legacy_setbsic; + uint8_t trxd_hdr_ver_max; /* Maximum TRXD header version to negotiate */ } osmotrx; struct { char *mcast_dev; /* Network device for multicast */ diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c index 9c1dc18..22ef2d7 100644 --- a/src/osmo-bts-trx/l1_if.c +++ b/src/osmo-bts-trx/l1_if.c @@ -185,6 +185,7 @@ int l1if_provision_transceiver_trx(struct trx_l1h *l1h) { uint8_t tn; + struct phy_link *plink = l1h->phy_inst->phy_link; if (!transceiver_available) return -EIO; @@ -208,10 +209,11 @@ l1h->config.bsic_sent = 1; } - /* Ask transceiver to use the newest TRXD header version */ - if (!l1h->config.setformat_sent) { - trx_if_cmd_setformat(l1h, TRX_DATA_FORMAT_VER); - l1h->config.trxd_hdr_ver_req = TRX_DATA_FORMAT_VER; + /* Ask transceiver to use the newest TRXD header version if not using it yet */ + if (!l1h->config.setformat_sent && + l1h->config.trxd_hdr_ver_use != plink->u.osmotrx.trxd_hdr_ver_max) { + trx_if_cmd_setformat(l1h, plink->u.osmotrx.trxd_hdr_ver_max); + l1h->config.trxd_hdr_ver_req = plink->u.osmotrx.trxd_hdr_ver_max; l1h->config.setformat_sent = 1; } diff --git a/src/osmo-bts-trx/main.c b/src/osmo-bts-trx/main.c index 9529190..b1fa207 100644 --- a/src/osmo-bts-trx/main.c +++ b/src/osmo-bts-trx/main.c @@ -134,6 +134,8 @@ plink->u.osmotrx.trx_ta_loop = true; plink->u.osmotrx.trx_ms_power_loop = false; plink->u.osmotrx.trx_target_rssi = -10; + /* attempt use newest TRXD version by default: */ + plink->u.osmotrx.trxd_hdr_ver_max = TRX_DATA_FORMAT_VER; } void bts_model_phy_instance_set_defaults(struct phy_instance *pinst) diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c index b9af445..21b21bd 100644 --- a/src/osmo-bts-trx/trx_vty.c +++ b/src/osmo-bts-trx/trx_vty.c @@ -496,6 +496,25 @@ return CMD_SUCCESS; } +DEFUN(cfg_phy_trxd_max_version, cfg_phy_trxd_max_version_cmd, + "osmotrx trxd-max-version <-1-15>", OSMOTRX_STR + "Set maximum TRXD format version to negotiate with TRX\n" + "The maximum TRXD format version to negotiate with TRX (-1 for highest supported, default)\n") +{ + struct phy_link *plink = vty->index; + + int max_ver = atoi(argv[0]); + if (max_ver == -1) + max_ver = TRX_DATA_FORMAT_VER; + if (max_ver > TRX_DATA_FORMAT_VER) { + vty_out(vty, "%% Format version %d is not supported by osmo-bts-trx%s", max_ver, VTY_NEWLINE); + return CMD_WARNING; + } + plink->u.osmotrx.trxd_hdr_ver_max = max_ver; + + return CMD_SUCCESS; +} + void bts_model_config_write_phy(struct vty *vty, struct phy_link *plink) { if (plink->u.osmotrx.local_ip) @@ -525,6 +544,9 @@ if (plink->u.osmotrx.use_legacy_setbsic) vty_out(vty, " osmotrx legacy-setbsic%s", VTY_NEWLINE); + + if (plink->u.osmotrx.trxd_hdr_ver_max != TRX_DATA_FORMAT_VER) + vty_out(vty, " osmotrx trxd-max-version %d%s", plink->u.osmotrx.trxd_hdr_ver_max, VTY_NEWLINE); } void bts_model_config_write_phy_inst(struct vty *vty, struct phy_instance *pinst) @@ -584,6 +606,7 @@ install_element(PHY_NODE, &cfg_phy_osmotrx_ip_cmd); install_element(PHY_NODE, &cfg_phy_setbsic_cmd); install_element(PHY_NODE, &cfg_phy_no_setbsic_cmd); + install_element(PHY_NODE, &cfg_phy_trxd_max_version_cmd); install_element(PHY_INST_NODE, &cfg_phyinst_rxgain_cmd); install_element(PHY_INST_NODE, &cfg_phyinst_tx_atten_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 15:14:56 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 15:14:56 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 ) Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... bts-trx: Introduce VTY command osmotrx trxd-max-version This command allows setting a maximum TRXD format version to negotiate with TRX. osmo-bts-trx will hence end up using that version if supported by TRX, or a lower one otherwise (or fail if TRX doesn't support any of them). Since now the maximum version can be 0, avoid going through SETFORMAT negotiation in that case, since 0 is the default version. This way we keep backward compatibility with TRX implementations that exit upon receival of unknown commands (such as SC5 current one). The VTY command is located in the "phy" node instead of the "phy instance" node because instances of same phy are expected to use same host with same implementation, so TRXD version to use should be the same for both. Related: OS#4006 Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 --- M include/osmo-bts/phy_link.h M src/osmo-bts-trx/l1_if.c M src/osmo-bts-trx/main.c M src/osmo-bts-trx/trx_vty.c 4 files changed, 32 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/96/14896/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 15:50:42 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 15:50:42 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Store TRXD version per channel Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14897 Change subject: Transceiver: Store TRXD version per channel ...................................................................... Transceiver: Store TRXD version per channel The setting is negotiatied by osmo-bts-trx on each channel, so let's keep and use state per channel instead of overwriting the state from different channels. Take the chance to change related log lines to also print the channel number. Change-Id: If9cf95e89d38d0155ab48b8c0977ca5f381c2aad --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 9 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/97/14897/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 17e0476..01a0e9b 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -127,7 +127,7 @@ mSPSTx(tx_sps), mSPSRx(rx_sps), mChans(chans), mExtRACH(false), mEdge(false), mOn(false), mForceClockInterface(false), mTxFreq(0.0), mRxFreq(0.0), mTSC(0), mMaxExpectedDelayAB(0), mMaxExpectedDelayNB(0), - mWriteBurstToDiskMask(0), mVersionTRXD(0) + mWriteBurstToDiskMask(0) { txFullScale = mRadioInterface->fullScaleInputValue(); rxFullScale = mRadioInterface->fullScaleOutputValue(); @@ -196,6 +196,7 @@ mTxPriorityQueues.resize(mChans); mReceiveFIFO.resize(mChans); mStates.resize(mChans); + mVersionTRXD.resize(mChans); /* Filler table retransmissions - support only on channel 0 */ if (filler == FILLER_DUMMY) @@ -883,14 +884,14 @@ // set TRXD protocol version unsigned version_recv; sscanf(params, "%u", &version_recv); - LOGC(DTRXCTRL, INFO) << "BTS requests TRXD version switch: " << version_recv; + LOGCHAN(chan, DTRXCTRL, INFO) << "BTS requests TRXD version switch: " << version_recv; if (version_recv > TRX_DATA_FORMAT_VER) { - LOGC(DTRXCTRL, INFO) << "rejecting TRXD version " << version_recv - << "in favor of " << TRX_DATA_FORMAT_VER; + LOGCHAN(chan, DTRXCTRL, INFO) << "rejecting TRXD version " << version_recv + << "in favor of " << TRX_DATA_FORMAT_VER; sprintf(response, "RSP SETFORMAT %u %u", TRX_DATA_FORMAT_VER, version_recv); } else { - LOGC(DTRXCTRL, NOTICE) << "switching to TRXD version " << version_recv; - mVersionTRXD = version_recv; + LOGCHAN(chan, DTRXCTRL, NOTICE) << "switching to TRXD version " << version_recv; + mVersionTRXD[chan] = version_recv; sprintf(response, "RSP SETFORMAT %u %u", version_recv, version_recv); } } else if (match_cmd(command, "_SETBURSTTODISKMASK", ¶ms)) { @@ -1021,7 +1022,7 @@ if (!bi.idle) logRxBurst(chan, &bi); - switch (mVersionTRXD) { + switch (mVersionTRXD[chan]) { case 0: trxd_send_burst_ind_v0(chan, mDataSockets[chan], &bi); break; diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index aa2a716..be67b33 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -216,8 +216,8 @@ unsigned mMaxExpectedDelayAB; ///< maximum expected time-of-arrival offset in GSM symbols for Access Bursts (RACH) unsigned mMaxExpectedDelayNB; ///< maximum expected time-of-arrival offset in GSM symbols for Normal Bursts unsigned mWriteBurstToDiskMask; ///< debug: bitmask to indicate which timeslots to dump to disk - unsigned mVersionTRXD; ///< Format version to use for TRXD protocol communication + std::vector mVersionTRXD; ///< Format version to use for TRXD protocol communication, per channel std::vector mStates; /** Start and stop I/O threads through the control socket API */ -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9cf95e89d38d0155ab48b8c0977ca5f381c2aad Gerrit-Change-Number: 14897 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 16:13:26 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 16:13:26 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Clean up code passing parameters to threads Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14898 Change subject: Transceiver: Clean up code passing parameters to threads ...................................................................... Transceiver: Clean up code passing parameters to threads TransceiverChannel naming was misleading there. It's simply a data type used to pass 2 parameters through the void* of the thread entry function, so let's clearly specify is a storage for thread params. Furthermore, we don't need a full C++ class for that, let's simply use a struct. Change-Id: I6e3898a8a66520cc5b2a7df9b9ae01b0b272387f --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 37 insertions(+), 45 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/98/14898/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 01a0e9b..c8cef73 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -238,10 +238,12 @@ /* Start control threads */ for (size_t i = 0; i < mChans; i++) { - TransceiverChannel *chan = new TransceiverChannel(this, i); + TrxChanThParams *params = (TrxChanThParams *)malloc(sizeof(struct TrxChanThParams)); + params->trx = this; + params->num = i; mControlServiceLoopThreads[i] = new Thread(stackSize); mControlServiceLoopThreads[i]->start((void * (*)(void*)) - ControlServiceLoopAdapter, (void*) chan); + ControlServiceLoopAdapter, (void*) params); if (i && filler == FILLER_DUMMY) filler = FILLER_ZERO; @@ -290,15 +292,19 @@ /* Launch uplink and downlink burst processing threads */ for (size_t i = 0; i < mChans; i++) { - TransceiverChannel *chan = new TransceiverChannel(this, i); + TrxChanThParams *params = (TrxChanThParams *)malloc(sizeof(struct TrxChanThParams)); + params->trx = this; + params->num = i; mRxServiceLoopThreads[i] = new Thread(stackSize); mRxServiceLoopThreads[i]->start((void * (*)(void*)) - RxUpperLoopAdapter, (void*) chan); + RxUpperLoopAdapter, (void*) params); - chan = new TransceiverChannel(this, i); + params = (TrxChanThParams *)malloc(sizeof(struct TrxChanThParams)); + params->trx = this; + params->num = i; mTxPriorityQueueServiceLoopThreads[i] = new Thread(stackSize); mTxPriorityQueueServiceLoopThreads[i]->start((void * (*)(void*)) - TxUpperLoopAdapter, (void*) chan); + TxUpperLoopAdapter, (void*) params); } mForceClockInterface = true; @@ -1106,13 +1112,13 @@ } -void *RxUpperLoopAdapter(TransceiverChannel *chan) +void *RxUpperLoopAdapter(TrxChanThParams *params) { char thread_name[16]; - Transceiver *trx = chan->trx; - size_t num = chan->num; + Transceiver *trx = params->trx; + size_t num = params->num; - delete chan; + free(params); snprintf(thread_name, 16, "RxUpper%zu", num); set_selfthread_name(thread_name); @@ -1152,13 +1158,13 @@ return NULL; } -void *ControlServiceLoopAdapter(TransceiverChannel *chan) +void *ControlServiceLoopAdapter(TrxChanThParams *params) { char thread_name[16]; - Transceiver *trx = chan->trx; - size_t num = chan->num; + Transceiver *trx = params->trx; + size_t num = params->num; - delete chan; + free(params); snprintf(thread_name, 16, "CtrlService%zu", num); set_selfthread_name(thread_name); @@ -1170,13 +1176,13 @@ return NULL; } -void *TxUpperLoopAdapter(TransceiverChannel *chan) +void *TxUpperLoopAdapter(TrxChanThParams *params) { char thread_name[16]; - Transceiver *trx = chan->trx; - size_t num = chan->num; + Transceiver *trx = params->trx; + size_t num = params->num; - delete chan; + free(params); snprintf(thread_name, 16, "TxUpper%zu", num); set_selfthread_name(thread_name); diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index be67b33..87d699c 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -37,19 +37,9 @@ class Transceiver; /** Channel descriptor for transceiver object and channel number pair */ -struct TransceiverChannel { - TransceiverChannel(Transceiver *trx, int num) - { - this->trx = trx; - this->num = num; - } - - ~TransceiverChannel() - { - } - - Transceiver *trx; - size_t num; +struct TrxChanThParams { + Transceiver *trx; + size_t num; }; /** Internal transceiver state variables */ @@ -246,15 +236,11 @@ */ bool driveTxPriorityQueue(size_t chan); - friend void *RxUpperLoopAdapter(TransceiverChannel *); - - friend void *TxUpperLoopAdapter(TransceiverChannel *); - - friend void *RxLowerLoopAdapter(Transceiver *); - - friend void *TxLowerLoopAdapter(Transceiver *); - - friend void *ControlServiceLoopAdapter(TransceiverChannel *); + friend void *RxUpperLoopAdapter(TrxChanThParams *params); + friend void *TxUpperLoopAdapter(TrxChanThParams *params); + friend void *RxLowerLoopAdapter(Transceiver *transceiver); + friend void *TxLowerLoopAdapter(Transceiver *transceiver); + friend void *ControlServiceLoopAdapter(TrxChanThParams *params); void reset(); @@ -265,14 +251,14 @@ void logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi); }; -void *RxUpperLoopAdapter(TransceiverChannel *); +void *RxUpperLoopAdapter(TrxChanThParams *params); /** Main drive threads */ -void *RxLowerLoopAdapter(Transceiver *); -void *TxLowerLoopAdapter(Transceiver *); +void *RxLowerLoopAdapter(Transceiver *transceiver); +void *TxLowerLoopAdapter(Transceiver *transceiver); /** control message handler thread loop */ -void *ControlServiceLoopAdapter(TransceiverChannel *); +void *ControlServiceLoopAdapter(TrxChanThParams *params); /** transmit queueing thread loop */ -void *TxUpperLoopAdapter(TransceiverChannel *); +void *TxUpperLoopAdapter(TrxChanThParams *params); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6e3898a8a66520cc5b2a7df9b9ae01b0b272387f Gerrit-Change-Number: 14898 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 16:37:28 2019 From: gerrit-no-reply at lists.osmocom.org (lynxis lazus) Date: Mon, 22 Jul 2019 16:37:28 +0000 Subject: Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3 In-Reply-To: References: Message-ID: Hello pespin, fixeria, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 to look at the new patch set (#4). Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 ...................................................................... fb_tools/bdf_to_c.py: make it compatible with python3 This would break python2 compatibility. Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 --- M src/host/fb_tools/bdf_to_c.py 1 file changed, 33 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/58/14758/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 16:43:57 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 16:43:57 +0000 Subject: Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14758 ) Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 22 Jul 2019 16:43:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:25:26 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:25:26 +0000 Subject: Change in ...osmo-trx[master]: Bind CTRL port to IP addr specified in VTY config In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14893 ) Change subject: Bind CTRL port to IP addr specified in VTY config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I61a06c1b9c20a906e7030f824a93370d041be7b9 Gerrit-Change-Number: 14893 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 19:25:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:25:53 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:25:53 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Store TRXD version per channel In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14897 ) Change subject: Transceiver: Store TRXD version per channel ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9cf95e89d38d0155ab48b8c0977ca5f381c2aad Gerrit-Change-Number: 14897 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 19:25:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:27:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:27:36 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Clean up code passing parameters to threads In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14898 ) Change subject: Transceiver: Clean up code passing parameters to threads ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6e3898a8a66520cc5b2a7df9b9ae01b0b272387f Gerrit-Change-Number: 14898 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 19:27:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:44:42 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:44:42 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 ) Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... Patch Set 2: why would osmo-bts-trx not always want to request the highest locally supported version and in the end chose whatever the highest the TRX supports? I think this vty command may actually be dangerous, in that it will persist software upgrades in your config file. This means you update e.g.both your trx and osmo-bts (which could provide better features/performance/...), but you will still use some old version as you have that statement in your config file. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 19:44:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:47:00 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:47:00 +0000 Subject: Change in ...libosmo-abis[master]: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14743 ) Change subject: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc ...................................................................... Patch Set 7: I'm a bit reluctant to merge this to master as we're close to tagging a new release. A change like this will need to be verified against 3rd party RSL/OML (e.g. nanoBTSs devices), and we have to test combinations of old OsmoBTS with new BSC using this patch and vice-versa. I don't know if all of those combinations will reliably send a PONG in response to PING. They should, but who knows... -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a Gerrit-Change-Number: 14743 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 19:47:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:48:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:48:35 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: Introduce Osmux documentation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 ) Change subject: common: Introduce Osmux documentation ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e Gerrit-Change-Number: 14839 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 22 Jul 2019 19:48:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:48:43 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:48:43 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: Introduce Osmux documentation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 ) Change subject: common: Introduce Osmux documentation ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e Gerrit-Change-Number: 14839 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 22 Jul 2019 19:48:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:48:46 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:48:46 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: Introduce Osmux documentation In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 ) Change subject: common: Introduce Osmux documentation ...................................................................... common: Introduce Osmux documentation Change-Id: I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e --- A common/chapters/osmux/mgcp_extension_osmux.adoc A common/chapters/osmux/mo_call_osmux_aoip.msc A common/chapters/osmux/mo_call_osmux_sccplite.msc A common/chapters/osmux/mo_call_osmux_sccplite_nat.msc A common/chapters/osmux/network_osmux_aoip.dot A common/chapters/osmux/network_osmux_sccplite.dot A common/chapters/osmux/network_osmux_sccplite_nat.dot A common/chapters/osmux/osmux.adoc 8 files changed, 550 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/common/chapters/osmux/mgcp_extension_osmux.adoc b/common/chapters/osmux/mgcp_extension_osmux.adoc new file mode 100644 index 0000000..c12e9ef --- /dev/null +++ b/common/chapters/osmux/mgcp_extension_osmux.adoc @@ -0,0 +1,115 @@ +[[mgcp-extension-osmux]] +=== Osmux and MGCP + +`X-Osmux` indicates to OsmoMGW that a given connection of an `rtpbridge` +endpoint has to be configured in order to handle Osmux frames instead of RTP +messages on the data plane. + +==== `X-Osmux` Format + +The value part of `X-Osmux` must be one integer in range [0..255], or +alternatively only on request messages, an asterisk (*) if the value is not yet +known. + +`X-Osmux` must be issued in the MGCP header section (typically as its last +item), before the SDP section starts. + +`X-Osmux` can be included inside `CRCX` and `MDCX` request messages, as well as +their respective response messages. + +In request messages, the value part of `X-Osmux` specifies the CID to be used by +OsmoMGW to _send_ Osmux frames to the remote peer for that connection, also +known as _sendCID_. + +In response messages, the value part of `X-Osmux` specifies the CID where +OsmoMGW expect to _receive_ Osmux frames from the remote peer for that +connection, also known as _recvCID_. + +.Example: `X-Osmux` format with a known CID 3. +---- +X-Osmux: 3 +---- + +.Example: `X-Osmux` format with a wildcard (not yet known) CID. +---- +X-Osmux: * +---- + +==== `X-Osmux` Considerations + +If the MGCP client is willing to use Osmux for a given connection, it shall +specify so during `CRCX` time, and not later. If at `CRCX` time the MGCP client +doesn't yet know the _sendCID_, it can use an astersik (*) and provide +_sendCID_ later within `MDCX` messages. + +All subsequent `MDCX` messages sent towards an Osmux connection must contain the +original _sendCID_ sent during `CRCX`. The same way, all `MDCX` response shall +contain the _recvCID_ sent during `CRCX`. + +The other required connection address parameters, such as IP address, port, and +codecs, are negotiated through MGCP and SDP as usual, but in this case the IP +address and port specific the Osmux socket IP address and port to use, that +together with the Osmux CID conform the entire tuple identifying a Osmux stream. + +Since Osmux only supports AMR codec payloads, the SDP must specify use of AMR +codec. + +.Example: `CRCX` message that instructs OsmoMGW to create an Osmux connection +---- +CRCX 189 rtpbridge/1 at mgw MGCP 1.0 +C: 36 +M: sendrecv +X-Osmux: 2 + +v=0 +o=- 36 23 IN IP4 172.18.2.20 +s=- +c=IN IP4 1.2.3.4 +t=0 0 +m=audio 2342 RTP/AVP 112 +a=fmtp:112 +a=rtpmap:112 AMR/8000/1 +a=ptime:20 +---- + +.Example: response to `CRCX` containing the <> +---- +200 189 OK +I: 07E41584 +X-Osmux: 2 +Z: rtpbridge/1 at mgw + +v=0 +o=- foo 21 IN IP4 172.18.1.20 +s=- +c=IN IP4 172.18.1.20 +t=0 0 +m=audio 11002 RTP/AVP 112 +a=rtpmap:112 AMR/8000 +a=ptime:20 +---- + +==== `X-Osmux` Support + +`X-Osmux` is known to be supported by OsmoMGW on the MGCP server side, and by +OsmoBSC as well as OsmoMSC on the MGCP client side (through libosmo-mgcp-cli). +No other programs supporting this feature are known or envisioned at the time of +writing this document. + +In OmoMGW, Osmux support is managed through VTY. + +.Example: Sample config file section with Osmux configuation +---- +mgcp + ... + osmux on <1> + osmux bind-ip 172.18.1.20 <2> + osmux port 1984 <3> + osmux batch-factor 4 <4> + osmux dummy on <5> +---- +<1> Allow clients to set allocate Osmux connections in `rtpbridge` endpoints, while still allowing RTP connections +<2> Bind the Osmux socket to the provided IP address +<3> Bind the Osmux socket to the provided UDP port +<4> Batch up to 4 RTP payloads of the same stream on each Osmux frame +<5> Periodically send Osmux dummy frames, useful to punch a hole in NATs and maintain connections opened. diff --git a/common/chapters/osmux/mo_call_osmux_aoip.msc b/common/chapters/osmux/mo_call_osmux_aoip.msc new file mode 100644 index 0000000..9cb2e50 --- /dev/null +++ b/common/chapters/osmux/mo_call_osmux_aoip.msc @@ -0,0 +1,54 @@ +# MO-call with Osmux enable on 3GPP AoIP +msc { + hscale=2; + ms [label="MS"], bts [label="OsmoBTS"], bsc[label="OsmoBSC"], mgw_bsc[label="OsmoMGW(bsc)"], m_sc[label="MSC"], mgw_msc[label="OsmoMGW(msc)"]; + + bsc <- m_sc [label="BSSMAP RESET (with extension IE: Osmux Support)"]; + bsc -> m_sc [label="BSSMAP RESET ACK (with extension IE: Osmux Support)"]; + ...; + ms box mgw_msc [label="We assume a SDCCH is already established"]; + ...; + + ms -> bsc [label="DTAP CM Service Request"]; + bsc -> m_sc [label="Complete Layer 3 Information DTAP CM Service Request"]; + + # Allocate MGW/MSC Osmux endpoint + m_sc -> mgw_msc [label="MGCP CRCX rtpbridge/*@mgw, X-Osmux: *"]; + mgw_msc box mgw_msc [label="Bind to MGW-local Osmux Port (1984)\nAllocate new endpoint 1, recvCID 5"]; + mgw_msc -> m_sc [label="MGCP CRCX rtpbridge/1 at mgw OK (MGW:1984, X-Osmux: 5)"]; + + bsc <- m_sc [label="BSSAP ASSGN REQ (3GPP AoIP, extension IE: Osmux CID 5)"]; + bts <- bsc [label="RSL CHAN ACT"]; + bts -> bsc [label="RSL CHAN ACT ACK"]; + ms <- bsc [label="Assignment Command"]; + ms -> bsc [label="Assignment Complete"]; + ...; + + # connect BTS RTP with BSC-MGW RTP + bts <- bsc [label="IPA CRCX"]; + bts box bts [label="Bind to BTS-local RTP Port (1000)"]; + bts -> bsc [label="IPA CRCX ACK (BTS:1000)"]; + bsc -> mgw_bsc [label="MGCP CRCX rtpbridge/2 at mgw (BTS:1000)"]; + mgw_bsc box mgw_bsc [label="Bind to MGW-local RTP Port (2000)\nConnect to BTS:1000"]; + bsc <- mgw_bsc [label="MGCP CRCX rtpbridge/2 at mgw OK (MGW:2000)"]; + bts <- bsc [label="IPA MDCX (MGW:2000)"]; + bts box bts [label="Connect RTP socket to remote (MGW) RTP Port"]; + bts -> bsc [label="IPA MDCX ACK"]; + ...; + + mgw_bsc <- bsc [label="MGCP CRCX rtpbridge/2 at mgw (MSC:1984, X-Osmux: 5)"]; + mgw_bsc box mgw_bsc [label="Bind to MGW-local Osmux Port (1985)\nConnect to MSC:1984\nAllocate new recvCID 7"]; + mgw_bsc -> bsc [label="MGCP CRCX rtpbridge/2 at mgw OK (MGW:1985, X-Osmux: 7)"]; + ...; + + bsc -> m_sc [label="BSSAP ASSGN CMPL (3GPP AoIP MGW:1985, extension IE: Osmux CID 7)"]; + m_sc box m_sc [label="Connect remote Osmux to MGW addr from ASSGN CMPL"]; + m_sc -> mgw_msc [label="MGCP MDCX rtpbridge/1 at mgw (MGW:1985, X-Osmux: 7)"]; + m_sc <- mgw_msc [label="MGCP MDCX rtpbridge/1 at mgw OK (X-Osmux: 5)"]; + ...; + + mgw_bsc <=> mgw_msc [label="Osmux Audio MGW:1985 MSC:1984, CID(uplink):5, CID(downlink):7"]; + bts <=> mgw_bsc [label="RTP Audio BTS:1000 MGW:2000"]; + ms <=> bts [label="Um Audio (bidirectional)"]; + ms <-> m_sc [label="DTAP CC ALERTING"]; +} diff --git a/common/chapters/osmux/mo_call_osmux_sccplite.msc b/common/chapters/osmux/mo_call_osmux_sccplite.msc new file mode 100644 index 0000000..903da46 --- /dev/null +++ b/common/chapters/osmux/mo_call_osmux_sccplite.msc @@ -0,0 +1,58 @@ +# MO-call with Osmux enable on 3GPP AoIP using A/IP with IPA/SCCPlite +msc { + hscale=2; + ms [label="MS"], bts [label="OsmoBTS"], bsc[label="OsmoBSC"], mgw_bsc[label="OsmoMGW(bsc)"], m_sc[label="MSC"], mgw_msc[label="OsmoMGW(msc)"]; + + ms box m_sc [label="We assume a SDCCH is already established"]; + ...; + + ms -> bsc [label="DTAP CM Service Request"]; + bsc -> m_sc [label="Complete Layer 3 Information DTAP CM Service Request"]; + bsc <- m_sc [label="Connection Confirmed"]; + + # Allocate MGW/MSC Osmux endpoint + m_sc -> mgw_msc [label="MGCP CRCX *@mgw, X-Osmux: *"]; + mgw_msc box mgw_msc [label="Bind to MGW-local Osmux Port (1984)\nAllocate new endpoint 1, recvCID 5"]; + mgw_msc -> m_sc [label="MGCP CRCX rtpbridge/1 at mgw OK (MGW:1984, X-Osmux: 5)"]; + + bsc <- m_sc [label="BSSAP ASSGN REQ (CIC:1)"]; + bts <- bsc [label="RSL CHAN ACT"]; + bts -> bsc [label="RSL CHAN ACT ACK"]; + ms <- bsc [label="Assignment Command"]; + ms -> bsc [label="Assignment Complete"]; + ...; + + # connect BTS RTP with BSC-MGW RTP, CIC is used as MGW endpoint + bts <- bsc [label="IPA CRCX"]; + bts box bts [label="Bind to BTS-local RTP Port (1000)"]; + bts -> bsc [label="IPA CRCX ACK (BTS:1000)"]; + bsc -> mgw_bsc [label="MGCP CRCX 1 at mgw (BTS:1000)"]; + mgw_bsc box mgw_bsc [label="Bind to MGW-local RTP Port (2000)\nConnect to BTS:1000"]; + bsc <- mgw_bsc [label="MGCP CRCX 1 at mgw OK (MGW:2000)"]; + bts <- bsc [label="IPA MDCX (MGW:2000)"]; + bts box bts [label="Connect RTP socket to remote (MGW) RTP Port"]; + bts -> bsc [label="IPA MDCX ACK"]; + ...; + + bsc -> m_sc [label="BSSMAP ASSGN Complete"]; + ...; + + # MSC configures BSC-MGW MSC-side of the endpoint through MGCP UDP forwarding + mgw_bsc <- m_sc [label="MGCP CRCX 1 at mgw (MSC:1984, X-Osmux: 5)"]; + mgw_bsc box mgw_bsc [label="Bind to BTS-local Osmux Port (1985)\nAllocate new recvCID 7"]; + mgw_bsc -> m_sc [label="MGCP CRCX 1 at mgw OK (MGW:1985, X-Osmux: 7)"]; + mgw_bsc <- m_sc [label="MGCP MDCX 1 at mgw (recvonly) "]; + mgw_bsc box mgw_bsc [label="Connect Osmux socket to remote (MSC) Osmux Port"]; + mgw_bsc -> m_sc [label="MGCP MDCX 1 at mgw OK"]; + mgw_bsc <= mgw_msc [label="Osmux Audio MGW:1985 MSC:1984, CID(downlink):7"]; + bts <= mgw_bsc [label="RTP Audio BTS:1000 MGW:2000"]; + ms <= bts [label="Um Audio (unidirectional)"]; + ms <- m_sc [label="DTAP CC ALERTING"]; + ...; + mgw_bsc <- m_sc [label="MGCP MDCX 1 at mgw (sndrecv) "]; + mgw_bsc box mgw_bsc [label="Switch to bi-directional audio"]; + mgw_bsc -> m_sc [label="MGCP MDCX 1 at mgw OK"]; + mgw_bsc <=> mgw_msc [label="Osmux Audio MGW:1985 MSC:1984, CID(uplink):5, CID(downlink):7"]; + bts <=> mgw_bsc [label="RTP Audio BTS:1000 MGW:2000"]; + ms <=> bts [label="Um Audio (bidirectional)"]; +} diff --git a/common/chapters/osmux/mo_call_osmux_sccplite_nat.msc b/common/chapters/osmux/mo_call_osmux_sccplite_nat.msc new file mode 100644 index 0000000..2aa8105 --- /dev/null +++ b/common/chapters/osmux/mo_call_osmux_sccplite_nat.msc @@ -0,0 +1,77 @@ +# MO-call with Osmux enable on 3GPP AoIP using A/IP with IPA/SCCPlite with a BSC-NAT between BSC and MSC +msc { + hscale=2; + ms [label="MS"], bts [label="OsmoBTS"], bsc[label="OsmoBSC"], mgw_bsc[label="OsmoMGW(bsc)"], bscnat[label="OsmoBSCNAT"], m_sc[label="MSC"], mgw_msc[label="OsmoMGW(msc)"]; + + ms box m_sc [label="We assume a SDCCH is already established"]; + ...; + + ms -> bsc [label="DTAP CM Service Request"]; + bsc -> m_sc [label="Complete Layer 3 Information DTAP CM Service Request"]; + bsc <- m_sc [label="Connection Confirmed"]; + + # Allocate MGW/MSC RTP endpoint + m_sc -> mgw_msc [label="MGCP CRCX *@mgw"]; + mgw_msc box mgw_msc [label="Bind to MGW-local RTP Port (3000)\nAllocate new endpoint 1"]; + mgw_msc -> m_sc [label="MGCP CRCX rtpbridge/1 at mgw OK (MGW:3000)"]; + bscnat <- m_sc [label="BSSAP ASSGN REQ (CIC:1)"]; + + # NAT: MGW/MSC Osmux endpoint + #bscnat -> bscnat [label="MGCP CRCX *@mgw, X-Osmux: *"]; + mgw_msc box mgw_msc [label="Bind to MGW-local Osmux Port (1984)\nAllocate new endpoint 2, recvCID 5"]; + #mgw_msc -> m_sc [label="MGCP CRCX rtpbridge/1 at mgw OK (MGW:1984, X-Osmux: 5)"]; + bsc <- bscnat [label="BSSAP ASSGN REQ (CIC:2)"]; + + bts <- bsc [label="RSL CHAN ACT"]; + bts -> bsc [label="RSL CHAN ACT ACK"]; + ms <- bsc [label="Assignment Command"]; + ms -> bsc [label="Assignment Complete"]; + ...; + + # connect BTS RTP with BSC-MGW RTP, CIC is used as MGW endpoint + bts <- bsc [label="IPA CRCX"]; + bts box bts [label="Bind to BTS-local RTP Port (1000)"]; + bts -> bsc [label="IPA CRCX ACK (BTS:1000)"]; + bsc -> mgw_bsc [label="MGCP CRCX 1 at mgw (BTS:1000)"]; + mgw_bsc box mgw_bsc [label="Bind to MGW-local RTP Port (2000)\nConnect to BTS:1000"]; + bsc <- mgw_bsc [label="MGCP CRCX 1 at mgw OK (MGW:2000)"]; + bts <- bsc [label="IPA MDCX (MGW:2000)"]; + bts box bts [label="Connect RTP socket to remote (MGW) RTP Port"]; + bts -> bsc [label="IPA MDCX ACK"]; + #bsc -> mgw_bsc [label="MGCP MDCX 1 at mgw (optional)"]; + #bsc <- mgw_bsc [label="MGCP MDCX 1 at mgw OK (optional)"]; + ...; + + bsc -> bscnat [label="BSSMAP ASSGN Complete"]; + bscnat -> m_sc [label="BSSMAP ASSGN Complete"]; + ...; + + # MSC configures BSC-MGW MSC-side of the endpoint through MGCP UDP forwarding + bscnat <- m_sc [label="MGCP CRCX 1 at mgw (MSC:3000)"]; + bscnat box bscnat [label="Allocate new endpoint 2\nAllocate new recvCID 5\nBind to local Osmux Port (1984)\nBind to local RTP port 4000"]; + mgw_bsc <- bscnat [label="MGCP CRCX 2 at mgw (MSC:1984, X-Osmux: 5)"]; + mgw_bsc -> bscnat [label="MGCP CRCX 2 at mgw OK (MGW:1985, X-Osmux: 7)"]; + bscnat -> m_sc [label="MGCP CRCX 1 at mgw OK (MGW:4000)"]; + bscnat <- m_sc [label="MGCP MDCX 1 at mgw (recvonly) "]; + mgw_bsc <- bscnat [label="MGCP MDCX 2 at mgw (recvonly) "]; + mgw_bsc box mgw_bsc [label="Connect Osmux socket to remote (MSC) Osmux Port"]; + mgw_bsc -> bscnat [label="MGCP MDCX 2 at mgw OK"]; + bscnat -> m_sc [label="MGCP MDCX 1 at mgw OK"]; + + bscnat <= mgw_msc [label="RTP Audio BSCNAT:4000 MGW:3000"]; + mgw_bsc <= bscnat [label="Osmux Audio MGW:1985 BSCNAT:1984, CID(downlink):7"]; + bts <= mgw_bsc [label="RTP Audio BTS:1000 MGW:2000"]; + ms <= bts [label="Um Audio (unidirectional)"]; + ms <- m_sc [label="DTAP CC ALERTING"]; + ...; + bscnat <- m_sc [label="MGCP MDCX 1 at mgw (sndrecv) "]; + mgw_bsc <- bscnat [label="MGCP MDCX 2 at mgw (sndrecv) "]; + mgw_bsc box mgw_bsc [label="Switch to bi-directional audio"]; + mgw_bsc -> bscnat [label="MGCP MDCX 2 at mgw OK"]; + bscnat -> m_sc [label="MGCP MDCX 1 at mgw OK"]; + + bscnat <=> mgw_msc [label="RTP Audio BSCNAT:4000 MGW:3000"]; + mgw_bsc <=> bscnat [label="Osmux Audio MGW:1985 MSC:1984, CID(uplink):5, CID(downlink):7"]; + bts <=> mgw_bsc [label="RTP Audio BTS:1000 MGW:2000"]; + ms <=> bts [label="Um Audio (bidirectional)"]; +} diff --git a/common/chapters/osmux/network_osmux_aoip.dot b/common/chapters/osmux/network_osmux_aoip.dot new file mode 100644 index 0000000..7531e6a --- /dev/null +++ b/common/chapters/osmux/network_osmux_aoip.dot @@ -0,0 +1,32 @@ +digraph G { + rankdir = LR; + subgraph cluster_RAN { + OsmoBTS1 [label="OsmoBTS"]; + OsmoBTS2 [label="OsmoBTS"]; + OsmoBSC; + OsmoMGW [label="OsmoMGW\n(for BSC)"]; + + OsmoBTS1 -> OsmoBSC [label="Abis/IP", dir="both"]; + OsmoBTS2 -> OsmoBSC [label="Abis/IP", dir="both"]; + OsmoBSC -> OsmoMGW [label="MGCP", dir="both"]; + { rank = same; OsmoBSC; OsmoMGW } + + OsmoBTS1 -> OsmoMGW [label="RTP", dir="both"]; + OsmoBTS2 -> OsmoMGW [label="RTP", dir="both"]; + + label = "RAN"; + } + subgraph cluster_CN { + OsmoMGW1 [label="OsmoMGW\n(for MSC)"]; + OsmoMSC [label="MSC\ne.g. OsmoMSC"]; + Core [label="Other CN Elements"]; + OsmoMSC -> Core [label="MAP/ISUP/SIP/GSUP", dir="both"]; + OsmoMSC -> OsmoMGW1 [label="MGCP", dir="both"]; + { rank = same; OsmoMSC; OsmoMGW1 } + OsmoMGW -> OsmoMGW1 [label="Osmux", dir="both", color=red]; + OsmoMGW1 -> Core [label="RTP", dir="both"]; + label = "CN"; + } + + OsmoBSC -> OsmoMSC [label="3GPP AoIP\nvia SIGTRAN/STP", dir="both"]; +} diff --git a/common/chapters/osmux/network_osmux_sccplite.dot b/common/chapters/osmux/network_osmux_sccplite.dot new file mode 100644 index 0000000..678a61e --- /dev/null +++ b/common/chapters/osmux/network_osmux_sccplite.dot @@ -0,0 +1,33 @@ +digraph G { + rankdir = LR; + subgraph cluster_RAN { + OsmoBTS1 [label="OsmoBTS"]; + OsmoBTS2 [label="OsmoBTS"]; + OsmoBSC; + OsmoMGW [label="OsmoMGW\n(for BSC)"]; + + OsmoBTS1 -> OsmoBSC [label="Abis/IP", dir="both"]; + OsmoBTS2 -> OsmoBSC [label="Abis/IP", dir="both"]; + OsmoBSC -> OsmoMGW [label="MGCP (BTS side)", dir="both"]; + { rank = same; OsmoBSC; OsmoMGW } + + OsmoBTS1 -> OsmoMGW [label="RTP", dir="both"]; + OsmoBTS2 -> OsmoMGW [label="RTP", dir="both"]; + + label = "RAN"; + } + subgraph cluster_CN { + OsmoMGW1 [label="OsmoMGW\n(for MSC)"]; + OsmoMSC [label="MSC\ne.g. OsmoMSC"]; + Core [label="Other CN Elements"]; + OsmoMSC -> Core [label="MAP/ISUP/SIP/GSUP", dir="both"]; + OsmoMSC -> OsmoMGW1 [label="MGCP", dir="both"]; + { rank = same; OsmoMSC; OsmoMGW1 } + OsmoMGW -> OsmoMGW1 [label="Osmux", dir="both", color=red]; + OsmoMGW1 -> Core [label="RTP", dir="both"]; + label = "CN"; + } + + OsmoBSC -> OsmoMSC [label="3GPP AoIP\nvia IPA/SCCPlite", dir="both"]; + OsmoMGW -> OsmoMSC [label="MGCP (CN side)\n(IPA/UDP forwarding via BSC)", dir="both"]; +} diff --git a/common/chapters/osmux/network_osmux_sccplite_nat.dot b/common/chapters/osmux/network_osmux_sccplite_nat.dot new file mode 100644 index 0000000..021d0ec --- /dev/null +++ b/common/chapters/osmux/network_osmux_sccplite_nat.dot @@ -0,0 +1,40 @@ +digraph G { + rankdir = LR; + subgraph cluster_RAN { + OsmoBTS1 [label="OsmoBTS"]; + OsmoBTS2 [label="OsmoBTS"]; + OsmoBSC; + OsmoMGW [label="OsmoMGW\n(for BSC)"]; + + OsmoBTS1 -> OsmoBSC [label="Abis/IP", dir="both"]; + OsmoBTS2 -> OsmoBSC [label="Abis/IP", dir="both"]; + OsmoBSC -> OsmoMGW [label="MGCP (BTS side)", dir="both"]; + { rank = same; OsmoBSC; OsmoMGW } + + OsmoBTS1 -> OsmoMGW [label="RTP", dir="both"]; + OsmoBTS2 -> OsmoMGW [label="RTP", dir="both"]; + + label = "RAN"; + } + subgraph cluster_BSCNAT { + OsmoBSCNAT; + label = "BSCNAT"; + } + subgraph cluster_CN { + OsmoMGW1 [label="OsmoMGW\n(for MSC)"]; + OsmoMSC [label="MSC\ne.g. OsmoMSC"]; + Core [label="Other CN Elements"]; + OsmoMSC -> Core [label="MAP/ISUP/SIP/GSUP", dir="both"]; + OsmoMSC -> OsmoMGW1 [label="MGCP", dir="both"]; + { rank = same; OsmoMSC; OsmoMGW1 } + OsmoMGW -> OsmoBSCNAT [label="Osmux", dir="both", color=red]; + OsmoMGW1 -> Core [label="RTP", dir="both"]; + label = "CN"; + } + + OsmoBSC -> OsmoBSCNAT [label="3GPP AoIP\nvia IPA/SCCPlite", dir="both"]; + OsmoMGW -> OsmoBSCNAT [label="MGCP (CN side)\n(IPA/UDP forwarding via BSC)", dir="both"]; + OsmoBSCNAT -> OsmoMSC [label="3GPP AoIP\nvia IPA/SCCPlite", dir="both"]; + OsmoBSCNAT -> OsmoMSC [label="MGCP\nvia UDP", dir="both"]; + OsmoBSCNAT -> OsmoMGW1 [label="RTP", dir="both"]; +} diff --git a/common/chapters/osmux/osmux.adoc b/common/chapters/osmux/osmux.adoc new file mode 100644 index 0000000..5e53b60 --- /dev/null +++ b/common/chapters/osmux/osmux.adoc @@ -0,0 +1,141 @@ +== Osmux + +`Osmux` is a protocol aimed at multiplexing and transmitting voice and +signalling traffic from multiple sources in order to reduce the overall +bandwidth consumption. This feature becomes specially meaningful in case of +satellite based GSM systems, where the transmission cost on the back-haul is +relatively expensive. In such environment, even seemingly small protocol +optimizations, eg. message batching and trunking, can result in significant cost +reduction. + +Full reference document for the osmux protocol can be found here: +http://ftp.osmocom.org/docs/latest/osmux-reference.pdf + +In Osmocom satellite based GSM networks, the satellite link is envisioned to be +in between the BSS and the core network, that is, between the BSC and the MSC +(or BSC-NAT). Hence, Osmocom components can make use of `Osmux` protocol to +multiplex payload audio streams from call legs between OsmoBSC and OsmoMSC (or +OsmoBSCNAT). The MGW attached those components need of course also be aware of +`Osmux` existence in order to properly set up the audio data plane. + +=== Osmux and NAT + +It is quite usual for satellite based links to use NATs, which means any or both +of the two components at each side of the satellite link (BSC and MSC/BSC-NAT) +may end up being behind a NAT and being unable to provide the real public +address to its peer on the other side of the satellite. + +As a result, upon call parameter negotiation (RTP/Osmux IP address and port), +those parameters won't be entirely useful and some specific logic needs to be +introduced into the network components to circumvent the NAT under those cases. + +For instance, if the BSC and its co-located MGW (BSC/MGW from now on) is under a +NAT, it may end up providing its private address and port as RTP/Osmux +parameters to the MSC/MGW through GSM protocols, but MSC will fail to send any +message to that tuple because of the NAT or routing issues (due to IP address +being a private address). In that scenario, MSC/MGW needs to be aware that +there's a NAT and wait until an RTP/Osmux message arrives from the BSC/MGW host. +It then can, from that message source IP address and port (and CID in case of +Osmux), discover the real public IP address and port of the peer (BSC/MGW). From +that point on, the BSC/MGW punched a hole in the NAT (its connection table is +updated) and MSC/MGW is able to send data back to it on that connection. + +Moreover, NATs tend to drop connections from their connection tables after some +inactivity time, meaning a peer may receive notice about the other end not being +available while it actually is. This means the GSM network needs to be +configured in a way to ensure inactivity periods are short enough that this +cannot occur. That's the reason why OsmoMGW provides the `osmux dummy` VTY +command to enable sending dummy packets from time to time to keep the +connections alive. + +=== CID allocation + +Each peer (BSC/MGW and MSC/MGW) allocates its own _recvCID_, and receives from +the peer through the used GSM protocol the peer's _recvCID_, which becomes +the local _sendCID_ for that connection. + +---- +BSC/MGW(recvCID=Y,sendCID=?)<-X--MSC/MGW(recvCID=X,sendCID=?) +BSC/MGW(recvCID=Y,sendCID=X)--Y->MSC/MGW(recvCID=X,sendCID=Y) +---- + +This way each peer is responsible for allocating and managing their own local +address (CID) space. This is basically the same that happens with regular IP +address and port in the RTP case (and those also apply when Osmux is used, but +an extra identifier, the CID, is allocated). + +In an ideal scenario, without NAT, each BSC/MGW would have a public, +differentiated and unique IP and port set tuple, And MSC/MGW should be able to +identify messages coming from them by easily matching source IP address, port +(and CID in Osmux case) against the parameters negotiated during call set up. + +In this kind of scenario, MSC/MGW could easily open and manage one Osmux socket +per BSC (based on SDP IPaddr and port parameters), with same `` tuple, allowing for 256 Osmux CIDs per BSC and hence call legs per +BSC. Each of the peers could actually have more than one Osmux socket towards +the other peer, by using a pool of ports or IP addresses, so there's really not +limit if required as long as there's a way to infer the initially negotiated +`` tuple from the received audio +packets. + +However, due to some constrains from in between NATs explained in section above, +BSC/MGW IP address and port are not a priory known, and could change between +different connections coming from it. As a result, it is difficult to infer the +entire tuple, so for now MGW needs to allocate its Osmux _recvCID_ in a clever +way, in order to be able to identify the full tuple from it. + +Hence, currently OsmoMGW CID allocation implementation shares CID between all +connections, which means it can only handle up to 256 concurrent Osmux +connections (call legs). + +Future work in OsmoMGW (https://osmocom.org/issues/4092[OS#4092]) plans to use a +set of local ports for Osmux sockets instead of only 1 currently used. This way +local ports can be matched against specific `` tuples and +have an entire 256 Osmux CID space per `` (aka per peer). + +=== 3GPP AoIP network setup with Osmux + +[[fig-network-osmux-aoip]] +.Sample node diagram of a 3GPP AoIP network with Osmux enabled +[graphviz] +---- +include::network_osmux_aoip.dot[] +---- + +.MO-call with Osmux enable on 3GPP AoIP +[mscgen] +---- +include::mo_call_osmux_aoip.msc[] +---- + +=== SCCPLite network setup with Osmux + +[[fig-network-osmux-sccplite]] +.Sample node diagram of a 3GPP AoIP using A/IP with IPA/SCCPlite network with Osmux enabled +[graphviz] +---- +include::network_osmux_sccplite.dot[] +---- + +.MO-call with Osmux enable on 3GPP AoIP using A/IP with IPA/SCCPlite +["mscgen"] +---- +include::mo_call_osmux_sccplite.msc[] +---- + +=== SCCPLite network setup with Osmux + BSC-NAT + +[[fig-network-osmux-sccplite-nat]] +.Sample node diagram of a 3GPP AoIP using A/IP with IPA/SCCPlite network and BSC-NAT with Osmux enabled +[graphviz] +---- +include::network_osmux_sccplite_nat.dot[] +---- + +.MO-call with Osmux enable on 3GPP AoIP using A/IP with IPA/SCCPlite with a BSC-NAT between BSC and MSC +["mscgen"] +---- +include::mo_call_osmux_sccplite_nat.msc[] +---- + +include::mgcp_extension_osmux.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e Gerrit-Change-Number: 14839 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:49:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:49:16 +0000 Subject: Change in ...osmo-gsm-manuals[master]: tests: pick up subdirs inside common/chapters In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14895 ) Change subject: tests: pick up subdirs inside common/chapters ...................................................................... tests: pick up subdirs inside common/chapters The Osmux documentation that will be introduced in [1] creates a common/chapters/osmux/ subdir. Update tests/Makefile.am to pick up the files in that directory too, so they get built by jenkins during gerrit verification. [1] I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e Change-Id: I4d1f440b7bfef159c98f918a2d23069594c4bc95 --- M tests/Makefile.am 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/Makefile.am b/tests/Makefile.am index 7dc9544..b2f579d 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -9,7 +9,8 @@ # Generate adoc file that includes all chapters ASCIIDOC = test-usermanual.adoc ASCIIDOC_DEPS = -$(ASCIIDOC): $(OSMO_GSM_MANUALS_DIR)/common/chapters/*.adoc +COMMON_CHAPTERS = $(shell find $(OSMO_GSM_MANUALS_DIR)/common/chapters -name '*.adoc') +$(ASCIIDOC): $(COMMON_CHAPTERS) echo ":gfdl-enabled:" > $@ echo ":program-name: Test" >> $@ echo "" >> $@ @@ -17,7 +18,7 @@ echo "====================================" >> $@ echo "Oliver Smith " >> $@ echo "" >> $@ - for chapter in $(OSMO_GSM_MANUALS_DIR)/common/chapters/*.adoc; do \ + for chapter in $(COMMON_CHAPTERS); do \ echo "include::$${chapter}[]" >> $@; \ done; CLEAN_FILES = $(ASCIIDOC) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14895 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I4d1f440b7bfef159c98f918a2d23069594c4bc95 Gerrit-Change-Number: 14895 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:50:55 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:50:55 +0000 Subject: Change in ...osmo-bsc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14840 ) Change subject: doc: Add Osmux documentation to User Manual ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75dcdddc713b0dc43e2ba577ca377c20fc511f38 Gerrit-Change-Number: 14840 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 22 Jul 2019 19:50:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:51:13 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:51:13 +0000 Subject: Change in ...osmo-trx[master]: debian/copyright: Update wrong paths in license list In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14889 ) Change subject: debian/copyright: Update wrong paths in license list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14889 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1857338b7a19e2a37f62386ceb4a1fad988272ba Gerrit-Change-Number: 14889 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 19:51:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:51:25 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:51:25 +0000 Subject: Change in ...osmo-trx[master]: debian/copyright: Remove non existent radioInterfaceDiversity.cpp fro... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14888 ) Change subject: debian/copyright: Remove non existent radioInterfaceDiversity.cpp from list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14888 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5cfbbafd411e580421f86df6817f91261aceda7e Gerrit-Change-Number: 14888 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 19:51:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:51:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:51:36 +0000 Subject: Change in ...osmo-trx[master]: debian/copyright: Add missing file Utils.* to LGPL-2.1+ list In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14890 ) Change subject: debian/copyright: Add missing file Utils.* to LGPL-2.1+ list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36b8b8be48ae8676688786f39008d08b61011ede Gerrit-Change-Number: 14890 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 19:51:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:54:57 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:54:57 +0000 Subject: Change in ...osmo-trx[master]: cosmetic: Fix trailing whitespace in several files In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14891 ) Change subject: cosmetic: Fix trailing whitespace in several files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ifafb68353960fc5046661854ccfb8d783b0efb14 Gerrit-Change-Number: 14891 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 19:54:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:55:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:55:56 +0000 Subject: Change in ...osmo-trx[master]: Add SPDX annotation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14892 ) Change subject: Add SPDX annotation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14892 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3719bd8dc015569ecd81928fc079e27593cdca09 Gerrit-Change-Number: 14892 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 19:55:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:55:59 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:55:59 +0000 Subject: Change in ...osmo-trx[master]: debian/copyright: Remove non existent radioInterfaceDiversity.cpp fro... In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14888 ) Change subject: debian/copyright: Remove non existent radioInterfaceDiversity.cpp from list ...................................................................... debian/copyright: Remove non existent radioInterfaceDiversity.cpp from list Change-Id: I5cfbbafd411e580421f86df6817f91261aceda7e --- M debian/copyright 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/copyright b/debian/copyright index b7790f2..970d427 100644 --- a/debian/copyright +++ b/debian/copyright @@ -15,7 +15,6 @@ Transceiver52M/Resampler.cpp Transceiver52M/Resampler.h Transceiver52M/osmo-trx.cpp - Transceiver52M/radioInterfaceDiversity.cpp Copyright: 2012-2013 Thomas Tsou License: LGPL-2.1+ -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14888 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5cfbbafd411e580421f86df6817f91261aceda7e Gerrit-Change-Number: 14888 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:55:59 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:55:59 +0000 Subject: Change in ...osmo-trx[master]: debian/copyright: Update wrong paths in license list In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14889 ) Change subject: debian/copyright: Update wrong paths in license list ...................................................................... debian/copyright: Update wrong paths in license list Those paths were moved into a subdir a while ago, but this file was not updated at the time. Change-Id: I1857338b7a19e2a37f62386ceb4a1fad988272ba --- M debian/copyright 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/copyright b/debian/copyright index 970d427..208eacd 100644 --- a/debian/copyright +++ b/debian/copyright @@ -9,9 +9,9 @@ 2010-2012 Range Networks, Inc. License: AGPL-3+ -Files: Transceiver52M/arm/* - Transceiver52M/x86/* - Transceiver52M/common/* +Files: Transceiver52M/arch/arm/* + Transceiver52M/arch/x86/* + Transceiver52M/arch/common/* Transceiver52M/Resampler.cpp Transceiver52M/Resampler.h Transceiver52M/osmo-trx.cpp -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14889 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1857338b7a19e2a37f62386ceb4a1fad988272ba Gerrit-Change-Number: 14889 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:55:59 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:55:59 +0000 Subject: Change in ...osmo-trx[master]: debian/copyright: Add missing file Utils.* to LGPL-2.1+ list In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14890 ) Change subject: debian/copyright: Add missing file Utils.* to LGPL-2.1+ list ...................................................................... debian/copyright: Add missing file Utils.* to LGPL-2.1+ list Change-Id: I36b8b8be48ae8676688786f39008d08b61011ede --- M debian/copyright 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/copyright b/debian/copyright index 208eacd..4a5d3c1 100644 --- a/debian/copyright +++ b/debian/copyright @@ -14,6 +14,8 @@ Transceiver52M/arch/common/* Transceiver52M/Resampler.cpp Transceiver52M/Resampler.h + Transceiver52M/Utils.cpp + Transceiver52M/Utils.h Transceiver52M/osmo-trx.cpp Copyright: 2012-2013 Thomas Tsou License: LGPL-2.1+ -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14890 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36b8b8be48ae8676688786f39008d08b61011ede Gerrit-Change-Number: 14890 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:56:00 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:56:00 +0000 Subject: Change in ...osmo-trx[master]: cosmetic: Fix trailing whitespace in several files In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14891 ) Change subject: cosmetic: Fix trailing whitespace in several files ...................................................................... cosmetic: Fix trailing whitespace in several files Change-Id: Ifafb68353960fc5046661854ccfb8d783b0efb14 --- M CommonLibs/Interthread.h M CommonLibs/Timeval.cpp M GSM/GSMCommon.h M Transceiver52M/Channelizer.cpp M Transceiver52M/ChannelizerBase.cpp M Transceiver52M/Resampler.cpp M Transceiver52M/Resampler.h M Transceiver52M/Synthesis.cpp M Transceiver52M/arch/arm/mult_neon.S M Transceiver52M/arch/common/convert_base.c M Transceiver52M/arch/common/fft.c M Transceiver52M/radioBuffer.cpp M tests/CommonLibs/BitVectorTest.cpp 13 files changed, 40 insertions(+), 41 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/CommonLibs/Interthread.h b/CommonLibs/Interthread.h index 42e6f7f..185112f 100644 --- a/CommonLibs/Interthread.h +++ b/CommonLibs/Interthread.h @@ -53,7 +53,7 @@ protected: - Fifo mQ; + Fifo mQ; mutable Mutex mLock; mutable Signal mWriteSignal; @@ -160,7 +160,7 @@ protected: - Fifo mQ; + Fifo mQ; mutable Mutex mLock; mutable Signal mWriteSignal; @@ -256,7 +256,7 @@ // This recurs (and the InterthreadQueue fills up with data) // until the read thread's accumulated temporary priority causes it to // get a second pre-emptive activation over the writing thread, - // resulting in bursts of activity by the read thread. + // resulting in bursts of activity by the read thread. { ScopedLock lock(mLock); mQ.put(val); } @@ -281,7 +281,7 @@ protected: - PointerFIFO mQ; + PointerFIFO mQ; mutable Mutex mLock; mutable Signal mWriteSignal; mutable Signal mReadSignal; diff --git a/CommonLibs/Timeval.cpp b/CommonLibs/Timeval.cpp index 420dd04..60bf7f6 100644 --- a/CommonLibs/Timeval.cpp +++ b/CommonLibs/Timeval.cpp @@ -81,7 +81,7 @@ int32_t deltaNs = other.nsec() - nsec(); return 1000*deltaS + deltaNs/1000000; } - + diff --git a/GSM/GSMCommon.h b/GSM/GSMCommon.h index f703c30..a3ada26 100644 --- a/GSM/GSMCommon.h +++ b/GSM/GSMCommon.h @@ -166,7 +166,7 @@ unsigned newTN = (mTN + other.mTN) % 8; uint64_t newFN = (mFN+other.mFN + (mTN + other.mTN)/8) % gHyperframe; return Time(newFN,newTN); - } + } int operator-(const Time& other) const { diff --git a/Transceiver52M/Channelizer.cpp b/Transceiver52M/Channelizer.cpp index a18dd03..1e4d7d4 100644 --- a/Transceiver52M/Channelizer.cpp +++ b/Transceiver52M/Channelizer.cpp @@ -1,6 +1,6 @@ /* * Polyphase channelizer - * + * * Copyright (C) 2012-2014 Tom Tsou * Copyright (C) 2015 Ettus Research LLC * @@ -63,7 +63,7 @@ return hInputs[chan]; } -/* +/* * Implementation based on material found in: * * "harris, fred, Multirate Signal Processing, Upper Saddle River, NJ, @@ -78,8 +78,8 @@ deinterleave(in, len, hInputs, blockLen, m); - /* - * Convolve through filterbank while applying and saving sample history + /* + * Convolve through filterbank while applying and saving sample history */ for (size_t i = 0; i < m; i++) { memcpy(&hInputs[i][2 * -hLen], hist[i], hSize); diff --git a/Transceiver52M/ChannelizerBase.cpp b/Transceiver52M/ChannelizerBase.cpp index f5b3ed4..96f76a9 100644 --- a/Transceiver52M/ChannelizerBase.cpp +++ b/Transceiver52M/ChannelizerBase.cpp @@ -1,8 +1,8 @@ /* * Polyphase channelizer - * + * * Copyright (C) 2012-2014 Tom Tsou - * Copyright (C) 2015 Ettus Research LLC + * Copyright (C) 2015 Ettus Research LLC * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by @@ -55,10 +55,10 @@ } } -/* +/* * Create polyphase filterbank * - * Implementation based material found in, + * Implementation based material found in, * * "harris, fred, Multirate Signal Processing, Upper Saddle River, NJ, * Prentice Hall, 2006." @@ -70,7 +70,7 @@ float sum = 0.0f, scale = 0.0f; float midpt = (float) (protoLen - 1.0) / 2.0; - /* + /* * Allocate 'M' partition filters and the temporary prototype * filter. Coefficients are real only and must be 16-byte memory * aligned for SSE usage. @@ -90,7 +90,7 @@ memalign(16, hLen * 2 * sizeof(float)); } - /* + /* * Generate the prototype filter with a Blackman-harris window. * Scale coefficients with DC filter gain set to unity divided * by the number of channels. @@ -110,7 +110,7 @@ } scale = (float) m / sum; - /* + /* * Populate partition filters and reverse the coefficients per * convolution requirements. */ @@ -174,7 +174,7 @@ return true; } -/* +/* * Setup filterbank internals */ bool ChannelizerBase::init() @@ -222,7 +222,7 @@ return true; } -/* +/* * Setup channelizer paramaters */ ChannelizerBase::ChannelizerBase(size_t m, size_t blockLen, size_t hLen) diff --git a/Transceiver52M/Resampler.cpp b/Transceiver52M/Resampler.cpp index ecd8865..f545db8 100644 --- a/Transceiver52M/Resampler.cpp +++ b/Transceiver52M/Resampler.cpp @@ -51,7 +51,7 @@ float cutoff; float sum = 0.0f, scale = 0.0f; - /* + /* * Allocate partition filters and the temporary prototype filter * according to numerator of the rational rate. Coefficients are * real only and must be 16-byte memory aligned for SSE usage. @@ -60,10 +60,10 @@ for (auto &part : partitions) part = (complex *) memalign(16, filt_len * sizeof(complex)); - /* + /* * Generate the prototype filter with a Blackman-harris window. * Scale coefficients with DC filter gain set to unity divided - * by the number of filter partitions. + * by the number of filter partitions. */ float a0 = 0.35875; float a1 = 0.48829; @@ -137,8 +137,8 @@ /* Generate output from precomputed input/output paths */ for (size_t i = 0; i < out_len; i++) { - n = in_index[i]; - path = out_path[i]; + n = in_index[i]; + path = out_path[i]; convolve_real(in, in_len, reinterpret_cast(partitions[path]), diff --git a/Transceiver52M/Resampler.h b/Transceiver52M/Resampler.h index caffc08..bee2436 100644 --- a/Transceiver52M/Resampler.h +++ b/Transceiver52M/Resampler.h @@ -28,7 +28,7 @@ /* Constructor for rational sample rate conversion * @param p numerator of resampling ratio * @param q denominator of resampling ratio - * @param filt_len length of each polyphase subfilter + * @param filt_len length of each polyphase subfilter */ Resampler(size_t p, size_t q, size_t filt_len = 16); ~Resampler(); @@ -58,7 +58,7 @@ int rotate(const float *in, size_t in_len, float *out, size_t out_len); /* Get filter length - * @return number of taps in each filter partition + * @return number of taps in each filter partition */ size_t len(); diff --git a/Transceiver52M/Synthesis.cpp b/Transceiver52M/Synthesis.cpp index 6b62156..a117390 100644 --- a/Transceiver52M/Synthesis.cpp +++ b/Transceiver52M/Synthesis.cpp @@ -1,6 +1,6 @@ /* * Polyphase synthesis filter - * + * * Copyright (C) 2012-2014 Tom Tsou * Copyright (C) 2015 Ettus Research LLC * @@ -74,7 +74,7 @@ return true; } -/* +/* * Implementation based on material found in: * * "harris, fred, Multirate Signal Processing, Upper Saddle River, NJ, @@ -92,8 +92,8 @@ cxvec_fft(fftHandle); - /* - * Convolve through filterbank while applying and saving sample history + /* + * Convolve through filterbank while applying and saving sample history */ for (size_t i = 0; i < m; i++) { memcpy(&hInputs[i][2 * -hLen], hist[i], hSize); diff --git a/Transceiver52M/arch/arm/mult_neon.S b/Transceiver52M/arch/arm/mult_neon.S index 162846e..113e227 100644 --- a/Transceiver52M/arch/arm/mult_neon.S +++ b/Transceiver52M/arch/arm/mult_neon.S @@ -1,5 +1,5 @@ /* - * NEON complex multiplication + * NEON complex multiplication * Copyright (C) 2012,2013 Thomas Tsou * * This library is free software; you can redistribute it and/or diff --git a/Transceiver52M/arch/common/convert_base.c b/Transceiver52M/arch/common/convert_base.c index 5251fb8..8d29310 100644 --- a/Transceiver52M/arch/common/convert_base.c +++ b/Transceiver52M/arch/common/convert_base.c @@ -31,4 +31,3 @@ for (int i = 0; i < len; i++) out[i] = in[i]; } - diff --git a/Transceiver52M/arch/common/fft.c b/Transceiver52M/arch/common/fft.c index 18b2de7..ed79d13 100644 --- a/Transceiver52M/arch/common/fft.c +++ b/Transceiver52M/arch/common/fft.c @@ -1,18 +1,18 @@ /* - * Fast Fourier transform + * Fast Fourier transform * * Copyright (C) 2012 Tom Tsou - * + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. - * + * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU Affero General Public License for more details. - * + * * You should have received a copy of the GNU Affero General Public License * along with this program; if not, see . * See the COPYING file in the main directory for details. @@ -32,9 +32,9 @@ fftwf_plan fft_plan; }; -/*! \brief Initialize FFT backend +/*! \brief Initialize FFT backend * \param[in] reverse FFT direction - * \param[in] m FFT length + * \param[in] m FFT length * \param[in] istride input stride count * \param[in] ostride output stride count * \param[in] in input buffer (FFTW aligned) @@ -92,7 +92,7 @@ free(ptr); } -/*! \brief Free FFT backend resources +/*! \brief Free FFT backend resources */ void free_fft(struct fft_hdl *hdl) { diff --git a/Transceiver52M/radioBuffer.cpp b/Transceiver52M/radioBuffer.cpp index a2b42c4..57de364 100644 --- a/Transceiver52M/radioBuffer.cpp +++ b/Transceiver52M/radioBuffer.cpp @@ -96,7 +96,7 @@ /* * Output direction * - * Write a non-segment length of samples to the buffer. + * Write a non-segment length of samples to the buffer. */ bool RadioBuffer::write(const float *wr, size_t len) { diff --git a/tests/CommonLibs/BitVectorTest.cpp b/tests/CommonLibs/BitVectorTest.cpp index 063138f..74c7d45 100644 --- a/tests/CommonLibs/BitVectorTest.cpp +++ b/tests/CommonLibs/BitVectorTest.cpp @@ -29,7 +29,7 @@ #include "BitVector.h" #include #include - + using namespace std; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ifafb68353960fc5046661854ccfb8d783b0efb14 Gerrit-Change-Number: 14891 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:56:00 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:56:00 +0000 Subject: Change in ...osmo-trx[master]: Add SPDX annotation In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14892 ) Change subject: Add SPDX annotation ...................................................................... Add SPDX annotation Related: OS#3515 Change-Id: I3719bd8dc015569ecd81928fc079e27593cdca09 --- M CommonLibs/BitVector.cpp M CommonLibs/BitVector.h M CommonLibs/Interthread.h M CommonLibs/LinkedLists.cpp M CommonLibs/LinkedLists.h M CommonLibs/Logger.cpp M CommonLibs/Logger.h M CommonLibs/PRBS.h M CommonLibs/Threads.cpp M CommonLibs/Threads.h M CommonLibs/Timeval.cpp M CommonLibs/Timeval.h M CommonLibs/Utils.cpp M CommonLibs/Utils.h M CommonLibs/Vector.h M CommonLibs/debug.c M CommonLibs/osmo_signal.h M GSM/GSMCommon.cpp M GSM/GSMCommon.h M Transceiver52M/Channelizer.cpp M Transceiver52M/ChannelizerBase.cpp M Transceiver52M/Resampler.cpp M Transceiver52M/Resampler.h M Transceiver52M/Synthesis.cpp M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h M Transceiver52M/arch/arm/convert.c M Transceiver52M/arch/arm/convert_neon.S M Transceiver52M/arch/arm/convolve.c M Transceiver52M/arch/arm/convolve_neon.S M Transceiver52M/arch/arm/mult.c M Transceiver52M/arch/arm/mult_neon.S M Transceiver52M/arch/arm/scale.c M Transceiver52M/arch/arm/scale_neon.S M Transceiver52M/arch/common/convert_base.c M Transceiver52M/arch/common/convolve_base.c M Transceiver52M/arch/common/fft.c M Transceiver52M/device/common/smpl_buf.cpp M Transceiver52M/device/common/smpl_buf.h M Transceiver52M/device/lms/LMSDevice.cpp M Transceiver52M/device/lms/LMSDevice.h M Transceiver52M/device/uhd/UHDDevice.cpp M Transceiver52M/device/uhd/UHDDevice.h M Transceiver52M/device/usrp1/USRPDevice.cpp M Transceiver52M/device/usrp1/USRPDevice.h M Transceiver52M/osmo-trx.cpp M Transceiver52M/radioBuffer.cpp M Transceiver52M/radioClock.cpp M Transceiver52M/radioClock.h M Transceiver52M/radioInterface.cpp M Transceiver52M/radioInterfaceMulti.cpp M Transceiver52M/radioInterfaceResamp.cpp M Transceiver52M/radioVector.cpp M Transceiver52M/radioVector.h M Transceiver52M/sigProcLib.cpp M tests/CommonLibs/BitVectorTest.cpp M tests/CommonLibs/InterthreadTest.cpp M tests/CommonLibs/LogTest.cpp M tests/CommonLibs/PRBSTest.cpp M tests/CommonLibs/TimevalTest.cpp M tests/CommonLibs/VectorTest.cpp 61 files changed, 139 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/CommonLibs/BitVector.cpp b/CommonLibs/BitVector.cpp index cf408cd..26b44ee 100644 --- a/CommonLibs/BitVector.cpp +++ b/CommonLibs/BitVector.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008, 2009 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/CommonLibs/BitVector.h b/CommonLibs/BitVector.h index 559dd99..16a1587 100644 --- a/CommonLibs/BitVector.h +++ b/CommonLibs/BitVector.h @@ -1,6 +1,8 @@ /* * Copyright 2008, 2009 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/CommonLibs/Interthread.h b/CommonLibs/Interthread.h index 185112f..8169985 100644 --- a/CommonLibs/Interthread.h +++ b/CommonLibs/Interthread.h @@ -1,6 +1,8 @@ /* * Copyright 2008, 2011 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/CommonLibs/LinkedLists.cpp b/CommonLibs/LinkedLists.cpp index b73a579..3ebf715 100644 --- a/CommonLibs/LinkedLists.cpp +++ b/CommonLibs/LinkedLists.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/CommonLibs/LinkedLists.h b/CommonLibs/LinkedLists.h index 136d13d..e98b41a 100644 --- a/CommonLibs/LinkedLists.h +++ b/CommonLibs/LinkedLists.h @@ -1,7 +1,10 @@ /* * Copyright 2008 Free Software Foundation, Inc. * -* This software is distributed under multiple licenses; see the COPYING file in the main directory for licensing information for this specific distribuion. +* SPDX-License-Identifier: AGPL-3.0+ +* +* This software is distributed under multiple licenses; see the COPYING file in +* the main directory for licensing information for this specific distribuion. * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/CommonLibs/Logger.cpp b/CommonLibs/Logger.cpp index f68fab5..5db7f87 100644 --- a/CommonLibs/Logger.cpp +++ b/CommonLibs/Logger.cpp @@ -1,6 +1,7 @@ /* * Copyright (C) 2018 sysmocom - s.f.m.c. GmbH * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/CommonLibs/Logger.h b/CommonLibs/Logger.h index 9c665cd..ab72303 100644 --- a/CommonLibs/Logger.h +++ b/CommonLibs/Logger.h @@ -2,6 +2,8 @@ * Copyright 2009, 2010 Free Software Foundation, Inc. * Copyright 2010 Kestrel Signal Processing, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/CommonLibs/PRBS.h b/CommonLibs/PRBS.h index 0b7bbc3..9235327 100644 --- a/CommonLibs/PRBS.h +++ b/CommonLibs/PRBS.h @@ -1,6 +1,8 @@ /* * Copyright (C) 2017 Alexander Chemeris * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/CommonLibs/Threads.cpp b/CommonLibs/Threads.cpp index ccea1e7..dd57d40 100644 --- a/CommonLibs/Threads.cpp +++ b/CommonLibs/Threads.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/CommonLibs/Threads.h b/CommonLibs/Threads.h index 8a6ba47..4cc0884 100644 --- a/CommonLibs/Threads.h +++ b/CommonLibs/Threads.h @@ -1,6 +1,8 @@ /* * Copyright 2008, 2011 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/CommonLibs/Timeval.cpp b/CommonLibs/Timeval.cpp index 60bf7f6..cfd01cf 100644 --- a/CommonLibs/Timeval.cpp +++ b/CommonLibs/Timeval.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/CommonLibs/Timeval.h b/CommonLibs/Timeval.h index 7c6a6f6..0826c12 100644 --- a/CommonLibs/Timeval.h +++ b/CommonLibs/Timeval.h @@ -1,6 +1,8 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/CommonLibs/Utils.cpp b/CommonLibs/Utils.cpp index 6cd4f84..e500475 100644 --- a/CommonLibs/Utils.cpp +++ b/CommonLibs/Utils.cpp @@ -1,6 +1,8 @@ /* * Copyright 2018 sysmocom - s.f.m.c. GmbH * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/CommonLibs/Utils.h b/CommonLibs/Utils.h index 4f0fbc0..3c5c802 100644 --- a/CommonLibs/Utils.h +++ b/CommonLibs/Utils.h @@ -1,6 +1,8 @@ /* * Copyright 2018 sysmocom - s.f.m.c. GmbH * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/CommonLibs/Vector.h b/CommonLibs/Vector.h index 4c96b78..0970248 100644 --- a/CommonLibs/Vector.h +++ b/CommonLibs/Vector.h @@ -2,6 +2,8 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/CommonLibs/debug.c b/CommonLibs/debug.c index 17ef5bc..48d4981 100644 --- a/CommonLibs/debug.c +++ b/CommonLibs/debug.c @@ -1,3 +1,26 @@ +/* + * Copyright (C) 2018-2019 sysmocom - s.f.m.c. GmbH + * All Rights Reserved + * + * SPDX-License-Identifier: AGPL-3.0+ + * + * Author: Pau Espin Pedrol + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * See the COPYING file in the main directory for details. + */ + #include #include diff --git a/CommonLibs/osmo_signal.h b/CommonLibs/osmo_signal.h index 6ee1bf9..ee7e2a4 100644 --- a/CommonLibs/osmo_signal.h +++ b/CommonLibs/osmo_signal.h @@ -5,6 +5,8 @@ * * All Rights Reserved * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation; either version 3 of the License, or diff --git a/GSM/GSMCommon.cpp b/GSM/GSMCommon.cpp index 711ca70..5e9e4ae 100644 --- a/GSM/GSMCommon.cpp +++ b/GSM/GSMCommon.cpp @@ -2,6 +2,8 @@ * Copyright 2008 Free Software Foundation, Inc. * Copyright 2011 Range Networks, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/GSM/GSMCommon.h b/GSM/GSMCommon.h index a3ada26..48723b4 100644 --- a/GSM/GSMCommon.h +++ b/GSM/GSMCommon.h @@ -2,6 +2,8 @@ /* * Copyright 2008-2011 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/Transceiver52M/Channelizer.cpp b/Transceiver52M/Channelizer.cpp index 1e4d7d4..341cd0a 100644 --- a/Transceiver52M/Channelizer.cpp +++ b/Transceiver52M/Channelizer.cpp @@ -4,6 +4,8 @@ * Copyright (C) 2012-2014 Tom Tsou * Copyright (C) 2015 Ettus Research LLC * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/ChannelizerBase.cpp b/Transceiver52M/ChannelizerBase.cpp index 96f76a9..f3f07c1 100644 --- a/Transceiver52M/ChannelizerBase.cpp +++ b/Transceiver52M/ChannelizerBase.cpp @@ -4,6 +4,8 @@ * Copyright (C) 2012-2014 Tom Tsou * Copyright (C) 2015 Ettus Research LLC * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/Resampler.cpp b/Transceiver52M/Resampler.cpp index f545db8..7ba0219 100644 --- a/Transceiver52M/Resampler.cpp +++ b/Transceiver52M/Resampler.cpp @@ -2,6 +2,8 @@ * Rational Sample Rate Conversion * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/Resampler.h b/Transceiver52M/Resampler.h index bee2436..139b857 100644 --- a/Transceiver52M/Resampler.h +++ b/Transceiver52M/Resampler.h @@ -2,6 +2,8 @@ * Rational Sample Rate Conversion * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/Synthesis.cpp b/Transceiver52M/Synthesis.cpp index a117390..24da8e6 100644 --- a/Transceiver52M/Synthesis.cpp +++ b/Transceiver52M/Synthesis.cpp @@ -4,6 +4,8 @@ * Copyright (C) 2012-2014 Tom Tsou * Copyright (C) 2015 Ettus Research LLC * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 17e0476..af6b0dd 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -1,6 +1,8 @@ /* * Copyright 2008, 2009, 2010 Free Software Foundation, Inc. * +* SPDX-License-Identifier: GPL-3.0+ +* * This software is distributed under the terms of the GNU Public License. * See the COPYING file in the main directory for details. * diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index aa2a716..8b5a9b1 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -1,6 +1,8 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: GPL-3.0+ +* * This software is distributed under the terms of the GNU Public License. * See the COPYING file in the main directory for details. * diff --git a/Transceiver52M/arch/arm/convert.c b/Transceiver52M/arch/arm/convert.c index c94a3d7..ace1b6f 100644 --- a/Transceiver52M/arch/arm/convert.c +++ b/Transceiver52M/arch/arm/convert.c @@ -2,6 +2,8 @@ * NEON type conversions * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/arm/convert_neon.S b/Transceiver52M/arch/arm/convert_neon.S index 842ed9f..a1fbd40 100644 --- a/Transceiver52M/arch/arm/convert_neon.S +++ b/Transceiver52M/arch/arm/convert_neon.S @@ -2,6 +2,8 @@ * NEON type conversions * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/arm/convolve.c b/Transceiver52M/arch/arm/convolve.c index 5b5bce5..63b1655 100644 --- a/Transceiver52M/arch/arm/convolve.c +++ b/Transceiver52M/arch/arm/convolve.c @@ -2,6 +2,8 @@ * NEON Convolution * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/arm/convolve_neon.S b/Transceiver52M/arch/arm/convolve_neon.S index 8a023ff..a3e1ba5 100644 --- a/Transceiver52M/arch/arm/convolve_neon.S +++ b/Transceiver52M/arch/arm/convolve_neon.S @@ -2,6 +2,8 @@ * NEON Convolution * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/arm/mult.c b/Transceiver52M/arch/arm/mult.c index 245be50..9851626 100644 --- a/Transceiver52M/arch/arm/mult.c +++ b/Transceiver52M/arch/arm/mult.c @@ -2,6 +2,8 @@ * NEON scaling * Copyright (C) 2012,2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/arm/mult_neon.S b/Transceiver52M/arch/arm/mult_neon.S index 113e227..6318c50 100644 --- a/Transceiver52M/arch/arm/mult_neon.S +++ b/Transceiver52M/arch/arm/mult_neon.S @@ -2,6 +2,8 @@ * NEON complex multiplication * Copyright (C) 2012,2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/arm/scale.c b/Transceiver52M/arch/arm/scale.c index 2de13ff..a3214f7 100644 --- a/Transceiver52M/arch/arm/scale.c +++ b/Transceiver52M/arch/arm/scale.c @@ -2,6 +2,8 @@ * NEON scaling * Copyright (C) 2012,2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/arm/scale_neon.S b/Transceiver52M/arch/arm/scale_neon.S index a66fbe5..f10de1e 100644 --- a/Transceiver52M/arch/arm/scale_neon.S +++ b/Transceiver52M/arch/arm/scale_neon.S @@ -2,6 +2,8 @@ * ARM NEON Scaling * Copyright (C) 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/common/convert_base.c b/Transceiver52M/arch/common/convert_base.c index 8d29310..9876e83 100644 --- a/Transceiver52M/arch/common/convert_base.c +++ b/Transceiver52M/arch/common/convert_base.c @@ -2,6 +2,8 @@ * Conversion * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/common/convolve_base.c b/Transceiver52M/arch/common/convolve_base.c index 9bb8d3d..bfda783 100644 --- a/Transceiver52M/arch/common/convolve_base.c +++ b/Transceiver52M/arch/common/convolve_base.c @@ -2,6 +2,8 @@ * Convolution * Copyright (C) 2012, 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/arch/common/fft.c b/Transceiver52M/arch/common/fft.c index ed79d13..ad096b1 100644 --- a/Transceiver52M/arch/common/fft.c +++ b/Transceiver52M/arch/common/fft.c @@ -3,6 +3,8 @@ * * Copyright (C) 2012 Tom Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/device/common/smpl_buf.cpp b/Transceiver52M/device/common/smpl_buf.cpp index c21f306..33161bc 100644 --- a/Transceiver52M/device/common/smpl_buf.cpp +++ b/Transceiver52M/device/common/smpl_buf.cpp @@ -7,6 +7,8 @@ * * Author: Tom Tsou * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/device/common/smpl_buf.h b/Transceiver52M/device/common/smpl_buf.h index 24d3ce9..383c814 100644 --- a/Transceiver52M/device/common/smpl_buf.h +++ b/Transceiver52M/device/common/smpl_buf.h @@ -7,6 +7,8 @@ * * Author: Tom Tsou * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp index 0253d4c..0eaf0a3 100644 --- a/Transceiver52M/device/lms/LMSDevice.cpp +++ b/Transceiver52M/device/lms/LMSDevice.cpp @@ -1,6 +1,8 @@ /* * Copyright 2018 sysmocom - s.f.m.c. GmbH * +* SPDX-License-Identifier: AGPL-3.0+ +* This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/device/lms/LMSDevice.h b/Transceiver52M/device/lms/LMSDevice.h index 9e0944d..906fbee 100644 --- a/Transceiver52M/device/lms/LMSDevice.h +++ b/Transceiver52M/device/lms/LMSDevice.h @@ -1,7 +1,10 @@ /* * Copyright 2018 sysmocom - s.f.m.c. GmbH * -* This software is distributed under multiple licenses; see the COPYING file in the main directory for licensing information for this specific distribuion. +* SPDX-License-Identifier: AGPL-3.0+ +* +* This software is distributed under multiple licenses; see the COPYING file in +* the main directory for licensing information for this specific distribuion. * * This use of this software may be subject to additional restrictions. * See the LEGAL file in the main directory for details. diff --git a/Transceiver52M/device/uhd/UHDDevice.cpp b/Transceiver52M/device/uhd/UHDDevice.cpp index 4e6f49d..8bb94d6 100644 --- a/Transceiver52M/device/uhd/UHDDevice.cpp +++ b/Transceiver52M/device/uhd/UHDDevice.cpp @@ -6,6 +6,8 @@ * * Author: Tom Tsou * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/device/uhd/UHDDevice.h b/Transceiver52M/device/uhd/UHDDevice.h index 0b57ba4..d5a6348 100644 --- a/Transceiver52M/device/uhd/UHDDevice.h +++ b/Transceiver52M/device/uhd/UHDDevice.h @@ -7,6 +7,8 @@ * * Author: Tom Tsou * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/device/usrp1/USRPDevice.cpp b/Transceiver52M/device/usrp1/USRPDevice.cpp index b1d6c56..af0b3de 100644 --- a/Transceiver52M/device/usrp1/USRPDevice.cpp +++ b/Transceiver52M/device/usrp1/USRPDevice.cpp @@ -1,6 +1,8 @@ /* * Copyright 2008, 2009 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/Transceiver52M/device/usrp1/USRPDevice.h b/Transceiver52M/device/usrp1/USRPDevice.h index c02e58c..9a2426c 100644 --- a/Transceiver52M/device/usrp1/USRPDevice.h +++ b/Transceiver52M/device/usrp1/USRPDevice.h @@ -1,7 +1,10 @@ /* * Copyright 2008 Free Software Foundation, Inc. * -* This software is distributed under multiple licenses; see the COPYING file in the main directory for licensing information for this specific distribuion. +* SPDX-License-Identifier: AGPL-3.0+ +* +* This software is distributed under multiple licenses; see the COPYING file in +* the main directory for licensing information for this specific distribuion. * * This use of this software may be subject to additional restrictions. * See the LEGAL file in the main directory for details. diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index 8a3f1e3..cd659a7 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -1,6 +1,8 @@ /* * Copyright (C) 2013 Thomas Tsou * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/Transceiver52M/radioBuffer.cpp b/Transceiver52M/radioBuffer.cpp index 57de364..62f6553 100644 --- a/Transceiver52M/radioBuffer.cpp +++ b/Transceiver52M/radioBuffer.cpp @@ -5,6 +5,8 @@ * * Author: Tom Tsou * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/radioClock.cpp b/Transceiver52M/radioClock.cpp index 505bb01..2befd0d 100644 --- a/Transceiver52M/radioClock.cpp +++ b/Transceiver52M/radioClock.cpp @@ -4,6 +4,8 @@ * * Copyright 2011 Free Software Foundation, Inc. * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/radioClock.h b/Transceiver52M/radioClock.h index 9c35c44..472f43d 100644 --- a/Transceiver52M/radioClock.h +++ b/Transceiver52M/radioClock.h @@ -4,6 +4,8 @@ * * Copyright 2011 Free Software Foundation, Inc. * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/radioInterface.cpp b/Transceiver52M/radioInterface.cpp index 04b98da..e32848e 100644 --- a/Transceiver52M/radioInterface.cpp +++ b/Transceiver52M/radioInterface.cpp @@ -4,6 +4,8 @@ * Copyright (C) 2008-2014 Free Software Foundation, Inc. * Copyright (C) 2015 Ettus Research LLC * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/radioInterfaceMulti.cpp b/Transceiver52M/radioInterfaceMulti.cpp index 17a015b..0208e82 100644 --- a/Transceiver52M/radioInterfaceMulti.cpp +++ b/Transceiver52M/radioInterfaceMulti.cpp @@ -5,6 +5,8 @@ * * Author: Tom Tsou * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/radioInterfaceResamp.cpp b/Transceiver52M/radioInterfaceResamp.cpp index 8ae4aa1..e2f69f2 100644 --- a/Transceiver52M/radioInterfaceResamp.cpp +++ b/Transceiver52M/radioInterfaceResamp.cpp @@ -6,6 +6,8 @@ * * Author: Tom Tsou * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/radioVector.cpp b/Transceiver52M/radioVector.cpp index 2e3af9d..ad40a11 100644 --- a/Transceiver52M/radioVector.cpp +++ b/Transceiver52M/radioVector.cpp @@ -4,6 +4,8 @@ * * Copyright 2011 Free Software Foundation, Inc. * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/radioVector.h b/Transceiver52M/radioVector.h index 0566123..0a14a4d 100644 --- a/Transceiver52M/radioVector.h +++ b/Transceiver52M/radioVector.h @@ -4,6 +4,8 @@ * * Copyright 2011 Free Software Foundation, Inc. * + * SPDX-License-Identifier: AGPL-3.0+ + * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU Affero General Public License as published by * the Free Software Foundation, either version 3 of the License, or diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp index 1042dbb..011ddff 100644 --- a/Transceiver52M/sigProcLib.cpp +++ b/Transceiver52M/sigProcLib.cpp @@ -1,6 +1,8 @@ /* * Copyright 2008, 2011 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ +* * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. * diff --git a/tests/CommonLibs/BitVectorTest.cpp b/tests/CommonLibs/BitVectorTest.cpp index 74c7d45..440ace1 100644 --- a/tests/CommonLibs/BitVectorTest.cpp +++ b/tests/CommonLibs/BitVectorTest.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/tests/CommonLibs/InterthreadTest.cpp b/tests/CommonLibs/InterthreadTest.cpp index c131c2a..462df08 100644 --- a/tests/CommonLibs/InterthreadTest.cpp +++ b/tests/CommonLibs/InterthreadTest.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/tests/CommonLibs/LogTest.cpp b/tests/CommonLibs/LogTest.cpp index 5e51ce7..0087070 100644 --- a/tests/CommonLibs/LogTest.cpp +++ b/tests/CommonLibs/LogTest.cpp @@ -2,6 +2,7 @@ * Copyright 2009 Free Software Foundation, Inc. * Copyright 2010 Kestrel Signal Processing, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/tests/CommonLibs/PRBSTest.cpp b/tests/CommonLibs/PRBSTest.cpp index b83e93d..cb5ed41 100644 --- a/tests/CommonLibs/PRBSTest.cpp +++ b/tests/CommonLibs/PRBSTest.cpp @@ -1,6 +1,8 @@ /* * Copyright (C) 2017 Alexander Chemeris * + * SPDX-License-Identifier: LGPL-2.1+ + * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either diff --git a/tests/CommonLibs/TimevalTest.cpp b/tests/CommonLibs/TimevalTest.cpp index b822982..6a45d3b 100644 --- a/tests/CommonLibs/TimevalTest.cpp +++ b/tests/CommonLibs/TimevalTest.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. diff --git a/tests/CommonLibs/VectorTest.cpp b/tests/CommonLibs/VectorTest.cpp index 6958889..292d56a 100644 --- a/tests/CommonLibs/VectorTest.cpp +++ b/tests/CommonLibs/VectorTest.cpp @@ -1,6 +1,7 @@ /* * Copyright 2008 Free Software Foundation, Inc. * +* SPDX-License-Identifier: AGPL-3.0+ * * This software is distributed under the terms of the GNU Affero Public License. * See the COPYING file in the main directory for details. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14892 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3719bd8dc015569ecd81928fc079e27593cdca09 Gerrit-Change-Number: 14892 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:56:39 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:56:39 +0000 Subject: Change in ...osmo-sgsn[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4d1219bf84d3b8dcaf925a60cf54abe733fba263 Gerrit-Change-Number: 14834 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 19:56:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:56:42 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:56:42 +0000 Subject: Change in ...osmo-msc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14835 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14835 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I615bb5be3671022c6b821575a61f945b50e8f2a5 Gerrit-Change-Number: 14835 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 22 Jul 2019 19:56:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:56:45 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:56:45 +0000 Subject: Change in ...osmo-mgw[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14836 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib157bd2e110b271dbe5ac928c98251e016477f56 Gerrit-Change-Number: 14836 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 19:56:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:56:52 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:56:52 +0000 Subject: Change in ...osmo-bsc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14833 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14833 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I571a85b6ea53af7661248afd84e61cf34b7b5641 Gerrit-Change-Number: 14833 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 19:56:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:56:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:56:56 +0000 Subject: Change in ...osmo-msc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14835 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Related: OS#4123 Change-Id: I615bb5be3671022c6b821575a61f945b50e8f2a5 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index a2dfa5b..bb8fb39 100644 --- a/configure.ac +++ b/configure.ac @@ -117,7 +117,7 @@ AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"]) +AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14835 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I615bb5be3671022c6b821575a61f945b50e8f2a5 Gerrit-Change-Number: 14835 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:56:59 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:56:59 +0000 Subject: Change in ...osmo-mgw[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14836 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Related: OS#4123 Change-Id: Ib157bd2e110b271dbe5ac928c98251e016477f56 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index a14c276..b4858c4 100644 --- a/configure.ac +++ b/configure.ac @@ -79,7 +79,7 @@ AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"]) +AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib157bd2e110b271dbe5ac928c98251e016477f56 Gerrit-Change-Number: 14836 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 19:57:02 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 22 Jul 2019 19:57:02 +0000 Subject: Change in ...osmo-sgsn[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed "error: potential null pointer dereference" Related: OS#4123 Change-Id: I4d1219bf84d3b8dcaf925a60cf54abe733fba263 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index e72e9d6..a7d3717 100644 --- a/configure.ac +++ b/configure.ac @@ -116,7 +116,7 @@ AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"]) +AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14834 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4d1219bf84d3b8dcaf925a60cf54abe733fba263 Gerrit-Change-Number: 14834 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 20:22:58 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Mon, 22 Jul 2019 20:22:58 +0000 Subject: Change in ...libosmo-abis[master]: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc In-Reply-To: References: Message-ID: Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14743 ) Change subject: add ipa pingp/pong keepalive for OML/RSL links between bts and bsc ...................................................................... Patch Set 7: > Patch Set 7: > > I'm a bit reluctant to merge this to master as we're close to tagging a new release. A change like this will need to be verified against 3rd party RSL/OML (e.g. nanoBTSs devices), and we have to test combinations of old OsmoBTS with new BSC using this patch and vice-versa. I don't know if all of those combinations will reliably send a PONG in response to PING. They should, but who knows... I guess merging after tagging would be fine, it needs to be explicitly enabled anyway, so even if it does not play well it has no impact on default configurations. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a Gerrit-Change-Number: 14743 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 20:22:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 20:48:47 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 22 Jul 2019 20:48:47 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 ) Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/14896/2/src/osmo-bts-trx/trx_vty.c File src/osmo-bts-trx/trx_vty.c: https://gerrit.osmocom.org/#/c/14896/2/src/osmo-bts-trx/trx_vty.c at 502 PS2, Line 502: -1 Somehow this '-1' on the VTY doesn't look like a good idea to me. Something like: "osmotrx trxd-max-version (max|legacy)", "osmotrx trxd-max-version <1-15>", looks intuitive and more elegant. This way a user doesn't need to know which version is the legacy one (0). https://gerrit.osmocom.org/#/c/14896/2/src/osmo-bts-trx/trx_vty.c at 510 PS2, Line 510: %d is not supported As a user, I would expect to see which one _is supported_ then (basically the maximum, "... %d\n" % TRX_DATA_FORMAT_VER). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 20:48:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 20:50:37 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 22 Jul 2019 20:50:37 +0000 Subject: Change in ...osmocom-bb[master]: fb_tools/bdf_to_c.py: make it compatible with python3 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14758 ) Change subject: fb_tools/bdf_to_c.py: make it compatible with python3 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iaa20dd0aafa20e36186cf8dfe4d0ac9ab638f235 Gerrit-Change-Number: 14758 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 22 Jul 2019 20:50:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 22 22:15:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 22 Jul 2019 22:15:25 +0000 Subject: Change in ...osmo-trx[master]: Bind CTRL port to IP addr specified in VTY config In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14893 ) Change subject: Bind CTRL port to IP addr specified in VTY config ...................................................................... Bind CTRL port to IP addr specified in VTY config Before this commit, osmo-trx was always setting its CTRL socket to listen on 127.0.0.1. Change-Id: I61a06c1b9c20a906e7030f824a93370d041be7b9 --- M Transceiver52M/osmo-trx.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp index cd659a7..15f744c 100644 --- a/Transceiver52M/osmo-trx.cpp +++ b/Transceiver52M/osmo-trx.cpp @@ -602,7 +602,7 @@ if (rc < 0) exit(1); - g_ctrlh = ctrl_interface_setup(NULL, OSMO_CTRL_PORT_TRX, NULL); + g_ctrlh = ctrl_interface_setup_dynip(NULL, ctrl_vty_get_bind_addr(), OSMO_CTRL_PORT_TRX, NULL); if (!g_ctrlh) { LOG(ERROR) << "Failed to create CTRL interface.\n"; exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14893 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I61a06c1b9c20a906e7030f824a93370d041be7b9 Gerrit-Change-Number: 14893 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Mon Jul 22 22:39:37 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 22:39:37 +0000 Subject: Build failure of network:osmocom:latest/libosmocore in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d363b337f078_2e5b10845fc266830@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libosmocore/Debian_Testing/x86_64 Package network:osmocom:latest/libosmocore failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmocore Last lines of build log: [ 23s] [106/239] installing libedit2-3.1-20190324-1 [ 23s] Processing triggers for libc-bin (2.28-10) ... [ 23s] [107/239] installing libhogweed4-3.4.1-1 [ 23s] Processing triggers for libc-bin (2.28-10) ... [ 23s] [108/239] installing libicu63-63.2-2 [ 24s] Processing triggers for libc-bin (2.28-10) ... [ 24s] [109/239] installing libmagic1-1:5.35-4 [ 24s] Processing triggers for libc-bin (2.28-10) ... [ 24s] [110/239] installing libuchardet0-0.0.6-3 [ 24s] Processing triggers for libc-bin (2.28-10) ... [ 24s] [111/239] installing libunwind8-1.2.1-9 [ 24s] Processing triggers for libc-bin (2.28-10) ... [ 24s] [112/239] installing python2.7-minimal-2.7.16-3 [ 25s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 25s] dpkg: error processing package python2.7-minimal (--install): [ 25s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 25s] Errors were encountered while processing: [ 25s] python2.7-minimal [ 25s] exit ... [ 25s] [ 25s] build74 failed "build libosmocore_1.1.0.dsc" at Mon Jul 22 22:39:30 UTC 2019. [ 25s] [ 25s] ### VM INTERACTION START ### [ 28s] [ 17.743269] sysrq: SysRq : Power Off [ 28s] [ 17.745395] reboot: Power down [ 28s] ### VM INTERACTION END ### [ 28s] [ 28s] build74 failed "build libosmocore_1.1.0.dsc" at Mon Jul 22 22:39:33 UTC 2019. [ 28s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 22:40:11 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 22:40:11 +0000 Subject: Build failure of network:osmocom:latest/libusrp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d363b4f9e638_2e5b10845fc2670e2@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/libusrp/Debian_Testing/x86_64 Package network:osmocom:latest/libusrp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libusrp Last lines of build log: [ 29s] [118/361] installing libedit2-3.1-20190324-1 [ 29s] Processing triggers for libc-bin (2.28-10) ... [ 29s] [119/361] installing libhwloc5-1.11.12-3 [ 30s] Processing triggers for libc-bin (2.28-10) ... [ 30s] [120/361] installing libicu63-63.2-2 [ 30s] Processing triggers for libc-bin (2.28-10) ... [ 31s] [121/361] installing libmagic1-1:5.35-4 [ 31s] Processing triggers for libc-bin (2.28-10) ... [ 31s] [122/361] installing libuchardet0-0.0.6-3 [ 31s] Processing triggers for libc-bin (2.28-10) ... [ 31s] [123/361] installing libunwind8-1.2.1-9 [ 31s] Processing triggers for libc-bin (2.28-10) ... [ 31s] [124/361] installing python2.7-minimal-2.7.16-3 [ 31s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 31s] dpkg: error processing package python2.7-minimal (--install): [ 31s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 31s] Errors were encountered while processing: [ 31s] python2.7-minimal [ 31s] exit ... [ 31s] [ 31s] sheep84 failed "build libusrp_3.4.2.dsc" at Mon Jul 22 22:39:51 UTC 2019. [ 31s] [ 31s] ### VM INTERACTION START ### [ 35s] [ 23.715877] sysrq: SysRq : Power Off [ 35s] [ 23.722687] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 35s] [ 35s] sheep84 failed "build libusrp_3.4.2.dsc" at Mon Jul 22 22:39:55 UTC 2019. [ 35s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 22:42:45 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 22:42:45 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d363c039053b_2e5b10845fc2672b4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmocore failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 45s] [106/239] installing libedit2-3.1-20190324-1 [ 45s] Processing triggers for libc-bin (2.28-10) ... [ 45s] [107/239] installing libhogweed4-3.4.1-1 [ 45s] Processing triggers for libc-bin (2.28-10) ... [ 45s] [108/239] installing libicu63-63.2-2 [ 46s] Processing triggers for libc-bin (2.28-10) ... [ 46s] [109/239] installing libmagic1-1:5.35-4 [ 46s] Processing triggers for libc-bin (2.28-10) ... [ 46s] [110/239] installing libuchardet0-0.0.6-3 [ 46s] Processing triggers for libc-bin (2.28-10) ... [ 46s] [111/239] installing libunwind8-1.2.1-9 [ 46s] Processing triggers for libc-bin (2.28-10) ... [ 46s] [112/239] installing python2.7-minimal-2.7.16-3 [ 47s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 47s] dpkg: error processing package python2.7-minimal (--install): [ 47s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 47s] Errors were encountered while processing: [ 47s] python2.7-minimal [ 47s] exit ... [ 47s] [ 47s] lamb16 failed "build libosmocore_1.1.0.91.eb57.dsc" at Mon Jul 22 22:42:25 UTC 2019. [ 47s] [ 47s] ### VM INTERACTION START ### [ 51s] [ 34.068640] sysrq: SysRq : Power Off [ 51s] [ 34.077026] reboot: Power down [ 51s] ### VM INTERACTION END ### [ 51s] [ 51s] lamb16 failed "build libosmocore_1.1.0.91.eb57.dsc" at Mon Jul 22 22:42:29 UTC 2019. [ 51s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 22:42:45 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 22:42:45 +0000 Subject: Build failure of network:osmocom:nightly/libusrp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d363c042eb64_2e5b10845fc267383@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Testing/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 46s] [119/363] installing libedit2-3.1-20190324-1 [ 46s] Processing triggers for libc-bin (2.28-10) ... [ 46s] [120/363] installing libhwloc5-1.11.12-3 [ 46s] Processing triggers for libc-bin (2.28-10) ... [ 46s] [121/363] installing libicu63-63.2-2 [ 47s] Processing triggers for libc-bin (2.28-10) ... [ 47s] [122/363] installing libmagic1-1:5.35-4 [ 48s] Processing triggers for libc-bin (2.28-10) ... [ 48s] [123/363] installing libuchardet0-0.0.6-3 [ 48s] Processing triggers for libc-bin (2.28-10) ... [ 48s] [124/363] installing libunwind8-1.2.1-9 [ 48s] Processing triggers for libc-bin (2.28-10) ... [ 48s] [125/363] installing python2.7-minimal-2.7.16-3 [ 48s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 48s] dpkg: error processing package python2.7-minimal (--install): [ 48s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 48s] Errors were encountered while processing: [ 48s] python2.7-minimal [ 48s] exit ... [ 48s] [ 48s] lamb16 failed "build libusrp_3.4.2.20190722.dsc" at Mon Jul 22 22:42:29 UTC 2019. [ 48s] [ 49s] ### VM INTERACTION START ### [ 52s] [ 32.831387] sysrq: SysRq : Power Off [ 52s] [ 32.855213] reboot: Power down [ 52s] ### VM INTERACTION END ### [ 52s] [ 52s] lamb16 failed "build libusrp_3.4.2.20190722.dsc" at Mon Jul 22 22:42:34 UTC 2019. [ 52s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 22:43:19 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 22:43:19 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d363c1f50740_2e5b10845fc2674d3@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 85s] [156/382] installing libmagic1-1:5.35-4 [ 85s] Processing triggers for libc-bin (2.28-10) ... [ 85s] [157/382] installing libosp5-1.5.2-13+b1 [ 85s] Processing triggers for libc-bin (2.28-10) ... [ 85s] [158/382] installing libostyle1c2-1.4devel1-21.3+b1 [ 85s] Processing triggers for libc-bin (2.28-10) ... [ 85s] [159/382] installing libthai0-0.1.28-2 [ 86s] Processing triggers for libc-bin (2.28-10) ... [ 86s] [160/382] installing libuchardet0-0.0.6-3 [ 86s] Processing triggers for libc-bin (2.28-10) ... [ 86s] [161/382] installing libunwind8-1.2.1-9 [ 86s] Processing triggers for libc-bin (2.28-10) ... [ 86s] [162/382] installing python2.7-minimal-2.7.16-3 [ 87s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 87s] dpkg: error processing package python2.7-minimal (--install): [ 87s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 87s] Errors were encountered while processing: [ 87s] python2.7-minimal [ 87s] exit ... [ 87s] [ 87s] lamb10 failed "build osmo-gsm-manuals-dev_0.1.1.1.5238.dsc" at Mon Jul 22 22:43:06 UTC 2019. [ 87s] [ 87s] ### VM INTERACTION START ### [ 90s] [ 62.940601] sysrq: SysRq : Power Off [ 90s] [ 62.954169] reboot: Power down [ 90s] ### VM INTERACTION END ### [ 90s] [ 90s] lamb10 failed "build osmo-gsm-manuals-dev_0.1.1.1.5238.dsc" at Mon Jul 22 22:43:10 UTC 2019. [ 90s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 22:46:29 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 22:46:29 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-sccp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d363cd3417fc_2e5b10845fc26783@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 39s] [165/415] installing libosmocore12-1.1.0.91.eb57 [ 39s] Processing triggers for libc-bin (2.28-10) ... [ 39s] [166/415] installing libosp5-1.5.2-13+b1 [ 39s] Processing triggers for libc-bin (2.28-10) ... [ 39s] [167/415] installing libostyle1c2-1.4devel1-21.3+b1 [ 39s] Processing triggers for libc-bin (2.28-10) ... [ 39s] [168/415] installing libthai0-0.1.28-2 [ 39s] Processing triggers for libc-bin (2.28-10) ... [ 39s] [169/415] installing libuchardet0-0.0.6-3 [ 39s] Processing triggers for libc-bin (2.28-10) ... [ 39s] [170/415] installing libunwind8-1.2.1-9 [ 39s] Processing triggers for libc-bin (2.28-10) ... [ 39s] [171/415] installing python2.7-minimal-2.7.16-3 [ 40s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 40s] dpkg: error processing package python2.7-minimal (--install): [ 40s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 40s] Errors were encountered while processing: [ 40s] python2.7-minimal [ 40s] exit ... [ 40s] [ 40s] sheep84 failed "build libosmo-sccp_1.0.0.25.2164.dsc" at Mon Jul 22 22:46:22 UTC 2019. [ 40s] [ 40s] ### VM INTERACTION START ### [ 43s] [ 31.069463] sysrq: SysRq : Power Off [ 43s] [ 31.075299] reboot: Power down [ 43s] ### VM INTERACTION END ### [ 43s] [ 43s] sheep84 failed "build libosmo-sccp_1.0.0.25.2164.dsc" at Mon Jul 22 22:46:25 UTC 2019. [ 43s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 22:49:03 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 22:49:03 +0000 Subject: Build failure of network:osmocom:latest/osmo-iuh in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d363d68103c8_2e5b10845fc2682ce@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-iuh/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-iuh failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-iuh Last lines of build log: [ 37s] Processing triggers for libc-bin (2.28-10) ... [ 37s] [105/239] installing libc6-dev-2.28-10 [ 38s] [106/239] installing libhogweed4-3.4.1-1 [ 38s] Processing triggers for libc-bin (2.28-10) ... [ 38s] [107/239] installing libicu63-63.2-2 [ 39s] Processing triggers for libc-bin (2.28-10) ... [ 39s] [108/239] installing libmagic1-1:5.35-4 [ 39s] Processing triggers for libc-bin (2.28-10) ... [ 39s] [109/239] installing libuchardet0-0.0.6-3 [ 39s] Processing triggers for libc-bin (2.28-10) ... [ 39s] [110/239] installing libunwind8-1.2.1-9 [ 39s] Processing triggers for libc-bin (2.28-10) ... [ 39s] [111/239] installing python2.7-minimal-2.7.16-3 [ 40s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 40s] dpkg: error processing package python2.7-minimal (--install): [ 40s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 40s] Errors were encountered while processing: [ 40s] python2.7-minimal [ 40s] exit ... [ 40s] [ 40s] lamb62 failed "build osmo-iuh_0.4.0.dsc" at Mon Jul 22 22:48:44 UTC 2019. [ 40s] [ 40s] ### VM INTERACTION START ### [ 43s] [ 27.649505] sysrq: SysRq : Power Off [ 43s] [ 27.665625] reboot: Power down [ 43s] ### VM INTERACTION END ### [ 43s] [ 43s] lamb62 failed "build osmo-iuh_0.4.0.dsc" at Mon Jul 22 22:48:48 UTC 2019. [ 43s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 22:49:37 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 22:49:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-mgw in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d363d8923aa_2e5b10845fc26832@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-mgw failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 90s] [161/400] installing libosmocore12-1.1.0.91.eb57 [ 90s] Processing triggers for libc-bin (2.28-10) ... [ 90s] [162/400] installing libosp5-1.5.2-13+b1 [ 91s] Processing triggers for libc-bin (2.28-10) ... [ 91s] [163/400] installing libostyle1c2-1.4devel1-21.3+b1 [ 91s] Processing triggers for libc-bin (2.28-10) ... [ 91s] [164/400] installing libthai0-0.1.28-2 [ 91s] Processing triggers for libc-bin (2.28-10) ... [ 91s] [165/400] installing libuchardet0-0.0.6-3 [ 91s] Processing triggers for libc-bin (2.28-10) ... [ 91s] [166/400] installing libunwind8-1.2.1-9 [ 91s] Processing triggers for libc-bin (2.28-10) ... [ 92s] [167/400] installing python2.7-minimal-2.7.16-3 [ 92s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 93s] dpkg: error processing package python2.7-minimal (--install): [ 93s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 93s] Errors were encountered while processing: [ 93s] python2.7-minimal [ 93s] exit ... [ 93s] [ 93s] morla3 failed "build osmo-mgw_1.5.0.78.06a4.dsc" at Mon Jul 22 22:49:16 UTC 2019. [ 93s] [ 93s] ### VM INTERACTION START ### [ 96s] [ 65.576743] sysrq: SysRq : Power Off [ 96s] [ 65.885712] reboot: Power down [ 96s] ### VM INTERACTION END ### [ 96s] [ 96s] morla3 failed "build osmo-mgw_1.5.0.78.06a4.dsc" at Mon Jul 22 22:49:20 UTC 2019. [ 96s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 22:51:03 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 22:51:03 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hlr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d363de2b774f_2e5b10845fc2686de@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 58s] [163/411] installing libosmocore12-1.1.0.91.eb57 [ 58s] Processing triggers for libc-bin (2.28-10) ... [ 58s] [164/411] installing libosp5-1.5.2-13+b1 [ 58s] Processing triggers for libc-bin (2.28-10) ... [ 58s] [165/411] installing libostyle1c2-1.4devel1-21.3+b1 [ 59s] Processing triggers for libc-bin (2.28-10) ... [ 59s] [166/411] installing libthai0-0.1.28-2 [ 59s] Processing triggers for libc-bin (2.28-10) ... [ 59s] [167/411] installing libuchardet0-0.0.6-3 [ 59s] Processing triggers for libc-bin (2.28-10) ... [ 59s] [168/411] installing libunwind8-1.2.1-9 [ 59s] Processing triggers for libc-bin (2.28-10) ... [ 59s] [169/411] installing python2.7-minimal-2.7.16-3 [ 60s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 60s] dpkg: error processing package python2.7-minimal (--install): [ 60s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 60s] Errors were encountered while processing: [ 60s] python2.7-minimal [ 60s] exit ... [ 60s] [ 60s] lamb13 failed "build osmo-hlr_1.0.0.41.b64c.dsc" at Mon Jul 22 22:50:56 UTC 2019. [ 60s] [ 60s] ### VM INTERACTION START ### [ 63s] [ 43.581758] sysrq: SysRq : Power Off [ 63s] [ 43.597573] reboot: Power down [ 63s] ### VM INTERACTION END ### [ 63s] [ 63s] lamb13 failed "build osmo-hlr_1.0.0.41.b64c.dsc" at Mon Jul 22 22:51:00 UTC 2019. [ 63s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 22:53:03 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 22:53:03 +0000 Subject: Build failure of network:osmocom:latest/osmo-hlr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d363e589e616_2e5b10845fc2689d4@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-hlr/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-hlr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-hlr Last lines of build log: [ 54s] Processing triggers for libc-bin (2.28-10) ... [ 54s] [98/220] installing libc6-dev-2.28-10 [ 55s] [99/220] installing libhogweed4-3.4.1-1 [ 55s] Processing triggers for libc-bin (2.28-10) ... [ 55s] [100/220] installing libicu63-63.2-2 [ 57s] Processing triggers for libc-bin (2.28-10) ... [ 57s] [101/220] installing libmagic1-1:5.35-4 [ 57s] Processing triggers for libc-bin (2.28-10) ... [ 57s] [102/220] installing libuchardet0-0.0.6-3 [ 57s] Processing triggers for libc-bin (2.28-10) ... [ 57s] [103/220] installing libunwind8-1.2.1-9 [ 57s] Processing triggers for libc-bin (2.28-10) ... [ 57s] [104/220] installing python2.7-minimal-2.7.16-3 [ 58s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 58s] dpkg: error processing package python2.7-minimal (--install): [ 58s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 58s] Errors were encountered while processing: [ 58s] python2.7-minimal [ 58s] exit ... [ 58s] [ 58s] lamb12 failed "build osmo-hlr_1.0.0.dsc" at Mon Jul 22 22:52:51 UTC 2019. [ 58s] [ 58s] ### VM INTERACTION START ### [ 62s] [ 47.504181] sysrq: SysRq : Power Off [ 62s] [ 47.523012] reboot: Power down [ 62s] ### VM INTERACTION END ### [ 62s] [ 62s] lamb12 failed "build osmo-hlr_1.0.0.dsc" at Mon Jul 22 22:52:56 UTC 2019. [ 62s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 22:53:20 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 22:53:20 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d363e7896a6_2e5b10845fc269099@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 57s] [106/240] installing libhogweed4-3.4.1-1 [ 57s] Processing triggers for libc-bin (2.28-10) ... [ 57s] [107/240] installing libicu63-63.2-2 [ 59s] Processing triggers for libc-bin (2.28-10) ... [ 59s] [108/240] installing libmagic1-1:5.35-4 [ 59s] Processing triggers for libc-bin (2.28-10) ... [ 59s] [109/240] installing libosmocore12-1.1.0.91.eb57 [ 59s] Processing triggers for libc-bin (2.28-10) ... [ 59s] [110/240] installing libuchardet0-0.0.6-3 [ 59s] Processing triggers for libc-bin (2.28-10) ... [ 59s] [111/240] installing libunwind8-1.2.1-9 [ 59s] Processing triggers for libc-bin (2.28-10) ... [ 59s] [112/240] installing python2.7-minimal-2.7.16-3 [ 60s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 60s] dpkg: error processing package python2.7-minimal (--install): [ 60s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 60s] Errors were encountered while processing: [ 60s] python2.7-minimal [ 60s] exit ... [ 61s] [ 61s] morla5 failed "build osmo-iuh_0.4.0.11.3030.dsc" at Mon Jul 22 22:53:00 UTC 2019. [ 61s] [ 61s] ### VM INTERACTION START ### [ 64s] [ 47.402203] sysrq: SysRq : Power Off [ 64s] [ 47.419056] reboot: Power down [ 64s] ### VM INTERACTION END ### [ 64s] [ 64s] morla5 failed "build osmo-iuh_0.4.0.11.3030.dsc" at Mon Jul 22 22:53:04 UTC 2019. [ 64s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 22:55:54 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 22:55:54 +0000 Subject: Build failure of network:osmocom:nightly/osmo-ggsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d363f0e90f60_2e5b10845fc269450@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 52s] [163/406] installing libosmocore12-1.1.0.91.eb57 [ 52s] Processing triggers for libc-bin (2.28-10) ... [ 52s] [164/406] installing libosp5-1.5.2-13+b1 [ 52s] Processing triggers for libc-bin (2.28-10) ... [ 52s] [165/406] installing libostyle1c2-1.4devel1-21.3+b1 [ 52s] Processing triggers for libc-bin (2.28-10) ... [ 52s] [166/406] installing libthai0-0.1.28-2 [ 52s] Processing triggers for libc-bin (2.28-10) ... [ 52s] [167/406] installing libuchardet0-0.0.6-3 [ 52s] Processing triggers for libc-bin (2.28-10) ... [ 52s] [168/406] installing libunwind8-1.2.1-9 [ 52s] Processing triggers for libc-bin (2.28-10) ... [ 52s] [169/406] installing python2.7-minimal-2.7.16-3 [ 53s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 53s] dpkg: error processing package python2.7-minimal (--install): [ 53s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 53s] Errors were encountered while processing: [ 53s] python2.7-minimal [ 53s] exit ... [ 53s] [ 53s] lamb17 failed "build osmo-ggsn_1.3.0.47.f1e0.dsc" at Mon Jul 22 22:55:33 UTC 2019. [ 53s] [ 53s] ### VM INTERACTION START ### [ 56s] [ 37.699707] sysrq: SysRq : Power Off [ 56s] [ 37.707397] reboot: Power down [ 56s] ### VM INTERACTION END ### [ 56s] [ 56s] lamb17 failed "build osmo-ggsn_1.3.0.47.f1e0.dsc" at Mon Jul 22 22:55:38 UTC 2019. [ 56s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 22:58:12 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 22:58:12 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d363f88b5ed7_2e5b10845fc2696eb@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 26s] Processing triggers for libc-bin (2.28-10) ... [ 26s] [89/208] installing libbinutils-2.31.1-16 [ 26s] Processing triggers for libc-bin (2.28-10) ... [ 26s] [90/208] installing libc6-dev-2.28-10 [ 27s] [91/208] installing libicu63-63.2-2 [ 28s] Processing triggers for libc-bin (2.28-10) ... [ 28s] [92/208] installing libmagic1-1:5.35-4 [ 28s] Processing triggers for libc-bin (2.28-10) ... [ 28s] [93/208] installing libuchardet0-0.0.6-3 [ 28s] Processing triggers for libc-bin (2.28-10) ... [ 28s] [94/208] installing libunwind8-1.2.1-9 [ 28s] Processing triggers for libc-bin (2.28-10) ... [ 28s] [95/208] installing python2.7-minimal-2.7.16-3 [ 29s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 29s] dpkg: error processing package python2.7-minimal (--install): [ 29s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 29s] Errors were encountered while processing: [ 29s] python2.7-minimal [ 29s] exit ... [ 29s] [ 29s] sheep83 failed "build osmo-python-tests_0.0.9.20190722.dsc" at Mon Jul 22 22:57:57 UTC 2019. [ 29s] [ 29s] ### VM INTERACTION START ### [ 32s] [ 22.024732] sysrq: SysRq : Power Off [ 32s] [ 22.029822] reboot: Power down [ 32s] ### VM INTERACTION END ### [ 32s] [ 32s] sheep83 failed "build osmo-python-tests_0.0.9.20190722.dsc" at Mon Jul 22 22:58:00 UTC 2019. [ 32s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 23:00:29 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 23:00:29 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d36401e70eac_2e5b10845fc2701a6@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 38s] [163/410] installing libosmocore12-1.1.0.91.eb57 [ 38s] Processing triggers for libc-bin (2.28-10) ... [ 38s] [164/410] installing libosp5-1.5.2-13+b1 [ 38s] Processing triggers for libc-bin (2.28-10) ... [ 38s] [165/410] installing libostyle1c2-1.4devel1-21.3+b1 [ 39s] Processing triggers for libc-bin (2.28-10) ... [ 39s] [166/410] installing libthai0-0.1.28-2 [ 39s] Processing triggers for libc-bin (2.28-10) ... [ 39s] [167/410] installing libuchardet0-0.0.6-3 [ 39s] Processing triggers for libc-bin (2.28-10) ... [ 39s] [168/410] installing libunwind8-1.2.1-9 [ 39s] Processing triggers for libc-bin (2.28-10) ... [ 39s] [169/410] installing python2.7-minimal-2.7.16-3 [ 39s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 39s] dpkg: error processing package python2.7-minimal (--install): [ 39s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 39s] Errors were encountered while processing: [ 39s] python2.7-minimal [ 39s] exit ... [ 39s] [ 39s] sheep84 failed "build osmo-bts_0.8.1.352.aa54.dsc" at Mon Jul 22 23:00:11 UTC 2019. [ 39s] [ 39s] ### VM INTERACTION START ### [ 43s] [ 30.426620] sysrq: SysRq : Power Off [ 43s] [ 30.432615] reboot: Power down [ 43s] ### VM INTERACTION END ### [ 43s] [ 43s] sheep84 failed "build osmo-bts_0.8.1.352.aa54.dsc" at Mon Jul 22 23:00:15 UTC 2019. [ 43s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 23:02:28 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 23:02:28 +0000 Subject: Build failure of network:osmocom:latest/osmo-bsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d364093776d3_2e5b10845fc270425@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-bsc/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-bsc Last lines of build log: [ 34s] Processing triggers for libc-bin (2.28-10) ... [ 34s] [98/224] installing libc6-dev-2.28-10 [ 35s] [99/224] installing libhogweed4-3.4.1-1 [ 35s] Processing triggers for libc-bin (2.28-10) ... [ 35s] [100/224] installing libicu63-63.2-2 [ 36s] Processing triggers for libc-bin (2.28-10) ... [ 36s] [101/224] installing libmagic1-1:5.35-4 [ 36s] Processing triggers for libc-bin (2.28-10) ... [ 36s] [102/224] installing libuchardet0-0.0.6-3 [ 36s] Processing triggers for libc-bin (2.28-10) ... [ 36s] [103/224] installing libunwind8-1.2.1-9 [ 36s] Processing triggers for libc-bin (2.28-10) ... [ 36s] [104/224] installing python2.7-minimal-2.7.16-3 [ 37s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 37s] dpkg: error processing package python2.7-minimal (--install): [ 37s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 37s] Errors were encountered while processing: [ 37s] python2.7-minimal [ 37s] exit ... [ 37s] [ 37s] lamb18 failed "build osmo-bsc_1.4.1.dsc" at Mon Jul 22 23:02:12 UTC 2019. [ 37s] [ 37s] ### VM INTERACTION START ### [ 40s] [ 25.058586] sysrq: SysRq : Power Off [ 40s] [ 25.065147] reboot: Power down [ 40s] ### VM INTERACTION END ### [ 40s] [ 40s] lamb18 failed "build osmo-bsc_1.4.1.dsc" at Mon Jul 22 23:02:16 UTC 2019. [ 40s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 23:02:45 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 23:02:45 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcu in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d3640b290f0d_2e5b10845fc27051e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 139s] [160/398] installing libosmocore12-1.1.0.91.eb57 [ 139s] Processing triggers for libc-bin (2.28-10) ... [ 139s] [161/398] installing libosp5-1.5.2-13+b1 [ 140s] Processing triggers for libc-bin (2.28-10) ... [ 140s] [162/398] installing libostyle1c2-1.4devel1-21.3+b1 [ 140s] Processing triggers for libc-bin (2.28-10) ... [ 141s] [163/398] installing libthai0-0.1.28-2 [ 141s] Processing triggers for libc-bin (2.28-10) ... [ 141s] [164/398] installing libuchardet0-0.0.6-3 [ 141s] Processing triggers for libc-bin (2.28-10) ... [ 141s] [165/398] installing libunwind8-1.2.1-9 [ 142s] Processing triggers for libc-bin (2.28-10) ... [ 142s] [166/398] installing python2.7-minimal-2.7.16-3 [ 143s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 143s] dpkg: error processing package python2.7-minimal (--install): [ 143s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 143s] Errors were encountered while processing: [ 143s] python2.7-minimal [ 143s] exit ... [ 143s] [ 143s] lamb60 failed "build osmo-pcu_0.6.0.82.7b7f2.dsc" at Mon Jul 22 23:02:31 UTC 2019. [ 143s] [ 143s] ### VM INTERACTION START ### [ 146s] [ 99.592696] sysrq: SysRq : Power Off [ 147s] [ 99.622869] reboot: Power down [ 147s] ### VM INTERACTION END ### [ 147s] [ 147s] lamb60 failed "build osmo-pcu_0.6.0.82.7b7f2.dsc" at Mon Jul 22 23:02:35 UTC 2019. [ 147s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 23:04:11 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 23:04:11 +0000 Subject: Build failure of network:osmocom:latest/osmo-gsm-manuals in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d3640efb92c4_2e5b10845fc27094e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-gsm-manuals/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-gsm-manuals failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-gsm-manuals Last lines of build log: [ 116s] [156/382] installing libmagic1-1:5.35-4 [ 117s] Processing triggers for libc-bin (2.28-10) ... [ 117s] [157/382] installing libosp5-1.5.2-13+b1 [ 117s] Processing triggers for libc-bin (2.28-10) ... [ 117s] [158/382] installing libostyle1c2-1.4devel1-21.3+b1 [ 117s] Processing triggers for libc-bin (2.28-10) ... [ 117s] [159/382] installing libthai0-0.1.28-2 [ 117s] Processing triggers for libc-bin (2.28-10) ... [ 117s] [160/382] installing libuchardet0-0.0.6-3 [ 118s] Processing triggers for libc-bin (2.28-10) ... [ 118s] [161/382] installing libunwind8-1.2.1-9 [ 118s] Processing triggers for libc-bin (2.28-10) ... [ 118s] [162/382] installing python2.7-minimal-2.7.16-3 [ 119s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 119s] dpkg: error processing package python2.7-minimal (--install): [ 119s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 119s] Errors were encountered while processing: [ 119s] python2.7-minimal [ 119s] exit ... [ 119s] [ 119s] cloud115 failed "build osmo-gsm-manuals-dev_0.1.1.dsc" at Mon Jul 22 23:03:58 UTC 2019. [ 119s] [ 119s] ### VM INTERACTION START ### [ 122s] [ 70.084076] sysrq: SysRq : Power Off [ 122s] [ 70.147532] reboot: Power down [ 124s] ### VM INTERACTION END ### [ 124s] [ 124s] cloud115 failed "build osmo-gsm-manuals-dev_0.1.1.dsc" at Mon Jul 22 23:04:04 UTC 2019. [ 124s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 23:05:02 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 23:05:02 +0000 Subject: Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d36412968a25_2e5b10845fc271060@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 63s] [190/559] installing libosmocore12-1.1.0.91.eb57 [ 63s] Processing triggers for libc-bin (2.28-10) ... [ 63s] [191/559] installing libosp5-1.5.2-13+b1 [ 63s] Processing triggers for libc-bin (2.28-10) ... [ 63s] [192/559] installing libostyle1c2-1.4devel1-21.3+b1 [ 63s] Processing triggers for libc-bin (2.28-10) ... [ 63s] [193/559] installing libthai0-0.1.28-2 [ 64s] Processing triggers for libc-bin (2.28-10) ... [ 64s] [194/559] installing libuchardet0-0.0.6-3 [ 64s] Processing triggers for libc-bin (2.28-10) ... [ 64s] [195/559] installing libunwind8-1.2.1-9 [ 64s] Processing triggers for libc-bin (2.28-10) ... [ 64s] [196/559] installing python2.7-minimal-2.7.16-3 [ 65s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 65s] dpkg: error processing package python2.7-minimal (--install): [ 65s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 65s] Errors were encountered while processing: [ 65s] python2.7-minimal [ 65s] exit ... [ 65s] [ 65s] lamb27 failed "build osmo-trx_1.0.0.81.2896.dsc" at Mon Jul 22 23:04:56 UTC 2019. [ 65s] [ 65s] ### VM INTERACTION START ### [ 68s] [ 47.364839] sysrq: SysRq : Power Off [ 68s] [ 47.381392] reboot: Power down [ 68s] ### VM INTERACTION END ### [ 68s] [ 68s] lamb27 failed "build osmo-trx_1.0.0.81.2896.dsc" at Mon Jul 22 23:05:00 UTC 2019. [ 68s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 23:07:19 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 23:07:19 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sip-connector in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d3641bf44fc6_2e5b10845fc271417@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sip-connector failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 49s] [164/419] installing libosmocore12-1.1.0.91.eb57 [ 50s] Processing triggers for libc-bin (2.28-10) ... [ 50s] [165/419] installing libosp5-1.5.2-13+b1 [ 50s] Processing triggers for libc-bin (2.28-10) ... [ 50s] [166/419] installing libostyle1c2-1.4devel1-21.3+b1 [ 50s] Processing triggers for libc-bin (2.28-10) ... [ 50s] [167/419] installing libthai0-0.1.28-2 [ 50s] Processing triggers for libc-bin (2.28-10) ... [ 50s] [168/419] installing libuchardet0-0.0.6-3 [ 50s] Processing triggers for libc-bin (2.28-10) ... [ 50s] [169/419] installing libunwind8-1.2.1-9 [ 50s] Processing triggers for libc-bin (2.28-10) ... [ 50s] [170/419] installing python2.7-minimal-2.7.16-3 [ 51s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 51s] dpkg: error processing package python2.7-minimal (--install): [ 51s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 51s] Errors were encountered while processing: [ 51s] python2.7-minimal [ 51s] exit ... [ 51s] [ 51s] lamb18 failed "build osmo-sip-connector_1.2.0.9.a35a.dsc" at Mon Jul 22 23:07:04 UTC 2019. [ 51s] [ 51s] ### VM INTERACTION START ### [ 54s] [ 36.122171] sysrq: SysRq : Power Off [ 54s] [ 36.133811] reboot: Power down [ 54s] ### VM INTERACTION END ### [ 54s] [ 54s] lamb18 failed "build osmo-sip-connector_1.2.0.9.a35a.dsc" at Mon Jul 22 23:07:07 UTC 2019. [ 54s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 23:09:03 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 23:09:03 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d36421aa0d75_2e5b10845fc2717ea@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 64s] [170/425] installing libosmocore12-1.1.0.91.eb57 [ 64s] Processing triggers for libc-bin (2.28-10) ... [ 64s] [171/425] installing libosp5-1.5.2-13+b1 [ 64s] Processing triggers for libc-bin (2.28-10) ... [ 64s] [172/425] installing libostyle1c2-1.4devel1-21.3+b1 [ 64s] Processing triggers for libc-bin (2.28-10) ... [ 64s] [173/425] installing libthai0-0.1.28-2 [ 64s] Processing triggers for libc-bin (2.28-10) ... [ 64s] [174/425] installing libuchardet0-0.0.6-3 [ 64s] Processing triggers for libc-bin (2.28-10) ... [ 64s] [175/425] installing libunwind8-1.2.1-9 [ 65s] Processing triggers for libc-bin (2.28-10) ... [ 65s] [176/425] installing python2.7-minimal-2.7.16-3 [ 65s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 65s] dpkg: error processing package python2.7-minimal (--install): [ 65s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 65s] Errors were encountered while processing: [ 65s] python2.7-minimal [ 65s] exit ... [ 65s] [ 65s] morla3 failed "build osmo-msc_1.3.1.180.efa7.dsc" at Mon Jul 22 23:08:49 UTC 2019. [ 65s] [ 65s] ### VM INTERACTION START ### [ 68s] [ 46.170660] sysrq: SysRq : Power Off [ 68s] [ 46.178393] reboot: Power down [ 69s] ### VM INTERACTION END ### [ 69s] [ 69s] morla3 failed "build osmo-msc_1.3.1.180.efa7.dsc" at Mon Jul 22 23:08:53 UTC 2019. [ 69s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 23:09:20 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 23:09:20 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d36423946218_2e5b10845fc271829@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 77s] [164/416] installing libosmocore12-1.1.0.91.eb57 [ 77s] Processing triggers for libc-bin (2.28-10) ... [ 77s] [165/416] installing libosp5-1.5.2-13+b1 [ 77s] Processing triggers for libc-bin (2.28-10) ... [ 78s] [166/416] installing libostyle1c2-1.4devel1-21.3+b1 [ 78s] Processing triggers for libc-bin (2.28-10) ... [ 78s] [167/416] installing libthai0-0.1.28-2 [ 78s] Processing triggers for libc-bin (2.28-10) ... [ 78s] [168/416] installing libuchardet0-0.0.6-3 [ 78s] Processing triggers for libc-bin (2.28-10) ... [ 78s] [169/416] installing libunwind8-1.2.1-9 [ 78s] Processing triggers for libc-bin (2.28-10) ... [ 79s] [170/416] installing python2.7-minimal-2.7.16-3 [ 79s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 79s] dpkg: error processing package python2.7-minimal (--install): [ 79s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 79s] Errors were encountered while processing: [ 79s] python2.7-minimal [ 79s] exit ... [ 79s] [ 79s] lamb24 failed "build osmo-bsc_1.4.0.104.7fbcc.dsc" at Mon Jul 22 23:09:00 UTC 2019. [ 79s] [ 79s] ### VM INTERACTION START ### [ 83s] [ 53.700286] sysrq: SysRq : Power Off [ 83s] [ 53.730390] reboot: Power down [ 83s] ### VM INTERACTION END ### [ 83s] [ 83s] lamb24 failed "build osmo-bsc_1.4.0.104.7fbcc.dsc" at Mon Jul 22 23:09:04 UTC 2019. [ 83s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Jul 22 23:10:23 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 22 Jul 2019 23:10:23 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Store TRXD version per channel In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14897 ) Change subject: Transceiver: Store TRXD version per channel ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9cf95e89d38d0155ab48b8c0977ca5f381c2aad Gerrit-Change-Number: 14897 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 23:10:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Mon Jul 22 23:13:37 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 23:13:37 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d3643298fdd6_2e5b10845fc272268@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 77s] [167/422] installing libosmocore12-1.1.0.91.eb57 [ 77s] Processing triggers for libc-bin (2.28-10) ... [ 77s] [168/422] installing libosp5-1.5.2-13+b1 [ 77s] Processing triggers for libc-bin (2.28-10) ... [ 77s] [169/422] installing libostyle1c2-1.4devel1-21.3+b1 [ 78s] Processing triggers for libc-bin (2.28-10) ... [ 78s] [170/422] installing libthai0-0.1.28-2 [ 78s] Processing triggers for libc-bin (2.28-10) ... [ 78s] [171/422] installing libuchardet0-0.0.6-3 [ 78s] Processing triggers for libc-bin (2.28-10) ... [ 78s] [172/422] installing libunwind8-1.2.1-9 [ 78s] Processing triggers for libc-bin (2.28-10) ... [ 78s] [173/422] installing python2.7-minimal-2.7.16-3 [ 79s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 79s] dpkg: error processing package python2.7-minimal (--install): [ 79s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 79s] Errors were encountered while processing: [ 79s] python2.7-minimal [ 79s] exit ... [ 79s] [ 79s] lamb59 failed "build osmo-sgsn_1.4.0.30.4b8e.dsc" at Mon Jul 22 23:13:19 UTC 2019. [ 79s] [ 79s] ### VM INTERACTION START ### [ 82s] [ 62.883645] sysrq: SysRq : Power Off [ 82s] [ 62.891759] reboot: Power down [ 82s] ### VM INTERACTION END ### [ 82s] [ 82s] lamb59 failed "build osmo-sgsn_1.4.0.30.4b8e.dsc" at Mon Jul 22 23:13:22 UTC 2019. [ 82s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 22 23:16:12 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 22 Jul 2019 23:16:12 +0000 Subject: Build failure of network:osmocom:latest/osmo-trx in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d3643c08fbdd_2e5b10845fc27267b@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:latest/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:latest osmo-trx Last lines of build log: [ 137s] [130/389] installing libhogweed4-3.4.1-1 [ 137s] Processing triggers for libc-bin (2.28-10) ... [ 137s] [131/389] installing libhwloc5-1.11.12-3 [ 137s] Processing triggers for libc-bin (2.28-10) ... [ 137s] [132/389] installing libicu63-63.2-2 [ 145s] Processing triggers for libc-bin (2.28-10) ... [ 145s] [133/389] installing libmagic1-1:5.35-4 [ 145s] Processing triggers for libc-bin (2.28-10) ... [ 145s] [134/389] installing libuchardet0-0.0.6-3 [ 145s] Processing triggers for libc-bin (2.28-10) ... [ 145s] [135/389] installing libunwind8-1.2.1-9 [ 145s] Processing triggers for libc-bin (2.28-10) ... [ 145s] [136/389] installing python2.7-minimal-2.7.16-3 [ 146s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 146s] dpkg: error processing package python2.7-minimal (--install): [ 146s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 146s] Errors were encountered while processing: [ 146s] python2.7-minimal [ 146s] exit ... [ 146s] [ 146s] cloud111 failed "build osmo-trx_1.0.0.dsc" at Mon Jul 22 23:15:58 UTC 2019. [ 146s] [ 146s] ### VM INTERACTION START ### [ 149s] [ 91.842701] sysrq: SysRq : Power Off [ 149s] [ 91.882074] reboot: Power down [ 150s] ### VM INTERACTION END ### [ 150s] [ 150s] cloud111 failed "build osmo-trx_1.0.0.dsc" at Mon Jul 22 23:16:03 UTC 2019. [ 150s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Jul 22 23:38:42 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Mon, 22 Jul 2019 23:38:42 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Clean up code passing parameters to threads In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14898 ) Change subject: Transceiver: Clean up code passing parameters to threads ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14898/1/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/14898/1/Transceiver52M/Transceiver.cpp at 241 PS1, Line 241: malloc I am wondering, can we use static allocation here and simply pass a pointer to the stack? Or is there a chance of the race-condition? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6e3898a8a66520cc5b2a7df9b9ae01b0b272387f Gerrit-Change-Number: 14898 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 22 Jul 2019 23:38:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Tue Jul 23 02:32:46 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 02:32:46 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d3671ec8a541_2e5b10845fc2948c8@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 37s] [156/382] installing libmagic1-1:5.35-4 [ 37s] Processing triggers for libc-bin (2.28-10) ... [ 37s] [157/382] installing libosp5-1.5.2-13+b1 [ 37s] Processing triggers for libc-bin (2.28-10) ... [ 37s] [158/382] installing libostyle1c2-1.4devel1-21.3+b1 [ 38s] Processing triggers for libc-bin (2.28-10) ... [ 38s] [159/382] installing libthai0-0.1.28-2 [ 38s] Processing triggers for libc-bin (2.28-10) ... [ 38s] [160/382] installing libuchardet0-0.0.6-3 [ 38s] Processing triggers for libc-bin (2.28-10) ... [ 38s] [161/382] installing libunwind8-1.2.1-9 [ 38s] Processing triggers for libc-bin (2.28-10) ... [ 38s] [162/382] installing python2.7-minimal-2.7.16-3 [ 38s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 38s] dpkg: error processing package python2.7-minimal (--install): [ 38s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 38s] Errors were encountered while processing: [ 38s] python2.7-minimal [ 38s] exit ... [ 38s] [ 38s] sheep83 failed "build osmo-gsm-manuals-dev_0.1.1.4.c197.dsc" at Tue Jul 23 02:32:41 UTC 2019. [ 38s] [ 38s] ### VM INTERACTION START ### [ 42s] [ 29.888881] sysrq: SysRq : Power Off [ 42s] [ 29.895581] reboot: Power down [ 42s] ### VM INTERACTION END ### [ 42s] [ 42s] sheep83 failed "build osmo-gsm-manuals-dev_0.1.1.4.c197.dsc" at Tue Jul 23 02:32:45 UTC 2019. [ 42s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 02:33:37 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 02:33:37 +0000 Subject: Build failure of network:osmocom:nightly/libosmocore in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d367209d228d_2e5b10845fc2951ae@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmocore failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of build log: [ 42s] [106/239] installing libedit2-3.1-20190324-1 [ 42s] Processing triggers for libc-bin (2.28-10) ... [ 42s] [107/239] installing libhogweed4-3.4.1-1 [ 42s] Processing triggers for libc-bin (2.28-10) ... [ 43s] [108/239] installing libicu63-63.2-2 [ 44s] Processing triggers for libc-bin (2.28-10) ... [ 44s] [109/239] installing libmagic1-1:5.35-4 [ 44s] Processing triggers for libc-bin (2.28-10) ... [ 44s] [110/239] installing libuchardet0-0.0.6-3 [ 44s] Processing triggers for libc-bin (2.28-10) ... [ 44s] [111/239] installing libunwind8-1.2.1-9 [ 44s] Processing triggers for libc-bin (2.28-10) ... [ 44s] [112/239] installing python2.7-minimal-2.7.16-3 [ 45s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 45s] dpkg: error processing package python2.7-minimal (--install): [ 45s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 45s] Errors were encountered while processing: [ 45s] python2.7-minimal [ 45s] exit ... [ 45s] [ 45s] lamb51 failed "build libosmocore_1.1.0.91.eb57.dsc" at Tue Jul 23 02:33:22 UTC 2019. [ 45s] [ 45s] ### VM INTERACTION START ### [ 48s] [ 31.099994] sysrq: SysRq : Power Off [ 48s] [ 31.106625] reboot: Power down [ 48s] ### VM INTERACTION END ### [ 48s] [ 48s] lamb51 failed "build libosmocore_1.1.0.91.eb57.dsc" at Tue Jul 23 02:33:26 UTC 2019. [ 48s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 02:47:19 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 02:47:19 +0000 Subject: Build failure of network:osmocom:nightly/libusrp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d3675505a400_2e5b10845fc29763e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libusrp/Debian_Testing/x86_64 Package network:osmocom:nightly/libusrp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libusrp Last lines of build log: [ 150s] [119/363] installing libedit2-3.1-20190324-1 [ 150s] Processing triggers for libc-bin (2.28-10) ... [ 150s] [120/363] installing libhwloc5-1.11.12-3 [ 150s] Processing triggers for libc-bin (2.28-10) ... [ 150s] [121/363] installing libicu63-63.2-2 [ 152s] Processing triggers for libc-bin (2.28-10) ... [ 152s] [122/363] installing libmagic1-1:5.35-4 [ 152s] Processing triggers for libc-bin (2.28-10) ... [ 152s] [123/363] installing libuchardet0-0.0.6-3 [ 152s] Processing triggers for libc-bin (2.28-10) ... [ 153s] [124/363] installing libunwind8-1.2.1-9 [ 153s] Processing triggers for libc-bin (2.28-10) ... [ 153s] [125/363] installing python2.7-minimal-2.7.16-3 [ 154s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 154s] dpkg: error processing package python2.7-minimal (--install): [ 154s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 154s] Errors were encountered while processing: [ 154s] python2.7-minimal [ 154s] exit ... [ 154s] [ 154s] cloud113 failed "build libusrp_3.4.2.20190723.dsc" at Tue Jul 23 02:46:55 UTC 2019. [ 154s] [ 154s] ### VM INTERACTION START ### [ 157s] [ 59.681646] sysrq: SysRq : Power Off [ 157s] [ 59.788285] reboot: Power down [ 164s] ### VM INTERACTION END ### [ 164s] [ 164s] cloud113 failed "build libusrp_3.4.2.20190723.dsc" at Tue Jul 23 02:47:06 UTC 2019. [ 164s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 02:47:19 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 02:47:19 +0000 Subject: Build failure of network:osmocom:nightly/osmo-ggsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d367550ce1d7_2e5b10845fc297780@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-ggsn/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-ggsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-ggsn Last lines of build log: [ 31s] [163/406] installing libosmocore12-1.1.0.91.eb57 [ 31s] Processing triggers for libc-bin (2.28-10) ... [ 31s] [164/406] installing libosp5-1.5.2-13+b1 [ 31s] Processing triggers for libc-bin (2.28-10) ... [ 31s] [165/406] installing libostyle1c2-1.4devel1-21.3+b1 [ 31s] Processing triggers for libc-bin (2.28-10) ... [ 31s] [166/406] installing libthai0-0.1.28-2 [ 31s] Processing triggers for libc-bin (2.28-10) ... [ 31s] [167/406] installing libuchardet0-0.0.6-3 [ 31s] Processing triggers for libc-bin (2.28-10) ... [ 31s] [168/406] installing libunwind8-1.2.1-9 [ 31s] Processing triggers for libc-bin (2.28-10) ... [ 31s] [169/406] installing python2.7-minimal-2.7.16-3 [ 32s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 32s] dpkg: error processing package python2.7-minimal (--install): [ 32s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 32s] Errors were encountered while processing: [ 32s] python2.7-minimal [ 32s] exit ... [ 32s] [ 32s] build80 failed "build osmo-ggsn_1.3.0.47.f1e0.dsc" at Tue Jul 23 02:47:07 UTC 2019. [ 32s] [ 32s] ### VM INTERACTION START ### [ 35s] [ 23.721567] sysrq: SysRq : Power Off [ 35s] [ 23.723147] reboot: Power down [ 35s] ### VM INTERACTION END ### [ 35s] [ 35s] build80 failed "build osmo-ggsn_1.3.0.47.f1e0.dsc" at Tue Jul 23 02:47:11 UTC 2019. [ 35s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 02:53:36 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 02:53:36 +0000 Subject: Build failure of network:osmocom:nightly/osmo-mgw in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d3676ba23b56_2e5b10845fc2991ea@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-mgw failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-mgw Last lines of build log: [ 46s] [161/400] installing libosmocore12-1.1.0.91.eb57 [ 47s] Processing triggers for libc-bin (2.28-10) ... [ 47s] [162/400] installing libosp5-1.5.2-13+b1 [ 47s] Processing triggers for libc-bin (2.28-10) ... [ 47s] [163/400] installing libostyle1c2-1.4devel1-21.3+b1 [ 47s] Processing triggers for libc-bin (2.28-10) ... [ 47s] [164/400] installing libthai0-0.1.28-2 [ 47s] Processing triggers for libc-bin (2.28-10) ... [ 47s] [165/400] installing libuchardet0-0.0.6-3 [ 47s] Processing triggers for libc-bin (2.28-10) ... [ 47s] [166/400] installing libunwind8-1.2.1-9 [ 47s] Processing triggers for libc-bin (2.28-10) ... [ 47s] [167/400] installing python2.7-minimal-2.7.16-3 [ 48s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 48s] dpkg: error processing package python2.7-minimal (--install): [ 48s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 48s] Errors were encountered while processing: [ 48s] python2.7-minimal [ 48s] exit ... [ 48s] [ 48s] lamb17 failed "build osmo-mgw_1.5.0.79.199c5.dsc" at Tue Jul 23 02:53:17 UTC 2019. [ 48s] [ 48s] ### VM INTERACTION START ### [ 51s] [ 34.871150] sysrq: SysRq : Power Off [ 51s] [ 34.890389] reboot: Power down [ 51s] ### VM INTERACTION END ### [ 51s] [ 51s] lamb17 failed "build osmo-mgw_1.5.0.79.199c5.dsc" at Tue Jul 23 02:53:20 UTC 2019. [ 51s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 02:53:36 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 02:53:36 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-sccp in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d3676ba6d7d9_2e5b10845fc299288@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-sccp/Debian_Testing/x86_64 Package network:osmocom:nightly/libosmo-sccp failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly libosmo-sccp Last lines of build log: [ 55s] [165/415] installing libosmocore12-1.1.0.91.eb57 [ 55s] Processing triggers for libc-bin (2.28-10) ... [ 55s] [166/415] installing libosp5-1.5.2-13+b1 [ 56s] Processing triggers for libc-bin (2.28-10) ... [ 56s] [167/415] installing libostyle1c2-1.4devel1-21.3+b1 [ 56s] Processing triggers for libc-bin (2.28-10) ... [ 56s] [168/415] installing libthai0-0.1.28-2 [ 56s] Processing triggers for libc-bin (2.28-10) ... [ 56s] [169/415] installing libuchardet0-0.0.6-3 [ 56s] Processing triggers for libc-bin (2.28-10) ... [ 56s] [170/415] installing libunwind8-1.2.1-9 [ 56s] Processing triggers for libc-bin (2.28-10) ... [ 56s] [171/415] installing python2.7-minimal-2.7.16-3 [ 57s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 57s] dpkg: error processing package python2.7-minimal (--install): [ 57s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 57s] Errors were encountered while processing: [ 57s] python2.7-minimal [ 57s] exit ... [ 57s] [ 57s] morla5 failed "build libosmo-sccp_1.0.0.25.2164.dsc" at Tue Jul 23 02:53:17 UTC 2019. [ 57s] [ 57s] ### VM INTERACTION START ### [ 60s] [ 41.063186] sysrq: SysRq : Power Off [ 60s] [ 41.070070] reboot: Power down [ 60s] ### VM INTERACTION END ### [ 60s] [ 60s] morla5 failed "build libosmo-sccp_1.0.0.25.2164.dsc" at Tue Jul 23 02:53:20 UTC 2019. [ 60s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 02:57:20 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 02:57:20 +0000 Subject: Build failure of network:osmocom:nightly/osmo-hlr in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d3677a77301c_2e5b10845fc29997c@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-hlr/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-hlr failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hlr Last lines of build log: [ 72s] [163/411] installing libosmocore12-1.1.0.91.eb57 [ 72s] Processing triggers for libc-bin (2.28-10) ... [ 72s] [164/411] installing libosp5-1.5.2-13+b1 [ 72s] Processing triggers for libc-bin (2.28-10) ... [ 72s] [165/411] installing libostyle1c2-1.4devel1-21.3+b1 [ 73s] Processing triggers for libc-bin (2.28-10) ... [ 73s] [166/411] installing libthai0-0.1.28-2 [ 73s] Processing triggers for libc-bin (2.28-10) ... [ 73s] [167/411] installing libuchardet0-0.0.6-3 [ 73s] Processing triggers for libc-bin (2.28-10) ... [ 73s] [168/411] installing libunwind8-1.2.1-9 [ 73s] Processing triggers for libc-bin (2.28-10) ... [ 73s] [169/411] installing python2.7-minimal-2.7.16-3 [ 74s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 74s] dpkg: error processing package python2.7-minimal (--install): [ 74s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 74s] Errors were encountered while processing: [ 74s] python2.7-minimal [ 74s] exit ... [ 74s] [ 74s] lamb60 failed "build osmo-hlr_1.0.0.41.b64c.dsc" at Tue Jul 23 02:57:10 UTC 2019. [ 74s] [ 74s] ### VM INTERACTION START ### [ 77s] [ 58.171011] sysrq: SysRq : Power Off [ 78s] [ 58.178696] reboot: Power down [ 78s] ### VM INTERACTION END ### [ 78s] [ 78s] lamb60 failed "build osmo-hlr_1.0.0.41.b64c.dsc" at Tue Jul 23 02:57:14 UTC 2019. [ 78s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 02:59:53 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 02:59:53 +0000 Subject: Build failure of network:osmocom:nightly/osmo-iuh in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d3678404ac2d_2e5b10845fc300192@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-iuh/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-iuh failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-iuh Last lines of build log: [ 44s] [106/240] installing libhogweed4-3.4.1-1 [ 44s] Processing triggers for libc-bin (2.28-10) ... [ 44s] [107/240] installing libicu63-63.2-2 [ 69s] Processing triggers for libc-bin (2.28-10) ... [ 69s] [108/240] installing libmagic1-1:5.35-4 [ 69s] Processing triggers for libc-bin (2.28-10) ... [ 69s] [109/240] installing libosmocore12-1.1.0.91.eb57 [ 70s] Processing triggers for libc-bin (2.28-10) ... [ 70s] [110/240] installing libuchardet0-0.0.6-3 [ 70s] Processing triggers for libc-bin (2.28-10) ... [ 70s] [111/240] installing libunwind8-1.2.1-9 [ 70s] Processing triggers for libc-bin (2.28-10) ... [ 70s] [112/240] installing python2.7-minimal-2.7.16-3 [ 71s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 71s] dpkg: error processing package python2.7-minimal (--install): [ 71s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 71s] Errors were encountered while processing: [ 71s] python2.7-minimal [ 71s] exit ... [ 71s] [ 71s] cloud118 failed "build osmo-iuh_0.4.0.11.3030.dsc" at Tue Jul 23 02:59:32 UTC 2019. [ 71s] [ 71s] ### VM INTERACTION START ### [ 74s] [ 54.256266] sysrq: SysRq : Power Off [ 74s] [ 54.262674] reboot: Power down [ 74s] ### VM INTERACTION END ### [ 74s] [ 74s] cloud118 failed "build osmo-iuh_0.4.0.11.3030.dsc" at Tue Jul 23 02:59:35 UTC 2019. [ 74s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 03:02:11 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 03:02:11 +0000 Subject: Build failure of network:osmocom:nightly/osmo-pcu in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d3678b78edf1_2e5b10845fc30029f@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [ 72s] [160/398] installing libosmocore12-1.1.0.91.eb57 [ 72s] Processing triggers for libc-bin (2.28-10) ... [ 72s] [161/398] installing libosp5-1.5.2-13+b1 [ 73s] Processing triggers for libc-bin (2.28-10) ... [ 73s] [162/398] installing libostyle1c2-1.4devel1-21.3+b1 [ 73s] Processing triggers for libc-bin (2.28-10) ... [ 73s] [163/398] installing libthai0-0.1.28-2 [ 73s] Processing triggers for libc-bin (2.28-10) ... [ 73s] [164/398] installing libuchardet0-0.0.6-3 [ 73s] Processing triggers for libc-bin (2.28-10) ... [ 73s] [165/398] installing libunwind8-1.2.1-9 [ 73s] Processing triggers for libc-bin (2.28-10) ... [ 73s] [166/398] installing python2.7-minimal-2.7.16-3 [ 74s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 74s] dpkg: error processing package python2.7-minimal (--install): [ 74s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 74s] Errors were encountered while processing: [ 74s] python2.7-minimal [ 74s] exit ... [ 74s] [ 74s] build33 failed "build osmo-pcu_0.6.0.82.7b7f2.dsc" at Tue Jul 23 03:01:57 UTC 2019. [ 74s] [ 74s] ### VM INTERACTION START ### [ 77s] [ 49.228274] sysrq: SysRq : Power Off [ 78s] [ 49.290020] reboot: Power down [ 79s] ### VM INTERACTION END ### [ 79s] [ 79s] build33 failed "build osmo-pcu_0.6.0.82.7b7f2.dsc" at Tue Jul 23 03:02:03 UTC 2019. [ 79s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 03:08:11 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 03:08:11 +0000 Subject: Build failure of network:osmocom:nightly/osmo-python-tests in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d367a1d4083e_2e5b10845fc30079@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-python-tests/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-python-tests failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-python-tests Last lines of build log: [ 65s] Processing triggers for libc-bin (2.28-10) ... [ 65s] [89/208] installing libbinutils-2.31.1-16 [ 66s] Processing triggers for libc-bin (2.28-10) ... [ 66s] [90/208] installing libc6-dev-2.28-10 [ 67s] [91/208] installing libicu63-63.2-2 [ 69s] Processing triggers for libc-bin (2.28-10) ... [ 69s] [92/208] installing libmagic1-1:5.35-4 [ 69s] Processing triggers for libc-bin (2.28-10) ... [ 69s] [93/208] installing libuchardet0-0.0.6-3 [ 69s] Processing triggers for libc-bin (2.28-10) ... [ 69s] [94/208] installing libunwind8-1.2.1-9 [ 69s] Processing triggers for libc-bin (2.28-10) ... [ 69s] [95/208] installing python2.7-minimal-2.7.16-3 [ 71s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 71s] dpkg: error processing package python2.7-minimal (--install): [ 71s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 71s] Errors were encountered while processing: [ 71s] python2.7-minimal [ 71s] exit ... [ 71s] [ 71s] cloud122 failed "build osmo-python-tests_0.0.9.20190723.dsc" at Tue Jul 23 03:08:05 UTC 2019. [ 71s] [ 71s] ### VM INTERACTION START ### [ 74s] [ 44.926674] sysrq: SysRq : Power Off [ 74s] [ 44.931645] reboot: Power down [ 75s] ### VM INTERACTION END ### [ 75s] [ 75s] cloud122 failed "build osmo-python-tests_0.0.9.20190723.dsc" at Tue Jul 23 03:08:10 UTC 2019. [ 75s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 03:16:11 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 03:16:11 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sip-connector in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d367bfef17a2_2e5b10845fc301357@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sip-connector/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sip-connector failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sip-connector Last lines of build log: [ 73s] [164/419] installing libosmocore12-1.1.0.91.eb57 [ 74s] Processing triggers for libc-bin (2.28-10) ... [ 74s] [165/419] installing libosp5-1.5.2-13+b1 [ 74s] Processing triggers for libc-bin (2.28-10) ... [ 74s] [166/419] installing libostyle1c2-1.4devel1-21.3+b1 [ 74s] Processing triggers for libc-bin (2.28-10) ... [ 74s] [167/419] installing libthai0-0.1.28-2 [ 74s] Processing triggers for libc-bin (2.28-10) ... [ 74s] [168/419] installing libuchardet0-0.0.6-3 [ 75s] Processing triggers for libc-bin (2.28-10) ... [ 75s] [169/419] installing libunwind8-1.2.1-9 [ 75s] Processing triggers for libc-bin (2.28-10) ... [ 75s] [170/419] installing python2.7-minimal-2.7.16-3 [ 76s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 76s] dpkg: error processing package python2.7-minimal (--install): [ 76s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 76s] Errors were encountered while processing: [ 76s] python2.7-minimal [ 76s] exit ... [ 76s] [ 76s] lamb59 failed "build osmo-sip-connector_1.2.0.9.a35a.dsc" at Tue Jul 23 03:15:55 UTC 2019. [ 76s] [ 76s] ### VM INTERACTION START ### [ 79s] [ 57.915640] sysrq: SysRq : Power Off [ 79s] [ 57.930370] reboot: Power down [ 79s] ### VM INTERACTION END ### [ 79s] [ 79s] lamb59 failed "build osmo-sip-connector_1.2.0.9.a35a.dsc" at Tue Jul 23 03:15:58 UTC 2019. [ 79s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 03:23:36 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 03:23:36 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bts in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d367dc248072_2e5b10845fc301755@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bts failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log: [ 55s] [163/410] installing libosmocore12-1.1.0.91.eb57 [ 56s] Processing triggers for libc-bin (2.28-10) ... [ 56s] [164/410] installing libosp5-1.5.2-13+b1 [ 56s] Processing triggers for libc-bin (2.28-10) ... [ 56s] [165/410] installing libostyle1c2-1.4devel1-21.3+b1 [ 56s] Processing triggers for libc-bin (2.28-10) ... [ 56s] [166/410] installing libthai0-0.1.28-2 [ 56s] Processing triggers for libc-bin (2.28-10) ... [ 57s] [167/410] installing libuchardet0-0.0.6-3 [ 57s] Processing triggers for libc-bin (2.28-10) ... [ 57s] [168/410] installing libunwind8-1.2.1-9 [ 57s] Processing triggers for libc-bin (2.28-10) ... [ 57s] [169/410] installing python2.7-minimal-2.7.16-3 [ 57s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 57s] dpkg: error processing package python2.7-minimal (--install): [ 57s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 57s] Errors were encountered while processing: [ 57s] python2.7-minimal [ 57s] exit ... [ 57s] [ 57s] build34 failed "build osmo-bts_0.8.1.352.aa54.dsc" at Tue Jul 23 03:23:24 UTC 2019. [ 57s] [ 58s] ### VM INTERACTION START ### [ 61s] [ 41.417156] sysrq: SysRq : Power Off [ 61s] [ 41.430521] reboot: Power down [ 61s] ### VM INTERACTION END ### [ 61s] [ 61s] build34 failed "build osmo-bts_0.8.1.352.aa54.dsc" at Tue Jul 23 03:23:28 UTC 2019. [ 61s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 03:28:29 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 03:28:29 +0000 Subject: Build failure of network:osmocom:nightly/osmo-trx in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d367eecbc292_2e5b10845fc3021af@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-trx/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-trx failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 161s] [190/559] installing libosmocore12-1.1.0.91.eb57 [ 161s] Processing triggers for libc-bin (2.28-10) ... [ 161s] [191/559] installing libosp5-1.5.2-13+b1 [ 162s] Processing triggers for libc-bin (2.28-10) ... [ 162s] [192/559] installing libostyle1c2-1.4devel1-21.3+b1 [ 162s] Processing triggers for libc-bin (2.28-10) ... [ 162s] [193/559] installing libthai0-0.1.28-2 [ 162s] Processing triggers for libc-bin (2.28-10) ... [ 162s] [194/559] installing libuchardet0-0.0.6-3 [ 162s] Processing triggers for libc-bin (2.28-10) ... [ 162s] [195/559] installing libunwind8-1.2.1-9 [ 162s] Processing triggers for libc-bin (2.28-10) ... [ 162s] [196/559] installing python2.7-minimal-2.7.16-3 [ 163s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 163s] dpkg: error processing package python2.7-minimal (--install): [ 163s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 163s] Errors were encountered while processing: [ 163s] python2.7-minimal [ 163s] exit ... [ 163s] [ 163s] cloud126 failed "build osmo-trx_1.0.0.87.88f8.dsc" at Tue Jul 23 03:28:08 UTC 2019. [ 163s] [ 163s] ### VM INTERACTION START ### [ 166s] [ 102.532273] sysrq: SysRq : Power Off [ 166s] [ 102.542952] reboot: Power down [ 169s] ### VM INTERACTION END ### [ 169s] [ 169s] cloud126 failed "build osmo-trx_1.0.0.87.88f8.dsc" at Tue Jul 23 03:28:15 UTC 2019. [ 169s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 03:32:12 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 03:32:12 +0000 Subject: Build failure of network:osmocom:nightly/osmo-bsc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d367fbe564a2_2e5b10845fc302976@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [ 59s] [164/416] installing libosmocore12-1.1.0.91.eb57 [ 60s] Processing triggers for libc-bin (2.28-10) ... [ 60s] [165/416] installing libosp5-1.5.2-13+b1 [ 60s] Processing triggers for libc-bin (2.28-10) ... [ 60s] [166/416] installing libostyle1c2-1.4devel1-21.3+b1 [ 60s] Processing triggers for libc-bin (2.28-10) ... [ 60s] [167/416] installing libthai0-0.1.28-2 [ 60s] Processing triggers for libc-bin (2.28-10) ... [ 60s] [168/416] installing libuchardet0-0.0.6-3 [ 60s] Processing triggers for libc-bin (2.28-10) ... [ 60s] [169/416] installing libunwind8-1.2.1-9 [ 60s] Processing triggers for libc-bin (2.28-10) ... [ 60s] [170/416] installing python2.7-minimal-2.7.16-3 [ 61s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 61s] dpkg: error processing package python2.7-minimal (--install): [ 61s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 61s] Errors were encountered while processing: [ 61s] python2.7-minimal [ 61s] exit ... [ 61s] [ 61s] lamb58 failed "build osmo-bsc_1.4.0.104.7fbcc.dsc" at Tue Jul 23 03:31:52 UTC 2019. [ 61s] [ 61s] ### VM INTERACTION START ### [ 64s] [ 41.616255] sysrq: SysRq : Power Off [ 64s] [ 41.620722] reboot: Power down [ 64s] ### VM INTERACTION END ### [ 64s] [ 64s] lamb58 failed "build osmo-bsc_1.4.0.104.7fbcc.dsc" at Tue Jul 23 03:31:56 UTC 2019. [ 64s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 03:37:54 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 03:37:54 +0000 Subject: Build failure of network:osmocom:nightly/osmo-msc in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d3681279cc4a_2e5b10845fc3044c0@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-msc failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: [ 48s] [170/425] installing libosmocore12-1.1.0.91.eb57 [ 48s] Processing triggers for libc-bin (2.28-10) ... [ 48s] [171/425] installing libosp5-1.5.2-13+b1 [ 48s] Processing triggers for libc-bin (2.28-10) ... [ 48s] [172/425] installing libostyle1c2-1.4devel1-21.3+b1 [ 48s] Processing triggers for libc-bin (2.28-10) ... [ 48s] [173/425] installing libthai0-0.1.28-2 [ 48s] Processing triggers for libc-bin (2.28-10) ... [ 49s] [174/425] installing libuchardet0-0.0.6-3 [ 49s] Processing triggers for libc-bin (2.28-10) ... [ 49s] [175/425] installing libunwind8-1.2.1-9 [ 49s] Processing triggers for libc-bin (2.28-10) ... [ 49s] [176/425] installing python2.7-minimal-2.7.16-3 [ 49s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 49s] dpkg: error processing package python2.7-minimal (--install): [ 49s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 49s] Errors were encountered while processing: [ 49s] python2.7-minimal [ 49s] exit ... [ 49s] [ 49s] lamb10 failed "build osmo-msc_1.3.1.181.fdda61.dsc" at Tue Jul 23 03:37:38 UTC 2019. [ 49s] [ 49s] ### VM INTERACTION START ### [ 53s] [ 35.140379] sysrq: SysRq : Power Off [ 53s] [ 35.152095] reboot: Power down [ 53s] ### VM INTERACTION END ### [ 53s] [ 53s] lamb10 failed "build osmo-msc_1.3.1.181.fdda61.dsc" at Tue Jul 23 03:37:42 UTC 2019. [ 53s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Tue Jul 23 03:40:11 2019 From: admin at opensuse.org (OBS Notification) Date: Tue, 23 Jul 2019 03:40:11 +0000 Subject: Build failure of network:osmocom:nightly/osmo-sgsn in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d36819ea5fd0_2e5b10845fc304867@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-sgsn failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build log: [ 48s] [167/422] installing libosmocore12-1.1.0.91.eb57 [ 49s] Processing triggers for libc-bin (2.28-10) ... [ 49s] [168/422] installing libosp5-1.5.2-13+b1 [ 49s] Processing triggers for libc-bin (2.28-10) ... [ 49s] [169/422] installing libostyle1c2-1.4devel1-21.3+b1 [ 49s] Processing triggers for libc-bin (2.28-10) ... [ 49s] [170/422] installing libthai0-0.1.28-2 [ 49s] Processing triggers for libc-bin (2.28-10) ... [ 49s] [171/422] installing libuchardet0-0.0.6-3 [ 49s] Processing triggers for libc-bin (2.28-10) ... [ 49s] [172/422] installing libunwind8-1.2.1-9 [ 49s] Processing triggers for libc-bin (2.28-10) ... [ 49s] [173/422] installing python2.7-minimal-2.7.16-3 [ 50s] awk: error while loading shared libraries: libreadline.so.8: cannot open shared object file: No such file or directory [ 50s] dpkg: error processing package python2.7-minimal (--install): [ 50s] installed python2.7-minimal package post-installation script subprocess returned error exit status 127 [ 50s] Errors were encountered while processing: [ 50s] python2.7-minimal [ 50s] exit ... [ 50s] [ 50s] lamb08 failed "build osmo-sgsn_1.4.0.31.05fe.dsc" at Tue Jul 23 03:39:52 UTC 2019. [ 50s] [ 50s] ### VM INTERACTION START ### [ 53s] [ 34.814520] sysrq: SysRq : Power Off [ 53s] [ 34.823764] reboot: Power down [ 53s] ### VM INTERACTION END ### [ 53s] [ 53s] lamb08 failed "build osmo-sgsn_1.4.0.31.05fe.dsc" at Tue Jul 23 03:39:55 UTC 2019. [ 53s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Tue Jul 23 06:21:26 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 06:21:26 +0000 Subject: Change in ...osmo-ci[master]: OBS: print date/time before git clone and on error In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14894 ) Change subject: OBS: print date/time before git clone and on error ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14894/1/scripts/common.sh File scripts/common.sh: https://gerrit.osmocom.org/#/c/14894/1/scripts/common.sh at 96 PS1, Line 96: if ! git clone "$@"; then > I think you should not use "" here. "$@" must be quoted in order to pass the parameters without change. Here's an example: #!/bin/sh in_quotes() { echo "in quotes:" for i in "$@"; do echo "arg: $i" done } not_in_quotes() { echo "not in quotes:" for i in $@; do echo "arg: $i" done } in_quotes "a b" c d not_in_quotes "a b" c d This yields: in quotes: arg: a b arg: c arg: d not in quotes: arg: a arg: b arg: c arg: d See also: https://www.tldp.org/LDP/abs/html/internalvariables.html -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic9a6d3f0c2b8dad2661ede793c21307f1680a52e Gerrit-Change-Number: 14894 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 06:21:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 08:39:30 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 08:39:30 +0000 Subject: Change in ...osmo-bsc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14840 ) Change subject: doc: Add Osmux documentation to User Manual ...................................................................... doc: Add Osmux documentation to User Manual Depends: osmo-gsm-manuals.git f3a734e6777a902abfb03257277454c7a879aeb7 Change-Id: I75dcdddc713b0dc43e2ba577ca377c20fc511f38 --- A doc/manuals/chapters/osmux_bsc.adoc M doc/manuals/osmobsc-usermanual.adoc 2 files changed, 46 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/osmux_bsc.adoc b/doc/manuals/chapters/osmux_bsc.adoc new file mode 100644 index 0000000..c9f387b --- /dev/null +++ b/doc/manuals/chapters/osmux_bsc.adoc @@ -0,0 +1,43 @@ +include::{commondir}/chapters/osmux/osmux.adoc[] + +=== Osmux Support in {program-name} + +==== {program-name} in a A/IP with IPA/SCCPlite network setup + +In this kind of setup, Osmux is transparent to {program-name} and no specific +configuration is required here, since the CN-side of the BSC-attached MGW is +managed directly by the MSC. + +So, in this case, only MSC and MGW (both for MSC-attached one and BSC-attached +one) need to be configured explicitly. + +==== {program-name} in a 3GPP AoIP network setup + +Osmux usage in {program-name} in managed through the VTY command `osmux +(on|off|only)`. Once enabled (`on` or `only`), {program-name} will start +appending the vendor specific _Osmux Support_ IE in _BSSMAP RESET_ and _BSSMAP +RESET-ACK_ message towards the MSC in order to announce it supports Osmux. This +way, the MSC can decide whether to use Osmux or not based on this information +when setting up a call (this time using _Osmux CID_ IE). It should be noted that +this option should not be enabled unless MSC managing {program-name} supports +handling this extension IE (like OsmoMSC), a 3rd-party MSC might otherwise +refuse the related _RESET_/_RESET-ACK_ messages. + +{program-name} will behave differently during call set up based on the VTY +command presented above: + +* `off`: If _BSSMAP Assign Request_ from MSC contains _Osmux CID_ IE, meaning + MSC wants to use Osmux for this call, then {program-name} will reject the + assignment and the call set up will fail. +* `on`: BSC will support and accept both Osmux and non-Osmux (RTP) upon call set + up. If _BSSMAP Assign Request_ from MSC contains _Osmux CID_ IE, + {program-name} will instruct its MGW to set up an Osmux connection on the + CN-side of the MGCP endpoint, and will provide the MSC with its _recvCID_ + through the extension IE _Osmux CID_ appened to the _BSSMAP Assign Complete_ + message. On the other hand, if _BSSMAP Assign Request_ doesn't contain an + _Osmux CID_ IE, {program-name} will instruct its MGW to set up a regular RTP + connection on the CN-side of the MGCP endpoint. +* `only`: Same as per `on`, except that {program-name} will accept only Osmux + calls on the CN-side, this is, if _BSSMAP Assign Request_ from MSC doesn't + contain an _Osmux CID_ IE, it will reject the assignment and the call set up + will fail. diff --git a/doc/manuals/osmobsc-usermanual.adoc b/doc/manuals/osmobsc-usermanual.adoc index 3515aaa..766a11f 100644 --- a/doc/manuals/osmobsc-usermanual.adoc +++ b/doc/manuals/osmobsc-usermanual.adoc @@ -1,4 +1,5 @@ :gfdl-enabled: +:program-name: OsmoBSC OsmoBSC User Manual =================== @@ -35,6 +36,8 @@ include::./common/chapters/cell-broadcast.adoc[] +include::{srcdir}/chapters/osmux_bsc.adoc[] + include::./common/chapters/port_numbers.adoc[] include::./common/chapters/bibliography.adoc[] @@ -42,4 +45,3 @@ include::./common/chapters/glossary.adoc[] include::./common/chapters/gfdl.adoc[] - -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I75dcdddc713b0dc43e2ba577ca377c20fc511f38 Gerrit-Change-Number: 14840 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 08:47:23 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 08:47:23 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 ) Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... Patch Set 2: > Patch Set 2: > > why would osmo-bts-trx not always want to request the highest locally supported version and in the end chose whatever the highest the TRX supports? I can think of several scenarios: * Because TRX in the set up has a bug when using that higher version of the protocol, or sends incorrect data. This allows to still have a running set up with a lower working/more tested version of the protocol. * Because TRX may not support SETFORMAT and fail to continue upon receival of that command (like SC5 TRX implementation). This way, if "osmotrx trxd-max-version 0" is used, no SETFORMAT is sent (because 0 is the default starting version for backward compatibility). > > I think this vty command may actually be dangerous, in that it will persist software upgrades in your config file. This means you update e.g.both your trx and osmo-bts (which could provide better features/performance/...), but you will still use some old version as you have that statement in your config file. I think it's fine, since you may want to stick to that version for reasons explained above (specially deployed in the field, it could be your TRX is never updated). I can add a notice log when using "osmotrx trxd-max-version" with version different than highest if you like. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 23 Jul 2019 08:47:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 08:49:49 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 08:49:49 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 ) Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/14896/2/src/osmo-bts-trx/trx_vty.c File src/osmo-bts-trx/trx_vty.c: https://gerrit.osmocom.org/#/c/14896/2/src/osmo-bts-trx/trx_vty.c at 502 PS2, Line 502: -1 > Somehow this '-1' on the VTY doesn't look like a good idea to me. [?] And later on, when we have version 2, there will be 2 legacy ones, 0 and 1. What are you going to do then? I'm sorry but I'm not liking your proposal either, i looks confusing to me. What I could do: "osmotrx trxd-max-version latest", "osmotrx trxd-max-version <0-15>", so see I changed -1 with "latest". Fine with it? https://gerrit.osmocom.org/#/c/14896/2/src/osmo-bts-trx/trx_vty.c at 510 PS2, Line 510: %d is not supported > As a user, I would expect to see which one _is supported_ then (basically the maximum, "... [?] Fine, I'll print that too. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 23 Jul 2019 08:49:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 09:05:43 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 09:05:43 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Clean up code passing parameters to threads In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14898 ) Change subject: Transceiver: Clean up code passing parameters to threads ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/14898/1/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/14898/1/Transceiver52M/Transceiver.cpp at 241 PS1, Line 241: malloc > I am wondering, can we use static allocation here and simply pass a pointer to the stack? Or is ther [?] There'd be a race condition between threads, since this thread returns quickly. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6e3898a8a66520cc5b2a7df9b9ae01b0b272387f Gerrit-Change-Number: 14898 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 09:05:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 09:05:49 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 09:05:49 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Store TRXD version per channel In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14897 ) Change subject: Transceiver: Store TRXD version per channel ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9cf95e89d38d0155ab48b8c0977ca5f381c2aad Gerrit-Change-Number: 14897 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 09:05:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 09:06:01 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 09:06:01 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Store TRXD version per channel In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14897 ) Change subject: Transceiver: Store TRXD version per channel ...................................................................... Transceiver: Store TRXD version per channel The setting is negotiatied by osmo-bts-trx on each channel, so let's keep and use state per channel instead of overwriting the state from different channels. Take the chance to change related log lines to also print the channel number. Change-Id: If9cf95e89d38d0155ab48b8c0977ca5f381c2aad --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 9 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index af6b0dd..a47f7db 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -129,7 +129,7 @@ mSPSTx(tx_sps), mSPSRx(rx_sps), mChans(chans), mExtRACH(false), mEdge(false), mOn(false), mForceClockInterface(false), mTxFreq(0.0), mRxFreq(0.0), mTSC(0), mMaxExpectedDelayAB(0), mMaxExpectedDelayNB(0), - mWriteBurstToDiskMask(0), mVersionTRXD(0) + mWriteBurstToDiskMask(0) { txFullScale = mRadioInterface->fullScaleInputValue(); rxFullScale = mRadioInterface->fullScaleOutputValue(); @@ -198,6 +198,7 @@ mTxPriorityQueues.resize(mChans); mReceiveFIFO.resize(mChans); mStates.resize(mChans); + mVersionTRXD.resize(mChans); /* Filler table retransmissions - support only on channel 0 */ if (filler == FILLER_DUMMY) @@ -885,14 +886,14 @@ // set TRXD protocol version unsigned version_recv; sscanf(params, "%u", &version_recv); - LOGC(DTRXCTRL, INFO) << "BTS requests TRXD version switch: " << version_recv; + LOGCHAN(chan, DTRXCTRL, INFO) << "BTS requests TRXD version switch: " << version_recv; if (version_recv > TRX_DATA_FORMAT_VER) { - LOGC(DTRXCTRL, INFO) << "rejecting TRXD version " << version_recv - << "in favor of " << TRX_DATA_FORMAT_VER; + LOGCHAN(chan, DTRXCTRL, INFO) << "rejecting TRXD version " << version_recv + << "in favor of " << TRX_DATA_FORMAT_VER; sprintf(response, "RSP SETFORMAT %u %u", TRX_DATA_FORMAT_VER, version_recv); } else { - LOGC(DTRXCTRL, NOTICE) << "switching to TRXD version " << version_recv; - mVersionTRXD = version_recv; + LOGCHAN(chan, DTRXCTRL, NOTICE) << "switching to TRXD version " << version_recv; + mVersionTRXD[chan] = version_recv; sprintf(response, "RSP SETFORMAT %u %u", version_recv, version_recv); } } else if (match_cmd(command, "_SETBURSTTODISKMASK", ¶ms)) { @@ -1023,7 +1024,7 @@ if (!bi.idle) logRxBurst(chan, &bi); - switch (mVersionTRXD) { + switch (mVersionTRXD[chan]) { case 0: trxd_send_burst_ind_v0(chan, mDataSockets[chan], &bi); break; diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index 8b5a9b1..8da52d1 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -218,8 +218,8 @@ unsigned mMaxExpectedDelayAB; ///< maximum expected time-of-arrival offset in GSM symbols for Access Bursts (RACH) unsigned mMaxExpectedDelayNB; ///< maximum expected time-of-arrival offset in GSM symbols for Normal Bursts unsigned mWriteBurstToDiskMask; ///< debug: bitmask to indicate which timeslots to dump to disk - unsigned mVersionTRXD; ///< Format version to use for TRXD protocol communication + std::vector mVersionTRXD; ///< Format version to use for TRXD protocol communication, per channel std::vector mStates; /** Start and stop I/O threads through the control socket API */ -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14897 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9cf95e89d38d0155ab48b8c0977ca5f381c2aad Gerrit-Change-Number: 14897 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 09:06:02 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 09:06:02 +0000 Subject: Change in ...osmo-trx[master]: Transceiver: Clean up code passing parameters to threads In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14898 ) Change subject: Transceiver: Clean up code passing parameters to threads ...................................................................... Transceiver: Clean up code passing parameters to threads TransceiverChannel naming was misleading there. It's simply a data type used to pass 2 parameters through the void* of the thread entry function, so let's clearly specify is a storage for thread params. Furthermore, we don't need a full C++ class for that, let's simply use a struct. Change-Id: I6e3898a8a66520cc5b2a7df9b9ae01b0b272387f --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 37 insertions(+), 45 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index a47f7db..b12a498 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -240,10 +240,12 @@ /* Start control threads */ for (size_t i = 0; i < mChans; i++) { - TransceiverChannel *chan = new TransceiverChannel(this, i); + TrxChanThParams *params = (TrxChanThParams *)malloc(sizeof(struct TrxChanThParams)); + params->trx = this; + params->num = i; mControlServiceLoopThreads[i] = new Thread(stackSize); mControlServiceLoopThreads[i]->start((void * (*)(void*)) - ControlServiceLoopAdapter, (void*) chan); + ControlServiceLoopAdapter, (void*) params); if (i && filler == FILLER_DUMMY) filler = FILLER_ZERO; @@ -292,15 +294,19 @@ /* Launch uplink and downlink burst processing threads */ for (size_t i = 0; i < mChans; i++) { - TransceiverChannel *chan = new TransceiverChannel(this, i); + TrxChanThParams *params = (TrxChanThParams *)malloc(sizeof(struct TrxChanThParams)); + params->trx = this; + params->num = i; mRxServiceLoopThreads[i] = new Thread(stackSize); mRxServiceLoopThreads[i]->start((void * (*)(void*)) - RxUpperLoopAdapter, (void*) chan); + RxUpperLoopAdapter, (void*) params); - chan = new TransceiverChannel(this, i); + params = (TrxChanThParams *)malloc(sizeof(struct TrxChanThParams)); + params->trx = this; + params->num = i; mTxPriorityQueueServiceLoopThreads[i] = new Thread(stackSize); mTxPriorityQueueServiceLoopThreads[i]->start((void * (*)(void*)) - TxUpperLoopAdapter, (void*) chan); + TxUpperLoopAdapter, (void*) params); } mForceClockInterface = true; @@ -1108,13 +1114,13 @@ } -void *RxUpperLoopAdapter(TransceiverChannel *chan) +void *RxUpperLoopAdapter(TrxChanThParams *params) { char thread_name[16]; - Transceiver *trx = chan->trx; - size_t num = chan->num; + Transceiver *trx = params->trx; + size_t num = params->num; - delete chan; + free(params); snprintf(thread_name, 16, "RxUpper%zu", num); set_selfthread_name(thread_name); @@ -1154,13 +1160,13 @@ return NULL; } -void *ControlServiceLoopAdapter(TransceiverChannel *chan) +void *ControlServiceLoopAdapter(TrxChanThParams *params) { char thread_name[16]; - Transceiver *trx = chan->trx; - size_t num = chan->num; + Transceiver *trx = params->trx; + size_t num = params->num; - delete chan; + free(params); snprintf(thread_name, 16, "CtrlService%zu", num); set_selfthread_name(thread_name); @@ -1172,13 +1178,13 @@ return NULL; } -void *TxUpperLoopAdapter(TransceiverChannel *chan) +void *TxUpperLoopAdapter(TrxChanThParams *params) { char thread_name[16]; - Transceiver *trx = chan->trx; - size_t num = chan->num; + Transceiver *trx = params->trx; + size_t num = params->num; - delete chan; + free(params); snprintf(thread_name, 16, "TxUpper%zu", num); set_selfthread_name(thread_name); diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index 8da52d1..18dc5f2 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -39,19 +39,9 @@ class Transceiver; /** Channel descriptor for transceiver object and channel number pair */ -struct TransceiverChannel { - TransceiverChannel(Transceiver *trx, int num) - { - this->trx = trx; - this->num = num; - } - - ~TransceiverChannel() - { - } - - Transceiver *trx; - size_t num; +struct TrxChanThParams { + Transceiver *trx; + size_t num; }; /** Internal transceiver state variables */ @@ -248,15 +238,11 @@ */ bool driveTxPriorityQueue(size_t chan); - friend void *RxUpperLoopAdapter(TransceiverChannel *); - - friend void *TxUpperLoopAdapter(TransceiverChannel *); - - friend void *RxLowerLoopAdapter(Transceiver *); - - friend void *TxLowerLoopAdapter(Transceiver *); - - friend void *ControlServiceLoopAdapter(TransceiverChannel *); + friend void *RxUpperLoopAdapter(TrxChanThParams *params); + friend void *TxUpperLoopAdapter(TrxChanThParams *params); + friend void *RxLowerLoopAdapter(Transceiver *transceiver); + friend void *TxLowerLoopAdapter(Transceiver *transceiver); + friend void *ControlServiceLoopAdapter(TrxChanThParams *params); void reset(); @@ -267,14 +253,14 @@ void logRxBurst(size_t chan, const struct trx_ul_burst_ind *bi); }; -void *RxUpperLoopAdapter(TransceiverChannel *); +void *RxUpperLoopAdapter(TrxChanThParams *params); /** Main drive threads */ -void *RxLowerLoopAdapter(Transceiver *); -void *TxLowerLoopAdapter(Transceiver *); +void *RxLowerLoopAdapter(Transceiver *transceiver); +void *TxLowerLoopAdapter(Transceiver *transceiver); /** control message handler thread loop */ -void *ControlServiceLoopAdapter(TransceiverChannel *); +void *ControlServiceLoopAdapter(TrxChanThParams *params); /** transmit queueing thread loop */ -void *TxUpperLoopAdapter(TransceiverChannel *); +void *TxUpperLoopAdapter(TrxChanThParams *params); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I6e3898a8a66520cc5b2a7df9b9ae01b0b272387f Gerrit-Change-Number: 14898 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 09:36:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 09:36:16 +0000 Subject: Change in ...osmo-mgw[master]: doc: Add Osmux documentation to OsmoMGW User Manual In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14681 ) Change subject: doc: Add Osmux documentation to OsmoMGW User Manual ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14681/2/doc/manuals/chapters/mgcp_extensions.adoc File doc/manuals/chapters/mgcp_extensions.adoc: https://gerrit.osmocom.org/#/c/14681/2/doc/manuals/chapters/mgcp_extensions.adoc at 74 PS2, Line 74: //include::./common/chapters/osmux/mgcp_extension_osmux.adoc[] why is that include commented out? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 Gerrit-Change-Number: 14681 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 09:36:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 09:36:46 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 09:36:46 +0000 Subject: Change in ...osmo-ci[master]: OBS: print date/time before git clone and on error In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14894 ) Change subject: OBS: print date/time before git clone and on error ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic9a6d3f0c2b8dad2661ede793c21307f1680a52e Gerrit-Change-Number: 14894 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 09:36:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 09:36:54 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 09:36:54 +0000 Subject: Change in ...osmo-bsc[master]: turn -Werror=null-dereference into a warning In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14833 ) Change subject: turn -Werror=null-dereference into a warning ...................................................................... turn -Werror=null-dereference into a warning There is unfortunately no way to suppres this witha pragma, and gcc 9 uncovers quite a few new instaces with enabled LTO that can't/won't be fixed Related: OS#4123 Change-Id: I571a85b6ea53af7661248afd84e61cf34b7b5641 --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index cdee90c..694a9a7 100644 --- a/configure.ac +++ b/configure.ac @@ -117,7 +117,7 @@ AX_CHECK_COMPILE_FLAG([-Werror=implicit], [CFLAGS="$CFLAGS -Werror=implicit"]) AX_CHECK_COMPILE_FLAG([-Werror=maybe-uninitialized], [CFLAGS="$CFLAGS -Werror=maybe-uninitialized"]) AX_CHECK_COMPILE_FLAG([-Werror=memset-transposed-args], [CFLAGS="$CFLAGS -Werror=memset-transposed-args"]) -AX_CHECK_COMPILE_FLAG([-Werror=null-dereference], [CFLAGS="$CFLAGS -Werror=null-dereference"]) +AX_CHECK_COMPILE_FLAG([-Wnull-dereference], [CFLAGS="$CFLAGS -Wnull-dereference"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-array-argument], [CFLAGS="$CFLAGS -Werror=sizeof-array-argument"]) AX_CHECK_COMPILE_FLAG([-Werror=sizeof-pointer-memaccess], [CFLAGS="$CFLAGS -Werror=sizeof-pointer-memaccess"]) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14833 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I571a85b6ea53af7661248afd84e61cf34b7b5641 Gerrit-Change-Number: 14833 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 09:37:17 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 09:37:17 +0000 Subject: Change in ...osmo-msc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14841 ) Change subject: doc: Add Osmux documentation to User Manual ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 Gerrit-Change-Number: 14841 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Jul 2019 09:37:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 09:37:37 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 09:37:37 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add docker container In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14779 ) Change subject: debian-repo-install-test: add docker container ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 Gerrit-Change-Number: 14779 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 09:37:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 09:38:11 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 09:38:11 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: run systemd services In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14781 ) Change subject: debian-repo-install-test: run systemd services ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie6385f85560fefa7e7c9dca72cb5e2e914d4507a Gerrit-Change-Number: 14781 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 09:38:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 09:38:17 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 09:38:17 +0000 Subject: Change in ...osmo-mgw[master]: doc: Add Osmux documentation to OsmoMGW User Manual In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14681 ) Change subject: doc: Add Osmux documentation to OsmoMGW User Manual ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14681/2/doc/manuals/chapters/mgcp_extensions.adoc File doc/manuals/chapters/mgcp_extensions.adoc: https://gerrit.osmocom.org/#/c/14681/2/doc/manuals/chapters/mgcp_extensions.adoc at 74 PS2, Line 74: //include::./common/chapters/osmux/mgcp_extension_osmux.adoc[] > why is that include commented out? That one should actually be removed. Thanks for noticing. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 Gerrit-Change-Number: 14681 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 09:38:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 09:39:28 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 09:39:28 +0000 Subject: Change in ...osmo-ci[master]: OBS: print date/time before git clone and on error In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14894 ) Change subject: OBS: print date/time before git clone and on error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic9a6d3f0c2b8dad2661ede793c21307f1680a52e Gerrit-Change-Number: 14894 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 09:39:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 10:01:15 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 10:01:15 +0000 Subject: Change in ...osmo-mgw[master]: doc: Add Osmux documentation to OsmoMGW User Manual In-Reply-To: References: Message-ID: Hello daniel, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/14681 to look at the new patch set (#3). Change subject: doc: Add Osmux documentation to OsmoMGW User Manual ...................................................................... doc: Add Osmux documentation to OsmoMGW User Manual Depends: osmo-gsm-manuals.git I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 --- M doc/manuals/chapters/mgcp_extensions.adoc M doc/manuals/osmomgw-usermanual.adoc 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/81/14681/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 Gerrit-Change-Number: 14681 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 11:03:25 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 11:03:25 +0000 Subject: Change in ...osmo-ci[master]: OBS: print date/time before git clone and on error In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/14894 ) Change subject: OBS: print date/time before git clone and on error ...................................................................... OBS: print date/time before git clone and on error The OBS job clones a lot of repositories from git.osmocom.org every night, so it is a good candidate to reproduce the "garbage at end of loose object" error we are getting sporadically. Print exact timestamps, so we can check if there is anything related in the server logs, when this error happens again. Related: OS#4083 Change-Id: Ic9a6d3f0c2b8dad2661ede793c21307f1680a52e --- M scripts/common.sh M scripts/osmocom-latest-packages.sh M scripts/osmocom-nightly-packages.sh 3 files changed, 15 insertions(+), 3 deletions(-) Approvals: osmith: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/scripts/common.sh b/scripts/common.sh index bf24fc4..6d91101 100644 --- a/scripts/common.sh +++ b/scripts/common.sh @@ -89,6 +89,16 @@ echo "$ret" | cut -d/ -f 3 } +# Pass all arguments to "git clone", but write the current date and time before the clone and on failure. +# This helps analyzing errors with git.osmocom.org (OS#4083). +osmo_git_clone_date() { + date "+%Y-%m-%d %H:%M:%S" + if ! git clone "$@"; then + date "+%Y-%m-%d %H:%M:%S" + exit 1 + fi +} + # Print the subdirectory of the repository where the source lies (configure.ac etc.). # Print nothing when the source is in the topdir of the repository. osmo_source_subdir() { diff --git a/scripts/osmocom-latest-packages.sh b/scripts/osmocom-latest-packages.sh index 1074294..509bced 100755 --- a/scripts/osmocom-latest-packages.sh +++ b/scripts/osmocom-latest-packages.sh @@ -1,4 +1,5 @@ #!/bin/sh +. "$(dirname "$0")/common.sh" . "$(dirname "$0")/common-obs.sh" # requirements @@ -54,7 +55,7 @@ if [ "$project" = "limesuite" ]; then [ -d "$project" ] || git clone "https://github.com/myriadrf/LimeSuite" "$project" else - [ -d "$project" ] || git clone "https://git.osmocom.org/$project" + [ -d "$project" ] || osmo_git_clone_date "https://git.osmocom.org/$project" fi cd "$project" git fetch diff --git a/scripts/osmocom-nightly-packages.sh b/scripts/osmocom-nightly-packages.sh index 172e4e0..1c76cc1 100755 --- a/scripts/osmocom-nightly-packages.sh +++ b/scripts/osmocom-nightly-packages.sh @@ -1,4 +1,5 @@ #!/bin/bash +. "$(dirname "$0")/common.sh" . "$(dirname "$0")/common-obs.sh" # requirements @@ -68,9 +69,9 @@ cd "$REPO" if [ -n "$branch" ] ; then - git clone "$url/$name" -b "$branch" + osmo_git_clone_date "$url/$name" -b "$branch" else - git clone "$url/$name" + osmo_git_clone_date "$url/$name" fi cd - -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14894 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic9a6d3f0c2b8dad2661ede793c21307f1680a52e Gerrit-Change-Number: 14894 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 11:16:58 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 23 Jul 2019 11:16:58 +0000 Subject: Change in ...osmo-mgw[master]: doc: Add Osmux documentation to OsmoMGW User Manual In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14681 ) Change subject: doc: Add Osmux documentation to OsmoMGW User Manual ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 Gerrit-Change-Number: 14681 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 11:16:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 11:41:48 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 11:41:48 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add docker container In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14779 ) Change subject: debian-repo-install-test: add docker container ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 Gerrit-Change-Number: 14779 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 11:41:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 11:54:42 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 11:54:42 +0000 Subject: Change in ...osmo-msc[master]: vlr_lu_fsm.c: don't send LU reject twice Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14899 Change subject: vlr_lu_fsm.c: don't send LU reject twice ...................................................................... vlr_lu_fsm.c: don't send LU reject twice Don't call tx_lu_rej() in the "vlr_lu_compl" FSM. It is always getting called in the parent "lu" FSM and is therefore redundant: vlr_lu_compl_fsm_failure() -> _vlr_lu_compl_fsm_done(fi, VLR_FSM_RESULT_FAILURE, cause) -> osmo_fsm_inst_state_chg(fi, LU_COMPL_VLR_S_DONE, 0, 0) -> vlr_lu_compl_fsm_dispatch_result() -> lu_fsm_wait_lu_compl()/lu_fsm_wait_lu_compl_standalone() -> lu_fsm_failure() -> lfp->vlr->ops.tx_lu_rej() I have noticed the bug with the TTCN3 tests. This patch fixes TC_lu_imsi_auth_tmsi_check_imei_{nack,err} after stricter checking in [1] and also TC_iu_mo_crcx_ran_reject. [1] I836f76242463789c4c003feec757714827f2a31b (osmo-ttcn3-hacks) Change-Id: I127b27937613ea0ff29d67991c0414fca6d441d9 --- M src/libvlr/vlr_lu_fsm.c M tests/msc_vlr/msc_vlr_test_gsm_authen.err 2 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/99/14899/1 diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 9dff4aa..caa4b28 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -368,8 +368,6 @@ static void vlr_lu_compl_fsm_failure(struct osmo_fsm_inst *fi, uint8_t cause) { - struct lu_compl_vlr_priv *lcvp = lu_compl_vlr_fi_priv(fi); - lcvp->vsub->vlr->ops.tx_lu_rej(lcvp->msc_conn_ref, cause); _vlr_lu_compl_fsm_done(fi, VLR_FSM_RESULT_FAILURE, cause); } diff --git a/tests/msc_vlr/msc_vlr_test_gsm_authen.err b/tests/msc_vlr/msc_vlr_test_gsm_authen.err index 0a18302..c9be4ef 100644 --- a/tests/msc_vlr/msc_vlr_test_gsm_authen.err +++ b/tests/msc_vlr/msc_vlr_test_gsm_authen.err @@ -1907,7 +1907,6 @@ DREF VLR subscr IMSI-901700000004620:MSISDN-46071 + vlr_gsup_rx: now used by 2 (active-conn,vlr_gsup_rx) DVLR vlr_lu_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){VLR_ULA_S_WAIT_LU_COMPL}: Received Event VLR_ULA_E_HLR_IMEI_NACK DVLR lu_compl_vlr_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){LU_COMPL_VLR_S_WAIT_IMEI}: Received Event LU_COMPL_VLR_E_IMEI_CHECK_NACK -- sending LU Reject for IMSI-901700000004620:MSISDN-46071:GERAN-A:LU, cause 6 DVLR lu_compl_vlr_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){LU_COMPL_VLR_S_WAIT_IMEI}: state_chg to LU_COMPL_VLR_S_DONE DVLR vlr_lu_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){VLR_ULA_S_WAIT_LU_COMPL}: Received Event VLR_ULA_E_LU_COMPL_FAILURE DVLR lu_compl_vlr_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){LU_COMPL_VLR_S_DONE}: Terminating (cause = OSMO_FSM_TERM_PARENT) @@ -2174,7 +2173,6 @@ DVLR SUBSCR(IMSI-901700000004620:MSISDN-46071) Check_IMEI_VLR failed; gmm_cause: Invalid mandatory information DVLR vlr_lu_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){VLR_ULA_S_WAIT_LU_COMPL}: Received Event VLR_ULA_E_HLR_IMEI_NACK DVLR lu_compl_vlr_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){LU_COMPL_VLR_S_WAIT_IMEI}: Received Event LU_COMPL_VLR_E_IMEI_CHECK_NACK -- sending LU Reject for IMSI-901700000004620:MSISDN-46071:GERAN-A:LU, cause 6 DVLR lu_compl_vlr_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){LU_COMPL_VLR_S_WAIT_IMEI}: state_chg to LU_COMPL_VLR_S_DONE DVLR vlr_lu_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){VLR_ULA_S_WAIT_LU_COMPL}: Received Event VLR_ULA_E_LU_COMPL_FAILURE DVLR lu_compl_vlr_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){LU_COMPL_VLR_S_DONE}: Terminating (cause = OSMO_FSM_TERM_PARENT) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I127b27937613ea0ff29d67991c0414fca6d441d9 Gerrit-Change-Number: 14899 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 11:55:15 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 11:55:15 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: use f_expect_clear() in check IMEI tests Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 Change subject: msc: use f_expect_clear() in check IMEI tests ...................................................................... msc: use f_expect_clear() in check IMEI tests Fix the broken pipe race condition caused by closing the RAN connection too early. Properly wait for clear command and send clear complete. TC_lu_imsi_auth_tmsi_check_imei_{nack,err} do not pass anymore, because OsmoMSC is sending the LU reject twice. Patch [1] fixes it. Update expected-results.xml, with latest from jenkins, and don't expect errors for TC_lu_imsi_auth_tmsi_check_imei_{nack,err} anymore. [1] I127b27937613ea0ff29d67991c0414fca6d441d9 (osmo-msc) Fixes: 1d118ff753d963cfe5feb2450a31bc3a51aa5eb6 ("msc: add check IMEI tests") Change-Id: I836f76242463789c4c003feec757714827f2a31b --- M msc/MSC_Tests.ttcn M msc/expected-results.xml 2 files changed, 106 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/00/14900/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index c7c96eb..15ff17c 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -5618,7 +5618,7 @@ f_msc_lu_hlr(); f_mm_imei(); - /* Expect reject. As of writing, sometimes it passes, sometimes we get a broken pipe (race condition)! */ + /* Expect reject */ alt { [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { setverdict(pass); @@ -5628,6 +5628,7 @@ mtc.stop; } } + f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_nack() runs on MTC_CT { var BSC_ConnHdlr vc_conn; @@ -5658,7 +5659,7 @@ f_msc_lu_hlr(); f_mm_imei(); - /* Expect reject. As of writing, sometimes it passes, sometimes we get a broken pipe (race condition)! */ + /* Expect reject */ alt { [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { setverdict(pass); @@ -5668,6 +5669,7 @@ mtc.stop; } } + f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_err() runs on MTC_CT { var BSC_ConnHdlr vc_conn; @@ -5769,6 +5771,7 @@ mtc.stop; } } + f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_early_nack() runs on MTC_CT { var BSC_ConnHdlr vc_conn; @@ -5807,6 +5810,7 @@ mtc.stop; } } + f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_early_err() runs on MTC_CT { var BSC_ConnHdlr vc_conn; diff --git a/msc/expected-results.xml b/msc/expected-results.xml index ca8edd2..96af4a4 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -1,11 +1,12 @@ - + + @@ -31,12 +32,7 @@ - - Timeout waiting for channel release - MSC_Tests.ttcn:MASKED MSC_Tests control part - MSC_Tests.ttcn:MASKED TC_mt_crcx_ran_reject testcase - - + @@ -60,6 +56,7 @@ + @@ -72,6 +69,10 @@ + + + + @@ -94,23 +95,108 @@ - - - + + + - - - - + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_imsi_reject testcase + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_imsi_timeout_gsup testcase + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_cmserv_imsi_unknown testcase + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_and_mo_call testcase + + + + + + + + + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_emerg_call_imsi testcase + + + + + + + Timeout waiting for channel release + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_mo_crcx_ran_reject testcase + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_gsup_cancel testcase + + + + + + + + + + + + + + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_and_mo_ussd_during_mt_call testcase + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_and_mt_ussd_during_mt_call testcase + + + + + + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I836f76242463789c4c003feec757714827f2a31b Gerrit-Change-Number: 14900 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 11:55:15 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 11:55:15 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: check IMEI: move reject LU into new function Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 Change subject: msc: check IMEI: move reject LU into new function ...................................................................... msc: check IMEI: move reject LU into new function Change-Id: Ifad259e21df035a89e97831a57c0675502308eb6 --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn 2 files changed, 22 insertions(+), 48 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/14901/1 diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index e951400..1e5e2d5 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -642,6 +642,24 @@ setverdict(pass); } +function f_reject_lu() runs on BSC_ConnHdlr { + var PDU_DTAP_MT dtap_mt; + timer T := 5.0; + + T.start; + alt { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { + setverdict(pass); + } + [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { + setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); + } + [] T.timeout { + setverdict(fail, "Timeout waiting for LU reject"); + } + } +} + function f_foo() runs on BSC_ConnHdlr{ /* SCCP CC handled by RAN_Emulation_CT.main() */ /* Expect auth, if enabled */ diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 15ff17c..e6aaf9f 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -5601,7 +5601,6 @@ private function f_tc_lu_imsi_auth_tmsi_check_imei_nack(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { var PDU_ML3_MS_NW l3_lu; - var PDU_DTAP_MT dtap_mt; pars.net.expect_auth := true; pars.net.expect_imei := true; @@ -5617,17 +5616,7 @@ f_mm_common(); f_msc_lu_hlr(); f_mm_imei(); - - /* Expect reject */ - alt { - [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { - setverdict(pass); - } - [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { - setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); - mtc.stop; - } - } + f_reject_lu(); f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_nack() runs on MTC_CT { @@ -5642,7 +5631,6 @@ private function f_tc_lu_imsi_auth_tmsi_check_imei_err(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { var PDU_ML3_MS_NW l3_lu; - var PDU_DTAP_MT dtap_mt; pars.net.expect_auth := true; pars.net.expect_imei := true; @@ -5658,17 +5646,7 @@ f_mm_common(); f_msc_lu_hlr(); f_mm_imei(); - - /* Expect reject */ - alt { - [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { - setverdict(pass); - } - [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { - setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); - mtc.stop; - } - } + f_reject_lu(); f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_err() runs on MTC_CT { @@ -5746,7 +5724,6 @@ private function f_tc_lu_imsi_auth_tmsi_check_imei_early_nack(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { var PDU_ML3_MS_NW l3_lu; - var PDU_DTAP_MT dtap_mt; pars.net.expect_auth := true; pars.net.expect_imei_early := true; @@ -5760,17 +5737,7 @@ BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); f_mm_imei_early(); - - /* Expect reject */ - alt { - [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { - setverdict(pass); - } - [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { - setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); - mtc.stop; - } - } + f_reject_lu(); f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_early_nack() runs on MTC_CT { @@ -5785,7 +5752,6 @@ private function f_tc_lu_imsi_auth_tmsi_check_imei_early_err(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { var PDU_ML3_MS_NW l3_lu; - var PDU_DTAP_MT dtap_mt; pars.net.expect_auth := true; pars.net.expect_imei_early := true; @@ -5799,17 +5765,7 @@ BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); f_mm_imei_early(); - - /* Expect reject */ - alt { - [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { - setverdict(pass); - } - [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { - setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); - mtc.stop; - } - } + f_reject_lu(); f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_early_err() runs on MTC_CT { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifad259e21df035a89e97831a57c0675502308eb6 Gerrit-Change-Number: 14901 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 12:09:37 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 12:09:37 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add docker container In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14779 ) Change subject: debian-repo-install-test: add docker container ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 Gerrit-Change-Number: 14779 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 12:09:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 12:09:53 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 12:09:53 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add docker container In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14779 ) Change subject: debian-repo-install-test: add docker container ...................................................................... debian-repo-install-test: add docker container Add own container with systemd, so we can (in a follow-up commit) run the Osmocom systemd services in this test job. Rewrite the "interactive shell" logic to support the new systemd docker container, and enable it with an INTERACTIVE environment variable instead of hardcoding 'interactive="true"' in the script. While at it, move the Repository.key install to the Dockerfile so it works more like the other docker containers we have. Related: OS#3369 Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 --- A debian-repo-install-test/Dockerfile A debian-repo-install-test/Makefile R debian-repo-install-test/Release.key M debian-repo-install-test/jenkins.sh M debian-repo-install-test/testdata/repo-install-test.sh 5 files changed, 50 insertions(+), 28 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Verified diff --git a/debian-repo-install-test/Dockerfile b/debian-repo-install-test/Dockerfile new file mode 100644 index 0000000..5448fd6 --- /dev/null +++ b/debian-repo-install-test/Dockerfile @@ -0,0 +1,12 @@ +ARG USER +FROM debian:stretch + +COPY Release.key /tmp/Release.key + +RUN apt-get update && \ + apt-get install -y --no-install-recommends \ + aptitude \ + gnupg \ + systemd && \ + apt-key add /tmp/Release.key && \ + rm /tmp/Release.key diff --git a/debian-repo-install-test/Makefile b/debian-repo-install-test/Makefile new file mode 100644 index 0000000..8d0e10b --- /dev/null +++ b/debian-repo-install-test/Makefile @@ -0,0 +1 @@ +include ../make/Makefile diff --git a/debian-repo-install-test/testdata/Release.key b/debian-repo-install-test/Release.key similarity index 100% rename from debian-repo-install-test/testdata/Release.key rename to debian-repo-install-test/Release.key diff --git a/debian-repo-install-test/jenkins.sh b/debian-repo-install-test/jenkins.sh index 9dd4565..db71bc6 100755 --- a/debian-repo-install-test/jenkins.sh +++ b/debian-repo-install-test/jenkins.sh @@ -1,18 +1,48 @@ #!/bin/sh . ../jenkins-common.sh +docker_images_require "debian-repo-install-test" -# Configuration [ -z "$FEED" ] && FEED="nightly" -interactive="false" + +# Try to run "systemctl status" 10 times, kill the container on failure +check_if_systemd_is_running() { + for i in $(seq 1 10); do + sleep 1 + if docker exec "$BUILD_TAG" systemctl status; then + return + fi + done + + echo "ERROR: systemd is not running properly." + docker container kill "$BUILD_TAG" + exit 1 +} # Run the container -extra_args="" -[ "$interactive" = "true" ] && extra_args="-it" +# Note that this does not output anything. For debugging, add -it and remove &. docker run --rm \ -v "$PWD/testdata:/testdata:ro" \ -v "$VOL_BASE_DIR:/data" \ --name "${BUILD_TAG}" \ -e FEED="$FEED" \ - $extra_args \ - debian:stretch \ - "/testdata/repo-install-test.sh" + -e container=docker \ + --tmpfs /run \ + --tmpfs /tmp \ + -v /sys/fs/cgroup:/sys/fs/cgroup:ro \ + --cap-add SYS_ADMIN \ + "$REPO_USER/debian-repo-install-test" \ + /lib/systemd/systemd & +check_if_systemd_is_running + +# Run the test script +docker exec "$BUILD_TAG" /testdata/repo-install-test.sh +ret="$?" + +# Interactive shell +if [ -n "$INTERACTIVE" ]; then + docker exec -it "$BUILD_TAG" bash +fi + +docker container kill "$BUILD_TAG" + +exit $ret diff --git a/debian-repo-install-test/testdata/repo-install-test.sh b/debian-repo-install-test/testdata/repo-install-test.sh index f45908b..38a982f 100755 --- a/debian-repo-install-test/testdata/repo-install-test.sh +++ b/debian-repo-install-test/testdata/repo-install-test.sh @@ -12,15 +12,8 @@ fi } -install_depends() { - echo "Installing dependencies" - apt-get update - apt-get install -y gnupg aptitude -} - configure_osmocom_repo() { echo "Configuring Osmocom repository" - apt-key add /testdata/Release.key echo "deb $HTTP ./" \ > /etc/apt/sources.list.d/osmocom-latest.list apt-get update @@ -87,21 +80,7 @@ osmo-trx-usrp1 } -finish() { - echo "Test finished successfully!" - - # When docker-run is called with "-it", then stdin and a tty are available. - # The container will still exit when the entrypoint script (this file) is - # through, so in order to be able to type in commands, we execute a bash shell. - if [ -t 0 ]; then - echo "Dropping to interactive shell" - bash - fi -} - check_env -install_depends configure_osmocom_repo install_repo_packages test_binaries -finish -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14779 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0348f65a2ac184ba6b001e5130dfc8124e657367 Gerrit-Change-Number: 14779 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 12:10:20 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 12:10:20 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: kill already running In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14780 ) Change subject: debian-repo-install-test: kill already running ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f Gerrit-Change-Number: 14780 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 12:10:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 12:11:37 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 12:11:37 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: kill already running In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14780 ) Change subject: debian-repo-install-test: kill already running ...................................................................... Patch Set 5: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f Gerrit-Change-Number: 14780 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 12:11:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 12:11:53 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 12:11:53 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: kill already running In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14780 ) Change subject: debian-repo-install-test: kill already running ...................................................................... debian-repo-install-test: kill already running The container grows heavily in size as the test runs, so make sure to always kill existing ones (from stopped jobs) before starting a new one. In order to do that, do not use $BUILD_TAG as container name, which changes with every new jenkins run. Related: OS#3369 Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f --- M debian-repo-install-test/jenkins.sh 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: osmith: Verified pespin: Looks good to me, approved diff --git a/debian-repo-install-test/jenkins.sh b/debian-repo-install-test/jenkins.sh index db71bc6..fbae4b9 100755 --- a/debian-repo-install-test/jenkins.sh +++ b/debian-repo-install-test/jenkins.sh @@ -3,27 +3,34 @@ docker_images_require "debian-repo-install-test" [ -z "$FEED" ] && FEED="nightly" +CONTAINER="repo-install-test-$FEED" # Try to run "systemctl status" 10 times, kill the container on failure check_if_systemd_is_running() { for i in $(seq 1 10); do sleep 1 - if docker exec "$BUILD_TAG" systemctl status; then + if docker exec "$CONTAINER" systemctl status; then return fi done echo "ERROR: systemd is not running properly." - docker container kill "$BUILD_TAG" + docker container kill "$CONTAINER" exit 1 } +# Kill already running container +if [ "$(docker inspect -f '{{.State.Running}}' "$CONTAINER" 2> /dev/null)" = "true" ]; then + docker container kill "$CONTAINER" + sleep 1 +fi + # Run the container # Note that this does not output anything. For debugging, add -it and remove &. docker run --rm \ -v "$PWD/testdata:/testdata:ro" \ -v "$VOL_BASE_DIR:/data" \ - --name "${BUILD_TAG}" \ + --name "$CONTAINER" \ -e FEED="$FEED" \ -e container=docker \ --tmpfs /run \ @@ -35,14 +42,14 @@ check_if_systemd_is_running # Run the test script -docker exec "$BUILD_TAG" /testdata/repo-install-test.sh +docker exec "$CONTAINER" /testdata/repo-install-test.sh ret="$?" # Interactive shell if [ -n "$INTERACTIVE" ]; then - docker exec -it "$BUILD_TAG" bash + docker exec -it "$CONTAINER" bash fi -docker container kill "$BUILD_TAG" +docker container kill "$CONTAINER" exit $ret -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ide795092b656c9f0eb92a075d8f662944089019f Gerrit-Change-Number: 14780 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 12:12:15 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 12:12:15 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: run systemd services In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14781 ) Change subject: debian-repo-install-test: run systemd services ...................................................................... Patch Set 5: Verified+1 Code-Review+2 1+1=2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie6385f85560fefa7e7c9dca72cb5e2e914d4507a Gerrit-Change-Number: 14781 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 12:12:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 12:12:24 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 12:12:24 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: run systemd services In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14781 ) Change subject: debian-repo-install-test: run systemd services ...................................................................... debian-repo-install-test: run systemd services Run systemd services of Osmocom programs, to check if any are not starting properly. Use a whitelist to determine which services must start up, because some are currently broken. Modify the docker run command to support changing the CPU scheduling policy/priority in systemd service files (used by osmo-bts). Related: OS#3369 Change-Id: Ie6385f85560fefa7e7c9dca72cb5e2e914d4507a --- M debian-repo-install-test/jenkins.sh M debian-repo-install-test/testdata/repo-install-test.sh 2 files changed, 60 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved; Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve diff --git a/debian-repo-install-test/jenkins.sh b/debian-repo-install-test/jenkins.sh index fbae4b9..c0c38c5 100755 --- a/debian-repo-install-test/jenkins.sh +++ b/debian-repo-install-test/jenkins.sh @@ -26,7 +26,9 @@ fi # Run the container -# Note that this does not output anything. For debugging, add -it and remove &. +# * This does not output anything, for debugging add -it and remove &. +# * /run, /tmp, cgroups, SYS_ADMIN: needed for systemd +# * SYS_NICE: needed for changing CPUScheduling{Policy,Priority} (osmo-bts systemd service files) docker run --rm \ -v "$PWD/testdata:/testdata:ro" \ -v "$VOL_BASE_DIR:/data" \ @@ -37,6 +39,7 @@ --tmpfs /tmp \ -v /sys/fs/cgroup:/sys/fs/cgroup:ro \ --cap-add SYS_ADMIN \ + --cap-add SYS_NICE \ "$REPO_USER/debian-repo-install-test" \ /lib/systemd/systemd & check_if_systemd_is_running diff --git a/debian-repo-install-test/testdata/repo-install-test.sh b/debian-repo-install-test/testdata/repo-install-test.sh index 38a982f..e2cedd2 100755 --- a/debian-repo-install-test/testdata/repo-install-test.sh +++ b/debian-repo-install-test/testdata/repo-install-test.sh @@ -1,5 +1,31 @@ #!/bin/sh -ex +# Systemd services that must start up successfully after installing all packages (OS#3369) +# Disabled services: +# * osmo-ctrl2cgi (missing config: /etc/osmocom/ctrl2cgi.ini) +# * osmo-trap2cgi (missing config: /etc/osmocom/%N.ini) +# * osmo-sgsn (port 2123 already used by osmo-ggsn) +# * osmo-pcu (expects missing /tmp/pcu_bts socket) +# * osmo-hnbgw (tries to listen on 10.23.24.1) +# * osmo-bts-virtual (unit_id is not matching osmo-bsc's config) +SERVICES=" + osmo-bsc + osmo-gbproxy + osmo-ggsn + osmo-gtphub + osmo-hlr + osmo-mgw + osmo-msc + osmo-pcap-client + osmo-sip-connector + osmo-stp +" +# Services working in nightly, but not yet in latest +# * osmo-pcap-server: service not included in osmo-pcap 0.0.11 +SERVICES_NIGHTLY=" + osmo-pcap-server +" + HTTP="http://download.opensuse.org/repositories/network:/osmocom:/$FEED/Debian_9.0/" OBS="obs://build.opensuse.org/network:osmocom:$FEED/Debian_9.0" @@ -80,7 +106,37 @@ osmo-trx-usrp1 } +services_check() { + local service + local services_feed="$SERVICES" + local failed="" + + if [ "$FEED" = "nightly" ]; then + services_feed="$services_feed $SERVICES_NIGHTLY" + fi + + systemctl start $services_feed + sleep 2 + + for service in $services_feed; do + if ! systemctl --no-pager -l status $service; then + failed="$failed $service" + fi + done + + systemctl stop $services_feed + + if [ -n "$failed" ]; then + set +x + echo + echo "ERROR: services failed to start: $failed" + echo + exit 1 + fi +} + check_env configure_osmocom_repo install_repo_packages test_binaries +services_check -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie6385f85560fefa7e7c9dca72cb5e2e914d4507a Gerrit-Change-Number: 14781 Gerrit-PatchSet: 5 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 12:14:09 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 12:14:09 +0000 Subject: Change in ...osmo-ci[master]: osmocom-debian-install.yml: add BRANCH variable In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14790 ) Change subject: osmocom-debian-install.yml: add BRANCH variable ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ice4662551625b3c96ca105629a934a0a081db2e4 Gerrit-Change-Number: 14790 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 12:14:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 12:14:13 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 12:14:13 +0000 Subject: Change in ...osmo-ci[master]: osmocom-debian-install.yml: update description In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14789 ) Change subject: osmocom-debian-install.yml: update description ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I17d2e9e0ac7fe77fb0306724a1f1e15641d76854 Gerrit-Change-Number: 14789 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 12:14:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 12:14:26 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 12:14:26 +0000 Subject: Change in ...osmo-ci[master]: osmocom-debian-install.yml: update description In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/14789 ) Change subject: osmocom-debian-install.yml: update description ...................................................................... osmocom-debian-install.yml: update description Replace "Generated by job-builder" with a proper description. The job builder automatically adds "" to the description (which is visible when editing the job), so we don't need to mention it in the description at all. Related: OS#3369 Change-Id: I17d2e9e0ac7fe77fb0306724a1f1e15641d76854 --- M jobs/osmocom-debian-install.yml 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved osmith: Verified diff --git a/jobs/osmocom-debian-install.yml b/jobs/osmocom-debian-install.yml index 2e88cbf..80abeec 100644 --- a/jobs/osmocom-debian-install.yml +++ b/jobs/osmocom-debian-install.yml @@ -12,7 +12,11 @@ project-type: freestyle defaults: global - description: 'Generated by job-builder' + description: | +
      +
    • Install all Osmocom debian packages (OS#3176) +
    • Check if Osmocom systemd services start properly (OS#3369) +
    node: osmocom-master-debian9 builders: - shell: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I17d2e9e0ac7fe77fb0306724a1f1e15641d76854 Gerrit-Change-Number: 14789 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 12:14:26 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 12:14:26 +0000 Subject: Change in ...osmo-ci[master]: osmocom-debian-install.yml: add BRANCH variable In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/14790 ) Change subject: osmocom-debian-install.yml: add BRANCH variable ...................................................................... osmocom-debian-install.yml: add BRANCH variable Allow changing the branch in the jenkins UI when starting the build. We already have this in other jobs, and it is very useful to test changes. Change-Id: Ice4662551625b3c96ca105629a934a0a081db2e4 --- M jobs/osmocom-debian-install.yml 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved osmith: Verified diff --git a/jobs/osmocom-debian-install.yml b/jobs/osmocom-debian-install.yml index 80abeec..1f6c62a 100644 --- a/jobs/osmocom-debian-install.yml +++ b/jobs/osmocom-debian-install.yml @@ -18,13 +18,19 @@
  • Check if Osmocom systemd services start properly (OS#3369) node: osmocom-master-debian9 + parameters: + - string: + name: BRANCH + description: | + docker-playground.git branch + default: '*/master' builders: - shell: cd debian-repo-install-test && FEED={type} ./jenkins.sh scm: - git: branches: - - '*/master' + - '$BRANCH' url: git://git.osmocom.org/docker-playground git-config-name: 'Jenkins Builder' git-config-email: 'jenkins at osmocom.org' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ice4662551625b3c96ca105629a934a0a081db2e4 Gerrit-Change-Number: 14790 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 12:53:16 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 12:53:16 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: use f_expect_clear() in check IMEI tests In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 ) Change subject: msc: use f_expect_clear() in check IMEI tests ...................................................................... Patch Set 1: (2 comments) Fine with me in general, excluding the expected results. https://gerrit.osmocom.org/#/c/14900/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14900/1//COMMIT_MSG at 15 PS1, Line 15: Update expected-results.xml, with latest from jenkins IMHO, this should be done in a separate change before this one. https://gerrit.osmocom.org/#/c/14900/1/msc/expected-results.xml File msc/expected-results.xml: https://gerrit.osmocom.org/#/c/14900/1/msc/expected-results.xml at a35 PS1, Line 35: ... otherwise it looks like this patch also fixes this and some other unrelated test cases. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I836f76242463789c4c003feec757714827f2a31b Gerrit-Change-Number: 14900 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 12:53:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 12:58:52 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 12:58:52 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: check IMEI: move reject LU into new function In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 ) Change subject: msc: check IMEI: move reject LU into new function ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14901/1/msc/BSC_ConnectionHandler.ttcn File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/#/c/14901/1/msc/BSC_ConnectionHandler.ttcn at 645 PS1, Line 645: f_reject_lu I would rather call it f_exp_lu_reject(), as we don't reject anything here, but expect this message from OsmoMSC. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifad259e21df035a89e97831a57c0675502308eb6 Gerrit-Change-Number: 14901 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 23 Jul 2019 12:58:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:00:41 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 13:00:41 +0000 Subject: Change in ...osmo-msc[master]: vlr_lu_fsm.c: don't send LU reject twice In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14899 ) Change subject: vlr_lu_fsm.c: don't send LU reject twice ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I127b27937613ea0ff29d67991c0414fca6d441d9 Gerrit-Change-Number: 14899 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 13:00:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:02:39 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 13:02:39 +0000 Subject: Change in ...osmo-hlr[master]: hlr_ussd.c: fix: properly pass invokeID in handle_ussd_own_msisdn() Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14902 Change subject: hlr_ussd.c: fix: properly pass invokeID in handle_ussd_own_msisdn() ...................................................................... hlr_ussd.c: fix: properly pass invokeID in handle_ussd_own_msisdn() Change-Id: I06845c2c9ebee61671477ee1c9d82010f1f37b7b --- M src/hlr_ussd.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/02/14902/1 diff --git a/src/hlr_ussd.c b/src/hlr_ussd.c index 4024780..773c571 100644 --- a/src/hlr_ussd.c +++ b/src/hlr_ussd.c @@ -336,11 +336,11 @@ ss_tx_ussd_7bit(ss, true, req->invoke_id, buf); break; case -ENOENT: - ss_tx_error(ss, true, GSM0480_ERR_CODE_UNKNOWN_SUBSCRIBER); + ss_tx_error(ss, req->invoke_id, GSM0480_ERR_CODE_UNKNOWN_SUBSCRIBER); break; case -EIO: default: - ss_tx_error(ss, true, GSM0480_ERR_CODE_SYSTEM_FAILURE); + ss_tx_error(ss, req->invoke_id, GSM0480_ERR_CODE_SYSTEM_FAILURE); break; } return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I06845c2c9ebee61671477ee1c9d82010f1f37b7b Gerrit-Change-Number: 14902 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:03:50 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 13:03:50 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: use f_expect_clear() in check IMEI tests In-Reply-To: References: Message-ID: Hello fixeria, pespin, neels, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 to look at the new patch set (#2). Change subject: msc: use f_expect_clear() in check IMEI tests ...................................................................... msc: use f_expect_clear() in check IMEI tests Fix the broken pipe race condition caused by closing the RAN connection too early. Properly wait for clear command and send clear complete. TC_lu_imsi_auth_tmsi_check_imei_{nack,err} do not pass anymore, because OsmoMSC is sending the LU reject twice. Patch [1] fixes it. [1] I127b27937613ea0ff29d67991c0414fca6d441d9 (osmo-msc) Fixes: 1d118ff753d963cfe5feb2450a31bc3a51aa5eb6 ("msc: add check IMEI tests") Change-Id: I836f76242463789c4c003feec757714827f2a31b --- M msc/MSC_Tests.ttcn M msc/expected-results.xml 2 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/00/14900/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I836f76242463789c4c003feec757714827f2a31b Gerrit-Change-Number: 14900 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:03:50 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 13:03:50 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: check IMEI: move reject LU into new function In-Reply-To: References: Message-ID: Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 to look at the new patch set (#2). Change subject: msc: check IMEI: move reject LU into new function ...................................................................... msc: check IMEI: move reject LU into new function Change-Id: Ifad259e21df035a89e97831a57c0675502308eb6 --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn 2 files changed, 22 insertions(+), 48 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/14901/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifad259e21df035a89e97831a57c0675502308eb6 Gerrit-Change-Number: 14901 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:03:53 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 13:03:53 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc/expected-results.xml: update from jenkins Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14903 Change subject: msc/expected-results.xml: update from jenkins ...................................................................... msc/expected-results.xml: update from jenkins Change-Id: I9110f7bcda2919ff04c63a99d554b53a793f0037 --- M msc/expected-results.xml 1 file changed, 102 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/14903/1 diff --git a/msc/expected-results.xml b/msc/expected-results.xml index ca8edd2..28a6728 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -1,11 +1,12 @@ - + + @@ -31,12 +32,7 @@ - - Timeout waiting for channel release - MSC_Tests.ttcn:MASKED MSC_Tests control part - MSC_Tests.ttcn:MASKED TC_mt_crcx_ran_reject testcase - - + @@ -60,6 +56,7 @@ + @@ -72,6 +69,10 @@ + + + + @@ -94,17 +95,17 @@ - - - + + + - + - + @@ -113,4 +114,93 @@ + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_imsi_reject testcase + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_imsi_timeout_gsup testcase + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_cmserv_imsi_unknown testcase + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_and_mo_call testcase + + + + + + + + + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_emerg_call_imsi testcase + + + + + + + Timeout waiting for channel release + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_mo_crcx_ran_reject testcase + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_gsup_cancel testcase + + + + + + + + + + + + + + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_and_mo_ussd_during_mt_call testcase + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_and_mt_ussd_during_mt_call testcase + + + + + + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9110f7bcda2919ff04c63a99d554b53a793f0037 Gerrit-Change-Number: 14903 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:05:05 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 13:05:05 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: use f_expect_clear() in check IMEI tests In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 ) Change subject: msc: use f_expect_clear() in check IMEI tests ...................................................................... Patch Set 2: (2 comments) Separate commit for updating expected-results.xml: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14903 https://gerrit.osmocom.org/#/c/14900/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14900/1//COMMIT_MSG at 15 PS1, Line 15: Update expected-results.xml, with latest from jenkins > IMHO, this should be done in a separate change before this one. Done https://gerrit.osmocom.org/#/c/14900/1/msc/expected-results.xml File msc/expected-results.xml: https://gerrit.osmocom.org/#/c/14900/1/msc/expected-results.xml at a35 PS1, Line 35: > ... otherwise it looks like this patch also fixes this and some other unrelated test cases. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I836f76242463789c4c003feec757714827f2a31b Gerrit-Change-Number: 14900 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 13:05:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:09:41 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 13:09:41 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: check IMEI: move reject LU into new function In-Reply-To: References: Message-ID: Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 to look at the new patch set (#3). Change subject: msc: check IMEI: move reject LU into new function ...................................................................... msc: check IMEI: move reject LU into new function Change-Id: Ifad259e21df035a89e97831a57c0675502308eb6 --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn 2 files changed, 22 insertions(+), 48 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/01/14901/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifad259e21df035a89e97831a57c0675502308eb6 Gerrit-Change-Number: 14901 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:09:49 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 23 Jul 2019 13:09:49 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: check IMEI: move reject LU into new function In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 ) Change subject: msc: check IMEI: move reject LU into new function ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14901/1/msc/BSC_ConnectionHandler.ttcn File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/#/c/14901/1/msc/BSC_ConnectionHandler.ttcn at 645 PS1, Line 645: f_reject_lu > I would rather call it f_exp_lu_reject(), as we don't reject anything here, but expect this message [?] Good idea! I went with f_expect_lu_reject for consistency with other functions in BSC_ConnectionHandler.ttcn. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifad259e21df035a89e97831a57c0675502308eb6 Gerrit-Change-Number: 14901 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 23 Jul 2019 13:09:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:14:49 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 13:14:49 +0000 Subject: Change in ...osmo-msc[master]: vlr_lu_fsm.c: don't send LU reject twice In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14899 ) Change subject: vlr_lu_fsm.c: don't send LU reject twice ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14899/1/src/libvlr/vlr_lu_fsm.c File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/#/c/14899/1/src/libvlr/vlr_lu_fsm.c at a369 PS1, Line 369: Looks like this function can be removed and simply use _vlr_lu_compl_fsm_done() everywhere. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I127b27937613ea0ff29d67991c0414fca6d441d9 Gerrit-Change-Number: 14899 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 13:14:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:15:47 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 13:15:47 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: use f_expect_clear() in check IMEI tests In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 ) Change subject: msc: use f_expect_clear() in check IMEI tests ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I836f76242463789c4c003feec757714827f2a31b Gerrit-Change-Number: 14900 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 13:15:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:17:04 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 13:17:04 +0000 Subject: Change in ...osmo-hlr[master]: hlr_ussd.c: fix: properly pass invokeID in handle_ussd_own_msisdn() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14902 ) Change subject: hlr_ussd.c: fix: properly pass invokeID in handle_ussd_own_msisdn() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I06845c2c9ebee61671477ee1c9d82010f1f37b7b Gerrit-Change-Number: 14902 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 13:17:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:17:22 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 13:17:22 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc/expected-results.xml: update from jenkins In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14903 ) Change subject: msc/expected-results.xml: update from jenkins ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9110f7bcda2919ff04c63a99d554b53a793f0037 Gerrit-Change-Number: 14903 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 13:17:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:19:56 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 13:19:56 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: check IMEI: move reject LU into new function In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 ) Change subject: msc: check IMEI: move reject LU into new function ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifad259e21df035a89e97831a57c0675502308eb6 Gerrit-Change-Number: 14901 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 23 Jul 2019 13:19:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:20:27 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 13:20:27 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc/expected-results.xml: update from jenkins In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14903 ) Change subject: msc/expected-results.xml: update from jenkins ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9110f7bcda2919ff04c63a99d554b53a793f0037 Gerrit-Change-Number: 14903 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 13:20:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:20:52 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 13:20:52 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: use f_expect_clear() in check IMEI tests In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 ) Change subject: msc: use f_expect_clear() in check IMEI tests ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I836f76242463789c4c003feec757714827f2a31b Gerrit-Change-Number: 14900 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 13:20:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:36:26 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 13:36:26 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 to look at the new patch set (#3). Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... bts-trx: Introduce VTY command osmotrx trxd-max-version This command allows setting a maximum TRXD format version to negotiate with TRX. osmo-bts-trx will hence end up using that version if supported by TRX, or a lower one otherwise (or fail if TRX doesn't support any of them). Since now the maximum version can be 0, avoid going through SETFORMAT negotiation in that case, since 0 is the default version. This way we keep backward compatibility with TRX implementations that exit upon receival of unknown commands (such as SC5 current one). The VTY command is located in the "phy" node instead of the "phy instance" node because instances of same phy are expected to use same host with same implementation, so TRXD version to use should be the same for both. Related: OS#4006 Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 --- M include/osmo-bts/phy_link.h M src/osmo-bts-trx/l1_if.c M src/osmo-bts-trx/main.c M src/osmo-bts-trx/trx_vty.c 4 files changed, 35 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/96/14896/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 13:48:13 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 13:48:13 +0000 Subject: Change in ...osmo-bts[master]: trx: Use LOGPPHI instead of LOGP in some more messages Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14904 Change subject: trx: Use LOGPPHI instead of LOGP in some more messages ...................................................................... trx: Use LOGPPHI instead of LOGP in some more messages This allows to clearly identify the phy instance owning those messages. Change-Id: I90990e4dbcbb2fb4a3fcb24658bdf53e57030bcf --- M src/osmo-bts-trx/trx_if.c 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/04/14904/1 diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index b966bbe..6c6d5ad 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -107,22 +107,22 @@ buf[len] = '\0'; if (!!strncmp(buf, "IND CLOCK ", 10)) { - LOGP(DTRX, LOGL_NOTICE, "Unknown message on clock port: %s\n", - buf); + LOGPPHI(pinst, DTRX, LOGL_NOTICE, + "Unknown message on clock port: %s\n", buf); return 0; } if (sscanf(buf, "IND CLOCK %u", &fn) != 1) { - LOGP(DTRX, LOGL_ERROR, "Unable to parse '%s'\n", buf); + LOGPPHI(pinst, DTRX, LOGL_ERROR, "Unable to parse '%s'\n", buf); return 0; } - LOGP(DTRX, LOGL_INFO, "Clock indication: fn=%u\n", fn); + LOGPPHI(pinst, DTRX, LOGL_INFO, "Clock indication: fn=%u\n", fn); if (fn >= GSM_HYPERFRAME) { fn %= GSM_HYPERFRAME; - LOGP(DTRX, LOGL_ERROR, "Indicated clock's FN is not wrapping " - "correctly, correcting to fn=%u\n", fn); + LOGPPHI(pinst, DTRX, LOGL_ERROR, "Indicated clock's FN is not " + "wrapping correctly, correcting to fn=%u\n", fn); } /* inform core TRX clock handling code that a FN has been received */ @@ -339,8 +339,8 @@ freq10 = gsm_arfcn2freq10(arfcn, 1); /* RX = uplink */ if (freq10 == 0xffff) { - LOGP(DTRX, LOGL_ERROR, "Arfcn %d not defined.\n", - arfcn & ~ARFCN_FLAG_MASK); + LOGPPHI(pinst, DTRX, LOGL_ERROR, "Arfcn %d not defined.\n", + arfcn & ~ARFCN_FLAG_MASK); return -ENOTSUP; } @@ -358,8 +358,8 @@ freq10 = gsm_arfcn2freq10(arfcn, 0); /* TX = downlink */ if (freq10 == 0xffff) { - LOGP(DTRX, LOGL_ERROR, "Arfcn %d not defined.\n", - arfcn & ~ARFCN_FLAG_MASK); + LOGPPHI(pinst, DTRX, LOGL_ERROR, "Arfcn %d not defined.\n", + arfcn & ~ARFCN_FLAG_MASK); return -ENOTSUP; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14904 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I90990e4dbcbb2fb4a3fcb24658bdf53e57030bcf Gerrit-Change-Number: 14904 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 14:20:43 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 14:20:43 +0000 Subject: Change in ...osmo-mgw[master]: Catch unsigned integer MGCP parsing errors with strtoul Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14905 Change subject: Catch unsigned integer MGCP parsing errors with strtoul ...................................................................... Catch unsigned integer MGCP parsing errors with strtoul Checks to find if strotul failed are taken both from: man strtoul man strtol Change-Id: Ifba1c1e3151d6f92f9da3d4ca2569a5908455ca8 --- M src/libosmo-mgcp-client/mgcp_client.c M src/libosmo-mgcp/mgcp_sdp.c 2 files changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/05/14905/1 diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index fd188c3..910289e 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -36,6 +36,8 @@ #include #include #include +#include +#include #ifndef OSMUX_CID_MAX #define OSMUX_CID_MAX 255 /* FIXME: use OSMUX_CID_MAX from libosmo-netif? */ @@ -265,6 +267,7 @@ static int mgcp_parse_audio_port_pt(struct mgcp_response *r, char *line) { char *pt_str; + char *pt_end; unsigned int pt; unsigned int count = 0; unsigned int i; @@ -289,7 +292,11 @@ pt_str = strtok(NULL, " "); if (!pt_str) break; - pt = atoi(pt_str); + errno = 0; + pt = strtoul(pt_str, &pt_end, 0); + if ((errno == ERANGE && pt == ULONG_MAX) || (errno && !pt) || + pt_str == pt_end) + goto response_parse_failure_pt; /* Do not allow duplicate payload types */ for (i = 0; i < count; i++) diff --git a/src/libosmo-mgcp/mgcp_sdp.c b/src/libosmo-mgcp/mgcp_sdp.c index 99e764b..70072c2 100644 --- a/src/libosmo-mgcp/mgcp_sdp.c +++ b/src/libosmo-mgcp/mgcp_sdp.c @@ -29,6 +29,8 @@ #include #include +#include +#include /* Two structs to store intermediate parsing results. The function * mgcp_parse_sdp_data() is using the following two structs as temporary @@ -129,6 +131,7 @@ char *str; char *str_ptr; char *pt_str; + char *pt_end; unsigned int pt; unsigned int count = 0; unsigned int i; @@ -154,7 +157,11 @@ if (!pt_str) break; - pt = atoi(pt_str); + errno = 0; + pt = strtoul(pt_str, &pt_end, 0); + if ((errno == ERANGE && pt == ULONG_MAX) || (errno && !pt) || + pt_str == pt_end) + goto error; /* Do not allow duplicate payload types */ for (i = 0; i < count; i++) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14905 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifba1c1e3151d6f92f9da3d4ca2569a5908455ca8 Gerrit-Change-Number: 14905 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 14:43:51 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 14:43:51 +0000 Subject: Change in ...osmo-bts[master]: trx: Use LOGPPHI instead of LOGP in some more messages In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14904 ) Change subject: trx: Use LOGPPHI instead of LOGP in some more messages ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14904 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I90990e4dbcbb2fb4a3fcb24658bdf53e57030bcf Gerrit-Change-Number: 14904 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 23 Jul 2019 14:43:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 14:48:42 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 14:48:42 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 ) Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14896/3/src/osmo-bts-trx/trx_vty.c File src/osmo-bts-trx/trx_vty.c: https://gerrit.osmocom.org/#/c/14896/3/src/osmo-bts-trx/trx_vty.c at 500 PS3, Line 500: latest I guess you need to add the corresponding help string for this one too. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 23 Jul 2019 14:48:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 15:17:33 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 23 Jul 2019 15:17:33 +0000 Subject: Change in ...osmo-pcu[master]: ubsan: fiy shift Message-ID: Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14906 Change subject: ubsan: fiy shift ...................................................................... ubsan: fiy shift Ubsan complains about shifts into the sign bit due to automatic int promotion, so cast explicitly. Change-Id: I6387c7313832f6c7c920e1016b74562b66d6b68e Related: OS#4029 --- M src/bts.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/06/14906/1 diff --git a/src/bts.cpp b/src/bts.cpp index 395fc73..26dd401 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -551,7 +551,7 @@ } /* get TLLI from downlink assignment */ - tlli = ((*data++) & 0xf) << 28; + tlli = (uint32_t)((*data++) & 0xf) << 28; tlli |= (*data++) << 20; tlli |= (*data++) << 12; tlli |= (*data++) << 4; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6387c7313832f6c7c920e1016b74562b66d6b68e Gerrit-Change-Number: 14906 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 15:17:47 2019 From: gerrit-no-reply at lists.osmocom.org (Hoernchen) Date: Tue, 23 Jul 2019 15:17:47 +0000 Subject: Change in ...osmo-pcu[master]: ubsan: fix shift In-Reply-To: References: Message-ID: Hoernchen has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/14906 ) Change subject: ubsan: fix shift ...................................................................... ubsan: fix shift Ubsan complains about shifts into the sign bit due to automatic int promotion, so cast explicitly. Change-Id: I6387c7313832f6c7c920e1016b74562b66d6b68e Related: OS#4029 --- M src/bts.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/06/14906/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6387c7313832f6c7c920e1016b74562b66d6b68e Gerrit-Change-Number: 14906 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 15:22:50 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 15:22:50 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 to look at the new patch set (#4). Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... bts-trx: Introduce VTY command osmotrx trxd-max-version This command allows setting a maximum TRXD format version to negotiate with TRX. osmo-bts-trx will hence end up using that version if supported by TRX, or a lower one otherwise (or fail if TRX doesn't support any of them). Since now the maximum version can be 0, avoid going through SETFORMAT negotiation in that case, since 0 is the default version. This way we keep backward compatibility with TRX implementations that exit upon receival of unknown commands (such as SC5 current one). The VTY command is located in the "phy" node instead of the "phy instance" node because instances of same phy are expected to use same host with same implementation, so TRXD version to use should be the same for both. Related: OS#4006 Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 --- M include/osmo-bts/phy_link.h M src/osmo-bts-trx/l1_if.c M src/osmo-bts-trx/main.c M src/osmo-bts-trx/trx_vty.c 4 files changed, 36 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/96/14896/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 15:23:26 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 15:23:26 +0000 Subject: Change in ...osmo-pcu[master]: ubsan: fix shift In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14906 ) Change subject: ubsan: fix shift ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6387c7313832f6c7c920e1016b74562b66d6b68e Gerrit-Change-Number: 14906 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 23 Jul 2019 15:23:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 15:26:20 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 23 Jul 2019 15:26:20 +0000 Subject: Change in ...osmo-bts[master]: manuals: Update vty documentation In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14523 ) Change subject: manuals: Update vty documentation ...................................................................... Patch Set 4: > Patch Set 4: > > Wait, you're basically rewriting the whole file without visible changes? Line endings? What do you mean? Patch set 3->4 was due to a change and rebase of the parent patch. If you're referring to the vty reference xml then the whole file and structure has changed. The previous reference was very old so a lot of commands got added, renamed and the structure the commands are presented has changed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icc0c96d173f31f2eb5fcb6385525a17f94ead852 Gerrit-Change-Number: 14523 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 23 Jul 2019 15:26:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 15:34:13 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 23 Jul 2019 15:34:13 +0000 Subject: Change in ...osmo-bts[master]: manuals: Update vty documentation In-Reply-To: References: Message-ID: Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/14523 to look at the new patch set (#5). Change subject: manuals: Update vty documentation ...................................................................... manuals: Update vty documentation This documentation only includes commands for osmo-bts-virtual Change-Id: Icc0c96d173f31f2eb5fcb6385525a17f94ead852 Related: OS#1700 --- M doc/manuals/vty/bts_vty_reference.xml 1 file changed, 1,742 insertions(+), 1,633 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/23/14523/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icc0c96d173f31f2eb5fcb6385525a17f94ead852 Gerrit-Change-Number: 14523 Gerrit-PatchSet: 5 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 15:39:07 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 23 Jul 2019 15:39:07 +0000 Subject: Change in ...osmo-bts[master]: manuals: Update vty documentation In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14523 ) Change subject: manuals: Update vty documentation ...................................................................... Patch Set 5: > Patch Set 4: > > > Patch Set 4: > > > > Wait, you're basically rewriting the whole file without visible changes? Line endings? > > What do you mean? Patch set 3->4 was due to a change and rebase of the parent patch. > If you're referring to the vty reference xml then the whole file and structure has changed. The previous reference was very old so a lot of commands got added, renamed and the structure the commands are presented has changed. I regenerated the vty reference from master and it now includes your changes to min-qual-rach. This was done by running regen_doc.sh in doc/manuals/ with COMMIT=master and DOCKER_PLAYGROUND set: $ COMMIT=master DOCKER_PLAYGROUND=~/scm/osmo/docker-playground OSMO_INTERACT_VTY=~/scm/osmo/osmo-python-tests/scripts/osmo_interact_vty.py ./regen_doc.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icc0c96d173f31f2eb5fcb6385525a17f94ead852 Gerrit-Change-Number: 14523 Gerrit-PatchSet: 5 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Tue, 23 Jul 2019 15:39:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 16:01:17 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 16:01:17 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 ) Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 23 Jul 2019 16:01:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 16:17:26 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 16:17:26 +0000 Subject: Change in ...osmo-remsim[master]: rspro_client_fsm/remsim_client: Fix double-free Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14907 Change subject: rspro_client_fsm/remsim_client: Fix double-free ...................................................................... rspro_client_fsm/remsim_client: Fix double-free respro_dec_msg() takes ownership of the input msgb in both successful and unsuccessful cases, so we must not call talloc_free on the resulting msgb. Change-Id: Id54d1b73395da1329a998d213c190da49eb90a93 --- M src/remsim_client.c M src/rspro_client_fsm.c M src/simtrace2-remsim_client.c 3 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/07/14907/1 diff --git a/src/remsim_client.c b/src/remsim_client.c index 88ac4cd..e73fcc4 100644 --- a/src/remsim_client.c +++ b/src/remsim_client.c @@ -90,6 +90,7 @@ default: break; } + msgb_free(msg); break; case IPAC_PROTO_OSMO: if (!he || msgb_l2len(msg) < sizeof(*he)) diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 768c15f..06364da 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -130,6 +130,7 @@ break; default: break; + msgb_free(msg); } break; case IPAC_PROTO_OSMO: @@ -139,6 +140,8 @@ switch (he->proto) { case IPAC_PROTO_EXT_RSPRO: LOGPFSM(srvc->fi, "Received RSPRO %s\n", msgb_hexdump(msg)); + /* respro_dec_msg() takes ownership of the input message buffer in successful + * and unsuccessful cases */ pdu = rspro_dec_msg(msg); if (!pdu) goto invalid; @@ -152,7 +155,6 @@ default: goto invalid; } - msgb_free(msg); return rc; invalid: diff --git a/src/simtrace2-remsim_client.c b/src/simtrace2-remsim_client.c index 04aa0c6..094773f 100644 --- a/src/simtrace2-remsim_client.c +++ b/src/simtrace2-remsim_client.c @@ -578,6 +578,7 @@ static int bankd_handle_msg(struct bankd_client *bc, struct msgb *msg) { + /* rspro_dec_msg takes ownership of msgb and talloc_free()s it in successful and unsuccessful case */ RsproPDU_t *pdu = rspro_dec_msg(msg); if (!pdu) { LOGPFSML(bc->bankd_fi, LOGL_ERROR, "Error decoding PDU\n"); @@ -627,7 +628,6 @@ LOGPFSML(bc->bankd_fi, LOGL_DEBUG, "Received RSPRO %s\n", msgb_hexdump(msg)); rc = bankd_handle_msg(bc, msg); - msgb_free(msg); return rc; invalid: -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id54d1b73395da1329a998d213c190da49eb90a93 Gerrit-Change-Number: 14907 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 16:19:29 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 16:19:29 +0000 Subject: Change in ...osmo-remsim[master]: debian/control: BuildDepends on mscgen (for documentation) Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14908 Change subject: debian/control: BuildDepends on mscgen (for documentation) ...................................................................... debian/control: BuildDepends on mscgen (for documentation) Change-Id: I8d0306246205df9925db43b160ce0aacd085cfb5 --- M debian/control 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/08/14908/1 diff --git a/debian/control b/debian/control index a9eaa98..2cde651 100644 --- a/debian/control +++ b/debian/control @@ -8,6 +8,7 @@ dh-systemd (>= 1.5), autotools-dev, pkg-config, + mscgen, libcsv-dev, libosmocore-dev, libosmo-abis-dev, -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8d0306246205df9925db43b160ce0aacd085cfb5 Gerrit-Change-Number: 14908 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 17:52:06 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 17:52:06 +0000 Subject: Change in ...osmo-remsim[master]: debian/control: BuildDepends on mscgen (for documentation) In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14908 ) Change subject: debian/control: BuildDepends on mscgen (for documentation) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8d0306246205df9925db43b160ce0aacd085cfb5 Gerrit-Change-Number: 14908 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Jul 2019 17:52:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 17:52:08 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 17:52:08 +0000 Subject: Change in ...osmo-remsim[master]: rspro_client_fsm/remsim_client: Fix double-free In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14907 ) Change subject: rspro_client_fsm/remsim_client: Fix double-free ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id54d1b73395da1329a998d213c190da49eb90a93 Gerrit-Change-Number: 14907 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Jul 2019 17:52:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 17:52:11 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 17:52:11 +0000 Subject: Change in ...osmo-remsim[master]: rspro_client_fsm/remsim_client: Fix double-free In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14907 ) Change subject: rspro_client_fsm/remsim_client: Fix double-free ...................................................................... rspro_client_fsm/remsim_client: Fix double-free respro_dec_msg() takes ownership of the input msgb in both successful and unsuccessful cases, so we must not call talloc_free on the resulting msgb. Change-Id: Id54d1b73395da1329a998d213c190da49eb90a93 --- M src/remsim_client.c M src/rspro_client_fsm.c M src/simtrace2-remsim_client.c 3 files changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/remsim_client.c b/src/remsim_client.c index 88ac4cd..e73fcc4 100644 --- a/src/remsim_client.c +++ b/src/remsim_client.c @@ -90,6 +90,7 @@ default: break; } + msgb_free(msg); break; case IPAC_PROTO_OSMO: if (!he || msgb_l2len(msg) < sizeof(*he)) diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 768c15f..06364da 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -130,6 +130,7 @@ break; default: break; + msgb_free(msg); } break; case IPAC_PROTO_OSMO: @@ -139,6 +140,8 @@ switch (he->proto) { case IPAC_PROTO_EXT_RSPRO: LOGPFSM(srvc->fi, "Received RSPRO %s\n", msgb_hexdump(msg)); + /* respro_dec_msg() takes ownership of the input message buffer in successful + * and unsuccessful cases */ pdu = rspro_dec_msg(msg); if (!pdu) goto invalid; @@ -152,7 +155,6 @@ default: goto invalid; } - msgb_free(msg); return rc; invalid: diff --git a/src/simtrace2-remsim_client.c b/src/simtrace2-remsim_client.c index 04aa0c6..094773f 100644 --- a/src/simtrace2-remsim_client.c +++ b/src/simtrace2-remsim_client.c @@ -578,6 +578,7 @@ static int bankd_handle_msg(struct bankd_client *bc, struct msgb *msg) { + /* rspro_dec_msg takes ownership of msgb and talloc_free()s it in successful and unsuccessful case */ RsproPDU_t *pdu = rspro_dec_msg(msg); if (!pdu) { LOGPFSML(bc->bankd_fi, LOGL_ERROR, "Error decoding PDU\n"); @@ -627,7 +628,6 @@ LOGPFSML(bc->bankd_fi, LOGL_DEBUG, "Received RSPRO %s\n", msgb_hexdump(msg)); rc = bankd_handle_msg(bc, msg); - msgb_free(msg); return rc; invalid: -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14907 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id54d1b73395da1329a998d213c190da49eb90a93 Gerrit-Change-Number: 14907 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 18:19:08 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 18:19:08 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 ) Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... Patch Set 4: Self note: Once this patch is merged, I'll submit a patch against osmo-gsm-tester to be able to set this value, so tests against SC5 work again. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 23 Jul 2019 18:19:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 18:28:13 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 18:28:13 +0000 Subject: Change in ...osmo-remsim[master]: usermanual: disable non-existant architecture chapter Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14909 Change subject: usermanual: disable non-existant architecture chapter ...................................................................... usermanual: disable non-existant architecture chapter Change-Id: I897fb528990d8cf47bd0796603b79bff5fd94bc0 --- M doc/manuals/osmo-remsim-usermanual.adoc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/09/14909/1 diff --git a/doc/manuals/osmo-remsim-usermanual.adoc b/doc/manuals/osmo-remsim-usermanual.adoc index 88e3dad..854271a 100644 --- a/doc/manuals/osmo-remsim-usermanual.adoc +++ b/doc/manuals/osmo-remsim-usermanual.adoc @@ -20,7 +20,7 @@ //include::./common/chapters/logging.adoc[] -include::{srcdir}/chapters/architecture.adoc[] +//include::{srcdir}/chapters/architecture.adoc[] //include::./common/chapters/port_numbers.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14909 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I897fb528990d8cf47bd0796603b79bff5fd94bc0 Gerrit-Change-Number: 14909 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 18:28:13 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 18:28:13 +0000 Subject: Change in ...osmo-remsim[master]: doc/manuals: Use correct path (osmo-remsim-doc) Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14910 Change subject: doc/manuals: Use correct path (osmo-remsim-doc) ...................................................................... doc/manuals: Use correct path (osmo-remsim-doc) Change-Id: I16a56af66a450e6bb19a53c652d6f93d35aacb8e --- M doc/manuals/Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/10/14910/1 diff --git a/doc/manuals/Makefile.am b/doc/manuals/Makefile.am index 36ca4f2..59ec86d 100644 --- a/doc/manuals/Makefile.am +++ b/doc/manuals/Makefile.am @@ -8,5 +8,6 @@ include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.asciidoc.inc osmo-remsim-usermanual.pdf: $(srcdir)/chapters/*.adoc + OSMO_REPOSITORY = osmo-remsim include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.common.inc endif -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I16a56af66a450e6bb19a53c652d6f93d35aacb8e Gerrit-Change-Number: 14910 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 18:28:13 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 18:28:13 +0000 Subject: Change in ...osmo-remsim[master]: debian: build manuals as osmo-remsim-doc package Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14911 Change subject: debian: build manuals as osmo-remsim-doc package ...................................................................... debian: build manuals as osmo-remsim-doc package Change-Id: If5812983d319a32864f5f34b160978533465d185 --- M debian/control A debian/osmo-remsim-doc.install M debian/rules 3 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/11/14911/1 diff --git a/debian/control b/debian/control index a9eaa98..c693fde 100644 --- a/debian/control +++ b/debian/control @@ -8,6 +8,7 @@ dh-systemd (>= 1.5), autotools-dev, pkg-config, + osmo-gsm-manuals-dev, libcsv-dev, libosmocore-dev, libosmo-abis-dev, @@ -68,3 +69,11 @@ 'cardem' firmware of a SIMtrcace2 (or compatible, such as sysmoQMOD) hardware and forwards the SIM card communication to a remsim-bankd, under the control of remsim-server. + +package: osmo-remsim-doc +Architecture: all +Section: doc +Priority: optional +Depends: ${misc:Depends} +Description: ${misc:Package} PDF documentation + User manual for ${misc:Package} in PDF format. diff --git a/debian/osmo-remsim-doc.install b/debian/osmo-remsim-doc.install new file mode 100644 index 0000000..e460a4d --- /dev/null +++ b/debian/osmo-remsim-doc.install @@ -0,0 +1 @@ +usr/share/doc/osmo-remsim-doc/*.pdf diff --git a/debian/rules b/debian/rules index bbf2626..a36fe36 100755 --- a/debian/rules +++ b/debian/rules @@ -12,7 +12,7 @@ dh $@ --with=systemd --with autoreconf --fail-missing override_dh_auto_configure: - dh_auto_configure -- --with-systemdsystemunitdir=/lib/systemd/system + dh_auto_configure -- --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals #override_dh_clean: # dh_clean -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: If5812983d319a32864f5f34b160978533465d185 Gerrit-Change-Number: 14911 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 18:32:34 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 18:32:34 +0000 Subject: Change in ...osmo-remsim[master]: usermanual: disable non-existant architecture chapter In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14909 ) Change subject: usermanual: disable non-existant architecture chapter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14909 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I897fb528990d8cf47bd0796603b79bff5fd94bc0 Gerrit-Change-Number: 14909 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Jul 2019 18:32:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 18:32:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 18:32:35 +0000 Subject: Change in ...osmo-remsim[master]: doc/manuals: Use correct path (osmo-remsim-doc) In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14910 ) Change subject: doc/manuals: Use correct path (osmo-remsim-doc) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I16a56af66a450e6bb19a53c652d6f93d35aacb8e Gerrit-Change-Number: 14910 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 23 Jul 2019 18:32:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 18:32:39 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 18:32:39 +0000 Subject: Change in ...osmo-remsim[master]: debian: build manuals as osmo-remsim-doc package In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14911 ) Change subject: debian: build manuals as osmo-remsim-doc package ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: If5812983d319a32864f5f34b160978533465d185 Gerrit-Change-Number: 14911 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 23 Jul 2019 18:32:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 18:32:41 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 18:32:41 +0000 Subject: Change in ...osmo-remsim[master]: usermanual: disable non-existant architecture chapter In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14909 ) Change subject: usermanual: disable non-existant architecture chapter ...................................................................... usermanual: disable non-existant architecture chapter Change-Id: I897fb528990d8cf47bd0796603b79bff5fd94bc0 --- M doc/manuals/osmo-remsim-usermanual.adoc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/manuals/osmo-remsim-usermanual.adoc b/doc/manuals/osmo-remsim-usermanual.adoc index 88e3dad..854271a 100644 --- a/doc/manuals/osmo-remsim-usermanual.adoc +++ b/doc/manuals/osmo-remsim-usermanual.adoc @@ -20,7 +20,7 @@ //include::./common/chapters/logging.adoc[] -include::{srcdir}/chapters/architecture.adoc[] +//include::{srcdir}/chapters/architecture.adoc[] //include::./common/chapters/port_numbers.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14909 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I897fb528990d8cf47bd0796603b79bff5fd94bc0 Gerrit-Change-Number: 14909 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 18:32:41 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 18:32:41 +0000 Subject: Change in ...osmo-remsim[master]: doc/manuals: Use correct path (osmo-remsim-doc) In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14910 ) Change subject: doc/manuals: Use correct path (osmo-remsim-doc) ...................................................................... doc/manuals: Use correct path (osmo-remsim-doc) Change-Id: I16a56af66a450e6bb19a53c652d6f93d35aacb8e --- M doc/manuals/Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/manuals/Makefile.am b/doc/manuals/Makefile.am index 36ca4f2..59ec86d 100644 --- a/doc/manuals/Makefile.am +++ b/doc/manuals/Makefile.am @@ -8,5 +8,6 @@ include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.asciidoc.inc osmo-remsim-usermanual.pdf: $(srcdir)/chapters/*.adoc + OSMO_REPOSITORY = osmo-remsim include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.common.inc endif -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14910 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I16a56af66a450e6bb19a53c652d6f93d35aacb8e Gerrit-Change-Number: 14910 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 18:34:47 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 18:34:47 +0000 Subject: Change in ...osmo-remsim[master]: debian: build manuals as osmo-remsim-doc package In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14911 ) Change subject: debian: build manuals as osmo-remsim-doc package ...................................................................... debian: build manuals as osmo-remsim-doc package Change-Id: If5812983d319a32864f5f34b160978533465d185 --- M debian/control A debian/osmo-remsim-doc.install M debian/rules 3 files changed, 11 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/control b/debian/control index a9eaa98..c693fde 100644 --- a/debian/control +++ b/debian/control @@ -8,6 +8,7 @@ dh-systemd (>= 1.5), autotools-dev, pkg-config, + osmo-gsm-manuals-dev, libcsv-dev, libosmocore-dev, libosmo-abis-dev, @@ -68,3 +69,11 @@ 'cardem' firmware of a SIMtrcace2 (or compatible, such as sysmoQMOD) hardware and forwards the SIM card communication to a remsim-bankd, under the control of remsim-server. + +package: osmo-remsim-doc +Architecture: all +Section: doc +Priority: optional +Depends: ${misc:Depends} +Description: ${misc:Package} PDF documentation + User manual for ${misc:Package} in PDF format. diff --git a/debian/osmo-remsim-doc.install b/debian/osmo-remsim-doc.install new file mode 100644 index 0000000..e460a4d --- /dev/null +++ b/debian/osmo-remsim-doc.install @@ -0,0 +1 @@ +usr/share/doc/osmo-remsim-doc/*.pdf diff --git a/debian/rules b/debian/rules index bbf2626..a36fe36 100755 --- a/debian/rules +++ b/debian/rules @@ -12,7 +12,7 @@ dh $@ --with=systemd --with autoreconf --fail-missing override_dh_auto_configure: - dh_auto_configure -- --with-systemdsystemunitdir=/lib/systemd/system + dh_auto_configure -- --with-systemdsystemunitdir=/lib/systemd/system --enable-manuals #override_dh_clean: # dh_clean -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: If5812983d319a32864f5f34b160978533465d185 Gerrit-Change-Number: 14911 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 18:37:53 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 18:37:53 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-remsim=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E0=2E4-573d_=E2=86=92_0=2E2=2E1?= Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14912 Change subject: Bump version: 0.2.0.4-573d ? 0.2.1 ...................................................................... Bump version: 0.2.0.4-573d ? 0.2.1 Change-Id: I70d67eddd474f7f738ec1a032e438a6211e2daa3 --- M debian/changelog 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/12/14912/1 diff --git a/debian/changelog b/debian/changelog index d2de5eb..5554597 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,12 @@ +osmo-remsim (0.2.1) unstable; urgency=medium + + * rspro_client_fsm/remsim_client: Fix double-free + * usermanual: disable non-existant architecture chapter + * doc/manuals: Use correct path (osmo-remsim-doc) + * debian: build manuals as osmo-remsim-doc package + + -- Harald Welte Tue, 23 Jul 2019 20:37:00 +0200 + osmo-remsim (0.2.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I70d67eddd474f7f738ec1a032e438a6211e2daa3 Gerrit-Change-Number: 14912 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 18:38:11 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 18:38:11 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-remsim=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E0=2E4-573d_=E2=86=92_0=2E2=2E1?= In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14912 ) Change subject: Bump version: 0.2.0.4-573d ? 0.2.1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I70d67eddd474f7f738ec1a032e438a6211e2daa3 Gerrit-Change-Number: 14912 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: laforge Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 23 Jul 2019 18:38:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 18:38:31 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 18:38:31 +0000 Subject: Change in ...osmo-remsim[master]: debian/control: BuildDepends on mscgen (for documentation) In-Reply-To: References: Message-ID: laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14908 ) Change subject: debian/control: BuildDepends on mscgen (for documentation) ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8d0306246205df9925db43b160ce0aacd085cfb5 Gerrit-Change-Number: 14908 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 19:01:03 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 23 Jul 2019 19:01:03 +0000 Subject: =?UTF-8?Q?Change_in_=2E=2E=2Eosmo-remsim=5Bmaster=5D=3A_Bump_version=3A_0=2E2=2E0=2E4-573d_=E2=86=92_0=2E2=2E1?= In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14912 ) Change subject: Bump version: 0.2.0.4-573d ? 0.2.1 ...................................................................... Bump version: 0.2.0.4-573d ? 0.2.1 Change-Id: I70d67eddd474f7f738ec1a032e438a6211e2daa3 --- M debian/changelog 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/changelog b/debian/changelog index d2de5eb..5554597 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,12 @@ +osmo-remsim (0.2.1) unstable; urgency=medium + + * rspro_client_fsm/remsim_client: Fix double-free + * usermanual: disable non-existant architecture chapter + * doc/manuals: Use correct path (osmo-remsim-doc) + * debian: build manuals as osmo-remsim-doc package + + -- Harald Welte Tue, 23 Jul 2019 20:37:00 +0200 + osmo-remsim (0.2.0) unstable; urgency=medium [ Harald Welte ] -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I70d67eddd474f7f738ec1a032e438a6211e2daa3 Gerrit-Change-Number: 14912 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 19:11:23 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 19:11:23 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: fix compatibility with Python 3 Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14913 Change subject: trx_toolkit/trx_sniff.py: fix compatibility with Python 3 ...................................................................... trx_toolkit/trx_sniff.py: fix compatibility with Python 3 Change-Id: I9cd9b7baae31045c6495b90df2517d32772098ed --- M src/target/trx_toolkit/trx_sniff.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/13/14913/1 diff --git a/src/target/trx_toolkit/trx_sniff.py b/src/target/trx_toolkit/trx_sniff.py index add04e1..6592455 100755 --- a/src/target/trx_toolkit/trx_sniff.py +++ b/src/target/trx_toolkit/trx_sniff.py @@ -83,7 +83,7 @@ trx = udp.payload # Convert to bytearray - msg_raw = bytearray(str(trx)) + msg_raw = bytearray(trx.load) # Determine a burst direction (L1 <-> TRX) l12trx = udp.sport > udp.dport -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9cd9b7baae31045c6495b90df2517d32772098ed Gerrit-Change-Number: 14913 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 19:12:46 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 23 Jul 2019 19:12:46 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: fix compatibility with Python 3 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14913 ) Change subject: trx_toolkit/trx_sniff.py: fix compatibility with Python 3 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9cd9b7baae31045c6495b90df2517d32772098ed Gerrit-Change-Number: 14913 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 23 Jul 2019 19:12:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 20:02:01 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 20:02:01 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: add support for reading from PCAP file Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14914 Change subject: trx_toolkit/trx_sniff.py: add support for reading from PCAP file ...................................................................... trx_toolkit/trx_sniff.py: add support for reading from PCAP file Change-Id: I8a3481fbea5f6c917ae5684d0b5b806f4a76ff78 --- M src/target/trx_toolkit/trx_sniff.py 1 file changed, 23 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/14/14914/1 diff --git a/src/target/trx_toolkit/trx_sniff.py b/src/target/trx_toolkit/trx_sniff.py index 6592455..45a5cf4 100755 --- a/src/target/trx_toolkit/trx_sniff.py +++ b/src/target/trx_toolkit/trx_sniff.py @@ -61,18 +61,29 @@ pkt_filter = "udp and (port %d or port %d)" \ % (self.argv.base_port + 2, self.argv.base_port + 102) - log.info("Listening on interface '%s'..." % self.argv.sniff_if) + # Arguments to be passed to scapy.all.sniff() + sniff_args = { + "prn" : self.pkt_handler, + "filter" : pkt_filter, + "store" : 0, + } + + if self.argv.cap_file is not None: + log.info("Reading packets from '%s'..." % self.argv.cap_file) + sniff_args["offline"] = self.argv.cap_file + else: + log.info("Listening on interface '%s'..." % self.argv.sniff_if) + sniff_args["iface"] = self.argv.sniff_if # Start sniffing... - scapy.all.sniff(iface = self.argv.sniff_if, store = 0, - filter = pkt_filter, prn = self.pkt_handler) + scapy.all.sniff(**sniff_args) # Scapy registers its own signal handler self.shutdown() def pkt_handler(self, ether): # Prevent loopback packet duplication - if self.argv.sniff_if == "lo": + if self.argv.sniff_if == "lo" and self.argv.cap_file is None: self.lo_trigger = not self.lo_trigger if not self.lo_trigger: return @@ -197,9 +208,6 @@ self.app_reg_logging_options(parser) trx_group = parser.add_argument_group("TRX interface") - trx_group.add_argument("-i", "--sniff-interface", - dest = "sniff_if", type = str, default = "lo", metavar = "IF", - help = "Set network interface (default '%(default)s')") trx_group.add_argument("-p", "--base-port", dest = "base_port", type = int, default = 6700, help = "Set base port number (default %(default)s)") @@ -207,6 +215,14 @@ dest = "output_file", type = str, help = "Write bursts to a capture file") + input_group = trx_group.add_mutually_exclusive_group() + input_group.add_argument("-i", "--sniff-interface", + dest = "sniff_if", type = str, default = "lo", metavar = "IF", + help = "Set network interface (default '%(default)s')") + input_group.add_argument("-r", "--capture-file", + dest = "cap_file", type = str, metavar = "FILE", + help = "Read packets from a PCAP file") + cnt_group = parser.add_argument_group("Count limitations (optional)") cnt_group.add_argument("--frame-count", metavar = "N", dest = "frame_count", type = int, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8a3481fbea5f6c917ae5684d0b5b806f4a76ff78 Gerrit-Change-Number: 14914 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 21:12:14 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 21:12:14 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: support sniffing on multiple ports Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14915 Change subject: trx_toolkit/trx_sniff.py: support sniffing on multiple ports ...................................................................... trx_toolkit/trx_sniff.py: support sniffing on multiple ports Change-Id: I76b818c673b98c427b5621ddb852f947c74557d6 --- M src/target/trx_toolkit/trx_sniff.py 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/15/14915/1 diff --git a/src/target/trx_toolkit/trx_sniff.py b/src/target/trx_toolkit/trx_sniff.py index 45a5cf4..7eea04c 100755 --- a/src/target/trx_toolkit/trx_sniff.py +++ b/src/target/trx_toolkit/trx_sniff.py @@ -57,14 +57,14 @@ self.ddf = DATADumpFile(self.argv.output_file) def run(self): - # Compose a packet filter - pkt_filter = "udp and (port %d or port %d)" \ - % (self.argv.base_port + 2, self.argv.base_port + 102) + # Compose a list of permitted UDP ports + rx_port_list = ["port %d" % (port + 102) for port in self.argv.base_ports] + tx_port_list = ["port %d" % (port + 2) for port in self.argv.base_ports] # Arguments to be passed to scapy.all.sniff() sniff_args = { + "filter" : "udp and (%s)" % " or ".join(rx_port_list + tx_port_list), "prn" : self.pkt_handler, - "filter" : pkt_filter, "store" : 0, } @@ -208,8 +208,9 @@ self.app_reg_logging_options(parser) trx_group = parser.add_argument_group("TRX interface") - trx_group.add_argument("-p", "--base-port", - dest = "base_port", type = int, default = 6700, + trx_group.add_argument("-p", "--base-port", "--base-ports", + dest = "base_ports", type = int, metavar = "PORT", + default = [5700, 6700], nargs = "*", help = "Set base port number (default %(default)s)") trx_group.add_argument("-o", "--output-file", metavar = "FILE", dest = "output_file", type = str, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I76b818c673b98c427b5621ddb852f947c74557d6 Gerrit-Change-Number: 14915 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 21:12:14 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 21:12:14 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: support additional capture filter Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14916 Change subject: trx_toolkit/trx_sniff.py: support additional capture filter ...................................................................... trx_toolkit/trx_sniff.py: support additional capture filter Change-Id: I761debb2e1c411f2c6d489eac0adf32060966a4c --- M src/target/trx_toolkit/trx_sniff.py 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/16/14916/1 diff --git a/src/target/trx_toolkit/trx_sniff.py b/src/target/trx_toolkit/trx_sniff.py index 7eea04c..0323e85 100755 --- a/src/target/trx_toolkit/trx_sniff.py +++ b/src/target/trx_toolkit/trx_sniff.py @@ -75,6 +75,10 @@ log.info("Listening on interface '%s'..." % self.argv.sniff_if) sniff_args["iface"] = self.argv.sniff_if + if self.argv.cap_filter is not None: + log.info("Using additional capture filter '%s'" % self.argv.cap_filter) + sniff_args["filter"] += " and (%s)" % self.argv.cap_filter + # Start sniffing... scapy.all.sniff(**sniff_args) @@ -224,6 +228,10 @@ dest = "cap_file", type = str, metavar = "FILE", help = "Read packets from a PCAP file") + trx_group.add_argument("-f", "--capture-filter", + dest = "cap_filter", type = str, metavar = "FILTER", + help = "Set additional capture filter (e.g. 'host 192.168.1.2')") + cnt_group = parser.add_argument_group("Count limitations (optional)") cnt_group.add_argument("--frame-count", metavar = "N", dest = "frame_count", type = int, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I761debb2e1c411f2c6d489eac0adf32060966a4c Gerrit-Change-Number: 14916 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 22:05:41 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 22:05:41 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/burst_gen.py: basic TRXD header version 1 support Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14917 Change subject: trx_toolkit/burst_gen.py: basic TRXD header version 1 support ...................................................................... trx_toolkit/burst_gen.py: basic TRXD header version 1 support Change-Id: Icd4505d211816dc80e91d65094be92f2aed856bd --- M src/target/trx_toolkit/burst_gen.py 1 file changed, 27 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/17/14917/1 diff --git a/src/target/trx_toolkit/burst_gen.py b/src/target/trx_toolkit/burst_gen.py index 6db8219..63c8786 100755 --- a/src/target/trx_toolkit/burst_gen.py +++ b/src/target/trx_toolkit/burst_gen.py @@ -5,7 +5,7 @@ # Auxiliary tool to generate and send random bursts via TRX DATA # interface, which may be useful for fuzzing and testing # -# (C) 2017-2018 by Vadim Yanitskiy +# (C) 2017-2019 by Vadim Yanitskiy # # All Rights Reserved # @@ -23,7 +23,7 @@ # with this program; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -APP_CR_HOLDERS = [("2017-2018", "Vadim Yanitskiy ")] +APP_CR_HOLDERS = [("2017-2019", "Vadim Yanitskiy ")] import logging as log import signal @@ -68,9 +68,9 @@ # Init an empty DATA message if self.argv.conn_mode == "TRX": - msg = DATAMSG_L12TRX() + msg = DATAMSG_L12TRX(ver = self.argv.hdr_ver) elif self.argv.conn_mode == "L1": - msg = DATAMSG_TRX2L1() + msg = DATAMSG_TRX2L1(ver = self.argv.hdr_ver) # Generate a random frame number or use provided one fn_init = msg.rand_fn() if self.argv.tdma_fn is None \ @@ -102,6 +102,17 @@ if self.argv.rssi is not None: msg.rssi = self.argv.rssi + if msg.ver >= 0x01: + # TODO: Only GMSK and TSC set 0 for now + msg.mod_type = Modulation.ModGMSK + self.tsc_set = 0 + + if self.argv.tsc is not None: + msg.tsc = self.argv.tsc + + if self.argv.ci is not None: + msg.ci = self.argv.ci + # Generate a random burst if self.argv.burst_type == "NB": burst = burst_gen.gen_nb() @@ -163,6 +174,10 @@ bg_group.add_argument("-c", "--burst-count", metavar = "N", dest = "burst_count", type = int, default = 1, help = "How many bursts to send (default %(default)s)") + bg_group.add_argument("-v", "--hdr-version", metavar = "VER", + dest = "hdr_ver", type = int, + default = 0, choices = DATAMSG.known_versions, + help = "TRXD header version (default %(default)s)") bg_group.add_argument("-f", "--frame-number", metavar = "FN", dest = "tdma_fn", type = int, help = "Set TDMA frame number (default random)") @@ -186,6 +201,14 @@ dest = "toa256", type = int, help = "Set Timing of Arrival in 1/256 symbol periods") + bg_group.add_argument("--tsc", metavar = "TSC", + dest = "tsc", type = int, choices = range(0, 8), + help = "Set Training Sequence Code (default random)") + bg_group.add_argument("--ci", metavar = "CI", + dest = "ci", type = int, + help = "C/I: Carrier-to-Interference ratio " + "in centiBels (default random)") + return parser.parse_args() def sig_handler(self, signum, frame): -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icd4505d211816dc80e91d65094be92f2aed856bd Gerrit-Change-Number: 14917 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 22:13:26 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 22:13:26 +0000 Subject: Change in ...osmo-hlr[master]: hlr_ussd.c: fix: properly pass invokeID in handle_ussd_own_msisdn() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14902 ) Change subject: hlr_ussd.c: fix: properly pass invokeID in handle_ussd_own_msisdn() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I06845c2c9ebee61671477ee1c9d82010f1f37b7b Gerrit-Change-Number: 14902 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 23 Jul 2019 22:13:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 22:13:29 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 22:13:29 +0000 Subject: Change in ...osmo-hlr[master]: hlr_ussd.c: fix: properly pass invokeID in handle_ussd_own_msisdn() In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14902 ) Change subject: hlr_ussd.c: fix: properly pass invokeID in handle_ussd_own_msisdn() ...................................................................... hlr_ussd.c: fix: properly pass invokeID in handle_ussd_own_msisdn() Change-Id: I06845c2c9ebee61671477ee1c9d82010f1f37b7b --- M src/hlr_ussd.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/hlr_ussd.c b/src/hlr_ussd.c index 4024780..773c571 100644 --- a/src/hlr_ussd.c +++ b/src/hlr_ussd.c @@ -336,11 +336,11 @@ ss_tx_ussd_7bit(ss, true, req->invoke_id, buf); break; case -ENOENT: - ss_tx_error(ss, true, GSM0480_ERR_CODE_UNKNOWN_SUBSCRIBER); + ss_tx_error(ss, req->invoke_id, GSM0480_ERR_CODE_UNKNOWN_SUBSCRIBER); break; case -EIO: default: - ss_tx_error(ss, true, GSM0480_ERR_CODE_SYSTEM_FAILURE); + ss_tx_error(ss, req->invoke_id, GSM0480_ERR_CODE_SYSTEM_FAILURE); break; } return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I06845c2c9ebee61671477ee1c9d82010f1f37b7b Gerrit-Change-Number: 14902 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 22:13:43 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 22:13:43 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: fix compatibility with Python 3 In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14913 ) Change subject: trx_toolkit/trx_sniff.py: fix compatibility with Python 3 ...................................................................... trx_toolkit/trx_sniff.py: fix compatibility with Python 3 Change-Id: I9cd9b7baae31045c6495b90df2517d32772098ed --- M src/target/trx_toolkit/trx_sniff.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/target/trx_toolkit/trx_sniff.py b/src/target/trx_toolkit/trx_sniff.py index add04e1..6592455 100755 --- a/src/target/trx_toolkit/trx_sniff.py +++ b/src/target/trx_toolkit/trx_sniff.py @@ -83,7 +83,7 @@ trx = udp.payload # Convert to bytearray - msg_raw = bytearray(str(trx)) + msg_raw = bytearray(trx.load) # Determine a burst direction (L1 <-> TRX) l12trx = udp.sport > udp.dport -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9cd9b7baae31045c6495b90df2517d32772098ed Gerrit-Change-Number: 14913 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 22:44:33 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 22:44:33 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/rand_burst_gen.py: fix compatibility with Python 3 Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14918 Change subject: trx_toolkit/rand_burst_gen.py: fix compatibility with Python 3 ...................................................................... trx_toolkit/rand_burst_gen.py: fix compatibility with Python 3 Change-Id: I362881af83664f94be09d40f43dfb23d18a35136 --- M src/target/trx_toolkit/rand_burst_gen.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/18/14918/1 diff --git a/src/target/trx_toolkit/rand_burst_gen.py b/src/target/trx_toolkit/rand_burst_gen.py index c449418..be4b696 100644 --- a/src/target/trx_toolkit/rand_burst_gen.py +++ b/src/target/trx_toolkit/rand_burst_gen.py @@ -46,6 +46,7 @@ # Pick a random TSC for a given burst type def get_rand_tsc(self, bt): tsc_list = filter(lambda seq: seq.bt == bt, list(TrainingSeqGMSK)) + tsc_list = list(tsc_list) # In Python 3 filter() returns an iterator return random.choice(tsc_list) # Generate a normal burst -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I362881af83664f94be09d40f43dfb23d18a35136 Gerrit-Change-Number: 14918 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 22:44:33 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 22:44:33 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit: fix compatibility with Python 3: 'is' vs '==' Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14919 Change subject: trx_toolkit: fix compatibility with Python 3: 'is' vs '==' ...................................................................... trx_toolkit: fix compatibility with Python 3: 'is' vs '==' Change-Id: I8ba05c04f206578cf61df58573c24cba1d6fba52 --- M src/target/trx_toolkit/burst_gen.py M src/target/trx_toolkit/burst_send.py M src/target/trx_toolkit/clck_gen.py M src/target/trx_toolkit/ctrl_cmd.py M src/target/trx_toolkit/fake_trx.py 5 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/19/14919/1 diff --git a/src/target/trx_toolkit/burst_gen.py b/src/target/trx_toolkit/burst_gen.py index 6db8219..5f39e6a 100755 --- a/src/target/trx_toolkit/burst_gen.py +++ b/src/target/trx_toolkit/burst_gen.py @@ -190,7 +190,7 @@ def sig_handler(self, signum, frame): log.info("Signal %d received" % signum) - if signum is signal.SIGINT: + if signum == signal.SIGINT: sys.exit(0) if __name__ == '__main__': diff --git a/src/target/trx_toolkit/burst_send.py b/src/target/trx_toolkit/burst_send.py index 2565f4a..368031c 100755 --- a/src/target/trx_toolkit/burst_send.py +++ b/src/target/trx_toolkit/burst_send.py @@ -149,7 +149,7 @@ def sig_handler(self, signum, frame): log.info("Signal %d received" % signum) - if signum is signal.SIGINT: + if signum == signal.SIGINT: sys.exit(0) if __name__ == '__main__': diff --git a/src/target/trx_toolkit/clck_gen.py b/src/target/trx_toolkit/clck_gen.py index 3e479e3..c58d8bd 100755 --- a/src/target/trx_toolkit/clck_gen.py +++ b/src/target/trx_toolkit/clck_gen.py @@ -111,7 +111,8 @@ def sig_handler(self, signum, frame): log.info("Signal %d received" % signum) - if signum is signal.SIGINT: + if signum == signal.SIGINT: + print("Stopping timer") self.clck.stop() if __name__ == '__main__': diff --git a/src/target/trx_toolkit/ctrl_cmd.py b/src/target/trx_toolkit/ctrl_cmd.py index 7deeeac..982cf31 100755 --- a/src/target/trx_toolkit/ctrl_cmd.py +++ b/src/target/trx_toolkit/ctrl_cmd.py @@ -114,7 +114,7 @@ def sig_handler(self, signum, frame): log.info("Signal %d received" % signum) - if signum is signal.SIGINT: + if signum == signal.SIGINT: sys.exit(0) if __name__ == '__main__': diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py index ab90af4..8beee6e 100755 --- a/src/target/trx_toolkit/fake_trx.py +++ b/src/target/trx_toolkit/fake_trx.py @@ -496,7 +496,7 @@ def sig_handler(self, signum, frame): log.info("Signal %d received" % signum) - if signum is signal.SIGINT: + if signum == signal.SIGINT: self.shutdown() sys.exit(0) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8ba05c04f206578cf61df58573c24cba1d6fba52 Gerrit-Change-Number: 14919 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 22:59:32 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 22:59:32 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/rand_burst_gen.py: fix compatibility with Python 3 In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14918 ) Change subject: trx_toolkit/rand_burst_gen.py: fix compatibility with Python 3 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I362881af83664f94be09d40f43dfb23d18a35136 Gerrit-Change-Number: 14918 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 23 Jul 2019 22:59:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 22:59:38 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 22:59:38 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit: fix compatibility with Python 3: 'is' vs '==' In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14919 ) Change subject: trx_toolkit: fix compatibility with Python 3: 'is' vs '==' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8ba05c04f206578cf61df58573c24cba1d6fba52 Gerrit-Change-Number: 14919 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Tue, 23 Jul 2019 22:59:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 22:59:40 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 22:59:40 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/rand_burst_gen.py: fix compatibility with Python 3 In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14918 ) Change subject: trx_toolkit/rand_burst_gen.py: fix compatibility with Python 3 ...................................................................... trx_toolkit/rand_burst_gen.py: fix compatibility with Python 3 Change-Id: I362881af83664f94be09d40f43dfb23d18a35136 --- M src/target/trx_toolkit/rand_burst_gen.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/target/trx_toolkit/rand_burst_gen.py b/src/target/trx_toolkit/rand_burst_gen.py index c449418..be4b696 100644 --- a/src/target/trx_toolkit/rand_burst_gen.py +++ b/src/target/trx_toolkit/rand_burst_gen.py @@ -46,6 +46,7 @@ # Pick a random TSC for a given burst type def get_rand_tsc(self, bt): tsc_list = filter(lambda seq: seq.bt == bt, list(TrainingSeqGMSK)) + tsc_list = list(tsc_list) # In Python 3 filter() returns an iterator return random.choice(tsc_list) # Generate a normal burst -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14918 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I362881af83664f94be09d40f43dfb23d18a35136 Gerrit-Change-Number: 14918 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 23 22:59:41 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Tue, 23 Jul 2019 22:59:41 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit: fix compatibility with Python 3: 'is' vs '==' In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14919 ) Change subject: trx_toolkit: fix compatibility with Python 3: 'is' vs '==' ...................................................................... trx_toolkit: fix compatibility with Python 3: 'is' vs '==' Change-Id: I8ba05c04f206578cf61df58573c24cba1d6fba52 --- M src/target/trx_toolkit/burst_gen.py M src/target/trx_toolkit/burst_send.py M src/target/trx_toolkit/clck_gen.py M src/target/trx_toolkit/ctrl_cmd.py M src/target/trx_toolkit/fake_trx.py 5 files changed, 6 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/target/trx_toolkit/burst_gen.py b/src/target/trx_toolkit/burst_gen.py index 6db8219..5f39e6a 100755 --- a/src/target/trx_toolkit/burst_gen.py +++ b/src/target/trx_toolkit/burst_gen.py @@ -190,7 +190,7 @@ def sig_handler(self, signum, frame): log.info("Signal %d received" % signum) - if signum is signal.SIGINT: + if signum == signal.SIGINT: sys.exit(0) if __name__ == '__main__': diff --git a/src/target/trx_toolkit/burst_send.py b/src/target/trx_toolkit/burst_send.py index 2565f4a..368031c 100755 --- a/src/target/trx_toolkit/burst_send.py +++ b/src/target/trx_toolkit/burst_send.py @@ -149,7 +149,7 @@ def sig_handler(self, signum, frame): log.info("Signal %d received" % signum) - if signum is signal.SIGINT: + if signum == signal.SIGINT: sys.exit(0) if __name__ == '__main__': diff --git a/src/target/trx_toolkit/clck_gen.py b/src/target/trx_toolkit/clck_gen.py index 3e479e3..c58d8bd 100755 --- a/src/target/trx_toolkit/clck_gen.py +++ b/src/target/trx_toolkit/clck_gen.py @@ -111,7 +111,8 @@ def sig_handler(self, signum, frame): log.info("Signal %d received" % signum) - if signum is signal.SIGINT: + if signum == signal.SIGINT: + print("Stopping timer") self.clck.stop() if __name__ == '__main__': diff --git a/src/target/trx_toolkit/ctrl_cmd.py b/src/target/trx_toolkit/ctrl_cmd.py index 7deeeac..982cf31 100755 --- a/src/target/trx_toolkit/ctrl_cmd.py +++ b/src/target/trx_toolkit/ctrl_cmd.py @@ -114,7 +114,7 @@ def sig_handler(self, signum, frame): log.info("Signal %d received" % signum) - if signum is signal.SIGINT: + if signum == signal.SIGINT: sys.exit(0) if __name__ == '__main__': diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py index ab90af4..8beee6e 100755 --- a/src/target/trx_toolkit/fake_trx.py +++ b/src/target/trx_toolkit/fake_trx.py @@ -496,7 +496,7 @@ def sig_handler(self, signum, frame): log.info("Signal %d received" % signum) - if signum is signal.SIGINT: + if signum == signal.SIGINT: self.shutdown() sys.exit(0) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14919 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8ba05c04f206578cf61df58573c24cba1d6fba52 Gerrit-Change-Number: 14919 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 07:01:48 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 24 Jul 2019 07:01:48 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc/expected-results.xml: update from jenkins In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14903 ) Change subject: msc/expected-results.xml: update from jenkins ...................................................................... msc/expected-results.xml: update from jenkins Change-Id: I9110f7bcda2919ff04c63a99d554b53a793f0037 --- M msc/expected-results.xml 1 file changed, 102 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/msc/expected-results.xml b/msc/expected-results.xml index ca8edd2..28a6728 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -1,11 +1,12 @@ - + + @@ -31,12 +32,7 @@ - - Timeout waiting for channel release - MSC_Tests.ttcn:MASKED MSC_Tests control part - MSC_Tests.ttcn:MASKED TC_mt_crcx_ran_reject testcase - - + @@ -60,6 +56,7 @@ + @@ -72,6 +69,10 @@ + + + + @@ -94,17 +95,17 @@ - - - + + + - + - + @@ -113,4 +114,93 @@ + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_imsi_reject testcase + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_imsi_timeout_gsup testcase + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_cmserv_imsi_unknown testcase + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_and_mo_call testcase + + + + + + + + + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_emerg_call_imsi testcase + + + + + + + Timeout waiting for channel release + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_mo_crcx_ran_reject testcase + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_gsup_cancel testcase + + + + + + + + + + + + + + + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_and_mo_ussd_during_mt_call testcase + + + + Tguard timeout + MSC_Tests_Iu.ttcn:MASKED MSC_Tests_Iu control part + MSC_Tests_Iu.ttcn:MASKED TC_iu_lu_and_mt_ussd_during_mt_call testcase + + + + + + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14903 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9110f7bcda2919ff04c63a99d554b53a793f0037 Gerrit-Change-Number: 14903 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 07:09:14 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 24 Jul 2019 07:09:14 +0000 Subject: Change in ...osmo-msc[master]: vlr_lu_fsm.c: don't send LU reject twice In-Reply-To: References: Message-ID: Hello pespin, fixeria, neels, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/14899 to look at the new patch set (#2). Change subject: vlr_lu_fsm.c: don't send LU reject twice ...................................................................... vlr_lu_fsm.c: don't send LU reject twice Don't call tx_lu_rej() in the "vlr_lu_compl" FSM. It is always getting called in the parent "lu" FSM and is therefore redundant: _vlr_lu_compl_fsm_done(fi, VLR_FSM_RESULT_FAILURE, cause) -> osmo_fsm_inst_state_chg(fi, LU_COMPL_VLR_S_DONE, 0, 0) -> vlr_lu_compl_fsm_dispatch_result() -> lu_fsm_wait_lu_compl()/lu_fsm_wait_lu_compl_standalone() -> lu_fsm_failure() -> lfp->vlr->ops.tx_lu_rej() I have noticed the bug with the TTCN3 tests. This patch fixes TC_lu_imsi_auth_tmsi_check_imei_{nack,err} after stricter checking in [1] and also TC_iu_mo_crcx_ran_reject. [1] I836f76242463789c4c003feec757714827f2a31b (osmo-ttcn3-hacks) Change-Id: I127b27937613ea0ff29d67991c0414fca6d441d9 --- M src/libvlr/vlr_lu_fsm.c M tests/msc_vlr/msc_vlr_test_gsm_authen.err 2 files changed, 4 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/99/14899/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I127b27937613ea0ff29d67991c0414fca6d441d9 Gerrit-Change-Number: 14899 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 07:09:30 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 24 Jul 2019 07:09:30 +0000 Subject: Change in ...osmo-msc[master]: vlr_lu_fsm.c: don't send LU reject twice In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14899 ) Change subject: vlr_lu_fsm.c: don't send LU reject twice ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14899/1/src/libvlr/vlr_lu_fsm.c File src/libvlr/vlr_lu_fsm.c: https://gerrit.osmocom.org/#/c/14899/1/src/libvlr/vlr_lu_fsm.c at a369 PS1, Line 369: > Looks like this function can be removed and simply use _vlr_lu_compl_fsm_done() everywhere. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I127b27937613ea0ff29d67991c0414fca6d441d9 Gerrit-Change-Number: 14899 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 07:09:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 08:55:50 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 24 Jul 2019 08:55:50 +0000 Subject: Change in ...osmo-sgsn[master]: manuals: Update vty/counter documentation In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14535 ) Change subject: manuals: Update vty/counter documentation ...................................................................... Patch Set 1: > Patch Set 1: > > Quick look: may be it's built without Iu support? or why are all those commands dropped? You're right. The docker container osmo-sgsn-master is built without Iu support. I've fixed that there and have now regenerated the counter/vty docs. Others have also recently updated the vty reference, so there's not much that has changed there. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id7245eb1011d1f04d5dfa1503a96d100bc98344c Gerrit-Change-Number: 14535 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 08:55:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 08:55:59 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 24 Jul 2019 08:55:59 +0000 Subject: Change in ...osmo-sgsn[master]: manuals: Update vty/counter documentation In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14535 to look at the new patch set (#2). Change subject: manuals: Update vty/counter documentation ...................................................................... manuals: Update vty/counter documentation Change-Id: Id7245eb1011d1f04d5dfa1503a96d100bc98344c Related: OS#1700 --- M doc/manuals/chapters/counters_generated.adoc M doc/manuals/vty/sgsn_vty_reference.xml 2 files changed, 26 insertions(+), 65 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/35/14535/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id7245eb1011d1f04d5dfa1503a96d100bc98344c Gerrit-Change-Number: 14535 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 08:59:00 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 24 Jul 2019 08:59:00 +0000 Subject: Change in ...docker-playground[master]: osmo-sgsn-master: Enable Iu support Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14920 Change subject: osmo-sgsn-master: Enable Iu support ...................................................................... osmo-sgsn-master: Enable Iu support So far the SGSN master image is built without Iu support. osmo-sgsn-latest is using the built debian packages which enable Iu support, so it's not an issue there. Change-Id: Ib9c2e96dc7309f7fcbd563d656b64d37f2599f7b --- M osmo-sgsn-master/Dockerfile 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/20/14920/1 diff --git a/osmo-sgsn-master/Dockerfile b/osmo-sgsn-master/Dockerfile index 4257141..9f31788 100644 --- a/osmo-sgsn-master/Dockerfile +++ b/osmo-sgsn-master/Dockerfile @@ -19,9 +19,12 @@ libosmo-abis-dev \ libosmo-gsup-client-dev \ libosmo-netif-dev \ + libosmo-ranap-dev \ libosmo-sccp-dev \ + libosmo-sigtran-dev \ libsmpp34-dev \ - libgtp-dev && \ + libgtp-dev \ + libasn1c-dev && \ apt-get clean WORKDIR /tmp @@ -36,7 +39,7 @@ (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_SGSN_BRANCH || exit 1); \ git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ autoreconf -fi && \ - ./configure && \ + ./configure --enable-iu && \ make -j8 install && \ ldconfig -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib9c2e96dc7309f7fcbd563d656b64d37f2599f7b Gerrit-Change-Number: 14920 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 09:06:02 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 24 Jul 2019 09:06:02 +0000 Subject: Change in ...osmo-ci[master]: jobs/master-builds.yml: add osmo-fl2k Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14921 Change subject: jobs/master-builds.yml: add osmo-fl2k ...................................................................... jobs/master-builds.yml: add osmo-fl2k Related: OS#3203 Depends: https://lists.osmocom.org/pipermail/osmocom-sdr/2019-July/001951.html Change-Id: Iac411a5d5e312b8db0b5388f58571141fb2f32df --- M docker/Dockerfile_osmocom_jenkins.amd64 M jobs/master-builds.yml 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/21/14921/1 diff --git a/docker/Dockerfile_osmocom_jenkins.amd64 b/docker/Dockerfile_osmocom_jenkins.amd64 index 3f499ad..91b0bf6 100644 --- a/docker/Dockerfile_osmocom_jenkins.amd64 +++ b/docker/Dockerfile_osmocom_jenkins.amd64 @@ -40,6 +40,9 @@ # for osmo-gsm-manuals RUN DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends xsltproc dblatex docbook5-xml graphviz python-pychart python-nwdiag libxml2-utils +# for osmo-fl2k +RUN DEBIAN_FRONTEND=noninteractive apt-get install -y cmake + # Linux kernel RUN DEBIAN_FRONTEND=noninteractive apt-get install -y bc diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 373e975..3f3816e 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -201,6 +201,17 @@ (FIRMWARE_VERSION == "origin/nrw/oc2g" && BTS_MODEL == "oc2g" && WITH_MANUALS == "0") cmd: 'PUBLISH=1 ./contrib/jenkins_bts_model.sh "$BTS_MODEL"' + - osmo-fl2k: + concurrent: true + cmd: | + docker run --rm=true \ + -e HOME=/build \ + -e PARALLEL_MAKE="$PARALLEL_MAKE" \ + -e PATH="$PATH:/build_bin" \ + -w /build -i -u build \ + -v "$PWD:/build" -v "$HOME/bin:/build_bin" \ + osmocom:amd64 /build/contrib/jenkins.sh + - osmo-ggsn: a1_name: GTP a1: !!python/tuple [--enable-gtp-linux,--disable-gtp-linux] -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iac411a5d5e312b8db0b5388f58571141fb2f32df Gerrit-Change-Number: 14921 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 09:06:33 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 24 Jul 2019 09:06:33 +0000 Subject: Change in ...osmo-ci[master]: jobs/master-builds.yml: add osmo-fl2k In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14921 ) Change subject: jobs/master-builds.yml: add osmo-fl2k ...................................................................... Patch Set 1: Setting to WIP until depending patch is merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iac411a5d5e312b8db0b5388f58571141fb2f32df Gerrit-Change-Number: 14921 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Wed, 24 Jul 2019 09:06:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 09:44:30 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 09:44:30 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional ...................................................................... gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional Change-Id: I940d220a399166122f33e67a222dd572085e1401 --- M src/gprs_bssgp_pcu.cpp 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/22/14922/1 diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index b34659b..3ea3e59 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -118,7 +118,11 @@ /* read IMSI. if no IMSI exists, use first paging block (any paging), * because during attachment the IMSI might not be known, so the MS * will listen to all paging blocks. */ - gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), TLVP_LEN(tp, BSSGP_IE_IMSI)); + if (TLVP_PRESENT(tp, BSSGP_IE_IMSI)) + { + gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), + TLVP_LEN(tp, BSSGP_IE_IMSI)); + } #if 0 /* Do not rely on this IE. TODO: make this configurable */ /* parse ms radio access capability */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401 Gerrit-Change-Number: 14922 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 09:44:30 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 09:44:30 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14923 Change subject: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() ...................................................................... gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() Change-Id: Id1ad279ce9bef38eb3d11ac62337276207e8d8bd --- M src/gprs_bssgp_pcu.cpp 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/23/14923/1 diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index 3ea3e59..730176a 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -93,6 +93,7 @@ char imsi[16] = "000"; uint8_t ms_class = 0; uint8_t egprs_ms_class = 0; + int rc; #if 0 MS_Radio_Access_capability_t rac; #endif @@ -120,8 +121,12 @@ * will listen to all paging blocks. */ if (TLVP_PRESENT(tp, BSSGP_IE_IMSI)) { - gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), - TLVP_LEN(tp, BSSGP_IE_IMSI)); + rc = gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), + TLVP_LEN(tp, BSSGP_IE_IMSI)); + if (rc) { + LOGP(DBSSGP, LOGL_NOTICE, "BSSGP TLLI=0x%08x Failed to parse IMSI IE\n", tlli); + return bssgp_tx_status(BSSGP_CAUSE_COND_IE_ERR, NULL, msg); + } } #if 0 /* Do not rely on this IE. TODO: make this configurable */ @@ -172,6 +177,7 @@ char imsi[16]; uint8_t *ptmsi = (uint8_t *) TLVP_VAL(tp, BSSGP_IE_TMSI); uint16_t ptmsi_len = TLVP_LEN(tp, BSSGP_IE_TMSI); + int rc; LOGP(DBSSGP, LOGL_NOTICE, " P-TMSI = "); for (int i = 0; i < ptmsi_len; i++) @@ -185,7 +191,12 @@ return -EINVAL; } - gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), TLVP_LEN(tp, BSSGP_IE_IMSI)); + rc = gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), + TLVP_LEN(tp, BSSGP_IE_IMSI)); + if (rc) { + LOGP(DBSSGP, LOGL_NOTICE, "Failed to parse IMSI IE\n"); + return bssgp_tx_status(BSSGP_CAUSE_COND_IE_ERR, NULL, msg); + } return gprs_rlcmac_paging_request(ptmsi, ptmsi_len, imsi); } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id1ad279ce9bef38eb3d11ac62337276207e8d8bd Gerrit-Change-Number: 14923 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:11:42 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Wed, 24 Jul 2019 10:11:42 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp at 121 PS1, Line 121: if (TLVP_PRESENT(tp, BSSGP_IE_IMSI)) This fixes the crash issue I was observing. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401 Gerrit-Change-Number: 14922 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Comment-Date: Wed, 24 Jul 2019 10:11:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:13:53 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Wed, 24 Jul 2019 10:13:53 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14923 ) Change subject: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14923/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/14923/1/src/gprs_bssgp_pcu.cpp at 127 PS1, Line 127: LOGP(DBSSGP, LOGL_NOTICE, "BSSGP TLLI=0x%08x Failed to parse IMSI IE\n", tlli); I see this really a LOT in the log. I wonder to we want to log it at DEBUG? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id1ad279ce9bef38eb3d11ac62337276207e8d8bd Gerrit-Change-Number: 14923 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: keith Gerrit-Comment-Date: Wed, 24 Jul 2019 10:13:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:27:57 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 10:27:57 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/burst_gen.py: basic TRXD header version 1 support In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14917 ) Change subject: trx_toolkit/burst_gen.py: basic TRXD header version 1 support ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icd4505d211816dc80e91d65094be92f2aed856bd Gerrit-Change-Number: 14917 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 10:27:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:28:11 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 10:28:11 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/burst_gen.py: basic TRXD header version 1 support In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14917 ) Change subject: trx_toolkit/burst_gen.py: basic TRXD header version 1 support ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icd4505d211816dc80e91d65094be92f2aed856bd Gerrit-Change-Number: 14917 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 10:28:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:30:51 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 10:30:51 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: add support for reading from PCAP file In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14914 ) Change subject: trx_toolkit/trx_sniff.py: add support for reading from PCAP file ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8a3481fbea5f6c917ae5684d0b5b806f4a76ff78 Gerrit-Change-Number: 14914 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 10:30:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:32:38 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 10:32:38 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: support sniffing on multiple ports In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14915 ) Change subject: trx_toolkit/trx_sniff.py: support sniffing on multiple ports ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14915/2/src/target/trx_toolkit/trx_sniff.py File src/target/trx_toolkit/trx_sniff.py: https://gerrit.osmocom.org/#/c/14915/2/src/target/trx_toolkit/trx_sniff.py at 211 PS2, Line 211: trx_group.add_argument("-p", "--base-port", "--base-ports", Are you sure it's correct keeping "--base-port" argument here? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I76b818c673b98c427b5621ddb852f947c74557d6 Gerrit-Change-Number: 14915 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 10:32:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:33:38 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 10:33:38 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: support additional capture filter In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14916 ) Change subject: trx_toolkit/trx_sniff.py: support additional capture filter ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I761debb2e1c411f2c6d489eac0adf32060966a4c Gerrit-Change-Number: 14916 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 10:33:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:34:53 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 10:34:53 +0000 Subject: Change in ...osmo-msc[master]: vlr_lu_fsm.c: don't send LU reject twice In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14899 ) Change subject: vlr_lu_fsm.c: don't send LU reject twice ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I127b27937613ea0ff29d67991c0414fca6d441d9 Gerrit-Change-Number: 14899 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 10:34:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:36:04 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 10:36:04 +0000 Subject: Change in ...docker-playground[master]: osmo-sgsn-master: Enable Iu support In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14920 ) Change subject: osmo-sgsn-master: Enable Iu support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib9c2e96dc7309f7fcbd563d656b64d37f2599f7b Gerrit-Change-Number: 14920 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 10:36:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:38:03 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 10:38:03 +0000 Subject: Change in ...osmo-sgsn[master]: manuals: Update vty/counter documentation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14535 ) Change subject: manuals: Update vty/counter documentation ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14535/2/doc/manuals/chapters/counters_generated.adoc File doc/manuals/chapters/counters_generated.adoc: https://gerrit.osmocom.org/#/c/14535/2/doc/manuals/chapters/counters_generated.adoc at a20 PS2, Line 20: Have these rate_ctr_group been dropped in recent osmo-sgsn? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id7245eb1011d1f04d5dfa1503a96d100bc98344c Gerrit-Change-Number: 14535 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 10:38:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:41:01 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 10:41:01 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp at 123 PS1, Line 123: gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), Did you check what happens on code below if imsi is not set? Adding description about that in the commit would be nice. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401 Gerrit-Change-Number: 14922 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 10:41:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:45:38 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 10:45:38 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14923 ) Change subject: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14923/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/14923/1/src/gprs_bssgp_pcu.cpp at 127 PS1, Line 127: LOGP(DBSSGP, LOGL_NOTICE, "BSSGP TLLI=0x%08x Failed to parse IMSI IE\n", tlli); > I see this really a LOT in the log. [?] How can that happen a lot? is the MS sending an incorrect format for this IE? Or do we have a bug in gsm48_mi_to_string? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id1ad279ce9bef38eb3d11ac62337276207e8d8bd Gerrit-Change-Number: 14923 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-CC: keith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 10:45:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:49:23 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 10:49:23 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: support sniffing on multiple ports In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14915 ) Change subject: trx_toolkit/trx_sniff.py: support sniffing on multiple ports ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14915/2/src/target/trx_toolkit/trx_sniff.py File src/target/trx_toolkit/trx_sniff.py: https://gerrit.osmocom.org/#/c/14915/2/src/target/trx_toolkit/trx_sniff.py at 211 PS2, Line 211: trx_group.add_argument("-p", "--base-port", "--base-ports", > Are you sure it's correct keeping "--base-port" argument here? Yep, it's kept for backwards compatibility. One can still specify only one base port. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I76b818c673b98c427b5621ddb852f947c74557d6 Gerrit-Change-Number: 14915 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 10:49:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:51:17 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 10:51:17 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: support sniffing on multiple ports In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14915 ) Change subject: trx_toolkit/trx_sniff.py: support sniffing on multiple ports ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I76b818c673b98c427b5621ddb852f947c74557d6 Gerrit-Change-Number: 14915 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 10:51:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 10:56:14 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 10:56:14 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14923 ) Change subject: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14923/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/14923/1/src/gprs_bssgp_pcu.cpp at 127 PS1, Line 127: LOGP(DBSSGP, LOGL_NOTICE, "BSSGP TLLI=0x%08x Failed to parse IMSI IE\n", tlli); > I see this really a LOT in the log. [?] Then we have a bug somewhere else in the code. Or gsm48_mi_to_string() is simply not applicable here :/ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id1ad279ce9bef38eb3d11ac62337276207e8d8bd Gerrit-Change-Number: 14923 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: keith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 10:56:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:00:20 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Wed, 24 Jul 2019 11:00:20 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp at 123 PS1, Line 123: gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), > Did you check what happens on code below if imsi is not set? Adding description about that in the co [?] I think you never get to the code below if imsi is not set, we crash first. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401 Gerrit-Change-Number: 14922 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 11:00:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:02:06 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Wed, 24 Jul 2019 11:02:06 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14923 ) Change subject: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14923/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/14923/1/src/gprs_bssgp_pcu.cpp at 127 PS1, Line 127: LOGP(DBSSGP, LOGL_NOTICE, "BSSGP TLLI=0x%08x Failed to parse IMSI IE\n", tlli); > How can that happen a lot? is the MS sending an incorrect format for this IE? Or do we have a bug in [?] It seems to be always followed by: gprs_bssgp_util.c:238 BSSGP BVCI=0 Tx STATUS, cause=Conditional IE error (running a slightly older osmo-bts here, in case that might have anything to do with it) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id1ad279ce9bef38eb3d11ac62337276207e8d8bd Gerrit-Change-Number: 14923 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: keith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 11:02:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: keith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:07:19 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Wed, 24 Jul 2019 11:07:19 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14923 ) Change subject: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() ...................................................................... Patch Set 1: > (1 comment) for example: https://pastebin.com/nh1T2gwK -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id1ad279ce9bef38eb3d11ac62337276207e8d8bd Gerrit-Change-Number: 14923 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: keith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 11:07:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:08:57 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 11:08:57 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/burst_gen.py: basic TRXD header version 1 support In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14917 ) Change subject: trx_toolkit/burst_gen.py: basic TRXD header version 1 support ...................................................................... trx_toolkit/burst_gen.py: basic TRXD header version 1 support Change-Id: Icd4505d211816dc80e91d65094be92f2aed856bd --- M src/target/trx_toolkit/burst_gen.py 1 file changed, 27 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/target/trx_toolkit/burst_gen.py b/src/target/trx_toolkit/burst_gen.py index 5f39e6a..a777246 100755 --- a/src/target/trx_toolkit/burst_gen.py +++ b/src/target/trx_toolkit/burst_gen.py @@ -5,7 +5,7 @@ # Auxiliary tool to generate and send random bursts via TRX DATA # interface, which may be useful for fuzzing and testing # -# (C) 2017-2018 by Vadim Yanitskiy +# (C) 2017-2019 by Vadim Yanitskiy # # All Rights Reserved # @@ -23,7 +23,7 @@ # with this program; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -APP_CR_HOLDERS = [("2017-2018", "Vadim Yanitskiy ")] +APP_CR_HOLDERS = [("2017-2019", "Vadim Yanitskiy ")] import logging as log import signal @@ -68,9 +68,9 @@ # Init an empty DATA message if self.argv.conn_mode == "TRX": - msg = DATAMSG_L12TRX() + msg = DATAMSG_L12TRX(ver = self.argv.hdr_ver) elif self.argv.conn_mode == "L1": - msg = DATAMSG_TRX2L1() + msg = DATAMSG_TRX2L1(ver = self.argv.hdr_ver) # Generate a random frame number or use provided one fn_init = msg.rand_fn() if self.argv.tdma_fn is None \ @@ -102,6 +102,17 @@ if self.argv.rssi is not None: msg.rssi = self.argv.rssi + if msg.ver >= 0x01: + # TODO: Only GMSK and TSC set 0 for now + msg.mod_type = Modulation.ModGMSK + self.tsc_set = 0 + + if self.argv.tsc is not None: + msg.tsc = self.argv.tsc + + if self.argv.ci is not None: + msg.ci = self.argv.ci + # Generate a random burst if self.argv.burst_type == "NB": burst = burst_gen.gen_nb() @@ -163,6 +174,10 @@ bg_group.add_argument("-c", "--burst-count", metavar = "N", dest = "burst_count", type = int, default = 1, help = "How many bursts to send (default %(default)s)") + bg_group.add_argument("-v", "--hdr-version", metavar = "VER", + dest = "hdr_ver", type = int, + default = 0, choices = DATAMSG.known_versions, + help = "TRXD header version (default %(default)s)") bg_group.add_argument("-f", "--frame-number", metavar = "FN", dest = "tdma_fn", type = int, help = "Set TDMA frame number (default random)") @@ -186,6 +201,14 @@ dest = "toa256", type = int, help = "Set Timing of Arrival in 1/256 symbol periods") + bg_group.add_argument("--tsc", metavar = "TSC", + dest = "tsc", type = int, choices = range(0, 8), + help = "Set Training Sequence Code (default random)") + bg_group.add_argument("--ci", metavar = "CI", + dest = "ci", type = int, + help = "C/I: Carrier-to-Interference ratio " + "in centiBels (default random)") + return parser.parse_args() def sig_handler(self, signum, frame): -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icd4505d211816dc80e91d65094be92f2aed856bd Gerrit-Change-Number: 14917 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:08:58 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 11:08:58 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: add support for reading from PCAP file In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14914 ) Change subject: trx_toolkit/trx_sniff.py: add support for reading from PCAP file ...................................................................... trx_toolkit/trx_sniff.py: add support for reading from PCAP file Change-Id: I8a3481fbea5f6c917ae5684d0b5b806f4a76ff78 --- M src/target/trx_toolkit/trx_sniff.py 1 file changed, 23 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/target/trx_toolkit/trx_sniff.py b/src/target/trx_toolkit/trx_sniff.py index 6592455..45a5cf4 100755 --- a/src/target/trx_toolkit/trx_sniff.py +++ b/src/target/trx_toolkit/trx_sniff.py @@ -61,18 +61,29 @@ pkt_filter = "udp and (port %d or port %d)" \ % (self.argv.base_port + 2, self.argv.base_port + 102) - log.info("Listening on interface '%s'..." % self.argv.sniff_if) + # Arguments to be passed to scapy.all.sniff() + sniff_args = { + "prn" : self.pkt_handler, + "filter" : pkt_filter, + "store" : 0, + } + + if self.argv.cap_file is not None: + log.info("Reading packets from '%s'..." % self.argv.cap_file) + sniff_args["offline"] = self.argv.cap_file + else: + log.info("Listening on interface '%s'..." % self.argv.sniff_if) + sniff_args["iface"] = self.argv.sniff_if # Start sniffing... - scapy.all.sniff(iface = self.argv.sniff_if, store = 0, - filter = pkt_filter, prn = self.pkt_handler) + scapy.all.sniff(**sniff_args) # Scapy registers its own signal handler self.shutdown() def pkt_handler(self, ether): # Prevent loopback packet duplication - if self.argv.sniff_if == "lo": + if self.argv.sniff_if == "lo" and self.argv.cap_file is None: self.lo_trigger = not self.lo_trigger if not self.lo_trigger: return @@ -197,9 +208,6 @@ self.app_reg_logging_options(parser) trx_group = parser.add_argument_group("TRX interface") - trx_group.add_argument("-i", "--sniff-interface", - dest = "sniff_if", type = str, default = "lo", metavar = "IF", - help = "Set network interface (default '%(default)s')") trx_group.add_argument("-p", "--base-port", dest = "base_port", type = int, default = 6700, help = "Set base port number (default %(default)s)") @@ -207,6 +215,14 @@ dest = "output_file", type = str, help = "Write bursts to a capture file") + input_group = trx_group.add_mutually_exclusive_group() + input_group.add_argument("-i", "--sniff-interface", + dest = "sniff_if", type = str, default = "lo", metavar = "IF", + help = "Set network interface (default '%(default)s')") + input_group.add_argument("-r", "--capture-file", + dest = "cap_file", type = str, metavar = "FILE", + help = "Read packets from a PCAP file") + cnt_group = parser.add_argument_group("Count limitations (optional)") cnt_group.add_argument("--frame-count", metavar = "N", dest = "frame_count", type = int, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8a3481fbea5f6c917ae5684d0b5b806f4a76ff78 Gerrit-Change-Number: 14914 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:08:58 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 11:08:58 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: support sniffing on multiple ports In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14915 ) Change subject: trx_toolkit/trx_sniff.py: support sniffing on multiple ports ...................................................................... trx_toolkit/trx_sniff.py: support sniffing on multiple ports Change-Id: I76b818c673b98c427b5621ddb852f947c74557d6 --- M src/target/trx_toolkit/trx_sniff.py 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/target/trx_toolkit/trx_sniff.py b/src/target/trx_toolkit/trx_sniff.py index 45a5cf4..7eea04c 100755 --- a/src/target/trx_toolkit/trx_sniff.py +++ b/src/target/trx_toolkit/trx_sniff.py @@ -57,14 +57,14 @@ self.ddf = DATADumpFile(self.argv.output_file) def run(self): - # Compose a packet filter - pkt_filter = "udp and (port %d or port %d)" \ - % (self.argv.base_port + 2, self.argv.base_port + 102) + # Compose a list of permitted UDP ports + rx_port_list = ["port %d" % (port + 102) for port in self.argv.base_ports] + tx_port_list = ["port %d" % (port + 2) for port in self.argv.base_ports] # Arguments to be passed to scapy.all.sniff() sniff_args = { + "filter" : "udp and (%s)" % " or ".join(rx_port_list + tx_port_list), "prn" : self.pkt_handler, - "filter" : pkt_filter, "store" : 0, } @@ -208,8 +208,9 @@ self.app_reg_logging_options(parser) trx_group = parser.add_argument_group("TRX interface") - trx_group.add_argument("-p", "--base-port", - dest = "base_port", type = int, default = 6700, + trx_group.add_argument("-p", "--base-port", "--base-ports", + dest = "base_ports", type = int, metavar = "PORT", + default = [5700, 6700], nargs = "*", help = "Set base port number (default %(default)s)") trx_group.add_argument("-o", "--output-file", metavar = "FILE", dest = "output_file", type = str, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I76b818c673b98c427b5621ddb852f947c74557d6 Gerrit-Change-Number: 14915 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:08:58 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 11:08:58 +0000 Subject: Change in ...osmocom-bb[master]: trx_toolkit/trx_sniff.py: support additional capture filter In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14916 ) Change subject: trx_toolkit/trx_sniff.py: support additional capture filter ...................................................................... trx_toolkit/trx_sniff.py: support additional capture filter Change-Id: I761debb2e1c411f2c6d489eac0adf32060966a4c --- M src/target/trx_toolkit/trx_sniff.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/target/trx_toolkit/trx_sniff.py b/src/target/trx_toolkit/trx_sniff.py index 7eea04c..0323e85 100755 --- a/src/target/trx_toolkit/trx_sniff.py +++ b/src/target/trx_toolkit/trx_sniff.py @@ -75,6 +75,10 @@ log.info("Listening on interface '%s'..." % self.argv.sniff_if) sniff_args["iface"] = self.argv.sniff_if + if self.argv.cap_filter is not None: + log.info("Using additional capture filter '%s'" % self.argv.cap_filter) + sniff_args["filter"] += " and (%s)" % self.argv.cap_filter + # Start sniffing... scapy.all.sniff(**sniff_args) @@ -224,6 +228,10 @@ dest = "cap_file", type = str, metavar = "FILE", help = "Read packets from a PCAP file") + trx_group.add_argument("-f", "--capture-filter", + dest = "cap_filter", type = str, metavar = "FILTER", + help = "Set additional capture filter (e.g. 'host 192.168.1.2')") + cnt_group = parser.add_argument_group("Count limitations (optional)") cnt_group.add_argument("--frame-count", metavar = "N", dest = "frame_count", type = int, -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/14916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I761debb2e1c411f2c6d489eac0adf32060966a4c Gerrit-Change-Number: 14916 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:12:38 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Wed, 24 Jul 2019 11:12:38 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp at 123 PS1, Line 123: gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), > I think you never get to the code below if imsi is not set, we crash first. Ah you mean after this patch? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401 Gerrit-Change-Number: 14922 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 11:12:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: keith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:31:37 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 11:31:37 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): use OSMO_IMSI_BUF_SIZE Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14924 Change subject: gprs_bssgp_pcu_rx_dl_ud(): use OSMO_IMSI_BUF_SIZE ...................................................................... gprs_bssgp_pcu_rx_dl_ud(): use OSMO_IMSI_BUF_SIZE Change-Id: Ia1da9f005b7f801872c542d31cc8eabd859d997a --- M src/gprs_bssgp_pcu.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/24/14924/1 diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index f7c681c..ddf5174 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -91,7 +91,7 @@ uint32_t tlli_old = 0; uint8_t *data; uint16_t len; - char imsi[16] = "000"; + char imsi[OSMO_IMSI_BUF_SIZE] = "000"; uint8_t ms_class = 0; uint8_t egprs_ms_class = 0; int rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14924 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia1da9f005b7f801872c542d31cc8eabd859d997a Gerrit-Change-Number: 14924 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:31:44 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 11:31:44 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14923 ) Change subject: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id1ad279ce9bef38eb3d11ac62337276207e8d8bd Gerrit-Change-Number: 14923 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: keith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 11:31:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:33:01 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 24 Jul 2019 11:33:01 +0000 Subject: Change in ...osmo-msc[master]: vlr_lu_fsm.c: don't send LU reject twice In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14899 ) Change subject: vlr_lu_fsm.c: don't send LU reject twice ...................................................................... Patch Set 2: Code-Review+2 1+1=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I127b27937613ea0ff29d67991c0414fca6d441d9 Gerrit-Change-Number: 14899 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 11:33:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:33:12 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 24 Jul 2019 11:33:12 +0000 Subject: Change in ...osmo-msc[master]: vlr_lu_fsm.c: don't send LU reject twice In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14899 ) Change subject: vlr_lu_fsm.c: don't send LU reject twice ...................................................................... vlr_lu_fsm.c: don't send LU reject twice Don't call tx_lu_rej() in the "vlr_lu_compl" FSM. It is always getting called in the parent "lu" FSM and is therefore redundant: _vlr_lu_compl_fsm_done(fi, VLR_FSM_RESULT_FAILURE, cause) -> osmo_fsm_inst_state_chg(fi, LU_COMPL_VLR_S_DONE, 0, 0) -> vlr_lu_compl_fsm_dispatch_result() -> lu_fsm_wait_lu_compl()/lu_fsm_wait_lu_compl_standalone() -> lu_fsm_failure() -> lfp->vlr->ops.tx_lu_rej() I have noticed the bug with the TTCN3 tests. This patch fixes TC_lu_imsi_auth_tmsi_check_imei_{nack,err} after stricter checking in [1] and also TC_iu_mo_crcx_ran_reject. [1] I836f76242463789c4c003feec757714827f2a31b (osmo-ttcn3-hacks) Change-Id: I127b27937613ea0ff29d67991c0414fca6d441d9 --- M src/libvlr/vlr_lu_fsm.c M tests/msc_vlr/msc_vlr_test_gsm_authen.err 2 files changed, 4 insertions(+), 15 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 9dff4aa..87bf7a5 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -366,13 +366,6 @@ vlr_sgs_fsm_update_id(vsub); } -static void vlr_lu_compl_fsm_failure(struct osmo_fsm_inst *fi, uint8_t cause) -{ - struct lu_compl_vlr_priv *lcvp = lu_compl_vlr_fi_priv(fi); - lcvp->vsub->vlr->ops.tx_lu_rej(lcvp->msc_conn_ref, cause); - _vlr_lu_compl_fsm_done(fi, VLR_FSM_RESULT_FAILURE, cause); -} - static void vlr_lu_compl_fsm_dispatch_result(struct osmo_fsm_inst *fi, uint32_t prev_state) { @@ -434,8 +427,7 @@ LOGPFSM(fi, "%s()\n", __func__); if (vlr_subscr_alloc_tmsi(vsub)) { - vlr_lu_compl_fsm_failure(fi, - GSM48_REJECT_SRV_OPT_TMP_OUT_OF_ORDER); + _vlr_lu_compl_fsm_done(fi, VLR_FSM_RESULT_FAILURE, GSM48_REJECT_SRV_OPT_TMP_OUT_OF_ORDER); return; } @@ -495,15 +487,14 @@ case LU_COMPL_VLR_E_IMEI_CHECK_ACK: if (!vsub->imei[0]) { /* Abort: Do nothing */ - vlr_lu_compl_fsm_failure(fi, - GSM48_REJECT_PROTOCOL_ERROR); + _vlr_lu_compl_fsm_done(fi, VLR_FSM_RESULT_FAILURE, GSM48_REJECT_PROTOCOL_ERROR); return; } /* Pass */ break; case LU_COMPL_VLR_E_IMEI_CHECK_NACK: - vlr_lu_compl_fsm_failure(fi, GSM48_REJECT_ILLEGAL_ME); + _vlr_lu_compl_fsm_done(fi, VLR_FSM_RESULT_FAILURE, GSM48_REJECT_ILLEGAL_ME); /* FIXME: IMEI Check Fail to VLR Application (Detach IMSI VLR) */ return; } @@ -544,7 +535,7 @@ LOGPFSML(fi, LOGL_ERROR, "TMSI Realloc Compl implies that" " the subscriber has a new TMSI allocated, but" " the new TMSI is unset.\n"); - vlr_lu_compl_fsm_failure(fi, GSM48_REJECT_NETWORK_FAILURE); + _vlr_lu_compl_fsm_done(fi, VLR_FSM_RESULT_FAILURE, GSM48_REJECT_NETWORK_FAILURE); return; } diff --git a/tests/msc_vlr/msc_vlr_test_gsm_authen.err b/tests/msc_vlr/msc_vlr_test_gsm_authen.err index 0a18302..c9be4ef 100644 --- a/tests/msc_vlr/msc_vlr_test_gsm_authen.err +++ b/tests/msc_vlr/msc_vlr_test_gsm_authen.err @@ -1907,7 +1907,6 @@ DREF VLR subscr IMSI-901700000004620:MSISDN-46071 + vlr_gsup_rx: now used by 2 (active-conn,vlr_gsup_rx) DVLR vlr_lu_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){VLR_ULA_S_WAIT_LU_COMPL}: Received Event VLR_ULA_E_HLR_IMEI_NACK DVLR lu_compl_vlr_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){LU_COMPL_VLR_S_WAIT_IMEI}: Received Event LU_COMPL_VLR_E_IMEI_CHECK_NACK -- sending LU Reject for IMSI-901700000004620:MSISDN-46071:GERAN-A:LU, cause 6 DVLR lu_compl_vlr_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){LU_COMPL_VLR_S_WAIT_IMEI}: state_chg to LU_COMPL_VLR_S_DONE DVLR vlr_lu_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){VLR_ULA_S_WAIT_LU_COMPL}: Received Event VLR_ULA_E_LU_COMPL_FAILURE DVLR lu_compl_vlr_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){LU_COMPL_VLR_S_DONE}: Terminating (cause = OSMO_FSM_TERM_PARENT) @@ -2174,7 +2173,6 @@ DVLR SUBSCR(IMSI-901700000004620:MSISDN-46071) Check_IMEI_VLR failed; gmm_cause: Invalid mandatory information DVLR vlr_lu_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){VLR_ULA_S_WAIT_LU_COMPL}: Received Event VLR_ULA_E_HLR_IMEI_NACK DVLR lu_compl_vlr_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){LU_COMPL_VLR_S_WAIT_IMEI}: Received Event LU_COMPL_VLR_E_IMEI_CHECK_NACK -- sending LU Reject for IMSI-901700000004620:MSISDN-46071:GERAN-A:LU, cause 6 DVLR lu_compl_vlr_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){LU_COMPL_VLR_S_WAIT_IMEI}: state_chg to LU_COMPL_VLR_S_DONE DVLR vlr_lu_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){VLR_ULA_S_WAIT_LU_COMPL}: Received Event VLR_ULA_E_LU_COMPL_FAILURE DVLR lu_compl_vlr_fsm(IMSI-901700000004620:MSISDN-46071:GERAN-A:LU){LU_COMPL_VLR_S_DONE}: Terminating (cause = OSMO_FSM_TERM_PARENT) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14899 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I127b27937613ea0ff29d67991c0414fca6d441d9 Gerrit-Change-Number: 14899 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:33:42 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 24 Jul 2019 11:33:42 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: use f_expect_clear() in check IMEI tests In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 ) Change subject: msc: use f_expect_clear() in check IMEI tests ...................................................................... msc: use f_expect_clear() in check IMEI tests Fix the broken pipe race condition caused by closing the RAN connection too early. Properly wait for clear command and send clear complete. TC_lu_imsi_auth_tmsi_check_imei_{nack,err} do not pass anymore, because OsmoMSC is sending the LU reject twice. Patch [1] fixes it. [1] I127b27937613ea0ff29d67991c0414fca6d441d9 (osmo-msc) Fixes: 1d118ff753d963cfe5feb2450a31bc3a51aa5eb6 ("msc: add check IMEI tests") Change-Id: I836f76242463789c4c003feec757714827f2a31b --- M msc/MSC_Tests.ttcn M msc/expected-results.xml 2 files changed, 9 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index c7c96eb..15ff17c 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -5618,7 +5618,7 @@ f_msc_lu_hlr(); f_mm_imei(); - /* Expect reject. As of writing, sometimes it passes, sometimes we get a broken pipe (race condition)! */ + /* Expect reject */ alt { [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { setverdict(pass); @@ -5628,6 +5628,7 @@ mtc.stop; } } + f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_nack() runs on MTC_CT { var BSC_ConnHdlr vc_conn; @@ -5658,7 +5659,7 @@ f_msc_lu_hlr(); f_mm_imei(); - /* Expect reject. As of writing, sometimes it passes, sometimes we get a broken pipe (race condition)! */ + /* Expect reject */ alt { [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { setverdict(pass); @@ -5668,6 +5669,7 @@ mtc.stop; } } + f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_err() runs on MTC_CT { var BSC_ConnHdlr vc_conn; @@ -5769,6 +5771,7 @@ mtc.stop; } } + f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_early_nack() runs on MTC_CT { var BSC_ConnHdlr vc_conn; @@ -5807,6 +5810,7 @@ mtc.stop; } } + f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_early_err() runs on MTC_CT { var BSC_ConnHdlr vc_conn; diff --git a/msc/expected-results.xml b/msc/expected-results.xml index 28a6728..96af4a4 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -1,5 +1,5 @@ - + @@ -102,12 +102,8 @@ - - - - - - + + -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14900 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I836f76242463789c4c003feec757714827f2a31b Gerrit-Change-Number: 14900 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:41:53 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 11:41:53 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14923 ) Change subject: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id1ad279ce9bef38eb3d11ac62337276207e8d8bd Gerrit-Change-Number: 14923 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: keith Gerrit-Comment-Date: Wed, 24 Jul 2019 11:41:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:43:48 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 11:43:48 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp at 123 PS1, Line 123: gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), > Ah you mean after this patch? lol, of course I mean after the patch :) maybe code after this point still expects "imsi" var to be filled correctly. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401 Gerrit-Change-Number: 14922 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 11:43:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: keith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:44:03 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 11:44:03 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): use OSMO_IMSI_BUF_SIZE In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14924 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): use OSMO_IMSI_BUF_SIZE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14924 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia1da9f005b7f801872c542d31cc8eabd859d997a Gerrit-Change-Number: 14924 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 11:44:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 11:45:08 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 11:45:08 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: check IMEI: move reject LU into new function In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 ) Change subject: msc: check IMEI: move reject LU into new function ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifad259e21df035a89e97831a57c0675502308eb6 Gerrit-Change-Number: 14901 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 11:45:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 12:03:11 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 24 Jul 2019 12:03:11 +0000 Subject: Change in ...osmo-sgsn[master]: manuals: Update vty/counter documentation In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14535 ) Change subject: manuals: Update vty/counter documentation ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/14535/2/doc/manuals/chapters/counters_generated.adoc File doc/manuals/chapters/counters_generated.adoc: https://gerrit.osmocom.org/#/c/14535/2/doc/manuals/chapters/counters_generated.adoc at a20 PS2, Line 20: > Have these rate_ctr_group been dropped in recent osmo-sgsn? It's the same as the one above, just removing duplication https://gerrit.osmocom.org/#/c/14535/2/doc/manuals/chapters/counters_generated.adoc at a48 PS2, Line 48: The NSVC Peer is also present below on line 79/51 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id7245eb1011d1f04d5dfa1503a96d100bc98344c Gerrit-Change-Number: 14535 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 12:03:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 12:05:38 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 12:05:38 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp at 123 PS1, Line 123: gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), > Did you check what happens on code below if imsi is not set? Adding description about that in the co [?] Nope, I didn't check. The proposed change makes it work in the same way as before. If the IE is absent, IMSI would be "000". I don't know how this case is handled later, and unfortunately have no time to investigate... -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401 Gerrit-Change-Number: 14922 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 12:05:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 12:05:57 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 12:05:57 +0000 Subject: Change in ...osmo-sgsn[master]: manuals: Update vty/counter documentation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14535 ) Change subject: manuals: Update vty/counter documentation ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id7245eb1011d1f04d5dfa1503a96d100bc98344c Gerrit-Change-Number: 14535 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 12:05:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 12:07:04 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Wed, 24 Jul 2019 12:07:04 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14923 ) Change subject: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id1ad279ce9bef38eb3d11ac62337276207e8d8bd Gerrit-Change-Number: 14923 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 12:07:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 12:14:40 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Wed, 24 Jul 2019 12:14:40 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/#/c/14922/1/src/gprs_bssgp_pcu.cpp at 123 PS1, Line 123: gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), > Nope, I didn't check. The proposed change makes it work in the same way as before. [?] I generally see a lot of IMSI=000 in the pcu vty with show ms all So I imagine as fixeria says, that at worst here, we do what we did before f3038e7b2a27270185337ec707dee5f4b9b25826 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401 Gerrit-Change-Number: 14922 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 12:14:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 12:15:48 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Wed, 24 Jul 2019 12:15:48 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional ...................................................................... Patch Set 1: > (1 comment) That's not to say this might not be a good time to investigate, but I vote to merge this anyway, because without this patch, my osmo-pcu crashes within a few seconds. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401 Gerrit-Change-Number: 14922 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 12:15:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 12:19:02 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 12:19:02 +0000 Subject: Change in ...osmo-hlr[master]: hlr_ussd.c: rx_proc_ss_req(): fix NULL pointer dereference Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14925 Change subject: hlr_ussd.c: rx_proc_ss_req(): fix NULL pointer dereference ...................................................................... hlr_ussd.c: rx_proc_ss_req(): fix NULL pointer dereference The SS payload is mandatory for GSUP PROC_SS_{REQ,RSP} messages with session state BEGIN or CONTINUE, and optional for the END. Make sure that it's present for both BEGIN and CONTINUE, consider received message as incorrect otherwise. In case of the END, call handle_ussd() / handle_ss() only if SS payload is present. Change-Id: Ia71cabbf396bd1388e764a1749e953ac1782e307 Fixes: CID#188841 --- M src/hlr_ussd.c 1 file changed, 16 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/25/14925/1 diff --git a/src/hlr_ussd.c b/src/hlr_ussd.c index 773c571..1568815 100644 --- a/src/hlr_ussd.c +++ b/src/hlr_ussd.c @@ -519,6 +519,11 @@ /* FIXME: Send a Reject component? */ goto out_err; } + } else if (gsup->session_state != OSMO_GSUP_SESSION_STATE_END) { + LOGP(DSS, LOGL_ERROR, "%s/0x%082x: Missing SS payload for '%s'\n", + gsup->imsi, gsup->session_id, + osmo_gsup_session_state_name(gsup->session_state)); + goto out_err; } switch (gsup->session_state) { @@ -606,13 +611,18 @@ gsup->imsi, gsup->session_id); goto out_err; } - if (ss_op_is_ussd(req.opcode)) { - /* dispatch unstructured SS to routing */ - handle_ussd(conn, ss, gsup, &req); - } else { - /* dispatch non-call SS to internal code */ - handle_ss(ss, gsup, &req); + + /* SS payload is optional for END */ + if (gsup->ss_info && gsup->ss_info_len) { + if (ss_op_is_ussd(req.opcode)) { + /* dispatch unstructured SS to routing */ + handle_ussd(conn, ss, gsup, &req); + } else { + /* dispatch non-call SS to internal code */ + handle_ss(ss, gsup, &req); + } } + ss_session_free(ss); break; default: -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14925 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ia71cabbf396bd1388e764a1749e953ac1782e307 Gerrit-Change-Number: 14925 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 12:19:40 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 12:19:40 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401 Gerrit-Change-Number: 14922 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 12:19:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 13:10:56 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Wed, 24 Jul 2019 13:10:56 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): use OSMO_IMSI_BUF_SIZE In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14924 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): use OSMO_IMSI_BUF_SIZE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14924 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia1da9f005b7f801872c542d31cc8eabd859d997a Gerrit-Change-Number: 14924 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 13:10:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 13:42:09 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Wed, 24 Jul 2019 13:42:09 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: msc: check IMEI: move reject LU into new function In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 ) Change subject: msc: check IMEI: move reject LU into new function ...................................................................... msc: check IMEI: move reject LU into new function Change-Id: Ifad259e21df035a89e97831a57c0675502308eb6 --- M msc/BSC_ConnectionHandler.ttcn M msc/MSC_Tests.ttcn 2 files changed, 22 insertions(+), 48 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, approved diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index e951400..fb2d888 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -642,6 +642,24 @@ setverdict(pass); } +function f_expect_lu_reject() runs on BSC_ConnHdlr { + var PDU_DTAP_MT dtap_mt; + timer T := 5.0; + + T.start; + alt { + [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { + setverdict(pass); + } + [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { + setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); + } + [] T.timeout { + setverdict(fail, "Timeout waiting for LU reject"); + } + } +} + function f_foo() runs on BSC_ConnHdlr{ /* SCCP CC handled by RAN_Emulation_CT.main() */ /* Expect auth, if enabled */ diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 15ff17c..c463dd5 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -5601,7 +5601,6 @@ private function f_tc_lu_imsi_auth_tmsi_check_imei_nack(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { var PDU_ML3_MS_NW l3_lu; - var PDU_DTAP_MT dtap_mt; pars.net.expect_auth := true; pars.net.expect_imei := true; @@ -5617,17 +5616,7 @@ f_mm_common(); f_msc_lu_hlr(); f_mm_imei(); - - /* Expect reject */ - alt { - [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { - setverdict(pass); - } - [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { - setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); - mtc.stop; - } - } + f_expect_lu_reject(); f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_nack() runs on MTC_CT { @@ -5642,7 +5631,6 @@ private function f_tc_lu_imsi_auth_tmsi_check_imei_err(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { var PDU_ML3_MS_NW l3_lu; - var PDU_DTAP_MT dtap_mt; pars.net.expect_auth := true; pars.net.expect_imei := true; @@ -5658,17 +5646,7 @@ f_mm_common(); f_msc_lu_hlr(); f_mm_imei(); - - /* Expect reject */ - alt { - [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { - setverdict(pass); - } - [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { - setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); - mtc.stop; - } - } + f_expect_lu_reject(); f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_err() runs on MTC_CT { @@ -5746,7 +5724,6 @@ private function f_tc_lu_imsi_auth_tmsi_check_imei_early_nack(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { var PDU_ML3_MS_NW l3_lu; - var PDU_DTAP_MT dtap_mt; pars.net.expect_auth := true; pars.net.expect_imei_early := true; @@ -5760,17 +5737,7 @@ BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); f_mm_imei_early(); - - /* Expect reject */ - alt { - [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { - setverdict(pass); - } - [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { - setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); - mtc.stop; - } - } + f_expect_lu_reject(); f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_early_nack() runs on MTC_CT { @@ -5785,7 +5752,6 @@ private function f_tc_lu_imsi_auth_tmsi_check_imei_early_err(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { var PDU_ML3_MS_NW l3_lu; - var PDU_DTAP_MT dtap_mt; pars.net.expect_auth := true; pars.net.expect_imei_early := true; @@ -5799,17 +5765,7 @@ BSSAP.send(ts_BSSMAP_ClassmarkUpd(g_pars.cm2, g_pars.cm3)); f_mm_imei_early(); - - /* Expect reject */ - alt { - [] BSSAP.receive(tr_PDU_DTAP_MT(tr_ML3_MT_LU_Rej)) { - setverdict(pass); - } - [] BSSAP.receive(tr_PDU_DTAP_MT(?)) -> value dtap_mt { - setverdict(fail, "Expected LU reject BSSAP message, got: ", dtap_mt); - mtc.stop; - } - } + f_expect_lu_reject(); f_expect_clear(); } testcase TC_lu_imsi_auth_tmsi_check_imei_early_err() runs on MTC_CT { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifad259e21df035a89e97831a57c0675502308eb6 Gerrit-Change-Number: 14901 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 13:43:53 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 24 Jul 2019 13:43:53 +0000 Subject: Change in ...docker-playground[master]: osmo-sgsn-master: Enable Iu support In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14920 ) Change subject: osmo-sgsn-master: Enable Iu support ...................................................................... Patch Set 1: Verified+1 Right, my job to verify. Container builds and works with regen_doc.py as well as ttcn3-sgsn-master -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib9c2e96dc7309f7fcbd563d656b64d37f2599f7b Gerrit-Change-Number: 14920 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 13:43:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 13:44:02 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 24 Jul 2019 13:44:02 +0000 Subject: Change in ...docker-playground[master]: osmo-sgsn-master: Enable Iu support In-Reply-To: References: Message-ID: daniel has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14920 ) Change subject: osmo-sgsn-master: Enable Iu support ...................................................................... osmo-sgsn-master: Enable Iu support So far the SGSN master image is built without Iu support. osmo-sgsn-latest is using the built debian packages which enable Iu support, so it's not an issue there. Change-Id: Ib9c2e96dc7309f7fcbd563d656b64d37f2599f7b --- M osmo-sgsn-master/Dockerfile 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved daniel: Verified diff --git a/osmo-sgsn-master/Dockerfile b/osmo-sgsn-master/Dockerfile index 4257141..9f31788 100644 --- a/osmo-sgsn-master/Dockerfile +++ b/osmo-sgsn-master/Dockerfile @@ -19,9 +19,12 @@ libosmo-abis-dev \ libosmo-gsup-client-dev \ libosmo-netif-dev \ + libosmo-ranap-dev \ libosmo-sccp-dev \ + libosmo-sigtran-dev \ libsmpp34-dev \ - libgtp-dev && \ + libgtp-dev \ + libasn1c-dev && \ apt-get clean WORKDIR /tmp @@ -36,7 +39,7 @@ (git symbolic-ref -q HEAD && git reset --hard origin/$OSMO_SGSN_BRANCH || exit 1); \ git rev-parse --abbrev-ref HEAD && git rev-parse HEAD && \ autoreconf -fi && \ - ./configure && \ + ./configure --enable-iu && \ make -j8 install && \ ldconfig -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib9c2e96dc7309f7fcbd563d656b64d37f2599f7b Gerrit-Change-Number: 14920 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 13:44:25 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 24 Jul 2019 13:44:25 +0000 Subject: Change in ...osmo-sgsn[master]: manuals: Update vty/counter documentation In-Reply-To: References: Message-ID: daniel has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14535 ) Change subject: manuals: Update vty/counter documentation ...................................................................... manuals: Update vty/counter documentation Change-Id: Id7245eb1011d1f04d5dfa1503a96d100bc98344c Related: OS#1700 --- M doc/manuals/chapters/counters_generated.adoc M doc/manuals/vty/sgsn_vty_reference.xml 2 files changed, 26 insertions(+), 65 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/doc/manuals/chapters/counters_generated.adoc b/doc/manuals/chapters/counters_generated.adoc index 756a4a5..dac46aa 100644 --- a/doc/manuals/chapters/counters_generated.adoc +++ b/doc/manuals/chapters/counters_generated.adoc @@ -1,5 +1,8 @@ + // autogenerated by show asciidoc counters -These counters and their description based on OsmoSGSN UNKNOWN (OsmoSGSN). +These counters and their description based on OsmoSGSN 1.4.0.31-05fe (OsmoSGSN). + +=== Rate Counters // generating tables for rate_ctr_group // rate_ctr_group table BSSGP Peer Statistics @@ -15,46 +18,15 @@ | discarded | <> | BVC LLC Discarded count | status | <> | BVC Status count |=== -// rate_ctr_group table BSSGP Peer Statistics -.bssgp:bss_ctx - BSSGP Peer Statistics -[options="header"] -|=== -| Name | Reference | Description -| packets:in | <> | Packets at BSSGP Level ( In) -| packets:out | <> | Packets at BSSGP Level (Out) -| bytes:in | <> | Bytes at BSSGP Level ( In) -| bytes:out | <> | Bytes at BSSGP Level (Out) -| blocked | <> | BVC Blocking count -| discarded | <> | BVC LLC Discarded count -| status | <> | BVC Status count -|=== -// rate_ctr_group table NSVC Peer Statistics -.ns:nsvc - NSVC Peer Statistics -[options="header"] -|=== -| Name | Reference | Description -| packets:in | <> | Packets at NS Level ( In) -| packets:out | <> | Packets at NS Level (Out) -| bytes:in | <> | Bytes at NS Level ( In) -| bytes:out | <> | Bytes at NS Level (Out) -| blocked | <> | NS-VC Block count -| dead | <> | NS-VC gone dead count -| replaced | <> | NS-VC replaced other count -| nsei-chg | <> | NS-VC changed NSEI count -| inv-nsvci | <> | NS-VCI was invalid count -| inv-nsei | <> | NSEI was invalid count -| lost:alive | <> | ALIVE ACK missing count -| lost:reset | <> | RESET ACK missing count -|=== // rate_ctr_group table SGSN Overall Statistics -.sgsn - SGSN Overall Statistics +.sgsn - SGSN Overall Statistics [options="header"] |=== | Name | Reference | Description | llc:dl_bytes | <> | Count sent LLC bytes before giving it to the bssgp layer -| llc:ul_bytes | <> | Count sucessful received LLC bytes (encrypt & fcs correct) -| llc:dl_packets | <> | Count sucessful sent LLC packets before giving it to the bssgp layer -| llc:ul_packets | <> | Count sucessful received LLC packets (encrypt & fcs correct) +| llc:ul_bytes | <> | Count successful received LLC bytes (encrypt & fcs correct) +| llc:dl_packets | <> | Count successful sent LLC packets before giving it to the bssgp layer +| llc:ul_packets | <> | Count successful received LLC packets (encrypt & fcs correct) | gprs:attach_requested | <> | Received attach requests | gprs:attach_accepted | <> | Sent attach accepts | gprs:attach_rejected | <> | Sent attach rejects @@ -76,7 +48,7 @@ | pdp:ul_deactivate_accepted | <> | Received deactivate accepts |=== // rate_ctr_group table NSVC Peer Statistics -.ns:nsvc - NSVC Peer Statistics +.ns:nsvc - NSVC Peer Statistics [options="header"] |=== | Name | Reference | Description @@ -84,38 +56,27 @@ | packets:out | <> | Packets at NS Level (Out) | bytes:in | <> | Bytes at NS Level ( In) | bytes:out | <> | Bytes at NS Level (Out) -| blocked | <> | NS-VC Block count -| dead | <> | NS-VC gone dead count +| blocked | <> | NS-VC Block count +| dead | <> | NS-VC gone dead count | replaced | <> | NS-VC replaced other count -| nsei-chg | <> | NS-VC changed NSEI count -| inv-nsvci | <> | NS-VCI was invalid count -| inv-nsei | <> | NSEI was invalid count -| lost:alive | <> | ALIVE ACK missing count -| lost:reset | <> | RESET ACK missing count +| nsei-chg | <> | NS-VC changed NSEI count +| inv-nsvci | <> | NS-VCI was invalid count +| inv-nsei | <> | NSEI was invalid count +| lost:alive | <> | ALIVE ACK missing count +| lost:reset | <> | RESET ACK missing count |=== +== Osmo Stat Items + // generating tables for osmo_stat_items NSVC Peer Statistics // osmo_stat_item_group table NSVC Peer Statistics -.ns.nsvc - NSVC Peer Statistics +.ns.nsvc - NSVC Peer Statistics [options="header"] |=== | Name | Reference | Description | Unit | alive.delay | <> | ALIVE response time | ms |=== -NSVC Peer Statistics -// osmo_stat_item_group table NSVC Peer Statistics -.ns.nsvc - NSVC Peer Statistics -[options="header"] -|=== -| Name | Reference | Description | Unit -| alive.delay | <> | ALIVE response time | ms -|=== +== Osmo Counters + // generating tables for osmo_counters -// ungrouped osmo_counters -.ungrouped osmo counters -[options="header"] -|=== -| Name | Reference | Description -|=== - - +// there are no ungrouped osmo_counters diff --git a/doc/manuals/vty/sgsn_vty_reference.xml b/doc/manuals/vty/sgsn_vty_reference.xml index e9cd322..c3f91cf 100644 --- a/doc/manuals/vty/sgsn_vty_reference.xml +++ b/doc/manuals/vty/sgsn_vty_reference.xml @@ -2460,7 +2460,7 @@ - + @@ -2469,7 +2469,7 @@ - + @@ -2483,7 +2483,7 @@ - + @@ -2498,7 +2498,7 @@ - + -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id7245eb1011d1f04d5dfa1503a96d100bc98344c Gerrit-Change-Number: 14535 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 15:36:46 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 24 Jul 2019 15:36:46 +0000 Subject: Change in ...docker-playground[master]: osmo-cn-latest: Let osmo-hlr upgrade the db scheme Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14926 Change subject: osmo-cn-latest: Let osmo-hlr upgrade the db scheme ...................................................................... osmo-cn-latest: Let osmo-hlr upgrade the db scheme Change-Id: I9171d908de03bf0de7cb7590c901c4ce0759b8c0 --- M osmo-cn-latest/runit/hlr-run 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/26/14926/1 diff --git a/osmo-cn-latest/runit/hlr-run b/osmo-cn-latest/runit/hlr-run index c093d13..829ba0d 100755 --- a/osmo-cn-latest/runit/hlr-run +++ b/osmo-cn-latest/runit/hlr-run @@ -1,3 +1,3 @@ #!/bin/sh -exec /usr/bin/osmo-hlr -c /data/osmo-hlr.cfg -l /data/hlr.db +exec /usr/bin/osmo-hlr -c /data/osmo-hlr.cfg -l /data/hlr.db --db-upgrade -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9171d908de03bf0de7cb7590c901c4ce0759b8c0 Gerrit-Change-Number: 14926 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 16:07:38 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 24 Jul 2019 16:07:38 +0000 Subject: Change in ...docker-playground[master]: regen_doc: Change IP network to an unused subnet Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14927 Change subject: regen_doc: Change IP network to an unused subnet ...................................................................... regen_doc: Change IP network to an unused subnet Previously we were using 178.18.12.0/24 which could have conflicted with the osmo-bsc sccplite TTCN3 tests. Change-Id: Ib5ab391ebb21ce2455fbb1ae47dd01ed53cd2e41 --- M scripts/regen_doc.sh 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/27/14927/1 diff --git a/scripts/regen_doc.sh b/scripts/regen_doc.sh index cd85d01..ca540f9 100755 --- a/scripts/regen_doc.sh +++ b/scripts/regen_doc.sh @@ -21,7 +21,7 @@ docker_images_require \ "$NAME-$IMAGE_SUFFIX" -network_create 172.18.12.0/24 +network_create 172.18.16.0/24 container_create() { CONTAINERNAME=$1 @@ -35,15 +35,15 @@ } -container_create "$NAME-$IMAGE_SUFFIX" 172.18.12.23 +container_create "$NAME-$IMAGE_SUFFIX" 172.18.16.23 # Get asciidoc counter info ${OSMO_INTERACT_VTY} \ - -c "enable;show asciidoc counters" -p "$PORT" -H 172.18.12.23 -O "$COUNTERFILE" + -c "enable;show asciidoc counters" -p "$PORT" -H 172.18.16.23 -O "$COUNTERFILE" # Get vty reference ${OSMO_INTERACT_VTY} \ - -X -p "$PORT" -H 172.18.12.23 -O "$VTYFILE" + -X -p "$PORT" -H 172.18.16.23 -O "$VTYFILE" docker container kill "${BUILD_TAG}-$NAME-$IMAGE_SUFFIX" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib5ab391ebb21ce2455fbb1ae47dd01ed53cd2e41 Gerrit-Change-Number: 14927 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 16:08:18 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 24 Jul 2019 16:08:18 +0000 Subject: Change in ...docker-playground[master]: regen_doc: Change IP network to an unused subnet In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14927 ) Change subject: regen_doc: Change IP network to an unused subnet ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib5ab391ebb21ce2455fbb1ae47dd01ed53cd2e41 Gerrit-Change-Number: 14927 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Comment-Date: Wed, 24 Jul 2019 16:08:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 16:08:27 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 24 Jul 2019 16:08:27 +0000 Subject: Change in ...docker-playground[master]: osmo-cn-latest: Let osmo-hlr upgrade the db scheme In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14926 ) Change subject: osmo-cn-latest: Let osmo-hlr upgrade the db scheme ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9171d908de03bf0de7cb7590c901c4ce0759b8c0 Gerrit-Change-Number: 14926 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Comment-Date: Wed, 24 Jul 2019 16:08:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 16:08:30 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 16:08:30 +0000 Subject: Change in ...osmo-trx[master]: manuals/configuration.adoc: fix copy-paste error in config example Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14928 Change subject: manuals/configuration.adoc: fix copy-paste error in config example ...................................................................... manuals/configuration.adoc: fix copy-paste error in config example Change-Id: If9de32eed8170038c8c177c8996c78846dddb624 --- M doc/manuals/chapters/configuration.adoc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/28/14928/1 diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index ad6742d..2f4986f 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -12,7 +12,7 @@ === Documented example -.Example: Static GGSN/APN configuration (single catch-all GGSN) +.Example: Single carrier configuration ---- trx bind-ip 127.0.0.1 <1> -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9de32eed8170038c8c177c8996c78846dddb624 Gerrit-Change-Number: 14928 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 16:21:09 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 16:21:09 +0000 Subject: Change in ...osmo-hlr[master]: hlr_ussd.c: rx_proc_ss_req(): fix NULL pointer dereference In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14925 ) Change subject: hlr_ussd.c: rx_proc_ss_req(): fix NULL pointer dereference ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14925 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ia71cabbf396bd1388e764a1749e953ac1782e307 Gerrit-Change-Number: 14925 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 16:21:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 16:21:42 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 16:21:42 +0000 Subject: Change in ...docker-playground[master]: regen_doc: Change IP network to an unused subnet In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14927 ) Change subject: regen_doc: Change IP network to an unused subnet ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib5ab391ebb21ce2455fbb1ae47dd01ed53cd2e41 Gerrit-Change-Number: 14927 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 16:21:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 16:21:58 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 16:21:58 +0000 Subject: Change in ...docker-playground[master]: osmo-cn-latest: Let osmo-hlr upgrade the db scheme In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14926 ) Change subject: osmo-cn-latest: Let osmo-hlr upgrade the db scheme ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9171d908de03bf0de7cb7590c901c4ce0759b8c0 Gerrit-Change-Number: 14926 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 16:21:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 16:22:30 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 16:22:30 +0000 Subject: Change in ...osmo-trx[master]: manuals/configuration.adoc: fix copy-paste error in config example In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14928 ) Change subject: manuals/configuration.adoc: fix copy-paste error in config example ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9de32eed8170038c8c177c8996c78846dddb624 Gerrit-Change-Number: 14928 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 16:22:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 16:44:11 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 16:44:11 +0000 Subject: Change in ...osmo-remsim[master]: rspro_client_fsm: Fix another memory leak Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14929 Change subject: rspro_client_fsm: Fix another memory leak ...................................................................... rspro_client_fsm: Fix another memory leak We basically must ensure that all code paths *except* the path leading to rspro_dec_msg() must call msgb_free(msg). This was not the case in two situations, as fixed now. Change-Id: I29f8413bb43b3ebf827be0bceda1a4db1e6e2b7c --- M src/rspro_client_fsm.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/29/14929/1 diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 06364da..d487f32 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -121,8 +121,10 @@ switch (hh->proto) { case IPAC_PROTO_IPACCESS: rc = ipaccess_bts_handle_ccm(srvc->conn, &srvc->ipa_dev, msg); - if (rc < 0) + if (rc < 0) { + msgb_free(msg); break; + } switch (hh->data[0]) { case IPAC_MSGT_PONG: ipa_keepalive_fsm_pong_received(srvc->keepalive_fi); @@ -130,8 +132,8 @@ break; default: break; - msgb_free(msg); } + msgb_free(msg); break; case IPAC_PROTO_OSMO: if (!he || msgb_l2len(msg) < sizeof(*he)) -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I29f8413bb43b3ebf827be0bceda1a4db1e6e2b7c Gerrit-Change-Number: 14929 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 17:10:44 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 24 Jul 2019 17:10:44 +0000 Subject: Change in ...osmo-msc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14841 ) Change subject: doc: Add Osmux documentation to User Manual ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/14841/5/doc/manuals/chapters/osmux_msc.adoc File doc/manuals/chapters/osmux_msc.adoc: https://gerrit.osmocom.org/#/c/14841/5/doc/manuals/chapters/osmux_msc.adoc at 27 PS5, Line 27: towrds towards -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 Gerrit-Change-Number: 14841 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 17:10:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 17:39:23 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 17:39:23 +0000 Subject: Change in ...osmo-msc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: Hello daniel, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 to look at the new patch set (#6). Change subject: doc: Add Osmux documentation to User Manual ...................................................................... doc: Add Osmux documentation to User Manual Depends: osmo-gsm-manuals.git f3a734e6777a902abfb03257277454c7a879aeb7 Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 --- A doc/manuals/chapters/osmux_msc.adoc M doc/manuals/osmomsc-usermanual.adoc 2 files changed, 67 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/41/14841/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 Gerrit-Change-Number: 14841 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 17:51:07 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 17:51:07 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 ) Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... Patch Set 4: ping. I'll like to have this one hopefully merged soon so I can have SC5 tests working fine again in osmo-gsm-tester. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 24 Jul 2019 17:51:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 18:01:50 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 18:01:50 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 ) Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... Patch Set 4: related osmo-gsm-tester patch using this feature is here: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14930 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 24 Jul 2019 18:01:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:22:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:22:35 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 ) Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:22:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:22:38 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:22:38 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 ) Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... bts-trx: Introduce VTY command osmotrx trxd-max-version This command allows setting a maximum TRXD format version to negotiate with TRX. osmo-bts-trx will hence end up using that version if supported by TRX, or a lower one otherwise (or fail if TRX doesn't support any of them). Since now the maximum version can be 0, avoid going through SETFORMAT negotiation in that case, since 0 is the default version. This way we keep backward compatibility with TRX implementations that exit upon receival of unknown commands (such as SC5 current one). The VTY command is located in the "phy" node instead of the "phy instance" node because instances of same phy are expected to use same host with same implementation, so TRXD version to use should be the same for both. Related: OS#4006 Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 --- M include/osmo-bts/phy_link.h M src/osmo-bts-trx/l1_if.c M src/osmo-bts-trx/main.c M src/osmo-bts-trx/trx_vty.c 4 files changed, 36 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmo-bts/phy_link.h b/include/osmo-bts/phy_link.h index 273103c..3bf5159 100644 --- a/include/osmo-bts/phy_link.h +++ b/include/osmo-bts/phy_link.h @@ -50,6 +50,7 @@ uint32_t clock_advance; uint32_t rts_advance; bool use_legacy_setbsic; + uint8_t trxd_hdr_ver_max; /* Maximum TRXD header version to negotiate */ } osmotrx; struct { char *mcast_dev; /* Network device for multicast */ diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c index 9c1dc18..22ef2d7 100644 --- a/src/osmo-bts-trx/l1_if.c +++ b/src/osmo-bts-trx/l1_if.c @@ -185,6 +185,7 @@ int l1if_provision_transceiver_trx(struct trx_l1h *l1h) { uint8_t tn; + struct phy_link *plink = l1h->phy_inst->phy_link; if (!transceiver_available) return -EIO; @@ -208,10 +209,11 @@ l1h->config.bsic_sent = 1; } - /* Ask transceiver to use the newest TRXD header version */ - if (!l1h->config.setformat_sent) { - trx_if_cmd_setformat(l1h, TRX_DATA_FORMAT_VER); - l1h->config.trxd_hdr_ver_req = TRX_DATA_FORMAT_VER; + /* Ask transceiver to use the newest TRXD header version if not using it yet */ + if (!l1h->config.setformat_sent && + l1h->config.trxd_hdr_ver_use != plink->u.osmotrx.trxd_hdr_ver_max) { + trx_if_cmd_setformat(l1h, plink->u.osmotrx.trxd_hdr_ver_max); + l1h->config.trxd_hdr_ver_req = plink->u.osmotrx.trxd_hdr_ver_max; l1h->config.setformat_sent = 1; } diff --git a/src/osmo-bts-trx/main.c b/src/osmo-bts-trx/main.c index 9529190..b1fa207 100644 --- a/src/osmo-bts-trx/main.c +++ b/src/osmo-bts-trx/main.c @@ -134,6 +134,8 @@ plink->u.osmotrx.trx_ta_loop = true; plink->u.osmotrx.trx_ms_power_loop = false; plink->u.osmotrx.trx_target_rssi = -10; + /* attempt use newest TRXD version by default: */ + plink->u.osmotrx.trxd_hdr_ver_max = TRX_DATA_FORMAT_VER; } void bts_model_phy_instance_set_defaults(struct phy_instance *pinst) diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c index b9af445..c52908e 100644 --- a/src/osmo-bts-trx/trx_vty.c +++ b/src/osmo-bts-trx/trx_vty.c @@ -496,6 +496,29 @@ return CMD_SUCCESS; } +DEFUN(cfg_phy_trxd_max_version, cfg_phy_trxd_max_version_cmd, + "osmotrx trxd-max-version (latest|<0-15>)", OSMOTRX_STR + "Set maximum TRXD format version to negotiate with TRX\n" + "Use latest supported TRXD format version (default)\n" + "Maximum TRXD format version number\n") +{ + struct phy_link *plink = vty->index; + + int max_ver; + if (strcmp(argv[0], "latest") == 0) + max_ver = TRX_DATA_FORMAT_VER; + else + max_ver = atoi(argv[0]); + if (max_ver > TRX_DATA_FORMAT_VER) { + vty_out(vty, "%% Format version %d is not supported, maximum supported is %d%s", + max_ver, TRX_DATA_FORMAT_VER, VTY_NEWLINE); + return CMD_WARNING; + } + plink->u.osmotrx.trxd_hdr_ver_max = max_ver; + + return CMD_SUCCESS; +} + void bts_model_config_write_phy(struct vty *vty, struct phy_link *plink) { if (plink->u.osmotrx.local_ip) @@ -525,6 +548,9 @@ if (plink->u.osmotrx.use_legacy_setbsic) vty_out(vty, " osmotrx legacy-setbsic%s", VTY_NEWLINE); + + if (plink->u.osmotrx.trxd_hdr_ver_max != TRX_DATA_FORMAT_VER) + vty_out(vty, " osmotrx trxd-max-version %d%s", plink->u.osmotrx.trxd_hdr_ver_max, VTY_NEWLINE); } void bts_model_config_write_phy_inst(struct vty *vty, struct phy_instance *pinst) @@ -584,6 +610,7 @@ install_element(PHY_NODE, &cfg_phy_osmotrx_ip_cmd); install_element(PHY_NODE, &cfg_phy_setbsic_cmd); install_element(PHY_NODE, &cfg_phy_no_setbsic_cmd); + install_element(PHY_NODE, &cfg_phy_trxd_max_version_cmd); install_element(PHY_INST_NODE, &cfg_phyinst_rxgain_cmd); install_element(PHY_INST_NODE, &cfg_phyinst_tx_atten_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:22:54 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 19:22:54 +0000 Subject: Change in ...osmo-gsm-tester[master]: Introduce and use osmo-bts-trx VTY cmd max_trxd_version on sysmocell-5K In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14930 ) Change subject: Introduce and use osmo-bts-trx VTY cmd max_trxd_version on sysmocell-5K ...................................................................... Patch Set 3: Tested in osmo-gsm-tester with osmo-bts built from a branch containing the osmo-bts patch adding the VTY command. All went fine! -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14930 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ic95c38d91dba354ae64c5edbfcea3fbbf34a7de3 Gerrit-Change-Number: 14930 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:22:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:22:54 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:22:54 +0000 Subject: Change in ...osmo-msc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14841 ) Change subject: doc: Add Osmux documentation to User Manual ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 Gerrit-Change-Number: 14841 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:22:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:23:00 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:23:00 +0000 Subject: Change in ...osmo-remsim[master]: rspro_client_fsm: Fix another memory leak In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14929 ) Change subject: rspro_client_fsm: Fix another memory leak ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I29f8413bb43b3ebf827be0bceda1a4db1e6e2b7c Gerrit-Change-Number: 14929 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Jul 2019 19:23:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:23:02 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:23:02 +0000 Subject: Change in ...osmo-remsim[master]: rspro_client_fsm: Fix another memory leak In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14929 ) Change subject: rspro_client_fsm: Fix another memory leak ...................................................................... rspro_client_fsm: Fix another memory leak We basically must ensure that all code paths *except* the path leading to rspro_dec_msg() must call msgb_free(msg). This was not the case in two situations, as fixed now. Change-Id: I29f8413bb43b3ebf827be0bceda1a4db1e6e2b7c --- M src/rspro_client_fsm.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index 06364da..d487f32 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -121,8 +121,10 @@ switch (hh->proto) { case IPAC_PROTO_IPACCESS: rc = ipaccess_bts_handle_ccm(srvc->conn, &srvc->ipa_dev, msg); - if (rc < 0) + if (rc < 0) { + msgb_free(msg); break; + } switch (hh->data[0]) { case IPAC_MSGT_PONG: ipa_keepalive_fsm_pong_received(srvc->keepalive_fi); @@ -130,8 +132,8 @@ break; default: break; - msgb_free(msg); } + msgb_free(msg); break; case IPAC_PROTO_OSMO: if (!he || msgb_l2len(msg) < sizeof(*he)) -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I29f8413bb43b3ebf827be0bceda1a4db1e6e2b7c Gerrit-Change-Number: 14929 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:23:20 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 19:23:20 +0000 Subject: Change in ...osmo-gsm-tester[master]: Introduce and use osmo-bts-trx VTY cmd max_trxd_version on sysmocell-5K In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14930 ) Change subject: Introduce and use osmo-bts-trx VTY cmd max_trxd_version on sysmocell-5K ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14930 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ic95c38d91dba354ae64c5edbfcea3fbbf34a7de3 Gerrit-Change-Number: 14930 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:23:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:23:58 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:23:58 +0000 Subject: Change in ...osmo-trx[master]: manuals/configuration.adoc: fix copy-paste error in config example In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14928 ) Change subject: manuals/configuration.adoc: fix copy-paste error in config example ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9de32eed8170038c8c177c8996c78846dddb624 Gerrit-Change-Number: 14928 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:23:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:24:00 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:24:00 +0000 Subject: Change in ...osmo-trx[master]: manuals/configuration.adoc: fix copy-paste error in config example In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14928 ) Change subject: manuals/configuration.adoc: fix copy-paste error in config example ...................................................................... manuals/configuration.adoc: fix copy-paste error in config example Change-Id: If9de32eed8170038c8c177c8996c78846dddb624 --- M doc/manuals/chapters/configuration.adoc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index ad6742d..2f4986f 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -12,7 +12,7 @@ === Documented example -.Example: Static GGSN/APN configuration (single catch-all GGSN) +.Example: Single carrier configuration ---- trx bind-ip 127.0.0.1 <1> -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14928 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If9de32eed8170038c8c177c8996c78846dddb624 Gerrit-Change-Number: 14928 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:24:17 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:24:17 +0000 Subject: Change in ...docker-playground[master]: osmo-cn-latest: Let osmo-hlr upgrade the db scheme In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14926 ) Change subject: osmo-cn-latest: Let osmo-hlr upgrade the db scheme ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9171d908de03bf0de7cb7590c901c4ce0759b8c0 Gerrit-Change-Number: 14926 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:24:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:24:19 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:24:19 +0000 Subject: Change in ...docker-playground[master]: osmo-cn-latest: Let osmo-hlr upgrade the db scheme In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14926 ) Change subject: osmo-cn-latest: Let osmo-hlr upgrade the db scheme ...................................................................... osmo-cn-latest: Let osmo-hlr upgrade the db scheme Change-Id: I9171d908de03bf0de7cb7590c901c4ce0759b8c0 --- M osmo-cn-latest/runit/hlr-run 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: daniel: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/osmo-cn-latest/runit/hlr-run b/osmo-cn-latest/runit/hlr-run index c093d13..829ba0d 100755 --- a/osmo-cn-latest/runit/hlr-run +++ b/osmo-cn-latest/runit/hlr-run @@ -1,3 +1,3 @@ #!/bin/sh -exec /usr/bin/osmo-hlr -c /data/osmo-hlr.cfg -l /data/hlr.db +exec /usr/bin/osmo-hlr -c /data/osmo-hlr.cfg -l /data/hlr.db --db-upgrade -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14926 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9171d908de03bf0de7cb7590c901c4ce0759b8c0 Gerrit-Change-Number: 14926 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:24:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:24:36 +0000 Subject: Change in ...docker-playground[master]: regen_doc: Change IP network to an unused subnet In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14927 ) Change subject: regen_doc: Change IP network to an unused subnet ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib5ab391ebb21ce2455fbb1ae47dd01ed53cd2e41 Gerrit-Change-Number: 14927 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:24:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:24:37 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:24:37 +0000 Subject: Change in ...docker-playground[master]: regen_doc: Change IP network to an unused subnet In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14927 ) Change subject: regen_doc: Change IP network to an unused subnet ...................................................................... regen_doc: Change IP network to an unused subnet Previously we were using 178.18.12.0/24 which could have conflicted with the osmo-bsc sccplite TTCN3 tests. Change-Id: Ib5ab391ebb21ce2455fbb1ae47dd01ed53cd2e41 --- M scripts/regen_doc.sh 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: daniel: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/scripts/regen_doc.sh b/scripts/regen_doc.sh index cd85d01..ca540f9 100755 --- a/scripts/regen_doc.sh +++ b/scripts/regen_doc.sh @@ -21,7 +21,7 @@ docker_images_require \ "$NAME-$IMAGE_SUFFIX" -network_create 172.18.12.0/24 +network_create 172.18.16.0/24 container_create() { CONTAINERNAME=$1 @@ -35,15 +35,15 @@ } -container_create "$NAME-$IMAGE_SUFFIX" 172.18.12.23 +container_create "$NAME-$IMAGE_SUFFIX" 172.18.16.23 # Get asciidoc counter info ${OSMO_INTERACT_VTY} \ - -c "enable;show asciidoc counters" -p "$PORT" -H 172.18.12.23 -O "$COUNTERFILE" + -c "enable;show asciidoc counters" -p "$PORT" -H 172.18.16.23 -O "$COUNTERFILE" # Get vty reference ${OSMO_INTERACT_VTY} \ - -X -p "$PORT" -H 172.18.12.23 -O "$VTYFILE" + -X -p "$PORT" -H 172.18.16.23 -O "$VTYFILE" docker container kill "${BUILD_TAG}-$NAME-$IMAGE_SUFFIX" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib5ab391ebb21ce2455fbb1ae47dd01ed53cd2e41 Gerrit-Change-Number: 14927 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:25:09 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:25:09 +0000 Subject: Change in ...osmo-hlr[master]: hlr_ussd.c: rx_proc_ss_req(): fix NULL pointer dereference In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14925 ) Change subject: hlr_ussd.c: rx_proc_ss_req(): fix NULL pointer dereference ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14925 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ia71cabbf396bd1388e764a1749e953ac1782e307 Gerrit-Change-Number: 14925 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:25:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:25:12 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:25:12 +0000 Subject: Change in ...osmo-hlr[master]: hlr_ussd.c: rx_proc_ss_req(): fix NULL pointer dereference In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14925 ) Change subject: hlr_ussd.c: rx_proc_ss_req(): fix NULL pointer dereference ...................................................................... hlr_ussd.c: rx_proc_ss_req(): fix NULL pointer dereference The SS payload is mandatory for GSUP PROC_SS_{REQ,RSP} messages with session state BEGIN or CONTINUE, and optional for the END. Make sure that it's present for both BEGIN and CONTINUE, consider received message as incorrect otherwise. In case of the END, call handle_ussd() / handle_ss() only if SS payload is present. Change-Id: Ia71cabbf396bd1388e764a1749e953ac1782e307 Fixes: CID#188841 --- M src/hlr_ussd.c 1 file changed, 16 insertions(+), 6 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/hlr_ussd.c b/src/hlr_ussd.c index 773c571..1568815 100644 --- a/src/hlr_ussd.c +++ b/src/hlr_ussd.c @@ -519,6 +519,11 @@ /* FIXME: Send a Reject component? */ goto out_err; } + } else if (gsup->session_state != OSMO_GSUP_SESSION_STATE_END) { + LOGP(DSS, LOGL_ERROR, "%s/0x%082x: Missing SS payload for '%s'\n", + gsup->imsi, gsup->session_id, + osmo_gsup_session_state_name(gsup->session_state)); + goto out_err; } switch (gsup->session_state) { @@ -606,13 +611,18 @@ gsup->imsi, gsup->session_id); goto out_err; } - if (ss_op_is_ussd(req.opcode)) { - /* dispatch unstructured SS to routing */ - handle_ussd(conn, ss, gsup, &req); - } else { - /* dispatch non-call SS to internal code */ - handle_ss(ss, gsup, &req); + + /* SS payload is optional for END */ + if (gsup->ss_info && gsup->ss_info_len) { + if (ss_op_is_ussd(req.opcode)) { + /* dispatch unstructured SS to routing */ + handle_ussd(conn, ss, gsup, &req); + } else { + /* dispatch non-call SS to internal code */ + handle_ss(ss, gsup, &req); + } } + ss_session_free(ss); break; default: -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14925 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ia71cabbf396bd1388e764a1749e953ac1782e307 Gerrit-Change-Number: 14925 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:25:27 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:25:27 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): use OSMO_IMSI_BUF_SIZE In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14924 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): use OSMO_IMSI_BUF_SIZE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14924 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia1da9f005b7f801872c542d31cc8eabd859d997a Gerrit-Change-Number: 14924 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:25:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:26:32 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:26:32 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401 Gerrit-Change-Number: 14922 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:26:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:26:58 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:26:58 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14923 ) Change subject: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id1ad279ce9bef38eb3d11ac62337276207e8d8bd Gerrit-Change-Number: 14923 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:26:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:27:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:27:36 +0000 Subject: Change in ...osmo-bts[master]: manuals: Update vty documentation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14523 ) Change subject: manuals: Update vty documentation ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icc0c96d173f31f2eb5fcb6385525a17f94ead852 Gerrit-Change-Number: 14523 Gerrit-PatchSet: 5 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Wed, 24 Jul 2019 19:27:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:27:43 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:27:43 +0000 Subject: Change in ...osmo-bts[master]: manuals: Update vty documentation In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14523 ) Change subject: manuals: Update vty documentation ...................................................................... manuals: Update vty documentation This documentation only includes commands for osmo-bts-virtual Change-Id: Icc0c96d173f31f2eb5fcb6385525a17f94ead852 Related: OS#1700 --- M doc/manuals/vty/bts_vty_reference.xml 1 file changed, 1,742 insertions(+), 1,633 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/vty/bts_vty_reference.xml b/doc/manuals/vty/bts_vty_reference.xml index 4697ee7..d5621c8 100644 --- a/doc/manuals/vty/bts_vty_reference.xml +++ b/doc/manuals/vty/bts_vty_reference.xml @@ -1,1633 +1,1742 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + Common Commands + These commands are available on all VTY nodes. They are listed here only once, to unclutter the VTY reference. + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + view + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + enable + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-log + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-stats + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-line + + + + + + + + + + + + + + + + + + + + + config-e1_input + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-ctrl + + + + + + + + + phy + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + phy-inst + + + bts + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + trx + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icc0c96d173f31f2eb5fcb6385525a17f94ead852 Gerrit-Change-Number: 14523 Gerrit-PatchSet: 6 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:28:30 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 19:28:30 +0000 Subject: Change in ...osmo-gsm-tester[master]: Introduce and use osmo-bts-trx VTY cmd max_trxd_version on sysmocell-5K In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14930 ) Change subject: Introduce and use osmo-bts-trx VTY cmd max_trxd_version on sysmocell-5K ...................................................................... Introduce and use osmo-bts-trx VTY cmd max_trxd_version on sysmocell-5K Force TRXDv0 when using sysmocell-5k as a TRX, since its implementation (different than osmo-trx) doesn't support higher versions. Furthermore, it will crash upon receival of SETFORMAT string. By forcing maximum TRXD version to 0, osmo-bts-trx won't sent any SETFORMAT message since 0 is the initial version to use. Depends: osmo-bts.git I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Related: OS#4006 Change-Id: Ic95c38d91dba354ae64c5edbfcea3fbbf34a7de3 --- M example/resources.conf.prod M src/osmo_gsm_tester/resource.py M src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl 3 files changed, 5 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/example/resources.conf.prod b/example/resources.conf.prod index f4e9fe4..8b498d0 100644 --- a/example/resources.conf.prod +++ b/example/resources.conf.prod @@ -73,6 +73,7 @@ launch_trx: false clock_reference: external trx_ip: 10.42.42.112 + max_trxd_version: 0 - label: OCTBTS 3500 type: osmo-bts-octphy diff --git a/src/osmo_gsm_tester/resource.py b/src/osmo_gsm_tester/resource.py index 246b196..1b18076 100644 --- a/src/osmo_gsm_tester/resource.py +++ b/src/osmo_gsm_tester/resource.py @@ -75,6 +75,7 @@ 'bts[].osmo_trx.remote_user': schema.STR, 'bts[].osmo_trx.dev_args': schema.STR, 'bts[].osmo_trx.multi_arfcn': schema.BOOL_STR, + 'bts[].osmo_trx.max_trxd_version': schema.UINT, 'arfcn[].arfcn': schema.INT, 'arfcn[].band': schema.BAND, 'modem[].type': schema.STR, diff --git a/src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl index 677b047..2239f74 100644 --- a/src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl +++ b/src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl @@ -23,6 +23,9 @@ phy 0 osmotrx ip local ${osmo_bts_trx.osmo_trx.bts_ip} osmotrx ip remote ${osmo_bts_trx.osmo_trx.trx_ip} +%if osmo_bts_trx.get('osmo_trx').get('max_trxd_version', False): + osmotrx trxd-max-version ${osmo_bts_trx.osmo_trx.max_trxd_version} +%endif %for chan in osmo_bts_trx.osmo_trx.channels: instance ${loop.index} osmotrx rx-gain 25 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14930 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Ic95c38d91dba354ae64c5edbfcea3fbbf34a7de3 Gerrit-Change-Number: 14930 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:28:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:28:36 +0000 Subject: Change in ...osmo-pcu[master]: ubsan: fix shift In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14906 ) Change subject: ubsan: fix shift ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6387c7313832f6c7c920e1016b74562b66d6b68e Gerrit-Change-Number: 14906 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:28:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:28:38 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:28:38 +0000 Subject: Change in ...osmo-pcu[master]: ubsan: fix shift In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14906 ) Change subject: ubsan: fix shift ...................................................................... ubsan: fix shift Ubsan complains about shifts into the sign bit due to automatic int promotion, so cast explicitly. Change-Id: I6387c7313832f6c7c920e1016b74562b66d6b68e Related: OS#4029 --- M src/bts.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/bts.cpp b/src/bts.cpp index 395fc73..26dd401 100644 --- a/src/bts.cpp +++ b/src/bts.cpp @@ -551,7 +551,7 @@ } /* get TLLI from downlink assignment */ - tlli = ((*data++) & 0xf) << 28; + tlli = (uint32_t)((*data++) & 0xf) << 28; tlli |= (*data++) << 20; tlli |= (*data++) << 12; tlli |= (*data++) << 4; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6387c7313832f6c7c920e1016b74562b66d6b68e Gerrit-Change-Number: 14906 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:28:55 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:28:55 +0000 Subject: Change in ...osmo-bts[master]: trx: Use LOGPPHI instead of LOGP in some more messages In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14904 ) Change subject: trx: Use LOGPPHI instead of LOGP in some more messages ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14904 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I90990e4dbcbb2fb4a3fcb24658bdf53e57030bcf Gerrit-Change-Number: 14904 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Jul 2019 19:28:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:28:57 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:28:57 +0000 Subject: Change in ...osmo-bts[master]: trx: Use LOGPPHI instead of LOGP in some more messages In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/14904 ) Change subject: trx: Use LOGPPHI instead of LOGP in some more messages ...................................................................... trx: Use LOGPPHI instead of LOGP in some more messages This allows to clearly identify the phy instance owning those messages. Change-Id: I90990e4dbcbb2fb4a3fcb24658bdf53e57030bcf --- M src/osmo-bts-trx/trx_if.c 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index b966bbe..6c6d5ad 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -107,22 +107,22 @@ buf[len] = '\0'; if (!!strncmp(buf, "IND CLOCK ", 10)) { - LOGP(DTRX, LOGL_NOTICE, "Unknown message on clock port: %s\n", - buf); + LOGPPHI(pinst, DTRX, LOGL_NOTICE, + "Unknown message on clock port: %s\n", buf); return 0; } if (sscanf(buf, "IND CLOCK %u", &fn) != 1) { - LOGP(DTRX, LOGL_ERROR, "Unable to parse '%s'\n", buf); + LOGPPHI(pinst, DTRX, LOGL_ERROR, "Unable to parse '%s'\n", buf); return 0; } - LOGP(DTRX, LOGL_INFO, "Clock indication: fn=%u\n", fn); + LOGPPHI(pinst, DTRX, LOGL_INFO, "Clock indication: fn=%u\n", fn); if (fn >= GSM_HYPERFRAME) { fn %= GSM_HYPERFRAME; - LOGP(DTRX, LOGL_ERROR, "Indicated clock's FN is not wrapping " - "correctly, correcting to fn=%u\n", fn); + LOGPPHI(pinst, DTRX, LOGL_ERROR, "Indicated clock's FN is not " + "wrapping correctly, correcting to fn=%u\n", fn); } /* inform core TRX clock handling code that a FN has been received */ @@ -339,8 +339,8 @@ freq10 = gsm_arfcn2freq10(arfcn, 1); /* RX = uplink */ if (freq10 == 0xffff) { - LOGP(DTRX, LOGL_ERROR, "Arfcn %d not defined.\n", - arfcn & ~ARFCN_FLAG_MASK); + LOGPPHI(pinst, DTRX, LOGL_ERROR, "Arfcn %d not defined.\n", + arfcn & ~ARFCN_FLAG_MASK); return -ENOTSUP; } @@ -358,8 +358,8 @@ freq10 = gsm_arfcn2freq10(arfcn, 0); /* TX = downlink */ if (freq10 == 0xffff) { - LOGP(DTRX, LOGL_ERROR, "Arfcn %d not defined.\n", - arfcn & ~ARFCN_FLAG_MASK); + LOGPPHI(pinst, DTRX, LOGL_ERROR, "Arfcn %d not defined.\n", + arfcn & ~ARFCN_FLAG_MASK); return -ENOTSUP; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14904 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I90990e4dbcbb2fb4a3fcb24658bdf53e57030bcf Gerrit-Change-Number: 14904 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:29:31 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:29:31 +0000 Subject: Change in ...osmo-mgw[master]: Catch unsigned integer MGCP parsing errors with strtoul In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14905 ) Change subject: Catch unsigned integer MGCP parsing errors with strtoul ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14905 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifba1c1e3151d6f92f9da3d4ca2569a5908455ca8 Gerrit-Change-Number: 14905 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 24 Jul 2019 19:29:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:31:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:31:22 +0000 Subject: Change in ...osmo-bsc[master]: osmo-bsc.cfg: work with osmo-bts example cfg In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14791 ) Change subject: osmo-bsc.cfg: work with osmo-bts example cfg ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie8001611756b661ff1871508c6248b2e990ba1d7 Gerrit-Change-Number: 14791 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:31:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:31:24 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:31:24 +0000 Subject: Change in ...osmo-bsc[master]: osmo-bsc.cfg: work with osmo-bts example cfg In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14791 ) Change subject: osmo-bsc.cfg: work with osmo-bts example cfg ...................................................................... osmo-bsc.cfg: work with osmo-bts example cfg Change cell_identity and unit-id to match osmo-bts-virtual.cfg. Related: OS#3369 Change-Id: Ie8001611756b661ff1871508c6248b2e990ba1d7 --- M doc/examples/osmo-bsc/osmo-bsc.cfg M tests/ctrl_test_runner.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/doc/examples/osmo-bsc/osmo-bsc.cfg b/doc/examples/osmo-bsc/osmo-bsc.cfg index 77b6094..f814788 100644 --- a/doc/examples/osmo-bsc/osmo-bsc.cfg +++ b/doc/examples/osmo-bsc/osmo-bsc.cfg @@ -22,7 +22,7 @@ bts 0 type sysmobts band DCS1800 - cell_identity 0 + cell_identity 6969 location_area_code 1 base_station_id_code 63 ms max power 15 @@ -36,7 +36,7 @@ channel-description bs-pa-mfrms 5 channel-description bs-ag-blks-res 1 early-classmark-sending forbidden - ipa unit-id 0 0 + ipa unit-id 6969 0 oml ipa stream-id 255 line 0 codec-support fr gprs mode none diff --git a/tests/ctrl_test_runner.py b/tests/ctrl_test_runner.py index cc37c97..4d87b74 100755 --- a/tests/ctrl_test_runner.py +++ b/tests/ctrl_test_runner.py @@ -198,7 +198,7 @@ r = self.do_get('bts.0.cell-identity') self.assertEquals(r['mtype'], 'GET_REPLY') self.assertEquals(r['var'], 'bts.0.cell-identity') - self.assertEquals(r['value'], '0') + self.assertEquals(r['value'], '6969') r = self.do_set('bts.0.cell-identity', '23') self.assertEquals(r['mtype'], 'SET_REPLY') -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie8001611756b661ff1871508c6248b2e990ba1d7 Gerrit-Change-Number: 14791 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:32:03 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:32:03 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-gtphub.cfg: fix conflict with osmo-sgsn.cfg In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14792 ) Change subject: osmo-gtphub.cfg: fix conflict with osmo-sgsn.cfg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id892e1f4ab2daabbe9824b819b5fed985373b97a Gerrit-Change-Number: 14792 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:32:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:32:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:32:05 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-gtphub.cfg: fix conflict with osmo-sgsn.cfg In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14792 ) Change subject: osmo-gtphub.cfg: fix conflict with osmo-sgsn.cfg ...................................................................... osmo-gtphub.cfg: fix conflict with osmo-sgsn.cfg Change bind-to-sgsns from 127.0.0.1 to 127.0.0.10, so osmo-gtphub's default config does not conflict with the osmo-sgsn default config. The value of bind-to-ggsns does not clash with osmo-ggsn's config, so it was left unchanged. Related: OS#3369 Change-Id: Id892e1f4ab2daabbe9824b819b5fed985373b97a --- M doc/examples/osmo-gtphub/osmo-gtphub.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/doc/examples/osmo-gtphub/osmo-gtphub.cfg b/doc/examples/osmo-gtphub/osmo-gtphub.cfg index 0dc4150..0bb63e3 100644 --- a/doc/examples/osmo-gtphub/osmo-gtphub.cfg +++ b/doc/examples/osmo-gtphub/osmo-gtphub.cfg @@ -8,7 +8,7 @@ gtphub ! Local addresses to listen on and send from, each on standard ports ! 2123 and 2152. Setting these addresses is mandatory. - bind-to-sgsns 127.0.0.1 + bind-to-sgsns 127.0.0.10 bind-to-ggsns 127.0.0.2 ! Local nonstandard ports or separate IPs: -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id892e1f4ab2daabbe9824b819b5fed985373b97a Gerrit-Change-Number: 14792 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:32:54 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:32:54 +0000 Subject: Change in ...osmo-mgw[master]: doc: Add Osmux documentation to OsmoMGW User Manual In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14681 ) Change subject: doc: Add Osmux documentation to OsmoMGW User Manual ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 Gerrit-Change-Number: 14681 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 19:32:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 19:32:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 24 Jul 2019 19:32:56 +0000 Subject: Change in ...osmo-mgw[master]: doc: Add Osmux documentation to OsmoMGW User Manual In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14681 ) Change subject: doc: Add Osmux documentation to OsmoMGW User Manual ...................................................................... doc: Add Osmux documentation to OsmoMGW User Manual Depends: osmo-gsm-manuals.git I182d94c63f7d74ef882b77be59a95b1b7d8a4e5e Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 --- M doc/manuals/chapters/mgcp_extensions.adoc M doc/manuals/osmomgw-usermanual.adoc 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/doc/manuals/chapters/mgcp_extensions.adoc b/doc/manuals/chapters/mgcp_extensions.adoc index a68d785..df314bc 100644 --- a/doc/manuals/chapters/mgcp_extensions.adoc +++ b/doc/manuals/chapters/mgcp_extensions.adoc @@ -66,3 +66,7 @@ a=rtpmap:97 GSM-EFR/8000 a=ptime:40 ---- + +=== `X-Osmux` + +See <> diff --git a/doc/manuals/osmomgw-usermanual.adoc b/doc/manuals/osmomgw-usermanual.adoc index b0bc83d..0c26449 100644 --- a/doc/manuals/osmomgw-usermanual.adoc +++ b/doc/manuals/osmomgw-usermanual.adoc @@ -20,6 +20,8 @@ include::{srcdir}/chapters/mgcp_extensions.adoc[] +include::./common/chapters/osmux/osmux.adoc[] + //include::{srcdir}/chapters/counters.adoc[] include::./common/chapters/port_numbers.adoc[] @@ -29,5 +31,3 @@ include::./common/chapters/glossary.adoc[] include::./common/chapters/gfdl.adoc[] - - -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie53f98777070fc00ed085646f698d20f8cf49553 Gerrit-Change-Number: 14681 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 20:39:15 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 20:39:15 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 ) Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... Patch Set 4: We forgot to update the VTY manual! -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 20:39:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 20:39:57 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 20:39:57 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14922 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional ...................................................................... gprs_bssgp_pcu_rx_dl_ud(): fix: BSSGP_IE_IMSI is optional Change-Id: I940d220a399166122f33e67a222dd572085e1401 --- M src/gprs_bssgp_pcu.cpp 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved keith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index b34659b..3ea3e59 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -118,7 +118,11 @@ /* read IMSI. if no IMSI exists, use first paging block (any paging), * because during attachment the IMSI might not be known, so the MS * will listen to all paging blocks. */ - gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), TLVP_LEN(tp, BSSGP_IE_IMSI)); + if (TLVP_PRESENT(tp, BSSGP_IE_IMSI)) + { + gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), + TLVP_LEN(tp, BSSGP_IE_IMSI)); + } #if 0 /* Do not rely on this IE. TODO: make this configurable */ /* parse ms radio access capability */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I940d220a399166122f33e67a222dd572085e1401 Gerrit-Change-Number: 14922 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 20:39:58 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 20:39:58 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14923 ) Change subject: gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() ...................................................................... gprs_bssgp_pcu.cpp: check return code of gsm48_mi_to_string() Change-Id: Id1ad279ce9bef38eb3d11ac62337276207e8d8bd --- M src/gprs_bssgp_pcu.cpp 1 file changed, 17 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved keith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index 3ea3e59..f7c681c 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -28,6 +28,7 @@ #include extern "C" { + #include #include #include "coding_scheme.h" } @@ -93,6 +94,7 @@ char imsi[16] = "000"; uint8_t ms_class = 0; uint8_t egprs_ms_class = 0; + int rc; #if 0 MS_Radio_Access_capability_t rac; #endif @@ -120,8 +122,13 @@ * will listen to all paging blocks. */ if (TLVP_PRESENT(tp, BSSGP_IE_IMSI)) { - gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), - TLVP_LEN(tp, BSSGP_IE_IMSI)); + /* gsm48_mi_to_string() returns number of bytes written, including '\0' */ + rc = gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), + TLVP_LEN(tp, BSSGP_IE_IMSI)); + if (rc != GSM23003_IMSI_MAX_DIGITS + 1) { + LOGP(DBSSGP, LOGL_NOTICE, "Failed to parse IMSI IE (rc=%d)\n", rc); + return bssgp_tx_status(BSSGP_CAUSE_COND_IE_ERR, NULL, msg); + } } #if 0 /* Do not rely on this IE. TODO: make this configurable */ @@ -172,6 +179,7 @@ char imsi[16]; uint8_t *ptmsi = (uint8_t *) TLVP_VAL(tp, BSSGP_IE_TMSI); uint16_t ptmsi_len = TLVP_LEN(tp, BSSGP_IE_TMSI); + int rc; LOGP(DBSSGP, LOGL_NOTICE, " P-TMSI = "); for (int i = 0; i < ptmsi_len; i++) @@ -185,7 +193,13 @@ return -EINVAL; } - gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), TLVP_LEN(tp, BSSGP_IE_IMSI)); + /* gsm48_mi_to_string() returns number of bytes written, including '\0' */ + rc = gsm48_mi_to_string(imsi, sizeof(imsi), TLVP_VAL(tp, BSSGP_IE_IMSI), + TLVP_LEN(tp, BSSGP_IE_IMSI)); + if (rc != GSM23003_IMSI_MAX_DIGITS + 1) { + LOGP(DBSSGP, LOGL_NOTICE, "Failed to parse IMSI IE (rc=%d)\n", rc); + return bssgp_tx_status(BSSGP_CAUSE_COND_IE_ERR, NULL, msg); + } return gprs_rlcmac_paging_request(ptmsi, ptmsi_len, imsi); } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id1ad279ce9bef38eb3d11ac62337276207e8d8bd Gerrit-Change-Number: 14923 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 20:39:59 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Wed, 24 Jul 2019 20:39:59 +0000 Subject: Change in ...osmo-pcu[master]: gprs_bssgp_pcu_rx_dl_ud(): use OSMO_IMSI_BUF_SIZE In-Reply-To: References: Message-ID: fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14924 ) Change subject: gprs_bssgp_pcu_rx_dl_ud(): use OSMO_IMSI_BUF_SIZE ...................................................................... gprs_bssgp_pcu_rx_dl_ud(): use OSMO_IMSI_BUF_SIZE Change-Id: Ia1da9f005b7f801872c542d31cc8eabd859d997a --- M src/gprs_bssgp_pcu.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved keith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp index f7c681c..ddf5174 100644 --- a/src/gprs_bssgp_pcu.cpp +++ b/src/gprs_bssgp_pcu.cpp @@ -91,7 +91,7 @@ uint32_t tlli_old = 0; uint8_t *data; uint16_t len; - char imsi[16] = "000"; + char imsi[OSMO_IMSI_BUF_SIZE] = "000"; uint8_t ms_class = 0; uint8_t egprs_ms_class = 0; int rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/14924 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia1da9f005b7f801872c542d31cc8eabd859d997a Gerrit-Change-Number: 14924 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: keith Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 24 21:44:54 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 24 Jul 2019 21:44:54 +0000 Subject: Change in ...osmo-bts[master]: bts-trx: Introduce VTY command osmotrx trxd-max-version In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14896 ) Change subject: bts-trx: Introduce VTY command osmotrx trxd-max-version ...................................................................... Patch Set 4: > Patch Set 4: > > We forgot to update the VTY manual! No, because afaik only commands from osmo-bts-virtual are currently shown in the manual! -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/14896 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5eb1fdc002f9d7f4acf475356d8fc998dc8f6326 Gerrit-Change-Number: 14896 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 24 Jul 2019 21:44:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 06:35:05 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Jul 2019 06:35:05 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add fixed services In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14793 ) Change subject: debian-repo-install-test: add fixed services ...................................................................... Patch Set 3: Verified+1 Code-Review+2 All depending patches were merged. 1+1=2. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14793 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4e182b396e1a2e36a73384233b1a38a70c7cd5d9 Gerrit-Change-Number: 14793 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Jul 2019 06:35:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 06:35:31 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Jul 2019 06:35:31 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: add fixed services In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14793 ) Change subject: debian-repo-install-test: add fixed services ...................................................................... debian-repo-install-test: add fixed services Enable test of systemd services for osmo-sgsn, osmo-pcu, osmo-hnbgw and osmo-bts-virtual. Add issue ID to failing osmo-ctrl2cgi and osmo-trap2cgi services. Depends: Id892e1f4ab2daabbe9824b819b5fed985373b97a (osmo-sgsn) Depends: Ie8001611756b661ff1871508c6248b2e990ba1d7 (osmo-bsc) Depends: I354140f014854f1755b649e40a65e5d88b99c0ec (osmo-iuh) Related: OS#3369 Change-Id: I4e182b396e1a2e36a73384233b1a38a70c7cd5d9 --- M debian-repo-install-test/testdata/repo-install-test.sh 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved; Verified diff --git a/debian-repo-install-test/testdata/repo-install-test.sh b/debian-repo-install-test/testdata/repo-install-test.sh index e2cedd2..338fe8d 100755 --- a/debian-repo-install-test/testdata/repo-install-test.sh +++ b/debian-repo-install-test/testdata/repo-install-test.sh @@ -2,12 +2,8 @@ # Systemd services that must start up successfully after installing all packages (OS#3369) # Disabled services: -# * osmo-ctrl2cgi (missing config: /etc/osmocom/ctrl2cgi.ini) -# * osmo-trap2cgi (missing config: /etc/osmocom/%N.ini) -# * osmo-sgsn (port 2123 already used by osmo-ggsn) -# * osmo-pcu (expects missing /tmp/pcu_bts socket) -# * osmo-hnbgw (tries to listen on 10.23.24.1) -# * osmo-bts-virtual (unit_id is not matching osmo-bsc's config) +# * osmo-ctrl2cgi (missing config: /etc/osmocom/ctrl2cgi.ini, OS#4108) +# * osmo-trap2cgi (missing config: /etc/osmocom/%N.ini, OS#4108) SERVICES=" osmo-bsc osmo-gbproxy @@ -22,8 +18,16 @@ " # Services working in nightly, but not yet in latest # * osmo-pcap-server: service not included in osmo-pcap 0.0.11 +# * osmo-sgsn: conflicts with osmo-gtphub config in osmo-sgsn 1.4.0 +# * osmo-pcu: needs osmo-bts-virtual to start up properly +# * osmo-hnbgw: tries to listen on 10.23.24.1 in osmo-iuh 0.4.0 +# * osmo-bts-virtual: unit id not matching osmo-bsc's config in osmo-bsc 1.4.0 SERVICES_NIGHTLY=" osmo-pcap-server + osmo-sgsn + osmo-pcu + osmo-hnbgw + osmo-bts-virtual " HTTP="http://download.opensuse.org/repositories/network:/osmocom:/$FEED/Debian_9.0/" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14793 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I4e182b396e1a2e36a73384233b1a38a70c7cd5d9 Gerrit-Change-Number: 14793 Gerrit-PatchSet: 4 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 07:23:30 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 25 Jul 2019 07:23:30 +0000 Subject: Change in ...osmo-msc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14841 ) Change subject: doc: Add Osmux documentation to User Manual ...................................................................... Patch Set 6: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/14841/5/doc/manuals/chapters/osmux_msc.adoc File doc/manuals/chapters/osmux_msc.adoc: https://gerrit.osmocom.org/#/c/14841/5/doc/manuals/chapters/osmux_msc.adoc at 27 PS5, Line 27: towrds > towards Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 Gerrit-Change-Number: 14841 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Jul 2019 07:23:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 09:41:02 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 25 Jul 2019 09:41:02 +0000 Subject: Change in ...libosmocore[master]: stats_vty: Add verb to sentence for show asciidoc counters Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14931 Change subject: stats_vty: Add verb to sentence for show asciidoc counters ...................................................................... stats_vty: Add verb to sentence for show asciidoc counters Change-Id: Ib444383d2074ddb89b3fe5bbf198bcbfabd7057f --- M src/vty/stats_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/31/14931/1 diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c index 8c2ddc6..296519c 100644 --- a/src/vty/stats_vty.c +++ b/src/vty/stats_vty.c @@ -510,7 +510,7 @@ SHOW_STR "Asciidoc generation\n" "Generate table of all registered counters\n") { vty_out(vty, "// autogenerated by show asciidoc counters%s", VTY_NEWLINE); - vty_out(vty, "These counters and their description based on %s %s (%s).%s%s", + vty_out(vty, "These counters and their description are based on %s %s (%s).%s%s", host.app_info->name, host.app_info->version, host.app_info->name ? host.app_info->name : "", VTY_NEWLINE, VTY_NEWLINE); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib444383d2074ddb89b3fe5bbf198bcbfabd7057f Gerrit-Change-Number: 14931 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 10:34:12 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Jul 2019 10:34:12 +0000 Subject: Change in ...osmo-hlr[master]: gitignore: ignore everything generated in db_test Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14932 Change subject: gitignore: ignore everything generated in db_test ...................................................................... gitignore: ignore everything generated in db_test Change-Id: I3545be056cc7e4f72f6f86e772f9cc70a8e5c03c --- M .gitignore 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/32/14932/1 diff --git a/.gitignore b/.gitignore index 0397e35..93f65e9 100644 --- a/.gitignore +++ b/.gitignore @@ -2,6 +2,8 @@ *.lo *.la *.db +*.db-shm +*.db-wal *.pyc .*.sw? .version @@ -38,6 +40,7 @@ tests/atconfig tests/testsuite tests/testsuite.log +tests/testsuite.dir tests/auc/auc_3g_test tests/auc/auc_ts_55_205_test_sets.c -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3545be056cc7e4f72f6f86e772f9cc70a8e5c03c Gerrit-Change-Number: 14932 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 10:34:13 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Jul 2019 10:34:13 +0000 Subject: Change in ...osmo-hlr[master]: db_auc.c: verify hex key sizes read from DB Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14933 Change subject: db_auc.c: verify hex key sizes read from DB ...................................................................... db_auc.c: verify hex key sizes read from DB Replace commented out size check for Ki with a real check, and use it consistently for Ki, K, OP and OPC. Add a test that sets all keys to the wrong size and tries to read them. Related: OS#2565 Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 --- M src/db_auc.c M tests/db/db_test.c M tests/db/db_test.err 3 files changed, 197 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/33/14933/1 diff --git a/src/db_auc.c b/src/db_auc.c index e29b44b..2265a5c 100644 --- a/src/db_auc.c +++ b/src/db_auc.c @@ -73,6 +73,28 @@ return ret; } +/* hexparse a specific column of a sqlite prepared statement into dst (with length check) + * returns 0 for success, -EIO on error */ +int hexparse_stmt(void *dst, sqlite3_stmt *stmt, int col, const char *col_name, const char *imsi, int len_dst) { + const uint8_t *text; + int len_col; + + len_col = sqlite3_column_bytes(stmt, col) / 2; + if (len_col != len_dst) { + LOGAUC(imsi, LOGL_ERROR, "Error reading %s, expected length %i but has length %i\n", col_name, len_dst, + len_col); + return -EIO; + } + + text = sqlite3_column_text(stmt, col); + if (!text) { + LOGAUC(imsi, LOGL_ERROR, "Error reading %s\n", col_name); + return -EIO; + } + osmo_hexparse((void *)text, dst, len_dst); + return 0; +} + /* obtain the authentication data for a given imsi * returns 0 for success, negative value on error: * -ENOENT if the IMSI is not known, -ENOKEY if the IMSI is known but has no auth data, @@ -113,49 +135,34 @@ /* obtain result values using sqlite3_column_*() */ if (sqlite3_column_type(stmt, 1) == SQLITE_INTEGER) { /* we do have some 2G authentication data */ - const uint8_t *ki; - - aud2g->algo = sqlite3_column_int(stmt, 1); - ki = sqlite3_column_text(stmt, 2); -#if 0 - if (sqlite3_column_bytes(stmt, 2) != sizeof(aud2g->u.gsm.ki)) { - LOGAUC(imsi, LOGL_ERROR, "Error reading Ki: %d\n", rc); + if (hexparse_stmt(&aud2g->u.gsm.ki, stmt, 2, "Ki", imsi, sizeof(aud2g->u.gsm.ki))) goto end_2g; - } -#endif - osmo_hexparse((void*)ki, (void*)&aud2g->u.gsm.ki, sizeof(aud2g->u.gsm.ki)); + aud2g->algo = sqlite3_column_int(stmt, 1); aud2g->type = OSMO_AUTH_TYPE_GSM; } else LOGAUC(imsi, LOGL_DEBUG, "No 2G Auth Data\n"); -//end_2g: +end_2g: if (sqlite3_column_type(stmt, 3) == SQLITE_INTEGER) { /* we do have some 3G authentication data */ - const uint8_t *k, *op, *opc; - - aud3g->algo = sqlite3_column_int(stmt, 3); - k = sqlite3_column_text(stmt, 4); - if (!k) { - LOGAUC(imsi, LOGL_ERROR, "Error reading K: %d\n", rc); + if (hexparse_stmt(&aud3g->u.umts.k, stmt, 4, "K", imsi, sizeof(aud3g->u.umts.k))) { ret = -EIO; goto out; } - osmo_hexparse((void*)k, (void*)&aud3g->u.umts.k, sizeof(aud3g->u.umts.k)); + aud3g->algo = sqlite3_column_int(stmt, 3); + /* UMTS Subscribers can have either OP or OPC */ - op = sqlite3_column_text(stmt, 5); - if (!op) { - opc = sqlite3_column_text(stmt, 6); - if (!opc) { - LOGAUC(imsi, LOGL_ERROR, "Error reading OPC: %d\n", rc); + if (sqlite3_column_text(stmt, 5)) { + if (hexparse_stmt(&aud3g->u.umts.opc, stmt, 5, "OP", imsi, sizeof(aud3g->u.umts.opc))) { ret = -EIO; goto out; } - osmo_hexparse((void*)opc, (void*)&aud3g->u.umts.opc, - sizeof(aud3g->u.umts.opc)); - aud3g->u.umts.opc_is_op = 0; - } else { - osmo_hexparse((void*)op, (void*)&aud3g->u.umts.opc, - sizeof(aud3g->u.umts.opc)); aud3g->u.umts.opc_is_op = 1; + } else { + if (hexparse_stmt(&aud3g->u.umts.opc, stmt, 6, "OPC", imsi, sizeof(aud3g->u.umts.opc))) { + ret = -EIO; + goto out; + } + aud3g->u.umts.opc_is_op = 0; } aud3g->u.umts.sqn = sqlite3_column_int64(stmt, 7); aud3g->u.umts.ind_bitlen = sqlite3_column_int(stmt, 8); diff --git a/tests/db/db_test.c b/tests/db/db_test.c index fdd62c5..cc299bf 100644 --- a/tests/db/db_test.c +++ b/tests/db/db_test.c @@ -208,6 +208,17 @@ #undef Phex } +void db_raw_sql(struct db_context *dbc, const char *sql) +{ + sqlite3_stmt *stmt; + + fprintf(stderr, "raw SQL: %s\n", sql); + ASSERT_RC(sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL), SQLITE_OK); + ASSERT_RC(sqlite3_step(stmt), SQLITE_DONE); + db_remove_reset(stmt); + sqlite3_finalize(stmt); +} + static const char *imsi0 = "123456789000000"; static const char *imsi1 = "123456789000001"; static const char *imsi2 = "123456789000002"; @@ -749,6 +760,70 @@ comment_end(); } +/* Make each key too short in this test. Note that we can't set them longer than the allowed size without changing the + * table structure. */ +static void test_subscr_aud_invalid_len() +{ + int64_t id; + + comment_start(); + comment("Create subscriber"); + ASSERT_RC(db_subscr_create(dbc, imsi0, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), 0); + ASSERT_SEL(imsi, imsi0, 0); + id = g_subscr.id; + + + /* Invalid Ki length */ + comment("Set auth data, 2G only, with invalid Ki length"); + ASSERT_RC(db_subscr_update_aud_by_id(dbc, id, + mk_aud_2g(OSMO_AUTH_ALG_COMP128v1, "0123456789abcdef0123456789abcdef")), + 0); + /* Use raw SQL to avoid length check in db_subscr_update_aud_by_id(). This changes all rows in the table, which + * is fine for this test (implicit WHERE 1). */ + db_raw_sql(dbc, "UPDATE auc_2g SET ki = '0123456789abcdef0123456789abcde'"); + ASSERT_SEL_AUD(imsi0, -ENOKEY, id); + + comment("Remove 2G auth data"); + ASSERT_RC(db_subscr_update_aud_by_id(dbc, id, + mk_aud_2g(OSMO_AUTH_ALG_NONE, NULL)), + 0); + + /* Invalid K length */ + comment("Set auth data, 3G only, with invalid K length"); + ASSERT_RC(db_subscr_update_aud_by_id(dbc, id, + mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, + "BeefedCafeFaceAcedAddedDecadeFee", true, + "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)), + 0); + db_raw_sql(dbc, "UPDATE auc_3g SET k = 'C01ffedC1cadaeAc1d1f1edAcac1aB0'"); + ASSERT_SEL_AUD(imsi0, -EIO, id); + + /* Invalid OP length */ + comment("Set auth data, 3G only, with invalid OP length"); + ASSERT_RC(db_subscr_update_aud_by_id(dbc, id, + mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, + "BeefedCafeFaceAcedAddedDecadeFee", true, + "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)), + 0); + db_raw_sql(dbc, "UPDATE auc_3g SET op = 'BeefedCafeFaceAcedAddedDecadeFe'"); + ASSERT_SEL_AUD(imsi0, -EIO, id); + + /* Invalid OPC length */ + comment("Set auth data, 3G only, with invalid OPC length"); + ASSERT_RC(db_subscr_update_aud_by_id(dbc, id, + mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, + "BeefedCafeFaceAcedAddedDecadeFee", false, + "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)), + 0); + db_raw_sql(dbc, "UPDATE auc_3g SET opc = 'BeefedCafeFaceAcedAddedDecadeFe'"); + ASSERT_SEL_AUD(imsi0, -EIO, id); + + + comment("Delete subscriber"); + ASSERT_RC(db_subscr_delete_by_id(dbc, id), 0); + comment_end(); +} + static void test_subscr_sqn() { int64_t id; @@ -900,6 +975,7 @@ test_subscr_create_update_sel_delete(); test_subscr_aud(); + test_subscr_aud_invalid_len(); test_subscr_sqn(); printf("Done\n"); diff --git a/tests/db/db_test.err b/tests/db/db_test.err index 4dc77e8..a7c4cf1 100644 --- a/tests/db/db_test.err +++ b/tests/db/db_test.err @@ -1338,6 +1338,91 @@ ===== test_subscr_aud: SUCCESS +===== test_subscr_aud_invalid_len + +--- Create subscriber + +db_subscr_create(dbc, imsi0, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS) --> 0 + +db_subscr_get_by_imsi(dbc, imsi0, &g_subscr) --> 0 +struct hlr_subscriber { + .id = 1, + .imsi = '123456789000000', +} + + +--- Set auth data, 2G only, with invalid Ki length + +db_subscr_update_aud_by_id(dbc, id, mk_aud_2g(OSMO_AUTH_ALG_COMP128v1, "0123456789abcdef0123456789abcdef")) --> 0 + +raw SQL: UPDATE auc_2g SET ki = '0123456789abcdef0123456789abcde' +sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL) --> SQLITE_OK + +sqlite3_step(stmt) --> SQLITE_DONE + +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -126 +DAUC IMSI='123456789000000': Error reading Ki, expected length 16 but has length 15 +DAUC IMSI='123456789000000': No 3G Auth Data + + + +--- Remove 2G auth data + +db_subscr_update_aud_by_id(dbc, id, mk_aud_2g(OSMO_AUTH_ALG_NONE, NULL)) --> 0 + + +--- Set auth data, 3G only, with invalid K length + +db_subscr_update_aud_by_id(dbc, id, mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, "BeefedCafeFaceAcedAddedDecadeFee", true, "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)) --> 0 + +raw SQL: UPDATE auc_3g SET k = 'C01ffedC1cadaeAc1d1f1edAcac1aB0' +sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL) --> SQLITE_OK + +sqlite3_step(stmt) --> SQLITE_DONE + +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -5 +DAUC IMSI='123456789000000': No 2G Auth Data +DAUC IMSI='123456789000000': Error reading K, expected length 16 but has length 15 + + + +--- Set auth data, 3G only, with invalid OP length + +db_subscr_update_aud_by_id(dbc, id, mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, "BeefedCafeFaceAcedAddedDecadeFee", true, "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)) --> 0 + +raw SQL: UPDATE auc_3g SET op = 'BeefedCafeFaceAcedAddedDecadeFe' +sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL) --> SQLITE_OK + +sqlite3_step(stmt) --> SQLITE_DONE + +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -5 +DAUC IMSI='123456789000000': No 2G Auth Data +DAUC IMSI='123456789000000': Error reading OP, expected length 16 but has length 15 + + + +--- Set auth data, 3G only, with invalid OPC length + +db_subscr_update_aud_by_id(dbc, id, mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, "BeefedCafeFaceAcedAddedDecadeFee", false, "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)) --> 0 + +raw SQL: UPDATE auc_3g SET opc = 'BeefedCafeFaceAcedAddedDecadeFe' +sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL) --> SQLITE_OK + +sqlite3_step(stmt) --> SQLITE_DONE + +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -5 +DAUC IMSI='123456789000000': No 2G Auth Data +DAUC IMSI='123456789000000': Error reading OPC, expected length 16 but has length 15 + + + +--- Delete subscriber + +db_subscr_delete_by_id(dbc, id) --> 0 + +===== test_subscr_aud_invalid_len: SUCCESS + + ===== test_subscr_sqn --- Set SQN for unknown subscriber -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 Gerrit-Change-Number: 14933 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 10:39:07 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 10:39:07 +0000 Subject: Change in ...osmo-msc[master]: doc: Add Osmux documentation to User Manual In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-msc/+/14841 ) Change subject: doc: Add Osmux documentation to User Manual ...................................................................... doc: Add Osmux documentation to User Manual Depends: osmo-gsm-manuals.git f3a734e6777a902abfb03257277454c7a879aeb7 Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 --- A doc/manuals/chapters/osmux_msc.adoc M doc/manuals/osmomsc-usermanual.adoc 2 files changed, 67 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve daniel: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/osmux_msc.adoc b/doc/manuals/chapters/osmux_msc.adoc new file mode 100644 index 0000000..ed722f2 --- /dev/null +++ b/doc/manuals/chapters/osmux_msc.adoc @@ -0,0 +1,65 @@ +include::{commondir}/chapters/osmux/osmux.adoc[] + +=== Osmux Support in {program-name} + +==== {program-name} in a A/IP with IPA/SCCPlite network setup + +In this kind of setup, the CN side of BSC co-located MGW is managed by the MSC, +meaning the use of Osmux is transparent to BSC since MSC takes care of both peer +MGW connections. Moreover, in this case the MSC has no dynamic information on +Osmux support in the BSC co-located MGW until `CRCX` time, which means +configuration on both nodes need to be carefully set up so they can work +together. + +Osmux usage in {program-name} in managed through the VTY command `osmux +(on|off|only)`. Since there's no dynamic information on Osmux support, it may be +required in the future to have an extra VTY command which can be set per BSC to +fine-tune which ones should use Osmux and which shouldn't. + +{program-name} will behave differently during call set up based on the VTY +command presented above: + +* `off`: {program-name} won't include an `X-Osmux` extension to `CRCX` sent to + the BSC co-located MGW when configuring the CN side of the MGW endpoint. If + the MGW answers with a `CRCX ACK` containing an `X-Osmux`, {program-name} will + cancel the call establishment. +* `on`: {program-name} will initially configure its co-located MGW to use Osmux, then + similarly send a `CRCX` with an `X-Osmux` extension towards the BSC co-located + MGW. Under this configuration, if the BSC co-located MGW didn't support Osmux, + it could send a `CRCX ACK` without `X-Osmux` extension or fail (depending on + its own configuration), and {program-name} could choose to re-create its local + connection as non-Osmux (RTP) (and possibly try again against BSC co-located + MGW), but this behavior is currently not implemented. As a result, currently + `on` behaves the same as `only`. +* `only`: {program-name} will configure its co-located MGW as well as the BSC + co-located MGW to use Osmux by including the `X-Osmux` MGCP extension. If MGW + rejects to use Osmux, {program-name} will reject the call and the call + establishment will fail. + +==== {program-name} in a 3GPP AoIP network setup + +Osmux usage in {program-name} in managed through the VTY command `osmux +(on|off|only)`. Once enabled (`on` or `only`), {program-name} will start +appending the vendor specific _Osmux Support_ IE in _BSSMAP RESET_ and _BSSMAP +RESET-ACK_ message towards the BSC in order to announce it supports Osmux, and +BSC will do the same. This way, {program-name} can decide whether to use Osmux +or not based on this information when setting up a call (this time using _Osmux +CID_ IE). It should be noted that this option should not be enabled unless BSCs +managed by {program-name} support handling this extension IE (like OsmoBSC), +3rd-party BSCs might otherwise refuse the related _RESET_/_RESET-ACK_ messages. + +{program-name} will behave differently during call set up based on the VTY +command presented above: + +* `off`: {program-name} won't use Osmux. That is, it will send a _BSSMAP Assign + Request_ without the _Osmux CID_ IE, and will send a `CRCX` without `X-Osmux` + extension towards its co-located MGW. +* `on`: If BSC announced Osmux support to {program-name} during _BSSMAP RESET_ + time, then {program-name} will set up the call to use Osmux (by adding + `X-Osmux` to MGCP `CRCX` and _Osmux CID_ IE to _BSSMAP Assign Request_). If + the BSC didn't announce Osmux support to {program-name}, then {program-name} + will use RTP to set up the call (by avoiding addition of previously described + bits). +* `only`: Same as per `on`, except that {program-name} will allow to set up only + Osmux calls on the CN-side, this is, it will reject to set up voice calls for + BSC which didn't announce Osmux support. diff --git a/doc/manuals/osmomsc-usermanual.adoc b/doc/manuals/osmomsc-usermanual.adoc index 3c69d7b..d680a51 100644 --- a/doc/manuals/osmomsc-usermanual.adoc +++ b/doc/manuals/osmomsc-usermanual.adoc @@ -28,6 +28,8 @@ include::./common/chapters/mncc.adoc[] +include::{srcdir}/chapters/osmux_msc.adoc[] + include::./common/chapters/control_if.adoc[] include::./common/chapters/gsup.adoc[] @@ -39,4 +41,3 @@ include::./common/chapters/glossary.adoc[] include::./common/chapters/gfdl.adoc[] - -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I70c488c3d9b05599b834a8608e6361c8aa43ef31 Gerrit-Change-Number: 14841 Gerrit-PatchSet: 7 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 10:42:24 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 10:42:24 +0000 Subject: Change in ...libosmocore[master]: stats_vty: Add verb to sentence for show asciidoc counters In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14931 ) Change subject: stats_vty: Add verb to sentence for show asciidoc counters ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib444383d2074ddb89b3fe5bbf198bcbfabd7057f Gerrit-Change-Number: 14931 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Jul 2019 10:42:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 10:42:48 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 10:42:48 +0000 Subject: Change in ...osmo-hlr[master]: gitignore: ignore everything generated in db_test In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14932 ) Change subject: gitignore: ignore everything generated in db_test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3545be056cc7e4f72f6f86e772f9cc70a8e5c03c Gerrit-Change-Number: 14932 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Jul 2019 10:42:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 10:51:10 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 10:51:10 +0000 Subject: Change in ...osmo-hlr[master]: db_auc.c: verify hex key sizes read from DB In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14933 ) Change subject: db_auc.c: verify hex key sizes read from DB ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/14933/1/src/db_auc.c File src/db_auc.c: https://gerrit.osmocom.org/#/c/14933/1/src/db_auc.c at 78 PS1, Line 78: int hexparse_stmt(void *dst, sqlite3_stmt *stmt, int col, const char *col_name, const char *imsi, int len_dst) { * static missing in function? * Why is dst a void* ptr? Isn't there something more descriptive? What's the type of aud2g->u.gsm.ki? uint8_t* ? * Please put dst next-to len-dst (if I understand correct len_dst is the buffer size of dst). https://gerrit.osmocom.org/#/c/14933/1/src/db_auc.c at 82 PS1, Line 82: len_col = sqlite3_column_bytes(stmt, col) / 2; Why /2? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 Gerrit-Change-Number: 14933 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Jul 2019 10:51:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 11:10:39 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 11:10:39 +0000 Subject: Change in ...osmo-gsm-tester[master]: resources.conf.prod: Use different ARFCN for sysmocell-5k Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14934 Change subject: resources.conf.prod: Use different ARFCN for sysmocell-5k ...................................................................... resources.conf.prod: Use different ARFCN for sysmocell-5k Due to a bug in sysmocell-5K's TRX implementation, it may keep polluting the air transmitting after the BTS is disconnected. This could cause interferences with other tests. Correct fix would be to RF lock it after test finishes (through ccli), but let's simply use a different ARFCN for now. Related: OS#4129 Change-Id: I6d5555aa8740b262ee92110987189c076db44f76 --- M example/resources.conf.prod M src/osmo_gsm_tester/resource.py 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/34/14934/1 diff --git a/example/resources.conf.prod b/example/resources.conf.prod index 8b498d0..b0a679e 100644 --- a/example/resources.conf.prod +++ b/example/resources.conf.prod @@ -69,6 +69,8 @@ addr: 10.42.42.51 band: GSM-1800 ciphers: [a5_0, a5_1] + trx_list: + - arfcn: 878 osmo_trx: launch_trx: false clock_reference: external diff --git a/src/osmo_gsm_tester/resource.py b/src/osmo_gsm_tester/resource.py index 1b18076..aa41b98 100644 --- a/src/osmo_gsm_tester/resource.py +++ b/src/osmo_gsm_tester/resource.py @@ -60,6 +60,7 @@ 'bts[].num_trx': schema.UINT, 'bts[].max_trx': schema.UINT, 'bts[].trx_list[].addr': schema.IPV4, + 'bts[].trx_list[].arfcn': schema.INT, 'bts[].trx_list[].hw_addr': schema.HWADDR, 'bts[].trx_list[].net_device': schema.STR, 'bts[].trx_list[].nominal_power': schema.UINT, -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I6d5555aa8740b262ee92110987189c076db44f76 Gerrit-Change-Number: 14934 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 12:00:12 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Jul 2019 12:00:12 +0000 Subject: Change in ...osmo-mgw[master]: Catch unsigned integer MGCP parsing errors with strtoul In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14905 ) Change subject: Catch unsigned integer MGCP parsing errors with strtoul ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14905 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifba1c1e3151d6f92f9da3d4ca2569a5908455ca8 Gerrit-Change-Number: 14905 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Jul 2019 12:00:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 12:05:29 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 25 Jul 2019 12:05:29 +0000 Subject: Change in ...osmo-hlr[master]: gitignore: ignore everything generated in db_test In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14932 ) Change subject: gitignore: ignore everything generated in db_test ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14932/1/.gitignore File .gitignore: https://gerrit.osmocom.org/#/c/14932/1/.gitignore at 5 PS1, Line 5: *.db-shm : *.db-wal If both files are left by the test, then the database was not closed properly. I think we should investigate the reason rather than ignoring consequences. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3545be056cc7e4f72f6f86e772f9cc70a8e5c03c Gerrit-Change-Number: 14932 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 25 Jul 2019 12:05:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 12:09:04 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Jul 2019 12:09:04 +0000 Subject: Change in ...osmo-hlr[master]: gitignore: ignore everything generated in db_test In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14932 ) Change subject: gitignore: ignore everything generated in db_test ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14932/1/.gitignore File .gitignore: https://gerrit.osmocom.org/#/c/14932/1/.gitignore at 5 PS1, Line 5: *.db-shm : *.db-wal > If both files are left by the test, then the database was not closed properly. [?] When the test runs through, then these don't remain. But it is inconvenient for me during development: some test may have an assertion failure, and then the files remain and git picks them up with "git add -A". -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3545be056cc7e4f72f6f86e772f9cc70a8e5c03c Gerrit-Change-Number: 14932 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 25 Jul 2019 12:09:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 12:14:07 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 25 Jul 2019 12:14:07 +0000 Subject: Change in ...libosmocore[master]: gsm/gsm48.h: drop meaningless 'const' from gsm48_mi_to_string() Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14935 Change subject: gsm/gsm48.h: drop meaningless 'const' from gsm48_mi_to_string() ...................................................................... gsm/gsm48.h: drop meaningless 'const' from gsm48_mi_to_string() Change-Id: I5eb17edadf89ac47b4ca86c9e822037f7c0e518e --- M include/osmocom/gsm/gsm48.h M src/gsm/gsm48.c 2 files changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/35/14935/1 diff --git a/include/osmocom/gsm/gsm48.h b/include/osmocom/gsm/gsm48.h index 786fbc9..7c68b1d 100644 --- a/include/osmocom/gsm/gsm48.h +++ b/include/osmocom/gsm/gsm48.h @@ -53,8 +53,7 @@ uint8_t gsm48_generate_mid(uint8_t *buf, const char *id, uint8_t mi_type); /* Convert Mobile Identity (10.5.1.4) to string */ -int gsm48_mi_to_string(char *string, const int str_len, - const uint8_t *mi, const int mi_len); +int gsm48_mi_to_string(char *string, int str_len, const uint8_t *mi, int mi_len); const char *gsm48_mi_type_name(uint8_t mi); const char *osmo_mi_name(const uint8_t *mi, uint8_t mi_len); char *osmo_mi_name_buf(char *buf, size_t buf_len, const uint8_t *mi, uint8_t mi_len); diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index c97337b..2d6deb5 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -741,8 +741,7 @@ * Depending on the MI type and amount of output buffer, this may return * the nr of written bytes, or the written strlen(), or the snprintf() * style strlen()-if-the-buffer-were-large-enough. */ -int gsm48_mi_to_string(char *string, const int str_len, const uint8_t *mi, - const int mi_len) +int gsm48_mi_to_string(char *string, int str_len, const uint8_t *mi, int mi_len) { int rc; uint8_t mi_type; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5eb17edadf89ac47b4ca86c9e822037f7c0e518e Gerrit-Change-Number: 14935 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 12:14:48 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 12:14:48 +0000 Subject: Change in ...osmo-mgw[master]: Catch unsigned integer MGCP parsing errors with strtoul In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14905 ) Change subject: Catch unsigned integer MGCP parsing errors with strtoul ...................................................................... Catch unsigned integer MGCP parsing errors with strtoul Checks to find if strotul failed are taken both from: man strtoul man strtol Change-Id: Ifba1c1e3151d6f92f9da3d4ca2569a5908455ca8 --- M src/libosmo-mgcp-client/mgcp_client.c M src/libosmo-mgcp/mgcp_sdp.c 2 files changed, 16 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index fd188c3..910289e 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -36,6 +36,8 @@ #include #include #include +#include +#include #ifndef OSMUX_CID_MAX #define OSMUX_CID_MAX 255 /* FIXME: use OSMUX_CID_MAX from libosmo-netif? */ @@ -265,6 +267,7 @@ static int mgcp_parse_audio_port_pt(struct mgcp_response *r, char *line) { char *pt_str; + char *pt_end; unsigned int pt; unsigned int count = 0; unsigned int i; @@ -289,7 +292,11 @@ pt_str = strtok(NULL, " "); if (!pt_str) break; - pt = atoi(pt_str); + errno = 0; + pt = strtoul(pt_str, &pt_end, 0); + if ((errno == ERANGE && pt == ULONG_MAX) || (errno && !pt) || + pt_str == pt_end) + goto response_parse_failure_pt; /* Do not allow duplicate payload types */ for (i = 0; i < count; i++) diff --git a/src/libosmo-mgcp/mgcp_sdp.c b/src/libosmo-mgcp/mgcp_sdp.c index ddd4657..56fc611 100644 --- a/src/libosmo-mgcp/mgcp_sdp.c +++ b/src/libosmo-mgcp/mgcp_sdp.c @@ -29,6 +29,8 @@ #include #include +#include +#include /* Two structs to store intermediate parsing results. The function * mgcp_parse_sdp_data() is using the following two structs as temporary @@ -129,6 +131,7 @@ char *str; char *str_ptr; char *pt_str; + char *pt_end; unsigned int pt; unsigned int count = 0; unsigned int i; @@ -154,7 +157,11 @@ if (!pt_str) break; - pt = atoi(pt_str); + errno = 0; + pt = strtoul(pt_str, &pt_end, 0); + if ((errno == ERANGE && pt == ULONG_MAX) || (errno && !pt) || + pt_str == pt_end) + goto error; /* Do not allow duplicate payload types */ for (i = 0; i < count; i++) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14905 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifba1c1e3151d6f92f9da3d4ca2569a5908455ca8 Gerrit-Change-Number: 14905 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 12:17:48 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 12:17:48 +0000 Subject: Change in ...libosmocore[master]: gsm/gsm48.h: drop meaningless 'const' from gsm48_mi_to_string() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14935 ) Change subject: gsm/gsm48.h: drop meaningless 'const' from gsm48_mi_to_string() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5eb17edadf89ac47b4ca86c9e822037f7c0e518e Gerrit-Change-Number: 14935 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 25 Jul 2019 12:17:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 12:19:04 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 25 Jul 2019 12:19:04 +0000 Subject: Change in ...osmo-hlr[master]: db_auc.c: verify hex key sizes read from DB In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14933 ) Change subject: db_auc.c: verify hex key sizes read from DB ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14933/1/src/db_auc.c File src/db_auc.c: https://gerrit.osmocom.org/#/c/14933/1/src/db_auc.c at 78 PS1, Line 78: int hexparse_stmt(void *dst, sqlite3_stmt *stmt, int col, const char *col_name, const char *imsi, int len_dst) { > Please put dst next-to len-dst (if I understand correct len_dst is the buffer size of dst). We can just follow the style of memcpy(): int hexparse_stmt(void *dst, size_t dst_len, ...); https://gerrit.osmocom.org/#/c/14933/1/src/db_auc.c at 82 PS1, Line 82: len_col = sqlite3_column_bytes(stmt, col) / 2; > Why /2? Probably because we're reading a 'hexstring', where e.g. '05FF' takes 4 bytes in the DB, but actually means 2 bytes. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 Gerrit-Change-Number: 14933 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 25 Jul 2019 12:19:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 12:27:50 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 25 Jul 2019 12:27:50 +0000 Subject: Change in ...osmo-hlr[master]: gitignore: ignore everything generated in db_test In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14932 ) Change subject: gitignore: ignore everything generated in db_test ...................................................................... Patch Set 1: Code-Review+1 Ok, fine with me then ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3545be056cc7e4f72f6f86e772f9cc70a8e5c03c Gerrit-Change-Number: 14932 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Jul 2019 12:27:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 12:45:08 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Jul 2019 12:45:08 +0000 Subject: Change in ...osmo-hlr[master]: db_auc.c: verify hex key sizes read from DB In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/14933 to look at the new patch set (#2). Change subject: db_auc.c: verify hex key sizes read from DB ...................................................................... db_auc.c: verify hex key sizes read from DB Replace commented out size check for Ki with a real check, and use it consistently for Ki, K, OP and OPC. Add a test that sets all keys to the wrong size and tries to read them. Related: OS#2565 Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 --- M src/db_auc.c M tests/db/db_test.c M tests/db/db_test.err 3 files changed, 199 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/33/14933/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 Gerrit-Change-Number: 14933 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 12:45:20 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Jul 2019 12:45:20 +0000 Subject: Change in ...osmo-hlr[master]: db_auc.c: verify hex key sizes read from DB In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14933 ) Change subject: db_auc.c: verify hex key sizes read from DB ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14933/1/src/db_auc.c File src/db_auc.c: https://gerrit.osmocom.org/#/c/14933/1/src/db_auc.c at 78 PS1, Line 78: int hexparse_stmt(void *dst, sqlite3_stmt *stmt, int col, const char *col_name, const char *imsi, int len_dst) { > > Please put dst next-to len-dst (if I understand correct len_dst is the buffer size of dst). [?] All review points addressed. Thanks! https://gerrit.osmocom.org/#/c/14933/1/src/db_auc.c at 82 PS1, Line 82: len_col = sqlite3_column_bytes(stmt, col) / 2; > Probably because we're reading a 'hexstring', where e.g. [?] Exactly. I've added a comment to clarify this. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 Gerrit-Change-Number: 14933 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 25 Jul 2019 12:45:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 12:45:55 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Jul 2019 12:45:55 +0000 Subject: Change in ...osmo-hlr[master]: gitignore: ignore everything generated in db_test In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14932 ) Change subject: gitignore: ignore everything generated in db_test ...................................................................... gitignore: ignore everything generated in db_test Change-Id: I3545be056cc7e4f72f6f86e772f9cc70a8e5c03c --- M .gitignore 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/.gitignore b/.gitignore index 0397e35..93f65e9 100644 --- a/.gitignore +++ b/.gitignore @@ -2,6 +2,8 @@ *.lo *.la *.db +*.db-shm +*.db-wal *.pyc .*.sw? .version @@ -38,6 +40,7 @@ tests/atconfig tests/testsuite tests/testsuite.log +tests/testsuite.dir tests/auc/auc_3g_test tests/auc/auc_ts_55_205_test_sets.c -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I3545be056cc7e4f72f6f86e772f9cc70a8e5c03c Gerrit-Change-Number: 14932 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 12:49:33 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 12:49:33 +0000 Subject: Change in ...osmo-hlr[master]: db_auc.c: verify hex key sizes read from DB In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14933 ) Change subject: db_auc.c: verify hex key sizes read from DB ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14933/2/src/db_auc.c File src/db_auc.c: https://gerrit.osmocom.org/#/c/14933/2/src/db_auc.c at 84 PS2, Line 84: col_len = sqlite3_column_bytes(stmt, col) / 2; You didn't finally add the comment ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 Gerrit-Change-Number: 14933 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 25 Jul 2019 12:49:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 12:51:12 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Jul 2019 12:51:12 +0000 Subject: Change in ...osmo-hlr[master]: db_auc.c: verify hex key sizes read from DB In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14933 ) Change subject: db_auc.c: verify hex key sizes read from DB ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14933/2/src/db_auc.c File src/db_auc.c: https://gerrit.osmocom.org/#/c/14933/2/src/db_auc.c at 84 PS2, Line 84: col_len = sqlite3_column_bytes(stmt, col) / 2; > You didn't finally add the comment ;) Right, I did not submit that one. Fixed :) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 Gerrit-Change-Number: 14933 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 25 Jul 2019 12:51:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 12:52:25 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Thu, 25 Jul 2019 12:52:25 +0000 Subject: Change in ...osmo-hlr[master]: db_auc.c: verify hex key sizes read from DB In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/14933 to look at the new patch set (#3). Change subject: db_auc.c: verify hex key sizes read from DB ...................................................................... db_auc.c: verify hex key sizes read from DB Replace commented out size check for Ki with a real check, and use it consistently for Ki, K, OP and OPC. Add a test that sets all keys to the wrong size and tries to read them. Related: OS#2565 Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 --- M src/db_auc.c M tests/db/db_test.c M tests/db/db_test.err 3 files changed, 201 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/33/14933/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 Gerrit-Change-Number: 14933 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 13:05:28 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 13:05:28 +0000 Subject: Change in ...osmo-gsm-tester[master]: ttcn3: Increase TTCN3 IPA UP to have sysmobts tests working Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14936 Change subject: ttcn3: Increase TTCN3 IPA UP to have sysmobts tests working ...................................................................... ttcn3: Increase TTCN3 IPA UP to have sysmobts tests working It was spotted that most TTCN3 tests run against sysmobts fail because of following error: BTS_Tests.ttcn:643 Test case TC_chan_act_react finished. Verdict: fail reason: "BTS_Tests.ttcn:399 : Timeout waiting for ASP_IPA_EVENT_UP" Looking carefully at the logs and pcap files, it was seen that usually sysmobts tries to connect around 1 second after the TTCN3 tests decides it's enough. Current timeout was default of 15 seconds. Let's set it to 30 seconds. While at it, also set mp_ipa_up_delay, as initially set to 3 seconds in osmo-ttcn3-hacks.git d95f340a01fe7e9fe59f02b6ec4f9d018feb8c75 having physical tests in mind. Change-Id: I25c0a49851865291c6251556aff139961c3d4166 --- M ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/36/14936/1 diff --git a/ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl b/ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl index 92f0faa..eae6063 100644 --- a/ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl +++ b/ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl @@ -22,6 +22,8 @@ BTS_Tests.mp_tolerance_rxlev := 10; BTS_Tests.mp_tolerance_rxqual := 1; BTS_Tests.mp_trx0_arfcn := 868 +BTS_Tests.mp_ipa_up_timeout := 30.0 +BTS_Tests.mp_ipa_up_delay := 3.0 [MAIN_CONTROLLER] -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I25c0a49851865291c6251556aff139961c3d4166 Gerrit-Change-Number: 14936 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 13:07:54 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 13:07:54 +0000 Subject: Change in ...osmo-hlr[master]: db_auc.c: verify hex key sizes read from DB In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14933 ) Change subject: db_auc.c: verify hex key sizes read from DB ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 Gerrit-Change-Number: 14933 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Thu, 25 Jul 2019 13:07:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 15:28:50 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 25 Jul 2019 15:28:50 +0000 Subject: Change in ...osmo-gsm-manuals[master]: counters-overview: Add a section about the stats reporter Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14937 Change subject: counters-overview: Add a section about the stats reporter ...................................................................... counters-overview: Add a section about the stats reporter Fixes: OS#3768 Change-Id: Ia338409e6cb1b1478429e3a99158b9d8255dbb2c --- M common/chapters/counters-overview.adoc 1 file changed, 86 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/37/14937/1 diff --git a/common/chapters/counters-overview.adoc b/common/chapters/counters-overview.adoc index fbdef30..8f9a29a 100644 --- a/common/chapters/counters-overview.adoc +++ b/common/chapters/counters-overview.adoc @@ -3,7 +3,7 @@ The following gives an overview of all the types of counters available: -=== Osmo Counters +=== Osmo Counters (deprecated) Osmo counters are the oldest type of counters added to Osmocom projects. They are not grouped. @@ -26,12 +26,11 @@ rate_ctr.per_{sec,min,hour,day,abs}...[counter_name] -It is possible to get all counters from a group by omitting the counter name +It is possible to get all counters in a group by omitting the counter name === Stat Item -Stat items are a grouped replacement for osmo counters, but not many stat -items are available yet. +Stat items are a grouped replacement for osmo counters. * Printed as part of VTY show stats * Replacement for osmo counters @@ -39,12 +38,91 @@ * Grouped and indexed like rate counters * Items have a unit * Keeps a list of the last values measured, so could return an average, min, - max, std. deviation + max, std. deviation. So far this is not implemented in any of the reporting + options. + +=== Statistic Levels + +There are three levels on which a statistic can be aggregated in Osmocom +projects: globally, per-peer and per-subscriber. + +==== Global + +These are global statistics. + +==== Peer + +These statistics relate to a peer the program connects to such as the NSVC in +an SGSN. + +This level also includes reporting global statistics. + +==== Subscriber + +These statistics are related to an individual mobile subscriber. An example +would be bytes transferred in an SGSN PDP context. + +This level also includes global and peer-based statistics. === Stats Reporter -Statsd stats reporter can send osmo counter, rate counter and stats item values to statsd +The stats reporter periodically collects osmo counter, rate counter and +stat item values and sends them to a backend. Currently implemented are +outputting to the configured log targets and a statsd connector. -See the stats reporter command of the VTY reference for details on how to -setup the connection to statsd. +==== Configuring a stats reporter +Periodically printing the statistics to the log can be done in the following +way: + +.Log statistics +==== + +---- +OsmoBSC> enable +OsmoBSC# configure terminal +OsmoBSC(config)# stats interval 60 <1> +OsmoBSC(config)# stats reporter log <2> +OsmoBSC(config-stats)# level global <3> +OsmoBSC(config-stats)# enable <4> +---- +==== + +<1> The interval determines how often the statistics are reported. +<2> Write the statistic information to any configured log target. +<3> Report only `global` statistics (can be `global`, `peer`, or + `subscriber`). +<4> Enable the reporter, `disable` will disable it again. + +The counter values can also be sent to any aggregation/visualization tool that +understands the statsd format, for example a statsd server with graphite or +prometheus using the statsd_exporter together with grafana. + +The statsd format is specified in https://github.com/b/statsd_spec + +.Report statistics to statsd +==== + +---- +OsmoBSC> enable +OsmoBSC# configure terminal +OsmoBSC(config)# stats interval 10 +OsmoBSC(config)# stats reporter statsd <1> +OsmoBSC(config-stats)# prefix BSC1 <2> +OsmoBSC(config-stats)# level subscriber <3> +OsmoBSC(config-stats)# remote-ip 1.2.3.4 <4> +OsmoBSC(config-stats)# remote-port 8125 <5> +OsmoBSC(config-stats)# enable +---- +==== + +<1> Configure the statsd reporter. +<2> Prefix the reported statistics. This is useful to distinguish statistics + from multiple instances of the same service. +<3> Report only `global` statistics or include `peer` or `subscriber` + statistics as well. +<4> IP address of the statsd server. +<5> UDP port of the statsd server. Statsd by default listens to port 8125. + +Setting up a statsd server and configuring the visualization is beyond the +scope of this document. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia338409e6cb1b1478429e3a99158b9d8255dbb2c Gerrit-Change-Number: 14937 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 15:31:40 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Thu, 25 Jul 2019 15:31:40 +0000 Subject: Change in ...libosmocore[master]: stats_vty: Add verb to sentence for show asciidoc counters In-Reply-To: References: Message-ID: daniel has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14931 ) Change subject: stats_vty: Add verb to sentence for show asciidoc counters ...................................................................... stats_vty: Add verb to sentence for show asciidoc counters Change-Id: Ib444383d2074ddb89b3fe5bbf198bcbfabd7057f --- M src/vty/stats_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c index 8c2ddc6..296519c 100644 --- a/src/vty/stats_vty.c +++ b/src/vty/stats_vty.c @@ -510,7 +510,7 @@ SHOW_STR "Asciidoc generation\n" "Generate table of all registered counters\n") { vty_out(vty, "// autogenerated by show asciidoc counters%s", VTY_NEWLINE); - vty_out(vty, "These counters and their description based on %s %s (%s).%s%s", + vty_out(vty, "These counters and their description are based on %s %s (%s).%s%s", host.app_info->name, host.app_info->version, host.app_info->name ? host.app_info->name : "", VTY_NEWLINE, VTY_NEWLINE); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib444383d2074ddb89b3fe5bbf198bcbfabd7057f Gerrit-Change-Number: 14931 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 15:35:28 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 15:35:28 +0000 Subject: Change in ...osmo-gsm-manuals[master]: counters-overview: Add a section about the stats reporter In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14937 ) Change subject: counters-overview: Add a section about the stats reporter ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia338409e6cb1b1478429e3a99158b9d8255dbb2c Gerrit-Change-Number: 14937 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Jul 2019 15:35:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 15:38:53 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 15:38:53 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 Change subject: common: trx_if.adoc: Improve documentation ...................................................................... common: trx_if.adoc: Improve documentation Several fixes and improvements to the documentation. This documentation still doesn't contain infrmation about TRXDv1, it will be added in a follow-up commit. Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 --- M common/chapters/trx_if.adoc 1 file changed, 85 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/38/14938/1 diff --git a/common/chapters/trx_if.adoc b/common/chapters/trx_if.adoc index b684b7b..f55c886 100644 --- a/common/chapters/trx_if.adoc +++ b/common/chapters/trx_if.adoc @@ -1,44 +1,53 @@ [[trx_if]] == TRX Manager UDP socket interface -This is the protocol used between `osmo-trx` and `osmo-bts-trx`. +This is the protocol used between `osmo-trx` (the transceiver) and +`osmo-bts-trx` (The BTS or core). -Each TRX Manager UDP socket interface represents a single ARFCN. Each of these -per-ARFCN interfaces is a pair of UDP sockets, one for control and one for data. -Given a base port B (5700), the master clock interface is at port P=B. The -TRX-side control interface for C(N) is on port P=B+2N+1 and the data interface -is on an odd numbered port P=B+2N+2. The corresponding core-side interface for -every socket is at P+100. For any given build, the number of ARFCN interfaces -can be fixed. +Each TRX Manager UDP socket interface represents a single transceiver (ARFCN). +Each of these channels is a pair of UDP sockets, one for control (`TRXC`) and +one for data (`TRXD`). Additionally, there's a separate global socket managing +the Master Clock Interface, shared among all channel. + +Given a base port `B` (5700), and a set of channels `0..N`, the ports related to +a channel `0 <= X <= N` are: +* The Master clock interface is located on port `P=B`. +* The `TRXC` interface for channel `X` is located on port `P=B+2N+1` +* The `TRXD` interface for channel `X` is located on port `P=B+2N+2`. + +The corresponding interface for every socket is at `P+100` on the BTS side. [[trx_if_clock_ind]] === Indications on the Master Clock Interface -The master clock interface is output only (from the radio). +The master clock interface is output only (uplink, from the radio to the BTS). Messages are "indications". -CLOCK gives the current value of the transceiver clock to be used by the core. -This message is sent whenever a trasmission packet arrives that is too late or -too early. The clock value is NOT the current transceiver time. It is a time -setting the the core should use to give better packet arrival times. +CLOCK gives the current value of the transceiver clock to be used by the BTS. +This message is usually sent around once per second (217 GSM frames), but can be +sent at any time. The clock value is NOT the current transceiver time. It is a +time setting that the BTS should use to give better packet arrival times. The +initial clock value is taken randomly, and then increased over time as the +transceiver submits downlink packets to the radio. ---- IND CLOCK ---- [[trx_if_control]] -=== Commands on the Per-ARFCN Control Interface +=== TRXC protocol -The per-ARFCN control interface uses a command-reponse protocol. Commands are -NULL-terminated ASCII strings, one per UDP socket. Each command has a -corresponding response. +The per-ARFCN control interface uses a command-response protocol. Each command +has a corresponding response. Commands are sent in downlink direction (BTS -> +TRX), and responses are sent in uplink direction (TRX -> BTS). Commands and +responses are NULL-terminated ASCII strings. -Every command is of the form: +Every command is structured this way: ---- CMD [params] ---- - The `` is the actual command. Parameters are optional depending on the commands type. + Every response is of the form: ---- RSP [result] @@ -46,7 +55,6 @@ The `` is 0 for success and a non-zero error code for failure. Successful responses may include results, depending on the command type. - ==== Power Control `POWEROFF` shuts off transmitter power and stops the demodulator. @@ -55,11 +63,11 @@ RSP POWEROFF ---- -`POWERON` starts the transmitter and starts the demodulator. Initial power +`POWERON` starts the transmitter and starts the demodulator. Initial power level is very low. This command fails if the transmitter and receiver are not yet tuned. This command fails if the transmit or receive frequency creates a conflict with another ARFCN that is already running. If the transceiver is -already on, it response with success to this command. +already on, it answers successfully to this command. ---- CMD POWERON RSP POWERON @@ -102,7 +110,7 @@ ==== Timeslot Control -`SETSLOT` sets the format of the uplink timeslots in the ARFCN. +`SETSLOT` sets the format of a given uplink timeslot in the ARFCN. The `` indicates the timeslot of interest. The `` indicates the type of channel that occupies the timeslot. A chantype of zero indicates the timeslot is off. @@ -111,11 +119,33 @@ RSP SETSLOT ---- -=== Messages on the per-ARFCN Data Interface +Here's the list of channel combinations and related values (``): + +.List of channel combinations and related values (``) +[options="header"] +|=== +| value | Channel Combination +|0| Channel is transmitted, but unused +|1| TCH/FS +|2| TCH/HS, idle every other slot +|3| TCH/HS +|4| Downlink: FCCH + SCH + CCCH + BCCH, Uplink: RACH +|5| Downlink: FCCH + SCH + CCCH + BCCH + SDCCH/4 + SACCH/4, Uplink: RACH+SDCCH/4 +|6| Downlink: CCCH+BCCH, Uplink: RACH +|7| SDCCH/8 + SACCH/8 +|8| TCH/F + FACCH/F + SACCH/M +|9| TCH/F + SACCH/M +|10| TCH/FD + SACCH/MD +|11| PBCCH+PCCCH+PDTCH+PACCH+PTCCH +|12| PCCCH+PDTCH+PACCH+PTCCH +|13| PDTCH+PACCH+PTCCH +|=== + +=== TRXD protocol Messages on the data interface carry one radio burst per UDP message. -==== Received Data Burst +==== Uplink Data Burst [packetdiag] ---- @@ -123,21 +153,29 @@ colwidth = 32 node_height = 40 - 0: T - 1-4: FN - 5: A - 6-7: C - 8-155: Payload + 0-2: TN + 3: RES + 4-7: VER + 8-39: FN + 40-47: RSSI + 48-55: TOA256 + 56-95: ...Payload... + 96-97: PAD } ---- -* _T_: timeslot index +* _TN_: timeslot number. +* _RES_: Reserved, shall be 0. +* _VER_: TRXD header version, shall be 0. * _FN_: GSM frame number, big endian -* _A_: RSSI in -dBm -* _C_: correlator timing offset in 1/256 symbol steps, 2's-comp, big endian -* _Payload_: 148 bytes soft symbol estimates, 0 -> definite "0", 255 -> definite "1" +* _RSSI_: RSSI in -dBm +* _TOA236_: correlator timing offset in 1/256 symbol steps, 2's-comp, big endian +* _Payload_: 148 bytes soft symbol estimates, 0 -> definite "0", 255 -> definite + "1". If packet contains an EDGE burst, then payload is 444 bytes. +* _PAD_: Optional 2 bit padding at the end, historical reasons (OpenBTS + inheritance). Bits can take any value, but 0 is preferred. -==== Transmit Data Burst +==== Downlink Data Burst [packetdiag] ---- @@ -145,14 +183,18 @@ colwidth = 32 node_height = 40 - 0: T - 1-4: FN - 5: A - 6-153: Payload + 0-3: TN + 4: RES + 5-8: VER + 9-39: FN + 40-47: RSSI + 48-95: ...Payload... } ---- -* _T_: timeslot index -* _FN_ GSM frame number, big endian -* _A_: transmit level wrt ARFCN max, -dB (attenuation) -* _Payload_: 148 bytes output symbol values, 0 & 1 +* _TN_: timeslot number. +* _RES_: Reserved, shall be 0. +* _VER_: TRXD header version, shall be 0. +* _FN_: GSM frame number, big endian. +* _RSSI_: RSSI in -dBm. +* _Payload_: 148 bytes output symbol values, 0 & 1. 444 bytes in case of EDGE burst. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 16:08:51 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 16:08:51 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 to look at the new patch set (#2). Change subject: common: trx_if.adoc: Improve documentation ...................................................................... common: trx_if.adoc: Improve documentation Several fixes and improvements to the documentation. This documentation still doesn't contain infrmation about TRXDv1, it will be added in a follow-up commit. Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 --- M common/chapters/trx_if.adoc 1 file changed, 89 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/38/14938/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 16:30:27 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 25 Jul 2019 16:30:27 +0000 Subject: Change in ...osmo-hlr[master]: src/db.c: integrate SQLite3 with talloc allocator Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14939 Change subject: src/db.c: integrate SQLite3 with talloc allocator ...................................................................... src/db.c: integrate SQLite3 with talloc allocator This change introduces an optional feature that allows to make SQLite3 use talloc for all internal allocations. This would facilitate finding memleaks. OsmoHLR needs to be configured with '--enable-sqlite-talloc'. full talloc report on 'OsmoHLR' (total 292168 bytes in 449 blocks) struct osmo_gsup_server contains 162 bytes in 3 blocks (ref 0) ... struct db_context contains 288407 bytes in 420 blocks (ref 0) hlr.db contains 7 bytes in 1 blocks (ref 0) SQLite3 contains 288192 bytes in 418 blocks (ref 0) db.c:95 contains 48 bytes in 1 blocks (ref 0) db.c:95 contains 2 bytes in 1 blocks (ref 0) ... Unfortunately, old SQLite3 versions (such as 3.8.2) somehow become unstable and fail to initialize the database with talloc. There is a huge difference in heap usage footprint compared to malloc. At the same time, the recent versions (at least 3.24.0), work just fine. Change-Id: Icfe67ed0f063b63e6794f9516da3003d01cf20a7 --- M configure.ac M src/db.c 2 files changed, 85 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/39/14939/1 diff --git a/configure.ac b/configure.ac index 6694f80..c59f40f 100644 --- a/configure.ac +++ b/configure.ac @@ -59,6 +59,20 @@ CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined" fi +AC_ARG_ENABLE([sqlite_talloc], + AC_HELP_STRING([--enable-sqlite-talloc], + [Configure SQLite3 to use talloc memory allocator [default=no]]), + [sqlite_talloc="$enableval"],[sqlite_talloc="no"]) +if test "x$sqlite_talloc" = "xyes" ; then + # Older versions of SQLite3 (at least 3.8.2) become unstable with talloc. + # Feel free to relax to 3.24.0 > VER > 3.8.2 if it works for you. + # FIXME: PKG_CHECK_MODULES() may return cached result here! + PKG_CHECK_MODULES(SQLITE3, sqlite3 >= 3.24.0) + AC_DEFINE([SQLITE_USE_TALLOC], 1, [Use talloc for SQLite3]) +fi +AC_MSG_CHECKING([whether to use talloc for SQLite3]) +AC_MSG_RESULT([$sqlite_talloc]) + AC_ARG_ENABLE(werror, [AS_HELP_STRING( [--enable-werror], diff --git a/src/db.c b/src/db.c index 7de61a2..f0bac2f 100644 --- a/src/db.c +++ b/src/db.c @@ -18,6 +18,7 @@ */ #include +#include #include #include @@ -83,6 +84,63 @@ [DB_STMT_EXISTS_BY_MSISDN] = "SELECT 1 FROM subscriber WHERE msisdn = $msisdn", }; +/* Optional feature to make SQLite using talloc */ +#ifdef SQLITE_USE_TALLOC + +/* Dedicated talloc context for SQLite */ +static void *db_sqlite_ctx = NULL; + +static void *tall_xMalloc(int size) +{ + return talloc_size(db_sqlite_ctx, size); +} + +static void tall_xFree(void *ptr) +{ + talloc_free(ptr); +} + +static void *tall_xRealloc(void *ptr, int size) +{ + return talloc_realloc_fn(db_sqlite_ctx, ptr, size); +} + +static int tall_xSize(void *ptr) +{ + return talloc_total_size(ptr); +} + +/* DUMMY: talloc doesn't round up the allocation size */ +static int tall_xRoundup(int size) { return size; } + +/* DUMMY: nothing to initialize */ +static int tall_xInit(void *data) { return 0; } + +/* DUMMY: nothing to deinitialize */ +static void tall_xShutdown(void *data) { } + +/* Interface between SQLite and talloc memory allocator */ +static const struct sqlite3_mem_methods tall_sqlite_if = { + /* Memory allocation function */ + .xMalloc = &tall_xMalloc, + /* Free a prior allocation */ + .xFree = &tall_xFree, + /* Resize an allocation */ + .xRealloc = &tall_xRealloc, + /* Return the size of an allocation */ + .xSize = &tall_xSize, + /* Round up request size to allocation size */ + .xRoundup = &tall_xRoundup, + /* Initialize the memory allocator */ + .xInit = &tall_xInit, + /* Deinitialize the memory allocator */ + .xShutdown = &tall_xShutdown, + /* Argument to xInit() and xShutdown() */ + .pAppData = NULL, +}; + +#endif /* SQLITE_USE_TALLOC */ + static void sql3_error_log_cb(void *arg, int err_code, const char *msg) { LOGP(DDB, LOGL_ERROR, "(%d) %s\n", err_code, msg); @@ -365,6 +423,19 @@ LOGP(DDB, LOGL_INFO, "Compiled against SQLite3 lib version %s\n", SQLITE_VERSION); LOGP(DDB, LOGL_INFO, "Running with SQLite3 lib version %s\n", sqlite3_libversion()); +#ifdef SQLITE_USE_TALLOC + db_sqlite_ctx = talloc_named_const(dbc, 0, "SQLite3"); + + /* Configure SQLite3 to use talloc memory allocator */ + rc = sqlite3_config(SQLITE_CONFIG_MALLOC, &tall_sqlite_if); + if (rc == SQLITE_OK) { + LOGP(DDB, LOGL_NOTICE, "SQLite3 is configured to use talloc\n"); + } else { + LOGP(DDB, LOGL_NOTICE, "Failed to configure SQLite3 " + "to use talloc, using default memory allocator\n"); + } +#endif + dbc->fname = talloc_strdup(dbc, fname); for (i = 0; i < 0xfffff; i++) { -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icfe67ed0f063b63e6794f9516da3003d01cf20a7 Gerrit-Change-Number: 14939 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 16:47:36 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 25 Jul 2019 16:47:36 +0000 Subject: Change in ...osmo-hlr[master]: src/db.c: integrate SQLite3 with talloc allocator In-Reply-To: References: Message-ID: Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/14939 to look at the new patch set (#2). Change subject: src/db.c: integrate SQLite3 with talloc allocator ...................................................................... src/db.c: integrate SQLite3 with talloc allocator This change introduces an optional feature that allows to make SQLite3 use talloc for all internal allocations. This would facilitate finding memleaks. OsmoHLR needs to be configured with '--enable-sqlite-talloc'. full talloc report on 'OsmoHLR' (total 292168 bytes in 449 blocks) struct osmo_gsup_server contains 162 bytes in 3 blocks (ref 0) ... struct db_context contains 288407 bytes in 420 blocks (ref 0) hlr.db contains 7 bytes in 1 blocks (ref 0) SQLite3 contains 288192 bytes in 418 blocks (ref 0) db.c:95 contains 48 bytes in 1 blocks (ref 0) db.c:95 contains 2 bytes in 1 blocks (ref 0) ... Unfortunately, old SQLite3 versions (such as 3.8.2) somehow become unstable and fail to initialize the database with talloc. There is a huge difference in heap usage footprint compared to malloc. At the same time, the recent versions (at least 3.24.0), work just fine. Change-Id: Icfe67ed0f063b63e6794f9516da3003d01cf20a7 --- M configure.ac M src/db.c 2 files changed, 85 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/39/14939/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icfe67ed0f063b63e6794f9516da3003d01cf20a7 Gerrit-Change-Number: 14939 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 17:07:52 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 17:07:52 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT ...................................................................... common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 --- M common/chapters/trx_if.adoc 1 file changed, 139 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/40/14940/1 diff --git a/common/chapters/trx_if.adoc b/common/chapters/trx_if.adoc index 0dda0f0..58d0f49 100644 --- a/common/chapters/trx_if.adoc +++ b/common/chapters/trx_if.adoc @@ -141,20 +141,63 @@ |13| PDTCH+PACCH+PTCCH |=== +==== TRXD header version negotiation + +Messages on DATA interface may have different header formats, defined by a +version number, which can be negotiated on the control interface. By default, +the Transceiver will use the legacy header version (0). + +The header format negotiation can be initiated by the BTS using 'SETFORMAT' +command. If the requested version is not supported by the transceiver, status +code of the response message should indicate a preferred (basically, the latest) +version. The format of this message is the following: +---- +CMD SETFORMAT +RSP SETFORMAT +---- + +where: +* `` is the requested version (suggested by the BTS), +* `` is either the applied version if matches ``, or a + preferred version if `` is not supported. + +If the transceiver indicates `` different than ``, the BTS is +supposed to re-initiate the version negotiation using the suggested ``. +For example: + +---- + BTS -> TRX: CMD SETFORMAT 2 + BTS <- TRX: RSP SETFORMAT 1 2 + + BTS -> TRX: CMD SETFORMAT 1 + BTS <- TRX: RSP SETFORMAT 1 1 +---- + +If no suitable `` is found, or the `` is incorrect, the status +code in the response shall be `-1`. + +As soon as `` matches `` in the response, the process of +negotiation is complete. Changing the header version is supposed to be done +before `POWERON`, but can be also done afterwards. + === TRXD protocol Messages on the data interface carry one radio burst per UDP message. ==== Uplink Data Burst -.TRXD Uplink data burst message structure +Uplink data burst message structure differs from version 0 to 1. Basically, +version 1 contains an extended header with regards to version 0, and the final +padding existence is completely dropped. + +.TRXDv0 Uplink data burst message structure [packetdiag] ---- { colwidth = 32 node_height = 40 - 0-3: VER + 0-3: VER(0) 4: RES 5-7: TN 8-39: FN @@ -165,8 +208,27 @@ } ---- +.TRXDv1 Uplink data burst message structure +[packetdiag] +---- +{ + colwidth = 32 + node_height = 40 + + 0-3: VER(1) + 4: RES + 5-7: TN + 8-39: FN + 40-47: RSSI + 48-55: TOA256 + 56-63: MTS + 64-71: C/I + 72-127: ...Payload... +} +---- + VER: 4 bits:: -TRXD header version, shall be 0. +TRXD header version, v0 and v1 are specified so far. TN: 3 bits:: Timeslot number. @@ -184,13 +246,83 @@ TOA256: 8 bits (1 byte):: Timing of Arrival in units of 1/256 of symbol, big endian. +MTS: 8 bits (1 byte):: +Contains the Modulation and Training Sequence information. See <> +for more information on the encoding. + +C/I: 16 bits (2 bytes):: +Contains the Carrier-to-Interference ratio in centiBels, big endian. The C/I +value is computed from the training sequence of each burst, where the "ideal" +training sequence can be compared with the actual training sequence and then +express that in centiBels. + Payload: 148 bytes for GSM, 444 bytes for EDGE:: -Contains the uplink burst. Soft symbol estimates, 0 -> definite "0", 255 -> -definite "1". +Contains the uplink burst. Unlike the downlink bursts, the uplink bursts are +designated using the soft-bits notation, so the receiver can indicate its +assurance from 0 to -127 that a given bit is 1, and from 0 to +127 that a given +bit is 0. The Viterbi algorithm allows to approximate the original sequence of +hard-bits (1 or 0) using these values. Each soft-bit (-127..127) of the burst is +encoded as an unsigned value in range (0..255) respectively using the constant +shift. This way: +* 0 -> definite "0" +* 255 -> definite "1". PAD: 2 bits (optional):: Padding at the end, historical reasons (OpenBTS inheritance). Bits can take any -value, but 0 is preferred. +value, but 0 is preferred. Only expected on TRXDv0 headers. + +[[coding-mts]] +===== Coding of MTS: Modulation and Training Sequence info + +3GPP TS 45.002 version 15.1.0 defines several modulation types, and a few sets +of training sequences for each type. The most common are GMSK and 8-PSK (which +is used in EDGE). + +.MTS field structure +---- ++-----------------+---------------------------------------+ +| 7 6 5 4 3 2 1 0 | bit numbers (value range) | ++-----------------+---------------------------------------+ +| X . . . . . . . | IDLE / nope frame indication (0 or 1) | ++-----------------+---------------------------------------+ +| . X X X X . . . | Modulation, TS set number (see below) | ++-----------------+---------------------------------------+ +| . . . . . X X X | Training Sequence Code (0..7) | ++-----------------+---------------------------------------+ +---- + +IDLE / nope frame indication:: +The bit number 7 (MSB) is set to high when either nothing has been detected, or +during IDLE frames, so noise levels can be delivered, and avoid clock gaps on +the BTS side. Other bits are ignored, and should be set to low (`0`) in this +case. + +Modulation and TS set number:: +GMSK has 4 sets of training sequences (see tables 5.2.3a-d), while 8-PSK (see +tables 5.2.3f-g) and the others have 2 sets. Access and Synchronization bursts +also have several synchronization sequences. + +.Modulation and TS set number +---- ++-----------------+---------------------------------------+ +| 7 6 5 4 3 2 1 0 | bit numbers (value range) | ++-----------------+---------------------------------------+ +| . 0 0 X X . . . | GMSK, 4 TS sets (0..3) | ++-----------------+---------------------------------------+ +| . 0 1 0 X . . . | 8-PSK, 2 TS sets (0..1) | ++-----------------+---------------------------------------+ +| . 0 1 1 X . . . | AQPSK, 2 TS sets (0..1) | ++-----------------+---------------------------------------+ +| . 1 0 0 X . . . | 16QAM, 2 TS sets (0..1) | ++-----------------+---------------------------------------+ +| . 1 0 1 X . . . | 32QAM, 2 TS sets (0..1) | ++-----------------+---------------------------------------+ +| . 1 1 1 X . . . | RESERVED (0) | ++-----------------+---------------------------------------+ +---- + +Training Sequence Code:: +The Training Sequence Code used to decode the burst. ==== Downlink Data Burst @@ -211,7 +343,7 @@ ---- VER: 4 bits:: -TRXD header version, shall be 0. +TRXD header version, v0 and v1 are specified so far. TN: 3 bits:: Timeslot number. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 Gerrit-Change-Number: 14940 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 17:08:05 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 17:08:05 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 ) Change subject: common: trx_if.adoc: Improve documentation ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Jul 2019 17:08:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 17:13:11 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 17:13:11 +0000 Subject: Change in ...osmo-hlr[master]: src/db.c: integrate SQLite3 with talloc allocator In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14939 ) Change subject: src/db.c: integrate SQLite3 with talloc allocator ...................................................................... Patch Set 2: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/14939/2/src/db.c File src/db.c: https://gerrit.osmocom.org/#/c/14939/2/src/db.c at 88 PS2, Line 88: #ifdef SQLITE_USE_TALLOC I'd rather move all this block into its own file + header, in case somebody wants to quickly reuse it in other apps using talloc + sqlite (so they don't need to go look all along this file). https://gerrit.osmocom.org/#/c/14939/2/src/db.c at 426 PS2, Line 426: #ifdef SQLITE_USE_TALLOC Move this into the file and provide a public function on that file (header). -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icfe67ed0f063b63e6794f9516da3003d01cf20a7 Gerrit-Change-Number: 14939 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Jul 2019 17:13:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 17:16:45 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Thu, 25 Jul 2019 17:16:45 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 ) Change subject: common: trx_if.adoc: Improve documentation ...................................................................... Patch Set 4: Code-Review-1 (6 comments) https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc at 5 PS4, Line 5: The s/The/the/ https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc at 162 PS4, Line 162: 48-55: TOA256 ToA256 actually takes 2 octets. https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc at 163 PS4, Line 163: 56-95: where does this range come from? https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc at 184 PS4, Line 184: TOA256: 8 bits (1 byte):: same here https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc at 208 PS4, Line 208: RSSI It's called PWR. https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc at 226 PS4, Line 226: RSSI: 8 bits (1 byte):: : Received Signal Strength Indication in -dBm, encoded without the negative sign. And AFAIR, it indicates Tx power attenuation wrt. the full scale. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 25 Jul 2019 17:16:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 17:46:24 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 17:46:24 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation In-Reply-To: References: Message-ID: Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 to look at the new patch set (#5). Change subject: common: trx_if.adoc: Improve documentation ...................................................................... common: trx_if.adoc: Improve documentation Several fixes and improvements to the documentation. This documentation still doesn't contain infrmation about TRXDv1, it will be added in a follow-up commit. Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 --- M common/chapters/trx_if.adoc 1 file changed, 118 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/38/14938/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 17:46:24 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Thu, 25 Jul 2019 17:46:24 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 to look at the new patch set (#2). Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT ...................................................................... common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 --- M common/chapters/trx_if.adoc 1 file changed, 139 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/40/14940/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 Gerrit-Change-Number: 14940 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 21:30:25 2019 From: gerrit-no-reply at lists.osmocom.org (Vasil Velichkov) Date: Thu, 25 Jul 2019 21:30:25 +0000 Subject: Change in ...gr-gsm[master]: Add control channels demappers tests Message-ID: Hello Piotr Krysik, fixeria, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/gr-gsm/+/14945 to review the following change. Change subject: Add control channels demappers tests ...................................................................... Add control channels demappers tests 3GPP TS 45.002 version 15.1.0 Release 15 Table 3 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5) Table 4 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5) Figure 8a: TDMA frame mapping for FCCH + SCH + BCCH + CCCH Figure 8b: TDMA frame mapping for FCCH + SCH + BCCH + CCCH + SDCCH/4(0...3) + SACCH/4(0...3) Five of the six tests currently fail and are marked with @unittest.expectedFailure. Fixes in subsequent commits. Change-Id: I33b0948832a0c2506bffd389cc134c3236c74d27 --- M include/grgsm/qa_utils/burst_sink.h M include/grgsm/qa_utils/burst_source.h M lib/qa_utils/burst_sink_impl.cc M lib/qa_utils/burst_sink_impl.h M lib/qa_utils/burst_source_impl.cc M lib/qa_utils/burst_source_impl.h M python/CMakeLists.txt A python/qa_gsm_bcch_ccch_demapper.py A python/qa_gsm_bcch_ccch_sdcch4_demapper.py A python/qa_gsm_demapper_data.py A python/qa_gsm_sdcch8_demapper.py 11 files changed, 909 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/45/14945/1 diff --git a/include/grgsm/qa_utils/burst_sink.h b/include/grgsm/qa_utils/burst_sink.h index 774075f..ed811ed 100644 --- a/include/grgsm/qa_utils/burst_sink.h +++ b/include/grgsm/qa_utils/burst_sink.h @@ -54,6 +54,8 @@ virtual std::vector get_timeslots() = 0; virtual std::vector get_burst_data() = 0; virtual pmt::pmt_t get_bursts() = 0; + virtual std::vector get_sub_types() = 0; + virtual std::vector get_sub_slots() = 0; }; } // namespace gsm } // namespace gr diff --git a/include/grgsm/qa_utils/burst_source.h b/include/grgsm/qa_utils/burst_source.h index e74a8aa..2f249ad 100644 --- a/include/grgsm/qa_utils/burst_source.h +++ b/include/grgsm/qa_utils/burst_source.h @@ -54,6 +54,7 @@ virtual void set_framenumbers(const std::vector &framenumbers) = 0; virtual void set_timeslots(const std::vector ×lots) = 0; virtual void set_burst_data(const std::vector &burst_data) = 0; + virtual void set_arfcn(uint16_t arfcn) = 0; }; } // namespace gsm diff --git a/lib/qa_utils/burst_sink_impl.cc b/lib/qa_utils/burst_sink_impl.cc index bdc2192..5151bf6 100644 --- a/lib/qa_utils/burst_sink_impl.cc +++ b/lib/qa_utils/burst_sink_impl.cc @@ -90,6 +90,8 @@ d_framenumbers.push_back(frame_nr); d_timeslots.push_back(header->timeslot); d_burst_data.push_back(burst_str.str()); + d_sub_types.push_back(header->sub_type); + d_sub_slots.push_back(header->sub_slot); } std::vector burst_sink_impl::get_framenumbers() @@ -110,6 +112,14 @@ { return d_bursts; } + std::vector burst_sink_impl::get_sub_types() + { + return d_sub_types; + } + std::vector burst_sink_impl::get_sub_slots() + { + return d_sub_slots; + } } /* namespace gsm */ } /* namespace gr */ diff --git a/lib/qa_utils/burst_sink_impl.h b/lib/qa_utils/burst_sink_impl.h index e87422d..15e3bcf 100644 --- a/lib/qa_utils/burst_sink_impl.h +++ b/lib/qa_utils/burst_sink_impl.h @@ -36,6 +36,8 @@ std::vector d_timeslots; std::vector d_burst_data; pmt::pmt_t d_bursts; + std::vector d_sub_types; + std::vector d_sub_slots; public: burst_sink_impl(); ~burst_sink_impl(); @@ -44,6 +46,8 @@ virtual std::vector get_timeslots(); virtual std::vector get_burst_data(); virtual pmt::pmt_t get_bursts(); + virtual std::vector get_sub_types(); + virtual std::vector get_sub_slots(); }; } // namespace gsm diff --git a/lib/qa_utils/burst_source_impl.cc b/lib/qa_utils/burst_source_impl.cc index f415eaf..276ed0e 100644 --- a/lib/qa_utils/burst_source_impl.cc +++ b/lib/qa_utils/burst_source_impl.cc @@ -52,7 +52,8 @@ : gr::block("burst_source", gr::io_signature::make(0, 0, 0), gr::io_signature::make(0, 0, 0)), - d_finished(false) + d_finished(false), + d_arfcn(0) { message_port_register_out(pmt::mp("out")); set_framenumbers(framenumbers); @@ -85,6 +86,11 @@ d_burst_data = burst_data; } + void burst_source_impl::set_arfcn(uint16_t arfcn) + { + d_arfcn = arfcn; + } + bool burst_source_impl::start() { d_finished = false; @@ -122,7 +128,7 @@ tap_header->timeslot = d_timeslots[i]; tap_header->frame_number = htobe32(d_framenumbers[i]); tap_header->sub_type = GSMTAP_BURST_NORMAL; - tap_header->arfcn = 0; + tap_header->arfcn = d_arfcn; tap_header->signal_dbm = 0; tap_header->snr_db = 0; diff --git a/lib/qa_utils/burst_source_impl.h b/lib/qa_utils/burst_source_impl.h index cc7d9b4..bbcfd98 100644 --- a/lib/qa_utils/burst_source_impl.h +++ b/lib/qa_utils/burst_source_impl.h @@ -40,6 +40,7 @@ std::vector d_timeslots; std::vector d_burst_data; bool d_finished; + uint16_t d_arfcn; void run(); public: burst_source_impl(const std::vector &framenumbers, @@ -49,6 +50,7 @@ virtual void set_framenumbers(const std::vector &framenumbers); virtual void set_timeslots(const std::vector ×lots); virtual void set_burst_data(const std::vector &burst_data); + virtual void set_arfcn(uint16_t arfcn); bool start(); bool stop(); bool finished(); diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt index 21f2507..97cb0a3 100644 --- a/python/CMakeLists.txt +++ b/python/CMakeLists.txt @@ -45,7 +45,7 @@ include(GrTest) set(GR_TEST_TARGET_DEPS gr-gsm) -set(GR_TEST_PYTHON_DIRS ${CMAKE_BINARY_DIR}/swig:${CMAKE_BINARY_DIR}/python/misc_utils) +set(GR_TEST_PYTHON_DIRS ${CMAKE_BINARY_DIR}/swig:${CMAKE_BINARY_DIR}/python/misc_utils:${CMAKE_BINARY_DIR}/python/receiver:${CMAKE_BINARY_DIR}/python/demapping:${CMAKE_BINARY_DIR}/python/transmitter) GR_ADD_TEST(qa_arfcn ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/qa_arfcn.py) GR_ADD_TEST(qa_decryption ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/qa_decryption.py) GR_ADD_TEST(qa_burst_printer ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/qa_burst_printer.py) @@ -61,6 +61,9 @@ GR_ADD_TEST(qa_tch_h_decoder ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/qa_tch_h_decoder.py) GR_ADD_TEST(qa_tch_f_chans_demapper ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/qa_tch_f_chans_demapper.py) GR_ADD_TEST(qa_tch_h_chans_demapper ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/qa_tch_h_chans_demapper.py) +GR_ADD_TEST(qa_gsm_bcch_ccch_demapper ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/qa_gsm_bcch_ccch_demapper.py) +GR_ADD_TEST(qa_gsm_bcch_ccch_sdcch4_demapper ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/qa_gsm_bcch_ccch_sdcch4_demapper.py) +GR_ADD_TEST(qa_gsm_sdcch8_demapper ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/qa_gsm_sdcch8_demapper.py) #GR_ADD_TEST(qa_msg_to_tag ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/qa_msg_to_tag.py) #GR_ADD_TEST(qa_controlled_fractional_resampler_cc ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/qa_controlled_fractional_resampler_cc.py) #GR_ADD_TEST(qa_uplink_downlink_splitter ${PYTHON_EXECUTABLE} ${CMAKE_CURRENT_SOURCE_DIR}/qa_uplink_downlink_splitter.py) diff --git a/python/qa_gsm_bcch_ccch_demapper.py b/python/qa_gsm_bcch_ccch_demapper.py new file mode 100644 index 0000000..358b046 --- /dev/null +++ b/python/qa_gsm_bcch_ccch_demapper.py @@ -0,0 +1,235 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*- +# @file +# @author (C) 2019 by Vasil Velichkov +# @section LICENSE +# +# Gr-gsm is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3, or (at your option) +# any later version. +# +# Gr-gsm is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with gr-gsm; see the file COPYING. If not, write to +# the Free Software Foundation, Inc., 51 Franklin Street, +# Boston, MA 02110-1301, USA. +# +# + +import unittest +import numpy as np +from gnuradio import gr, gr_unittest, blocks +import grgsm +import pmt +import qa_gsm_demapper_data as test_data + +class qa_gsm_bcch_ccch_demapper (gr_unittest.TestCase): + + def setUp (self): + self.tb = gr.top_block () + self.maxDiff = None + + def tearDown (self): + self.tb = None + + def test_downlink (self): + """ + BCCH_CCCH demapper downlink test + """ + src = grgsm.burst_source(test_data.frames, test_data.timeslots, test_data.bursts) + src.set_arfcn(0); # downlink + demapper = grgsm.gsm_bcch_ccch_demapper(timeslot_nr=0) + dst = grgsm.burst_sink() + + self.tb.msg_connect(src, "out", demapper, "bursts") + self.tb.msg_connect(demapper, "bursts", dst, "in") + self.tb.run () + + b = test_data.bursts + self.assertEqual([ + b[ 2], b[ 3], b[ 4], b[ 5], #BCCH + b[ 6], b[ 7], b[ 8], b[ 9], #CCCH skip 10-11 + b[ 12], b[ 13], b[ 14], b[ 15], + b[ 16], b[ 17], b[ 18], b[ 19], #skip 20-21 + b[ 22], b[ 23], b[ 24], b[ 25], + b[ 26], b[ 27], b[ 28], b[ 29], #skip 30-31 + b[ 32], b[ 33], b[ 34], b[ 35], + b[ 36], b[ 37], b[ 38], b[ 39], #skip 40-41 + b[ 42], b[ 43], b[ 44], b[ 45], + b[ 46], b[ 47], b[ 48], b[ 49], #skip 50-52 + b[ 53], b[ 54], b[ 55], b[ 56], #BCCH + b[ 57], b[ 58], b[ 59], b[ 60], #CCCH skip 61-62 + b[ 63], b[ 64], b[ 65], b[ 66], + b[ 67], b[ 68], b[ 69], b[ 70], #skip 71-72 + b[ 73], b[ 74], b[ 75], b[ 76], + b[ 77], b[ 78], b[ 79], b[ 80], #skip 81-82 + b[ 83], b[ 84], b[ 85], b[ 86], + b[ 87], b[ 88], b[ 89], b[ 90], #skip 91-92 + b[ 93], b[ 94], b[ 95], b[ 96], + b[ 97], b[ 98], b[ 99], b[100], #skip 101-103 + b[104], b[105], b[106], b[107] #BCCH + ], list(dst.get_burst_data())) + + self.assertEqual([ + 1, 1, 1, 1, #BCCH + 2, 2, 2, 2, #CCCH + 2, 2, 2, 2, + 2, 2, 2, 2, + 2, 2, 2, 2, + 2, 2, 2, 2, + 2, 2, 2, 2, + 2, 2, 2, 2, + 2, 2, 2, 2, + 2, 2, 2, 2, + 1, 1, 1, 1, #BCCH + 2, 2, 2, 2, #CCCH + 2, 2, 2, 2, + 2, 2, 2, 2, + 2, 2, 2, 2, + 2, 2, 2, 2, + 2, 2, 2, 2, + 2, 2, 2, 2, + 2, 2, 2, 2, + 2, 2, 2, 2, + 1, 1, 1, 1, #BCCH + ], list(dst.get_sub_types())) + + self.assertEqual([ + 0, 0, 0, 0, #BCCH + 0, 0, 0, 0, #CCCH 0 + 1, 1, 1, 1, + 2, 2, 2, 2, + 3, 3, 3, 3, + 4, 4, 4, 4, + 5, 5, 5, 5, + 6, 6, 6, 6, + 7, 7, 7, 7, + 8, 8, 8, 8, #CCCH 8 + 0, 0, 0, 0, #BCCH + 0, 0, 0, 0, #CCCH 0 + 1, 1, 1, 1, + 2, 2, 2, 2, + 3, 3, 3, 3, + 4, 4, 4, 4, + 5, 5, 5, 5, + 6, 6, 6, 6, + 7, 7, 7, 7, + 8, 8, 8, 8, #CCCH 8 + 0, 0, 0, 0, #BCCH + ], list(dst.get_sub_slots())) + + @unittest.expectedFailure + def test_uplink (self): + """ + BCCH_CCCH demapper uplink test + """ + src = grgsm.burst_source(test_data.frames, test_data.timeslots, test_data.bursts) + src.set_arfcn(0x2240); #uplink flag is 40 + demapper = grgsm.gsm_bcch_ccch_demapper(timeslot_nr=0) + dst = grgsm.burst_sink() + + self.tb.msg_connect(src, "out", demapper, "bursts") + self.tb.msg_connect(demapper, "bursts", dst, "in") + self.tb.run () + + b = test_data.bursts + self.assertEqual([ + b[ 0], b[ 1], b[ 2], b[ 3], + b[ 4], b[ 5], b[ 6], b[ 7], + b[ 8], b[ 9], b[ 10], b[ 11], + b[ 12], b[ 13], b[ 14], b[ 15], + b[ 16], b[ 17], b[ 18], b[ 19], + b[ 20], b[ 21], b[ 22], b[ 23], + b[ 24], b[ 25], b[ 26], b[ 27], + b[ 28], b[ 29], b[ 30], b[ 31], + b[ 32], b[ 33], b[ 34], b[ 35], + b[ 36], b[ 37], b[ 38], b[ 39], + b[ 40], b[ 41], b[ 42], b[ 43], + b[ 44], b[ 45], b[ 46], b[ 47], + b[ 48], b[ 49], b[ 50], + b[ 51], b[ 52], b[ 53], b[ 54], + b[ 55], b[ 56], b[ 57], b[ 58], + b[ 59], b[ 60], b[ 61], b[ 62], + b[ 63], b[ 64], b[ 65], b[ 66], + b[ 67], b[ 68], b[ 69], b[ 70], + b[ 71], b[ 72], b[ 73], b[ 74], + b[ 75], b[ 76], b[ 77], b[ 78], + b[ 79], b[ 80], b[ 81], b[ 82], + b[ 83], b[ 84], b[ 85], b[ 86], + b[ 87], b[ 88], b[ 89], b[ 90], + b[ 91], b[ 92], b[ 93], b[ 94], + b[ 95], b[ 96], b[ 97], b[ 98], + b[ 99], b[100], b[101], + b[102], b[103], b[104], b[105], + b[106], b[107], + ], list(dst.get_burst_data())) + + self.assertEqual([ + 3, 3, 3, 3, #RACH + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, # 51 + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, 3, + 3, 3, 3, # 102 + 3, 3, 3, 3, + 3, 3, + ], list(dst.get_sub_types())) + + self.assertEqual([ + 0, 0, 0, 0, #RACH + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, # 51 + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, 0, + 0, 0, 0, # 102 + 0, 0, 0, 0, + 0, 0, + ], list(dst.get_sub_slots())) + +if __name__ == '__main__': + gr_unittest.run(qa_gsm_bcch_ccch_demapper, "qa_gsm_bcch_ccch_demapper.xml") diff --git a/python/qa_gsm_bcch_ccch_sdcch4_demapper.py b/python/qa_gsm_bcch_ccch_sdcch4_demapper.py new file mode 100644 index 0000000..f51c7bf --- /dev/null +++ b/python/qa_gsm_bcch_ccch_sdcch4_demapper.py @@ -0,0 +1,242 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*- +# @file +# @author (C) 2019 by Vasil Velichkov +# @section LICENSE +# +# Gr-gsm is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3, or (at your option) +# any later version. +# +# Gr-gsm is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with gr-gsm; see the file COPYING. If not, write to +# the Free Software Foundation, Inc., 51 Franklin Street, +# Boston, MA 02110-1301, USA. +# +# + +import unittest +import numpy as np +from gnuradio import gr, gr_unittest, blocks +import grgsm +import pmt +import qa_gsm_demapper_data as test_data + +class qa_bcch_ccch_sdcch4_demapper (gr_unittest.TestCase): + + def setUp (self): + self.tb = gr.top_block () + self.maxDiff = None + + def tearDown (self): + self.tb = None + + @unittest.expectedFailure + def test_downlink (self): + """ + BCCH_CCCH_SDCCH4 demapper downlink test + """ + src = grgsm.burst_source(test_data.frames, test_data.timeslots, test_data.bursts) + src.set_arfcn(0); # downlink + demapper = grgsm.gsm_bcch_ccch_sdcch4_demapper(timeslot_nr=0) + dst = grgsm.burst_sink() + + self.tb.msg_connect(src, "out", demapper, "bursts") + self.tb.msg_connect(demapper, "bursts", dst, "in") + self.tb.run () + + b = test_data.bursts + self.assertEqual([ + b[ 2], b[ 3], b[ 4], b[ 5], #BCCH + b[ 6], b[ 7], b[ 8], b[ 9], #CCCH skip 2 + b[ 12], b[ 13], b[ 14], b[ 15], #CCCH + b[ 16], b[ 17], b[ 18], b[ 19], #CCCH skip 2 + b[ 22], b[ 23], b[ 24], b[ 25], #SDCCH 0 + b[ 26], b[ 27], b[ 28], b[ 29], #SDCCH 1 skip 2 + b[ 32], b[ 33], b[ 34], b[ 35], #SDCCH 2 + b[ 36], b[ 37], b[ 38], b[ 39], #SDCCH 3 skip 2 + b[ 42], b[ 43], b[ 44], b[ 45], #SACCH 0 + b[ 46], b[ 47], b[ 48], b[ 49], #SACCH 1 skip 3 + b[ 53], b[ 54], b[ 55], b[ 56], #BCCH + b[ 57], b[ 58], b[ 59], b[ 60], #CCCH skip 2 + b[ 63], b[ 64], b[ 65], b[ 66], #CCCH + b[ 67], b[ 68], b[ 69], b[ 70], #CCCH skip 2 + b[ 73], b[ 74], b[ 75], b[ 76], #SDCCH 0 + b[ 77], b[ 78], b[ 79], b[ 80], #SDCCH 1 skip 2 + b[ 83], b[ 84], b[ 85], b[ 86], #SDCCH 2 + b[ 87], b[ 88], b[ 89], b[ 90], #SDCCH 3 skip 2 + b[ 93], b[ 94], b[ 95], b[ 96], #SACCH 1 + b[ 97], b[ 98], b[ 99], b[100], #SACCH 2 skip 3 + b[104], b[105], b[106], b[107] #BCCH + ], list(dst.get_burst_data())) + + self.assertEqual([ + 1, 1, 1, 1, #BCCH + 2, 2, 2, 2, #CCCH + 2, 2, 2, 2, #CCCH + 2, 2, 2, 2, #CCCH + 7, 7, 7, 7, #SDCCH 0 + 7, 7, 7, 7, #SDCCH 1 + 7, 7, 7, 7, #SDCCH 2 + 7, 7, 7, 7, #SDCCH 3 + 135, 135, 135, 135, #SACCH 0 + 135, 135, 135, 135, #SACCH 1 + 1, 1, 1, 1, #BCCH + 2, 2, 2, 2, #CCCH + 2, 2, 2, 2, #CCCH + 2, 2, 2, 2, #CCCH + 7, 7, 7, 7, #SDCCH 0 + 7, 7, 7, 7, #SDCCH 1 + 7, 7, 7, 7, #SDCCH 2 + 7, 7, 7, 7, #SDCCH 3 + 135, 135, 135, 135, #SACCH 2 + 135, 135, 135, 135, #SACCH 3 + 1, 1, 1, 1, #BCCH + ], list(dst.get_sub_types())) + + self.assertEqual([ + 0, 0, 0, 0, #BCCH + 0, 0, 0, 0, #CCCH + 1, 1, 1, 1, #CCCH + 2, 2, 2, 2, #CCCH + 0, 0, 0, 0, #SDCCH 0 + 1, 1, 1, 1, #SDCCH 1 + 2, 2, 2, 2, #SDCCH 2 + 3, 3, 3, 3, #SDCCH 3 + 0, 0, 0, 0, #SACCH 0 + 1, 1, 1, 1, #SACCH 1 + 0, 0, 0, 0, #BCCH + 0, 0, 0, 0, #CCCH + 1, 1, 1, 1, #CCCH + 2, 2, 2, 2, #CCCH + 0, 0, 0, 0, #SDCCH 0 + 1, 1, 1, 1, #SDCCH 1 + 2, 2, 2, 2, #SDCCH 2 + 3, 3, 3, 3, #SDCCH 3 + 2, 2, 2, 2, #SACCH 2 + 3, 3, 3, 3, #SACCH 3 + 0, 0, 0, 0, #BCCH + ], list(dst.get_sub_slots())) + + @unittest.expectedFailure + def test_uplink (self): + """ + BCCH_CCCH_SDCCH4 demapper uplink test + """ + src = grgsm.burst_source(test_data.frames, test_data.timeslots, test_data.bursts) + src.set_arfcn(0x2240); #uplink flag is 40 + demapper = grgsm.gsm_bcch_ccch_sdcch4_demapper(timeslot_nr=0) + dst = grgsm.burst_sink() + + self.tb.msg_connect(src, "out", demapper, "bursts") + self.tb.msg_connect(demapper, "bursts", dst, "in") + self.tb.run () + + b = test_data.bursts + self.assertEqual([ + b[ 0], b[ 1], b[ 2], b[ 3], #SDCCH 3 + b[ 4], b[ 5], #RACCH + b[ 6], b[ 7], b[ 8], b[ 9], #SACCH 2 + b[ 10], b[ 11], b[ 12], b[ 13], #SACCH 3 + b[ 14], b[ 15], b[ 16], b[ 17], #RACCH + b[ 18], b[ 19], b[ 20], b[ 21], #RACCH + b[ 22], b[ 23], b[ 24], b[ 25], #RACCH + b[ 26], b[ 27], b[ 28], b[ 29], #RACCH + b[ 30], b[ 31], b[ 32], b[ 33], #RACCH + b[ 34], b[ 35], b[ 36], #RACCH + b[ 37], b[ 38], b[ 39], b[ 40], #SDCCH 0 + b[ 41], b[ 42], b[ 43], b[ 44], #SDCCH 1 + b[ 45], b[ 46], #RACCH + b[ 47], b[ 48], b[ 49], b[ 50], #SDCCH 2 + b[ 51], b[ 52], b[ 53], b[ 54], #SDCCH 3 + b[ 55], b[ 56], #RACCH + b[ 57], b[ 58], b[ 59], b[ 60], #SACCH 0 + b[ 61], b[ 62], b[ 63], b[ 64], #SACCH 1 + b[ 65], b[ 66], b[ 67], b[ 68], #RACCH + b[ 69], b[ 70], b[ 71], b[ 72], #RACCH + b[ 73], b[ 74], b[ 75], b[ 76], #RACCH + b[ 77], b[ 78], b[ 79], b[ 80], #RACCH + b[ 81], b[ 82], b[ 83], b[ 84], #RACCH + b[ 85], b[ 86], b[ 87], #RACCH + b[ 88], b[ 89], b[ 90], b[ 91], #SDCCH 0 + b[ 92], b[ 93], b[ 94], b[ 95], #SDCCH 1 + b[ 96], b[ 97], #RACCH + b[ 98], b[ 99], b[100], b[101], #SDCCH 2 + b[102], b[103], b[104], b[105], #SDCCH 3 + b[106], b[107], #RACCH + ], list(dst.get_burst_data())) + + self.assertEqual([ + 7, 7, 7, 7, #SDCCH 3 + 3, 3, #RACCH + 135, 135, 135, 135, #SACCH 2 + 135, 135, 135, 135, #SACCH 3 + 3, 3, 3, 3, #RACCH + 3, 3, 3, 3, #RACCH + 3, 3, 3, 3, #RACCH + 3, 3, 3, 3, #RACCH + 3, 3, 3, 3, #RACCH + 3, 3, 3, #RACCH + 7, 7, 7, 7, #SDCCH 0 + 7, 7, 7, 7, #SDCCH 1 + 3, 3, #RACCH + 7, 7, 7, 7, #SDCCH 2 + 7, 7, 7, 7, #SDCCH 3 + 3, 3, #RACCH + 135, 135, 135, 135, #SACCH 0 + 135, 135, 135, 135, #SACCH 1 + 3, 3, 3, 3, #RACCH + 3, 3, 3, 3, #RACCH + 3, 3, 3, 3, #RACCH + 3, 3, 3, 3, #RACCH + 3, 3, 3, 3, #RACCH + 3, 3, 3, #RACCH + 7, 7, 7, 7, #SDCCH 0 + 7, 7, 7, 7, #SDCCH 1 + 3, 3, #RACCH + 7, 7, 7, 7, #SDCCH 2 + 7, 7, 7, 7, #SDCCH 3 + 3, 3, #RACCH + ], list(dst.get_sub_types())) + + self.assertEqual([ + 3, 3, 3, 3, #SDCCH 3 + 0, 0, #RACCH + 2, 2, 2, 2, #SACCH 2 + 3, 3, 3, 3, #SACCH 3 + 0, 0, 0, 0, #RACCH + 0, 0, 0, 0, #RACCH + 0, 0, 0, 0, #RACCH + 0, 0, 0, 0, #RACCH + 0, 0, 0, 0, #RACCH + 0, 0, 0, #RACCH + 0, 0, 0, 0, #SDCCH 0 + 1, 1, 1, 1, #SDCCH 1 + 0, 0, #RACCH + 2, 2, 2, 2, #SDCCH 2 + 3, 3, 3, 3, #SDCCH 3 + 0, 0, #RACCH + 0, 0, 0, 0, #SACCH 0 + 1, 1, 1, 1, #SACCH 1 + 0, 0, 0, 0, #RACCH + 0, 0, 0, 0, #RACCH + 0, 0, 0, 0, #RACCH + 0, 0, 0, 0, #RACCH + 0, 0, 0, 0, #RACCH + 0, 0, 0, #RACCH + 0, 0, 0, 0, #SDCCH 0 + 1, 1, 1, 1, #SDCCH 1 + 0, 0, #RACCH + 2, 2, 2, 2, #SDCCH 2 + 3, 3, 3, 3, #SDCCH 3 + 0, 0, #RACCH + ], list(dst.get_sub_slots())) + +if __name__ == '__main__': + gr_unittest.run(qa_bcch_ccch_sdcch4_demapper, "qa_bcch_ccch_sdcch4_demapper.xml") diff --git a/python/qa_gsm_demapper_data.py b/python/qa_gsm_demapper_data.py new file mode 100644 index 0000000..e38a4ae --- /dev/null +++ b/python/qa_gsm_demapper_data.py @@ -0,0 +1,162 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*- +# @file +# @author (C) 2019 by Vasil Velichkov +# @section LICENSE +# +# Gr-gsm is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3, or (at your option) +# any later version. +# +# Gr-gsm is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with gr-gsm; see the file COPYING. If not, write to +# the Free Software Foundation, Inc., 51 Franklin Street, +# Boston, MA 02110-1301, USA. +# +# + +bursts = [ + "1000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000", + "0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000", + ] + +frames = [ + 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, + 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, + 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, + 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, + 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, + 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, + 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, + 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, + 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, + 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, + 100, 101, 102, 103, 104, 105, 106, 107, + ] + +timeslots = [ + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, + 0, 0, 0, 0, 0, 0, 0, 0, + ] diff --git a/python/qa_gsm_sdcch8_demapper.py b/python/qa_gsm_sdcch8_demapper.py new file mode 100644 index 0000000..aacb1a8 --- /dev/null +++ b/python/qa_gsm_sdcch8_demapper.py @@ -0,0 +1,239 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*- +# @file +# @author (C) 2019 by Vasil Velichkov +# @section LICENSE +# +# Gr-gsm is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3, or (at your option) +# any later version. +# +# Gr-gsm is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with gr-gsm; see the file COPYING. If not, write to +# the Free Software Foundation, Inc., 51 Franklin Street, +# Boston, MA 02110-1301, USA. +# +# + +import unittest +import numpy as np +from gnuradio import gr, gr_unittest, blocks +import grgsm +import pmt +import qa_gsm_demapper_data as test_data + +class qa_gsm_sdcch8_demapper (gr_unittest.TestCase): + + def setUp (self): + self.tb = gr.top_block () + self.maxDiff = None + + def tearDown (self): + self.tb = None + + @unittest.expectedFailure + def test_downlink (self): + """ + SDCCH8 demapper downlink test + """ + src = grgsm.burst_source(test_data.frames, test_data.timeslots, test_data.bursts) + src.set_arfcn(0); # downlink + demapper = grgsm.gsm_sdcch8_demapper(timeslot_nr=0) + dst = grgsm.burst_sink() + + self.tb.msg_connect(src, "out", demapper, "bursts") + self.tb.msg_connect(demapper, "bursts", dst, "in") + self.tb.run () + + b = test_data.bursts + self.assertEqual([ + b[ 0], b[ 1], b[ 2], b[ 3], #SDCCH 0 + b[ 4], b[ 5], b[ 6], b[ 7], #SDCCH 1 + b[ 8], b[ 9], b[ 10], b[ 11], #SDCCH 2 + b[ 12], b[ 13], b[ 14], b[ 15], #SDCCH 3 + b[ 16], b[ 17], b[ 18], b[ 19], #SDCCH 4 + b[ 20], b[ 21], b[ 22], b[ 23], #SDCCH 5 + b[ 24], b[ 25], b[ 26], b[ 27], #SDCCH 6 + b[ 28], b[ 29], b[ 30], b[ 31], #SDCCH 7 + b[ 32], b[ 33], b[ 34], b[ 35], #SACCH 0 + b[ 36], b[ 37], b[ 38], b[ 39], #SACCH 1 + b[ 40], b[ 41], b[ 42], b[ 43], #SACCH 2 + b[ 44], b[ 45], b[ 46], b[ 47], #SACCH 3 #skip 48-50 + b[ 51], b[ 52], b[ 53], b[ 54], #SDCCH 0 + b[ 55], b[ 56], b[ 57], b[ 58], #SDCCH 1 + b[ 59], b[ 60], b[ 61], b[ 62], #SDCCH 2 + b[ 63], b[ 64], b[ 65], b[ 66], #SDCCH 3 + b[ 67], b[ 68], b[ 69], b[ 70], #SDCCH 4 + b[ 71], b[ 72], b[ 73], b[ 74], #SDCCH 5 + b[ 75], b[ 76], b[ 77], b[ 78], #SDCCH 6 + b[ 79], b[ 80], b[ 81], b[ 82], #SDCCH 7 + b[ 83], b[ 84], b[ 85], b[ 86], #SACCH 4 + b[ 87], b[ 88], b[ 89], b[ 90], #SACCH 5 + b[ 91], b[ 92], b[ 93], b[ 94], #SACCH 6 + b[ 95], b[ 96], b[ 97], b[ 98], #SACCH 7 #skip 99-101 + b[102], b[103], b[104], b[105], #SDCCH + ], list(dst.get_burst_data())) + + self.assertEqual([ + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 136, 136, 136, 136, + 136, 136, 136, 136, + 136, 136, 136, 136, + 136, 136, 136, 136, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 136, 136, 136, 136, + 136, 136, 136, 136, + 136, 136, 136, 136, + 136, 136, 136, 136, + 8, 8, 8, 8, + ], list(dst.get_sub_types())) + + self.assertEqual([ + 0, 0, 0, 0, + 1, 1, 1, 1, + 2, 2, 2, 2, + 3, 3, 3, 3, + 4, 4, 4, 4, + 5, 5, 5, 5, + 6, 6, 6, 6, + 7, 7, 7, 7, + 0, 0, 0, 0, #SACCH 0 + 1, 1, 1, 1, #SACCH 1 + 2, 2, 2, 2, #SACCH 2 + 3, 3, 3, 3, #SACCH 3 + 0, 0, 0, 0, + 1, 1, 1, 1, + 2, 2, 2, 2, + 3, 3, 3, 3, + 4, 4, 4, 4, + 5, 5, 5, 5, + 6, 6, 6, 6, + 7, 7, 7, 7, + 4, 4, 4, 4, #SACCH 4 + 5, 5, 5, 5, #SACCH 5 + 6, 6, 6, 6, #SACCH 6 + 7, 7, 7, 7, #SACCH 7 + 0, 0, 0, 0, + ], list(dst.get_sub_slots())) + + @unittest.expectedFailure + def test_uplink (self): + """ + BCCH_CCCH_SDCCH4 demapper uplink test + """ + src = grgsm.burst_source(test_data.frames, test_data.timeslots, test_data.bursts) + src.set_arfcn(0x2240); #uplink flag is 40 + demapper = grgsm.gsm_sdcch8_demapper(timeslot_nr=0) + dst = grgsm.burst_sink() + + self.tb.msg_connect(src, "out", demapper, "bursts") + self.tb.msg_connect(demapper, "bursts", dst, "in") + self.tb.run () + + b = test_data.bursts + self.assertEqual([ + b[ 0], b[ 1], b[ 2], b[ 3], #SACCH 5 + b[ 4], b[ 5], b[ 6], b[ 7], #SACCH 6 + b[ 8], b[ 9], b[ 10], b[ 11], #SACCH 7 #skip 12-14 + b[ 15], b[ 16], b[ 17], b[ 18], #SDCCH 0 + b[ 19], b[ 20], b[ 21], b[ 22], #SDCCH 1 + b[ 23], b[ 24], b[ 25], b[ 26], #SDCCH 2 + b[ 27], b[ 28], b[ 29], b[ 30], #SDCCH 3 + b[ 31], b[ 32], b[ 33], b[ 34], #SDCCH 4 + b[ 35], b[ 36], b[ 37], b[ 38], #SDCCH 5 + b[ 39], b[ 40], b[ 41], b[ 42], #SDCCH 6 + b[ 43], b[ 44], b[ 45], b[ 46], #SDCCH 7 + b[ 47], b[ 48], b[ 49], b[ 50], #SACCH 0 + b[ 51], b[ 52], b[ 53], b[ 54], #SACCH 1 + b[ 55], b[ 56], b[ 57], b[ 58], #SACCH 2 + b[ 59], b[ 60], b[ 61], b[ 62], #SACCH 3 #skip 63-65 + b[ 66], b[ 67], b[ 68], b[ 69], #SDCCH 0 + b[ 70], b[ 71], b[ 72], b[ 73], #SDCCH 1 + b[ 74], b[ 75], b[ 76], b[ 77], #SDCCH 2 + b[ 78], b[ 79], b[ 80], b[ 81], #SDCCH 3 + b[ 82], b[ 83], b[ 84], b[ 85], #SDCCH 4 + b[ 86], b[ 87], b[ 88], b[ 89], #SDCCH 5 + b[ 90], b[ 91], b[ 92], b[ 93], #SDCCH 6 + b[ 94], b[ 95], b[ 96], b[ 97], #SDCCH 7 + b[ 98], b[ 99], b[100], b[101], #SACCH 4 + b[102], b[103], b[104], b[105], #SACCH 5 + ], list(dst.get_burst_data())) + + self.assertEqual([ + 136, 136, 136, 136, + 136, 136, 136, 136, + 136, 136, 136, 136, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 136, 136, 136, 136, + 136, 136, 136, 136, + 136, 136, 136, 136, + 136, 136, 136, 136, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 8, 8, 8, 8, + 136, 136, 136, 136, + 136, 136, 136, 136, + ], list(dst.get_sub_types())) + + self.assertEqual([ + 5, 5, 5, 5, #SACCH 5 + 6, 6, 6, 6, #SACCH 6 + 7, 7, 7, 7, #SACCH 7 + 0, 0, 0, 0, + 1, 1, 1, 1, + 2, 2, 2, 2, + 3, 3, 3, 3, + 4, 4, 4, 4, + 5, 5, 5, 5, + 6, 6, 6, 6, + 7, 7, 7, 7, + 0, 0, 0, 0, #SACCH 0 + 1, 1, 1, 1, #SACCH 1 + 2, 2, 2, 2, #SACCH 2 + 3, 3, 3, 3, #SACCH 3 + 0, 0, 0, 0, + 1, 1, 1, 1, + 2, 2, 2, 2, + 3, 3, 3, 3, + 4, 4, 4, 4, + 5, 5, 5, 5, + 6, 6, 6, 6, + 7, 7, 7, 7, + 4, 4, 4, 4, #SACCH 4 + 5, 5, 5, 5, + ], list(dst.get_sub_slots())) + +if __name__ == '__main__': + gr_unittest.run(qa_gsm_sdcch8_demapper, "qa_gsm_sdcch8_demapper.xml") -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: I33b0948832a0c2506bffd389cc134c3236c74d27 Gerrit-Change-Number: 14945 Gerrit-PatchSet: 1 Gerrit-Owner: Vasil Velichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 21:30:26 2019 From: gerrit-no-reply at lists.osmocom.org (Vasil Velichkov) Date: Thu, 25 Jul 2019 21:30:26 +0000 Subject: Change in ...gr-gsm[master]: Fix sub_slot assignment in the universal_ctrl_chans_demapper block Message-ID: Hello Piotr Krysik, fixeria, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/gr-gsm/+/14946 to review the following change. Change subject: Fix sub_slot assignment in the universal_ctrl_chans_demapper block ...................................................................... Fix sub_slot assignment in the universal_ctrl_chans_demapper block 3GPP TS 45.002 version 15.1.0 Release 15 Table 3 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5) Table 4 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5) Fixes the following tests: qa_gsm_bcch_ccch_sdcch4_demapper.test_downlink qa_gsm_sdcch8_demapper.test_downlink Change-Id: Idc63407694fd1f7be962ab630d4e8c13b4a5d348 --- M lib/demapping/universal_ctrl_chans_demapper_impl.cc M python/qa_gsm_bcch_ccch_sdcch4_demapper.py M python/qa_gsm_sdcch8_demapper.py 3 files changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/46/14946/1 diff --git a/lib/demapping/universal_ctrl_chans_demapper_impl.cc b/lib/demapping/universal_ctrl_chans_demapper_impl.cc index 98bcc9c..a6ab956 100644 --- a/lib/demapping/universal_ctrl_chans_demapper_impl.cc +++ b/lib/demapping/universal_ctrl_chans_demapper_impl.cc @@ -140,7 +140,7 @@ { new_header->sub_type = ch_type; } - new_header->sub_slot = subslots[fn_mod51 + (51 * (frame_nr % 2))]; + new_header->sub_slot = subslots[fn_mod102]; if(fn_mod51>=fn51_start && fn_mod51<=fn51_stop) { diff --git a/python/qa_gsm_bcch_ccch_sdcch4_demapper.py b/python/qa_gsm_bcch_ccch_sdcch4_demapper.py index f51c7bf..a3688c7 100644 --- a/python/qa_gsm_bcch_ccch_sdcch4_demapper.py +++ b/python/qa_gsm_bcch_ccch_sdcch4_demapper.py @@ -37,7 +37,6 @@ def tearDown (self): self.tb = None - @unittest.expectedFailure def test_downlink (self): """ BCCH_CCCH_SDCCH4 demapper downlink test diff --git a/python/qa_gsm_sdcch8_demapper.py b/python/qa_gsm_sdcch8_demapper.py index aacb1a8..b5c5ff5 100644 --- a/python/qa_gsm_sdcch8_demapper.py +++ b/python/qa_gsm_sdcch8_demapper.py @@ -37,7 +37,6 @@ def tearDown (self): self.tb = None - @unittest.expectedFailure def test_downlink (self): """ SDCCH8 demapper downlink test -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14946 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: Idc63407694fd1f7be962ab630d4e8c13b4a5d348 Gerrit-Change-Number: 14946 Gerrit-PatchSet: 1 Gerrit-Owner: Vasil Velichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 21:30:26 2019 From: gerrit-no-reply at lists.osmocom.org (Vasil Velichkov) Date: Thu, 25 Jul 2019 21:30:26 +0000 Subject: Change in ...gr-gsm[master]: Fix uplink sub_slot assignment in the sdcch8 demapper block Message-ID: Hello Piotr Krysik, fixeria, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/gr-gsm/+/14947 to review the following change. Change subject: Fix uplink sub_slot assignment in the sdcch8 demapper block ...................................................................... Fix uplink sub_slot assignment in the sdcch8 demapper block 3GPP TS 45.002 version 15.1.0 Release 15 Table 4 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5) Fixes qa_gsm_sdcch8_demapper.test_uplink test Change-Id: I29e9055805c8478010c51ceb40f86ba3aed5ecab --- M hier_blocks/demapping/gsm_sdcch8_demapper.grc M python/demapping/gsm_sdcch8_demapper.py M python/qa_gsm_sdcch8_demapper.py 3 files changed, 148 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/47/14947/1 diff --git a/hier_blocks/demapping/gsm_sdcch8_demapper.grc b/hier_blocks/demapping/gsm_sdcch8_demapper.grc index d9496cb..8a1f509 100644 --- a/hier_blocks/demapping/gsm_sdcch8_demapper.grc +++ b/hier_blocks/demapping/gsm_sdcch8_demapper.grc @@ -145,7 +145,7 @@ uplink_subslots - [1,1,1,1,2,2,2,2,3,3,3,3,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,3,3,3,3,4,4,4,4,5,5,5,5,6,6,6,6,7,7,7,7,0,0,0,0,5,5,5,5,6,6,6,6,7,7,7,7,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,3,3,3,3,4,4,4,4,5,5,5,5,6,6,6,6,7,7,7,7,4,4,4,4] + [5,5,5,5,6,6,6,6,7,7,7,7,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,3,3,3,3,4,4,4,4,5,5,5,5,6,6,6,6,7,7,7,7,0,0,0,0,1,1,1,1,2,2,2,2,3,3,3,3,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,3,3,3,3,4,4,4,4,5,5,5,5,6,6,6,6,7,7,7,7,4,4,4,4] diff --git a/python/demapping/gsm_sdcch8_demapper.py b/python/demapping/gsm_sdcch8_demapper.py index 3d3a5a0..b412594 100644 --- a/python/demapping/gsm_sdcch8_demapper.py +++ b/python/demapping/gsm_sdcch8_demapper.py @@ -51,7 +51,153 @@ ################################################## # Blocks ################################################## - self.gsm_universal_ctrl_chans_demapper_0 = grgsm.universal_ctrl_chans_demapper(timeslot_nr, ([0,0,0,0,4,4,4,4,8,8,8,8,12,12,12,12,16,16,16,16,20,20,20,20,24,24,24,24,28,28,28,28,32,32,32,32,36,36,36,36,40,40,40,40,44,44,44,44,0,0,0]), ([8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,136,136,136,136,136,136,136,136,136,136,136,136,136,136,136,136,0,0,0]), ([0,0,0,0,1,1,1,1,2,2,2,2,3,3,3,3,4,4,4,4,5,5,5,5,6,6,6,6,7,7,7,7,0,0,0,0,1,1,1,1,2,2,2,2,3,3,3,3,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,3,3,3,3,4,4,4,4,5,5,5,5,6,6,6,6,7,7,7,7,4,4,4,4,5,5,5,5,6,6,6,6,7,7,7,7,0,0,0]), ([0,0,0,0,4,4,4,4,8,8,8,8,0,0,0,15,15,15,15,19,19,19,19,23,23,23,23,27,27,27,27,31,31,31,31,35,35,35,35,39,39,39,39,43,43,43,43,47,47,47,47]), ([136,136,136,136,136,136,136,136,136,136,136,136,0,0,0,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,136,136,136,136]), ([1,1,1,1,2,2,2,2,3,3,3,3,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,3,3,3,3,4,4,4,4,5,5,5,5,6,6,6,6,7,7,7,7,0,0,0,0,5,5,5,5,6,6,6,6,7,7,7,7,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,3,3,3,3,4,4,4,4,5,5,5,5,6,6,6,6,7,7,7,7,4,4,4,4])) + + # 3GPP TS 45.002 version 15.1.0 Release 15 + # Table 4 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5) + # SDCCH/8 0 D 0 ... 7 C0 ... Cn NB1 51 B (0 ... 3) + # U B (15 ... 18) + # 1 D B (4 ... 7) + # U B (19 ... 22) + # 2 D B (8 ... 11) + # U B (23 ... 26) + # 3 D B (12 ... 15) + # U B (27 ... 30) + # 4 D B (16 ... 19) + # U B (31 ... 34) + # 5 D B (20 ... 23) + # U B (35 ... 38) + # 6 D B (24 ... 27) + # U B (39 ... 42) + # 7 D B (28 ... 31) + # U B (43 ... 46) + # SACCH/C8 0 D 0 ... 7 C0 ... Cn NB3 102 B (32 ... 35) + # U B (47 ... 50) + # 1 D B (36 ... 39) + # U B (51 ... 54) + # 2 D B (40 ... 43) + # U B (55 ... 58) + # 3 D B (44 ... 47) + # U B (59 ... 62) + # 4 D B (83 ... 86) + # U B (98 ... 101) + # 5 D B (87 ... 90) + # U B (0 ... 3) + # 6 D B (91 ... 94) + # U B (4 ... 7) + # 7 D B (95 ... 98) + # U B (8 ... 11) + self.gsm_universal_ctrl_chans_demapper_0 = grgsm.universal_ctrl_chans_demapper( + timeslot_nr, ([ #downlink + 0,0,0,0, + 4,4,4,4, + 8,8,8,8, + 12,12,12,12, + 16,16,16,16, + 20,20,20,20, + 24,24,24,24, + 28,28,28,28, + 32,32,32,32, + 36,36,36,36, + 40,40,40,40, + 44,44,44,44, + 0,0,0 + ]), ([ + 8,8,8,8, + 8,8,8,8, + 8,8,8,8, + 8,8,8,8, + 8,8,8,8, + 8,8,8,8, + 8,8,8,8, + 8,8,8,8, + 136,136,136,136, + 136,136,136,136, + 136,136,136,136, + 136,136,136,136, + 0,0,0 + ]), ([ + 0,0,0,0, + 1,1,1,1, + 2,2,2,2, + 3,3,3,3, + 4,4,4,4, + 5,5,5,5, + 6,6,6,6, + 7,7,7,7, + 0,0,0,0, + 1,1,1,1, + 2,2,2,2, + 3,3,3,3, + 0,0,0,0, + 0,0,0, + 1,1,1,1, + 2,2,2,2, + 3,3,3,3, + 4,4,4,4, + 5,5,5,5, + 6,6,6,6, + 7,7,7,7, + 4,4,4,4, + 5,5,5,5, + 6,6,6,6, + 7,7,7,7, + 0,0,0 + ]), ([ #uplink + 0,0,0,0, + 4,4,4,4, + 8,8,8,8, + 0,0,0, + 15,15,15,15, + 19,19,19,19, + 23,23,23,23, + 27,27,27,27, + 31,31,31,31, + 35,35,35,35, + 39,39,39,39, + 43,43,43,43, + 47,47,47,47 + ]), ([ + 136,136,136,136, + 136,136,136,136, + 136,136,136,136, + 0,0,0, + 8,8,8,8, + 8,8,8,8, + 8,8,8,8, + 8,8,8,8, + 8,8,8,8, + 8,8,8,8, + 8,8,8,8, + 8,8,8,8, + 136,136,136,136 + ]), ([ + 5,5,5,5, + 6,6,6,6, + 7,7,7,7, + 0,0,0, + 0,0,0,0, + 1,1,1,1, + 2,2,2,2, + 3,3,3,3, + 4,4,4,4, + 5,5,5,5, + 6,6,6,6, + 7,7,7,7, + 0,0,0,0, + 1,1,1,1, + 2,2,2,2, + 3,3,3,3, + 0,0,0, + 0,0,0,0, + 1,1,1,1, + 2,2,2,2, + 3,3,3,3, + 4,4,4,4, + 5,5,5,5, + 6,6,6,6, + 7,7,7,7, + 4,4,4,4 + ])) ################################################## # Connections diff --git a/python/qa_gsm_sdcch8_demapper.py b/python/qa_gsm_sdcch8_demapper.py index b5c5ff5..9972bee 100644 --- a/python/qa_gsm_sdcch8_demapper.py +++ b/python/qa_gsm_sdcch8_demapper.py @@ -135,7 +135,6 @@ 0, 0, 0, 0, ], list(dst.get_sub_slots())) - @unittest.expectedFailure def test_uplink (self): """ BCCH_CCCH_SDCCH4 demapper uplink test -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: I29e9055805c8478010c51ceb40f86ba3aed5ecab Gerrit-Change-Number: 14947 Gerrit-PatchSet: 1 Gerrit-Owner: Vasil Velichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Thu Jul 25 21:30:26 2019 From: gerrit-no-reply at lists.osmocom.org (Vasil Velichkov) Date: Thu, 25 Jul 2019 21:30:26 +0000 Subject: Change in ...gr-gsm[master]: Fix uplink sub_slot and sub_types assignment in the sdcch4 and bcch_c... Message-ID: Hello Piotr Krysik, fixeria, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/gr-gsm/+/14948 to review the following change. Change subject: Fix uplink sub_slot and sub_types assignment in the sdcch4 and bcch_ccch demappers blocks ...................................................................... Fix uplink sub_slot and sub_types assignment in the sdcch4 and bcch_ccch demappers blocks Add support for RACH bursts although they are not yet supported in the receiver and control channel decoder blocks. 3GPP TS 45.002 version 15.1.0 Release 15 Table 3 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5) Figure 8a: TDMA frame mapping for FCCH + SCH + BCCH + CCCH Fixes the following tests: qa_gsm_bcch_ccch_demapper.test_uplink qa_gsm_bcch_ccch_sdcch4_demapper.test_uplink Change-Id: Ia6b3070c1085bcdda6d98fd94a89c6e0982e2aec --- M hier_blocks/demapping/gsm_bcch_ccch_demapper.grc M hier_blocks/demapping/gsm_bcch_ccch_sdcch4_demapper.grc M lib/demapping/universal_ctrl_chans_demapper_impl.cc M python/demapping/gsm_bcch_ccch_demapper.py M python/demapping/gsm_bcch_ccch_sdcch4_demapper.py M python/qa_gsm_bcch_ccch_demapper.py M python/qa_gsm_bcch_ccch_sdcch4_demapper.py 7 files changed, 300 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/48/14948/1 diff --git a/hier_blocks/demapping/gsm_bcch_ccch_demapper.grc b/hier_blocks/demapping/gsm_bcch_ccch_demapper.grc index 79033ef..5f751b1 100644 --- a/hier_blocks/demapping/gsm_bcch_ccch_demapper.grc +++ b/hier_blocks/demapping/gsm_bcch_ccch_demapper.grc @@ -137,15 +137,15 @@ uplink_channel_types - [2,2,2,2,0,0,2,2,2,2,2,2,2,2,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,2,2,2,2,2,2,2,2,0,0,2,2,2,2,] + [3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,] uplink_starts_fn_mod51 - [0,0,0,0,0,0,6,6,6,6,10,10,10,10,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,37,37,37,37,41,41,41,41,0,0,47,47,47,47] + [0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,] uplink_subslots - [0,0,0,0,0,0,0,0,0,0,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,0,0,3,3,3,3,0,0,0,0,0,0,2,2,2,2,3,3,3,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,0,0,3,3,3,3] + [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0] diff --git a/hier_blocks/demapping/gsm_bcch_ccch_sdcch4_demapper.grc b/hier_blocks/demapping/gsm_bcch_ccch_sdcch4_demapper.grc index 9d722ba..235feb2 100644 --- a/hier_blocks/demapping/gsm_bcch_ccch_sdcch4_demapper.grc +++ b/hier_blocks/demapping/gsm_bcch_ccch_sdcch4_demapper.grc @@ -137,15 +137,15 @@ uplink_channel_types - [7,7,7,7,0,0,135,135,135,135,135,135,135,135,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,7,7,7,7,7,7,7,7,0,0,7,7,7,7] + [7,7,7,7,3,3,135,135,135,135,135,135,135,135,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,3,7,7,7,7,7,7,7,7,3,3,7,7,7,7] uplink_starts_fn_mod51 - [0,0,0,0,0,0,6,6,6,6,10,10,10,10,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,37,37,37,37,41,41,41,41,0,0,47,47,47,47] + [0,0,0,0,4,5,6,6,6,6,10,10,10,10,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,37,37,37,41,41,41,41,45,46,47,47,47,47,] uplink_subslots - [0,0,0,0,0,0,0,0,0,0,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,0,0,3,3,3,3,0,0,0,0,0,0,2,2,2,2,3,3,3,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,0,0,3,3,3,3] + [3,3,3,3,0,0,2,2,2,2,3,3,3,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,0,0,2,2,2,2,3,3,3,3,0,0,0,0,0,0,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,0,0,2,2,2,2,] diff --git a/lib/demapping/universal_ctrl_chans_demapper_impl.cc b/lib/demapping/universal_ctrl_chans_demapper_impl.cc index a6ab956..94e8648 100644 --- a/lib/demapping/universal_ctrl_chans_demapper_impl.cc +++ b/lib/demapping/universal_ctrl_chans_demapper_impl.cc @@ -128,9 +128,6 @@ frame_numbers = d_downlink_frame_numbers; bursts = d_downlink_bursts; } - - uint32_t fn51_start = starts_fn_mod51[fn_mod51]; - uint32_t fn51_stop = fn51_start + 3; //set type new_header->type = GSMTAP_TYPE_UM; @@ -141,7 +138,16 @@ new_header->sub_type = ch_type; } new_header->sub_slot = subslots[fn_mod102]; - + + if (ch_type == GSMTAP_CHANNEL_RACH) + { + message_port_pub(pmt::mp("bursts"), burst_out); + return; + } + + uint32_t fn51_start = starts_fn_mod51[fn_mod51]; + uint32_t fn51_stop = fn51_start + 3; + if(fn_mod51>=fn51_start && fn_mod51<=fn51_stop) { uint32_t ii = fn_mod51 - fn51_start; diff --git a/python/demapping/gsm_bcch_ccch_demapper.py b/python/demapping/gsm_bcch_ccch_demapper.py index 5bafba7..e036831 100644 --- a/python/demapping/gsm_bcch_ccch_demapper.py +++ b/python/demapping/gsm_bcch_ccch_demapper.py @@ -51,7 +51,135 @@ ################################################## # Blocks ################################################## - self.gsm_universal_ctrl_chans_demapper_0 = grgsm.universal_ctrl_chans_demapper(timeslot_nr, ([0,0,2,2,2,2,6,6,6,6,0,0,12,12,12,12,16,16,16,16,0,0,22,22,22,22,26,26,26,26,0,0,32,32,32,32,36,36,36,36,0,0,42,42,42,42,46,46,46,46,0,]), ([0,0,1,1,1,1,2,2,2,2,0,0,2,2,2,2,2,2,2,2,0,0,2,2,2,2,2,2,2,2,0,0,2,2,2,2,2,2,2,2,0,0,2,2,2,2,2,2,2,2,0,]), ([0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,0,0,3,3,3,3,4,4,4,4,0,0,5,5,5,5,6,6,6,6,0,0,7,7,7,7,8,8,8,8,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,0,0,3,3,3,3,4,4,4,4,0,0,5,5,5,5,6,6,6,6,0,0,7,7,7,7,8,8,8,8,0]), ([0,0,0,0,0,0,6,6,6,6,10,10,10,10,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,37,37,37,37,41,41,41,41,0,0,47,47,47,47]), ([2,2,2,2,0,0,2,2,2,2,2,2,2,2,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,2,2,2,2,2,2,2,2,0,0,2,2,2,2,]), ([0,0,0,0,0,0,0,0,0,0,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,0,0,3,3,3,3,0,0,0,0,0,0,2,2,2,2,3,3,3,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,0,0,3,3,3,3])) + + # 3GPP TS 45.002 version 15.1.0 Release 15 + # Table 3 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5) + # BCCH Norm D 0,2,4,6 C0 NB 51 B(2..5) + # RACH U 0,2,4,6 C0 AB, Extended AB2 51 B0(0),B1(1)..B50(50) + # Figure 8a: TDMA frame mapping for FCCH + SCH + BCCH + CCCH + self.gsm_universal_ctrl_chans_demapper_0 = grgsm.universal_ctrl_chans_demapper( + timeslot_nr, ([ #downlink + 0,0, + 2,2,2,2, + 6,6,6,6, + 0,0, + 12,12,12,12, + 16,16,16,16, + 0,0, + 22,22,22,22, + 26,26,26,26, + 0,0, + 32,32,32,32, + 36,36,36,36, + 0,0, + 42,42,42,42, + 46,46,46,46, + 0, + ]), ([ + 0,0, + 1,1,1,1, + 2,2,2,2, + 0,0, + 2,2,2,2, + 2,2,2,2, + 0,0, + 2,2,2,2, + 2,2,2,2, + 0,0, + 2,2,2,2, + 2,2,2,2, + 0,0, + 2,2,2,2, + 2,2,2,2, + 0, + ]), ([ + 0,0, + 0,0,0,0, + 0,0,0,0, + 0,0, + 1,1,1,1, + 2,2,2,2, + 0,0, + 3,3,3,3, + 4,4,4,4, + 0,0, + 5,5,5,5, + 6,6,6,6, + 0,0, + 7,7,7,7, + 8,8,8,8, + 0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 1,1,1,1, + 2,2,2,2, + 0,0, + 3,3,3,3, + 4,4,4,4, + 0,0, + 5,5,5,5, + 6,6,6,6, + 0,0, + 7,7,7,7, + 8,8,8,8, + 0, + ]), ([ #uplink + 0,1,2,3, + 4,5,6,7, + 8,9,10,11, + 12,13,14,15, + 16,17,18,19, + 20,21,22,23, + 24,25,26,27, + 28,29,30,31, + 32,33,34,35, + 36,37,38,39, + 40,41,42,43, + 44,45,46,47, + 48,49,50, + ]), ([ + 3,3,3,3, + 3,3,3,3, + 3,3,3,3, + 3,3,3,3, + 3,3,3,3, + 3,3,3,3, + 3,3,3,3, + 3,3,3,3, + 3,3,3,3, + 3,3,3,3, + 3,3,3,3, + 3,3,3,3, + 3,3,3, + ]), ([ + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0, + ])) ################################################## # Connections diff --git a/python/demapping/gsm_bcch_ccch_sdcch4_demapper.py b/python/demapping/gsm_bcch_ccch_sdcch4_demapper.py index 7b6a04d..bff67a4 100644 --- a/python/demapping/gsm_bcch_ccch_sdcch4_demapper.py +++ b/python/demapping/gsm_bcch_ccch_sdcch4_demapper.py @@ -51,7 +51,161 @@ ################################################## # Blocks ################################################## - self.gsm_universal_ctrl_chans_demapper_0 = grgsm.universal_ctrl_chans_demapper(timeslot_nr, ([0,0,2,2,2,2,6,6,6,6,0,0,12,12,12,12,16,16,16,16,0,0,22,22,22,22,26,26,26,26,0,0,32,32,32,32,36,36,36,36,0,0,42,42,42,42,46,46,46,46,0]), ([0,0,1,1,1,1,2,2,2,2,0,0,2,2,2,2,2,2,2,2,0,0,7,7,7,7,7,7,7,7,0,0,7,7,7,7,7,7,7,7,0,0,135,135,135,135,135,135,135,135,0]), ([0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,0,0,0,0,0,0,1,1,1,1,0,0,2,2,2,2,3,3,3,3,0,0,0,0,0,0,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,0,0,0,0,0,0,1,1,1,1,0,0,2,2,2,2,3,3,3,3,0,0,2,2,2,2,3,3,3,3,0]), ([0,0,0,0,0,0,6,6,6,6,10,10,10,10,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,37,37,37,37,41,41,41,41,0,0,47,47,47,47]), ([7,7,7,7,0,0,135,135,135,135,135,135,135,135,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,7,7,7,7,7,7,7,7,0,0,7,7,7,7]), ([0,0,0,0,0,0,0,0,0,0,1,1,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,0,0,3,3,3,3,0,0,0,0,0,0,2,2,2,2,3,3,3,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,1,1,1,2,2,2,2,0,0,3,3,3,3])) + + # 3GPP TS 45.002 version 15.1.0 Release 15 + # Table 3 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5) + # + # BCCH Norm D 0,2,4,6 C0 NB 51 B(2..5) + # SDCCH/4 0 D 0 C0 NB1 51 B(22..25) + # U B(37..40) + # 1 D B(26..29) + # U B(41..44) + # 2 D B(32..35) + # U B(47..50) + # 3 D B(36..39) + # U B(0..3) + # SACCH/C4 0 D 0 C0 NB3 102 B(42..45) + # U B(57..60) + # 1 D B(46..49) + # U B(61..64) + # 2 D B(93..96) + # U B(6..9) + # 3 D B(97..100) + # U B(10..13) + # + # Figure 8b: TDMA frame mapping for FCCH + SCH + BCCH + CCCH + SDCCH/4(0...3) + SACCH/4(0...3) + # + self.gsm_universal_ctrl_chans_demapper_0 = grgsm.universal_ctrl_chans_demapper( + timeslot_nr, ([ #downlink + 0,0, + 2,2,2,2, + 6,6,6,6, + 0,0, + 12,12,12,12, + 16,16,16,16, + 0,0, + 22,22,22,22, + 26,26,26,26, + 0,0, + 32,32,32,32, + 36,36,36,36, + 0,0, + 42,42,42,42, + 46,46,46,46, + 0, + ]), ([ + 0,0, + 1,1,1,1, + 2,2,2,2, + 0,0, + 2,2,2,2, + 2,2,2,2, + 0,0, + 7,7,7,7, + 7,7,7,7, + 0,0, + 7,7,7,7, + 7,7,7,7, + 0,0, + 135,135,135,135, + 135,135,135,135, + 0, + ]), ([ + 0,0, + 0,0,0,0, + 0,0,0,0, + 0,0, + 1,1,1,1, + 2,2,2,2, + 0,0, + 0,0,0,0, + 1,1,1,1, + 0,0, + 2,2,2,2, + 3,3,3,3, + 0,0, + 0,0,0,0, + 1,1,1,1, + 0,0, + 0,0,0,0, + 0,0,0,0, + 0,0, + 0, + 1,1,1,1, + 2,2,2,2, + 0,0, + 0,0,0,0, + 1,1,1,1, + 0,0, + 2,2,2,2, + 3,3,3,3, + 0,0, + 2,2,2,2, + 3,3,3,3, + 0, + ]), ([ #uplink + 0,0,0,0, + 4,5, + 6,6,6,6, + 10,10,10,10, + 14,15,16,17, + 18,19,20,21, + 22,23,24,25, + 26,27,28,29, + 30,31,32,33, + 34,35,36, + 37,37,37,37, + 41,41,41,41, + 45,46, + 47,47,47,47, + ]), ([ + 7,7,7,7, + 3,3, + 135,135,135,135, + 135,135,135,135, + 3,3,3,3, + 3,3,3,3, + 3,3,3,3, + 3,3,3,3, + 3,3,3,3, + 3,3, + 3, + 7,7,7,7, + 7,7,7,7, + 3,3, + 7,7,7,7, + ]), ([ + 3,3,3,3, + 0,0, + 2,2,2,2, + 3,3,3,3, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0, + 0, + 0,0,0,0, + 1,1,1,1, + 0,0, + 2,2,2,2, + 3,3,3,3, + 0,0, + 0,0,0,0, + 1,1,1,1, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0,0,0, + 0,0, + 0, + 0,0,0,0, + 1,1,1,1, + 0,0, + 2,2,2,2, + ])) ################################################## # Connections diff --git a/python/qa_gsm_bcch_ccch_demapper.py b/python/qa_gsm_bcch_ccch_demapper.py index 358b046..17a006d 100644 --- a/python/qa_gsm_bcch_ccch_demapper.py +++ b/python/qa_gsm_bcch_ccch_demapper.py @@ -123,7 +123,6 @@ 0, 0, 0, 0, #BCCH ], list(dst.get_sub_slots())) - @unittest.expectedFailure def test_uplink (self): """ BCCH_CCCH demapper uplink test diff --git a/python/qa_gsm_bcch_ccch_sdcch4_demapper.py b/python/qa_gsm_bcch_ccch_sdcch4_demapper.py index a3688c7..3cc74a4 100644 --- a/python/qa_gsm_bcch_ccch_sdcch4_demapper.py +++ b/python/qa_gsm_bcch_ccch_sdcch4_demapper.py @@ -123,7 +123,6 @@ 0, 0, 0, 0, #BCCH ], list(dst.get_sub_slots())) - @unittest.expectedFailure def test_uplink (self): """ BCCH_CCCH_SDCCH4 demapper uplink test -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: Ia6b3070c1085bcdda6d98fd94a89c6e0982e2aec Gerrit-Change-Number: 14948 Gerrit-PatchSet: 1 Gerrit-Owner: Vasil Velichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Fri Jul 26 02:36:18 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 26 Jul 2019 02:36:18 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_9.0/aarch64 In-Reply-To: References: Message-ID: <5d3a67381a815_6c02b0f410305f42322d@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_9.0/aarch64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 217s] asciidoc -v -f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -f ../build/python2-filter.conf -a srcdir='.' -a commondir='../common' test-usermanual.adoc > test-usermanual.check 2>&1 [ 249s] # Make absolutely sure that the %.check target is updated. [ 249s] touch test-usermanual.check [ 249s] # Do print the WARNING output but return error if any was found [ 249s] # (grep -v would omit the WARNING output from the log). [ 249s] asciidoc: WARNING: mgcp_extension_osmux.adoc: line 2: section title out of sequence: expected level 1, got level 2 [ 249s] ../build/Makefile.asciidoc.inc:87: recipe for target 'test-usermanual.check' failed [ 249s] make[3]: *** [test-usermanual.check] Error 1 [ 249s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 249s] Makefile:438: recipe for target 'check-recursive' failed [ 249s] make[2]: *** [check-recursive] Error 1 [ 249s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 249s] Makefile:729: recipe for target 'check' failed [ 249s] make[1]: *** [check] Error 2 [ 249s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 249s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2 [ 249s] debian/rules:5: recipe for target 'binary' failed [ 249s] make: *** [binary] Error 2 [ 249s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 [ 249s] [ 249s] obs-arm-9 failed "build osmo-gsm-manuals-dev_0.1.1.4.c197.dsc" at Fri Jul 26 02:36:07 UTC 2019. [ 249s] [ 249s] ### VM INTERACTION START ### [ 253s] [ 242.037439] sysrq: Power Off [ 253s] [ 242.040847] reboot: Power down [ 253s] ### VM INTERACTION END ### [ 253s] [ 253s] obs-arm-9 failed "build osmo-gsm-manuals-dev_0.1.1.4.c197.dsc" at Fri Jul 26 02:36:10 UTC 2019. [ 253s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Fri Jul 26 02:39:10 2019 From: admin at opensuse.org (OBS Notification) Date: Fri, 26 Jul 2019 02:39:10 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in xUbuntu_18.10/i586 In-Reply-To: References: Message-ID: <5d3a67e937383_6c02b0f410305f423247e@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/xUbuntu_18.10/i586 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in xUbuntu_18.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 368s] # same. [ 368s] if ! [ -f test-usermanual.adoc ]; then \ [ 368s] ln -s test-usermanual.adoc test-usermanual.adoc; \ [ 368s] fi [ 368s] asciidoc -v -f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -f ../build/python2-filter.conf -a srcdir='.' -a commondir='../common' test-usermanual.adoc > test-usermanual.check 2>&1 [ 395s] # Make absolutely sure that the %.check target is updated. [ 395s] touch test-usermanual.check [ 395s] # Do print the WARNING output but return error if any was found [ 395s] # (grep -v would omit the WARNING output from the log). [ 395s] asciidoc: WARNING: mgcp_extension_osmux.adoc: line 2: section title out of sequence: expected level 1, got level 2 [ 395s] make[3]: *** [../build/Makefile.asciidoc.inc:96: test-usermanual.check] Error 1 [ 395s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 395s] make[2]: *** [Makefile:438: check-recursive] Error 1 [ 395s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 395s] make[1]: *** [Makefile:732: check] Error 2 [ 395s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 395s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2 [ 395s] make: *** [debian/rules:5: binary] Error 2 [ 395s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 395s] [ 395s] lamb26 failed "build osmo-gsm-manuals-dev_0.1.1.4.c197.dsc" at Fri Jul 26 02:39:00 UTC 2019. [ 395s] [ 395s] ### VM INTERACTION START ### [ 398s] [ 382.053306] sysrq: SysRq : Power Off [ 398s] [ 382.058427] reboot: Power down [ 398s] ### VM INTERACTION END ### [ 398s] [ 398s] lamb26 failed "build osmo-gsm-manuals-dev_0.1.1.4.c197.dsc" at Fri Jul 26 02:39:04 UTC 2019. [ 398s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:23:24 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 05:23:24 +0000 Subject: Change in ...osmo-gsm-tester[master]: resources.conf.prod: Use different ARFCN for sysmocell-5k In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14934 ) Change subject: resources.conf.prod: Use different ARFCN for sysmocell-5k ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I6d5555aa8740b262ee92110987189c076db44f76 Gerrit-Change-Number: 14934 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Jul 2019 05:23:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:23:55 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 05:23:55 +0000 Subject: Change in ...libosmocore[master]: gsm/gsm48.h: drop meaningless 'const' from gsm48_mi_to_string() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14935 ) Change subject: gsm/gsm48.h: drop meaningless 'const' from gsm48_mi_to_string() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5eb17edadf89ac47b4ca86c9e822037f7c0e518e Gerrit-Change-Number: 14935 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Jul 2019 05:23:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:23:57 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 05:23:57 +0000 Subject: Change in ...libosmocore[master]: gsm/gsm48.h: drop meaningless 'const' from gsm48_mi_to_string() In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14935 ) Change subject: gsm/gsm48.h: drop meaningless 'const' from gsm48_mi_to_string() ...................................................................... gsm/gsm48.h: drop meaningless 'const' from gsm48_mi_to_string() Change-Id: I5eb17edadf89ac47b4ca86c9e822037f7c0e518e --- M include/osmocom/gsm/gsm48.h M src/gsm/gsm48.c 2 files changed, 2 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/gsm/gsm48.h b/include/osmocom/gsm/gsm48.h index 786fbc9..7c68b1d 100644 --- a/include/osmocom/gsm/gsm48.h +++ b/include/osmocom/gsm/gsm48.h @@ -53,8 +53,7 @@ uint8_t gsm48_generate_mid(uint8_t *buf, const char *id, uint8_t mi_type); /* Convert Mobile Identity (10.5.1.4) to string */ -int gsm48_mi_to_string(char *string, const int str_len, - const uint8_t *mi, const int mi_len); +int gsm48_mi_to_string(char *string, int str_len, const uint8_t *mi, int mi_len); const char *gsm48_mi_type_name(uint8_t mi); const char *osmo_mi_name(const uint8_t *mi, uint8_t mi_len); char *osmo_mi_name_buf(char *buf, size_t buf_len, const uint8_t *mi, uint8_t mi_len); diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c index c97337b..2d6deb5 100644 --- a/src/gsm/gsm48.c +++ b/src/gsm/gsm48.c @@ -741,8 +741,7 @@ * Depending on the MI type and amount of output buffer, this may return * the nr of written bytes, or the written strlen(), or the snprintf() * style strlen()-if-the-buffer-were-large-enough. */ -int gsm48_mi_to_string(char *string, const int str_len, const uint8_t *mi, - const int mi_len) +int gsm48_mi_to_string(char *string, int str_len, const uint8_t *mi, int mi_len) { int rc; uint8_t mi_type; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5eb17edadf89ac47b4ca86c9e822037f7c0e518e Gerrit-Change-Number: 14935 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:25:30 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 05:25:30 +0000 Subject: Change in ...osmo-hlr[master]: db_auc.c: verify hex key sizes read from DB In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14933 ) Change subject: db_auc.c: verify hex key sizes read from DB ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 Gerrit-Change-Number: 14933 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-Comment-Date: Fri, 26 Jul 2019 05:25:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:26:14 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 05:26:14 +0000 Subject: Change in ...osmo-gsm-tester[master]: ttcn3: Increase TTCN3 IPA UP to have sysmobts tests working In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14936 ) Change subject: ttcn3: Increase TTCN3 IPA UP to have sysmobts tests working ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I25c0a49851865291c6251556aff139961c3d4166 Gerrit-Change-Number: 14936 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 05:26:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:26:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 05:26:16 +0000 Subject: Change in ...osmo-gsm-tester[master]: ttcn3: Increase TTCN3 IPA UP to have sysmobts tests working In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14936 ) Change subject: ttcn3: Increase TTCN3 IPA UP to have sysmobts tests working ...................................................................... ttcn3: Increase TTCN3 IPA UP to have sysmobts tests working It was spotted that most TTCN3 tests run against sysmobts fail because of following error: BTS_Tests.ttcn:643 Test case TC_chan_act_react finished. Verdict: fail reason: "BTS_Tests.ttcn:399 : Timeout waiting for ASP_IPA_EVENT_UP" Looking carefully at the logs and pcap files, it was seen that usually sysmobts tries to connect around 1 second after the TTCN3 tests decides it's enough. Current timeout was default of 15 seconds. Let's set it to 30 seconds. While at it, also set mp_ipa_up_delay, as initially set to 3 seconds in osmo-ttcn3-hacks.git d95f340a01fe7e9fe59f02b6ec4f9d018feb8c75 having physical tests in mind. Change-Id: I25c0a49851865291c6251556aff139961c3d4166 --- M ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl b/ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl index 92f0faa..eae6063 100644 --- a/ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl +++ b/ttcn3/suites/ttcn3_bts_tests/scripts/BTS_Tests.cfg.tmpl @@ -22,6 +22,8 @@ BTS_Tests.mp_tolerance_rxlev := 10; BTS_Tests.mp_tolerance_rxqual := 1; BTS_Tests.mp_trx0_arfcn := 868 +BTS_Tests.mp_ipa_up_timeout := 30.0 +BTS_Tests.mp_ipa_up_delay := 3.0 [MAIN_CONTROLLER] -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I25c0a49851865291c6251556aff139961c3d4166 Gerrit-Change-Number: 14936 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:27:00 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 05:27:00 +0000 Subject: Change in ...osmo-gsm-manuals[master]: counters-overview: Add a section about the stats reporter In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14937 ) Change subject: counters-overview: Add a section about the stats reporter ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia338409e6cb1b1478429e3a99158b9d8255dbb2c Gerrit-Change-Number: 14937 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Jul 2019 05:27:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:27:06 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 05:27:06 +0000 Subject: Change in ...osmo-gsm-manuals[master]: counters-overview: Add a section about the stats reporter In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14937 ) Change subject: counters-overview: Add a section about the stats reporter ...................................................................... counters-overview: Add a section about the stats reporter Fixes: OS#3768 Change-Id: Ia338409e6cb1b1478429e3a99158b9d8255dbb2c --- M common/chapters/counters-overview.adoc 1 file changed, 86 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/common/chapters/counters-overview.adoc b/common/chapters/counters-overview.adoc index fbdef30..8f9a29a 100644 --- a/common/chapters/counters-overview.adoc +++ b/common/chapters/counters-overview.adoc @@ -3,7 +3,7 @@ The following gives an overview of all the types of counters available: -=== Osmo Counters +=== Osmo Counters (deprecated) Osmo counters are the oldest type of counters added to Osmocom projects. They are not grouped. @@ -26,12 +26,11 @@ rate_ctr.per_{sec,min,hour,day,abs}...[counter_name] -It is possible to get all counters from a group by omitting the counter name +It is possible to get all counters in a group by omitting the counter name === Stat Item -Stat items are a grouped replacement for osmo counters, but not many stat -items are available yet. +Stat items are a grouped replacement for osmo counters. * Printed as part of VTY show stats * Replacement for osmo counters @@ -39,12 +38,91 @@ * Grouped and indexed like rate counters * Items have a unit * Keeps a list of the last values measured, so could return an average, min, - max, std. deviation + max, std. deviation. So far this is not implemented in any of the reporting + options. + +=== Statistic Levels + +There are three levels on which a statistic can be aggregated in Osmocom +projects: globally, per-peer and per-subscriber. + +==== Global + +These are global statistics. + +==== Peer + +These statistics relate to a peer the program connects to such as the NSVC in +an SGSN. + +This level also includes reporting global statistics. + +==== Subscriber + +These statistics are related to an individual mobile subscriber. An example +would be bytes transferred in an SGSN PDP context. + +This level also includes global and peer-based statistics. === Stats Reporter -Statsd stats reporter can send osmo counter, rate counter and stats item values to statsd +The stats reporter periodically collects osmo counter, rate counter and +stat item values and sends them to a backend. Currently implemented are +outputting to the configured log targets and a statsd connector. -See the stats reporter command of the VTY reference for details on how to -setup the connection to statsd. +==== Configuring a stats reporter +Periodically printing the statistics to the log can be done in the following +way: + +.Log statistics +==== + +---- +OsmoBSC> enable +OsmoBSC# configure terminal +OsmoBSC(config)# stats interval 60 <1> +OsmoBSC(config)# stats reporter log <2> +OsmoBSC(config-stats)# level global <3> +OsmoBSC(config-stats)# enable <4> +---- +==== + +<1> The interval determines how often the statistics are reported. +<2> Write the statistic information to any configured log target. +<3> Report only `global` statistics (can be `global`, `peer`, or + `subscriber`). +<4> Enable the reporter, `disable` will disable it again. + +The counter values can also be sent to any aggregation/visualization tool that +understands the statsd format, for example a statsd server with graphite or +prometheus using the statsd_exporter together with grafana. + +The statsd format is specified in https://github.com/b/statsd_spec + +.Report statistics to statsd +==== + +---- +OsmoBSC> enable +OsmoBSC# configure terminal +OsmoBSC(config)# stats interval 10 +OsmoBSC(config)# stats reporter statsd <1> +OsmoBSC(config-stats)# prefix BSC1 <2> +OsmoBSC(config-stats)# level subscriber <3> +OsmoBSC(config-stats)# remote-ip 1.2.3.4 <4> +OsmoBSC(config-stats)# remote-port 8125 <5> +OsmoBSC(config-stats)# enable +---- +==== + +<1> Configure the statsd reporter. +<2> Prefix the reported statistics. This is useful to distinguish statistics + from multiple instances of the same service. +<3> Report only `global` statistics or include `peer` or `subscriber` + statistics as well. +<4> IP address of the statsd server. +<5> UDP port of the statsd server. Statsd by default listens to port 8125. + +Setting up a statsd server and configuring the visualization is beyond the +scope of this document. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia338409e6cb1b1478429e3a99158b9d8255dbb2c Gerrit-Change-Number: 14937 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:29:21 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 05:29:21 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 ) Change subject: common: trx_if.adoc: Improve documentation ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Jul 2019 05:29:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:30:00 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 05:30:00 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 ) Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 Gerrit-Change-Number: 14940 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 05:30:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:31:43 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 05:31:43 +0000 Subject: Change in ...gr-gsm[master]: Add control channels demappers tests In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14945 ) Change subject: Add control channels demappers tests ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: I33b0948832a0c2506bffd389cc134c3236c74d27 Gerrit-Change-Number: 14945 Gerrit-PatchSet: 1 Gerrit-Owner: vvvelichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 05:31:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:33:34 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 05:33:34 +0000 Subject: Change in ...gr-gsm[master]: Fix sub_slot assignment in the universal_ctrl_chans_demapper block In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14946 ) Change subject: Fix sub_slot assignment in the universal_ctrl_chans_demapper block ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14946 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: Idc63407694fd1f7be962ab630d4e8c13b4a5d348 Gerrit-Change-Number: 14946 Gerrit-PatchSet: 1 Gerrit-Owner: vvvelichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 05:33:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:34:32 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 05:34:32 +0000 Subject: Change in ...gr-gsm[master]: Fix uplink sub_slot assignment in the sdcch8 demapper block In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14947 ) Change subject: Fix uplink sub_slot assignment in the sdcch8 demapper block ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14947 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: I29e9055805c8478010c51ceb40f86ba3aed5ecab Gerrit-Change-Number: 14947 Gerrit-PatchSet: 1 Gerrit-Owner: vvvelichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 05:34:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:34:41 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 05:34:41 +0000 Subject: Change in ...gr-gsm[master]: Fix uplink sub_slot and sub_types assignment in the sdcch4 and bcch_c... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14948 ) Change subject: Fix uplink sub_slot and sub_types assignment in the sdcch4 and bcch_ccch demappers blocks ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: Ia6b3070c1085bcdda6d98fd94a89c6e0982e2aec Gerrit-Change-Number: 14948 Gerrit-PatchSet: 1 Gerrit-Owner: vvvelichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 05:34:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 05:55:22 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Jul 2019 05:55:22 +0000 Subject: Change in ...osmo-hlr[master]: db_auc.c: verify hex key sizes read from DB In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14933 ) Change subject: db_auc.c: verify hex key sizes read from DB ...................................................................... db_auc.c: verify hex key sizes read from DB Replace commented out size check for Ki with a real check, and use it consistently for Ki, K, OP and OPC. Add a test that sets all keys to the wrong size and tries to read them. Related: OS#2565 Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 --- M src/db_auc.c M tests/db/db_test.c M tests/db/db_test.err 3 files changed, 201 insertions(+), 29 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/db_auc.c b/src/db_auc.c index e29b44b..2cf7143 100644 --- a/src/db_auc.c +++ b/src/db_auc.c @@ -73,6 +73,32 @@ return ret; } +/* hexparse a specific column of a sqlite prepared statement into dst (with length check) + * returns 0 for success, -EIO on error */ +static int hexparse_stmt(uint8_t *dst, size_t dst_len, sqlite3_stmt *stmt, int col, const char *col_name, + const char *imsi) +{ + const uint8_t *text; + size_t col_len; + + /* Bytes are stored as hex strings in database, hence divide length by two */ + col_len = sqlite3_column_bytes(stmt, col) / 2; + + if (col_len != dst_len) { + LOGAUC(imsi, LOGL_ERROR, "Error reading %s, expected length %lu but has length %lu\n", col_name, + dst_len, col_len); + return -EIO; + } + + text = sqlite3_column_text(stmt, col); + if (!text) { + LOGAUC(imsi, LOGL_ERROR, "Error reading %s\n", col_name); + return -EIO; + } + osmo_hexparse((void *)text, dst, dst_len); + return 0; +} + /* obtain the authentication data for a given imsi * returns 0 for success, negative value on error: * -ENOENT if the IMSI is not known, -ENOKEY if the IMSI is known but has no auth data, @@ -113,49 +139,34 @@ /* obtain result values using sqlite3_column_*() */ if (sqlite3_column_type(stmt, 1) == SQLITE_INTEGER) { /* we do have some 2G authentication data */ - const uint8_t *ki; - - aud2g->algo = sqlite3_column_int(stmt, 1); - ki = sqlite3_column_text(stmt, 2); -#if 0 - if (sqlite3_column_bytes(stmt, 2) != sizeof(aud2g->u.gsm.ki)) { - LOGAUC(imsi, LOGL_ERROR, "Error reading Ki: %d\n", rc); + if (hexparse_stmt(aud2g->u.gsm.ki, sizeof(aud2g->u.gsm.ki), stmt, 2, "Ki", imsi)) goto end_2g; - } -#endif - osmo_hexparse((void*)ki, (void*)&aud2g->u.gsm.ki, sizeof(aud2g->u.gsm.ki)); + aud2g->algo = sqlite3_column_int(stmt, 1); aud2g->type = OSMO_AUTH_TYPE_GSM; } else LOGAUC(imsi, LOGL_DEBUG, "No 2G Auth Data\n"); -//end_2g: +end_2g: if (sqlite3_column_type(stmt, 3) == SQLITE_INTEGER) { /* we do have some 3G authentication data */ - const uint8_t *k, *op, *opc; - - aud3g->algo = sqlite3_column_int(stmt, 3); - k = sqlite3_column_text(stmt, 4); - if (!k) { - LOGAUC(imsi, LOGL_ERROR, "Error reading K: %d\n", rc); + if (hexparse_stmt(aud3g->u.umts.k, sizeof(aud3g->u.umts.k), stmt, 4, "K", imsi)) { ret = -EIO; goto out; } - osmo_hexparse((void*)k, (void*)&aud3g->u.umts.k, sizeof(aud3g->u.umts.k)); + aud3g->algo = sqlite3_column_int(stmt, 3); + /* UMTS Subscribers can have either OP or OPC */ - op = sqlite3_column_text(stmt, 5); - if (!op) { - opc = sqlite3_column_text(stmt, 6); - if (!opc) { - LOGAUC(imsi, LOGL_ERROR, "Error reading OPC: %d\n", rc); + if (sqlite3_column_text(stmt, 5)) { + if (hexparse_stmt(aud3g->u.umts.opc, sizeof(aud3g->u.umts.opc), stmt, 5, "OP", imsi)) { ret = -EIO; goto out; } - osmo_hexparse((void*)opc, (void*)&aud3g->u.umts.opc, - sizeof(aud3g->u.umts.opc)); - aud3g->u.umts.opc_is_op = 0; - } else { - osmo_hexparse((void*)op, (void*)&aud3g->u.umts.opc, - sizeof(aud3g->u.umts.opc)); aud3g->u.umts.opc_is_op = 1; + } else { + if (hexparse_stmt(aud3g->u.umts.opc, sizeof(aud3g->u.umts.opc), stmt, 6, "OPC", imsi)) { + ret = -EIO; + goto out; + } + aud3g->u.umts.opc_is_op = 0; } aud3g->u.umts.sqn = sqlite3_column_int64(stmt, 7); aud3g->u.umts.ind_bitlen = sqlite3_column_int(stmt, 8); diff --git a/tests/db/db_test.c b/tests/db/db_test.c index fdd62c5..cc299bf 100644 --- a/tests/db/db_test.c +++ b/tests/db/db_test.c @@ -208,6 +208,17 @@ #undef Phex } +void db_raw_sql(struct db_context *dbc, const char *sql) +{ + sqlite3_stmt *stmt; + + fprintf(stderr, "raw SQL: %s\n", sql); + ASSERT_RC(sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL), SQLITE_OK); + ASSERT_RC(sqlite3_step(stmt), SQLITE_DONE); + db_remove_reset(stmt); + sqlite3_finalize(stmt); +} + static const char *imsi0 = "123456789000000"; static const char *imsi1 = "123456789000001"; static const char *imsi2 = "123456789000002"; @@ -749,6 +760,70 @@ comment_end(); } +/* Make each key too short in this test. Note that we can't set them longer than the allowed size without changing the + * table structure. */ +static void test_subscr_aud_invalid_len() +{ + int64_t id; + + comment_start(); + comment("Create subscriber"); + ASSERT_RC(db_subscr_create(dbc, imsi0, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), 0); + ASSERT_SEL(imsi, imsi0, 0); + id = g_subscr.id; + + + /* Invalid Ki length */ + comment("Set auth data, 2G only, with invalid Ki length"); + ASSERT_RC(db_subscr_update_aud_by_id(dbc, id, + mk_aud_2g(OSMO_AUTH_ALG_COMP128v1, "0123456789abcdef0123456789abcdef")), + 0); + /* Use raw SQL to avoid length check in db_subscr_update_aud_by_id(). This changes all rows in the table, which + * is fine for this test (implicit WHERE 1). */ + db_raw_sql(dbc, "UPDATE auc_2g SET ki = '0123456789abcdef0123456789abcde'"); + ASSERT_SEL_AUD(imsi0, -ENOKEY, id); + + comment("Remove 2G auth data"); + ASSERT_RC(db_subscr_update_aud_by_id(dbc, id, + mk_aud_2g(OSMO_AUTH_ALG_NONE, NULL)), + 0); + + /* Invalid K length */ + comment("Set auth data, 3G only, with invalid K length"); + ASSERT_RC(db_subscr_update_aud_by_id(dbc, id, + mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, + "BeefedCafeFaceAcedAddedDecadeFee", true, + "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)), + 0); + db_raw_sql(dbc, "UPDATE auc_3g SET k = 'C01ffedC1cadaeAc1d1f1edAcac1aB0'"); + ASSERT_SEL_AUD(imsi0, -EIO, id); + + /* Invalid OP length */ + comment("Set auth data, 3G only, with invalid OP length"); + ASSERT_RC(db_subscr_update_aud_by_id(dbc, id, + mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, + "BeefedCafeFaceAcedAddedDecadeFee", true, + "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)), + 0); + db_raw_sql(dbc, "UPDATE auc_3g SET op = 'BeefedCafeFaceAcedAddedDecadeFe'"); + ASSERT_SEL_AUD(imsi0, -EIO, id); + + /* Invalid OPC length */ + comment("Set auth data, 3G only, with invalid OPC length"); + ASSERT_RC(db_subscr_update_aud_by_id(dbc, id, + mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, + "BeefedCafeFaceAcedAddedDecadeFee", false, + "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)), + 0); + db_raw_sql(dbc, "UPDATE auc_3g SET opc = 'BeefedCafeFaceAcedAddedDecadeFe'"); + ASSERT_SEL_AUD(imsi0, -EIO, id); + + + comment("Delete subscriber"); + ASSERT_RC(db_subscr_delete_by_id(dbc, id), 0); + comment_end(); +} + static void test_subscr_sqn() { int64_t id; @@ -900,6 +975,7 @@ test_subscr_create_update_sel_delete(); test_subscr_aud(); + test_subscr_aud_invalid_len(); test_subscr_sqn(); printf("Done\n"); diff --git a/tests/db/db_test.err b/tests/db/db_test.err index 4dc77e8..a7c4cf1 100644 --- a/tests/db/db_test.err +++ b/tests/db/db_test.err @@ -1338,6 +1338,91 @@ ===== test_subscr_aud: SUCCESS +===== test_subscr_aud_invalid_len + +--- Create subscriber + +db_subscr_create(dbc, imsi0, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS) --> 0 + +db_subscr_get_by_imsi(dbc, imsi0, &g_subscr) --> 0 +struct hlr_subscriber { + .id = 1, + .imsi = '123456789000000', +} + + +--- Set auth data, 2G only, with invalid Ki length + +db_subscr_update_aud_by_id(dbc, id, mk_aud_2g(OSMO_AUTH_ALG_COMP128v1, "0123456789abcdef0123456789abcdef")) --> 0 + +raw SQL: UPDATE auc_2g SET ki = '0123456789abcdef0123456789abcde' +sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL) --> SQLITE_OK + +sqlite3_step(stmt) --> SQLITE_DONE + +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -126 +DAUC IMSI='123456789000000': Error reading Ki, expected length 16 but has length 15 +DAUC IMSI='123456789000000': No 3G Auth Data + + + +--- Remove 2G auth data + +db_subscr_update_aud_by_id(dbc, id, mk_aud_2g(OSMO_AUTH_ALG_NONE, NULL)) --> 0 + + +--- Set auth data, 3G only, with invalid K length + +db_subscr_update_aud_by_id(dbc, id, mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, "BeefedCafeFaceAcedAddedDecadeFee", true, "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)) --> 0 + +raw SQL: UPDATE auc_3g SET k = 'C01ffedC1cadaeAc1d1f1edAcac1aB0' +sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL) --> SQLITE_OK + +sqlite3_step(stmt) --> SQLITE_DONE + +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -5 +DAUC IMSI='123456789000000': No 2G Auth Data +DAUC IMSI='123456789000000': Error reading K, expected length 16 but has length 15 + + + +--- Set auth data, 3G only, with invalid OP length + +db_subscr_update_aud_by_id(dbc, id, mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, "BeefedCafeFaceAcedAddedDecadeFee", true, "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)) --> 0 + +raw SQL: UPDATE auc_3g SET op = 'BeefedCafeFaceAcedAddedDecadeFe' +sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL) --> SQLITE_OK + +sqlite3_step(stmt) --> SQLITE_DONE + +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -5 +DAUC IMSI='123456789000000': No 2G Auth Data +DAUC IMSI='123456789000000': Error reading OP, expected length 16 but has length 15 + + + +--- Set auth data, 3G only, with invalid OPC length + +db_subscr_update_aud_by_id(dbc, id, mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, "BeefedCafeFaceAcedAddedDecadeFee", false, "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)) --> 0 + +raw SQL: UPDATE auc_3g SET opc = 'BeefedCafeFaceAcedAddedDecadeFe' +sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL) --> SQLITE_OK + +sqlite3_step(stmt) --> SQLITE_DONE + +db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -5 +DAUC IMSI='123456789000000': No 2G Auth Data +DAUC IMSI='123456789000000': Error reading OPC, expected length 16 but has length 15 + + + +--- Delete subscriber + +db_subscr_delete_by_id(dbc, id) --> 0 + +===== test_subscr_aud_invalid_len: SUCCESS + + ===== test_subscr_sqn --- Set SQN for unknown subscriber -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 Gerrit-Change-Number: 14933 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-CC: fixeria Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 06:42:07 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Jul 2019 06:42:07 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-gbproxy.cfg: don't conflict with osmo-sgsn.cfg Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14957 Change subject: osmo-gbproxy.cfg: don't conflict with osmo-sgsn.cfg ...................................................................... osmo-gbproxy.cfg: don't conflict with osmo-sgsn.cfg Listen on 127.0.0.100 by default, so there is no conflict on 127.0.0.1:23000. This allows starting both services with their default configuration, like we are doing it in theOsmocom-Debian-install-* jenkins jobs. Related: OS#3369 Change-Id: I6e3053de8885a7954296d820c6a069d06276e4df --- M doc/examples/osmo-gbproxy/osmo-gbproxy.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/57/14957/1 diff --git a/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg b/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg index 0c3917a..29f698f 100644 --- a/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg +++ b/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg @@ -22,4 +22,5 @@ timer tns-alive-retries 10 encapsulation framerelay-gre enabled 0 encapsulation framerelay-gre local-ip 0.0.0.0 + encapsulation udp local-ip 127.0.0.100 encapsulation udp local-port 23000 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6e3053de8885a7954296d820c6a069d06276e4df Gerrit-Change-Number: 14957 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 06:44:00 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Jul 2019 06:44:00 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: systemctl status -n 200 Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14958 Change subject: debian-repo-install-test: systemctl status -n 200 ...................................................................... debian-repo-install-test: systemctl status -n 200 Show up to 200 log lines instead of the default (10). Related: OS#3369 Change-Id: Ic72dbf1b4c59a259139187b98e74211d57534dc2 --- M debian-repo-install-test/testdata/repo-install-test.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/58/14958/1 diff --git a/debian-repo-install-test/testdata/repo-install-test.sh b/debian-repo-install-test/testdata/repo-install-test.sh index 338fe8d..4fae488 100755 --- a/debian-repo-install-test/testdata/repo-install-test.sh +++ b/debian-repo-install-test/testdata/repo-install-test.sh @@ -123,7 +123,7 @@ sleep 2 for service in $services_feed; do - if ! systemctl --no-pager -l status $service; then + if ! systemctl --no-pager -l -n 200 status $service; then failed="$failed $service" fi done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic72dbf1b4c59a259139187b98e74211d57534dc2 Gerrit-Change-Number: 14958 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 06:55:40 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Jul 2019 06:55:40 +0000 Subject: Change in ...osmo-ci[master]: jobs: upload to OBS before debian-install test Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14959 Change subject: jobs: upload to OBS before debian-install test ...................................................................... jobs: upload to OBS before debian-install test Make sure that we don't test yesterday's packages. Adjust timers to run the OBS job around 1 o'clock, and the debian-install test around 4 o'clock. Use the H (hash) symbol for minute to spread the load. Change-Id: I503058018172d50e9585d4804dfec1b4ece7644a --- M jobs/osmocom-debian-install.yml M jobs/osmocom-obs.yml 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/59/14959/1 diff --git a/jobs/osmocom-debian-install.yml b/jobs/osmocom-debian-install.yml index 1f6c62a..26b7fa0 100644 --- a/jobs/osmocom-debian-install.yml +++ b/jobs/osmocom-debian-install.yml @@ -35,7 +35,7 @@ git-config-name: 'Jenkins Builder' git-config-email: 'jenkins at osmocom.org' triggers: - - timed: "@midnight" + - timed: "H 04 * * *" # run after osmocom-obs.yml publishers: - email: notify-every-unstable-build: true diff --git a/jobs/osmocom-obs.yml b/jobs/osmocom-obs.yml index 023ab0c..fe03f86 100644 --- a/jobs/osmocom-obs.yml +++ b/jobs/osmocom-obs.yml @@ -35,7 +35,7 @@ git-config-name: 'Jenkins Builder' git-config-email: 'jenkins at osmocom.org' triggers: - - timed: "@midnight" + - timed: "H 01 * * *" # run before osmocom-debian-install.yml publishers: - email: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I503058018172d50e9585d4804dfec1b4ece7644a Gerrit-Change-Number: 14959 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 06:56:06 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Jul 2019 06:56:06 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: systemctl status -n 200 In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14958 ) Change subject: debian-repo-install-test: systemctl status -n 200 ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic72dbf1b4c59a259139187b98e74211d57534dc2 Gerrit-Change-Number: 14958 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 26 Jul 2019 06:56:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 06:56:25 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Jul 2019 06:56:25 +0000 Subject: Change in ...osmo-ci[master]: jobs: upload to OBS before debian-install test In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14959 ) Change subject: jobs: upload to OBS before debian-install test ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I503058018172d50e9585d4804dfec1b4ece7644a Gerrit-Change-Number: 14959 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 26 Jul 2019 06:56:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 06:58:52 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Jul 2019 06:58:52 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-gbproxy.cfg: fix conflict with osmo-sgsn.cfg In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14957 to look at the new patch set (#2). Change subject: osmo-gbproxy.cfg: fix conflict with osmo-sgsn.cfg ...................................................................... osmo-gbproxy.cfg: fix conflict with osmo-sgsn.cfg Listen on 127.0.0.100 by default, so there is no conflict on 127.0.0.1:23000. This allows starting both services with their default configuration, like we are doing it in the Osmocom-Debian-install-* jenkins jobs. Related: OS#3369 Change-Id: I6e3053de8885a7954296d820c6a069d06276e4df --- M doc/examples/osmo-gbproxy/osmo-gbproxy.cfg 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/57/14957/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6e3053de8885a7954296d820c6a069d06276e4df Gerrit-Change-Number: 14957 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 07:51:33 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Fri, 26 Jul 2019 07:51:33 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: pcu: add osmo-pcu.cfg Message-ID: osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14960 Change subject: pcu: add osmo-pcu.cfg ...................................................................... pcu: add osmo-pcu.cfg Copy from docker-playground.git, change IP to 127.0.0.1, log to stderr and adjust pcu-socket patch. Change-Id: Iff3e5e6cf0c608680c8c5f9f83e8bc1032274ea9 --- A pcu/osmo-pcu.cfg 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/60/14960/1 diff --git a/pcu/osmo-pcu.cfg b/pcu/osmo-pcu.cfg new file mode 100644 index 0000000..d6213b5 --- /dev/null +++ b/pcu/osmo-pcu.cfg @@ -0,0 +1,22 @@ +log gsmtap 127.0.0.1 + logging level set-all debug + +log stderr + logging filter all 1 + logging print level 1 + logging print category 1 + logging print category-hex 0 + logging print file basename last + logging print extended-timestamp 1 + logging level set-all debug + +line vty + no login + bind 127.0.0.1 +pcu + flow-control-interval 10 + cs 2 + alloc-algorithm dynamic + alpha 0 + gamma 0 + pcu-socket /tmp/pcu_bts -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14960 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iff3e5e6cf0c608680c8c5f9f83e8bc1032274ea9 Gerrit-Change-Number: 14960 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 09:11:03 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 09:11:03 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: systemctl status -n 200 In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14958 ) Change subject: debian-repo-install-test: systemctl status -n 200 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic72dbf1b4c59a259139187b98e74211d57534dc2 Gerrit-Change-Number: 14958 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 26 Jul 2019 09:11:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 09:11:24 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 09:11:24 +0000 Subject: Change in ...osmo-ci[master]: jobs: upload to OBS before debian-install test In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14959 ) Change subject: jobs: upload to OBS before debian-install test ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I503058018172d50e9585d4804dfec1b4ece7644a Gerrit-Change-Number: 14959 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 26 Jul 2019 09:11:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 09:12:04 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 09:12:04 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-gbproxy.cfg: fix conflict with osmo-sgsn.cfg In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14957 ) Change subject: osmo-gbproxy.cfg: fix conflict with osmo-sgsn.cfg ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6e3053de8885a7954296d820c6a069d06276e4df Gerrit-Change-Number: 14957 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 09:12:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 09:15:13 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 09:15:13 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: pcu: add osmo-pcu.cfg In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14960 ) Change subject: pcu: add osmo-pcu.cfg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14960 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iff3e5e6cf0c608680c8c5f9f83e8bc1032274ea9 Gerrit-Change-Number: 14960 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 09:15:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 09:33:10 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 26 Jul 2019 09:33:10 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix: use reasonable minimum default for C/I Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14961 Change subject: BTS_Tests.ttcn: fix: use reasonable minimum default for C/I ...................................................................... BTS_Tests.ttcn: fix: use reasonable minimum default for C/I Since [1] we additionally filter Access Bursts by the link quality (defined by C/I) in L1SAP, and since [2] we do provide the actual C/I values for osmo-bts-trx, as was received from the transceiver. [1] https://gerrit.osmocom.org/r/I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 [2] https://gerrit.osmocom.org/r/I8d86dec7ebc039cbfd038c4342ff328b11281865 The default minimum C/I for Access Bursts in OsmoBTS is 50 cB, while the TTCN-3 test cases configure fake_trx.py to send 0 cB, so all Access Bursts are getting dropped, as expected. Let's use 60 cB (or 6 dB) by default. This change makes Access Bursts pass again, and thus fixes some broken test cases. Change-Id: Ic345f7995c2553e346590cd851f8857d26e7beb2 --- M bts/BTS_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/14961/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index ebe74c0..d3fb958 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -422,8 +422,8 @@ /* Start with a default moderate timing offset equalling TA=2, and RSSI=-60 */ ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_TIMING(2*256))); ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_RSSI(-60))); - /* FIXME: OsmoBTS may have different AB / NB threshold (see MIN_QUAL_NORM, MIN_QUAL_RACH) */ - ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_CI(0))); + /* OsmoBTS may have different AB / NB threshold (see MIN_QUAL_NORM, MIN_QUAL_RACH) */ + ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_CI(60))); } /* Wait some extra time to make sure the BTS emits a stable carrier. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic345f7995c2553e346590cd851f8857d26e7beb2 Gerrit-Change-Number: 14961 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 09:34:16 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 26 Jul 2019 09:34:16 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix: use reasonable minimum default for C/I In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14961 ) Change subject: BTS_Tests.ttcn: fix: use reasonable minimum default for C/I ...................................................................... Patch Set 1: Verified+1 Makes broken TTCN-3 test cases green. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic345f7995c2553e346590cd851f8857d26e7beb2 Gerrit-Change-Number: 14961 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Jul 2019 09:34:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 09:39:06 2019 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 26 Jul 2019 09:39:06 +0000 Subject: Change in ...osmo-bsc[master]: rest_octets: add Serving Cell Priority Parameters In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, Hoernchen, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/14678 to look at the new patch set (#2). Change subject: rest_octets: add Serving Cell Priority Parameters ...................................................................... rest_octets: add Serving Cell Priority Parameters When we add an EARFCN to to the SI2quater struct we do not add Serving Cell Priority Parameters. This essentially causes to MS to ignore the EARFCN because it is still undefined under which conditions the MS should change to LTE. Related: SYS#4510 Change-Id: I7eaf7de4386fe8aea404e8a187d8a1f5ed596ead --- M src/osmo-bsc/rest_octets.c 1 file changed, 19 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/14678/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7eaf7de4386fe8aea404e8a187d8a1f5ed596ead Gerrit-Change-Number: 14678 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 09:49:48 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 09:49:48 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix: use reasonable minimum default for C/I In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14961 ) Change subject: BTS_Tests.ttcn: fix: use reasonable minimum default for C/I ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic345f7995c2553e346590cd851f8857d26e7beb2 Gerrit-Change-Number: 14961 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Jul 2019 09:49:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 09:50:13 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 09:50:13 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix: use reasonable minimum default for C/I In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14961 ) Change subject: BTS_Tests.ttcn: fix: use reasonable minimum default for C/I ...................................................................... BTS_Tests.ttcn: fix: use reasonable minimum default for C/I Since [1] we additionally filter Access Bursts by the link quality (defined by C/I) in L1SAP, and since [2] we do provide the actual C/I values for osmo-bts-trx, as was received from the transceiver. [1] https://gerrit.osmocom.org/r/I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 [2] https://gerrit.osmocom.org/r/I8d86dec7ebc039cbfd038c4342ff328b11281865 The default minimum C/I for Access Bursts in OsmoBTS is 50 cB, while the TTCN-3 test cases configure fake_trx.py to send 0 cB, so all Access Bursts are getting dropped, as expected. Let's use 60 cB (or 6 dB) by default. This change makes Access Bursts pass again, and thus fixes some broken test cases. Change-Id: Ic345f7995c2553e346590cd851f8857d26e7beb2 --- M bts/BTS_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index ebe74c0..d3fb958 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -422,8 +422,8 @@ /* Start with a default moderate timing offset equalling TA=2, and RSSI=-60 */ ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_TIMING(2*256))); ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_RSSI(-60))); - /* FIXME: OsmoBTS may have different AB / NB threshold (see MIN_QUAL_NORM, MIN_QUAL_RACH) */ - ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_CI(0))); + /* OsmoBTS may have different AB / NB threshold (see MIN_QUAL_NORM, MIN_QUAL_RACH) */ + ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_CI(60))); } /* Wait some extra time to make sure the BTS emits a stable carrier. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic345f7995c2553e346590cd851f8857d26e7beb2 Gerrit-Change-Number: 14961 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 09:50:41 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 09:50:41 +0000 Subject: Change in ...osmo-bsc[master]: rest_octets: add Serving Cell Priority Parameters In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14678 ) Change subject: rest_octets: add Serving Cell Priority Parameters ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7eaf7de4386fe8aea404e8a187d8a1f5ed596ead Gerrit-Change-Number: 14678 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 09:50:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 10:04:22 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 26 Jul 2019 10:04:22 +0000 Subject: Change in ...osmo-sgsn[master]: Add/fix help string for version option Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14962 Change subject: Add/fix help string for version option ...................................................................... Add/fix help string for version option osmo-sgsn was missing the help text of the -V option gb_proxy still thought of itself as OpenBSC Omit the name of the program in the help text to avoid such issues in the future. Related: OS#1720 Change-Id: Ib57694b6bff7c98a269dc4b4dbb7173349a57b81 --- M src/gprs/gb_proxy_main.c M src/gprs/gtphub_main.c M src/gprs/sgsn_main.c 3 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/62/14962/1 diff --git a/src/gprs/gb_proxy_main.c b/src/gprs/gb_proxy_main.c index 19fbbba..1e1aeac 100644 --- a/src/gprs/gb_proxy_main.c +++ b/src/gprs/gb_proxy_main.c @@ -140,7 +140,7 @@ printf(" -c --config-file filename The config file to use [%s]\n", CONFIG_FILE_DEFAULT); printf(" -s --disable-color\n"); printf(" -T --timestamp Prefix every log line with a timestamp\n"); - printf(" -V --version. Print the version of OpenBSC.\n"); + printf(" -V --version. Print the version.\n"); printf(" -e --log-level number. Set a global loglevel.\n"); } diff --git a/src/gprs/gtphub_main.c b/src/gprs/gtphub_main.c index 585a3cb..6d470bd 100644 --- a/src/gprs/gtphub_main.c +++ b/src/gprs/gtphub_main.c @@ -238,7 +238,7 @@ printf(" -e,--log-level Set a global log level.\n"); printf(" -r,--restart-file File for counting restarts [%s].\n", ccfg->restart_counter_file); - printf(" -V,--version Print the version number.\n"); + printf(" -V,--version Print the version.\n"); } static void list_categories(void) diff --git a/src/gprs/sgsn_main.c b/src/gprs/sgsn_main.c index f12270d..3543517 100644 --- a/src/gprs/sgsn_main.c +++ b/src/gprs/sgsn_main.c @@ -209,6 +209,7 @@ { printf("Some useful help...\n"); printf(" -h --help\tthis text\n"); + printf(" -V --version\tPrint the version\n"); printf(" -D --daemonize\tFork the process into a background daemon\n"); printf(" -d option --debug\tenable Debugging\n"); printf(" -s --disable-color\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ib57694b6bff7c98a269dc4b4dbb7173349a57b81 Gerrit-Change-Number: 14962 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 10:07:46 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Fri, 26 Jul 2019 10:07:46 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-sgsn: Fix outdated information in usermanual Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14963 Change subject: osmo-sgsn: Fix outdated information in usermanual ...................................................................... osmo-sgsn: Fix outdated information in usermanual Quite a few features that are listed as not-implemented in the overview section are actually implemented now. Change-Id: I8d499a25293b69babc2aebb2d697438f8ba8141f Related: OS#1720 --- M doc/manuals/chapters/overview.adoc M doc/manuals/chapters/running.adoc 2 files changed, 9 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/63/14963/1 diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc index abc7496..e2c0107 100644 --- a/doc/manuals/chapters/overview.adoc +++ b/doc/manuals/chapters/overview.adoc @@ -74,14 +74,13 @@ non-acknowledged mode, as this is the most common use case in real-world GPRS networks. -Furthermore, it does not support IP header nor payload compression at -this point. Addition of those features is subject to customer demand or -user/customer contributions. +It does support both TCP/IP header compression according to RFC1144 and +payload compression according to V.42bis -The LLC implementation does support LLC encryption. However, as no HLR -access is implemented yet, there is no way to enable/configure -per-subscriber specific keys. - +The LLC implementation does support LLC encryption with ciphers GEA3 and GEA4. +For encryption to work the auth policy needs to be set to remote and the SGSN +connected to an HLR containing the subscriber data including key material. +Other auth policys will not work with encryption. ==== Session Management Implementation @@ -93,11 +92,8 @@ Multiple PDP contexts can be attached by a single MS. -Currently, all PDP contexts are routed to the same GGSN, irrespective of -the APN used/configured in the MS. This is sufficient (and actually -desirable) for small autonomous networks, but of course not suitable for -real networks in roaming scenarios. Please contact sysmocom in case you -require additional features such as DNS-based APN resolving. +Multiple GGSNs can be configured and routing to a GGSN can be configured based +on APN. Dynamic lookup of GGSNs though DNS-based APN resolving is also possible. === Limitations @@ -109,10 +105,5 @@ Known Limitations include: -* No LLC encryption support -* No interface to the OsmoNITB HLR * No paging coordination between SGSN and MSC * No SMS over Ps support -* No IuPS interface for 3G (in progress) -* No IP header compression -* No payload compression diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index d758b28..63c2b27 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -14,7 +14,7 @@ *-h, --help*:: Print a short help message about the supported options *-V, --version*:: - Print the compile-time version number of the OsmoBTS program + Print the compile-time version number of the OsmoSGSN program *-d, --debug 'DBGMASK','DBGLEVELS'*:: Set the log subsystems and levels for logging to stderr. This has mostly been superseded by VTY-based logging configuration, -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8d499a25293b69babc2aebb2d697438f8ba8141f Gerrit-Change-Number: 14963 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 10:55:53 2019 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Fri, 26 Jul 2019 10:55:53 +0000 Subject: Change in ...osmo-bsc[master]: rest_octets: add Serving Cell Priority Parameters In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, Hoernchen, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/14678 to look at the new patch set (#3). Change subject: rest_octets: add Serving Cell Priority Parameters ...................................................................... rest_octets: add Serving Cell Priority Parameters When we add an EARFCN to to the SI2quater struct we do not add Serving Cell Priority Parameters. This essentially causes to MS to ignore the EARFCN because it is still undefined under which conditions the MS should change to LTE. Related: SYS#4510 Change-Id: I7eaf7de4386fe8aea404e8a187d8a1f5ed596ead --- M src/osmo-bsc/rest_octets.c M tests/gsm0408/gsm0408_test.ok 2 files changed, 87 insertions(+), 70 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/14678/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7eaf7de4386fe8aea404e8a187d8a1f5ed596ead Gerrit-Change-Number: 14678 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 11:47:43 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Jul 2019 11:47:43 +0000 Subject: Change in ...osmo-gsm-tester[master]: resources.conf.prod: Use different ARFCN for sysmocell-5k In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14934 ) Change subject: resources.conf.prod: Use different ARFCN for sysmocell-5k ...................................................................... resources.conf.prod: Use different ARFCN for sysmocell-5k Due to a bug in sysmocell-5K's TRX implementation, it may keep polluting the air transmitting after the BTS is disconnected. This could cause interferences with other tests. Correct fix would be to RF lock it after test finishes (through ccli), but let's simply use a different ARFCN for now. Related: OS#4129 Change-Id: I6d5555aa8740b262ee92110987189c076db44f76 --- M example/resources.conf.prod M src/osmo_gsm_tester/resource.py 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/example/resources.conf.prod b/example/resources.conf.prod index 8b498d0..b0a679e 100644 --- a/example/resources.conf.prod +++ b/example/resources.conf.prod @@ -69,6 +69,8 @@ addr: 10.42.42.51 band: GSM-1800 ciphers: [a5_0, a5_1] + trx_list: + - arfcn: 878 osmo_trx: launch_trx: false clock_reference: external diff --git a/src/osmo_gsm_tester/resource.py b/src/osmo_gsm_tester/resource.py index 1b18076..aa41b98 100644 --- a/src/osmo_gsm_tester/resource.py +++ b/src/osmo_gsm_tester/resource.py @@ -60,6 +60,7 @@ 'bts[].num_trx': schema.UINT, 'bts[].max_trx': schema.UINT, 'bts[].trx_list[].addr': schema.IPV4, + 'bts[].trx_list[].arfcn': schema.INT, 'bts[].trx_list[].hw_addr': schema.HWADDR, 'bts[].trx_list[].net_device': schema.STR, 'bts[].trx_list[].nominal_power': schema.UINT, -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/14934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I6d5555aa8740b262ee92110987189c076db44f76 Gerrit-Change-Number: 14934 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 11:48:12 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 26 Jul 2019 11:48:12 +0000 Subject: Change in ...osmo-hlr[master]: src/db.c: integrate SQLite3 with talloc allocator In-Reply-To: References: Message-ID: Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hlr/+/14939 to look at the new patch set (#3). Change subject: src/db.c: integrate SQLite3 with talloc allocator ...................................................................... src/db.c: integrate SQLite3 with talloc allocator This change introduces an optional feature that allows to make SQLite3 use talloc for all internal allocations. This would facilitate finding memleaks. OsmoHLR needs to be configured with '--enable-sqlite-talloc'. full talloc report on 'OsmoHLR' (total 292168 bytes in 449 blocks) struct osmo_gsup_server contains 162 bytes in 3 blocks (ref 0) ... struct db_context contains 288407 bytes in 420 blocks (ref 0) hlr.db contains 7 bytes in 1 blocks (ref 0) SQLite3 contains 288192 bytes in 418 blocks (ref 0) db.c:95 contains 48 bytes in 1 blocks (ref 0) db.c:95 contains 2 bytes in 1 blocks (ref 0) ... Unfortunately, old SQLite3 versions (such as 3.8.2) run out of memory when trying to initialize a new database: DDB ERROR db.c:88 (7) statement aborts at 3: [] DDB ERROR db.c:420 Unable to set Write-Ahead Logging: out of memory DDB ERROR db.c:88 (7) statement aborts at 3: [] DDB ERROR db.c:238 Unable to prepare SQL statement 'SELECT name FROM sqlite_master WHERE type='table' AND name=?' ... I've noticed a huge difference in heap usage footprint compared to generic malloc. At the same time, the recent versions (at least 3.24.0), work just fine. Change-Id: Icfe67ed0f063b63e6794f9516da3003d01cf20a7 --- M configure.ac M src/Makefile.am M src/db.c M src/db.h A src/db_debug.c M tests/db/Makefile.am 6 files changed, 126 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/39/14939/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icfe67ed0f063b63e6794f9516da3003d01cf20a7 Gerrit-Change-Number: 14939 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 11:48:13 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 26 Jul 2019 11:48:13 +0000 Subject: Change in ...osmo-hlr[master]: build: fix mess with 'db_test_SOURCES' and 'db_test_LDADD' Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14964 Change subject: build: fix mess with 'db_test_SOURCES' and 'db_test_LDADD' ...................................................................... build: fix mess with 'db_test_SOURCES' and 'db_test_LDADD' Somehow both 'db_test_SOURCES' and 'db_test_LDADD' ended up in 'src/Makefile.am'. This causes automake / autoconf to complain. Let's get rid of both useless declarations. Furthermore, the actual 'db_test_LDADD' in 'tests/Makefile.am' contained references to the source files from '$(top_srcdir)'. Most likely, the original intention was to depend on the object files in '$(top_builddir)'. Let's also fix this. Change-Id: Ib2e436ed91d9b7551dc5b205329d468c2b0ced04 --- M src/Makefile.am M tests/db/Makefile.am 2 files changed, 4 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/64/14964/1 diff --git a/src/Makefile.am b/src/Makefile.am index 7ee019f..131b44f 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -87,21 +87,6 @@ $(SQLITE3_LIBS) \ $(NULL) -db_test_SOURCES = \ - auc.c \ - db.c \ - db_auc.c \ - db_test.c \ - logging.c \ - rand_fake.c \ - $(NULL) - -db_test_LDADD = \ - $(LIBOSMOCORE_LIBS) \ - $(LIBOSMOGSM_LIBS) \ - $(SQLITE3_LIBS) \ - $(NULL) - osmo_euse_demo_SOURCES = \ osmo-euse-demo.c \ $(NULL) diff --git a/tests/db/Makefile.am b/tests/db/Makefile.am index afda5be..fa925f8 100644 --- a/tests/db/Makefile.am +++ b/tests/db/Makefile.am @@ -26,10 +26,10 @@ $(NULL) db_test_LDADD = \ - $(top_srcdir)/src/db.c \ - $(top_srcdir)/src/db_hlr.c \ - $(top_srcdir)/src/db_auc.c \ - $(top_srcdir)/src/logging.c \ + $(top_builddir)/src/logging.o \ + $(top_builddir)/src/db_auc.o \ + $(top_builddir)/src/db_hlr.o \ + $(top_builddir)/src/db.o \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOABIS_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib2e436ed91d9b7551dc5b205329d468c2b0ced04 Gerrit-Change-Number: 14964 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 11:48:13 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 26 Jul 2019 11:48:13 +0000 Subject: Change in ...osmo-hlr[master]: tests/db_test: close the database when test is finished Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14965 Change subject: tests/db_test: close the database when test is finished ...................................................................... tests/db_test: close the database when test is finished Change-Id: I96fedf9181e89e4d68815b04f494a9c2ecc0e057 --- M tests/db/db_test.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/65/14965/1 diff --git a/tests/db/db_test.c b/tests/db/db_test.c index fdd62c5..57fbf0c 100644 --- a/tests/db/db_test.c +++ b/tests/db/db_test.c @@ -903,6 +903,7 @@ test_subscr_sqn(); printf("Done\n"); + db_close(dbc); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14965 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I96fedf9181e89e4d68815b04f494a9c2ecc0e057 Gerrit-Change-Number: 14965 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 12:02:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 12:02:35 +0000 Subject: Change in ...osmo-bsc[master]: rest_octets: add Serving Cell Priority Parameters In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14678 ) Change subject: rest_octets: add Serving Cell Priority Parameters ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7eaf7de4386fe8aea404e8a187d8a1f5ed596ead Gerrit-Change-Number: 14678 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 12:02:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 12:02:38 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 12:02:38 +0000 Subject: Change in ...osmo-bsc[master]: rest_octets: add Serving Cell Priority Parameters In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14678 ) Change subject: rest_octets: add Serving Cell Priority Parameters ...................................................................... rest_octets: add Serving Cell Priority Parameters When we add an EARFCN to to the SI2quater struct we do not add Serving Cell Priority Parameters. This essentially causes to MS to ignore the EARFCN because it is still undefined under which conditions the MS should change to LTE. Related: SYS#4510 Change-Id: I7eaf7de4386fe8aea404e8a187d8a1f5ed596ead --- M src/osmo-bsc/rest_octets.c M tests/gsm0408/gsm0408_test.ok 2 files changed, 87 insertions(+), 70 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/rest_octets.c b/src/osmo-bsc/rest_octets.c index 9f2b4c0..1d2279b 100644 --- a/src/osmo-bsc/rest_octets.c +++ b/src/osmo-bsc/rest_octets.c @@ -190,8 +190,25 @@ /* Priority and E-UTRAN Parameters Description */ bitvec_set_bit(bv, 1); - /* No Serving Cell Priority Parameters Descr. */ - bitvec_set_bit(bv, 0); + /* Serving Cell Priority Parameters Descr. is Present, + * see also: 3GPP TS 44.018, Table 10.5.2.33b.1 */ + bitvec_set_bit(bv, 1); + + /* GERAN_PRIORITY */ + bitvec_set_uint(bv, 0, 3); + + /* THRESH_Priority_Search */ + bitvec_set_uint(bv, 0, 4); + + /* THRESH_GSM_low */ + bitvec_set_uint(bv, 0, 4); + + /* H_PRIO */ + bitvec_set_uint(bv, 0, 2); + + /* T_Reselection */ + bitvec_set_uint(bv, 0, 2); + /* No 3G Priority Parameters Description */ bitvec_set_bit(bv, 0); /* E-UTRAN Parameters Description */ diff --git a/tests/gsm0408/gsm0408_test.ok b/tests/gsm0408/gsm0408_test.ok index b083f08..e3290b5 100644 --- a/tests/gsm0408/gsm0408_test.ok +++ b/tests/gsm0408/gsm0408_test.ok @@ -71,25 +71,25 @@ generating SI2quater for 0 EARFCNs and 0 UARFCNs... generated invalid SI2quater [00/00]: [23] 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 added EARFCN 1917 - generating SI2quater for 1 EARFCNs and 0 UARFCNs... -generated valid SI2quater [00/00]: [23] 59 06 07 40 00 04 86 59 83 be e8 50 0b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b +generated valid SI2quater [00/00]: [23] 59 06 07 40 00 04 87 00 00 b3 07 7d d0 a0 2b 2b 2b 2b 2b 2b 2b 2b 2b removed EARFCN 1917 - generating SI2quater for 0 EARFCNs and 0 UARFCNs... -generated invalid SI2quater [00/00]: [23] 59 06 07 40 00 04 86 59 83 be e8 50 0b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b +generated invalid SI2quater [00/00]: [23] 59 06 07 40 00 04 87 00 00 b3 07 7d d0 a0 2b 2b 2b 2b 2b 2b 2b 2b 2b added EARFCN 1917 - generating SI2quater for 1 EARFCNs and 0 UARFCNs... -generated valid SI2quater [00/00]: [23] 59 06 07 40 00 04 86 59 83 be c8 50 0b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b +generated valid SI2quater [00/00]: [23] 59 06 07 40 00 04 87 00 00 b3 07 7d 90 a0 2b 2b 2b 2b 2b 2b 2b 2b 2b added EARFCN 1932 - generating SI2quater for 2 EARFCNs and 0 UARFCNs... -generated valid SI2quater [00/00]: [23] 59 06 07 40 00 04 86 59 83 be cc 1e 30 14 03 2b 2b 2b 2b 2b 2b 2b 2b +generated valid SI2quater [00/00]: [23] 59 06 07 40 00 04 87 00 00 b3 07 7d 98 3c 60 28 0b 2b 2b 2b 2b 2b 2b added EARFCN 1937 - generating SI2quater for 3 EARFCNs and 0 UARFCNs... -generated valid SI2quater [00/00]: [23] 59 06 07 40 00 04 86 59 83 be cc 1e 31 07 91 a0 a0 2b 2b 2b 2b 2b 2b +generated valid SI2quater [00/00]: [23] 59 06 07 40 00 04 87 00 00 b3 07 7d 98 3c 62 0f 23 41 40 2b 2b 2b 2b added EARFCN 1945 - generating SI2quater for 4 EARFCNs and 0 UARFCNs... -generated valid SI2quater [00/00]: [23] 59 06 07 40 00 04 86 59 83 be cc 1e 31 07 91 a8 3c c8 28 0b 2b 2b 2b +generated valid SI2quater [00/00]: [23] 59 06 07 40 00 04 87 00 00 b3 07 7d 98 3c 62 0f 23 50 79 90 50 0b 2b added EARFCN 1965 - generating SI2quater for 5 EARFCNs and 0 UARFCNs... -generated valid SI2quater [00/00]: [23] 59 06 07 40 00 04 86 59 83 be cc 1e 31 07 91 a8 3c ca 0f 5a 0a 03 2b +generated valid SI2quater [00/00]: [23] 59 06 07 40 00 04 87 00 00 b3 07 7d 98 3c 62 0f 23 50 79 94 1e b4 14 added EARFCN 1967 - generating SI2quater for 6 EARFCNs and 0 UARFCNs... -generated valid SI2quater [00/01]: [23] 59 06 07 40 20 04 86 59 83 be cc 1e 31 07 91 a8 3c ca 0f 5a 0a 03 2b -generated valid SI2quater [01/01]: [23] 59 06 07 42 20 04 86 59 83 d7 e0 50 0b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b +generated valid SI2quater [00/01]: [23] 59 06 07 40 20 04 87 00 00 b3 07 7d 98 3c 62 0f 23 50 79 94 1e b4 14 +generated valid SI2quater [01/01]: [23] 59 06 07 42 20 04 87 00 00 b3 07 af c0 a0 2b 2b 2b 2b 2b 2b 2b 2b 2b added EARFCN 1982 - generating SI2quater for 7 EARFCNs and 0 UARFCNs... -generated valid SI2quater [00/01]: [23] 59 06 07 40 20 04 86 59 83 be cc 1e 31 07 91 a8 3c ca 0f 5a 0a 03 2b -generated valid SI2quater [01/01]: [23] 59 06 07 42 20 04 86 59 83 d7 e4 1e fa c2 80 2b 2b 2b 2b 2b 2b 2b 2b +generated valid SI2quater [00/01]: [23] 59 06 07 40 20 04 87 00 00 b3 07 7d 98 3c 62 0f 23 50 79 94 1e b4 14 +generated valid SI2quater [01/01]: [23] 59 06 07 42 20 04 87 00 00 b3 07 af c8 3d f5 85 01 2b 2b 2b 2b 2b 2b BTS deallocated OK in test_si2q_e() BTS allocation OK in test_si2q_u() Testing SYSINFO_TYPE_2quater UARFCN generation: @@ -138,77 +138,77 @@ BTS allocation OK in test_si2q_long() Testing SYSINFO_TYPE_2quater combined EARFCN & UARFCN generation: generating SI2quater for 17 EARFCNs and 1 UARFCNs... -generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 0c 1a 10 99 66 0f 04 83 c1 1c bb 2b 03 2b 2b -generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 86 59 83 c2 6c 1e 0f 60 f0 bb 08 3f d7 2e ca c1 2b -generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 86 59 84 20 64 21 06 e1 08 55 08 53 d7 2e ca c1 2b -generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 86 59 84 2a 64 21 56 e1 0a d5 08 49 d7 2e ca c1 2b -generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 86 59 84 25 64 21 2e e1 09 94 e5 d9 58 2b 2b 2b 2b +generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 0c 1a 10 9c 00 02 cc 1e 09 07 82 39 76 56 0b +generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 87 00 00 b3 07 84 d8 3c 1e c1 e1 76 10 7f ae 5d 95 +generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 87 00 00 b3 08 40 c8 42 0d c2 10 aa 10 a7 ae 5d 95 +generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 87 00 00 b3 08 54 c8 42 ad c2 15 aa 10 93 ae 5d 95 +generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 87 00 00 b3 08 4a c8 42 5d c2 13 29 cb b2 b0 2b 2b generating SI2quater for 17 EARFCNs and 2 UARFCNs... -generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 14 4d e7 00 44 b3 07 82 41 e0 8e 5d 95 83 2b -generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 86 59 83 c2 6c 1e 0f 60 f0 bb 08 3f d7 2e ca c1 2b -generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 86 59 84 20 64 21 06 e1 08 55 08 53 d7 2e ca c1 2b -generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 86 59 84 2a 64 21 56 e1 0a d5 08 49 d7 2e ca c1 2b -generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 86 59 84 25 64 21 2e e1 09 94 e5 d9 58 2b 2b 2b 2b +generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 14 4d e7 00 46 00 01 66 0f 04 83 c1 1c bb 2b +generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 87 00 00 b3 07 84 d8 3c 1e c1 e1 76 10 7f ae 5d 95 +generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 87 00 00 b3 08 40 c8 42 0d c2 10 aa 10 a7 ae 5d 95 +generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 87 00 00 b3 08 54 c8 42 ad c2 15 aa 10 93 ae 5d 95 +generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 87 00 00 b3 08 4a c8 42 5d c2 13 29 cb b2 b0 2b 2b generating SI2quater for 17 EARFCNs and 3 UARFCNs... -generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 1c 4d e7 03 04 86 59 83 c1 20 f0 47 2e ca c1 -generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 86 59 83 c2 6c 1e 0f 60 f0 bb 08 3f d7 2e ca c1 2b -generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 86 59 84 20 64 21 06 e1 08 55 08 53 d7 2e ca c1 2b -generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 86 59 84 2a 64 21 56 e1 0a d5 08 49 d7 2e ca c1 2b -generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 86 59 84 25 64 21 2e e1 09 94 e5 d9 58 2b 2b 2b 2b +generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 1c 4d e7 03 04 87 00 00 b3 07 82 41 e0 8e 5d +generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 87 00 00 b3 07 84 d8 3c 1e c1 e1 76 10 7f ae 5d 95 +generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 87 00 00 b3 08 40 c8 42 0d c2 10 aa 10 a7 ae 5d 95 +generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 87 00 00 b3 08 54 c8 42 ad c2 15 aa 10 93 ae 5d 95 +generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 87 00 00 b3 08 4a c8 42 5d c2 13 29 cb b2 b0 2b 2b generating SI2quater for 17 EARFCNs and 4 UARFCNs... -generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 24 59 fa 26 73 84 86 59 83 c1 1c bb 2b 03 2b -generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 86 59 83 c1 20 f0 9b 07 83 d8 3c 2e b9 76 56 0b 2b -generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 86 59 84 1f ec 21 03 21 08 37 08 42 a7 2e ca c1 2b -generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 86 59 84 29 ec 21 53 21 0a b7 08 56 a7 2e ca c1 2b -generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 86 59 84 24 ec 21 2b 21 09 77 08 4c a7 2e ca c1 2b +generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 24 59 fa 26 73 84 87 00 00 b3 07 82 39 76 56 +generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 87 00 00 b3 07 82 41 e1 36 0f 07 b0 78 5d 72 ec ac +generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 87 00 00 b3 08 3f d8 42 06 42 10 6e 10 85 4e 5d 95 +generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 87 00 00 b3 08 53 d8 42 a6 42 15 6e 10 ad 4e 5d 95 +generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 87 00 00 b3 08 49 d8 42 56 42 12 ee 10 99 4e 5d 95 generating SI2quater for 17 EARFCNs and 5 UARFCNs... -generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 2c 59 fa 30 73 f6 04 86 59 83 c1 1c bb 2b 03 -generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 86 59 83 c1 20 f0 9b 07 83 d8 3c 2e b9 76 56 0b 2b -generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 86 59 84 1f ec 21 03 21 08 37 08 42 a7 2e ca c1 2b -generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 86 59 84 29 ec 21 53 21 0a b7 08 56 a7 2e ca c1 2b -generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 86 59 84 24 ec 21 2b 21 09 77 08 4c a7 2e ca c1 2b +generated valid SI2quater [00/04]: [23] 59 06 07 40 80 25 0f 70 2c 59 fa 30 73 f6 04 87 00 00 b3 07 82 39 76 +generated valid SI2quater [01/04]: [23] 59 06 07 42 80 04 87 00 00 b3 07 82 41 e1 36 0f 07 b0 78 5d 72 ec ac +generated valid SI2quater [02/04]: [23] 59 06 07 44 80 04 87 00 00 b3 08 3f d8 42 06 42 10 6e 10 85 4e 5d 95 +generated valid SI2quater [03/04]: [23] 59 06 07 46 80 04 87 00 00 b3 08 53 d8 42 a6 42 15 6e 10 ad 4e 5d 95 +generated valid SI2quater [04/04]: [23] 59 06 07 48 80 04 87 00 00 b3 08 49 d8 42 56 42 12 ee 10 99 4e 5d 95 generating SI2quater for 17 EARFCNs and 6 UARFCNs... -generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 34 f1 ae 15 f3 f4 83 04 86 59 72 ec ac 0b 2b -generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 86 59 83 c1 20 f0 48 3c 26 c1 e0 f5 cb b2 b0 2b 2b -generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 86 59 83 c2 ec 20 ff 61 08 19 08 41 b7 2e ca c1 2b -generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 86 59 84 21 54 21 4f 61 0a 99 08 55 b7 2e ca c1 2b -generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 86 59 84 2b 54 21 27 61 09 59 08 4b b7 2e ca c1 2b -generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 86 59 84 26 53 97 65 60 2b 2b 2b 2b 2b 2b 2b 2b 2b +generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 34 f1 ae 15 f3 f4 83 04 87 00 00 b2 e5 d9 58 +generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 87 00 00 b3 07 82 41 e0 90 78 4d 83 c1 eb 97 65 60 +generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 87 00 00 b3 07 85 d8 41 fe c2 10 32 10 83 6e 5d 95 +generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 87 00 00 b3 08 42 a8 42 9e c2 15 32 10 ab 6e 5d 95 +generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b2 10 97 6e 5d 95 +generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 87 00 00 b3 08 4c a7 2e ca c1 2b 2b 2b 2b 2b 2b 2b generating SI2quater for 17 EARFCNs and 7 UARFCNs... -generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 3c f1 ae 15 f3 f4 83 01 84 86 59 72 ec ac 0b -generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 86 59 83 c1 20 f0 48 3c 26 c1 e0 f5 cb b2 b0 2b 2b -generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 86 59 83 c2 ec 20 ff 61 08 19 08 41 b7 2e ca c1 2b -generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 86 59 84 21 54 21 4f 61 0a 99 08 55 b7 2e ca c1 2b -generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 86 59 84 2b 54 21 27 61 09 59 08 4b b7 2e ca c1 2b -generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 86 59 84 26 53 97 65 60 2b 2b 2b 2b 2b 2b 2b 2b 2b +generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 3c f1 ae 15 f3 f4 83 01 84 87 00 00 b2 e5 d9 +generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 87 00 00 b3 07 82 41 e0 90 78 4d 83 c1 eb 97 65 60 +generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 87 00 00 b3 07 85 d8 41 fe c2 10 32 10 83 6e 5d 95 +generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 87 00 00 b3 08 42 a8 42 9e c2 15 32 10 ab 6e 5d 95 +generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b2 10 97 6e 5d 95 +generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 87 00 00 b3 08 4c a7 2e ca c1 2b 2b 2b 2b 2b 2b 2b generating SI2quater for 17 EARFCNs and 8 UARFCNs... generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 45 19 a0 0d 7d 7e a6 19 e7 0b 2b 2b 2b 2b 2b -generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 86 59 83 c1 20 f0 48 3c 26 c1 e0 f5 cb b2 b0 2b 2b -generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 86 59 83 c2 ec 20 ff 61 08 19 08 41 b7 2e ca c1 2b -generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 86 59 84 21 54 21 4f 61 0a 99 08 55 b7 2e ca c1 2b -generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 86 59 84 2b 54 21 27 61 09 59 08 4b b7 2e ca c1 2b -generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 86 59 84 26 53 97 65 60 2b 2b 2b 2b 2b 2b 2b 2b 2b +generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 87 00 00 b3 07 82 41 e0 90 78 4d 83 c1 eb 97 65 60 +generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 87 00 00 b3 07 85 d8 41 fe c2 10 32 10 83 6e 5d 95 +generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 87 00 00 b3 08 42 a8 42 9e c2 15 32 10 ab 6e 5d 95 +generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b2 10 97 6e 5d 95 +generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 87 00 00 b3 08 4c a7 2e ca c1 2b 2b 2b 2b 2b 2b 2b generating SI2quater for 17 EARFCNs and 9 UARFCNs... generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 4d 19 a0 26 fd 66 a6 03 e7 fa 0b 2b 2b 2b 2b -generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 86 59 83 c1 20 f0 48 3c 26 c1 e0 f5 cb b2 b0 2b 2b -generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 86 59 83 c2 ec 20 ff 61 08 19 08 41 b7 2e ca c1 2b -generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 86 59 84 21 54 21 4f 61 0a 99 08 55 b7 2e ca c1 2b -generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 86 59 84 2b 54 21 27 61 09 59 08 4b b7 2e ca c1 2b -generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 86 59 84 26 53 97 65 60 2b 2b 2b 2b 2b 2b 2b 2b 2b +generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 87 00 00 b3 07 82 41 e0 90 78 4d 83 c1 eb 97 65 60 +generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 87 00 00 b3 07 85 d8 41 fe c2 10 32 10 83 6e 5d 95 +generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 87 00 00 b3 08 42 a8 42 9e c2 15 32 10 ab 6e 5d 95 +generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b2 10 97 6e 5d 95 +generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 87 00 00 b3 08 4c a7 2e ca c1 2b 2b 2b 2b 2b 2b 2b generating SI2quater for 17 EARFCNs and 10 UARFCNs... generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 55 47 89 1e fd 7c b0 00 e7 9b b0 2b 2b 2b 2b -generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 86 59 83 c1 20 f0 48 3c 26 c1 e0 f5 cb b2 b0 2b 2b -generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 86 59 83 c2 ec 20 ff 61 08 19 08 41 b7 2e ca c1 2b -generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 86 59 84 21 54 21 4f 61 0a 99 08 55 b7 2e ca c1 2b -generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 86 59 84 2b 54 21 27 61 09 59 08 4b b7 2e ca c1 2b -generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 86 59 84 26 53 97 65 60 2b 2b 2b 2b 2b 2b 2b 2b 2b +generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 87 00 00 b3 07 82 41 e0 90 78 4d 83 c1 eb 97 65 60 +generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 87 00 00 b3 07 85 d8 41 fe c2 10 32 10 83 6e 5d 95 +generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 87 00 00 b3 08 42 a8 42 9e c2 15 32 10 ab 6e 5d 95 +generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b2 10 97 6e 5d 95 +generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 87 00 00 b3 08 4c a7 2e ca c1 2b 2b 2b 2b 2b 2b 2b generating SI2quater for 17 EARFCNs and 11 UARFCNs... generated valid SI2quater [00/05]: [23] 59 06 07 40 a0 25 0f 70 5d 47 89 1e fd 7c b0 01 67 9b b3 f8 2b 2b 2b -generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 86 59 83 c1 20 f0 48 3c 26 c1 e0 f5 cb b2 b0 2b 2b -generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 86 59 83 c2 ec 20 ff 61 08 19 08 41 b7 2e ca c1 2b -generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 86 59 84 21 54 21 4f 61 0a 99 08 55 b7 2e ca c1 2b -generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 86 59 84 2b 54 21 27 61 09 59 08 4b b7 2e ca c1 2b -generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 86 59 84 26 53 97 65 60 2b 2b 2b 2b 2b 2b 2b 2b 2b +generated valid SI2quater [01/05]: [23] 59 06 07 42 a0 04 87 00 00 b3 07 82 41 e0 90 78 4d 83 c1 eb 97 65 60 +generated valid SI2quater [02/05]: [23] 59 06 07 44 a0 04 87 00 00 b3 07 85 d8 41 fe c2 10 32 10 83 6e 5d 95 +generated valid SI2quater [03/05]: [23] 59 06 07 46 a0 04 87 00 00 b3 08 42 a8 42 9e c2 15 32 10 ab 6e 5d 95 +generated valid SI2quater [04/05]: [23] 59 06 07 48 a0 04 87 00 00 b3 08 56 a8 42 4e c2 12 b2 10 97 6e 5d 95 +generated valid SI2quater [05/05]: [23] 59 06 07 4a a0 04 87 00 00 b3 08 4c a7 2e ca c1 2b 2b 2b 2b 2b 2b 2b BTS deallocated OK in test_si2q_long() BTS allocation OK in test_si_ba_ind() Testing if BA-IND is set as expected in SI2xxx and SI5xxx -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14678 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7eaf7de4386fe8aea404e8a187d8a1f5ed596ead Gerrit-Change-Number: 14678 Gerrit-PatchSet: 4 Gerrit-Owner: dexter Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 12:10:40 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 12:10:40 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-sgsn: Fix outdated information in usermanual In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14963 ) Change subject: osmo-sgsn: Fix outdated information in usermanual ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8d499a25293b69babc2aebb2d697438f8ba8141f Gerrit-Change-Number: 14963 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Jul 2019 12:10:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 12:11:01 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 12:11:01 +0000 Subject: Change in ...osmo-sgsn[master]: Add/fix help string for version option In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14962 ) Change subject: Add/fix help string for version option ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ib57694b6bff7c98a269dc4b4dbb7173349a57b81 Gerrit-Change-Number: 14962 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Jul 2019 12:11:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 12:11:04 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 12:11:04 +0000 Subject: Change in ...osmo-sgsn[master]: Add/fix help string for version option In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14962 ) Change subject: Add/fix help string for version option ...................................................................... Add/fix help string for version option osmo-sgsn was missing the help text of the -V option gb_proxy still thought of itself as OpenBSC Omit the name of the program in the help text to avoid such issues in the future. Related: OS#1720 Change-Id: Ib57694b6bff7c98a269dc4b4dbb7173349a57b81 --- M src/gprs/gb_proxy_main.c M src/gprs/gtphub_main.c M src/gprs/sgsn_main.c 3 files changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/gprs/gb_proxy_main.c b/src/gprs/gb_proxy_main.c index 19fbbba..1e1aeac 100644 --- a/src/gprs/gb_proxy_main.c +++ b/src/gprs/gb_proxy_main.c @@ -140,7 +140,7 @@ printf(" -c --config-file filename The config file to use [%s]\n", CONFIG_FILE_DEFAULT); printf(" -s --disable-color\n"); printf(" -T --timestamp Prefix every log line with a timestamp\n"); - printf(" -V --version. Print the version of OpenBSC.\n"); + printf(" -V --version. Print the version.\n"); printf(" -e --log-level number. Set a global loglevel.\n"); } diff --git a/src/gprs/gtphub_main.c b/src/gprs/gtphub_main.c index 585a3cb..6d470bd 100644 --- a/src/gprs/gtphub_main.c +++ b/src/gprs/gtphub_main.c @@ -238,7 +238,7 @@ printf(" -e,--log-level Set a global log level.\n"); printf(" -r,--restart-file File for counting restarts [%s].\n", ccfg->restart_counter_file); - printf(" -V,--version Print the version number.\n"); + printf(" -V,--version Print the version.\n"); } static void list_categories(void) diff --git a/src/gprs/sgsn_main.c b/src/gprs/sgsn_main.c index f12270d..3543517 100644 --- a/src/gprs/sgsn_main.c +++ b/src/gprs/sgsn_main.c @@ -209,6 +209,7 @@ { printf("Some useful help...\n"); printf(" -h --help\tthis text\n"); + printf(" -V --version\tPrint the version\n"); printf(" -D --daemonize\tFork the process into a background daemon\n"); printf(" -d option --debug\tenable Debugging\n"); printf(" -s --disable-color\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ib57694b6bff7c98a269dc4b4dbb7173349a57b81 Gerrit-Change-Number: 14962 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 12:11:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 12:11:05 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-sgsn: Fix outdated information in usermanual In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14963 ) Change subject: osmo-sgsn: Fix outdated information in usermanual ...................................................................... osmo-sgsn: Fix outdated information in usermanual Quite a few features that are listed as not-implemented in the overview section are actually implemented now. Change-Id: I8d499a25293b69babc2aebb2d697438f8ba8141f Related: OS#1720 --- M doc/manuals/chapters/overview.adoc M doc/manuals/chapters/running.adoc 2 files changed, 9 insertions(+), 18 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc index abc7496..e2c0107 100644 --- a/doc/manuals/chapters/overview.adoc +++ b/doc/manuals/chapters/overview.adoc @@ -74,14 +74,13 @@ non-acknowledged mode, as this is the most common use case in real-world GPRS networks. -Furthermore, it does not support IP header nor payload compression at -this point. Addition of those features is subject to customer demand or -user/customer contributions. +It does support both TCP/IP header compression according to RFC1144 and +payload compression according to V.42bis -The LLC implementation does support LLC encryption. However, as no HLR -access is implemented yet, there is no way to enable/configure -per-subscriber specific keys. - +The LLC implementation does support LLC encryption with ciphers GEA3 and GEA4. +For encryption to work the auth policy needs to be set to remote and the SGSN +connected to an HLR containing the subscriber data including key material. +Other auth policys will not work with encryption. ==== Session Management Implementation @@ -93,11 +92,8 @@ Multiple PDP contexts can be attached by a single MS. -Currently, all PDP contexts are routed to the same GGSN, irrespective of -the APN used/configured in the MS. This is sufficient (and actually -desirable) for small autonomous networks, but of course not suitable for -real networks in roaming scenarios. Please contact sysmocom in case you -require additional features such as DNS-based APN resolving. +Multiple GGSNs can be configured and routing to a GGSN can be configured based +on APN. Dynamic lookup of GGSNs though DNS-based APN resolving is also possible. === Limitations @@ -109,10 +105,5 @@ Known Limitations include: -* No LLC encryption support -* No interface to the OsmoNITB HLR * No paging coordination between SGSN and MSC * No SMS over Ps support -* No IuPS interface for 3G (in progress) -* No IP header compression -* No payload compression diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index d758b28..63c2b27 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -14,7 +14,7 @@ *-h, --help*:: Print a short help message about the supported options *-V, --version*:: - Print the compile-time version number of the OsmoBTS program + Print the compile-time version number of the OsmoSGSN program *-d, --debug 'DBGMASK','DBGLEVELS'*:: Set the log subsystems and levels for logging to stderr. This has mostly been superseded by VTY-based logging configuration, -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14963 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8d499a25293b69babc2aebb2d697438f8ba8141f Gerrit-Change-Number: 14963 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 12:12:26 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 12:12:26 +0000 Subject: Change in ...osmo-hlr[master]: tests/db_test: close the database when test is finished In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14965 ) Change subject: tests/db_test: close the database when test is finished ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14965 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I96fedf9181e89e4d68815b04f494a9c2ecc0e057 Gerrit-Change-Number: 14965 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 12:12:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 12:13:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 12:13:22 +0000 Subject: Change in ...osmo-hlr[master]: build: fix mess with 'db_test_SOURCES' and 'db_test_LDADD' In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14964 ) Change subject: build: fix mess with 'db_test_SOURCES' and 'db_test_LDADD' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib2e436ed91d9b7551dc5b205329d468c2b0ced04 Gerrit-Change-Number: 14964 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 12:13:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 12:13:59 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Fri, 26 Jul 2019 12:13:59 +0000 Subject: Change in ...osmo-hlr[master]: src/db.c: integrate SQLite3 with talloc allocator In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14939 ) Change subject: src/db.c: integrate SQLite3 with talloc allocator ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icfe67ed0f063b63e6794f9516da3003d01cf20a7 Gerrit-Change-Number: 14939 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 26 Jul 2019 12:13:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 12:16:14 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Jul 2019 12:16:14 +0000 Subject: Change in ...osmo-mgw[master]: Fix return variable of strtoul() Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14966 Change subject: Fix return variable of strtoul() ...................................................................... Fix return variable of strtoul() Return variable specified by strtoul() is "unsigned long int". If "unsigned int" is used, according to Coverity the return value can never be ULONG_MAX: CID 202173: Integer handling issues (CONSTANT_EXPRESSION_RESULT) "pt == 18446744073709551615UL /* 9223372036854775807L * 2UL + 1UL */" is always false regardless of the values of its operands. This occurs as the logical second operand of "&&". Fixes: c5c1430a1c00ad86855ffff3df3f106bb2bce1d5 ("Catch unsigned integer MGCP parsing errors with strtoul") Fixes: Coverity CID#202172 FIxes: Coverity CID#202173 Change-Id: Ice9eee6a252fab73dbab5ebf3cfc83c1b354fd08 --- M src/libosmo-mgcp-client/mgcp_client.c M src/libosmo-mgcp/mgcp_sdp.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/66/14966/1 diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 910289e..5af441c 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -268,7 +268,7 @@ { char *pt_str; char *pt_end; - unsigned int pt; + unsigned long int pt; unsigned int count = 0; unsigned int i; diff --git a/src/libosmo-mgcp/mgcp_sdp.c b/src/libosmo-mgcp/mgcp_sdp.c index 56fc611..64d038d 100644 --- a/src/libosmo-mgcp/mgcp_sdp.c +++ b/src/libosmo-mgcp/mgcp_sdp.c @@ -132,7 +132,7 @@ char *str_ptr; char *pt_str; char *pt_end; - unsigned int pt; + unsigned long int pt; unsigned int count = 0; unsigned int i; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ice9eee6a252fab73dbab5ebf3cfc83c1b354fd08 Gerrit-Change-Number: 14966 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 12:34:12 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 26 Jul 2019 12:34:12 +0000 Subject: Change in ...gr-gsm[master]: Add control channels demappers tests In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14945 ) Change subject: Add control channels demappers tests ...................................................................... Patch Set 1: (6 comments) https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py File python/qa_gsm_bcch_ccch_demapper.py: https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py at 6 PS1, Line 6: ws https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py at 142 PS1, Line 142: b[ 0], b[ 1], b[ 2], b[ 3], Any benefits of having such sequential notation? This could be also done in an imperative way: a = list(dst.get_burst_data()) self.assertEqual(len(a), 108) for i in range(108): self.assertEqual(a[i], b[i]) https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py at 172 PS1, Line 172: assertEqual Same here, and even simpler. https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py at 203 PS1, Line 203: assertEqual Same here. https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_demapper_data.py File python/qa_gsm_demapper_data.py: https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_demapper_data.py at 24 PS1, Line 24: bursts This list can also be generated using a for loop. https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_demapper_data.py at 150 PS1, Line 150: timeslots Same here, just [0] * X, where X == len(timeslots). -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: I33b0948832a0c2506bffd389cc134c3236c74d27 Gerrit-Change-Number: 14945 Gerrit-PatchSet: 1 Gerrit-Owner: vvvelichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 12:34:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 12:35:22 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 26 Jul 2019 12:35:22 +0000 Subject: Change in ...gr-gsm[master]: Fix sub_slot assignment in the universal_ctrl_chans_demapper block In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14946 ) Change subject: Fix sub_slot assignment in the universal_ctrl_chans_demapper block ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14946 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: Idc63407694fd1f7be962ab630d4e8c13b4a5d348 Gerrit-Change-Number: 14946 Gerrit-PatchSet: 1 Gerrit-Owner: vvvelichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 12:35:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 12:39:23 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Fri, 26 Jul 2019 12:39:23 +0000 Subject: Change in ...gr-gsm[master]: Fix uplink sub_slot and sub_types assignment in the sdcch4 and bcch_c... In-Reply-To: References: Message-ID: fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14948 ) Change subject: Fix uplink sub_slot and sub_types assignment in the sdcch4 and bcch_ccch demappers blocks ...................................................................... Patch Set 1: In general, I am find with the proposed patch set. But instead of having magic calculations in the original code, I would rather follow the way of OsmoBTS, which I followed in trxcon: https://git.osmocom.org/osmocom-bb/tree/src/host/trxcon/sched_mframe.c Ideally, we need to share this code somewhere in libosmogsm, so then it can be used by gr-gsm, and even by OsmoTRX. -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: Ia6b3070c1085bcdda6d98fd94a89c6e0982e2aec Gerrit-Change-Number: 14948 Gerrit-PatchSet: 1 Gerrit-Owner: vvvelichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 26 Jul 2019 12:39:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 13:06:08 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Jul 2019 13:06:08 +0000 Subject: Change in ...osmo-gsm-manuals[master]: mgcp_extension_osmux.adoc: Workaround make check failures Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14967 Change subject: mgcp_extension_osmux.adoc: Workaround make check failures ...................................................................... mgcp_extension_osmux.adoc: Workaround make check failures It seems make check fails on some asciidoc version due to title level inconsistencies. Have alook at the redmine Osmocom ticket for more information. Related: OS#4131 Change-Id: I57ab562d5976b400085e8a38224b7d28179fc8ef --- M common/chapters/osmux/mgcp_extension_osmux.adoc M common/chapters/osmux/osmux.adoc 2 files changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/67/14967/1 diff --git a/common/chapters/osmux/mgcp_extension_osmux.adoc b/common/chapters/osmux/mgcp_extension_osmux.adoc index c12e9ef..7d28189 100644 --- a/common/chapters/osmux/mgcp_extension_osmux.adoc +++ b/common/chapters/osmux/mgcp_extension_osmux.adoc @@ -1,11 +1,11 @@ [[mgcp-extension-osmux]] -=== Osmux and MGCP +== Osmux and MGCP `X-Osmux` indicates to OsmoMGW that a given connection of an `rtpbridge` endpoint has to be configured in order to handle Osmux frames instead of RTP messages on the data plane. -==== `X-Osmux` Format +=== `X-Osmux` Format The value part of `X-Osmux` must be one integer in range [0..255], or alternatively only on request messages, an asterisk (*) if the value is not yet @@ -35,7 +35,7 @@ X-Osmux: * ---- -==== `X-Osmux` Considerations +=== `X-Osmux` Considerations If the MGCP client is willing to use Osmux for a given connection, it shall specify so during `CRCX` time, and not later. If at `CRCX` time the MGCP client @@ -89,7 +89,7 @@ a=ptime:20 ---- -==== `X-Osmux` Support +=== `X-Osmux` Support `X-Osmux` is known to be supported by OsmoMGW on the MGCP server side, and by OsmoBSC as well as OsmoMSC on the MGCP client side (through libosmo-mgcp-cli). diff --git a/common/chapters/osmux/osmux.adoc b/common/chapters/osmux/osmux.adoc index 5e53b60..5b05abc 100644 --- a/common/chapters/osmux/osmux.adoc +++ b/common/chapters/osmux/osmux.adoc @@ -138,4 +138,6 @@ include::mo_call_osmux_sccplite_nat.msc[] ---- +:leveloffset: 1 include::mgcp_extension_osmux.adoc[] +:leveloffset: 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I57ab562d5976b400085e8a38224b7d28179fc8ef Gerrit-Change-Number: 14967 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 14:01:22 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Fri, 26 Jul 2019 14:01:22 +0000 Subject: Change in ...osmo-gsm-manuals[master]: mgcp_extension_osmux.adoc: Workaround make check failures In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14967 to look at the new patch set (#2). Change subject: mgcp_extension_osmux.adoc: Workaround make check failures ...................................................................... mgcp_extension_osmux.adoc: Workaround make check failures It seems make check fails on some asciidoc version due to title level inconsistencies. Have alook at the redmine Osmocom ticket for more information. Related: OS#4131 Change-Id: I57ab562d5976b400085e8a38224b7d28179fc8ef --- M common/chapters/osmux/mgcp_extension_osmux.adoc M common/chapters/osmux/osmux.adoc 2 files changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/67/14967/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I57ab562d5976b400085e8a38224b7d28179fc8ef Gerrit-Change-Number: 14967 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 16:39:35 2019 From: gerrit-no-reply at lists.osmocom.org (roh) Date: Fri, 26 Jul 2019 16:39:35 +0000 Subject: Change in ...osmo-remsim[master]: add contrib/remsim-apitool.py to control the REST-interface of osmo-r... Message-ID: roh has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14968 Change subject: add contrib/remsim-apitool.py to control the REST-interface of osmo-remsim-server ...................................................................... add contrib/remsim-apitool.py to control the REST-interface of osmo-remsim-server Change-Id: Ia01b0a89e21af18b898becd8f5440c32936772b7 --- M Makefile.am A contrib/remsim-apitool.py 2 files changed, 114 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/68/14968/1 diff --git a/Makefile.am b/Makefile.am index 4843641..0ff9363 100644 --- a/Makefile.am +++ b/Makefile.am @@ -5,7 +5,7 @@ pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = libosmo-rspro.pc -EXTRA_DIST = asn1 .version README.md +EXTRA_DIST = asn1 .version README.md contrib/remsim-apitool.py pkgcofigdir = $(libdir)/pkgconfig diff --git a/contrib/remsim-apitool.py b/contrib/remsim-apitool.py new file mode 100755 index 0000000..8f8f29f --- /dev/null +++ b/contrib/remsim-apitool.py @@ -0,0 +1,113 @@ +#!/usr/bin/env python3 + +import sys +import argparse +import requests + +version = "0.1" + +#access rest +def build_url(suffix): + BASE_PATH = "/api/backend/v1" + return ("http://" + server_host + ":" + server_port + BASE_PATH + suffix) + +def rest_get(suffix): + if verbose: + print("GET "+ build_url(suffix)) + resp = requests.get(build_url(suffix)) + if resp.ok: + try: + js = resp.json() + print("%s: %s" % (suffix, js)) + except: + return + else: + return None + +def rest_post(suffix, js = None): + if verbose: + print("POST "+ build_url(suffix)+ str(js)) + resp = requests.post(build_url(suffix), json=js) + if not resp.ok: + print("post failed") + +def rest_delete(suffix): + if verbose: + print("DELETE "+ build_url(suffix)) + resp = requests.delete(build_url(suffix)) + if not resp.ok: + print("delete failed") + +#rest calls +def slotmap_create(bank_id, bank_slot, client_id, client_slot): + js = { + 'bank': {'bankId': bank_id, 'slotNr': bank_slot}, + 'client': {'clientId': client_id, 'slotNr': client_slot}, + } + return rest_post('/slotmaps', js) + +def slotmap_delete(bank_id, bank_slot): + slotmap_id = bank_id * 65536 + bank_slot + return rest_delete("/slotmaps/%u"%slotmap_id) + +def reset_global(): + return rest_post('/global-reset') + +def main(argv): + global server_port, server_host, verbose + + parser = argparse.ArgumentParser() + parser.add_argument("-H", "--host", help="host to connect to", default="127.0.0.1") + parser.add_argument("-p", "--port", help="port to connect to", default="9997") + parser.add_argument("-v", "--verbose", help="increase output verbosity", action="count", default=0) + group = parser.add_mutually_exclusive_group() + group.add_argument("-r", "--reset", help="remove all mappings (POST /global-reset)", action="store_true") + group.add_argument("-c", "--clients", help="show clients (GET /clients)",nargs='?',const="all",default=None) + group.add_argument("-b", "--banks", help="show banks (GET /banks)",nargs='?',const="all",default=None) + group.add_argument("-s", "--slotmaps", help="show slotmaps (GET /slotmaps)",nargs='?',const="all",default=None) + group.add_argument("-m", "--map", help="create new slotmapping (POST /slotmaps)",nargs=4,metavar=('bank_id', 'bank_slot','client_id','client_slot')) + group.add_argument("-d", "--delete", help="delete slotmapping (DELETE /slotmaps/:id)", type=int, nargs=2, metavar=('bank_id','bank_slot')) + group.add_argument("-a", "--all", help="show all (default if no argument given)", action="store_true") + + args = parser.parse_args() + if args.verbose: + print("verbosity = ", args.verbose) + + server_host = args.host + server_port = args.port + verbose = args.verbose + + if args.reset: + reset_global() + return + if args.clients: + if args.clients == "all": + rest_get("/clients") + else: + rest_get("/clients/" + str(args.clients)) + return + if args.banks: + if args.banks == "all": + rest_get("/banks") + else: + rest_get("/banks/" + str(args.banks)) + return + if args.slotmaps: + if args.slotmaps == "all": + rest_get("/slotmaps") + else: + rest_get("/slotmaps/" + str(args.slotmaps)) + return + if args.map: + slotmap_create(args.map[0],args.map[1],args.map[2],args.map[3]) + return + if args.delete: + slotmap_delete(args.delete[0],args.delete[1]) + return + rest_get("/clients") + rest_get("/banks") + rest_get("/slotmaps") + +if __name__ == "__main__": + main(sys.argv) + -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia01b0a89e21af18b898becd8f5440c32936772b7 Gerrit-Change-Number: 14968 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Fri Jul 26 20:15:17 2019 From: gerrit-no-reply at lists.osmocom.org (roh) Date: Fri, 26 Jul 2019 20:15:17 +0000 Subject: Change in ...simtrace2[master]: add new board and app for gpio testing on octsimtest board Message-ID: roh has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/14969 Change subject: add new board and app for gpio testing on octsimtest board ...................................................................... add new board and app for gpio testing on octsimtest board Change-Id: I01243044002f51b34e8dc12c1b1f565bbf1740a2 --- A firmware/apps/gpio_test/Makefile A firmware/apps/gpio_test/gpio_test.c A firmware/apps/gpio_test/main.c A firmware/apps/gpio_test/usb_strings.txt A firmware/libboard/octsimtest/include/board.h A firmware/libboard/octsimtest/include/i2c.h A firmware/libboard/octsimtest/include/mcp23017.h A firmware/libboard/octsimtest/source/board_octsimtest.c A firmware/libboard/octsimtest/source/i2c.c A firmware/libboard/octsimtest/source/mcp23017.c 10 files changed, 686 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/69/14969/1 diff --git a/firmware/apps/gpio_test/Makefile b/firmware/apps/gpio_test/Makefile new file mode 100644 index 0000000..b2b4707 --- /dev/null +++ b/firmware/apps/gpio_test/Makefile @@ -0,0 +1,3 @@ +C_FILES += $(C_LIBUSB_RT) + +C_FILES += gpio_test.c diff --git a/firmware/apps/gpio_test/gpio_test.c b/firmware/apps/gpio_test/gpio_test.c new file mode 100644 index 0000000..2ab23e7 --- /dev/null +++ b/firmware/apps/gpio_test/gpio_test.c @@ -0,0 +1,10 @@ +#include +#include "utils.h" +#include "chip.h" + + + +void gpio_test_init(void) +{ + printf("FIXME run tests here\n\n"); +} diff --git a/firmware/apps/gpio_test/main.c b/firmware/apps/gpio_test/main.c new file mode 100644 index 0000000..8fe68b3 --- /dev/null +++ b/firmware/apps/gpio_test/main.c @@ -0,0 +1,54 @@ + +#include "board.h" +#include "utils.h" +#include "osmocom/core/timer.h" + +extern void gpio_test_init(void); + +/* returns '1' in case we should break any endless loop */ +static void check_exec_dbg_cmd(void) +{ + int ch; + + if (!UART_IsRxReady()) + return; + + ch = UART_GetChar(); + + board_exec_dbg_cmd(ch); +} + + +extern int main(void) +{ + led_init(); + led_blink(LED_RED, BLINK_ALWAYS_ON); + led_blink(LED_GREEN, BLINK_ALWAYS_ON); + + /* Enable watchdog for 2000 ms, with no window */ + WDT_Enable(WDT, WDT_MR_WDRSTEN | WDT_MR_WDDBGHLT | WDT_MR_WDIDLEHLT | + (WDT_GetPeriod(2000) << 16) | WDT_GetPeriod(2000)); + + PIO_InitializeInterrupts(0); + + + printf("\n\r\n\r" + "=============================================================================\n\r" + "GPIO Test firmware " GIT_VERSION " (C) 2019 Sysmocom GmbH\n\r" + "=============================================================================\n\r"); + + board_main_top(); + + TRACE_INFO("starting gpio test...\n\r"); + gpio_test_init(); + + TRACE_INFO("entering main loop...\n\r"); + while (1) { + WDT_Restart(WDT); + + check_exec_dbg_cmd(); + osmo_timers_prepare(); + osmo_timers_update(); + } + +} diff --git a/firmware/apps/gpio_test/usb_strings.txt b/firmware/apps/gpio_test/usb_strings.txt new file mode 100644 index 0000000..0e797ac --- /dev/null +++ b/firmware/apps/gpio_test/usb_strings.txt @@ -0,0 +1,10 @@ +sysmocom - s.f.m.c. GmbH +SIMtrace 2 compatible device +SIMtrace Sniffer +SIMtrace CCID +SIMtrace Phone +SIMtrace MITM +CardEmulator Modem 1 +CardEmulator Modem 2 +CardEmulator Modem 3 +CardEmulator Modem 4 diff --git a/firmware/libboard/octsimtest/include/board.h b/firmware/libboard/octsimtest/include/board.h new file mode 100644 index 0000000..018cfdd --- /dev/null +++ b/firmware/libboard/octsimtest/include/board.h @@ -0,0 +1,155 @@ +/* SIMtrace with SAM3S board definition + * + * (C) 2016-2017 by Harald Welte + * (C) 2018 by sysmocom -s.f.m.c. GmbH, Author: Kevin Redon + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA + */ +#pragma once +#include "board_common.h" +#include "simtrace_usb.h" + +/* Name of the board */ +#define BOARD_NAME "OCTSIMTEST" +/* Board definition */ +#define octsimtest + +/** oscillator used as main clock source (in Hz) */ +#define BOARD_MAINOSC 18432000 +/** desired main clock frequency (in Hz, based on BOARD_MAINOSC) */ +#define BOARD_MCK 58982400 // 18.432 * 16 / 5 + +/** Pin configuration **/ +/* Button to force bootloader start (shorted to ground when pressed */ +#define PIN_BOOTLOADER_SW {PIO_PA5, PIOA, ID_PIOA, PIO_INPUT, PIO_PULLUP} + +//FIXME SIM_PWEN_PIN collides with PA5/bootloader_sw on octsimtest +/* Enable powering the card using the second 3.3 V output of the LDO (active high) */ +#define SIM_PWEN_PIN {PIO_PA12, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_DEFAULT} +/* Enable powering the SIM card */ +#define PWR_PINS SIM_PWEN_PIN + +// FIXME PA8 is 32khz xtal on octsimtest +/* Card presence pin */ +#define SW_SIM PIO_PA11 +/* Pull card presence pin high (shorted to ground in card slot when card is present) */ +#define SMARTCARD_CONNECT_PIN {SW_SIM, PIOA, ID_PIOA, PIO_INPUT, PIO_PULLUP | PIO_DEBOUNCE | PIO_DEGLITCH | PIO_IT_EDGE } + +/** Smart card connection **/ +//FIXME +/* Card RST reset signal input (active low; RST_SIM in schematic) */ +#define PIN_SIM_RST {PIO_PA13, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} +/* Card I/O data signal input/output (I/O_SIM in schematic) */ +#define PIN_SIM_IO {PIO_PA6A_TXD0, PIOA, ID_PIOA, PIO_PERIPH_A, PIO_DEFAULT} +/* Card CLK clock input (CLK_SIM in schematic) */ +#define PIN_SIM_CLK {PIO_PA2B_SCK0, PIOA, ID_PIOA, PIO_PERIPH_B, PIO_DEFAULT} +/* Pin to measure card I/O timing (to start measuring the ETU on I/O activity; connected I/O_SIM in schematic) */ +#define PIN_SIM_IO_INPUT {PIO_PA1B_TIOB0, PIOA, ID_PIOA, PIO_PERIPH_B, PIO_DEFAULT} +//FIXME PIO_PA4B_TCLK0 PA4 is LED on octsimtest +/* Pin used as clock input (to measure the ETU duration; connected to CLK_SIM in schematic) */ +#define PIN_SIM_CLK_INPUT {PIO_PA14, PIOA, ID_PIOA, PIO_PERIPH_B, PIO_DEFAULT} +/* Pins used to measure ETU timing (using timer counter) */ +#define PINS_TC PIN_SIM_IO_INPUT, PIN_SIM_CLK_INPUT + +/** Phone connection **/ +/* Phone USIM slot 1 VCC pin (VCC_PHONE in schematic) */ +#define PIN_USIM1_VCC {PIO_PA25, PIOA, ID_PIOA, PIO_INPUT, PIO_DEFAULT} +/* Phone USIM slot 1 RST pin (active low; RST_PHONE in schematic) */ +#define PIN_USIM1_nRST {PIO_PA24, PIOA, ID_PIOA, PIO_INPUT, PIO_IT_RISE_EDGE | PIO_DEGLITCH } +/* Phone I/O data signal input/output (I/O_PHONE in schematic) */ +#define PIN_PHONE_IO {PIO_PA22A_TXD1, PIOA, ID_PIOA, PIO_PERIPH_A, PIO_DEFAULT} +/* Phone CLK clock input (CLK_PHONE in schematic) */ +#define PIN_PHONE_CLK {PIO_PA23A_SCK1, PIOA, ID_PIOA, PIO_PERIPH_A, PIO_DEFAULT} +/* Pin used for phone USIM slot 1 communication */ +#define PINS_USIM1 PIN_PHONE_IO, PIN_PHONE_CLK, PIN_PHONE_CLK_INPUT, PIN_USIM1_VCC, PIN_PHONE_IO_INPUT, PIN_USIM1_nRST +/* Phone I/O data signal input/output (unused USART RX input; connected to I/O_PHONE in schematic) */ +#define PIN_PHONE_IO_INPUT {PIO_PA21A_RXD1, PIOA, ID_PIOA, PIO_PERIPH_A, PIO_DEFAULT} +/* Pin used as clock input (to measure the ETU duration; connected to CLK_PHONE in schematic) */ +#define PIN_PHONE_CLK_INPUT {PIO_PA29B_TCLK2, PIOA, ID_PIOA, PIO_PERIPH_B, PIO_DEFAULT} + +/** Default pin configuration **/ +/* Disconnect VPP, CLK, and RST lines between card and phone using bus switch (high sets bus switch to high-impedance) */ +#define PIN_SC_SW_DEFAULT {PIO_PA20, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_DEFAULT} +/* Disconnect I/O line between card and phone using bus switch (high sets bus switch to high-impedance) */ +#define PIN_IO_SW_DEFAULT {PIO_PA19, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_DEFAULT} +/* Disconnect all lines (VPP, CLK, RST, and I/O) between card and phone */ +#define PINS_BUS_DEFAULT PIN_SC_SW_DEFAULT, PIN_IO_SW_DEFAULT + +/** Sniffer configuration **/ +/* Connect VPP, CLK, and RST lines between card and phone using bus switch (low connects signals on bus switch) */ +#define PIN_SC_SW_SNIFF {PIO_PA20, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} +/* Connect I/O line between card and phone using bus switch (low connects signals on bus switch) */ +#define PIN_IO_SW_SNIFF {PIO_PA19, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} +/* Connect all lines (VPP, CLK, RST, and I/O) between card and phone */ +#define PINS_BUS_SNIFF PIN_SC_SW_SNIFF, PIN_IO_SW_SNIFF +/* Card RST reset signal input (use as input since the phone will drive it) */ +#define PIN_SIM_RST_SNIFF {PIO_PA7, PIOA, ID_PIOA, PIO_INPUT, PIO_DEGLITCH | PIO_IT_EDGE} +/* Pins used to sniff phone-card communication */ +#define PINS_SIM_SNIFF PIN_SIM_IO, PIN_SIM_CLK, PIN_SIM_RST_SNIFF +/* Disable power converter 4.5-6V to 3.3V (active high) */ +#define PIN_SIM_PWEN_SNIFF {SIM_PWEN, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} +/* Enable power switch to forward VCC_PHONE to VCC_SIM (active high) */ +#define PIN_VCC_FWD_SNIFF {VCC_FWD, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_DEFAULT} +/* Use phone VCC to power card */ +#define PINS_PWR_SNIFF PIN_SIM_PWEN_SNIFF, PIN_VCC_FWD_SNIFF + +/** CCID configuration */ +/* Card RST reset signal input (active low; RST_SIM in schematic) */ +#define PIN_ISO7816_RSTMC {PIO_PA7, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} +/* ISO7816-communication related pins */ +#define PINS_ISO7816 PIN_SIM_IO, PIN_SIM_CLK, PIN_ISO7816_RSTMC // SIM_PWEN_PIN, PIN_SIM_IO2, PIN_SIM_CLK2 + +/** External SPI flash interface **/ +/* SPI MISO pin definition */ +#define PIN_SPI_MISO {PIO_PA12A_MISO, PIOA, PIOA, PIO_PERIPH_A, PIO_PULLUP} +/* SPI MOSI pin definition */ +#define PIN_SPI_MOSI {PIO_PA13A_MOSI, PIOA, PIOA, PIO_PERIPH_A, PIO_DEFAULT} +/* SPI SCK pin definition */ +#define PIN_SPI_SCK {PIO_PA14A_SPCK, PIOA, PIOA, PIO_PERIPH_A, PIO_DEFAULT} +/* SPI pins definition. Contains MISO, MOSI & SCK */ +#define PINS_SPI PIN_SPI_MISO, PIN_SPI_MOSI, PIN_SPI_SCK +/* SPI chip select 0 pin definition */ +#define PIN_SPI_NPCS0 {PIO_PA11A_NPCS0, PIOA, PIOA, PIO_PERIPH_A, PIO_DEFAULT} +/* SPI flash write protect pin (active low, pulled low) */ +#define PIN_SPI_WP {PA15, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} + +/** Pin configuration to control USB pull-up on D+ + * @details the USB pull-up on D+ is enable by default on the board but can be disabled by setting PA16 high + */ +#define PIN_USB_PULLUP {PIO_PA16, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} + +/** USB definitions */ +/* OpenMoko SIMtrace 2 USB vendor ID */ +#define BOARD_USB_VENDOR_ID USB_VENDOR_OPENMOKO +/* OpenMoko SIMtrace 2 USB product ID (main application/runtime mode) */ +#define BOARD_USB_PRODUCT_ID USB_PRODUCT_SIMTRACE2 +/* OpenMoko SIMtrace 2 DFU USB product ID (DFU bootloader/DFU mode) */ +#define BOARD_DFU_USB_PRODUCT_ID USB_PRODUCT_SIMTRACE2_DFU +/* USB release number (bcdDevice, shown as 0.00) */ +#define BOARD_USB_RELEASE 0x000 +/* Indicate SIMtrace is bus power in USB attributes */ +#define BOARD_USB_BMATTRIBUTES USBConfigurationDescriptor_BUSPOWERED_NORWAKEUP + +/** Supported modes */ +/* SIMtrace board supports sniffer mode */ +//#define HAVE_SNIFFER +/* SIMtrace board supports CCID mode */ +//#define HAVE_CCID +/* SIMtrace board supports card emulation mode */ +//#define HAVE_CARDEM +/* SIMtrace board supports man-in-the-middle mode */ +//#define HAVE_MITM +/* octsimtest board supports gpio_test mode */ +#define HAVE_GPIO_TEST diff --git a/firmware/libboard/octsimtest/include/i2c.h b/firmware/libboard/octsimtest/include/i2c.h new file mode 100644 index 0000000..5a8c908 --- /dev/null +++ b/firmware/libboard/octsimtest/include/i2c.h @@ -0,0 +1,28 @@ +/* I2C EEPROM memory read and write utilities + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA + */ +#pragma once + +#include + +void i2c_pin_init(void); + +bool i2c_write_byte(bool send_start, bool send_stop, uint8_t byte); +uint8_t i2c_read_byte(bool nack, bool send_stop); +static void i2c_stop_cond(void); + +int eeprom_write_byte(uint8_t slave, uint8_t addr, uint8_t byte); +int eeprom_read_byte(uint8_t slave, uint8_t addr); diff --git a/firmware/libboard/octsimtest/include/mcp23017.h b/firmware/libboard/octsimtest/include/mcp23017.h new file mode 100644 index 0000000..dea6285 --- /dev/null +++ b/firmware/libboard/octsimtest/include/mcp23017.h @@ -0,0 +1,23 @@ +/* mcp23017 i2c gpio expander read and write utilities + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA + */ +#pragma once + +#define MCP23017_ADDRESS 0x20 + +int mcp23017_init(uint8_t slave); +//int mcp23017_write_byte(uint8_t slave, uint8_t addr, uint8_t byte); +//int mcp23017_read_byte(uint8_t slave, uint8_t addr); diff --git a/firmware/libboard/octsimtest/source/board_octsimtest.c b/firmware/libboard/octsimtest/source/board_octsimtest.c new file mode 100644 index 0000000..2772015 --- /dev/null +++ b/firmware/libboard/octsimtest/source/board_octsimtest.c @@ -0,0 +1,72 @@ +/* SIMtrace with SAM3S specific application code + * + * (C) 2017 by Harald Welte + * (C) 2018 by sysmocom -s.f.m.c. GmbH, Author: Kevin Redon + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA + */ +#include "board.h" +#include "simtrace.h" +#include "utils.h" +#include "sim_switch.h" +#include +#include "usb_buf.h" +#include "i2c.h" +#include "mcp23017.h" + +void board_exec_dbg_cmd(int ch) +{ + switch (ch) { + case '?': + printf("\t?\thelp\n\r"); + printf("\tR\treset SAM3\n\r"); + break; + case 'R': + printf("Asking NVIC to reset us\n\r"); + USBD_Disconnect(); + NVIC_SystemReset(); + break; + default: + printf("Unknown command '%c'\n\r", ch); + break; + } +} + +void board_main_top(void) +{ +#ifndef APPLICATION_dfu + usb_buf_init(); + + i2c_pin_init(); + mcp23017_init(MCP23017_ADDRESS); + /* Initialize checking for card insert/remove events */ + //card_present_init(); +#endif +} + +int board_override_enter_dfu(void) +{ + const Pin bl_sw_pin = PIN_BOOTLOADER_SW; + + PIO_Configure(&bl_sw_pin, 1); + + /* Enter DFU bootloader in case the respective button is pressed */ + if (PIO_Get(&bl_sw_pin) == 0) { + /* do not print to early since the console is not initialized yet */ + //printf("BOOTLOADER switch pressed -> Force DFU\n\r"); + return 1; + } else + return 0; +} diff --git a/firmware/libboard/octsimtest/source/i2c.c b/firmware/libboard/octsimtest/source/i2c.c new file mode 100644 index 0000000..a708704 --- /dev/null +++ b/firmware/libboard/octsimtest/source/i2c.c @@ -0,0 +1,225 @@ +/* I2C EEPROM memory read and write utilities + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA + */ +#include "board.h" +#include + +/* Low-Level I2C Routines */ + +static const Pin pin_sda = {PIO_PA30, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_OPENDRAIN }; +static const Pin pin_sda_in = {PIO_PA30, PIOA, ID_PIOA, PIO_INPUT, PIO_DEFAULT }; +static const Pin pin_scl = {PIO_PA31, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_OPENDRAIN }; + +static void i2c_delay() +{ + volatile int v; + int i; + + /* 100 cycles results in SCL peak length of 44us, so it's about + * 440ns per cycle here */ + for (i = 0; i < 14; i++) { + v = 0; + } +} + +void i2c_pin_init(void) +{ + PIO_Configure(&pin_scl, PIO_LISTSIZE(pin_scl)); + PIO_Configure(&pin_sda, PIO_LISTSIZE(pin_sda)); +} + +static void set_scl(void) +{ + PIO_Set(&pin_scl); + i2c_delay(); +} + +static void set_sda(void) +{ + PIO_Set(&pin_sda); + i2c_delay(); +} + +static void clear_scl(void) +{ + PIO_Clear(&pin_scl); + i2c_delay(); +} + +static void clear_sda(void) +{ + PIO_Clear(&pin_sda); + i2c_delay(); +} + +static bool read_sda(void) +{ + bool ret; + + PIO_Configure(&pin_sda_in, PIO_LISTSIZE(pin_sda_in)); + if (PIO_Get(&pin_sda_in)) + ret = true; + else + ret = false; + PIO_Configure(&pin_sda, PIO_LISTSIZE(pin_sda)); + + return ret; +} + +/* Core I2C Routines */ + +static bool i2c_started = false; + +static void i2c_start_cond(void) +{ + if (i2c_started) { + set_sda(); + set_scl(); + } + + clear_sda(); + i2c_delay(); + clear_scl(); + i2c_started = true; +} + +static void i2c_stop_cond(void) +{ + clear_sda(); + set_scl(); + set_sda(); + i2c_delay(); + i2c_started = false; +} + +static void i2c_write_bit(bool bit) +{ + if (bit) + set_sda(); + else + clear_sda(); + i2c_delay(); // ? + set_scl(); + clear_scl(); +} + +static bool i2c_read_bit(void) +{ + bool bit; + + set_sda(); + set_scl(); + bit = read_sda(); + clear_scl(); + + return bit; +} + +bool i2c_write_byte(bool send_start, bool send_stop, uint8_t byte) +{ + uint8_t bit; + bool nack; + + if (send_start) + i2c_start_cond(); + + for (bit = 0; bit < 8; bit++) { + i2c_write_bit((byte & 0x80) != 0); + byte <<= 1; + } + + nack = i2c_read_bit(); + + if (send_stop) + i2c_stop_cond(); + + return nack; +} + +uint8_t i2c_read_byte(bool nack, bool send_stop) +{ + uint8_t byte = 0; + uint8_t bit; + + for (bit = 0; bit < 8; bit++) { + byte = (byte << 1) | i2c_read_bit(); + } + + i2c_write_bit(nack); + + if (send_stop) + i2c_stop_cond(); + + return byte; +} + + +/* EEPROM related code */ + +int eeprom_write_byte(uint8_t slave, uint8_t addr, uint8_t byte) +{ + bool nack; + + WDT_Restart(WDT); + + /* Write slave address */ + nack = i2c_write_byte(true, false, slave << 1); + if (nack) + goto out_stop; + nack = i2c_write_byte(false, false, addr); + if (nack) + goto out_stop; + nack = i2c_write_byte(false, true, byte); + if (nack) + goto out_stop; + /* Wait tWR time to ensure EEPROM is writing correctly (tWR = 5 ms for AT24C02) */ + mdelay(5); + +out_stop: + i2c_stop_cond(); + if (nack) + return -1; + else + return 0; +} + +int eeprom_read_byte(uint8_t slave, uint8_t addr) +{ + bool nack; + + WDT_Restart(WDT); + + /* dummy write cycle */ + nack = i2c_write_byte(true, false, slave << 1); + if (nack) + goto out_stop; + nack = i2c_write_byte(false, false, addr); + if (nack) + goto out_stop; + /* Re-start with read */ + nack = i2c_write_byte(true, false, (slave << 1) | 1); + if (nack) + goto out_stop; + + return i2c_read_byte(true, true); + +out_stop: + i2c_stop_cond(); + if (nack) + return -1; + else + return 0; +} diff --git a/firmware/libboard/octsimtest/source/mcp23017.c b/firmware/libboard/octsimtest/source/mcp23017.c new file mode 100644 index 0000000..63390b4 --- /dev/null +++ b/firmware/libboard/octsimtest/source/mcp23017.c @@ -0,0 +1,106 @@ +#include "board.h" +#include +#include "i2c.h" +#include "mcp23017.h" + + +//defines from https://github.com/adafruit/Adafruit-MCP23017-Arduino-Library/blob/master/Adafruit_MCP23017.h under BSD license + +// registers +#define MCP23017_IODIRA 0x00 +#define MCP23017_IPOLA 0x02 +#define MCP23017_GPINTENA 0x04 +#define MCP23017_DEFVALA 0x06 +#define MCP23017_INTCONA 0x08 +#define MCP23017_IOCONA 0x0A +#define MCP23017_GPPUA 0x0C +#define MCP23017_INTFA 0x0E +#define MCP23017_INTCAPA 0x10 +#define MCP23017_GPIOA 0x12 +#define MCP23017_OLATA 0x14 + + +#define MCP23017_IODIRB 0x01 +#define MCP23017_IPOLB 0x03 +#define MCP23017_GPINTENB 0x05 +#define MCP23017_DEFVALB 0x07 +#define MCP23017_INTCONB 0x09 +#define MCP23017_IOCONB 0x0B +#define MCP23017_GPPUB 0x0D +#define MCP23017_INTFB 0x0F +#define MCP23017_INTCAPB 0x11 +#define MCP23017_GPIOB 0x13 +#define MCP23017_OLATB 0x15 + +#define MCP23017_INT_ERR 255 + + +//bool i2c_write_byte(bool send_start, bool send_stop, uint8_t byte) +//uint8_t i2c_read_byte(bool nack, bool send_stop) +//static void i2c_stop_cond(void) + +int mcp23017_write_byte(uint8_t slave, uint8_t addr, uint8_t byte) +{ + bool nack; + + WDT_Restart(WDT); + +// Write slave address + nack = i2c_write_byte(true, false, slave << 1); + if (nack) + goto out_stop; + nack = i2c_write_byte(false, false, addr); + if (nack) + goto out_stop; + nack = i2c_write_byte(false, true, byte); + if (nack) + goto out_stop; + +out_stop: + i2c_stop_cond(); + if (nack) + return -1; + else + return 0; +} + +int mcp23017_read_byte(uint8_t slave, uint8_t addr) +{ + bool nack; + + WDT_Restart(WDT); + + // dummy write cycle + nack = i2c_write_byte(true, false, slave << 1); + if (nack) + goto out_stop; + nack = i2c_write_byte(false, false, addr); + if (nack) + goto out_stop; + // Re-start with read + nack = i2c_write_byte(true, false, (slave << 1) | 1); + if (nack) + goto out_stop; + + return i2c_read_byte(true, true); + +out_stop: + i2c_stop_cond(); + if (nack) + return -1; + else + return 0; +} + +int mcp23017_init(uint8_t slave) +{ + printf("mcp23017_init\n"); + // all gpio input + if (mcp23017_write_byte(slave, MCP23017_IODIRA, 0xff)) + return false; + if (mcp23017_write_byte(slave, MCP23017_IODIRB, 0xff)) + return false; + printf("mcp23017 found\n"); + return true; +} + -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/14969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I01243044002f51b34e8dc12c1b1f565bbf1740a2 Gerrit-Change-Number: 14969 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 27 19:35:14 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 27 Jul 2019 19:35:14 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: use DLGLOBAL logging sub-system Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14970 Change subject: vty/telnet_interface.c: use DLGLOBAL logging sub-system ...................................................................... vty/telnet_interface.c: use DLGLOBAL logging sub-system Change-Id: I1564f4714a33d36792e4982deb8f19d1b740dc0c --- M src/vty/telnet_interface.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/70/14970/1 diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c index a1fc999..c16b0b1 100644 --- a/src/vty/telnet_interface.c +++ b/src/vty/telnet_interface.c @@ -169,7 +169,7 @@ int rc; if (new_connection < 0) { - LOGP(0, LOGL_ERROR, "telnet accept failed\n"); + LOGP(DLGLOBAL, LOGL_ERROR, "telnet accept failed\n"); return new_connection; } @@ -188,7 +188,7 @@ connection->vty = vty_create(new_connection, connection); if (!connection->vty) { - LOGP(0, LOGL_ERROR, "couldn't create VTY\n"); + LOGP(DLGLOBAL, LOGL_ERROR, "couldn't create VTY\n"); /* vty_create() is already closing the fd if it returns NULL */ talloc_free(connection); return -1; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1564f4714a33d36792e4982deb8f19d1b740dc0c Gerrit-Change-Number: 14970 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 27 19:35:14 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 27 Jul 2019 19:35:14 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: avoid unneeded initialization Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14971 Change subject: vty/telnet_interface.c: avoid unneeded initialization ...................................................................... vty/telnet_interface.c: avoid unneeded initialization Unconditional initialization follows the structure definition, so there is no need to do it twice. This prevents compiler from warning about potential errors. Change-Id: If9fd2826f132dfa203dda62940d93dbdfcfd92ac --- M src/vty/telnet_interface.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/71/14971/1 diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c index c16b0b1..d44754c 100644 --- a/src/vty/telnet_interface.c +++ b/src/vty/telnet_interface.c @@ -210,7 +210,7 @@ /*! callback from core VTY code about VTY related events */ void vty_event(enum event event, int sock, struct vty *vty) { - struct vty_signal_data sig_data = { 0, }; + struct vty_signal_data sig_data; struct telnet_connection *connection = vty->priv; struct osmo_fd *bfd; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If9fd2826f132dfa203dda62940d93dbdfcfd92ac Gerrit-Change-Number: 14971 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 27 19:35:14 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 27 Jul 2019 19:35:14 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 Change subject: vty/telnet_interface.c: log connection accept() / close() events ...................................................................... vty/telnet_interface.c: log connection accept() / close() events Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c --- M src/vty/telnet_interface.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/72/14972/1 diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c index d44754c..dbbbfec 100644 --- a/src/vty/telnet_interface.c +++ b/src/vty/telnet_interface.c @@ -123,6 +123,16 @@ int telnet_close_client(struct osmo_fd *fd) { struct telnet_connection *conn = (struct telnet_connection*)fd->data; + struct sockaddr_in sockaddr; + socklen_t len = sizeof(sockaddr); + int rc; + + /* FIXME: getsockname() always fails: "Bad file descriptor" */ + rc = getsockname(fd->fd, (struct sockaddr *) &sockaddr, &len); + if (rc == 0) { + LOGP(DLGLOBAL, LOGL_INFO, "Closing telnet connection %s:%u\n", + inet_ntoa(sockaddr.sin_addr), ntohs(sockaddr.sin_port)); + } close(fd->fd); osmo_fd_unregister(fd); @@ -173,6 +183,9 @@ return new_connection; } + LOGP(DLGLOBAL, LOGL_INFO, "Accept()ed new telnet connection from %s:%u\n", + inet_ntoa(sockaddr.sin_addr), ntohs(sockaddr.sin_port)); + connection = talloc_zero(tall_telnet_ctx, struct telnet_connection); connection->priv = fd->data; connection->fd.data = connection; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c Gerrit-Change-Number: 14972 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 27 19:35:15 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 27 Jul 2019 19:35:15 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: fix vty_execute(): prevent further heap-buffer overrun Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 Change subject: vty/vty.c: fix vty_execute(): prevent further heap-buffer overrun ...................................................................... vty/vty.c: fix vty_execute(): prevent further heap-buffer overrun After reading data from the socket, assigned to a given VTY, we need to '\0'-terminate the received string. Otherwise, further access to that string, stored in a heap buffer vty->buf, would lead to a heap overrun. == How to reproduce? $ python -c "print 'A' * 512" | telnet $HOST $PORT ==21264==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6190000211e0 at pc 0x000000435d2f bp 0x7ffc06c7add0 sp 0x7ffc06c7a578 READ of size 1025 at 0x6190000211e0 thread T0 #0 0x435d2e in __interceptor_strlen (/usr/local/bin/osmo-msc+0x435d2e) #1 0x7fb95bfa5624 in talloc_strdup (/usr/lib/x86_64-linux-gnu/libtalloc.so.2+0x6624) #2 0x7fb95c1be2bc in vty_hist_add /opt/osmocom/libosmocore/src/vty/vty.c:578 #3 0x7fb95c1be2bc in vty_execute /opt/osmocom/libosmocore/src/vty/vty.c:703 #4 0x7fb95c1be2bc in vty_read /opt/osmocom/libosmocore/src/vty/vty.c:1425 #5 0x7fb95c1bfd78 in client_data /opt/osmocom/libosmocore/src/vty/telnet_interface.c:157 #6 0x7fb95b90bd33 in osmo_fd_disp_fds /opt/osmocom/libosmocore/src/select.c:223 #7 0x7fb95b90bd33 in osmo_select_main /opt/osmocom/libosmocore/src/select.c:263 #8 0x5006cc in main /opt/osmocom/osmo-msc/src/osmo-msc/msc_main.c:723:3 #9 0x7fb959935f44 in __libc_start_main /build/eglibc-xkFqqE/eglibc-2.19/csu/libc-start.c:287 #10 0x4226fb in _start (/usr/local/bin/osmo-msc+0x4226fb) == Why exactly 512? Because the initial size of the heap buffer is 512 (see VTY_BUFSIZ). Later on it can be realloc()ated, so X > 512 should also work. Found using AddressSanitizer and Radamsa [1] fuzzer. [1] https://gitlab.com/akihe/radamsa Change-Id: I82f774ad18d0e555eb8f3590a519946d9c583c78 --- M src/vty/vty.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/73/14973/1 diff --git a/src/vty/vty.c b/src/vty/vty.c index 98b332d..c557524 100644 --- a/src/vty/vty.c +++ b/src/vty/vty.c @@ -686,6 +686,9 @@ ret = CMD_SUCCESS; + /* '\0'-terminate the command buffer */ + vty->buf[vty->length] = '\0'; + switch (vty->node) { case AUTH_NODE: case AUTH_ENABLE_NODE: -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82f774ad18d0e555eb8f3590a519946d9c583c78 Gerrit-Change-Number: 14973 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 27 19:35:15 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 27 Jul 2019 19:35:15 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: log received commands from telnet interface Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14974 Change subject: vty/vty.c: log received commands from telnet interface ...................................................................... vty/vty.c: log received commands from telnet interface This may be useful for investigating TTCN-3 test case failures. Change-Id: I5f6639f6ebc3e8f8df50ef48538df94285b759fd --- M src/vty/vty.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/74/14974/1 diff --git a/src/vty/vty.c b/src/vty/vty.c index c557524..4960aea 100644 --- a/src/vty/vty.c +++ b/src/vty/vty.c @@ -61,11 +61,14 @@ #include #include +#include #include #include #include #include +#include +#include /* \addtogroup vty * @{ @@ -422,6 +425,17 @@ int ret; vector vline; + if (vty->length > 0 && log_check_level(DLGLOBAL, LOGL_DEBUG)) { + char rem_addr[INET6_ADDRSTRLEN + 1] = "(unknown)"; + char rem_port[10] = "(unknown)"; + + osmo_sock_get_ip_and_port(vty->fd, rem_addr, sizeof(rem_addr), + rem_port, sizeof(rem_port), + false); + LOGP(DLGLOBAL, LOGL_DEBUG, "(%s:%s) Got VTY command: '%s'\n", + rem_addr, rem_port, buf); + } + /* Split readline string up into the vector */ vline = cmd_make_strvec(buf); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f6639f6ebc3e8f8df50ef48538df94285b759fd Gerrit-Change-Number: 14974 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 27 19:41:53 2019 From: gerrit-no-reply at lists.osmocom.org (fixeria) Date: Sat, 27 Jul 2019 19:41:53 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly Message-ID: fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 Change subject: vty/vty.c: the command buffer can be accessed directly ...................................................................... vty/vty.c: the command buffer can be accessed directly Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39 --- M src/vty/vty.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/14975/1 diff --git a/src/vty/vty.c b/src/vty/vty.c index 4960aea..85c9fe5 100644 --- a/src/vty/vty.c +++ b/src/vty/vty.c @@ -139,7 +139,7 @@ } /* Authentication of vty */ -static void vty_auth(struct vty *vty, char *buf) +static void vty_auth(struct vty *vty) { char *passwd = NULL; enum node_type next_node = 0; @@ -173,10 +173,10 @@ if (passwd) { #ifdef VTY_CRYPT_PW if (host.encrypt) - fail = strcmp(crypt(buf, passwd), passwd); + fail = strcmp(crypt(vty->buf, passwd), passwd); else #endif - fail = strcmp(buf, passwd); + fail = strcmp(vty->buf, passwd); } else fail = 1; @@ -420,7 +420,7 @@ } /* Command execution over the vty interface. */ -static int vty_command(struct vty *vty, char *buf) +static int vty_command(struct vty *vty) { int ret; vector vline; @@ -433,11 +433,11 @@ rem_port, sizeof(rem_port), false); LOGP(DLGLOBAL, LOGL_DEBUG, "(%s:%s) Got VTY command: '%s'\n", - rem_addr, rem_port, buf); + rem_addr, rem_port, vty->buf); } /* Split readline string up into the vector */ - vline = cmd_make_strvec(buf); + vline = cmd_make_strvec(vty->buf); if (vline == NULL) return CMD_SUCCESS; @@ -706,10 +706,10 @@ switch (vty->node) { case AUTH_NODE: case AUTH_ENABLE_NODE: - vty_auth(vty, vty->buf); + vty_auth(vty); break; default: - ret = vty_command(vty, vty->buf); + ret = vty_command(vty); if (vty->type == VTY_TERM) vty_hist_add(vty); break; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39 Gerrit-Change-Number: 14975 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Sat Jul 27 21:36:55 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Sat, 27 Jul 2019 21:36:55 +0000 Subject: Change in ...libosmocore[master]: vty/logging_vty.c: fix writing of 'print category-hex' Message-ID: Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14976 Change subject: vty/logging_vty.c: fix writing of 'print category-hex' ...................................................................... vty/logging_vty.c: fix writing of 'print category-hex' Change-Id: I33837f0fac1afe83596fa600916abc05ecb8c356 --- M src/vty/logging_vty.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/14976/1 diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index f3e1419..9911c6f 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -906,6 +906,8 @@ vty_out(vty, " logging color %u%s", tgt->use_color ? 1 : 0, VTY_NEWLINE); + vty_out(vty, " logging print category-hex %d%s", + tgt->print_category_hex ? 1 : 0, VTY_NEWLINE); vty_out(vty, " logging print category %d%s", tgt->print_category ? 1 : 0, VTY_NEWLINE); if (tgt->print_ext_timestamp) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I33837f0fac1afe83596fa600916abc05ecb8c356 Gerrit-Change-Number: 14976 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From admin at opensuse.org Sun Jul 28 02:57:00 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 28 Jul 2019 02:57:00 +0000 Subject: Build failure of network:osmocom:nightly/libosmo-netif in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <5d3d0f0f4bffc_6c02b0f410305f47822ab@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Raspbian_10/armv7l Package network:osmocom:nightly/libosmo-netif failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines of build log: [ 304s] | #define HAVE_STDINT_H 1 [ 304s] | #define HAVE_UNISTD_H 1 [ 304s] | #define HAVE_DLFCN_H 1 [ 304s] | #define LT_OBJDIR ".libs/" [ 304s] | #define STDC_HEADERS 1 [ 304s] | #define HAVE_EXECINFO_H 1 [ 304s] | #define HAVE_SYS_SELECT_H 1 [ 304s] | #define HAVE_SYS_SOCKET_H 1 [ 304s] | #define HAVE_SYSLOG_H 1 [ 304s] | #define HAVE_CTYPE_H 1 [ 304s] | #define HAVE_LIBSCTP 1 [ 304s] | #define HAVE_PCAP_H 1 [ 304s] | [ 304s] | configure: exit 0 [ 304s] [ 304s] make[1]: *** [debian/rules:27: override_dh_auto_test] Error 1 [ 304s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 304s] make: *** [debian/rules:13: build] Error 2 [ 304s] dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2 [ 304s] [ 304s] obs-arm-5 failed "build libosmo-netif_0.5.0.2.6563.dsc" at Sun Jul 28 02:56:53 UTC 2019. [ 304s] [ 304s] ### VM INTERACTION START ### [ 306s] [ 260.888598] sysrq: SysRq : Power Off [ 306s] [ 260.942693] reboot: Power down [ 307s] ### VM INTERACTION END ### [ 307s] [ 307s] obs-arm-5 failed "build libosmo-netif_0.5.0.2.6563.dsc" at Sun Jul 28 02:56:56 UTC 2019. [ 307s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 28 07:17:05 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 28 Jul 2019 07:17:05 +0000 Subject: Build failure of network:osmocom:nightly/limesuite in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <5d3d4c0923376_6c02b0f410305f48120fa@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/limesuite/Raspbian_10/armv7l Package network:osmocom:nightly/limesuite failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly limesuite Last lines of build log: [ 232s] /usr/bin/ld: libLimeSuite.so.19.04.0: undefined reference to `__atomic_load_8' [ 232s] /usr/bin/ld: libLimeSuite.so.19.04.0: undefined reference to `__atomic_store_8' [ 232s] collect2: error: ld returned 1 exit status [ 232s] make[3]: *** [src/CMakeFiles/boardEmulator.dir/build.make:89: src/boardEmulator] Error 1 [ 232s] make[3]: Leaving directory '/usr/src/packages/BUILD/obj-arm-linux-gnueabihf' [ 232s] make[2]: *** [CMakeFiles/Makefile2:216: src/CMakeFiles/boardEmulator.dir/all] Error 2 [ 244s] [ 43%] Linking CXX static library liboglGraph.a [ 244s] cd /usr/src/packages/BUILD/obj-arm-linux-gnueabihf/src/oglGraph && /usr/bin/cmake -P CMakeFiles/oglGraph.dir/cmake_clean_target.cmake [ 244s] cd /usr/src/packages/BUILD/obj-arm-linux-gnueabihf/src/oglGraph && /usr/bin/cmake -E cmake_link_script CMakeFiles/oglGraph.dir/link.txt --verbose=1 [ 244s] /usr/bin/ar qc liboglGraph.a CMakeFiles/oglGraph.dir/dlgMarkers.cpp.o CMakeFiles/oglGraph.dir/GLFont.cpp.o CMakeFiles/oglGraph.dir/OpenGLGraph.cpp.o CMakeFiles/oglGraph.dir/glew/glew.c.o [ 244s] /usr/bin/ranlib liboglGraph.a [ 244s] make[3]: Leaving directory '/usr/src/packages/BUILD/obj-arm-linux-gnueabihf' [ 244s] [ 43%] Built target oglGraph [ 244s] make[2]: Leaving directory '/usr/src/packages/BUILD/obj-arm-linux-gnueabihf' [ 244s] make[1]: *** [Makefile:133: all] Error 2 [ 244s] make[1]: Leaving directory '/usr/src/packages/BUILD/obj-arm-linux-gnueabihf' [ 244s] dh_auto_build: cd obj-arm-linux-gnueabihf && make -j4 returned exit code 2 [ 244s] make: *** [debian/rules:28: binary] Error 2 [ 244s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 244s] [ 244s] armbuild21 failed "build limesuite_19.04.0-1.dsc" at Sun Jul 28 07:17:01 UTC 2019. [ 244s] [ 244s] ### VM INTERACTION START ### [ 247s] [ 226.393918] sysrq: SysRq : Power Off [ 248s] [ 226.447511] reboot: Power down [ 248s] ### VM INTERACTION END ### [ 248s] [ 248s] armbuild21 failed "build limesuite_19.04.0-1.dsc" at Sun Jul 28 07:17:04 UTC 2019. [ 248s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Sun Jul 28 07:29:09 2019 From: admin at opensuse.org (OBS Notification) Date: Sun, 28 Jul 2019 07:29:09 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Raspbian_10/armv7l In-Reply-To: References: Message-ID: <5d3d4ed2eab84_6c02b0f410305f48131a7@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Raspbian_10/armv7l Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 648s] asciidoc: control_if.adoc: line 131: evaluating: {counter2:target-number} [ 648s] asciidoc: control_if.adoc: line 131: evaluating: {set2:target:test-usermanual__53.png} [ 648s] asciidoc: control_if.adoc: line 136: filtering: "/usr/bin/python2" "./build/filter-wrapper.py" mscgen -o "/usr/src/packages/BUILD/tests/test-usermanual__53.png" -Tpng - [ 648s] asciidoc: control_if.adoc: line 136: evaluating: {counter:figure-number} [ 648s] asciidoc: control_if.adoc: line 152: evaluating: {counter:table-number} [ 648s] asciidoc: include: /usr/src/packages/BUILD/common/chapters/mncc.adoc [ 648s] asciidoc: test-usermanual.adoc: line 31: reading: /usr/src/packages/BUILD/common/chapters/mncc.adoc [ 649s] asciidoc: include: /usr/src/packages/BUILD/common/chapters/bts.adoc [ 649s] asciidoc: test-usermanual.adoc: line 32: reading: /usr/src/packages/BUILD/common/chapters/bts.adoc [ 650s] asciidoc: bts.adoc: line 305: evaluating: {counter:table-number} [ 650s] make[3]: *** [../build/Makefile.asciidoc.inc:69: test-usermanual.pdf] Error 1 [ 650s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 650s] make[2]: *** [Makefile:438: all-recursive] Error 1 [ 650s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 650s] make[1]: *** [Makefile:362: all] Error 2 [ 650s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 650s] dh_auto_build: make -j1 returned exit code 2 [ 650s] make: *** [debian/rules:5: binary] Error 2 [ 650s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 650s] [ 650s] obs-arm-5 failed "build osmo-gsm-manuals-dev_0.1.1.5.abad.dsc" at Sun Jul 28 07:28:54 UTC 2019. [ 650s] [ 650s] ### VM INTERACTION START ### [ 653s] [ 616.998720] sysrq: SysRq : Power Off [ 653s] [ 617.011072] reboot: Power down [ 654s] ### VM INTERACTION END ### [ 654s] [ 654s] obs-arm-5 failed "build osmo-gsm-manuals-dev_0.1.1.5.abad.dsc" at Sun Jul 28 07:28:58 UTC 2019. [ 654s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 29 02:35:45 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 29 Jul 2019 02:35:45 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals-debian8-jessie in xUbuntu_16.04/i586 In-Reply-To: References: Message-ID: <5d3e5b997610_220f2b22a1a045f81013ce@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals-debian8-jessie/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-gsm-manuals-debian8-jessie failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals-debian8-jessie Last lines of build log: [ 187s] asciidoc -v -f ../build/mscgen-filter.conf -f ../build/diag-filter.conf -f ../build/docinfo-releaseinfo.conf -f ../build/python2-filter.conf -a srcdir='.' -a commondir='../common' test-usermanual.adoc > test-usermanual.check 2>&1 [ 216s] # Make absolutely sure that the %.check target is updated. [ 216s] touch test-usermanual.check [ 216s] # Do print the WARNING output but return error if any was found [ 216s] # (grep -v would omit the WARNING output from the log). [ 216s] asciidoc: WARNING: mgcp_extension_osmux.adoc: line 2: section title out of sequence: expected level 1, got level 2 [ 216s] ../build/Makefile.asciidoc.inc:87: recipe for target 'test-usermanual.check' failed [ 216s] make[3]: *** [test-usermanual.check] Error 1 [ 216s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 216s] Makefile:438: recipe for target 'check-recursive' failed [ 216s] make[2]: *** [check-recursive] Error 1 [ 216s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 216s] Makefile:729: recipe for target 'check' failed [ 216s] make[1]: *** [check] Error 2 [ 216s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 216s] dh_auto_test: make -j1 check returned exit code 2 [ 216s] debian/rules:5: recipe for target 'binary' failed [ 216s] make: *** [binary] Error 2 [ 216s] dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 [ 216s] [ 216s] lamb04 failed "build osmo-gsm-manuals-dev_0.1.1.6.a20f.dsc" at Mon Jul 29 02:35:31 UTC 2019. [ 216s] [ 216s] ### VM INTERACTION START ### [ 219s] [ 206.749620] sysrq: SysRq : Power Off [ 219s] [ 206.757251] reboot: Power down [ 219s] ### VM INTERACTION END ### [ 219s] [ 219s] lamb04 failed "build osmo-gsm-manuals-dev_0.1.1.6.a20f.dsc" at Mon Jul 29 02:35:35 UTC 2019. [ 219s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From admin at opensuse.org Mon Jul 29 03:48:55 2019 From: admin at opensuse.org (OBS Notification) Date: Mon, 29 Jul 2019 03:48:55 +0000 Subject: Build failure of network:osmocom:nightly/osmo-gsm-manuals in Debian_Testing/x86_64 In-Reply-To: References: Message-ID: <5d3e6cb7c7c8_220f2b22a1a045f8103924@build.opensuse.org> Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-gsm-manuals/Debian_Testing/x86_64 Package network:osmocom:nightly/osmo-gsm-manuals failed to build in Debian_Testing/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-gsm-manuals Last lines of build log: [ 342s] asciidoc: cell-broadcast.adoc: line 46: reading: /usr/src/packages/BUILD/common/chapters/osmocom-cbs.msc [ 342s] asciidoc: cell-broadcast.adoc: line 45: evaluating: {counter2:target-number} [ 342s] asciidoc: cell-broadcast.adoc: line 45: evaluating: {set2:target:test-usermanual__53.png} [ 342s] asciidoc: osmocom-cbs.msc: line 12: filtering: "/usr/bin/python2" "./build/filter-wrapper.py" mscgen -o "/usr/src/packages/BUILD/tests/test-usermanual__53.png" -Tpng - [ 343s] asciidoc: include: /usr/src/packages/BUILD/common/chapters/port_numbers.adoc [ 343s] asciidoc: test-usermanual.adoc: line 31: reading: /usr/src/packages/BUILD/common/chapters/port_numbers.adoc [ 343s] asciidoc: port_numbers.adoc: line 50: evaluating: {counter:table-number} [ 343s] asciidoc: include: /usr/src/packages/BUILD/common/chapters/bts.adoc [ 343s] asciidoc: test-usermanual.adoc: line 32: reading: /usr/src/packages/BUILD/common/chapters/bts.adoc [ 343s] asciidoc: bts.adoc: line 305: evaluating: {counter:table-number} [ 343s] make[3]: *** [../build/Makefile.asciidoc.inc:69: test-usermanual.pdf] Error 1 [ 343s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests' [ 343s] make[2]: *** [Makefile:438: all-recursive] Error 1 [ 343s] make[2]: Leaving directory '/usr/src/packages/BUILD' [ 343s] make[1]: *** [Makefile:362: all] Error 2 [ 343s] make[1]: Leaving directory '/usr/src/packages/BUILD' [ 343s] dh_auto_build: make -j1 returned exit code 2 [ 343s] make: *** [debian/rules:5: binary] Error 255 [ 343s] dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2 [ 343s] [ 343s] lamb28 failed "build osmo-gsm-manuals-dev_0.1.1.5.abad.dsc" at Mon Jul 29 03:48:50 UTC 2019. [ 343s] [ 343s] ### VM INTERACTION START ### [ 347s] [ 329.135464] sysrq: SysRq : Power Off [ 347s] [ 329.140959] reboot: Power down [ 347s] ### VM INTERACTION END ### [ 347s] [ 347s] lamb28 failed "build osmo-gsm-manuals-dev_0.1.1.5.abad.dsc" at Mon Jul 29 03:48:54 UTC 2019. [ 347s] -- Configure notifications at https://build.opensuse.org/user/notifications openSUSE Build Service (https://build.opensuse.org/) From gerrit-no-reply at lists.osmocom.org Mon Jul 29 08:13:17 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Mon, 29 Jul 2019 08:13:17 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-gbproxy.cfg: fix conflict with osmo-sgsn.cfg In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14957 ) Change subject: osmo-gbproxy.cfg: fix conflict with osmo-sgsn.cfg ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6e3053de8885a7954296d820c6a069d06276e4df Gerrit-Change-Number: 14957 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 08:13:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 08:26:37 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Jul 2019 08:26:37 +0000 Subject: Change in ...osmo-sgsn[master]: osmo-gbproxy.cfg: fix conflict with osmo-sgsn.cfg In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14957 ) Change subject: osmo-gbproxy.cfg: fix conflict with osmo-sgsn.cfg ...................................................................... osmo-gbproxy.cfg: fix conflict with osmo-sgsn.cfg Listen on 127.0.0.100 by default, so there is no conflict on 127.0.0.1:23000. This allows starting both services with their default configuration, like we are doing it in the Osmocom-Debian-install-* jenkins jobs. Related: OS#3369 Change-Id: I6e3053de8885a7954296d820c6a069d06276e4df --- M doc/examples/osmo-gbproxy/osmo-gbproxy.cfg 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Vadim Yanitskiy: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg b/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg index 0c3917a..29f698f 100644 --- a/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg +++ b/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg @@ -22,4 +22,5 @@ timer tns-alive-retries 10 encapsulation framerelay-gre enabled 0 encapsulation framerelay-gre local-ip 0.0.0.0 + encapsulation udp local-ip 127.0.0.100 encapsulation udp local-port 23000 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6e3053de8885a7954296d820c6a069d06276e4df Gerrit-Change-Number: 14957 Gerrit-PatchSet: 3 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 08:29:37 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Mon, 29 Jul 2019 08:29:37 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: systemctl status -n 200 In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14958 ) Change subject: debian-repo-install-test: systemctl status -n 200 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic72dbf1b4c59a259139187b98e74211d57534dc2 Gerrit-Change-Number: 14958 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 08:29:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 08:50:52 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Jul 2019 08:50:52 +0000 Subject: Change in ...docker-playground[master]: debian-repo-install-test: systemctl status -n 200 In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14958 ) Change subject: debian-repo-install-test: systemctl status -n 200 ...................................................................... debian-repo-install-test: systemctl status -n 200 Show up to 200 log lines instead of the default (10). Related: OS#3369 Change-Id: Ic72dbf1b4c59a259139187b98e74211d57534dc2 --- M debian-repo-install-test/testdata/repo-install-test.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Verified laforge: Looks good to me, approved Vadim Yanitskiy: Looks good to me, but someone else must approve diff --git a/debian-repo-install-test/testdata/repo-install-test.sh b/debian-repo-install-test/testdata/repo-install-test.sh index 338fe8d..4fae488 100755 --- a/debian-repo-install-test/testdata/repo-install-test.sh +++ b/debian-repo-install-test/testdata/repo-install-test.sh @@ -123,7 +123,7 @@ sleep 2 for service in $services_feed; do - if ! systemctl --no-pager -l status $service; then + if ! systemctl --no-pager -l -n 200 status $service; then failed="$failed $service" fi done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic72dbf1b4c59a259139187b98e74211d57534dc2 Gerrit-Change-Number: 14958 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 09:52:50 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 29 Jul 2019 09:52:50 +0000 Subject: Change in ...docker-playground[master]: osmo-hnbgw-master: Bind Iuh socket to 0.0.0.0 Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/14977 Change subject: osmo-hnbgw-master: Bind Iuh socket to 0.0.0.0 ...................................................................... osmo-hnbgw-master: Bind Iuh socket to 0.0.0.0 Change-Id: I117fb440beaf4fcecde705e1e6d7e0d43e1226e4 Related: OS#2589 --- M osmo-hnbgw-master/osmo-hnbgw.cfg 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/77/14977/1 diff --git a/osmo-hnbgw-master/osmo-hnbgw.cfg b/osmo-hnbgw-master/osmo-hnbgw.cfg index 4c7e75b..5608e3e 100644 --- a/osmo-hnbgw-master/osmo-hnbgw.cfg +++ b/osmo-hnbgw-master/osmo-hnbgw.cfg @@ -32,7 +32,7 @@ point-code 0.23.4 hnbgw iuh - local-ip 172.18.0.170 + local-ip 0.0.0.0 hnbap-allow-tmsi 1 iucs remote-addr msc -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I117fb440beaf4fcecde705e1e6d7e0d43e1226e4 Gerrit-Change-Number: 14977 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 10:12:29 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 29 Jul 2019 10:12:29 +0000 Subject: Change in ...osmo-iuh[master]: Add VTY reference manual Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14978 Change subject: Add VTY reference manual ...................................................................... Add VTY reference manual Fixes: OS#2589 Change-Id: I042734fa9979b598d5471839e408cbf39bba57b5 --- M configure.ac M doc/Makefile.am A doc/manuals/Makefile.am A doc/manuals/osmohnbgw-vty-reference.xml A doc/manuals/regen_doc.sh A doc/manuals/vty/hnbgw_vty_additions.xml A doc/manuals/vty/hnbgw_vty_reference.xml 7 files changed, 1,651 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/78/14978/1 diff --git a/configure.ac b/configure.ac index 559db39..dc3d1eb 100644 --- a/configure.ac +++ b/configure.ac @@ -79,6 +79,48 @@ CFLAGS="$CFLAGS -Wall" CPPFLAGS="$CPPFLAGS -Wall" +# Generate manuals +AC_ARG_ENABLE(manuals, + [AS_HELP_STRING( + [--enable-manuals], + [Generate manual PDFs [default=no]], + )], + [osmo_ac_build_manuals=$enableval], [osmo_ac_build_manuals="no"]) +AM_CONDITIONAL([BUILD_MANUALS], [test x"$osmo_ac_build_manuals" = x"yes"]) +AC_ARG_VAR(OSMO_GSM_MANUALS_DIR, [path to common osmo-gsm-manuals files, overriding pkg-config and "../osmo-gsm-manuals" + fallback]) +if test x"$osmo_ac_build_manuals" = x"yes" +then + # Find OSMO_GSM_MANUALS_DIR (env, pkg-conf, fallback) + if test -n "$OSMO_GSM_MANUALS_DIR"; then + echo "checking for OSMO_GSM_MANUALS_DIR... $OSMO_GSM_MANUALS_DIR (from env)" + else + OSMO_GSM_MANUALS_DIR="$($PKG_CONFIG osmo-gsm-manuals --variable=osmogsmmanualsdir 2>/dev/null)" + if test -n "$OSMO_GSM_MANUALS_DIR"; then + echo "checking for OSMO_GSM_MANUALS_DIR... $OSMO_GSM_MANUALS_DIR (from pkg-conf)" + else + OSMO_GSM_MANUALS_DIR="../osmo-gsm-manuals" + echo "checking for OSMO_GSM_MANUALS_DIR... $OSMO_GSM_MANUALS_DIR (fallback)" + fi + fi + if ! test -d "$OSMO_GSM_MANUALS_DIR"; then + AC_MSG_ERROR("OSMO_GSM_MANUALS_DIR does not exist! Install osmo-gsm-manuals or set OSMO_GSM_MANUALS_DIR.") + fi + + # Find and run check-depends + CHECK_DEPENDS="$OSMO_GSM_MANUALS_DIR/check-depends.sh" + if ! test -x "$CHECK_DEPENDS"; then + CHECK_DEPENDS="osmo-gsm-manuals-check-depends" + fi + if ! $CHECK_DEPENDS; then + AC_MSG_ERROR("missing dependencies for --enable-manuals") + fi + + # Put in Makefile with absolute path + OSMO_GSM_MANUALS_DIR="$(realpath "$OSMO_GSM_MANUALS_DIR")" + AC_SUBST([OSMO_GSM_MANUALS_DIR]) +fi + # https://www.freedesktop.org/software/systemd/man/daemon.html AC_ARG_WITH([systemdsystemunitdir], [AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd service files])],, @@ -114,6 +156,7 @@ include/osmocom/iuh/Makefile doc/Makefile doc/examples/Makefile + doc/manuals/Makefile contrib/Makefile contrib/systemd/Makefile ) diff --git a/doc/Makefile.am b/doc/Makefile.am index 81a25e2..eeed875 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -1,4 +1,7 @@ -SUBDIRS = examples +SUBDIRS = \ + examples \ + manuals \ + $(NULL) EXTRA_DIST = \ hnb_cs_lu.msc \ diff --git a/doc/manuals/Makefile.am b/doc/manuals/Makefile.am new file mode 100644 index 0000000..91aa8f8 --- /dev/null +++ b/doc/manuals/Makefile.am @@ -0,0 +1,12 @@ +EXTRA_DIST = \ + osmohnbgw-vty-reference.xml \ + regen_doc.sh \ + vty + +if BUILD_MANUALS + VTY_REFERENCE = osmohnbgw-vty-reference.xml + include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.vty-reference.inc + + OSMO_REPOSITORY = osmo-hnbgw + include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.common.inc +endif diff --git a/doc/manuals/osmohnbgw-vty-reference.xml b/doc/manuals/osmohnbgw-vty-reference.xml new file mode 100644 index 0000000..cd69333 --- /dev/null +++ b/doc/manuals/osmohnbgw-vty-reference.xml @@ -0,0 +1,38 @@ + + + + +]> + + + + + + v1 + 29th July 2019 + dw + Initial + + + + OsmoHNBGW VTY Reference + + + 2019 + + + + This work is copyright by sysmocom - s.f.m.c. GmbH. All rights reserved. + + + + + + &chapter-vty; + + diff --git a/doc/manuals/regen_doc.sh b/doc/manuals/regen_doc.sh new file mode 100755 index 0000000..39dd9ee --- /dev/null +++ b/doc/manuals/regen_doc.sh @@ -0,0 +1,17 @@ +#!/bin/sh -x + +if [ -z "$DOCKER_PLAYGROUND" ]; then + echo "You need to set DOCKER_PLAYGROUND" + exit 1 +fi + +SCRIPT=$(realpath "$0") +MANUAL_DIR=$(dirname "$SCRIPT") + +COMMIT=${COMMIT:-$(git log -1 --format=format:%H)} + +cd "$DOCKER_PLAYGROUND/scripts" || exit 1 + +OSMO_SGSN_BRANCH=$COMMIT ./regen_doc.sh osmo-hnbgw 4261 \ + "$MANUAL_DIR/chapters/counters_generated.adoc" \ + "$MANUAL_DIR/vty/hnbgw_vty_reference.xml" diff --git a/doc/manuals/vty/hnbgw_vty_additions.xml b/doc/manuals/vty/hnbgw_vty_additions.xml new file mode 100644 index 0000000..a4c675e --- /dev/null +++ b/doc/manuals/vty/hnbgw_vty_additions.xml @@ -0,0 +1,2 @@ + + diff --git a/doc/manuals/vty/hnbgw_vty_reference.xml b/doc/manuals/vty/hnbgw_vty_reference.xml new file mode 100644 index 0000000..4046636 --- /dev/null +++ b/doc/manuals/vty/hnbgw_vty_reference.xml @@ -0,0 +1,1535 @@ + + + Common Commands + These commands are available on all VTY nodes. They are listed here only once, to unclutter the VTY reference. + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + view + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + enable + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-log + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-line + + + + + + + + + + + + + + + + + + + + + config-cs7 + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-cs7-as + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-cs7-asp + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-cs7-sccpaddr + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-cs7-sccpaddr-gt + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-hnbgw + + + + + + + + + + + + + + + + + + + + + + + + config-hnbgw-iuh + + + + + + + + + + + + + + + + + + + + + + config-hnbgw-iucs + + + + + + + + + config-hnbgw-iups + + + + + + + + -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14978 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I042734fa9979b598d5471839e408cbf39bba57b5 Gerrit-Change-Number: 14978 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 12:40:36 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 12:40:36 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: use DLGLOBAL logging sub-system In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14970 ) Change subject: vty/telnet_interface.c: use DLGLOBAL logging sub-system ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1564f4714a33d36792e4982deb8f19d1b740dc0c Gerrit-Change-Number: 14970 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 12:40:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 12:41:32 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 12:41:32 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: avoid unneeded initialization In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14971 ) Change subject: vty/telnet_interface.c: avoid unneeded initialization ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If9fd2826f132dfa203dda62940d93dbdfcfd92ac Gerrit-Change-Number: 14971 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 12:41:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 12:47:46 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 12:47:46 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/14972/1/src/vty/telnet_interface.c File src/vty/telnet_interface.c: https://gerrit.osmocom.org/#/c/14972/1/src/vty/telnet_interface.c at 131 PS1, Line 131: rc = getsockname(fd->fd, (struct sockaddr *) &sockaddr, &len); What about using osmo_sock_get_name_buf() here? https://gerrit.osmocom.org/#/c/14972/1/src/vty/telnet_interface.c at 187 PS1, Line 187: inet_ntoa(sockaddr.sin_addr), ntohs(sockaddr.sin_port)); Let's use inet_ntop, which is thread-safe. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c Gerrit-Change-Number: 14972 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 12:47:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 12:54:15 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 12:54:15 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: fix vty_execute(): prevent further heap-buffer overrun In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 ) Change subject: vty/vty.c: fix vty_execute(): prevent further heap-buffer overrun ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14973/1/src/vty/vty.c File src/vty/vty.c: https://gerrit.osmocom.org/#/c/14973/1/src/vty/vty.c at 690 PS1, Line 690: vty->buf[vty->length] = '\0'; Rather move this to vty_read(), immediately before read() call. Let's assume in vty_execute that vty->buf is null-terminate, that'd be more sane for everybody. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82f774ad18d0e555eb8f3590a519946d9c583c78 Gerrit-Change-Number: 14973 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 12:54:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 12:59:37 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 12:59:37 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: log received commands from telnet interface In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14974 ) Change subject: vty/vty.c: log received commands from telnet interface ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14974/1/src/vty/vty.c File src/vty/vty.c: https://gerrit.osmocom.org/#/c/14974/1/src/vty/vty.c at 441 PS1, Line 441: What about moving the code in here and then you can probably drop the vty->length>0 condition? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f6639f6ebc3e8f8df50ef48538df94285b759fd Gerrit-Change-Number: 14974 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 12:59:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 13:00:48 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 13:00:48 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 ) Change subject: vty/vty.c: the command buffer can be accessed directly ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39 Gerrit-Change-Number: 14975 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 13:00:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 13:01:51 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 13:01:51 +0000 Subject: Change in ...libosmocore[master]: vty/logging_vty.c: fix writing of 'print category-hex' In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14976 ) Change subject: vty/logging_vty.c: fix writing of 'print category-hex' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I33837f0fac1afe83596fa600916abc05ecb8c356 Gerrit-Change-Number: 14976 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 13:01:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 13:02:15 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 13:02:15 +0000 Subject: Change in ...osmo-ci[master]: jobs: upload to OBS before debian-install test In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14959 ) Change subject: jobs: upload to OBS before debian-install test ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I503058018172d50e9585d4804dfec1b4ece7644a Gerrit-Change-Number: 14959 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 13:02:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 13:04:01 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 13:04:01 +0000 Subject: Change in ...docker-playground[master]: osmo-hnbgw-master: Bind Iuh socket to 0.0.0.0 In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14977 ) Change subject: osmo-hnbgw-master: Bind Iuh socket to 0.0.0.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I117fb440beaf4fcecde705e1e6d7e0d43e1226e4 Gerrit-Change-Number: 14977 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 13:04:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 13:14:45 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 13:14:45 +0000 Subject: Change in ...osmo-gsm-manuals[master]: mgcp_extension_osmux.adoc: Workaround make check failures In-Reply-To: References: Message-ID: pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14967 ) Change subject: mgcp_extension_osmux.adoc: Workaround make check failures ...................................................................... Abandoned Abandoning since this patch itself seems to be introducing issues, and the original cause for this patch to exist seems to have magically auto-fixed. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I57ab562d5976b400085e8a38224b7d28179fc8ef Gerrit-Change-Number: 14967 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 13:16:52 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Mon, 29 Jul 2019 13:16:52 +0000 Subject: Change in ...osmo-ci[master]: jobs: upload to OBS before debian-install test In-Reply-To: References: Message-ID: osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/14959 ) Change subject: jobs: upload to OBS before debian-install test ...................................................................... jobs: upload to OBS before debian-install test Make sure that we don't test yesterday's packages. Adjust timers to run the OBS job around 1 o'clock, and the debian-install test around 4 o'clock. Use the H (hash) symbol for minute to spread the load. Change-Id: I503058018172d50e9585d4804dfec1b4ece7644a --- M jobs/osmocom-debian-install.yml M jobs/osmocom-obs.yml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: osmith: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/jobs/osmocom-debian-install.yml b/jobs/osmocom-debian-install.yml index 1f6c62a..26b7fa0 100644 --- a/jobs/osmocom-debian-install.yml +++ b/jobs/osmocom-debian-install.yml @@ -35,7 +35,7 @@ git-config-name: 'Jenkins Builder' git-config-email: 'jenkins at osmocom.org' triggers: - - timed: "@midnight" + - timed: "H 04 * * *" # run after osmocom-obs.yml publishers: - email: notify-every-unstable-build: true diff --git a/jobs/osmocom-obs.yml b/jobs/osmocom-obs.yml index 023ab0c..fe03f86 100644 --- a/jobs/osmocom-obs.yml +++ b/jobs/osmocom-obs.yml @@ -35,7 +35,7 @@ git-config-name: 'Jenkins Builder' git-config-email: 'jenkins at osmocom.org' triggers: - - timed: "@midnight" + - timed: "H 01 * * *" # run before osmocom-debian-install.yml publishers: - email: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I503058018172d50e9585d4804dfec1b4ece7644a Gerrit-Change-Number: 14959 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 14:20:00 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 29 Jul 2019 14:20:00 +0000 Subject: Change in ...docker-playground[master]: osmo-hnbgw-master: Bind Iuh socket to 0.0.0.0 In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14977 ) Change subject: osmo-hnbgw-master: Bind Iuh socket to 0.0.0.0 ...................................................................... Patch Set 1: Verified+1 Works for regen_docs and can't break a non-existent ttcn3 test. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I117fb440beaf4fcecde705e1e6d7e0d43e1226e4 Gerrit-Change-Number: 14977 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 14:20:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 14:20:11 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 29 Jul 2019 14:20:11 +0000 Subject: Change in ...docker-playground[master]: osmo-hnbgw-master: Bind Iuh socket to 0.0.0.0 In-Reply-To: References: Message-ID: daniel has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/docker-playground/+/14977 ) Change subject: osmo-hnbgw-master: Bind Iuh socket to 0.0.0.0 ...................................................................... osmo-hnbgw-master: Bind Iuh socket to 0.0.0.0 Change-Id: I117fb440beaf4fcecde705e1e6d7e0d43e1226e4 Related: OS#2589 --- M osmo-hnbgw-master/osmo-hnbgw.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved daniel: Verified diff --git a/osmo-hnbgw-master/osmo-hnbgw.cfg b/osmo-hnbgw-master/osmo-hnbgw.cfg index 4c7e75b..5608e3e 100644 --- a/osmo-hnbgw-master/osmo-hnbgw.cfg +++ b/osmo-hnbgw-master/osmo-hnbgw.cfg @@ -32,7 +32,7 @@ point-code 0.23.4 hnbgw iuh - local-ip 172.18.0.170 + local-ip 0.0.0.0 hnbap-allow-tmsi 1 iucs remote-addr msc -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I117fb440beaf4fcecde705e1e6d7e0d43e1226e4 Gerrit-Change-Number: 14977 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 14:50:33 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 29 Jul 2019 14:50:33 +0000 Subject: Change in ...osmo-mgw[master]: Fix return variable of strtoul() In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14966 ) Change subject: Fix return variable of strtoul() ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp-client/mgcp_client.c File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp-client/mgcp_client.c at 312 PS1, Line 312: r->codecs[count] = pt; r->codecs[] is an enum which will probably only be int in size. As RTP pt is 7-bit anyway does it make sense to limit the range of pt to [0,127] here and goto response_parse_failure_pt in case it's outside? https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp/mgcp_sdp.c File src/libosmo-mgcp/mgcp_sdp.c: https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp/mgcp_sdp.c at 168 PS1, Line 168: if (codecs[i].payload_type == pt) Here as well -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ice9eee6a252fab73dbab5ebf3cfc83c1b354fd08 Gerrit-Change-Number: 14966 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 14:50:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 14:56:13 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 14:56:13 +0000 Subject: Change in ...libosmocore[master]: gsm0808_test: Fix wrong use of memcp Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14979 Change subject: gsm0808_test: Fix wrong use of memcp ...................................................................... gsm0808_test: Fix wrong use of memcp After recent system upgrade, gcc 9.1.0, I started getting gsm0808_test failing locally: Assert failed memcmp(&enc_ct, &dec_ct, sizeof(enc_ct)) == 0 libosmocore/tests/gsm0808/gsm0808_test.c:992 During investigation with gdb, fields of both structures seem to contain same values. However, closer lookup gives some hints on why it fails: (gdb) print memcmp(&enc_ct, &dec_ct, sizeof(enc_ct)) $1 = 85 (gdb) print memcmp(&enc_ct, &dec_ct, 12) $14 = 85 (gdb) print ((uint8_t*)&enc_ct)[11] $15 = 85 'U' (gdb) print ((uint8_t*)&dec_ct)[11] $16 = 0 '\000' So the 12th byte in struct gsm0808_channel_type is basically an alignment padding byte added by the compiler (to align perm_spch_len to 4-byte alignment). Since both compared structs are initialized without memset(0) but using compiler's designated initializers, it seems the compiler decided it's no longer needed to zero the padding byte, making memcp fail in this case. In order to avoid the failure, let's properly check every field instead of using memcp here. Change-Id: I17fe7a0a5dc650f050bba1f47d071be749550729 --- M tests/gsm0808/gsm0808_test.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/79/14979/1 diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c index 8f1e299..2389218 100644 --- a/tests/gsm0808/gsm0808_test.c +++ b/tests/gsm0808/gsm0808_test.c @@ -989,7 +989,10 @@ rc_dec = gsm0808_dec_channel_type(&dec_ct, msg->data + 2, msg->len - 2); OSMO_ASSERT(rc_dec == 4); - OSMO_ASSERT(memcmp(&enc_ct, &dec_ct, sizeof(enc_ct)) == 0); + OSMO_ASSERT(enc_ct.ch_indctr == dec_ct.ch_indctr); + OSMO_ASSERT(enc_ct.ch_rate_type == dec_ct.ch_rate_type); + OSMO_ASSERT(enc_ct.perm_spch_len == dec_ct.perm_spch_len); + OSMO_ASSERT(memcmp(&enc_ct.perm_spch[0], &dec_ct.perm_spch[0], enc_ct.perm_spch_len) == 0); msgb_free(msg); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I17fe7a0a5dc650f050bba1f47d071be749550729 Gerrit-Change-Number: 14979 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 15:00:55 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 29 Jul 2019 15:00:55 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 ) Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc at 319 PS2, Line 319: +-----------------+---------------------------------------+ . 1 1 0 X seems to be missing. Reserved as well? -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 Gerrit-Change-Number: 14940 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-Comment-Date: Mon, 29 Jul 2019 15:00:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 15:01:50 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 15:01:50 +0000 Subject: Change in ...osmo-mgw[master]: Fix return variable of strtoul() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14966 ) Change subject: Fix return variable of strtoul() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp-client/mgcp_client.c File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp-client/mgcp_client.c at 312 PS1, Line 312: r->codecs[count] = pt; > r->codecs[] is an enum which will probably only be int in size. [?] How you provide feedback on where pt is specified being 7-bit and why? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ice9eee6a252fab73dbab5ebf3cfc83c1b354fd08 Gerrit-Change-Number: 14966 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 15:01:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 16:02:35 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 29 Jul 2019 16:02:35 +0000 Subject: Change in ...osmo-mgw[master]: Fix return variable of strtoul() In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14966 ) Change subject: Fix return variable of strtoul() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp-client/mgcp_client.c File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp-client/mgcp_client.c at 312 PS1, Line 312: r->codecs[count] = pt; > How you provide feedback on where pt is specified being 7-bit and why? Lots of places only specify 0-127 as values (with the latter being dynamic). So I looked into the RTP spec and the field there is 7-bit wide. See https://tools.ietf.org/html/rfc3550#section-5 field PT. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ice9eee6a252fab73dbab5ebf3cfc83c1b354fd08 Gerrit-Change-Number: 14966 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 16:02:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 16:06:46 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 16:06:46 +0000 Subject: Change in ...osmo-ggsn[master]: sgsnemu: Fix unaligned pointer access during ip/icmp checksum Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14980 Change subject: sgsnemu: Fix unaligned pointer access during ip/icmp checksum ...................................................................... sgsnemu: Fix unaligned pointer access during ip/icmp checksum Catched by gcc 9.1.0: osmo-ggsn/sgsnemu/sgsnemu.c:1294:2: error: converting a packed struct ip_ping pointer (alignment 1) to a uint16_t {aka short unsigned int} pointer (alignment 2) may result in an unaligned pointer value [-Werror=address-of-packed-member] 1294 | p = (uint16_t *) & pack; Change-Id: I783f104c31234a07f2a13f6dbc577a71b25b36a7 --- M sgsnemu/sgsnemu.c 1 file changed, 12 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/80/14980/1 diff --git a/sgsnemu/sgsnemu.c b/sgsnemu/sgsnemu.c index 8e41031..4f1f844 100644 --- a/sgsnemu/sgsnemu.c +++ b/sgsnemu/sgsnemu.c @@ -1234,7 +1234,7 @@ { struct ip_ping pack; - uint16_t *p = (uint16_t *) & pack; + uint16_t v16; uint8_t *p8 = (uint8_t *) & pack; struct in_addr src; unsigned int n; @@ -1270,7 +1270,7 @@ pack.seq = htons(seq); /* Generate ICMP payload */ - p8 = (uint8_t *) & pack + CREATEPING_IP + CREATEPING_ICMP; + p8 = (uint8_t *) &pack + CREATEPING_IP + CREATEPING_ICMP; for (n = 0; n < (datasize); n++) p8[n] = n; @@ -1278,11 +1278,13 @@ gettimeofday(tp, &tz); /* Calculate IP header checksum */ - p = (uint16_t *) & pack; + p8 = (uint8_t *) &pack; count = CREATEPING_IP; sum = 0; while (count > 1) { - sum += *p++; + memcpy(&v16, p8, 2); + sum += v16; + p8 += 2; count -= 2; } while (sum >> 16) @@ -1292,14 +1294,16 @@ /* Calculate ICMP checksum */ count = CREATEPING_ICMP + datasize; /* Length of ICMP message */ sum = 0; - p = (uint16_t *) & pack; - p += CREATEPING_IP / 2; + p8 = (uint8_t *) &pack; + p8 += CREATEPING_IP; while (count > 1) { - sum += *p++; + memcpy(&v16, p8, 2); + sum += v16; + p8 += 2; count -= 2; } if (count > 0) - sum += *(unsigned char *)p; + sum += *(unsigned char *)p8; while (sum >> 16) sum = (sum & 0xffff) + (sum >> 16); pack.checksum = ~sum; -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I783f104c31234a07f2a13f6dbc577a71b25b36a7 Gerrit-Change-Number: 14980 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 16:11:48 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Jul 2019 16:11:48 +0000 Subject: Change in ...docker-playground[master]: adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7 In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14764 ) Change subject: adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7 ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14764/1/ttcn3-bsc-test/osmo-bsc.cfg File ttcn3-bsc-test/osmo-bsc.cfg: https://gerrit.osmocom.org/#/c/14764/1/ttcn3-bsc-test/osmo-bsc.cfg at 69 PS1, Line 69: handover 1 > is this enabling handover? do we want to enable it by default? or only in related tests? (not sure i [?] I'm certain that it won't change the behavior, since none of our tests actually send measurement reports. With handover turned off, I would actually have expected none of our handover tests to be successful. But so far we checked for the handover flag only while evaluating measurements, and handover tests directly trigger handovers via vty commands... Soon though the handover flag may also be needed for determining which target cells are eligible, so we better turn this on now. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14764 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1c57a04747f5ec004ccf4657954dcb0b003c24fc Gerrit-Change-Number: 14764 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 16:11:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 16:12:10 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Jul 2019 16:12:10 +0000 Subject: Change in ...docker-playground[master]: adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7 In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/14764 ) Change subject: adjust osmo-bsc.cfg for TC_ho_neighbor_config_1 thru _7 ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/14764 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I1c57a04747f5ec004ccf4657954dcb0b003c24fc Gerrit-Change-Number: 14764 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 16:12:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 16:14:11 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 29 Jul 2019 16:14:11 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Small fixes Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 Change subject: configuration.adoc: Small fixes ...................................................................... configuration.adoc: Small fixes Fix some typos, correct data compression command, add example to turn off compression. Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558 Related: OS#1720 --- M doc/manuals/chapters/configuration.adoc 1 file changed, 26 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/81/14981/1 diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index 2828987..6fe44b3 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -7,7 +7,7 @@ from the BSC side. On the other hand, it is because the Gb interface does not need an -explicit configuration of all each PCU connecting to the SGSN. The +explicit configuration of each PCU connecting to the SGSN. The administrator only has to ensure that the NS and BSSGP layer identities (NSEI, NSVCI, BVCI) are unique for each PCU connecting to the SGSN. @@ -17,7 +17,7 @@ and the GGSNs. It is implemented via UDP on well-known source and destination ports. -When a MS requests establishment of a PDP context, it specifies the APN +When an MS requests establishment of a PDP context, it specifies the APN (Access Point Name) to which the context shall be established. This APN determines which GGSN shall be used, and that in turn determines which external IP network the MS will be connected to. @@ -100,7 +100,7 @@ policy that is defined for osmo-nitb! -.Example: Assign or change authorization policy: +.Example: Assign or change authorization policy ---- OsmoSGSN> enable OsmoSGSN# configure terminal @@ -116,7 +116,7 @@ <2> Saves current changes to cofiguration to make this policy persistent -.Example: Access control list: +.Example: Access control list ---- sgsn auth-policy acl-only <1> @@ -153,7 +153,7 @@ GSM/GPRS. GSUP performs a challenge-response authentication protocol called OAP, -which uses the standard MILEAGE algorithm for mutual authentication +which uses the standard MILENAGE algorithm for mutual authentication between OsmoSGSN and the HLR/HLR-GW. [[sgsn-ex-gsup]] @@ -251,9 +251,9 @@ === User traffic compression -In order to save optimize GPRS bandwith, OsmoSGSN implements header and data -compression schemes. The compression will reduce the packet length in order -to save radio bandwith. +In order to save GPRS bandwith, OsmoSGSN implements header and data +compression schemes. The compression will reduce the packet length in +order to save radio bandwith. ==== Header compression @@ -278,18 +278,24 @@ compression parameters entirely. The number of slots is the maximum number of packet headers per subscriber that can be stored in the codebook. -.Example: Accept compression if requested: +.Example: Accept compression if requested ---- sgsn compression rfc1144 passive ---- -.Example: Actively promote compression: +.Example: Actively promote compression ---- sgsn compression rfc1144 active slots 8 ---- +.Example: Turn off compression again +---- +sgsn + no compression rfc1144 +---- + NOTE: The usage of TCP/IP options may disturb the RFC1144 header compression scheme. TCP/IP options may render RFC1144 ineffective if variable data is encoded into the option section of the TCP/IP packet. (e.g. TCP option 8, @@ -299,10 +305,10 @@ ==== Data compression Data compression works on the raw packet data, including the header part of the -packet. If enabled, header compression is applied before first data compression +packet. If enabled, header compression is applied first before data compression is applied. OsmoSGSN implements the V.42bis data compression scheme. -*compression rfc1144 passive*:: +*compression v42bis passive*:: V42bis data compression has to be actively requested by the modem. The network will not promote compression by itself. This is the recommended mode of operation. @@ -316,14 +322,20 @@ the codebook size by the maxium number ('codewords') and size ('strlen') of entries. -.Example: Accept compression if requested: +.Example: Accept compression if requested ---- sgsn compression v42bis passive ---- -.Example: Actively promote compression: +.Example: Actively promote compression ---- sgsn compression v42bis active direction both codewords 512 strlen 20 ---- + +.Example: Turn off compression again +---- +sgsn + no compression v42bis +---- -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558 Gerrit-Change-Number: 14981 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 16:14:12 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 29 Jul 2019 16:14:12 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Add a section about encryption Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 Change subject: configuration.adoc: Add a section about encryption ...................................................................... configuration.adoc: Add a section about encryption Change-Id: I3a2b84d386f55447e9eed35e59fdc0272e5147d1 Related: OS#1720 --- M doc/manuals/chapters/configuration.adoc 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/82/14982/1 diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index 6fe44b3..9babcf4 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -339,3 +339,21 @@ sgsn no compression v42bis ---- + +=== Encryption + +Encryption can be enabled if the auth-policy is set to remote and the +HLR subscriber entries contain the keys of the SIM card. See +<> on how to connect to an external HLR. + +.Example: Turn on encryption (GEA4) +---- +sgsn + encryption GEA4 +---- + +.Example: Turn off encryption (GEA0) +---- +sgsn + encryption GEA0 +---- -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3a2b84d386f55447e9eed35e59fdc0272e5147d1 Gerrit-Change-Number: 14982 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 16:14:38 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Jul 2019 16:14:38 +0000 Subject: Change in ...osmo-bsc[master]: neighbor config: allow re-using ARFCN+BSIC pairs In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14769 ) Change subject: neighbor config: allow re-using ARFCN+BSIC pairs ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14769/1/src/osmo-bsc/handover_decision_2.c File src/osmo-bsc/handover_decision_2.c: https://gerrit.osmocom.org/#/c/14769/1/src/osmo-bsc/handover_decision_2.c at 903 PS1, Line 903: find_handover_target_cell(&neighbor_bts, &neighbor_cil, > no check for return code? the return values neighbor_bts and neighbor_cil are checked, they will both be NULL for any errors. Also, this is just collecting candidates, so it should not raise error logs, rather just yield no candidates. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29bca59ab232eddc74e0d4698efb9c9992443983 Gerrit-Change-Number: 14769 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 16:14:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 16:21:15 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 16:21:15 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Small fixes In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 ) Change subject: configuration.adoc: Small fixes ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558 Gerrit-Change-Number: 14981 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 29 Jul 2019 16:21:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 16:22:02 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 16:22:02 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Add a section about encryption In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 ) Change subject: configuration.adoc: Add a section about encryption ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3a2b84d386f55447e9eed35e59fdc0272e5147d1 Gerrit-Change-Number: 14982 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 29 Jul 2019 16:22:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 16:24:14 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 16:24:14 +0000 Subject: Change in ...osmo-bsc[master]: neighbor config: allow re-using ARFCN+BSIC pairs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14769 ) Change subject: neighbor config: allow re-using ARFCN+BSIC pairs ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/14769/1/src/osmo-bsc/handover_decision_2.c File src/osmo-bsc/handover_decision_2.c: https://gerrit.osmocom.org/#/c/14769/1/src/osmo-bsc/handover_decision_2.c at 903 PS1, Line 903: find_handover_target_cell(&neighbor_bts, &neighbor_cil, I'd usually expect an API to return error/success and then have out parameters set to meaningful values only when needed, that is, upon success. But fine anyway. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29bca59ab232eddc74e0d4698efb9c9992443983 Gerrit-Change-Number: 14769 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 16:24:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 16:35:41 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 16:35:41 +0000 Subject: Change in ...osmo-mgw[master]: Fix return variable of strtoul() In-Reply-To: References: Message-ID: Hello daniel, laforge, osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/14966 to look at the new patch set (#2). Change subject: Fix return variable of strtoul() ...................................................................... Fix return variable of strtoul() Return variable specified by strtoul() is "unsigned long int". If "unsigned int" is used, according to Coverity the return value can never be ULONG_MAX: CID 202173: Integer handling issues (CONSTANT_EXPRESSION_RESULT) "pt == 18446744073709551615UL /* 9223372036854775807L * 2UL + 1UL */" is always false regardless of the values of its operands. This occurs as the logical second operand of "&&". Furthermore, PT is 7 bit in RTP header [1], so let's avoid accepting incorrect values. [1] https://tools.ietf.org/html/rfc3550#section-5 Fixes: c5c1430a1c00ad86855ffff3df3f106bb2bce1d5 ("Catch unsigned integer MGCP parsing errors with strtoul") Fixes: Coverity CID#202172 FIxes: Coverity CID#202173 Change-Id: Ice9eee6a252fab73dbab5ebf3cfc83c1b354fd08 --- M src/libosmo-mgcp-client/mgcp_client.c M src/libosmo-mgcp/mgcp_sdp.c 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/66/14966/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ice9eee6a252fab73dbab5ebf3cfc83c1b354fd08 Gerrit-Change-Number: 14966 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 16:41:21 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Jul 2019 16:41:21 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: bsc: add TC_ho_neighbor_config_1 thru _7 In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14765 ) Change subject: bsc: add TC_ho_neighbor_config_1 thru _7 ...................................................................... Patch Set 2: Code-Review+2 combining two +1 votes, but not merging yet to wait for osmo-bsc 'no neighbors' vty command first -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14765 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia4ba0e75abd3d45a3422b2525e5f938cdc5a04cc Gerrit-Change-Number: 14765 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 16:41:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 17:11:18 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 17:11:18 +0000 Subject: Change in ...osmo-trx[master]: Remove empty ChangeLog fnd NEWS files Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14983 Change subject: Remove empty ChangeLog fnd NEWS files ...................................................................... Remove empty ChangeLog fnd NEWS files We already have debian/changelog for same purpose. This file is empty and doesn't exist on other osmocom projects. Change-Id: I5a90107476ca116bebc8569f4eb1db0fa25807a6 --- D ChangeLog D NEWS 2 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/83/14983/1 diff --git a/ChangeLog b/ChangeLog deleted file mode 100644 index e69de29..0000000 --- a/ChangeLog +++ /dev/null diff --git a/NEWS b/NEWS deleted file mode 100644 index e69de29..0000000 --- a/NEWS +++ /dev/null -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5a90107476ca116bebc8569f4eb1db0fa25807a6 Gerrit-Change-Number: 14983 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 17:11:19 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 17:11:19 +0000 Subject: Change in ...osmo-trx[master]: Remove unused autogen.sh Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14984 Change subject: Remove unused autogen.sh ...................................................................... Remove unused autogen.sh autoreconf is used instead, as done in all of the osmocom projects. Change-Id: I87676cdf6818b4250f478962baf96ad5f28564d5 --- M Makefile.am D autogen.sh M debian/copyright 3 files changed, 1 insertion(+), 1,585 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/84/14984/1 diff --git a/Makefile.am b/Makefile.am index 79c4e06..3e87200 100644 --- a/Makefile.am +++ b/Makefile.am @@ -36,7 +36,6 @@ tests EXTRA_DIST = \ - autogen.sh \ INSTALLATION \ LEGAL \ COPYING \ diff --git a/autogen.sh b/autogen.sh deleted file mode 100755 index b2ed160..0000000 --- a/autogen.sh +++ /dev/null @@ -1,1578 +0,0 @@ -#!/bin/sh -# a u t o g e n . s h -# -# Copyright (c) 2005-2009 United States Government as represented by -# the U.S. Army Research Laboratory. -# -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions -# are met: -# -# 1. Redistributions of source code must retain the above copyright -# notice, this list of conditions and the following disclaimer. -# -# 2. Redistributions in binary form must reproduce the above -# copyright notice, this list of conditions and the following -# disclaimer in the documentation and/or other materials provided -# with the distribution. -# -# 3. The name of the author may not be used to endorse or promote -# products derived from this software without specific prior written -# permission. -# -# THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS -# OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED -# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE -# ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY -# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL -# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE -# GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS -# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, -# WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING -# NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS -# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -# -### -# -# Script for automatically preparing the sources for compilation by -# performing the myrid of necessary steps. The script attempts to -# detect proper version support, and outputs warnings about particular -# systems that have autotool peculiarities. -# -# Basically, if everything is set up and installed correctly, the -# script will validate that minimum versions of the GNU Build System -# tools are installed, account for several common configuration -# issues, and then simply run autoreconf for you. -# -# If autoreconf fails, which can happen for many valid configurations, -# this script proceeds to run manual preparation steps effectively -# providing a POSIX shell script (mostly complete) reimplementation of -# autoreconf. -# -# The AUTORECONF, AUTOCONF, AUTOMAKE, LIBTOOLIZE, ACLOCAL, AUTOHEADER -# environment variables and corresponding _OPTIONS variables (e.g. -# AUTORECONF_OPTIONS) may be used to override the default automatic -# detection behaviors. Similarly the _VERSION variables will override -# the minimum required version numbers. -# -# Examples: -# -# To obtain help on usage: -# ./autogen.sh --help -# -# To obtain verbose output: -# ./autogen.sh --verbose -# -# To skip autoreconf and prepare manually: -# AUTORECONF=false ./autogen.sh -# -# To verbosely try running with an older (unsupported) autoconf: -# AUTOCONF_VERSION=2.50 ./autogen.sh --verbose -# -# Author: -# Christopher Sean Morrison -# -# Patches: -# Sebastian Pipping -# -###################################################################### - -# set to minimum acceptible version of autoconf -if [ "x$AUTOCONF_VERSION" = "x" ] ; then - AUTOCONF_VERSION=2.52 -fi -# set to minimum acceptible version of automake -if [ "x$AUTOMAKE_VERSION" = "x" ] ; then - AUTOMAKE_VERSION=1.6.0 -fi -# set to minimum acceptible version of libtool -if [ "x$LIBTOOL_VERSION" = "x" ] ; then - LIBTOOL_VERSION=1.4.2 -fi - - -################## -# ident function # -################## -ident ( ) { - # extract copyright from header - __copyright="`grep Copyright $AUTOGEN_SH | head -${HEAD_N}1 | awk '{print $4}'`" - if [ "x$__copyright" = "x" ] ; then - __copyright="`date +%Y`" - fi - - # extract version from CVS Id string - __id="$Id: autogen.sh 33925 2009-03-01 23:27:06Z brlcad $" - __version="`echo $__id | sed 's/.*\([0-9][0-9][0-9][0-9]\)[-\/]\([0-9][0-9]\)[-\/]\([0-9][0-9]\).*/\1\2\3/'`" - if [ "x$__version" = "x" ] ; then - __version="" - fi - - echo "autogen.sh build preparation script by Christopher Sean Morrison" - echo " + config.guess download patch by Sebastian Pipping (2008-12-03)" - echo "revised 3-clause BSD-style license, copyright (c) $__copyright" - echo "script version $__version, ISO/IEC 9945 POSIX shell script" -} - - -################## -# USAGE FUNCTION # -################## -usage ( ) { - echo "Usage: $AUTOGEN_SH [-h|--help] [-v|--verbose] [-q|--quiet] [-d|--download] [--version]" - echo " --help Help on $NAME_OF_AUTOGEN usage" - echo " --verbose Verbose progress output" - echo " --quiet Quiet suppressed progress output" - echo " --download Download the latest config.guess from gnulib" - echo " --version Only perform GNU Build System version checks" - echo - echo "Description: This script will validate that minimum versions of the" - echo "GNU Build System tools are installed and then run autoreconf for you." - echo "Should autoreconf fail, manual preparation steps will be run" - echo "potentially accounting for several common preparation issues. The" - - echo "AUTORECONF, AUTOCONF, AUTOMAKE, LIBTOOLIZE, ACLOCAL, AUTOHEADER," - echo "PROJECT, & CONFIGURE environment variables and corresponding _OPTIONS" - echo "variables (e.g. AUTORECONF_OPTIONS) may be used to override the" - echo "default automatic detection behavior." - echo - - ident - - return 0 -} - - -########################## -# VERSION_ERROR FUNCTION # -########################## -version_error ( ) { - if [ "x$1" = "x" ] ; then - echo "INTERNAL ERROR: version_error was not provided a version" - exit 1 - fi - if [ "x$2" = "x" ] ; then - echo "INTERNAL ERROR: version_error was not provided an application name" - exit 1 - fi - $ECHO - $ECHO "ERROR: To prepare the ${PROJECT} build system from scratch," - $ECHO " at least version $1 of $2 must be installed." - $ECHO - $ECHO "$NAME_OF_AUTOGEN does not need to be run on the same machine that will" - $ECHO "run configure or make. Either the GNU Autotools will need to be installed" - $ECHO "or upgraded on this system, or $NAME_OF_AUTOGEN must be run on the source" - $ECHO "code on another system and then transferred to here. -- Cheers!" - $ECHO -} - -########################## -# VERSION_CHECK FUNCTION # -########################## -version_check ( ) { - if [ "x$1" = "x" ] ; then - echo "INTERNAL ERROR: version_check was not provided a minimum version" - exit 1 - fi - _min="$1" - if [ "x$2" = "x" ] ; then - echo "INTERNAL ERROR: version check was not provided a comparison version" - exit 1 - fi - _cur="$2" - - # needed to handle versions like 1.10 and 1.4-p6 - _min="`echo ${_min}. | sed 's/[^0-9]/./g' | sed 's/\.\././g'`" - _cur="`echo ${_cur}. | sed 's/[^0-9]/./g' | sed 's/\.\././g'`" - - _min_major="`echo $_min | cut -d. -f1`" - _min_minor="`echo $_min | cut -d. -f2`" - _min_patch="`echo $_min | cut -d. -f3`" - - _cur_major="`echo $_cur | cut -d. -f1`" - _cur_minor="`echo $_cur | cut -d. -f2`" - _cur_patch="`echo $_cur | cut -d. -f3`" - - if [ "x$_min_major" = "x" ] ; then - _min_major=0 - fi - if [ "x$_min_minor" = "x" ] ; then - _min_minor=0 - fi - if [ "x$_min_patch" = "x" ] ; then - _min_patch=0 - fi - if [ "x$_cur_minor" = "x" ] ; then - _cur_major=0 - fi - if [ "x$_cur_minor" = "x" ] ; then - _cur_minor=0 - fi - if [ "x$_cur_patch" = "x" ] ; then - _cur_patch=0 - fi - - $VERBOSE_ECHO "Checking if ${_cur_major}.${_cur_minor}.${_cur_patch} is greater than ${_min_major}.${_min_minor}.${_min_patch}" - - if [ $_min_major -lt $_cur_major ] ; then - return 0 - elif [ $_min_major -eq $_cur_major ] ; then - if [ $_min_minor -lt $_cur_minor ] ; then - return 0 - elif [ $_min_minor -eq $_cur_minor ] ; then - if [ $_min_patch -lt $_cur_patch ] ; then - return 0 - elif [ $_min_patch -eq $_cur_patch ] ; then - return 0 - fi - fi - fi - return 1 -} - - -###################################### -# LOCATE_CONFIGURE_TEMPLATE FUNCTION # -###################################### -locate_configure_template ( ) { - _pwd="`pwd`" - if test -f "./configure.ac" ; then - echo "./configure.ac" - elif test -f "./configure.in" ; then - echo "./configure.in" - elif test -f "$_pwd/configure.ac" ; then - echo "$_pwd/configure.ac" - elif test -f "$_pwd/configure.in" ; then - echo "$_pwd/configure.in" - elif test -f "$PATH_TO_AUTOGEN/configure.ac" ; then - echo "$PATH_TO_AUTOGEN/configure.ac" - elif test -f "$PATH_TO_AUTOGEN/configure.in" ; then - echo "$PATH_TO_AUTOGEN/configure.in" - fi -} - - -################## -# argument check # -################## -ARGS="$*" -PATH_TO_AUTOGEN="`dirname $0`" -NAME_OF_AUTOGEN="`basename $0`" -AUTOGEN_SH="$PATH_TO_AUTOGEN/$NAME_OF_AUTOGEN" - -LIBTOOL_M4="${PATH_TO_AUTOGEN}/misc/libtool.m4" - -if [ "x$HELP" = "x" ] ; then - HELP=no -fi -if [ "x$QUIET" = "x" ] ; then - QUIET=no -fi -if [ "x$VERBOSE" = "x" ] ; then - VERBOSE=no -fi -if [ "x$VERSION_ONLY" = "x" ] ; then - VERSION_ONLY=no -fi -if [ "x$DOWNLOAD" = "x" ] ; then - DOWNLOAD=no -fi -if [ "x$AUTORECONF_OPTIONS" = "x" ] ; then - AUTORECONF_OPTIONS="-i -f" -fi -if [ "x$AUTOCONF_OPTIONS" = "x" ] ; then - AUTOCONF_OPTIONS="-f" -fi -if [ "x$AUTOMAKE_OPTIONS" = "x" ] ; then - AUTOMAKE_OPTIONS="-a -c -f" -fi -ALT_AUTOMAKE_OPTIONS="-a -c" -if [ "x$LIBTOOLIZE_OPTIONS" = "x" ] ; then - LIBTOOLIZE_OPTIONS="--automake -c -f" -fi -ALT_LIBTOOLIZE_OPTIONS="--automake --copy --force" -if [ "x$ACLOCAL_OPTIONS" = "x" ] ; then - ACLOCAL_OPTIONS="" -fi -if [ "x$AUTOHEADER_OPTIONS" = "x" ] ; then - AUTOHEADER_OPTIONS="" -fi -if [ "x$CONFIG_GUESS_URL" = "x" ] ; then - CONFIG_GUESS_URL="http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob_plain;f=build-aux/config.guess;hb=HEAD" -fi -for arg in $ARGS ; do - case "x$arg" in - x--help) HELP=yes ;; - x-[hH]) HELP=yes ;; - x--quiet) QUIET=yes ;; - x-[qQ]) QUIET=yes ;; - x--verbose) VERBOSE=yes ;; - x-[dD]) DOWNLOAD=yes ;; - x--download) DOWNLOAD=yes ;; - x-[vV]) VERBOSE=yes ;; - x--version) VERSION_ONLY=yes ;; - *) - echo "Unknown option: $arg" - echo - usage - exit 1 - ;; - esac -done - - -##################### -# environment check # -##################### - -# sanity check before recursions potentially begin -if [ ! -f "$AUTOGEN_SH" ] ; then - echo "INTERNAL ERROR: $AUTOGEN_SH does not exist" - if [ ! "x$0" = "x$AUTOGEN_SH" ] ; then - echo "INTERNAL ERROR: dirname/basename inconsistency: $0 != $AUTOGEN_SH" - fi - exit 1 -fi - -# force locale setting to C so things like date output as expected -LC_ALL=C - -# commands that this script expects -for __cmd in echo head tail pwd ; do - echo "test" | $__cmd > /dev/null 2>&1 - if [ $? != 0 ] ; then - echo "INTERNAL ERROR: '${__cmd}' command is required" - exit 2 - fi -done -echo "test" | grep "test" > /dev/null 2>&1 -if test ! x$? = x0 ; then - echo "INTERNAL ERROR: grep command is required" - exit 1 -fi -echo "test" | sed "s/test/test/" > /dev/null 2>&1 -if test ! x$? = x0 ; then - echo "INTERNAL ERROR: sed command is required" - exit 1 -fi - - -# determine the behavior of echo -case `echo "testing\c"; echo 1,2,3`,`echo -n testing; echo 1,2,3` in - *c*,-n*) ECHO_N= ECHO_C=' -' ECHO_T=' ' ;; - *c*,* ) ECHO_N=-n ECHO_C= ECHO_T= ;; - *) ECHO_N= ECHO_C='\c' ECHO_T= ;; -esac - -# determine the behavior of head -case "x`echo 'head' | head -n 1 2>&1`" in - *xhead*) HEAD_N="n " ;; - *) HEAD_N="" ;; -esac - -# determine the behavior of tail -case "x`echo 'tail' | tail -n 1 2>&1`" in - *xtail*) TAIL_N="n " ;; - *) TAIL_N="" ;; -esac - -VERBOSE_ECHO=: -ECHO=: -if [ "x$QUIET" = "xyes" ] ; then - if [ "x$VERBOSE" = "xyes" ] ; then - echo "Verbose output quelled by quiet option. Further output disabled." - fi -else - ECHO=echo - if [ "x$VERBOSE" = "xyes" ] ; then - echo "Verbose output enabled" - VERBOSE_ECHO=echo - fi -fi - - -# allow a recursive run to disable further recursions -if [ "x$RUN_RECURSIVE" = "x" ] ; then - RUN_RECURSIVE=yes -fi - - -################################################ -# check for help arg and bypass version checks # -################################################ -if [ "x`echo $ARGS | sed 's/.*[hH][eE][lL][pP].*/help/'`" = "xhelp" ] ; then - HELP=yes -fi -if [ "x$HELP" = "xyes" ] ; then - usage - $ECHO "---" - $ECHO "Help was requested. No preparation or configuration will be performed." - exit 0 -fi - - -####################### -# set up signal traps # -####################### -untrap_abnormal ( ) { - for sig in 1 2 13 15; do - trap - $sig - done -} - -# do this cleanup whenever we exit. -trap ' - # start from the root - if test -d "$START_PATH" ; then - cd "$START_PATH" - fi - - # restore/delete backup files - if test "x$PFC_INIT" = "x1" ; then - recursive_restore - fi -' 0 - -# trap SIGHUP (1), SIGINT (2), SIGPIPE (13), SIGTERM (15) -for sig in 1 2 13 15; do - trap ' - $ECHO "" - $ECHO "Aborting $NAME_OF_AUTOGEN: caught signal '$sig'" - - # start from the root - if test -d "$START_PATH" ; then - cd "$START_PATH" - fi - - # clean up on abnormal exit - $VERBOSE_ECHO "rm -rf autom4te.cache" - rm -rf autom4te.cache - - if test -f "acinclude.m4.$$.backup" ; then - $VERBOSE_ECHO "cat acinclude.m4.$$.backup > acinclude.m4" - chmod u+w acinclude.m4 - cat acinclude.m4.$$.backup > acinclude.m4 - - $VERBOSE_ECHO "rm -f acinclude.m4.$$.backup" - rm -f acinclude.m4.$$.backup - fi - - { (exit 1); exit 1; } -' $sig -done - - -############################# -# look for a configure file # -############################# -if [ "x$CONFIGURE" = "x" ] ; then - CONFIGURE="`locate_configure_template`" - if [ ! "x$CONFIGURE" = "x" ] ; then - $VERBOSE_ECHO "Found a configure template: $CONFIGURE" - fi -else - $ECHO "Using CONFIGURE environment variable override: $CONFIGURE" -fi -if [ "x$CONFIGURE" = "x" ] ; then - if [ "x$VERSION_ONLY" = "xyes" ] ; then - CONFIGURE=/dev/null - else - $ECHO - $ECHO "A configure.ac or configure.in file could not be located implying" - $ECHO "that the GNU Build System is at least not used in this directory. In" - $ECHO "any case, there is nothing to do here without one of those files." - $ECHO - $ECHO "ERROR: No configure.in or configure.ac file found in `pwd`" - exit 1 - fi -fi - -#################### -# get project name # -#################### -if [ "x$PROJECT" = "x" ] ; then - PROJECT="`grep AC_INIT $CONFIGURE | grep -v '.*#.*AC_INIT' | tail -${TAIL_N}1 | sed 's/^[ ]*AC_INIT(\([^,)]*\).*/\1/' | sed 's/.*\[\(.*\)\].*/\1/'`" - if [ "x$PROJECT" = "xAC_INIT" ] ; then - # projects might be using the older/deprecated arg-less AC_INIT .. look for AM_INIT_AUTOMAKE instead - PROJECT="`grep AM_INIT_AUTOMAKE $CONFIGURE | grep -v '.*#.*AM_INIT_AUTOMAKE' | tail -${TAIL_N}1 | sed 's/^[ ]*AM_INIT_AUTOMAKE(\([^,)]*\).*/\1/' | sed 's/.*\[\(.*\)\].*/\1/'`" - fi - if [ "x$PROJECT" = "xAM_INIT_AUTOMAKE" ] ; then - PROJECT="project" - fi - if [ "x$PROJECT" = "x" ] ; then - PROJECT="project" - fi -else - $ECHO "Using PROJECT environment variable override: $PROJECT" -fi -$ECHO "Preparing the $PROJECT build system...please wait" -$ECHO - - -######################## -# check for autoreconf # -######################## -HAVE_AUTORECONF=no -if [ "x$AUTORECONF" = "x" ] ; then - for AUTORECONF in autoreconf ; do - $VERBOSE_ECHO "Checking autoreconf version: $AUTORECONF --version" - $AUTORECONF --version > /dev/null 2>&1 - if [ $? = 0 ] ; then - HAVE_AUTORECONF=yes - break - fi - done -else - HAVE_AUTORECONF=yes - $ECHO "Using AUTORECONF environment variable override: $AUTORECONF" -fi - - -########################## -# autoconf version check # -########################## -_acfound=no -if [ "x$AUTOCONF" = "x" ] ; then - for AUTOCONF in autoconf ; do - $VERBOSE_ECHO "Checking autoconf version: $AUTOCONF --version" - $AUTOCONF --version > /dev/null 2>&1 - if [ $? = 0 ] ; then - _acfound=yes - break - fi - done -else - _acfound=yes - $ECHO "Using AUTOCONF environment variable override: $AUTOCONF" -fi - -_report_error=no -if [ ! "x$_acfound" = "xyes" ] ; then - $ECHO "ERROR: Unable to locate GNU Autoconf." - _report_error=yes -else - _version="`$AUTOCONF --version | head -${HEAD_N}1 | sed 's/[^0-9]*\([0-9\.][0-9\.]*\)/\1/'`" - if [ "x$_version" = "x" ] ; then - _version="0.0.0" - fi - $ECHO "Found GNU Autoconf version $_version" - version_check "$AUTOCONF_VERSION" "$_version" - if [ $? -ne 0 ] ; then - _report_error=yes - fi -fi -if [ "x$_report_error" = "xyes" ] ; then - version_error "$AUTOCONF_VERSION" "GNU Autoconf" - exit 1 -fi - - -########################## -# automake version check # -########################## -_amfound=no -if [ "x$AUTOMAKE" = "x" ] ; then - for AUTOMAKE in automake ; do - $VERBOSE_ECHO "Checking automake version: $AUTOMAKE --version" - $AUTOMAKE --version > /dev/null 2>&1 - if [ $? = 0 ] ; then - _amfound=yes - break - fi - done -else - _amfound=yes - $ECHO "Using AUTOMAKE environment variable override: $AUTOMAKE" -fi - - -_report_error=no -if [ ! "x$_amfound" = "xyes" ] ; then - $ECHO - $ECHO "ERROR: Unable to locate GNU Automake." - _report_error=yes -else - _version="`$AUTOMAKE --version | head -${HEAD_N}1 | sed 's/[^0-9]*\([0-9\.][0-9\.]*\)/\1/'`" - if [ "x$_version" = "x" ] ; then - _version="0.0.0" - fi - $ECHO "Found GNU Automake version $_version" - version_check "$AUTOMAKE_VERSION" "$_version" - if [ $? -ne 0 ] ; then - _report_error=yes - fi -fi -if [ "x$_report_error" = "xyes" ] ; then - version_error "$AUTOMAKE_VERSION" "GNU Automake" - exit 1 -fi - - -######################## -# check for libtoolize # -######################## -HAVE_LIBTOOLIZE=yes -HAVE_ALT_LIBTOOLIZE=no -_ltfound=no -if [ "x$LIBTOOLIZE" = "x" ] ; then - LIBTOOLIZE=libtoolize - $VERBOSE_ECHO "Checking libtoolize version: $LIBTOOLIZE --version" - $LIBTOOLIZE --version > /dev/null 2>&1 - if [ ! $? = 0 ] ; then - HAVE_LIBTOOLIZE=no - $ECHO - if [ "x$HAVE_AUTORECONF" = "xno" ] ; then - $ECHO "Warning: libtoolize does not appear to be available." - else - $ECHO "Warning: libtoolize does not appear to be available. This means that" - $ECHO "the automatic build preparation via autoreconf will probably not work." - $ECHO "Preparing the build by running each step individually, however, should" - $ECHO "work and will be done automatically for you if autoreconf fails." - fi - - # look for some alternates - for tool in glibtoolize libtoolize15 libtoolize14 libtoolize13 ; do - $VERBOSE_ECHO "Checking libtoolize alternate: $tool --version" - _glibtoolize="`$tool --version > /dev/null 2>&1`" - if [ $? = 0 ] ; then - $VERBOSE_ECHO "Found $tool --version" - _glti="`which $tool`" - if [ "x$_glti" = "x" ] ; then - $VERBOSE_ECHO "Cannot find $tool with which" - continue; - fi - if test ! -f "$_glti" ; then - $VERBOSE_ECHO "Cannot use $tool, $_glti is not a file" - continue; - fi - _gltidir="`dirname $_glti`" - if [ "x$_gltidir" = "x" ] ; then - $VERBOSE_ECHO "Cannot find $tool path with dirname of $_glti" - continue; - fi - if test ! -d "$_gltidir" ; then - $VERBOSE_ECHO "Cannot use $tool, $_gltidir is not a directory" - continue; - fi - HAVE_ALT_LIBTOOLIZE=yes - LIBTOOLIZE="$tool" - $ECHO - $ECHO "Fortunately, $tool was found which means that your system may simply" - $ECHO "have a non-standard or incomplete GNU Autotools install. If you have" - $ECHO "sufficient system access, it may be possible to quell this warning by" - $ECHO "running:" - $ECHO - sudo -V > /dev/null 2>&1 - if [ $? = 0 ] ; then - $ECHO " sudo ln -s $_glti $_gltidir/libtoolize" - $ECHO - else - $ECHO " ln -s $_glti $_gltidir/libtoolize" - $ECHO - $ECHO "Run that as root or with proper permissions to the $_gltidir directory" - $ECHO - fi - _ltfound=yes - break - fi - done - else - _ltfound=yes - fi -else - _ltfound=yes - $ECHO "Using LIBTOOLIZE environment variable override: $LIBTOOLIZE" -fi - - -############################ -# libtoolize version check # -############################ -_report_error=no -if [ ! "x$_ltfound" = "xyes" ] ; then - $ECHO - $ECHO "ERROR: Unable to locate GNU Libtool." - _report_error=yes -else - _version="`$LIBTOOLIZE --version | head -${HEAD_N}1 | sed 's/[^0-9]*\([0-9\.][0-9\.]*\)/\1/'`" - if [ "x$_version" = "x" ] ; then - _version="0.0.0" - fi - $ECHO "Found GNU Libtool version $_version" - version_check "$LIBTOOL_VERSION" "$_version" - if [ $? -ne 0 ] ; then - _report_error=yes - fi -fi -if [ "x$_report_error" = "xyes" ] ; then - version_error "$LIBTOOL_VERSION" "GNU Libtool" - exit 1 -fi - - -##################### -# check for aclocal # -##################### -if [ "x$ACLOCAL" = "x" ] ; then - for ACLOCAL in aclocal ; do - $VERBOSE_ECHO "Checking aclocal version: $ACLOCAL --version" - $ACLOCAL --version > /dev/null 2>&1 - if [ $? = 0 ] ; then - break - fi - done -else - $ECHO "Using ACLOCAL environment variable override: $ACLOCAL" -fi - - -######################## -# check for autoheader # -######################## -if [ "x$AUTOHEADER" = "x" ] ; then - for AUTOHEADER in autoheader ; do - $VERBOSE_ECHO "Checking autoheader version: $AUTOHEADER --version" - $AUTOHEADER --version > /dev/null 2>&1 - if [ $? = 0 ] ; then - break - fi - done -else - $ECHO "Using AUTOHEADER environment variable override: $AUTOHEADER" -fi - - -######################### -# check if version only # -######################### -$VERBOSE_ECHO "Checking whether to only output version information" -if [ "x$VERSION_ONLY" = "xyes" ] ; then - $ECHO - ident - $ECHO "---" - $ECHO "Version requested. No preparation or configuration will be performed." - exit 0 -fi - - -################################# -# PROTECT_FROM_CLOBBER FUNCTION # -################################# -protect_from_clobber ( ) { - PFC_INIT=1 - - # protect COPYING & INSTALL from overwrite by automake. the - # automake force option will (inappropriately) ignore the existing - # contents of a COPYING and/or INSTALL files (depending on the - # version) instead of just forcing *missing* files like it does - # for AUTHORS, NEWS, and README. this is broken but extremely - # prevalent behavior, so we protect against it by keeping a backup - # of the file that can later be restored. - - for file in COPYING INSTALL ; do - if test -f ${file} ; then - if test -f ${file}.$$.protect_from_automake.backup ; then - $VERBOSE_ECHO "Already backed up ${file} in `pwd`" - else - $VERBOSE_ECHO "Backing up ${file} in `pwd`" - $VERBOSE_ECHO "cp -p ${file} ${file}.$$.protect_from_automake.backup" - cp -p ${file} ${file}.$$.protect_from_automake.backup - fi - fi - done -} - - -############################## -# RECURSIVE_PROTECT FUNCTION # -############################## -recursive_protect ( ) { - - # for projects using recursive configure, run the build - # preparation steps for the subdirectories. this function assumes - # START_PATH was set to pwd before recursion begins so that - # relative paths work. - - # git 'r done, protect COPYING and INSTALL from being clobbered - protect_from_clobber - - if test -d autom4te.cache ; then - $VERBOSE_ECHO "Found an autom4te.cache directory, deleting it" - $VERBOSE_ECHO "rm -rf autom4te.cache" - rm -rf autom4te.cache - fi - - # find configure template - _configure="`locate_configure_template`" - if [ "x$_configure" = "x" ] ; then - return - fi - # $VERBOSE_ECHO "Looking for configure template found `pwd`/$_configure" - - # look for subdirs - # $VERBOSE_ECHO "Looking for subdirs in `pwd`" - _det_config_subdirs="`grep AC_CONFIG_SUBDIRS $_configure | grep -v '.*#.*AC_CONFIG_SUBDIRS' | sed 's/^[ ]*AC_CONFIG_SUBDIRS(\(.*\)).*/\1/' | sed 's/.*\[\(.*\)\].*/\1/'`" - CHECK_DIRS="" - for dir in $_det_config_subdirs ; do - if test -d "`pwd`/$dir" ; then - CHECK_DIRS="$CHECK_DIRS \"`pwd`/$dir\"" - fi - done - - # process subdirs - if [ ! "x$CHECK_DIRS" = "x" ] ; then - $VERBOSE_ECHO "Recursively scanning the following directories:" - $VERBOSE_ECHO " $CHECK_DIRS" - for dir in $CHECK_DIRS ; do - $VERBOSE_ECHO "Protecting files from automake in $dir" - cd "$START_PATH" - eval "cd $dir" - - # recursively git 'r done - recursive_protect - done - fi -} # end of recursive_protect - - -############################# -# RESTORE_CLOBBERED FUNCION # -############################# -restore_clobbered ( ) { - - # The automake (and autoreconf by extension) -f/--force-missing - # option may overwrite COPYING and INSTALL even if they do exist. - # Here we restore the files if necessary. - - spacer=no - - for file in COPYING INSTALL ; do - if test -f ${file}.$$.protect_from_automake.backup ; then - if test -f ${file} ; then - # compare entire content, restore if needed - if test "x`cat ${file}`" != "x`cat ${file}.$$.protect_from_automake.backup`" ; then - if test "x$spacer" = "xno" ; then - $VERBOSE_ECHO - spacer=yes - fi - # restore the backup - $VERBOSE_ECHO "Restoring ${file} from backup (automake -f likely clobbered it)" - $VERBOSE_ECHO "rm -f ${file}" - rm -f ${file} - $VERBOSE_ECHO "mv ${file}.$$.protect_from_automake.backup ${file}" - mv ${file}.$$.protect_from_automake.backup ${file} - fi # check contents - elif test -f ${file}.$$.protect_from_automake.backup ; then - $VERBOSE_ECHO "mv ${file}.$$.protect_from_automake.backup ${file}" - mv ${file}.$$.protect_from_automake.backup ${file} - fi # -f ${file} - - # just in case - $VERBOSE_ECHO "rm -f ${file}.$$.protect_from_automake.backup" - rm -f ${file}.$$.protect_from_automake.backup - fi # -f ${file}.$$.protect_from_automake.backup - done - - CONFIGURE="`locate_configure_template`" - if [ "x$CONFIGURE" = "x" ] ; then - return - fi - - _aux_dir="`grep AC_CONFIG_AUX_DIR $CONFIGURE | grep -v '.*#.*AC_CONFIG_AUX_DIR' | tail -${TAIL_N}1 | sed 's/^[ ]*AC_CONFIG_AUX_DIR(\(.*\)).*/\1/' | sed 's/.*\[\(.*\)\].*/\1/'`" - if test ! -d "$_aux_dir" ; then - _aux_dir=. - fi - - for file in config.guess config.sub ltmain.sh ; do - if test -f "${_aux_dir}/${file}" ; then - $VERBOSE_ECHO "rm -f \"${_aux_dir}/${file}.backup\"" - rm -f "${_aux_dir}/${file}.backup" - fi - done -} # end of restore_clobbered - - -############################## -# RECURSIVE_RESTORE FUNCTION # -############################## -recursive_restore ( ) { - - # restore COPYING and INSTALL from backup if they were clobbered - # for each directory recursively. - - # git 'r undone - restore_clobbered - - # find configure template - _configure="`locate_configure_template`" - if [ "x$_configure" = "x" ] ; then - return - fi - - # look for subdirs - _det_config_subdirs="`grep AC_CONFIG_SUBDIRS $_configure | grep -v '.*#.*AC_CONFIG_SUBDIRS' | sed 's/^[ ]*AC_CONFIG_SUBDIRS(\(.*\)).*/\1/' | sed 's/.*\[\(.*\)\].*/\1/'`" - CHECK_DIRS="" - for dir in $_det_config_subdirs ; do - if test -d "`pwd`/$dir" ; then - CHECK_DIRS="$CHECK_DIRS \"`pwd`/$dir\"" - fi - done - - # process subdirs - if [ ! "x$CHECK_DIRS" = "x" ] ; then - $VERBOSE_ECHO "Recursively scanning the following directories:" - $VERBOSE_ECHO " $CHECK_DIRS" - for dir in $CHECK_DIRS ; do - $VERBOSE_ECHO "Checking files for automake damage in $dir" - cd "$START_PATH" - eval "cd $dir" - - # recursively git 'r undone - recursive_restore - done - fi -} # end of recursive_restore - - -####################### -# INITIALIZE FUNCTION # -####################### -initialize ( ) { - - # this routine performs a variety of directory-specific - # initializations. some are sanity checks, some are preventive, - # and some are necessary setup detection. - # - # this function sets: - # CONFIGURE - # SEARCH_DIRS - # CONFIG_SUBDIRS - - ################################## - # check for a configure template # - ################################## - CONFIGURE="`locate_configure_template`" - if [ "x$CONFIGURE" = "x" ] ; then - $ECHO - $ECHO "A configure.ac or configure.in file could not be located implying" - $ECHO "that the GNU Build System is at least not used in this directory. In" - $ECHO "any case, there is nothing to do here without one of those files." - $ECHO - $ECHO "ERROR: No configure.in or configure.ac file found in `pwd`" - exit 1 - fi - - ##################### - # detect an aux dir # - ##################### - _aux_dir="`grep AC_CONFIG_AUX_DIR $CONFIGURE | grep -v '.*#.*AC_CONFIG_AUX_DIR' | tail -${TAIL_N}1 | sed 's/^[ ]*AC_CONFIG_AUX_DIR(\(.*\)).*/\1/' | sed 's/.*\[\(.*\)\].*/\1/'`" - if test ! -d "$_aux_dir" ; then - _aux_dir=. - else - $VERBOSE_ECHO "Detected auxillary directory: $_aux_dir" - fi - - ################################ - # detect a recursive configure # - ################################ - CONFIG_SUBDIRS="" - _det_config_subdirs="`grep AC_CONFIG_SUBDIRS $CONFIGURE | grep -v '.*#.*AC_CONFIG_SUBDIRS' | sed 's/^[ ]*AC_CONFIG_SUBDIRS(\(.*\)).*/\1/' | sed 's/.*\[\(.*\)\].*/\1/'`" - for dir in $_det_config_subdirs ; do - if test -d "`pwd`/$dir" ; then - $VERBOSE_ECHO "Detected recursive configure directory: `pwd`/$dir" - CONFIG_SUBDIRS="$CONFIG_SUBDIRS `pwd`/$dir" - fi - done - - ########################################################### - # make sure certain required files exist for GNU projects # - ########################################################### - _marker_found="" - _marker_found_message_intro='Detected non-GNU marker "' - _marker_found_message_mid='" in ' - for marker in foreign cygnus ; do - _marker_found_message=${_marker_found_message_intro}${marker}${_marker_found_message_mid} - _marker_found="`grep 'AM_INIT_AUTOMAKE.*'${marker} $CONFIGURE`" - if [ ! "x$_marker_found" = "x" ] ; then - $VERBOSE_ECHO "${_marker_found_message}`basename \"$CONFIGURE\"`" - break - fi - if test -f "`dirname \"$CONFIGURE\"/Makefile.am`" ; then - _marker_found="`grep 'AUTOMAKE_OPTIONS.*'${marker} Makefile.am`" - if [ ! "x$_marker_found" = "x" ] ; then - $VERBOSE_ECHO "${_marker_found_message}Makefile.am" - break - fi - fi - done - if [ "x${_marker_found}" = "x" ] ; then - _suggest_foreign=no - for file in AUTHORS COPYING ChangeLog INSTALL NEWS README ; do - if [ ! -f $file ] ; then - $VERBOSE_ECHO "Touching ${file} since it does not exist" - _suggest_foreign=yes - touch $file - fi - done - - if [ "x${_suggest_foreign}" = "xyes" ] ; then - $ECHO - $ECHO "Warning: Several files expected of projects that conform to the GNU" - $ECHO "coding standards were not found. The files were automatically added" - $ECHO "for you since you do not have a 'foreign' declaration specified." - $ECHO - $ECHO "Considered adding 'foreign' to AM_INIT_AUTOMAKE in `basename \"$CONFIGURE\"`" - if test -f "`dirname \"$CONFIGURE\"/Makefile.am`" ; then - $ECHO "or to AUTOMAKE_OPTIONS in your top-level Makefile.am file." - fi - $ECHO - fi - fi - - ################################################## - # make sure certain generated files do not exist # - ################################################## - for file in config.guess config.sub ltmain.sh ; do - if test -f "${_aux_dir}/${file}" ; then - $VERBOSE_ECHO "mv -f \"${_aux_dir}/${file}\" \"${_aux_dir}/${file}.backup\"" - mv -f "${_aux_dir}/${file}" "${_aux_dir}/${file}.backup" - fi - done - - ############################ - # search alternate m4 dirs # - ############################ - SEARCH_DIRS="" - for dir in m4 ; do - if [ -d $dir ] ; then - $VERBOSE_ECHO "Found extra aclocal search directory: $dir" - SEARCH_DIRS="$SEARCH_DIRS -I $dir" - fi - done - - ###################################### - # remove any previous build products # - ###################################### - if test -d autom4te.cache ; then - $VERBOSE_ECHO "Found an autom4te.cache directory, deleting it" - $VERBOSE_ECHO "rm -rf autom4te.cache" - rm -rf autom4te.cache - fi -# tcl/tk (and probably others) have a customized aclocal.m4, so can't delete it -# if test -f aclocal.m4 ; then -# $VERBOSE_ECHO "Found an aclocal.m4 file, deleting it" -# $VERBOSE_ECHO "rm -f aclocal.m4" -# rm -f aclocal.m4 -# fi - -} # end of initialize() - - -############## -# initialize # -############## - -# stash path -START_PATH="`pwd`" - -# Before running autoreconf or manual steps, some prep detection work -# is necessary or useful. Only needs to occur once per directory, but -# does need to traverse the entire subconfigure hierarchy to protect -# files from being clobbered even by autoreconf. -recursive_protect - -# start from where we started -cd "$START_PATH" - -# get ready to process -initialize - - -######################################### -# DOWNLOAD_GNULIB_CONFIG_GUESS FUNCTION # -######################################### - -# TODO - should make sure wget/curl exist and/or work before trying to -# use them. - -download_gnulib_config_guess () { - # abuse gitweb to download gnulib's latest config.guess via HTTP - config_guess_temp="config.guess.$$.download" - ret=1 - for __cmd in wget curl fetch ; do - $VERBOSE_ECHO "Checking for command ${__cmd}" - ${__cmd} --version > /dev/null 2>&1 - ret=$? - if [ ! $ret = 0 ] ; then - continue - fi - - __cmd_version=`${__cmd} --version | head -n 1 | sed -e 's/^[^0-9]\+//' -e 's/ .*//'` - $VERBOSE_ECHO "Found ${__cmd} ${__cmd_version}" - - opts="" - case ${__cmd} in - wget) - opts="-O" - ;; - curl) - opts="-o" - ;; - fetch) - opts="-t 5 -f" - ;; - esac - - $VERBOSE_ECHO "Running $__cmd \"${CONFIG_GUESS_URL}\" $opts \"${config_guess_temp}\"" - eval "$__cmd \"${CONFIG_GUESS_URL}\" $opts \"${config_guess_temp}\"" > /dev/null 2>&1 - if [ $? = 0 ] ; then - mv -f "${config_guess_temp}" ${_aux_dir}/config.guess - ret=0 - break - fi - done - - if [ ! $ret = 0 ] ; then - $ECHO "Warning: config.guess download failed from: $CONFIG_GUESS_URL" - rm -f "${config_guess_temp}" - fi -} - - -############################## -# LIBTOOLIZE_NEEDED FUNCTION # -############################## -libtoolize_needed () { - ret=1 # means no, don't need libtoolize - for feature in AC_PROG_LIBTOOL AM_PROG_LIBTOOL LT_INIT ; do - $VERBOSE_ECHO "Searching for $feature in $CONFIGURE" - found="`grep \"^$feature.*\" $CONFIGURE`" - if [ ! "x$found" = "x" ] ; then - ret=0 # means yes, need to run libtoolize - break - fi - done - return ${ret} -} - - - -############################################ -# prepare build via autoreconf or manually # -############################################ -reconfigure_manually=no -if [ "x$HAVE_AUTORECONF" = "xyes" ] ; then - $ECHO - $ECHO $ECHO_N "Automatically preparing build ... $ECHO_C" - - $VERBOSE_ECHO "$AUTORECONF $SEARCH_DIRS $AUTORECONF_OPTIONS" - autoreconf_output="`$AUTORECONF $SEARCH_DIRS $AUTORECONF_OPTIONS 2>&1`" - ret=$? - $VERBOSE_ECHO "$autoreconf_output" - - if [ ! $ret = 0 ] ; then - if [ "x$HAVE_ALT_LIBTOOLIZE" = "xyes" ] ; then - if [ ! "x`echo \"$autoreconf_output\" | grep libtoolize | grep \"No such file or directory\"`" = "x" ] ; then - $ECHO - $ECHO "Warning: autoreconf failed but due to what is usually a common libtool" - $ECHO "misconfiguration issue. This problem is encountered on systems that" - $ECHO "have installed libtoolize under a different name without providing a" - $ECHO "symbolic link or without setting the LIBTOOLIZE environment variable." - $ECHO - $ECHO "Restarting the preparation steps with LIBTOOLIZE set to $LIBTOOLIZE" - - export LIBTOOLIZE - RUN_RECURSIVE=no - export RUN_RECURSIVE - untrap_abnormal - - $VERBOSE_ECHO sh $AUTOGEN_SH "$1" "$2" "$3" "$4" "$5" "$6" "$7" "$8" "$9" - sh "$AUTOGEN_SH" "$1" "$2" "$3" "$4" "$5" "$6" "$7" "$8" "$9" - exit $? - fi - fi - - $ECHO "Warning: $AUTORECONF failed" - - if test -f ltmain.sh ; then - $ECHO "libtoolize being run by autoreconf is not creating ltmain.sh in the auxillary directory like it should" - fi - - $ECHO "Attempting to run the preparation steps individually" - reconfigure_manually=yes - else - if [ "x$DOWNLOAD" = "xyes" ] ; then - if libtoolize_needed ; then - download_gnulib_config_guess - fi - fi - fi -else - reconfigure_manually=yes -fi - - -############################ -# LIBTOOL_FAILURE FUNCTION # -############################ -libtool_failure ( ) { - - # libtool is rather error-prone in comparison to the other - # autotools and this routine attempts to compensate for some - # common failures. the output after a libtoolize failure is - # parsed for an error related to AC_PROG_LIBTOOL and if found, we - # attempt to inject a project-provided libtool.m4 file. - - _autoconf_output="$1" - - if [ "x$RUN_RECURSIVE" = "xno" ] ; then - # we already tried the libtool.m4, don't try again - return 1 - fi - - if test -f "$LIBTOOL_M4" ; then - found_libtool="`$ECHO $_autoconf_output | grep AC_PROG_LIBTOOL`" - if test ! "x$found_libtool" = "x" ; then - if test -f acinclude.m4 ; then - rm -f acinclude.m4.$$.backup - $VERBOSE_ECHO "cat acinclude.m4 > acinclude.m4.$$.backup" - cat acinclude.m4 > acinclude.m4.$$.backup - fi - $VERBOSE_ECHO "cat \"$LIBTOOL_M4\" >> acinclude.m4" - chmod u+w acinclude.m4 - cat "$LIBTOOL_M4" >> acinclude.m4 - - # don't keep doing this - RUN_RECURSIVE=no - export RUN_RECURSIVE - untrap_abnormal - - $ECHO - $ECHO "Restarting the preparation steps with libtool macros in acinclude.m4" - $VERBOSE_ECHO sh $AUTOGEN_SH "$1" "$2" "$3" "$4" "$5" "$6" "$7" "$8" "$9" - sh "$AUTOGEN_SH" "$1" "$2" "$3" "$4" "$5" "$6" "$7" "$8" "$9" - exit $? - fi - fi -} - - -########################### -# MANUAL_AUTOGEN FUNCTION # -########################### -manual_autogen ( ) { - - ################################################## - # Manual preparation steps taken are as follows: # - # aclocal [-I m4] # - # libtoolize --automake -c -f # - # aclocal [-I m4] # - # autoconf -f # - # autoheader # - # automake -a -c -f # - ################################################## - - ########### - # aclocal # - ########### - $VERBOSE_ECHO "$ACLOCAL $SEARCH_DIRS $ACLOCAL_OPTIONS" - aclocal_output="`$ACLOCAL $SEARCH_DIRS $ACLOCAL_OPTIONS 2>&1`" - ret=$? - $VERBOSE_ECHO "$aclocal_output" - if [ ! $ret = 0 ] ; then $ECHO "ERROR: $ACLOCAL failed" && exit 2 ; fi - - ############## - # libtoolize # - ############## - if libtoolize_needed ; then - if [ "x$HAVE_LIBTOOLIZE" = "xyes" ] ; then - $VERBOSE_ECHO "$LIBTOOLIZE $LIBTOOLIZE_OPTIONS" - libtoolize_output="`$LIBTOOLIZE $LIBTOOLIZE_OPTIONS 2>&1`" - ret=$? - $VERBOSE_ECHO "$libtoolize_output" - - if [ ! $ret = 0 ] ; then $ECHO "ERROR: $LIBTOOLIZE failed" && exit 2 ; fi - else - if [ "x$HAVE_ALT_LIBTOOLIZE" = "xyes" ] ; then - $VERBOSE_ECHO "$LIBTOOLIZE $ALT_LIBTOOLIZE_OPTIONS" - libtoolize_output="`$LIBTOOLIZE $ALT_LIBTOOLIZE_OPTIONS 2>&1`" - ret=$? - $VERBOSE_ECHO "$libtoolize_output" - - if [ ! $ret = 0 ] ; then $ECHO "ERROR: $LIBTOOLIZE failed" && exit 2 ; fi - fi - fi - - ########### - # aclocal # - ########### - # re-run again as instructed by libtoolize - $VERBOSE_ECHO "$ACLOCAL $SEARCH_DIRS $ACLOCAL_OPTIONS" - aclocal_output="`$ACLOCAL $SEARCH_DIRS $ACLOCAL_OPTIONS 2>&1`" - ret=$? - $VERBOSE_ECHO "$aclocal_output" - - # libtoolize might put ltmain.sh in the wrong place - if test -f ltmain.sh ; then - if test ! -f "${_aux_dir}/ltmain.sh" ; then - $ECHO - $ECHO "Warning: $LIBTOOLIZE is creating ltmain.sh in the wrong directory" - $ECHO - $ECHO "Fortunately, the problem can be worked around by simply copying the" - $ECHO "file to the appropriate location (${_aux_dir}/). This has been done for you." - $ECHO - $VERBOSE_ECHO "cp -p ltmain.sh \"${_aux_dir}/ltmain.sh\"" - cp -p ltmain.sh "${_aux_dir}/ltmain.sh" - $ECHO $ECHO_N "Continuing build preparation ... $ECHO_C" - fi - fi # ltmain.sh - - if [ "x$DOWNLOAD" = "xyes" ] ; then - download_gnulib_config_guess - fi - fi # libtoolize_needed - - ############ - # autoconf # - ############ - $VERBOSE_ECHO - $VERBOSE_ECHO "$AUTOCONF $AUTOCONF_OPTIONS" - autoconf_output="`$AUTOCONF $AUTOCONF_OPTIONS 2>&1`" - ret=$? - $VERBOSE_ECHO "$autoconf_output" - - if [ ! $ret = 0 ] ; then - # retry without the -f and check for usage of macros that are too new - ac2_59_macros="AC_C_RESTRICT AC_INCLUDES_DEFAULT AC_LANG_ASSERT AC_LANG_WERROR AS_SET_CATFILE" - ac2_55_macros="AC_COMPILER_IFELSE AC_FUNC_MBRTOWC AC_HEADER_STDBOOL AC_LANG_CONFTEST AC_LANG_SOURCE AC_LANG_PROGRAM AC_LANG_CALL AC_LANG_FUNC_TRY_LINK AC_MSG_FAILURE AC_PREPROC_IFELSE" - ac2_54_macros="AC_C_BACKSLASH_A AC_CONFIG_LIBOBJ_DIR AC_GNU_SOURCE AC_PROG_EGREP AC_PROG_FGREP AC_REPLACE_FNMATCH AC_FUNC_FNMATCH_GNU AC_FUNC_REALLOC AC_TYPE_MBSTATE_T" - - macros_to_search="" - ac_major="`echo ${AUTOCONF_VERSION}. | cut -d. -f1 | sed 's/[^0-9]//g'`" - ac_minor="`echo ${AUTOCONF_VERSION}. | cut -d. -f2 | sed 's/[^0-9]//g'`" - - if [ $ac_major -lt 2 ] ; then - macros_to_search="$ac2_59_macros $ac2_55_macros $ac2_54_macros" - else - if [ $ac_minor -lt 54 ] ; then - macros_to_search="$ac2_59_macros $ac2_55_macros $ac2_54_macros" - elif [ $ac_minor -lt 55 ] ; then - macros_to_search="$ac2_59_macros $ac2_55_macros" - elif [ $ac_minor -lt 59 ] ; then - macros_to_search="$ac2_59_macros" - fi - fi - - configure_ac_macros=__none__ - for feature in $macros_to_search ; do - $VERBOSE_ECHO "Searching for $feature in $CONFIGURE" - found="`grep \"^$feature.*\" $CONFIGURE`" - if [ ! "x$found" = "x" ] ; then - if [ "x$configure_ac_macros" = "x__none__" ] ; then - configure_ac_macros="$feature" - else - configure_ac_macros="$feature $configure_ac_macros" - fi - fi - done - if [ ! "x$configure_ac_macros" = "x__none__" ] ; then - $ECHO - $ECHO "Warning: Unsupported macros were found in $CONFIGURE" - $ECHO - $ECHO "The `basename \"$CONFIGURE\"` file was scanned in order to determine if any" - $ECHO "unsupported macros are used that exceed the minimum version" - $ECHO "settings specified within this file. As such, the following macros" - $ECHO "should be removed from configure.ac or the version numbers in this" - $ECHO "file should be increased:" - $ECHO - $ECHO "$configure_ac_macros" - $ECHO - $ECHO $ECHO_N "Ignorantly continuing build preparation ... $ECHO_C" - fi - - ################### - # autoconf, retry # - ################### - $VERBOSE_ECHO - $VERBOSE_ECHO "$AUTOCONF" - autoconf_output="`$AUTOCONF 2>&1`" - ret=$? - $VERBOSE_ECHO "$autoconf_output" - - if [ ! $ret = 0 ] ; then - # test if libtool is busted - libtool_failure "$autoconf_output" - - # let the user know what went wrong - cat < License: GPL-3+ @@ -66,7 +61,7 @@ . This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for more details. . You should have received a copy of the GNU Affero General Public License -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I87676cdf6818b4250f478962baf96ad5f28564d5 Gerrit-Change-Number: 14984 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 17:11:19 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 17:11:19 +0000 Subject: Change in ...osmo-trx[master]: Drop old README information, provide new updated README Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14985 Change subject: Drop old README information, provide new updated README ...................................................................... Drop old README information, provide new updated README Previous content in README file is actually a description of the TRXD and TRXC protocols, and it has already been moved to the User Manual some time ago. INSTALLATION contained README related information, but it was really out of date. So this commit basically drops those two files and provides a new README with content taken from Osmocom's OsmoTRX project wiki page. Change-Id: I3df00799ce80aa4af43225e69a408ba2cbc444db --- D INSTALLATION M Makefile.am M README 3 files changed, 18 insertions(+), 132 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/85/14985/1 diff --git a/INSTALLATION b/INSTALLATION deleted file mode 100644 index f87b6cc..0000000 --- a/INSTALLATION +++ /dev/null @@ -1,19 +0,0 @@ -Installation Requirements - - - -osmo-trx compiles to a simple Unix binary and does not require special -installation. - -One some systems (Ubuntu), you will need to define LIBS = -lpthread prior to -running configure. - -To run osmo-trx, the following should be installed: - libuhd (https://gnuradio.org). - This is part of the GNURadio installation. - -For information on specific executables, see tests/README.tests and -apps/README.apps. - -See https://osmocom.org/projects/osmotrx/wiki/OsmoTRX for more -information. diff --git a/Makefile.am b/Makefile.am index 3e87200..ccc39a2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -36,7 +36,6 @@ tests EXTRA_DIST = \ - INSTALLATION \ LEGAL \ COPYING \ README diff --git a/README b/README index 502d661..7747fc8 100644 --- a/README +++ b/README @@ -1,116 +1,22 @@ -This is the interface to the transcevier. +About OsmTRX +============= -Each TRX Manager UDP socket interface represents a single ARFCN. -Each of these per-ARFCN interfaces is a pair of UDP sockets, one for control and one for data. -Give a base port B (5700), the master clock interface is at port P=B. -The TRX-side control interface for C(N) is on port P=B+2N+1 and the data interface is on an odd numbered port P=B+2N+2. -The corresponding core-side interface for every socket is at P+100. -For any given build, the number of ARFCN interfaces can be fixed. +OsmoTRX is a software-defined radio transceiver that implements the Layer 1 +physical layer of a BTS comprising the following 3GPP specifications: +* TS 05.01 "Physical layer on the radio path" +* TS 05.02 "Multiplexing and Multiple Access on the Radio Path" +* TS 05.04 "Modulation" +* TS 05.10 "Radio subsystem synchronization" +OsmoTRX is based on the transceiver code from the OpenBTS project, but setup to +operate independently with the purpose of using with non-OpenBTS software and +projects, while still maintaining backwards compatibility with OpenBTS when +possible. Currently there are numerous features contained in OsmoTRX that extend +the functionality of the OpenBTS transceiver. These features include enhanced +support for various embedded platforms - notably ARM - and dual channel +diversity support for the Fairwaves umtrx. -Indications on the Master Clock Interface - -The master clock interface is output only (from the radio). -Messages are "indications". - -CLOCK gives the current value of the transceiver clock to be used by the core. -This message is sent whenever a trasmission packet arrives that is too late or too early. The clock value is NOT the current transceiver time. It is a time setting the the core should use to give better packet arrival times. -IND CLOCK - - - -Commands on the Per-ARFCN Control Interface - -The per-ARFCN control interface uses a command-reponse protocol. -Commands are NULL-terminated ASCII strings, one per UDP socket. -Each command has a corresponding response. -Every command is of the form: - -CMD [params] - -The is the actual command. -Parameters are optional depending on the commands type. -Every response is of the form: - -RSP [result] - -The is 0 for success and a non-zero error code for failure. -Successful responses may include results, depending on the command type. - - -Power Control - -POWEROFF shuts off transmitter power and stops the demodulator. -CMD POWEROFF -RSP POWEROFF - -POWERON starts the transmitter and starts the demodulator. Initial power level is very low. -This command fails if the transmitter and receiver are not yet tuned. -This command fails if the transmit or receive frequency creates a conflict with another ARFCN that is already runnng. -If the transceiver is already on, it response with success to this command. -CMD POWERON -RSP POWERON - -SETPOWER sets output power in dB wrt full scale. -This command fails if the transmitter and receiver are not running. -CMD SETPOWER -RSP SETPOWER - -ADJPOWER adjusts power by the given dB step. Response returns resulting power level wrt full scale. -This command fails if the transmitter and receiver are not running. -CMD ADJPOWER -RSP ADJPOWER - - -Tuning Control - -RXTUNE tunes the receiver to a given frequency in kHz. -This command fails if the receiver is already running. -(To re-tune you stop the radio, re-tune, and restart.) -This command fails if the transmit or receive frequency creates a conflict with another ARFCN that is already runnng. -CMD RXTUNE -RSP RXTUNE - -TXTUNE tunes the transmitter to a given frequency in kHz. -This command fails if the transmitter is already running. -(To re-tune you stop the radio, re-tune, and restart.) -This command fails if the transmit or receive frequency creates a conflict with another ARFCN that is already runnng. -CMD TXTUNE -RSP TXTUNE - - -Timeslot Control - -SETSLOT sets the format of the uplink timeslots in the ARFCN. -The indicates the timeslot of interest. -The indicates the type of channel that occupies the timeslot. -A chantype of zero indicates the timeslot is off. -CMD SETSLOT -RSP SETSLOT - - -Messages on the per-ARFCN Data Interface - -Messages on the data interface carry one radio burst per UDP message. - - -Received Data Burst - -1 byte timeslot index -4 bytes GSM frame number, big endian -1 byte RSSI in -dBm -2 bytes correlator timing offset in 1/256 symbol steps, 2's-comp, big endian -148 bytes soft symbol estimates, 0 -> definite "0", 255 -> definite "1" - - -Transmit Data Burst - -1 byte timeslot index -4 bytes GSM frame number, big endian -1 byte transmit level wrt ARFCN max, -dB (attenuation) -148 bytes output symbol values, 0 & 1 - - - - +Find OsmoTRX issue tracker and wiki online at +https://osmocom.org/projects/osmotrx +https://osmocom.org/projects/osmotrx/wiki/OsmoTRX -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3df00799ce80aa4af43225e69a408ba2cbc444db Gerrit-Change-Number: 14985 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 17:50:09 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Jul 2019 17:50:09 +0000 Subject: Change in ...libosmocore[master]: add vty logp command to echo on all log targets Message-ID: neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14986 Change subject: add vty logp command to echo on all log targets ...................................................................... add vty logp command to echo on all log targets When reading SUT logs resulting from TTCN3 runs, it can be hard to figure out which log section corresponds to which test code. Add a 'logp' command on VIEW and ENABLE nodes that simply echos an arbitrary message on log output, useful to set markers / explanations from the TTCN3 code, which then appear in all log outputs and can make it trivial to figure out which log section is interesting. logging_vty_test# logp lglobal notice This is the log message DLGLOBAL NOTICE This is the log message >From TTCN3, could be used like this, e.g. in BSC_Tests.ttcn: private function f_logp(charstring log_msg) runs on MSC_ConnHdlr { // log on TTCN3 log output log(log_msg); // log in stderr log f_vty_transceive(BSCVTY, "logp lglobal notice " & log_msg); } ... f_logp("f_probe_for_handover(" & log_label & "): Ending the test: Handover Failure stops the procedure."); Change-Id: Ife5dc8999174c74e0d133729284fe526d6eaf8d9 --- M src/vty/logging_vty.c M tests/logging/logging_vty_test.vty 2 files changed, 94 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/86/14986/1 diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index f3e1419..7491974 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -987,6 +987,44 @@ install_element(CFG_LOG_NODE, cmd); } +/* logp () (debug|...|fatal) .LOGMESSAGE*/ +DEFUN(vty_logp, + vty_logp_cmd, + NULL, /* cmdstr is dynamically set in gen_vty_logp_cmd_strs(). */ + NULL) /* same thing for helpstr. */ +{ + int category = log_parse_category(argv[0]); + int level = log_parse_level(argv[1]); + char *str = argv_concat(argv, argc, 2); + LOGP(category, level, "%s\n", str); + return CMD_SUCCESS; +} + +static void gen_vty_logp_cmd_strs(struct cmd_element *cmd) +{ + char *cmd_str = NULL; + char *doc_str = NULL; + + assert_loginfo(__func__); + + OSMO_ASSERT(cmd->string == NULL); + OSMO_ASSERT(cmd->doc == NULL); + + osmo_talloc_asprintf(tall_log_ctx, cmd_str, "logp ("); + osmo_talloc_asprintf(tall_log_ctx, doc_str, + "Print a message on all log outputs; useful for placing markers in test logs\n"); + add_category_strings(&cmd_str, &doc_str, osmo_log_info); + osmo_talloc_asprintf(tall_log_ctx, cmd_str, ") %s", LOG_LEVEL_ARGS); + osmo_talloc_asprintf(tall_log_ctx, doc_str, "%s", LOG_LEVEL_STRS); + + osmo_talloc_asprintf(tall_log_ctx, cmd_str, " .LOGMESSAGE"); + osmo_talloc_asprintf(tall_log_ctx, doc_str, + "Arbitrary message to log on given category and log level\n"); + + cmd->string = cmd_str; + cmd->doc = doc_str; +} + /*! Register logging related commands to the VTY. Call this once from * your application if you want to support those commands. */ void logging_vty_add_cmds() @@ -1022,6 +1060,9 @@ install_element_ve(&show_logging_vty_cmd); install_element_ve(&show_alarms_cmd); + gen_vty_logp_cmd_strs(&vty_logp_cmd); + install_element_ve(&vty_logp_cmd); + install_node(&cfg_log_node, config_write_log); install_element(CFG_LOG_NODE, &logging_fltr_all_cmd); install_element(CFG_LOG_NODE, &logging_use_clr_cmd); diff --git a/tests/logging/logging_vty_test.vty b/tests/logging/logging_vty_test.vty index 895d2bc..d77f8ce 100644 --- a/tests/logging/logging_vty_test.vty +++ b/tests/logging/logging_vty_test.vty @@ -468,3 +468,56 @@ DDDDD ERROR Log message for DDDDD on level LOGL_ERROR DDDDD FATAL Log message for DDDDD on level LOGL_FATAL DEEE FATAL Log message for DEEE on level LOGL_FATAL + +logging_vty_test# list +... + logp (aa|bb|ccc|dddd|eee|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro) (debug|info|notice|error|fatal) .LOGMESSAGE +... + +logging_vty_test# logp? + logp Print a message on all log outputs; useful for placing markers in test logs + +logging_vty_test# logp ? + aa Antropomorphic Armadillos (AA) + bb Bidirectional Breadspread (BB) + ccc Chaos Communication Congress (CCC) + dddd Dehydrated Dribbling Duck Dunkers (DDDD) + eee Exhaustive Entropy Extraction (EEE) + lglobal Library-internal global log family + llapd LAPD in libosmogsm + linp A-bis Intput Subsystem + lmux A-bis B-Subchannel TRAU Frame Multiplex + lmi A-bis Input Driver for Signalling + lmib A-bis Input Driver for B-Channels (voice) + lsms Layer3 Short Message Service (SMS) + lctrl Control Interface + lgtp GPRS GTP library + lstats Statistics messages and logging + lgsup Generic Subscriber Update Protocol + loap Osmocom Authentication Protocol + lss7 libosmo-sigtran Signalling System 7 + lsccp libosmo-sigtran SCCP Implementation + lsua libosmo-sigtran SCCP User Adaptation + lm3ua libosmo-sigtran MTP3 User Adaptation + lmgcp libosmo-mgcp Media Gateway Control Protocol + ljibuf libosmo-netif Jitter Buffer + lrspro Remote SIM protocol + +logging_vty_test# logp lglobal ? + debug Log debug messages and higher levels + info Log informational messages and higher levels + notice Log noticeable messages and higher levels + error Log error messages and higher levels + fatal Log only fatal messages + +logging_vty_test# logp lglobal info ? + LOGMESSAGE Arbitrary message to log on given category and log level + +logging_vty_test# logging level set-all notice + +logging_vty_test# logp aa error This is the log message +DAA ERROR This is the log message + +logging_vty_test# logp lglobal debug This log message is not echoed +logging_vty_test# logp lglobal notice This log message is echoed +DLGLOBAL NOTICE This log message is echoed -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ife5dc8999174c74e0d133729284fe526d6eaf8d9 Gerrit-Change-Number: 14986 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 17:53:37 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Jul 2019 17:53:37 +0000 Subject: Change in ...osmo-bsc[master]: add vty 'no neighbors' to remove all HO targets In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14768 ) Change subject: add vty 'no neighbors' to remove all HO targets ...................................................................... Patch Set 1: (5 comments) https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c File src/osmo-bsc/neighbor_ident_vty.c: https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c at 392 PS1, Line 392: static int del_all(struct vty *vty) > let's make this a bit more descriptive like neighbor_del_all, neigh_del_all, bts_remove_all_neighbor [?] I figured since it's in the static context, the short name would do. But indeed, in other places I argued for longer names. so ack. https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c at 403 PS1, Line 403: if (!bts) { : vty_out(vty, "%% Error: cannot remove BTS neighbor, no BTS on this node%s", : VTY_NEWLINE); : return CMD_WARNING; : } > it's arguable whether the removal of 0 neighbors is successful or an error (warning esentially is th [?] This comment applies below. This here is more like another assert error: on a vty node that has a NULL vty->index where a BTS pointer would be expected. https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c at 410 PS1, Line 410: while (1) { : struct gsm_bts_ref *neigh = llist_first_entry_or_null(&bts->local_neighbors, struct gsm_bts_ref, entry); > why are we not using llist_for_each_entry() here? It seems more natural to me. [?] This is a style bikeshed... Since this aims at removing *all* items, I preferred a while() loop: it doesn't need two gsm_bts_ref variables (for llist_for_each_entry_safe) to be declared outside of the loop scope. The exit conditions are sane, no danger of infinite loops. We also have other such while() loops which are arguably even safer than llist_for_each_entry_safe() -- not in this case, but generally if more than one item could be removed per iteration. https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c at 432 PS1, Line 432: neighbor_ident_iter(g_neighbor_cells, nil_match_bts, &d); BTW, when inventing the neighbor_ident, I wanted the API as opaque as possible, which seemed to be a good idea (TM). I have since regretted the choice of an opaque iteration at least five times. Next time I would again go for a transparently open llist instead of a clumsy iter callback mechanism. Considered refactoring it, but probably not worth the effort now... https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c at 449 PS1, Line 449: return CMD_WARNING; above comment applies here instead: "it's arguable whether the removal of 0 neighbors is successful or an error (warning esentially is the error, as they only altrenative is CMD_FATAL which terminates the process)." Will return CMD_SUCCESS instead. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8623ab581639e9f8af6a9ff1eca990518d1b1211 Gerrit-Change-Number: 14768 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 29 Jul 2019 17:53:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 17:53:46 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Jul 2019 17:53:46 +0000 Subject: Change in ...osmo-bsc[master]: add vty 'no neighbors' to remove all HO targets In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/14768 to look at the new patch set (#2). Change subject: add vty 'no neighbors' to remove all HO targets ...................................................................... add vty 'no neighbors' to remove all HO targets This is required for an upcoming TTCN3 test that plays through various neighbor configurations. Related: OS#4056 Ia4ba0e75abd3d45a3422b2525e5f938cdc5a04cc (osmo-ttcn3-hacks) Change-Id: I8623ab581639e9f8af6a9ff1eca990518d1b1211 --- M src/osmo-bsc/neighbor_ident_vty.c M tests/neighbor_ident.vty 2 files changed, 111 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/68/14768/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8623ab581639e9f8af6a9ff1eca990518d1b1211 Gerrit-Change-Number: 14768 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 17:53:46 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Mon, 29 Jul 2019 17:53:46 +0000 Subject: Change in ...osmo-bsc[master]: neighbor config: allow re-using ARFCN+BSIC pairs In-Reply-To: References: Message-ID: Hello pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/14769 to look at the new patch set (#2). Change subject: neighbor config: allow re-using ARFCN+BSIC pairs ...................................................................... neighbor config: allow re-using ARFCN+BSIC pairs Fix neighbor config to match OsmoBSC manual: implement the plan for neighbor configuration that was so far only described in the manual without actually being in operation. This first allows re-using ARFCN+BSIC pairs in and across BSS. So far the handover_start() code always looked for handover target cells across *all* local cells, even if they were not listed as neighbors to a source cell. Imply all cells as neighbors only as long as there are no explicit neighbors configured. As soon as the first 'neighbor' line appears in a 'bts' config, only the listed neighbors are regarded as handover target cells. (The 'neighbor-list' commands are not related to this, only the relatively new 'neighbor (bts|lac|cgi|...)' commands affect actual handover procedures.) TTCN3 tests TC_ho_neighbor_config_1 thru _7 play through the various aspects of neighbor configuration: both the legacy implicit all-cells-are-neighbors as well as allowing only explicit neighbors by config. Related: OS#4056 Related: osmo-ttcn3-hacks Ia4ba0e75abd3d45a3422b2525e5f938cdc5a04cc Change-Id: I29bca59ab232eddc74e0d4698efb9c9992443983 --- M include/osmocom/bsc/handover.h M include/osmocom/bsc/handover_fsm.h M include/osmocom/bsc/neighbor_ident.h M src/osmo-bsc/handover_decision_2.c M src/osmo-bsc/handover_fsm.c M src/osmo-bsc/handover_logic.c M src/osmo-bsc/neighbor_ident_vty.c M tests/bsc/bsc_test.c 8 files changed, 241 insertions(+), 61 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/69/14769/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29bca59ab232eddc74e0d4698efb9c9992443983 Gerrit-Change-Number: 14769 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:03:39 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Mon, 29 Jul 2019 18:03:39 +0000 Subject: Change in ...osmo-mgw[master]: Fix return variable of strtoul() In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14966 ) Change subject: Fix return variable of strtoul() ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp-client/mgcp_client.c File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp-client/mgcp_client.c at 312 PS1, Line 312: r->codecs[count] = pt; > Lots of places only specify 0-127 as values (with the latter being dynamic). [?] Done https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp/mgcp_sdp.c File src/libosmo-mgcp/mgcp_sdp.c: https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp/mgcp_sdp.c at 168 PS1, Line 168: if (codecs[i].payload_type == pt) > Here as well Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ice9eee6a252fab73dbab5ebf3cfc83c1b354fd08 Gerrit-Change-Number: 14966 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 18:03:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:14:49 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:14:49 +0000 Subject: Change in ...osmo-mgw[master]: Fix return variable of strtoul() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14966 ) Change subject: Fix return variable of strtoul() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ice9eee6a252fab73dbab5ebf3cfc83c1b354fd08 Gerrit-Change-Number: 14966 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 18:14:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:15:50 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:15:50 +0000 Subject: Change in ...osmo-bsc[master]: neighbor config: allow re-using ARFCN+BSIC pairs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14769 ) Change subject: neighbor config: allow re-using ARFCN+BSIC pairs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14769 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I29bca59ab232eddc74e0d4698efb9c9992443983 Gerrit-Change-Number: 14769 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 18:15:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:20:09 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:20:09 +0000 Subject: Change in ...osmo-bsc[master]: add vty 'no neighbors' to remove all HO targets In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14768 ) Change subject: add vty 'no neighbors' to remove all HO targets ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c File src/osmo-bsc/neighbor_ident_vty.c: https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c at 410 PS1, Line 410: while (1) { : struct gsm_bts_ref *neigh = llist_first_entry_or_null(&bts->local_neighbors, struct gsm_bts_ref, entry); > This is a style bikeshed... [?] Call it bikeshed, but I'm always for using the designated API of a given sub-system (linuxlist.h here) than manual constructs. You're free to ignore this, https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c at 432 PS1, Line 432: neighbor_ident_iter(g_neighbor_cells, nil_match_bts, &d); > BTW, when inventing the neighbor_ident, I wanted the API as opaque as possible, which seemed to be a [?] In terms of style, I also don't think we have any iterator functions in other osmocom code, but generally the "list user" iterates open/manually over the llist_head -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8623ab581639e9f8af6a9ff1eca990518d1b1211 Gerrit-Change-Number: 14768 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 29 Jul 2019 18:20:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:21:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:21:22 +0000 Subject: Change in ...libosmocore[master]: add vty logp command to echo on all log targets In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14986 ) Change subject: add vty logp command to echo on all log targets ...................................................................... Patch Set 1: Code-Review+1 very nice idea! -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ife5dc8999174c74e0d133729284fe526d6eaf8d9 Gerrit-Change-Number: 14986 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 29 Jul 2019 18:21:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:22:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:22:05 +0000 Subject: Change in ...osmo-trx[master]: Remove unused autogen.sh In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14984 ) Change subject: Remove unused autogen.sh ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I87676cdf6818b4250f478962baf96ad5f28564d5 Gerrit-Change-Number: 14984 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 29 Jul 2019 18:22:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:22:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:22:16 +0000 Subject: Change in ...osmo-trx[master]: Remove empty ChangeLog fnd NEWS files In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14983 ) Change subject: Remove empty ChangeLog fnd NEWS files ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5a90107476ca116bebc8569f4eb1db0fa25807a6 Gerrit-Change-Number: 14983 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 29 Jul 2019 18:22:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:25:03 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:25:03 +0000 Subject: Change in ...osmo-trx[master]: Drop old README information, provide new updated README In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14985 ) Change subject: Drop old README information, provide new updated README ...................................................................... Patch Set 1: I think the README should definitely point to the user manual, which is probably the most important document to read. Please also note that most other osmocom projects have a README.md in mark-down syntax, which results in nicely rendered "about" pages both on our cgit (for example http://git.osmocom.org/libosmocore/about/) as well as the github mirror. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3df00799ce80aa4af43225e69a408ba2cbc444db Gerrit-Change-Number: 14985 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 29 Jul 2019 18:25:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:26:25 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:26:25 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Small fixes In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 ) Change subject: configuration.adoc: Small fixes ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc File doc/manuals/chapters/configuration.adoc: https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc at 20 PS1, Line 20: an why an? "MS" doesn't start with a vowel? Maybe I should read up on english, feel free to ignore me if I'm wrong. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558 Gerrit-Change-Number: 14981 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 18:26:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:27:17 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:27:17 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Add a section about encryption In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 ) Change subject: configuration.adoc: Add a section about encryption ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14982/1/doc/manuals/chapters/configuration.adoc File doc/manuals/chapters/configuration.adoc: https://gerrit.osmocom.org/#/c/14982/1/doc/manuals/chapters/configuration.adoc at 352 PS1, Line 352: GEA did anyone ever test GEA4? It uses 128bit key length and is hence quite a bit different than GEA1/2/3. Maybe switch the example to GEA3 to be safe? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3a2b84d386f55447e9eed35e59fdc0272e5147d1 Gerrit-Change-Number: 14982 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 29 Jul 2019 18:27:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:28:57 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:28:57 +0000 Subject: Change in ...libosmocore[master]: gsm0808_test: Fix wrong use of memcp In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14979 ) Change subject: gsm0808_test: Fix wrong use of memcp ...................................................................... Patch Set 1: Code-Review+1 In such situations I would also stick with the simplicity of memcmp() and simply make sure the input data structures are always zero-initialized before. But let's not argue about an unit test here... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I17fe7a0a5dc650f050bba1f47d071be749550729 Gerrit-Change-Number: 14979 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 29 Jul 2019 18:28:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:29:52 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:29:52 +0000 Subject: Change in ...osmo-ggsn[master]: sgsnemu: Fix unaligned pointer access during ip/icmp checksum In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14980 ) Change subject: sgsnemu: Fix unaligned pointer access during ip/icmp checksum ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14980/1/sgsnemu/sgsnemu.c File sgsnemu/sgsnemu.c: https://gerrit.osmocom.org/#/c/14980/1/sgsnemu/sgsnemu.c at 1285 PS1, Line 1285: memcpy(&v16, p8, 2); don't we have osmo_load16be or something like that for exactly this kind of situation? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I783f104c31234a07f2a13f6dbc577a71b25b36a7 Gerrit-Change-Number: 14980 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 29 Jul 2019 18:29:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:30:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:30:35 +0000 Subject: Change in ...osmo-iuh[master]: Add VTY reference manual In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14978 ) Change subject: Add VTY reference manual ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14978 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I042734fa9979b598d5471839e408cbf39bba57b5 Gerrit-Change-Number: 14978 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 29 Jul 2019 18:30:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:30:38 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:30:38 +0000 Subject: Change in ...osmo-iuh[master]: Add VTY reference manual In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14978 ) Change subject: Add VTY reference manual ...................................................................... Add VTY reference manual Fixes: OS#2589 Change-Id: I042734fa9979b598d5471839e408cbf39bba57b5 --- M configure.ac M doc/Makefile.am A doc/manuals/Makefile.am A doc/manuals/osmohnbgw-vty-reference.xml A doc/manuals/regen_doc.sh A doc/manuals/vty/hnbgw_vty_additions.xml A doc/manuals/vty/hnbgw_vty_reference.xml 7 files changed, 1,651 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/configure.ac b/configure.ac index 559db39..dc3d1eb 100644 --- a/configure.ac +++ b/configure.ac @@ -79,6 +79,48 @@ CFLAGS="$CFLAGS -Wall" CPPFLAGS="$CPPFLAGS -Wall" +# Generate manuals +AC_ARG_ENABLE(manuals, + [AS_HELP_STRING( + [--enable-manuals], + [Generate manual PDFs [default=no]], + )], + [osmo_ac_build_manuals=$enableval], [osmo_ac_build_manuals="no"]) +AM_CONDITIONAL([BUILD_MANUALS], [test x"$osmo_ac_build_manuals" = x"yes"]) +AC_ARG_VAR(OSMO_GSM_MANUALS_DIR, [path to common osmo-gsm-manuals files, overriding pkg-config and "../osmo-gsm-manuals" + fallback]) +if test x"$osmo_ac_build_manuals" = x"yes" +then + # Find OSMO_GSM_MANUALS_DIR (env, pkg-conf, fallback) + if test -n "$OSMO_GSM_MANUALS_DIR"; then + echo "checking for OSMO_GSM_MANUALS_DIR... $OSMO_GSM_MANUALS_DIR (from env)" + else + OSMO_GSM_MANUALS_DIR="$($PKG_CONFIG osmo-gsm-manuals --variable=osmogsmmanualsdir 2>/dev/null)" + if test -n "$OSMO_GSM_MANUALS_DIR"; then + echo "checking for OSMO_GSM_MANUALS_DIR... $OSMO_GSM_MANUALS_DIR (from pkg-conf)" + else + OSMO_GSM_MANUALS_DIR="../osmo-gsm-manuals" + echo "checking for OSMO_GSM_MANUALS_DIR... $OSMO_GSM_MANUALS_DIR (fallback)" + fi + fi + if ! test -d "$OSMO_GSM_MANUALS_DIR"; then + AC_MSG_ERROR("OSMO_GSM_MANUALS_DIR does not exist! Install osmo-gsm-manuals or set OSMO_GSM_MANUALS_DIR.") + fi + + # Find and run check-depends + CHECK_DEPENDS="$OSMO_GSM_MANUALS_DIR/check-depends.sh" + if ! test -x "$CHECK_DEPENDS"; then + CHECK_DEPENDS="osmo-gsm-manuals-check-depends" + fi + if ! $CHECK_DEPENDS; then + AC_MSG_ERROR("missing dependencies for --enable-manuals") + fi + + # Put in Makefile with absolute path + OSMO_GSM_MANUALS_DIR="$(realpath "$OSMO_GSM_MANUALS_DIR")" + AC_SUBST([OSMO_GSM_MANUALS_DIR]) +fi + # https://www.freedesktop.org/software/systemd/man/daemon.html AC_ARG_WITH([systemdsystemunitdir], [AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd service files])],, @@ -114,6 +156,7 @@ include/osmocom/iuh/Makefile doc/Makefile doc/examples/Makefile + doc/manuals/Makefile contrib/Makefile contrib/systemd/Makefile ) diff --git a/doc/Makefile.am b/doc/Makefile.am index 81a25e2..eeed875 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -1,4 +1,7 @@ -SUBDIRS = examples +SUBDIRS = \ + examples \ + manuals \ + $(NULL) EXTRA_DIST = \ hnb_cs_lu.msc \ diff --git a/doc/manuals/Makefile.am b/doc/manuals/Makefile.am new file mode 100644 index 0000000..91aa8f8 --- /dev/null +++ b/doc/manuals/Makefile.am @@ -0,0 +1,12 @@ +EXTRA_DIST = \ + osmohnbgw-vty-reference.xml \ + regen_doc.sh \ + vty + +if BUILD_MANUALS + VTY_REFERENCE = osmohnbgw-vty-reference.xml + include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.vty-reference.inc + + OSMO_REPOSITORY = osmo-hnbgw + include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.common.inc +endif diff --git a/doc/manuals/osmohnbgw-vty-reference.xml b/doc/manuals/osmohnbgw-vty-reference.xml new file mode 100644 index 0000000..cd69333 --- /dev/null +++ b/doc/manuals/osmohnbgw-vty-reference.xml @@ -0,0 +1,38 @@ + + + + +]> + + + + + + v1 + 29th July 2019 + dw + Initial + + + + OsmoHNBGW VTY Reference + + + 2019 + + + + This work is copyright by sysmocom - s.f.m.c. GmbH. All rights reserved. + + + + + + &chapter-vty; + + diff --git a/doc/manuals/regen_doc.sh b/doc/manuals/regen_doc.sh new file mode 100755 index 0000000..39dd9ee --- /dev/null +++ b/doc/manuals/regen_doc.sh @@ -0,0 +1,17 @@ +#!/bin/sh -x + +if [ -z "$DOCKER_PLAYGROUND" ]; then + echo "You need to set DOCKER_PLAYGROUND" + exit 1 +fi + +SCRIPT=$(realpath "$0") +MANUAL_DIR=$(dirname "$SCRIPT") + +COMMIT=${COMMIT:-$(git log -1 --format=format:%H)} + +cd "$DOCKER_PLAYGROUND/scripts" || exit 1 + +OSMO_SGSN_BRANCH=$COMMIT ./regen_doc.sh osmo-hnbgw 4261 \ + "$MANUAL_DIR/chapters/counters_generated.adoc" \ + "$MANUAL_DIR/vty/hnbgw_vty_reference.xml" diff --git a/doc/manuals/vty/hnbgw_vty_additions.xml b/doc/manuals/vty/hnbgw_vty_additions.xml new file mode 100644 index 0000000..a4c675e --- /dev/null +++ b/doc/manuals/vty/hnbgw_vty_additions.xml @@ -0,0 +1,2 @@ + + diff --git a/doc/manuals/vty/hnbgw_vty_reference.xml b/doc/manuals/vty/hnbgw_vty_reference.xml new file mode 100644 index 0000000..4046636 --- /dev/null +++ b/doc/manuals/vty/hnbgw_vty_reference.xml @@ -0,0 +1,1535 @@ + + + Common Commands + These commands are available on all VTY nodes. They are listed here only once, to unclutter the VTY reference. + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + view + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + enable + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-log + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-line + + + + + + + + + + + + + + + + + + + + + config-cs7 + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-cs7-as + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-cs7-asp + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-cs7-sccpaddr + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-cs7-sccpaddr-gt + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + config-hnbgw + + + + + + + + + + + + + + + + + + + + + + + + config-hnbgw-iuh + + + + + + + + + + + + + + + + + + + + + + config-hnbgw-iucs + + + + + + + + + config-hnbgw-iups + + + + + + + + -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14978 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I042734fa9979b598d5471839e408cbf39bba57b5 Gerrit-Change-Number: 14978 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:33:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 18:33:25 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Small fixes In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 ) Change subject: configuration.adoc: Small fixes ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc File doc/manuals/chapters/configuration.adoc: https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc at 20 PS1, Line 20: an > why an? "MS" doesn't start with a vowel? Maybe I should read up on english, feel free to ignore me i [?] While your statement is true, I also tend to do same thing as Daniel did here, because it feels more natural when reading/talking, because MS is pronounced something like "EMES", so phonetically it starts with a vowel. Not sure if it applies as a correct English norm though ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558 Gerrit-Change-Number: 14981 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 18:33:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:33:54 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:33:54 +0000 Subject: Change in ...osmo-remsim[master]: add contrib/remsim-apitool.py to control the REST-interface of osmo-r... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14968 ) Change subject: add contrib/remsim-apitool.py to control the REST-interface of osmo-remsim-server ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/14968/1/contrib/remsim-apitool.py File contrib/remsim-apitool.py: https://gerrit.osmocom.org/#/c/14968/1/contrib/remsim-apitool.py at 65 PS1, Line 65: group.add_argument("-c", "--clients", help="show clients (GET /clients)",nargs='?',const="all",default=None) Let's go for more "orthogonal" long commands, such as "--show-clients, --show-banks, --show-slotmaps and --create-slotmap, --show-all --delete-slotmap". This way it's easier to extend in the future, where we might have other maps, or other things to delete. Please change accordingly. One might even do away with the short options (single-character ones) as they're more difficult to understand/read/memorize. This part is up to you. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia01b0a89e21af18b898becd8f5440c32936772b7 Gerrit-Change-Number: 14968 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 29 Jul 2019 18:33:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:36:00 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 18:36:00 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Small fixes In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 ) Change subject: configuration.adoc: Small fixes ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc File doc/manuals/chapters/configuration.adoc: https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc at 20 PS1, Line 20: an > While your statement is true, I also tend to do same thing as Daniel did here, because it feels more [?] https://english.stackexchange.com/questions/1016/do-you-use-a-or-an-before-acronyms-initialisms -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558 Gerrit-Change-Number: 14981 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 29 Jul 2019 18:36:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:36:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Mon, 29 Jul 2019 18:36:16 +0000 Subject: Change in ...simtrace2[master]: add new board and app for gpio testing on octsimtest board In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/14969 ) Change subject: add new board and app for gpio testing on octsimtest board ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14969/1/firmware/libboard/octsimtest/include/board.h File firmware/libboard/octsimtest/include/board.h: https://gerrit.osmocom.org/#/c/14969/1/firmware/libboard/octsimtest/include/board.h at 1 PS1, Line 1: SIMtrace copy+paste error https://gerrit.osmocom.org/#/c/14969/1/firmware/libboard/octsimtest/include/board.h at 3 PS1, Line 3: * (C) 2016-2017 by Harald Welte : * (C) 2018 by sysmocom -s.f.m.c. GmbH, Author: Kevin Redon (C) 2019 by sysmocom - s.fm.c. GmbH, Author: Joachim Steiger -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/14969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I01243044002f51b34e8dc12c1b1f565bbf1740a2 Gerrit-Change-Number: 14969 Gerrit-PatchSet: 1 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 29 Jul 2019 18:36:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:38:32 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 18:38:32 +0000 Subject: Change in ...osmo-ggsn[master]: sgsnemu: Fix unaligned pointer access during ip/icmp checksum In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14980 ) Change subject: sgsnemu: Fix unaligned pointer access during ip/icmp checksum ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14980/1/sgsnemu/sgsnemu.c File sgsnemu/sgsnemu.c: https://gerrit.osmocom.org/#/c/14980/1/sgsnemu/sgsnemu.c at 1285 PS1, Line 1285: memcpy(&v16, p8, 2); > don't we have osmo_load16be or something like that for exactly this kind of situation? To be honest, I'm not sure if that would be the same in this case. iiuc, on a LittleEndian system it would swap the 2 bytes, and we don't want that here? This kind of stuff always confused me a lot... -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I783f104c31234a07f2a13f6dbc577a71b25b36a7 Gerrit-Change-Number: 14980 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 29 Jul 2019 18:38:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:42:30 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 18:42:30 +0000 Subject: Change in ...osmo-trx[master]: Remove empty ChangeLog fnd NEWS files In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14983 ) Change subject: Remove empty ChangeLog fnd NEWS files ...................................................................... Remove empty ChangeLog fnd NEWS files We already have debian/changelog for same purpose. This file is empty and doesn't exist on other osmocom projects. Change-Id: I5a90107476ca116bebc8569f4eb1db0fa25807a6 --- D ChangeLog D NEWS 2 files changed, 0 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ChangeLog b/ChangeLog deleted file mode 100644 index e69de29..0000000 --- a/ChangeLog +++ /dev/null diff --git a/NEWS b/NEWS deleted file mode 100644 index e69de29..0000000 --- a/NEWS +++ /dev/null -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5a90107476ca116bebc8569f4eb1db0fa25807a6 Gerrit-Change-Number: 14983 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:42:31 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 18:42:31 +0000 Subject: Change in ...osmo-trx[master]: Remove unused autogen.sh In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/14984 ) Change subject: Remove unused autogen.sh ...................................................................... Remove unused autogen.sh autoreconf is used instead, as done in all of the osmocom projects. Change-Id: I87676cdf6818b4250f478962baf96ad5f28564d5 --- M Makefile.am D autogen.sh M debian/copyright 3 files changed, 1 insertion(+), 1,585 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/Makefile.am b/Makefile.am index 79c4e06..3e87200 100644 --- a/Makefile.am +++ b/Makefile.am @@ -36,7 +36,6 @@ tests EXTRA_DIST = \ - autogen.sh \ INSTALLATION \ LEGAL \ COPYING \ diff --git a/autogen.sh b/autogen.sh deleted file mode 100755 index b2ed160..0000000 --- a/autogen.sh +++ /dev/null @@ -1,1578 +0,0 @@ -#!/bin/sh -# a u t o g e n . s h -# -# Copyright (c) 2005-2009 United States Government as represented by -# the U.S. Army Research Laboratory. -# -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions -# are met: -# -# 1. Redistributions of source code must retain the above copyright -# notice, this list of conditions and the following disclaimer. -# -# 2. Redistributions in binary form must reproduce the above -# copyright notice, this list of conditions and the following -# disclaimer in the documentation and/or other materials provided -# with the distribution. -# -# 3. The name of the author may not be used to endorse or promote -# products derived from this software without specific prior written -# permission. -# -# THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS -# OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED -# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE -# ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY -# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL -# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE -# GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS -# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, -# WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING -# NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS -# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -# -### -# -# Script for automatically preparing the sources for compilation by -# performing the myrid of necessary steps. The script attempts to -# detect proper version support, and outputs warnings about particular -# systems that have autotool peculiarities. -# -# Basically, if everything is set up and installed correctly, the -# script will validate that minimum versions of the GNU Build System -# tools are installed, account for several common configuration -# issues, and then simply run autoreconf for you. -# -# If autoreconf fails, which can happen for many valid configurations, -# this script proceeds to run manual preparation steps effectively -# providing a POSIX shell script (mostly complete) reimplementation of -# autoreconf. -# -# The AUTORECONF, AUTOCONF, AUTOMAKE, LIBTOOLIZE, ACLOCAL, AUTOHEADER -# environment variables and corresponding _OPTIONS variables (e.g. -# AUTORECONF_OPTIONS) may be used to override the default automatic -# detection behaviors. Similarly the _VERSION variables will override -# the minimum required version numbers. -# -# Examples: -# -# To obtain help on usage: -# ./autogen.sh --help -# -# To obtain verbose output: -# ./autogen.sh --verbose -# -# To skip autoreconf and prepare manually: -# AUTORECONF=false ./autogen.sh -# -# To verbosely try running with an older (unsupported) autoconf: -# AUTOCONF_VERSION=2.50 ./autogen.sh --verbose -# -# Author: -# Christopher Sean Morrison -# -# Patches: -# Sebastian Pipping -# -###################################################################### - -# set to minimum acceptible version of autoconf -if [ "x$AUTOCONF_VERSION" = "x" ] ; then - AUTOCONF_VERSION=2.52 -fi -# set to minimum acceptible version of automake -if [ "x$AUTOMAKE_VERSION" = "x" ] ; then - AUTOMAKE_VERSION=1.6.0 -fi -# set to minimum acceptible version of libtool -if [ "x$LIBTOOL_VERSION" = "x" ] ; then - LIBTOOL_VERSION=1.4.2 -fi - - -################## -# ident function # -################## -ident ( ) { - # extract copyright from header - __copyright="`grep Copyright $AUTOGEN_SH | head -${HEAD_N}1 | awk '{print $4}'`" - if [ "x$__copyright" = "x" ] ; then - __copyright="`date +%Y`" - fi - - # extract version from CVS Id string - __id="$Id: autogen.sh 33925 2009-03-01 23:27:06Z brlcad $" - __version="`echo $__id | sed 's/.*\([0-9][0-9][0-9][0-9]\)[-\/]\([0-9][0-9]\)[-\/]\([0-9][0-9]\).*/\1\2\3/'`" - if [ "x$__version" = "x" ] ; then - __version="" - fi - - echo "autogen.sh build preparation script by Christopher Sean Morrison" - echo " + config.guess download patch by Sebastian Pipping (2008-12-03)" - echo "revised 3-clause BSD-style license, copyright (c) $__copyright" - echo "script version $__version, ISO/IEC 9945 POSIX shell script" -} - - -################## -# USAGE FUNCTION # -################## -usage ( ) { - echo "Usage: $AUTOGEN_SH [-h|--help] [-v|--verbose] [-q|--quiet] [-d|--download] [--version]" - echo " --help Help on $NAME_OF_AUTOGEN usage" - echo " --verbose Verbose progress output" - echo " --quiet Quiet suppressed progress output" - echo " --download Download the latest config.guess from gnulib" - echo " --version Only perform GNU Build System version checks" - echo - echo "Description: This script will validate that minimum versions of the" - echo "GNU Build System tools are installed and then run autoreconf for you." - echo "Should autoreconf fail, manual preparation steps will be run" - echo "potentially accounting for several common preparation issues. The" - - echo "AUTORECONF, AUTOCONF, AUTOMAKE, LIBTOOLIZE, ACLOCAL, AUTOHEADER," - echo "PROJECT, & CONFIGURE environment variables and corresponding _OPTIONS" - echo "variables (e.g. AUTORECONF_OPTIONS) may be used to override the" - echo "default automatic detection behavior." - echo - - ident - - return 0 -} - - -########################## -# VERSION_ERROR FUNCTION # -########################## -version_error ( ) { - if [ "x$1" = "x" ] ; then - echo "INTERNAL ERROR: version_error was not provided a version" - exit 1 - fi - if [ "x$2" = "x" ] ; then - echo "INTERNAL ERROR: version_error was not provided an application name" - exit 1 - fi - $ECHO - $ECHO "ERROR: To prepare the ${PROJECT} build system from scratch," - $ECHO " at least version $1 of $2 must be installed." - $ECHO - $ECHO "$NAME_OF_AUTOGEN does not need to be run on the same machine that will" - $ECHO "run configure or make. Either the GNU Autotools will need to be installed" - $ECHO "or upgraded on this system, or $NAME_OF_AUTOGEN must be run on the source" - $ECHO "code on another system and then transferred to here. -- Cheers!" - $ECHO -} - -########################## -# VERSION_CHECK FUNCTION # -########################## -version_check ( ) { - if [ "x$1" = "x" ] ; then - echo "INTERNAL ERROR: version_check was not provided a minimum version" - exit 1 - fi - _min="$1" - if [ "x$2" = "x" ] ; then - echo "INTERNAL ERROR: version check was not provided a comparison version" - exit 1 - fi - _cur="$2" - - # needed to handle versions like 1.10 and 1.4-p6 - _min="`echo ${_min}. | sed 's/[^0-9]/./g' | sed 's/\.\././g'`" - _cur="`echo ${_cur}. | sed 's/[^0-9]/./g' | sed 's/\.\././g'`" - - _min_major="`echo $_min | cut -d. -f1`" - _min_minor="`echo $_min | cut -d. -f2`" - _min_patch="`echo $_min | cut -d. -f3`" - - _cur_major="`echo $_cur | cut -d. -f1`" - _cur_minor="`echo $_cur | cut -d. -f2`" - _cur_patch="`echo $_cur | cut -d. -f3`" - - if [ "x$_min_major" = "x" ] ; then - _min_major=0 - fi - if [ "x$_min_minor" = "x" ] ; then - _min_minor=0 - fi - if [ "x$_min_patch" = "x" ] ; then - _min_patch=0 - fi - if [ "x$_cur_minor" = "x" ] ; then - _cur_major=0 - fi - if [ "x$_cur_minor" = "x" ] ; then - _cur_minor=0 - fi - if [ "x$_cur_patch" = "x" ] ; then - _cur_patch=0 - fi - - $VERBOSE_ECHO "Checking if ${_cur_major}.${_cur_minor}.${_cur_patch} is greater than ${_min_major}.${_min_minor}.${_min_patch}" - - if [ $_min_major -lt $_cur_major ] ; then - return 0 - elif [ $_min_major -eq $_cur_major ] ; then - if [ $_min_minor -lt $_cur_minor ] ; then - return 0 - elif [ $_min_minor -eq $_cur_minor ] ; then - if [ $_min_patch -lt $_cur_patch ] ; then - return 0 - elif [ $_min_patch -eq $_cur_patch ] ; then - return 0 - fi - fi - fi - return 1 -} - - -###################################### -# LOCATE_CONFIGURE_TEMPLATE FUNCTION # -###################################### -locate_configure_template ( ) { - _pwd="`pwd`" - if test -f "./configure.ac" ; then - echo "./configure.ac" - elif test -f "./configure.in" ; then - echo "./configure.in" - elif test -f "$_pwd/configure.ac" ; then - echo "$_pwd/configure.ac" - elif test -f "$_pwd/configure.in" ; then - echo "$_pwd/configure.in" - elif test -f "$PATH_TO_AUTOGEN/configure.ac" ; then - echo "$PATH_TO_AUTOGEN/configure.ac" - elif test -f "$PATH_TO_AUTOGEN/configure.in" ; then - echo "$PATH_TO_AUTOGEN/configure.in" - fi -} - - -################## -# argument check # -################## -ARGS="$*" -PATH_TO_AUTOGEN="`dirname $0`" -NAME_OF_AUTOGEN="`basename $0`" -AUTOGEN_SH="$PATH_TO_AUTOGEN/$NAME_OF_AUTOGEN" - -LIBTOOL_M4="${PATH_TO_AUTOGEN}/misc/libtool.m4" - -if [ "x$HELP" = "x" ] ; then - HELP=no -fi -if [ "x$QUIET" = "x" ] ; then - QUIET=no -fi -if [ "x$VERBOSE" = "x" ] ; then - VERBOSE=no -fi -if [ "x$VERSION_ONLY" = "x" ] ; then - VERSION_ONLY=no -fi -if [ "x$DOWNLOAD" = "x" ] ; then - DOWNLOAD=no -fi -if [ "x$AUTORECONF_OPTIONS" = "x" ] ; then - AUTORECONF_OPTIONS="-i -f" -fi -if [ "x$AUTOCONF_OPTIONS" = "x" ] ; then - AUTOCONF_OPTIONS="-f" -fi -if [ "x$AUTOMAKE_OPTIONS" = "x" ] ; then - AUTOMAKE_OPTIONS="-a -c -f" -fi -ALT_AUTOMAKE_OPTIONS="-a -c" -if [ "x$LIBTOOLIZE_OPTIONS" = "x" ] ; then - LIBTOOLIZE_OPTIONS="--automake -c -f" -fi -ALT_LIBTOOLIZE_OPTIONS="--automake --copy --force" -if [ "x$ACLOCAL_OPTIONS" = "x" ] ; then - ACLOCAL_OPTIONS="" -fi -if [ "x$AUTOHEADER_OPTIONS" = "x" ] ; then - AUTOHEADER_OPTIONS="" -fi -if [ "x$CONFIG_GUESS_URL" = "x" ] ; then - CONFIG_GUESS_URL="http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob_plain;f=build-aux/config.guess;hb=HEAD" -fi -for arg in $ARGS ; do - case "x$arg" in - x--help) HELP=yes ;; - x-[hH]) HELP=yes ;; - x--quiet) QUIET=yes ;; - x-[qQ]) QUIET=yes ;; - x--verbose) VERBOSE=yes ;; - x-[dD]) DOWNLOAD=yes ;; - x--download) DOWNLOAD=yes ;; - x-[vV]) VERBOSE=yes ;; - x--version) VERSION_ONLY=yes ;; - *) - echo "Unknown option: $arg" - echo - usage - exit 1 - ;; - esac -done - - -##################### -# environment check # -##################### - -# sanity check before recursions potentially begin -if [ ! -f "$AUTOGEN_SH" ] ; then - echo "INTERNAL ERROR: $AUTOGEN_SH does not exist" - if [ ! "x$0" = "x$AUTOGEN_SH" ] ; then - echo "INTERNAL ERROR: dirname/basename inconsistency: $0 != $AUTOGEN_SH" - fi - exit 1 -fi - -# force locale setting to C so things like date output as expected -LC_ALL=C - -# commands that this script expects -for __cmd in echo head tail pwd ; do - echo "test" | $__cmd > /dev/null 2>&1 - if [ $? != 0 ] ; then - echo "INTERNAL ERROR: '${__cmd}' command is required" - exit 2 - fi -done -echo "test" | grep "test" > /dev/null 2>&1 -if test ! x$? = x0 ; then - echo "INTERNAL ERROR: grep command is required" - exit 1 -fi -echo "test" | sed "s/test/test/" > /dev/null 2>&1 -if test ! x$? = x0 ; then - echo "INTERNAL ERROR: sed command is required" - exit 1 -fi - - -# determine the behavior of echo -case `echo "testing\c"; echo 1,2,3`,`echo -n testing; echo 1,2,3` in - *c*,-n*) ECHO_N= ECHO_C=' -' ECHO_T=' ' ;; - *c*,* ) ECHO_N=-n ECHO_C= ECHO_T= ;; - *) ECHO_N= ECHO_C='\c' ECHO_T= ;; -esac - -# determine the behavior of head -case "x`echo 'head' | head -n 1 2>&1`" in - *xhead*) HEAD_N="n " ;; - *) HEAD_N="" ;; -esac - -# determine the behavior of tail -case "x`echo 'tail' | tail -n 1 2>&1`" in - *xtail*) TAIL_N="n " ;; - *) TAIL_N="" ;; -esac - -VERBOSE_ECHO=: -ECHO=: -if [ "x$QUIET" = "xyes" ] ; then - if [ "x$VERBOSE" = "xyes" ] ; then - echo "Verbose output quelled by quiet option. Further output disabled." - fi -else - ECHO=echo - if [ "x$VERBOSE" = "xyes" ] ; then - echo "Verbose output enabled" - VERBOSE_ECHO=echo - fi -fi - - -# allow a recursive run to disable further recursions -if [ "x$RUN_RECURSIVE" = "x" ] ; then - RUN_RECURSIVE=yes -fi - - -################################################ -# check for help arg and bypass version checks # -################################################ -if [ "x`echo $ARGS | sed 's/.*[hH][eE][lL][pP].*/help/'`" = "xhelp" ] ; then - HELP=yes -fi -if [ "x$HELP" = "xyes" ] ; then - usage - $ECHO "---" - $ECHO "Help was requested. No preparation or configuration will be performed." - exit 0 -fi - - -####################### -# set up signal traps # -####################### -untrap_abnormal ( ) { - for sig in 1 2 13 15; do - trap - $sig - done -} - -# do this cleanup whenever we exit. -trap ' - # start from the root - if test -d "$START_PATH" ; then - cd "$START_PATH" - fi - - # restore/delete backup files - if test "x$PFC_INIT" = "x1" ; then - recursive_restore - fi -' 0 - -# trap SIGHUP (1), SIGINT (2), SIGPIPE (13), SIGTERM (15) -for sig in 1 2 13 15; do - trap ' - $ECHO "" - $ECHO "Aborting $NAME_OF_AUTOGEN: caught signal '$sig'" - - # start from the root - if test -d "$START_PATH" ; then - cd "$START_PATH" - fi - - # clean up on abnormal exit - $VERBOSE_ECHO "rm -rf autom4te.cache" - rm -rf autom4te.cache - - if test -f "acinclude.m4.$$.backup" ; then - $VERBOSE_ECHO "cat acinclude.m4.$$.backup > acinclude.m4" - chmod u+w acinclude.m4 - cat acinclude.m4.$$.backup > acinclude.m4 - - $VERBOSE_ECHO "rm -f acinclude.m4.$$.backup" - rm -f acinclude.m4.$$.backup - fi - - { (exit 1); exit 1; } -' $sig -done - - -############################# -# look for a configure file # -############################# -if [ "x$CONFIGURE" = "x" ] ; then - CONFIGURE="`locate_configure_template`" - if [ ! "x$CONFIGURE" = "x" ] ; then - $VERBOSE_ECHO "Found a configure template: $CONFIGURE" - fi -else - $ECHO "Using CONFIGURE environment variable override: $CONFIGURE" -fi -if [ "x$CONFIGURE" = "x" ] ; then - if [ "x$VERSION_ONLY" = "xyes" ] ; then - CONFIGURE=/dev/null - else - $ECHO - $ECHO "A configure.ac or configure.in file could not be located implying" - $ECHO "that the GNU Build System is at least not used in this directory. In" - $ECHO "any case, there is nothing to do here without one of those files." - $ECHO - $ECHO "ERROR: No configure.in or configure.ac file found in `pwd`" - exit 1 - fi -fi - -#################### -# get project name # -#################### -if [ "x$PROJECT" = "x" ] ; then - PROJECT="`grep AC_INIT $CONFIGURE | grep -v '.*#.*AC_INIT' | tail -${TAIL_N}1 | sed 's/^[ ]*AC_INIT(\([^,)]*\).*/\1/' | sed 's/.*\[\(.*\)\].*/\1/'`" - if [ "x$PROJECT" = "xAC_INIT" ] ; then - # projects might be using the older/deprecated arg-less AC_INIT .. look for AM_INIT_AUTOMAKE instead - PROJECT="`grep AM_INIT_AUTOMAKE $CONFIGURE | grep -v '.*#.*AM_INIT_AUTOMAKE' | tail -${TAIL_N}1 | sed 's/^[ ]*AM_INIT_AUTOMAKE(\([^,)]*\).*/\1/' | sed 's/.*\[\(.*\)\].*/\1/'`" - fi - if [ "x$PROJECT" = "xAM_INIT_AUTOMAKE" ] ; then - PROJECT="project" - fi - if [ "x$PROJECT" = "x" ] ; then - PROJECT="project" - fi -else - $ECHO "Using PROJECT environment variable override: $PROJECT" -fi -$ECHO "Preparing the $PROJECT build system...please wait" -$ECHO - - -######################## -# check for autoreconf # -######################## -HAVE_AUTORECONF=no -if [ "x$AUTORECONF" = "x" ] ; then - for AUTORECONF in autoreconf ; do - $VERBOSE_ECHO "Checking autoreconf version: $AUTORECONF --version" - $AUTORECONF --version > /dev/null 2>&1 - if [ $? = 0 ] ; then - HAVE_AUTORECONF=yes - break - fi - done -else - HAVE_AUTORECONF=yes - $ECHO "Using AUTORECONF environment variable override: $AUTORECONF" -fi - - -########################## -# autoconf version check # -########################## -_acfound=no -if [ "x$AUTOCONF" = "x" ] ; then - for AUTOCONF in autoconf ; do - $VERBOSE_ECHO "Checking autoconf version: $AUTOCONF --version" - $AUTOCONF --version > /dev/null 2>&1 - if [ $? = 0 ] ; then - _acfound=yes - break - fi - done -else - _acfound=yes - $ECHO "Using AUTOCONF environment variable override: $AUTOCONF" -fi - -_report_error=no -if [ ! "x$_acfound" = "xyes" ] ; then - $ECHO "ERROR: Unable to locate GNU Autoconf." - _report_error=yes -else - _version="`$AUTOCONF --version | head -${HEAD_N}1 | sed 's/[^0-9]*\([0-9\.][0-9\.]*\)/\1/'`" - if [ "x$_version" = "x" ] ; then - _version="0.0.0" - fi - $ECHO "Found GNU Autoconf version $_version" - version_check "$AUTOCONF_VERSION" "$_version" - if [ $? -ne 0 ] ; then - _report_error=yes - fi -fi -if [ "x$_report_error" = "xyes" ] ; then - version_error "$AUTOCONF_VERSION" "GNU Autoconf" - exit 1 -fi - - -########################## -# automake version check # -########################## -_amfound=no -if [ "x$AUTOMAKE" = "x" ] ; then - for AUTOMAKE in automake ; do - $VERBOSE_ECHO "Checking automake version: $AUTOMAKE --version" - $AUTOMAKE --version > /dev/null 2>&1 - if [ $? = 0 ] ; then - _amfound=yes - break - fi - done -else - _amfound=yes - $ECHO "Using AUTOMAKE environment variable override: $AUTOMAKE" -fi - - -_report_error=no -if [ ! "x$_amfound" = "xyes" ] ; then - $ECHO - $ECHO "ERROR: Unable to locate GNU Automake." - _report_error=yes -else - _version="`$AUTOMAKE --version | head -${HEAD_N}1 | sed 's/[^0-9]*\([0-9\.][0-9\.]*\)/\1/'`" - if [ "x$_version" = "x" ] ; then - _version="0.0.0" - fi - $ECHO "Found GNU Automake version $_version" - version_check "$AUTOMAKE_VERSION" "$_version" - if [ $? -ne 0 ] ; then - _report_error=yes - fi -fi -if [ "x$_report_error" = "xyes" ] ; then - version_error "$AUTOMAKE_VERSION" "GNU Automake" - exit 1 -fi - - -######################## -# check for libtoolize # -######################## -HAVE_LIBTOOLIZE=yes -HAVE_ALT_LIBTOOLIZE=no -_ltfound=no -if [ "x$LIBTOOLIZE" = "x" ] ; then - LIBTOOLIZE=libtoolize - $VERBOSE_ECHO "Checking libtoolize version: $LIBTOOLIZE --version" - $LIBTOOLIZE --version > /dev/null 2>&1 - if [ ! $? = 0 ] ; then - HAVE_LIBTOOLIZE=no - $ECHO - if [ "x$HAVE_AUTORECONF" = "xno" ] ; then - $ECHO "Warning: libtoolize does not appear to be available." - else - $ECHO "Warning: libtoolize does not appear to be available. This means that" - $ECHO "the automatic build preparation via autoreconf will probably not work." - $ECHO "Preparing the build by running each step individually, however, should" - $ECHO "work and will be done automatically for you if autoreconf fails." - fi - - # look for some alternates - for tool in glibtoolize libtoolize15 libtoolize14 libtoolize13 ; do - $VERBOSE_ECHO "Checking libtoolize alternate: $tool --version" - _glibtoolize="`$tool --version > /dev/null 2>&1`" - if [ $? = 0 ] ; then - $VERBOSE_ECHO "Found $tool --version" - _glti="`which $tool`" - if [ "x$_glti" = "x" ] ; then - $VERBOSE_ECHO "Cannot find $tool with which" - continue; - fi - if test ! -f "$_glti" ; then - $VERBOSE_ECHO "Cannot use $tool, $_glti is not a file" - continue; - fi - _gltidir="`dirname $_glti`" - if [ "x$_gltidir" = "x" ] ; then - $VERBOSE_ECHO "Cannot find $tool path with dirname of $_glti" - continue; - fi - if test ! -d "$_gltidir" ; then - $VERBOSE_ECHO "Cannot use $tool, $_gltidir is not a directory" - continue; - fi - HAVE_ALT_LIBTOOLIZE=yes - LIBTOOLIZE="$tool" - $ECHO - $ECHO "Fortunately, $tool was found which means that your system may simply" - $ECHO "have a non-standard or incomplete GNU Autotools install. If you have" - $ECHO "sufficient system access, it may be possible to quell this warning by" - $ECHO "running:" - $ECHO - sudo -V > /dev/null 2>&1 - if [ $? = 0 ] ; then - $ECHO " sudo ln -s $_glti $_gltidir/libtoolize" - $ECHO - else - $ECHO " ln -s $_glti $_gltidir/libtoolize" - $ECHO - $ECHO "Run that as root or with proper permissions to the $_gltidir directory" - $ECHO - fi - _ltfound=yes - break - fi - done - else - _ltfound=yes - fi -else - _ltfound=yes - $ECHO "Using LIBTOOLIZE environment variable override: $LIBTOOLIZE" -fi - - -############################ -# libtoolize version check # -############################ -_report_error=no -if [ ! "x$_ltfound" = "xyes" ] ; then - $ECHO - $ECHO "ERROR: Unable to locate GNU Libtool." - _report_error=yes -else - _version="`$LIBTOOLIZE --version | head -${HEAD_N}1 | sed 's/[^0-9]*\([0-9\.][0-9\.]*\)/\1/'`" - if [ "x$_version" = "x" ] ; then - _version="0.0.0" - fi - $ECHO "Found GNU Libtool version $_version" - version_check "$LIBTOOL_VERSION" "$_version" - if [ $? -ne 0 ] ; then - _report_error=yes - fi -fi -if [ "x$_report_error" = "xyes" ] ; then - version_error "$LIBTOOL_VERSION" "GNU Libtool" - exit 1 -fi - - -##################### -# check for aclocal # -##################### -if [ "x$ACLOCAL" = "x" ] ; then - for ACLOCAL in aclocal ; do - $VERBOSE_ECHO "Checking aclocal version: $ACLOCAL --version" - $ACLOCAL --version > /dev/null 2>&1 - if [ $? = 0 ] ; then - break - fi - done -else - $ECHO "Using ACLOCAL environment variable override: $ACLOCAL" -fi - - -######################## -# check for autoheader # -######################## -if [ "x$AUTOHEADER" = "x" ] ; then - for AUTOHEADER in autoheader ; do - $VERBOSE_ECHO "Checking autoheader version: $AUTOHEADER --version" - $AUTOHEADER --version > /dev/null 2>&1 - if [ $? = 0 ] ; then - break - fi - done -else - $ECHO "Using AUTOHEADER environment variable override: $AUTOHEADER" -fi - - -######################### -# check if version only # -######################### -$VERBOSE_ECHO "Checking whether to only output version information" -if [ "x$VERSION_ONLY" = "xyes" ] ; then - $ECHO - ident - $ECHO "---" - $ECHO "Version requested. No preparation or configuration will be performed." - exit 0 -fi - - -################################# -# PROTECT_FROM_CLOBBER FUNCTION # -################################# -protect_from_clobber ( ) { - PFC_INIT=1 - - # protect COPYING & INSTALL from overwrite by automake. the - # automake force option will (inappropriately) ignore the existing - # contents of a COPYING and/or INSTALL files (depending on the - # version) instead of just forcing *missing* files like it does - # for AUTHORS, NEWS, and README. this is broken but extremely - # prevalent behavior, so we protect against it by keeping a backup - # of the file that can later be restored. - - for file in COPYING INSTALL ; do - if test -f ${file} ; then - if test -f ${file}.$$.protect_from_automake.backup ; then - $VERBOSE_ECHO "Already backed up ${file} in `pwd`" - else - $VERBOSE_ECHO "Backing up ${file} in `pwd`" - $VERBOSE_ECHO "cp -p ${file} ${file}.$$.protect_from_automake.backup" - cp -p ${file} ${file}.$$.protect_from_automake.backup - fi - fi - done -} - - -############################## -# RECURSIVE_PROTECT FUNCTION # -############################## -recursive_protect ( ) { - - # for projects using recursive configure, run the build - # preparation steps for the subdirectories. this function assumes - # START_PATH was set to pwd before recursion begins so that - # relative paths work. - - # git 'r done, protect COPYING and INSTALL from being clobbered - protect_from_clobber - - if test -d autom4te.cache ; then - $VERBOSE_ECHO "Found an autom4te.cache directory, deleting it" - $VERBOSE_ECHO "rm -rf autom4te.cache" - rm -rf autom4te.cache - fi - - # find configure template - _configure="`locate_configure_template`" - if [ "x$_configure" = "x" ] ; then - return - fi - # $VERBOSE_ECHO "Looking for configure template found `pwd`/$_configure" - - # look for subdirs - # $VERBOSE_ECHO "Looking for subdirs in `pwd`" - _det_config_subdirs="`grep AC_CONFIG_SUBDIRS $_configure | grep -v '.*#.*AC_CONFIG_SUBDIRS' | sed 's/^[ ]*AC_CONFIG_SUBDIRS(\(.*\)).*/\1/' | sed 's/.*\[\(.*\)\].*/\1/'`" - CHECK_DIRS="" - for dir in $_det_config_subdirs ; do - if test -d "`pwd`/$dir" ; then - CHECK_DIRS="$CHECK_DIRS \"`pwd`/$dir\"" - fi - done - - # process subdirs - if [ ! "x$CHECK_DIRS" = "x" ] ; then - $VERBOSE_ECHO "Recursively scanning the following directories:" - $VERBOSE_ECHO " $CHECK_DIRS" - for dir in $CHECK_DIRS ; do - $VERBOSE_ECHO "Protecting files from automake in $dir" - cd "$START_PATH" - eval "cd $dir" - - # recursively git 'r done - recursive_protect - done - fi -} # end of recursive_protect - - -############################# -# RESTORE_CLOBBERED FUNCION # -############################# -restore_clobbered ( ) { - - # The automake (and autoreconf by extension) -f/--force-missing - # option may overwrite COPYING and INSTALL even if they do exist. - # Here we restore the files if necessary. - - spacer=no - - for file in COPYING INSTALL ; do - if test -f ${file}.$$.protect_from_automake.backup ; then - if test -f ${file} ; then - # compare entire content, restore if needed - if test "x`cat ${file}`" != "x`cat ${file}.$$.protect_from_automake.backup`" ; then - if test "x$spacer" = "xno" ; then - $VERBOSE_ECHO - spacer=yes - fi - # restore the backup - $VERBOSE_ECHO "Restoring ${file} from backup (automake -f likely clobbered it)" - $VERBOSE_ECHO "rm -f ${file}" - rm -f ${file} - $VERBOSE_ECHO "mv ${file}.$$.protect_from_automake.backup ${file}" - mv ${file}.$$.protect_from_automake.backup ${file} - fi # check contents - elif test -f ${file}.$$.protect_from_automake.backup ; then - $VERBOSE_ECHO "mv ${file}.$$.protect_from_automake.backup ${file}" - mv ${file}.$$.protect_from_automake.backup ${file} - fi # -f ${file} - - # just in case - $VERBOSE_ECHO "rm -f ${file}.$$.protect_from_automake.backup" - rm -f ${file}.$$.protect_from_automake.backup - fi # -f ${file}.$$.protect_from_automake.backup - done - - CONFIGURE="`locate_configure_template`" - if [ "x$CONFIGURE" = "x" ] ; then - return - fi - - _aux_dir="`grep AC_CONFIG_AUX_DIR $CONFIGURE | grep -v '.*#.*AC_CONFIG_AUX_DIR' | tail -${TAIL_N}1 | sed 's/^[ ]*AC_CONFIG_AUX_DIR(\(.*\)).*/\1/' | sed 's/.*\[\(.*\)\].*/\1/'`" - if test ! -d "$_aux_dir" ; then - _aux_dir=. - fi - - for file in config.guess config.sub ltmain.sh ; do - if test -f "${_aux_dir}/${file}" ; then - $VERBOSE_ECHO "rm -f \"${_aux_dir}/${file}.backup\"" - rm -f "${_aux_dir}/${file}.backup" - fi - done -} # end of restore_clobbered - - -############################## -# RECURSIVE_RESTORE FUNCTION # -############################## -recursive_restore ( ) { - - # restore COPYING and INSTALL from backup if they were clobbered - # for each directory recursively. - - # git 'r undone - restore_clobbered - - # find configure template - _configure="`locate_configure_template`" - if [ "x$_configure" = "x" ] ; then - return - fi - - # look for subdirs - _det_config_subdirs="`grep AC_CONFIG_SUBDIRS $_configure | grep -v '.*#.*AC_CONFIG_SUBDIRS' | sed 's/^[ ]*AC_CONFIG_SUBDIRS(\(.*\)).*/\1/' | sed 's/.*\[\(.*\)\].*/\1/'`" - CHECK_DIRS="" - for dir in $_det_config_subdirs ; do - if test -d "`pwd`/$dir" ; then - CHECK_DIRS="$CHECK_DIRS \"`pwd`/$dir\"" - fi - done - - # process subdirs - if [ ! "x$CHECK_DIRS" = "x" ] ; then - $VERBOSE_ECHO "Recursively scanning the following directories:" - $VERBOSE_ECHO " $CHECK_DIRS" - for dir in $CHECK_DIRS ; do - $VERBOSE_ECHO "Checking files for automake damage in $dir" - cd "$START_PATH" - eval "cd $dir" - - # recursively git 'r undone - recursive_restore - done - fi -} # end of recursive_restore - - -####################### -# INITIALIZE FUNCTION # -####################### -initialize ( ) { - - # this routine performs a variety of directory-specific - # initializations. some are sanity checks, some are preventive, - # and some are necessary setup detection. - # - # this function sets: - # CONFIGURE - # SEARCH_DIRS - # CONFIG_SUBDIRS - - ################################## - # check for a configure template # - ################################## - CONFIGURE="`locate_configure_template`" - if [ "x$CONFIGURE" = "x" ] ; then - $ECHO - $ECHO "A configure.ac or configure.in file could not be located implying" - $ECHO "that the GNU Build System is at least not used in this directory. In" - $ECHO "any case, there is nothing to do here without one of those files." - $ECHO - $ECHO "ERROR: No configure.in or configure.ac file found in `pwd`" - exit 1 - fi - - ##################### - # detect an aux dir # - ##################### - _aux_dir="`grep AC_CONFIG_AUX_DIR $CONFIGURE | grep -v '.*#.*AC_CONFIG_AUX_DIR' | tail -${TAIL_N}1 | sed 's/^[ ]*AC_CONFIG_AUX_DIR(\(.*\)).*/\1/' | sed 's/.*\[\(.*\)\].*/\1/'`" - if test ! -d "$_aux_dir" ; then - _aux_dir=. - else - $VERBOSE_ECHO "Detected auxillary directory: $_aux_dir" - fi - - ################################ - # detect a recursive configure # - ################################ - CONFIG_SUBDIRS="" - _det_config_subdirs="`grep AC_CONFIG_SUBDIRS $CONFIGURE | grep -v '.*#.*AC_CONFIG_SUBDIRS' | sed 's/^[ ]*AC_CONFIG_SUBDIRS(\(.*\)).*/\1/' | sed 's/.*\[\(.*\)\].*/\1/'`" - for dir in $_det_config_subdirs ; do - if test -d "`pwd`/$dir" ; then - $VERBOSE_ECHO "Detected recursive configure directory: `pwd`/$dir" - CONFIG_SUBDIRS="$CONFIG_SUBDIRS `pwd`/$dir" - fi - done - - ########################################################### - # make sure certain required files exist for GNU projects # - ########################################################### - _marker_found="" - _marker_found_message_intro='Detected non-GNU marker "' - _marker_found_message_mid='" in ' - for marker in foreign cygnus ; do - _marker_found_message=${_marker_found_message_intro}${marker}${_marker_found_message_mid} - _marker_found="`grep 'AM_INIT_AUTOMAKE.*'${marker} $CONFIGURE`" - if [ ! "x$_marker_found" = "x" ] ; then - $VERBOSE_ECHO "${_marker_found_message}`basename \"$CONFIGURE\"`" - break - fi - if test -f "`dirname \"$CONFIGURE\"/Makefile.am`" ; then - _marker_found="`grep 'AUTOMAKE_OPTIONS.*'${marker} Makefile.am`" - if [ ! "x$_marker_found" = "x" ] ; then - $VERBOSE_ECHO "${_marker_found_message}Makefile.am" - break - fi - fi - done - if [ "x${_marker_found}" = "x" ] ; then - _suggest_foreign=no - for file in AUTHORS COPYING ChangeLog INSTALL NEWS README ; do - if [ ! -f $file ] ; then - $VERBOSE_ECHO "Touching ${file} since it does not exist" - _suggest_foreign=yes - touch $file - fi - done - - if [ "x${_suggest_foreign}" = "xyes" ] ; then - $ECHO - $ECHO "Warning: Several files expected of projects that conform to the GNU" - $ECHO "coding standards were not found. The files were automatically added" - $ECHO "for you since you do not have a 'foreign' declaration specified." - $ECHO - $ECHO "Considered adding 'foreign' to AM_INIT_AUTOMAKE in `basename \"$CONFIGURE\"`" - if test -f "`dirname \"$CONFIGURE\"/Makefile.am`" ; then - $ECHO "or to AUTOMAKE_OPTIONS in your top-level Makefile.am file." - fi - $ECHO - fi - fi - - ################################################## - # make sure certain generated files do not exist # - ################################################## - for file in config.guess config.sub ltmain.sh ; do - if test -f "${_aux_dir}/${file}" ; then - $VERBOSE_ECHO "mv -f \"${_aux_dir}/${file}\" \"${_aux_dir}/${file}.backup\"" - mv -f "${_aux_dir}/${file}" "${_aux_dir}/${file}.backup" - fi - done - - ############################ - # search alternate m4 dirs # - ############################ - SEARCH_DIRS="" - for dir in m4 ; do - if [ -d $dir ] ; then - $VERBOSE_ECHO "Found extra aclocal search directory: $dir" - SEARCH_DIRS="$SEARCH_DIRS -I $dir" - fi - done - - ###################################### - # remove any previous build products # - ###################################### - if test -d autom4te.cache ; then - $VERBOSE_ECHO "Found an autom4te.cache directory, deleting it" - $VERBOSE_ECHO "rm -rf autom4te.cache" - rm -rf autom4te.cache - fi -# tcl/tk (and probably others) have a customized aclocal.m4, so can't delete it -# if test -f aclocal.m4 ; then -# $VERBOSE_ECHO "Found an aclocal.m4 file, deleting it" -# $VERBOSE_ECHO "rm -f aclocal.m4" -# rm -f aclocal.m4 -# fi - -} # end of initialize() - - -############## -# initialize # -############## - -# stash path -START_PATH="`pwd`" - -# Before running autoreconf or manual steps, some prep detection work -# is necessary or useful. Only needs to occur once per directory, but -# does need to traverse the entire subconfigure hierarchy to protect -# files from being clobbered even by autoreconf. -recursive_protect - -# start from where we started -cd "$START_PATH" - -# get ready to process -initialize - - -######################################### -# DOWNLOAD_GNULIB_CONFIG_GUESS FUNCTION # -######################################### - -# TODO - should make sure wget/curl exist and/or work before trying to -# use them. - -download_gnulib_config_guess () { - # abuse gitweb to download gnulib's latest config.guess via HTTP - config_guess_temp="config.guess.$$.download" - ret=1 - for __cmd in wget curl fetch ; do - $VERBOSE_ECHO "Checking for command ${__cmd}" - ${__cmd} --version > /dev/null 2>&1 - ret=$? - if [ ! $ret = 0 ] ; then - continue - fi - - __cmd_version=`${__cmd} --version | head -n 1 | sed -e 's/^[^0-9]\+//' -e 's/ .*//'` - $VERBOSE_ECHO "Found ${__cmd} ${__cmd_version}" - - opts="" - case ${__cmd} in - wget) - opts="-O" - ;; - curl) - opts="-o" - ;; - fetch) - opts="-t 5 -f" - ;; - esac - - $VERBOSE_ECHO "Running $__cmd \"${CONFIG_GUESS_URL}\" $opts \"${config_guess_temp}\"" - eval "$__cmd \"${CONFIG_GUESS_URL}\" $opts \"${config_guess_temp}\"" > /dev/null 2>&1 - if [ $? = 0 ] ; then - mv -f "${config_guess_temp}" ${_aux_dir}/config.guess - ret=0 - break - fi - done - - if [ ! $ret = 0 ] ; then - $ECHO "Warning: config.guess download failed from: $CONFIG_GUESS_URL" - rm -f "${config_guess_temp}" - fi -} - - -############################## -# LIBTOOLIZE_NEEDED FUNCTION # -############################## -libtoolize_needed () { - ret=1 # means no, don't need libtoolize - for feature in AC_PROG_LIBTOOL AM_PROG_LIBTOOL LT_INIT ; do - $VERBOSE_ECHO "Searching for $feature in $CONFIGURE" - found="`grep \"^$feature.*\" $CONFIGURE`" - if [ ! "x$found" = "x" ] ; then - ret=0 # means yes, need to run libtoolize - break - fi - done - return ${ret} -} - - - -############################################ -# prepare build via autoreconf or manually # -############################################ -reconfigure_manually=no -if [ "x$HAVE_AUTORECONF" = "xyes" ] ; then - $ECHO - $ECHO $ECHO_N "Automatically preparing build ... $ECHO_C" - - $VERBOSE_ECHO "$AUTORECONF $SEARCH_DIRS $AUTORECONF_OPTIONS" - autoreconf_output="`$AUTORECONF $SEARCH_DIRS $AUTORECONF_OPTIONS 2>&1`" - ret=$? - $VERBOSE_ECHO "$autoreconf_output" - - if [ ! $ret = 0 ] ; then - if [ "x$HAVE_ALT_LIBTOOLIZE" = "xyes" ] ; then - if [ ! "x`echo \"$autoreconf_output\" | grep libtoolize | grep \"No such file or directory\"`" = "x" ] ; then - $ECHO - $ECHO "Warning: autoreconf failed but due to what is usually a common libtool" - $ECHO "misconfiguration issue. This problem is encountered on systems that" - $ECHO "have installed libtoolize under a different name without providing a" - $ECHO "symbolic link or without setting the LIBTOOLIZE environment variable." - $ECHO - $ECHO "Restarting the preparation steps with LIBTOOLIZE set to $LIBTOOLIZE" - - export LIBTOOLIZE - RUN_RECURSIVE=no - export RUN_RECURSIVE - untrap_abnormal - - $VERBOSE_ECHO sh $AUTOGEN_SH "$1" "$2" "$3" "$4" "$5" "$6" "$7" "$8" "$9" - sh "$AUTOGEN_SH" "$1" "$2" "$3" "$4" "$5" "$6" "$7" "$8" "$9" - exit $? - fi - fi - - $ECHO "Warning: $AUTORECONF failed" - - if test -f ltmain.sh ; then - $ECHO "libtoolize being run by autoreconf is not creating ltmain.sh in the auxillary directory like it should" - fi - - $ECHO "Attempting to run the preparation steps individually" - reconfigure_manually=yes - else - if [ "x$DOWNLOAD" = "xyes" ] ; then - if libtoolize_needed ; then - download_gnulib_config_guess - fi - fi - fi -else - reconfigure_manually=yes -fi - - -############################ -# LIBTOOL_FAILURE FUNCTION # -############################ -libtool_failure ( ) { - - # libtool is rather error-prone in comparison to the other - # autotools and this routine attempts to compensate for some - # common failures. the output after a libtoolize failure is - # parsed for an error related to AC_PROG_LIBTOOL and if found, we - # attempt to inject a project-provided libtool.m4 file. - - _autoconf_output="$1" - - if [ "x$RUN_RECURSIVE" = "xno" ] ; then - # we already tried the libtool.m4, don't try again - return 1 - fi - - if test -f "$LIBTOOL_M4" ; then - found_libtool="`$ECHO $_autoconf_output | grep AC_PROG_LIBTOOL`" - if test ! "x$found_libtool" = "x" ; then - if test -f acinclude.m4 ; then - rm -f acinclude.m4.$$.backup - $VERBOSE_ECHO "cat acinclude.m4 > acinclude.m4.$$.backup" - cat acinclude.m4 > acinclude.m4.$$.backup - fi - $VERBOSE_ECHO "cat \"$LIBTOOL_M4\" >> acinclude.m4" - chmod u+w acinclude.m4 - cat "$LIBTOOL_M4" >> acinclude.m4 - - # don't keep doing this - RUN_RECURSIVE=no - export RUN_RECURSIVE - untrap_abnormal - - $ECHO - $ECHO "Restarting the preparation steps with libtool macros in acinclude.m4" - $VERBOSE_ECHO sh $AUTOGEN_SH "$1" "$2" "$3" "$4" "$5" "$6" "$7" "$8" "$9" - sh "$AUTOGEN_SH" "$1" "$2" "$3" "$4" "$5" "$6" "$7" "$8" "$9" - exit $? - fi - fi -} - - -########################### -# MANUAL_AUTOGEN FUNCTION # -########################### -manual_autogen ( ) { - - ################################################## - # Manual preparation steps taken are as follows: # - # aclocal [-I m4] # - # libtoolize --automake -c -f # - # aclocal [-I m4] # - # autoconf -f # - # autoheader # - # automake -a -c -f # - ################################################## - - ########### - # aclocal # - ########### - $VERBOSE_ECHO "$ACLOCAL $SEARCH_DIRS $ACLOCAL_OPTIONS" - aclocal_output="`$ACLOCAL $SEARCH_DIRS $ACLOCAL_OPTIONS 2>&1`" - ret=$? - $VERBOSE_ECHO "$aclocal_output" - if [ ! $ret = 0 ] ; then $ECHO "ERROR: $ACLOCAL failed" && exit 2 ; fi - - ############## - # libtoolize # - ############## - if libtoolize_needed ; then - if [ "x$HAVE_LIBTOOLIZE" = "xyes" ] ; then - $VERBOSE_ECHO "$LIBTOOLIZE $LIBTOOLIZE_OPTIONS" - libtoolize_output="`$LIBTOOLIZE $LIBTOOLIZE_OPTIONS 2>&1`" - ret=$? - $VERBOSE_ECHO "$libtoolize_output" - - if [ ! $ret = 0 ] ; then $ECHO "ERROR: $LIBTOOLIZE failed" && exit 2 ; fi - else - if [ "x$HAVE_ALT_LIBTOOLIZE" = "xyes" ] ; then - $VERBOSE_ECHO "$LIBTOOLIZE $ALT_LIBTOOLIZE_OPTIONS" - libtoolize_output="`$LIBTOOLIZE $ALT_LIBTOOLIZE_OPTIONS 2>&1`" - ret=$? - $VERBOSE_ECHO "$libtoolize_output" - - if [ ! $ret = 0 ] ; then $ECHO "ERROR: $LIBTOOLIZE failed" && exit 2 ; fi - fi - fi - - ########### - # aclocal # - ########### - # re-run again as instructed by libtoolize - $VERBOSE_ECHO "$ACLOCAL $SEARCH_DIRS $ACLOCAL_OPTIONS" - aclocal_output="`$ACLOCAL $SEARCH_DIRS $ACLOCAL_OPTIONS 2>&1`" - ret=$? - $VERBOSE_ECHO "$aclocal_output" - - # libtoolize might put ltmain.sh in the wrong place - if test -f ltmain.sh ; then - if test ! -f "${_aux_dir}/ltmain.sh" ; then - $ECHO - $ECHO "Warning: $LIBTOOLIZE is creating ltmain.sh in the wrong directory" - $ECHO - $ECHO "Fortunately, the problem can be worked around by simply copying the" - $ECHO "file to the appropriate location (${_aux_dir}/). This has been done for you." - $ECHO - $VERBOSE_ECHO "cp -p ltmain.sh \"${_aux_dir}/ltmain.sh\"" - cp -p ltmain.sh "${_aux_dir}/ltmain.sh" - $ECHO $ECHO_N "Continuing build preparation ... $ECHO_C" - fi - fi # ltmain.sh - - if [ "x$DOWNLOAD" = "xyes" ] ; then - download_gnulib_config_guess - fi - fi # libtoolize_needed - - ############ - # autoconf # - ############ - $VERBOSE_ECHO - $VERBOSE_ECHO "$AUTOCONF $AUTOCONF_OPTIONS" - autoconf_output="`$AUTOCONF $AUTOCONF_OPTIONS 2>&1`" - ret=$? - $VERBOSE_ECHO "$autoconf_output" - - if [ ! $ret = 0 ] ; then - # retry without the -f and check for usage of macros that are too new - ac2_59_macros="AC_C_RESTRICT AC_INCLUDES_DEFAULT AC_LANG_ASSERT AC_LANG_WERROR AS_SET_CATFILE" - ac2_55_macros="AC_COMPILER_IFELSE AC_FUNC_MBRTOWC AC_HEADER_STDBOOL AC_LANG_CONFTEST AC_LANG_SOURCE AC_LANG_PROGRAM AC_LANG_CALL AC_LANG_FUNC_TRY_LINK AC_MSG_FAILURE AC_PREPROC_IFELSE" - ac2_54_macros="AC_C_BACKSLASH_A AC_CONFIG_LIBOBJ_DIR AC_GNU_SOURCE AC_PROG_EGREP AC_PROG_FGREP AC_REPLACE_FNMATCH AC_FUNC_FNMATCH_GNU AC_FUNC_REALLOC AC_TYPE_MBSTATE_T" - - macros_to_search="" - ac_major="`echo ${AUTOCONF_VERSION}. | cut -d. -f1 | sed 's/[^0-9]//g'`" - ac_minor="`echo ${AUTOCONF_VERSION}. | cut -d. -f2 | sed 's/[^0-9]//g'`" - - if [ $ac_major -lt 2 ] ; then - macros_to_search="$ac2_59_macros $ac2_55_macros $ac2_54_macros" - else - if [ $ac_minor -lt 54 ] ; then - macros_to_search="$ac2_59_macros $ac2_55_macros $ac2_54_macros" - elif [ $ac_minor -lt 55 ] ; then - macros_to_search="$ac2_59_macros $ac2_55_macros" - elif [ $ac_minor -lt 59 ] ; then - macros_to_search="$ac2_59_macros" - fi - fi - - configure_ac_macros=__none__ - for feature in $macros_to_search ; do - $VERBOSE_ECHO "Searching for $feature in $CONFIGURE" - found="`grep \"^$feature.*\" $CONFIGURE`" - if [ ! "x$found" = "x" ] ; then - if [ "x$configure_ac_macros" = "x__none__" ] ; then - configure_ac_macros="$feature" - else - configure_ac_macros="$feature $configure_ac_macros" - fi - fi - done - if [ ! "x$configure_ac_macros" = "x__none__" ] ; then - $ECHO - $ECHO "Warning: Unsupported macros were found in $CONFIGURE" - $ECHO - $ECHO "The `basename \"$CONFIGURE\"` file was scanned in order to determine if any" - $ECHO "unsupported macros are used that exceed the minimum version" - $ECHO "settings specified within this file. As such, the following macros" - $ECHO "should be removed from configure.ac or the version numbers in this" - $ECHO "file should be increased:" - $ECHO - $ECHO "$configure_ac_macros" - $ECHO - $ECHO $ECHO_N "Ignorantly continuing build preparation ... $ECHO_C" - fi - - ################### - # autoconf, retry # - ################### - $VERBOSE_ECHO - $VERBOSE_ECHO "$AUTOCONF" - autoconf_output="`$AUTOCONF 2>&1`" - ret=$? - $VERBOSE_ECHO "$autoconf_output" - - if [ ! $ret = 0 ] ; then - # test if libtool is busted - libtool_failure "$autoconf_output" - - # let the user know what went wrong - cat < License: GPL-3+ @@ -66,7 +61,7 @@ . This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for more details. . You should have received a copy of the GNU Affero General Public License -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I87676cdf6818b4250f478962baf96ad5f28564d5 Gerrit-Change-Number: 14984 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:48:06 2019 From: gerrit-no-reply at lists.osmocom.org (vvvelichkov) Date: Mon, 29 Jul 2019 18:48:06 +0000 Subject: Change in ...gr-gsm[master]: Add control channels demappers tests In-Reply-To: References: Message-ID: Hello Piotr Krysik, Vadim Yanitskiy, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/gr-gsm/+/14945 to look at the new patch set (#2). Change subject: Add control channels demappers tests ...................................................................... Add control channels demappers tests 3GPP TS 45.002 version 15.1.0 Release 15 Table 3 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5) Table 4 : Mapping of logical channels onto physical channels (see subclauses 6.3, 6.4, 6.5) Figure 8a: TDMA frame mapping for FCCH + SCH + BCCH + CCCH Figure 8b: TDMA frame mapping for FCCH + SCH + BCCH + CCCH + SDCCH/4(0...3) + SACCH/4(0...3) Five of the six tests currently fail and are marked with @unittest.expectedFailure. Fixes in subsequent commits. Change-Id: I33b0948832a0c2506bffd389cc134c3236c74d27 --- M include/grgsm/qa_utils/burst_sink.h M include/grgsm/qa_utils/burst_source.h M lib/qa_utils/burst_sink_impl.cc M lib/qa_utils/burst_sink_impl.h M lib/qa_utils/burst_source_impl.cc M lib/qa_utils/burst_source_impl.h M python/CMakeLists.txt A python/qa_gsm_bcch_ccch_demapper.py A python/qa_gsm_bcch_ccch_sdcch4_demapper.py A python/qa_gsm_demapper_data.py A python/qa_gsm_sdcch8_demapper.py 11 files changed, 653 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/45/14945/2 -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: I33b0948832a0c2506bffd389cc134c3236c74d27 Gerrit-Change-Number: 14945 Gerrit-PatchSet: 2 Gerrit-Owner: vvvelichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:52:23 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 18:52:23 +0000 Subject: Change in ...osmo-trx[master]: Drop old README information, provide new updated README In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14985 to look at the new patch set (#2). Change subject: Drop old README information, provide new updated README ...................................................................... Drop old README information, provide new updated README Previous content in README file is actually a description of the TRXD and TRXC protocols, and it has already been moved to the User Manual some time ago. INSTALLATION contained README related information, but it was really out of date. So this commit basically drops those two files and provides a new README.md with content taken from Osmocom's OsmoTRX project wiki page. Change-Id: I3df00799ce80aa4af43225e69a408ba2cbc444db --- D INSTALLATION M Makefile.am D README A README.md 4 files changed, 66 insertions(+), 136 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/85/14985/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3df00799ce80aa4af43225e69a408ba2cbc444db Gerrit-Change-Number: 14985 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 18:59:41 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 18:59:41 +0000 Subject: Change in ...osmo-trx[master]: Drop old README information, provide new updated README In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14985 to look at the new patch set (#3). Change subject: Drop old README information, provide new updated README ...................................................................... Drop old README information, provide new updated README Previous content in README file is actually a description of the TRXD and TRXC protocols, and it has already been moved to the User Manual some time ago. INSTALLATION contained README related information, but it was really out of date. So this commit basically drops those two files and provides a new README.md with content taken from Osmocom's OsmoTRX project wiki page. Change-Id: I3df00799ce80aa4af43225e69a408ba2cbc444db --- D INSTALLATION M Makefile.am D README A README.md 4 files changed, 67 insertions(+), 137 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/85/14985/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3df00799ce80aa4af43225e69a408ba2cbc444db Gerrit-Change-Number: 14985 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 19:00:54 2019 From: gerrit-no-reply at lists.osmocom.org (vvvelichkov) Date: Mon, 29 Jul 2019 19:00:54 +0000 Subject: Change in ...gr-gsm[master]: Add control channels demappers tests In-Reply-To: References: Message-ID: vvvelichkov has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14945 ) Change subject: Add control channels demappers tests ...................................................................... Patch Set 2: (6 comments) https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py File python/qa_gsm_bcch_ccch_demapper.py: https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py at 6 PS1, Line 6: > ws Done https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py at 142 PS1, Line 142: b[ 0], b[ 1], b[ 2], b[ 3], > Any benefits of having such sequential notation? [?] I like the test to be more explicit and probably I've copy-pasted it from one of the other tests ? I've change it to self.assertEqual(b, list(dst.get_burst_data())) which is one line and in case of a failure the assertEqual prints all bursts that are different and not only the first different burst as in the for loop variant. https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py at 172 PS1, Line 172: assertEqual > Same here, and even simpler. Done https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_bcch_ccch_demapper.py at 203 PS1, Line 203: assertEqual > Same here. Done https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_demapper_data.py File python/qa_gsm_demapper_data.py: https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_demapper_data.py at 24 PS1, Line 24: bursts > This list can also be generated using a for loop. Done https://gerrit.osmocom.org/#/c/14945/1/python/qa_gsm_demapper_data.py at 150 PS1, Line 150: timeslots > Same here, just [0] * X, where X == len(timeslots). Done -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: I33b0948832a0c2506bffd389cc134c3236c74d27 Gerrit-Change-Number: 14945 Gerrit-PatchSet: 2 Gerrit-Owner: vvvelichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: vvvelichkov Gerrit-Comment-Date: Mon, 29 Jul 2019 19:00:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 19:07:42 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 19:07:42 +0000 Subject: Change in ...osmo-trx[master]: radioInterface: Clarify how underruns are handled driving a radioDevice Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14987 Change subject: radioInterface: Clarify how underruns are handled driving a radioDevice ...................................................................... radioInterface: Clarify how underruns are handled driving a radioDevice The underrun parameter in radioDevice's readSamples() is not a "Rx Underrun" event, but rather it's used to retrieve a "Tx Underrun" which on some SDRs (like USRP1) seems to be (so far) available only at readSamples() times. Thus, underrun parameter for both readSamples() and writeSamples() is actually flagging the same event, and should be ORed in pushBuffer() as it's already done in pullBuffer(). Otherwise if implementation is setting the underrun pointer to false, it could erase the flag being marked by the counterpart function before isUnderrun() is called (which is the one responsible to clear the flag). Change-Id: Id549489fc1485e0d762818c8e682aaddd5041f1c --- M Transceiver52M/radioInterface.cpp 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/87/14987/1 diff --git a/Transceiver52M/radioInterface.cpp b/Transceiver52M/radioInterface.cpp index e32848e..0d33f22 100644 --- a/Transceiver52M/radioInterface.cpp +++ b/Transceiver52M/radioInterface.cpp @@ -348,6 +348,7 @@ /* Send timestamped chunk to the device with arbitrary size */ bool RadioInterface::pushBuffer() { + bool local_underrun; size_t numSent, segmentLen = sendBuffer[0]->getSegmentLen(); if (sendBuffer[0]->getAvailSegments() < 1) @@ -363,8 +364,9 @@ /* Send the all samples in the send buffer */ numSent = mRadio->writeSamples(convertSendBuffer, segmentLen, - &underrun, + &local_underrun, writeTimestamp); + underrun |= local_underrun; writeTimestamp += numSent; return true; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14987 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id549489fc1485e0d762818c8e682aaddd5041f1c Gerrit-Change-Number: 14987 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 19:07:43 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 19:07:43 +0000 Subject: Change in ...osmo-trx[master]: usrp1: don't check for non-null underrun pointer Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14988 Change subject: usrp1: don't check for non-null underrun pointer ...................................................................... usrp1: don't check for non-null underrun pointer The pointer can't never be null, so avoid checking it. Change-Id: I12e14641713a6494bc89570f02cecfc6f8fd4b5e --- M Transceiver52M/device/usrp1/USRPDevice.cpp 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/88/14988/1 diff --git a/Transceiver52M/device/usrp1/USRPDevice.cpp b/Transceiver52M/device/usrp1/USRPDevice.cpp index af0b3de..63debee 100644 --- a/Transceiver52M/device/usrp1/USRPDevice.cpp +++ b/Transceiver52M/device/usrp1/USRPDevice.cpp @@ -377,7 +377,7 @@ return len; } - if (underrun) *underrun = false; + *underrun = false; uint32_t readBuf[2000]; @@ -427,7 +427,7 @@ continue; } if ((word0 >> 28) & 0x04) { - if (underrun) *underrun = true; + *underrun = true; LOGC(DDEV, DEBUG) << "UNDERRUN in TRX->USRP interface"; } if (RSSI) *RSSI = (word0 >> 21) & 0x3f; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14988 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I12e14641713a6494bc89570f02cecfc6f8fd4b5e Gerrit-Change-Number: 14988 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 19:07:43 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 19:07:43 +0000 Subject: Change in ...osmo-trx[master]: lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14989 Change subject: lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr ...................................................................... lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr After discussion in [1] and further look at the code, it became obvios rx_underrun events are not happening in general for any SDR (don't exist), so let's drop that counter. Instead, add Tx Dropped Packet counters, which were not accounted prior to this commit. [1] https://github.com/osmocom/osmo-trx/commit/bde55afd29fc9aae10eb11f6515821afa39b772d Change-Id: Iff1535c219a4695a511d383d7c4b06ef6eff959d --- M CommonLibs/osmo_signal.h M CommonLibs/trx_rate_ctr.cpp M CommonLibs/trx_rate_ctr.h M CommonLibs/trx_vty.c M Transceiver52M/device/lms/LMSDevice.cpp M Transceiver52M/device/lms/LMSDevice.h 6 files changed, 80 insertions(+), 40 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/89/14989/1 diff --git a/CommonLibs/osmo_signal.h b/CommonLibs/osmo_signal.h index ee7e2a4..ceb7d6f 100644 --- a/CommonLibs/osmo_signal.h +++ b/CommonLibs/osmo_signal.h @@ -48,9 +48,10 @@ /* signal cb for signal */ struct device_counters { size_t chan; - unsigned int rx_underruns; unsigned int rx_overruns; unsigned int tx_underruns; unsigned int rx_dropped_events; unsigned int rx_dropped_samples; + unsigned int tx_dropped_events; + unsigned int tx_dropped_samples; }; diff --git a/CommonLibs/trx_rate_ctr.cpp b/CommonLibs/trx_rate_ctr.cpp index 43e4189..a9ef88c 100644 --- a/CommonLibs/trx_rate_ctr.cpp +++ b/CommonLibs/trx_rate_ctr.cpp @@ -93,20 +93,22 @@ }; const struct value_string trx_chan_ctr_names[] = { - { TRX_CTR_RX_UNDERRUNS, "rx_underruns" }, { TRX_CTR_RX_OVERRUNS, "rx_overruns" }, { TRX_CTR_TX_UNDERRUNS, "tx_underruns" }, { TRX_CTR_RX_DROP_EV, "rx_drop_events" }, { TRX_CTR_RX_DROP_SMPL, "rx_drop_samples" }, + { TRX_CTR_TX_DROP_EV, "tx_drop_events" }, + { TRX_CTR_TX_DROP_SMPL, "tx_drop_samples" }, { 0, NULL } }; static const struct rate_ctr_desc trx_chan_ctr_desc[] = { - [TRX_CTR_RX_UNDERRUNS] = { "device:rx_underruns", "Number of Rx underruns" }, - [TRX_CTR_RX_OVERRUNS] = { "device:rx_overruns", "Number of Rx overruns" }, - [TRX_CTR_TX_UNDERRUNS] = { "device:tx_underruns", "Number of Tx underruns" }, + [TRX_CTR_RX_OVERRUNS] = { "device:rx_overruns", "Number of Rx overruns in FIFO queue" }, + [TRX_CTR_TX_UNDERRUNS] = { "device:tx_underruns", "Number of Tx underruns in FIFO queue" }, [TRX_CTR_RX_DROP_EV] = { "device:rx_drop_events", "Number of times Rx samples were dropped by HW" }, [TRX_CTR_RX_DROP_SMPL] = { "device:rx_drop_samples", "Number of Rx samples dropped by HW" }, + [TRX_CTR_TX_DROP_EV] = { "device:tx_drop_events", "Number of times Tx samples were dropped by HW" }, + [TRX_CTR_TX_DROP_SMPL] = { "device:tx_drop_samples", "Number of Tx samples dropped by HW" } }; static const struct rate_ctr_group_desc trx_chan_ctr_group_desc = { @@ -126,8 +128,6 @@ if (ctrs_pending[chan].chan == PENDING_CHAN_NONE) continue; LOGCHAN(chan, DMAIN, INFO) << "rate_ctr update"; - ctr = &rate_ctrs[chan]->ctr[TRX_CTR_RX_UNDERRUNS]; - rate_ctr_add(ctr, ctrs_pending[chan].rx_underruns - ctr->current); ctr = &rate_ctrs[chan]->ctr[TRX_CTR_RX_OVERRUNS]; rate_ctr_add(ctr, ctrs_pending[chan].rx_overruns - ctr->current); ctr = &rate_ctrs[chan]->ctr[TRX_CTR_TX_UNDERRUNS]; @@ -136,6 +136,10 @@ rate_ctr_add(ctr, ctrs_pending[chan].rx_dropped_events - ctr->current); ctr = &rate_ctrs[chan]->ctr[TRX_CTR_RX_DROP_SMPL]; rate_ctr_add(ctr, ctrs_pending[chan].rx_dropped_samples - ctr->current); + ctr = &rate_ctrs[chan]->ctr[TRX_CTR_TX_DROP_EV]; + rate_ctr_add(ctr, ctrs_pending[chan].tx_dropped_events - ctr->current); + ctr = &rate_ctrs[chan]->ctr[TRX_CTR_TX_DROP_SMPL]; + rate_ctr_add(ctr, ctrs_pending[chan].tx_dropped_samples - ctr->current); /* Mark as done */ ctrs_pending[chan].chan = PENDING_CHAN_NONE; diff --git a/CommonLibs/trx_rate_ctr.h b/CommonLibs/trx_rate_ctr.h index 6e4fa4d..155f413 100644 --- a/CommonLibs/trx_rate_ctr.h +++ b/CommonLibs/trx_rate_ctr.h @@ -4,11 +4,12 @@ #include enum TrxCtr { - TRX_CTR_RX_UNDERRUNS, TRX_CTR_RX_OVERRUNS, TRX_CTR_TX_UNDERRUNS, TRX_CTR_RX_DROP_EV, TRX_CTR_RX_DROP_SMPL, + TRX_CTR_TX_DROP_EV, + TRX_CTR_TX_DROP_SMPL, }; struct ctr_threshold { diff --git a/CommonLibs/trx_vty.c b/CommonLibs/trx_vty.c index e184f49..bac9653 100644 --- a/CommonLibs/trx_vty.c +++ b/CommonLibs/trx_vty.c @@ -384,14 +384,15 @@ return -1; } -#define THRESHOLD_ARGS "(rx_underruns|rx_overruns|tx_underruns|rx_drop_events|rx_drop_samples)" +#define THRESHOLD_ARGS "(rx_overruns|tx_underruns|rx_drop_events|rx_drop_samples|tx_drop_events|tx_drop_samples)" #define THRESHOLD_STR_VAL(s) "Set threshold value for rate_ctr device:" OSMO_STRINGIFY_VAL(s) "\n" #define THRESHOLD_STRS \ - THRESHOLD_STR_VAL(rx_underruns) \ THRESHOLD_STR_VAL(rx_overruns) \ THRESHOLD_STR_VAL(tx_underruns) \ THRESHOLD_STR_VAL(rx_drop_events) \ - THRESHOLD_STR_VAL(rx_drop_samples) + THRESHOLD_STR_VAL(rx_drop_samples) \ + THRESHOLD_STR_VAL(tx_drop_events) \ + THRESHOLD_STR_VAL(tx_drop_samples) #define INTV_ARGS "(per-second|per-minute|per-hour|per-day)" #define INTV_STR_VAL(s) "Threshold value sampled " OSMO_STRINGIFY_VAL(s) "\n" #define INTV_STRS \ diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp index 0eaf0a3..e027050 100644 --- a/Transceiver52M/device/lms/LMSDevice.cpp +++ b/Transceiver52M/device/lms/LMSDevice.cpp @@ -574,38 +574,37 @@ /* UNUSED on limesdr (only used on usrp1/2) */ return GSM::Time(0,0); } - -void LMSDevice::update_stream_stats(size_t chan, bool * underrun, bool * overrun) +/*! + * Issue tracking description of several events: https://github.com/myriadrf/LimeSuite/issues/265 + */ +void LMSDevice::update_stream_stats_rx(size_t chan, bool *overrun) { lms_stream_status_t status; bool changed = false; if (LMS_GetStreamStatus(&m_lms_stream_rx[chan], &status) != 0) { - LOGCHAN(chan, DDEV, ERROR) << "LMS_GetStreamStatus failed"; + LOGCHAN(chan, DDEV, ERROR) << "Rx LMS_GetStreamStatus failed"; return; } - if (status.underrun) { - changed = true; - *underrun = true; - LOGCHAN(chan, DDEV, ERROR) << "recv Underrun! (" - << m_ctr[chan].rx_underruns << " -> " - << status.underrun << ")"; - } - m_ctr[chan].rx_underruns += status.underrun; - + /* FIFO overrun is counted when Rx FIFO is full but new data comes from + the board and oldest samples in FIFO are overwritte. Value count + since the last call to LMS_GetStreamStatus(stream). */ if (status.overrun) { changed = true; *overrun = true; - LOGCHAN(chan, DDEV, ERROR) << "recv Overrun! (" + LOGCHAN(chan, DDEV, ERROR) << "Rx Overrun! (" << m_ctr[chan].rx_overruns << " -> " << status.overrun << ")"; } m_ctr[chan].rx_overruns += status.overrun; + /* Dropped packets in Rx are counted when gaps in Rx timestamps are + detected (likely because buffer oveflow in hardware). Value count + since the last call to LMS_GetStreamStatus(stream). */ if (status.droppedPackets) { changed = true; - LOGCHAN(chan, DDEV, ERROR) << "recv Dropped packets by HW! (" + LOGCHAN(chan, DDEV, ERROR) << "Rx Dropped packets by HW! (" << m_ctr[chan].rx_dropped_samples << " -> " << m_ctr[chan].rx_dropped_samples + status.droppedPackets @@ -653,7 +652,7 @@ while ((avail_smpls = rx_buffers[i]->avail_smpls(timestamp)) < len) { thread_enable_cancel(false); num_smpls = LMS_RecvStream(&m_lms_stream_rx[i], bufs[i], len - avail_smpls, &rx_metadata, 100); - update_stream_stats(i, underrun, overrun); + update_stream_stats_rx(i, overrun); thread_enable_cancel(true); if (num_smpls <= 0) { LOGCHAN(i, DDEV, ERROR) << "Device receive timed out (" << rc << " vs exp " << len << ")."; @@ -697,13 +696,53 @@ return len; } +void LMSDevice::update_stream_stats_tx(size_t chan, bool *underrun) +{ + lms_stream_status_t status; + bool changed = false; + + if (LMS_GetStreamStatus(&m_lms_stream_tx[chan], &status) != 0) { + LOGCHAN(chan, DDEV, ERROR) << "Tx LMS_GetStreamStatus failed"; + return; + } + + /* FIFO underrun is counted when Tx is running but FIFO is empty for + >100 ms (500ms in older versions). Value count since the last call to + LMS_GetStreamStatus(stream). */ + if (status.underrun) { + changed = true; + *underrun = true; + LOGCHAN(chan, DDEV, ERROR) << "Tx Underrun! (" + << m_ctr[chan].tx_underruns << " -> " + << status.underrun << ")"; + } + m_ctr[chan].tx_underruns += status.underrun; + + /* Dropped packets in Tx are counted only when timestamps are enabled + and SDR drops packet because of late timestamp. Value count since the + last call to LMS_GetStreamStatus(stream). */ + if (status.droppedPackets) { + changed = true; + LOGCHAN(chan, DDEV, ERROR) << "Tx Dropped packets by HW! (" + << m_ctr[chan].tx_dropped_samples << " -> " + << m_ctr[chan].tx_dropped_samples + + status.droppedPackets + << ")"; + m_ctr[chan].tx_dropped_events++; + } + m_ctr[chan].tx_dropped_samples += status.droppedPackets; + + if (changed) + osmo_signal_dispatch(SS_DEVICE, S_DEVICE_COUNTER_CHANGE, &m_ctr[chan]); + +} + int LMSDevice::writeSamples(std::vector < short *>&bufs, int len, bool * underrun, unsigned long long timestamp, bool isControl) { int rc = 0; unsigned int i; - lms_stream_status_t status; lms_stream_meta_t tx_metadata = {}; tx_metadata.flushPartialPacket = false; tx_metadata.waitForTimestamp = true; @@ -725,19 +764,12 @@ LOGCHAN(i, DDEV, DEBUG) << "send buffer of len " << len << " timestamp " << std::hex << tx_metadata.timestamp; thread_enable_cancel(false); rc = LMS_SendStream(&m_lms_stream_tx[i], bufs[i], len, &tx_metadata, 100); - if (rc != len) { - LOGCHAN(i, DDEV, ERROR) << "LMS: Device send timed out"; - } - - if (LMS_GetStreamStatus(&m_lms_stream_tx[i], &status) == 0) { - if (status.underrun > m_ctr[i].tx_underruns) { - *underrun = true; - m_ctr[i].tx_underruns = status.underrun; - osmo_signal_dispatch(SS_DEVICE, S_DEVICE_COUNTER_CHANGE, &m_ctr[i]); - } - - } + update_stream_stats_rx(i, underrun); thread_enable_cancel(true); + if (rc != len) { + LOGCHAN(i, DDEV, ERROR) << "LMS: Device Tx timed out (" << rc << " vs exp " << len << ")."; + return -1; + } } return rc; diff --git a/Transceiver52M/device/lms/LMSDevice.h b/Transceiver52M/device/lms/LMSDevice.h index 906fbee..bc79f97 100644 --- a/Transceiver52M/device/lms/LMSDevice.h +++ b/Transceiver52M/device/lms/LMSDevice.h @@ -65,7 +65,8 @@ bool do_filters(size_t chan); int get_ant_idx(const std::string & name, bool dir_tx, size_t chan); bool flush_recv(size_t num_pkts); - void update_stream_stats(size_t chan, bool * underrun, bool * overrun); + void update_stream_stats_rx(size_t chan, bool *overrun); + void update_stream_stats_tx(size_t chan, bool *underrun); public: -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iff1535c219a4695a511d383d7c4b06ef6eff959d Gerrit-Change-Number: 14989 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 19:08:54 2019 From: gerrit-no-reply at lists.osmocom.org (vvvelichkov) Date: Mon, 29 Jul 2019 19:08:54 +0000 Subject: Change in ...gr-gsm[master]: Fix uplink sub_slot and sub_types assignment in the sdcch4 and bcch_c... In-Reply-To: References: Message-ID: vvvelichkov has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14948 ) Change subject: Fix uplink sub_slot and sub_types assignment in the sdcch4 and bcch_ccch demappers blocks ...................................................................... Patch Set 2: Hi Vadim, > Patch Set 1: > > In general, I am find with the proposed patch set. But instead of having magic calculations in the original code, I would rather follow the way of OsmoBTS, which I followed in trxcon: > > https://git.osmocom.org/osmocom-bb/tree/src/host/trxcon/sched_mframe.c > > Ideally, we need to share this code somewhere in libosmogsm, so then it can be used by gr-gsm, and even by OsmoTRX. Agree. My intention with this patch set was to fix demappers with minimal code changes and to add some tests. -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14948 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: Ia6b3070c1085bcdda6d98fd94a89c6e0982e2aec Gerrit-Change-Number: 14948 Gerrit-PatchSet: 2 Gerrit-Owner: vvvelichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: vvvelichkov Gerrit-Comment-Date: Mon, 29 Jul 2019 19:08:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Mon Jul 29 19:37:07 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Mon, 29 Jul 2019 19:37:07 +0000 Subject: Change in ...osmo-trx[master]: jenkins.sh: Workaround libusrp build race conditon Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14990 Change subject: jenkins.sh: Workaround libusrp build race conditon ...................................................................... jenkins.sh: Workaround libusrp build race conditon When submitting patches to osmo-trx in gerrit, sometimes the jenkins job fails due to libusrp failing to build. I never have this issue in on my workstation. Let's disable parallel make and see if we can avoid it for now. Related: OS#3970 Change-Id: I24bc54f5872e8edb9fab5b88055a00cebe1a6911 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/90/14990/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 1dd8478..f3f5ed9 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -72,7 +72,7 @@ mkdir "$deps" || true osmo-build-dep.sh libosmocore "" "--enable-sanitize --disable-doxygen --disable-pcsc" -osmo-build-dep.sh libusrp +PARALLEL_MAKE="" osmo-build-dep.sh libusrp export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I24bc54f5872e8edb9fab5b88055a00cebe1a6911 Gerrit-Change-Number: 14990 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 00:38:52 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 00:38:52 +0000 Subject: Change in ...gr-gsm[master]: Add control channels demappers tests In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/14945 ) Change subject: Add control channels demappers tests ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/14945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: I33b0948832a0c2506bffd389cc134c3236c74d27 Gerrit-Change-Number: 14945 Gerrit-PatchSet: 2 Gerrit-Owner: vvvelichkov Gerrit-Reviewer: Piotr Krysik Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: vvvelichkov Gerrit-Comment-Date: Tue, 30 Jul 2019 00:38:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 01:09:33 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 01:09:33 +0000 Subject: Change in ...osmo-trx[master]: jenkins.sh: Workaround libusrp build race conditon In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14990 ) Change subject: jenkins.sh: Workaround libusrp build race conditon ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I24bc54f5872e8edb9fab5b88055a00cebe1a6911 Gerrit-Change-Number: 14990 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Tue, 30 Jul 2019 01:09:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 01:16:46 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 01:16:46 +0000 Subject: Change in ...libosmocore[master]: gsm0808_test: Fix wrong use of memcp In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14979 ) Change subject: gsm0808_test: Fix wrong use of memcp ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I17fe7a0a5dc650f050bba1f47d071be749550729 Gerrit-Change-Number: 14979 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 30 Jul 2019 01:16:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 01:23:24 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 01:23:24 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Small fixes In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 ) Change subject: configuration.adoc: Small fixes ...................................................................... Patch Set 1: Code-Review+1 (3 comments) https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc File doc/manuals/chapters/configuration.adoc: https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc at 255 PS1, Line 255: in : order to save radio bandwith I would remove this part, because it duplicates the first sentence. https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc at 293 PS1, Line 293: again Again? https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc at 337 PS1, Line 337: again Again? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558 Gerrit-Change-Number: 14981 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 01:23:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 01:37:26 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 01:37:26 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 ) Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT ...................................................................... Patch Set 2: Code-Review+1 (3 comments) https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc at 257 PS2, Line 257: express that in centiBels I think this part needs to be corrected, because "the ideal training sequence can be compared ... and then express ...". https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc at 319 PS2, Line 319: +-----------------+---------------------------------------+ > . 1 1 0 X seems to be missing. [?] Right, thanks! Let's also mark it as reserved. https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc at 325 PS2, Line 325: used to decode the burst This only applies to Access and Synchronization bursts, but not to Normal bursts. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 Gerrit-Change-Number: 14940 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-Comment-Date: Tue, 30 Jul 2019 01:37:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 03:03:52 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 03:03:52 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: fix vty_execute(): prevent further heap-buffer overrun In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 ) Change subject: vty/vty.c: fix vty_execute(): prevent further heap-buffer overrun ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14973/1/src/vty/vty.c File src/vty/vty.c: https://gerrit.osmocom.org/#/c/14973/1/src/vty/vty.c at 690 PS1, Line 690: vty->buf[vty->length] = '\0'; > Rather move this to vty_read(), immediately before read() call. [?] No way, because vty_read() read()s into a temporary buffer of fixed size on stack, and then parses each received symbol in a loop. Regular ASCII symbols are getting copied to another buffer on heap, which can also be reallocated if needed: if (buf[i] > 31 && buf[i] < 127) vty_self_insert(vty, buf[i]); Therefore neither adding '\0' before read() nor after would help. I still can move this code to vty_read() just before calling vty_execute(). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82f774ad18d0e555eb8f3590a519946d9c583c78 Gerrit-Change-Number: 14973 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 03:03:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 03:32:21 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 03:32:21 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: log received commands from telnet interface In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14974 ) Change subject: vty/vty.c: log received commands from telnet interface ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14974/1/src/vty/vty.c File src/vty/vty.c: https://gerrit.osmocom.org/#/c/14974/1/src/vty/vty.c at 441 PS1, Line 441: > What about moving the code in here and then you can probably drop the vty->length>0 condition? Well, cmd_make_strvec() may fail due to various reasons, so I think it's better to do logging before this call. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f6639f6ebc3e8f8df50ef48538df94285b759fd Gerrit-Change-Number: 14974 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 03:32:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 03:36:02 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 03:36:02 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14973 to look at the new patch set (#2). Change subject: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun ...................................................................... vty/vty.c: fix vty_read(): prevent further heap-buffer overrun After reading data from the socket, assigned to a given VTY, we need to '\0'-terminate the received string. Otherwise, further access to that string, stored in a heap buffer vty->buf, would lead to a heap overrun. == How to reproduce? $ python -c "print 'A' * 512" | telnet $HOST $PORT ==21264==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6190000211e0 at pc 0x000000435d2f bp 0x7ffc06c7add0 sp 0x7ffc06c7a578 READ of size 1025 at 0x6190000211e0 thread T0 #0 0x435d2e in __interceptor_strlen (/usr/local/bin/osmo-msc+0x435d2e) #1 0x7fb95bfa5624 in talloc_strdup (/usr/lib/x86_64-linux-gnu/libtalloc.so.2+0x6624) #2 0x7fb95c1be2bc in vty_hist_add /opt/osmocom/libosmocore/src/vty/vty.c:578 #3 0x7fb95c1be2bc in vty_execute /opt/osmocom/libosmocore/src/vty/vty.c:703 #4 0x7fb95c1be2bc in vty_read /opt/osmocom/libosmocore/src/vty/vty.c:1425 #5 0x7fb95c1bfd78 in client_data /opt/osmocom/libosmocore/src/vty/telnet_interface.c:157 #6 0x7fb95b90bd33 in osmo_fd_disp_fds /opt/osmocom/libosmocore/src/select.c:223 #7 0x7fb95b90bd33 in osmo_select_main /opt/osmocom/libosmocore/src/select.c:263 #8 0x5006cc in main /opt/osmocom/osmo-msc/src/osmo-msc/msc_main.c:723:3 #9 0x7fb959935f44 in __libc_start_main /build/eglibc-xkFqqE/eglibc-2.19/csu/libc-start.c:287 #10 0x4226fb in _start (/usr/local/bin/osmo-msc+0x4226fb) == Why exactly 512? Because the initial size of the heap buffer is 512 (see VTY_BUFSIZ). Later on it can be realloc()ated, so X > 512 should also work. Found using AddressSanitizer and Radamsa [1] fuzzer. [1] https://gitlab.com/akihe/radamsa Change-Id: I82f774ad18d0e555eb8f3590a519946d9c583c78 --- M src/vty/vty.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/73/14973/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82f774ad18d0e555eb8f3590a519946d9c583c78 Gerrit-Change-Number: 14973 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 03:36:02 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 03:36:02 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14975 to look at the new patch set (#2). Change subject: vty/vty.c: the command buffer can be accessed directly ...................................................................... vty/vty.c: the command buffer can be accessed directly Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39 --- M src/vty/vty.c 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/14975/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39 Gerrit-Change-Number: 14975 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 03:36:02 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 03:36:02 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: log received commands from telnet interface In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14974 to look at the new patch set (#2). Change subject: vty/vty.c: log received commands from telnet interface ...................................................................... vty/vty.c: log received commands from telnet interface This may be useful for investigating TTCN-3 test case failures. Change-Id: I5f6639f6ebc3e8f8df50ef48538df94285b759fd --- M src/vty/vty.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/74/14974/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f6639f6ebc3e8f8df50ef48538df94285b759fd Gerrit-Change-Number: 14974 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 03:37:23 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 03:37:23 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c Gerrit-Change-Number: 14972 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 03:37:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 03:38:20 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 03:38:20 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/14972/1/src/vty/telnet_interface.c File src/vty/telnet_interface.c: https://gerrit.osmocom.org/#/c/14972/1/src/vty/telnet_interface.c at 131 PS1, Line 131: rc = getsockname(fd->fd, (struct sockaddr *) &sockaddr, &len); > What about using osmo_sock_get_name_buf() here? Done https://gerrit.osmocom.org/#/c/14972/1/src/vty/telnet_interface.c at 187 PS1, Line 187: inet_ntoa(sockaddr.sin_addr), ntohs(sockaddr.sin_port)); > Let's use inet_ntop, which is thread-safe. I decided to use osmo_sock_get_name_buf() here too. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c Gerrit-Change-Number: 14972 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 03:38:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 06:57:21 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Jul 2019 06:57:21 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Add a section about encryption In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 to look at the new patch set (#2). Change subject: configuration.adoc: Add a section about encryption ...................................................................... configuration.adoc: Add a section about encryption Change-Id: I3a2b84d386f55447e9eed35e59fdc0272e5147d1 Related: OS#1720 --- M doc/manuals/chapters/configuration.adoc 1 file changed, 21 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/82/14982/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3a2b84d386f55447e9eed35e59fdc0272e5147d1 Gerrit-Change-Number: 14982 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 06:58:43 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Jul 2019 06:58:43 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Small fixes In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 ) Change subject: configuration.adoc: Small fixes ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc File doc/manuals/chapters/configuration.adoc: https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc at 20 PS1, Line 20: an > https://english.stackexchange. [?] I checked this when writing my diploma thesis and it's about the sound of the word before the article. So a source, an uninformed source, a uniformed (j-sound) source should all be correct as should an hour (h is silent). That's why I changed it to an EM-ES, but left a PEE-DEE-PEE context alone. It seems that historic and hotel are exceptions - at least according to Merriam-Webster. https://www.merriam-webster.com/words-at-play/is-it-a-or-an https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc at 255 PS1, Line 255: in : order to save radio bandwith > I would remove this part, because it duplicates the first sentence. Thanks https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc at 293 PS1, Line 293: again > Again? Well, it's disabled by default, so this command only has an effect if compression was previously enabled. Can you think of a different way to say it or do you think it's unnecessary? On further though I guess it's unnecessary. Removed it. https://gerrit.osmocom.org/#/c/14981/1/doc/manuals/chapters/configuration.adoc at 337 PS1, Line 337: again > Again? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558 Gerrit-Change-Number: 14981 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 06:58:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: Vadim Yanitskiy Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 07:00:54 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Jul 2019 07:00:54 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Small fixes In-Reply-To: References: Message-ID: Hello Vadim Yanitskiy, pespin, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 to look at the new patch set (#2). Change subject: configuration.adoc: Small fixes ...................................................................... configuration.adoc: Small fixes Fix some typos, correct data compression command, add example to turn off compression. Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558 Related: OS#1720 --- M doc/manuals/chapters/configuration.adoc 1 file changed, 25 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/81/14981/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558 Gerrit-Change-Number: 14981 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 07:03:29 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Jul 2019 07:03:29 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Add a section about encryption In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 to look at the new patch set (#4). Change subject: configuration.adoc: Add a section about encryption ...................................................................... configuration.adoc: Add a section about encryption Change-Id: I3a2b84d386f55447e9eed35e59fdc0272e5147d1 Related: OS#1720 --- M doc/manuals/chapters/configuration.adoc 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/82/14982/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3a2b84d386f55447e9eed35e59fdc0272e5147d1 Gerrit-Change-Number: 14982 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 07:03:50 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Jul 2019 07:03:50 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Add a section about encryption In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 ) Change subject: configuration.adoc: Add a section about encryption ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/14982/1/doc/manuals/chapters/configuration.adoc File doc/manuals/chapters/configuration.adoc: https://gerrit.osmocom.org/#/c/14982/1/doc/manuals/chapters/configuration.adoc at 352 PS1, Line 352: GEA > did anyone ever test GEA4? It uses 128bit key length and is hence quite a bit different than GEA1/2/ [?] I didn't so far. What I checked was which algorighms are implemented in libosmocore and it seems only GEA3/4 are. So I'll switch to GEA3 just in case -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3a2b84d386f55447e9eed35e59fdc0272e5147d1 Gerrit-Change-Number: 14982 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Jul 2019 07:03:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 07:52:20 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 07:52:20 +0000 Subject: Change in ...osmo-ggsn[master]: sgsnemu: Fix unaligned pointer access during ip/icmp checksum In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14980 ) Change subject: sgsnemu: Fix unaligned pointer access during ip/icmp checksum ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14980/1/sgsnemu/sgsnemu.c File sgsnemu/sgsnemu.c: https://gerrit.osmocom.org/#/c/14980/1/sgsnemu/sgsnemu.c at 1285 PS1, Line 1285: memcpy(&v16, p8, 2); > To be honest, I'm not sure if that would be the same in this case. [?] Now that I see this is actualy computing the IP header checksum, what about using ggsn/checksum.c:ip_compute_csum() ? The function could be moved to a shared source file... -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/14980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I783f104c31234a07f2a13f6dbc577a71b25b36a7 Gerrit-Change-Number: 14980 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Jul 2019 07:52:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 07:58:00 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 07:58:00 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Add a section about encryption In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 ) Change subject: configuration.adoc: Add a section about encryption ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3a2b84d386f55447e9eed35e59fdc0272e5147d1 Gerrit-Change-Number: 14982 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 07:58:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 07:58:19 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 07:58:19 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Small fixes In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 ) Change subject: configuration.adoc: Small fixes ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558 Gerrit-Change-Number: 14981 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 07:58:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 07:58:27 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 07:58:27 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Small fixes In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 ) Change subject: configuration.adoc: Small fixes ...................................................................... configuration.adoc: Small fixes Fix some typos, correct data compression command, add example to turn off compression. Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558 Related: OS#1720 --- M doc/manuals/chapters/configuration.adoc 1 file changed, 25 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index 2828987..f61fd55 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -7,7 +7,7 @@ from the BSC side. On the other hand, it is because the Gb interface does not need an -explicit configuration of all each PCU connecting to the SGSN. The +explicit configuration of each PCU connecting to the SGSN. The administrator only has to ensure that the NS and BSSGP layer identities (NSEI, NSVCI, BVCI) are unique for each PCU connecting to the SGSN. @@ -17,7 +17,7 @@ and the GGSNs. It is implemented via UDP on well-known source and destination ports. -When a MS requests establishment of a PDP context, it specifies the APN +When an MS requests establishment of a PDP context, it specifies the APN (Access Point Name) to which the context shall be established. This APN determines which GGSN shall be used, and that in turn determines which external IP network the MS will be connected to. @@ -100,7 +100,7 @@ policy that is defined for osmo-nitb! -.Example: Assign or change authorization policy: +.Example: Assign or change authorization policy ---- OsmoSGSN> enable OsmoSGSN# configure terminal @@ -116,7 +116,7 @@ <2> Saves current changes to cofiguration to make this policy persistent -.Example: Access control list: +.Example: Access control list ---- sgsn auth-policy acl-only <1> @@ -153,7 +153,7 @@ GSM/GPRS. GSUP performs a challenge-response authentication protocol called OAP, -which uses the standard MILEAGE algorithm for mutual authentication +which uses the standard MILENAGE algorithm for mutual authentication between OsmoSGSN and the HLR/HLR-GW. [[sgsn-ex-gsup]] @@ -251,9 +251,8 @@ === User traffic compression -In order to save optimize GPRS bandwith, OsmoSGSN implements header and data -compression schemes. The compression will reduce the packet length in order -to save radio bandwith. +In order to save GPRS bandwith, OsmoSGSN implements header and data +compression schemes which will reduce the packet length. ==== Header compression @@ -278,18 +277,24 @@ compression parameters entirely. The number of slots is the maximum number of packet headers per subscriber that can be stored in the codebook. -.Example: Accept compression if requested: +.Example: Accept compression if requested ---- sgsn compression rfc1144 passive ---- -.Example: Actively promote compression: +.Example: Actively promote compression ---- sgsn compression rfc1144 active slots 8 ---- +.Example: Turn off compression +---- +sgsn + no compression rfc1144 +---- + NOTE: The usage of TCP/IP options may disturb the RFC1144 header compression scheme. TCP/IP options may render RFC1144 ineffective if variable data is encoded into the option section of the TCP/IP packet. (e.g. TCP option 8, @@ -299,10 +304,10 @@ ==== Data compression Data compression works on the raw packet data, including the header part of the -packet. If enabled, header compression is applied before first data compression +packet. If enabled, header compression is applied first before data compression is applied. OsmoSGSN implements the V.42bis data compression scheme. -*compression rfc1144 passive*:: +*compression v42bis passive*:: V42bis data compression has to be actively requested by the modem. The network will not promote compression by itself. This is the recommended mode of operation. @@ -316,14 +321,20 @@ the codebook size by the maxium number ('codewords') and size ('strlen') of entries. -.Example: Accept compression if requested: +.Example: Accept compression if requested ---- sgsn compression v42bis passive ---- -.Example: Actively promote compression: +.Example: Actively promote compression ---- sgsn compression v42bis active direction both codewords 512 strlen 20 ---- + +.Example: Turn off compression +---- +sgsn + no compression v42bis +---- -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6beff8c66eacf12f1081d51dd6b124bdd4478558 Gerrit-Change-Number: 14981 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 07:58:28 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 07:58:28 +0000 Subject: Change in ...osmo-sgsn[master]: configuration.adoc: Add a section about encryption In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 ) Change subject: configuration.adoc: Add a section about encryption ...................................................................... configuration.adoc: Add a section about encryption Change-Id: I3a2b84d386f55447e9eed35e59fdc0272e5147d1 Related: OS#1720 --- M doc/manuals/chapters/configuration.adoc 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index f61fd55..fd2d7ed 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -338,3 +338,21 @@ sgsn no compression v42bis ---- + +=== Encryption + +Encryption can be enabled if the auth-policy is set to remote and the +HLR subscriber entries contain the keys of the SIM card. See +<> on how to connect to an external HLR. + +.Example: Turn on encryption (GEA3) +---- +sgsn + encryption GEA3 +---- + +.Example: Turn off encryption (GEA0) +---- +sgsn + encryption GEA0 +---- -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/14982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3a2b84d386f55447e9eed35e59fdc0272e5147d1 Gerrit-Change-Number: 14982 Gerrit-PatchSet: 4 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 07:59:39 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 07:59:39 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: use DLGLOBAL logging sub-system In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14970 ) Change subject: vty/telnet_interface.c: use DLGLOBAL logging sub-system ...................................................................... vty/telnet_interface.c: use DLGLOBAL logging sub-system Change-Id: I1564f4714a33d36792e4982deb8f19d1b740dc0c --- M src/vty/telnet_interface.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c index a1fc999..c16b0b1 100644 --- a/src/vty/telnet_interface.c +++ b/src/vty/telnet_interface.c @@ -169,7 +169,7 @@ int rc; if (new_connection < 0) { - LOGP(0, LOGL_ERROR, "telnet accept failed\n"); + LOGP(DLGLOBAL, LOGL_ERROR, "telnet accept failed\n"); return new_connection; } @@ -188,7 +188,7 @@ connection->vty = vty_create(new_connection, connection); if (!connection->vty) { - LOGP(0, LOGL_ERROR, "couldn't create VTY\n"); + LOGP(DLGLOBAL, LOGL_ERROR, "couldn't create VTY\n"); /* vty_create() is already closing the fd if it returns NULL */ talloc_free(connection); return -1; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1564f4714a33d36792e4982deb8f19d1b740dc0c Gerrit-Change-Number: 14970 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 07:59:40 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 07:59:40 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: avoid unneeded initialization In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14971 ) Change subject: vty/telnet_interface.c: avoid unneeded initialization ...................................................................... vty/telnet_interface.c: avoid unneeded initialization Unconditional initialization follows the structure definition, so there is no need to do it twice. This prevents compiler from warning about potential errors. Change-Id: If9fd2826f132dfa203dda62940d93dbdfcfd92ac --- M src/vty/telnet_interface.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c index c16b0b1..d44754c 100644 --- a/src/vty/telnet_interface.c +++ b/src/vty/telnet_interface.c @@ -210,7 +210,7 @@ /*! callback from core VTY code about VTY related events */ void vty_event(enum event event, int sock, struct vty *vty) { - struct vty_signal_data sig_data = { 0, }; + struct vty_signal_data sig_data; struct telnet_connection *connection = vty->priv; struct osmo_fd *bfd; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If9fd2826f132dfa203dda62940d93dbdfcfd92ac Gerrit-Change-Number: 14971 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 08:01:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 08:01:05 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 ) Change subject: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82f774ad18d0e555eb8f3590a519946d9c583c78 Gerrit-Change-Number: 14973 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 08:01:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 08:02:09 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 08:02:09 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 ) Change subject: vty/vty.c: the command buffer can be accessed directly ...................................................................... Patch Set 2: gerrit doesn't show anything but whitespace changes? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39 Gerrit-Change-Number: 14975 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Jul 2019 08:02:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 08:57:12 2019 From: gerrit-no-reply at lists.osmocom.org (roh) Date: Tue, 30 Jul 2019 08:57:12 +0000 Subject: Change in ...simtrace2[master]: add new board and app for gpio testing on octsimtest board In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/14969 to look at the new patch set (#2). Change subject: add new board and app for gpio testing on octsimtest board ...................................................................... add new board and app for gpio testing on octsimtest board Change-Id: I01243044002f51b34e8dc12c1b1f565bbf1740a2 --- M firmware/README.txt A firmware/apps/gpio_test/Makefile A firmware/apps/gpio_test/gpio_test.c A firmware/apps/gpio_test/main.c A firmware/apps/gpio_test/usb_strings.txt A firmware/libboard/octsimtest/include/board.h A firmware/libboard/octsimtest/include/i2c.h A firmware/libboard/octsimtest/include/mcp23017.h A firmware/libboard/octsimtest/source/board_octsimtest.c A firmware/libboard/octsimtest/source/i2c.c A firmware/libboard/octsimtest/source/mcp23017.c 11 files changed, 687 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/69/14969/2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/14969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I01243044002f51b34e8dc12c1b1f565bbf1740a2 Gerrit-Change-Number: 14969 Gerrit-PatchSet: 2 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 09:16:46 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Jul 2019 09:16:46 +0000 Subject: Change in ...osmo-iuh[master]: jenkins: Enable manual publishing and building Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14991 Change subject: jenkins: Enable manual publishing and building ...................................................................... jenkins: Enable manual publishing and building Related: OS#2589 Change-Id: Ic7437daeab0b07d16fd71ca3881cb31bab7b1925 --- M contrib/jenkins.sh 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/91/14991/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 5754f2c..16f61b7 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -25,6 +25,12 @@ # the asn1c binary is used by the 'regen' target below osmo-build-dep.sh asn1c aper-prefix +CONFIG="" +if [ "$WITH_MANUALS" = "1" ]; then + osmo-build-dep.sh osmo-gsm-manuals + CONFIG="--enable-manuals" +fi + set +x echo echo @@ -34,7 +40,7 @@ set -x autoreconf --install --force -./configure --enable-sanitize +./configure --enable-sanitize $CONFIG # Verify that checked-in asn1 code is identical to regenerated asn1 code PATH="$inst/bin:$PATH" $MAKE $PARALLEL_MAKE -C src regen @@ -55,6 +61,10 @@ || cat-testlogs.sh $MAKE distcheck \ || cat-testlogs.sh -$MAKE maintainer-clean +if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then + make -C "$base/doc/manuals" publish +fi + +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ic7437daeab0b07d16fd71ca3881cb31bab7b1925 Gerrit-Change-Number: 14991 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 09:22:45 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Jul 2019 09:22:45 +0000 Subject: Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation Message-ID: daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 Change subject: master-builds: Publish osmo-hnbgw documentation ...................................................................... master-builds: Publish osmo-hnbgw documentation Requires: Ic7437daeab0b07d16fd71ca3881cb31bab7b1925 (osmo-iuh) Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 --- M jobs/master-builds.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/92/14992/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 373e975..fc5744b 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -227,6 +227,7 @@ cmd: WITH_MANUALS=1 PUBLISH=1 ./contrib/jenkins.sh - osmo-iuh: + cmd: WITH_MANUALS=1 PUBLISH=1 ./contrib/jenkins.sh # Full triggers would be: # trigger: master-osmo-msc, master-osmo-sgsn # Optimized: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 Gerrit-Change-Number: 14992 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 09:30:05 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Jul 2019 09:30:05 +0000 Subject: Change in ...osmo-iuh[master]: jenkins: Enable manual publishing and building In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/14991 to look at the new patch set (#2). Change subject: jenkins: Enable manual publishing and building ...................................................................... jenkins: Enable manual publishing and building Related: OS#2589 Change-Id: Ic7437daeab0b07d16fd71ca3881cb31bab7b1925 --- M contrib/jenkins.sh 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/91/14991/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ic7437daeab0b07d16fd71ca3881cb31bab7b1925 Gerrit-Change-Number: 14991 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 09:39:27 2019 From: gerrit-no-reply at lists.osmocom.org (roh) Date: Tue, 30 Jul 2019 09:39:27 +0000 Subject: Change in ...osmo-remsim[master]: add contrib/remsim-apitool.py to control the REST-interface of osmo-r... In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/14968 to look at the new patch set (#2). Change subject: add contrib/remsim-apitool.py to control the REST-interface of osmo-remsim-server ...................................................................... add contrib/remsim-apitool.py to control the REST-interface of osmo-remsim-server Change-Id: Ia01b0a89e21af18b898becd8f5440c32936772b7 --- M Makefile.am A contrib/remsim-apitool.py 2 files changed, 118 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/68/14968/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia01b0a89e21af18b898becd8f5440c32936772b7 Gerrit-Change-Number: 14968 Gerrit-PatchSet: 2 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 09:46:26 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Jul 2019 09:46:26 +0000 Subject: Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation ...................................................................... Patch Set 1: Code-Review+1 We should also set WITH_MANUALS=1 for osmo-iuh in gerrit-verifications.yml (either in same patch or as separate patch). -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 Gerrit-Change-Number: 14992 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 09:46:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 09:51:25 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Jul 2019 09:51:25 +0000 Subject: Change in ...osmo-iuh[master]: jenkins: Enable manual publishing and building In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14991 ) Change subject: jenkins: Enable manual publishing and building ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ic7437daeab0b07d16fd71ca3881cb31bab7b1925 Gerrit-Change-Number: 14991 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 09:51:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 11:31:12 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 11:31:12 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/14972/2/src/vty/telnet_interface.c File src/vty/telnet_interface.c: https://gerrit.osmocom.org/#/c/14972/2/src/vty/telnet_interface.c at 129 PS2, Line 129: osmo_sock_get_name_buf(sock_name_buf, OSMO_SOCK_NAME_MAXLEN, fd->fd); You must check for negative here, and in that case don't use sock_name_buf (it may be uninitialized). https://gerrit.osmocom.org/#/c/14972/2/src/vty/telnet_interface.c at 182 PS2, Line 182: osmo_sock_get_name_buf(sock_name_buf, OSMO_SOCK_NAME_MAXLEN, new_connection); Same here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c Gerrit-Change-Number: 14972 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 11:31:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 11:31:15 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 11:31:15 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events ...................................................................... Patch Set 2: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c Gerrit-Change-Number: 14972 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 11:31:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 11:35:16 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 11:35:16 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 ) Change subject: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14973/2/src/vty/vty.c File src/vty/vty.c: https://gerrit.osmocom.org/#/c/14973/2/src/vty/vty.c at 1420 PS2, Line 1420: vty->buf[vty->length] = '\0'; Just wondering if this affects other functions called in other cases of this switch statement... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82f774ad18d0e555eb8f3590a519946d9c583c78 Gerrit-Change-Number: 14973 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 11:35:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 11:36:34 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 11:36:34 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 ) Change subject: vty/vty.c: the command buffer can be accessed directly ...................................................................... Patch Set 2: Code-Review+1 Looks fine for me, no idea what laforge's talking about. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39 Gerrit-Change-Number: 14975 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Jul 2019 11:36:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 11:37:47 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 11:37:47 +0000 Subject: Change in ...osmo-iuh[master]: jenkins: Enable manual publishing and building In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14991 ) Change subject: jenkins: Enable manual publishing and building ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ic7437daeab0b07d16fd71ca3881cb31bab7b1925 Gerrit-Change-Number: 14991 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 11:37:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 11:38:33 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 11:38:33 +0000 Subject: Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 Gerrit-Change-Number: 14992 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 11:38:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 11:48:21 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 11:48:21 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 ) Change subject: vty/vty.c: the command buffer can be accessed directly ...................................................................... Patch Set 2: > Patch Set 2: Code-Review+1 > > Looks fine for me, no idea what laforge's talking about. I think he faced a bug in the old Gerrit UI. For some reason, diff view is broken there :/ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39 Gerrit-Change-Number: 14975 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Jul 2019 11:48:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:01:39 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 12:01:39 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 ) Change subject: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14973/2/src/vty/vty.c File src/vty/vty.c: https://gerrit.osmocom.org/#/c/14973/2/src/vty/vty.c at 1420 PS2, Line 1420: vty->buf[vty->length] = '\0'; > Just wondering if this affects other functions called in other cases of this switch statement... Other cases are mostly about handling the control commands, such as Ctrl + D, Ctrl + W, etc. They don't use the buffer pointed by vty->buf. Excluding the cases below: auto-completion and interactive help. They both call cmd_make_strvec(), which seems to be safe against non-terminated input. At least I don't see any warnings from ASAN. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82f774ad18d0e555eb8f3590a519946d9c583c78 Gerrit-Change-Number: 14973 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 12:01:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:08:15 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 12:08:15 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14972/2/src/vty/telnet_interface.c File src/vty/telnet_interface.c: https://gerrit.osmocom.org/#/c/14972/2/src/vty/telnet_interface.c at 129 PS2, Line 129: osmo_sock_get_name_buf(sock_name_buf, OSMO_SOCK_NAME_MAXLEN, fd->fd); > You must check for negative here, and in that case don't use sock_name_buf (it may be uninitialized) [?] Are you sure? I checked the source code, and AFAICS osmo_sock_get_name_buf() always writes something to 'sock_name_buf', even in case of error (''). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c Gerrit-Change-Number: 14972 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 12:08:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:39:29 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 12:39:29 +0000 Subject: Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 Gerrit-Change-Number: 14992 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 12:39:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:39:32 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 12:39:32 +0000 Subject: Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation In-Reply-To: References: Message-ID: laforge has removed a vote on this change. Change subject: master-builds: Publish osmo-hnbgw documentation ...................................................................... Removed Verified+1 by laforge -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 Gerrit-Change-Number: 14992 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: deleteVote -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:39:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 12:39:36 +0000 Subject: Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 Gerrit-Change-Number: 14992 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 12:39:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:40:38 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 12:40:38 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 ) Change subject: vty/vty.c: the command buffer can be accessed directly ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39 Gerrit-Change-Number: 14975 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Jul 2019 12:40:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:41:04 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 12:41:04 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 ) Change subject: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82f774ad18d0e555eb8f3590a519946d9c583c78 Gerrit-Change-Number: 14973 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 12:41:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:41:06 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 12:41:06 +0000 Subject: Change in ...osmo-iuh[master]: jenkins: Enable manual publishing and building In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14991 ) Change subject: jenkins: Enable manual publishing and building ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ic7437daeab0b07d16fd71ca3881cb31bab7b1925 Gerrit-Change-Number: 14991 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 12:41:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:41:29 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 12:41:29 +0000 Subject: Change in ...simtrace2[master]: add new board and app for gpio testing on octsimtest board In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/14969 ) Change subject: add new board and app for gpio testing on octsimtest board ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/14969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I01243044002f51b34e8dc12c1b1f565bbf1740a2 Gerrit-Change-Number: 14969 Gerrit-PatchSet: 2 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 30 Jul 2019 12:41:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:41:30 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 12:41:30 +0000 Subject: Change in ...simtrace2[master]: add new board and app for gpio testing on octsimtest board In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/simtrace2/+/14969 ) Change subject: add new board and app for gpio testing on octsimtest board ...................................................................... add new board and app for gpio testing on octsimtest board Change-Id: I01243044002f51b34e8dc12c1b1f565bbf1740a2 --- M firmware/README.txt A firmware/apps/gpio_test/Makefile A firmware/apps/gpio_test/gpio_test.c A firmware/apps/gpio_test/main.c A firmware/apps/gpio_test/usb_strings.txt A firmware/libboard/octsimtest/include/board.h A firmware/libboard/octsimtest/include/i2c.h A firmware/libboard/octsimtest/include/mcp23017.h A firmware/libboard/octsimtest/source/board_octsimtest.c A firmware/libboard/octsimtest/source/i2c.c A firmware/libboard/octsimtest/source/mcp23017.c 11 files changed, 687 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/README.txt b/firmware/README.txt index fa7f60a..cd04e7a 100644 --- a/firmware/README.txt +++ b/firmware/README.txt @@ -24,6 +24,7 @@ * `simtrace`: The good old Osmocom SIMtrace PCB with SAM3 instead of SAM7, open hardware. * `qmod`: A sysmocom-proprietary quad mPCIe carrier board, publicly available * `owhw`: An undisclosed sysmocom-internal board, not publicly available +* `octsimtest`: A sysmocom-proprietary production testing board, not publicly available = Firmware @@ -51,6 +52,7 @@ * `cardem`: To provide remote SIM operation capabilities. * `trace`: To monitor the communication between a SIM card and a phone (corresponds to the functionality provide by the first SIMtrace) * `triple_play`: To support the three previous functionalities, using USB configurations. +* `gpio_test`: internal test code == Memories diff --git a/firmware/apps/gpio_test/Makefile b/firmware/apps/gpio_test/Makefile new file mode 100644 index 0000000..b2b4707 --- /dev/null +++ b/firmware/apps/gpio_test/Makefile @@ -0,0 +1,3 @@ +C_FILES += $(C_LIBUSB_RT) + +C_FILES += gpio_test.c diff --git a/firmware/apps/gpio_test/gpio_test.c b/firmware/apps/gpio_test/gpio_test.c new file mode 100644 index 0000000..2ab23e7 --- /dev/null +++ b/firmware/apps/gpio_test/gpio_test.c @@ -0,0 +1,10 @@ +#include +#include "utils.h" +#include "chip.h" + + + +void gpio_test_init(void) +{ + printf("FIXME run tests here\n\n"); +} diff --git a/firmware/apps/gpio_test/main.c b/firmware/apps/gpio_test/main.c new file mode 100644 index 0000000..8fe68b3 --- /dev/null +++ b/firmware/apps/gpio_test/main.c @@ -0,0 +1,54 @@ + +#include "board.h" +#include "utils.h" +#include "osmocom/core/timer.h" + +extern void gpio_test_init(void); + +/* returns '1' in case we should break any endless loop */ +static void check_exec_dbg_cmd(void) +{ + int ch; + + if (!UART_IsRxReady()) + return; + + ch = UART_GetChar(); + + board_exec_dbg_cmd(ch); +} + + +extern int main(void) +{ + led_init(); + led_blink(LED_RED, BLINK_ALWAYS_ON); + led_blink(LED_GREEN, BLINK_ALWAYS_ON); + + /* Enable watchdog for 2000 ms, with no window */ + WDT_Enable(WDT, WDT_MR_WDRSTEN | WDT_MR_WDDBGHLT | WDT_MR_WDIDLEHLT | + (WDT_GetPeriod(2000) << 16) | WDT_GetPeriod(2000)); + + PIO_InitializeInterrupts(0); + + + printf("\n\r\n\r" + "=============================================================================\n\r" + "GPIO Test firmware " GIT_VERSION " (C) 2019 Sysmocom GmbH\n\r" + "=============================================================================\n\r"); + + board_main_top(); + + TRACE_INFO("starting gpio test...\n\r"); + gpio_test_init(); + + TRACE_INFO("entering main loop...\n\r"); + while (1) { + WDT_Restart(WDT); + + check_exec_dbg_cmd(); + osmo_timers_prepare(); + osmo_timers_update(); + } + +} diff --git a/firmware/apps/gpio_test/usb_strings.txt b/firmware/apps/gpio_test/usb_strings.txt new file mode 100644 index 0000000..0e797ac --- /dev/null +++ b/firmware/apps/gpio_test/usb_strings.txt @@ -0,0 +1,10 @@ +sysmocom - s.f.m.c. GmbH +SIMtrace 2 compatible device +SIMtrace Sniffer +SIMtrace CCID +SIMtrace Phone +SIMtrace MITM +CardEmulator Modem 1 +CardEmulator Modem 2 +CardEmulator Modem 3 +CardEmulator Modem 4 diff --git a/firmware/libboard/octsimtest/include/board.h b/firmware/libboard/octsimtest/include/board.h new file mode 100644 index 0000000..2effc02 --- /dev/null +++ b/firmware/libboard/octsimtest/include/board.h @@ -0,0 +1,154 @@ +/* octSIMtest with SAM3S board definition + * + * (C) 2019 by sysmocom -s.f.m.c. GmbH, Author:Joachim Steiger + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA + */ +#pragma once +#include "board_common.h" +#include "simtrace_usb.h" + +/* Name of the board */ +#define BOARD_NAME "OCTSIMTEST" +/* Board definition */ +#define octsimtest + +/** oscillator used as main clock source (in Hz) */ +#define BOARD_MAINOSC 18432000 +/** desired main clock frequency (in Hz, based on BOARD_MAINOSC) */ +#define BOARD_MCK 58982400 // 18.432 * 16 / 5 + +/** Pin configuration **/ +/* Button to force bootloader start (shorted to ground when pressed */ +#define PIN_BOOTLOADER_SW {PIO_PA5, PIOA, ID_PIOA, PIO_INPUT, PIO_PULLUP} + +//FIXME SIM_PWEN_PIN collides with PA5/bootloader_sw on octsimtest +/* Enable powering the card using the second 3.3 V output of the LDO (active high) */ +#define SIM_PWEN_PIN {PIO_PA12, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_DEFAULT} +/* Enable powering the SIM card */ +#define PWR_PINS SIM_PWEN_PIN + +// FIXME PA8 is 32khz xtal on octsimtest +/* Card presence pin */ +#define SW_SIM PIO_PA11 +/* Pull card presence pin high (shorted to ground in card slot when card is present) */ +#define SMARTCARD_CONNECT_PIN {SW_SIM, PIOA, ID_PIOA, PIO_INPUT, PIO_PULLUP | PIO_DEBOUNCE | PIO_DEGLITCH | PIO_IT_EDGE } + +/** Smart card connection **/ +//FIXME +/* Card RST reset signal input (active low; RST_SIM in schematic) */ +#define PIN_SIM_RST {PIO_PA13, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} +/* Card I/O data signal input/output (I/O_SIM in schematic) */ +#define PIN_SIM_IO {PIO_PA6A_TXD0, PIOA, ID_PIOA, PIO_PERIPH_A, PIO_DEFAULT} +/* Card CLK clock input (CLK_SIM in schematic) */ +#define PIN_SIM_CLK {PIO_PA2B_SCK0, PIOA, ID_PIOA, PIO_PERIPH_B, PIO_DEFAULT} +/* Pin to measure card I/O timing (to start measuring the ETU on I/O activity; connected I/O_SIM in schematic) */ +#define PIN_SIM_IO_INPUT {PIO_PA1B_TIOB0, PIOA, ID_PIOA, PIO_PERIPH_B, PIO_DEFAULT} +//FIXME PIO_PA4B_TCLK0 PA4 is LED on octsimtest +/* Pin used as clock input (to measure the ETU duration; connected to CLK_SIM in schematic) */ +#define PIN_SIM_CLK_INPUT {PIO_PA14, PIOA, ID_PIOA, PIO_PERIPH_B, PIO_DEFAULT} +/* Pins used to measure ETU timing (using timer counter) */ +#define PINS_TC PIN_SIM_IO_INPUT, PIN_SIM_CLK_INPUT + +/** Phone connection **/ +/* Phone USIM slot 1 VCC pin (VCC_PHONE in schematic) */ +#define PIN_USIM1_VCC {PIO_PA25, PIOA, ID_PIOA, PIO_INPUT, PIO_DEFAULT} +/* Phone USIM slot 1 RST pin (active low; RST_PHONE in schematic) */ +#define PIN_USIM1_nRST {PIO_PA24, PIOA, ID_PIOA, PIO_INPUT, PIO_IT_RISE_EDGE | PIO_DEGLITCH } +/* Phone I/O data signal input/output (I/O_PHONE in schematic) */ +#define PIN_PHONE_IO {PIO_PA22A_TXD1, PIOA, ID_PIOA, PIO_PERIPH_A, PIO_DEFAULT} +/* Phone CLK clock input (CLK_PHONE in schematic) */ +#define PIN_PHONE_CLK {PIO_PA23A_SCK1, PIOA, ID_PIOA, PIO_PERIPH_A, PIO_DEFAULT} +/* Pin used for phone USIM slot 1 communication */ +#define PINS_USIM1 PIN_PHONE_IO, PIN_PHONE_CLK, PIN_PHONE_CLK_INPUT, PIN_USIM1_VCC, PIN_PHONE_IO_INPUT, PIN_USIM1_nRST +/* Phone I/O data signal input/output (unused USART RX input; connected to I/O_PHONE in schematic) */ +#define PIN_PHONE_IO_INPUT {PIO_PA21A_RXD1, PIOA, ID_PIOA, PIO_PERIPH_A, PIO_DEFAULT} +/* Pin used as clock input (to measure the ETU duration; connected to CLK_PHONE in schematic) */ +#define PIN_PHONE_CLK_INPUT {PIO_PA29B_TCLK2, PIOA, ID_PIOA, PIO_PERIPH_B, PIO_DEFAULT} + +/** Default pin configuration **/ +/* Disconnect VPP, CLK, and RST lines between card and phone using bus switch (high sets bus switch to high-impedance) */ +#define PIN_SC_SW_DEFAULT {PIO_PA20, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_DEFAULT} +/* Disconnect I/O line between card and phone using bus switch (high sets bus switch to high-impedance) */ +#define PIN_IO_SW_DEFAULT {PIO_PA19, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_DEFAULT} +/* Disconnect all lines (VPP, CLK, RST, and I/O) between card and phone */ +#define PINS_BUS_DEFAULT PIN_SC_SW_DEFAULT, PIN_IO_SW_DEFAULT + +/** Sniffer configuration **/ +/* Connect VPP, CLK, and RST lines between card and phone using bus switch (low connects signals on bus switch) */ +#define PIN_SC_SW_SNIFF {PIO_PA20, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} +/* Connect I/O line between card and phone using bus switch (low connects signals on bus switch) */ +#define PIN_IO_SW_SNIFF {PIO_PA19, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} +/* Connect all lines (VPP, CLK, RST, and I/O) between card and phone */ +#define PINS_BUS_SNIFF PIN_SC_SW_SNIFF, PIN_IO_SW_SNIFF +/* Card RST reset signal input (use as input since the phone will drive it) */ +#define PIN_SIM_RST_SNIFF {PIO_PA7, PIOA, ID_PIOA, PIO_INPUT, PIO_DEGLITCH | PIO_IT_EDGE} +/* Pins used to sniff phone-card communication */ +#define PINS_SIM_SNIFF PIN_SIM_IO, PIN_SIM_CLK, PIN_SIM_RST_SNIFF +/* Disable power converter 4.5-6V to 3.3V (active high) */ +#define PIN_SIM_PWEN_SNIFF {SIM_PWEN, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} +/* Enable power switch to forward VCC_PHONE to VCC_SIM (active high) */ +#define PIN_VCC_FWD_SNIFF {VCC_FWD, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_DEFAULT} +/* Use phone VCC to power card */ +#define PINS_PWR_SNIFF PIN_SIM_PWEN_SNIFF, PIN_VCC_FWD_SNIFF + +/** CCID configuration */ +/* Card RST reset signal input (active low; RST_SIM in schematic) */ +#define PIN_ISO7816_RSTMC {PIO_PA7, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} +/* ISO7816-communication related pins */ +#define PINS_ISO7816 PIN_SIM_IO, PIN_SIM_CLK, PIN_ISO7816_RSTMC // SIM_PWEN_PIN, PIN_SIM_IO2, PIN_SIM_CLK2 + +/** External SPI flash interface **/ +/* SPI MISO pin definition */ +#define PIN_SPI_MISO {PIO_PA12A_MISO, PIOA, PIOA, PIO_PERIPH_A, PIO_PULLUP} +/* SPI MOSI pin definition */ +#define PIN_SPI_MOSI {PIO_PA13A_MOSI, PIOA, PIOA, PIO_PERIPH_A, PIO_DEFAULT} +/* SPI SCK pin definition */ +#define PIN_SPI_SCK {PIO_PA14A_SPCK, PIOA, PIOA, PIO_PERIPH_A, PIO_DEFAULT} +/* SPI pins definition. Contains MISO, MOSI & SCK */ +#define PINS_SPI PIN_SPI_MISO, PIN_SPI_MOSI, PIN_SPI_SCK +/* SPI chip select 0 pin definition */ +#define PIN_SPI_NPCS0 {PIO_PA11A_NPCS0, PIOA, PIOA, PIO_PERIPH_A, PIO_DEFAULT} +/* SPI flash write protect pin (active low, pulled low) */ +#define PIN_SPI_WP {PA15, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} + +/** Pin configuration to control USB pull-up on D+ + * @details the USB pull-up on D+ is enable by default on the board but can be disabled by setting PA16 high + */ +#define PIN_USB_PULLUP {PIO_PA16, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT} + +/** USB definitions */ +/* OpenMoko SIMtrace 2 USB vendor ID */ +#define BOARD_USB_VENDOR_ID USB_VENDOR_OPENMOKO +/* OpenMoko SIMtrace 2 USB product ID (main application/runtime mode) */ +#define BOARD_USB_PRODUCT_ID USB_PRODUCT_SIMTRACE2 +/* OpenMoko SIMtrace 2 DFU USB product ID (DFU bootloader/DFU mode) */ +#define BOARD_DFU_USB_PRODUCT_ID USB_PRODUCT_SIMTRACE2_DFU +/* USB release number (bcdDevice, shown as 0.00) */ +#define BOARD_USB_RELEASE 0x000 +/* Indicate SIMtrace is bus power in USB attributes */ +#define BOARD_USB_BMATTRIBUTES USBConfigurationDescriptor_BUSPOWERED_NORWAKEUP + +/** Supported modes */ +/* SIMtrace board supports sniffer mode */ +//#define HAVE_SNIFFER +/* SIMtrace board supports CCID mode */ +//#define HAVE_CCID +/* SIMtrace board supports card emulation mode */ +//#define HAVE_CARDEM +/* SIMtrace board supports man-in-the-middle mode */ +//#define HAVE_MITM +/* octsimtest board supports gpio_test mode */ +#define HAVE_GPIO_TEST diff --git a/firmware/libboard/octsimtest/include/i2c.h b/firmware/libboard/octsimtest/include/i2c.h new file mode 100644 index 0000000..5a8c908 --- /dev/null +++ b/firmware/libboard/octsimtest/include/i2c.h @@ -0,0 +1,28 @@ +/* I2C EEPROM memory read and write utilities + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA + */ +#pragma once + +#include + +void i2c_pin_init(void); + +bool i2c_write_byte(bool send_start, bool send_stop, uint8_t byte); +uint8_t i2c_read_byte(bool nack, bool send_stop); +static void i2c_stop_cond(void); + +int eeprom_write_byte(uint8_t slave, uint8_t addr, uint8_t byte); +int eeprom_read_byte(uint8_t slave, uint8_t addr); diff --git a/firmware/libboard/octsimtest/include/mcp23017.h b/firmware/libboard/octsimtest/include/mcp23017.h new file mode 100644 index 0000000..dea6285 --- /dev/null +++ b/firmware/libboard/octsimtest/include/mcp23017.h @@ -0,0 +1,23 @@ +/* mcp23017 i2c gpio expander read and write utilities + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA + */ +#pragma once + +#define MCP23017_ADDRESS 0x20 + +int mcp23017_init(uint8_t slave); +//int mcp23017_write_byte(uint8_t slave, uint8_t addr, uint8_t byte); +//int mcp23017_read_byte(uint8_t slave, uint8_t addr); diff --git a/firmware/libboard/octsimtest/source/board_octsimtest.c b/firmware/libboard/octsimtest/source/board_octsimtest.c new file mode 100644 index 0000000..2772015 --- /dev/null +++ b/firmware/libboard/octsimtest/source/board_octsimtest.c @@ -0,0 +1,72 @@ +/* SIMtrace with SAM3S specific application code + * + * (C) 2017 by Harald Welte + * (C) 2018 by sysmocom -s.f.m.c. GmbH, Author: Kevin Redon + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA + */ +#include "board.h" +#include "simtrace.h" +#include "utils.h" +#include "sim_switch.h" +#include +#include "usb_buf.h" +#include "i2c.h" +#include "mcp23017.h" + +void board_exec_dbg_cmd(int ch) +{ + switch (ch) { + case '?': + printf("\t?\thelp\n\r"); + printf("\tR\treset SAM3\n\r"); + break; + case 'R': + printf("Asking NVIC to reset us\n\r"); + USBD_Disconnect(); + NVIC_SystemReset(); + break; + default: + printf("Unknown command '%c'\n\r", ch); + break; + } +} + +void board_main_top(void) +{ +#ifndef APPLICATION_dfu + usb_buf_init(); + + i2c_pin_init(); + mcp23017_init(MCP23017_ADDRESS); + /* Initialize checking for card insert/remove events */ + //card_present_init(); +#endif +} + +int board_override_enter_dfu(void) +{ + const Pin bl_sw_pin = PIN_BOOTLOADER_SW; + + PIO_Configure(&bl_sw_pin, 1); + + /* Enter DFU bootloader in case the respective button is pressed */ + if (PIO_Get(&bl_sw_pin) == 0) { + /* do not print to early since the console is not initialized yet */ + //printf("BOOTLOADER switch pressed -> Force DFU\n\r"); + return 1; + } else + return 0; +} diff --git a/firmware/libboard/octsimtest/source/i2c.c b/firmware/libboard/octsimtest/source/i2c.c new file mode 100644 index 0000000..a708704 --- /dev/null +++ b/firmware/libboard/octsimtest/source/i2c.c @@ -0,0 +1,225 @@ +/* I2C EEPROM memory read and write utilities + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA + */ +#include "board.h" +#include + +/* Low-Level I2C Routines */ + +static const Pin pin_sda = {PIO_PA30, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_OPENDRAIN }; +static const Pin pin_sda_in = {PIO_PA30, PIOA, ID_PIOA, PIO_INPUT, PIO_DEFAULT }; +static const Pin pin_scl = {PIO_PA31, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_OPENDRAIN }; + +static void i2c_delay() +{ + volatile int v; + int i; + + /* 100 cycles results in SCL peak length of 44us, so it's about + * 440ns per cycle here */ + for (i = 0; i < 14; i++) { + v = 0; + } +} + +void i2c_pin_init(void) +{ + PIO_Configure(&pin_scl, PIO_LISTSIZE(pin_scl)); + PIO_Configure(&pin_sda, PIO_LISTSIZE(pin_sda)); +} + +static void set_scl(void) +{ + PIO_Set(&pin_scl); + i2c_delay(); +} + +static void set_sda(void) +{ + PIO_Set(&pin_sda); + i2c_delay(); +} + +static void clear_scl(void) +{ + PIO_Clear(&pin_scl); + i2c_delay(); +} + +static void clear_sda(void) +{ + PIO_Clear(&pin_sda); + i2c_delay(); +} + +static bool read_sda(void) +{ + bool ret; + + PIO_Configure(&pin_sda_in, PIO_LISTSIZE(pin_sda_in)); + if (PIO_Get(&pin_sda_in)) + ret = true; + else + ret = false; + PIO_Configure(&pin_sda, PIO_LISTSIZE(pin_sda)); + + return ret; +} + +/* Core I2C Routines */ + +static bool i2c_started = false; + +static void i2c_start_cond(void) +{ + if (i2c_started) { + set_sda(); + set_scl(); + } + + clear_sda(); + i2c_delay(); + clear_scl(); + i2c_started = true; +} + +static void i2c_stop_cond(void) +{ + clear_sda(); + set_scl(); + set_sda(); + i2c_delay(); + i2c_started = false; +} + +static void i2c_write_bit(bool bit) +{ + if (bit) + set_sda(); + else + clear_sda(); + i2c_delay(); // ? + set_scl(); + clear_scl(); +} + +static bool i2c_read_bit(void) +{ + bool bit; + + set_sda(); + set_scl(); + bit = read_sda(); + clear_scl(); + + return bit; +} + +bool i2c_write_byte(bool send_start, bool send_stop, uint8_t byte) +{ + uint8_t bit; + bool nack; + + if (send_start) + i2c_start_cond(); + + for (bit = 0; bit < 8; bit++) { + i2c_write_bit((byte & 0x80) != 0); + byte <<= 1; + } + + nack = i2c_read_bit(); + + if (send_stop) + i2c_stop_cond(); + + return nack; +} + +uint8_t i2c_read_byte(bool nack, bool send_stop) +{ + uint8_t byte = 0; + uint8_t bit; + + for (bit = 0; bit < 8; bit++) { + byte = (byte << 1) | i2c_read_bit(); + } + + i2c_write_bit(nack); + + if (send_stop) + i2c_stop_cond(); + + return byte; +} + + +/* EEPROM related code */ + +int eeprom_write_byte(uint8_t slave, uint8_t addr, uint8_t byte) +{ + bool nack; + + WDT_Restart(WDT); + + /* Write slave address */ + nack = i2c_write_byte(true, false, slave << 1); + if (nack) + goto out_stop; + nack = i2c_write_byte(false, false, addr); + if (nack) + goto out_stop; + nack = i2c_write_byte(false, true, byte); + if (nack) + goto out_stop; + /* Wait tWR time to ensure EEPROM is writing correctly (tWR = 5 ms for AT24C02) */ + mdelay(5); + +out_stop: + i2c_stop_cond(); + if (nack) + return -1; + else + return 0; +} + +int eeprom_read_byte(uint8_t slave, uint8_t addr) +{ + bool nack; + + WDT_Restart(WDT); + + /* dummy write cycle */ + nack = i2c_write_byte(true, false, slave << 1); + if (nack) + goto out_stop; + nack = i2c_write_byte(false, false, addr); + if (nack) + goto out_stop; + /* Re-start with read */ + nack = i2c_write_byte(true, false, (slave << 1) | 1); + if (nack) + goto out_stop; + + return i2c_read_byte(true, true); + +out_stop: + i2c_stop_cond(); + if (nack) + return -1; + else + return 0; +} diff --git a/firmware/libboard/octsimtest/source/mcp23017.c b/firmware/libboard/octsimtest/source/mcp23017.c new file mode 100644 index 0000000..63390b4 --- /dev/null +++ b/firmware/libboard/octsimtest/source/mcp23017.c @@ -0,0 +1,106 @@ +#include "board.h" +#include +#include "i2c.h" +#include "mcp23017.h" + + +//defines from https://github.com/adafruit/Adafruit-MCP23017-Arduino-Library/blob/master/Adafruit_MCP23017.h under BSD license + +// registers +#define MCP23017_IODIRA 0x00 +#define MCP23017_IPOLA 0x02 +#define MCP23017_GPINTENA 0x04 +#define MCP23017_DEFVALA 0x06 +#define MCP23017_INTCONA 0x08 +#define MCP23017_IOCONA 0x0A +#define MCP23017_GPPUA 0x0C +#define MCP23017_INTFA 0x0E +#define MCP23017_INTCAPA 0x10 +#define MCP23017_GPIOA 0x12 +#define MCP23017_OLATA 0x14 + + +#define MCP23017_IODIRB 0x01 +#define MCP23017_IPOLB 0x03 +#define MCP23017_GPINTENB 0x05 +#define MCP23017_DEFVALB 0x07 +#define MCP23017_INTCONB 0x09 +#define MCP23017_IOCONB 0x0B +#define MCP23017_GPPUB 0x0D +#define MCP23017_INTFB 0x0F +#define MCP23017_INTCAPB 0x11 +#define MCP23017_GPIOB 0x13 +#define MCP23017_OLATB 0x15 + +#define MCP23017_INT_ERR 255 + + +//bool i2c_write_byte(bool send_start, bool send_stop, uint8_t byte) +//uint8_t i2c_read_byte(bool nack, bool send_stop) +//static void i2c_stop_cond(void) + +int mcp23017_write_byte(uint8_t slave, uint8_t addr, uint8_t byte) +{ + bool nack; + + WDT_Restart(WDT); + +// Write slave address + nack = i2c_write_byte(true, false, slave << 1); + if (nack) + goto out_stop; + nack = i2c_write_byte(false, false, addr); + if (nack) + goto out_stop; + nack = i2c_write_byte(false, true, byte); + if (nack) + goto out_stop; + +out_stop: + i2c_stop_cond(); + if (nack) + return -1; + else + return 0; +} + +int mcp23017_read_byte(uint8_t slave, uint8_t addr) +{ + bool nack; + + WDT_Restart(WDT); + + // dummy write cycle + nack = i2c_write_byte(true, false, slave << 1); + if (nack) + goto out_stop; + nack = i2c_write_byte(false, false, addr); + if (nack) + goto out_stop; + // Re-start with read + nack = i2c_write_byte(true, false, (slave << 1) | 1); + if (nack) + goto out_stop; + + return i2c_read_byte(true, true); + +out_stop: + i2c_stop_cond(); + if (nack) + return -1; + else + return 0; +} + +int mcp23017_init(uint8_t slave) +{ + printf("mcp23017_init\n"); + // all gpio input + if (mcp23017_write_byte(slave, MCP23017_IODIRA, 0xff)) + return false; + if (mcp23017_write_byte(slave, MCP23017_IODIRB, 0xff)) + return false; + printf("mcp23017 found\n"); + return true; +} + -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/14969 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I01243044002f51b34e8dc12c1b1f565bbf1740a2 Gerrit-Change-Number: 14969 Gerrit-PatchSet: 2 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:42:12 2019 From: gerrit-no-reply at lists.osmocom.org (osmith) Date: Tue, 30 Jul 2019 12:42:12 +0000 Subject: Change in ...osmo-ttcn3-hacks[master]: pcu: add osmo-pcu.cfg In-Reply-To: References: Message-ID: osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14960 ) Change subject: pcu: add osmo-pcu.cfg ...................................................................... Patch Set 1: Setting to WIP, I might need to make changes to it while working on the PCU tests. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14960 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iff3e5e6cf0c608680c8c5f9f83e8bc1032274ea9 Gerrit-Change-Number: 14960 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Comment-Date: Tue, 30 Jul 2019 12:42:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:42:22 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 12:42:22 +0000 Subject: Change in ...osmo-remsim[master]: add contrib/remsim-apitool.py to control the REST-interface of osmo-r... In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14968 ) Change subject: add contrib/remsim-apitool.py to control the REST-interface of osmo-remsim-server ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia01b0a89e21af18b898becd8f5440c32936772b7 Gerrit-Change-Number: 14968 Gerrit-PatchSet: 2 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Tue, 30 Jul 2019 12:42:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:42:24 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 12:42:24 +0000 Subject: Change in ...osmo-remsim[master]: add contrib/remsim-apitool.py to control the REST-interface of osmo-r... In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-remsim/+/14968 ) Change subject: add contrib/remsim-apitool.py to control the REST-interface of osmo-remsim-server ...................................................................... add contrib/remsim-apitool.py to control the REST-interface of osmo-remsim-server Change-Id: Ia01b0a89e21af18b898becd8f5440c32936772b7 --- M Makefile.am A contrib/remsim-apitool.py 2 files changed, 118 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/Makefile.am b/Makefile.am index 4843641..0ff9363 100644 --- a/Makefile.am +++ b/Makefile.am @@ -5,7 +5,7 @@ pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = libosmo-rspro.pc -EXTRA_DIST = asn1 .version README.md +EXTRA_DIST = asn1 .version README.md contrib/remsim-apitool.py pkgcofigdir = $(libdir)/pkgconfig diff --git a/contrib/remsim-apitool.py b/contrib/remsim-apitool.py new file mode 100755 index 0000000..35c8826 --- /dev/null +++ b/contrib/remsim-apitool.py @@ -0,0 +1,117 @@ +#!/usr/bin/env python3 + +import sys +import argparse +import requests + +version = "0.1" + +#access rest +def build_url(suffix): + BASE_PATH = "/api/backend/v1" + return ("http://" + server_host + ":" + server_port + BASE_PATH + suffix) + +def rest_get(suffix): + if verbose: + print("GET "+ build_url(suffix)) + try: + resp = requests.get(build_url(suffix)) + except: + print("REST GET failed") + return + if resp.ok: + try: + js = resp.json() + print("%s: %s" % (suffix, js)) + except: + return + else: + return None + +def rest_post(suffix, js = None): + if verbose: + print("POST "+ build_url(suffix)+ str(js)) + resp = requests.post(build_url(suffix), json=js) + if not resp.ok: + print("post failed") + +def rest_delete(suffix): + if verbose: + print("DELETE "+ build_url(suffix)) + resp = requests.delete(build_url(suffix)) + if not resp.ok: + print("delete failed") + +#rest calls +def slotmap_create(bank_id, bank_slot, client_id, client_slot): + js = { + 'bank': {'bankId': bank_id, 'slotNr': bank_slot}, + 'client': {'clientId': client_id, 'slotNr': client_slot}, + } + return rest_post('/slotmaps', js) + +def slotmap_delete(bank_id, bank_slot): + slotmap_id = bank_id * 65536 + bank_slot + return rest_delete("/slotmaps/%u"%slotmap_id) + +def reset_global(): + return rest_post('/global-reset') + +def main(argv): + global server_port, server_host, verbose + + parser = argparse.ArgumentParser() + parser.add_argument("-H", "--host", help="host to connect to", default="127.0.0.1") + parser.add_argument("-p", "--port", help="port to connect to", default="9997") + parser.add_argument("-v", "--verbose", help="increase output verbosity", action="count", default=0) + group = parser.add_mutually_exclusive_group() + group.add_argument("-r", "--reset", help="remove all mappings (POST /global-reset)", action="store_true") + group.add_argument("-c", "--show-clients", help="show clients (GET /clients)",nargs='?',const="all",default=None) + group.add_argument("-b", "--show-banks", help="show banks (GET /banks)",nargs='?',const="all",default=None) + group.add_argument("-s", "--show-slotmaps", help="show slotmaps (GET /slotmaps)",nargs='?',const="all",default=None) + group.add_argument("-m", "--create-slotmap", help="create new slotmap (POST /slotmaps)",nargs=4,metavar=('bank_id', 'bank_slot','client_id','client_slot')) + group.add_argument("-d", "--delete-slotmap", help="delete slotmapping (DELETE /slotmaps/)", type=int, nargs=2, metavar=('bank_id','bank_slot')) + group.add_argument("-a", "--show-all", help="show all (default if no argument given)", action="store_true") + + args = parser.parse_args() + if args.verbose: + print("verbosity = ", args.verbose) + + server_host = args.host + server_port = args.port + verbose = args.verbose + + if args.reset: + reset_global() + return + if args.show_clients: + if args.show_clients == "all": + rest_get("/clients") + else: + rest_get("/clients/" + str(args.show_clients)) + return + if args.show_banks: + if args.show_banks == "all": + rest_get("/banks") + else: + rest_get("/banks/" + str(args.show_banks)) + return + if args.show_slotmaps: + if args.show_slotmaps == "all": + rest_get("/slotmaps") + else: + rest_get("/slotmaps/" + str(args.show_slotmaps)) + return + if args.create_slotmap: + slotmap_create(args.create_slotmap[0],args.create_slotmap[1],args.create_slotmap[2],args.create_slotmap[3]) + return + if args.delete_slotmap: + slotmap_delete(args.delete_slotmap[0],args.delete_slotmap[1]) + return + rest_get("/clients") + rest_get("/banks") + rest_get("/slotmaps") + +if __name__ == "__main__": + main(sys.argv) + -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/14968 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Ia01b0a89e21af18b898becd8f5440c32936772b7 Gerrit-Change-Number: 14968 Gerrit-PatchSet: 2 Gerrit-Owner: roh Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:42:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 12:42:25 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14972/2/src/vty/telnet_interface.c File src/vty/telnet_interface.c: https://gerrit.osmocom.org/#/c/14972/2/src/vty/telnet_interface.c at 129 PS2, Line 129: osmo_sock_get_name_buf(sock_name_buf, OSMO_SOCK_NAME_MAXLEN, fd->fd); > Are you sure? I checked the source code, and AFAICS osmo_sock_get_name_buf() always writes something [?] Implementation wise it does so, but I wouldn't rely on that. Handling return code is also expecteds by other people reading this code in the future, otherwise they might loose time checking if it's correct or not based on implementation. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c Gerrit-Change-Number: 14972 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 12:42:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:42:45 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 12:42:45 +0000 Subject: Change in ...libosmocore[master]: vty/logging_vty.c: fix writing of 'print category-hex' In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14976 ) Change subject: vty/logging_vty.c: fix writing of 'print category-hex' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I33837f0fac1afe83596fa600916abc05ecb8c356 Gerrit-Change-Number: 14976 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 12:42:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:42:47 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Tue, 30 Jul 2019 12:42:47 +0000 Subject: Change in ...libosmocore[master]: vty/logging_vty.c: fix writing of 'print category-hex' In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14976 ) Change subject: vty/logging_vty.c: fix writing of 'print category-hex' ...................................................................... vty/logging_vty.c: fix writing of 'print category-hex' Change-Id: I33837f0fac1afe83596fa600916abc05ecb8c356 --- M src/vty/logging_vty.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index f3e1419..9911c6f 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -906,6 +906,8 @@ vty_out(vty, " logging color %u%s", tgt->use_color ? 1 : 0, VTY_NEWLINE); + vty_out(vty, " logging print category-hex %d%s", + tgt->print_category_hex ? 1 : 0, VTY_NEWLINE); vty_out(vty, " logging print category %d%s", tgt->print_category ? 1 : 0, VTY_NEWLINE); if (tgt->print_ext_timestamp) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I33837f0fac1afe83596fa600916abc05ecb8c356 Gerrit-Change-Number: 14976 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:50:53 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 12:50:53 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT In-Reply-To: References: Message-ID: Hello fixeria, Vadim Yanitskiy, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 to look at the new patch set (#3). Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT ...................................................................... common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 --- M common/chapters/trx_if.adoc 1 file changed, 140 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/40/14940/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 Gerrit-Change-Number: 14940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:51:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 12:51:25 +0000 Subject: Change in ...libosmocore[master]: gsm0808_test: Fix wrong use of memcp In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14979 ) Change subject: gsm0808_test: Fix wrong use of memcp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I17fe7a0a5dc650f050bba1f47d071be749550729 Gerrit-Change-Number: 14979 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 12:51:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:51:29 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 12:51:29 +0000 Subject: Change in ...libosmocore[master]: gsm0808_test: Fix wrong use of memcp In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14979 ) Change subject: gsm0808_test: Fix wrong use of memcp ...................................................................... gsm0808_test: Fix wrong use of memcp After recent system upgrade, gcc 9.1.0, I started getting gsm0808_test failing locally: Assert failed memcmp(&enc_ct, &dec_ct, sizeof(enc_ct)) == 0 libosmocore/tests/gsm0808/gsm0808_test.c:992 During investigation with gdb, fields of both structures seem to contain same values. However, closer lookup gives some hints on why it fails: (gdb) print memcmp(&enc_ct, &dec_ct, sizeof(enc_ct)) $1 = 85 (gdb) print memcmp(&enc_ct, &dec_ct, 12) $14 = 85 (gdb) print ((uint8_t*)&enc_ct)[11] $15 = 85 'U' (gdb) print ((uint8_t*)&dec_ct)[11] $16 = 0 '\000' So the 12th byte in struct gsm0808_channel_type is basically an alignment padding byte added by the compiler (to align perm_spch_len to 4-byte alignment). Since both compared structs are initialized without memset(0) but using compiler's designated initializers, it seems the compiler decided it's no longer needed to zero the padding byte, making memcp fail in this case. In order to avoid the failure, let's properly check every field instead of using memcp here. Change-Id: I17fe7a0a5dc650f050bba1f47d071be749550729 --- M tests/gsm0808/gsm0808_test.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve Vadim Yanitskiy: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c index 8f1e299..2389218 100644 --- a/tests/gsm0808/gsm0808_test.c +++ b/tests/gsm0808/gsm0808_test.c @@ -989,7 +989,10 @@ rc_dec = gsm0808_dec_channel_type(&dec_ct, msg->data + 2, msg->len - 2); OSMO_ASSERT(rc_dec == 4); - OSMO_ASSERT(memcmp(&enc_ct, &dec_ct, sizeof(enc_ct)) == 0); + OSMO_ASSERT(enc_ct.ch_indctr == dec_ct.ch_indctr); + OSMO_ASSERT(enc_ct.ch_rate_type == dec_ct.ch_rate_type); + OSMO_ASSERT(enc_ct.perm_spch_len == dec_ct.perm_spch_len); + OSMO_ASSERT(memcmp(&enc_ct.perm_spch[0], &dec_ct.perm_spch[0], enc_ct.perm_spch_len) == 0); msgb_free(msg); } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I17fe7a0a5dc650f050bba1f47d071be749550729 Gerrit-Change-Number: 14979 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:52:15 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 12:52:15 +0000 Subject: Change in ...osmo-mgw[master]: Fix return variable of strtoul() In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14966 ) Change subject: Fix return variable of strtoul() ...................................................................... Fix return variable of strtoul() Return variable specified by strtoul() is "unsigned long int". If "unsigned int" is used, according to Coverity the return value can never be ULONG_MAX: CID 202173: Integer handling issues (CONSTANT_EXPRESSION_RESULT) "pt == 18446744073709551615UL /* 9223372036854775807L * 2UL + 1UL */" is always false regardless of the values of its operands. This occurs as the logical second operand of "&&". Furthermore, PT is 7 bit in RTP header [1], so let's avoid accepting incorrect values. [1] https://tools.ietf.org/html/rfc3550#section-5 Fixes: c5c1430a1c00ad86855ffff3df3f106bb2bce1d5 ("Catch unsigned integer MGCP parsing errors with strtoul") Fixes: Coverity CID#202172 FIxes: Coverity CID#202173 Change-Id: Ice9eee6a252fab73dbab5ebf3cfc83c1b354fd08 --- M src/libosmo-mgcp-client/mgcp_client.c M src/libosmo-mgcp/mgcp_sdp.c 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 910289e..3f8e780 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -268,7 +268,7 @@ { char *pt_str; char *pt_end; - unsigned int pt; + unsigned long int pt; unsigned int count = 0; unsigned int i; @@ -298,6 +298,9 @@ pt_str == pt_end) goto response_parse_failure_pt; + if (pt >> 7) /* PT is 7 bit field, higher values not allowed */ + goto response_parse_failure_pt; + /* Do not allow duplicate payload types */ for (i = 0; i < count; i++) if (r->codecs[i] == pt) diff --git a/src/libosmo-mgcp/mgcp_sdp.c b/src/libosmo-mgcp/mgcp_sdp.c index 56fc611..01e7968 100644 --- a/src/libosmo-mgcp/mgcp_sdp.c +++ b/src/libosmo-mgcp/mgcp_sdp.c @@ -132,7 +132,7 @@ char *str_ptr; char *pt_str; char *pt_end; - unsigned int pt; + unsigned long int pt; unsigned int count = 0; unsigned int i; @@ -163,6 +163,9 @@ pt_str == pt_end) goto error; + if (pt >> 7) /* PT is 7 bit field, higher values not allowed */ + goto error; + /* Do not allow duplicate payload types */ for (i = 0; i < count; i++) if (codecs[i].payload_type == pt) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ice9eee6a252fab73dbab5ebf3cfc83c1b354fd08 Gerrit-Change-Number: 14966 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 12:57:08 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 12:57:08 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/14972 to look at the new patch set (#3). Change subject: vty/telnet_interface.c: log connection accept() / close() events ...................................................................... vty/telnet_interface.c: log connection accept() / close() events Unfortunately, osmo_sock_get_name_buf() fails in telnet_close_client(): DLGLOBAL INFO telnet_interface.c:130 Closing telnet connection because getsockname(), getpeername(), and even close() fail with: "Bad file descriptor". This looks like a bug of the existing code. Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c --- M src/vty/telnet_interface.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/72/14972/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c Gerrit-Change-Number: 14972 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 13:12:00 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 13:12:00 +0000 Subject: Change in ...osmo-trx[master]: lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr In-Reply-To: References: Message-ID: Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14989 to look at the new patch set (#2). Change subject: lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr ...................................................................... lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr After discussion in [1] and further look at the code, it became obvios rx_underrun events are not happening in general for any SDR (don't exist), so let's drop that counter. Instead, add Tx Dropped Packet counters, which were not accounted prior to this commit. [1] https://github.com/osmocom/osmo-trx/commit/bde55afd29fc9aae10eb11f6515821afa39b772d Change-Id: Iff1535c219a4695a511d383d7c4b06ef6eff959d --- M CommonLibs/osmo_signal.h M CommonLibs/trx_rate_ctr.cpp M CommonLibs/trx_rate_ctr.h M CommonLibs/trx_vty.c M Transceiver52M/device/lms/LMSDevice.cpp M Transceiver52M/device/lms/LMSDevice.h M doc/manuals/chapters/counters_generated.adoc M doc/manuals/vty/trx_vty_reference.xml 8 files changed, 105 insertions(+), 54 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/89/14989/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iff1535c219a4695a511d383d7c4b06ef6eff959d Gerrit-Change-Number: 14989 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 13:13:00 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 13:13:00 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c Gerrit-Change-Number: 14972 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 13:13:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 14:06:20 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Jul 2019 14:06:20 +0000 Subject: Change in ...osmo-iuh[master]: jenkins: Enable manual publishing and building In-Reply-To: References: Message-ID: daniel has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-iuh/+/14991 ) Change subject: jenkins: Enable manual publishing and building ...................................................................... jenkins: Enable manual publishing and building Related: OS#2589 Change-Id: Ic7437daeab0b07d16fd71ca3881cb31bab7b1925 --- M contrib/jenkins.sh 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 5754f2c..ac7363e 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -15,6 +15,7 @@ export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH" export LD_LIBRARY_PATH="$inst/lib" +export PATH="$inst/bin:$PATH" osmo-build-dep.sh libosmocore "" --disable-doxygen osmo-build-dep.sh libosmo-abis @@ -25,6 +26,12 @@ # the asn1c binary is used by the 'regen' target below osmo-build-dep.sh asn1c aper-prefix +CONFIG="" +if [ "$WITH_MANUALS" = "1" ]; then + osmo-build-dep.sh osmo-gsm-manuals + CONFIG="--enable-manuals" +fi + set +x echo echo @@ -34,7 +41,7 @@ set -x autoreconf --install --force -./configure --enable-sanitize +./configure --enable-sanitize $CONFIG # Verify that checked-in asn1 code is identical to regenerated asn1 code PATH="$inst/bin:$PATH" $MAKE $PARALLEL_MAKE -C src regen @@ -55,6 +62,10 @@ || cat-testlogs.sh $MAKE distcheck \ || cat-testlogs.sh -$MAKE maintainer-clean +if [ "$WITH_MANUALS" = "1" ] && [ "$PUBLISH" = "1" ]; then + make -C "$base/doc/manuals" publish +fi + +$MAKE maintainer-clean osmo-clean-workspace.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/14991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ic7437daeab0b07d16fd71ca3881cb31bab7b1925 Gerrit-Change-Number: 14991 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 14:15:37 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Jul 2019 14:15:37 +0000 Subject: Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation In-Reply-To: References: Message-ID: Hello pespin, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 to look at the new patch set (#2). Change subject: master-builds: Publish osmo-hnbgw documentation ...................................................................... master-builds: Publish osmo-hnbgw documentation Requires: Ic7437daeab0b07d16fd71ca3881cb31bab7b1925 (osmo-iuh) Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/92/14992/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 Gerrit-Change-Number: 14992 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 14:36:15 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Jul 2019 14:36:15 +0000 Subject: Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation ...................................................................... Patch Set 2: Verified+1 Already updated jenkins and both build run fine. VTY reference is there as well: https://ftp.osmocom.org/docs/latest/osmohnbgw-vty-reference.pdf -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 Gerrit-Change-Number: 14992 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 14:36:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 14:36:17 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 14:36:17 +0000 Subject: Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file() Message-ID: keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Add media mode parameter to sdp_create_file() This enables call hold implemented by subsequent commits Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 --- M src/sdp.c M src/sdp.h M src/sip.c 3 files changed, 25 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/93/14993/1 diff --git a/src/sdp.c b/src/sdp.c index 17eb577..93e0c7f 100644 --- a/src/sdp.c +++ b/src/sdp.c @@ -163,16 +163,31 @@ return true; } -char *sdp_create_file(struct sip_call_leg *leg, struct call_leg *other) +char *sdp_create_file(struct sip_call_leg *leg, struct call_leg *other, sdp_mode_t mode) { struct in_addr net = { .s_addr = htonl(other->ip) }; char *fmtp_str = NULL, *sdp; + char *mode_attribute = NULL; leg->wanted_codec = app_media_name(other->payload_msg_type); if (strcmp(leg->wanted_codec, "AMR") == 0) fmtp_str = talloc_asprintf(leg, "a=fmtp:%d octet-align=1\r\n", other->payload_type); + switch (mode) { + case sdp_inactive: + mode_attribute = "a=inactive\r\n"; + break; + case sdp_sendrecv: + mode_attribute = "a=sendrecv\r\n"; + break; + case sdp_sendonly: + mode_attribute = "a=sendonly\r\n"; + break; + case sdp_recvonly: + mode_attribute = "a=recvonly\r\n"; + } + sdp = talloc_asprintf(leg, "v=0\r\n" "o=Osmocom 0 0 IN IP4 %s\r\n" @@ -181,12 +196,14 @@ "t=0 0\r\n" "m=audio %d RTP/AVP %d\r\n" "%s" - "a=rtpmap:%d %s/8000\r\n", + "a=rtpmap:%d %s/8000\r\n" + "%s", inet_ntoa(net), inet_ntoa(net), /* never use diff. addr! */ other->port, other->payload_type, fmtp_str ? fmtp_str : "", other->payload_type, - leg->wanted_codec); + leg->wanted_codec, + mode_attribute ? mode_attribute : ""); talloc_free(fmtp_str); return sdp; } diff --git a/src/sdp.h b/src/sdp.h index d716644..72ff6b7 100644 --- a/src/sdp.h +++ b/src/sdp.h @@ -1,6 +1,7 @@ #pragma once #include +#include #include @@ -10,4 +11,4 @@ bool sdp_screen_sdp(const sip_t *sip); bool sdp_extract_sdp(struct sip_call_leg *leg, const sip_t *sip, bool any_codec); -char *sdp_create_file(struct sip_call_leg *, struct call_leg *); +char *sdp_create_file(struct sip_call_leg *, struct call_leg *, sdp_mode_t mode); diff --git a/src/sip.c b/src/sip.c index adf20d8..21401c6 100644 --- a/src/sip.c +++ b/src/sip.c @@ -28,6 +28,7 @@ #include #include +#include #include @@ -385,7 +386,7 @@ return; } - sdp = sdp_create_file(leg, other); + sdp = sdp_create_file(leg, other, sdp_sendrecv); leg->state = SIP_CC_CONNECTED; nua_respond(leg->nua_handle, SIP_200_OK, @@ -425,7 +426,7 @@ called_num, agent->app->sip.remote_addr, agent->app->sip.remote_port); - char *sdp = sdp_create_file(leg, other); + char *sdp = sdp_create_file(leg, other, sdp_sendrecv); leg->state = SIP_CC_INITIAL; leg->dir = SIP_DIR_MT; -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 14:36:18 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 14:36:18 +0000 Subject: Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs Message-ID: keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 Change subject: Handle SIP re-INVITEs ...................................................................... Handle SIP re-INVITEs SIP end points can send periodic re-INVITES. Previous to this commit, the osmo-sip-connector would send a new call SETUP to the MSC for each re-INVITE. Add a function to find if we already handle this call based on the nua handle. Use this function to detect and respond with an ACK to re-INVITES. Add a function to extract the media mode from the SDP. In the case the re-INVITE has a=sendonly (HOLD) respond with a=recvonly Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed --- M src/sdp.c M src/sdp.h M src/sip.c 3 files changed, 86 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/94/14994/1 diff --git a/src/sdp.c b/src/sdp.c index 93e0c7f..d1d4777 100644 --- a/src/sdp.c +++ b/src/sdp.c @@ -32,6 +32,36 @@ #include +sdp_mode_t sdp_mode(const sip_t *sip) { + + const char *sdp_data; + sdp_parser_t *parser; + sdp_session_t *sdp; + + if (!sip->sip_payload || !sip->sip_payload->pl_data) { + LOGP(DSIP, LOGL_ERROR, "No SDP file\n"); + return false; + } + + sdp_data = sip->sip_payload->pl_data; + parser = sdp_parse(NULL, sdp_data, strlen(sdp_data), sdp_f_mode_0000); + if (!parser) { + LOGP(DSIP, LOGL_ERROR, "Failed to parse SDP\n"); + return false; + } + + sdp = sdp_session(parser); + if (!sdp) { + LOGP(DSIP, LOGL_ERROR, "No sdp session\n"); + sdp_parser_free(parser); + return false; + } + + if (!sdp->sdp_media || !sdp->sdp_media->m_mode) + return sdp_sendrecv; + return sdp->sdp_media->m_mode; +} + /* * We want to decide on the audio codec later but we need to see * if it is even including some of the supported ones. diff --git a/src/sdp.h b/src/sdp.h index 72ff6b7..80c6698 100644 --- a/src/sdp.h +++ b/src/sdp.h @@ -8,6 +8,7 @@ struct sip_call_leg; struct call_leg; +sdp_mode_t sdp_mode(const sip_t *sip); bool sdp_screen_sdp(const sip_t *sip); bool sdp_extract_sdp(struct sip_call_leg *leg, const sip_t *sip, bool any_codec); diff --git a/src/sip.c b/src/sip.c index 21401c6..b5f856a 100644 --- a/src/sip.c +++ b/src/sip.c @@ -41,6 +41,27 @@ static void sip_connect_call(struct call_leg *_leg); static void sip_dtmf_call(struct call_leg *_leg, int keypad); +/* Find a SIP Call leg by given nua_handle */ +static struct sip_call_leg *sip_find_leg(nua_handle_t *nh) +{ + struct call *call; + + llist_for_each_entry(call, &g_call_list, entry) { + if (call->initial && call->initial->type == CALL_TYPE_SIP) { + struct sip_call_leg *leg = (struct sip_call_leg *) call->initial; + if (leg->nua_handle == nh) + return leg; + } + if (call->remote && call->remote->type == CALL_TYPE_SIP) { + struct sip_call_leg *leg = (struct sip_call_leg *) call->remote; + if (leg->nua_handle == nh) + return leg; + } + } + + return NULL; +} + static void call_progress(struct sip_call_leg *leg, const sip_t *sip, int status) { struct call_leg *other = call_leg_other(&leg->base); @@ -149,6 +170,32 @@ talloc_strdup(leg, to)); } +static void sip_handle_reinvite(struct sip_call_leg *leg, nua_handle_t *nh, const sip_t *sip) { + + char *sdp = NULL; + + LOGP(DSIP, LOGL_NOTICE, "re-INVITE for call %s\n", sip->sip_call_id->i_id); + sdp_mode_t mode = sdp_mode(sip); + struct call_leg *other = call_leg_other(&leg->base); + if (mode == sdp_sendonly) { + LOGP(DSIP, LOGL_NOTICE, "SIP side puts call on HOLD\n"); + sdp = sdp_create_file(leg, other, sdp_recvonly); + // TODO: Tell osmo-bts to stop sending RTP ? + } else { + // Regular re-INVITE. Just ACK. + sdp = sdp_create_file(leg, other, sdp_sendrecv); + } + + LOGP(DSIP, LOGL_DEBUG, "Sending 200 response to re-INVITE for mode(%u)\n", mode); + nua_respond(nh, SIP_200_OK, + NUTAG_MEDIA_ENABLE(0), + SIPTAG_CONTENT_TYPE_STR("application/sdp"), + SIPTAG_PAYLOAD_STR(sdp), + TAG_END()); + talloc_free(sdp); + return; +} + /* Sofia SIP definitions come with error code numbers and strings, this * map allows us to reuse the existing definitions. * The map is in priority order. The first matching entry found @@ -270,10 +317,15 @@ if (other) other->release_call(other); } else if (event == nua_i_invite) { - /* new incoming leg */ + /* new incoming leg or re-INVITE */ - if (status == 100) - new_call((struct sip_agent *) magic, nh, sip); + if (status == 100) { + struct sip_call_leg *leg = sip_find_leg(nh); + if (leg) + sip_handle_reinvite(leg, nh, sip); + else + new_call((struct sip_agent *) magic, nh, sip); + } } else if (event == nua_i_cancel) { struct sip_call_leg *leg; struct call_leg *other; -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed Gerrit-Change-Number: 14994 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 14:36:18 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 14:36:18 +0000 Subject: Change in ...osmo-sip-connector[master]: Prepare to support MO Call HOLD Message-ID: keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 Change subject: Prepare to support MO Call HOLD ...................................................................... Prepare to support MO Call HOLD Add function pointers to the call_leg struct for call hold and retrieve. Add function to send re-INVITE to SIP side when MNCC side puts call on HOLD/RETRIEVES. Add MNCC/SIP CC_HOLD to call states. Change-Id: I2595626dfa50eb2f8e29a02540b708c9c1dce88c --- M src/call.c M src/call.h M src/sip.c 3 files changed, 55 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/95/14995/1 diff --git a/src/call.c b/src/call.c index 9be6b4d..67207e5 100644 --- a/src/call.c +++ b/src/call.c @@ -40,6 +40,7 @@ { MNCC_CC_INITIAL, "INITIAL" }, { MNCC_CC_PROCEEDING, "PROCEEDING" }, { MNCC_CC_CONNECTED, "CONNECTED" }, + { MNCC_CC_HOLD, "ON HOLD" }, { 0, NULL }, }; @@ -53,6 +54,7 @@ { SIP_CC_INITIAL, "INITIAL" }, { SIP_CC_DLG_CNFD, "CONFIRMED" }, { SIP_CC_CONNECTED, "CONNECTED" }, + { SIP_CC_HOLD, "ON HOLD" }, { 0, NULL }, }; diff --git a/src/call.h b/src/call.h index 65d1111..365b3eb 100644 --- a/src/call.h +++ b/src/call.h @@ -74,12 +74,24 @@ * A DTMF key was entered. Forward it. */ void (*dtmf)(struct call_leg *, int keypad); + + /** + * Call HOLD requested + */ + void (*hold_call)(struct call_leg *); + + /** + * Call HOLD ended + */ + void (*retrieve_call)(struct call_leg *); + }; enum sip_cc_state { SIP_CC_INITIAL, SIP_CC_DLG_CNFD, SIP_CC_CONNECTED, + SIP_CC_HOLD, }; enum sip_dir { @@ -110,6 +122,7 @@ MNCC_CC_INITIAL, MNCC_CC_PROCEEDING, /* skip delivered state */ MNCC_CC_CONNECTED, + MNCC_CC_HOLD, }; enum mncc_dir { diff --git a/src/sip.c b/src/sip.c index b5f856a..6507486 100644 --- a/src/sip.c +++ b/src/sip.c @@ -40,6 +40,9 @@ static void sip_ring_call(struct call_leg *_leg); static void sip_connect_call(struct call_leg *_leg); static void sip_dtmf_call(struct call_leg *_leg, int keypad); +static void sip_hold_call(struct call_leg *_leg); +static void sip_retrieve_call(struct call_leg *_leg); + /* Find a SIP Call leg by given nua_handle */ static struct sip_call_leg *sip_find_leg(nua_handle_t *nh) @@ -160,6 +163,8 @@ leg->base.ring_call = sip_ring_call; leg->base.connect_call = sip_connect_call; leg->base.dtmf = sip_dtmf_call; + leg->base.hold_call = sip_hold_call; + leg->base.retrieve_call = sip_retrieve_call; leg->agent = agent; leg->nua_handle = nh; nua_handle_bind(nh, leg); @@ -403,6 +408,7 @@ } break; case SIP_CC_CONNECTED: + case SIP_CC_HOLD: LOGP(DSIP, LOGL_NOTICE, "Ending leg(%p) in con\n", leg); nua_bye(leg->nua_handle, TAG_END()); break; @@ -465,6 +471,40 @@ talloc_free(buf); } +static void sip_hold_call(struct call_leg *_leg) +{ + struct sip_call_leg *leg; + struct call_leg *other_leg; + OSMO_ASSERT(_leg->type == CALL_TYPE_SIP); + leg = (struct sip_call_leg *) _leg; + other_leg = call_leg_other(&leg->base); + char *sdp = sdp_create_file(leg, other_leg, sdp_sendonly); + nua_invite(leg->nua_handle, + NUTAG_MEDIA_ENABLE(0), + SIPTAG_CONTENT_TYPE_STR("application/sdp"), + SIPTAG_PAYLOAD_STR(sdp), + TAG_END()); + talloc_free(sdp); + leg->state = SIP_CC_HOLD; +} + +static void sip_retrieve_call(struct call_leg *_leg) +{ + struct sip_call_leg *leg; + struct call_leg *other_leg; + OSMO_ASSERT(_leg->type == CALL_TYPE_SIP); + leg = (struct sip_call_leg *) _leg; + other_leg = call_leg_other(&leg->base); + char *sdp = sdp_create_file(leg, other_leg, sdp_sendrecv); + nua_invite(leg->nua_handle, + NUTAG_MEDIA_ENABLE(0), + SIPTAG_CONTENT_TYPE_STR("application/sdp"), + SIPTAG_PAYLOAD_STR(sdp), + TAG_END()); + talloc_free(sdp); + leg->state = SIP_CC_CONNECTED; +} + static int send_invite(struct sip_agent *agent, struct sip_call_leg *leg, const char *calling_num, const char *called_num) { -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I2595626dfa50eb2f8e29a02540b708c9c1dce88c Gerrit-Change-Number: 14995 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 14:36:18 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 14:36:18 +0000 Subject: Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE Message-ID: keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 Change subject: Add support for MNCC HOLD/RETRIEVE ...................................................................... Add support for MNCC HOLD/RETRIEVE Handle MO hold and retrieve and pass this to the SIP side. Handle the 200 from the SIP side in response to our HOLD-ing re-INVITE. With this commit we now handle MO hold and therefore also handle call-waiting and swapping. Change-Id: Ife7bdab20cde92b7ce550215bab28b36a0f302e9 --- M src/mncc.c M src/sip.c 2 files changed, 37 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/96/14996/1 diff --git a/src/mncc.c b/src/mncc.c index ab2bed6..3f93126 100644 --- a/src/mncc.c +++ b/src/mncc.c @@ -669,14 +669,39 @@ { const struct gsm_mncc *data; struct mncc_call_leg *leg; + struct call_leg *other_leg; leg = find_leg(conn, buf, rc, &data); if (!leg) return; LOGP(DMNCC, LOGL_DEBUG, - "leg(%u) is req hold. rejecting.\n", leg->callref); - mncc_send(leg->conn, MNCC_HOLD_REJ, leg->callref); + "leg(%u) is req hold.\n", leg->callref); + other_leg = call_leg_other(&leg->base); + other_leg->hold_call(other_leg); + mncc_send(leg->conn, MNCC_HOLD_CNF, leg->callref); + leg->state = MNCC_CC_HOLD; +} + +static void check_retrieve_ind(struct mncc_connection *conn, const char *buf, int rc) +{ + const struct gsm_mncc *data; + struct mncc_call_leg *leg; + struct call_leg *other_leg; + + leg = find_leg(conn, buf, rc, &data); + if (!leg) + return; + + LOGP(DMNCC, LOGL_DEBUG, + "leg(%u) is req unhold.\n", leg->callref); + other_leg = call_leg_other(&leg->base); + other_leg->retrieve_call(other_leg); + mncc_send(leg->conn, MNCC_RETRIEVE_CNF, leg->callref); + // In case of call waiting/swap, At this point we need to tell the BTS to send audio to + // the port of the original call + leg->state = MNCC_CC_CONNECTED; + send_rtp_connect(leg, other_leg); } static void check_stp_cnf(struct mncc_connection *conn, const char *buf, int rc) @@ -919,6 +944,9 @@ case MNCC_HOLD_IND: check_hold_ind(conn, buf, rc); break; + case MNCC_RETRIEVE_IND: + check_retrieve_ind(conn, buf, rc); + break; case MNCC_START_DTMF_IND: check_dtmf_start(conn, buf, rc); break; diff --git a/src/sip.c b/src/sip.c index 6507486..236c332 100644 --- a/src/sip.c +++ b/src/sip.c @@ -287,8 +287,13 @@ if (status == 180 || status == 183) call_progress(leg, sip, status); - else if (status == 200) - call_connect(leg, sip); + else if (status == 200) { + struct sip_call_leg *leg = sip_find_leg(nh); + if (leg) + nua_ack(leg->nua_handle, TAG_END()); + else + call_connect(leg, sip); + } else if (status >= 300) { struct call_leg *other = call_leg_other(&leg->base); -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ife7bdab20cde92b7ce550215bab28b36a0f302e9 Gerrit-Change-Number: 14996 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 14:37:05 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Jul 2019 14:37:05 +0000 Subject: Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation ...................................................................... Patch Set 2: > Patch Set 1: Code-Review+1 > > We should also set WITH_MANUALS=1 for osmo-iuh in gerrit-verifications.yml (either in same patch or as separate patch). Included in this patch, thanks. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 Gerrit-Change-Number: 14992 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 14:37:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 14:50:17 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 14:50:17 +0000 Subject: Change in ...osmo-sip-connector[master]: Add further logging. Message-ID: keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 Change subject: Add further logging. ...................................................................... Add further logging. Log the IP port, payload type for calls. Also log the SIP Call-ID, this help for correlation with SIP traces. Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b --- M src/mncc.c M src/sip.c 2 files changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/97/14997/1 diff --git a/src/mncc.c b/src/mncc.c index 3f93126..5bd8af4 100644 --- a/src/mncc.c +++ b/src/mncc.c @@ -188,6 +188,8 @@ * FIXME: mncc.payload_msg_type should already be compatible.. but * payload_type should be different.. */ + struct in_addr net = { .s_addr = other->ip }; + LOGP(DMNCC, LOGL_DEBUG, "SEND rtp_connect: IP=(%s) PORT=(%u)\n", inet_ntoa(net), mncc.port); rc = write(leg->conn->fd.fd, &mncc, sizeof(mncc)); if (rc != sizeof(mncc)) { LOGP(DMNCC, LOGL_ERROR, "Failed to send message leg(%u)\n", diff --git a/src/sip.c b/src/sip.c index 236c332..8f81a3f 100644 --- a/src/sip.c +++ b/src/sip.c @@ -98,7 +98,7 @@ return; } - LOGP(DSIP, LOGL_NOTICE, "leg(%p) is now connected.\n", leg); + LOGP(DSIP, LOGL_NOTICE, "leg(%p) is now connected(%s).\n", leg, sip->sip_call_id->i_id); leg->state = SIP_CC_CONNECTED; other->connect_call(other); nua_ack(leg->nua_handle, TAG_END()); @@ -111,7 +111,7 @@ struct sip_call_leg *leg; const char *from = NULL, *to = NULL; - LOGP(DSIP, LOGL_DEBUG, "Incoming call handle(%p)\n", nh); + LOGP(DSIP, LOGL_DEBUG, "Incoming call(%s) handle(%p)\n", sip->sip_call_id->i_id, nh); if (!sdp_screen_sdp(sip)) { LOGP(DSIP, LOGL_ERROR, "No supported codec.\n"); @@ -158,6 +158,11 @@ call_leg_release(&leg->base); return; } + struct in_addr net = { .s_addr = leg->base.ip }; + LOGP(DSIP, LOGL_DEBUG, "SDP Extracted: IP=(%s) PORT=(%u) PAYLOAD=(%u).\n", + inet_ntoa(net), + leg->base.port, + leg->base.payload_type); leg->base.release_call = sip_release_call; leg->base.ring_call = sip_ring_call; @@ -328,6 +333,7 @@ other->release_call(other); } else if (event == nua_i_invite) { /* new incoming leg or re-INVITE */ + LOGP(DSIP, LOGL_NOTICE, "Processing INVITE Call-ID: %s\n", sip->sip_call_id->i_id); if (status == 100) { struct sip_call_leg *leg = sip_find_leg(nh); -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b Gerrit-Change-Number: 14997 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 14:54:00 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 14:54:00 +0000 Subject: Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 Gerrit-Change-Number: 14992 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 14:54:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 14:57:16 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 14:57:16 +0000 Subject: Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c File src/sdp.c: https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c at 189 PS1, Line 189: } Just to make sure, no enum option missing? default? In that case, no need to initialize mode_attribute as NULL above. https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c at 206 PS1, Line 206: mode_attribute ? mode_attribute : ""); simply set mode_attriubte = "" in default case then. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 14:57:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:02:17 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 15:02:17 +0000 Subject: Change in ...osmo-msc[master]: add BSC/MSC neighbor VTY commands for inter-MSC HO In-Reply-To: References: Message-ID: neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/12446 ) Change subject: add BSC/MSC neighbor VTY commands for inter-MSC HO ...................................................................... Abandoned absorbed in other patches, already merged -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/12446 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia0dd08b087bfd4aa22e234917669d003150a4cd4 Gerrit-Change-Number: 12446 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling Gerrit-Assignee: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:04:05 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 15:04:05 +0000 Subject: Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file() In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c File src/sdp.c: https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c at 189 PS1, Line 189: } > Just to make sure, no enum option missing? default? In that case, no need to initialize mode_attribu [?] no, no enum option missing, otherwise the compiler would warn. https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c at 206 PS1, Line 206: mode_attribute ? mode_attribute : ""); > simply set mode_attriubte = "" in default case then. OK no problem.. just out of interest, how much could your comment here be considered a personal style? -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 15:04:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:04:07 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 15:04:07 +0000 Subject: Change in ...osmo-msc[master]: Log protocol for which transaction is allocated In-Reply-To: References: Message-ID: neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13420 ) Change subject: Log protocol for which transaction is allocated ...................................................................... Abandoned similar functionality implemented in other patch, already merged -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/13420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If4a5f3ecaec568b3f8d5a57d864184d7af2b95cc Gerrit-Change-Number: 13420 Gerrit-PatchSet: 2 Gerrit-Owner: Max Gerrit-Assignee: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-CC: laforge Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:05:15 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 15:05:15 +0000 Subject: Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs ...................................................................... Patch Set 1: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/14994/1/src/sdp.c File src/sdp.c: https://gerrit.osmocom.org/#/c/14994/1/src/sdp.c at 61 PS1, Line 61: return sdp_sendrecv; memleak of parser? https://gerrit.osmocom.org/#/c/14994/1/src/sdp.c at 62 PS1, Line 62: return sdp->sdp_media->m_mode; memleak of parser? https://gerrit.osmocom.org/#/c/14994/1/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14994/1/src/sip.c at 175 PS1, Line 175: char *sdp = NULL; No need to set it to NULL, it's always set. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed Gerrit-Change-Number: 14994 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 15:05:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:08:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 15:08:25 +0000 Subject: Change in ...osmo-sip-connector[master]: Prepare to support MO Call HOLD In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 ) Change subject: Prepare to support MO Call HOLD ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I2595626dfa50eb2f8e29a02540b708c9c1dce88c Gerrit-Change-Number: 14995 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 15:08:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:11:12 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 15:11:12 +0000 Subject: Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 ) Change subject: Add support for MNCC HOLD/RETRIEVE ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14996/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/14996/1/src/mncc.c at 681 PS1, Line 681: other_leg->hold_call(other_leg); Just wondering... cannot hold_call fail? in that case I'm not sure if MNCC_HOLD_CNF should be sent back. https://gerrit.osmocom.org/#/c/14996/1/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14996/1/src/sip.c at 291 PS1, Line 291: struct sip_call_leg *leg = sip_find_leg(nh); Wasn't this already added on a prior commit? -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ife7bdab20cde92b7ce550215bab28b36a0f302e9 Gerrit-Change-Number: 14996 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 15:11:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:12:59 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 15:12:59 +0000 Subject: Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file() In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 to look at the new patch set (#2). Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Add media mode parameter to sdp_create_file() This enables call hold implemented by subsequent commits Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 --- M src/sdp.c M src/sdp.h M src/sip.c 3 files changed, 28 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/93/14993/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:14:29 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 15:14:29 +0000 Subject: Change in ...osmo-sip-connector[master]: Add further logging. In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 ) Change subject: Add further logging. ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c at 191 PS1, Line 191: struct in_addr net = { .s_addr = other->ip }; Are you sure this is correct? or you need to use mncc.ip? https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c at 192 PS1, Line 192: LOGP(DMNCC, LOGL_DEBUG, "SEND rtp_connect: IP=(%s) PORT=(%u)\n", inet_ntoa(net), mncc.port); Better use inet_ntop(). https://gerrit.osmocom.org/#/c/14997/1/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14997/1/src/sip.c at 163 PS1, Line 163: inet_ntoa(net), Better use inet_ntop(). -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b Gerrit-Change-Number: 14997 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 15:14:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:14:43 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 15:14:43 +0000 Subject: Change in ...osmo-bsc[master]: WIP: bsc: timeslot_fsm: Set TS state as unused instead of broken on P... In-Reply-To: References: Message-ID: neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/11958 ) Change subject: WIP: bsc: timeslot_fsm: Set TS state as unused instead of broken on PDCH DEACT NACK ...................................................................... Abandoned inactivity timeout -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/11958 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I906e6123f40081b52c62bed1411fcd901981ae3d Gerrit-Change-Number: 11958 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Assignee: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-MessageType: abandon -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:19:16 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 15:19:16 +0000 Subject: Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c File src/sdp.c: https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c at 189 PS1, Line 189: } > no, no enum option missing, otherwise the compiler would warn. ^ That depends on compiler and version used (and flags used) :) https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c at 206 PS1, Line 206: mode_attribute ? mode_attribute : ""); > OK no problem.. [?] If you consider having a more efficient and simplified code to be my personal style, I'm fine with that! -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 15:19:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: keith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:19:53 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 15:19:53 +0000 Subject: Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 15:19:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:20:32 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 15:20:32 +0000 Subject: Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs In-Reply-To: References: Message-ID: Hello pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 to look at the new patch set (#3). Change subject: Handle SIP re-INVITEs ...................................................................... Handle SIP re-INVITEs SIP end points can send periodic re-INVITES. Previous to this commit, the osmo-sip-connector would send a new call SETUP to the MSC for each re-INVITE. Add a function to find if we already handle this call based on the nua handle. Use this function to detect and respond with an ACK to re-INVITES. Add a function to extract the media mode from the SDP. In the case the re-INVITE has a=sendonly (HOLD) respond with a=recvonly Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed --- M src/sdp.c M src/sdp.h M src/sip.c 3 files changed, 90 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/94/14994/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed Gerrit-Change-Number: 14994 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:22:14 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 15:22:14 +0000 Subject: Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file() In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c File src/sdp.c: https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c at 206 PS1, Line 206: mode_attribute ? mode_attribute : ""); > If you consider having a more efficient and simplified code to be my personal style, I'm fine with t [?] :-) OK.. I'm just kind of dumbstruck by the variety of coding and coding styles out there! It's hard to learn by example, when so much example is.er.. not so great. Happy to follow yours. Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 1 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 15:22:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Comment-In-Reply-To: keith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:28:21 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 15:28:21 +0000 Subject: Change in ...osmo-bsc[master]: add vty 'no neighbors' to remove all HO targets In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14768 ) Change subject: add vty 'no neighbors' to remove all HO targets ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c File src/osmo-bsc/neighbor_ident_vty.c: https://gerrit.osmocom.org/#/c/14768/1/src/osmo-bsc/neighbor_ident_vty.c at 416 PS1, Line 416: rc = gsm_bts_local_neighbor_del(bts, neigh_bts); I feel more comfortable with the while(), but if two reviewers insist, I can change it to llist_for_each_entry_safe(). Reasoning: I am pretty sure that each neighbor is listed only once, and always will. But assuming that implementations change, and that for some weird reason a neighbor could end up listed twice, then this gsm_bts_local_neighbor_del() should semantically remove more than one item from the list. llist_for_each_entry_safe() is only safe as long as one item gets deleted. That's why I feel more comfortable with a while() loop that always goes back to the start. I pretty much know that this situation does not apply for this particular list and it's unlikely to ever change so that this applies. But still the while() comes from a general mistrust of llist_for_each_entry_safe() where it is not directly and trivially clear for all eternity that at most one item will be removed per iteration. Here the llist_del() is hidden in another function which might change in implementation ... (not actually, but feels safer to assume that it might) ...that's my bikeshed reason to not change this -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8623ab581639e9f8af6a9ff1eca990518d1b1211 Gerrit-Change-Number: 14768 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Jul 2019 15:28:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:31:28 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 15:31:28 +0000 Subject: Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14994/3/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14994/3/src/sip.c at 185 PS3, Line 185: // Regular re-INVITE. Just ACK. BTW, reviewers: We should check the SDP in the reINVITE is acceptable, and maybe the remote wants to change media IP/ PORT. More is coming in subsequent commits. For now, this does not make it any worse. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed Gerrit-Change-Number: 14994 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 15:31:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:35:21 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 15:35:21 +0000 Subject: Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14994/3/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14994/3/src/sip.c at 175 PS3, Line 175: char *sdp = NULL; This NULL assignment is not needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed Gerrit-Change-Number: 14994 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 15:35:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 15:37:48 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 15:37:48 +0000 Subject: Change in ...osmo-trx[master]: Move inband-signaling-usb documentation to UserManual Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14998 Change subject: Move inband-signaling-usb documentation to UserManual ...................................................................... Move inband-signaling-usb documentation to UserManual Change-Id: I4d6ef1f54f3d6c5a73ce00dc4640bd698f96842b --- D Transceiver52M/inband-signaling-usb A doc/manuals/chapters/device-usrp-inband-signaling-usb.adoc M doc/manuals/chapters/trx-devices.adoc 3 files changed, 306 insertions(+), 314 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/98/14998/1 diff --git a/Transceiver52M/inband-signaling-usb b/Transceiver52M/inband-signaling-usb deleted file mode 100644 index 14f8347..0000000 --- a/Transceiver52M/inband-signaling-usb +++ /dev/null @@ -1,314 +0,0 @@ -This file specifies the format of USB packets used for in-band data -transmission and signaling on the USRP. All packets are 512-byte long, -and are transfered using USB "bulk" transfers. - -IN packets are sent towards the host. -OUT packets are sent away from the host. - -The layout is 32-bits wide. All data is transmitted in little-endian -format across the USB. - - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - |O|U|D|S|E| RSSI | Chan | mbz | Tag | Payload Len | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Timestamp | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | | - + + - | Payload | - . . - . . - . . - | | - + +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | ... | . - +-+-+-+-+-+-+-+ . - . . - . Padding . - . . - | | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - - - mbz Must be Zero: these bits must be zero in both IN and OUT packets. - - O Overrun Flag: set in an IN packet if an overrun condition was - detected. Must be zero in OUT packets. Overrun occurs when - the FPGA has data to transmit to the host and there is no - buffer space available. This generally indicates a problem on - the host. Either it is not keeping up, or it has configured - the FPGA to transmit data at a higher rate than the transport - (USB) can support. - - U Underrun Flag: set in an IN packet if an underrun condition - was detected. Must be zero in OUT packets. Underrun occurs - when the FPGA runs out of samples, and it's not between - bursts. See the "End of Burst flag" below. - - D Dropped Packet Flag: Set in an IN packet if the FPGA - discarded an OUT packet because its timestamp had already - passed. - - S Start of Burst Flag: Set in an OUT packet if the data is the - first segment of what is logically a continuous burst of data. - Must be zero in IN packets. - - E End of Burst Flag: Set in an OUT packet if the data is the - last segment of what is logically a continuous burst of data. - Must be zero in IN packets. Underruns are not reported - when the FPGA runs out of samples between bursts. - - - RSSI 6-bit Received Strength Signal Indicator: Must be zero in OUT - packets. In IN packets, indicates RSSI as reported by front end. - FIXME The format and interpretation are to be determined. - - Chan 5-bit logical channel number. Channel number 0x1f is reserved - for control information. See "Control Channel" below. Other - channels are "data channels." Each data channel is logically - independent of the others. A data channel payload field - contains a sequence of homogeneous samples. The format of the - samples is determined by the configuration associated with the - given channel. It is often the case that the payload field - contains 32-bit complex samples, each containing 16-bit real - and imaginary components. - - Tag 4-bit tag for matching IN packets with OUT packets. - [FIXME, write more...] - - Payload Len: 9-bit field that specifies the length of the payload - field in bytes. Must be in the range 0 to 504 inclusive. - - Timestamp: 32-bit timestamp. - On IN packets, the timestamp indicates the time at which the - first sample of the packet was produced by the A/D converter(s) - for that channel. On OUT packets, the timestamp specifies the - time at which the first sample in the packet should go out the - D/A converter(s) for that channel. If a packet reaches the - head of the transmit queue, and the current time is later than - the timestamp, an error is assumed to have occurred and the - packet is discarded. As a special case, the timestamp - 0xffffffff is interpreted as "Now". - - The time base is a free running 32-bit counter that is - incremented by the A/D sample-clock. - - Payload: Variable length field. Length is specified by the - Payload Len field. - - Padding: This field is 504 - Payload Len bytes long, and its content - is unspecified. This field pads the packet out to a constant - 512 bytes. - - - -"Data Channel" payload format: -------------------------------- - -If Chan != 0x1f, the packet is a "data packet" and the payload is a -sequence of homogeneous samples. The format of the samples is -determined by the configuration associated with the given channel. -It is often the case that the payload field contains 32-bit complex -samples, each containing 16-bit real and imaginary components. - - -"Control Channel" payload format: ---------------------------------- - -If Chan == 0x1f, the packet is a "control packet". The control channel -payload consists of a sequence of 0 or more sub-packets. - -Each sub-packet starts on a 32-bit boundary, and consists of an 8-bit -Opcode field, an 8-bit Length field, Length bytes of arguments, and 0, -1, 2 or 3 bytes of padding to align the tail of the sub-packet to -a 32-bit boundary. - -Control channel packets shall be processed at the head of the queue, -and shall observe the timestamp semantics described above. - - -General sub-packet format: --------------------------- - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-//-+-+-+-+-+-+-+-+ - | Opcode | Length | ... | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-//-+-+-+-+-+-+-+-+ - - -Specific sub-packet formats: ----------------------------- - - RID: 6-bit Request-ID. Copied from request sub-packet into corresponding - reply sub-packet. RID allows the host to match requests and replies. - - Reg Number: 10-bit Register Number. - - - -Ping Fixed Length: - - Opcode: OP_PING_FIXED - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Opcode | 2 | RID | Ping Value | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - - -Ping Fixed Length Reply: - - Opcode: OP_PING_FIXED_REPLY - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Opcode | 2 | RID | Ping Value | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - - -Write Register: - - Opcode: OP_WRITE_REG - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Opcode | 6 | mbz | Reg Number | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Register Value | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - - -Write Register Masked: - - Opcode: OP_WRITE_REG_MASKED - - REG[Num] = (REG[Num] & ~Mask) | (Value & Mask) - - That is, only the register bits that correspond to 1's in the - mask are written with the new value. - - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Opcode | 10 | mbz | Reg Number | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Register Value | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Mask Value | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - - -Read Register: - - Opcode: OP_READ_REG - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Opcode | 2 | RID | Reg Number | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - - -Read Register Reply: - - Opcode: OP_READ_REG_REPLY - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Opcode | 6 | RID | Reg Number | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Register Value | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - - -I2C Write: - - Opcode: OP_I2C_WRITE - I2C Addr: 7-bit I2C address - Data: The bytes to write to the I2C bus - Length: Length of Data + 2 - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Opcode | Length | mbz | I2C Addr | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Data ... . - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - - -I2C Read: - - Opcode: OP_I2C_READ - I2C Addr: 7-bit I2C address - Nbytes: Number of bytes to read from I2C bus - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Opcode | 3 | RID | mbz | I2C Addr | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Nbytes | unspecified padding | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - - -I2C Read Reply: - - Opcode: OP_I2C_READ_REPLY - I2C Addr: 7-bit I2C address - Data: Length - 2 bytes of data read from I2C bus. - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Opcode | Length | RID | mbz | I2C Addr | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Data ... . - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - - -SPI Write: - - Opcode: OP_SPI_WRITE - Enables: Which SPI enables to assert (mask) - Format: Specifies format of SPI data and Opt Header Bytes - Opt Header Bytes: 2-byte field containing optional Tx bytes; see Format - Data: The bytes to write to the SPI bus - Length: Length of Data + 6 - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Opcode | Length | mbz | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Enables | Format | Opt Header Bytes | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Data ... . - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - - -SPI Read: - - Opcode: OP_SPI_READ - Enables: Which SPI enables to assert (mask) - Format: Specifies format of SPI data and Opt Header Bytes - Opt Header Bytes: 2-byte field containing optional Tx bytes; see Format - Nbytes: Number of bytes to read from SPI bus. - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Opcode | 7 | RID | mbz | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Enables | Format | Opt Header Bytes | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Nbytes | unspecified padding | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - - -SPI Read Reply: - - Opcode: OP_SPI_READ_REPLY - Data: Length - 2 bytes of data read from SPI bus. - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Opcode | Length | RID | mbz | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Data ... . - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - - -Delay: - - Opcode: OP_DELAY - Ticks: 16-bit unsigned delay count - - Delay Ticks clock ticks before executing next operation. - - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - | Opcode | 2 | Ticks | - +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ - diff --git a/doc/manuals/chapters/device-usrp-inband-signaling-usb.adoc b/doc/manuals/chapters/device-usrp-inband-signaling-usb.adoc new file mode 100644 index 0000000..7a4352f --- /dev/null +++ b/doc/manuals/chapters/device-usrp-inband-signaling-usb.adoc @@ -0,0 +1,304 @@ +[[dev_usrp_inband_signaling_usb]] +==== USRP in-band USB protocol + +This section specifies the format of USB packets used for in-band data +transmission and signaling on the USRP. All packets are 512-byte long, +and are transfered using USB "bulk" transfers. + +IN packets are sent towards the host. +OUT packets are sent away from the host. + +The layout is 32-bits wide. All data is transmitted in little-endian +format across the USB. + +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +|O|U|D|S|E| RSSI | Chan | mbz | Tag | Payload Len | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Timestamp | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| | ++ + +| Payload | +. . +. . +. . +| | ++ +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| ... | . ++-+-+-+-+-+-+-+ . +. . +. Padding . +. . +| | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +---- + +mbz: Must be Zero:: +These bits must be zero in both IN and OUT packets. + +O: Overrun Flag:: +Set in an IN packet if an overrun condition was detected. Must be zero in OUT +packets. Overrun occurs when the FPGA has data to transmit to the host and there +is no buffer space available. This generally indicates a problem on the host. +Either it is not keeping up, or it has configured the FPGA to transmit data at a +higher rate than the transport (USB) can support. + +U: Underrun Flag:: +Set in an IN packet if an underrun condition was detected. Must be zero in OUT +packets. Underrun occurs when the FPGA runs out of samples, and it's not between +bursts. See the "End of Burst flag" below. + +D: Dropped Packet Flag:: +Set in an IN packet if the FPGA discarded an OUT packet because its timestamp +had already passed. + +S: Start of Burst Flag:: +Set in an OUT packet if the data is the first segment of what is logically a +continuous burst of data. Must be zero in IN packets. + +E: End of Burst Flag:: +Set in an OUT packet if the data is the last segment of what is logically a +continuous burst of data. Must be zero in IN packets. Underruns are not +reported when the FPGA runs out of samples between bursts. + +RSSI: 6-bit Received Strength Signal Indicator:: +Must be zero in OUT packets. In IN packets, indicates RSSI as reported by front +end. FIXME The format and interpretation are to be determined. + +Chan: 5-bit logical channel number:: +Channel number 0x1f is reserved for control information. See "Control Channel" +below. Other channels are "data channels". Each data channel is logically +independent of the others. A data channel payload field contains a sequence of +homogeneous samples. The format of the samples is determined by the +configuration associated with the given channel. It is often the case that the +payload field contains 32-bit complex samples, each containing 16-bit real and +imaginary components. + +Tag:: +4-bit tag for matching IN packets with OUT packets. +//FIXME, write more... + +Payload Len:: +9-bit field that specifies the length of the payload field in bytes. Must be in +the range 0 to 504 inclusive. + +Timestamp: 32-bit timestamp:: +On IN packets, the timestamp indicates the time at which the first sample of the +packet was produced by the A/D converter(s) for that channel. On OUT packets, +the timestamp specifies the time at which the first sample in the packet should +go out the D/A converter(s) for that channel. If a packet reaches the head of +the transmit queue, and the current time is later than the timestamp, an error +is assumed to have occurred and the packet is discarded. As a special case, the +timestamp 0xffffffff is interpreted as "Now". +The time base is a free running 32-bit counter that is incremented by the A/D +sample-clock. + +Payload:: +Variable length field Length is specified by the Payload Len field. + +Padding:: +This field is 504 - Payload Len bytes long, and its content is unspecified. +This field pads the packet out to a constant 512 bytes. + + +===== "Data Channel" payload format + +If `Chan != 0x1f`, the packet is a "data packet" and the payload is a sequence of +homogeneous samples. The format of the samples is determined by the +configuration associated with the given channel. It is often the case that the +payload field contains 32-bit complex samples, each containing 16-bit real and +imaginary components. + + +===== "Control Channel" payload format + +If `Chan == 0x1f`, the packet is a "control packet". The control channel payload +consists of a sequence of 0 or more sub-packets. + +Each sub-packet starts on a 32-bit boundary, and consists of an 8-bit Opcode +field, an 8-bit Length field, Length bytes of arguments, and 0, 1, 2 or 3 bytes +of padding to align the tail of the sub-packet to a 32-bit boundary. + +Control channel packets shall be processed at the head of the queue, and shall +observe the timestamp semantics described above. + + +===== General sub-packet format + +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-//-+-+-+-+-+-+-+-+ +| Opcode | Length | ... | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-//-+-+-+-+-+-+-+-+ +---- + +===== Specific sub-packet formats + +RID: 6-bit Request-ID:: +Copied from request sub-packet into corresponding reply sub-packet. RID allows +the host to match requests and replies. + +Reg Number:: +10-bit Register Number. + +Ping Fixed Length:: + +* Opcode: OP_PING_FIXED +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Opcode | 2 | RID | Ping Value | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +---- + +Ping Fixed Length Reply:: + +* Opcode: OP_PING_FIXED_REPLY +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Opcode | 2 | RID | Ping Value | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +---- + +Write Register:: + +* Opcode: OP_WRITE_REG +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Opcode | 6 | mbz | Reg Number | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Register Value | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +---- + +Write Register Masked:: +Only the register bits that correspond to 1's in the mask are written +with the new value. `REG[Num] = (REG[Num] & ~Mask) | (Value & Mask)` + +* Opcode: OP_WRITE_REG_MASKED +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Opcode | 10 | mbz | Reg Number | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Register Value | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Mask Value | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +---- + +Read Register:: + +* Opcode: OP_READ_REG +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Opcode | 2 | RID | Reg Number | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +---- + +Read Register Reply:: + +* Opcode: OP_READ_REG_REPLY +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Opcode | 6 | RID | Reg Number | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Register Value | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +---- + +I2C Write:: + +* Opcode: OP_I2C_WRITE +* I2C Addr: 7-bit I2C address +* Data: The bytes to write to the I2C bus +* Length: Length of Data + 2 +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Opcode | Length | mbz | I2C Addr | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Data ... . ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +---- + +I2C Read:: + +* Opcode: OP_I2C_READ +* I2C Addr: 7-bit I2C address +* Nbytes: Number of bytes to read from I2C bus +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Opcode | 3 | RID | mbz | I2C Addr | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Nbytes | unspecified padding | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +---- + +I2C Read Reply:: + +* Opcode: OP_I2C_READ_REPLY +* I2C Addr: 7-bit I2C address +* Data: Length - 2 bytes of data read from I2C bus. +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Opcode | Length | RID | mbz | I2C Addr | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Data ... . ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +---- + +SPI Write:: + +* Opcode: OP_SPI_WRITE +* Enables: Which SPI enables to assert (mask) +* Format: Specifies format of SPI data and Opt Header Bytes +* Opt Header Bytes: 2-byte field containing optional Tx bytes; see Format +* Data: The bytes to write to the SPI bus +* Length: Length of Data + 6 +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Opcode | Length | mbz | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Enables | Format | Opt Header Bytes | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Data ... . ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +---- + +SPI Read:: + +* Opcode: OP_SPI_READ +* Enables: Which SPI enables to assert (mask) +* Format: Specifies format of SPI data and Opt Header Bytes +* Opt Header Bytes: 2-byte field containing optional Tx bytes; see Format +* Nbytes: Number of bytes to read from SPI bus. +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Opcode | 7 | RID | mbz | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Enables | Format | Opt Header Bytes | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Nbytes | unspecified padding | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +---- + +SPI Read Reply:: + +* Opcode: OP_SPI_READ_REPLY +* Data: Length - 2 bytes of data read from SPI bus. +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Opcode | Length | RID | mbz | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Data ... . ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +---- + +Delay:: + +* Opcode: OP_DELAY +* Ticks: 16-bit unsigned delay count +* Delay Ticks clock ticks before executing next operation. +---- ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +| Opcode | 2 | Ticks | ++-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ +---- diff --git a/doc/manuals/chapters/trx-devices.adoc b/doc/manuals/chapters/trx-devices.adoc index 10c8529..3c21e59 100644 --- a/doc/manuals/chapters/trx-devices.adoc +++ b/doc/manuals/chapters/trx-devices.adoc @@ -29,6 +29,8 @@ The binary _osmo-trx-usrp1_ is used to drive this device, see <>. +include::./device-usrp-inband-signaling-usb.adoc[] + [[dev_ettus_b200]] === Ettus B200 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4d6ef1f54f3d6c5a73ce00dc4640bd698f96842b Gerrit-Change-Number: 14998 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:03:43 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 16:03:43 +0000 Subject: Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file() In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14993/2/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14993/2/src/sip.c at 389 PS2, Line 389: sdp = sdp_create_file(leg, other, sdp_sendrecv); before, this would send no "a=sendrecv", now it always does. There's two ways we can go here: a) keep the SIP headers unchanged, only send additional 'a=...' where new behavior is implemented. i.e. in this patch keep the exact old behavior; but how? Unfortunately sdp_mode_t has no "none" kind of enum value. We could somehow define -1 as "do not add any 'a=' attribute"? Or maybe add our own mode enum?? b) accept that we now always have an explicit "a=sendrecv" (or other mode) in all SIP headers. Then this should be made clear in the commit log message. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Tue, 30 Jul 2019 16:03:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:06:17 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 16:06:17 +0000 Subject: Change in ...osmo-trx[master]: Move matlab files under utils/matlab Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14999 Change subject: Move matlab files under utils/matlab ...................................................................... Move matlab files under utils/matlab Change-Id: I15b687fbf436d662b264cb00f72b367ccd64b962 --- R utils/matlab/laurent.m R utils/matlab/pulseApproximate.m 2 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/99/14999/1 diff --git a/Transceiver52M/laurent.m b/utils/matlab/laurent.m similarity index 100% rename from Transceiver52M/laurent.m rename to utils/matlab/laurent.m diff --git a/Transceiver52M/pulseApproximate.m b/utils/matlab/pulseApproximate.m similarity index 100% rename from Transceiver52M/pulseApproximate.m rename to utils/matlab/pulseApproximate.m -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14999 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I15b687fbf436d662b264cb00f72b367ccd64b962 Gerrit-Change-Number: 14999 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:06:18 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 16:06:18 +0000 Subject: Change in ...osmo-trx[master]: Move Transceiver52/README to UserManual Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15000 Change subject: Move Transceiver52/README to UserManual ...................................................................... Move Transceiver52/README to UserManual Change-Id: Ib5a56cfe0c27d027bc0c60abda89e646a80849de --- M Transceiver52M/Makefile.am D Transceiver52M/README M doc/manuals/chapters/trx-backends.adoc 3 files changed, 27 insertions(+), 37 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/00/15000/1 diff --git a/Transceiver52M/Makefile.am b/Transceiver52M/Makefile.am index 791c586..f039e3f 100644 --- a/Transceiver52M/Makefile.am +++ b/Transceiver52M/Makefile.am @@ -33,8 +33,6 @@ dist_rev2_DATA = std_inband.rbf dist_rev4_DATA = std_inband.rbf -EXTRA_DIST = README - noinst_LTLIBRARIES = libtransceiver_common.la COMMON_SOURCES = \ diff --git a/Transceiver52M/README b/Transceiver52M/README deleted file mode 100644 index 491693c..0000000 --- a/Transceiver52M/README +++ /dev/null @@ -1,35 +0,0 @@ -The Transceiver - -The transceiver consists of three modules: - --- transceiver - --- radioInterface - --- USRPDevice - -The USRPDevice module is basically a driver that reads/writes -packets to a USRP with two RFX900 daughterboards, board -A is the Tx chain and board B is the Rx chain. - -The radioInterface module is basically an interface b/w the -transceiver and the USRP. It operates the basestation clock -based upon the sample count of received USRP samples. Packets -from the USRP are queued and segmented into GSM bursts that are -passed up to the transceiver; bursts from the transceiver are -passed down to the USRP. - -The transceiver basically operates "layer 0" of the GSM stack, -performing the modulation, detection, and demodulation of GSM -bursts. It communicates with the GSM stack via three UDP sockets, -one socket for data, one for control messages, and one socket to -pass clocking information. The transceiver contains a priority -queue to sort to-be-transmitted bursts, and a filler table to fill -in timeslots that do not have bursts in the priority queue. The -transceiver tries to stay ahead of the basestation clock, adapting -its latency when underruns are reported by the radioInterface/USRP. -Received bursts (from the radioInterface) pass through a simple -energy detector, a RACH or midamble correlator, and a DFE-based demodulator. - -NOTE: There's a SWLOOPBACK #define statement, where the USRP is replaced -with a memory buffer. In this mode, data written to the USRP is actually stored -in a buffer, and read commands to the USRP simply pull data from this buffer. -This was very useful in early testing, and still may be useful in testing basic -Transceiver and radioInterface functionality. diff --git a/doc/manuals/chapters/trx-backends.adoc b/doc/manuals/chapters/trx-backends.adoc index 8829fa6..fb1e960 100644 --- a/doc/manuals/chapters/trx-backends.adoc +++ b/doc/manuals/chapters/trx-backends.adoc @@ -44,3 +44,30 @@ Related code can be found in the _Transceiver52M/device/usrp1/_ directory in _osmo-trx.git_. + +The USRPDevice module is basically a driver that reads/writes packets to a USRP +with two RFX900 daughterboards, board A is the Tx chain and board B is the Rx +chain. + +The `radioInterface` module is basically an interface between the transceiver +and the USRP. It operates the basestation clock based upon the sample count of +received USRP samples. Packets from the USRP are queued and segmented into GSM +bursts that are passed up to the transceiver; bursts from the transceiver are +passed down to the USRP. + +The transceiver basically operates "layer 0" of the GSM stack, performing the +modulation, detection, and demodulation of GSM bursts. It communicates with the +GSM stack via three UDP sockets, one socket for data, one for control messages, +and one socket to pass clocking information. The transceiver contains a priority +queue to sort to-be-transmitted bursts, and a filler table to fill in timeslots +that do not have bursts in the priority queue. The transceiver tries to stay +ahead of the basestation clock, adapting its latency when underruns are reported +by the radioInterface/USRP. Received bursts (from the radioInterface) pass +through a simple energy detector, a RACH or midamble correlator, and a DFE-based +demodulator. + +NOTE: There's a `SWLOOPBACK` #define statement, where the USRP is replaced +with a memory buffer. In this mode, data written to the USRP is actually stored +in a buffer, and read commands to the USRP simply pull data from this buffer. +This was very useful in early testing, and still may be useful in testing basic +Transceiver and radioInterface functionality. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15000 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib5a56cfe0c27d027bc0c60abda89e646a80849de Gerrit-Change-Number: 15000 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:06:18 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 16:06:18 +0000 Subject: Change in ...osmo-trx[master]: Move README.DFEsymbolspaced to utils/matlab Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15001 Change subject: Move README.DFEsymbolspaced to utils/matlab ...................................................................... Move README.DFEsymbolspaced to utils/matlab Change-Id: Icccc18688ee54e669cf3452b08747b3509042fa2 --- R utils/matlab/README.DFEsymbolspaced 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/01/15001/1 diff --git a/Transceiver52M/README.DFEsymbolspaced b/utils/matlab/README.DFEsymbolspaced similarity index 100% rename from Transceiver52M/README.DFEsymbolspaced rename to utils/matlab/README.DFEsymbolspaced -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Icccc18688ee54e669cf3452b08747b3509042fa2 Gerrit-Change-Number: 15001 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:06:18 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 16:06:18 +0000 Subject: Change in ...osmo-trx[master]: Move std_inband.rbf under device/usrp1/ dir Message-ID: pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15002 Change subject: Move std_inband.rbf under device/usrp1/ dir ...................................................................... Move std_inband.rbf under device/usrp1/ dir This file is only used by USRP1, so let's move it there and avoid processing it in Makefiles if build for USRP1 is not requested at configure time. Change-Id: Ibb40ba487581e76d2ae3e8a420d631670f876cf0 --- M Transceiver52M/Makefile.am M Transceiver52M/device/usrp1/Makefile.am R Transceiver52M/device/usrp1/std_inband.rbf M debian/copyright 4 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/02/15002/1 diff --git a/Transceiver52M/Makefile.am b/Transceiver52M/Makefile.am index f039e3f..ade4e30 100644 --- a/Transceiver52M/Makefile.am +++ b/Transceiver52M/Makefile.am @@ -27,12 +27,6 @@ AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) AM_CFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -rev2dir = $(datadir)/usrp/rev2 -rev4dir = $(datadir)/usrp/rev4 - -dist_rev2_DATA = std_inband.rbf -dist_rev4_DATA = std_inband.rbf - noinst_LTLIBRARIES = libtransceiver_common.la COMMON_SOURCES = \ diff --git a/Transceiver52M/device/usrp1/Makefile.am b/Transceiver52M/device/usrp1/Makefile.am index 5078934..24760f7 100644 --- a/Transceiver52M/device/usrp1/Makefile.am +++ b/Transceiver52M/device/usrp1/Makefile.am @@ -3,6 +3,12 @@ AM_CPPFLAGS = -Wall $(STD_DEFINES_AND_INCLUDES) -I${srcdir}/../common AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(USRP_CFLAGS) +rev2dir = $(datadir)/usrp/rev2 +rev4dir = $(datadir)/usrp/rev4 + +dist_rev2_DATA = std_inband.rbf +dist_rev4_DATA = std_inband.rbf + noinst_HEADERS = USRPDevice.h noinst_LTLIBRARIES = libdevice.la diff --git a/Transceiver52M/std_inband.rbf b/Transceiver52M/device/usrp1/std_inband.rbf similarity index 100% rename from Transceiver52M/std_inband.rbf rename to Transceiver52M/device/usrp1/std_inband.rbf Binary files differ diff --git a/debian/copyright b/debian/copyright index d8db465..19926cd 100644 --- a/debian/copyright +++ b/debian/copyright @@ -1,7 +1,7 @@ Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ Upstream-Name: OsmoTRX Source: http://cgit.osmocom.org/osmo-trx/ -Files-Excluded: Transceiver52M/std_inband.rbf +Files-Excluded: Transceiver52M/device/usrp1/std_inband.rbf Files: * Copyright: 2008-2013 Free Software Foundation -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ibb40ba487581e76d2ae3e8a420d631670f876cf0 Gerrit-Change-Number: 15002 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:15:05 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 16:15:05 +0000 Subject: Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file() In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14993/2/src/sdp.c File src/sdp.c: https://gerrit.osmocom.org/#/c/14993/2/src/sdp.c at 191 PS2, Line 191: mode_attribute = ""; (I'm not sure why, but at least by convention) end each case in 'break;' BTW, there is no other enum value, is there? If it is never to be used, we might as well OSMO_ASSERT(false) here, to make it obvious that the code path is never used. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Tue, 30 Jul 2019 16:15:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:22:00 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 16:22:00 +0000 Subject: Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs ...................................................................... Patch Set 3: Code-Review+1 (3 comments) https://gerrit.osmocom.org/#/c/14994/3/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14994/3/src/sip.c at 183 PS3, Line 183: // TODO: Tell osmo-bts to stop sending RTP ? you mean tell osmo-msc to tell osmo-bsc to tell osmo-bts to stop sending rtp? is such in the specs? https://gerrit.osmocom.org/#/c/14994/3/src/sip.c at 185 PS3, Line 185: // Regular re-INVITE. Just ACK. > BTW, reviewers: [?] sounds like a good thing to put in an in-code comment. BTW, I personally prefer '//' comments, but osmocom code style wants us to always use '/* ... */' comments. https://gerrit.osmocom.org/#/c/14994/3/src/sip.c at 189 PS3, Line 189: LOGP(DSIP, LOGL_DEBUG, "Sending 200 response to re-INVITE for mode(%u)\n", mode); (looks like we could use a value_string array translating the modes to human-readable strings...) -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed Gerrit-Change-Number: 14994 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 16:22:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: keith Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:26:59 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 16:26:59 +0000 Subject: Change in ...osmo-sip-connector[master]: Prepare to support MO Call HOLD In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 ) Change subject: Prepare to support MO Call HOLD ...................................................................... Patch Set 3: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/14995/3/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14995/3/src/sip.c at 481 PS3, Line 481: char *sdp = sdp_create_file(leg, other_leg, sdp_sendonly); (I know, but osmocom style would require declaring the char* sdp at the top.) https://gerrit.osmocom.org/#/c/14995/3/src/sip.c at 491 PS3, Line 491: static void sip_retrieve_call(struct call_leg *_leg) (this is mostly code dup from above, but ok) -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I2595626dfa50eb2f8e29a02540b708c9c1dce88c Gerrit-Change-Number: 14995 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 16:26:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:30:42 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 16:30:42 +0000 Subject: Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 ) Change subject: Add support for MNCC HOLD/RETRIEVE ...................................................................... Patch Set 3: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/14996/3/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/14996/3/src/mncc.c at 697 PS3, Line 697: "leg(%u) is req unhold.\n", leg->callref); reason to call "retrieve" "unhold" all of a sudden? funny: German word "der Unhold" https://dict.leo.org/german-english/der+Unhold https://gerrit.osmocom.org/#/c/14996/3/src/mncc.c at 702 PS3, Line 702: // the port of the original call /* ... */ -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ife7bdab20cde92b7ce550215bab28b36a0f302e9 Gerrit-Change-Number: 14996 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 16:30:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:33:11 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Jul 2019 16:33:11 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 ) Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc at 257 PS2, Line 257: express that in centiBels > I think this part needs to be corrected, because "the ideal training sequence can be compared ... [?] This is nit-picking now, sorry...but "can be compared" reads strange here. '[...] "ideal" training sequence is compared to the actual training sequence and the result expressed in centiBels.' ? -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 Gerrit-Change-Number: 14940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-Comment-Date: Tue, 30 Jul 2019 16:33:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:37:16 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 16:37:16 +0000 Subject: Change in ...osmo-sip-connector[master]: Add further logging. In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 ) Change subject: Add further logging. ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b Gerrit-Change-Number: 14997 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 16:37:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:38:16 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 16:38:16 +0000 Subject: Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 Gerrit-Change-Number: 14992 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 16:38:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:38:21 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 16:38:21 +0000 Subject: Change in ...osmo-ci[master]: master-builds: Publish osmo-hnbgw documentation In-Reply-To: References: Message-ID: neels has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ci/+/14992 ) Change subject: master-builds: Publish osmo-hnbgw documentation ...................................................................... master-builds: Publish osmo-hnbgw documentation Requires: Ic7437daeab0b07d16fd71ca3881cb31bab7b1925 (osmo-iuh) Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: daniel: Verified pespin: Looks good to me, but someone else must approve neels: Looks good to me, approved diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index a696d86..0b983dd 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -141,7 +141,8 @@ - osmo-hlr: cmd: WITH_MANUALS=1 ./contrib/jenkins.sh - - osmo-iuh + - osmo-iuh: + cmd: WITH_MANUALS=1 ./contrib/jenkins.sh - osmo-mgw: concurrent: true diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 373e975..fc5744b 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -227,6 +227,7 @@ cmd: WITH_MANUALS=1 PUBLISH=1 ./contrib/jenkins.sh - osmo-iuh: + cmd: WITH_MANUALS=1 PUBLISH=1 ./contrib/jenkins.sh # Full triggers would be: # trigger: master-osmo-msc, master-osmo-sgsn # Optimized: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/14992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia1be4ef79a1089d7af582acb63eb3afa5a60f4f3 Gerrit-Change-Number: 14992 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:40:00 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 16:40:00 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 ) Change subject: vty/vty.c: the command buffer can be accessed directly ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39 Gerrit-Change-Number: 14975 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Tue, 30 Jul 2019 16:40:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:41:31 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 16:41:31 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c Gerrit-Change-Number: 14972 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 16:41:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:45:10 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 16:45:10 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 ) Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc at 257 PS2, Line 257: express that in centiBels > This is nit-picking now, sorry...but "can be compared" reads strange here. [?] I hate you all so much! -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 Gerrit-Change-Number: 14940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-Comment-Date: Tue, 30 Jul 2019 16:45:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:46:46 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 16:46:46 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT In-Reply-To: References: Message-ID: Hello fixeria, Vadim Yanitskiy, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 to look at the new patch set (#4). Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT ...................................................................... common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 --- M common/chapters/trx_if.adoc 1 file changed, 140 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/40/14940/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 Gerrit-Change-Number: 14940 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: daniel Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:47:46 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 16:47:46 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 ) Change subject: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14973/3/src/vty/vty.c File src/vty/vty.c: https://gerrit.osmocom.org/#/c/14973/3/src/vty/vty.c at 1420 PS3, Line 1420: vty->buf[vty->length] = '\0'; While this might be correct, I wonder if there is a better place for this. Usually I would expect stuff written to vty->buf and some range checks and assignment to vty->length right before this. Reading this here seems out of context: I don't see any vty->buf or vty->length used in this function. Where is the vty->buf filled with vty->length nr of characters? If there is no single place like that, maybe it would make sense to put this nul termination into vty_execute()? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82f774ad18d0e555eb8f3590a519946d9c583c78 Gerrit-Change-Number: 14973 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Tue, 30 Jul 2019 16:47:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 16:57:53 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 16:57:53 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: log received commands from telnet interface In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14974 ) Change subject: vty/vty.c: log received commands from telnet interface ...................................................................... Patch Set 3: I think this is a good idea, but causes unit tests to get unexpected log output. Also it changes the application's user interaction behavior just by using a different libosmocore version, which we should avoid. I think you need to solve this by adding a flag that keeps VTY command logging disabled by default, so that all the unit tests that work with both VTY and log output remain unchanged and keep passing. This could either be a boolean flag that the main() scope of each application sets to true in C, and/or this could be set to true by an actual vty config item. An example for such a flag would be osmo_fsm_term_safely(), e.g. set to true in msc_main.c, but off by default to not cause inadvertent behavioral changes from a new libosmocore version. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f6639f6ebc3e8f8df50ef48538df94285b759fd Gerrit-Change-Number: 14974 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Tue, 30 Jul 2019 16:57:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 17:01:12 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 17:01:12 +0000 Subject: Change in ...osmo-hlr[master]: build: fix mess with 'db_test_SOURCES' and 'db_test_LDADD' In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14964 ) Change subject: build: fix mess with 'db_test_SOURCES' and 'db_test_LDADD' ...................................................................... Patch Set 1: Code-Review+2 very interesting -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib2e436ed91d9b7551dc5b205329d468c2b0ced04 Gerrit-Change-Number: 14964 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 17:01:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 17:04:13 2019 From: gerrit-no-reply at lists.osmocom.org (neels) Date: Tue, 30 Jul 2019 17:04:13 +0000 Subject: Change in ...osmo-hlr[master]: src/db.c: integrate SQLite3 with talloc allocator In-Reply-To: References: Message-ID: neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14939 ) Change subject: src/db.c: integrate SQLite3 with talloc allocator ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14939/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14939/3//COMMIT_MSG at 34 PS3, Line 34: I've noticed a huge difference in heap usage footprint compared to difference in what way? which one is smaller? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icfe67ed0f063b63e6794f9516da3003d01cf20a7 Gerrit-Change-Number: 14939 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 17:04:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 17:14:20 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 17:14:20 +0000 Subject: Change in ...osmo-hlr[master]: src/db.c: integrate SQLite3 with talloc allocator In-Reply-To: References: Message-ID: Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14939 ) Change subject: src/db.c: integrate SQLite3 with talloc allocator ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14939/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14939/3//COMMIT_MSG at 34 PS3, Line 34: I've noticed a huge difference in heap usage footprint compared to > difference in what way? which one is smaller? It was in 2018 when I was trying to debug this odd bug. Basically I added a debug printf() to each (de|re|_)allocation wrapper. I don't remember which one was smaller, but with recent SQLite3 versions I did not notice any difference comparing the footprints of both malloc() and talloc(). What's even more interesting is that an old SQLite3 (e.g. 3.8.2) does pass 'make check' just fine... -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icfe67ed0f063b63e6794f9516da3003d01cf20a7 Gerrit-Change-Number: 14939 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 17:14:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 17:15:17 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 17:15:17 +0000 Subject: Change in ...osmo-hlr[master]: build: fix mess with 'db_test_SOURCES' and 'db_test_LDADD' In-Reply-To: References: Message-ID: Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14964 ) Change subject: build: fix mess with 'db_test_SOURCES' and 'db_test_LDADD' ...................................................................... build: fix mess with 'db_test_SOURCES' and 'db_test_LDADD' Somehow both 'db_test_SOURCES' and 'db_test_LDADD' ended up in 'src/Makefile.am'. This causes automake / autoconf to complain. Let's get rid of both useless declarations. Furthermore, the actual 'db_test_LDADD' in 'tests/Makefile.am' contained references to the source files from '$(top_srcdir)'. Most likely, the original intention was to depend on the object files in '$(top_builddir)'. Let's also fix this. Change-Id: Ib2e436ed91d9b7551dc5b205329d468c2b0ced04 --- M src/Makefile.am M tests/db/Makefile.am 2 files changed, 4 insertions(+), 19 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/Makefile.am b/src/Makefile.am index 7ee019f..131b44f 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -87,21 +87,6 @@ $(SQLITE3_LIBS) \ $(NULL) -db_test_SOURCES = \ - auc.c \ - db.c \ - db_auc.c \ - db_test.c \ - logging.c \ - rand_fake.c \ - $(NULL) - -db_test_LDADD = \ - $(LIBOSMOCORE_LIBS) \ - $(LIBOSMOGSM_LIBS) \ - $(SQLITE3_LIBS) \ - $(NULL) - osmo_euse_demo_SOURCES = \ osmo-euse-demo.c \ $(NULL) diff --git a/tests/db/Makefile.am b/tests/db/Makefile.am index afda5be..fa925f8 100644 --- a/tests/db/Makefile.am +++ b/tests/db/Makefile.am @@ -26,10 +26,10 @@ $(NULL) db_test_LDADD = \ - $(top_srcdir)/src/db.c \ - $(top_srcdir)/src/db_hlr.c \ - $(top_srcdir)/src/db_auc.c \ - $(top_srcdir)/src/logging.c \ + $(top_builddir)/src/logging.o \ + $(top_builddir)/src/db_auc.o \ + $(top_builddir)/src/db_hlr.o \ + $(top_builddir)/src/db.o \ $(LIBOSMOCORE_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(LIBOSMOABIS_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14964 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib2e436ed91d9b7551dc5b205329d468c2b0ced04 Gerrit-Change-Number: 14964 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 17:15:18 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 17:15:18 +0000 Subject: Change in ...osmo-hlr[master]: tests/db_test: close the database when test is finished In-Reply-To: References: Message-ID: Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14965 ) Change subject: tests/db_test: close the database when test is finished ...................................................................... tests/db_test: close the database when test is finished Change-Id: I96fedf9181e89e4d68815b04f494a9c2ecc0e057 --- M tests/db/db_test.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/tests/db/db_test.c b/tests/db/db_test.c index cc299bf..91b32ea 100644 --- a/tests/db/db_test.c +++ b/tests/db/db_test.c @@ -979,6 +979,7 @@ test_subscr_sqn(); printf("Done\n"); + db_close(dbc); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14965 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I96fedf9181e89e4d68815b04f494a9c2ecc0e057 Gerrit-Change-Number: 14965 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 17:15:19 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 17:15:19 +0000 Subject: Change in ...osmo-hlr[master]: src/db.c: integrate SQLite3 with talloc allocator In-Reply-To: References: Message-ID: Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14939 ) Change subject: src/db.c: integrate SQLite3 with talloc allocator ...................................................................... src/db.c: integrate SQLite3 with talloc allocator This change introduces an optional feature that allows to make SQLite3 use talloc for all internal allocations. This would facilitate finding memleaks. OsmoHLR needs to be configured with '--enable-sqlite-talloc'. full talloc report on 'OsmoHLR' (total 292168 bytes in 449 blocks) struct osmo_gsup_server contains 162 bytes in 3 blocks (ref 0) ... struct db_context contains 288407 bytes in 420 blocks (ref 0) hlr.db contains 7 bytes in 1 blocks (ref 0) SQLite3 contains 288192 bytes in 418 blocks (ref 0) db.c:95 contains 48 bytes in 1 blocks (ref 0) db.c:95 contains 2 bytes in 1 blocks (ref 0) ... Unfortunately, old SQLite3 versions (such as 3.8.2) run out of memory when trying to initialize a new database: DDB ERROR db.c:88 (7) statement aborts at 3: [] DDB ERROR db.c:420 Unable to set Write-Ahead Logging: out of memory DDB ERROR db.c:88 (7) statement aborts at 3: [] DDB ERROR db.c:238 Unable to prepare SQL statement 'SELECT name FROM sqlite_master WHERE type='table' AND name=?' ... I've noticed a huge difference in heap usage footprint compared to generic malloc. At the same time, the recent versions (at least 3.24.0), work just fine. Change-Id: Icfe67ed0f063b63e6794f9516da3003d01cf20a7 --- M configure.ac M src/Makefile.am M src/db.c M src/db.h A src/db_debug.c M tests/db/Makefile.am 6 files changed, 126 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved neels: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index 6694f80..ef703f2 100644 --- a/configure.ac +++ b/configure.ac @@ -59,6 +59,21 @@ CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined" fi +AC_ARG_ENABLE([sqlite_talloc], + AC_HELP_STRING([--enable-sqlite-talloc], + [Configure SQLite3 to use talloc memory allocator [default=no]]), + [sqlite_talloc="$enableval"],[sqlite_talloc="no"]) +if test "x$sqlite_talloc" = "xyes" ; then + # Older versions of SQLite3 (at least 3.8.2) become unstable with talloc. + # Feel free to relax to 3.24.0 > VER > 3.8.2 if it works for you. + # FIXME: PKG_CHECK_MODULES() may return cached result here! + PKG_CHECK_MODULES(SQLITE3, sqlite3 >= 3.24.0) + AC_DEFINE([SQLITE_USE_TALLOC], 1, [Use talloc for SQLite3]) +fi +AC_MSG_CHECKING([whether to use talloc for SQLite3]) +AC_MSG_RESULT([$sqlite_talloc]) +AM_CONDITIONAL([DB_SQLITE_DEBUG], [test "x$sqlite_talloc" = "xyes"]) + AC_ARG_ENABLE(werror, [AS_HELP_STRING( [--enable-werror], diff --git a/src/Makefile.am b/src/Makefile.am index 131b44f..a042e4e 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -97,6 +97,11 @@ $(LIBOSMOGSM_LIBS) \ $(NULL) +if DB_SQLITE_DEBUG +osmo_hlr_SOURCES += db_debug.c +osmo_hlr_db_tool_SOURCES += db_debug.c +endif + BOOTSTRAP_SQL = $(top_srcdir)/sql/hlr.sql db_bootstrap.h: $(BOOTSTRAP_SQL) $(srcdir)/db_sql2c.sed diff --git a/src/db.c b/src/db.c index 7de61a2..5e6b5eb 100644 --- a/src/db.c +++ b/src/db.c @@ -365,6 +365,17 @@ LOGP(DDB, LOGL_INFO, "Compiled against SQLite3 lib version %s\n", SQLITE_VERSION); LOGP(DDB, LOGL_INFO, "Running with SQLite3 lib version %s\n", sqlite3_libversion()); +#ifdef SQLITE_USE_TALLOC + /* Configure SQLite3 to use talloc memory allocator */ + rc = db_sqlite3_use_talloc(ctx); + if (rc == SQLITE_OK) { + LOGP(DDB, LOGL_NOTICE, "SQLite3 is configured to use talloc\n"); + } else { + LOGP(DDB, LOGL_ERROR, "Failed to configure SQLite3 " + "to use talloc, using default memory allocator\n"); + } +#endif + dbc->fname = talloc_strdup(dbc, fname); for (i = 0; i < 0xfffff; i++) { diff --git a/src/db.h b/src/db.h index 6e4bf49..15d83de 100644 --- a/src/db.h +++ b/src/db.h @@ -39,6 +39,11 @@ sqlite3_stmt *stmt[_NUM_DB_STMT]; }; +/* Optional feature to make SQLite3 using talloc */ +#ifdef SQLITE_USE_TALLOC +int db_sqlite3_use_talloc(void *ctx); +#endif + void db_remove_reset(sqlite3_stmt *stmt); bool db_bind_text(sqlite3_stmt *stmt, const char *param_name, const char *text); bool db_bind_int(sqlite3_stmt *stmt, const char *param_name, int nr); diff --git a/src/db_debug.c b/src/db_debug.c new file mode 100644 index 0000000..13ccdd6 --- /dev/null +++ b/src/db_debug.c @@ -0,0 +1,86 @@ +/* + * libtalloc based memory allocator for SQLite3. + * + * (C) 2019 by Vadim Yanitskiy + * + * All Rights Reserved + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation; either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + */ + +#include +#include +#include + +/* Dedicated talloc context for SQLite */ +static void *db_sqlite_ctx = NULL; + +static void *tall_xMalloc(int size) +{ + return talloc_size(db_sqlite_ctx, size); +} + +static void tall_xFree(void *ptr) +{ + talloc_free(ptr); +} + +static void *tall_xRealloc(void *ptr, int size) +{ + return talloc_realloc_fn(db_sqlite_ctx, ptr, size); +} + +static int tall_xSize(void *ptr) +{ + return talloc_total_size(ptr); +} + +/* DUMMY: talloc doesn't round up the allocation size */ +static int tall_xRoundup(int size) { return size; } + +/* DUMMY: nothing to initialize */ +static int tall_xInit(void *data) { return 0; } + +/* DUMMY: nothing to deinitialize */ +static void tall_xShutdown(void *data) { } + +/* Interface between SQLite and talloc memory allocator */ +static const struct sqlite3_mem_methods tall_sqlite_if = { + /* Memory allocation function */ + .xMalloc = &tall_xMalloc, + /* Free a prior allocation */ + .xFree = &tall_xFree, + /* Resize an allocation */ + .xRealloc = &tall_xRealloc, + /* Return the size of an allocation */ + .xSize = &tall_xSize, + /* Round up request size to allocation size */ + .xRoundup = &tall_xRoundup, + /* Initialize the memory allocator */ + .xInit = &tall_xInit, + /* Deinitialize the memory allocator */ + .xShutdown = &tall_xShutdown, + /* Argument to xInit() and xShutdown() */ + .pAppData = NULL, +}; + +int db_sqlite3_use_talloc(void *ctx) +{ + if (db_sqlite_ctx != NULL) + return -EEXIST; + + db_sqlite_ctx = talloc_named_const(ctx, 0, "SQLite3"); + return sqlite3_config(SQLITE_CONFIG_MALLOC, &tall_sqlite_if); +} diff --git a/tests/db/Makefile.am b/tests/db/Makefile.am index fa925f8..5730937 100644 --- a/tests/db/Makefile.am +++ b/tests/db/Makefile.am @@ -36,6 +36,10 @@ $(SQLITE3_LIBS) \ $(NULL) +if DB_SQLITE_DEBUG +db_test_LDADD += $(top_builddir)/src/db_debug.o +endif + .PHONY: db_test.db update_exp manual manual-nonverbose manual-gdb db_test.db: rm -f db_test.db -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/14939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Icfe67ed0f063b63e6794f9516da3003d01cf20a7 Gerrit-Change-Number: 14939 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 17:17:16 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 17:17:16 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun In-Reply-To: References: Message-ID: Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14973 ) Change subject: vty/vty.c: fix vty_read(): prevent further heap-buffer overrun ...................................................................... vty/vty.c: fix vty_read(): prevent further heap-buffer overrun After reading data from the socket, assigned to a given VTY, we need to '\0'-terminate the received string. Otherwise, further access to that string, stored in a heap buffer vty->buf, would lead to a heap overrun. == How to reproduce? $ python -c "print 'A' * 512" | telnet $HOST $PORT ==21264==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6190000211e0 at pc 0x000000435d2f bp 0x7ffc06c7add0 sp 0x7ffc06c7a578 READ of size 1025 at 0x6190000211e0 thread T0 #0 0x435d2e in __interceptor_strlen (/usr/local/bin/osmo-msc+0x435d2e) #1 0x7fb95bfa5624 in talloc_strdup (/usr/lib/x86_64-linux-gnu/libtalloc.so.2+0x6624) #2 0x7fb95c1be2bc in vty_hist_add /opt/osmocom/libosmocore/src/vty/vty.c:578 #3 0x7fb95c1be2bc in vty_execute /opt/osmocom/libosmocore/src/vty/vty.c:703 #4 0x7fb95c1be2bc in vty_read /opt/osmocom/libosmocore/src/vty/vty.c:1425 #5 0x7fb95c1bfd78 in client_data /opt/osmocom/libosmocore/src/vty/telnet_interface.c:157 #6 0x7fb95b90bd33 in osmo_fd_disp_fds /opt/osmocom/libosmocore/src/select.c:223 #7 0x7fb95b90bd33 in osmo_select_main /opt/osmocom/libosmocore/src/select.c:263 #8 0x5006cc in main /opt/osmocom/osmo-msc/src/osmo-msc/msc_main.c:723:3 #9 0x7fb959935f44 in __libc_start_main /build/eglibc-xkFqqE/eglibc-2.19/csu/libc-start.c:287 #10 0x4226fb in _start (/usr/local/bin/osmo-msc+0x4226fb) == Why exactly 512? Because the initial size of the heap buffer is 512 (see VTY_BUFSIZ). Later on it can be realloc()ated, so X > 512 should also work. Found using AddressSanitizer and Radamsa [1] fuzzer. [1] https://gitlab.com/akihe/radamsa Change-Id: I82f774ad18d0e555eb8f3590a519946d9c583c78 --- M src/vty/vty.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/vty/vty.c b/src/vty/vty.c index 98b332d..b1bb3f4 100644 --- a/src/vty/vty.c +++ b/src/vty/vty.c @@ -1416,6 +1416,8 @@ case '\n': case '\r': vty_out(vty, "%s", VTY_NEWLINE); + /* '\0'-terminate the command buffer */ + vty->buf[vty->length] = '\0'; vty_execute(vty); break; case '\t': -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82f774ad18d0e555eb8f3590a519946d9c583c78 Gerrit-Change-Number: 14973 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 17:17:17 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 17:17:17 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly In-Reply-To: References: Message-ID: Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 ) Change subject: vty/vty.c: the command buffer can be accessed directly ...................................................................... vty/vty.c: the command buffer can be accessed directly Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39 --- M src/vty/vty.c 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/vty/vty.c b/src/vty/vty.c index b1bb3f4..a96d86c 100644 --- a/src/vty/vty.c +++ b/src/vty/vty.c @@ -136,7 +136,7 @@ } /* Authentication of vty */ -static void vty_auth(struct vty *vty, char *buf) +static void vty_auth(struct vty *vty) { char *passwd = NULL; enum node_type next_node = 0; @@ -170,10 +170,10 @@ if (passwd) { #ifdef VTY_CRYPT_PW if (host.encrypt) - fail = strcmp(crypt(buf, passwd), passwd); + fail = strcmp(crypt(vty->buf, passwd), passwd); else #endif - fail = strcmp(buf, passwd); + fail = strcmp(vty->buf, passwd); } else fail = 1; @@ -417,13 +417,13 @@ } /* Command execution over the vty interface. */ -static int vty_command(struct vty *vty, char *buf) +static int vty_command(struct vty *vty) { int ret; vector vline; /* Split readline string up into the vector */ - vline = cmd_make_strvec(buf); + vline = cmd_make_strvec(vty->buf); if (vline == NULL) return CMD_SUCCESS; @@ -689,10 +689,10 @@ switch (vty->node) { case AUTH_NODE: case AUTH_ENABLE_NODE: - vty_auth(vty, vty->buf); + vty_auth(vty); break; default: - ret = vty_command(vty, vty->buf); + ret = vty_command(vty); if (vty->type == VTY_TERM) vty_hist_add(vty); break; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39 Gerrit-Change-Number: 14975 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 17:17:16 2019 From: gerrit-no-reply at lists.osmocom.org (Vadim Yanitskiy) Date: Tue, 30 Jul 2019 17:17:16 +0000 Subject: Change in ...libosmocore[master]: vty/telnet_interface.c: log connection accept() / close() events In-Reply-To: References: Message-ID: Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 ) Change subject: vty/telnet_interface.c: log connection accept() / close() events ...................................................................... vty/telnet_interface.c: log connection accept() / close() events Unfortunately, osmo_sock_get_name_buf() fails in telnet_close_client(): DLGLOBAL INFO telnet_interface.c:130 Closing telnet connection because getsockname(), getpeername(), and even close() fail with: "Bad file descriptor". This looks like a bug of the existing code. Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c --- M src/vty/telnet_interface.c 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c index d44754c..9aa36fe 100644 --- a/src/vty/telnet_interface.c +++ b/src/vty/telnet_interface.c @@ -123,6 +123,13 @@ int telnet_close_client(struct osmo_fd *fd) { struct telnet_connection *conn = (struct telnet_connection*)fd->data; + char sock_name_buf[OSMO_SOCK_NAME_MAXLEN]; + int rc; + + /* FIXME: getsockname() always fails: "Bad file descriptor" */ + rc = osmo_sock_get_name_buf(sock_name_buf, OSMO_SOCK_NAME_MAXLEN, fd->fd); + LOGP(DLGLOBAL, LOGL_INFO, "Closing telnet connection %s\n", + (rc <= 0) ? "r=NULL<->l=NULL" : sock_name_buf); close(fd->fd); osmo_fd_unregister(fd); @@ -166,6 +173,7 @@ struct sockaddr_in sockaddr; socklen_t len = sizeof(sockaddr); int new_connection = accept(fd->fd, (struct sockaddr*)&sockaddr, &len); + char sock_name_buf[OSMO_SOCK_NAME_MAXLEN]; int rc; if (new_connection < 0) { @@ -173,6 +181,10 @@ return new_connection; } + rc = osmo_sock_get_name_buf(sock_name_buf, OSMO_SOCK_NAME_MAXLEN, new_connection); + LOGP(DLGLOBAL, LOGL_INFO, "Accept()ed new telnet connection %s\n", + (rc <= 0) ? "r=NULL<->l=NULL" : sock_name_buf); + connection = talloc_zero(tall_telnet_ctx, struct telnet_connection); connection->priv = fd->data; connection->fd.data = connection; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c Gerrit-Change-Number: 14972 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 17:30:30 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Tue, 30 Jul 2019 17:30:30 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 ) Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT ...................................................................... Patch Set 4: Code-Review+2 (3 comments) Love you too https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc at 257 PS2, Line 257: express that in centiBels > I hate you all so much! Done https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc at 319 PS2, Line 319: +-----------------+---------------------------------------+ > Right, thanks! Let's also mark it as reserved. Done https://gerrit.osmocom.org/#/c/14940/2/common/chapters/trx_if.adoc at 325 PS2, Line 325: used to decode the burst > This only applies to Access and Synchronization bursts, but not to Normal bursts. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 Gerrit-Change-Number: 14940 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 17:30:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: Vadim Yanitskiy Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 17:45:18 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 17:45:18 +0000 Subject: Change in ...osmo-sip-connector[master]: Prepare to support MO Call HOLD In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 ) Change subject: Prepare to support MO Call HOLD ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14995/3/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14995/3/src/sip.c at 491 PS3, Line 491: static void sip_retrieve_call(struct call_leg *_leg) > (this is mostly code dup from above, but ok) so, I could make one function sip_hold_retrieve_call() and pass a mode to it.. (There's quite a lot of code dup in general in osmo-sip-connector.) -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I2595626dfa50eb2f8e29a02540b708c9c1dce88c Gerrit-Change-Number: 14995 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 17:45:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 17:51:59 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 17:51:59 +0000 Subject: Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file() In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14993/2/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14993/2/src/sip.c at 389 PS2, Line 389: sdp = sdp_create_file(leg, other, sdp_sendrecv); > before, this would send no "a=sendrecv", now it always does. [?] I can see that you are concerned about a change that might break something downstream. In this case, i'm pretty sure that if it breaks something downstream then that thing was fairly badly broken already. I'm fairly sure that a=sendrecv is implicit it it's absence. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Tue, 30 Jul 2019 17:51:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 17:58:10 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 17:58:10 +0000 Subject: Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file() In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Patch Set 2: > (1 comment) just confirmed my Linksys/PAP2T is sending a=sendrecv by default with INVITE. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-CC: neels Gerrit-Comment-Date: Tue, 30 Jul 2019 17:58:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 18:02:12 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 18:02:12 +0000 Subject: Change in ...osmo-sip-connector[master]: Add support for MNCC HOLD/RETRIEVE In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 ) Change subject: Add support for MNCC HOLD/RETRIEVE ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14996/3/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/14996/3/src/mncc.c at 697 PS3, Line 697: "leg(%u) is req unhold.\n", leg->callref); > reason to call "retrieve" "unhold" all of a sudden? [?] My Nokia 6070 displays "Unhold" in the right hand bottom corner of the screen when the principal call is on hold. I guess that took over my brain.. + I was writing code for the compiler and comments for humans. I've never heard a human refer to "retrieve"-ing a call. We say. "I'll just put you on hold" "take the call off hold" etc.. :-) -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ife7bdab20cde92b7ce550215bab28b36a0f302e9 Gerrit-Change-Number: 14996 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-CC: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 18:02:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 18:09:49 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 18:09:49 +0000 Subject: Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14994/3/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14994/3/src/sip.c at 183 PS3, Line 183: // TODO: Tell osmo-bts to stop sending RTP ? > you mean tell osmo-msc to tell osmo-bsc to tell osmo-bts to stop sending rtp? is such in the specs? This is a good question. don't sigh.. but I was testing this against nitb, and it works. freeswitch has a "bypass_media_after_bridge" option which means it takes itself out of the media path after the call is answered. I have this working by sending further MNCC_RTP_CONNECT to nitb in response to the re-INVITES. so now I can take freeswitch in and out of the media path at will during the call. When it's out of the path, RTP flows only on lo in the BTS. I know this should be handled by osmo-mgw etc.. but it would be of use to me in the meantime. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed Gerrit-Change-Number: 14994 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 18:09:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 18:10:46 2019 From: gerrit-no-reply at lists.osmocom.org (keith) Date: Tue, 30 Jul 2019 18:10:46 +0000 Subject: Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs In-Reply-To: References: Message-ID: keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14994/3/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14994/3/src/sip.c at 183 PS3, Line 183: // TODO: Tell osmo-bts to stop sending RTP ? > This is a good question. don't sigh.. but I was testing this against nitb, and it works. [?] not quite the same thing as don't send RTP... I'll do further research on tihts. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed Gerrit-Change-Number: 14994 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 18:10:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Tue Jul 30 21:44:46 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Tue, 30 Jul 2019 21:44:46 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 ) Change subject: common: trx_if.adoc: Improve documentation ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc at 163 PS4, Line 163: 56-95: > where does this range come from? It's a filler for 1 entire row, since otherwise it'd be too long. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Tue, 30 Jul 2019 21:44:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Vadim Yanitskiy Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 08:13:52 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 08:13:52 +0000 Subject: Change in ...libosmocore[master]: avoid gcc format error on embedded builds Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15003 Change subject: avoid gcc format error on embedded builds ...................................................................... avoid gcc format error on embedded builds when using gcc 8.3.0 on Debian unstable and doing an embedded build, I'm getting the following error: > fsm.c:621:40: error: format '%ld' expects argument of type > 'long int', but argument 6 has type 'time_t {aka long long int}' > [-Werror=format=] Let's avoid that... Change-Id: I92fb9b08def8475739f0dc6316de43b166f48ac3 --- M src/fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/03/15003/1 diff --git a/src/fsm.c b/src/fsm.c index 337786d..c886351 100644 --- a/src/fsm.c +++ b/src/fsm.c @@ -620,7 +620,7 @@ else snprintf(trailer, sizeof(trailer), "(keeping " OSMO_T_FMT ", %ld.%03lds remaining)", OSMO_T_FMT_ARGS(fi->T), - remaining.tv_sec, remaining.tv_usec / 1000); + (long) remaining.tv_sec, remaining.tv_usec / 1000); } else if (timeout_ms) { if (timeout_ms % 1000 == 0) /* keep log output legacy compatible to avoid autotest failures */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I92fb9b08def8475739f0dc6316de43b166f48ac3 Gerrit-Change-Number: 15003 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 08:14:35 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 08:14:35 +0000 Subject: Change in ...libosmocore[master]: context: Add support for [per-thread] global talloc contexts In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13312 ) Change subject: context: Add support for [per-thread] global talloc contexts ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/13312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae39cd57274bf6753ecaf186f229e582b42662e3 Gerrit-Change-Number: 13312 Gerrit-PatchSet: 15 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-CC: Max Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 08:14:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 08:16:56 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 08:16:56 +0000 Subject: Change in ...libosmocore[master]: pseudotalloc: Simplistic wrapper of talloc_named() Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/15004 Change subject: pseudotalloc: Simplistic wrapper of talloc_named() ...................................................................... pseudotalloc: Simplistic wrapper of talloc_named() The pseudotalloc layer doesn't yet support talloc_named() API which will be used by the upcoming "context" change. Let's add this function to pseudotalloc.c for our arm-non-eabi builds. Change-Id: I4d91ebd73a3357a17ef9143a1b41b90186d4c128 --- M src/pseudotalloc/pseudotalloc.c M src/pseudotalloc/talloc.h 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/04/15004/1 diff --git a/src/pseudotalloc/pseudotalloc.c b/src/pseudotalloc/pseudotalloc.c index c368296..25425e5 100644 --- a/src/pseudotalloc/pseudotalloc.c +++ b/src/pseudotalloc/pseudotalloc.c @@ -46,6 +46,11 @@ return pseudotalloc_malloc(size); } +void *talloc_named(const void *context, size_t size, const char *fmt, ...) +{ + return pseudotalloc_malloc(size); +} + void talloc_set_name_const(const void *ptr, const char *name) { } diff --git a/src/pseudotalloc/talloc.h b/src/pseudotalloc/talloc.h index fe2efbc..d257a98 100644 --- a/src/pseudotalloc/talloc.h +++ b/src/pseudotalloc/talloc.h @@ -48,6 +48,7 @@ #define talloc(ctx, type) (type *)talloc_named_const(ctx, sizeof(type), #type) #define talloc_size(ctx, size) talloc_named_const(ctx, size, __location__) void *talloc_named_const(const void *context, size_t size, const char *name); +void *talloc_named(const void *context, size_t size, const char *fmt, ...); void talloc_set_name_const(const void *ptr, const char *name); char *talloc_strdup(const void *t, const char *p); void *talloc_pool(const void *context, size_t size); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15004 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4d91ebd73a3357a17ef9143a1b41b90186d4c128 Gerrit-Change-Number: 15004 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 09:50:42 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 31 Jul 2019 09:50:42 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 ) Change subject: common: trx_if.adoc: Improve documentation ...................................................................... Patch Set 5: Code-Review-1 (10 comments) https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc at 5 PS4, Line 5: The > s/The/the/ Done https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc at 162 PS4, Line 162: 48-55: TOA256 > ToA256 actually takes 2 octets. Done https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc at 184 PS4, Line 184: TOA256: 8 bits (1 byte):: > same here Done https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc at 208 PS4, Line 208: RSSI > It's called PWR. Done https://gerrit.osmocom.org/#/c/14938/4/common/chapters/trx_if.adoc at 226 PS4, Line 226: RSSI: 8 bits (1 byte):: : Received Signal Strength Indication in -dBm, encoded without the negative sign. > And AFAIR, it indicates Tx power attenuation wrt. the full scale. Done https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc at 10 PS5, Line 10: channel channels https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc at 15 PS5, Line 15: N X https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc at 16 PS5, Line 16: N X https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc at 163 PS5, Line 163: 64-95: ...Payload... What's the payload size here? In line 187 it says 148 bytes for GSM, 444 bytes for EDGE. Here it's 32... https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc at 209 PS5, Line 209: 48-95: ...Payload... See above comment It's 48 bytes here, below specifies 148 or 444 bytes again. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 09:50:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Vadim Yanitskiy Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 09:52:00 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 09:52:00 +0000 Subject: Change in ...libosmocore[master]: context: Add support for [per-thread] global talloc contexts In-Reply-To: References: Message-ID: Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/13312 to look at the new patch set (#17). Change subject: context: Add support for [per-thread] global talloc contexts ...................................................................... context: Add support for [per-thread] global talloc contexts Rather than having applications maintain their own talloc cotexts, let's offer some root talloc contexts in libosmocore. Let's also make them per thread right from the beginning. This will help some multi-threaded applications to use talloc in a thread-safe way. Change-Id: Iae39cd57274bf6753ecaf186f229e582b42662e3 --- M include/osmocom/core/select.h M include/osmocom/core/talloc.h M src/Makefile.am A src/context.c M src/select.c M tests/Makefile.am A tests/context/context_test.c A tests/context/context_test.ok M tests/testsuite.at 9 files changed, 214 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/12/13312/17 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/13312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae39cd57274bf6753ecaf186f229e582b42662e3 Gerrit-Change-Number: 13312 Gerrit-PatchSet: 17 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-CC: Max Gerrit-CC: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 10:11:28 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 10:11:28 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx: Don't increment rssi_valid_count twice Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15005 Change subject: osmo-bts-trx: Don't increment rssi_valid_count twice ...................................................................... osmo-bts-trx: Don't increment rssi_valid_count twice In the ms_power_val() function, don't increment the number of valid RSSI values counter twice. Change-Id: I19d9d933a69f7ad6252cbe51751d5db41790c698 --- M src/osmo-bts-trx/loops.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/05/15005/1 diff --git a/src/osmo-bts-trx/loops.c b/src/osmo-bts-trx/loops.c index c17f548..380bac5 100644 --- a/src/osmo-bts-trx/loops.c +++ b/src/osmo-bts-trx/loops.c @@ -109,7 +109,6 @@ if (chan_state->meas.rssi_valid_count == ARRAY_SIZE(chan_state->meas.rssi)) return; chan_state->meas.rssi[chan_state->meas.rssi_valid_count++] = rssi; - chan_state->meas.rssi_valid_count++; } /*! Process a single clock tick of the MS power control loop. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15005 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I19d9d933a69f7ad6252cbe51751d5db41790c698 Gerrit-Change-Number: 15005 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 10:11:29 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 10:11:29 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx: Don't attemtp to adjust MS power if fixed Message-ID: laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15006 Change subject: osmo-bts-trx: Don't attemtp to adjust MS power if fixed ...................................................................... osmo-bts-trx: Don't attemtp to adjust MS power if fixed If the BSC has instructed the BTS via RSL to not autonomously perform MS power control, we are storing this in lchan->ms_power_ctrl.fixed. However, osmo-bts-trx would simply ignore that flag in loops.c and continue to compute new MS power values based on measurement results. Change-Id: I628d1f4f1094c22248d372c11c2ecc504135b757 --- M src/osmo-bts-trx/loops.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/06/15006/1 diff --git a/src/osmo-bts-trx/loops.c b/src/osmo-bts-trx/loops.c index 380bac5..3fa2b3b 100644 --- a/src/osmo-bts-trx/loops.c +++ b/src/osmo-bts-trx/loops.c @@ -232,6 +232,9 @@ .lchan[l1sap_chan2ss(chan_nr)]; struct phy_instance *pinst = trx_phy_instance(l1t->trx); + if (lchan->ms_power_ctrl.fixed) + return; + if (pinst->phy_link->u.osmotrx.trx_ms_power_loop) ms_power_clock(lchan, chan_state); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15006 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I628d1f4f1094c22248d372c11c2ecc504135b757 Gerrit-Change-Number: 15006 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 10:42:11 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 31 Jul 2019 10:42:11 +0000 Subject: Change in ...libosmocore[master]: avoid gcc format error on embedded builds In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15003 ) Change subject: avoid gcc format error on embedded builds ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I92fb9b08def8475739f0dc6316de43b166f48ac3 Gerrit-Change-Number: 15003 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 10:42:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 10:43:25 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 31 Jul 2019 10:43:25 +0000 Subject: Change in ...libosmocore[master]: pseudotalloc: Simplistic wrapper of talloc_named() In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15004 ) Change subject: pseudotalloc: Simplistic wrapper of talloc_named() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15004 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4d91ebd73a3357a17ef9143a1b41b90186d4c128 Gerrit-Change-Number: 15004 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 10:43:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 10:48:12 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 10:48:12 +0000 Subject: Change in ...libosmocore[master]: vty/vty.c: the command buffer can be accessed directly In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14975 ) Change subject: vty/vty.c: the command buffer can be accessed directly ...................................................................... Patch Set 4: Code-Review+1 in the "old ui" gerrit will have red/green background under lines that are unmodified or only have whitespace changes. In the new UI it looks reasonable. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39 Gerrit-Change-Number: 14975 Gerrit-PatchSet: 4 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 10:48:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 10:48:36 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 10:48:36 +0000 Subject: Change in ...libosmocore[master]: avoid gcc format error on embedded builds In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15003 ) Change subject: avoid gcc format error on embedded builds ...................................................................... avoid gcc format error on embedded builds when using gcc 8.3.0 on Debian unstable and doing an embedded build, I'm getting the following error: > fsm.c:621:40: error: format '%ld' expects argument of type > 'long int', but argument 6 has type 'time_t {aka long long int}' > [-Werror=format=] Let's avoid that... Change-Id: I92fb9b08def8475739f0dc6316de43b166f48ac3 --- M src/fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/fsm.c b/src/fsm.c index 337786d..c886351 100644 --- a/src/fsm.c +++ b/src/fsm.c @@ -620,7 +620,7 @@ else snprintf(trailer, sizeof(trailer), "(keeping " OSMO_T_FMT ", %ld.%03lds remaining)", OSMO_T_FMT_ARGS(fi->T), - remaining.tv_sec, remaining.tv_usec / 1000); + (long) remaining.tv_sec, remaining.tv_usec / 1000); } else if (timeout_ms) { if (timeout_ms % 1000 == 0) /* keep log output legacy compatible to avoid autotest failures */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I92fb9b08def8475739f0dc6316de43b166f48ac3 Gerrit-Change-Number: 15003 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 10:48:37 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 10:48:37 +0000 Subject: Change in ...libosmocore[master]: pseudotalloc: Simplistic wrapper of talloc_named() In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15004 ) Change subject: pseudotalloc: Simplistic wrapper of talloc_named() ...................................................................... pseudotalloc: Simplistic wrapper of talloc_named() The pseudotalloc layer doesn't yet support talloc_named() API which will be used by the upcoming "context" change. Let's add this function to pseudotalloc.c for our arm-non-eabi builds. Change-Id: I4d91ebd73a3357a17ef9143a1b41b90186d4c128 --- M src/pseudotalloc/pseudotalloc.c M src/pseudotalloc/talloc.h 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/pseudotalloc/pseudotalloc.c b/src/pseudotalloc/pseudotalloc.c index c368296..25425e5 100644 --- a/src/pseudotalloc/pseudotalloc.c +++ b/src/pseudotalloc/pseudotalloc.c @@ -46,6 +46,11 @@ return pseudotalloc_malloc(size); } +void *talloc_named(const void *context, size_t size, const char *fmt, ...) +{ + return pseudotalloc_malloc(size); +} + void talloc_set_name_const(const void *ptr, const char *name) { } diff --git a/src/pseudotalloc/talloc.h b/src/pseudotalloc/talloc.h index fe2efbc..d257a98 100644 --- a/src/pseudotalloc/talloc.h +++ b/src/pseudotalloc/talloc.h @@ -48,6 +48,7 @@ #define talloc(ctx, type) (type *)talloc_named_const(ctx, sizeof(type), #type) #define talloc_size(ctx, size) talloc_named_const(ctx, size, __location__) void *talloc_named_const(const void *context, size_t size, const char *name); +void *talloc_named(const void *context, size_t size, const char *fmt, ...); void talloc_set_name_const(const void *ptr, const char *name); char *talloc_strdup(const void *t, const char *p); void *talloc_pool(const void *context, size_t size); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15004 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4d91ebd73a3357a17ef9143a1b41b90186d4c128 Gerrit-Change-Number: 15004 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 10:51:32 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 10:51:32 +0000 Subject: Change in ...osmo-sip-connector[master]: Add media mode parameter to sdp_create_file() In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 ) Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/14993/2/src/sdp.c File src/sdp.c: https://gerrit.osmocom.org/#/c/14993/2/src/sdp.c at 191 PS2, Line 191: mode_attribute = ""; > (I'm not sure why, but at least by convention) end each case in 'break;' [?] full ACK here to both comments. https://gerrit.osmocom.org/#/c/14993/2/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14993/2/src/sip.c at 389 PS2, Line 389: sdp = sdp_create_file(leg, other, sdp_sendrecv); > I can see that you are concerned about a change that might break something downstream. [?] I also agree that a=sendrecv is implicit if absent. But as neels states, it is a good idea to mention such a rather visible change in the commitlog. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-CC: neels Gerrit-Comment-Date: Wed, 31 Jul 2019 10:51:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 10:54:46 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 31 Jul 2019 10:54:46 +0000 Subject: Change in ...libosmocore[master]: context: Add support for [per-thread] global talloc contexts In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13312 ) Change subject: context: Add support for [per-thread] global talloc contexts ...................................................................... Patch Set 17: (2 comments) https://gerrit.osmocom.org/#/c/13312/17/src/context.c File src/context.c: https://gerrit.osmocom.org/#/c/13312/17/src/context.c at 36 PS17, Line 36: memset(osmo_ctx, 0, sizeof(*osmo_ctx)); This memset is not needed, can be removed. https://gerrit.osmocom.org/#/c/13312/17/src/select.c File src/select.c: https://gerrit.osmocom.org/#/c/13312/17/src/select.c at 277 PS17, Line 277: OSMO_ASSERT(0); osmo_panic? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/13312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae39cd57274bf6753ecaf186f229e582b42662e3 Gerrit-Change-Number: 13312 Gerrit-PatchSet: 17 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-CC: Max Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 10:54:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 10:56:24 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 10:56:24 +0000 Subject: Change in ...osmo-sip-connector[master]: Handle SIP re-INVITEs In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 ) Change subject: Handle SIP re-INVITEs ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/14994/3/src/sdp.c File src/sdp.c: https://gerrit.osmocom.org/#/c/14994/3/src/sdp.c at 35 PS3, Line 35: sdp_mode_t sdp_mode(const sip_t *sip) { an (at least) one line comment about what this function is doing) is customary. Also, in terms of naming "sip_get_sdp_mode()" or "sip_{retrieve,obtain,determine}_sdp_mode()" would be more readable. https://gerrit.osmocom.org/#/c/14994/3/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14994/3/src/sip.c at 183 PS3, Line 183: // TODO: Tell osmo-bts to stop sending RTP ? > not quite the same thing as don't send RTP... I'll do further research on tihts. well, the "correct" approach is probably to instruct the MSC-colocated MGW to put the SIP-side RTP connection in "recvonly" mode. If osmo-sip-connector was talking MGCP directly to the MGW (as suggested in some discussions) that would be easy. As it is not, we'd have to find a way to make that work via MNCC. For sure the BTS/BSC or BSC-colocated MGW shouldn't be involved in it. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I4083ed50d0cf1b302b80354fe0c2b73fc6e14fed Gerrit-Change-Number: 14994 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Wed, 31 Jul 2019 10:56:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith Comment-In-Reply-To: neels Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 10:56:26 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 31 Jul 2019 10:56:26 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx: Don't increment rssi_valid_count twice In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15005 ) Change subject: osmo-bts-trx: Don't increment rssi_valid_count twice ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15005 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I19d9d933a69f7ad6252cbe51751d5db41790c698 Gerrit-Change-Number: 15005 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 10:56:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 10:57:07 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 31 Jul 2019 10:57:07 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx: Don't attemtp to adjust MS power if fixed In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15006 ) Change subject: osmo-bts-trx: Don't attemtp to adjust MS power if fixed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15006 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I628d1f4f1094c22248d372c11c2ecc504135b757 Gerrit-Change-Number: 15006 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 10:57:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:00:17 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:00:17 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 ) Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 Gerrit-Change-Number: 14940 Gerrit-PatchSet: 4 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 11:00:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:12:12 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 31 Jul 2019 11:12:12 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 ) Change subject: common: trx_if.adoc: Improve documentation ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc at 163 PS5, Line 163: 64-95: ...Payload... > What's the payload size here? [?] Here it's 32 bits, enough to fill one entire row to showcase where data goes, because 187*8 or 444*8 would give a super big diagram. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 11:12:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:13:21 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 31 Jul 2019 11:13:21 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 ) Change subject: common: trx_if.adoc: Improve documentation ...................................................................... Patch Set 5: (4 comments) https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc at 10 PS5, Line 10: channel > channels Ack https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc at 15 PS5, Line 15: N > X Ack https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc at 16 PS5, Line 16: N > X Ack https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc at 209 PS5, Line 209: 48-95: ...Payload... > See above comment [?] That's 48 bits, not bytes. Explained in the above comment. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 11:13:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:13:43 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 31 Jul 2019 11:13:43 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation In-Reply-To: References: Message-ID: Hello Vadim Yanitskiy, daniel, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 to look at the new patch set (#6). Change subject: common: trx_if.adoc: Improve documentation ...................................................................... common: trx_if.adoc: Improve documentation Several fixes and improvements to the documentation. This documentation still doesn't contain infrmation about TRXDv1, it will be added in a follow-up commit. Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 --- M common/chapters/trx_if.adoc 1 file changed, 118 insertions(+), 44 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/38/14938/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:18:59 2019 From: gerrit-no-reply at lists.osmocom.org (dexter) Date: Wed, 31 Jul 2019 11:18:59 +0000 Subject: Change in ...osmo-bsc[master]: bsc_msc_data: remove unused member is_authenticated Message-ID: dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15007 Change subject: bsc_msc_data: remove unused member is_authenticated ...................................................................... bsc_msc_data: remove unused member is_authenticated The struct member struct bsc_msc_data->is_authenticated is set to true permanently. This is a leftover from the sccplite implementation and can be removed now. Change-Id: I966a48b383c85345c92c9a1fec791150e96cd7b9 Related: OS#3112 --- M include/osmocom/bsc/bsc_msc_data.h M src/osmo-bsc/gsm_08_08.c M src/osmo-bsc/osmo_bsc_msc.c 3 files changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/15007/1 diff --git a/include/osmocom/bsc/bsc_msc_data.h b/include/osmocom/bsc/bsc_msc_data.h index 2ad7c68..5612483 100644 --- a/include/osmocom/bsc/bsc_msc_data.h +++ b/include/osmocom/bsc/bsc_msc_data.h @@ -77,7 +77,6 @@ int core_lac; int core_ci; int rtp_base; - bool is_authenticated; /* audio codecs */ struct gsm48_multi_rate_conf amr_conf; diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c index 6ca5455..4dc4883 100644 --- a/src/osmo-bsc/gsm_08_08.c +++ b/src/osmo-bsc/gsm_08_08.c @@ -307,8 +307,6 @@ round_robin: llist_for_each_entry(msc, &bsc->mscs, entry) { - if (!msc->is_authenticated) - continue; if (!is_emerg && msc->type != MSC_CON_TYPE_NORMAL) continue; if (is_emerg && !msc->allow_emerg) diff --git a/src/osmo-bsc/osmo_bsc_msc.c b/src/osmo-bsc/osmo_bsc_msc.c index 7e78d94..24c8c6d 100644 --- a/src/osmo-bsc/osmo_bsc_msc.c +++ b/src/osmo-bsc/osmo_bsc_msc.c @@ -49,13 +49,6 @@ uint16_t mgw_port; int rc; - /* FIXME: This is a leftover from the old architecture that used - * sccp-lite with osmocom specific authentication. Since we now - * changed to AoIP the connected status and the authentication - * status is managed differently. However osmo_bsc_filter.c still - * needs the flags to be set to one. See also: OS#3112 */ - msc->is_authenticated = 1; - if (net->mgw.conf->remote_port >= 0) mgw_port = net->mgw.conf->remote_port; else -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15007 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I966a48b383c85345c92c9a1fec791150e96cd7b9 Gerrit-Change-Number: 15007 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:20:38 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 31 Jul 2019 11:20:38 +0000 Subject: Change in ...osmo-bsc[master]: bsc_msc_data: remove unused member is_authenticated In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15007 ) Change subject: bsc_msc_data: remove unused member is_authenticated ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15007 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I966a48b383c85345c92c9a1fec791150e96cd7b9 Gerrit-Change-Number: 15007 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 31 Jul 2019 11:20:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:23:10 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:23:10 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx: Don't increment rssi_valid_count twice In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15005 ) Change subject: osmo-bts-trx: Don't increment rssi_valid_count twice ...................................................................... osmo-bts-trx: Don't increment rssi_valid_count twice In the ms_power_val() function, don't increment the number of valid RSSI values counter twice. Change-Id: I19d9d933a69f7ad6252cbe51751d5db41790c698 --- M src/osmo-bts-trx/loops.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/osmo-bts-trx/loops.c b/src/osmo-bts-trx/loops.c index c17f548..380bac5 100644 --- a/src/osmo-bts-trx/loops.c +++ b/src/osmo-bts-trx/loops.c @@ -109,7 +109,6 @@ if (chan_state->meas.rssi_valid_count == ARRAY_SIZE(chan_state->meas.rssi)) return; chan_state->meas.rssi[chan_state->meas.rssi_valid_count++] = rssi; - chan_state->meas.rssi_valid_count++; } /*! Process a single clock tick of the MS power control loop. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15005 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I19d9d933a69f7ad6252cbe51751d5db41790c698 Gerrit-Change-Number: 15005 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:23:18 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:23:18 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx: Don't attemtp to adjust MS power if fixed In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15006 ) Change subject: osmo-bts-trx: Don't attemtp to adjust MS power if fixed ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15006 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I628d1f4f1094c22248d372c11c2ecc504135b757 Gerrit-Change-Number: 15006 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 11:23:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:23:19 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:23:19 +0000 Subject: Change in ...osmo-bts[master]: osmo-bts-trx: Don't attemtp to adjust MS power if fixed In-Reply-To: References: Message-ID: laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15006 ) Change subject: osmo-bts-trx: Don't attemtp to adjust MS power if fixed ...................................................................... osmo-bts-trx: Don't attemtp to adjust MS power if fixed If the BSC has instructed the BTS via RSL to not autonomously perform MS power control, we are storing this in lchan->ms_power_ctrl.fixed. However, osmo-bts-trx would simply ignore that flag in loops.c and continue to compute new MS power values based on measurement results. Change-Id: I628d1f4f1094c22248d372c11c2ecc504135b757 --- M src/osmo-bts-trx/loops.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bts-trx/loops.c b/src/osmo-bts-trx/loops.c index 380bac5..3fa2b3b 100644 --- a/src/osmo-bts-trx/loops.c +++ b/src/osmo-bts-trx/loops.c @@ -232,6 +232,9 @@ .lchan[l1sap_chan2ss(chan_nr)]; struct phy_instance *pinst = trx_phy_instance(l1t->trx); + if (lchan->ms_power_ctrl.fixed) + return; + if (pinst->phy_link->u.osmotrx.trx_ms_power_loop) ms_power_clock(lchan, chan_state); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15006 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I628d1f4f1094c22248d372c11c2ecc504135b757 Gerrit-Change-Number: 15006 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:23:42 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:23:42 +0000 Subject: Change in ...osmo-bsc[master]: bsc_msc_data: remove unused member is_authenticated In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15007 ) Change subject: bsc_msc_data: remove unused member is_authenticated ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15007 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I966a48b383c85345c92c9a1fec791150e96cd7b9 Gerrit-Change-Number: 15007 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 31 Jul 2019 11:23:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:24:12 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:24:12 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 ) Change subject: common: trx_if.adoc: Improve documentation ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 11:24:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:25:16 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:25:16 +0000 Subject: Change in ...osmo-trx[master]: radioInterface: Clarify how underruns are handled driving a radioDevice In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14987 ) Change subject: radioInterface: Clarify how underruns are handled driving a radioDevice ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14987 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id549489fc1485e0d762818c8e682aaddd5041f1c Gerrit-Change-Number: 14987 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 31 Jul 2019 11:25:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:25:33 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:25:33 +0000 Subject: Change in ...osmo-trx[master]: usrp1: don't check for non-null underrun pointer In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14988 ) Change subject: usrp1: don't check for non-null underrun pointer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14988 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I12e14641713a6494bc89570f02cecfc6f8fd4b5e Gerrit-Change-Number: 14988 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 31 Jul 2019 11:25:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:25:46 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:25:46 +0000 Subject: Change in ...osmo-trx[master]: jenkins.sh: Workaround libusrp build race conditon In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14990 ) Change subject: jenkins.sh: Workaround libusrp build race conditon ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I24bc54f5872e8edb9fab5b88055a00cebe1a6911 Gerrit-Change-Number: 14990 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 31 Jul 2019 11:25:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:26:46 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:26:46 +0000 Subject: Change in ...osmo-trx[master]: lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14989 ) Change subject: lms: Drop rx_underruns rate ctr, add tx_drop_* rate ctr ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iff1535c219a4695a511d383d7c4b06ef6eff959d Gerrit-Change-Number: 14989 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 31 Jul 2019 11:26:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:27:55 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:27:55 +0000 Subject: Change in ...osmo-trx[master]: Move inband-signaling-usb documentation to UserManual In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14998 ) Change subject: Move inband-signaling-usb documentation to UserManual ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14998/1/doc/manuals/chapters/device-usrp-inband-signaling-usb.adoc File doc/manuals/chapters/device-usrp-inband-signaling-usb.adoc: https://gerrit.osmocom.org/#/c/14998/1/doc/manuals/chapters/device-usrp-inband-signaling-usb.adoc at 2 PS1, Line 2: USRP it makes sense to state USRP1 everywhere here. It later became an entire family, and this documentation only applies to the std_inband.rbf file for USRP1. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4d6ef1f54f3d6c5a73ce00dc4640bd698f96842b Gerrit-Change-Number: 14998 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 31 Jul 2019 11:27:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:28:05 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:28:05 +0000 Subject: Change in ...osmo-trx[master]: Move matlab files under utils/matlab In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14999 ) Change subject: Move matlab files under utils/matlab ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14999 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I15b687fbf436d662b264cb00f72b367ccd64b962 Gerrit-Change-Number: 14999 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 31 Jul 2019 11:28:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:28:29 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:28:29 +0000 Subject: Change in ...osmo-trx[master]: Move Transceiver52/README to UserManual In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15000 ) Change subject: Move Transceiver52/README to UserManual ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15000 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib5a56cfe0c27d027bc0c60abda89e646a80849de Gerrit-Change-Number: 15000 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 31 Jul 2019 11:28:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:28:41 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:28:41 +0000 Subject: Change in ...osmo-trx[master]: Move README.DFEsymbolspaced to utils/matlab In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15001 ) Change subject: Move README.DFEsymbolspaced to utils/matlab ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Icccc18688ee54e669cf3452b08747b3509042fa2 Gerrit-Change-Number: 15001 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 31 Jul 2019 11:28:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 11:29:09 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 11:29:09 +0000 Subject: Change in ...osmo-trx[master]: Move std_inband.rbf under device/usrp1/ dir In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15002 ) Change subject: Move std_inband.rbf under device/usrp1/ dir ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ibb40ba487581e76d2ae3e8a420d631670f876cf0 Gerrit-Change-Number: 15002 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 31 Jul 2019 11:29:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 12:38:40 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 31 Jul 2019 12:38:40 +0000 Subject: Change in ...osmo-trx[master]: Move inband-signaling-usb documentation to UserManual In-Reply-To: References: Message-ID: Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14998 to look at the new patch set (#2). Change subject: Move inband-signaling-usb documentation to UserManual ...................................................................... Move inband-signaling-usb documentation to UserManual Change-Id: I4d6ef1f54f3d6c5a73ce00dc4640bd698f96842b --- D Transceiver52M/inband-signaling-usb A doc/manuals/chapters/device-usrp-inband-signaling-usb.adoc M doc/manuals/chapters/trx-devices.adoc 3 files changed, 305 insertions(+), 314 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/98/14998/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4d6ef1f54f3d6c5a73ce00dc4640bd698f96842b Gerrit-Change-Number: 14998 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 13:10:54 2019 From: gerrit-no-reply at lists.osmocom.org (daniel) Date: Wed, 31 Jul 2019 13:10:54 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation In-Reply-To: References: Message-ID: daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 ) Change subject: common: trx_if.adoc: Improve documentation ...................................................................... Patch Set 6: Code-Review+2 (2 comments) https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc at 163 PS5, Line 163: 64-95: ...Payload... > Here it's 32 bits, enough to fill one entire row to showcase where data goes, because 187*8 or 444*8 [?] Ah, sorry. With regards to the diagram this creates it makes sense! https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc at 209 PS5, Line 209: 48-95: ...Payload... > That's 48 bits, not bytes. Explained in the above comment. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 13:10:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: daniel Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 13:15:40 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 31 Jul 2019 13:15:40 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Improve documentation In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 ) Change subject: common: trx_if.adoc: Improve documentation ...................................................................... common: trx_if.adoc: Improve documentation Several fixes and improvements to the documentation. This documentation still doesn't contain infrmation about TRXDv1, it will be added in a follow-up commit. Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 --- M common/chapters/trx_if.adoc 1 file changed, 118 insertions(+), 44 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/common/chapters/trx_if.adoc b/common/chapters/trx_if.adoc index b684b7b..ecbaa7f 100644 --- a/common/chapters/trx_if.adoc +++ b/common/chapters/trx_if.adoc @@ -1,44 +1,53 @@ [[trx_if]] == TRX Manager UDP socket interface -This is the protocol used between `osmo-trx` and `osmo-bts-trx`. +This is the protocol used between `osmo-trx` (the transceiver) and +`osmo-bts-trx` (the BTS or core). -Each TRX Manager UDP socket interface represents a single ARFCN. Each of these -per-ARFCN interfaces is a pair of UDP sockets, one for control and one for data. -Given a base port B (5700), the master clock interface is at port P=B. The -TRX-side control interface for C(N) is on port P=B+2N+1 and the data interface -is on an odd numbered port P=B+2N+2. The corresponding core-side interface for -every socket is at P+100. For any given build, the number of ARFCN interfaces -can be fixed. +Each TRX Manager UDP socket interface represents a single transceiver (ARFCN). +Each of these channels is a pair of UDP sockets, one for control (`TRXC`) and +one for data (`TRXD`). Additionally, there's a separate global socket managing +the Master Clock Interface, shared among all channels. + +Given a base port `B` (5700), and a set of channels `0..N`, the ports related to +a channel `0 <= X <= N` are: +* The Master clock interface is located on port `P=B`. +* The `TRXC` interface for channel `X` is located on port `P=B+2X+1` +* The `TRXD` interface for channel `X` is located on port `P=B+2X+2`. + +The corresponding interface for every socket is at `P+100` on the BTS side. [[trx_if_clock_ind]] === Indications on the Master Clock Interface -The master clock interface is output only (from the radio). +The master clock interface is output only (uplink, from the radio to the BTS). Messages are "indications". -CLOCK gives the current value of the transceiver clock to be used by the core. -This message is sent whenever a trasmission packet arrives that is too late or -too early. The clock value is NOT the current transceiver time. It is a time -setting the the core should use to give better packet arrival times. +CLOCK gives the current value of the transceiver clock to be used by the BTS. +This message is usually sent around once per second (217 GSM frames), but can be +sent at any time. The clock value is NOT the current transceiver time. It is a +time setting that the BTS should use to give better packet arrival times. The +initial clock value is taken randomly, and then increased over time as the +transceiver submits downlink packets to the radio. ---- IND CLOCK ---- [[trx_if_control]] -=== Commands on the Per-ARFCN Control Interface +=== TRXC protocol -The per-ARFCN control interface uses a command-reponse protocol. Commands are -NULL-terminated ASCII strings, one per UDP socket. Each command has a -corresponding response. +The per-ARFCN control interface uses a command-response protocol. Each command +has a corresponding response. Commands are sent in downlink direction (BTS -> +TRX), and responses are sent in uplink direction (TRX -> BTS). Commands and +responses are NULL-terminated ASCII strings. -Every command is of the form: +Every command is structured this way: ---- CMD [params] ---- - The `` is the actual command. Parameters are optional depending on the commands type. + Every response is of the form: ---- RSP [result] @@ -46,7 +55,6 @@ The `` is 0 for success and a non-zero error code for failure. Successful responses may include results, depending on the command type. - ==== Power Control `POWEROFF` shuts off transmitter power and stops the demodulator. @@ -55,11 +63,11 @@ RSP POWEROFF ---- -`POWERON` starts the transmitter and starts the demodulator. Initial power +`POWERON` starts the transmitter and starts the demodulator. Initial power level is very low. This command fails if the transmitter and receiver are not yet tuned. This command fails if the transmit or receive frequency creates a conflict with another ARFCN that is already running. If the transceiver is -already on, it response with success to this command. +already on, it answers successfully to this command. ---- CMD POWERON RSP POWERON @@ -102,7 +110,7 @@ ==== Timeslot Control -`SETSLOT` sets the format of the uplink timeslots in the ARFCN. +`SETSLOT` sets the format of a given uplink timeslot in the ARFCN. The `` indicates the timeslot of interest. The `` indicates the type of channel that occupies the timeslot. A chantype of zero indicates the timeslot is off. @@ -111,48 +119,114 @@ RSP SETSLOT ---- -=== Messages on the per-ARFCN Data Interface +Here's the list of channel combinations and related values (``): + +.List of channel combinations and related values (``) +[options="header"] +|=== +| value | Channel Combination +|0| Channel is transmitted, but unused +|1| TCH/FS +|2| TCH/HS, idle every other slot +|3| TCH/HS +|4| Downlink: FCCH + SCH + CCCH + BCCH, Uplink: RACH +|5| Downlink: FCCH + SCH + CCCH + BCCH + SDCCH/4 + SACCH/4, Uplink: RACH+SDCCH/4 +|6| Downlink: CCCH+BCCH, Uplink: RACH +|7| SDCCH/8 + SACCH/8 +|8| TCH/F + FACCH/F + SACCH/M +|9| TCH/F + SACCH/M +|10| TCH/FD + SACCH/MD +|11| PBCCH+PCCCH+PDTCH+PACCH+PTCCH +|12| PCCCH+PDTCH+PACCH+PTCCH +|13| PDTCH+PACCH+PTCCH +|=== + +=== TRXD protocol Messages on the data interface carry one radio burst per UDP message. -==== Received Data Burst +==== Uplink Data Burst +.TRXD Uplink data burst message structure [packetdiag] ---- { colwidth = 32 node_height = 40 - 0: T - 1-4: FN - 5: A - 6-7: C - 8-155: Payload + 0-3: VER + 4: RES + 5-7: TN + 8-39: FN + 40-47: RSSI + 48-63: TOA256 + 64-95: ...Payload... + 96-97: PAD } ---- -* _T_: timeslot index -* _FN_: GSM frame number, big endian -* _A_: RSSI in -dBm -* _C_: correlator timing offset in 1/256 symbol steps, 2's-comp, big endian -* _Payload_: 148 bytes soft symbol estimates, 0 -> definite "0", 255 -> definite "1" +VER: 4 bits:: +TRXD header version, shall be 0. -==== Transmit Data Burst +TN: 3 bits:: +Timeslot number. +RES: 1 bit:: +Reserved, shall be 0. It can be used in the future to extend the TDMA TN range +to (0..15), in case anybody would need to transfer UMTS bursts. + +FN: 32 bits (4 bytes):: +GSM frame number, big endian. + +RSSI: 8 bits (1 byte):: +Received Signal Strength Indication in -dBm, encoded without the negative sign. + +TOA256: 16 bits (2 bytes):: +Timing of Arrival in units of 1/256 of symbol, big endian. + +Payload: 148 bytes for GSM, 444 bytes for EDGE:: +Contains the uplink burst. Soft symbol estimates, 0 -> definite "0", 255 -> +definite "1". + +PAD: 2 bits (optional):: +Padding at the end, historical reasons (OpenBTS inheritance). Bits can take any +value, but 0 is preferred. + +==== Downlink Data Burst + +.TRXD Downlink data burst message structure [packetdiag] ---- { colwidth = 32 node_height = 40 - 0: T - 1-4: FN - 5: A - 6-153: Payload + 0-3: VER + 4: RES + 5-7: TN + 8-39: FN + 40-47: PWR + 48-95: ...Payload... } ---- -* _T_: timeslot index -* _FN_ GSM frame number, big endian -* _A_: transmit level wrt ARFCN max, -dB (attenuation) -* _Payload_: 148 bytes output symbol values, 0 & 1 +VER: 4 bits:: +TRXD header version, shall be 0. + +TN: 3 bits:: +Timeslot number. + +RES: 1 bit:: +Reserved, shall be 0. It can be used in the future to extend the TDMA TN range +to (0..15), in case anybody would need to transfer UMTS bursts. + +FN: 32 bits (4 bytes):: +GSM frame number, big endian. + +PWR: 8 bits (1 byte):: +Contains the relative (to the full-scale amplitude) transmit power level in dB. +The absolute value is set on the control interface. + +Payload: 148 bytes for GSM, 444 bytes for EDGE:: +Contains the downlink burst. Each hard-bit (1 or 0) of the burst is represented +using one byte (0x01 or 0x00 respectively). -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 6 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 13:15:41 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 31 Jul 2019 13:15:41 +0000 Subject: Change in ...osmo-gsm-manuals[master]: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT In-Reply-To: References: Message-ID: pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 ) Change subject: common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT ...................................................................... common: trx_if.adoc: Add documentation about TRXDv1 and SETFORMAT Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 --- M common/chapters/trx_if.adoc 1 file changed, 140 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved laforge: Looks good to me, approved diff --git a/common/chapters/trx_if.adoc b/common/chapters/trx_if.adoc index ecbaa7f..6dd680b 100644 --- a/common/chapters/trx_if.adoc +++ b/common/chapters/trx_if.adoc @@ -141,20 +141,63 @@ |13| PDTCH+PACCH+PTCCH |=== +==== TRXD header version negotiation + +Messages on DATA interface may have different header formats, defined by a +version number, which can be negotiated on the control interface. By default, +the Transceiver will use the legacy header version (0). + +The header format negotiation can be initiated by the BTS using 'SETFORMAT' +command. If the requested version is not supported by the transceiver, status +code of the response message should indicate a preferred (basically, the latest) +version. The format of this message is the following: +---- +CMD SETFORMAT +RSP SETFORMAT +---- + +where: +* `` is the requested version (suggested by the BTS), +* `` is either the applied version if matches ``, or a + preferred version if `` is not supported. + +If the transceiver indicates `` different than ``, the BTS is +supposed to re-initiate the version negotiation using the suggested ``. +For example: + +---- + BTS -> TRX: CMD SETFORMAT 2 + BTS <- TRX: RSP SETFORMAT 1 2 + + BTS -> TRX: CMD SETFORMAT 1 + BTS <- TRX: RSP SETFORMAT 1 1 +---- + +If no suitable `` is found, or the `` is incorrect, the status +code in the response shall be `-1`. + +As soon as `` matches `` in the response, the process of +negotiation is complete. Changing the header version is supposed to be done +before `POWERON`, but can be also done afterwards. + === TRXD protocol Messages on the data interface carry one radio burst per UDP message. ==== Uplink Data Burst -.TRXD Uplink data burst message structure +Uplink data burst message structure differs from version 0 to 1. Basically, +version 1 contains an extended header with regards to version 0, and the final +padding existence is completely dropped. + +.TRXDv0 Uplink data burst message structure [packetdiag] ---- { colwidth = 32 node_height = 40 - 0-3: VER + 0-3: VER(0) 4: RES 5-7: TN 8-39: FN @@ -165,8 +208,27 @@ } ---- +.TRXDv1 Uplink data burst message structure +[packetdiag] +---- +{ + colwidth = 32 + node_height = 40 + + 0-3: VER(1) + 4: RES + 5-7: TN + 8-39: FN + 40-47: RSSI + 48-63: TOA256 + 64-71: MTS + 72-87: C/I + 88-127: ...Payload... +} +---- + VER: 4 bits:: -TRXD header version, shall be 0. +TRXD header version, v0 and v1 are specified so far. TN: 3 bits:: Timeslot number. @@ -184,13 +246,84 @@ TOA256: 16 bits (2 bytes):: Timing of Arrival in units of 1/256 of symbol, big endian. +MTS: 8 bits (1 byte):: +Contains the Modulation and Training Sequence information. See <> +for more information on the encoding. + +C/I: 16 bits (2 bytes):: +Contains the Carrier-to-Interference ratio in centiBels, big endian. The C/I +value is computed from the training sequence of each burst, where the "ideal" +training sequence is compared to the actual training sequence and the result +expressed in centiBels. + Payload: 148 bytes for GSM, 444 bytes for EDGE:: -Contains the uplink burst. Soft symbol estimates, 0 -> definite "0", 255 -> -definite "1". +Contains the uplink burst. Unlike the downlink bursts, the uplink bursts are +designated using the soft-bits notation, so the receiver can indicate its +assurance from 0 to -127 that a given bit is 1, and from 0 to +127 that a given +bit is 0. The Viterbi algorithm allows to approximate the original sequence of +hard-bits (1 or 0) using these values. Each soft-bit (-127..127) of the burst is +encoded as an unsigned value in range (0..255) respectively using the constant +shift. This way: +* 0 -> definite "0" +* 255 -> definite "1". PAD: 2 bits (optional):: Padding at the end, historical reasons (OpenBTS inheritance). Bits can take any -value, but 0 is preferred. +value, but 0 is preferred. Only expected on TRXDv0 headers. + +[[coding-mts]] +===== Coding of MTS: Modulation and Training Sequence info + +3GPP TS 45.002 version 15.1.0 defines several modulation types, and a few sets +of training sequences for each type. The most common are GMSK and 8-PSK (which +is used in EDGE). + +.MTS field structure +---- ++-----------------+---------------------------------------+ +| 7 6 5 4 3 2 1 0 | bit numbers (value range) | ++-----------------+---------------------------------------+ +| X . . . . . . . | IDLE / nope frame indication (0 or 1) | ++-----------------+---------------------------------------+ +| . X X X X . . . | Modulation, TS set number (see below) | ++-----------------+---------------------------------------+ +| . . . . . X X X | Training Sequence Code (0..7) | ++-----------------+---------------------------------------+ +---- + +IDLE / nope frame indication:: +The bit number 7 (MSB) is set to high when either nothing has been detected, or +during IDLE frames, so noise levels can be delivered, and avoid clock gaps on +the BTS side. Other bits are ignored, and should be set to low (`0`) in this +case. + +Modulation and TS set number:: +GMSK has 4 sets of training sequences (see tables 5.2.3a-d), while 8-PSK (see +tables 5.2.3f-g) and the others have 2 sets. Access and Synchronization bursts +also have several synchronization sequences. + +.Modulation and TS set number +---- ++-----------------+---------------------------------------+ +| 7 6 5 4 3 2 1 0 | bit numbers (value range) | ++-----------------+---------------------------------------+ +| . 0 0 X X . . . | GMSK, 4 TS sets (0..3) | ++-----------------+---------------------------------------+ +| . 0 1 0 X . . . | 8-PSK, 2 TS sets (0..1) | ++-----------------+---------------------------------------+ +| . 0 1 1 X . . . | AQPSK, 2 TS sets (0..1) | ++-----------------+---------------------------------------+ +| . 1 0 0 X . . . | 16QAM, 2 TS sets (0..1) | ++-----------------+---------------------------------------+ +| . 1 0 1 X . . . | 32QAM, 2 TS sets (0..1) | ++-----------------+---------------------------------------+ +| . 1 1 X X . . . | RESERVED (0) | ++-----------------+---------------------------------------+ +---- + +Training Sequence Code:: +The Training Sequence Code used to decode an Access or a Synchronization burst. +This field hence doesn't apply for Normal bursts. ==== Downlink Data Burst @@ -211,7 +344,7 @@ ---- VER: 4 bits:: -TRXD header version, shall be 0. +TRXD header version, v0 and v1 are specified so far. TN: 3 bits:: Timeslot number. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I320539fc9ffb7dd0f09ec18892299bd603cd7a85 Gerrit-Change-Number: 14940 Gerrit-PatchSet: 5 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 20:42:46 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 20:42:46 +0000 Subject: Change in ...osmo-trx[master]: Move inband-signaling-usb documentation to UserManual In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14998 ) Change subject: Move inband-signaling-usb documentation to UserManual ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/14998 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I4d6ef1f54f3d6c5a73ce00dc4640bd698f96842b Gerrit-Change-Number: 14998 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 31 Jul 2019 20:42:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 20:45:06 2019 From: gerrit-no-reply at lists.osmocom.org (laforge) Date: Wed, 31 Jul 2019 20:45:06 +0000 Subject: Change in ...libosmocore[master]: context: Add support for [per-thread] global talloc contexts In-Reply-To: References: Message-ID: laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13312 ) Change subject: context: Add support for [per-thread] global talloc contexts ...................................................................... Patch Set 17: (1 comment) https://gerrit.osmocom.org/#/c/13312/17/src/context.c File src/context.c: https://gerrit.osmocom.org/#/c/13312/17/src/context.c at 36 PS17, Line 36: memset(osmo_ctx, 0, sizeof(*osmo_ctx)); > This memset is not needed, can be removed. well, talloc_named is not talloc_zero. Sure, right now we just have two pointers that we overwrite two lines below, but I would still keep it on principle. As the function is only called once there's no performance issue either. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/13312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae39cd57274bf6753ecaf186f229e582b42662e3 Gerrit-Change-Number: 13312 Gerrit-PatchSet: 17 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-CC: Max Gerrit-CC: pespin Gerrit-Comment-Date: Wed, 31 Jul 2019 20:45:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: From gerrit-no-reply at lists.osmocom.org Wed Jul 31 22:37:18 2019 From: gerrit-no-reply at lists.osmocom.org (pespin) Date: Wed, 31 Jul 2019 22:37:18 +0000 Subject: Change in ...libosmocore[master]: context: Add support for [per-thread] global talloc contexts In-Reply-To: References: Message-ID: pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13312 ) Change subject: context: Add support for [per-thread] global talloc contexts ...................................................................... Patch Set 17: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/13312/17/src/context.c File src/context.c: https://gerrit.osmocom.org/#/c/13312/17/src/context.c at 36 PS17, Line 36: memset(osmo_ctx, 0, sizeof(*osmo_ctx)); > well, talloc_named is not talloc_zero. [?] Well I don't see how we'll end up adding more fields which are not set in this same place, so I don't really think it's ever going to be needed (and if at some point it's needed it can be added). But if you still think it makes sense then go ahead. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/13312 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iae39cd57274bf6753ecaf186f229e582b42662e3 Gerrit-Change-Number: 13312 Gerrit-PatchSet: 17 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-CC: Max Gerrit-Comment-Date: Wed, 31 Jul 2019 22:37:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Comment-In-Reply-To: laforge Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: