Change in osmo-mgw[master]: Auto-cleanup inactive connections

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Jan 30 16:33:02 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12730 )

Change subject: Auto-cleanup inactive connections
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

either add VTY config right here or follow up with a patch to add it. Also allow switching off the timer (to still make legacy behavior possible). Hence call it MGCP_CONN_DEFAULT_TIMEOUT from the start.

https://gerrit.osmocom.org/#/c/12730/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/12730/1//COMMIT_MSG@12
PS1, Line 12: arrive.
elaborate why it makes sense only for MDCX:
 
- CRCX creates the conn and timer
- DLCX deletes the conn and timer
- MDCX is the only remaining supported MGCP message that indicates a CI
- can't easily generically parse a CI for all MGCP messages, parsing is done in handle_modify_con().


https://gerrit.osmocom.org/#/c/12730/1/include/osmocom/mgcp/mgcp_internal.h
File include/osmocom/mgcp/mgcp_internal.h:

https://gerrit.osmocom.org/#/c/12730/1/include/osmocom/mgcp/mgcp_internal.h@41
PS1, Line 41: #define MGCP_CONN_TIMEOUT 180
MGCP_CONN_DEFAULT_TIMEOUT and make it configurable in VTY



-- 
To view, visit https://gerrit.osmocom.org/12730
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0
Gerrit-Change-Number: 12730
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 30 Jan 2019 16:33:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190130/1479552c/attachment.htm>


More information about the gerrit-log mailing list