Change in osmo-sip-connector[master]: Support International Caller ID

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Jan 29 12:38:43 UTC 2019


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12706 )

Change subject: Support International Caller ID
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.osmocom.org/#/c/12706/5/src/mncc.c
File src/mncc.c:

https://gerrit.osmocom.org/#/c/12706/5/src/mncc.c@795
PS5, Line 795: osmo_strlcpy
OSMO_STRLCPY_ARRAY(mncc.calling.number, call->source +1)


https://gerrit.osmocom.org/#/c/12706/5/src/mncc.c@798
PS5, Line 798: 		osmo_strlcpy(mncc.calling.number, call->source, sizeof(mncc.calling.number));
same here. avoids the sizeof, the macro takes care of it.



-- 
To view, visit https://gerrit.osmocom.org/12706
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcfa31aff90e04dd0aa3583957f288889b1bbefe
Gerrit-Change-Number: 12706
Gerrit-PatchSet: 5
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Tue, 29 Jan 2019 12:38:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190129/b1f2fe8a/attachment.htm>


More information about the gerrit-log mailing list