Change in osmo-sip-connector[master]: Support International Caller ID

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Jan 29 00:30:05 UTC 2019


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12706 )

Change subject: Support International Caller ID
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

I guess it's ok this way, but if you are a friend of C paranoia like I am:

https://gerrit.osmocom.org/#/c/12706/3/src/mncc.c
File src/mncc.c:

https://gerrit.osmocom.org/#/c/12706/3/src/mncc.c@783
PS3, Line 783: 	if (call->source[0] == '+') {
before this patch, osmo_strlcpy() made sure that we don't access a call->source == NULL.
If it is 110% sure that call->source is always a char * != NULL, this should add an

  OSMO_ASSERT(call->source);

above. Otherwise make it

  if (call->source && call->source[0] == '+') {

That way we are keeping an unchanged level of paranoia :)



-- 
To view, visit https://gerrit.osmocom.org/12706
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcfa31aff90e04dd0aa3583957f288889b1bbefe
Gerrit-Change-Number: 12706
Gerrit-PatchSet: 3
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Tue, 29 Jan 2019 00:30:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190129/a504cae1/attachment.htm>


More information about the gerrit-log mailing list