This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgMax has submitted this change and it was merged. ( https://gerrit.osmocom.org/12316 ) Change subject: ctrl: separate config structure ...................................................................... ctrl: separate config structure Moving configuration data from anonymous struct into shared header as a preparation for ctrl logging improvements in follow-up patches. Change-Id: I3520e14ca6e1b8e270dbd4b1bf2378fe486991ce Related: SYS#2655 --- M src/osysmon_ctrl.c M src/simple_ctrl.h 2 files changed, 11 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/osysmon_ctrl.c b/src/osysmon_ctrl.c index 4aa7a1d..c2d0725 100644 --- a/src/osysmon_ctrl.c +++ b/src/osysmon_ctrl.c @@ -38,14 +38,7 @@ struct ctrl_client { /* links to osysmon.ctrl_clients */ struct llist_head list; - struct { - /* name of this CTRL client */ - const char *name; - /* remote host/IP */ - const char *remote_host; - /* remote CTRL port */ - uint16_t remote_port; - } cfg; + struct ctrl_cfg cfg; struct simple_ctrl_handle *sch; /* list of ctrl_client_get_var objects */ struct llist_head get_vars; diff --git a/src/simple_ctrl.h b/src/simple_ctrl.h index 81a759d..f35eab1 100644 --- a/src/simple_ctrl.h +++ b/src/simple_ctrl.h @@ -2,6 +2,16 @@ #include <stdint.h> +/* a CTRL client config */ +struct ctrl_cfg { + /* name of this CTRL client */ + const char *name; + /* remote host/IP */ + const char *remote_host; + /* remote CTRL port */ + uint16_t remote_port; +}; + struct simple_ctrl_handle; struct simple_ctrl_handle *simple_ctrl_open(void *ctx, const char *host, uint16_t dport, -- To view, visit https://gerrit.osmocom.org/12316 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sysmon Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3520e14ca6e1b8e270dbd4b1bf2378fe486991ce Gerrit-Change-Number: 12316 Gerrit-PatchSet: 5 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-CC: Stefan Sperling <stsp at stsp.name> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190128/d542a7c1/attachment.htm>