Change in osmo-sysmon[master]: ctrl: log host/port on errors

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Mon Jan 28 15:21:56 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/12318 )

Change subject: ctrl: log host/port on errors
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/12318/4/src/simple_ctrl.c
File src/simple_ctrl.c:

https://gerrit.osmocom.org/#/c/12318/4/src/simple_ctrl.c@40
PS4, Line 40: #define CTRL_ERR(cfg, fmt, args...) fprintf(stderr, "CTRL %s:%u error: " fmt, cfg->remote_host, cfg->remote_port, ##args)
This line is longer than 120 characters, which is the max allowed length defined here: https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards


https://gerrit.osmocom.org/#/c/12318/4/src/simple_ctrl.c@103
PS4, Line 103: 	struct ctrl_cfg *cfg;
Pau asked in your other path:

> Do we really need a pointer allocated by talloc here? and an alloc function? just to have 2 strings and one int, all this seems overengineered to me.

https://gerrit.osmocom.org/#/c/osmo-sysmon/+/12316/2/src/osysmon_ctrl.c@41

Then you changed it to "struct ctrl_cfg cfg;".

So shouldn't it be the same here for consistency?



-- 
To view, visit https://gerrit.osmocom.org/12318
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sysmon
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I788d51359965a66c54075a3971aa7824c3bfb0bf
Gerrit-Change-Number: 12318
Gerrit-PatchSet: 5
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Stefan Sperling <stsp at stsp.name>
Gerrit-Comment-Date: Mon, 28 Jan 2019 15:21:56 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190128/e334a4b7/attachment.htm>


More information about the gerrit-log mailing list